4405 Commits (f705445f21efecde4eb1865b949b70fc7aae56d7)

Author SHA1 Message Date
faluco ec272061a0 Fix a dangling SDU pointer in mac_sch_subpdu_nr when adding subpdus into a mac_sch_pdu_nr. 3 years ago
faluco 934802d23c Report the SIB9 home enb name in the enb sector start/sector stop events. 3 years ago
faluco 2fd3ed789a Rename sector_id to carrier_id JSON key in enb metrics and events. 3 years ago
faluco d122d0c69b Add new field for the PCI in the enb JSON report file. 3 years ago
faluco d168536bc4 Add a new program option to control how ASN1 messages get printed into the enb JSON report file. 3 years ago
faluco df6ae7b0e0 - Implement new enb events:
* ho_command
* connection_resume
* rlf_detected
- Rename rlf_report event to "rlf_report".
3 years ago
faluco 8a3586dfbf Include a ASN1 json representation for RRC enb events. 3 years ago
David Rupprecht a9a23214b0 Added more 5G security kdfs
Added new 5G SIM functions

Added const parameters for security functions
3 years ago
David Rupprecht a645d74eaf USIM functions for res star
Added gen_res_star in security.h

Added USIM interfaces for res star

Added RES star test case
3 years ago
David Rupprecht bce6b5cc0f Added kdf common
Use kdf functions in 5G KDF

Moved EPS KDF function to new KDF structure
3 years ago
David Rupprecht 15eaef21e2 Update test f12345 function
Moved XOR functions to lib

Added testcase for KDF

Minor liblte_security updates
3 years ago
David Rupprecht 0ef8976d53 Remove length from class and pass by reference 3 years ago
Andre Puschmann 88bb92dc0d mac_nr,sched: handle C-RNTI CE 3 years ago
Andre Puschmann f3e8847ad3 mac_pdu_nr_test: fix test 3 years ago
Andre Puschmann 82e9652a92 mac_sch_pdu_nr: fix ASAN/fmt issue when print space 3 years ago
Andre Puschmann ea48a350a4 mac_rar_pdu_nr: fix clearing of padding bytes 3 years ago
Andre Puschmann 02bd15878e mac_sch_pdu_nr: fix logging 3 years ago
Andre Puschmann ede81be5e4 mac_rar_pdu_nr: add packing routines
* add packing for RAR PDUs
* rewrite to_string() to use fmt lib
* add test case for packer
3 years ago
Andre Puschmann 20c0e0bc41 mac_sch_pdu_nr: add to_string() helper to format MAC PDUs in logs 3 years ago
Francisco Paisana 227ae97bcb workaround gcc4.8 issue with inability to derive move ctor noexcept specifier 3 years ago
Francisco Paisana ebd12b0778 stack lte,refactor: pass bearer manager instead of stack pointer to srsenb::rrc 3 years ago
Francisco Paisana f4df55c245 stack lte: separate bearer manager into two classes, one for the ue and one for the enb 3 years ago
Francisco Paisana 2ade4628ca stack lte: create an gtpu-pdcp adapter class that correctly converts lcids to eps bearers and vice-versa 3 years ago
Francisco Paisana 4b2f079581 gtpu: renamed lcid to eps_bearer_id as parte of the refactor of gtpu to use eps_bearer_ids 3 years ago
Andre Puschmann 3949a727a7 enb_interface: add stack interface for RRC
RRC uses the interface to register/deregister EPS bearer
3 years ago
Andre Puschmann db8b710442 bearer_manager: move to lib folder and extend for multiple users
prepare bearer manager to be used by eNB which requires
to support multiple RNTIs
3 years ago
Francisco Paisana 020bec025e sched: created class common to LTE and NR for ue buffer status management 3 years ago
Xavier Arteaga 9e1669c403 Better comments in minimum size symbol selection 3 years ago
Xavier Arteaga 4858202bf6 Fix NR symbol size for 270RB 3 years ago
Xavier Arteaga 14a85d31ec Fix symbol size simensioning for LTE standard rate 3 years ago
Xavier Arteaga 01390a7340 Better NR softbuffer size adjustment 3 years ago
Andre Puschmann 9bf74843f6 mac_pdu_nr: add error handling to init_tx() method
check provided byte_buffer and return error if it's not valid
3 years ago
Francisco Paisana 04e5c81edf sched,nr: nr_phy_test now uses the whole mac class rather than just the scheduler 3 years ago
Francisco Paisana b486d2a1b5 sched,nr: implement prb grant fmt formatting 3 years ago
Francisco Paisana da4b7e4f80 sched,nr: fix sched RAR NR test; update test assert macros 3 years ago
Xavier Arteaga 83b9b2d1ff Implemented UE open loop CFO compensation for NR 3 years ago
Xavier Arteaga 5aa2279990 Fix NZP-CSI-RS CFO sign 3 years ago
Xavier Arteaga 7da2d20447 Added UE UL NR frequency offset option 3 years ago
Xavier Arteaga cfe2b305a1 Fix CORESET0 related PDSCH resource allocation procedure 3 years ago
Xavier Arteaga 36207db615 Added CORESET start_rb helper function 3 years ago
Xavier Arteaga 89ef3b64b4 Optimization NR PDCCH mapping minor optimization 3 years ago
Xavier Arteaga ae0d8f83f0 Add PDCCH interleaved mapping in phy_dl_nr_test and iterate all possible 15kHz SCS bandwidths 3 years ago
Xavier Arteaga 9c3dd56398 Added PDCCH DMRS interleaved mapping 3 years ago
Xavier Arteaga f5f18054eb Added PDCCH NR interleaved mapping 3 years ago
Xavier Arteaga d61d6aa59f Integrated CORESET0 into UE's RRC 3 years ago
Xavier Arteaga e07263ee26 Added band helper for getting band from ARFCN 3 years ago
Xavier Arteaga 7377496417 Added SCS to string and corrected coreset0 3 years ago
Xavier Arteaga 62ba7d386d Initial CORESET Zero constructor 3 years ago
Xavier Arteaga 5d149a4b78 Moved NR time/frequency allocation SLIV to new component 3 years ago
Francisco Paisana 36eee0ab40 test,nr: add ra_search_space configuration to phy_cfg_nr; now the test ue searches for RA-RNTI while expecting a RAR 3 years ago
Francisco Paisana 2668a8f68b sched,nr: fix Msg3 decoding in PHY to not expect any UCI 3 years ago
Xavier Arteaga 2cd5e98132 Fix NULL check in DCI NR for RAR type 3 years ago
Xavier Arteaga 3784359da5 Use NR DCI format 0_0 packing and unpacking for TC-RNTI type 3 years ago
Xavier Arteaga b846116c5c Added NR RAR UL DCI packing 3 years ago
Francisco Paisana 55d83a1279 fix compilation issue due to wrong include path for srsran_assert.h file 3 years ago
Francisco Paisana f518861ebc fix location of support/ folder. Created macros for ASSERT_EQ and ASSERT_NEQ 3 years ago
Francisco Paisana 599fc978a5 improvement of srsran_assert design, with specializations to enable/disable assertions based on compile flags other than ASSERTS_ENABLED. Creation of the support/ folder 3 years ago
Francisco Paisana e896ac49e8 adt: create split optional span view to be used for C-array types 3 years ago
Francisco Paisana d616e46936 adt: allow choice between static and dynamic optional vector types 3 years ago
Francisco Paisana 1596fcf349 adt: rename optional table to optional array 3 years ago
Francisco Paisana 8c24cfebd3 adt: create data structure type to represent an array of optional fields 3 years ago
Francisco Paisana eb4999a18e lte,pdcp: silence error message when a reconfiguration of a PDCP entity is no-op 3 years ago
Andre Puschmann 32ab1baeb1 enb,rrc: during NSA activation, remove EUTRA DRB and set MAC logical channel config 3 years ago
Andre Puschmann 9e7852ac83 srsran_asn1_nr: add RLC config to packing test 3 years ago
Andre Puschmann 1c3a03cb2b rlc: fix memleak in queue_rx_pdu
* alternative to #3141
* use byte_buffer as queue element
3 years ago
Andre Puschmann c365c16531 gnb_interfaces: inherit from EUTRA interfaces when they are identical 3 years ago
Andre Puschmann 4076338a1b enb: add MAC-NR PCAP
* use fixed filename until eNB stack layout is decided
3 years ago
Andre Puschmann c03623863b enb,nsa: fix UL PDU processing
* remove const from pusch_info() MAC/PHY interface to allow moving unique byte buffer
3 years ago
Andre Puschmann fc35c0ee51 enb,nsa: fix packing of DL MAC PDUs
* use byte_buffer_t as interface type for DL PHY-MAC interface
* fix missing clear() for new DL tx
3 years ago
Andre Puschmann 4a828be39f rlc_am_test: fix reestablishment test
after changing the retx counting we receive one SDU more than before
3 years ago
Andre Puschmann 7726acad41 rlc_am_lte: fix counting of retx of entire PDUs and PDU segments
this patch fixes a bug discovered in a real network where the DL CQI of a
user degraded repidly in very short time. A relativly big RLC PDU that
was still sent with the good CQI in a big grant now needs to be split
across many tiny segments because the CQI degraded so much.

The retx couting for each transmitted segment caused the retx counter to
reach maxRetx quickly.

With this patch we do not increment the retx counter for each transmitted
PDU or segment of a PDU but instead only increment the counter when
a given SN is added to the retx queue. This can happen either:
a) if the SN is negativly acknowledged and was not already on the retx queue,
b) no new data is available for tx and a SN is selected for retx.

This is in accordance with TS 36.322 which handles retx counting in section
5.2.1 according to the above description.
3 years ago
Xavier Arteaga cba6df3722 Extended NR PHY robustnes against wrong RRC configuration 3 years ago
Xavier Arteaga de89e829e7 Added NR PUCCH Resource ASN1 helper 3 years ago
Xavier Arteaga 3ae131b336 gNb creates PUSCH decode PDU 3 years ago
Xavier Arteaga 98f29961bc Fix old GCC compilation 3 years ago
Xavier Arteaga 856573b92f Added 4096 symbol size as LTE rate 3 years ago
Xavier Arteaga 54e1fe172c Minor NR PHY aesthetical modifications 3 years ago
Xavier Arteaga 956c4f8266 Added PHY NR test TDD FR1.15-1 pattern 3 years ago
Xavier Arteaga dfa323df6b Added 20MHz default configuration 3 years ago
Xavier Arteaga ea802c23f2 Remove PHY lib verbose from test and use byte vector random function 3 years ago
Xavier Arteaga 1b50758bd5 Initial NZP-CSI default configuration from TS38.101-4 3 years ago
Andre Puschmann 28668aac34 ue,proc_ra_nr: add temporary flag to skip RAR reception
this will be removed again as soon as the eNB supports full RAR
transmission.
3 years ago
Andre Puschmann 3b5344b0f7 thread_pool: add optional ID to thread pool
this allows to prepend an ID to each thread pool to
better differentiate workers from different pools
3 years ago
Andre Puschmann 38f1e158a5 enb,nr: fix NR PHY PRACH init and MAC-PHY interaction 3 years ago
Xavier Arteaga a300a47673 Fix value selector for NEON 3 years ago
Xavier Arteaga 42b052112f Added TS reference and use SRSRAN_CEI_LOG2 macro 3 years ago
Xavier Arteaga 1f495cb008 Added generic SRSRAN_CEIL_LOG2 3 years ago
Andre Puschmann b6f8280f67 cqi: protect potential div by zero bug 3 years ago
Andre Puschmann b388930325 srsran_asn1_rrc_nr_test: disable PCAP output by default 3 years ago
David Rupprecht 11f9ac75db Added PLMN to serving network string name 3 years ago
Xavier Arteaga 085e247ece Fix ZMQ TX channel mapping for NULL pointers
Fix ZMQ transmit frequency mapping

Use map mask in ZMQ to determine mapped channels

Fix ZMQ mapping
3 years ago
Xavier Arteaga 562fd1b4d4 Fix segfault 3 years ago
Xavier Arteaga dbb10dd6a2 Hold worker thread until baseband is transmitted 3 years ago
Xavier Arteaga 0c7239e5df SRSUE: add RF channel offset 3 years ago
Xavier Arteaga b57df4db10 Refactored worker_end mechanism for concurrent workers 3 years ago
Andre Puschmann e833751031 rrc_nr: add CSI config packing 3 years ago
Andre Puschmann f181733c7e rrc_nr,enb: add more fields to spcell cfg dedicated 3 years ago
Andre Puschmann 4915dc9642 test_pcap: add function description 3 years ago
Francisco Paisana bd08a64b5e sched: fix crash for 100 prbs and subband CQI reporting 3 years ago
Andre Puschmann 45c1971249 mac,phy,interface: clean up and add NR interface to LTE stack
* remove obsolte rx_data_ind
* add mac_phy_interface_nr to LTE stack
3 years ago
David Rupprecht 04ef6e120d Added new SIM functions to get MCC, MNC and MSIN 3 years ago
Bedran Karakoc a6226379b4 Introducing NGAP UE context procedures 3 years ago
Ismael Gomez a896e32cf4 Refactor sub-band CQI processing 3 years ago
Ismael Gomez 9b10e1c45d Fix sub-band CQI in UE. Refactor variable names 3 years ago
Francisco Paisana 12e33483e1 sched,nr: add slot_point to sched nr 3 years ago
Francisco Paisana a0a1af9d0f nr: slot value that handles wrapping around 3 years ago
Andre Puschmann a7eb9b471b pssch_file_test: relax test result check
the file test sometimes decodes 2 and sometimes 3 (less often) SCI.
its not entirly clear why it's different though.

this "fixes" #3088
3 years ago
Xavier Arteaga ca5ea369f5 Extended ue_dl_nr_file test 3 years ago
Xavier Arteaga 914a2e2d31 Add SCH NR softbuffer check 3 years ago
Xavier Arteaga b59c330858 Fix filesource include 3 years ago
Xavier Arteaga 858fc2c0fc Cleanup include 3 years ago
Xavier Arteaga 5a6b8f42f5 Add standard rate check for FFT minimum size function 3 years ago
Xavier Arteaga 98929c95a8 Initial UE DL NR file test 3 years ago
Xavier Arteaga dcf9ae039c Fix related Sidekiq comments and mutex 3 years ago
Xavier Arteaga b3d9a94dd5 SIDEKIQ: fix tx time protection 3 years ago
Xavier Arteaga ecf668ee9e SIDEKIQ: fix comment 3 years ago
Xavier Arteaga 96ee4b7258 SIDEKIQ: Initial implementation
SIDEKIQ: Add SKIQ_FOUND to RF found condition

SIDEKIQ: finished SKIQ component abstraction

SIDEKIQ: fix issues and added external PPS example

SIDEKIQ: add PPS test card index argument

SIDEKIQ: improvements

SIDEKIQ: improved srate change

SIDEKIQ: more improvements

SIDEKIQ: more fixes

SIDEKIQ: fix Rx ch gain

SIDEKIQ: Fix multi-card synchronism

SIDEKIQ: Better Rx gain tracking
3 years ago
Robert Falkenberg 24e52d6291 soapy: fix array parameter mismatch for some functions
With soapy 0.8.0, GCC 11.1.0 warns of mismatched array bounds
in some functions.
This commit aligns the bound and adds proper wrappers to
fix subsequent warnings.
3 years ago
Francisco Paisana bc5a548fe8 sched: scheduler now accounts for prachs with different durations 3 years ago
Xavier Arteaga bb4f469794 Integrated SR decoder in gNb 3 years ago
Xavier Arteaga 6a9baef11d Limit DMRS PUCCH SNR to void NAN/INF 3 years ago
Xavier Arteaga d783fbf3a0 Reviewed NR procedure for PUCCH resource sselection and reviewed gNb PUCCH interface 3 years ago
Xavier Arteaga 64f4767c4f Fix NR PUCCH decoder memory access 3 years ago
Andre Puschmann 60a795acc0 asn1,rrc_nr,test: extend RRC reconf test, add PCAP output
test now can write the NR reconfig into a PCAP for easy
debugging with Wireshark

patch also adds a new test helper to write a RRC PDU
into a PCAP file (helper packs PDCP and RLC AM first)
3 years ago
Andre Puschmann c9c3a68fae asn1,rrc_nr: add error code handling to packing/unpacking of pdcch_cfg 3 years ago
Ismael Gomez 6fb9b6bf94 Fix sub-band CQI in UE. Refactor variable names 3 years ago
Francisco Paisana 74d0a8adb8 sched: add subband cqi info interface to LTE scheduler 3 years ago
Ismael Gomez 2e1127f385 Add sub-band CQI periodicity and configuration to lib 3 years ago
Ismael Gomez 3f5094f30e Remove confusing subband_size variable and replace with subband_wideband_ratio 3 years ago
Andre Puschmann a142192d4e test_common: handle return value from make_byte_buffer() 3 years ago
Andre Puschmann 8d2e81ad6f enb,mac,nr: add basic UE object skeleton
refactor that also adds a basic UE object to the NR MAC
3 years ago
David Rupprecht 0217bf5332 Fixed name space for rrc ue 3 years ago
Francisco Paisana 09c7000201 sched,nr: update nr scheduler to use new mac nr interface types 3 years ago
Francisco Paisana d9336bcd9e sched,nr: creation of pool of softbuffers for NR. Now the sched NR harq manages the lifetime of the softbuffer and its forwarding to the PHY 3 years ago
Francisco Paisana 1535e6b205 sched,nr: extend sched nr testing suite. restrict paralllelization for correct DAI generation 3 years ago
faluco b79481f74b - Fix text formatter unit test for printing the date. 3 years ago
Francisco 357bc10a17 feature - make minimum SNR, under which the RRC is notified with UL KO, configurable 3 years ago
faluco 8708043a5f - Add date to log timestamps.
- Print once per second the current timestamp into stdout, feature guarded by a config expert option.
3 years ago
Francisco 67325ab5c1 add pdcch_cqi_offset parameter to enb.conf 3 years ago
Francisco 2a31daca4a enb,configuration: allow to specify enb specific max nof RLC retxs 3 years ago
Andre Puschmann b5b2f8190e signal_handler: use std::atomic for running var 3 years ago
Andre Puschmann ff5fe5df14 rf_uhd_imp: fix race in RF metrics 3 years ago
Pedro Alvarez 8d41c0d476 Maded SRB configuration optional in rb.conf 3 years ago
David Rupprecht d990db66f6 Added syslog logger 3 years ago
faluco 7b7ecb7983 Add a new configuration option that controls PDSCH baseband sample dump to a file on KO. 3 years ago
Xavier Arteaga b25681f9de gnb,prach: add PRACH to gNB
rebase of Xavier's feature_gnb_prach branch
3 years ago
David Rupprecht fb92118bb7 Add 5G NAS infrastructure 3 years ago
David Rupprecht e0b09f1301 Fixed coverity findings 3 years ago
David Rupprecht 709b706d07 Fix 5G NAS extended protocol discriminator 3 years ago
Andre Puschmann 6c82d63aa6 remove legacy PNF/VNF code
the code hasn't been maintained for a while an likely needs to be
adapted for a real-world scenarios.

in order to avoid having to maintain two MAC/PHY interfaces we
remove the code from now.
3 years ago
Xavier Arteaga 54a12870ec SRSUE: avoid negative SR transmission in NR 3 years ago
Xavier Arteaga 603c67e36d Set g_ulsch LLR overlaped with g_harq_ack to zero 3 years ago
Xavier Arteaga 3416aad16d Fix PUSCH NR test false alarm 3 years ago
Xavier Arteaga 04aca98e5f Added more checks in PUSCH NR test 3 years ago
Xavier Arteaga ef865b81a3 NR SCH TB information prints actual rate and not the target rate 3 years ago
Xavier Arteaga 11a52248cd RA NR Calculates actual PUSCH rate 3 years ago
Xavier Arteaga 35840d6bc1 Removed all zero condition from LDPC decoding 3 years ago
Xavier Arteaga 64b7dfed65 UHD: fix nullptr buffer 3 years ago
Xavier Arteaga ecc0b92142 Integrated PUSCH decoder in gNb 3 years ago
Xavier Arteaga f07d925be1 Initial NR PHY test scheduling for PUSCH 3 years ago
Andre Puschmann 654afac9c7 nas_5g_msg_test: remove copy_msg_to_buffer() that is now in test_common.h 3 years ago
David Rupprecht 724af2b060 Added nas 5g msg packing and unpacking 3 years ago
Andre Puschmann e330f50ef8 rrc_meas_test: add packing test for measObjectNR 3 years ago
Andre Puschmann a2dd83a7e9 asn1: rename RRC NR test to avoid confusion with component test 3 years ago
Andre Puschmann fd7b9a0575 enb,nsa: add basic RRC EUTRA<>RRC NR interface for SgNB addition 3 years ago
Andre Puschmann 6bf3feda92 rrc_nr_test: add packing test for NR radio bearer config
also add (still incomplete) secondary cell group config pack test
3 years ago
Andre Puschmann c9e87b2cf3 config_file: print message when config file couldn't be read
this prints an message on stdout so config files are not
simply skipped and the default one is read instead.
3 years ago
Andre Puschmann fa461f0129 rrc_nr: fix linker error in setup_release_c
move implementation to cc file to avoid

[build] /bin/ld: CMakeFiles/rrc_nr_asn1_test.dir/rrc_nr_test.cc.o: in function `asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::set_setup()':
[build] /home/anpu/src/srsLTE/lib/include/srsran/asn1/rrc_nr.h:2276: undefined reference to `asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::set(asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::types_opts::options)'
[build] clang: error: linker command failed with exit code 1 (use -v to see invocation)
3 years ago
Andre Puschmann 4379c20eb9 rlc_am_lte: avoid locking of Rx mutex twice when generating status PDU
call reset_status(), which now is an private method directly when
building a status PDU. No need for the Tx side to call Rx again.
3 years ago
Andre Puschmann 53a7dc78ee rlc_am_lte: replace do_status boolean with atomic
the do_status is queried from the Tx code frequently. To reduce
chances to delay the execution because the RLC Rx side is currently
holding the mutex we can use an atomic.
3 years ago
Xavier Arteaga 5307fec2f0 Added GNB MAC UL info initial interface and fix PHY implementation 3 years ago
Xavier Arteaga cf496e75eb Fix default PHY NR configuration 3 years ago
Xavier Arteaga 2fbd172888 Initial PHY NR configuration generator 3 years ago
Xavier Arteaga 320aabec13 Initial PHY NR configuration 3 years ago
Xavier Arteaga e764a26136 Integrated PUCCH decoding in gNb 3 years ago
Xavier Arteaga 3fe9176750 Added PUCCH dedocder to slot worker 3 years ago
Xavier Arteaga e3afd945bc Refactored NR HARQ ACK feedback 3 years ago
Xavier Arteaga 658b47d917 Added NR PUSCH and PUCCH decoder in gnb_ul 3 years ago
Xavier Arteaga 89994cd5a8 change ERROR macro format to be parsed by IDE 3 years ago
Xavier Arteaga f6fc215541 Refactored enb_dl_nr to gnb_dl and initial gnb_ul 3 years ago
Xavier Arteaga eecaccb541 Added NR PHY helpers 3 years ago
Andre Puschmann 6372f89c09 s1ap_test: fix compilation on 32bit 3 years ago
Andre Puschmann f292042f66 rlc_am_lte: use try-lock when building status PDU
the patch uses try-lock whenever a status PDU is tried
to be built. This makes sure that when the lock is currently
hold (e.g. by a thread processing rx PDUs) the generation
of the status PDUs is not taking too long and blocking the calling
thread. Instead the status PDU generation is deferred to the next
Tx opportunity.

It's a probabilistic approach that assumes that at some stage the
lock can in fact be acquired.
3 years ago
Andre Puschmann a9d21696c5 rlc_am_lte: make number of RLC SDUs per PDU a compile-time parameter
this allows to set the maximum number of RLC SDUs included
in a single PDU at compile time.
3 years ago
David Rupprecht f90e359208 Moved cp to test common 3 years ago
Andre Puschmann bbcaa49429 network_utils: fix TSAN detected race 3 years ago
Andre Puschmann a9ad408f51 task_scheduler: use block_queue for internal tasks
TSAN detected wrong use of the old deque-based internal queue. To avoid
unwanted/undetected mis-use the patch uses the thread-safe block_queue
data structure instead.
3 years ago
Andre Puschmann 626f24c9f9 block_queue: use class mutex to protect size() getter
detected with TSAN
3 years ago
Andre Puschmann 0e6e3d201e sys_metrics: reduce log level when measurement interval is shorter than expected
on highly loaded systems it can happen that the get_metrics() is called
twice within a few houndred milliseconds. Logging a warning in this
case isn't needed, so reduce to info.

on the other hand, 100ms might be to convervative. Patch also
lowers the smallest interval to 10ms
3 years ago
Ismael Gomez 4e39982a19
Fix TSAN warnings in UE (#3021)
* Protect PHY SR signal management in a class

* Protect intra_freq_meas vector

* Protect cell and srate shared variables in thread-safe classes

* srsue,srsenb: include TSAN options header

* Protect ue_rnti_t and rnti scheduling windows behind thread-safe classes

* Protect access to state variable in sync_state

* Protect access to metrics configuration

* Protect access to is_pending_sr

* Protect access to UE prach worker

* Protect UE mux

* Avoid unlocking mutex twice

* Fix data races in RF/ZMQ

* Fix data races in intra_measure and PHY

* Fix minor data races in MAC

* Make TSAN default behaviour to not halt on error

* Fix blocking in intra cell measurement

* Address comments

Co-authored-by: Andre Puschmann <andre@softwareradiosystems.com>
3 years ago
David Rupprecht 4ed33fed7d Fixed unpack bytes limit 3 years ago
Pedro Alvarez 05fbca43d1 Fix GCC 11 warning in dyn_array 3 years ago
Pedro Alvarez 1b676aa406 Moved lib GTPU to its own folder 3 years ago
Pedro Alvarez 865298f8d5 Moved lib PDCP to its own folder 3 years ago
Pedro Alvarez 171d5727be Moved lib RLC into it's own folder 3 years ago
Francisco Paisana 4d014e7ceb s1ap,feature: make the ts1 reloc timers configurable via the enb.conf 3 years ago
Andre Puschmann b6a3b8c5b1 rlc: fix dtor
TSAN was complaining about destroying a locked mutex
3 years ago
faluco a70ad58440 Fix a data race in the UHD class wrapper where the last error member was being set concurrently causing random crashes.
Introduce a new macro to catch UHD exceptions and log them directly instead of storing an error string, similar to what errno does.

Remove usrp logging helpers that depend on the now removed member since all calls potentially log the error directly.
3 years ago
Andre Puschmann 4d11e5552a rrc,ue: for RRC conn release, delay transition to RRC idle by 60ms as per TS 36.331
when receiving RRC connection release all actions shall be delayed by 60ms as
per the standard
3 years ago
Andre Puschmann 368c7b9e4f ue,stack: clear all EPS bearers when going RRC idle
the EPS bearer manager was only informed when a single DRB
was removed but not when entering idle which requires to
remove all bearers.

This cause the service request to fail.
3 years ago
faluco e20934583e Remove an unsafe assert in the log backend that could be triggered under very certain circumstances.
RFCI has detected this assert failing in the log_backend_test. I have not been able to reproduce this locally but my theory is the following one:
one of the unit tests does the following:

backend.start();
backend.stop();

the internal running_flag member could be set to true and then to false by the main thread before the worker thread calls do_work(). If this happens
the assert will be triggered, which is wrong and too conservative, so remove the assert.
3 years ago
Xavier Arteaga 6f5614a0cc Suggested modifications on gNb MAC/PHY interface 3 years ago
Xavier Arteaga 8378c85ec4 Refactored gNb PHY 3 years ago
Xavier Arteaga aef3e5a40a More NR PHY test and GNB PHY development 3 years ago
Xavier Arteaga 9126ad3b8b Added NR type1 RIV function helper 3 years ago
Xavier Arteaga d49734b1bc SRSENB: Refactor to accomodate 5G NR 3 years ago
Xavier Arteaga e98a6f9eea Make ACK M constant i UEDLNR 3 years ago
Xavier Arteaga 567c7c9c77 Create TTI semaphpore default constructor 3 years ago
Andre Puschmann 483a216bd5 ue,stack: refactor handling of radio bearears in UE stack
this is a rather large commit that is hard to split because
it touches quite a few components.

It's a preparation patch for adding NR split bearers in the next
step.

We realized that managing RLC and PDCP bearers for both NR and LTE
in the same entity doesn't work. This is because we use the LCID
as a key for all accesses. With NR dual connectivity however we
can have the same LCID active at the same time for both LTE and NR
carriers.

The patch solves that by creating a dedicated NR instance for RLC/PDCP
in the stack. But then the question arises for UL traffic on, e.g. LCID 4
what PDCP instance the GW should use for pushing SDUs. It doesnt' know
that. And in fact it doesn't need to. It just needs to know EPS
bearer IDs. So the next change was to remove the knowledge of what
LCIDs are from the GW. Make is agnostic and only work on EPS bearer IDs.

The handling and mapping between EPS bearer IDs and LCIDs for LTE
or NR (mainly PDCP for pushing data) is done in the Stack because
it has access to both.

The NAS also has a EPS bearer map but only knows about default and
dedicated bearers. It doesn't know on which logical channels they
are transmitted.
3 years ago
Andre Puschmann a4b2a065ff pdcp: reword warning when dropping PDU 3 years ago
Andre Puschmann 7113e55d53 rlc: refactor RLC entity to use smart pointers for holding bearers
this patch mainly modernizes the bearer creation to use smart pointers.
that allows to simplify the error handling.

ue_stack is changed to match new interface. This commit compiles
but doesn't work.
3 years ago
David Rupprecht 6d5391756c Refactor build of RLC NR config 3 years ago
David Rupprecht d1d8500ce5 Add testcase for reconfiguration 3 years ago
David Rupprecht ec19919246 Fix NGAP valgrind test 3 years ago
Xavier Arteaga eb7980f2b3 Initial UE synchronization for NR 3 years ago
Pedro Alvarez 4d13906760 Increase logging level of MAC mismatches to warning in PDCP 3 years ago
Andre Puschmann e1fb58d76e rlc_um: reduce log level for message handling lost PDUs
when a lost PDU is detected a warning will be logged. In theory
this could be info as well but a warning may help to detect issues
in tests. The same event causes multiple other warnings to be logged,
which is very spammy. The patch reduces the log level for
those messages to info.
3 years ago
Pedro Alvarez aae266e848 Added configuration option for S1AP SCTP bind port 3 years ago
David Rupprecht 85d7a851fb Added 5G NAS PCAP support 3 years ago
Francisco 78acf81cf0 bugfix,sched: avoid instability in TPCs around PHR~0 3 years ago
Xavier Arteaga b1e4720721 SRSUE/SRSENB: added tx_enable flag in worker_end 3 years ago
Xavier Arteaga 027201d457 SRSUE/SRSENB: Refactor NR workers to generalise lower PHY 3 years ago
Andre Puschmann 83bf5dcd49 rlc_am_lte: reduce time holding Tx mutex when processing status PDUs
the patch is a re-implementation of the customer-specific optimization
we did in order to reduce the time the RLC holds the Tx mutex when
processing an incoming status PDU.

The patch makes sure to never operate on a raw mutex but instead
uses the deadlock-avoiding RAII lock.
3 years ago
Ismael Gomez 5aa5a8e997 Revert UE changes 3 years ago
Ismael Gomez e35a0d72fa Revert UE changes 3 years ago
Ismael Gomez dd9889e07c Add carrier index to uplink PCAP captures 3 years ago
Bedran Karakoc c280ac5ad6 Introducing extended NGAP functionality
Remove unused logger for now in ngap::ue to pass tests
3 years ago
Francisco 5a82a63bb5 bugfix,srsenb: fix intraenb handover softbuffer allocation during handover 3 years ago
Xavier Arteaga cf09044453 Optimised random bit (unpacked) and byte (packed) generator 3 years ago
Xavier Arteaga d2a19c3043 SCH minimum number of iterations to 2 to reduce systematic false alarm probability 3 years ago
Xavier Arteaga ef4c978d72 Optimized byte random generator 3 years ago
Andre Puschmann 475c033440 rlc_am_test: extend status PDU test
add full test with malformed status PDU
3 years ago
Andre Puschmann d7204df896 rlc_am_lte: check rx window first when receiving status PDU
move rx window check up so no actions are taken when receiving
malformed status PDU
3 years ago
Xavier Arteaga 2cd8ba3a1a PDCCH test skips 100PRB for ARM 3 years ago
Francisco 2a009eb340 sched,feature: Enable configuring maximum coderate for SIB allocations 3 years ago
Francisco 6ababf401b feature,sched: allow setting initial DL CQI in enb.conf 3 years ago
Francisco e8983b88f0 refactor: use enb_cc_idx instead of ue_cc_idx in mac::ue 3 years ago
Andre Puschmann fa7a8fb687 rlc_am_test: add testcase for processing out-of-order status PDUs 3 years ago
Andre Puschmann 19f30aa652 rlc_am_lte: fix handling of out-of-order status PDUs
before processing incoming status PDUs we should be checking
if the ACK_SN falls within our current Tx window. If not the PDU
will be dropped.

Without the check we were incorrectly processing the status PDU
and because the sequence number wrap around wasn't working
correctly if ACK_SN is smaller than vt_a we were corrupting
our Tx window.
3 years ago
Xavier Arteaga 8743713bb1 Fix compilation 3 years ago
Xavier Arteaga 676080d6af Added macro SRSRAN_VEC_SAFE_CMA 3 years ago
Andre Puschmann b862bbc2e6 rlc_am_lte: add missing mutex to get_status getter
fixws race detected with TSAN
3 years ago
Andre Puschmann d51ee722f6 rlc_am_test: add unit test for ACK_SN is outside rx window
the test uses a malformed status PDU from a PCAP and makes
sure the RLC receiver detects such a PDU and raises a warning
3 years ago
Andre Puschmann 878142843e rlc_am_lte: add further sanity check when creating status PDU
the test verifies that the ACK_SN of a status PDU falls inside the
rx_window of the receiver. If not, than the RLC state has been
corrupted and the status PDU is likely invalid.
3 years ago
Andre Puschmann 46265c5829 rlc_am_data_test: add data PDU unpack test
TV captured in PCAP
3 years ago
Andre Puschmann b379910690 pdu_test: add UL-SCH unpacking test
TV captured in PCAPs.
3 years ago
Xavier Arteaga 6be57dd216 Disable PDCCH false detection for non AVX2 machines 3 years ago
Alejandro Leal Conejos a51f2a1de4 Fills the value of the number of cpus for the system_metrics_t and
initiliaze its value to 0 when executing 2 measures in less than 100 ms.
3 years ago
Pedro Alvarez a53b321ab8 Release UE upon reception of integrity error. 3 years ago
Pedro Alvarez 299d2ee35d Added interface to make the PDCP notify the RRC of integrity check
failures.
3 years ago
Xavier Arteaga 939dd1b977 Change struct sync_raster_t to class 3 years ago
Xavier Arteaga a79d518799 Added SSB search measure/decode file test 3 years ago
Xavier Arteaga 5181a9d64c Implemented PBCH blind decode 3 years ago
Xavier Arteaga a7b7f8e78a Avoid SSB search to have a peak that SSB data is outside buffer 3 years ago
Xavier Arteaga 480f1b14fe Protect Radio from null phy 3 years ago
Xavier Arteaga 9621cf57c2 Implemented NR SS raster object 3 years ago
Xavier Arteaga 49d857cd17 Refactored decode_tb function 3 years ago
Xavier Arteaga 22b1673b36 Added CRC match function and simplify CRC check 3 years ago
Xavier Arteaga 7846bfccb1 Implemented softbuffer RX CRC reset 3 years ago
David Rupprecht ff3e7c321d Added bref function for calc distance til end 3 years ago
Xavier Arteaga e8f2b3a74c Add PDCCH decoder correlation check in blind search 3 years ago
Xavier Arteaga 7c78fd2050 Implemented PDCCH DCI message correlation and updated test 3 years ago
Xavier Arteaga bcd2e59635 PDCCH test global variable cleanup 3 years ago
Francisco 7e77da6a15 mac,optimization: use rnti memory pool to create mac::ue objects 3 years ago
Andre Puschmann 295b5fe8fb rlc_tm: fix stopping of entity detected with TSAN 3 years ago
Andre Puschmann a013a2fe05 rlc_stress_test: fix bug when read_pdu was returning -1 3 years ago
Andre Puschmann c0be8187c8 rlc interface: convert entire read_pdu() interface to return uint32_t
we had it returning int but had a bug in using the return value properly,
i.e. handling when -1 was returned in RLC TM.

Thinking about it more, it doesn't make sense to have a negative return
value here anyway. Either the RLC can return a PDU or not. If it can't the
returned lenght is zero.
3 years ago
Francisco 539ca47fe2 lib,bugfix: fix blocking queue unit test. Dtor cannot destroy object while a thread is still pushing data 3 years ago
Xavier Arteaga 60f294a6a1 Refactor PDCCH encode/decode unit test 3 years ago
Xavier Arteaga 5ddc974beb Reverted PDCCH threshold 3 years ago
Xavier Arteaga d46be09663 Increase viterbi default number of iterations 3 years ago
Xavier Arteaga 090022568e DCI NCCE find considers L and NCCE 3 years ago
Andre Puschmann a36e0477b8 rlc_am: fix status PDU packing when grant size isn't enough to send full report
when a small grant is provided it might not be possible to fit a full status
PDU. This is currently detected while packing the PDU.

In order to avoid sending potentiall contradicting status info to the sending
entity, the fix makes sure to only transmit a small PDU acking what really
has been received so far.

This might not be optimal in terms for retx but will not corrupt any
state.
3 years ago
Andre Puschmann 5838ec4999 rlc_am: revert expect macro back to error log and inform higher layers
the incidence really must be handled by the higher layers, i.e. the bearer
needs to be reestablished.
3 years ago
Andre Puschmann f22f4b4fbd rlc_am: fix potential stalling in RLC transmitter
it turned out that a certain order of events can lead to
a RLC transmitter stalling because even though unacknowledged PDUs
are queued, none of them was actually considered for retx.

This can happen if a pollRetxTimer expires for a SN that, meanwhile,
has already been acknowledged. The positive lead to the deletion of
the SN from the Tx window.

The fix makes sure that when a retx for a unexisting SN is requested,
the sender will consider the next unacknowledged SN instead.
3 years ago
Andre Puschmann 9612bb0e14 rlc_am_test: fix status PDU test and add extra test for failure signaling 3 years ago
Andre Puschmann aaffdeb326 rrc,rlc: add method to signal protocol failure to RRC
general-purpose method for lower layers to signal protocol
failures to higher layers, i.e. RRC.

In the current case, implement a direct release of the UE (enb) or
a reestablishment (UE).
3 years ago
Andre Puschmann 107f6334dd compile: fix compilation on 32bit systems that require -latomic 3 years ago
Francisco ceaef3523f sched,feature: Enable setting the target PHR below which the maximum UL grant size starts decreasing 3 years ago
Francisco 486823e5de sched,bugfix: The PHR handling scheme now considers the number of PRBs of the UL grant that carried the PHR. Before, it was assuming the most conservative scenario of Nprb=1 3 years ago
Francisco f7aef3ffc1 sched,bugfix: fix nof_retx update when UL HARQs are resumed 3 years ago
Ismael Gomez 5db3030428 Tiny changes 3 years ago
Francisco 89406b07d6 make eNB UL SNR initial value an exponential average alpha configurable 3 years ago
Andre Puschmann 1529379e9e fec,pbch: remove unused variables
unused code that moreover was causing TSAN to complain, e.g.
in the ue_phy_test
3 years ago
Andre Puschmann 7ee38e6255 threads: disable thread attributes when compiled with TSAN
TSAN doesn't work well then threads are created with attributes
thar require root rights but the process is run as normal user.

this patch avoid the thread attributes in this case. TSAN isn't going
to be used for production builds.
3 years ago
Andre Puschmann b88f22b9fe network_utils_test: fix race detected with TSAN 3 years ago
Andre Puschmann f823340a95 rf_imp: fix race when stopping gain thread
detected with TSAN using benchmark_radio test
3 years ago
Andre Puschmann 716caafd6c multiqueue_test: fix race reported by TSAN 3 years ago
Andre Puschmann 1ef3cb7e5d threads: fix race in stopping periodic thread 3 years ago
Andre Puschmann 312b5a241c mac_pcap_base: fix race detected with TSAN 3 years ago
Andre Puschmann c434aac526 rlc_stress_test: include tsan options header 3 years ago
Andre Puschmann 1d34aa280f byte_buffer_queue: make class thread-safe by using atomics 3 years ago
Pedro Alvarez 18e2149d68 Sending Initial Context Setup Response after RRC reconfiguration. 3 years ago
Xavier Arteaga 4f7a94acb6 Fix comment 3 years ago
Xavier Arteaga d329297151 Implement radio invalid mapping countermeasure 3 years ago
Andre Puschmann 3966065bff pssch_test: fix newlines in printf 3 years ago
Andre Puschmann 2ace2b47b8 pssch: fix uninitialized value 3 years ago
Xavier Arteaga bbab2cd9ba Make PDCCH LLR mean amplitude in function of maximum 3 years ago
Xavier Arteaga 2ca0932d9b Reviewed LTE noise estimation 3 years ago
Xavier Arteaga 10a268fdba Added SNR to phy_dl_test 3 years ago
Francisco f36f5271d3 timers,feature: make timers thread-safe by using atomic to store timers state. 3 years ago
Xavier Arteaga dddb3ede71 Fix zero parity 3 years ago
Andre Puschmann 50f7fc644b rlc_am_lte: log event when status prohibit timer expires 3 years ago
Xavier Arteaga 3c93d5ba43 Fix carrier mapping concurrency issue 3 years ago
Xavier Arteaga 235a664120 SRSUE: Removed PUSCH-DMRS/SRS pregeneration methods 3 years ago
Andre Puschmann 531acc0a98 rlc_am_test: add check for RLC buffer state return during retx 3 years ago
Andre Puschmann 3102861ee3 rlc_am_lte: make func param const& 3 years ago
Francisco 0dafe4dd58 fix coderate derivation in PDCCH based on aggregation level 3 years ago
Francisco a587d20252 allow specification of subset of valid measurement gap offsets in rr.conf 3 years ago
Andre Puschmann 02cceee997 rf_zmq_imp: revert 28399dd876 and fix unit
although the manual test with Amarisoft eNB worked fine it seems
the delay is still needed in the default case. Over 50% of the
tests failed in the nightly with:

[zmq] Error: tx time is 0.067 ms in the past (138240 < 139776)
[zmq] Error: tx time is 1.100 ms in the past (184320 < 209664)

While this usleep() should increase the pass likelihood it
still doesn't guarantee error-free runs, so we might need
to revisit it again as some stage.
3 years ago
Andre Puschmann e7aa484308 rf_zmq_test: remove srsran.h include 3 years ago
Andre Puschmann bb6a5ebe80 tsan: add TSAN options file to set some default flags and exclude some libs from checks 3 years ago
Andre Puschmann 28399dd876 rf_zmq_imp: remove sleep 3 years ago
Andre Puschmann 574459fd90 rf: remove srsran.h include 3 years ago
Xavier Arteaga f33731ecd4 Disable irrelevant unit/component test by default 3 years ago
Andre Puschmann d9a5d3f95a pcap_base: increase PDU queue length
some systems with slower HDD seem to have issues
writing the PDUs to disk. increasing length to see if that helps.
3 years ago
Xavier Arteaga a245039cf3 Initial NR-PBCH-DMRS integration 3 years ago
Pedro Alvarez 997f7db23a Small fixes for observer.h missing std::size_t 3 years ago
Pedro Alvarez c74b2dd633 Fix some warnings in PHY due to array parameter mismatch for a few functions 3 years ago
Andre Puschmann c1ad867824 epoll_helper: use std::atomic to protect exit called from different thread 3 years ago
Andre Puschmann d8b2cfcef8 zmq,ringbuffer: protect concurrent access
some issue found through TSAN execution
3 years ago
Andre Puschmann f1e6a975de thread_pool: fix concurrent access of state variable
the thread workers need access to their current state to exit properly
when they are set to state STOP. However, since the state is kept in
a std::vector for all workers, it seems more appropiate to add a per-thread
running variable rather then mutexing the entire vector.
3 years ago
Xavier Arteaga 48e0fc3c99 Implemented initial PBCH decoder and refactored SSB candidate selection 3 years ago
Xavier Arteaga de1b25558f Added PRN sequence apply bit with state 3 years ago
Xavier Arteaga 1f38817b3b Added random bit vector generator 3 years ago
Xavier Arteaga bcb91d6173 srsran_vec_sprint_hex returns number of written characters 3 years ago
Xavier Arteaga 3634e96c3e Added SSB measure test add/put/encode time measure 3 years ago
Xavier Arteaga 0aa5b14145 Initial NR PBCH encoding 3 years ago
Xavier Arteaga d66dac0ab2 Added bit sequence state apply 3 years ago
Francisco 7076dbfef8 feature, scheduler: Add configuration parameter to set minimum TTI interval between TPCs 4 years ago
Francisco dedd9c09a7 feature, scheduler: Add abitility to set minimum aggregation level in PDCCH, and disable adaptive aggregation level based on target BLER 4 years ago
Francisco c5029fc266 feature - implement adaptive link adaptation in DL and UL 4 years ago
Francisco 8df6ed07c6 sched small fixes - use 0.930 instead of 0.932 for max coderate. Allow computing mcs/tbs based on max coderate directly. Other small fixes 4 years ago
Francisco 31936c9754 bugfix - printf formatting incorrect in bounded_bitset method 4 years ago
Francisco b093576634 avoid sending UEContextReleaseRequest from Source eNB during S1 Handover. 4 years ago
Francisco f2a56c9139 simplification of multiqueue design.
- the consumer does multi-staged waiting:
  1. spins first across all queues in a RR fashion
  2. each queue access is done with a try_lock.
  3. if the try_lock fails, it increases the number of spins needed
  2. if no queue had data, the consumer sleeps for 100 usec.
- no differentiation between queues, in terms of notification features
4 years ago
Francisco 60a8ee0af9 multiqueue optimization - use condition_var wait_for() method, use queue try_lock in the consumer side 4 years ago
Francisco b41aba2a03 fix task scheduler test 4 years ago
Francisco 2d6a878826 change interface to create multiqueue queues 4 years ago
Francisco f705735093 optimization - only allow some multiqueue queues to notify the multiqueue consumer of the arrival of tasks 4 years ago
Andre Puschmann bc3be73364 rlc_am_lte: replace simple sanitfy check with error log with expect
this should help debugging the situation when this happens by
aborting when STOP_ON_WARNING is enabled
4 years ago
yagoda 9501283c1c fixing support for extended Cyclic Prefix
small cosmetic fixes of CP code
4 years ago
Andre Puschmann 21b3635ae4 rlc_am_lte: refactor retransmit_pdu() to send different SNs
it seems that different SNs should be retransmitted depending
on the actual situation. In case of pollRetx timer expiration,
vt_s - 1 should actually be resent.

This patch prepares the function to accept different SNs but
leaves it to send vt_a by default. The RLC AM test would need
to changed as well to not fail.
4 years ago
Andre Puschmann 81c1851bbd rlc_am_test: fix TSAN isses and removing info log when dropping PDU 4 years ago
yagoda f90f6f0c7e adding MAC 0 padding support 4 years ago
Xavier Arteaga 8ffbf0ff6d Fix SSB segfault 4 years ago
Xavier Arteaga f9aafd00a7 Added subcarrier spacing parsing from string 4 years ago
Xavier Arteaga b69057b76e Filesource filename to constant 4 years ago
Xavier Arteaga 5eadc06dd4 Intra-frequency miscellanous changes 4 years ago
Xavier Arteaga 7b159563ab Fixes in LTE CRS measurements 4 years ago