5g-team
/
srsRAN_4G
mirror of https://github.com/pvnis/srsRAN_4G.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
10,000 Commits
2 Branches
0 Tags
243 MiB
fix-cqi
master
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'e086479a7b'
${ noResults }
Commit Graph

4699 Commits (e086479a7b6962f152d383c4e73ea6312d8aa887)

Author SHA1 Message Date
faluco edf0926a2f Batch of LGTM fixes. 3 years ago
Francisco 529e2bdf55 nr,rlc: call bsr update callback in RLC UM NR 3 years ago
Francisco 7ad1ad800e lte,enb,rlc: atomically compute DL buffer state and update the scheduler in the eNB 3 years ago
Ismael Gomez d972fb368c
Some LGTM fixes (#3564) 
* Fix LGTM issues

* ue: add logging to switch on function

* Fix new LGTM issues
 3 years ago
Joaquim 93649429dd
WIP: Fix Coverity issues in PHY lib (#3507) 
Fix several Coverity issues

This commit adrresses the following code issues found by Coverity:

CID 339785 Division by zero, in fading_channel_test.c
CID 355272 Division by zero, in awgn_channel_test.c
CID 355277 NULL ptr dereference, in awgn_channel_test.c
CID 359663 NULL ptr dereference, in delay_channel_test.c
CID 369544 NULL ptr dereference, in chest_dl_nbiot.c
CID 373326 Resource Leak, in dft_fftw.c
CID 373329 Resource Leak, in dft_fftw.c
CID 372878 Division by zero, in sliv_test.c
CID 372871 Division by zero, in dmrs_pdcch.c
CID 370622 Negative loop bound, in csr_rs.c
CID 370624 Negative loop bound, in csr_rs.c
CID 370626 Negative loop bound, in csr_rs.c
CID's 369568, 369594 NULL ptr dereference, in ch_awgn.c
CID 369540 Logically dead code, in refsignal_dl.c
CID 369608 Logically dead code, in refsignal_ul.c
CIDs 366291, 366296, 366297 Out-of-bounds access, in zc_sequence.c
CID 372209 Division by zero, in cqi.c
CID 370992 Uninitialized pointer read, in pdcch_test.c
CID 373334 Integer overflow, in ue_sync.h
CID 370993, 370995 Undefined division, in pdcch_test.c
CID 370994 Undefined division, in ssb_decode_test.c
CIDs 353368 353364 353365 359673 353366 353367
Explicit null dereferenced, in psss_file_test.c
CID 371865 Unchecked return value, in rf_uhd_imp.cc
CID 363810 Undefined division, in ldpc_rm_chain_test.c
CID 372209, 372211, 372213, 372216 Undefined modulo, in cqi.c
CID 339834 Array compared against 0, in chest_dl.c
CID 369589 Out of bounds access, in dmrs_pucch.c
CID 371681 Out of bounds access, in ue_sync_nr_test.c
CIDs 370761, 370825 Copy-paste error, in ssb.c
CID 369599 out of bounds read, in dmrs_pdcch_test.c
CID 363795 out of bounds read, in ldpc_dec_c_avx2_flood.c
CID 363805 out of bounds read, in ldpc_dec_c_avx2long_flood.c
CID 363821 out of bounds read, in ldpc_dec_c_flood.c
 3 years ago
faluco dc31fb05a3 Fix ODR issue detected by ASAN in arch for the srsran_verbose global variable. 3 years ago
faluco fa8e8ddf1f Fix an ODR issue detected by ASAN in arch, where the global variable handler_registered was defined multiple times. 3 years ago
yagoda 5d6b48311e fixing a few regression bugs in embms 3 years ago
Andre Puschmann 497e183487 rf_zmq_imp: disable Tx baseband scaling 
until the correct gain settings are documented and potential
mis-configuration are handled. It seems that the default
Tx/rx gains values are not working with this function.
 3 years ago
Andre Puschmann e2d26b5a8c rlc_um_nr: log PDU without SN if full SDU is transmitted 
PDUs that contain full SDUs don't have SNs, so the log should be
without it
 3 years ago
Andre Puschmann 3eb1862ab9 gnb_interface: reduce MAX_GRANTS to 4 
see #3530 for detailed discussion. This change saves some CPU cycles it seems
 3 years ago
Fabian Eckermann 32a1646536
nr,gnb,rrc: Derive RRC parameters from config. 
* Derive RRC parameters from config.
* nr,gnb,rrc: hard code prach config index to 8 to avoid expiring RA proc window.
 3 years ago
faluco 5ff6b2eaa9 Fix data race in ZMQ where nsamples and running variables could be read concurrently. 3 years ago
Xavier Arteaga 322f57a952
Initial real-time Tx gain setting (#2976) 
* Make filename const in filesink

* Sine generation returns the next phase

* Avoid malloc/free in radio class

* Implement Tx gain in ZMQ

* Initial ratio RT gain test

* UHD: use timed Tx gain commands to align changes to subframes

* Minor improvement in test_radio_rt_gain

* Fix compilation

* Check RF gain thread id before joining

* Remove redundant zero initialization.

Co-authored-by: Fabian Eckermann <fabian@srs.io>
 3 years ago
Xavier Arteaga ebab12403f
Asynchronous NR PHY configuration (#3527) 
* Fix a race condition when accessing the NR PHY cfg by the RRC and phy workers.
Rework how the phy cfg is handled, now workers have their own copy that gets updated after a reconfig moving it out of the state class.

* Default initialize sf_len member in sf_worker for consistency.

* Asynchronous NR PHY configuration

* Fix compilation

* Corrected method override and fix unitialised value

* Added carrier equal comparison to avoid aligment byte padding comparison

Co-authored-by: faluco <borja.ferrer@softwareradiosystems.com>
 3 years ago
faluco 0ada9a01ec Whitelist TSAN issue in srsenb::mac::sr_detected. 3 years ago
faluco a1b2f3915d Whitelist lock order inversion tsan issue in srsenb::rlc::rb_is_um. 3 years ago
Andre Puschmann 8294724aad gnb_interface: reduce MAX_GRANTS to 4 
this significantly reduces data copies when providing the PHY
with scheduler results.
 3 years ago
Xavier Arteaga 95bf85b3d3 Reduced maximum number of CSI reports 3 years ago
Pedro Alvarez fbcffb84bd Check if RLC is suspended before transmiting PDCP SDU. 
This was done to avoid integrity issues, when the UE's RRC erroneously sent
measurement reports while the re-establishment was already in progress.

As errously sending PDCP PDUs on DRBs can cause issues as well, this was
disabled too.
 3 years ago
Alejandro Leal Conejos 9daa32e591 Configure the term timeout using the cmake definition 
EXTRA_TERM_TIMEOUT_S
 3 years ago
Xavier Arteaga d9bdc3f83e Add CSI resource information and fix segmentation fault 3 years ago
Carlo Galiotto 284207dad6 WIP: fixing collision in the the users_map 
Signed-off-by: Carlo Galiotto <carlo@srs.io>
 3 years ago
Xavier Arteaga eace81d613 Fix UCI multiplexing for NR PUSCH 3 years ago
Xavier Arteaga 39bfcf4a5c Add UCI valid in NR PUSCH info 3 years ago
Ismael Gomez 7920e084b8 Revert "Do not abort tsan" 
This reverts commit e8e1d101c553912f733070e71d020a33ec895280.
 3 years ago
Ismael Gomez 80c48a8b01 rlc: protect access to tx_enabled 3 years ago
Ismael Gomez bf566fbd29 radio: protect concurrent access from tx_end and tx 3 years ago
Ismael Gomez 4239222909 Do not abort tsan 3 years ago
faluco 95b4a92f5f Clarify the error messages printed when trying to open a RF device. 3 years ago
Francisco c6226b0d94 lte,enb,rrc: parse cellIndividualOffset in rr.conf and propagate it to measConfig sent to UE 3 years ago
Pedro Alvarez 65a2b35f09 Fix not checking initialization of S11 in MME. Fixed typo. 3 years ago
Pedro Alvarez 0b948d4098 Make sure that bind returns error if it cannot bind. Added test for SCTP bind error/success. 3 years ago
Pedro Alvarez e721504f8e Removed the sctp_init_server for consistency. Added listen method to unique_socket class. 3 years ago
Pedro Alvarez e9a7e6dbae Getting rid of sctp_init_client function. The only thing it does is call the sctp_init_socket function. 3 years ago
Francisco d60950d0f3 lte,enb,rlc: change new_tx and prio_tx variable names to snake_case and ensure they are zero initialized 3 years ago
Francisco 7aa5f731ce lte,enb,rlc: push to scheduler pending prioritized bytes both in case of RLC timer expiry or in case of new buffer state detection 3 years ago
Francisco 4a58c10f30 lte,enb,rlc: compute and forward to scheduler the number of bytes pending for retx and status pdu in RLC AM bearer 3 years ago
Xavier Arteaga 4edb61212f Added number of CDM groups to phy_dl_nr_test 3 years ago
Xavier Arteaga 8e5fe9018b Corrected LBRM functionality 3 years ago
Xavier Arteaga 9ecea014bd Added PUSCH DMRS minimum SNR 3 years ago
Francisco 0b51848dda nr,gnb,rrc: use multiqueue to forward x2 tasks to NR stack 3 years ago
Fabian Eckermann 59df04547e Increase buffer size for NR. 3 years ago
Andre Puschmann 3bf09021f9 enb: remove unused parameter 3 years ago
Francisco 5b2afb1739 rrc,nr,gnb: ensure same PDCCH config is sent to PHY, scheduler cell config, and sched ue cfg 3 years ago
Francisco 7a16be9692 rrc,nr: ensure coresets and search spaces are passed to scheduler cell_cfg and ue_cfg 3 years ago
Andre Puschmann e5556fcc32 mac_pdu_nr_test: add LBSR unpacking tests 3 years ago
Andre Puschmann af69551c8d mac_sch_pdu_nr: add LBSR unpacking 
* add LBSR unpacking
* add pretty printer
* also simplify and unify general unpacking code
 3 years ago
Francisco 81174bda64 nr,ue,rrc: release NR logical channels during RRC release 3 years ago
Xavier Arteaga 537f165482 Added comments 3 years ago
Xavier Arteaga 3c40cd2840 Improved NR PHY logging info 3 years ago
Xavier Arteaga addd687d7e Fix NR PUCCH format 1 normalised correlation 3 years ago
Xavier Arteaga e6bd6462b1 Estimate CFO for NR PUCCH formats 0 and 1 3 years ago
Xavier Arteaga 51ff429bc7 Added SS type to PDSCH context info 3 years ago
Xavier Arteaga a5f6aa9f31 Added CSI string in PDSCH and PUSCH decode 3 years ago
Xavier Arteaga 003c6e524c Added short NR CSI information 3 years ago
faluco dacf40f63e Delete move constructor and move assignment operator explictly for mac_pcap_base and s1ap_pcap classes. 
Move emergency handlers header file into the support folder.

Refactored signal handling:
- Remove the dependency with the running static variable in the header file.
- Move implementations down to cc files.
- Allow specifying a new signal handler that will be used to stop the applications.
- Move signal handling files to support.
 3 years ago
faluco 9075251627 Move the cleanup code from the signal handlers down to the new emergency handlers for the ue, epc and enb. 3 years ago
faluco 2c1e9c0c55 Implement an emergency cleanup handler registration mechanism to allow modules to clean themselves before application gets killed. 
Flush PCAP contents just before killing the application.
 3 years ago
Fabian Eckermann 44de4996e8 Fix log message. 3 years ago
Francisco f427a25a30 nr,gnb,mac: account for header space larger than 2 when packing PDSCH 3 years ago
Francisco ed2e88524f asn1,rrc_nr: implement to_json in setup_release_c 3 years ago
Francisco 9df6c6b936 sched,nr: ensure the ue_cfg_t passed to the scheduler in NR FDD mode has the correct harq delay 3 years ago
Andre Puschmann 255ddb1329 enb,gnb: add basic support for sgnb release procedure 
the procedure is currently started when the EUTRA UE object
is deleted (after RRC release) in order to clean-up the
ENDC resources on the gNB.
 3 years ago
Francisco ea324e8cbe nr,sched,test: update sched nr test to better reflect MAC-PHY FAPI 3 years ago
Andre Puschmann 7cbd3d50b7 mac_sch_pdu_nr,bsr: fix length check for BSR 
fix nasty bug where the length calucation for the LCID
was taking the bsr_format_nr_t that was having the same name.
 3 years ago
faluco 28bbaa7816 Blacklist TSAN issues from libusb and libuhd. 3 years ago
faluco 75af37bd4b Batch of race fixes when running the UE and ENB with UHD. 
Main fixes are in the UHD driver, fixing races and potential deadlocks.
 3 years ago
Alejandro Leal Conejos 1a64c6adad Enum fixes so clang 12 can build the repo 3 years ago
Carlo Galiotto f53e01cfa3 mac: apply changes by PR reviewers 
- reinstate write_lock on ue metrics
- change "rwlock" variable name in mac_nr.h

Signed-off-by: Carlo Galiotto <carlo@srs.io>
 3 years ago
Carlo Galiotto dc3e3a89f8 mac: update CQI in MAC with CSI reports from PHY 
Signed-off-by: Carlo Galiotto <carlo@srs.io>
 3 years ago
Xavier Arteaga a9904c2b64 Fix info format string 3 years ago
Xavier Arteaga a31a40184d Fix NR PRACH encoding 3 years ago
Xavier Arteaga 8bab12fb00 Added NR case to prach_test 3 years ago
Xavier Arteaga 3c4efba418 Added missing parameters to NR PHY configuration factory 3 years ago
Xavier Arteaga 5e1291b0c7 Fix PRACH detection sequence generation for NR 3 years ago
Francisco 11ee4ab9dd nr,gnb,rrc: fix scheduler FDD configuration 3 years ago
Francisco 4e49508d8f nr,gnb,mac: fix RAR encoding by resetting the RAR buffer 3 years ago
Francisco 1b595b6eff nr,gnb: if no nr cell is initiated, do not enable endc in the LTE RRC 3 years ago
Francisco 3721523810 pdcp,lte: fix debug logging in PDCP, to avoid segmentation fault and crash 3 years ago
Francisco 43b12b9ffb rrc,nr: transfer SSB config to both UE and NR scheduler 3 years ago
Carlo Galiotto 43a7d822fa stack,rrc: fix double removal of EPS bearer 
The EPS bearer was removed twice, causing an error in the logs.

Fix issue #3380

Signed-off-by: Carlo Galiotto <carlo@srs.io>
 3 years ago
Xavier Arteaga 7262287926 Zero power UCI bits is not an error but KO 3 years ago
Xavier Arteaga 4a327ad17d Consider CRC length when calculating real LDPC rate 3 years ago
Xavier Arteaga 5f17c46098 Modify periodic CSI time offset to UL slot 3 years ago
Xavier Arteaga bd186fab2e Fix CMake SSB frequency addition overflow 3 years ago
Xavier Arteaga be870d66ad More relaxed SSB measure assertions and reorder SSB test 3 years ago
Xavier Arteaga 4b77127ed6 Added missing SSB pattern to unit test 3 years ago
Xavier Arteaga 8bb23cc74a Correct CMake sign 3 years ago
Xavier Arteaga 52e00d6376 Fix PBCH encoding and added unit test 3 years ago
Xavier Arteaga 25bd0d6219 Added SSB pattern to/from string functions 3 years ago
Francisco 053877f489 rrc,nr: fix conversion from asn1 to phy cfg 3 years ago
Francisco 47e5e85449 refactor: clean unnecessary includes of the asn1/rrc_nr.h 3 years ago
Xavier Arteaga 1bdb1bb62d Store PUSCH CSI from PUSCH DMRS 3 years ago
Fabian Eckermann 420d6a6a98 enhanced and fixed some tests. 3 years ago
Bedran Karakoc 850606f20b Added deregistration (UE terminating) 3 years ago
Robert Falkenberg b0430ebfe2 rf_imp.c: fix segfault when closing RF device with no AGC thread 3 years ago
Francisco 3b79393974 sched,nr: fix default ue configuration when prach arrives 3 years ago
Xavier Arteaga d5b34696b4 Sepparate CSI report configuration from quantification and integrate in nr_phy_test with assertions 3 years ago
faluco 388b1e5d92 Fix data race in radio::is_start_of_burst. 3 years ago
faluco 7b0b76d58e Whitelist two lock order inversion TSAN issues that acquire a readlock. 3 years ago
Francisco Paisana b7f40b2baf rrc,nr: reenable CSI reporting in gNB 3 years ago
Xavier Arteaga 00a6e71f50 Fix UL/DL frequency compensation 3 years ago
Fabian Eckermann cb721aa292 fix calculation of ssb frequency. 3 years ago
Francisco Paisana b58915d7ed rrc,nr: make gnb cell CSI NZP configuration consistent with UE NSA configuration. 3 years ago
Francisco Paisana 23bf542ae7 stack,nr: isolate calls between LTE and NR stacks via the task multiqueue 3 years ago
Andre Puschmann 8bb06ff2c0 Added SSB in gNb PHY 3 years ago
Xavier Arteaga 3763d04578 implement helper function to calculate FFT size for a given sampling rate 3 years ago
Andre Puschmann 7496b7c14f Add SSB to configuration factory 3 years ago
Andre Puschmann 5b0767772b Added SSB center frequency to band helper 3 years ago
Andre Puschmann 91e17337db Added SSB scaling configuration option 3 years ago
Andre Puschmann 3e5b40fd36 enb,rrc: fix compilation after freq point a has been removed from nr_carrier_t 
since absolute freq point a members have been removed from the srslte_nr_carrier_t
struct (they are now actual frequencies) the abs_point_a values are now in
the RRC cell structs
 3 years ago
Fabian Eckermann 5f40d4fd99 Add test for ssb from band calculation. 3 years ago
Fabian Eckermann 95abfbfec8 Calculate ssb frequency from freqency point a. 3 years ago
Francisco Paisana f22483ce72 sched,nr: use formatting %d to represent slot index 3 years ago
Xavier Arteaga c9d7db7314 Minor changes 3 years ago
Xavier Arteaga e3bd92d87c Fix SSB pattern in UE 3 years ago
Xavier Arteaga 8f90ee847a Refactor carrier frequency from PHY and fix OFDM phase compensation 3 years ago
Xavier Arteaga fda35bf6a1 Initial OFDM carrier phase compensation 3 years ago
Xavier Arteaga 2ab3971ef1 Fix NR PBCH encoding/decoding 3 years ago
Xavier Arteaga 530b381c6c Change NR PDSCH/PUSCH freq/time resource format in log 3 years ago
Ismael Gomez 6b506ec357
phy_common: clear tx_hold flag before releasing the semaphore (#3342) 3 years ago
yagoda 82bda02b36 adding nr metrics 3 years ago
Andre Puschmann 1937e4d7fc ssb: add extra checks when configuring SSB 
this is to avoid invalid configs that later on cause segfaults, etc.

e.g.:

    0 0x7f397adf64a3  (/lib/x86_64-linux-gnu/libc.so.6+0xbb4a3)
    1 0x7f397cc8c6ce  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x796ce)
    2 0x55b921d61707 in srsran_vec_cf_copy /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/src/phy/utils/vector.c:226
    3 0x55b921d3b1d4 in ssb_demodulate /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/src/phy/sync/ssb.c:632
    4 0x55b921d3d8ce in srsran_ssb_csi_measure /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/src/phy/sync/ssb.c:905
    5 0x55b9215dc20f in srsue::nr::cc_worker::measure_csi() /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/srsue/src/phy/nr/cc_worker.cc:373
    6 0x55b9215dd216 in srsue::nr::cc_worker::work_dl() /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/srsue/src/phy/nr/cc_worker.cc:483
    7 0x55b9215f9c69 in srsue::nr::sf_worker::work_imp() /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/srsue/src/phy/nr/sf_worker.cc:78
    8 0x55b921c47cc6 in srsran::thread_pool::worker::run_thread() /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/src/common/thread_pool.cc:48
    9 0x55b92152ea0b in srsran:🧵:thread_function_entry(void*) /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/include/srsran/common/threads.h:103
    10 0x7f397c9fb6da in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76da)
    11 0x7f397ae5c71e in __clone (/lib/x86_64-linux-gnu/libc.so.6+0x12171e)
 3 years ago
Xavier Arteaga 1aa65bd10c HOTFIX: force DFT wisdom save at exit 3 years ago
Fabian Eckermann 077f9cd03e Add test for get_abs_freq_point_a_arfcn. 3 years ago
Fabian Eckermann 7f7cfe687d fix calculation. 3 years ago
Ismael Gomez c09f09b7be Move rrc_common from srsue to lib 3 years ago
Fabian Eckermann 8830c2796f Add support for NSA FDD on band n3, n5 and n7. 3 years ago
Fabian Eckermann 2d0be77660 Add helper functions for abs freq point a. 3 years ago
faluco a8f58f503c - Fix arm compiler warning. GCC treats chars as unsigned in this arch. 
- Fix race condition in json metrics.
 3 years ago
Andre Puschmann 315057d11c enb: signal user activity to EUTRA RRC when doing NR DL traffic 
to avoid releasing the UE when only NR DL traffic is done.
similar to the EUTRA solution.
 3 years ago
Xavier Arteaga 8b2514ded3 Added NZP-CSI-RS signals in gNb 3 years ago
Francisco Paisana cbb709d4e3 sched,nr: function to log UEs buffer status before scheduling decision, fix const_iterator of circular_map 3 years ago
faluco 1eaca0d343 Escape asn1 message strings that get printed in the enb event json report. 3 years ago
Ismael Gomez 1c77998df5 Stop PDCP for data bearers before initiating HO 3 years ago
faluco fa351cd285 Rename functions that contain the unsafe word to nolock. 
The term "unsafe" does not clearly state that the function is not locking the shared date and it sounds "dangerous", so use a more explicit term.
 3 years ago
Andre Puschmann 59e1bca3f5 rlc_am_lte: fix potential crash when attempting to resize tx queue 
under some circumstances it could happen that the RLC is configured
when SDUs are already being written to the queue. The resize
operation of the underlying container would fail in this case.

Make sure to empty the queue before doing the resize.
 3 years ago
Francisco Paisana bdf18856d1 sched,nr: fix handling of DL BSR in NR scheduler and computation of UCI 3 years ago
faluco 7b079fe289 Fix a data race in rlc TM metrics. 3 years ago
faluco edb7342aef Fix data race in rlc UM metrics. 3 years ago
faluco 6c91a824e2 Whitelist the TSAN lock order inversion issue in srsenb::mac::rlc_buffer_state. 3 years ago
faluco 8a38a89652 Fix compiler warning: control reaches end of non-void function 3 years ago
Andre Puschmann 426e876047 enb,nr: fix GTPU handler to forward UL PDUs 3 years ago
yagoda bc4388a78c -adding temp crnti removal for NR carrier attach 3 years ago
Andre Puschmann 430694c72f gnb,dl: fix amplitude scaling 
use PDSCH struct to get number of PRBs to compute scaling factor.
then PDCCH struct is only filled if it's encoded.
 3 years ago
Andre Puschmann 802b22ac91 enb,nsa: refactor NR RRC/cell config parsing 
this allows to access all cell-related params from within RRC
 3 years ago
David Rupprecht 611255aa5f Added GTPU bind address as output parameter 3 years ago
David Rupprecht bd0e641633 Added GTPU PDU Session header parsing 3 years ago
Bedran Karakoc 43915550cc NGAP GTP Bearer Establishment 3 years ago
David Rupprecht 3712983308 Added PDU Session est request 3 years ago
David Rupprecht c670383ae9 Added NAS 5G functions incoming msg and reg proc 3 years ago
David Rupprecht bbe54fb248 Fix uninitialized issue in NAS 5G pack/unpacking 3 years ago
Xavier Arteaga d0ce17f736 Added SSB different SCS combination unit test 3 years ago
Xavier Arteaga e2facef540 Abort radio application if decimation/interpolation ratios are not integer 3 years ago
Xavier Arteaga cdfbe28b69 Initial NR-MIB packing/unpacking 3 years ago
Fabian Eckermann f44eb0534f Add RRC NR test for FDD 3 years ago
Xavier Arteaga 0324806d6c Packed NR TDD config in duplex configuration and created test case for FDD 3 years ago
Fabian Eckermann dd8db1a929 Replaced inet_addr() with inet_pton. 3 years ago
Xavier Arteaga 574683e3ef Fix error message 3 years ago
Fabian Eckermann d59ebfce9d add lock for fftw wisdom 3 years ago
Xavier Arteaga ffba972fb7 Fix gnb amplitude 3 years ago
Xavier Arteaga 51d6ab3b3f Disable CSI-RS resource mapping number of port check 3 years ago
Xavier Arteaga de00b80228 Review NR NSA CFO estimation and compensation 3 years ago
Xavier Arteaga 63bb86bce1 Added SS type conversion to string 3 years ago
Xavier Arteaga 7ba5099bee Implement CSI-RS resource mapping validation 3 years ago
Fabian Eckermann e57ffca722
gnss_sync: fix timestamp to TTI conversion 
* Improve reliability of timestamp to tti conversion

Difftime is not reliable as it might use 32 bit calculation, depending on the system. This leads to wrong frame numbers and subframe indices.
I encountered this Issue when testing the pssch_ue exampel on my system and the conversion from timestamp to frame number and sf idx was wrong.

* Improve GNSS Sync 

Added loop to check for GNSS alignment while syncing.
If the received GNSS signal is weak, synchronization errors might occur while syncing.
 3 years ago
Andre Puschmann 3fd47d2af4 enb: refactor L2/L3 and (re)move all NR components to gNB stack 
* decouple EUTRA and NR stack classes
* implement dummy X2 interface with control and data plane methods
* implement eNB time source interface that PHY calls
 3 years ago
faluco d2f09a8d3c Fix a nasty data race in the ue_bearer_manager class. The underlying std::map member was being accessed concurrently potentially corrupting memory. 3 years ago
faluco d009160ba6 Fix data race in the metrics of the rlc. 3 years ago
Andre Puschmann e563e5918e rf_imp: fail opening RF altogether if specified device fails to open 
we've had a few runs in the CI where opening the specified RF device
failed but the eNB/UE still continued to run, just picking the next available
run. This led to false-positive tests.

The policy should be that whenever the user specified a RF device to
be openend, and this device fails, the whole process should fail and
the application should exit.

The auto-detection mode is still available but only if no device name
is specified at all.
 3 years ago
Andre Puschmann b127327684 enb,s1ap: print filename when writing S1AP PCAP 3 years ago
David Rupprecht e8a464228d Cleaned string helpers 3 years ago
Andre Puschmann cc2d71183e ue,phy,nr: fix race condition when setting UL grant for Msg3 
the Msg3 UL grant requires the TTI in which the RAR has been received
to calcualte the correct timing. There was a race between PHY and Stack
thread.

This patch circumvents the issue by removing a PHY state member that only holds
the RAR Rx timing. In the new interface the RA proc passes the Rx TTI
to the PHY again when setting the UL grant so the PHY can calculate the
correct timing without any state.
 3 years ago
Andre Puschmann ed92f2bd34 enb,mac_nr: remove EUTRA cell param for MAC-NR cell config calls 
* the old srsran_cell_cfg_t is only carried for SIB params
* the SIB scheduling, etc needs to be ported and integrated into NR data structures
* disbable SIB test for the moment
 3 years ago
faluco cf20b143c0 Fix the default constructor of the optional class to avoid a spurious uninitialized value warning in older GCC versions (seen for ARM32 and GCC 8.3). 
Use a union of a byte and the real storage, and init the char by default.
 3 years ago
faluco 485ec2edab Implement a new option to flush the file sink contents on every write. 3 years ago
Nils Fürste d75fe22a0a Soapy: Fix include path of Types.h 3 years ago
Andre Puschmann 06f000c2c4 band_helper: fix format 3 years ago
faluco c7ddedcf72 Log the invalid format string to help grepping it in the logs. 3 years ago
faluco 9571109a69 Abort program execution if STOP_ON_WARNING is defined when formatting an invalid log entry. 3 years ago
faluco 8cde3f20e7 Catch exceptions thrown on invalid format strings in the log backend and print an error message to signal the issue. 3 years ago
Andre Puschmann 07019a5bd6 nr: refactor DL/UL frequency deriviation 
* add separate DL/UL freq point a in NR carrier struct
* use freqInfoDL/freqInfoUL to get freq point a
* simplify carrier tuning logic
 3 years ago
Andre Puschmann 11af5662a7 band_helper_test: extend TC for band 5 FDD freq calcs 3 years ago
Andre Puschmann d26a7e0350 band_helper: add helper to derive DL/UL freq from abs_freq_point 
calculate DL and UL freq in carrier struct based on given values
 3 years ago
Andre Puschmann 377eb52b86 band_helper_test: add TC for band n5 3 years ago
Andre Puschmann 69619d725a band_helper: add helper to derive UL ARFCN from DL ARFCN 3 years ago
Andre Puschmann 93e1d7712d enb,phy: add checks for invalid EARFCN and exit eNB if config is wrong 3 years ago
faluco 5703752faa Fix a enb crash when no more users could be added into the bearer manager map. 
This was caused by not removing old user from the map, so add the code to cleanup the map on user removal.
 3 years ago
Andre Puschmann f382a7c7db Revert "ue,proc_ra_nr: add temporary flag to skip RAR reception" 
This reverts commit 28668aac34.
 3 years ago
Andre Puschmann c1892eb2ec enb,nsa: refactor of SgNB addition interface 
* update of FSM
* better integration of parameter for X2 calls
 3 years ago
Andre Puschmann aba0ba9ad8 mac_sch_pdu_nr: fix newline in logs 3 years ago
Andre Puschmann 54ab64327a ue,mac_nr: move BSR levels lookup table into lib header 
prepare for shared use with gNB
 3 years ago
Andre Puschmann 6745eced49 ssb: avoid NaN when SSB can't be detected 
when PSS+SSS can't be detected the RSRP was 0 and
the resulting conversion to dB resulted in NaN.
 3 years ago
faluco ec272061a0 Fix a dangling SDU pointer in mac_sch_subpdu_nr when adding subpdus into a mac_sch_pdu_nr. 3 years ago
faluco 934802d23c Report the SIB9 home enb name in the enb sector start/sector stop events. 3 years ago
faluco 2fd3ed789a Rename sector_id to carrier_id JSON key in enb metrics and events. 3 years ago
faluco d122d0c69b Add new field for the PCI in the enb JSON report file. 3 years ago
faluco d168536bc4 Add a new program option to control how ASN1 messages get printed into the enb JSON report file. 3 years ago
faluco df6ae7b0e0 - Implement new enb events: 
* ho_command
* connection_resume
* rlf_detected
- Rename rlf_report event to "rlf_report".
 3 years ago
faluco 8a3586dfbf Include a ASN1 json representation for RRC enb events. 3 years ago
David Rupprecht a9a23214b0 Added more 5G security kdfs 
Added new 5G SIM functions

Added const parameters for security functions
 3 years ago
David Rupprecht a645d74eaf USIM functions for res star 
Added gen_res_star in security.h

Added USIM interfaces for res star

Added RES star test case
 3 years ago
David Rupprecht bce6b5cc0f Added kdf common 
Use kdf functions in 5G KDF

Moved EPS KDF function to new KDF structure
 3 years ago
David Rupprecht 15eaef21e2 Update test f12345 function 
Moved XOR functions to lib

Added testcase for KDF

Minor liblte_security updates
 3 years ago
David Rupprecht 0ef8976d53 Remove length from class and pass by reference 3 years ago
Andre Puschmann 88bb92dc0d mac_nr,sched: handle C-RNTI CE 3 years ago
Andre Puschmann f3e8847ad3 mac_pdu_nr_test: fix test 3 years ago
Andre Puschmann 82e9652a92 mac_sch_pdu_nr: fix ASAN/fmt issue when print space 3 years ago
Andre Puschmann ea48a350a4 mac_rar_pdu_nr: fix clearing of padding bytes 3 years ago
Andre Puschmann 02bd15878e mac_sch_pdu_nr: fix logging 3 years ago
Andre Puschmann ede81be5e4 mac_rar_pdu_nr: add packing routines 
* add packing for RAR PDUs
* rewrite to_string() to use fmt lib
* add test case for packer
 3 years ago
Andre Puschmann 20c0e0bc41 mac_sch_pdu_nr: add to_string() helper to format MAC PDUs in logs 3 years ago
Francisco Paisana 227ae97bcb workaround gcc4.8 issue with inability to derive move ctor noexcept specifier 3 years ago
Francisco Paisana ebd12b0778 stack lte,refactor: pass bearer manager instead of stack pointer to srsenb::rrc 3 years ago
Francisco Paisana f4df55c245 stack lte: separate bearer manager into two classes, one for the ue and one for the enb 3 years ago
Francisco Paisana 2ade4628ca stack lte: create an gtpu-pdcp adapter class that correctly converts lcids to eps bearers and vice-versa 3 years ago
Francisco Paisana 4b2f079581 gtpu: renamed lcid to eps_bearer_id as parte of the refactor of gtpu to use eps_bearer_ids 3 years ago
Andre Puschmann 3949a727a7 enb_interface: add stack interface for RRC 
RRC uses the interface to register/deregister EPS bearer
 3 years ago
Andre Puschmann db8b710442 bearer_manager: move to lib folder and extend for multiple users 
prepare bearer manager to be used by eNB which requires
to support multiple RNTIs
 3 years ago
Francisco Paisana 020bec025e sched: created class common to LTE and NR for ue buffer status management 3 years ago
Xavier Arteaga 9e1669c403 Better comments in minimum size symbol selection 3 years ago
Xavier Arteaga 4858202bf6 Fix NR symbol size for 270RB 3 years ago
Xavier Arteaga 14a85d31ec Fix symbol size simensioning for LTE standard rate 3 years ago
Xavier Arteaga 01390a7340 Better NR softbuffer size adjustment 3 years ago
Andre Puschmann 9bf74843f6 mac_pdu_nr: add error handling to init_tx() method 
check provided byte_buffer and return error if it's not valid
 3 years ago
Francisco Paisana 04e5c81edf sched,nr: nr_phy_test now uses the whole mac class rather than just the scheduler 3 years ago
Francisco Paisana b486d2a1b5 sched,nr: implement prb grant fmt formatting 3 years ago
Francisco Paisana da4b7e4f80 sched,nr: fix sched RAR NR test; update test assert macros 3 years ago
Xavier Arteaga 83b9b2d1ff Implemented UE open loop CFO compensation for NR 3 years ago
Xavier Arteaga 5aa2279990 Fix NZP-CSI-RS CFO sign 3 years ago
Xavier Arteaga 7da2d20447 Added UE UL NR frequency offset option 3 years ago
Xavier Arteaga cfe2b305a1 Fix CORESET0 related PDSCH resource allocation procedure 3 years ago
Xavier Arteaga 36207db615 Added CORESET start_rb helper function 3 years ago
Xavier Arteaga 89ef3b64b4 Optimization NR PDCCH mapping minor optimization 3 years ago
Xavier Arteaga ae0d8f83f0 Add PDCCH interleaved mapping in phy_dl_nr_test and iterate all possible 15kHz SCS bandwidths 3 years ago
Xavier Arteaga 9c3dd56398 Added PDCCH DMRS interleaved mapping 3 years ago
Xavier Arteaga f5f18054eb Added PDCCH NR interleaved mapping 3 years ago
Xavier Arteaga d61d6aa59f Integrated CORESET0 into UE's RRC 3 years ago
Xavier Arteaga e07263ee26 Added band helper for getting band from ARFCN 3 years ago
Xavier Arteaga 7377496417 Added SCS to string and corrected coreset0 3 years ago
Xavier Arteaga 62ba7d386d Initial CORESET Zero constructor 3 years ago
Xavier Arteaga 5d149a4b78 Moved NR time/frequency allocation SLIV to new component 3 years ago
Francisco Paisana 36eee0ab40 test,nr: add ra_search_space configuration to phy_cfg_nr; now the test ue searches for RA-RNTI while expecting a RAR 3 years ago
Francisco Paisana 2668a8f68b sched,nr: fix Msg3 decoding in PHY to not expect any UCI 3 years ago
Xavier Arteaga 2cd5e98132 Fix NULL check in DCI NR for RAR type 3 years ago
Xavier Arteaga 3784359da5 Use NR DCI format 0_0 packing and unpacking for TC-RNTI type 3 years ago
Xavier Arteaga b846116c5c Added NR RAR UL DCI packing 3 years ago
Francisco Paisana 55d83a1279 fix compilation issue due to wrong include path for srsran_assert.h file 3 years ago
Francisco Paisana f518861ebc fix location of support/ folder. Created macros for ASSERT_EQ and ASSERT_NEQ 3 years ago
Francisco Paisana 599fc978a5 improvement of srsran_assert design, with specializations to enable/disable assertions based on compile flags other than ASSERTS_ENABLED. Creation of the support/ folder 3 years ago
Francisco Paisana e896ac49e8 adt: create split optional span view to be used for C-array types 3 years ago
Francisco Paisana d616e46936 adt: allow choice between static and dynamic optional vector types 3 years ago
Francisco Paisana 1596fcf349 adt: rename optional table to optional array 3 years ago
Francisco Paisana 8c24cfebd3 adt: create data structure type to represent an array of optional fields 3 years ago
Francisco Paisana eb4999a18e lte,pdcp: silence error message when a reconfiguration of a PDCP entity is no-op 3 years ago
Andre Puschmann 32ab1baeb1 enb,rrc: during NSA activation, remove EUTRA DRB and set MAC logical channel config 3 years ago
Andre Puschmann 9e7852ac83 srsran_asn1_nr: add RLC config to packing test 3 years ago
Andre Puschmann 1c3a03cb2b rlc: fix memleak in queue_rx_pdu 
* alternative to #3141
* use byte_buffer as queue element
 3 years ago
Andre Puschmann c365c16531 gnb_interfaces: inherit from EUTRA interfaces when they are identical 3 years ago
Andre Puschmann 4076338a1b enb: add MAC-NR PCAP 
* use fixed filename until eNB stack layout is decided
 3 years ago
Andre Puschmann c03623863b enb,nsa: fix UL PDU processing 
* remove const from pusch_info() MAC/PHY interface to allow moving unique byte buffer
 3 years ago
Andre Puschmann fc35c0ee51 enb,nsa: fix packing of DL MAC PDUs 
* use byte_buffer_t as interface type for DL PHY-MAC interface
* fix missing clear() for new DL tx
 3 years ago
Andre Puschmann 4a828be39f rlc_am_test: fix reestablishment test 
after changing the retx counting we receive one SDU more than before
 3 years ago
Andre Puschmann 7726acad41 rlc_am_lte: fix counting of retx of entire PDUs and PDU segments 
this patch fixes a bug discovered in a real network where the DL CQI of a
user degraded repidly in very short time. A relativly big RLC PDU that
was still sent with the good CQI in a big grant now needs to be split
across many tiny segments because the CQI degraded so much.

The retx couting for each transmitted segment caused the retx counter to
reach maxRetx quickly.

With this patch we do not increment the retx counter for each transmitted
PDU or segment of a PDU but instead only increment the counter when
a given SN is added to the retx queue. This can happen either:
a) if the SN is negativly acknowledged and was not already on the retx queue,
b) no new data is available for tx and a SN is selected for retx.

This is in accordance with TS 36.322 which handles retx counting in section
5.2.1 according to the above description.
 3 years ago
Xavier Arteaga cba6df3722 Extended NR PHY robustnes against wrong RRC configuration 3 years ago
Xavier Arteaga de89e829e7 Added NR PUCCH Resource ASN1 helper 3 years ago
Xavier Arteaga 3ae131b336 gNb creates PUSCH decode PDU 3 years ago
Xavier Arteaga 98f29961bc Fix old GCC compilation 3 years ago
Xavier Arteaga 856573b92f Added 4096 symbol size as LTE rate 3 years ago
Xavier Arteaga 54e1fe172c Minor NR PHY aesthetical modifications 3 years ago
Xavier Arteaga 956c4f8266 Added PHY NR test TDD FR1.15-1 pattern 3 years ago
Xavier Arteaga dfa323df6b Added 20MHz default configuration 3 years ago
Xavier Arteaga ea802c23f2 Remove PHY lib verbose from test and use byte vector random function 3 years ago
Xavier Arteaga 1b50758bd5 Initial NZP-CSI default configuration from TS38.101-4 3 years ago
Andre Puschmann 28668aac34 ue,proc_ra_nr: add temporary flag to skip RAR reception 
this will be removed again as soon as the eNB supports full RAR
transmission.
 3 years ago
Andre Puschmann 3b5344b0f7 thread_pool: add optional ID to thread pool 
this allows to prepend an ID to each thread pool to
better differentiate workers from different pools
 3 years ago
Andre Puschmann 38f1e158a5 enb,nr: fix NR PHY PRACH init and MAC-PHY interaction 3 years ago
Xavier Arteaga a300a47673 Fix value selector for NEON 3 years ago
Xavier Arteaga 42b052112f Added TS reference and use SRSRAN_CEI_LOG2 macro 3 years ago
Xavier Arteaga 1f495cb008 Added generic SRSRAN_CEIL_LOG2 3 years ago
Andre Puschmann b6f8280f67 cqi: protect potential div by zero bug 3 years ago
Andre Puschmann b388930325 srsran_asn1_rrc_nr_test: disable PCAP output by default 3 years ago
David Rupprecht 11f9ac75db Added PLMN to serving network string name 3 years ago
Xavier Arteaga 085e247ece Fix ZMQ TX channel mapping for NULL pointers 
Fix ZMQ transmit frequency mapping

Use map mask in ZMQ to determine mapped channels

Fix ZMQ mapping
 3 years ago
Xavier Arteaga 562fd1b4d4 Fix segfault 3 years ago
Xavier Arteaga dbb10dd6a2 Hold worker thread until baseband is transmitted 3 years ago
Xavier Arteaga 0c7239e5df SRSUE: add RF channel offset 3 years ago
Xavier Arteaga b57df4db10 Refactored worker_end mechanism for concurrent workers 3 years ago
Andre Puschmann e833751031 rrc_nr: add CSI config packing 3 years ago
Andre Puschmann f181733c7e rrc_nr,enb: add more fields to spcell cfg dedicated 3 years ago
Andre Puschmann 4915dc9642 test_pcap: add function description 3 years ago
Francisco Paisana bd08a64b5e sched: fix crash for 100 prbs and subband CQI reporting 3 years ago
Andre Puschmann 45c1971249 mac,phy,interface: clean up and add NR interface to LTE stack 
* remove obsolte rx_data_ind
* add mac_phy_interface_nr to LTE stack
 3 years ago
David Rupprecht 04ef6e120d Added new SIM functions to get MCC, MNC and MSIN 3 years ago
Bedran Karakoc a6226379b4 Introducing NGAP UE context procedures 3 years ago
Ismael Gomez a896e32cf4 Refactor sub-band CQI processing 3 years ago
Ismael Gomez 9b10e1c45d Fix sub-band CQI in UE. Refactor variable names 3 years ago
Francisco Paisana 12e33483e1 sched,nr: add slot_point to sched nr 3 years ago
Francisco Paisana a0a1af9d0f nr: slot value that handles wrapping around 3 years ago
Andre Puschmann a7eb9b471b pssch_file_test: relax test result check 
the file test sometimes decodes 2 and sometimes 3 (less often) SCI.
its not entirly clear why it's different though.

this "fixes" #3088
 3 years ago
Xavier Arteaga ca5ea369f5 Extended ue_dl_nr_file test 3 years ago
Xavier Arteaga 914a2e2d31 Add SCH NR softbuffer check 3 years ago
Xavier Arteaga b59c330858 Fix filesource include 3 years ago
Xavier Arteaga 858fc2c0fc Cleanup include 3 years ago
Xavier Arteaga 5a6b8f42f5 Add standard rate check for FFT minimum size function 3 years ago
Xavier Arteaga 98929c95a8 Initial UE DL NR file test 3 years ago
Xavier Arteaga dcf9ae039c Fix related Sidekiq comments and mutex 3 years ago
Xavier Arteaga b3d9a94dd5 SIDEKIQ: fix tx time protection 3 years ago
Xavier Arteaga ecf668ee9e SIDEKIQ: fix comment 3 years ago
Xavier Arteaga 96ee4b7258 SIDEKIQ: Initial implementation 
SIDEKIQ: Add SKIQ_FOUND to RF found condition

SIDEKIQ: finished SKIQ component abstraction

SIDEKIQ: fix issues and added external PPS example

SIDEKIQ: add PPS test card index argument

SIDEKIQ: improvements

SIDEKIQ: improved srate change

SIDEKIQ: more improvements

SIDEKIQ: more fixes

SIDEKIQ: fix Rx ch gain

SIDEKIQ: Fix multi-card synchronism

SIDEKIQ: Better Rx gain tracking
 3 years ago
Robert Falkenberg 24e52d6291 soapy: fix array parameter mismatch for some functions 
With soapy 0.8.0, GCC 11.1.0 warns of mismatched array bounds
in some functions.
This commit aligns the bound and adds proper wrappers to
fix subsequent warnings.
 3 years ago
Francisco Paisana bc5a548fe8 sched: scheduler now accounts for prachs with different durations 3 years ago
Xavier Arteaga bb4f469794 Integrated SR decoder in gNb 3 years ago
Xavier Arteaga 6a9baef11d Limit DMRS PUCCH SNR to void NAN/INF 3 years ago
Xavier Arteaga d783fbf3a0 Reviewed NR procedure for PUCCH resource sselection and reviewed gNb PUCCH interface 3 years ago
Xavier Arteaga 64f4767c4f Fix NR PUCCH decoder memory access 3 years ago
Andre Puschmann 60a795acc0 asn1,rrc_nr,test: extend RRC reconf test, add PCAP output 
test now can write the NR reconfig into a PCAP for easy
debugging with Wireshark

patch also adds a new test helper to write a RRC PDU
into a PCAP file (helper packs PDCP and RLC AM first)
 3 years ago
Andre Puschmann c9c3a68fae asn1,rrc_nr: add error code handling to packing/unpacking of pdcch_cfg 3 years ago
Ismael Gomez 6fb9b6bf94 Fix sub-band CQI in UE. Refactor variable names 3 years ago
Francisco Paisana 74d0a8adb8 sched: add subband cqi info interface to LTE scheduler 4 years ago
Ismael Gomez 2e1127f385 Add sub-band CQI periodicity and configuration to lib 4 years ago
Ismael Gomez 3f5094f30e Remove confusing subband_size variable and replace with subband_wideband_ratio 4 years ago
Andre Puschmann a142192d4e test_common: handle return value from make_byte_buffer() 4 years ago
Andre Puschmann 8d2e81ad6f enb,mac,nr: add basic UE object skeleton 
refactor that also adds a basic UE object to the NR MAC
 4 years ago
David Rupprecht 0217bf5332 Fixed name space for rrc ue 4 years ago
Francisco Paisana 09c7000201 sched,nr: update nr scheduler to use new mac nr interface types 4 years ago
Francisco Paisana d9336bcd9e sched,nr: creation of pool of softbuffers for NR. Now the sched NR harq manages the lifetime of the softbuffer and its forwarding to the PHY 4 years ago
Francisco Paisana 1535e6b205 sched,nr: extend sched nr testing suite. restrict paralllelization for correct DAI generation 4 years ago
faluco b79481f74b - Fix text formatter unit test for printing the date. 4 years ago
Francisco 357bc10a17 feature - make minimum SNR, under which the RRC is notified with UL KO, configurable 4 years ago
faluco 8708043a5f - Add date to log timestamps. 
- Print once per second the current timestamp into stdout, feature guarded by a config expert option.
 4 years ago
Francisco 67325ab5c1 add pdcch_cqi_offset parameter to enb.conf 4 years ago
Francisco 2a31daca4a enb,configuration: allow to specify enb specific max nof RLC retxs 4 years ago
Andre Puschmann b5b2f8190e signal_handler: use std::atomic for running var 4 years ago
Andre Puschmann ff5fe5df14 rf_uhd_imp: fix race in RF metrics 4 years ago
Pedro Alvarez 8d41c0d476 Maded SRB configuration optional in rb.conf 4 years ago
David Rupprecht d990db66f6 Added syslog logger 4 years ago
faluco 7b7ecb7983 Add a new configuration option that controls PDSCH baseband sample dump to a file on KO. 4 years ago
Xavier Arteaga b25681f9de gnb,prach: add PRACH to gNB 
rebase of Xavier's feature_gnb_prach branch
 4 years ago
David Rupprecht fb92118bb7 Add 5G NAS infrastructure 4 years ago
David Rupprecht e0b09f1301 Fixed coverity findings 4 years ago
David Rupprecht 709b706d07 Fix 5G NAS extended protocol discriminator 4 years ago
Andre Puschmann 6c82d63aa6 remove legacy PNF/VNF code 
the code hasn't been maintained for a while an likely needs to be
adapted for a real-world scenarios.

in order to avoid having to maintain two MAC/PHY interfaces we
remove the code from now.
 4 years ago
Xavier Arteaga 54a12870ec SRSUE: avoid negative SR transmission in NR 4 years ago
Xavier Arteaga 603c67e36d Set g_ulsch LLR overlaped with g_harq_ack to zero 4 years ago
Xavier Arteaga 3416aad16d Fix PUSCH NR test false alarm 4 years ago
Xavier Arteaga 04aca98e5f Added more checks in PUSCH NR test 4 years ago
Xavier Arteaga ef865b81a3 NR SCH TB information prints actual rate and not the target rate 4 years ago
Xavier Arteaga 11a52248cd RA NR Calculates actual PUSCH rate 4 years ago
Xavier Arteaga 35840d6bc1 Removed all zero condition from LDPC decoding 4 years ago
Xavier Arteaga 64b7dfed65 UHD: fix nullptr buffer 4 years ago
Xavier Arteaga ecc0b92142 Integrated PUSCH decoder in gNb 4 years ago
Xavier Arteaga f07d925be1 Initial NR PHY test scheduling for PUSCH 4 years ago
Andre Puschmann 654afac9c7 nas_5g_msg_test: remove copy_msg_to_buffer() that is now in test_common.h 4 years ago
David Rupprecht 724af2b060 Added nas 5g msg packing and unpacking 4 years ago
Andre Puschmann e330f50ef8 rrc_meas_test: add packing test for measObjectNR 4 years ago
Andre Puschmann a2dd83a7e9 asn1: rename RRC NR test to avoid confusion with component test 4 years ago
Andre Puschmann fd7b9a0575 enb,nsa: add basic RRC EUTRA<>RRC NR interface for SgNB addition 4 years ago
Andre Puschmann 6bf3feda92 rrc_nr_test: add packing test for NR radio bearer config 
also add (still incomplete) secondary cell group config pack test
 4 years ago
Andre Puschmann c9e87b2cf3 config_file: print message when config file couldn't be read 
this prints an message on stdout so config files are not
simply skipped and the default one is read instead.
 4 years ago
Andre Puschmann fa461f0129 rrc_nr: fix linker error in setup_release_c 
move implementation to cc file to avoid

[build] /bin/ld: CMakeFiles/rrc_nr_asn1_test.dir/rrc_nr_test.cc.o: in function `asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::set_setup()':
[build] /home/anpu/src/srsLTE/lib/include/srsran/asn1/rrc_nr.h:2276: undefined reference to `asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::set(asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::types_opts::options)'
[build] clang: error: linker command failed with exit code 1 (use -v to see invocation)
 4 years ago
Andre Puschmann 4379c20eb9 rlc_am_lte: avoid locking of Rx mutex twice when generating status PDU 
call reset_status(), which now is an private method directly when
building a status PDU. No need for the Tx side to call Rx again.
 4 years ago
Andre Puschmann 53a7dc78ee rlc_am_lte: replace do_status boolean with atomic 
the do_status is queried from the Tx code frequently. To reduce
chances to delay the execution because the RLC Rx side is currently
holding the mutex we can use an atomic.
 4 years ago
Xavier Arteaga 5307fec2f0 Added GNB MAC UL info initial interface and fix PHY implementation 4 years ago
Xavier Arteaga cf496e75eb Fix default PHY NR configuration 4 years ago
Xavier Arteaga 2fbd172888 Initial PHY NR configuration generator 4 years ago
Xavier Arteaga 320aabec13 Initial PHY NR configuration 4 years ago
Xavier Arteaga e764a26136 Integrated PUCCH decoding in gNb 4 years ago
Xavier Arteaga 3fe9176750 Added PUCCH dedocder to slot worker 4 years ago
Xavier Arteaga e3afd945bc Refactored NR HARQ ACK feedback 4 years ago
Xavier Arteaga 658b47d917 Added NR PUSCH and PUCCH decoder in gnb_ul 4 years ago
Xavier Arteaga 89994cd5a8 change ERROR macro format to be parsed by IDE 4 years ago
Xavier Arteaga f6fc215541 Refactored enb_dl_nr to gnb_dl and initial gnb_ul 4 years ago
Xavier Arteaga eecaccb541 Added NR PHY helpers 4 years ago
Andre Puschmann 6372f89c09 s1ap_test: fix compilation on 32bit 4 years ago
Andre Puschmann f292042f66 rlc_am_lte: use try-lock when building status PDU 
the patch uses try-lock whenever a status PDU is tried
to be built. This makes sure that when the lock is currently
hold (e.g. by a thread processing rx PDUs) the generation
of the status PDUs is not taking too long and blocking the calling
thread. Instead the status PDU generation is deferred to the next
Tx opportunity.

It's a probabilistic approach that assumes that at some stage the
lock can in fact be acquired.
 4 years ago
Andre Puschmann a9d21696c5 rlc_am_lte: make number of RLC SDUs per PDU a compile-time parameter 
this allows to set the maximum number of RLC SDUs included
in a single PDU at compile time.
 4 years ago
David Rupprecht f90e359208 Moved cp to test common 4 years ago
Andre Puschmann bbcaa49429 network_utils: fix TSAN detected race 4 years ago
Andre Puschmann a9ad408f51 task_scheduler: use block_queue for internal tasks 
TSAN detected wrong use of the old deque-based internal queue. To avoid
unwanted/undetected mis-use the patch uses the thread-safe block_queue
data structure instead.
 4 years ago
Andre Puschmann 626f24c9f9 block_queue: use class mutex to protect size() getter 
detected with TSAN
 4 years ago
Andre Puschmann 0e6e3d201e sys_metrics: reduce log level when measurement interval is shorter than expected 
on highly loaded systems it can happen that the get_metrics() is called
twice within a few houndred milliseconds. Logging a warning in this
case isn't needed, so reduce to info.

on the other hand, 100ms might be to convervative. Patch also
lowers the smallest interval to 10ms
 4 years ago
Ismael Gomez 4e39982a19
Fix TSAN warnings in UE (#3021) 
* Protect PHY SR signal management in a class

* Protect intra_freq_meas vector

* Protect cell and srate shared variables in thread-safe classes

* srsue,srsenb: include TSAN options header

* Protect ue_rnti_t and rnti scheduling windows behind thread-safe classes

* Protect access to state variable in sync_state

* Protect access to metrics configuration

* Protect access to is_pending_sr

* Protect access to UE prach worker

* Protect UE mux

* Avoid unlocking mutex twice

* Fix data races in RF/ZMQ

* Fix data races in intra_measure and PHY

* Fix minor data races in MAC

* Make TSAN default behaviour to not halt on error

* Fix blocking in intra cell measurement

* Address comments

Co-authored-by: Andre Puschmann <andre@softwareradiosystems.com>
 4 years ago
David Rupprecht 4ed33fed7d Fixed unpack bytes limit 4 years ago
Pedro Alvarez 05fbca43d1 Fix GCC 11 warning in dyn_array 4 years ago
Pedro Alvarez 1b676aa406 Moved lib GTPU to its own folder 4 years ago
Pedro Alvarez 865298f8d5 Moved lib PDCP to its own folder 4 years ago
Pedro Alvarez 171d5727be Moved lib RLC into it's own folder 4 years ago
Francisco Paisana 4d014e7ceb s1ap,feature: make the ts1 reloc timers configurable via the enb.conf 4 years ago
Andre Puschmann b6a3b8c5b1 rlc: fix dtor 
TSAN was complaining about destroying a locked mutex
 4 years ago
faluco a70ad58440 Fix a data race in the UHD class wrapper where the last error member was being set concurrently causing random crashes. 
Introduce a new macro to catch UHD exceptions and log them directly instead of storing an error string, similar to what errno does.

Remove usrp logging helpers that depend on the now removed member since all calls potentially log the error directly.
 4 years ago
Andre Puschmann 4d11e5552a rrc,ue: for RRC conn release, delay transition to RRC idle by 60ms as per TS 36.331 
when receiving RRC connection release all actions shall be delayed by 60ms as
per the standard
 4 years ago
Andre Puschmann 368c7b9e4f ue,stack: clear all EPS bearers when going RRC idle 
the EPS bearer manager was only informed when a single DRB
was removed but not when entering idle which requires to
remove all bearers.

This cause the service request to fail.
 4 years ago
faluco e20934583e Remove an unsafe assert in the log backend that could be triggered under very certain circumstances. 
RFCI has detected this assert failing in the log_backend_test. I have not been able to reproduce this locally but my theory is the following one:
one of the unit tests does the following:

backend.start();
backend.stop();

the internal running_flag member could be set to true and then to false by the main thread before the worker thread calls do_work(). If this happens
the assert will be triggered, which is wrong and too conservative, so remove the assert.
 4 years ago
Xavier Arteaga 6f5614a0cc Suggested modifications on gNb MAC/PHY interface 4 years ago
Xavier Arteaga 8378c85ec4 Refactored gNb PHY 4 years ago
Xavier Arteaga aef3e5a40a More NR PHY test and GNB PHY development 4 years ago
Xavier Arteaga 9126ad3b8b Added NR type1 RIV function helper 4 years ago
Xavier Arteaga d49734b1bc SRSENB: Refactor to accomodate 5G NR 4 years ago
Xavier Arteaga e98a6f9eea Make ACK M constant i UEDLNR 4 years ago
Xavier Arteaga 567c7c9c77 Create TTI semaphpore default constructor 4 years ago
Andre Puschmann 483a216bd5 ue,stack: refactor handling of radio bearears in UE stack 
this is a rather large commit that is hard to split because
it touches quite a few components.

It's a preparation patch for adding NR split bearers in the next
step.

We realized that managing RLC and PDCP bearers for both NR and LTE
in the same entity doesn't work. This is because we use the LCID
as a key for all accesses. With NR dual connectivity however we
can have the same LCID active at the same time for both LTE and NR
carriers.

The patch solves that by creating a dedicated NR instance for RLC/PDCP
in the stack. But then the question arises for UL traffic on, e.g. LCID 4
what PDCP instance the GW should use for pushing SDUs. It doesnt' know
that. And in fact it doesn't need to. It just needs to know EPS
bearer IDs. So the next change was to remove the knowledge of what
LCIDs are from the GW. Make is agnostic and only work on EPS bearer IDs.

The handling and mapping between EPS bearer IDs and LCIDs for LTE
or NR (mainly PDCP for pushing data) is done in the Stack because
it has access to both.

The NAS also has a EPS bearer map but only knows about default and
dedicated bearers. It doesn't know on which logical channels they
are transmitted.
 4 years ago
Andre Puschmann a4b2a065ff pdcp: reword warning when dropping PDU 4 years ago
Andre Puschmann 7113e55d53 rlc: refactor RLC entity to use smart pointers for holding bearers 
this patch mainly modernizes the bearer creation to use smart pointers.
that allows to simplify the error handling.

ue_stack is changed to match new interface. This commit compiles
but doesn't work.
 4 years ago
David Rupprecht 6d5391756c Refactor build of RLC NR config 4 years ago
David Rupprecht d1d8500ce5 Add testcase for reconfiguration 4 years ago
David Rupprecht ec19919246 Fix NGAP valgrind test 4 years ago
Xavier Arteaga eb7980f2b3 Initial UE synchronization for NR 4 years ago
Pedro Alvarez 4d13906760 Increase logging level of MAC mismatches to warning in PDCP 4 years ago
Andre Puschmann e1fb58d76e rlc_um: reduce log level for message handling lost PDUs 
when a lost PDU is detected a warning will be logged. In theory
this could be info as well but a warning may help to detect issues
in tests. The same event causes multiple other warnings to be logged,
which is very spammy. The patch reduces the log level for
those messages to info.
 4 years ago
Pedro Alvarez aae266e848 Added configuration option for S1AP SCTP bind port 4 years ago
David Rupprecht 85d7a851fb Added 5G NAS PCAP support 4 years ago
Francisco 78acf81cf0 bugfix,sched: avoid instability in TPCs around PHR~0 4 years ago
Xavier Arteaga b1e4720721 SRSUE/SRSENB: added tx_enable flag in worker_end 4 years ago
Xavier Arteaga 027201d457 SRSUE/SRSENB: Refactor NR workers to generalise lower PHY 4 years ago
Andre Puschmann 83bf5dcd49 rlc_am_lte: reduce time holding Tx mutex when processing status PDUs 
the patch is a re-implementation of the customer-specific optimization
we did in order to reduce the time the RLC holds the Tx mutex when
processing an incoming status PDU.

The patch makes sure to never operate on a raw mutex but instead
uses the deadlock-avoiding RAII lock.
 4 years ago
Ismael Gomez 5aa5a8e997 Revert UE changes 4 years ago
Ismael Gomez e35a0d72fa Revert UE changes 4 years ago
Ismael Gomez dd9889e07c Add carrier index to uplink PCAP captures 4 years ago
Bedran Karakoc c280ac5ad6 Introducing extended NGAP functionality 
Remove unused logger for now in ngap::ue to pass tests
 4 years ago
Francisco 5a82a63bb5 bugfix,srsenb: fix intraenb handover softbuffer allocation during handover 4 years ago
Xavier Arteaga cf09044453 Optimised random bit (unpacked) and byte (packed) generator 4 years ago
Xavier Arteaga d2a19c3043 SCH minimum number of iterations to 2 to reduce systematic false alarm probability 4 years ago
Xavier Arteaga ef4c978d72 Optimized byte random generator 4 years ago
Andre Puschmann 475c033440 rlc_am_test: extend status PDU test 
add full test with malformed status PDU
 4 years ago
Andre Puschmann d7204df896 rlc_am_lte: check rx window first when receiving status PDU 
move rx window check up so no actions are taken when receiving
malformed status PDU
 4 years ago
Xavier Arteaga 2cd8ba3a1a PDCCH test skips 100PRB for ARM 4 years ago
Francisco 2a009eb340 sched,feature: Enable configuring maximum coderate for SIB allocations 4 years ago
Francisco 6ababf401b feature,sched: allow setting initial DL CQI in enb.conf 4 years ago
Francisco e8983b88f0 refactor: use enb_cc_idx instead of ue_cc_idx in mac::ue 4 years ago
Andre Puschmann fa7a8fb687 rlc_am_test: add testcase for processing out-of-order status PDUs 4 years ago
Andre Puschmann 19f30aa652 rlc_am_lte: fix handling of out-of-order status PDUs 
before processing incoming status PDUs we should be checking
if the ACK_SN falls within our current Tx window. If not the PDU
will be dropped.

Without the check we were incorrectly processing the status PDU
and because the sequence number wrap around wasn't working
correctly if ACK_SN is smaller than vt_a we were corrupting
our Tx window.
 4 years ago
Xavier Arteaga 8743713bb1 Fix compilation 4 years ago
Xavier Arteaga 676080d6af Added macro SRSRAN_VEC_SAFE_CMA 4 years ago
Andre Puschmann b862bbc2e6 rlc_am_lte: add missing mutex to get_status getter 
fixws race detected with TSAN
 4 years ago
Andre Puschmann d51ee722f6 rlc_am_test: add unit test for ACK_SN is outside rx window 
the test uses a malformed status PDU from a PCAP and makes
sure the RLC receiver detects such a PDU and raises a warning
 4 years ago
Andre Puschmann 878142843e rlc_am_lte: add further sanity check when creating status PDU 
the test verifies that the ACK_SN of a status PDU falls inside the
rx_window of the receiver. If not, than the RLC state has been
corrupted and the status PDU is likely invalid.
 4 years ago
Andre Puschmann 46265c5829 rlc_am_data_test: add data PDU unpack test 
TV captured in PCAP
 4 years ago
Andre Puschmann b379910690 pdu_test: add UL-SCH unpacking test 
TV captured in PCAPs.
 4 years ago
Xavier Arteaga 6be57dd216 Disable PDCCH false detection for non AVX2 machines 4 years ago
Alejandro Leal Conejos a51f2a1de4 Fills the value of the number of cpus for the system_metrics_t and 
initiliaze its value to 0 when executing 2 measures in less than 100 ms.
 4 years ago
Pedro Alvarez a53b321ab8 Release UE upon reception of integrity error. 4 years ago
Pedro Alvarez 299d2ee35d Added interface to make the PDCP notify the RRC of integrity check 
failures.
 4 years ago
Xavier Arteaga 939dd1b977 Change struct sync_raster_t to class 4 years ago
Xavier Arteaga a79d518799 Added SSB search measure/decode file test 4 years ago
Xavier Arteaga 5181a9d64c Implemented PBCH blind decode 4 years ago
Xavier Arteaga a7b7f8e78a Avoid SSB search to have a peak that SSB data is outside buffer 4 years ago
Xavier Arteaga 480f1b14fe Protect Radio from null phy 4 years ago
Xavier Arteaga 9621cf57c2 Implemented NR SS raster object 4 years ago