4666 Commits (a2174a57142fb7416856977a021260c4a9a33315)

Author SHA1 Message Date
Xavier Arteaga e68c822505 NR Added CSI measurement channel processing 4 years ago
Xavier Arteaga c51ff0c9f9 Added safe exponential moving average filter 4 years ago
Francisco c5396155ad set default gtpu tunnel close timeout to infinity 4 years ago
Francisco 15484e9472 rrc - make t304 configurable via rr.conf 4 years ago
Francisco c6b9c12ba2 gtpu, feature - added the ability to configure gtpu indirect tunnel timeout value. This parameter is useful in the case that the end marker is not received 4 years ago
Francisco cd51537234 add comment explaining the use case of cached_alloc 4 years ago
Francisco 28847badcf implementation of custom allocator for memory caching. This allocator may be used for unbounded queues 4 years ago
David Rupprecht c117b563c9 Initial commit for ngap in enb 4 years ago
Francisco 7bee75e126 update description of srsenb --expert.nof_prealloc_ues config parameter, and added a comment in header file explaining the use of such parameter. 4 years ago
Francisco 5818488b27 change enb max_nof_ues config parameter to nof_prealloc_ues 4 years ago
Xavier Arteaga de9158eeaf Enable NR RRC MCS table selection 4 years ago
Xavier Arteaga eef3fac863 Improved float XOR readability 4 years ago
Xavier Arteaga 751b6858b3 Added CSI-RS resource set measurements 4 years ago
Xavier Arteaga 3b919b4f6c Minor aestheics change 4 years ago
Xavier Arteaga 243ad05dfa Added on the fly sequence apply in float 4 years ago
faluco aef18f9931 Implement a benchmark for measuring latency in the foreground threads when pushing log entries.
This benchmark runs with several threads to test contention.
4 years ago
Francisco 01eace2631 rrc paging mechanism improvements
- moved paging record handling to separate class
- parallel access to pending pcch messages by phy workers based on TTI and without common lock
- asn1 pcch message packing now takes place in stack thread, to avoid real-time issues
4 years ago
Xavier Arteaga 318f064ff4 Multiple NR SCH fixes 4 years ago
Xavier Arteaga b8e0164f7f Multiple fix NR PHY procedures 4 years ago
Xavier Arteaga a8e181971c Refactored PHY NR procedures for supporting DCI formats 0_1 and 1_1 4 years ago
Andre Puschmann bbea3dd6a1 byte_buffer: fix compilation when buffer pool log is enabled 4 years ago
Francisco 5cecb40410 rlc,bugfix - increase pdcp sn notification ack list maximum size 4 years ago
Francisco ad1a0eb2ac rlc,fix - Add PDCP PDUs to undelivered_sdu_info_queue when the PDUs are popped from the tx_sdu_queue, rather than they are pushed to.
- This simplifies the sdu discard
- This also fixes an existing race condition
4 years ago
Andre Puschmann 598594c51a all: bunch of pass by const& changes suggested by LGTM 4 years ago
Francisco 7ced0e73eb rlc,bugfix - avoid accessing the PDCP info of RLC segments when the PDCP has already discarded the respective PDCP SN. 4 years ago
Andre Puschmann 597729ac53 rlc: always remove PDCP SNs from undelivered queue
if RLC PDUs with certain PDCP SNs were already in flight
when their discard timer at PDCP expires, they weren't
remove from the undelivered_sdu_info_queue causing
indesired log entries like:

08:08:52.455280 [RLC    ] [W] PDCP_SN=2103 already marked as undelivered

when the SN was sent again (after wrap around).

The patch makes sure to always try to delete the PDCP SN
from the queue. It should fix (at least partly) #2560
4 years ago
Andre Puschmann 20075f6f33 rf_uhd_generic: fix segfault when accessing device tree
for some reasons the dev tree isn't available on the X310
with UHD4 and the code never checked the return value, causing
a segfault with that combo.
4 years ago
Xavier Arteaga 949ce965c7 Fix SCH NR CRC check 4 years ago
Xavier Arteaga fb5dfb3a86 Improved NR unit test 4 years ago
Xavier Arteaga 28170c92a9 Multiple NR SCH fixes 4 years ago
Xavier Arteaga efb8da69d8 Cleaned DCI NR info string 4 years ago
Xavier Arteaga 8cb3e92ab3 Added LDPC flooded early stop 4 years ago
Xavier Arteaga 033661182a Aded SF len macro for NR 4 years ago
Xavier Arteaga 6c39a5e4ff Added PDSCH DMRS aditional unpacking 4 years ago
Xavier Arteaga 334b308c35 Fix DCI NR configuration from main configuration 4 years ago
Xavier Arteaga 86ad0446e1 Added NR PDSCH and PUSCH resource allocating flattening 4 years ago
Xavier Arteaga 892aea8219 Fix coverity warnings under lib/src/phy/utils 4 years ago
Xavier Arteaga 87cf3cf2e5 Fix coverity warnings under lib/src/phy/phch 4 years ago
Francisco 3f64b94a0f increase asn1 variable length field intermediate buffer, to support longer UE Radio Capabilities messages 4 years ago
David Rupprecht bde30bb9be Added tests for band helper 4 years ago
Andre Puschmann 937c4ff3c3 demod_soft: removed unused NEON code
clang complained about unused code, so remove it of course.
4 years ago
Xavier Arteaga 71226e89df Minor dereference check 4 years ago
Xavier Arteaga b6fa82bf9a Fix more static analysis warnings 4 years ago
Xavier Arteaga 290541993e Fix debug compilation 4 years ago
Xavier Arteaga efd6c569b8 Fix some static analisys warnings under lib/src/phy/fec 4 years ago
David Rupprecht fafa03f7c8 Extended the band helper table 4 years ago
Francisco 3c4512cdd2 demote assert to expect check in circular stack pool destruction, when a leak is detected 4 years ago
Xavier Arteaga 217f3cb416 SRSENB: select highest with/without SR correlation PUCCH result 4 years ago
Andre Puschmann ada6c71b5a rf_soapy: fix logic to print warning when Lime is used with short sample rates
previously the warning was printed when a Lime was connected to the PC.
Now all connected devices are printed but the warning is only
shown if the selected device is the Lime.
4 years ago
faluco aa3309157b Fixed polar encoder and decoder initialization failure for ARM. Initialization unconditionally used x86 SIMD routines instead of getting disabled for ARM compilations. 4 years ago
faluco d9e5f4ccc7 Replace a couple of inline functions in demod_soft with macros to allow constant propagation. The vgetq_lane_sX builtin expects a constant instead of a variable. 4 years ago
Francisco Paisana d39183419c
Separate TPC PUSCH and PUCCH target SINR (#2740)
* separate target pusch and pucch sinr configurations in tpc class and rr.conf
4 years ago
Francisco 38bf895efa fix asn1 compilation issue 4 years ago
Francisco 86dac9c823 several coverity high and medium impact fixes 4 years ago
Xavier Arteaga 9a4fcb605b Reviewed UHD Tx FSM 4 years ago
Xavier Arteaga 3413f29cc8 Fix channel interpolator for 4 ports 4 years ago
Andre Puschmann 03e1277b0b rf_soapy_imp: fix lowercase to detect Lime 4 years ago
Andre Puschmann b569e81299 rf_soapy_imp: fix LTE sample rate info check
only print if Lime is substring in dev args, so don't print with blade
4 years ago
Andre Puschmann f76cd5ef83 backward: fix compile error on aarch64 4 years ago
Andre Puschmann 0826b86cec srsue: remove NR DL freq and ARFCN option
not required anymore as all NR carrier tuning is done
through RRC signaling
4 years ago
Andre Puschmann 4dd17aee45 rrc/phy/nr: calculate tuning freq of NR carrier from RRC signaling params
skip initial tuning to hard-coded NR frequency and use RRC-provided
values to calculate center frequency
4 years ago
Andre Puschmann 6e79ae67aa ldpc/polar: add casts to avoid possible variable overflow before assignment 4 years ago
Andre Puschmann 92d4e6e746 adt/common: remove const from return type
reported by LGTM https://lgtm.com/projects/g/srsLTE/srsLTE/rev/pr-9ae46cae260b6b8137b34b9423bf1477bd6b5c42
4 years ago
Andre Puschmann ff53d2b8b8 all: set of trivial changes reported by LGTM
mainly fixmes, unused/empty code, etc.
4 years ago
AlaiaL 0535473895 Fixes coverity 369570 4 years ago
AlaiaL 6332490cae Fixes coverity 369581 4 years ago
AlaiaL 385b12a33a Fixes coverity 369620 4 years ago
AlaiaL 23f0bd4d4f Fixed coverity 369716 4 years ago
AlaiaL 862784ee46 Fixed coverity 369719 4 years ago
AlaiaL 82788ca094 Fixed issues from coverity:
- 370233
- 370234
- 370239
- 370240
- 370241
- 370242
- 370243
- 370295
4 years ago
herlesupreeth 0f06ec0d9c Add feature to provide custom GTP-U (S1) address to be advertised inside S1AP messages
This feature is useful in scenarios where eNB is behind a NAT and EPC on public cloud
Since eNB's GTP-U can only bind to IP address visible in it's host (usually a private IP beind a NAT), it advertises the same to UE in S1AP message
resulting in traffic from EPC to eNB (DL traffic) not able to reach eNB. This commit solves this issue by providing a means to advertise a different IP address than the one GTP-U UDP socket is bound to.
This IP is usually advertised in InitialContextSetupResponse and E-RABSetupResponse.

In order to make use of this feature, use the following parameter in enb.conf

Example:

gtp_advertise_addr = 213.61.141.82
4 years ago
herlesupreeth aff9091ad3 Make use of RF device passed as argument 4 years ago
herlesupreeth 00a7d3a4cd Add option to provide RF device to use for cell search 4 years ago
Matan Perelman 7ee52dc676 srsUE: Add option to filter N_id_2 / PSS to configuration 4 years ago
David Rupprecht 102a943171 Fixed naming srsLTE to srsRAN 4 years ago
faluco 1ccb62af3d Apply srsLTE formatting rules to srsLog. They were previously formatted with different rules when the project lived in the external rapo. 4 years ago
Xavier Arteaga 873f375ecc Make NR DCI test more exhaustive and fix issues 4 years ago
Xavier Arteaga ab6a5ef17a Added NR DCI conversion to string for formats 1_0 and 1_1 4 years ago
Xavier Arteaga bccfa8d875 Added NR DCI packing/unpacking format 1_1 4 years ago
Xavier Arteaga 11b9990224 Added NR DCI packing/unpacking format 0_1 4 years ago
faluco 0afd59a5a0 Replace a string with a const char * in the rlc to_string. 4 years ago
Francisco 289559af82 asn1 fix - fix choice access correct type assert 4 years ago
Francisco ff3fc0826b asn1 fixes and improvements
- use const char* instead of std::string in enumerated<>::to_string() to avoid mallocs.
- Remove the use of "typedef", and use "using" keyword instead.
- Fix rrc_nr::setup_release_c<>::to_string() broken linkage.
4 years ago
David Rupprecht 98914dab6a Allow pdcp lte entity to use 18 bit SN 4 years ago
faluco 7df308c756 Remove two mallocs in the stack:
1) Extend the small buffer to 64bytes for the move_callback class.
2) Replace a std::map for a fixed size circular map in sched_time_pf.
4 years ago
Francisco 28f787f1de extend timer handler unit test to check correct time wheel implementation 4 years ago
Francisco 2b572f5376 fix overwrite of timer timeout when it matches previous time wheel position 4 years ago
Xavier Arteaga 407903e0d6 SRSUE: refactor carrier setting for accepting a dynamic carrier configuration 4 years ago
Xavier Arteaga 47523935f6 Minor NR RRC fixes 4 years ago
Francisco ce47cf5910 fix - re-add log flush to srsran_assert 4 years ago
Francisco 63913ff2b2 remove uneeded assert condition. change pdcp log when notified pdcp pdu doesnt exist to info. 4 years ago
Francisco 9efb959471 bugfix, scheduler - fix bit counter specializations for 32 and 64 bits. 4 years ago
Francisco 6137e4569b fix srsran_assert definition when asserts are disabled 4 years ago
Francisco 3b78bf3730 bugfix - fix memcheck warnings. move instructions with side effects outside of asserts 4 years ago
David Rupprecht a064e85c54 rename common lte header 4 years ago
David Rupprecht 81ad72b0ff Refactor srb and drb handling 4 years ago
David Rupprecht 91ff8a2e6d Add rrc_nr to rlc init function 4 years ago
David Rupprecht 6b41ae7e8b Updated PDCP config struct for rat type 4 years ago
Xavier Arteaga 77b6b60b82 Fix rach_cfg.nof_groupA_preambles 4 years ago
Xavier Arteaga aadbe6d880 Normalise NR PUSCH to maximum Tx power 4 years ago
Xavier Arteaga 53e41a165c Revert zeros around DC REs in NR PDSCH 4 years ago
Xavier Arteaga 93c3dc1cb1 Revert "Demodulator sets LLR to zero for 0.0 symbols"
This reverts commit 1a6e5cdee5.
4 years ago
Xavier Arteaga 1c1d7e2447 Revert "Review soft demodulator zero check"
This reverts commit b8a9a7fc70.
4 years ago
Xavier Arteaga 0999b271ba Added RFNOC based LO frequency offset 4 years ago
Francisco ac375f07d9 add precompiler guards to restrict builtin use to gcc and clang 4 years ago
Francisco 22024ac35d implemented bounded_bitset::find_lowest(...) for both reverse and non-reverse bit ordering. Applied this method to UL scheduling search for PRB intervals 4 years ago
Francisco 3f15fc2811 implemented bounded_bitset::find_first(...) 4 years ago
David Rupprecht db9dd85783 Parse carrier config in NR RRC reconfig 4 years ago
David Rupprecht f42d4dbc28 Refactored carrier config 4 years ago
Andre Puschmann 9009c3439c rlc_um_nr: convert log entries to info if they are expected
dropping a PDU and not being able to build a PDU if the
grant is too small is expected and should therefore not cause a log warning.
4 years ago
Andre Puschmann 936bebcfd7 rrc_nr_utils: fix extraction of HARQ processes from ASN1 reconfig 4 years ago
Xavier Arteaga 53b38fccf9 Fix compile and other 4 years ago
Xavier Arteaga ed0929b46d NR PHY logging minor corrections 4 years ago
Xavier Arteaga 8ffced7e88 NR PHY logging minor corrections 4 years ago
Xavier Arteaga abfc1da921 Multiple NR-PUSCH fixes 4 years ago
Xavier Arteaga 7e06e789d5 Fic NR UCI in the info string 4 years ago
Xavier Arteaga 01ce0718be NR-PUSCH RE mapping correction and NR-SCH detailed grant information 4 years ago
David Rupprecht bfe2ad98ef Added parsing for NR DL HARQ cfg 4 years ago
Andre Puschmann b9ae064338 mac_nr: add DL HARQ
this commit adds a complete DL HARQ entity to the MAC of the UE.
It also refactors demux into an own class and adapts the PHY-MAC
interface to use the new MAC capabilities.
4 years ago
Francisco e3e4564a7e fix inconsistency in use of invalid_sn and status_report_sn throughout rlc am code 4 years ago
Francisco c3ec28002b refactor - integration of segment list in rlc_amd_tx_pdu and pdcp_pdu_info classes 4 years ago
Francisco 7f0083a985 implementation of intrusive list abstract classes to be used in RLC for lists of segments 4 years ago
Francisco b06f16891d use of a single array-based pool of RLC AM PDU segments to build data PDUs, while
avoiding any allocations.
Each segment stores its own PDCP SN and RLC SN and has two pointers,
one for the next segment of the same RLC PDU, and another for the next segment
of the same PDCP PDU.
4 years ago
faluco e1752c0878 Replace the queue in thread pool in favour of a static circular buffer to avoid allocations. 4 years ago
David Rupprecht 1cbd1c9d26 Deleted hardcoded phy config 4 years ago
David Rupprecht fe8727050b Added new rrc_nr to phy flattening functions and fixes 4 years ago
Ismael Gomez 635db8dde1 Initialize metrics in hub 4 years ago
Xavier Arteaga e4e3456d76 Refactored PDSCH/PUSCH decoder for LDPC early stopping 4 years ago
Xavier Arteaga 6c5e28bc19 Optimised AVX512 LDPC decoder hard decision 4 years ago
Xavier Arteaga 422d479852 Added CRC match function and optimised byte packing 4 years ago
Xavier Arteaga 5aa7f9dd8b Condensed LDPC Decoder config arguments into an structure and unified common decoder code 4 years ago
Francisco 1f1233782f timers - fix old gcc compilation issue. Changed free list to intrusive list. 4 years ago
Francisco e37968410e simplification of timers handler design, relying solely on one time wheel. 4 years ago
Francisco 60896e30b5 implementation of time wheel-based timer handler, using a circular array and intrusive list 4 years ago
Ismael Gomez 77b11b82ac
Release UE if no activity in DRB (#2658)
* Count user activity with DRB only and SRBs for initial procedures. Add counter to release user after max KO in UL.
4 years ago
Francisco 4838cd2f5e implement cell measurement bandwidth feature 4 years ago
Francisco 14d32db92f implement Handover direct forwarding path availability configuration feature 4 years ago
faluco 582ad5f6de Replace the std::stack member in the buffer_pool class for a vector to avoid reallocs. 4 years ago
Francisco b8fa1d1b61 fix rrc mobility test 4 years ago
Francisco 66988ffd32 s1ap - simplified erab setup procedure. Handle correctly the failure to setup causes 4 years ago
Francisco f401683960 s1ap - simplified erab modify procedure 4 years ago
Francisco 76978f0d14 s1ap - simplified erab release procedure 4 years ago
Francisco c5fc543516 s1ap - handling of ts1 reloc overall timer. 4 years ago
Xavier Arteaga faa6d01e9d Fix RFNOC compilation 4 years ago
Xavier Arteaga c82f609085 Fix b200mini external clock 4 years ago
Andre Puschmann 44baea6666 mac_nr: add UL HARQ
this patch adds a basic UL HARQ entity for NR.

The patch also updates some interfaces between MAC/RA/HARQ,
i.e. get_temp_crnti().

It also adds a Msg3 unit test.
4 years ago
Andre Puschmann b7146c41b2 nr: add NDI for PUSCH grant to sch cfg struct 4 years ago
faluco a474a0f293 SRSLOG: Avoid calling unordered_map::emplace if element already exists since it will allocate even if the insertion is not going to take place. 4 years ago
Xavier Arteaga 80f5c82b53 Fix formatter test 4 years ago
Xavier Arteaga 7823bfc28c Fix append NR to loggers for NR components 4 years ago
Francisco c2a99a8112 handover - support for handover cancellation causes, check for E-RAB QoS requirements, cancellation of handover if E-RABs are not supported in the target eNB 4 years ago
faluco daad20c9d4 Disable copy and move operations for dyn_node_pool. 4 years ago
faluco a2f6e13138 Add a tag to the string memory pool in fmt to discriminate between pool vs heap allocated buffers. Heap allocated buffers are used as a fallback mechanism when the buffer runs out of space. 4 years ago
faluco 0465f6badd Implement a pool in FMT to avoid allocating heap memory when passing a char* to the backend, usually when formatting a %s argument.
Previously since a char* can have any length, this was managed by FMT by converting it into a std::string.
Now we store it into a configurable size node that can store a fixed size string, otherwise it falls back to std::string.
4 years ago
Xavier Arteaga 2f453b43ba Initial NR PHY interface 4 years ago
Francisco d2c404b166 handover - setup s1ap cause in case of handover failure at the target enb 4 years ago
Francisco 49bd895e29 s1ap - handle invalid or repeated erab ids in s1ap erab release command 4 years ago
Francisco 7842e3bff3 s1ap - add unit test to check correct handling of invalid E-RAB ids in modification request. Fix s1ap in order for the test to pass 4 years ago
Francisco 985846e3bd s1ap - set multiple erab ids cause in replay when s1ap erab modify request has repeated ids. 4 years ago
David Rupprecht 5a3a2a6d6f Added functions for adding phr and tag config 4 years ago
Andre Puschmann 48537f3fe7 pdcp,rlc: increase number of PDCP SDUs for notification from RLC
the current value of 256 limits the number of PDCP SDUs that can be
notified from RLC. The limit is quickly hit when too many SDUs
are in flight. This can cause unwanted log entries and weird PDCP
behaviour.

the patch increases the value to 1024, which still can be too few if
many smaller SDUs are traveling.

The patch also set the log level to warning to quicker spot
misconfigs in logs.

Fixes #2616
4 years ago
Xavier Arteaga 2f8ea05132 SRSUE: Add periodic CQI R10 parsing 4 years ago
Andre Puschmann c9da21c9bb mac_nr: add error handling when unpacking SCH MAC PDU
* only handle PDU if unpacking was successfull
* add TC unpacking with malformed PDU
4 years ago
Xavier Arteaga e989e62c52 Fix NR PDCCH DMRS test 4 years ago
Xavier Arteaga b8a9a7fc70 Review soft demodulator zero check 4 years ago
Xavier Arteaga dd26c6a90e Added more comments for better understanding in NR PDCCH DMRS 4 years ago
Xavier Arteaga 17a3c76540 Fix NR TDD pattern configuration 4 years ago
Xavier Arteaga c84e73541d Offset FFT window for UE DL NR 4 years ago
Xavier Arteaga f799ab6f94 Fix NR UL RV selection 4 years ago
Xavier Arteaga 42dcff45b2 Improve PDCCH NR detection 4 years ago
Xavier Arteaga 1a6e5cdee5 Demodulator sets LLR to zero for 0.0 symbols 4 years ago
Xavier Arteaga 3889f1369f Added partial NR time resource mapping tables 4 years ago
Xavier Arteaga de187d4c88 Fix copy-past issue in srsran_vec_apply_cfo_simd 4 years ago
Xavier Arteaga 2e3c00aa97 NR PDSCH zeroes RE around the DC. Added delay and CFO emulation to phy_dl_nr_test 4 years ago
Xavier Arteaga 667cc0b552 NR PDSCH/PUSCH DMRS estimation precompensates Synch error and CFO before interpolation 4 years ago
Francisco 685c971dc2 fix recursive call to get rb name 4 years ago
Francisco f7a8b8bf94 separate drb srb ids into separate enum types 4 years ago
Francisco 21718af3b6 avoid allocating std::string to get lcid radio bearer name. Refactored the lte radio bearer enum type 4 years ago
Francisco 437db3af03 forbid allocations when dispatching task to thread pool 4 years ago
Andre Puschmann b991b07167 rlc: add length check for RLC PDU generation
makes sure that RLC doesn't generate a PDU larger than
the provided grant size
4 years ago
Andre Puschmann 8024bf7820 mux_nr: improve logging when building UL MAC PDU 4 years ago
Andre Puschmann 9950278a12 nr,mac_sch_pdu,mux: fix packing of MAC subPDUs with 16bit L field
the created RLC PDU was too large to fit inside the MAC grant
because only the header room for the short L field was used.

The patch determines the correct size before passing the opportunity to RLC.

It also improves logging in error case by using the MAC logger instead of
stderr/stdout when error occurs.
4 years ago
Francisco ff8a43f6b0 avoid allocation of dl_sched_list and ul_sched_t by converting a std::vector to bounded_vector 4 years ago
Francisco f1c67f5b2b pool - avoid concurrent batch allocations in background threads 4 years ago
Francisco 75e9700de0 rlc - usage of memory pool to allocate RLC bearers 4 years ago
Francisco 71f1f1b556 enb - log warning when rnti-specific memory block is full 4 years ago
Francisco a890a22ccd enb - rnti memory pool now fallbacks to new/delete if rnti-specific memory block is full 4 years ago
Francisco a780a6a7b6 fix obj pool interface 4 years ago
Francisco 60d5c6df7b implementation of memory pool with individual memory blocks per UE that get accessed via their rnti 4 years ago
Andre Puschmann db496df1e6 mac_nr: add support for periodic BSR reporting
building on the previous refactor this patch now adds support
for peridoic BSR reporting (using short BSR). It furthermore does
the following changes:

* add BSR packing
* add proc_bsr_nr unit test
* move mac_nr test code into test folder under src (needs to be done with other test code too)
4 years ago
Andre Puschmann 6dd8c21073 mac_sch_pdu_nr: add unpacking of TA CE in DL-SCH
also add basic test to verify correct unpacking
4 years ago
Francisco dc763b5045 rlc am - fix bugs in buffered_pdcp_pdu_list
The count and container elements were not being correctly updated in the events
of SN overwrite, clear(), clear_pdcp_sdu(sn) of sn that doesnt exist
4 years ago
Francisco ebbb74e639 rlc am - use of circular_map container in RLC AM window
The window elements are not being correctly cleaned up when clear() is called
or when overwritten by newer SN. Furthermore, the window count member is not being
correctly updated when the insertion of a newer SN overwrites the previous one.

I used the circular_map container to avoid this sort of bugs
4 years ago
David Rupprecht 82c9636156 Refactor pdcp ctor seperate the configure function 4 years ago
David Rupprecht 56e947bf27 Added functionality for releasing a NR bearer 4 years ago
David Rupprecht cc6d8128ad Added gw interface if it is running 4 years ago
David Rupprecht 7a481c40ab Added mac prach nr proc error handling 4 years ago
David Rupprecht f9ea02b6bf Added functions for rrc reestablishing procedure if nr reconfig failes 4 years ago
Xavier Arteaga 58a9ef6e7f Minor NR PHY tweaks and aesthetic 4 years ago
Xavier Arteaga 991c6e7016 Refactored NR HARQ-ACK feedback enqueue 4 years ago
Xavier Arteaga bd11b66b6c Fix unitialised NR PHY arguments 4 years ago
Xavier Arteaga 22239b29c5 Disable smoothing filter for NR PDCCH DMRS 4 years ago
Xavier Arteaga 9f54c6ae6d Fix NR PUCCH info string and memory leak 4 years ago
Francisco b7d4a72ea1 adt - fix circular map clear() and erase(it) functions 4 years ago
Andre Puschmann 0fdcea2924 rlc_am: count every segment retx as a full retx for this SN
previously we were only counting retx if we retx the start of a segment.
this could lead to unwanted behaviour, i.e., not counting retx
correctly and thus not triggering the maxretx attempt, if the receive
always sends NACKs with a SO_start.

The RLC spec is not clear on how this should be handled correctly but
IMHO using an integer number of retx is reasonable, even for segments
that might be retransmitted more often.

The alternative of using a fractional retx counter that may be increamented
proportional to the segment size that is retx is another alternative
but considered too complex to implement (and test correctly).
4 years ago
Andre Puschmann c74661ae95 rlc_am: add log message when received NACK SN is already on retx queue 4 years ago
Francisco d02cc51e33 use mutex or atomic in running flag to signal the interruption of a thread 4 years ago
Xavier Arteaga 49731ab5a1 Initial NR-DCI refactor
Added NR DCI 1_1 size

Several DCI NR fixes
4 years ago
Xavier Arteaga 01990c2e1d SRSUE: Add PHY-MAC SR related interfaces 4 years ago
Xavier Arteaga 64acf03158 Fix sch_nr_test 4 years ago
Xavier Arteaga 1dcd75a6c7 Ignore CRC for RV!=0 in phy_dl_nr_test 4 years ago
Xavier Arteaga 3504bfcf5a Fix NR-SCH test 4 years ago
Xavier Arteaga 39e97cbcf4 Fix unbounded memory access 4 years ago
Xavier Arteaga 29c6adad93 Avoid unused LDPC memory in AVX2 decoder 4 years ago
Xavier Arteaga 392a8cc1b6 Fix LDPC RM number of useful iterations 4 years ago
Xavier Arteaga 3568f633c3 Use LDPC RM number of useful LLR and rename functions 4 years ago
Xavier Arteaga ecd2c1cdcc Improved LDPC decoded performance and other NR aesthetical changes 4 years ago
Francisco cdf72248f3 Reimplement batch-based background object/memory pool
Main changes:
- addition of pool utilities
- The node size/alignment and batch allocation threshold are now runtime arguments
- object pool and memory pool are not anymore based on the same class.
  The object pool cannot use intrusive free list because it would overwrite the object
  memory
4 years ago
Francisco 62a6d9a8dc fix background memory pool destruction 4 years ago
Francisco b004c2024d integration of object pool in mac::ue for allocation of softbuffers. Definition of common object pool interface class 4 years ago
Francisco 460d7a8f4f fix memory pool test - placed the pool state into a shared_ptr so that the callbacks still have a valid handle when the pool is destroyed 4 years ago
Francisco 9bec13731a adt unit test - fix memory pool test 4 years ago
Francisco ec3cd9ffea adt - added background object pool test, and fix existing bugs related to the creation of pools with objects that are too small to be used in free lists 4 years ago
Francisco d1c5b000dc adt - creation of pre-initialized object pool, that leverages the background memory pool allocator 4 years ago
Ismael Gomez 3daba090f6 Fixed compilation of turbo decoder in ARM 4 years ago
Francisco 2fc2280c3b adt pool - replace uint8_t* for void* to represent memory blocks 4 years ago
Francisco a79ca92020 refactor type storage and pool tests 4 years ago
Francisco 2723993740 fix network utils test 4 years ago
Francisco 046633674a refactor - removal of stack-gtpu interface, and use of socket manager interface instead 4 years ago
Francisco c24e382c19 Refactor of socket manager class
- use of inheritance to simplify testing
- removal of global network manager
- pass of custon socket manager to s1ap and gtpu ctors
- overhauled the registration of socket fd,callback in socket manager
4 years ago
Francisco 4aac7ac238 use global rx multisocket handler, and remove stack-s1ap interface 4 years ago
Francisco 39de2efa69 multisocket handler - use blocking socket remove method 4 years ago
Francisco bf96d897ee network utils refactor - renaming of socket handle to unique socket and cleanup of its methods 4 years ago
Pedro Alvarez 8194b5ec73 Added check for consequetive KOs in MAC. Change set_activity_user to pass activity and max KOs to RRC and trigger RLF timeout. 4 years ago
dr 968c261bec Reordered lock to avoid deadlock in mac pcap thread 4 years ago
Francisco 23ae9967cf replaced present+value for optional field in s1ap mme_ue_s1ap_id context field 4 years ago
Francisco c3482b45e1 s1ap - handle erroneous enb/mme s1ap ue id in received s1ap messages from the MME 4 years ago
Francisco ced757a11b adt - add optional construct that closely emulates std::optional<T> 4 years ago
faluco 54fab314c0 Enhance RRC eNB events:
- Implement a common event "log_rrc" for all RRC events and discriminate by procedure using an enum.
- Log events for connection, reestablishment, reconfig, reject and release.
- Log the corresponding ASN1 message used by each procedure.
- Redefine the JSON object for this event to match the new structure.

Fixed a compilation error detected by the static analyzer in gcc9.3 where bounded_vector::data() was using taking the address of the internal buffer which confused it, prefer to use the data method of std::array.
4 years ago
Andre Puschmann d135ae4d29 proc_bsr: initial BSR procedure for NR
* refactor some common methods to mac_common.cc
* add common mux_base class
* move UL PDU generation to mux class
* add logical channel registration to MAC, MUX, BSR
* add initial proc BSR
* add basic MAC NR test
* rework MAC interfaces
4 years ago
Francisco d04a19f8bc refactor - increase code reuse in adt files 4 years ago
Francisco 5eccfad05b gtpu - added comments, updated expected construct, handled in rrc the case a gtpu teid fails to allocate 4 years ago
Francisco ab2bd9a2d2 gtpu refactor - handle dl path state activation internally in gtpu tunnel manager class 4 years ago
Francisco cfd24f6a0e gtpu - leverage byte_buffer_pool to store buffered sdus in gtpu 4 years ago
Francisco c201eb7708 use of more space efficient sorted vector structure for lcid tunnels of a rnti 4 years ago
Francisco eba0edea4a creation of static id obj pool class. Application of this class to gtpu tunnels container to avoid allocations 4 years ago
Francisco 60cd7e6cfe adt - improved concurrent fixed memory pool policy to send buffers from thread cache to central cache 4 years ago
Francisco eb38ff43ab fixed size buffer pool bugfix - deleted threads now return the cached memory blocks to the pool shared memory block container 4 years ago
Francisco be771e5c23 performance - use of new concurrent fixed size pool for byte_buffer pool 4 years ago
Francisco e1523692c2 implementation of concurrent fixed size pool that leverages thread local caches to avoid mutexing 4 years ago
David Rupprecht b944528a4f Install srslog to system folder 4 years ago
faluco e2c7809abb - Introduce a new tracer scoped object that only records if the event duration exceeds the programmed threshold. 4 years ago
Andre Puschmann bde7b49ca3 ue,mac_nr: add basic SR procedure
the current implementation support only one SR config
and doesn't support the prohibit timer
4 years ago
Xavier Arteaga 6219500148 Added NR-RRC RACH parsing 4 years ago
faluco 3c1a97f450 - Use fprintf in the srsran_assert context incase the assert is being triggered by srslog producing a circular loop.
- Switch to use a dynamic circular buffer for the log backend queue.
4 years ago
faluco 4b5e15cd70 - Fixed missing return statements in base_circular_buffer::try_push.
- Fixed array index calculation in base_circular_buffer::clear.
- Removed redundant explicit in srslog::backend_worker.
4 years ago
faluco b06ef3f390 Switch the queue of the log backend to use a circular buffer. 4 years ago
David Rupprecht 8c86d2084d Adding NR phy config RRC parsing
Added error handling

Reworked flattening error handling
4 years ago
Andre Puschmann 6eedd70275 rlc_stress_test: add RLC UM NR 12bit stresstest 4 years ago
Andre Puschmann 48c106ae64 rlc_um_nr: fix packing/unpacking of PDUs with 12bit SN
* fix SN extraction/writing
* fix packed header size calculation
* fix segmentation logic and take variable header lenght into account
4 years ago
Andre Puschmann f992350d2d rlc_um_nr_pdu_test: add testcases for 12bit SN length packing/unpacking 4 years ago
AlaiaL 1cc2cc4e7f Fixed typo 4 years ago
AlaiaL fd3c2b855e - Renamed log to logger.
- Added a log entry in the metrics when skipping a measurement due to
time constrains
4 years ago
AlaiaL bbaebd1274 Added a warning in the log when the cpu metrics are not registered due
to the number cpu cores is greater than supported.
4 years ago
AlaiaL c9d1c77e8c - Deleted the magic number of maximum supported cores, now it is a
constexpr.
- When the system has more cores that the maximum supported, the cpu
metrics will not be registered.
4 years ago
AlaiaL 6cd9bba641 Added the cpu metrics to the system metrics. 4 years ago
Xavier Arteaga 5bdf2c93b3 Initial NR PDSCH CSI-RS RE skip and other changes 4 years ago
Pedro Alvarez 5bc55ec48c Changed discard_if to appyly_if in circular_buffer.h.
This was done so it would work when circular buffer holds other things
that are not unique_pointers. Queue and pop_func had to be made public
to be able to call the pop_func when an SDU is discarded.
4 years ago
Andre Puschmann 1b1cfa40c9 rlc_am_lte: add some more sanity checks around retx of PDUs
this patch doesn't change any functionality but adds a bit
of further error checking around the handling of status PDUs
and the retx of PDUs
4 years ago
Francisco 6d9709fe54 adt - make circular buffer work with types without default ctor 4 years ago
Francisco ef5329bec0 adt - extend circular map unit test to test the container with move-only types 4 years ago
Xavier Arteaga 7704c09ce2 Fix typos 4 years ago
faluco e8395c7474 - Implement a pool to store dyn arg store objects in srslog to avoid allocations when passing arguments to the backend.
- Use string views inside the log formatters to avoid allocations.
- Avoid a std::string when using fmt::vsprintf, instead favour fmt::vprintf.
4 years ago
Andre Puschmann 1a0891df51 all: check return value of make_byte_buffer() and handle them safely 4 years ago
Francisco 46d46e70ff add documentation for srsran_assert and srsran_expect macros 4 years ago
Francisco dd336c53ea changed srsran_warning to srsran_expect. Applied new macro to rlc am 4 years ago
Francisco b5692037a2 created macros for assertions and warnings. The assert macro prints the whole callstack on crash. The warning macro can just log a warning or call an assertion fail depending on the cmake flag STOP_ON_WARNING 4 years ago
Andre Puschmann 9d8d897d3e mac_pcap_base: log warning when PDUs can't be added to write queue 4 years ago
Andre Puschmann 26e7964694 mac_pcap_base: increase PDU queue size to 512 4 years ago
Pedro Alvarez d91119baf6
RLC discard (#2515)
* Added ability to discard to dyn_block_queue

* Change way of keeping track of SDUs

* Check nullptr in poping callback. Starting to check for nullptr in RLC read_pdu.

* Adding RLC discard tests

* Clearing PDCP info when RLC discard happens

* Read SDUs until they are no longer nullptr

* Changed discard_if to use template argument
4 years ago
Francisco 0d5038dd34 fix wrong lib linking in cmaker 4 years ago
Francisco 88f5add1fb adt - fix circular map erase function and added extra asserts 4 years ago
Francisco 5d676199ab adt bugfix - fix copy/move ctor of circular map 4 years ago
Francisco 4869b14de3 application of new circular map to mac::ue_db 4 years ago
Francisco 98d0637ded adt addition - implemented reusable circular map 4 years ago
Codebot 4523ee6087 rename srsLTE to srsRAN 4 years ago
David Rupprecht ad3a3af490 Adding more info into pcap test 4 years ago
Francisco 977c194cbc gtpu,bugfix - handle the case when gtpu fails to allocate buffer for end marker. Also, added a timer that when expired, it autoremoves the GTPU handover tunnel 4 years ago
Pedro Alvarez dde8157bf1 Make sure that S1 Setup request is restarted regardless of which error made the procedure fail. 4 years ago
Xavier Arteaga 2782d96170 SRSUE: compute speed from TA commands 4 years ago
Andre Puschmann 47654af717 pdcp_entity_lte: fix printf formatter for size_t
we've seen a heap-buffer overflow in fmt because printf wasn't using
the right formtter for size_t, which should be %zu

this patch fixes it for the PDCP LTE entity but we might have it elsewhere too

[1m[31m==7595==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x629000e6f1fc at pc 0x562273a45289 bp 0x7f35567641f0 sp 0x7f35567641e0
[1m[0m[1m[34mREAD of size 4 at 0x629000e6f1fc thread T12 (STACK)[1m[0m
    0 0x562273a45288 in fmt::v7::basic_format_arg<fmt::v7::basic_printf_context<std::back_insert_iterator<fmt::v7::detail::buffer<char> >, char> > fmt::v7::detail::make_arg<fmt::v7::basic_printf_context<std::back_insert_iterator<fmt::v7::detail::buffer<char> >, char>, unsigned int>(unsigned int const&) (/osmo-gsm-tester-srsue/srslte/bin/srsue+0x9dc288)
    1 0x562273a3aa86 in void fmt::v7::dynamic_format_arg_store<fmt::v7::basic_printf_context<std::back_insert_iterator<fmt::v7::detail::buffer<char> >, char> >::emplace_arg<unsigned int>(unsigned int const&) (/osmo-gsm-tester-srsue/srslte/bin/srsue+0x9d1a86)
    2 0x562273a308e7 in void fmt::v7::dynamic_format_arg_store<fmt::v7::basic_printf_context<std::back_insert_iterator<fmt::v7::detail::buffer<char> >, char> >::push_back<unsigned int>(unsigned int const&) /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/include/srslte/srslog/bundled/fmt/core.h:1548
    3 0x562274361541 in void srslog::log_channel::operator()<unsigned int&, unsigned int&, unsigned long>(char const*, unsigned int&, unsigned int&, unsigned long&&) /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/include/srslte/srslog/log_channel.h:101
    4 0x56227430d9e7 in srslte::pdcp_entity_lte::update_rx_counts_queue(unsigned int) /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/src/upper/pdcp_entity_lte.cc:451
4 years ago
Francisco fb48f4484c sched refactor - removal or cleanup of unused sched methods 4 years ago
Andre Puschmann 2cfc657fbb rlc_am_lte: refactor logging when PDCP SDUs are enqueued
the patch refactor the logging when a new PDCP SDU is enqueued for
transmission at RLC.

If the SN is already present, only a warning is logged. From the RLC
perspective operation continues and the SDU will be transmitted.

The patch also changes the order of logs. When the SN cannot be inserted
inside the queue of undelivered SDUs, only one message is logged.
4 years ago
faluco 358c4de0bd Fix a valgrind issue in a unit test in log_channel_test where the buffer was not being null terminated. 4 years ago
faluco eb27efd867 Modify the policy of the buffered sink to flush its contents continuously instead of doing it once. 4 years ago
Francisco 0d91802495 sched optimization - swap c-arrays for bounded_vector in sched_interface to reduce time performing bzero/memcpy in the scheduler 4 years ago
Xavier Arteaga 5f954ab379 Fix UHD compilation 4 years ago
Xavier Arteaga a8b5b8efa1 UHD: stability improvements 4 years ago
Xavier Arteaga f9689ec956 Added PUSCH CFO estimation 4 years ago
Francisco 47f1175502 [sched, feature enhancement] - allow variable nof prbs allocated per SIB / Paging message 4 years ago
Andre Puschmann 3e07767f28 rlc_stress_test: set maxRetx for AM to 32 by default
since the tests are random we sometimes hit the maxRetx threshold
with 8 retx allowed that made the unit test fail.

increase threshold to lower the likelihood for this to happen.
4 years ago
Xavier Arteaga f3c0360842 Applied aesthetical changes 4 years ago
Xavier Arteaga d9780e1f13 Fix duplicated NR-DCI in different search spaces and CORESET and other aesthetic modification 4 years ago
Xavier Arteaga 6fa33c890d Simultaneous HARQ-ACK, SR and CSI in NR-PUCCH 4 years ago
Xavier Arteaga 1463b11bad Fix compilation 4 years ago
Xavier Arteaga be8e8cbe3e Fix radio decimation Rx stream stall 4 years ago
Xavier Arteaga 1153555ae1 SRSUE: Added UE specific cell space 4 years ago
Xavier Arteaga 10af89fcdd NR-PDCCH aesthetic changes 4 years ago
Xavier Arteaga fb1a0b6bce SRSUE: added NR-PDCCH information 4 years ago
Xavier Arteaga d3cfb00211 SRSUE: Added TDD DL/UL slot detection 4 years ago
Xavier Arteaga f3bf0c1c68 Wrap slot index in modulus macro 4 years ago
Xavier Arteaga 4bab0b53b7 SRSUE: fix slot index overflow 4 years ago
Xavier Arteaga 6f6c20e194 SRSUE: Added procedure for multiplexing UCI in NR-PUSCH 4 years ago
faluco e43f555fc0 - Provide a fast path for logging pre-formatted strings that are small and fit in 64 bytes without any allocations.
- Use this new feature in the tracer.
4 years ago
Francisco 2e18827259 avoid accessing C-array via &[0] for initialized buffer 4 years ago
Francisco 80104c7e65 adt, bugfix - fix assert when accessing bounded_vector::data() member 4 years ago
David Rupprecht be46806495 PCAP: Enable carrier ID TAG 4 years ago
Francisco ca7fe1349e remove unnecessary sfinae from bounded_vector. Use bounded_vector for UE cc buffers. Set ue cc used buffers remove_pdu method to private 4 years ago
Francisco d27e0be609 created special class to manage mac::ue currently allocated rx UL buffers. This class avoids mallocs 4 years ago
Ismael Gomez 7b33c48fe7 Use static queue in pdu_queue 4 years ago
Pedro Alvarez f02694dd3e PDCP status report: Fix issue in keeping track of Rx'ed COUNTs after eNB reestablishment. Fixed issue in logic that limits the size of the rx_counts info vector. 4 years ago
Pedro Alvarez d2ef541957 Changed the structure to store rx_counts info to std::vector, to reduce
memory allocations.
Update the rx_count_info queue if the queue size is too large.
4 years ago
Pedro Alvarez 3f79cd6281 Changed generation of status report to use rx_counts instead of
undeliverd_sdus_queue. Added a queue to store information about
rx_counts received.
Added unit test for when the SNs wrap-around in status report genaration
4 years ago
Francisco 6159cb3817 add assert to ensure a valid ptr is passed to memory pool deallocator 4 years ago
Francisco 20928651c7 created batch allocator that leverages background worker pool 4 years ago
Francisco 3e9f93eb8a refactor - remove old log_filter and logmap libraries from the codebase 4 years ago
Francisco 3b491ab06b optimize .count() method of bounded_bitset to leverage popcount special instructions. Confirmed to work for gcc in -msse4 flag is passed. 4 years ago
Francisco 7dcb703d06 adt lib,bugfix - fix bounded_bitset resize to clear bits outside of mask correctly 4 years ago
Francisco d1483dc0f8 sched,bugfix - fix bitmask formatting. fix msg3 adaptive retx pdcch allocation 4 years ago
faluco 173dcdd421 - Import latest srslog version.
- Remove string allocs in some log lines in radio.cc.

Add new tracing buffer capcity options into srsenb and srsue.

Add missing file.
4 years ago
faluco c7542daf43 Remove rlc traces and add new ones into tti run functions both in the enb and ue. 4 years ago
faluco 82db6544fb Add instrumentation points to rlc_am_lte::rlc_am_lte_tx::handle_control_pdu using srslog. 4 years ago
Ismael Gomez 8e9d28e7e0 Change wait_for interface for wait_until in circular_buffer 4 years ago
Andre Puschmann 16de8668e0 rlc_am_lte: convert mutexes to std::mutex
replace all pthread_mutex with std::mutex and use lock_guard and unique_lock (where needed)
4 years ago
Andre Puschmann 20cbc48f90 rlc_am_lte: refactor PDCP/RLC interface to use fix sized data structure
this patch replaces the std::vector type used in the interface between
PDCP and RLC to signal delivery status between both layers. The new
data type is a configurable but fixed-size vector.
The RLC AM doesn't need to dynamically allocate the vector for every SN but
uses the tx_window for storage.
4 years ago
Francisco ee77343f26 fix compilation issue for centos7 4 years ago
Francisco 20e341d0a1 mac,bugfix - fixed formatting of MAC and scheduler user-defined types 4 years ago
Francisco f72cd4151c rlc am,bugfix - fixed formatting of RLC AM header and status pdu 4 years ago
Francisco 4c1067bcf6 bitset - fix compilation issue for centos7 4 years ago
Francisco 0f9d73012f use srslte::move_callback instead of std::function in timers to avoid allocations 4 years ago
Francisco 5a1bf28fe1 optimization - minimization of number of std::string allocations for logging 4 years ago
Francisco 1ffc4cef86 rlc am,optimization - change helper log methods to avoid mallocs 4 years ago
Francisco d77b6e1d9c sched,optimization,refactor - use of custom formatter that avoids mallocs for getting bitmasks strings in hex and binary formats 4 years ago
Xavier Arteaga a03c78a777 Fix NR-PUSCH defect 4 years ago
Xavier Arteaga 05f4d6af71 Fix and validated UCI multiplex in NR-PUSCH 4 years ago
Xavier Arteaga 2b9bd1173e More NR-PUSCH UCI bit multiplexing 4 years ago
Xavier Arteaga 289fff9c22 Removed carrier set in UCI NR module 4 years ago
Xavier Arteaga 97435b085e Added CSI part1 and 1/2 bit HARQ-ACK multiplexing on PUSCH 4 years ago
Xavier Arteaga dc2542901a Verified HARQ-ACK in PUSCH 4 years ago
Xavier Arteaga 9dffad87f2 Initial UCI bits multiplexing in PUSCH 4 years ago
Xavier Arteaga f4e9d00ea8 Initial HARQ-ACK multiplex in PUSCH 4 years ago
Xavier Arteaga 7b588eafec Minor aesthet change 4 years ago
Andre Puschmann ace8764568 rlc_am_lte: add missing unlock when building status PDU fails 4 years ago
Francisco 0b6293c676 adt lib additions - add the ability to perform timedwait for popping from a blocking queue 4 years ago
Francisco f0ed1e06a8 documentation,bugfix - added documentation to new blocking queues, changed class names, and removed blocking pushes from the critical path 4 years ago
Francisco d1236fd62f stack,optimization - replaced previous block_queue design for new bounded queue in several places in the enb 4 years ago
Francisco 28ef5833a2 fix compilation issue for centos7 4 years ago
Francisco 0ba93d274f converted byte_buffer_queue to use new circular buffer-based queue to avoid mallocs 4 years ago
Francisco 822e26b63f implemented circular buffer-based queue 4 years ago
Francisco fb278a8b21 Fallback to default R8 TBS tables for format 1A DCI
Co-authored-by: xavierarteaga <xavier.arteaga@softwareradiosystems.com>
4 years ago
Andre Puschmann 83f24fbf77 rlc_am_test: fix max_retx test
the test should only check the correct signaling of the maxretx
to the upper layer.
4 years ago
Andre Puschmann ceacf8508d rlc_am_lte: fix handling of maxretx
this patch fixes the actions/handling after RLC detected
maxRetx reached for a given SN.

According to the TS, RLC should only inform upper layers and
not try to recover from the event itself.

As a consequence, we won't manipulate the Tx or Rx window.
As a result of this, we might retransmit a SN more than
the specified amount of times.

It's the task of RRC to reestablish the bearer to recover
from that.
4 years ago
Francisco fb04fdbe69 sched,bugfix - fix mcs/tbs computation for 256-QAM. 4 years ago
Andre Puschmann 9f627911df rlc_am_{control}_test: extend status PDU test 4 years ago
Andre Puschmann 6a4bf65fd8 rlc_am_lte: extend check for valid status PDU
check for all NACKed SNs are smaller than ACK_SN
4 years ago
Andre Puschmann fa23be4d6d rlc_stress_test: fix SDU generation
the PDCP SN was used to fill the SDU with data. But since
the max value isn't devisable by 256 it didn't always increment
correctly. Use a normal byte now that wraps correctly.
4 years ago
Andre Puschmann 62b2327178 rlc_am_lte: fix header reconstruction
* optimize processing of status PDU (SN is removed from window immediately)
* fix maxRetx signaling for segments
* make tx_window_t a template class, rename and use for rx_window as well
4 years ago
Andre Puschmann 5e345df439 rlc_stress_test: make pedantic operation the default
among cleaning up the the stress test, it does:
* remove optional pedantic flag and make it the default to catch resegmentation issues
* use random SDU and MAC grant size the default
* use factory functions to create RLC configs (make maxretx configurable)
* remove reestablishment and print error when maxRetx is triggered
* fix NR PCAP usage and removes PCAP ifdef
4 years ago
Andre Puschmann 1a59f2d5ba rlc_am_test: extend header reconstruction test
this patch adds various new test cases generated from
rlc_stress_test to test header reconstruction.
4 years ago
faluco dc6a2e5160 Implement a log spy to check if a certain message has been logged. 4 years ago
Francisco 9eeddcec5f disabled prach vs pucch collision detection temporarily until enb cfg files are updated in the rfci 4 years ago
Francisco 102cb196e1 Addition of enb cfg option to choose between PUCCH with multiplexing and without. Change default prach offset to 4.
- The new prach offset of 4 accounts for the size of the PUCCH-ACK region with 100 prbs
4 years ago
Francisco 39aea96c69 fix sched tests UL HARQs. Set common pucch cfg in the sched tests 4 years ago
Andre Puschmann 99df71a914 rf_zmq: make error message when port bind failed more verbose 4 years ago
Francisco 9748c0be84 simplified tbs/mcs computation in scheduler 4 years ago
Pedro Alvarez 9c67a029b5 Trying to make calculation of offset in status report more readable 4 years ago
Pedro Alvarez 7b23a83306 Fixup tests to consider wrap-around in status report 4 years ago
Pedro Alvarez c4e9516561 Fix issue when LMS wraps-around and FMS doesn't in PDCP status report. Fix incorrect update of FMS on clear_sdu. Adding unit test to LMS wrap-around. 4 years ago
Pedro Alvarez 0d020a7f07 Disable sending and handling status report on SRBs 4 years ago
Xavier Arteaga 81cc8de2b7 Protect NAS unbounded message read 4 years ago
David Rupprecht aef6805d03 Added pcap net feature to eNodeB 4 years ago
David Rupprecht 9e72d89fa1 MAC PCAP move run thread in base class 4 years ago
David Rupprecht 894e4d3501 Added mac pcap network class that dumps the packets to a udp network sink 4 years ago
David Rupprecht a58f0642cb created pcap base class for main handling 4 years ago
David Rupprecht da658ed2d4 Changable UE ID for enodeb 4 years ago
David Rupprecht 5a95cbdfae Disable rat assignment in pcap class 4 years ago
David Rupprecht 24bea9a860 Refactored functions for pcap udp packing and write lte mac pcap with udp frame 4 years ago
David Rupprecht bb3e87302d Added new pcap enable option and mac nr 4 years ago
AlaiaL 390a4c0f76 [metrics] Changing variable types.
Adjusting the license.
4 years ago
AlaiaL 723c56051e [metrics] Changed the extension from cpp to cc.
- Fix date of CMakeLists.txt.
- Initialization of the used variables in the cpu usage calculation.
4 years ago
AlaiaL 41cf15f5ad [metrics] Adjusted function names and documentation 4 years ago
AlaiaL d518a625cc [metrics] Added the system metrics to the csv 4 years ago
AlaiaL 0ba7cd7df9 [metrics] Added system metrics to the enb's stdout 4 years ago
AlaiaL 3a86c210f9 [metrics] Added the system metrics to the ue stdout 4 years ago
Francisco 290f39d805 fix crnti mac ce handling in the rrc in normal (no handover) case 4 years ago
Xavier Arteaga 0346564241 Fix NR-PUCCH encoding 4 years ago
Xavier Arteaga 784f4be72e SRSUE: NR CSI report fixes 4 years ago
Xavier Arteaga 4679e9f871 Initial NR CSI reports 4 years ago
Francisco 202c4d7566 remove uses of method .clear() of stack timers 4 years ago
Francisco be7e78da53 limit allocation of PDCP SDU+Timer buffer to DRB+RLC AM cases 4 years ago
Pedro Alvarez 8dfa87c377 Disable undelivered SDU queue for SRBs. 4 years ago
Francisco a3cb21d378 move undelivered_pdcp_sdus class methods to .cc file. Fixed the forwarding of pending PDCP SNs during S1 handover 4 years ago
Francisco 17fa79f24c couple the pdcp discard timers and sdu buffer management into same subclass. Add asserts to ensure there is no ambiguity in the PDCP SN assignment and buffering. Extend the discard timer and pdcp sdu buffering to SN lengths above 12 4 years ago
Pedro Alvarez 4723dd0aa9 Converted undelivered sdus queue in the PDCP to use a vector.
This was done to improve the performance of the notify_delivery().
4 years ago
Francisco a72a659fdf fix timers interface to avoid accessing to a timer after its release. fix gtpu tunnel activation during s1 handover 4 years ago
Xavier Arteaga 6c9ff3ac92 Fix packed sequence genration for non multiples of 8 4 years ago
Xavier Arteaga 1e55d68b55 Removed set RNTI from API 4 years ago
Xavier Arteaga 93752fb2c4 Fix LDPC compilation for GCC 10 4 years ago
Xavier Arteaga 576a923a4c Added i8 zero vector 4 years ago
Pedro Alvarez 4011714664 Fix errors in RLC stress tests due to PDCP SN wrap-around 4 years ago
Francisco 1cd3576134 fix gcc compilation issue 4 years ago
Francisco 5ea2e8f45d remove more srslte.h includes from upper layers 4 years ago
Francisco 4b09507c19 remove srslte.h includes from upper layers 4 years ago
Francisco 766018f2b4 fix gcc compilation issue 4 years ago
Francisco b329e25bbb move ue phy interfaces to separate interfaces header file 4 years ago
Francisco 13d805ef56 move ue rrc interfaces to separate interfaces header file 4 years ago
Francisco b1706b9197 move ue nas interfaces to separate interfaces header file 4 years ago
Francisco b8bd869d0f move ue rlc interfaces to separate interfaces header file 4 years ago
Francisco a988351f46 move ue pdcp interfaces to separate interfaces header file 4 years ago
Francisco ea04104e8e move ue gw interfaces to separate interfaces header file 4 years ago
Francisco 186285ffd3 move ue usim interfaces to separate interfaces header file 4 years ago
David Rupprecht 8f49b92760 Using PDCP entity lte instead of nr for nr bearer 4 years ago
Pedro Alvarez c0b5edf6db
Make sure discard timers are initialized, even when timeout is infinite. (#2400) 4 years ago
Francisco 6e64933335 handle the scenario when the network thread fails to allocate a byte buffer 4 years ago
Francisco f610a7b83d Change background worker pool to become a global variable
Allocate rrc::ue objects in batches in the background worker pool
4 years ago
Xavier Arteaga 11cffdcbec Minor comment 4 years ago
Xavier Arteaga 126fc09b7d SRSUE: Added initial SR procedure for NR 4 years ago
Andre Puschmann 822abc763e rlc_am_lte: when max retx is reached, remove SN from tx window
this fixes an issue when the RLC bearer isn't reset from RRC.
In this case, the RLC would retransmit the same PDU over and over
again despite the max retx counter being reached.
4 years ago
Andre Puschmann c0a1b0efa3 rlc_am_test: add TC to check RLC AM drops PDU if max retx have been reached 4 years ago
Francisco 0b6b62324f convert rlc am retx_queue to circular buffer 4 years ago
Andre Puschmann 9c4146442a mac,phy: refactor NR MAC/PHY UL data passing interface
inspired by accepted (but not yet merged) PR to include the
(unique_)byte_buffer_t for MAC/PHY interfacing, this patch adds
a few more useful bits to that. Buffer management for UL data is now
done in MAC and only a pointer to the data is passed in the UL action.

* Move Tx softbuffer to MAC (until UL HARQ class is ready)
* Remove temparal data member in cc_worker
* Remove memcpy after packing MAC PDU
4 years ago
David Rupprecht fc9d5befda Remove header test case 4 years ago
Andre Puschmann 5e93a6f5bd rlc_um_nr_pdu_test: add 12bit SN unpack test 4 years ago
Andre Puschmann 06e7f169c6 rlc_um_nr: fix unpacking of 12bit UM PDU 4 years ago
Pedro Alvarez 976b5c12c1
Releasing the UE when max retransmissions are reached in the RLC. (#2385) 4 years ago
Francisco 138685399e remove allocations from rlc_am_tx::handle_control_pdu 4 years ago
David Rupprecht cc0c091a39 pcap checksum to null for decoding if checksum check is enabled 4 years ago
Xavier Arteaga 6ba9f8fd41 SRSUE: Remove UL hard-coded phase and more PUSCH logging info 4 years ago
David Rupprecht 1fcd006a7c fixed segfaulting 4 years ago
Xavier Arteaga b768002a93 SRSUE Added RAR unpacking and other fixes 4 years ago
David Rupprecht 82a8dcc77a Change interface to unique_byte_buffer
logging message for msg3 preparing
4 years ago
Xavier Arteaga 760ad3a746 SRSUE: Interface stack and PHY for NR-RA procedure 4 years ago
Francisco 9a6512f4e8 fix RLC AM undelivered PDCN SNs reset bug 4 years ago
Francisco 1ede82bb30 use circular array for buffered PDCP SNs in RLC AM to limit memory allocations 4 years ago
Francisco 2a65bf9636 fix undelivered PDCP SNs buffers in RLC AM to handle SN=-1 case 4 years ago
Francisco bad2302e31 avoid the use of two arrays for managing buffered pdcp sns in RLC AM 4 years ago
Francisco 299634b319 use of vector to store undelivered PDCP SNs in RLC AM 4 years ago
David Rupprecht 0f1586dd2d Deleted all HAVE_5GNR in CC and h files
CMakeList and travis yaml
4 years ago
Xavier Arteaga c2c05d1e8f Initialise to zeros NR PHY configuration by default 4 years ago
Pedro Alvarez d8f3878ce1
RLC failure to deliver notifications and discard timer limits to 1500ms (#2368)
* Added interfaces for the RLC to notify the PDCP of failure to transmit
SDU

* Limit discard timer to 1500ms, to avoid issues of lingering SDUs in the undeliverd_sdus_queue.

* Fix bug in early exit of notify_delivery and notify_failure

* fix compilation issue in rlc-pdcp notification

Co-authored-by: Francisco <francisco.paisana@softwareradiosystems.com>
4 years ago
Francisco 2f75abcc7a fix failing rlc am test 4 years ago
Francisco 1d185fb152 use macro for rlc tx window size. refactor tx window clearing 4 years ago
Francisco abe4f4c7eb use tx_window to store the map of rlc sn to pdcp sns 4 years ago
Francisco f86eb84876 conversion of RLC AM tx window from std::map to array 4 years ago
Francisco 1660fc81a0 fix comment regarding PDCP SN value for status report 4 years ago
Francisco 047dd2a56d use function helper for discard timer lookup and stopping in the PDCP 4 years ago
Francisco c6fa011eec fix pdcp discard timer list creation 4 years ago
Francisco 82bb0a7d81 implementation of pdcp discard timers using a vector for efficiency 4 years ago
Andre Puschmann 40d7934267 rlc: call PDCP notify without holding Tx lock
move notify_info_vec as stack variable and unlock mutex
before calling PDCP notify
4 years ago
Francisco 93b1450e03 fix enb crash during close down of enb and epc 4 years ago
Francisco Paisana cd8ee37f74
Use a reverse lookup to avoid iteration over a std::map (#2363)
* reuse vector capacity for pdcp sn notification
* use an extra lookup data structure to find PDCP SNs that an RLC SN contains
* fix rlc sn->pdcp sn lookup datastructure in rlc
* fix rlc failing test
4 years ago
Pedro Alvarez d947a0bccf Used the used SN to insert into the discard timer instead of the TX_COUNT 4 years ago
Pedro Alvarez 3f2fe4e5f6 Disable PDCP discard timer when using RLC UM. 4 years ago
Xavier Arteaga b8b27709b9 Radio: implement resampling buffer protection 4 years ago
Pedro Alvarez 24d5b9071c Fix issue with status report test config 4 years ago
Pedro Alvarez 6ecd6e273c Make sure that the status report is sent in RLF and PDCP reestablishment triggered by Handover 4 years ago
Pedro Alvarez 6a6bffcf5c Changed log of discarding SN due limit to info level 4 years ago
Pedro Alvarez c66c96aac7 Simplify if condition in checking the maximum allocated SNs in PDCP 4 years ago
Pedro Alvarez 33808a5cb8 Making sure that SNs don't wrap-around in PDCP with RLC AM. 4 years ago
Ismael Gomez 543e84d873 Fix compilation error in PPC 4 years ago
faluco 613d397d0a - Dump the PDCP metrics into the JSON file.
- Fix the PDCP metrics getting reset periodically which invalidated the byte counters.
4 years ago
faluco a940e169a3 Add the enb_cc_idx value to S1 events. 4 years ago
faluco b750647cd8 - Remove the cause field in the rrc disconnect event.
- Add the sib9 enb home name field to the sectors events, but leave the value as a TODO.
4 years ago
faluco 7b9dab3a73 Rename cc_idx variable to enb_cc_idx for specific upper layer events. 4 years ago
faluco a4605883f0 Implement second revision of the events and metrics document. 4 years ago
Pedro Alvarez 0e828aeb4b Remove unecessary mutex. PDCP metrics are accessed from the stack thread. 4 years ago
Pedro Alvarez c39905744c Fix metrics of TX PDUs and TX_PDU bytes in PDCP 4 years ago
Pedro Alvarez 451c305790 Add mutex to isolate metrics_hub thread from the stack thread when
getting the metrics from the PDCP
4 years ago
Pedro Alvarez 0c240a80aa Fix up PDCP metrics to calculate the buffered bytes when get_metrics is
called.
4 years ago
Xavier Arteaga 70a55ebf1e Fix ZMQ sleep time 4 years ago
Pedro Alvarez 46cd29e0ac Temporarly disable sending status report and retrasnsmissions on reestablishment in PDCP 4 years ago
Pedro Alvarez df501d1500 Clear underlivered SDUs info map for SRBs on reestablishment 4 years ago
Pedro Alvarez d705fa2106 Tentative fix for errors due to status report already present in RLC info queue 4 years ago
Pedro Alvarez ba5367bc56 Change order which reestablish is called in eNB
Make sure that RLC info queue is reset when reestablish happens
4 years ago
David Rupprecht a7949e69c8 configure and start ra proc
Fix crash due to missing init
4 years ago
David Rupprecht 876858b44c Added mac nr prach common config convert function with test case 4 years ago
David Rupprecht b19cbdde23 Added test case for testing the decoding of cell group config 4 years ago
David Rupprecht a3be380e3b workaround to mitigate the linking error 4 years ago
Andre Puschmann e0495d1da8 zmq: fix parsing of log_trx_timeout
add temp var for this param. the bug cause log_trx_timeout
to have the value of the previously parsed fail_on_disconnect
4 years ago
Pedro Alvarez cfd94441a5 Added metrics to srsenb PDCP 4 years ago
Pedro Alvarez 8873b7c42f Added computation for the metrics 4 years ago
Pedro Alvarez d34aba8065 Added interfaces to get metrics from PDCP entities. 4 years ago
Pedro Alvarez eb2f5b978f Starting to add metrics to lib/upper/pdcp.cc 4 years ago
Pedro Alvarez dd6a292d79 Added structure to hold PDCP metrics 4 years ago
Pedro Alvarez 3eab97340b Fix issue in getting PDCP discard timer from configs 4 years ago
Xavier Arteaga bdef411855 SRSUE: Aesthetic changes 4 years ago
Xavier Arteaga 96a47fb93a Add NR RRC interface types 4 years ago
Xavier Arteaga 784a33583b SRSUE: Initial NR MAC-PHY interfaces
SRSUE Fix compilation

SRSUE: temporary fixes LTE/NR PHY/Stack interface problem

fix

fix
4 years ago
Francisco 6a178693a8 handle rrc configs with pdcp with sn=15 or 18 bits 4 years ago
Francisco faf2adde90 set last_submitted_pdcp_rx_sn to -1 of the next ul rx sn 4 years ago
Pedro Alvarez e2d2951b00 Added some extra logging for the PDCP get_buffered_pdus and notification reception. 4 years ago
Pedro Alvarez 963dff34af Added retransmissions to the UE's PDCP on re-establishment. 4 years ago
Xavier Arteaga 8ac6d7382f Fix PRACH sequence generation 4 years ago
Xavier Arteaga 2fd618a295 Avoid FFTW re-planning if no DFT change is required 4 years ago
Xavier Arteaga 596c8f52a9 PRACH set config avoids modulo operation 4 years ago
Xavier Arteaga 1e073b8b67 PRACH: avoid general cexp for sequence generation using LUT 4 years ago
Andre Puschmann c1a1c92e1b zmq: optionally log rx/tx timout from ZMQ ringbuffers to stderr
this patch adds two new config flags to the ZMQ driver that allows to:
* configure the default ZMQ trx timeout in ms
* turn on error logging if the timeout occurs

Use with, e.g.:
device_args = log_trx_timeout=true,trx_timeout_ms=3333
4 years ago
Xavier Arteaga 984c4a4748 Changed license header 4 years ago
Pedro Alvarez e0542a4651 Fix issue in sending PDCP status PDU from the eNB due to non-existing LCID at the RLC. 4 years ago
Pedro Alvarez b0fe302f8e Added interfaces so the upper layers can trigger the PDCP status report. Added ability to the UE to send Status Report aftre reestablishment. 4 years ago
Pedro Alvarez 89a23cec7e Added statusReportRequired to the PDCP entity config. 4 years ago
David Rupprecht 24123313bf Added MAC NR RA procedure with a minimal test case 4 years ago
Xavier Arteaga 3d3c80262c Modified Error messages 4 years ago
Xavier Arteaga d9805f7ba7 Added AVX512 LDPC 4 years ago
Pedro Alvarez 2ed8dceddf Use TX_COUNT in RLC AM stress test. Avoids issue with re-using SNs within the test 4 years ago
Xavier Arteaga 2e39e103f8 Minor NR related corrections 4 years ago
Xavier Arteaga 24cfed6489 Fix scrambling sequence for PUCCH format2 4 years ago
Xavier Arteaga 5f70526ac5 Minor NR-PUCCH related fixes 4 years ago
Xavier Arteaga 9faa2d5fcd SRSUE: Automatic DL-HARQ Reset for every TTI and Generate PUCCH baseband signal 4 years ago
Xavier Arteaga 2d9e964147 Fix RA RNTI grant count 4 years ago
Xavier Arteaga d807ccc3dd SRSUE: Initial NR-PUCCH HARQ feedback 4 years ago
Xavier Arteaga ff5fbbf0a0 Added vector sprint for bit 4 years ago
Xavier Arteaga 818f3ea7c7 Initial NR-PDSCH HARQ-ACK/NACK procedure 4 years ago
Xavier Arteaga 18db846c6c Remove NR hard-coded phase offsets 4 years ago
Xavier Arteaga 44df2288b9 Corrected typos 4 years ago
Pedro Alvarez f89b644902 Added function to get control pdu type to the PDCP base class. Shorten logger name in PDCP Status report test. 4 years ago
Pedro Alvarez 90113419c2 Added memset(0) to PDCP status report bitmap before starting to fill it in. 4 years ago
Pedro Alvarez 9bc08af880 - Added ability to the PDCP LTE entity to send PDCP Status report.
- Added handling of PDCP status report to the PDCP LTE entity.
- Added test to the generation and handling of PDCP status report.
4 years ago
Francisco Paisana 4152e43bab fix gtpu packing when extension header is enabled 4 years ago
Francisco Paisana c40ad81a90 cleanup s1ap methods. remove hard coded erab list in s1ap handover required message. 4 years ago
Francisco Paisana 5e48327eca fix valgrind memcheck warnings in rlc_am_test 4 years ago
Francisco dc4283c572 added cmake functions as helpers to set labels in ctests 4 years ago
Francisco add156c3fe update phy lib cmake test labels 4 years ago
Francisco 23459dee28 Created enb_{rlc/pdcp/gtpu/phy_interfaces.h files. 4 years ago
Francisco 43e57df00b breaking enb_interfaces.h into multiple files on a layer basis. Created enb_rrc_interfaces.h, enb_mac_interfaces.h and enb_s1ap_interfaces.h 4 years ago
Pedro Alvarez dd6d6f731d Passing SN provided by upper layers to PDCP entity. Using it to calculate TX_COUNT if passed. 4 years ago
Pedro Alvarez 492ea2a5a8 Addressing reviewers comments to #2290.
Removing unecessary \n for logs and changed log of PDCP info queue
 capacity to debug to avoid log spam.
Changed log level for unhandled S1AP messages from error to warning
 in EPC to avoid failing tests because of error message.
Changed usage of allocate_unique_buffer to make_unique_buffer()
4 years ago
Pedro Alvarez fcaaf72187 Starting to add discard functionality to PDCP LTE entity.
This includes:
  - Adding a queue (implemented with std::map) for undelivered PDUs.
    This queue uses the SN used for TX as the key.
  - Added discard timer that is started upon reception of the SDU. Upon
    expiry of the timeout a discard callback removes undelivered PDUs
from the queue.
  - Added the mechanisms to the notify_delivery to remove PDUs from the
    undelivered queue when the PDU is ACK'ed.
  - Added test case for both timer expiry and acknowledgment.
  - Fix up the getter for buffered SDUs to return the undelivered SDUs
  - Changed default PDCP discard timer, so AM has a discard timer by
    default.
4 years ago
faluco 5c8923123a Misc compilation fixes from the fapi repo. 4 years ago
faluco 57f66febfc Ported the RLC classes to srslog in the lib dir. 4 years ago
faluco f424f2e113 - Upgraded PDCP classes in lib to use srslog.
- Update tests to new changes.
4 years ago
faluco 6359a2d948 - Upgrade the gtpu class in lib dir to srslog.
- Propagate old log elimination through all the dependencies of gtpu.
4 years ago
faluco 62fcf04083 Ported the all radio classes to use srslog. 4 years ago
Francisco c2dfe615e7 fixed alignment of LIBLTE_BYTE_MSG_STRUCT to reflect the one of byte_buffer. Add bzero in liblte packers 4 years ago
Francisco 4188b5146e fix uninitialized memory access in gtpu_test and liblte_mme unpacking 4 years ago
faluco 6545df6681 Removed new lines in log macros in all example apps. 4 years ago
Ismael Gomez 77f905dc64 Move TTI to PID mapping to MAC 4 years ago
faluco 9d15a44c73
Port lib/phy to srslog (#2298)
* - Ported the channel class to srslog.
- Removed all newlines of log messages in lib/phy.

* Remove more newlines that use the C debug macros.
4 years ago
Andre Puschmann 6eed6f622f mac_nr: update RA related function in MAC/PHY interface
* expose interface to trigger PRACH from MAC
* indicate PRACH tx from PHY
* add temporary RAR PDU handling with Msg3 grant indication to PHY
4 years ago
Andre Puschmann 01acf95566 mac_rar_pdu_nr: update public interface to make it easier to access
* provide all subPDUs as const vector&
* return UL grant directly
4 years ago
Francisco 6925b40722 remove extra print when buffer pool is depleted 4 years ago
Francisco 798f1e57e6 fix byte buffer double free in EPC 4 years ago
Francisco d2ddcb0d4e avoid bzeroing byte buffers at every allocation for better runtime performance 4 years ago
Francisco 3265d940ec remove byte buffer pool cached member variables as they are unnecessary now. 4 years ago
Francisco 04ab4eefcd use new make_byte_buffer() helper method to create unique_byte_buffers 4 years ago
Francisco 8a9c326bcb remove old direct uses of byte_buffer_pool 4 years ago
Francisco 1e2153769e remove byte buffer pool cleanup method and unnecessary mutexes 4 years ago
Francisco 0c7c317be5 refactor byte_buffer class and move it to separate file 4 years ago
Andre Puschmann 30216fe1fc mac_pdu_nr_test: add packing test for UL-SCH PDU with CRNTI, PHR and SBSR 4 years ago
Andre Puschmann e227916819 mac_sch_pdu_nr: add SBSR, PHR and CRNTI packing 4 years ago
Andre Puschmann 6a0f3d0bc5 common_helper: remove newline 4 years ago
Andre Puschmann 4ca43c6804 mac_sch_pdu_nr: add unpacking helpers for CRNTI, SBSR and PHR CEs
* unpackers for CEs
* testcase with TV
4 years ago
Xavier Arteaga a154bef23f Added incremental phase in NR-PUSCH modulator 4 years ago
Xavier Arteaga 8f57437e6f Add NR-PUSCH-DMRS amplitude option and procedure 4 years ago
Xavier Arteaga a19671802e Added SRSUE NR-PUSCH initial procedures 4 years ago
Xavier Arteaga 19e9c25d1d Added ZMQ Tx sample offset 4 years ago
Pedro Alvarez 7b25eac47c Fix race condition in rlc_am_stress test and other fixes related to this
test. The race condition was being cause by write_sdu being called
simultanously to read_pdu, which could cause the read_pdu to try to get
the SDU info before it had been written by the write_sdu.

Changes in this commit include:
 - Make sure PDCP sn in included in RLC AM stress test.
 - Stop handling control PDU when TX is not enabled in RLC AM.
 - Fixed issue with length of the PDCP SN in rlc_stress_test.
 - Moved the place were sdu info erase was called to avoid double calls to erase
 - Tentative fix for race condition in rlc_am_stress test.
 - Added function to print information about undelivered_sdu_info_queue
   for debugging.
4 years ago
Pedro Alvarez 2b092ddc85 Initialize byte_buffer metadata to avoid unintialized variable warnings. 4 years ago
Pedro Alvarez 261c2b2e03 Removed limit to the undelivered SDUs info queue in RLC AM. Printing a warning if the queue is getting large instead. 4 years ago
Pedro Alvarez d0ef6ce00b Fix typos and bad comments in rlc_am_lte.cc and rlc_am_test.cc
Added checks for the nack_sn in the status reports of the rlc_am_test.
4 years ago
Pedro Alvarez 24db20bcca Removed some unused variables after changing method of tracking notifications. Removed rlc_am_notify_pdcp test file. Testing is now in rlc_am_test.cc 4 years ago
Pedro Alvarez 6c071a784c Changed notification mechanisms to use map of acked SNs instead of acked bytes.
This was required due to an issue where bytes were counted twice when a
packet had been lost.
4 years ago
Pedro Alvarez 649d642776 Moved notification tests from rlc_am_notify_pdcp_test.cc to rlc_am_test.cc.
This added some tests to resegmentation.
4 years ago
Pedro Alvarez 389cf4d943 Moved updating the notify info to it's own function. 4 years ago
Pedro Alvarez de669d214a Fix test header and queue_capacity check in RLC notifications.
Also, remove unecessary nullptr initializaion and fixup some newlines.
4 years ago
Pedro Alvarez de90b4753f Added the ability of the RLC AM to notify the PDCP of the acknowledged
PDCP PDUs. This includes:

- Modifying the byte_buffer_t to include PDCP SN meta-data. This way,
  the RLC can keep track of the ack'ed bytes for a specific PDCP PDU.
- Added in the RLC an `undelivered_sdu_info queue`, to keep track of the
  amount of ack'ed bytes and the total size of the PDCP PDU,
  so the RLC can know when delivery is finished.
- Added an interface between the PDCP and the RLC so that the RLC can
  notify the PDCP when it receives an ack from the status PDUs. The RLC
  passes to the PDCP a vector of all the ack'ed pdus in a rx'ed status PDU.
- Added some tests to the notify functionality. This includes some tests
  where the PDUs are acked imediatly, and one test where the PDU is
  retx'ed.
4 years ago
David Rupprecht 3dab82c42f Added interface that allows to update the lcid in case of a nr reconfiguration
nr rrc updates gw lcid if reconf was received
4 years ago
faluco 821925a273 - Upgrade to srslog the loggers in lib/mac.
- Adapted users of these classes and tests.
4 years ago
AlaiaL 9c764c299d - Removed the try/catch. Checking the allocation with std::nothrow
- Adjusting the code with the coding style.
4 years ago
Xavier Arteaga a2d9b436d9 SRSUE: add NR stack to PHY and initial decoded PDU push 4 years ago
Xavier Arteaga 4f43935dd3 NR-SCH: CRC is KO if data is all zeros 4 years ago
Xavier Arteaga 77f0a53abd Added DCI Format 0_0 unpacking and more NR-PUSCH procedures 4 years ago
Francisco 9e25e95545 fix S1AP UE Capability Indication message. Created helper to log received S1AP messages 4 years ago
Francisco 78d1b8083a fix GTPU tunneling. Avoid forwarding packets to PDCP while the PDCP bearer is not yet created 4 years ago
Andre Puschmann 8e13f04684 mac_pcap: refactor MAC PCAP and include NR RAT into same object
after adding the thread-safe PCAP writer functionality to the EUTRA
MAC object it became clear that we don't wont to replicate the
same for the NR object.

This patch therefore refactors the class that now supports both EUTRA and
NR rats. The old mac_nr_pcap.[h/cc] has been deleted. All test-cases
and usages now use the new object that needs to pass the RAT type in
the ctor.

this patch addresses the last open point of #2160
4 years ago
faluco 199f1c953e Remove unneeded logmap headers. 4 years ago
faluco b014233662 - Port time related classes to srslog.
- Adapt tti_point_test to srslog.
4 years ago
faluco 1a5799a6ca - Replace loggers is network utils.
- Adapt tests that use network utils and callers.
4 years ago
faluco e9ed6f31ba Port mac_pcap to srslog. 4 years ago
faluco 79eca0980d - Ported fsm.h to srslog.
- Adapted and removed old loggers in tests and code that used fsm.h
4 years ago
faluco c8a4bf2613 - Fix unused variable in buffer_pool.h
- Replaced logger to srslog in log_args utility function.
4 years ago
faluco d37a07a47f Replaced loggers in buffer_pool.h 4 years ago
faluco f8485fb799 Replaced loggers to srslog in PNF and VNF classes. 4 years ago
faluco 96c07a69c0 Report the RLF event to the JSON event file in the enb. 4 years ago
Xavier Arteaga c60d207826 Add fix phase shift in gNb PHY 4 years ago
Xavier Arteaga 194670a2a3 NRPHY: hard-coded symbol phase correction 4 years ago
Xavier Arteaga 820c9066db Fix OFDM modulator for NR 4 years ago
Xavier Arteaga 2421f2cd99 Multiple PHY fixes and NR-PHY configuration refactor 4 years ago
Xavier Arteaga 7e6a35a9f7 Fix Synch error calculation 4 years ago
Xavier Arteaga b652cd68a5 Refactored NR PHY configuration to accept multiple CORESETs/SearchSpaces 4 years ago
Xavier Arteaga a85d79c6b7 Added ZMQ option to delay/advance Rx samples 4 years ago
Xavier Arteaga 73001c9541 Implement NR-DCI conversion to string 4 years ago
Xavier Arteaga 83a5ce96ed Initial NR OFDM symbol size compatibility 4 years ago
Andre Puschmann f5c945dc2f mac_nr: add interface to set C-RNTI and contention ID from RRC
used during contention-based/free RA
4 years ago
Francisco 2bde28252c send UE capability indication through S1AP 4 years ago
Francisco d64ce7df77 implementation of S1 E-RAB Release Indication and Error Indication messages 4 years ago
faluco 806268f6cf
Por asn1 code in lib directory to srslog (#2253)
* Match hex dump indentation with srslog.

* Port asn1 utils to use srslog. Converted logging functions from taking varargs to variadic template functions.

* Remove trailing new lines in log lines from asn1 utils.

* First round of upgrades to srslog to asn1 tests.

* Second round of porting asn1 tests to srslog.
4 years ago
Andre Puschmann f88943653b mac: implement MAC RAR PDU unpacking for NR
* add class for mac_rar_pdu_nr
* extend test case
4 years ago
Andre Puschmann da9e3363f1 mac_pdu_nr: rename MAC PDU class for NR to adhere naming conventions
* mainly to have _nr as trailing name for filename and class
* also add "sch" to class and filename (RAR PDU will have extra class)
4 years ago
Xavier Arteaga 6b4a17dc66 Fix uninit condition 4 years ago
Francisco 2befbd1825 setup of forwarding tunnels during enb s1 handover 4 years ago
Francisco e8f6a436af update gtpu test to account for scenario of buffered PDCP SNs, and buffering of direct path until indirect tunnel is closed 4 years ago
Francisco a55c4cdca5 avoid gtpu extension header pdcp number magic number 4 years ago
Francisco 56ec2c286e add gtpu test for tunneling 4 years ago
Francisco 13649e4e19 Implement new GTPU functionality:
- multiple tunnels per E-RAB
- data forwarding between connected GTPU tunnels
- forwarding GTPU End Marker between connected tunnels
- TeNB GTPU handles in-sequence delivery when multiple tunnels for the same ERAB exist.
4 years ago
Andre Puschmann 3784439088 add backward as backtrace pretty printer
this patch adds the MIT-licensed header-only library backward-cpp
as possible alternative for our internal backtrace-to-file
writer.
4 years ago
faluco 711438f756
Port enb specific classes to use srslog (#2155)
* - Started porting the enb PHY layer to use srslog loggers.
- Updated srslog to manage the none level.

* Finished porting enb phy layer including the NR part.

* Ported MAC, GTPU, PDCP, RLC and S1AP enb classes to use srslog.

* Use new stack logger.

* Ported the enb RRC clases to use srslog.

* Remove unused log macros.

* Replace loggers in sched, sched_carrier, sched_helpers.

* Replaced loggers in sched grid.

* Replaced loggers in sched harq.

* Replaced loggers in sched ue.

* Replaced loggers in sched ue ctrl.

* Replace loggers in sched ue ctrl TPC.

* Replaced loggers in sched subclasses.

* Replaced loggers in rrc_meascfg_test

* Configure loggers in rrc_mobility_test.

* Fix compilation errors left out after the rebase.

* - Implement a custom log sink that will serve as a test spy to intercept and count the number of error and warning log entries.
- Adapt the erab_test_setup and rrc_mobility tests to use this new class and make them pass again.

* - Remove trailing new lines introduced in the rebase.
- Ported the sched_ue_cell class to srslog.

* Remove unused log member.

* Ported mac tests to srslog.

* - Removed remaining trailing newlines from log entries.

* Fix compiler errors detected in CI.

* Fix another static variable without definition passed to log lines.

* Fixed a bug in srslog::flush that would never end when the backend queue is full.

* Fetch the RRC logger instead of injecting it in the constructor.
4 years ago
Andre Puschmann 4709bacefd srsue: add DL NR-ARFCN param
* add PHY param to set DL NR-ARFCN
* use new band_helper class to convert ARFCNs to supported bands
* signal supported NR bands in UE capabilities
4 years ago
Andre Puschmann 617e0ddb67 band_helper: add helper class for RF bands
attempt to C++ify handling of radio bands and (E/NR)ARFCNs, etc.
4 years ago
Xavier Arteaga 4fe34b5e5b Apply minor comments in NR-PUCCH 4 years ago
Xavier Arteaga 4c6944b883 Implement NR-PUCCH Format 2 DMRS put/Estimate 4 years ago
Xavier Arteaga 958afaee60 Implement NR-PUCCH Format 2 encode/decode. Initial NR-PUCCH procedures. 4 years ago
Xavier Arteaga 4b6849b775 Polar: Add more information to ERROR traces 4 years ago
Xavier Arteaga 573ff24a47 Fix CRC for more sizes 4 years ago
Xavier Arteaga 1ee4d84f80 Added NR-PUCCH encode/decode format2 skeleton 4 years ago
Xavier Arteaga 4d96cf4a41 More NR-PUCCH support 4 years ago
Xavier Arteaga 697bdb4d6d Added NR-PUCCH Format 1 encoder, decoder and DMRS 4 years ago
Xavier Arteaga 33bb387f52 Initial NR-PUCCH formats 0 and 1 encoder 4 years ago
Xavier Arteaga e7562e5b3f Added ZC sequence LUT object 4 years ago
Xavier Arteaga d100919561 Initial NR-UCI encoder 4 years ago
David Rupprecht 1b19ee40e7 Added usim features for key derivation 4 years ago
David Rupprecht 306bb6b38b Added function for derive keys 4 years ago
David Rupprecht ceda458bb3 Added MAC NR to EUTRA and NR with stack interfaces including MAC config build
Moved MAC logical channel config to MAC interface types
4 years ago
David Rupprecht a6046ca875 Added funcs for asn flat config RLC and PDCP 4 years ago
David Rupprecht 64299960bd Added procedure for NR reconfiguration and RRC with NR complete 4 years ago
David Rupprecht 145528ad32 Added unpacking test for RRC reconfig 4 years ago
David Rupprecht 99c3aa9ba2 Refactor assert to TESTASSERT in unit test 4 years ago
Xavier Arteaga 7dd99da045 Disable carry-less multiplication 4 years ago
Xavier Arteaga 058bee5fda Increased prime number range 4 years ago
Xavier Arteaga 2f5b1ba9cb Avoid PUSCH-DMRS initialization for 0 PRB 4 years ago
Xavier Arteaga 2f2114f377 Fix typo 4 years ago
Xavier Arteaga 732a220d42 Unified low-PAPR Ruv sequence generation 4 years ago
Xavier Arteaga aa8b69e9a7 Fix prime number 4 years ago
Xavier Arteaga 8de73988b8 Add real vector and complex scalar product 4 years ago
Xavier Arteaga 6bb1788df1 Added more NR CRC polynomials 4 years ago
Xavier Arteaga a7ca8ffff7 Moved prime number to different file 4 years ago
Xavier Arteaga ae3c5ec7d0 Moved all block code (32, O/K) to FEC block
Fix missing header

Fix missing header
4 years ago
Xavier Arteaga 95ce49acd4 Added more vector copy functions 4 years ago
Xavier Arteaga be6cb666e2 Initial moved block coding to FEC 4 years ago
Xavier Arteaga f6b4f65f12 Add NR-PDSCH-DMRS SNR estimation 4 years ago
Pedro Alvarez 350e90a030 Make RLC retransmissions deterministic. It was creating unpredictablity
in the RLC AM tests. See issue #2228
4 years ago
Pedro Alvarez 6ca8bc12ec Fix wrong SN in RLC status PDU when packet is dropped. 4 years ago
Francisco e0937d1dd1 add lcid check and increase limit to 10 4 years ago
Francisco bed979b722 fix out-of-bounds memory writing in the sched_interface::ue_cfg_t ue_bearers member 4 years ago
Ismael Gomez 47dbd6ed70
Merge pull request #2214 from softwareradiosystems/pr_mac_buffers
Limit the number of UL buffers in MAC and deallocate old ones
4 years ago
Francisco b45fdd4f10 use using keyword in asn1 rather than typedef 4 years ago
Francisco 049ad77fca simplify asn1 choice types with one single type with a packer 4 years ago
Francisco c336c3eed2 added to_number() conversion of rrc_nr poll_byte 4 years ago
Ismael Gomez a6423442c2
Refactor NR RA files and fix header includes all over library (#2162)
* Refactor NR resource allocation classes. Use DCI instead of grant for dummy PDSCH UE/eNB test

* Minor refactors in NR workers and ue_dl

* Fix include issues

* fix compilation issues
4 years ago
Ismael Gomez d5f0634975
Add PUCCH SNR measurement (#2175)
* Add PUCCH SNR measurement

* Fix PUCCH SNR estimation

* Reverted PUCCH noise estimation

* use fpclassify instead of iszero

Co-authored-by: Xavier Arteaga <xavier@softwareradiosystems.com>
4 years ago
Ismael Gomez c1c5fa426c Fix issue with new way of managing ul buffers not working with CA 4 years ago
Ismael Gomez 0780f3caea pdu_queue must be non-blocking in order to avoid the ue or enb to block in the event of a memory leak and the buffer pool running out of buffers. In that case, the null return shall be handled properly and error logged. This commit restores commit c4c44c33f4. 4 years ago
Francisco Paisana d4242f2db7 precompute nof_re_table[sf][prb][slot][cfi] for faster nof_re computation and for more accurate lower bound nof_re computation 4 years ago
Francisco Paisana 9c7c190074 when the rrc fails to allocate the ue cell resources, it should erase the ue from all stack layers 4 years ago
Andre Puschmann dadff1a947 pdu: default initialize pdu members with MAC log
MAC PDUs are default logged using the MAC log. So this gives
hex prints, etc. without having to manually set the logger for each
PDU.
4 years ago
Andre Puschmann fcf481b83e pdu: add check when unpacking MAC PDUs to not read beyond PDU length
we've checked the same when unpacking the subheaders but missed the
case where the payload was read beyond the PDU length, as has been
seen with a malformed RAR PDU.
4 years ago
Andre Puschmann 10da7df194 pdu_test: add TC with malformed RAR PDU
a malformed RAR PDU should not be decoded further if the payload
indicates a length beyond the actual PDU size.
4 years ago
Francisco Paisana 2866886ade fix gcc4.8 compilation issue 4 years ago
Francisco Paisana f8b7351e1b implementation of object memory pool via class-specific operator new/delete 4 years ago
Francisco Paisana ea74ca67eb resolve forward declaration compilation issue in memory pool 4 years ago
Francisco Paisana e96b8c263a add mem pool test. fix mem pool leak bug 4 years ago
Francisco Paisana 8912a8ce6c added extra comments to memory pool code. generalized object pool to mutexed and non-mutexed cases 4 years ago
Francisco Paisana 768a4fa627 added growth policy for rrc::ue memory pool. Fixed memory leak 4 years ago
Francisco Paisana a73cbcdc9d added mem_pool for growing object pools. Applied the mem pool to the rrc::ue creation 4 years ago
Andre Puschmann 78b07daf3b pcap: make public interfaces thread-safe and handle fopen returning nullptr
the previous patch only introduced a thread-safe queue between
PHY workers (writers) and PCAP writer thread (consumer).

However, it is also required to protect the ctor (and close()) to
prevent corrupted PCAP files.

The patch also correctly handles the case where the PCAP couldn't
be openend for writing and doesn't start the thread.
4 years ago
Francisco Paisana ea8ad153c4 add configurable fairness parameter to pf scheduler 4 years ago
David Rupprecht f7d313147a Added infrastrukture for measurements
Init rrc_nr as part of the LTE stack
4 years ago
David Rupprecht b79eef0860 Introducing nr_rrc <-> rrc interface for eutra and nr cap query 4 years ago
David Rupprecht 020d0dacc8 add the additional sec cap to NAS attach request
use same capabilities that are signaled for EUTRA
4 years ago
David Rupprecht 9eb0b72cb4 Added rrc function has_nr_dc 4 years ago
Andre Puschmann c02aa8f124 liblte_mme: add DCNR UE capabilties packing 4 years ago
Andre Puschmann 4fa89b7039 pcap: make PCAP write thread-safe
* offload PCAP writing to background thread
* use blocking_queue between writer and clients to make it thread-safe
* add basic test case

this fixes point 1-3 of #2161
4 years ago
Andre Puschmann 2ca894df01 pdu: fortify RAR packing
detected with ASAN trying to write negative number of padding bytes.

The patch checks the calculated length and returns with an error
if the length is negative.

=================================================================
==5759==AddressSanitizer: while reporting a bug found another one. Ignoring.
m==5759==ERROR: AddressSanitizer: negative-size-param: (size=-6)
4 years ago
Xavier Arteaga 54a864e021 Added Initial NR-PRACH configuration for preamble format 0 4 years ago
Xavier Arteaga b3200d9ef5 Renaming common UL/DL DMRS related types and initial NR PUSCH implementation 4 years ago
Xavier Arteaga cc5fdb68f3 Added on-the-fly sequence for bit packed 4 years ago
Xavier Arteaga d0a4b4d409 Changed DL-SCH LDPC scaling factor for decoding high rates 4 years ago
Xavier Arteaga 2e59f6a568 Applied LDPC fixes and minor aestheic modifications 4 years ago
Xavier Arteaga 13443c3f8c Added number of DMRS CDM groups without data to NR grant 4 years ago
Xavier Arteaga d413c1aaec Fix base graph selection and improved PHY LIB logging 4 years ago
Xavier Arteaga 808bb3fb94 Fix string to modulation conversion and apply clang-format 4 years ago
Xavier Arteaga 0a06074158 Skip NR PDSCH allocation in PDSCH DMRS symbols 4 years ago
Xavier Arteaga 1775052144 Fix NR PDSCH DMRS cinit and zero after free 4 years ago
Francisco Paisana 74ffe393c6 asn1 update: s1ap asn1 is now v16.1 (2020-03) 4 years ago
faluco 92b11c1adb Backport misc changes from the fapi repo. 4 years ago
Francisco Paisana 66aa34d173 update RRC NR ASN1 to 2020-09 v15.11 4 years ago
Andre Puschmann d5daf60773 pdu_test: add unpacking test for DL-SCH PDU containing TA command 4 years ago
Andre Puschmann c5514d7f80 pdu: fix to_string() for TA command
the get_ta_cmd() is returning uint8_t which stringstream
interprets as ASCII character by default. So the log message is bogus.
4 years ago
Pedro Alvarez 0ad0e9acac Make sure that RLC entity is only re-created if it switches modes. 4 years ago
Pedro Alvarez 0c20b7a455 Added support for S1AP modify bearer request support. This includes:
- Handle received E-RAB S1AP at s1ap.cc.
 - Added methods to rrc.cc, rrc_ue.cc and rrc_bearer_cfg.cc to handle erab modify request.
 - Made RLC add_bearer() function capable of re-creating the RLC entity.
 - Send RRC reconfiguration to the UE and reply to the EPC with S1AP
   modify bearer response.

This commit also adds support to srsEPC to send S1AP modify bearer request for
testing purposes.
4 years ago
Andre Puschmann 48b37394f1 rlc: remove unneeded log entry
was added for testing only
4 years ago
Francisco Paisana 099dad8cb1 disable PHR handling in the UL sched by default 4 years ago
Francisco Paisana e27c0869e5 update RRC ASN1 to 2020-09 v15.11 4 years ago
Andre Puschmann bc4c9606ce rlc_am: add extended bearer metrics
this patch adds support for measuring the:
* SDU rx latency (Average time in ms from first RLC segment to full SDU)
* amount of buffered bytes (sum of payload of PDUs buffered in rx_window)

the implementation is using std::chrono
4 years ago
Andre Puschmann d54c33258b rlc_metrics: add sdu rx latency and buffered bytes 4 years ago
Andre Puschmann 2e64fff1df common: extend timestamp interface for byte_buffer
* allow setting timestamp to a specific std::chrono::time_point
* add getter from raw tp
4 years ago
Andre Puschmann 81cfce6cf0 rlc_um: remove latency calculation from RLC UM 4 years ago
Xavier Arteaga 533222f245 NR PDCCH fixes 4 years ago
Xavier Arteaga a746e29395 Removed shadow variable 4 years ago
Xavier Arteaga 99ca2d2f14 Add polar interleaver 4 years ago
Xavier Arteaga 3662210842 Fix external softbuffer inclusion 4 years ago
Francisco Paisana 1ea635f9ae asn1 utils fix: avoid unpacking an unconstrained integer length twice 4 years ago
Andre Puschmann e43eab8b5f rlc: fix rate metrics (nan,inf values), use std::chrono
similar to GW, we remove gettimeofday and use std::chrono.
we also make sure to reset the metrics after reestablishment
4 years ago
David Rupprecht 826dd32c89 Rename meas_cell to meas_cell_eutra
Added meas_cell_nr class

Make meas_cell list as template class

Inheritance rrc_cell to meas_cell_nr
Added process_new_cell_meas_nr function
4 years ago
David Rupprecht 62b558fccf Move rat type to common header
Removed phy measurement from rrc interface phy

Updated rrc interface for handling measurements
4 years ago
Ismael Gomez f9a02299f9 Use MAC PDU pointer instead of tti_rx and rnti as a key to associate buffers. Decouple crc_info() and push_pdu() functions. This allows for different timing architectures in the PHY 4 years ago
Ismael Gomez 0498439d41
Backport some changes from FAPI branch (#2124)
* Reorder DCI FORMAT enum

* Fix endianness issue

* Fix return codes in phy_ue_db

* Log members should be destructed after the layers.

* Add JSON metrics and Events. Add Alarm log channel. Simplify MAC metrics struct.

* Restore metrics_stdout change
4 years ago
Francisco Paisana ea36e46635 fix asn1 length determinant packing/unpacking. avoid subtracting len by zero before the packing 4 years ago
Francisco Paisana d198e8fb31 fix asn1 length determinant packing for upper bounds above 64K 4 years ago
Francisco Paisana 1304746bce use of fmt lib in asn1 utils 4 years ago
Andre Puschmann 9133135e12 rlc_tm: remove error from log when RLC TM PDU can't be sent
RLC TM can't be segmented so it may happen that a PDU
cannot be sent because the grant is too small. That is not
an error and should only be logged in info.
4 years ago
Francisco Paisana 53116a99fc add rlc metrics to rlc_um 4 years ago
Francisco Paisana 82eb31f70f add rlc metrics to enb 4 years ago
Francisco Paisana 0f693b36b2 changed pdu latency calculation to std chrono 4 years ago
Francisco Paisana 7ffc236a1a enable log line when rlc tx pdu last segment is sent but the latency log is disabled 4 years ago
Francisco 951912d18a disable RLC latency measure when ENABLE_TIMESTAMP flag is disabled 4 years ago
Francisco 92bc98e2f0 add byte tx counter to the set of metrics being measured in RLC 4 years ago
Francisco e2654e69ec Enable pdu stack latency measurements in the eNB. 4 years ago
faluco f23fdf0639 Include missing files. 4 years ago
faluco 98a2c868b5 Update srslog to latest version. 4 years ago
faluco f20b75a05f Re-structure enb metrics a bit. Create a generic mac metric struct and per ue mac metrics struct. 4 years ago
faluco 5529943172 Add a per sector rach preable counter for the metrics. 4 years ago
faluco dcd1157d39 - Prototype the extension of enb metrics. 4 years ago
Pedro Alvarez 7eebd71627 Added S1AP E-RAB release command/response handling to srsENB.
Added the ability to srsEPC to send the E-RAB release command.
4 years ago
Francisco cba0cc457f sched rand test refactor: creation of abstract sched simulator class for testing 4 years ago
Francisco b86d2ab7d0 move choice_type to adt folder 4 years ago
Codebot 43082e8d6a enb/ue: turn various warning messages into info
turn events that may happen in the normal life of a eNB/UE
into info rather than warning to allow strict
warning/error checking in tests.
4 years ago
Codebot f5d14d7649 polar_chain_test: fix compilation issue when AVX2 isn't used
this fixes compilation on aarch64:

FAILED: lib/src/phy/fec/polar/test/CMakeFiles/polar_chain_test.dir/polar_chain_test.c.o
/usr/bin/gcc -DENABLE_TIMEPROF -DENABLE_TTCN3 -DHAVE_5GNR -DHAVE_MBEDTLS -I/usr/include/SoapySDR -Ilib/include -I../lib/include -Wno-unused-but-set-variable -Wall -Wno-comment -Wno-write-strings -Wno-unused-result -Wformat -Wmissing-field-initializers -Wtype-limits -std=c99 -fno-strict-aliasing -D_GNU_SOURCE -O3 -fno-trapping-math -fno-math-errno -DBUILD_TYPE_RELEASE -DIS_ARM -DHAVE_NEON -DHAVE_NEONv8 -fvisibility=hidden -fdiagnostics-color=always -Werror --param large-function-growth=1600 -O3 -DNDEBUG -fPIE -MD -MT lib/src/phy/fec/polar/test/CMakeFiles/polar_chain_test.dir/polar_chain_test.c.o -MF lib/src/phy/fec/polar/test/CMakeFiles/polar_chain_test.dir/polar_chain_test.c.o.d -o lib/src/phy/fec/polar/test/CMakeFiles/polar_chain_test.dir/polar_chain_test.c.o   -c ../lib/src/phy/fec/polar/test/polar_chain_test.c
../lib/src/phy/fec/polar/test/polar_chain_test.c: In function ‘main’:
../lib/src/phy/fec/polar/test/polar_chain_test.c:214:11: error: unused variable ‘gain_c_avx2’ [-Werror=unused-variable]
  214 |   float   gain_c_avx2 = NAN;
      |           ^~~~~~~~~~~
../lib/src/phy/fec/polar/test/polar_chain_test.c:191:7: error: unused variable ‘errors_symb_c_avx2’ [-Werror=unused-variable]
  191 |   int errors_symb_c_avx2 = 0;
      |       ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
4 years ago
David Rupprecht 848496bb0f Moved get_earfcn to srslte get_carrier_freq func 4 years ago
David Rupprecht 2e51cfc1a5 Added black cells with index function
Added new index functios
Use asn1 list functions for toAddMod and toRem lists
4 years ago
David Rupprecht 96b75b6433 Fixes clang compiler error in case of UHD_ENABLE_RFNOC enable 4 years ago
Andre Puschmann c0883291f6 rlc: pass TTI to get_metrics to calculate "real" LTE rx/tx rate
when retrieving the RLC metrics, the number of TTIs since the last
call are passed. This allows to calculate the actual rate
based on the LTE timing rather than only the system timing.
4 years ago
Andre Puschmann cff9f03a11 rlc_am_lte: remove unused rx/tx metrics members
those variables aren't used and are included in the bearer metrics already
4 years ago
Andre Puschmann 3c169e6be1 rlc_am: increment retx counter for segments
we've only incremented the retx when retransmitting a full PDU,
but not when only retransmitting segments.

This might lead to many more retx than allowed.
4 years ago
Francisco b41fc96d6d fix asn1 integer packing for integer values whose length is equal or above 32 bits 4 years ago
Pedro Alvarez 38206bea69 Fixed RLC AM fixed header size in get_buffer_state function. Fixed RLC AM tests accordingly. 4 years ago
Francisco 99f94d9a1a Bug fixes of srseNB scheduler TPC
- fix encoding of TPC command
- use of exponential average with irregular sampling for the ULSNR average estimate.
  Turns out using a time-windowed average for the SNR was a bad idea.
  If the UL grants are very sporadic, the SNR time window will never have samples
  when a TPC is encoded
- update of TPC sched test
- other fixes in accumulators lib
4 years ago
Xavier Arteaga d6b5229dbe Added CSI-RS unit test and fix defects 4 years ago
Xavier Arteaga 6127681102 Added csi_rs header 4 years ago
Xavier Arteaga 08799cfe0f NR CSI-RS initial put/measure 4 years ago
Xavier Arteaga b7d74ef70b Initial CSI RS 4 years ago
Francisco 7ee99a529a fix assertion messages for bounded_vector::back() method 4 years ago
Francisco 5cce2e4dc7 extension of bounded_vector unit test and fix of compilation issues
- now bounded_vector::resize(N) works for move-only types
- bounded_vector assertions now print error messages
- fixed move ctor/assignment of bounded_vector
- created a unit test for bounded_vectors of move-only types
4 years ago
Francisco 2598989f7d replace msg3grant type from C-array to bounded vector 4 years ago
Francisco fc451f17f0 implementation of bounded_vector and respective unit test 4 years ago
Francisco 22229adf08 fix: normal phr is only sent for PCell 4 years ago
Francisco 69748e9313 fix compilation issue regarding definition of size_t in header and declaration of static member null_value in sliding average class 4 years ago
Francisco d42dc50c44 Write TPC sched unit test and fix sched logical channel test 4 years ago
Francisco 479602ed1d add option to specify target ul sinr for UL power control to the enb rr.conf parser 4 years ago
Francisco 5865df39d1 created class that implements the scheduler transmit power control and PHR handling 4 years ago
Xavier Arteaga 788ed5ce70 Corrected PDCCH SEGFAULT 4 years ago
Xavier Arteaga 8cc023e168 Fix PDCCH NR Test 4 years ago
Xavier Arteaga c0cdce6450 Updated license 4 years ago
Xavier Arteaga e07cf513d0 Improved NR blind search and DL test 4 years ago
Xavier Arteaga 90aa4fbea7 Improved srslte_chest_set_smooth_filter_gauss 4 years ago
Xavier Arteaga c635b1e467 Initial NR DCI blind-search 4 years ago
Xavier Arteaga 85d5026e38 Improved NR PDCCH unit test 4 years ago
Xavier Arteaga 315394560d Fix Polar unitialised read 4 years ago
Xavier Arteaga cd1aef7d76 Added NR PDCCH unit test plus fixes 4 years ago
Xavier Arteaga 53f6ac118e Initial PDCCH encode/decode 4 years ago
Xavier Arteaga 159a3d84bd Fix minor precoding issue 4 years ago
Xavier Arteaga 65d5fcf45d Add minor DCI location comment 4 years ago
Xavier Arteaga 67ce4c1491 Avoid std memory functions in EVM measurement 4 years ago
Andre Puschmann 00a6e16c14 update license header for liblte_*.{h,cc} files
user license-agnostic text to refer to license file.
make sure copyrights/years are correct.
4 years ago
Andre Puschmann 47c5f9e85b remove AGPL header from remaining cpp files
* also add commercial header to come CMake helpers
4 years ago
Andre Puschmann b9f363db9a ssl: rename liblte_ssl.h to ssl.h 4 years ago
Andre Puschmann ef19b1a9bd fix various uninit vars detected by cppcheck
non-critical fixes in tests mostly, still good to have those clean
4 years ago
Xavier Arteaga 81d72380b5 Reduce FEC Polar chain test time 4 years ago
Xavier Arteaga f9643843a0 SRSENB/UE Fixed NR workers 4 years ago
Xavier Arteaga b501f2eeaf SRSENB/UE: Added NR workers 4 years ago
Xavier Arteaga ac930003be SRSUE: Integrated NR workers 4 years ago
Xavier Arteaga 6fb56a3c62 LDPC: fix AVX tests compilation 4 years ago
Xavier Arteaga a908fb6c5b Fix NR srsue/srsenb. Initial PHY NR in SRSENB. 4 years ago
Xavier Arteaga eed9405e40 Moved NR MAX MIMO layers to carrier 4 years ago
Xavier Arteaga c6798653be SRSUE: created initial PHY LTE worker pool 4 years ago
David Rupprecht c9c8a1db5c Added toRemoveList function for rrc asn lists 4 years ago
Xavier Arteaga 31a637adae Fix UCI SCH threshold, cover PUSCH 64QAM, check UCI-ACK valid in PUSCH test 4 years ago
Xavier Arteaga 12c076bf96 updated copyright headers 4 years ago
Xavier Arteaga 24297f973c Removed CTTC from file headers 4 years ago
Xavier Arteaga 035fcc9afb Removed FEC working directory 4 years ago
Xavier Arteaga bde1fa703d Added Polar RM and removed vectors with malloc from FEC NR 4 years ago
Francisco 82d057345b fix compilation issue with user-defined fmt formatter 4 years ago
Francisco 86ab1864f7 The struct tti_point is now used ubiquitously in the scheduler 4 years ago
Pedro Alvarez 49bcffcdf8 Fix issue packing TEID in Error indication. 4 years ago
Francisco 8fb3ea6922 Added the ability to choose scheduling policy from enb.conf
- The two options provided at the moment are time-domain RR and PF
4 years ago
Andre Puschmann 07d2bc4fe8 change license header to agnostic version with hint to root LICENSE file 4 years ago
Francisco 2dc3fce9bd fix derivation of UL-64QAM support from the UE Capabilities in the eNB
Before this PR, the eNB was not activating UL-64QAM if the UE release was below 12,
due to an erroneous convertion of the ASN1 EUTRA Capabilities struct into the flattened
srslte::ue_capabilities_t.

With this PR, the eNB activates UL-64QAM for the following cases:
- UE category 5
- UE category 8 and release >= 10
- UE category UL 8 and release >= 12
4 years ago
Francisco f07e52129c increase mcs ul upper bound to 24 when ue is cat4 and enb supports 64qam. Simplified max_mcs computation 4 years ago
Andre Puschmann 477fe77f24 rlc_am: reformat log message for PDU retx 4 years ago
Andre Puschmann 6d3af2d2bd rlc_um: fix bearer name in logging after re-configuration
the RLC bearer name was empty after reestablishing a UM bearer.

we need to pass the RLF config and RB name to the internal configure()
call of the Rx entity, like we already do for the Tx side
4 years ago
Xavier Arteaga 225bc9d260 Enable FEC SIMD acceleration 4 years ago
Jesus Gomez c9cdb0d53c Solve Issue 1: Invalid read in LDPC AVX2 Encoder/Decoder 4 years ago
Andre Puschmann d014a89cfb pdsch_ue: enable EVM measurements for PDSCH
enable EVM measurements by default and print them in to stdout.
This is very useful for manual receiver calibration with the
PDSCH eNB example.
4 years ago
Andre Puschmann 504d8fd9f0 pdsch: calculate average PDSCH EVM over all decoded codewords
when EVM measurements are enabled, instead of only logging them for
each decoded codeword, we also calculate the average.

this is useful for calibration.
4 years ago
Andre Puschmann cfee074756 pdsch_enodeb: add tx gain control over page-up/down keys
this allows to modify the tx gain of a running pdsch_enodeb
with the page-up/down keys in 1dB steps
4 years ago
Andre Puschmann 382f56fbea pdsch_{ue,enodeb}: add -Q switch to enable use of standard LTE rates
this is useful for RF equipment that doesn't support the shorter symbol
size we use by default, e.g. the N310
4 years ago
Xavier Arteaga 755325fc3e Avoid sizeof and standard memory functions 4 years ago
Xavier Arteaga 35bf5b8c6d Added generic memory malloc 4 years ago
Xavier Arteaga 83dddae525 Added vector zero 4 years ago
Xavier Arteaga a5537cc1ef Correct argument 4 years ago
Xavier Arteaga b7fc2299e5 Softbuffers initialise buffer pointers with zero memory 4 years ago
Andre Puschmann 7f81f44427 rf_uhd: treat N3xx like the X3xx and do not set timespec on every burst iteration
the N310 too doesn't seem to like setting the timespec for each call to
send in a single burst
4 years ago
Francisco 7a74bf28d1 forward declare s1ap types in enb interfaces 4 years ago
Francisco 66712023bb remove unneeded includes of full rrc asn1 lib 4 years ago
Francisco 0ffea62411 Wrote logging functions for SCHED MAC CE/LCID allocations 4 years ago
Francisco 68eda336bd remove ENB_METRICS_MAX_USERS compile time macro and use run-time variable to set maximum number of UEs the srseNB can have connected at a given instant. 4 years ago
Pedro Alvarez d05bc064b5 Reduced SCTP connect() timeout.
Added configuration for RTO_MAX. Cleanup debug prints.
4 years ago
yagoda bdc1964335 consolidating RRC eMBMS configuration into single function, setting some parameters to const 4 years ago
yagoda b90574975b refactoring asn1 eMBMS code, removing asn1 from PHY and MAC in eNodeB 4 years ago
Francisco 1cb65f07f1 enable meas gaps in RRC and enb parser 4 years ago
Xavier Arteaga c2bc042713 Disable SIMD AVX decoder 4 years ago
Francisco Paisana 9579931f16 added meas gap checks to scheduler ue 4 years ago
Andre Puschmann 43a6cd50e5 rf_imp: fix stopping of AGC thread
hard killing of AGC thread causes issue on some RF devices,
such as the N310. The thread still seemed to access the device while
the radio was already killed (or the streamer object deleted).

It's unclear why this isn't causing similar issues on B210 or X310,
at least not visible, but it is obviously not the correct way to stop a thread.

The patch now correctly sets the stop flag for the AGC thread, wakes it
it up and waits until it has terminated.
4 years ago
Xavier Arteaga 7495986b5c Minor aesthetic changes and fix memory issue 4 years ago
Xavier Arteaga 0396ebae17 Fix UE/ENB DL NR 4 years ago
Xavier Arteaga 8de2870788 Added NR ue_dl, enb_dl and test 4 years ago
Xavier Arteaga 6b5c4148c8 DL Channel estimation results accepts nof RE 4 years ago
Xavier Arteaga ce330a6dfb OFDM's DC is optional 4 years ago
Xavier Arteaga c6a2e4578e Refactored PHY object arguments 4 years ago
Xavier Arteaga e621a1cde3 EVM buffer takes number of bits 4 years ago
Xavier Arteaga a278a49e42 Limit PDSCH-NR unit test 4 years ago
Xavier Arteaga bff71761a9 PDSCH-NR: Added single layer channel equalization 4 years ago
Xavier Arteaga 0138c3b856 PDSCH-NR fixed with unit test 4 years ago
Jesus Gomez 6defd2658c Solve Issue 2: Rate matching zeroes output data prior to soft-combine 4 years ago
Xavier Arteaga fb64c2a460 Initial NR PDSCH encode/decode 4 years ago
Xavier Arteaga 666ba7d590 Added unpacked bit sequence XOR 4 years ago
Xavier Arteaga 6df83c32b3 Added NR layer mapper and demapper 4 years ago
Xavier Arteaga 3060972514 Removed redundant softbuffer dependency 4 years ago
Xavier Arteaga 644758416e DL-SCH-NR adjust unit test 4 years ago
Xavier Arteaga d27f0819a8 Fix DL-SCH for NR 4 years ago
Xavier Arteaga 53282bdfbf Dl-SCH-NR: updated unit test 4 years ago
Xavier Arteaga 4e5edb5168 DL-SCH NR added traces and fixes 4 years ago
Xavier Arteaga 2aa7e43771 Implemented NR DL SCH decoder and unit test 4 years ago
Xavier Arteaga 3464dd3c0d Added MCS table string serializer 4 years ago
Xavier Arteaga 794d1b5c4b Added LDPC decoder RM interface 4 years ago
Xavier Arteaga fa691bb8e3 Fix softbuffer 4 years ago
Xavier Arteaga 27a3e87fb7 Initial DL-SCH encoding 4 years ago
Xavier Arteaga bc66942b8d Bit unpacking input to constant 4 years ago
Xavier Arteaga 9a320baf37 extended resource allocation for NR 4 years ago
Xavier Arteaga 766a43225d 5G FEC extension 4 years ago
Xavier Arteaga 30037d9223 Added guru softbuffer interface 4 years ago
Xavier Arteaga 8e8889032e Changed CRC input vector to constant 4 years ago
Xavier Arteaga f64c268a69 SRSUE: Refactored MAC/RRC SCell Activation/Deactivation 4 years ago
Andre Puschmann ff5f215df9 rf_soapy: print warning when using the Lime with shorter sample rates
the Lime has better performance when using the default LTE sample
rates due to filterering being done in the LMS RF chip.

Print a warning when using the Lime with the non-default LTE rates.
4 years ago
Andre Puschmann 2c797fce1a phy_common: add method to check whether we use default LTE symbol size
helpful getter to check whether we've compiled in
or selected at run time to use default LTE sample rates
4 years ago
Xavier Arteaga a6ac80cfbf Initial NR DL DCI Packing/Unpacking 4 years ago
Francisco Paisana fdec451a9d disable mcs>20 if eNB supports UL 64QAM but UE doesn't 4 years ago
Francisco Paisana bf7c587e4f add UL 64QAM support to eNB RRC and scheduler 4 years ago
Andre Puschmann 5f7f818abb pdu: fix bug in BSR table lookup
the bug causes the BSR to return a bsr_idx of 0, i.e. no data
pending, when the buff_size was reported to be 1 B only.

Instead, the UE should return BSR idx 1, i.e. between 0 < BSR <= 10.
4 years ago
Andre Puschmann e227fec3d8 pdu_test: add rigerous test for LBSR content
* make sure upper and lower edges of Table 6.1.3.1-1 in 36.321 are correct
* fix existing BSR test vectors (verified with Wireshark)
4 years ago
Andre Puschmann 286844b3dd mac_pdu: reset subheader state when deleting from PDU
when packing MAC PDUs, adding a new SDU might fail, for example
because RLC couldn't provide a new PDU. The muxer then needs
to delete the subheader from the PDU again.

When adding a padding BSR at the end, the same subheader is again
used to store the BSR, so any state in that subheader should be removed.

In the particular case, this was causing an issue when logging a LBSR
because the LCG buffer states are printed using the payload buffer,
which was still pointing to some memory that was used when trying
to add the new RLC PDU in the beginning.
4 years ago
Andre Puschmann 035d989737 pdu: fix unpacking of LCG2 of LBSR MAC CE
LBSR packing is fine but this makes the eNB do wrong things
because it thinkgs LCG2 has no or too much data to send.

LCG2 is our default LCG for DRB1. One occasion we saw the issue
is doing full rate TCP DL which requires quite a bit of ACK traffic
back to the sender. With the BSR for LCG2 being wrong, providing
UL grants was delayed and so the TCP DL throuhgput was very low.

In the log below we see that the buff_size[2]=1 so there is data to send.
Interestingly, the packing was correct so Wireshark displays it correctly.
But the unpacking not, as can be seen in the MAC log below which reports
0 buffer state for all LCGs

22:08:54.804792 [MAC ] [I] [ 5084] pdu_get: sdu_len=1212, channel.sched_len=1213, bsr.buff_size[2]=1
22:08:54.804840 [MAC ] [I] [ 5084] UL LCID=3 len=1212 LBSR: b=0 0 0 0
4 years ago
Xavier Arteaga cf55eb4c4f Improved comments 4 years ago
Xavier Arteaga e8f94c40b8 Added LDPC codeblock segmentation 4 years ago
Xavier Arteaga fc3d154fe3 Fix compilation 4 years ago
Xavier Arteaga 736e6db616 Initial resource allocation for NR 4 years ago
Xavier Arteaga 0439161de6 Removed modulation enum from LDPC RM 4 years ago
Pedro Alvarez 454162cea7 Deleted nas_interface_stack. 4 years ago
Pedro Alvarez 604e79214d Changed NAS is_attached interface to is_registered. 4 years ago
Pedro Alvarez 14844a168a Created new class to hold all NAS states for the NAS state machine. Added EMM-DEREGISTERED substates and EMM-REGISTERED substates.
Decoupled PLMN selection, attach request and service request. Removed RRC connect procedure from NAS.
4 years ago
Andre Puschmann 6773f6d02f pdu_queue: add reset method to empty queue 4 years ago
Francisco Paisana 88105c1577 change the namespace of tti point helper functions for the eNB 4 years ago
Andre Puschmann f155b7a5d5 rlc: fix stopping of poll retx timer (#2006)
* rlc_am: add TC for pollRetx timer handling

* rlc_am: fix stopping of pollRetx timer

stopping the pollRetx timer when receiving a status PDU
without checking the acknowledged PDUs is wrong.

if an ACK for another PDU, for which the polling bit has been set,
is still pending, it won't be rescheduled until another
PDU is transmitted that again starts the pollRetx timer.

this fixes the issue with missing RLC AM segment retx in #1992,
and #2003
4 years ago
Andre Puschmann 7cf919e2af Fix MAC PDU packing after sending Truncated BSR (#2004)
* mac_test: add extended TBSR unit test

unit test to MAC UL packing after sending a TBSR

this fixes the MAC issues described in issue #2002

* mux: fix updating of LCG buffer state after packing PDU

we've previously lowered the buffer state of the LCG according
to the bytes that have been scheduled, but not according to
those that have been actually included in the PDU.

* proc_bsr: fix LCG buffer state updating for TBSR

when sending a TBSR do not update the internal buffer
state of the BSR proc.

This caused issues because the buffer state for all LCG that
are not included in the TBSR are set to zero, although at least
one LCG does have data to transmit.

* rlc_am: include LCID when logging retx of SN
4 years ago
Andre Puschmann 1b97ba5300 benchmark_radio: fix duration and thread priority
I noticed that the app didn't configure the process with
RT thread prio. But it then turned out that in order to do
that we need to actually spawn a new thread. Also a few other things
didn't work out of the box.

In summary the changes are:
* fix duration to support more than 120s
* move main functionality in thread
* set high priority for radio thread
* only return success if no radio errors occured
4 years ago
Francisco Paisana 510959b50f update nr asn1 files, and asn1 tests 4 years ago
Xavier Arteaga 8d9577626b Fix NR FEC unit test 4 years ago
Xavier Arteaga 0c2f96d389 Fix 5G NR FEC memcheck 4 years ago
Xavier Arteaga 2835e87ff0 Add missing file 4 years ago
Xavier Arteaga f8dd67260f Polar: fix unit test working directory 4 years ago
Xavier Arteaga 15356b3ec8 Fix compilation for non-AVX2 machines 4 years ago
Xavier Arteaga 2c4aa1e379 Added Polar and LDPC forward error correction 4 years ago
David Rupprecht 387a84ff84 Updated missing byte 4 years ago
David Rupprecht b85cb614aa Added test cases for asn1 decoding lib from pcap 4 years ago
Xavier Arteaga 271002c9fb Fix compilation 4 years ago
Xavier Arteaga 4f89c6ed3f Added missing CMakeFiles 4 years ago
Xavier Arteaga f21590735d refactored FEC directories 4 years ago
Xavier Arteaga 7093a85f81 Refactored FEC directories 4 years ago
Xavier Arteaga c2621cc4f8 Protect ring-buffer write from nullptr 4 years ago
Francisco Paisana a865858db3 disable srbs UL during handover to avoid UL grants and scheduling requests before the handover is complete 4 years ago
Andre Puschmann f647343f18 rlc_am: fix poll bit during header reconstruction
this makes sure that the reconstructed RLC AM header
has the poll bit set when any of its segments had it set.

this triggered a bug in RLC AM because the Status PDU
isn't transmitted for a RLC PDU that was segmented and
only the first segment had the P flag set.
4 years ago
Francisco Paisana b40a5a958e use common function to fill rrc reconf message in handover 4 years ago
Francisco Paisana e9b693942f diff-based cell selection activation 4 years ago
Francisco Paisana 836e7d7ede refactor scell addition in the srsenb::rrc to follow the same style of other rrc recfg fields 4 years ago
Francisco Paisana f26b5ccde7 fix drb reestablishment during handover 4 years ago
Francisco Paisana 97f2e4336e refactor of functions for filling the asn1 radio resource config structs. This functions are used during rrc setup/reest/reconf 4 years ago
Xavier Arteaga 9487d27ef9 Renamed NR constants and comments 4 years ago
Xavier Arteaga e8f168b20c PDSCH NR: Added files 4 years ago
Xavier Arteaga c8477483d9 PDSCH NR: Added files 4 years ago
Xavier Arteaga 30d8e05d50 Fix PDSCH-DMRS symbol index 4 years ago
Xavier Arteaga 275cbafe6e Modified comments 4 years ago
Xavier Arteaga 8d34d344a8 Created PDSCH-NR configuration structures and refactored DMRS 4 years ago
Xavier Arteaga 009f300c5e Initial PHY Data procedures 4 years ago
Xavier Arteaga 775692f461 Rearanged PDCCH NR functions structures 4 years ago
Xavier Arteaga 452eb2dbbf Updated some DOCS 4 years ago
Xavier Arteaga 937c52339d Added PDCCH DMRS estimation and measurement 4 years ago
Xavier Arteaga 5799100e42 FFT based Resampler admits NULL inputs/outputs 4 years ago
Xavier Arteaga 44ae70dcc6 Initial implementation of the 5G NR PDCCH DMRS encoding 4 years ago
Xavier Arteaga 29ad2427d9 Initial implementation of the 5G NR PDCCH DMRS encoding 4 years ago
Xavier Arteaga 579526f1fe Added sequence advance without generating data 4 years ago
Xavier Arteaga eba20b6367 Radio: fix frame overlap at start-of-burst 4 years ago
Xavier Arteaga be400503b9 Add pass criteria to PRACH USRP test 4 years ago
Xavier Arteaga 28bb4709ff Solved possible high impact PHY out-of-bounds issues 4 years ago
Pedro Alvarez e4f143059e Simple log fix to make it easier to compare PDCP RX and TX. 4 years ago
Xavier Arteaga 58be68f856 Changed cell gain command from cell index to cell id 4 years ago
Andre Puschmann 0740154bff rrc,sync: fix two uninit vars
detected by Valgrind when running UE with TDD cell
4 years ago
Andre Puschmann 723ca2dd48 ra_dl: fix TDD reference symbol extraction
reported/provided by user softdev86 in https://github.com/srsLTE/srsLTE/issues/566

author tested with local 4 port cell. I am not able to verify locally but
it looks ok, we'll revise later if needed.
4 years ago
gracid f67a152a2a Remove unnecessary Lime calibration step from Soapy implementation
When using srsLTE with Lime devices, calibration was performed before any configuration steps have happened, thus making calibration values invalid. Removing Lime specific calibration step from rf_soapy_imp makes so that devices will be automatically calibrated by SoapyLMS on rf_soapy_start_stream call.

Tested and working with srsENB using LimeSDR-USB v1.4 and LimeSDR-Mini v1.2 boards.
4 years ago
gracid 78b63c9465 Set same antennas for all Soapy channels
This commit adresses an issue where two or more channels could have different antennas, despite being explicitly set in the configuration file
4 years ago
Francisco Paisana 4cb6ed27eb updated scheduler ue mcs computation to account for new 256QAM tables 4 years ago
Francisco Paisana c7697b62a6 fix asn1_utils_test. arrays used for equal comparison where not being initialized. 4 years ago
Xavier Arteaga fac6d40a45 SRSENB: fix PUSCH max number of iterations 4 years ago
Xavier Arteaga 791c979063 Vector: fix cf to cs conjugate conversion 4 years ago
Francisco Paisana 698af97ec4 updated asn1 utils to account for conversion from 0 to bitstring. Added asn1 utils test to repository. 4 years ago
Andre Puschmann 5e7de0a95b cmake: install individual libraries (common, phy, etc)
this seems to be important for package maintainers
or people who use srslte components in other projects
thar require to link against static libs

so besides installing headers, the apps and the RF lib, we also
install all individual libraries

this fixes https://github.com/srsLTE/srsLTE/issues/500#
and https://github.com/softwareradiosystems/srsLTE/issues/1754
4 years ago
faluco 8376111419 - LGTM fixes. 4 years ago
Xavier Arteaga caf37b8e62 Added serving cell index in UCI/CSI report trace 4 years ago
Douglas Anderson fe21b2717c Fix "Comparison is always true because ret >= 0" LGTM warnings
... and refactor out some other dead code in the vacinity of these warnings
4 years ago
Andre Puschmann 48e7734188 phy_dl_test: fix uninit var 4 years ago
Andre Puschmann 1a03839f78 rlc_am_lte: fix potential bug when setting uint32_t to -1
discovered in Coverity CID 359664
4 years ago
Andre Puschmann bb1dd0f4cf gnb_interface: remove FIXME 4 years ago
Francisco Paisana 665b3996bb now the phy controller handles the scenario where the phy cell selection failed to be initialized 4 years ago
Pedro Alvarez 4c1416b84f Remove redundant declaration of EIA2 4 years ago
Andre Puschmann 5a31c5765b rf_soapy: fix auto selection of Soapy device
when the default RF args are used, NULL is passed as argument
to the RF driver. In this case, we should use the previous
SoapySDRDevice_enumerate() and let Soapy pick the device
4 years ago
Francisco Paisana 9b10acff06 implemented logical channel prioritization in DL scheduler 4 years ago
Xavier Arteaga ca6566ad46 Fix PUCCH format1b false detection 4 years ago
Andre Puschmann fab86382c1 mac,rrc: add interface to set SR config explicitly without touching any other MAC function
when releasing PUCCH/SRS (see 5.3.13 in 36.331) we need to reset the SR config as well.
In our case, SR is handled by MAC so we need to (re-)configure MAC, not all of
MAC though, just SR.
4 years ago
Francisco Paisana e7239163e9 silence noisy unhandled in_sync_ev logs 4 years ago
Francisco Paisana b7ed8b1858 - added react method to to_state<...> transitions
- s1 handover composite state simplified
- the eNB now starts a HO cancellation when it receives an invalid
Handover Command
- the FSM log now prints the current state when it receives an unhandled
event
4 years ago
Andre Puschmann 30b8848ea9 metrics_hub: protect access to vector of metrics_listener
prevent potential race between metrics hub thread trying
to access the metrics vector and another thread
adding another element to it
4 years ago
Pedro Alvarez b43e724b4c Remove packing/unpacking code for M2AP. 4 years ago
Pedro Alvarez 5a4e71a6e4 Created k_enb_context structure that holds k_enb, NCC and NH to make it easier to restore context from failed handover. 4 years ago
Jan Remeš 8c7b7cc55a libsrslte_rf: add library version
This patch adds version string to the 'libsrslte_rf' library.
This results in the library being built as
    libsrslte_rf.so.20.04.2
with the following symbolic links
    libsrslte_rf.so.0 -> libsrslte_rf.so.20.04.2
    libsrslte_rf.so -> libsrslte_rf.so.0

The SRSLTE_SOVERSION variable should be increased with each backwards
incompatible change of the library.

Signed-off-by: Jan Remes <jan.remes@invasys.com>
4 years ago
Pedro Alvarez 00ac85e1b3 Small compilation fixes for GCC 10.1 4 years ago
Xavier Arteaga da54e2b501 Better docs in RRC interface types and apply clang-format 4 years ago
Xavier Arteaga 6ae47b6510 SRSUE: Deafult PUCCH/SRS does not imply full PHY dedicated defaults 4 years ago
yagoda 615af5cc4d setting seed to constant in prach test 4 years ago
Andre Puschmann b08a586fd4 pdu: refactor error logging
just some refactoring of error messages when a PDU packing error occurs
4 years ago
faluco 693d2f10b7 - Fix hex dumps newlines. 4 years ago
Pedro Alvarez 2f0125ef4e Fix issue recovering key state, when the first HO fails (specifically, is_first_ncc was not recovered). Minor improvements in key logging. 4 years ago
Francisco Paisana 137e554eb3 reestablish pdcp bearers is required in case of AM bearers 4 years ago
faluco 079ae70e64 - Fix logs entries having two newlines instead of one. The old log formatter will delegate this to the new one. 4 years ago
Andre Puschmann f73fa47a7b pdu: fix printing of buffer state of long BSR
extracted wrong number of bits for 2nd LCID in long BSR
4 years ago
Xavier Arteaga ef9d77c966 SRSUE: add PRACH config present field in PHY configuration structure 4 years ago
faluco 51b27fc255
Import latest srslog version (#1796)
* - Import latest srslog version.
- Adjusted the nas_test to create logs correctly.
- Remove timestamp formatting now that is provided by srslog.
4 years ago
Ismael Gomez 4e88daae21
Set DCI unpacking errors to info (#1781) 4 years ago
faluco 85544bb8d3 - Remove unnecessary newline character and optimize the code to use fputs instead of fprintf since no formatting is required. 4 years ago
faluco dfeed52514 - Rename out_stream function to console. 4 years ago
faluco 62faef7c71 - Replaced all uses of the log::console method. 4 years ago
faluco 302f9793ca - Add common utils to print to stdout and stderr as a first step to remove the log::console method. 4 years ago
Andre Puschmann 58ce9d3959 pdcp: adding basic test to check if control PDUs are handled correctly
use a 3 B long status PDU to check if its dropped from the rx'ing entity
4 years ago
Andre Puschmann 795db30338 pdcp: drop PDCP control PDUs
this patch adds a check to drop all PDCP control PDUs
in order to prevent handling them as data PDUs.

This could happen when the size exceeded the arbitrary length check.

This should fix #1787
4 years ago
Sylvain Munaut 2890bd07ea liblte_mme.h: Adjust LIBLTE_MME_PACKET_FILTER_MAX_SIZE for IPv6
Original was 20 but TS 24.008, section 10.5.6.12 specifies a max
of 60 for ipv6 packet filter
4 years ago
Xavier Arteaga d375e305ec Initial NR DMRS for PDSCH 4 years ago
Ismael Gomez 76bfc78147
Fix issues with Sounding-RS (#1761)
* Fix deadlock caused by update_measurements calling in_sync

* Fix overlapping SRS condition

* Do not use shortened PUSCH in transmissions and retx from RAR

* Revert "Fix deadlock caused by update_measurements calling in_sync"

This reverts commit f58c8c8c766f8f95baa3a3bf8287d8e25b2057ba.
4 years ago
Pedro Alvarez 86f4d469c6 Added some functions to save and restore AS keys for the case of failed handover in the USIM 4 years ago
Ismael Gomez b94d24ed98
Take into account CRS from neigbhour cells when measuring interference (#1757)
* Take into account CRS from neigbhour cells when measuring interference

* fix std::isnormal compilation

* Fixed compilation of test

* Address comments

* Remove unused overrides
4 years ago
Xavier Arteaga 236ef4378d Fix u32 parsing 4 years ago
Xavier Arteaga ede58319ae Vector: added conjugate complex float to short 4 years ago
Xavier Arteaga 8566cbb079 Added device name to prach_test_usrp 4 years ago
Xavier Arteaga 60d563aa06 Fix ringbuffer read conversion 4 years ago
Xavier Arteaga eb5210dbda Radio stops Rx stream prior to stop and benchmark prompts RF metrics 4 years ago
Xavier Arteaga de0501cc55 Fix radio benchmark 4 years ago
Xavier Arteaga c20d4ff5cc Added ringbuffer zerocopy a timeout 4 years ago
Xavier Arteaga 759719ad55 Improved RF helper 4 years ago
Andre Puschmann 1afc137032
[REBASE] Make PHY non-blocking and fefactor HO procedure (#1753)
* Make PHY non-blocking and fefactor HO procedure

* makes entire PHY non-blocking through command interface
* adds dedicated queue for cell_search/cell_select commands
* refactor HO procedure to run faster, in one stack cycle. Looks closer to the specs
* force ue to always apply SIB2 configuration during reestablishment
* Run update_measurements in all workers

Co-authored-by: Ismael Gomez <ismagom@gmail.com>
4 years ago
faluco c1e680769c - Remove stray code left behind. 4 years ago
faluco f604506858 - Fixed missing initialization issues in nas that caused several jumps in liblte_mme to use uninitialized memory.
- Fixed missing initialization in spgw that caused recvfrom to use an unitialized argument.
4 years ago
faluco f0d651ae8e - Fixed a leak in the MME class not releasing the static byte buffer pool.
- Now the pool gets destroyed on program exit using a unique_ptr.
- Removed manual cleanup() calls in all the code base to free the pool instance.
4 years ago
Francisco Paisana dcf5a727f2 do not send RRC release in case the eNB receives a S1AP UEContextRelease command and the UE is doing handover. Handle GTPU end marker 4 years ago
faluco b892da0294 - Calculate the FFT of the PRACH on demand.
- Fixed a PRACH test that was failing with ASAN.
4 years ago
Xavier Arteaga 8cb3945886 SRSUE: fix RV assertion for PUSCH 4 years ago
Xavier Arteaga 44c2412be2 SRSUE: silent PUSCH encoding error by dropping invalid grant 4 years ago
Andre Puschmann 9dd02af15c network_utils: lower verbosity of when socket connection fails
the network helper can log this event but it should be up to
the caller to decide whether this is an error or not.
4 years ago
Andre Puschmann 6dc7841369 epoll_helper: move code to block OS signals into own helper function
before epoll can handle signals, the calling thread needs to block
them. the blocking needs to happen before any other threads get
spawned so they inherit the mask.
4 years ago
Andre Puschmann 33c050791f pdu: add missing to_string() content for MAC SCH PDU subheaders
* add both scell activation CE
* add rnti to CRNTI and CONT RES CE
4 years ago
Xavier Arteaga 1d71cf8557 Avoid zero division 4 years ago
faluco 5e8a4c898d
Bring back the circular array object. (#1712) 4 years ago
Andre Puschmann 6a56476b2a rlc: increase RLC Tx SDU queue
the Tx SDU has been set to 128 PDUs because this gives approx.
150kByte UL buffer state (max value for Rel 8 BSR).

Previously, however, we've always reported too much pending UL
data because we weren't subtracting the transmitted data from
the reported data.

with this newer BSR reporting, however, even with full buffers we would
never report full buffers because the queues size is too short.

This seems to cause issues for iperf TCP sessions not resulting
in full DL rate, see isse #1703. It seems that the TCP bandwitdh
probing works better with larger buffers (in our case this can
only be achieved with more PDUs in the pool).

This should fix #1703
4 years ago
Andre Puschmann 569d8ee860 rlc: remove unused macro
this seems to be a legacy copy of the RLC_TX_QUEUE_LEN macro
in rlc_interfaces_types.h
4 years ago
faluco 1860006203 - Fixed leaks in prach module spotted by asan. 4 years ago
Andre Puschmann e80aa0a553 add circular array class to simplify access to truly circular arrays 4 years ago
yagoda 24574caf44 cleaning up the PRACH time offset calculation 4 years ago
yagoda b5a8d82058 -adding more prach tests to make test, removing some variables from stack
-PRACH time offset to TA unit conversion
4 years ago
yagoda 59082770d3 moving some arrays to the heap, fixing formatting, setting dft norm 4 years ago
yagoda f6ea431555 -adopting new PRACH equalization approach for successive cancellation
-adding frequency domain time offset detection
-adding to testing of PRACH
4 years ago
yagoda ec7873e7cc refactoring PRACH, adding phase correction to successive cancellation 4 years ago
yagoda 4d8888aae6 - adding simple successive cancellation to PRACH detection
- adding testing for same and for offset detection
4 years ago
Ismael Gomez 1bd3e76f98 Move unncessary buffer in radio 4 years ago
Ismael Gomez c4080e35cc Set different timestamp behaviour for X300 and B200 4 years ago