5g-team
/
srsRAN_4G
mirror of https://github.com/pvnis/srsRAN_4G.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,470 Commits
2 Branches
0 Tags
243 MiB
fix-cqi
master
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '91f47de3cc'
${ noResults }
Commit Graph

3070 Commits (91f47de3ccd1cb1883a0c2097d5875a6c384ed6d)

Author SHA1 Message Date
Xavier Arteaga 98929c95a8 Initial UE DL NR file test 3 years ago
Xavier Arteaga dcf9ae039c Fix related Sidekiq comments and mutex 3 years ago
Xavier Arteaga b3d9a94dd5 SIDEKIQ: fix tx time protection 3 years ago
Xavier Arteaga ecf668ee9e SIDEKIQ: fix comment 3 years ago
Xavier Arteaga 96ee4b7258 SIDEKIQ: Initial implementation 
SIDEKIQ: Add SKIQ_FOUND to RF found condition

SIDEKIQ: finished SKIQ component abstraction

SIDEKIQ: fix issues and added external PPS example

SIDEKIQ: add PPS test card index argument

SIDEKIQ: improvements

SIDEKIQ: improved srate change

SIDEKIQ: more improvements

SIDEKIQ: more fixes

SIDEKIQ: fix Rx ch gain

SIDEKIQ: Fix multi-card synchronism

SIDEKIQ: Better Rx gain tracking
 3 years ago
Robert Falkenberg 24e52d6291 soapy: fix array parameter mismatch for some functions 
With soapy 0.8.0, GCC 11.1.0 warns of mismatched array bounds
in some functions.
This commit aligns the bound and adds proper wrappers to
fix subsequent warnings.
 3 years ago
Francisco Paisana bc5a548fe8 sched: scheduler now accounts for prachs with different durations 3 years ago
Xavier Arteaga bb4f469794 Integrated SR decoder in gNb 3 years ago
Xavier Arteaga 6a9baef11d Limit DMRS PUCCH SNR to void NAN/INF 3 years ago
Xavier Arteaga d783fbf3a0 Reviewed NR procedure for PUCCH resource sselection and reviewed gNb PUCCH interface 3 years ago
Xavier Arteaga 64f4767c4f Fix NR PUCCH decoder memory access 3 years ago
Andre Puschmann c9c3a68fae asn1,rrc_nr: add error code handling to packing/unpacking of pdcch_cfg 3 years ago
Ismael Gomez 6fb9b6bf94 Fix sub-band CQI in UE. Refactor variable names 3 years ago
Ismael Gomez 2e1127f385 Add sub-band CQI periodicity and configuration to lib 3 years ago
Ismael Gomez 3f5094f30e Remove confusing subband_size variable and replace with subband_wideband_ratio 3 years ago
Francisco Paisana 1535e6b205 sched,nr: extend sched nr testing suite. restrict paralllelization for correct DAI generation 3 years ago
faluco 8708043a5f - Add date to log timestamps. 
- Print once per second the current timestamp into stdout, feature guarded by a config expert option.
 4 years ago
Andre Puschmann ff5fe5df14 rf_uhd_imp: fix race in RF metrics 4 years ago
Pedro Alvarez 8d41c0d476 Maded SRB configuration optional in rb.conf 4 years ago
David Rupprecht d990db66f6 Added syslog logger 4 years ago
Xavier Arteaga b25681f9de gnb,prach: add PRACH to gNB 
rebase of Xavier's feature_gnb_prach branch
 4 years ago
David Rupprecht e0b09f1301 Fixed coverity findings 4 years ago
Andre Puschmann 6c82d63aa6 remove legacy PNF/VNF code 
the code hasn't been maintained for a while an likely needs to be
adapted for a real-world scenarios.

in order to avoid having to maintain two MAC/PHY interfaces we
remove the code from now.
 4 years ago
Xavier Arteaga 54a12870ec SRSUE: avoid negative SR transmission in NR 4 years ago
Xavier Arteaga 603c67e36d Set g_ulsch LLR overlaped with g_harq_ack to zero 4 years ago
Xavier Arteaga 3416aad16d Fix PUSCH NR test false alarm 4 years ago
Xavier Arteaga 04aca98e5f Added more checks in PUSCH NR test 4 years ago
Xavier Arteaga ef865b81a3 NR SCH TB information prints actual rate and not the target rate 4 years ago
Xavier Arteaga 11a52248cd RA NR Calculates actual PUSCH rate 4 years ago
Xavier Arteaga 35840d6bc1 Removed all zero condition from LDPC decoding 4 years ago
Xavier Arteaga 64b7dfed65 UHD: fix nullptr buffer 4 years ago
Xavier Arteaga ecc0b92142 Integrated PUSCH decoder in gNb 4 years ago
Xavier Arteaga f07d925be1 Initial NR PHY test scheduling for PUSCH 4 years ago
David Rupprecht 724af2b060 Added nas 5g msg packing and unpacking 4 years ago
Andre Puschmann fa461f0129 rrc_nr: fix linker error in setup_release_c 
move implementation to cc file to avoid

[build] /bin/ld: CMakeFiles/rrc_nr_asn1_test.dir/rrc_nr_test.cc.o: in function `asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::set_setup()':
[build] /home/anpu/src/srsLTE/lib/include/srsran/asn1/rrc_nr.h:2276: undefined reference to `asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::set(asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::types_opts::options)'
[build] clang: error: linker command failed with exit code 1 (use -v to see invocation)
 4 years ago
Andre Puschmann 4379c20eb9 rlc_am_lte: avoid locking of Rx mutex twice when generating status PDU 
call reset_status(), which now is an private method directly when
building a status PDU. No need for the Tx side to call Rx again.
 4 years ago
Andre Puschmann 53a7dc78ee rlc_am_lte: replace do_status boolean with atomic 
the do_status is queried from the Tx code frequently. To reduce
chances to delay the execution because the RLC Rx side is currently
holding the mutex we can use an atomic.
 4 years ago
Xavier Arteaga 5307fec2f0 Added GNB MAC UL info initial interface and fix PHY implementation 4 years ago
Xavier Arteaga cf496e75eb Fix default PHY NR configuration 4 years ago
Xavier Arteaga 2fbd172888 Initial PHY NR configuration generator 4 years ago
Xavier Arteaga e764a26136 Integrated PUCCH decoding in gNb 4 years ago
Xavier Arteaga 3fe9176750 Added PUCCH dedocder to slot worker 4 years ago
Xavier Arteaga e3afd945bc Refactored NR HARQ ACK feedback 4 years ago
Xavier Arteaga 658b47d917 Added NR PUSCH and PUCCH decoder in gnb_ul 4 years ago
Xavier Arteaga f6fc215541 Refactored enb_dl_nr to gnb_dl and initial gnb_ul 4 years ago
Xavier Arteaga eecaccb541 Added NR PHY helpers 4 years ago
Andre Puschmann f292042f66 rlc_am_lte: use try-lock when building status PDU 
the patch uses try-lock whenever a status PDU is tried
to be built. This makes sure that when the lock is currently
hold (e.g. by a thread processing rx PDUs) the generation
of the status PDUs is not taking too long and blocking the calling
thread. Instead the status PDU generation is deferred to the next
Tx opportunity.

It's a probabilistic approach that assumes that at some stage the
lock can in fact be acquired.
 4 years ago
Andre Puschmann a9d21696c5 rlc_am_lte: make number of RLC SDUs per PDU a compile-time parameter 
this allows to set the maximum number of RLC SDUs included
in a single PDU at compile time.
 4 years ago
Andre Puschmann bbcaa49429 network_utils: fix TSAN detected race 4 years ago
Andre Puschmann 0e6e3d201e sys_metrics: reduce log level when measurement interval is shorter than expected 
on highly loaded systems it can happen that the get_metrics() is called
twice within a few houndred milliseconds. Logging a warning in this
case isn't needed, so reduce to info.

on the other hand, 100ms might be to convervative. Patch also
lowers the smallest interval to 10ms
 4 years ago
Ismael Gomez 4e39982a19
Fix TSAN warnings in UE (#3021) 
* Protect PHY SR signal management in a class

* Protect intra_freq_meas vector

* Protect cell and srate shared variables in thread-safe classes

* srsue,srsenb: include TSAN options header

* Protect ue_rnti_t and rnti scheduling windows behind thread-safe classes

* Protect access to state variable in sync_state

* Protect access to metrics configuration

* Protect access to is_pending_sr

* Protect access to UE prach worker

* Protect UE mux

* Avoid unlocking mutex twice

* Fix data races in RF/ZMQ

* Fix data races in intra_measure and PHY

* Fix minor data races in MAC

* Make TSAN default behaviour to not halt on error

* Fix blocking in intra cell measurement

* Address comments

Co-authored-by: Andre Puschmann <andre@softwareradiosystems.com>
 4 years ago
David Rupprecht 4ed33fed7d Fixed unpack bytes limit 4 years ago
Pedro Alvarez 1b676aa406 Moved lib GTPU to its own folder 4 years ago
Pedro Alvarez 865298f8d5 Moved lib PDCP to its own folder 4 years ago
Pedro Alvarez 171d5727be Moved lib RLC into it's own folder 4 years ago
Andre Puschmann b6a3b8c5b1 rlc: fix dtor 
TSAN was complaining about destroying a locked mutex
 4 years ago
faluco a70ad58440 Fix a data race in the UHD class wrapper where the last error member was being set concurrently causing random crashes. 
Introduce a new macro to catch UHD exceptions and log them directly instead of storing an error string, similar to what errno does.

Remove usrp logging helpers that depend on the now removed member since all calls potentially log the error directly.
 4 years ago
faluco e20934583e Remove an unsafe assert in the log backend that could be triggered under very certain circumstances. 
RFCI has detected this assert failing in the log_backend_test. I have not been able to reproduce this locally but my theory is the following one:
one of the unit tests does the following:

backend.start();
backend.stop();

the internal running_flag member could be set to true and then to false by the main thread before the worker thread calls do_work(). If this happens
the assert will be triggered, which is wrong and too conservative, so remove the assert.
 4 years ago
Xavier Arteaga 6f5614a0cc Suggested modifications on gNb MAC/PHY interface 4 years ago
Xavier Arteaga 8378c85ec4 Refactored gNb PHY 4 years ago
Xavier Arteaga 9126ad3b8b Added NR type1 RIV function helper 4 years ago
Xavier Arteaga e98a6f9eea Make ACK M constant i UEDLNR 4 years ago
Andre Puschmann 483a216bd5 ue,stack: refactor handling of radio bearears in UE stack 
this is a rather large commit that is hard to split because
it touches quite a few components.

It's a preparation patch for adding NR split bearers in the next
step.

We realized that managing RLC and PDCP bearers for both NR and LTE
in the same entity doesn't work. This is because we use the LCID
as a key for all accesses. With NR dual connectivity however we
can have the same LCID active at the same time for both LTE and NR
carriers.

The patch solves that by creating a dedicated NR instance for RLC/PDCP
in the stack. But then the question arises for UL traffic on, e.g. LCID 4
what PDCP instance the GW should use for pushing SDUs. It doesnt' know
that. And in fact it doesn't need to. It just needs to know EPS
bearer IDs. So the next change was to remove the knowledge of what
LCIDs are from the GW. Make is agnostic and only work on EPS bearer IDs.

The handling and mapping between EPS bearer IDs and LCIDs for LTE
or NR (mainly PDCP for pushing data) is done in the Stack because
it has access to both.

The NAS also has a EPS bearer map but only knows about default and
dedicated bearers. It doesn't know on which logical channels they
are transmitted.
 4 years ago
Andre Puschmann a4b2a065ff pdcp: reword warning when dropping PDU 4 years ago
Andre Puschmann 7113e55d53 rlc: refactor RLC entity to use smart pointers for holding bearers 
this patch mainly modernizes the bearer creation to use smart pointers.
that allows to simplify the error handling.

ue_stack is changed to match new interface. This commit compiles
but doesn't work.
 4 years ago
David Rupprecht 6d5391756c Refactor build of RLC NR config 4 years ago
David Rupprecht d1d8500ce5 Add testcase for reconfiguration 4 years ago
Xavier Arteaga eb7980f2b3 Initial UE synchronization for NR 4 years ago
Pedro Alvarez 4d13906760 Increase logging level of MAC mismatches to warning in PDCP 4 years ago
Andre Puschmann e1fb58d76e rlc_um: reduce log level for message handling lost PDUs 
when a lost PDU is detected a warning will be logged. In theory
this could be info as well but a warning may help to detect issues
in tests. The same event causes multiple other warnings to be logged,
which is very spammy. The patch reduces the log level for
those messages to info.
 4 years ago
Pedro Alvarez aae266e848 Added configuration option for S1AP SCTP bind port 4 years ago
David Rupprecht 85d7a851fb Added 5G NAS PCAP support 4 years ago
Andre Puschmann 83bf5dcd49 rlc_am_lte: reduce time holding Tx mutex when processing status PDUs 
the patch is a re-implementation of the customer-specific optimization
we did in order to reduce the time the RLC holds the Tx mutex when
processing an incoming status PDU.

The patch makes sure to never operate on a raw mutex but instead
uses the deadlock-avoiding RAII lock.
 4 years ago
Ismael Gomez 5aa5a8e997 Revert UE changes 4 years ago
Ismael Gomez e35a0d72fa Revert UE changes 4 years ago
Ismael Gomez dd9889e07c Add carrier index to uplink PCAP captures 4 years ago
Xavier Arteaga cf09044453 Optimised random bit (unpacked) and byte (packed) generator 4 years ago
Xavier Arteaga d2a19c3043 SCH minimum number of iterations to 2 to reduce systematic false alarm probability 4 years ago
Xavier Arteaga ef4c978d72 Optimized byte random generator 4 years ago
Andre Puschmann d7204df896 rlc_am_lte: check rx window first when receiving status PDU 
move rx window check up so no actions are taken when receiving
malformed status PDU
 4 years ago
Xavier Arteaga 2cd8ba3a1a PDCCH test skips 100PRB for ARM 4 years ago
Andre Puschmann 19f30aa652 rlc_am_lte: fix handling of out-of-order status PDUs 
before processing incoming status PDUs we should be checking
if the ACK_SN falls within our current Tx window. If not the PDU
will be dropped.

Without the check we were incorrectly processing the status PDU
and because the sequence number wrap around wasn't working
correctly if ACK_SN is smaller than vt_a we were corrupting
our Tx window.
 4 years ago
Andre Puschmann b862bbc2e6 rlc_am_lte: add missing mutex to get_status getter 
fixws race detected with TSAN
 4 years ago
Andre Puschmann 878142843e rlc_am_lte: add further sanity check when creating status PDU 
the test verifies that the ACK_SN of a status PDU falls inside the
rx_window of the receiver. If not, than the RLC state has been
corrupted and the status PDU is likely invalid.
 4 years ago
Xavier Arteaga 6be57dd216 Disable PDCCH false detection for non AVX2 machines 4 years ago
Alejandro Leal Conejos a51f2a1de4 Fills the value of the number of cpus for the system_metrics_t and 
initiliaze its value to 0 when executing 2 measures in less than 100 ms.
 4 years ago
Pedro Alvarez a53b321ab8 Release UE upon reception of integrity error. 4 years ago
Pedro Alvarez 299d2ee35d Added interface to make the PDCP notify the RRC of integrity check 
failures.
 4 years ago
Xavier Arteaga a79d518799 Added SSB search measure/decode file test 4 years ago
Xavier Arteaga 5181a9d64c Implemented PBCH blind decode 4 years ago
Xavier Arteaga a7b7f8e78a Avoid SSB search to have a peak that SSB data is outside buffer 4 years ago
Xavier Arteaga 480f1b14fe Protect Radio from null phy 4 years ago
Xavier Arteaga 9621cf57c2 Implemented NR SS raster object 4 years ago
Xavier Arteaga 49d857cd17 Refactored decode_tb function 4 years ago
Xavier Arteaga 22b1673b36 Added CRC match function and simplify CRC check 4 years ago
Xavier Arteaga 7846bfccb1 Implemented softbuffer RX CRC reset 4 years ago
David Rupprecht ff3e7c321d Added bref function for calc distance til end 4 years ago
Xavier Arteaga e8f2b3a74c Add PDCCH decoder correlation check in blind search 4 years ago
Xavier Arteaga 7c78fd2050 Implemented PDCCH DCI message correlation and updated test 4 years ago
Xavier Arteaga bcd2e59635 PDCCH test global variable cleanup 4 years ago
Andre Puschmann c0be8187c8 rlc interface: convert entire read_pdu() interface to return uint32_t 
we had it returning int but had a bug in using the return value properly,
i.e. handling when -1 was returned in RLC TM.

Thinking about it more, it doesn't make sense to have a negative return
value here anyway. Either the RLC can return a PDU or not. If it can't the
returned lenght is zero.
 4 years ago
Xavier Arteaga 60f294a6a1 Refactor PDCCH encode/decode unit test 4 years ago
Xavier Arteaga 5ddc974beb Reverted PDCCH threshold 4 years ago
Xavier Arteaga d46be09663 Increase viterbi default number of iterations 4 years ago
Xavier Arteaga 090022568e DCI NCCE find considers L and NCCE 4 years ago
Andre Puschmann a36e0477b8 rlc_am: fix status PDU packing when grant size isn't enough to send full report 
when a small grant is provided it might not be possible to fit a full status
PDU. This is currently detected while packing the PDU.

In order to avoid sending potentiall contradicting status info to the sending
entity, the fix makes sure to only transmit a small PDU acking what really
has been received so far.

This might not be optimal in terms for retx but will not corrupt any
state.
 4 years ago
Andre Puschmann 5838ec4999 rlc_am: revert expect macro back to error log and inform higher layers 
the incidence really must be handled by the higher layers, i.e. the bearer
needs to be reestablished.
 4 years ago
Andre Puschmann f22f4b4fbd rlc_am: fix potential stalling in RLC transmitter 
it turned out that a certain order of events can lead to
a RLC transmitter stalling because even though unacknowledged PDUs
are queued, none of them was actually considered for retx.

This can happen if a pollRetxTimer expires for a SN that, meanwhile,
has already been acknowledged. The positive lead to the deletion of
the SN from the Tx window.

The fix makes sure that when a retx for a unexisting SN is requested,
the sender will consider the next unacknowledged SN instead.
 4 years ago
Andre Puschmann 107f6334dd compile: fix compilation on 32bit systems that require -latomic 4 years ago
Francisco 486823e5de sched,bugfix: The PHR handling scheme now considers the number of PRBs of the UL grant that carried the PHR. Before, it was assuming the most conservative scenario of Nprb=1 4 years ago
Ismael Gomez 5db3030428 Tiny changes 4 years ago
Andre Puschmann 1529379e9e fec,pbch: remove unused variables 
unused code that moreover was causing TSAN to complain, e.g.
in the ue_phy_test
 4 years ago
Andre Puschmann 7ee38e6255 threads: disable thread attributes when compiled with TSAN 
TSAN doesn't work well then threads are created with attributes
thar require root rights but the process is run as normal user.

this patch avoid the thread attributes in this case. TSAN isn't going
to be used for production builds.
 4 years ago
Andre Puschmann f823340a95 rf_imp: fix race when stopping gain thread 
detected with TSAN using benchmark_radio test
 4 years ago
Xavier Arteaga 4f7a94acb6 Fix comment 4 years ago
Xavier Arteaga d329297151 Implement radio invalid mapping countermeasure 4 years ago
Andre Puschmann 3966065bff pssch_test: fix newlines in printf 4 years ago
Andre Puschmann 2ace2b47b8 pssch: fix uninitialized value 4 years ago
Xavier Arteaga bbab2cd9ba Make PDCCH LLR mean amplitude in function of maximum 4 years ago
Xavier Arteaga 2ca0932d9b Reviewed LTE noise estimation 4 years ago
Xavier Arteaga dddb3ede71 Fix zero parity 4 years ago
Andre Puschmann 50f7fc644b rlc_am_lte: log event when status prohibit timer expires 4 years ago
Xavier Arteaga 3c93d5ba43 Fix carrier mapping concurrency issue 4 years ago
Andre Puschmann 3102861ee3 rlc_am_lte: make func param const& 4 years ago
Francisco 0dafe4dd58 fix coderate derivation in PDCCH based on aggregation level 4 years ago
Andre Puschmann 02cceee997 rf_zmq_imp: revert 28399dd876 and fix unit 
although the manual test with Amarisoft eNB worked fine it seems
the delay is still needed in the default case. Over 50% of the
tests failed in the nightly with:

[zmq] Error: tx time is 0.067 ms in the past (138240 < 139776)
[zmq] Error: tx time is 1.100 ms in the past (184320 < 209664)

While this usleep() should increase the pass likelihood it
still doesn't guarantee error-free runs, so we might need
to revisit it again as some stage.
 4 years ago
Andre Puschmann e7aa484308 rf_zmq_test: remove srsran.h include 4 years ago
Andre Puschmann 28399dd876 rf_zmq_imp: remove sleep 4 years ago
Andre Puschmann 574459fd90 rf: remove srsran.h include 4 years ago
Xavier Arteaga f33731ecd4 Disable irrelevant unit/component test by default 4 years ago
Xavier Arteaga a245039cf3 Initial NR-PBCH-DMRS integration 4 years ago
Pedro Alvarez c74b2dd633 Fix some warnings in PHY due to array parameter mismatch for a few functions 4 years ago
Andre Puschmann d8b2cfcef8 zmq,ringbuffer: protect concurrent access 
some issue found through TSAN execution
 4 years ago
Andre Puschmann f1e6a975de thread_pool: fix concurrent access of state variable 
the thread workers need access to their current state to exit properly
when they are set to state STOP. However, since the state is kept in
a std::vector for all workers, it seems more appropiate to add a per-thread
running variable rather then mutexing the entire vector.
 4 years ago
Xavier Arteaga 48e0fc3c99 Implemented initial PBCH decoder and refactored SSB candidate selection 4 years ago
Xavier Arteaga de1b25558f Added PRN sequence apply bit with state 4 years ago
Xavier Arteaga 1f38817b3b Added random bit vector generator 4 years ago
Xavier Arteaga bcb91d6173 srsran_vec_sprint_hex returns number of written characters 4 years ago
Xavier Arteaga 3634e96c3e Added SSB measure test add/put/encode time measure 4 years ago
Xavier Arteaga 0aa5b14145 Initial NR PBCH encoding 4 years ago
Xavier Arteaga d66dac0ab2 Added bit sequence state apply 4 years ago
Andre Puschmann bc3be73364 rlc_am_lte: replace simple sanitfy check with error log with expect 
this should help debugging the situation when this happens by
aborting when STOP_ON_WARNING is enabled
 4 years ago
yagoda 9501283c1c fixing support for extended Cyclic Prefix 
small cosmetic fixes of CP code
 4 years ago
Andre Puschmann 21b3635ae4 rlc_am_lte: refactor retransmit_pdu() to send different SNs 
it seems that different SNs should be retransmitted depending
on the actual situation. In case of pollRetx timer expiration,
vt_s - 1 should actually be resent.

This patch prepares the function to accept different SNs but
leaves it to send vt_a by default. The RLC AM test would need
to changed as well to not fail.
 4 years ago
Xavier Arteaga 8ffbf0ff6d Fix SSB segfault 4 years ago
Xavier Arteaga f9aafd00a7 Added subcarrier spacing parsing from string 4 years ago
Xavier Arteaga b69057b76e Filesource filename to constant 4 years ago
Xavier Arteaga 5eadc06dd4 Intra-frequency miscellanous changes 4 years ago
Xavier Arteaga 7b159563ab Fixes in LTE CRS measurements 4 years ago
Xavier Arteaga 1603580901 Fix NR PSS correlation 4 years ago
Xavier Arteaga 0b3f4e5de0 Improvements in NR cell search 4 years ago
Xavier Arteaga 53b2c6076b Fix UHD subdev specification 4 years ago
Xavier Arteaga 11d925c0b2 Minor SSB fix and changes 4 years ago
Xavier Arteaga c8cb128317 Declare band helper methods as constant 4 years ago
Xavier Arteaga 648f0af437 Implement SSB search based on correlation 4 years ago
faluco 6fb81c7619 - Add a mutex with priority inheritance for srslog internal structures. 
- Replace shared_variable members in log_channel class in favor of atomics.
- Remove the small string optimization in srslog now that we dont allocate anymore.
- Trim some critical sections in srslog.
 4 years ago
Andre Puschmann 167200f5cd rrc_bearer_cfg: replace fixed E-RAB to DRB mapping 
also make sure we don't assign LCIDs beyond the possible
number.

possible fix for https://github.com/srsran/srsRAN/issues/658

Co-authored-by: herlesupreeth <herlesupreeth@gmail.com>
Co-authored-by: Francisco <francisco.paisana@softwareradiosystems.com>
 4 years ago
Xavier Arteaga 9e1a85afe8 Fix NR SCH Nref calculation 4 years ago
Xavier Arteaga 0ecb3a7220 Modify NR PHY info messages 4 years ago
Xavier Arteaga 91030c5824 Fix procedure for MCS table selection 4 years ago
Xavier Arteaga b02a0d3db9 Added RNTI type short string 4 years ago
Xavier Arteaga a57336d64f Integrate periodic SSB measurement in SRSUE and fix related defects 4 years ago
Xavier Arteaga 5e41e99f08 Added NR symbol offset helper function 4 years ago
Xavier Arteaga 7450232b3e Added more NR band related helpers 4 years ago
Xavier Arteaga 758fd3c1ba Implemented initial NR cell search 4 years ago
Xavier Arteaga 2f9c7e1345 Avoid cexpf in srsran_vec_apply_cfo_simd 4 years ago
Xavier Arteaga 90c42bc9c3 Fix resampler stack overflow 4 years ago
Xavier Arteaga 9517b78c03 Fix resampler and improved unit test 4 years ago
Xavier Arteaga d9586015f5 SSB related minor aesthetical corrections 4 years ago
Xavier Arteaga 60d1708b80 Initial SSB measurement implementation 4 years ago
Xavier Arteaga 1396c2a1e2 Mulpiple CSI measurement fixes. Channel and sync metrics from CSI measurements 4 years ago
Xavier Arteaga e68c822505 NR Added CSI measurement channel processing 4 years ago
Xavier Arteaga de9158eeaf Enable NR RRC MCS table selection 4 years ago
Xavier Arteaga eef3fac863 Improved float XOR readability 4 years ago
Xavier Arteaga 751b6858b3 Added CSI-RS resource set measurements 4 years ago
Xavier Arteaga 3b919b4f6c Minor aestheics change 4 years ago
Xavier Arteaga 243ad05dfa Added on the fly sequence apply in float 4 years ago
faluco aef18f9931 Implement a benchmark for measuring latency in the foreground threads when pushing log entries. 
This benchmark runs with several threads to test contention.
 4 years ago
Xavier Arteaga 318f064ff4 Multiple NR SCH fixes 4 years ago
Xavier Arteaga b8e0164f7f Multiple fix NR PHY procedures 4 years ago
Xavier Arteaga a8e181971c Refactored PHY NR procedures for supporting DCI formats 0_1 and 1_1 4 years ago
Francisco ad1a0eb2ac rlc,fix - Add PDCP PDUs to undelivered_sdu_info_queue when the PDUs are popped from the tx_sdu_queue, rather than they are pushed to. 
- This simplifies the sdu discard
- This also fixes an existing race condition
 4 years ago
Andre Puschmann 598594c51a all: bunch of pass by const& changes suggested by LGTM 4 years ago
Francisco 7ced0e73eb rlc,bugfix - avoid accessing the PDCP info of RLC segments when the PDCP has already discarded the respective PDCP SN. 4 years ago
Andre Puschmann 597729ac53 rlc: always remove PDCP SNs from undelivered queue 
if RLC PDUs with certain PDCP SNs were already in flight
when their discard timer at PDCP expires, they weren't
remove from the undelivered_sdu_info_queue causing
indesired log entries like:

08:08:52.455280 [RLC    ] [W] PDCP_SN=2103 already marked as undelivered

when the SN was sent again (after wrap around).

The patch makes sure to always try to delete the PDCP SN
from the queue. It should fix (at least partly) #2560
 4 years ago
Andre Puschmann 20075f6f33 rf_uhd_generic: fix segfault when accessing device tree 
for some reasons the dev tree isn't available on the X310
with UHD4 and the code never checked the return value, causing
a segfault with that combo.
 4 years ago
Xavier Arteaga 949ce965c7 Fix SCH NR CRC check 4 years ago
Xavier Arteaga fb5dfb3a86 Improved NR unit test 4 years ago
Xavier Arteaga 28170c92a9 Multiple NR SCH fixes 4 years ago
Xavier Arteaga efb8da69d8 Cleaned DCI NR info string 4 years ago
Xavier Arteaga 8cb3e92ab3 Added LDPC flooded early stop 4 years ago
Xavier Arteaga 6c39a5e4ff Added PDSCH DMRS aditional unpacking 4 years ago
Xavier Arteaga 86ad0446e1 Added NR PDSCH and PUSCH resource allocating flattening 4 years ago
Xavier Arteaga 892aea8219 Fix coverity warnings under lib/src/phy/utils 4 years ago
Xavier Arteaga 87cf3cf2e5 Fix coverity warnings under lib/src/phy/phch 4 years ago
David Rupprecht bde30bb9be Added tests for band helper 4 years ago
Andre Puschmann 937c4ff3c3 demod_soft: removed unused NEON code 
clang complained about unused code, so remove it of course.
 4 years ago
Xavier Arteaga 71226e89df Minor dereference check 4 years ago
Xavier Arteaga b6fa82bf9a Fix more static analysis warnings 4 years ago
Xavier Arteaga efd6c569b8 Fix some static analisys warnings under lib/src/phy/fec 4 years ago
Xavier Arteaga 217f3cb416 SRSENB: select highest with/without SR correlation PUCCH result 4 years ago
Andre Puschmann ada6c71b5a rf_soapy: fix logic to print warning when Lime is used with short sample rates 
previously the warning was printed when a Lime was connected to the PC.
Now all connected devices are printed but the warning is only
shown if the selected device is the Lime.
 4 years ago
faluco aa3309157b Fixed polar encoder and decoder initialization failure for ARM. Initialization unconditionally used x86 SIMD routines instead of getting disabled for ARM compilations. 4 years ago
faluco d9e5f4ccc7 Replace a couple of inline functions in demod_soft with macros to allow constant propagation. The vgetq_lane_sX builtin expects a constant instead of a variable. 4 years ago
Francisco 86dac9c823 several coverity high and medium impact fixes 4 years ago
Xavier Arteaga 9a4fcb605b Reviewed UHD Tx FSM 4 years ago
Xavier Arteaga 3413f29cc8 Fix channel interpolator for 4 ports 4 years ago
Andre Puschmann 03e1277b0b rf_soapy_imp: fix lowercase to detect Lime 4 years ago
Andre Puschmann b569e81299 rf_soapy_imp: fix LTE sample rate info check 
only print if Lime is substring in dev args, so don't print with blade
 4 years ago
Andre Puschmann 4dd17aee45 rrc/phy/nr: calculate tuning freq of NR carrier from RRC signaling params 
skip initial tuning to hard-coded NR frequency and use RRC-provided
values to calculate center frequency
 4 years ago
Andre Puschmann 6e79ae67aa ldpc/polar: add casts to avoid possible variable overflow before assignment 4 years ago
Andre Puschmann ff53d2b8b8 all: set of trivial changes reported by LGTM 
mainly fixmes, unused/empty code, etc.
 4 years ago
AlaiaL 0535473895 Fixes coverity 369570 4 years ago
AlaiaL 6332490cae Fixes coverity 369581 4 years ago
AlaiaL 385b12a33a Fixes coverity 369620 4 years ago
AlaiaL 23f0bd4d4f Fixed coverity 369716 4 years ago
faluco 1ccb62af3d Apply srsLTE formatting rules to srsLog. They were previously formatted with different rules when the project lived in the external rapo. 4 years ago
Xavier Arteaga 873f375ecc Make NR DCI test more exhaustive and fix issues 4 years ago
Xavier Arteaga ab6a5ef17a Added NR DCI conversion to string for formats 1_0 and 1_1 4 years ago
Xavier Arteaga bccfa8d875 Added NR DCI packing/unpacking format 1_1 4 years ago
Xavier Arteaga 11b9990224 Added NR DCI packing/unpacking format 0_1 4 years ago
faluco 0afd59a5a0 Replace a string with a const char * in the rlc to_string. 4 years ago
Francisco 289559af82 asn1 fix - fix choice access correct type assert 4 years ago
Francisco ff3fc0826b asn1 fixes and improvements 
- use const char* instead of std::string in enumerated<>::to_string() to avoid mallocs.
- Remove the use of "typedef", and use "using" keyword instead.
- Fix rrc_nr::setup_release_c<>::to_string() broken linkage.
 4 years ago
David Rupprecht 98914dab6a Allow pdcp lte entity to use 18 bit SN 4 years ago
Xavier Arteaga 407903e0d6 SRSUE: refactor carrier setting for accepting a dynamic carrier configuration 4 years ago
Xavier Arteaga 47523935f6 Minor NR RRC fixes 4 years ago
Francisco 3b78bf3730 bugfix - fix memcheck warnings. move instructions with side effects outside of asserts 4 years ago
David Rupprecht a064e85c54 rename common lte header 4 years ago
David Rupprecht 91ff8a2e6d Add rrc_nr to rlc init function 4 years ago
David Rupprecht 6b41ae7e8b Updated PDCP config struct for rat type 4 years ago
Xavier Arteaga 77b6b60b82 Fix rach_cfg.nof_groupA_preambles 4 years ago
Xavier Arteaga aadbe6d880 Normalise NR PUSCH to maximum Tx power 4 years ago
Xavier Arteaga 53e41a165c Revert zeros around DC REs in NR PDSCH 4 years ago
Xavier Arteaga 93c3dc1cb1 Revert "Demodulator sets LLR to zero for 0.0 symbols" 
This reverts commit 1a6e5cdee5.
 4 years ago
Xavier Arteaga 1c1d7e2447 Revert "Review soft demodulator zero check" 
This reverts commit b8a9a7fc70.
 4 years ago
Xavier Arteaga 0999b271ba Added RFNOC based LO frequency offset 4 years ago
David Rupprecht db9dd85783 Parse carrier config in NR RRC reconfig 4 years ago
David Rupprecht f42d4dbc28 Refactored carrier config 4 years ago
Andre Puschmann 9009c3439c rlc_um_nr: convert log entries to info if they are expected 
dropping a PDU and not being able to build a PDU if the
grant is too small is expected and should therefore not cause a log warning.
 4 years ago
Andre Puschmann 936bebcfd7 rrc_nr_utils: fix extraction of HARQ processes from ASN1 reconfig 4 years ago
Xavier Arteaga 53b38fccf9 Fix compile and other 4 years ago
Xavier Arteaga ed0929b46d NR PHY logging minor corrections 4 years ago
Xavier Arteaga 8ffced7e88 NR PHY logging minor corrections 4 years ago
Xavier Arteaga abfc1da921 Multiple NR-PUSCH fixes 4 years ago
Xavier Arteaga 7e06e789d5 Fic NR UCI in the info string 4 years ago
Xavier Arteaga 01ce0718be NR-PUSCH RE mapping correction and NR-SCH detailed grant information 4 years ago
David Rupprecht bfe2ad98ef Added parsing for NR DL HARQ cfg 4 years ago
Andre Puschmann b9ae064338 mac_nr: add DL HARQ 
this commit adds a complete DL HARQ entity to the MAC of the UE.
It also refactors demux into an own class and adapts the PHY-MAC
interface to use the new MAC capabilities.
 4 years ago
Francisco e3e4564a7e fix inconsistency in use of invalid_sn and status_report_sn throughout rlc am code 4 years ago
Francisco c3ec28002b refactor - integration of segment list in rlc_amd_tx_pdu and pdcp_pdu_info classes 4 years ago
Francisco 7f0083a985 implementation of intrusive list abstract classes to be used in RLC for lists of segments 4 years ago
Francisco b06f16891d use of a single array-based pool of RLC AM PDU segments to build data PDUs, while 
avoiding any allocations.
Each segment stores its own PDCP SN and RLC SN and has two pointers,
one for the next segment of the same RLC PDU, and another for the next segment
of the same PDCP PDU.
 4 years ago
faluco e1752c0878 Replace the queue in thread pool in favour of a static circular buffer to avoid allocations. 4 years ago
David Rupprecht fe8727050b Added new rrc_nr to phy flattening functions and fixes 4 years ago
Xavier Arteaga e4e3456d76 Refactored PDSCH/PUSCH decoder for LDPC early stopping 4 years ago
Xavier Arteaga 6c5e28bc19 Optimised AVX512 LDPC decoder hard decision 4 years ago
Xavier Arteaga 422d479852 Added CRC match function and optimised byte packing 4 years ago
Xavier Arteaga 5aa7f9dd8b Condensed LDPC Decoder config arguments into an structure and unified common decoder code 4 years ago
Francisco e37968410e simplification of timers handler design, relying solely on one time wheel. 4 years ago
Francisco 66988ffd32 s1ap - simplified erab setup procedure. Handle correctly the failure to setup causes 4 years ago
Francisco f401683960 s1ap - simplified erab modify procedure 4 years ago
Francisco 76978f0d14 s1ap - simplified erab release procedure 4 years ago
Xavier Arteaga faa6d01e9d Fix RFNOC compilation 4 years ago
Xavier Arteaga c82f609085 Fix b200mini external clock 4 years ago
Andre Puschmann b7146c41b2 nr: add NDI for PUSCH grant to sch cfg struct 4 years ago
faluco a474a0f293 SRSLOG: Avoid calling unordered_map::emplace if element already exists since it will allocate even if the insertion is not going to take place. 4 years ago
Xavier Arteaga 7823bfc28c Fix append NR to loggers for NR components 4 years ago
faluco daad20c9d4 Disable copy and move operations for dyn_node_pool. 4 years ago
faluco a2f6e13138 Add a tag to the string memory pool in fmt to discriminate between pool vs heap allocated buffers. Heap allocated buffers are used as a fallback mechanism when the buffer runs out of space. 4 years ago
faluco 0465f6badd Implement a pool in FMT to avoid allocating heap memory when passing a char* to the backend, usually when formatting a %s argument. 
Previously since a char* can have any length, this was managed by FMT by converting it into a std::string.
Now we store it into a configurable size node that can store a fixed size string, otherwise it falls back to std::string.
 4 years ago
Xavier Arteaga 2f453b43ba Initial NR PHY interface 4 years ago
Francisco d2c404b166 handover - setup s1ap cause in case of handover failure at the target enb 4 years ago
David Rupprecht 5a3a2a6d6f Added functions for adding phr and tag config 4 years ago
Andre Puschmann 48537f3fe7 pdcp,rlc: increase number of PDCP SDUs for notification from RLC 
the current value of 256 limits the number of PDCP SDUs that can be
notified from RLC. The limit is quickly hit when too many SDUs
are in flight. This can cause unwanted log entries and weird PDCP
behaviour.

the patch increases the value to 1024, which still can be too few if
many smaller SDUs are traveling.

The patch also set the log level to warning to quicker spot
misconfigs in logs.

Fixes #2616
 4 years ago
Xavier Arteaga 2f8ea05132 SRSUE: Add periodic CQI R10 parsing 4 years ago
Andre Puschmann c9da21c9bb mac_nr: add error handling when unpacking SCH MAC PDU 
* only handle PDU if unpacking was successfull
* add TC unpacking with malformed PDU
 4 years ago
Xavier Arteaga e989e62c52 Fix NR PDCCH DMRS test 4 years ago
Xavier Arteaga b8a9a7fc70 Review soft demodulator zero check 4 years ago
Xavier Arteaga dd26c6a90e Added more comments for better understanding in NR PDCCH DMRS 4 years ago
Xavier Arteaga 17a3c76540 Fix NR TDD pattern configuration 4 years ago
Xavier Arteaga c84e73541d Offset FFT window for UE DL NR 4 years ago
Xavier Arteaga f799ab6f94 Fix NR UL RV selection 4 years ago
Xavier Arteaga 42dcff45b2 Improve PDCCH NR detection 4 years ago
Xavier Arteaga 1a6e5cdee5 Demodulator sets LLR to zero for 0.0 symbols 4 years ago
Xavier Arteaga 3889f1369f Added partial NR time resource mapping tables 4 years ago
Xavier Arteaga de187d4c88 Fix copy-past issue in srsran_vec_apply_cfo_simd 4 years ago
Xavier Arteaga 2e3c00aa97 NR PDSCH zeroes RE around the DC. Added delay and CFO emulation to phy_dl_nr_test 4 years ago
Xavier Arteaga 667cc0b552 NR PDSCH/PUSCH DMRS estimation precompensates Synch error and CFO before interpolation 4 years ago
Francisco 685c971dc2 fix recursive call to get rb name 4 years ago
Francisco 21718af3b6 avoid allocating std::string to get lcid radio bearer name. Refactored the lte radio bearer enum type 4 years ago
Andre Puschmann b991b07167 rlc: add length check for RLC PDU generation 
makes sure that RLC doesn't generate a PDU larger than
the provided grant size
 4 years ago
Andre Puschmann 9950278a12 nr,mac_sch_pdu,mux: fix packing of MAC subPDUs with 16bit L field 
the created RLC PDU was too large to fit inside the MAC grant
because only the header room for the short L field was used.

The patch determines the correct size before passing the opportunity to RLC.

It also improves logging in error case by using the MAC logger instead of
stderr/stdout when error occurs.
 4 years ago
Francisco 75e9700de0 rlc - usage of memory pool to allocate RLC bearers 4 years ago
Andre Puschmann db496df1e6 mac_nr: add support for periodic BSR reporting 
building on the previous refactor this patch now adds support
for peridoic BSR reporting (using short BSR). It furthermore does
the following changes:

* add BSR packing
* add proc_bsr_nr unit test
* move mac_nr test code into test folder under src (needs to be done with other test code too)
 4 years ago
Andre Puschmann 6dd8c21073 mac_sch_pdu_nr: add unpacking of TA CE in DL-SCH 
also add basic test to verify correct unpacking
 4 years ago
Francisco dc763b5045 rlc am - fix bugs in buffered_pdcp_pdu_list 
The count and container elements were not being correctly updated in the events
of SN overwrite, clear(), clear_pdcp_sdu(sn) of sn that doesnt exist
 4 years ago
David Rupprecht 82c9636156 Refactor pdcp ctor seperate the configure function 4 years ago
David Rupprecht 7a481c40ab Added mac prach nr proc error handling 4 years ago
Xavier Arteaga 58a9ef6e7f Minor NR PHY tweaks and aesthetic 4 years ago
Xavier Arteaga 991c6e7016 Refactored NR HARQ-ACK feedback enqueue 4 years ago
Xavier Arteaga 22239b29c5 Disable smoothing filter for NR PDCCH DMRS 4 years ago
Xavier Arteaga 9f54c6ae6d Fix NR PUCCH info string and memory leak 4 years ago
Andre Puschmann 0fdcea2924 rlc_am: count every segment retx as a full retx for this SN 
previously we were only counting retx if we retx the start of a segment.
this could lead to unwanted behaviour, i.e., not counting retx
correctly and thus not triggering the maxretx attempt, if the receive
always sends NACKs with a SO_start.

The RLC spec is not clear on how this should be handled correctly but
IMHO using an integer number of retx is reasonable, even for segments
that might be retransmitted more often.

The alternative of using a fractional retx counter that may be increamented
proportional to the segment size that is retx is another alternative
but considered too complex to implement (and test correctly).
 4 years ago
Andre Puschmann c74661ae95 rlc_am: add log message when received NACK SN is already on retx queue 4 years ago
Francisco d02cc51e33 use mutex or atomic in running flag to signal the interruption of a thread 4 years ago
Xavier Arteaga 49731ab5a1 Initial NR-DCI refactor 
Added NR DCI 1_1 size

Several DCI NR fixes
 4 years ago
Xavier Arteaga 64acf03158 Fix sch_nr_test 4 years ago
Xavier Arteaga 3504bfcf5a Fix NR-SCH test 4 years ago
Xavier Arteaga 39e97cbcf4 Fix unbounded memory access 4 years ago
Xavier Arteaga 29c6adad93 Avoid unused LDPC memory in AVX2 decoder 4 years ago
Xavier Arteaga 392a8cc1b6 Fix LDPC RM number of useful iterations 4 years ago
Xavier Arteaga 3568f633c3 Use LDPC RM number of useful LLR and rename functions 4 years ago
Xavier Arteaga ecd2c1cdcc Improved LDPC decoded performance and other NR aesthetical changes 4 years ago
Ismael Gomez 3daba090f6 Fixed compilation of turbo decoder in ARM 4 years ago
Francisco c24e382c19 Refactor of socket manager class 
- use of inheritance to simplify testing
- removal of global network manager
- pass of custon socket manager to s1ap and gtpu ctors
- overhauled the registration of socket fd,callback in socket manager
 4 years ago
Francisco 4aac7ac238 use global rx multisocket handler, and remove stack-s1ap interface 4 years ago
Francisco 39de2efa69 multisocket handler - use blocking socket remove method 4 years ago
Francisco bf96d897ee network utils refactor - renaming of socket handle to unique socket and cleanup of its methods 4 years ago
dr 968c261bec Reordered lock to avoid deadlock in mac pcap thread 4 years ago
faluco 54fab314c0 Enhance RRC eNB events: 
- Implement a common event "log_rrc" for all RRC events and discriminate by procedure using an enum.
- Log events for connection, reestablishment, reconfig, reject and release.
- Log the corresponding ASN1 message used by each procedure.
- Redefine the JSON object for this event to match the new structure.

Fixed a compilation error detected by the static analyzer in gcc9.3 where bounded_vector::data() was using taking the address of the internal buffer which confused it, prefer to use the data method of std::array.
 4 years ago
Francisco be771e5c23 performance - use of new concurrent fixed size pool for byte_buffer pool 4 years ago
David Rupprecht b944528a4f Install srslog to system folder 4 years ago
faluco e2c7809abb - Introduce a new tracer scoped object that only records if the event duration exceeds the programmed threshold. 4 years ago
Xavier Arteaga 6219500148 Added NR-RRC RACH parsing 4 years ago
faluco 4b5e15cd70 - Fixed missing return statements in base_circular_buffer::try_push. 
- Fixed array index calculation in base_circular_buffer::clear.
- Removed redundant explicit in srslog::backend_worker.
 4 years ago
David Rupprecht 8c86d2084d Adding NR phy config RRC parsing 
Added error handling

Reworked flattening error handling
 4 years ago
Andre Puschmann 48c106ae64 rlc_um_nr: fix packing/unpacking of PDUs with 12bit SN 
* fix SN extraction/writing
* fix packed header size calculation
* fix segmentation logic and take variable header lenght into account
 4 years ago
AlaiaL 1cc2cc4e7f Fixed typo 4 years ago
AlaiaL fd3c2b855e - Renamed log to logger. 
- Added a log entry in the metrics when skipping a measurement due to
time constrains
 4 years ago
AlaiaL bbaebd1274 Added a warning in the log when the cpu metrics are not registered due 
to the number cpu cores is greater than supported.
 4 years ago
AlaiaL c9d1c77e8c - Deleted the magic number of maximum supported cores, now it is a 
constexpr.
- When the system has more cores that the maximum supported, the cpu
metrics will not be registered.
 4 years ago
AlaiaL 6cd9bba641 Added the cpu metrics to the system metrics. 4 years ago
Xavier Arteaga 5bdf2c93b3 Initial NR PDSCH CSI-RS RE skip and other changes 4 years ago
Pedro Alvarez 5bc55ec48c Changed discard_if to appyly_if in circular_buffer.h. 
This was done so it would work when circular buffer holds other things
that are not unique_pointers. Queue and pop_func had to be made public
to be able to call the pop_func when an SDU is discarded.
 4 years ago
Andre Puschmann 1b1cfa40c9 rlc_am_lte: add some more sanity checks around retx of PDUs 
this patch doesn't change any functionality but adds a bit
of further error checking around the handling of status PDUs
and the retx of PDUs
 4 years ago
Xavier Arteaga 7704c09ce2 Fix typos 4 years ago
faluco e8395c7474 - Implement a pool to store dyn arg store objects in srslog to avoid allocations when passing arguments to the backend. 
- Use string views inside the log formatters to avoid allocations.
- Avoid a std::string when using fmt::vsprintf, instead favour fmt::vprintf.
 4 years ago
Andre Puschmann 1a0891df51 all: check return value of make_byte_buffer() and handle them safely 4 years ago
Francisco dd336c53ea changed srsran_warning to srsran_expect. Applied new macro to rlc am 4 years ago
Andre Puschmann 9d8d897d3e mac_pcap_base: log warning when PDUs can't be added to write queue 4 years ago
Pedro Alvarez d91119baf6
RLC discard (#2515) 
* Added ability to discard to dyn_block_queue

* Change way of keeping track of SDUs

* Check nullptr in poping callback. Starting to check for nullptr in RLC read_pdu.

* Adding RLC discard tests

* Clearing PDCP info when RLC discard happens

* Read SDUs until they are no longer nullptr

* Changed discard_if to use template argument
 4 years ago
Codebot 4523ee6087 rename srsLTE to srsRAN 4 years ago
Pedro Alvarez dde8157bf1 Make sure that S1 Setup request is restarted regardless of which error made the procedure fail. 4 years ago
Andre Puschmann 47654af717 pdcp_entity_lte: fix printf formatter for size_t 
we've seen a heap-buffer overflow in fmt because printf wasn't using
the right formtter for size_t, which should be %zu

this patch fixes it for the PDCP LTE entity but we might have it elsewhere too

[1m[31m==7595==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x629000e6f1fc at pc 0x562273a45289 bp 0x7f35567641f0 sp 0x7f35567641e0
[1m[0m[1m[34mREAD of size 4 at 0x629000e6f1fc thread T12 (STACK)[1m[0m
    0 0x562273a45288 in fmt::v7::basic_format_arg<fmt::v7::basic_printf_context<std::back_insert_iterator<fmt::v7::detail::buffer<char> >, char> > fmt::v7::detail::make_arg<fmt::v7::basic_printf_context<std::back_insert_iterator<fmt::v7::detail::buffer<char> >, char>, unsigned int>(unsigned int const&) (/osmo-gsm-tester-srsue/srslte/bin/srsue+0x9dc288)
    1 0x562273a3aa86 in void fmt::v7::dynamic_format_arg_store<fmt::v7::basic_printf_context<std::back_insert_iterator<fmt::v7::detail::buffer<char> >, char> >::emplace_arg<unsigned int>(unsigned int const&) (/osmo-gsm-tester-srsue/srslte/bin/srsue+0x9d1a86)
    2 0x562273a308e7 in void fmt::v7::dynamic_format_arg_store<fmt::v7::basic_printf_context<std::back_insert_iterator<fmt::v7::detail::buffer<char> >, char> >::push_back<unsigned int>(unsigned int const&) /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/include/srslte/srslog/bundled/fmt/core.h:1548
    3 0x562274361541 in void srslog::log_channel::operator()<unsigned int&, unsigned int&, unsigned long>(char const*, unsigned int&, unsigned int&, unsigned long&&) /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/include/srslte/srslog/log_channel.h:101
    4 0x56227430d9e7 in srslte::pdcp_entity_lte::update_rx_counts_queue(unsigned int) /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/src/upper/pdcp_entity_lte.cc:451
 4 years ago
Andre Puschmann 2cfc657fbb rlc_am_lte: refactor logging when PDCP SDUs are enqueued 
the patch refactor the logging when a new PDCP SDU is enqueued for
transmission at RLC.

If the SN is already present, only a warning is logged. From the RLC
perspective operation continues and the SDU will be transmitted.

The patch also changes the order of logs. When the SN cannot be inserted
inside the queue of undelivered SDUs, only one message is logged.
 4 years ago
faluco eb27efd867 Modify the policy of the buffered sink to flush its contents continuously instead of doing it once. 4 years ago
Xavier Arteaga 5f954ab379 Fix UHD compilation 4 years ago
Xavier Arteaga a8b5b8efa1 UHD: stability improvements 4 years ago
Xavier Arteaga f9689ec956 Added PUSCH CFO estimation 4 years ago