* - Started porting the enb PHY layer to use srslog loggers.
- Updated srslog to manage the none level.
* Finished porting enb phy layer including the NR part.
* Ported MAC, GTPU, PDCP, RLC and S1AP enb classes to use srslog.
* Use new stack logger.
* Ported the enb RRC clases to use srslog.
* Remove unused log macros.
* Replace loggers in sched, sched_carrier, sched_helpers.
* Replaced loggers in sched grid.
* Replaced loggers in sched harq.
* Replaced loggers in sched ue.
* Replaced loggers in sched ue ctrl.
* Replace loggers in sched ue ctrl TPC.
* Replaced loggers in sched subclasses.
* Replaced loggers in rrc_meascfg_test
* Configure loggers in rrc_mobility_test.
* Fix compilation errors left out after the rebase.
* - Implement a custom log sink that will serve as a test spy to intercept and count the number of error and warning log entries.
- Adapt the erab_test_setup and rrc_mobility tests to use this new class and make them pass again.
* - Remove trailing new lines introduced in the rebase.
- Ported the sched_ue_cell class to srslog.
* Remove unused log member.
* Ported mac tests to srslog.
* - Removed remaining trailing newlines from log entries.
* Fix compiler errors detected in CI.
* Fix another static variable without definition passed to log lines.
* Fixed a bug in srslog::flush that would never end when the backend queue is full.
* Fetch the RRC logger instead of injecting it in the constructor.
* Refactor NR resource allocation classes. Use DCI instead of grant for dummy PDSCH UE/eNB test
* Minor refactors in NR workers and ue_dl
* Fix include issues
* fix compilation issues
* offload PCAP writing to background thread
* use blocking_queue between writer and clients to make it thread-safe
* add basic test case
this fixes point 1-3 of #2161
this patch adds support for measuring the:
* SDU rx latency (Average time in ms from first RLC segment to full SDU)
* amount of buffered bytes (sum of payload of PDUs buffered in rx_window)
the implementation is using std::chrono
when retrieving the RLC metrics, the number of TTIs since the last
call are passed. This allows to calculate the actual rate
based on the LTE timing rather than only the system timing.
- now bounded_vector::resize(N) works for move-only types
- bounded_vector assertions now print error messages
- fixed move ctor/assignment of bounded_vector
- created a unit test for bounded_vectors of move-only types
* rlc_am: add TC for pollRetx timer handling
* rlc_am: fix stopping of pollRetx timer
stopping the pollRetx timer when receiving a status PDU
without checking the acknowledged PDUs is wrong.
if an ACK for another PDU, for which the polling bit has been set,
is still pending, it won't be rescheduled until another
PDU is transmitted that again starts the pollRetx timer.
this fixes the issue with missing RLC AM segment retx in #1992,
and #2003
this patch refactors the MAC PDU class, the main changes are:
* add to_string() method to pretty print PDU and subheaders
This allows to have a single log entry per MAC PDU with all its
contents.
It removes the C-style fprint() method
* Simplity payload vs. w_payload_ce
Before we've used payload when reading the PDU and w_payload_ce
as a buffer when writing. In all getters we needed to differentiate
between both. Now payload points to w_payload_ce initially and is
only updated when parsing a new PDU.
* add various helpers, e.g. to get subheader index, update a BSR, ..
* fix PDU test to use new to_string() method
- Documented methods and class.
- Adapted interface to the latest standard: no init list and generic container constructors, new iterator pair ctor.
- Implemented some SFINAE for managing conversions in constructors.
- Re-organised some methods to be grouped by category (modifiers, observers, iterators, ...).
- Added convenience make_span functions.
- Added some more asserts.
- Adapted test to use some syntax that was modified.
- Import the srslog project into srslte.
- Ported srsue app to use the new logging framework.
- Implemented a wrapper that dispatches log entries to srslog.
- Renamed an existing log test to be more specific to avoid name clashes.
this patch refactors the SDU queuing and dropping policy of the RLC and PDCP layer.
the previous design had issues when packets have been generated at a higher
rate above the PDCP than they could be consumed below the RLC.
When the RLC SDU queues were full, we allowed two policies, one to block on the write
and the other to drop the SDU. Both options are not ideal because they either
lead to a blocking stack thread or to lost PDCP PDUs.
To avoid this, this patch makes the following changes:
* PDCP monitors RLC's SDU queue and drops packets on its north-bound SAP if queues are full
* a new method sdu_queue_is_full() has been added to the RLC interface for PDCP
* remove blocking write from pdcp and rlc write_sdu() interface
* all writes into queues need to be non-blocking
* if Tx queues are overflowing, SDUs are dropped above PDCP, not RLC
* log warning if RLC still needs to drop SDUs
* this case should be avoided with the monitoring mechanism
Here is the test output with the fix disabled:
13:47:42.679774 [RLC_UM_1] [D] MAC opportunity - 14 bytes
13:47:42.679784 [RLC_UM_1] [D] pdu_space=14, head_len=2
13:47:42.679790 [RLC_UM_1] [D] adding new SDU segment - 10 bytes of 10 remaining
13:47:42.679834 [RLC_UM_1] [D] Complete SDU scheduled for tx. Stack latency: 0 us
13:47:42.679909 [RLC_UM_1] [D] pdu_space=4, head_len=2
13:47:42.679922 [RLC_UM_1] [D] adding new SDU segment - 0 bytes of 10 remaining
13:47:42.679928 [RLC_UM_1] [I] Tx PDU SN=0 (14 B)
13:47:42.679974 [RLC_UM_1] [D] vt_us = 1
The test checks the correct packing and of the two PDUs at the end.
this allows to create a queue that has a non-default capacity
currently this is 8192, but the value might now be suitable in some
cases like for TTI sync events
previously PDCP security (integrity and ciphering) could only
be enabled for both Rx and Tx at the same time.
this, however, caused an issue during the conformance testing in which,
in TC_8_2_1_1() for example, the eNB sends a SecModeCommand and a
RRC Reconfiguration in the same MAC TB. In this case, the eNB
needs to be able to enable DL security right after sending the SecModeCmd
in order to send the RRCReconfig encrypted. However, enabling UL security needs
to be postponed until after the SecModeComplete is received.
This patch allows to enable PDCP security for rx/tx independently if
that is needed. The default way is like before, enabling it for tx/rx at
the same time.
rrc_meas refactor. Need to split commit
Fix typo
Temporal commit
Apply rx_gain_offset to neighbour cell measurements
srsLTE: modify TESTASSERT Macro to follow codeline
SRSUE: prevent RRC from having serving cell in neighbour list
SRSUE: DL HARQ does not need Time Aligment Timer. UL is disabled using PUCCH resources release
SRSUE: extend intra-frequency to CA SCell
SRSUE: fix confusing/ambiguous code in the RRC measurements and fix concurrency issue
SRSUE: remove RRC measurement report triggers when measurements are modified or HO succesful
SRSUE: fix compilation issues and Reest SIB indexes
Fixes sync using incorrect cell configuration when search cell does not find a correct cell
Small refactor to remove measurement report triggers always after removing measurement
SRSUE: Removed SIC PSS from UE
SRSUE: fix inter-frequency reestablishment and added more traces
SRSUE: Fix compilation issue
* Clang-formated UE, eNB and lib.
* Fixed compiling errors from clang-format.
* Fix linking issues introduced by clang-format
* Fix poor formating in initializing arrays of arrays.
* Fix mistake in conflict resolution on rm_turbo.c
* Re-apply clang format to gtpc_ies.h
move non-type-specific methods of proc_t to its base class.
procedure state machine was simplified via a future-type. Now procedures dont get stuck until the user reads the procedure outcome.
made the NAS procedures more event trigger/reaction-based.
happens when very small grant is provided and the status
PDU generation fails because of a too small grant
add extra check to prevent that ACK_SN is also in NACKS list
RRC-PHY interface refactor. Moved RRC-MAC interface to rrc_asn1_utils and created RRC-PHY interface also in rrc_asn1_utils. All ASN1 includes should be made from rrc_asn1_utils only keeping ue_interfaces clean of ASN1
Tested with different common and dedicated configurations (64QAM UL, 256QAM, CA, SRS enabled/disabled, etc)
* first step towards moving MAC timers to stack. Mac is still using its own timers. srslte::timers class can be restructured.
* moved timers out of the UE MAC
this fixes the issue when the stack is torn down if, for example,
the radio couldn't be loaded correctly. it will hence call stop() on all stack
components which are not initialzized yet, and logging therefore doesn't work.
the log object is know during contruction time and therefore can be passed
in as soon as possible.
- all RLC entities are now initialized during contruction
- there is no need to check for, e.g., existance of timers, during
runtime
- there is also no need to call re-init during resume
- timers are freed in dtor
this will also extend all classes that use srslte::thread
to specify the name of the thread in the ctor as well
as to set the name of the worker threads in the thread pool
the thread name will be displayed in gdb.
- abstract UE object now consists of a radio, a PHY, and a stack layer
- add new stack abstraction layer that combines MAC, RLC, RRC, PDCP, NAS and GW
- PHY layer now has a single stack interface and does not talk to MAC and RRC seperatly
- there was an issue in the stack allocation of the large
m2ap pdu struct that was fixed by heap-allocating it
- there was also an issue in the m2ap packing that used
a temporary struct that was not initialized
* Starting to add EIA1 tests.
* Initial tests for EIA1
* Bit shifted bearer by 27. Test case 1 and 4 are passing now.
* Adding EIA test case 7.
* Making sure the test is called.
* Fixed double initialization of msg_len_bits.
* Starting to add M2AP serialization structures.
* Added M2AP procedure ids.
* Added some M2AP max values.
* Removing m2ap.cc for now.
* Adding cause IE.
* Adding dummy m2ap.cc to check correct compilation of m2ap.h
* Fixed compilation issues in m2ap.h
* Adding Cell Information IE.
* Added Criticality diagnostics IE.
* Adding eNB-MBMS-ConfigurationDataItem.
* Adding MBMS-Service-Area-Id-List
* Added MBMS Service Area Id.
* Added Global eNB Id IE.
* Added Global MCE id IE.
* Added MBMS-Service-associatedLogicalM2-ConnectionItem IE.
* Added MBSFN_SUBFRAME_CONFIGURATION IE
* Added MCCHrelatedBCCH-ConfigPerMBSFNArea IE.
* Added MCH scheduling period IE.
* Added PMCH-Configuration IE.
* Added Time-to-Wait IE.
* Added TNL-Information IE.
* Starting to add M2SetupRequest msg.
* Adding M2 Setup Request message.
* Fixed up enums related to initiating messages, successful outcome and unscesseful outcome.
* Starting to add m2ap apck/unpack PDU functions.
* Started to add a test for M2 Setup Request Pack/Unpack.
* Filling in M2SetupRequest structure.
* Adding packing of more IEs in the M2SetupRequest.
* Starting to add unpacking functions to M2SetupRequest.
* Continuing to unpack M2SetupRequest. Unpacking PLMN Identity correctly now.
* Fixed up enb_id unpacking. eNB Id and eNB name unpacking correctly now.
* Starting to add unpacking for dataconfiguration item.
* Adding support for eCGI unpacking.
* Adding MBSFN Synchronization Area id Unpacking.
* Adding service area unpacking.
* Added unpacking functionality to the rest of the IEs in the M2 Setup Request. Unpacking the M2 Setup Request is passing unit test.
* Fized mistake in packing eNB Id. Starting to add packing to eCGI.
* Starting to pack value in ENB MBMS Configuration item.
* Fixed packing of ENB MBMS configuration item header.
* Packing of M2 Setup request is now passing the unit test.
* Starting to add M2setup response.
* Starting to add packing/unpacking succeful outcome.
* Starting to add M2SetupResponse to test.
* Continue to add testing to setup response. Choice type seems OK.
* Starting to add unpacking to MCE Id.
* Adding MCEname packing/unpacking.
* Continue to unpack m2setupresponse.
* Adding MBMS Area Id unpacking
* Added pddch length unpacking.
* Adding more IE unpacking.
* Adding more code to unpack M2 Setup response.
* Added M2 Setup response unpacking.
* Added M2 response packing. Fixed mistake on eCGI packing/unpacking, which broke M2 Setup request.
* M2 setup request and response pack and unpacking seems to work.
* Starting to add MBMS Session Start Request.
* Continue to unpack MBMS session start request.
* Added TMGI unpacking.
* Continue to add unpacking to MBMS session start request
* Starting to add TNL Information unpacking
* Added unpack for MBMS session start request.
* Strating to add MBMS session start request packing.
* Adding MCE MBMS M2AP Id packing.
* Added MBMS Session Start Reqeust pack and unpack.
* Added MBMS Session start response packing/unpacking.
* Starting to add unpacking of MBMS Scheduling information.
* Adding MCCH Update time Unpacking.
* Adding MBSFN Area Configuration List Unpacking.
* Starting to add unpack PMCH configuration Item.
* Adding AllocatedSubframesEnd unpack
* Fixed multiple mistakes in unpacking PMCH configuration.
* Unpacking MCH Scheduling Period
* Continue to unpack MBMS Session List Per PMCH Item.
* Added unpacking of PMCH Configuration List. Starting to add unpacking of MBSFN Subframe Configuration List.
* Adding radioframe allocation period and offset unpacking.
* Added unpacking of MBMS Scheduling Information (needs testing.)
* Added more testing to MBMS Scheduling Info.
* Small commit.
* Added more testing to the unpacking of MBMS Scheduling Information. Unpacking correctly now.
* Continue to pack MBMS Scheduling information. Packing PMCH Configuration.
* Fixed mistach in packing PMCH configuration list.
* Adding more packing to MBMS scheduling info message.
* Fixed more mistakes in MBMS Scheduling information packing. Passing tests now.
* Added MBMS Scheduling Information Response.
* Remove debug prints.