4154 Commits (aabec3d7af38520f29fd40fba2e88ac72df580fe)

Author SHA1 Message Date
Xavier Arteaga 2cd5e98132 Fix NULL check in DCI NR for RAR type 3 years ago
Xavier Arteaga 3784359da5 Use NR DCI format 0_0 packing and unpacking for TC-RNTI type 3 years ago
Xavier Arteaga b846116c5c Added NR RAR UL DCI packing 3 years ago
Francisco Paisana 55d83a1279 fix compilation issue due to wrong include path for srsran_assert.h file 3 years ago
Francisco Paisana f518861ebc fix location of support/ folder. Created macros for ASSERT_EQ and ASSERT_NEQ 3 years ago
Francisco Paisana 599fc978a5 improvement of srsran_assert design, with specializations to enable/disable assertions based on compile flags other than ASSERTS_ENABLED. Creation of the support/ folder 3 years ago
Francisco Paisana e896ac49e8 adt: create split optional span view to be used for C-array types 3 years ago
Francisco Paisana d616e46936 adt: allow choice between static and dynamic optional vector types 3 years ago
Francisco Paisana 1596fcf349 adt: rename optional table to optional array 3 years ago
Francisco Paisana 8c24cfebd3 adt: create data structure type to represent an array of optional fields 3 years ago
Francisco Paisana eb4999a18e lte,pdcp: silence error message when a reconfiguration of a PDCP entity is no-op 3 years ago
Andre Puschmann 32ab1baeb1 enb,rrc: during NSA activation, remove EUTRA DRB and set MAC logical channel config 3 years ago
Andre Puschmann 9e7852ac83 srsran_asn1_nr: add RLC config to packing test 3 years ago
Andre Puschmann 1c3a03cb2b rlc: fix memleak in queue_rx_pdu
* alternative to #3141
* use byte_buffer as queue element
3 years ago
Andre Puschmann c365c16531 gnb_interfaces: inherit from EUTRA interfaces when they are identical 3 years ago
Andre Puschmann 4076338a1b enb: add MAC-NR PCAP
* use fixed filename until eNB stack layout is decided
3 years ago
Andre Puschmann c03623863b enb,nsa: fix UL PDU processing
* remove const from pusch_info() MAC/PHY interface to allow moving unique byte buffer
3 years ago
Andre Puschmann fc35c0ee51 enb,nsa: fix packing of DL MAC PDUs
* use byte_buffer_t as interface type for DL PHY-MAC interface
* fix missing clear() for new DL tx
3 years ago
Andre Puschmann 4a828be39f rlc_am_test: fix reestablishment test
after changing the retx counting we receive one SDU more than before
3 years ago
Andre Puschmann 7726acad41 rlc_am_lte: fix counting of retx of entire PDUs and PDU segments
this patch fixes a bug discovered in a real network where the DL CQI of a
user degraded repidly in very short time. A relativly big RLC PDU that
was still sent with the good CQI in a big grant now needs to be split
across many tiny segments because the CQI degraded so much.

The retx couting for each transmitted segment caused the retx counter to
reach maxRetx quickly.

With this patch we do not increment the retx counter for each transmitted
PDU or segment of a PDU but instead only increment the counter when
a given SN is added to the retx queue. This can happen either:
a) if the SN is negativly acknowledged and was not already on the retx queue,
b) no new data is available for tx and a SN is selected for retx.

This is in accordance with TS 36.322 which handles retx counting in section
5.2.1 according to the above description.
3 years ago
Xavier Arteaga cba6df3722 Extended NR PHY robustnes against wrong RRC configuration 3 years ago
Xavier Arteaga de89e829e7 Added NR PUCCH Resource ASN1 helper 3 years ago
Xavier Arteaga 3ae131b336 gNb creates PUSCH decode PDU 3 years ago
Xavier Arteaga 98f29961bc Fix old GCC compilation 3 years ago
Xavier Arteaga 856573b92f Added 4096 symbol size as LTE rate 3 years ago
Xavier Arteaga 54e1fe172c Minor NR PHY aesthetical modifications 3 years ago
Xavier Arteaga 956c4f8266 Added PHY NR test TDD FR1.15-1 pattern 3 years ago
Xavier Arteaga dfa323df6b Added 20MHz default configuration 3 years ago
Xavier Arteaga ea802c23f2 Remove PHY lib verbose from test and use byte vector random function 3 years ago
Xavier Arteaga 1b50758bd5 Initial NZP-CSI default configuration from TS38.101-4 3 years ago
Andre Puschmann 28668aac34 ue,proc_ra_nr: add temporary flag to skip RAR reception
this will be removed again as soon as the eNB supports full RAR
transmission.
3 years ago
Andre Puschmann 3b5344b0f7 thread_pool: add optional ID to thread pool
this allows to prepend an ID to each thread pool to
better differentiate workers from different pools
3 years ago
Andre Puschmann 38f1e158a5 enb,nr: fix NR PHY PRACH init and MAC-PHY interaction 3 years ago
Xavier Arteaga a300a47673 Fix value selector for NEON 3 years ago
Xavier Arteaga 42b052112f Added TS reference and use SRSRAN_CEI_LOG2 macro 3 years ago
Xavier Arteaga 1f495cb008 Added generic SRSRAN_CEIL_LOG2 3 years ago
Andre Puschmann b6f8280f67 cqi: protect potential div by zero bug 3 years ago
Andre Puschmann b388930325 srsran_asn1_rrc_nr_test: disable PCAP output by default 3 years ago
David Rupprecht 11f9ac75db Added PLMN to serving network string name 3 years ago
Xavier Arteaga 085e247ece Fix ZMQ TX channel mapping for NULL pointers
Fix ZMQ transmit frequency mapping

Use map mask in ZMQ to determine mapped channels

Fix ZMQ mapping
3 years ago
Xavier Arteaga 562fd1b4d4 Fix segfault 3 years ago
Xavier Arteaga dbb10dd6a2 Hold worker thread until baseband is transmitted 3 years ago
Xavier Arteaga 0c7239e5df SRSUE: add RF channel offset 3 years ago
Xavier Arteaga b57df4db10 Refactored worker_end mechanism for concurrent workers 3 years ago
Andre Puschmann e833751031 rrc_nr: add CSI config packing 3 years ago
Andre Puschmann f181733c7e rrc_nr,enb: add more fields to spcell cfg dedicated 3 years ago
Andre Puschmann 4915dc9642 test_pcap: add function description 3 years ago
Francisco Paisana bd08a64b5e sched: fix crash for 100 prbs and subband CQI reporting 3 years ago
Andre Puschmann 45c1971249 mac,phy,interface: clean up and add NR interface to LTE stack
* remove obsolte rx_data_ind
* add mac_phy_interface_nr to LTE stack
3 years ago
David Rupprecht 04ef6e120d Added new SIM functions to get MCC, MNC and MSIN 3 years ago
Bedran Karakoc a6226379b4 Introducing NGAP UE context procedures 3 years ago
Ismael Gomez a896e32cf4 Refactor sub-band CQI processing 3 years ago
Ismael Gomez 9b10e1c45d Fix sub-band CQI in UE. Refactor variable names 3 years ago
Francisco Paisana 12e33483e1 sched,nr: add slot_point to sched nr 3 years ago
Francisco Paisana a0a1af9d0f nr: slot value that handles wrapping around 3 years ago
Andre Puschmann a7eb9b471b pssch_file_test: relax test result check
the file test sometimes decodes 2 and sometimes 3 (less often) SCI.
its not entirly clear why it's different though.

this "fixes" #3088
3 years ago
Xavier Arteaga ca5ea369f5 Extended ue_dl_nr_file test 3 years ago
Xavier Arteaga 914a2e2d31 Add SCH NR softbuffer check 3 years ago
Xavier Arteaga b59c330858 Fix filesource include 3 years ago
Xavier Arteaga 858fc2c0fc Cleanup include 3 years ago
Xavier Arteaga 5a6b8f42f5 Add standard rate check for FFT minimum size function 3 years ago
Xavier Arteaga 98929c95a8 Initial UE DL NR file test 3 years ago
Xavier Arteaga dcf9ae039c Fix related Sidekiq comments and mutex 3 years ago
Xavier Arteaga b3d9a94dd5 SIDEKIQ: fix tx time protection 3 years ago
Xavier Arteaga ecf668ee9e SIDEKIQ: fix comment 3 years ago
Xavier Arteaga 96ee4b7258 SIDEKIQ: Initial implementation
SIDEKIQ: Add SKIQ_FOUND to RF found condition

SIDEKIQ: finished SKIQ component abstraction

SIDEKIQ: fix issues and added external PPS example

SIDEKIQ: add PPS test card index argument

SIDEKIQ: improvements

SIDEKIQ: improved srate change

SIDEKIQ: more improvements

SIDEKIQ: more fixes

SIDEKIQ: fix Rx ch gain

SIDEKIQ: Fix multi-card synchronism

SIDEKIQ: Better Rx gain tracking
3 years ago
Robert Falkenberg 24e52d6291 soapy: fix array parameter mismatch for some functions
With soapy 0.8.0, GCC 11.1.0 warns of mismatched array bounds
in some functions.
This commit aligns the bound and adds proper wrappers to
fix subsequent warnings.
3 years ago
Francisco Paisana bc5a548fe8 sched: scheduler now accounts for prachs with different durations 3 years ago
Xavier Arteaga bb4f469794 Integrated SR decoder in gNb 3 years ago
Xavier Arteaga 6a9baef11d Limit DMRS PUCCH SNR to void NAN/INF 3 years ago
Xavier Arteaga d783fbf3a0 Reviewed NR procedure for PUCCH resource sselection and reviewed gNb PUCCH interface 3 years ago
Xavier Arteaga 64f4767c4f Fix NR PUCCH decoder memory access 3 years ago
Andre Puschmann 60a795acc0 asn1,rrc_nr,test: extend RRC reconf test, add PCAP output
test now can write the NR reconfig into a PCAP for easy
debugging with Wireshark

patch also adds a new test helper to write a RRC PDU
into a PCAP file (helper packs PDCP and RLC AM first)
3 years ago
Andre Puschmann c9c3a68fae asn1,rrc_nr: add error code handling to packing/unpacking of pdcch_cfg 3 years ago
Ismael Gomez 6fb9b6bf94 Fix sub-band CQI in UE. Refactor variable names 3 years ago
Francisco Paisana 74d0a8adb8 sched: add subband cqi info interface to LTE scheduler 3 years ago
Ismael Gomez 2e1127f385 Add sub-band CQI periodicity and configuration to lib 3 years ago
Ismael Gomez 3f5094f30e Remove confusing subband_size variable and replace with subband_wideband_ratio 3 years ago
Andre Puschmann a142192d4e test_common: handle return value from make_byte_buffer() 3 years ago
Andre Puschmann 8d2e81ad6f enb,mac,nr: add basic UE object skeleton
refactor that also adds a basic UE object to the NR MAC
3 years ago
David Rupprecht 0217bf5332 Fixed name space for rrc ue 3 years ago
Francisco Paisana 09c7000201 sched,nr: update nr scheduler to use new mac nr interface types 3 years ago
Francisco Paisana d9336bcd9e sched,nr: creation of pool of softbuffers for NR. Now the sched NR harq manages the lifetime of the softbuffer and its forwarding to the PHY 3 years ago
Francisco Paisana 1535e6b205 sched,nr: extend sched nr testing suite. restrict paralllelization for correct DAI generation 3 years ago
faluco b79481f74b - Fix text formatter unit test for printing the date. 3 years ago
Francisco 357bc10a17 feature - make minimum SNR, under which the RRC is notified with UL KO, configurable 3 years ago
faluco 8708043a5f - Add date to log timestamps.
- Print once per second the current timestamp into stdout, feature guarded by a config expert option.
3 years ago
Francisco 67325ab5c1 add pdcch_cqi_offset parameter to enb.conf 3 years ago
Francisco 2a31daca4a enb,configuration: allow to specify enb specific max nof RLC retxs 3 years ago
Andre Puschmann b5b2f8190e signal_handler: use std::atomic for running var 4 years ago
Andre Puschmann ff5fe5df14 rf_uhd_imp: fix race in RF metrics 4 years ago
Pedro Alvarez 8d41c0d476 Maded SRB configuration optional in rb.conf 4 years ago
David Rupprecht d990db66f6 Added syslog logger 4 years ago
faluco 7b7ecb7983 Add a new configuration option that controls PDSCH baseband sample dump to a file on KO. 4 years ago
Xavier Arteaga b25681f9de gnb,prach: add PRACH to gNB
rebase of Xavier's feature_gnb_prach branch
4 years ago
David Rupprecht fb92118bb7 Add 5G NAS infrastructure 4 years ago
David Rupprecht e0b09f1301 Fixed coverity findings 4 years ago
David Rupprecht 709b706d07 Fix 5G NAS extended protocol discriminator 4 years ago
Andre Puschmann 6c82d63aa6 remove legacy PNF/VNF code
the code hasn't been maintained for a while an likely needs to be
adapted for a real-world scenarios.

in order to avoid having to maintain two MAC/PHY interfaces we
remove the code from now.
4 years ago
Xavier Arteaga 54a12870ec SRSUE: avoid negative SR transmission in NR 4 years ago
Xavier Arteaga 603c67e36d Set g_ulsch LLR overlaped with g_harq_ack to zero 4 years ago
Xavier Arteaga 3416aad16d Fix PUSCH NR test false alarm 4 years ago
Xavier Arteaga 04aca98e5f Added more checks in PUSCH NR test 4 years ago
Xavier Arteaga ef865b81a3 NR SCH TB information prints actual rate and not the target rate 4 years ago
Xavier Arteaga 11a52248cd RA NR Calculates actual PUSCH rate 4 years ago
Xavier Arteaga 35840d6bc1 Removed all zero condition from LDPC decoding 4 years ago
Xavier Arteaga 64b7dfed65 UHD: fix nullptr buffer 4 years ago
Xavier Arteaga ecc0b92142 Integrated PUSCH decoder in gNb 4 years ago
Xavier Arteaga f07d925be1 Initial NR PHY test scheduling for PUSCH 4 years ago
Andre Puschmann 654afac9c7 nas_5g_msg_test: remove copy_msg_to_buffer() that is now in test_common.h 4 years ago
David Rupprecht 724af2b060 Added nas 5g msg packing and unpacking 4 years ago
Andre Puschmann e330f50ef8 rrc_meas_test: add packing test for measObjectNR 4 years ago
Andre Puschmann a2dd83a7e9 asn1: rename RRC NR test to avoid confusion with component test 4 years ago
Andre Puschmann fd7b9a0575 enb,nsa: add basic RRC EUTRA<>RRC NR interface for SgNB addition 4 years ago
Andre Puschmann 6bf3feda92 rrc_nr_test: add packing test for NR radio bearer config
also add (still incomplete) secondary cell group config pack test
4 years ago
Andre Puschmann c9e87b2cf3 config_file: print message when config file couldn't be read
this prints an message on stdout so config files are not
simply skipped and the default one is read instead.
4 years ago
Andre Puschmann fa461f0129 rrc_nr: fix linker error in setup_release_c
move implementation to cc file to avoid

[build] /bin/ld: CMakeFiles/rrc_nr_asn1_test.dir/rrc_nr_test.cc.o: in function `asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::set_setup()':
[build] /home/anpu/src/srsLTE/lib/include/srsran/asn1/rrc_nr.h:2276: undefined reference to `asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::set(asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::types_opts::options)'
[build] clang: error: linker command failed with exit code 1 (use -v to see invocation)
4 years ago
Andre Puschmann 4379c20eb9 rlc_am_lte: avoid locking of Rx mutex twice when generating status PDU
call reset_status(), which now is an private method directly when
building a status PDU. No need for the Tx side to call Rx again.
4 years ago
Andre Puschmann 53a7dc78ee rlc_am_lte: replace do_status boolean with atomic
the do_status is queried from the Tx code frequently. To reduce
chances to delay the execution because the RLC Rx side is currently
holding the mutex we can use an atomic.
4 years ago
Xavier Arteaga 5307fec2f0 Added GNB MAC UL info initial interface and fix PHY implementation 4 years ago
Xavier Arteaga cf496e75eb Fix default PHY NR configuration 4 years ago
Xavier Arteaga 2fbd172888 Initial PHY NR configuration generator 4 years ago
Xavier Arteaga 320aabec13 Initial PHY NR configuration 4 years ago
Xavier Arteaga e764a26136 Integrated PUCCH decoding in gNb 4 years ago
Xavier Arteaga 3fe9176750 Added PUCCH dedocder to slot worker 4 years ago
Xavier Arteaga e3afd945bc Refactored NR HARQ ACK feedback 4 years ago
Xavier Arteaga 658b47d917 Added NR PUSCH and PUCCH decoder in gnb_ul 4 years ago
Xavier Arteaga 89994cd5a8 change ERROR macro format to be parsed by IDE 4 years ago
Xavier Arteaga f6fc215541 Refactored enb_dl_nr to gnb_dl and initial gnb_ul 4 years ago
Xavier Arteaga eecaccb541 Added NR PHY helpers 4 years ago
Andre Puschmann 6372f89c09 s1ap_test: fix compilation on 32bit 4 years ago
Andre Puschmann f292042f66 rlc_am_lte: use try-lock when building status PDU
the patch uses try-lock whenever a status PDU is tried
to be built. This makes sure that when the lock is currently
hold (e.g. by a thread processing rx PDUs) the generation
of the status PDUs is not taking too long and blocking the calling
thread. Instead the status PDU generation is deferred to the next
Tx opportunity.

It's a probabilistic approach that assumes that at some stage the
lock can in fact be acquired.
4 years ago
Andre Puschmann a9d21696c5 rlc_am_lte: make number of RLC SDUs per PDU a compile-time parameter
this allows to set the maximum number of RLC SDUs included
in a single PDU at compile time.
4 years ago
David Rupprecht f90e359208 Moved cp to test common 4 years ago
Andre Puschmann bbcaa49429 network_utils: fix TSAN detected race 4 years ago
Andre Puschmann a9ad408f51 task_scheduler: use block_queue for internal tasks
TSAN detected wrong use of the old deque-based internal queue. To avoid
unwanted/undetected mis-use the patch uses the thread-safe block_queue
data structure instead.
4 years ago
Andre Puschmann 626f24c9f9 block_queue: use class mutex to protect size() getter
detected with TSAN
4 years ago
Andre Puschmann 0e6e3d201e sys_metrics: reduce log level when measurement interval is shorter than expected
on highly loaded systems it can happen that the get_metrics() is called
twice within a few houndred milliseconds. Logging a warning in this
case isn't needed, so reduce to info.

on the other hand, 100ms might be to convervative. Patch also
lowers the smallest interval to 10ms
4 years ago
Ismael Gomez 4e39982a19
Fix TSAN warnings in UE (#3021)
* Protect PHY SR signal management in a class

* Protect intra_freq_meas vector

* Protect cell and srate shared variables in thread-safe classes

* srsue,srsenb: include TSAN options header

* Protect ue_rnti_t and rnti scheduling windows behind thread-safe classes

* Protect access to state variable in sync_state

* Protect access to metrics configuration

* Protect access to is_pending_sr

* Protect access to UE prach worker

* Protect UE mux

* Avoid unlocking mutex twice

* Fix data races in RF/ZMQ

* Fix data races in intra_measure and PHY

* Fix minor data races in MAC

* Make TSAN default behaviour to not halt on error

* Fix blocking in intra cell measurement

* Address comments

Co-authored-by: Andre Puschmann <andre@softwareradiosystems.com>
4 years ago
David Rupprecht 4ed33fed7d Fixed unpack bytes limit 4 years ago
Pedro Alvarez 05fbca43d1 Fix GCC 11 warning in dyn_array 4 years ago
Pedro Alvarez 1b676aa406 Moved lib GTPU to its own folder 4 years ago
Pedro Alvarez 865298f8d5 Moved lib PDCP to its own folder 4 years ago
Pedro Alvarez 171d5727be Moved lib RLC into it's own folder 4 years ago
Francisco Paisana 4d014e7ceb s1ap,feature: make the ts1 reloc timers configurable via the enb.conf 4 years ago
Andre Puschmann b6a3b8c5b1 rlc: fix dtor
TSAN was complaining about destroying a locked mutex
4 years ago
faluco a70ad58440 Fix a data race in the UHD class wrapper where the last error member was being set concurrently causing random crashes.
Introduce a new macro to catch UHD exceptions and log them directly instead of storing an error string, similar to what errno does.

Remove usrp logging helpers that depend on the now removed member since all calls potentially log the error directly.
4 years ago
Andre Puschmann 4d11e5552a rrc,ue: for RRC conn release, delay transition to RRC idle by 60ms as per TS 36.331
when receiving RRC connection release all actions shall be delayed by 60ms as
per the standard
4 years ago
Andre Puschmann 368c7b9e4f ue,stack: clear all EPS bearers when going RRC idle
the EPS bearer manager was only informed when a single DRB
was removed but not when entering idle which requires to
remove all bearers.

This cause the service request to fail.
4 years ago
faluco e20934583e Remove an unsafe assert in the log backend that could be triggered under very certain circumstances.
RFCI has detected this assert failing in the log_backend_test. I have not been able to reproduce this locally but my theory is the following one:
one of the unit tests does the following:

backend.start();
backend.stop();

the internal running_flag member could be set to true and then to false by the main thread before the worker thread calls do_work(). If this happens
the assert will be triggered, which is wrong and too conservative, so remove the assert.
4 years ago