Xavier Arteaga
b02a0d3db9
Added RNTI type short string
4 years ago
Xavier Arteaga
a57336d64f
Integrate periodic SSB measurement in SRSUE and fix related defects
4 years ago
Xavier Arteaga
5e41e99f08
Added NR symbol offset helper function
4 years ago
Xavier Arteaga
7450232b3e
Added more NR band related helpers
4 years ago
Xavier Arteaga
758fd3c1ba
Implemented initial NR cell search
4 years ago
Xavier Arteaga
2f9c7e1345
Avoid cexpf in srsran_vec_apply_cfo_simd
4 years ago
Xavier Arteaga
90c42bc9c3
Fix resampler stack overflow
4 years ago
Xavier Arteaga
9517b78c03
Fix resampler and improved unit test
4 years ago
Xavier Arteaga
d9586015f5
SSB related minor aesthetical corrections
4 years ago
Xavier Arteaga
60d1708b80
Initial SSB measurement implementation
4 years ago
Xavier Arteaga
1396c2a1e2
Mulpiple CSI measurement fixes. Channel and sync metrics from CSI measurements
4 years ago
Xavier Arteaga
e68c822505
NR Added CSI measurement channel processing
4 years ago
Xavier Arteaga
de9158eeaf
Enable NR RRC MCS table selection
4 years ago
Xavier Arteaga
eef3fac863
Improved float XOR readability
4 years ago
Xavier Arteaga
751b6858b3
Added CSI-RS resource set measurements
4 years ago
Xavier Arteaga
3b919b4f6c
Minor aestheics change
4 years ago
Xavier Arteaga
243ad05dfa
Added on the fly sequence apply in float
4 years ago
faluco
aef18f9931
Implement a benchmark for measuring latency in the foreground threads when pushing log entries.
...
This benchmark runs with several threads to test contention.
4 years ago
Xavier Arteaga
318f064ff4
Multiple NR SCH fixes
4 years ago
Xavier Arteaga
b8e0164f7f
Multiple fix NR PHY procedures
4 years ago
Xavier Arteaga
a8e181971c
Refactored PHY NR procedures for supporting DCI formats 0_1 and 1_1
4 years ago
Francisco
ad1a0eb2ac
rlc,fix - Add PDCP PDUs to undelivered_sdu_info_queue when the PDUs are popped from the tx_sdu_queue, rather than they are pushed to.
...
- This simplifies the sdu discard
- This also fixes an existing race condition
4 years ago
Andre Puschmann
598594c51a
all: bunch of pass by const& changes suggested by LGTM
4 years ago
Francisco
7ced0e73eb
rlc,bugfix - avoid accessing the PDCP info of RLC segments when the PDCP has already discarded the respective PDCP SN.
4 years ago
Andre Puschmann
597729ac53
rlc: always remove PDCP SNs from undelivered queue
...
if RLC PDUs with certain PDCP SNs were already in flight
when their discard timer at PDCP expires, they weren't
remove from the undelivered_sdu_info_queue causing
indesired log entries like:
08:08:52.455280 [RLC ] [W] PDCP_SN=2103 already marked as undelivered
when the SN was sent again (after wrap around).
The patch makes sure to always try to delete the PDCP SN
from the queue. It should fix (at least partly) #2560
4 years ago
Andre Puschmann
20075f6f33
rf_uhd_generic: fix segfault when accessing device tree
...
for some reasons the dev tree isn't available on the X310
with UHD4 and the code never checked the return value, causing
a segfault with that combo.
4 years ago
Xavier Arteaga
949ce965c7
Fix SCH NR CRC check
4 years ago
Xavier Arteaga
fb5dfb3a86
Improved NR unit test
4 years ago
Xavier Arteaga
28170c92a9
Multiple NR SCH fixes
4 years ago
Xavier Arteaga
efb8da69d8
Cleaned DCI NR info string
4 years ago
Xavier Arteaga
8cb3e92ab3
Added LDPC flooded early stop
4 years ago
Xavier Arteaga
6c39a5e4ff
Added PDSCH DMRS aditional unpacking
4 years ago
Xavier Arteaga
86ad0446e1
Added NR PDSCH and PUSCH resource allocating flattening
4 years ago
Xavier Arteaga
892aea8219
Fix coverity warnings under lib/src/phy/utils
4 years ago
Xavier Arteaga
87cf3cf2e5
Fix coverity warnings under lib/src/phy/phch
4 years ago
David Rupprecht
bde30bb9be
Added tests for band helper
4 years ago
Andre Puschmann
937c4ff3c3
demod_soft: removed unused NEON code
...
clang complained about unused code, so remove it of course.
4 years ago
Xavier Arteaga
71226e89df
Minor dereference check
4 years ago
Xavier Arteaga
b6fa82bf9a
Fix more static analysis warnings
4 years ago
Xavier Arteaga
efd6c569b8
Fix some static analisys warnings under lib/src/phy/fec
4 years ago
Xavier Arteaga
217f3cb416
SRSENB: select highest with/without SR correlation PUCCH result
4 years ago
Andre Puschmann
ada6c71b5a
rf_soapy: fix logic to print warning when Lime is used with short sample rates
...
previously the warning was printed when a Lime was connected to the PC.
Now all connected devices are printed but the warning is only
shown if the selected device is the Lime.
4 years ago
faluco
aa3309157b
Fixed polar encoder and decoder initialization failure for ARM. Initialization unconditionally used x86 SIMD routines instead of getting disabled for ARM compilations.
4 years ago
faluco
d9e5f4ccc7
Replace a couple of inline functions in demod_soft with macros to allow constant propagation. The vgetq_lane_sX builtin expects a constant instead of a variable.
4 years ago
Francisco
86dac9c823
several coverity high and medium impact fixes
4 years ago
Xavier Arteaga
9a4fcb605b
Reviewed UHD Tx FSM
4 years ago
Xavier Arteaga
3413f29cc8
Fix channel interpolator for 4 ports
4 years ago
Andre Puschmann
03e1277b0b
rf_soapy_imp: fix lowercase to detect Lime
4 years ago
Andre Puschmann
b569e81299
rf_soapy_imp: fix LTE sample rate info check
...
only print if Lime is substring in dev args, so don't print with blade
4 years ago
Andre Puschmann
4dd17aee45
rrc/phy/nr: calculate tuning freq of NR carrier from RRC signaling params
...
skip initial tuning to hard-coded NR frequency and use RRC-provided
values to calculate center frequency
4 years ago
Andre Puschmann
6e79ae67aa
ldpc/polar: add casts to avoid possible variable overflow before assignment
4 years ago
Andre Puschmann
ff53d2b8b8
all: set of trivial changes reported by LGTM
...
mainly fixmes, unused/empty code, etc.
4 years ago
AlaiaL
0535473895
Fixes coverity 369570
4 years ago
AlaiaL
6332490cae
Fixes coverity 369581
4 years ago
AlaiaL
385b12a33a
Fixes coverity 369620
4 years ago
AlaiaL
23f0bd4d4f
Fixed coverity 369716
4 years ago
faluco
1ccb62af3d
Apply srsLTE formatting rules to srsLog. They were previously formatted with different rules when the project lived in the external rapo.
4 years ago
Xavier Arteaga
873f375ecc
Make NR DCI test more exhaustive and fix issues
4 years ago
Xavier Arteaga
ab6a5ef17a
Added NR DCI conversion to string for formats 1_0 and 1_1
4 years ago
Xavier Arteaga
bccfa8d875
Added NR DCI packing/unpacking format 1_1
4 years ago
Xavier Arteaga
11b9990224
Added NR DCI packing/unpacking format 0_1
4 years ago
faluco
0afd59a5a0
Replace a string with a const char * in the rlc to_string.
4 years ago
Francisco
289559af82
asn1 fix - fix choice access correct type assert
4 years ago
Francisco
ff3fc0826b
asn1 fixes and improvements
...
- use const char* instead of std::string in enumerated<>::to_string() to avoid mallocs.
- Remove the use of "typedef", and use "using" keyword instead.
- Fix rrc_nr::setup_release_c<>::to_string() broken linkage.
4 years ago
David Rupprecht
98914dab6a
Allow pdcp lte entity to use 18 bit SN
4 years ago
Xavier Arteaga
407903e0d6
SRSUE: refactor carrier setting for accepting a dynamic carrier configuration
4 years ago
Xavier Arteaga
47523935f6
Minor NR RRC fixes
4 years ago
Francisco
3b78bf3730
bugfix - fix memcheck warnings. move instructions with side effects outside of asserts
4 years ago
David Rupprecht
a064e85c54
rename common lte header
4 years ago
David Rupprecht
91ff8a2e6d
Add rrc_nr to rlc init function
4 years ago
David Rupprecht
6b41ae7e8b
Updated PDCP config struct for rat type
4 years ago
Xavier Arteaga
77b6b60b82
Fix rach_cfg.nof_groupA_preambles
4 years ago
Xavier Arteaga
aadbe6d880
Normalise NR PUSCH to maximum Tx power
4 years ago
Xavier Arteaga
53e41a165c
Revert zeros around DC REs in NR PDSCH
4 years ago
Xavier Arteaga
93c3dc1cb1
Revert "Demodulator sets LLR to zero for 0.0 symbols"
...
This reverts commit 1a6e5cdee5
.
4 years ago
Xavier Arteaga
1c1d7e2447
Revert "Review soft demodulator zero check"
...
This reverts commit b8a9a7fc70
.
4 years ago
Xavier Arteaga
0999b271ba
Added RFNOC based LO frequency offset
4 years ago
David Rupprecht
db9dd85783
Parse carrier config in NR RRC reconfig
4 years ago
David Rupprecht
f42d4dbc28
Refactored carrier config
4 years ago
Andre Puschmann
9009c3439c
rlc_um_nr: convert log entries to info if they are expected
...
dropping a PDU and not being able to build a PDU if the
grant is too small is expected and should therefore not cause a log warning.
4 years ago
Andre Puschmann
936bebcfd7
rrc_nr_utils: fix extraction of HARQ processes from ASN1 reconfig
4 years ago
Xavier Arteaga
53b38fccf9
Fix compile and other
4 years ago
Xavier Arteaga
ed0929b46d
NR PHY logging minor corrections
4 years ago
Xavier Arteaga
8ffced7e88
NR PHY logging minor corrections
4 years ago
Xavier Arteaga
abfc1da921
Multiple NR-PUSCH fixes
4 years ago
Xavier Arteaga
7e06e789d5
Fic NR UCI in the info string
4 years ago
Xavier Arteaga
01ce0718be
NR-PUSCH RE mapping correction and NR-SCH detailed grant information
4 years ago
David Rupprecht
bfe2ad98ef
Added parsing for NR DL HARQ cfg
4 years ago
Andre Puschmann
b9ae064338
mac_nr: add DL HARQ
...
this commit adds a complete DL HARQ entity to the MAC of the UE.
It also refactors demux into an own class and adapts the PHY-MAC
interface to use the new MAC capabilities.
4 years ago
Francisco
e3e4564a7e
fix inconsistency in use of invalid_sn and status_report_sn throughout rlc am code
4 years ago
Francisco
c3ec28002b
refactor - integration of segment list in rlc_amd_tx_pdu and pdcp_pdu_info classes
4 years ago
Francisco
7f0083a985
implementation of intrusive list abstract classes to be used in RLC for lists of segments
4 years ago
Francisco
b06f16891d
use of a single array-based pool of RLC AM PDU segments to build data PDUs, while
...
avoiding any allocations.
Each segment stores its own PDCP SN and RLC SN and has two pointers,
one for the next segment of the same RLC PDU, and another for the next segment
of the same PDCP PDU.
4 years ago
faluco
e1752c0878
Replace the queue in thread pool in favour of a static circular buffer to avoid allocations.
4 years ago
David Rupprecht
fe8727050b
Added new rrc_nr to phy flattening functions and fixes
4 years ago
Xavier Arteaga
e4e3456d76
Refactored PDSCH/PUSCH decoder for LDPC early stopping
4 years ago
Xavier Arteaga
6c5e28bc19
Optimised AVX512 LDPC decoder hard decision
4 years ago
Xavier Arteaga
422d479852
Added CRC match function and optimised byte packing
4 years ago
Xavier Arteaga
5aa7f9dd8b
Condensed LDPC Decoder config arguments into an structure and unified common decoder code
4 years ago
Francisco
e37968410e
simplification of timers handler design, relying solely on one time wheel.
4 years ago
Francisco
66988ffd32
s1ap - simplified erab setup procedure. Handle correctly the failure to setup causes
4 years ago
Francisco
f401683960
s1ap - simplified erab modify procedure
4 years ago
Francisco
76978f0d14
s1ap - simplified erab release procedure
4 years ago
Xavier Arteaga
faa6d01e9d
Fix RFNOC compilation
4 years ago
Xavier Arteaga
c82f609085
Fix b200mini external clock
4 years ago
Andre Puschmann
b7146c41b2
nr: add NDI for PUSCH grant to sch cfg struct
4 years ago
faluco
a474a0f293
SRSLOG: Avoid calling unordered_map::emplace if element already exists since it will allocate even if the insertion is not going to take place.
4 years ago
Xavier Arteaga
7823bfc28c
Fix append NR to loggers for NR components
4 years ago
faluco
daad20c9d4
Disable copy and move operations for dyn_node_pool.
4 years ago
faluco
a2f6e13138
Add a tag to the string memory pool in fmt to discriminate between pool vs heap allocated buffers. Heap allocated buffers are used as a fallback mechanism when the buffer runs out of space.
4 years ago
faluco
0465f6badd
Implement a pool in FMT to avoid allocating heap memory when passing a char* to the backend, usually when formatting a %s argument.
...
Previously since a char* can have any length, this was managed by FMT by converting it into a std::string.
Now we store it into a configurable size node that can store a fixed size string, otherwise it falls back to std::string.
4 years ago
Xavier Arteaga
2f453b43ba
Initial NR PHY interface
4 years ago
Francisco
d2c404b166
handover - setup s1ap cause in case of handover failure at the target enb
4 years ago
David Rupprecht
5a3a2a6d6f
Added functions for adding phr and tag config
4 years ago
Andre Puschmann
48537f3fe7
pdcp,rlc: increase number of PDCP SDUs for notification from RLC
...
the current value of 256 limits the number of PDCP SDUs that can be
notified from RLC. The limit is quickly hit when too many SDUs
are in flight. This can cause unwanted log entries and weird PDCP
behaviour.
the patch increases the value to 1024, which still can be too few if
many smaller SDUs are traveling.
The patch also set the log level to warning to quicker spot
misconfigs in logs.
Fixes #2616
4 years ago
Xavier Arteaga
2f8ea05132
SRSUE: Add periodic CQI R10 parsing
4 years ago
Andre Puschmann
c9da21c9bb
mac_nr: add error handling when unpacking SCH MAC PDU
...
* only handle PDU if unpacking was successfull
* add TC unpacking with malformed PDU
4 years ago
Xavier Arteaga
e989e62c52
Fix NR PDCCH DMRS test
4 years ago
Xavier Arteaga
b8a9a7fc70
Review soft demodulator zero check
4 years ago
Xavier Arteaga
dd26c6a90e
Added more comments for better understanding in NR PDCCH DMRS
4 years ago
Xavier Arteaga
17a3c76540
Fix NR TDD pattern configuration
4 years ago
Xavier Arteaga
c84e73541d
Offset FFT window for UE DL NR
4 years ago
Xavier Arteaga
f799ab6f94
Fix NR UL RV selection
4 years ago
Xavier Arteaga
42dcff45b2
Improve PDCCH NR detection
4 years ago
Xavier Arteaga
1a6e5cdee5
Demodulator sets LLR to zero for 0.0 symbols
4 years ago
Xavier Arteaga
3889f1369f
Added partial NR time resource mapping tables
4 years ago
Xavier Arteaga
de187d4c88
Fix copy-past issue in srsran_vec_apply_cfo_simd
4 years ago
Xavier Arteaga
2e3c00aa97
NR PDSCH zeroes RE around the DC. Added delay and CFO emulation to phy_dl_nr_test
4 years ago
Xavier Arteaga
667cc0b552
NR PDSCH/PUSCH DMRS estimation precompensates Synch error and CFO before interpolation
4 years ago
Francisco
685c971dc2
fix recursive call to get rb name
4 years ago
Francisco
21718af3b6
avoid allocating std::string to get lcid radio bearer name. Refactored the lte radio bearer enum type
4 years ago
Andre Puschmann
b991b07167
rlc: add length check for RLC PDU generation
...
makes sure that RLC doesn't generate a PDU larger than
the provided grant size
4 years ago
Andre Puschmann
9950278a12
nr,mac_sch_pdu,mux: fix packing of MAC subPDUs with 16bit L field
...
the created RLC PDU was too large to fit inside the MAC grant
because only the header room for the short L field was used.
The patch determines the correct size before passing the opportunity to RLC.
It also improves logging in error case by using the MAC logger instead of
stderr/stdout when error occurs.
4 years ago
Francisco
75e9700de0
rlc - usage of memory pool to allocate RLC bearers
4 years ago
Andre Puschmann
db496df1e6
mac_nr: add support for periodic BSR reporting
...
building on the previous refactor this patch now adds support
for peridoic BSR reporting (using short BSR). It furthermore does
the following changes:
* add BSR packing
* add proc_bsr_nr unit test
* move mac_nr test code into test folder under src (needs to be done with other test code too)
4 years ago
Andre Puschmann
6dd8c21073
mac_sch_pdu_nr: add unpacking of TA CE in DL-SCH
...
also add basic test to verify correct unpacking
4 years ago
Francisco
dc763b5045
rlc am - fix bugs in buffered_pdcp_pdu_list
...
The count and container elements were not being correctly updated in the events
of SN overwrite, clear(), clear_pdcp_sdu(sn) of sn that doesnt exist
4 years ago
David Rupprecht
82c9636156
Refactor pdcp ctor seperate the configure function
4 years ago
David Rupprecht
7a481c40ab
Added mac prach nr proc error handling
4 years ago
Xavier Arteaga
58a9ef6e7f
Minor NR PHY tweaks and aesthetic
4 years ago
Xavier Arteaga
991c6e7016
Refactored NR HARQ-ACK feedback enqueue
4 years ago
Xavier Arteaga
22239b29c5
Disable smoothing filter for NR PDCCH DMRS
4 years ago
Xavier Arteaga
9f54c6ae6d
Fix NR PUCCH info string and memory leak
4 years ago
Andre Puschmann
0fdcea2924
rlc_am: count every segment retx as a full retx for this SN
...
previously we were only counting retx if we retx the start of a segment.
this could lead to unwanted behaviour, i.e., not counting retx
correctly and thus not triggering the maxretx attempt, if the receive
always sends NACKs with a SO_start.
The RLC spec is not clear on how this should be handled correctly but
IMHO using an integer number of retx is reasonable, even for segments
that might be retransmitted more often.
The alternative of using a fractional retx counter that may be increamented
proportional to the segment size that is retx is another alternative
but considered too complex to implement (and test correctly).
4 years ago
Andre Puschmann
c74661ae95
rlc_am: add log message when received NACK SN is already on retx queue
4 years ago
Francisco
d02cc51e33
use mutex or atomic in running flag to signal the interruption of a thread
4 years ago
Xavier Arteaga
49731ab5a1
Initial NR-DCI refactor
...
Added NR DCI 1_1 size
Several DCI NR fixes
4 years ago
Xavier Arteaga
64acf03158
Fix sch_nr_test
4 years ago
Xavier Arteaga
3504bfcf5a
Fix NR-SCH test
4 years ago
Xavier Arteaga
39e97cbcf4
Fix unbounded memory access
4 years ago
Xavier Arteaga
29c6adad93
Avoid unused LDPC memory in AVX2 decoder
4 years ago
Xavier Arteaga
392a8cc1b6
Fix LDPC RM number of useful iterations
4 years ago
Xavier Arteaga
3568f633c3
Use LDPC RM number of useful LLR and rename functions
4 years ago
Xavier Arteaga
ecd2c1cdcc
Improved LDPC decoded performance and other NR aesthetical changes
4 years ago
Ismael Gomez
3daba090f6
Fixed compilation of turbo decoder in ARM
4 years ago
Francisco
c24e382c19
Refactor of socket manager class
...
- use of inheritance to simplify testing
- removal of global network manager
- pass of custon socket manager to s1ap and gtpu ctors
- overhauled the registration of socket fd,callback in socket manager
4 years ago
Francisco
4aac7ac238
use global rx multisocket handler, and remove stack-s1ap interface
4 years ago
Francisco
39de2efa69
multisocket handler - use blocking socket remove method
4 years ago
Francisco
bf96d897ee
network utils refactor - renaming of socket handle to unique socket and cleanup of its methods
4 years ago
dr
968c261bec
Reordered lock to avoid deadlock in mac pcap thread
4 years ago
faluco
54fab314c0
Enhance RRC eNB events:
...
- Implement a common event "log_rrc" for all RRC events and discriminate by procedure using an enum.
- Log events for connection, reestablishment, reconfig, reject and release.
- Log the corresponding ASN1 message used by each procedure.
- Redefine the JSON object for this event to match the new structure.
Fixed a compilation error detected by the static analyzer in gcc9.3 where bounded_vector::data() was using taking the address of the internal buffer which confused it, prefer to use the data method of std::array.
4 years ago
Francisco
be771e5c23
performance - use of new concurrent fixed size pool for byte_buffer pool
4 years ago
David Rupprecht
b944528a4f
Install srslog to system folder
4 years ago
faluco
e2c7809abb
- Introduce a new tracer scoped object that only records if the event duration exceeds the programmed threshold.
4 years ago
Xavier Arteaga
6219500148
Added NR-RRC RACH parsing
4 years ago
faluco
4b5e15cd70
- Fixed missing return statements in base_circular_buffer::try_push.
...
- Fixed array index calculation in base_circular_buffer::clear.
- Removed redundant explicit in srslog::backend_worker.
4 years ago
David Rupprecht
8c86d2084d
Adding NR phy config RRC parsing
...
Added error handling
Reworked flattening error handling
4 years ago
Andre Puschmann
48c106ae64
rlc_um_nr: fix packing/unpacking of PDUs with 12bit SN
...
* fix SN extraction/writing
* fix packed header size calculation
* fix segmentation logic and take variable header lenght into account
4 years ago
AlaiaL
1cc2cc4e7f
Fixed typo
4 years ago
AlaiaL
fd3c2b855e
- Renamed log to logger.
...
- Added a log entry in the metrics when skipping a measurement due to
time constrains
4 years ago
AlaiaL
bbaebd1274
Added a warning in the log when the cpu metrics are not registered due
...
to the number cpu cores is greater than supported.
4 years ago
AlaiaL
c9d1c77e8c
- Deleted the magic number of maximum supported cores, now it is a
...
constexpr.
- When the system has more cores that the maximum supported, the cpu
metrics will not be registered.
4 years ago
AlaiaL
6cd9bba641
Added the cpu metrics to the system metrics.
4 years ago
Xavier Arteaga
5bdf2c93b3
Initial NR PDSCH CSI-RS RE skip and other changes
4 years ago
Pedro Alvarez
5bc55ec48c
Changed discard_if to appyly_if in circular_buffer.h.
...
This was done so it would work when circular buffer holds other things
that are not unique_pointers. Queue and pop_func had to be made public
to be able to call the pop_func when an SDU is discarded.
4 years ago
Andre Puschmann
1b1cfa40c9
rlc_am_lte: add some more sanity checks around retx of PDUs
...
this patch doesn't change any functionality but adds a bit
of further error checking around the handling of status PDUs
and the retx of PDUs
4 years ago
Xavier Arteaga
7704c09ce2
Fix typos
4 years ago
faluco
e8395c7474
- Implement a pool to store dyn arg store objects in srslog to avoid allocations when passing arguments to the backend.
...
- Use string views inside the log formatters to avoid allocations.
- Avoid a std::string when using fmt::vsprintf, instead favour fmt::vprintf.
4 years ago
Andre Puschmann
1a0891df51
all: check return value of make_byte_buffer() and handle them safely
4 years ago
Francisco
dd336c53ea
changed srsran_warning to srsran_expect. Applied new macro to rlc am
4 years ago
Andre Puschmann
9d8d897d3e
mac_pcap_base: log warning when PDUs can't be added to write queue
4 years ago
Pedro Alvarez
d91119baf6
RLC discard ( #2515 )
...
* Added ability to discard to dyn_block_queue
* Change way of keeping track of SDUs
* Check nullptr in poping callback. Starting to check for nullptr in RLC read_pdu.
* Adding RLC discard tests
* Clearing PDCP info when RLC discard happens
* Read SDUs until they are no longer nullptr
* Changed discard_if to use template argument
4 years ago
Codebot
4523ee6087
rename srsLTE to srsRAN
4 years ago
Pedro Alvarez
dde8157bf1
Make sure that S1 Setup request is restarted regardless of which error made the procedure fail.
4 years ago
Andre Puschmann
47654af717
pdcp_entity_lte: fix printf formatter for size_t
...
we've seen a heap-buffer overflow in fmt because printf wasn't using
the right formtter for size_t, which should be %zu
this patch fixes it for the PDCP LTE entity but we might have it elsewhere too
[1m[31m==7595==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x629000e6f1fc at pc 0x562273a45289 bp 0x7f35567641f0 sp 0x7f35567641e0
[1m[0m[1m[34mREAD of size 4 at 0x629000e6f1fc thread T12 (STACK)[1m[0m
0 0x562273a45288 in fmt::v7::basic_format_arg<fmt::v7::basic_printf_context<std::back_insert_iterator<fmt::v7::detail::buffer<char> >, char> > fmt::v7::detail::make_arg<fmt::v7::basic_printf_context<std::back_insert_iterator<fmt::v7::detail::buffer<char> >, char>, unsigned int>(unsigned int const&) (/osmo-gsm-tester-srsue/srslte/bin/srsue+0x9dc288)
1 0x562273a3aa86 in void fmt::v7::dynamic_format_arg_store<fmt::v7::basic_printf_context<std::back_insert_iterator<fmt::v7::detail::buffer<char> >, char> >::emplace_arg<unsigned int>(unsigned int const&) (/osmo-gsm-tester-srsue/srslte/bin/srsue+0x9d1a86)
2 0x562273a308e7 in void fmt::v7::dynamic_format_arg_store<fmt::v7::basic_printf_context<std::back_insert_iterator<fmt::v7::detail::buffer<char> >, char> >::push_back<unsigned int>(unsigned int const&) /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/include/srslte/srslog/bundled/fmt/core.h:1548
3 0x562274361541 in void srslog::log_channel::operator()<unsigned int&, unsigned int&, unsigned long>(char const*, unsigned int&, unsigned int&, unsigned long&&) /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/include/srslte/srslog/log_channel.h:101
4 0x56227430d9e7 in srslte::pdcp_entity_lte::update_rx_counts_queue(unsigned int) /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/src/upper/pdcp_entity_lte.cc:451
4 years ago
Andre Puschmann
2cfc657fbb
rlc_am_lte: refactor logging when PDCP SDUs are enqueued
...
the patch refactor the logging when a new PDCP SDU is enqueued for
transmission at RLC.
If the SN is already present, only a warning is logged. From the RLC
perspective operation continues and the SDU will be transmitted.
The patch also changes the order of logs. When the SN cannot be inserted
inside the queue of undelivered SDUs, only one message is logged.
4 years ago
faluco
eb27efd867
Modify the policy of the buffered sink to flush its contents continuously instead of doing it once.
4 years ago
Xavier Arteaga
5f954ab379
Fix UHD compilation
4 years ago
Xavier Arteaga
a8b5b8efa1
UHD: stability improvements
4 years ago
Xavier Arteaga
f9689ec956
Added PUSCH CFO estimation
4 years ago
Francisco
47f1175502
[sched, feature enhancement] - allow variable nof prbs allocated per SIB / Paging message
4 years ago
Xavier Arteaga
f3c0360842
Applied aesthetical changes
4 years ago
Xavier Arteaga
d9780e1f13
Fix duplicated NR-DCI in different search spaces and CORESET and other aesthetic modification
4 years ago
Xavier Arteaga
6fa33c890d
Simultaneous HARQ-ACK, SR and CSI in NR-PUCCH
4 years ago
Xavier Arteaga
1463b11bad
Fix compilation
4 years ago
Xavier Arteaga
be8e8cbe3e
Fix radio decimation Rx stream stall
4 years ago
Xavier Arteaga
10af89fcdd
NR-PDCCH aesthetic changes
4 years ago
Xavier Arteaga
fb1a0b6bce
SRSUE: added NR-PDCCH information
4 years ago
Xavier Arteaga
d3cfb00211
SRSUE: Added TDD DL/UL slot detection
4 years ago
Xavier Arteaga
f3bf0c1c68
Wrap slot index in modulus macro
4 years ago
Xavier Arteaga
4bab0b53b7
SRSUE: fix slot index overflow
4 years ago
Xavier Arteaga
6f6c20e194
SRSUE: Added procedure for multiplexing UCI in NR-PUSCH
4 years ago
faluco
e43f555fc0
- Provide a fast path for logging pre-formatted strings that are small and fit in 64 bytes without any allocations.
...
- Use this new feature in the tracer.
4 years ago
David Rupprecht
be46806495
PCAP: Enable carrier ID TAG
4 years ago
Ismael Gomez
7b33c48fe7
Use static queue in pdu_queue
4 years ago
Pedro Alvarez
f02694dd3e
PDCP status report: Fix issue in keeping track of Rx'ed COUNTs after eNB reestablishment. Fixed issue in logic that limits the size of the rx_counts info vector.
4 years ago
Pedro Alvarez
d2ef541957
Changed the structure to store rx_counts info to std::vector, to reduce
...
memory allocations.
Update the rx_count_info queue if the queue size is too large.
4 years ago
Pedro Alvarez
3f79cd6281
Changed generation of status report to use rx_counts instead of
...
undeliverd_sdus_queue. Added a queue to store information about
rx_counts received.
Added unit test for when the SNs wrap-around in status report genaration
4 years ago
Francisco
3e9f93eb8a
refactor - remove old log_filter and logmap libraries from the codebase
4 years ago
faluco
173dcdd421
- Import latest srslog version.
...
- Remove string allocs in some log lines in radio.cc.
Add new tracing buffer capcity options into srsenb and srsue.
Add missing file.
4 years ago
faluco
c7542daf43
Remove rlc traces and add new ones into tti run functions both in the enb and ue.
4 years ago
faluco
82db6544fb
Add instrumentation points to rlc_am_lte::rlc_am_lte_tx::handle_control_pdu using srslog.
4 years ago
Andre Puschmann
16de8668e0
rlc_am_lte: convert mutexes to std::mutex
...
replace all pthread_mutex with std::mutex and use lock_guard and unique_lock (where needed)
4 years ago
Andre Puschmann
20cbc48f90
rlc_am_lte: refactor PDCP/RLC interface to use fix sized data structure
...
this patch replaces the std::vector type used in the interface between
PDCP and RLC to signal delivery status between both layers. The new
data type is a configurable but fixed-size vector.
The RLC AM doesn't need to dynamically allocate the vector for every SN but
uses the tx_window for storage.
4 years ago
Francisco
ee77343f26
fix compilation issue for centos7
4 years ago
Francisco
f72cd4151c
rlc am,bugfix - fixed formatting of RLC AM header and status pdu
4 years ago
Francisco
0f9d73012f
use srslte::move_callback instead of std::function in timers to avoid allocations
4 years ago
Francisco
5a1bf28fe1
optimization - minimization of number of std::string allocations for logging
4 years ago
Francisco
1ffc4cef86
rlc am,optimization - change helper log methods to avoid mallocs
4 years ago
Xavier Arteaga
a03c78a777
Fix NR-PUSCH defect
4 years ago
Xavier Arteaga
05f4d6af71
Fix and validated UCI multiplex in NR-PUSCH
4 years ago
Xavier Arteaga
2b9bd1173e
More NR-PUSCH UCI bit multiplexing
4 years ago
Xavier Arteaga
289fff9c22
Removed carrier set in UCI NR module
4 years ago
Xavier Arteaga
97435b085e
Added CSI part1 and 1/2 bit HARQ-ACK multiplexing on PUSCH
4 years ago
Xavier Arteaga
dc2542901a
Verified HARQ-ACK in PUSCH
4 years ago
Xavier Arteaga
9dffad87f2
Initial UCI bits multiplexing in PUSCH
4 years ago
Xavier Arteaga
f4e9d00ea8
Initial HARQ-ACK multiplex in PUSCH
4 years ago
Xavier Arteaga
7b588eafec
Minor aesthet change
4 years ago
Andre Puschmann
ace8764568
rlc_am_lte: add missing unlock when building status PDU fails
4 years ago
Francisco
f0ed1e06a8
documentation,bugfix - added documentation to new blocking queues, changed class names, and removed blocking pushes from the critical path
4 years ago
Francisco
d1236fd62f
stack,optimization - replaced previous block_queue design for new bounded queue in several places in the enb
4 years ago
Francisco
fb278a8b21
Fallback to default R8 TBS tables for format 1A DCI
...
Co-authored-by: xavierarteaga <xavier.arteaga@softwareradiosystems.com>
4 years ago
Andre Puschmann
ceacf8508d
rlc_am_lte: fix handling of maxretx
...
this patch fixes the actions/handling after RLC detected
maxRetx reached for a given SN.
According to the TS, RLC should only inform upper layers and
not try to recover from the event itself.
As a consequence, we won't manipulate the Tx or Rx window.
As a result of this, we might retransmit a SN more than
the specified amount of times.
It's the task of RRC to reestablish the bearer to recover
from that.
4 years ago
Francisco
fb04fdbe69
sched,bugfix - fix mcs/tbs computation for 256-QAM.
4 years ago
Andre Puschmann
6a4bf65fd8
rlc_am_lte: extend check for valid status PDU
...
check for all NACKed SNs are smaller than ACK_SN
4 years ago
Andre Puschmann
62b2327178
rlc_am_lte: fix header reconstruction
...
* optimize processing of status PDU (SN is removed from window immediately)
* fix maxRetx signaling for segments
* make tx_window_t a template class, rename and use for rx_window as well
4 years ago
Francisco
39aea96c69
fix sched tests UL HARQs. Set common pucch cfg in the sched tests
4 years ago
Andre Puschmann
99df71a914
rf_zmq: make error message when port bind failed more verbose
4 years ago
Francisco
9748c0be84
simplified tbs/mcs computation in scheduler
4 years ago
Pedro Alvarez
9c67a029b5
Trying to make calculation of offset in status report more readable
4 years ago
Pedro Alvarez
7b23a83306
Fixup tests to consider wrap-around in status report
4 years ago
Pedro Alvarez
c4e9516561
Fix issue when LMS wraps-around and FMS doesn't in PDCP status report. Fix incorrect update of FMS on clear_sdu. Adding unit test to LMS wrap-around.
4 years ago
Pedro Alvarez
0d020a7f07
Disable sending and handling status report on SRBs
4 years ago
Xavier Arteaga
81cc8de2b7
Protect NAS unbounded message read
4 years ago
David Rupprecht
aef6805d03
Added pcap net feature to eNodeB
4 years ago
David Rupprecht
9e72d89fa1
MAC PCAP move run thread in base class
4 years ago
David Rupprecht
894e4d3501
Added mac pcap network class that dumps the packets to a udp network sink
4 years ago
David Rupprecht
a58f0642cb
created pcap base class for main handling
4 years ago
David Rupprecht
da658ed2d4
Changable UE ID for enodeb
4 years ago
David Rupprecht
5a95cbdfae
Disable rat assignment in pcap class
4 years ago