2131 Commits (2f8643fb9757c3f12bb69f60d42e32a7d7a895fa)

Author SHA1 Message Date
Francisco Paisana 57cd40ca31 added an ho required message send from SeNB to MME 5 years ago
Francisco Paisana 690a9850e7 cleaned up some old patterns and run clang-format in RRC and scheduler 5 years ago
Xavier Arteaga 2e1479e9d6 SRSENB: Added PHY CA PRACH workers 5 years ago
Andre Puschmann 2d126371f6 adopt PDCP NR to use new timer class 5 years ago
Pedro Alvarez ac9ee9d863 Added comment. 5 years ago
Pedro Alvarez ea0a413c8a Added check on wether the PDCP entity is initialized. 5 years ago
Pedro Alvarez 9998b3e857 Small white space fix and clang-format on pdcp_nr_test.h 5 years ago
Pedro Alvarez cede56abe1 Fix small typo 5 years ago
Pedro Alvarez 900d535baa Added test for reception of duplicated packets 5 years ago
Pedro Alvarez 347e10d967 Adding test for reception of duplicate packets. 5 years ago
Pedro Alvarez 3614c1004e Fixed issue in test with out-of-order packets. 5 years ago
Pedro Alvarez 7542e5a936 Continue to change PDCP test to support timeouts. 5 years ago
Pedro Alvarez 6265325e20 Starting to change test to also run the clock. 5 years ago
Pedro Alvarez 8511fca940 Clang-formated to prepare for PR 5 years ago
Pedro Alvarez d3a07fdd38 Added check for overflow at RX. Adding more tests. 5 years ago
Pedro Alvarez eb1470621a Added function to generate vector of PDUs 5 years ago
Pedro Alvarez ed24544a63 Added debug print for out of order, wraparound and duplicate RX PDUs. Adding a helper function to help generate a vector of test PDUs 5 years ago
Pedro Alvarez a191eb6606 Fixed up some PDCP tx tests. 5 years ago
Pedro Alvarez 2752e3cff5 Starting to stop tx'ing packets if TX_NEXT overflows. 5 years ago
Pedro Alvarez 62230c6ab9 Starting to have overflow protection in PDCP NR tx 5 years ago
Pedro Alvarez f872c1b55a Added test for PDCP COUNT wraparound. (Needs to be changed, COUNT wraparound is not allowed.) 5 years ago
Pedro Alvarez f29dd3c5de Added test for reordering at COUNT wraparound. Failing at the moment (as expected). 5 years ago
Pedro Alvarez 1d56fa6308 Improved speed of tests for COUNT wraparound, by setting the PDCP initial state. 5 years ago
Pedro Alvarez ffc26a702d Changed the name of more PDUs 5 years ago
Pedro Alvarez cb0466bce7 Starting to change the expected pdus name. 5 years ago
Pedro Alvarez 49e0e3a24a Added helper function to generate expected PDUs 5 years ago
Pedro Alvarez 39943367ab Starting to add the ability to tweak the initial state of the PDCP NR state, so that the tests of counter wraparound don't take hours. 5 years ago
Pedro Alvarez 517ce8a220 Added test to test out of order COUNT wraparoung. Added setters to help with the testers. 5 years ago
Pedro Alvarez 727436ec0b Added helper function to compare two packets. Making generic function to test out of order packets. 5 years ago
Pedro Alvarez 43c68fe78b Sarting to add test for out of order wrap-around. 5 years ago
Pedro Alvarez ceea761ca4 Added append_bytes method to byte_buffer_t class. Continue to reduce boilerplate. 5 years ago
Pedro Alvarez 59bc2baf3f Continue to reduce boiler plate 5 years ago
Pedro Alvarez df7a020e5f removing some boiler plate 5 years ago
Pedro Alvarez 977238a79c Added pdcp_nr_test.h to reduce boiler code in the pdcp_nr_test.cc 5 years ago
Pedro Alvarez 837ca9e07e Changed name of helper class 5 years ago
Pedro Alvarez be090768c9 Making helper class to reduce boilerplate in PDCP NR tests. 5 years ago
Pedro Alvarez b7fdcaabc5 Starting to add reordering timers at PDCP NR entity. Timeout seems to be triggered correctly and pass the SDUs to the upper layers when it expires. First tests passing. 5 years ago
Pedro Alvarez b92c99ad2f Removing PDCP config from rrc_interfaces_types. Starting to add t_reordering configuration. 5 years ago
Pedro Alvarez 45d298507b Starting to move pdcp configs to rrc_interface_types. Starting to add test for reorder timeout. 5 years ago
Pedro Alvarez 6cf2bd7bc3 Starting to add reordering queue in the PDCP. 5 years ago
Pedro Alvarez f06e1af4e0 Added test for receiving out of order NR PDCP packets 5 years ago
Pedro Alvarez ff15ed5018 Starting to add timers to the NR PDCP. 5 years ago
Justin Tallon 4a1b8a5952 adding support for neon soft demodulation, adding cmake checks for aarch64
* adding support for neon soft demodulation, adding cmake checks for aarch64
* rearranging some arm cmake flags
5 years ago
Francisco Paisana 35c9f02579 added quant cfg parsing and addition to measCfg 5 years ago
Francisco Paisana 427fdb83fe using std::make_tuple now to support old compilers. Move operator== definitions for meascfg types to rrc_asn1_types 5 years ago
Francisco Paisana 200e18ee3a added diff computation for reportconfig and measid. Tests passing 5 years ago
Francisco Paisana 1524e28c3a finished the function to compute diffs between cells/measObjs of two var_meas_cfg objects. Added tests for this. Now the update of a UE's var_meas_cfg is made via a shared pointer. 5 years ago
Francisco Paisana b7559171b7 added logic to insert cells from conf file into var_meas_cfg and calculate diffs between meas_objs 5 years ago
Andre Puschmann f4a0bebe1f fix handling of invalid MAC LCIDs 5 years ago
Andre Puschmann aa9733eb59 add packing for CCCH over UL-SCH for MAC NR 5 years ago
Ismael Gomez 575499c95b Fix HO when doing ping due to reseting of the PDCP counters in reestablishment. Fixes #618 5 years ago
Francisco Paisana 7e62d6d1f9 added parser for rrc_cnfg section of rr.conf file, and dummy rrc_mobility class 5 years ago
Andre Puschmann 2ec62f7fa9 fixing weird gcc9 bug with strncpy
see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88780 for details
5 years ago
Andre Puschmann 1d6f72b478 soapy: fixing various soapy bugs detected with asan
- use nof_rx_channels to set rx pointers
- use returned value to set bw
- fix heap use after free
5 years ago
Francisco Paisana 8440126d35 removal of srslte::timers class 5 years ago
Francisco Paisana 9ae5563331 fixed timer issue with setting the duration. Setting the duration cannot reset the on-going timer run 5 years ago
Francisco Paisana d2c56caf7e applied new timer class to the whole code base 5 years ago
Francisco Paisana 5953d5ef96 fixed some potential bug related to timer getting stopped, but signaling that it expired 5 years ago
Francisco Paisana 551192705e allow for pre-reservation of timers vector and priority queue 5 years ago
Francisco Paisana 50a1c9d557 addressed potential overflow, and extended timer test to check if ordering is working correctly 5 years ago
Francisco Paisana 349646a9da created a new class for timers. It uses a priority queue to avoid incrementing all timers every tti (step_all() went from O(N) to O(1)), and that is not bounded in number of timers. Not being bounded will be useful for layers that require one or more timers per UE 5 years ago
Francisco Paisana 15bde8660a getting a future of an already finished proc is dangerous 5 years ago
Francisco Paisana 248583ecdf added extra logging and removed uneeded member from proc_t 5 years ago
Francisco Paisana b254bdbb93 typedefed the proc_result_t<void> to become proc_state_t 5 years ago
Francisco Paisana f2d88e5a5b simplified NAS rrc connection request procedure
move non-type-specific methods of proc_t to its base class.
procedure state machine was simplified via a future-type. Now procedures dont get stuck until the user reads the procedure outcome.
made the NAS procedures more event trigger/reaction-based.
5 years ago
Francisco Paisana 8864787f59 added the continuation functionality to procedures via the "then()" method. 5 years ago
Francisco Paisana c1be118d1d new wrapper-based design for stack procedures. Removes extra base class, gets rid of spurious copies/moves during the pop(), and allows the use of a non-default ctor() 5 years ago
Ismael Gomez 3828e03f33
Refactor in eNodeB, add channel emulator and fixes in OFDM
* Added channel emulator to srsENB. Added support for fixed delay

* Bug in OFDM when using nonguru mode

* A few changes and refactor in eNodeB
5 years ago
Xavier Arteaga 73517f981e Minor fixes 5 years ago
Xavier Arteaga 423475173d Refactored magnitude and argument extraction from sf_worker 5 years ago
Xavier Arteaga 10480f62b3 SRSENB: Split sf_worker and cc_worker 5 years ago
Andre Puschmann d5835fc8a0 add info_long() method to log filter 5 years ago
Andre Puschmann 891a66a2e5 make the establishment cause a paramter when sending a connection request
needed to signal a mo_sig establishment cause after a RLF
5 years ago
Xavier Arteaga 4227da9bd0 Fixed DCI Format1B length 5 years ago
Xavier Arteaga 73cf593891 SRSENB: Fixed PUCCH resource selection 5 years ago
Andre Puschmann 2d730389fe fix type mismatch in bzero 5 years ago
Andre Puschmann 626259eede add helper method to obtain thread name
this is helpful to, for example, print the name of
the thread that calls a function, i.e.:

log.console("%s from %s\n", __PRETTY_FUNCTION__, thread::get_name().c_str());
5 years ago
Pedro Alvarez fd01c44d4e Fix compilation error on GCC 8.x due to usage of strncpy in zmq_imp_rx/tx.
Fixed also order in which zmq object is zero'ed out.
5 years ago
Xavier Arteaga ba6a68825c UE DL: Extended ack test for FDD 5 years ago
Xavier Arteaga 0b00e6d94a SRSUE: fixed CSI and HARQ collision for CA 5 years ago
Ismael Gomez 1d83bb08e2 Changes in ACK procedure to support CA. Tested 1 cell in SISO/MIMO 5 years ago
Andre Puschmann d8fedf2e19 fix parsing of corrupted MAC PDUs 5 years ago
Andre Puschmann 89889d6df5 add packing and unpacking test for MAC PDU only containing padding bytes 5 years ago
Andre Puschmann 80afe5ca40 rlc_um: add missing lock in get_buffer_state() 5 years ago
Andre Puschmann c5f52adfba nas: fix issue in which NAS wouldn't allow to attach once it failed
the main issue was the plmn_selected variable. the solution
was to create a function to enter the deregistered state that resets the variable
and performs all other actions that need to be performed, like clearing
EPS bearers.

The patch also extends the SS to support AT commands to enable/disable
data services and now succesfully passes TC_9_2_2_1_7
5 years ago
Francisco Paisana 2fb830fcfa moved cell search to background task thread pool, and provided a stack interface to rrc to call "start_cell_search". Once completed, the background task signals back to RRC 5 years ago
Andre Puschmann f07a9277a0 fix RLC AM issue where an invalid status PDU was generated
happens when very small grant is provided and the status
PDU generation fails because of a too small grant

add extra check to prevent that ACK_SN is also in NACKS list
5 years ago
Francisco Paisana a2f1998350 fix issue with thread pool shut down 5 years ago
Francisco Paisana 3f1fad3f4e bug fix: avoid renaming thread in worker ctor 5 years ago
Andre Puschmann c7f0caa24a add TTI field to MAC dl/ul grants and fix PCAP to include TTI 5 years ago
Andre Puschmann d73965e887 fix tear-down of worker 5 years ago
Francisco Paisana 6db0e474be moved RA waiting procedure to a background task of the stack thread pool 5 years ago
Francisco Paisana c413fadea9 created a queue-based thread pool. Tasks are inserted into a queue and then popped by the thread pool workers to be processed. 5 years ago
Xavier Arteaga 665f899a74 Fixed some coverity and Clang tidy warnings 5 years ago
Andre Puschmann 50999d8116 allow integrity protection for identity response 5 years ago
Andre Puschmann 3e4bbbda5c fix PSS threshold value in cell_search 5 years ago
Andre Puschmann 2deaab8ded fix synch_file example to work with sample rates other than 1.92 5 years ago
Francisco Paisana e92632e729 zero-initialized mbms rrc interface types 5 years ago
Francisco Paisana fc9bb3c934 removed rrc asn1 header include from the ue_interfaces and phy 5 years ago
Ismael Gomez 4b5353e87a BladeRF: tx gain range was incorrectly obtained from rx module 5 years ago
Ismael Gomez 9325aaddf2 Do not change master clock rate if not necessary. Hint in ue/enb configs for low BW cells 5 years ago
Ismael Gomez 5689d6513d Fix not checking for explicit value 5 years ago
Andre Puschmann 2f47010eb6 fix various uninitialized vars 5 years ago
David Rupprecht f9a668861a Fixed USRP capture sync due to missing channel ptr 5 years ago
Andre Puschmann b0fd588a23 fixing zmq includes 5 years ago
Xavier Arteaga 191e8d6520 ZMQ: Fixed for more stability 5 years ago
Xavier Arteaga 125f1e7282 ZMQ: Split Tx and Rx, bug fixes and clean up 5 years ago
Ismael Gomez cf550f6e56 Fix incorrect pointer passing in rf_uhd 5 years ago
Andre Puschmann c99d5077c8 add RLC UM NR transmitter 5 years ago
Xavier Arteaga 11109460e6 Fix continuous_tx parsing 5 years ago
Xavier Arteaga f8dcb8bf67 CRS SCell searcher: Minimal simplification 5 years ago
Xavier Arteaga 9ee8cc0ad2 CRS SCell searcher: Fixed memory leaks 5 years ago
Xavier Arteaga 9ea9aab39d Added High Speed Train model to channel emulator 5 years ago
Xavier Arteaga 6eb26be34e Fixed include headers 5 years ago
Xavier Arteaga 35f85c651c SRSUE: Added SCell synchronizer and measurements based on reference signals 5 years ago
Xavier Arteaga 8e17aba5d8 Improved SSS decoding and improved scell_search_test 5 years ago
Xavier Arteaga dedf0f2f78 Added initial time to delay channel simulator 5 years ago
Xavier Arteaga 368690ea6b SRSUE: Added intra frequency SCell search test 5 years ago
Xavier Arteaga d7c1a0bda9 Added High Speed Train model to channel emulator 5 years ago
Xavier Arteaga 78fcc11a30 Fixes minor unitialised/leaked memory 5 years ago
Xavier Arteaga 703bbb44a3 Removed master clock rate for soapy. Tested with LimeSDR. 5 years ago
Xavier Arteaga 531ea2d0cd Cleaned up unused RF functions. Integrated Soapy Master Clock Rate in set srate. 5 years ago
Xavier Arteaga db5a21e659 Remove set_master_clock_rate from PHY RF API 5 years ago
Xavier Arteaga 9984e14170 BladeRF: Solved all clang tidy warnings 5 years ago
Ismael Gomez 0984debe1b
Fix issues with RLF in B210 and X300 (#669)
* Calling tx_end() from radio_reset() causes long execution time in B210. Using boolean to call later instead. Fixes RLF failing in B210. Checked in X300

* Fix issue #655
5 years ago
Andre Puschmann a2ab043c0d fix memleaks and uninitialized vars found by cppcheck 5 years ago
Francisco Paisana 946ead06e8 using an interface between the stack and lower mac to process demux pdus. 5 years ago
Andre Puschmann 57317fab7c expose debug_long to class log and use in RRC to log ASN1 structs 5 years ago
Andre Puschmann 7ad2b217df fix logging all in error level 5 years ago
Francisco Paisana 7e67aee839 resolved the uninit variable issue in the queue_test 5 years ago
Francisco Paisana 14267640ee implemented andre's PR review requests 5 years ago
Francisco Paisana b2bc05c50a make queue_test less dependent on thread timings 5 years ago
Francisco Paisana ceba00f00e extended multiqueue to support blocking push 5 years ago
Francisco Paisana 63457f195c extented queue test 5 years ago
Francisco Paisana 647c624423 created a multiqueue handler, and started using it for the ue stack 5 years ago
Andre Puschmann 95b2239dd5 add base class for socket handler using netsource object 5 years ago
Andre Puschmann 6baa89cd2c add MAC NR PDU packing and associated unit tests 5 years ago
Andre Puschmann 090f2b4110 add MAC-NR PCAP support 5 years ago
Ismael Gomez a3932f9bea Minor change to fix coverty issue 5 years ago
Francisco Paisana 94667beb00 added a bound checker to bit_ref packer, and other fixes 5 years ago
Ismael Gomez f74efe908b
Fix blocking in resume() after RLF in 100 PRB (#654) 5 years ago
Francisco Paisana cd521a84cb bigger log buffer. Now it is 1024 chars (#649)
Use dynamic string for debug_long() function and known relation of size between log_str and log_filter
5 years ago
Andre Puschmann 5189bbad69 add stop() to logger_file
this allows to close and currently running log process, flush the content
to the file, continue logging during that time, open a new file
and write the new log entries to that new file

basically it allows to use the logger_file multiple times without
needing to destroy the object

this is used in the UE tester to write each testcase into a separate
log file
5 years ago
Andre Puschmann 4869509c7b add write function to netsource
this is useful for listening sockets to also send responses,
i.e. implement bi-directional communication
5 years ago
Francisco Paisana e768989074 added a packer/unpacker for bytes. This should a faster version than normal bit_ref::pack, when we want to pack multiple bytes, and the bit_ref::offset is 0. Also added a way to skip a fixed number of bits 5 years ago
Ismael Gomez 6bb0790cf1
Fix coverty issues (#652) 5 years ago
Xavier Arteaga 1a567a764e SRSUE: Call Radio tx-end when PHY is reseted and removed redundant attribute is_start_of_burst. 5 years ago
Andre Puschmann 4ea9ed058c fix reporting of Tx gain stages in rf_soapy
reported by DreamNik
5 years ago
Pedro Alvarez 1d3e541069 Fixed warning on bytes_to_mnc 5 years ago
Pedro Alvarez 9b20a0de16 Added comment to zuc.cc and zuc.h 5 years ago
Pedro Alvarez 004db4a067 Applied clang-format to zuc_support PR. 5 years ago
Pedro Alvarez 595185d4b5 Fixed small compiler warning. 5 years ago
David Rupprecht 50332089ce Add EEA3 and EIA3 support for UE/enodeb and MME 5 years ago
David Rupprecht f05bb12c78 Process with EIA3 test cases and fix EIA3 5 years ago
David Rupprecht d580a94dab Add EIA3 and test case 5 years ago
David Rupprecht 7e13860dd5 Add decryption function and all tests for enc 5 years ago
David Rupprecht 0841d837de Make ZUC state ful no global vars 5 years ago
David Rupprecht ef4cf7aa52 First ZUC working test case 5 years ago
Andre Puschmann 8da610d68b fix gcc (<= 5) warning with type-limits by casting vr_r to a signed type
this warning is a bit annoying as it is really safe to do
that kind of comparision, it's just that for vr_r==0, any other
unsigned number is >= 0.
5 years ago
Andre Puschmann 49279c89d8 send DL-DCCH on SRB2 after it has been established 5 years ago
Harald Welte 2e426948fe [ENB] Add CFSB support
This commit introduces CSFB (circuit switched fall-back) capabilities to
srsLTE.  Actually, all the eNB has to do is to send a
RrcConnectionRelease with the RedirectedCarrierInfo IE.

The MME triggers this by the S1AP CS Fallback Indicator IE, which may
be present either in the Initial Context Setup Requst or in the
UE Context Modification Request.

As srsLTE has no support for the UE Context Modification Request at all
yet (!), basic support for this message is introduced in this patch.

Both Mobile Originated and Mobile Terminated CSFB with a coupel of
different UE models have been verified using this patch in a setup
consisting of srsENB attached to an undisclosed EPC connected via SGsAP
to a complete  Osmocom 2G network.

Closes: #358
Closes: #363
5 years ago
Andre Puschmann d9577f0e1e suppress type-limit warning issued by some compilers by making var signed
Used to happen with older gcc giving:

"rlc_am.cc:1791:22: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]"
5 years ago
Andre Puschmann a9bea7e30c add -Werror to compile flags 5 years ago
Ismael Gomez bfddc55148
RRC-PHY interface (#639)
RRC-PHY interface refactor. Moved RRC-MAC interface to rrc_asn1_utils and created RRC-PHY interface also in rrc_asn1_utils. All ASN1 includes should be made from rrc_asn1_utils only keeping ue_interfaces clean of ASN1

Tested with different common and dedicated configurations (64QAM UL, 256QAM, CA, SRS enabled/disabled, etc)
5 years ago
Merlin Chlosta 2079c1324c UHD: Wait for `lo_locked` after frequency change (#635)
* UHD: clang-tidy rf_uhd_imp.c
* UHD: wait for LO_lock after frequency change
5 years ago
Ismael Gomez c92c61d560
Optimized front-end logging processing (#641)
Avoid memory allocation and stringstream in log frontend calls (executed from worker threads). Uses a buffer pool of fixed buffer and vsnprintf
5 years ago
Francisco Paisana 67d6a25194 Moving mac timers to stack timers (#638)
* first step towards moving MAC timers to stack. Mac is still using its own timers. srslte::timers class can be restructured.

* moved timers out of the UE MAC
5 years ago
Ismael Gomez 69edee4e6c
Fix issues in uplink QoS (#636)
Fix bugs in Long BSR and Truncated BSR and added unit tests
5 years ago
Francisco Paisana ef61f0408c fix asn1 version separator string 5 years ago
Francisco Paisana ad64207a32 added test for unknown group extensions, and the asn1 lib version in its generated files 5 years ago
Francisco Paisana 939c8905cb now the unknown group exts are also consumed 5 years ago
Francisco Paisana 116dc0a57b fixed group extensions, removed extra presence flag for copy_ptr<T> types as it was just a source of bugs. 5 years ago
Robert Falkenberg bf35f83a5e Fixed inverted interpretation of new data indication (ndi) field in dci_format1As_pack() function 5 years ago
Robert Falkenberg c75f314c3f Fixed incorrect DCI location assignment in pdsch_enodeb.c example 5 years ago
Mark Rohrbacher 4a76801459 Fixed duplex spacing for bands 65 to 70 5 years ago
Robert Falkenberg 3cf4431c66 Fixed inverted handling of fseek result value in srslte_filesource_seek 5 years ago
Igor Kim dd613c1514 Fix TBS table with auto-generated one (#368) 5 years ago
Andre Puschmann ada4e6644f fixing various issues in NB-IoT sync code detected by Coverity and clang-tidy 5 years ago
Francisco Paisana c9d3b61038 added resumable procedures to make RRC and NAS non-blocking 5 years ago
Andre Puschmann e42449532b fix wrong namespace definition in various places 5 years ago
Andre Puschmann deb3cbec28 soapy: start rx stream without extra flags and print error if not successful 5 years ago
Andre Puschmann 80655db4a4 fix missing include in filesink 5 years ago
Andre Puschmann 95a5c2dcdb adding NB-IoT sync code 5 years ago
Ismael Gomez d887624e74 Increased PSS threshold to detect RLF after change to number of missed subframes 5 years ago
Ismael Gomez 19066c49ab Ad Rel10 info to dci logs 5 years ago
Pedro Alvarez 6efa944b5e Removed srslte prefix from pdcp_config_t 5 years ago
Pedro Alvarez 0e7c5634f1 Added comment to PDCP maximum SDU size. 5 years ago
Pedro Alvarez dd56d08269 Replaced byte_buffer by array in PDCP base 5 years ago
Pedro Alvarez 8c10eabf23 Changed PDCP LTE to use unique_lock. 5 years ago
Pedro Alvarez 3da0391fff Adding default initializers to PDCP config. 5 years ago
Pedro Alvarez 494be243c0 Changed security direction to use an enum. 5 years ago
Pedro Alvarez 61051b4cb3 Changed PDCP NR read_data_header to return SN. 5 years ago
Pedro Alvarez f90b69e5f4 More clang-format for PDCP 5 years ago
Pedro Alvarez 491695ab77 Clang-formated PDCP NR PR. 5 years ago
Pedro Alvarez 38bbc55631 Added tests for PDCP NR Rx with SN Len = 18. In-sequence reception seems to work. 5 years ago
Pedro Alvarez d4aeb12db8 Adding more TX tests to PDCP NR entity. 5 years ago
Pedro Alvarez 39e3800781 Fixed header packing for SN length 18 for PDCP NR. First TX test is passing. 5 years ago
Pedro Alvarez d399c65082 Starting to add PDCP SN len 18 unit tests. 5 years ago
Pedro Alvarez 7a69e8ba64 Removed comment. 5 years ago
Pedro Alvarez adfe9f950e Fixed issue in computing the SN. Added test for packets received in sequence for PDCP NR. Test is passing now. 5 years ago
Pedro Alvarez 2104e6bbcf Added test for more TX packets in PDCP NR. Tests passing for TX_NEXT = 0, 2048 and 4096 5 years ago
Pedro Alvarez ecd164ed65 Starting to add more tx tests to PDCP NR tests. 5 years ago
Pedro Alvarez af2b593b8c Added check for integrity in test. First Rx PDCP NR test passing. 5 years ago
Pedro Alvarez d3b6828082 Changed PDCP configuration to explicitly have tx and rx direction. Decrypt on PDCP NR seems fine. 5 years ago
Pedro Alvarez ea3c44e9ac Removing header before decrypting. Continuing to add decryption tests to PDCP NR 5 years ago
Pedro Alvarez 7e6725f0a2 Fixing up PDCP NR tx test. Starting to add rx test. 5 years ago
Pedro Alvarez 378c8d247e Starting to add the mechanisms to store the last PDU in the PDCP tests. 5 years ago
Pedro Alvarez a42726f836 Fixed hdr_len_bytes in PDCP NR. Tx seems OK now. 5 years ago
Pedro Alvarez 73e30743d1 Added enum to PDCP config to replace two bools. 5 years ago
Pedro Alvarez 457f35699d Reverted back to a single config structure between PDCP NR and PDCP LTE. 5 years ago
Pedro Alvarez 810cacdc02 Adding write_data_header and append_mac helper functions to PDCP NR entity. 5 years ago
Pedro Alvarez 9d0db108c6 Continue to add PDCP tx test 5 years ago
Pedro Alvarez d1ac121100 Writting PDU into PDCP in tx test. 5 years ago
Pedro Alvarez c9e99443d8 Adding PDCP NR Tx test. 5 years ago
Pedro Alvarez 4bb99464ed Starting to add PDCP NR tests. 5 years ago
Pedro Alvarez 8e8a7a4154 Add more logic to PDCP NR tx logic. 5 years ago
Pedro Alvarez 2081b22465 Added PDCP_SN_LEN constants. Added bearer_id and direction back to the pdcp_entity_base. 5 years ago
Pedro Alvarez 8e1b9b9f5b Starting to implement the receive function of PDCP NR. 5 years ago
Pedro Alvarez d7a2721bb0 Adding algorithm to get COUNT for PDCP NR. Added convinience functions to manipulate HFN, SN and COUNT. 5 years ago
Pedro Alvarez 52f75c3cf2 Starting to add PDCP NR state variables. 5 years ago
Pedro Alvarez 2449f901f0 Fixed error in setting Kint in pdcp_entity_lte. 5 years ago
Pedro Alvarez 1944bf9a80 Continue to split pdcp_entity_lte and pdcp_entity_nr. Compiling now. 5 years ago
Pedro Alvarez bd91678d98 Continuing to split pdcp_entity into pdcp_entity_lte and pdcp_entity_nr 5 years ago
Pedro Alvarez 005d03cb1a Starting to split pdcp_entity into pdcp_entity_lte and pdcp_entity_nr to support NR PDCP 5 years ago
Ismael Gomez 069c55f2e5 Fix db to dbm typo 5 years ago
Ismael Gomez 2859a75ca0 Reset counter for sync lost when PSS is found 5 years ago
Ismael Gomez d32739c315 Minor logging changes in PHY 6 years ago
Andre Puschmann e0bd7f156d replace remaining warning macros with pragma message 6 years ago
Andre Puschmann 09610ce788 add type setter to sch_subh and use it for MCH PDUs 6 years ago
Andre Puschmann c4bc151e14 rlc: fix MRB logging 6 years ago
Andre Puschmann e562dfed15 minor code formating and debug fixes 6 years ago
yagoda 408400bee6 adding fixes and tests for eMBMS 6 years ago
Francisco Paisana 424876c5e4 added DL TTI mask for MBMS 6 years ago
yagoda b99178d8da updating timing advance values for lime 6 years ago
Ismael Gomez 50e1ed6cc6 Change order of radio stop to avoid locking on rf_ms() by async thread 6 years ago
Guillem Foreman 2574de4d2d Fixed soft demodulator 6 years ago
Ismael Gomez 126f2efb5c
Radio and UHD fixes to avoid changing master clock rate and fixes X300 (#589)
* Fixes X300 MIMO

* Do not change sampling rate and calibrate time_adv_nsamples for b210
6 years ago
Andre Puschmann 9ee415ac82 correct the max size for a single TB
since the size in bits is counted per TB we don't need to allocate
space for the 2x2 MIMO case. Both CW have their own buffer.
6 years ago
Andre Puschmann 21f8698397 fix MAC PDU packing for large TB sizes
update the byte_buffer length variable after updating the remaining
PDU length. This has caused an error when calculating the
remaing space in the PDU because the SDU length was counted twice.
6 years ago
Andre Puschmann 94cc61e4b1 add MAC PDU pack test for max size TB PDU 6 years ago
Ismael Gomez c9c43e44e9 Fixed PDU buffer size 6 years ago
Andre Puschmann 2ae35e4ce0 make sure status PDU doens't exceed grant size 6 years ago
Pedro Alvarez 9597cc4c14 Clang-formated liblte_* 6 years ago
Xavier Arteaga 5e49aca835
Merge pull request #570 from softwareradiosystems/feature_256qam_fix
Resource allocation extended tables and PDSCH table 2 for 256QAM
6 years ago
Ismael Gomez 6d2c6ec58d Do not change master clock rate in UHD if dynamic rate is supported 6 years ago
Guillem Foreman 2a8ec5c9b9 More fixes 256QAM 6 years ago
Guillem Foreman eab73829f6 Changes requested 6 years ago
Ismael Gomez 538f38cf54 Let PDCP Control PDUs be processed 6 years ago
Pedro Alvarez 9b6aaac1b5 Ignore PDCP status PDUs, instead of passing them to the GW. Check on the GW if the packet is large enough to hold an IPv4 header. 6 years ago
Ismael Gomez 11d42acb3a Fix using deallocated PDU 6 years ago
Ismael Gomez 8c41625599 Add RLC suspend and resume 6 years ago
Andre Puschmann db196cc052 add RLC AM test for status PDU generation with small and big MAC grants 6 years ago
Andre Puschmann db9f093b63 add debug log when handling reordering timer 6 years ago
Andre Puschmann 849ad2655c fix creation of malformed RLC AM status PDU
the issue was caused by an unneeded length check during the
assembly of the status PDU. This length check caused an too early
break from the while-loop that adds all missing SNs to the status PDU
leaving the PDU struct in an invalid state where ack_sn was equal to
one of the NACK_SNs.
The fix is to simply remove the length check during the generation to
fully generate the status PDU. If, for whatever reason, MAC provides
a too small grant to fully fit the status PDU, the PDU will not be
generated, i.e. the calling function checks the return value and does
not pass the (then too big PDU) down the stack.
6 years ago
Andre Puschmann 9f3a947c02 modify RLC AM retx test to provide exactly a MAC opportunity of the size
that is reported as buffer state
6 years ago
Xavier Arteaga aa6652155c Phy: added ue_ul normalization mode parameter 6 years ago
Xavier Arteaga 20823e191d SRSUE: Added UL force amplitude optional parameter 6 years ago
Andre Puschmann 4e86b2f6b2 introduce layerd architecture we use for UE to eNB
- this allows flexible use of different PHYs and radios
- use common radio_multi (moved to lib)
6 years ago
Xavier Arteaga 2530894374 Channel emulator: added input pointer checks 6 years ago
Ismael Gomez d595c4d882 Fixes issue #545 and unlocking of tti_sync condvar before closing causing deadlock at stop 6 years ago
Andre Puschmann aff26abc89 fix memleak in Soapy driver when no device was found 6 years ago
Ismael Gomez 773c2a9721 Fixed multiple issues in Random Access procedure and extended MAC test 6 years ago
Andre Puschmann 6b2961fcee add MAC DL-SCH unpacking test 6 years ago
Andre Puschmann 92f0d58856 mac: move further init/config into ctor to allow early logging, etc. 6 years ago
Francisco Paisana 92b4b168fe added default rlc um and am in the interface as factories 6 years ago
Francisco Paisana b903c1a52c made default init for rlc um test 6 years ago
Francisco Paisana 58e2e51044 removed rlc_interfaces. The rlc_cnfg types are now part of the rrc_interface_types. Removed implicit RB initialization in the RLC. 6 years ago
Francisco Paisana c5509caece added extra operators and remove rrc_asn1 in some cmake targets 6 years ago
Francisco Paisana b936629221 removed rrc asn1 header from bcd_helpers, from rlc_interface, and rlc tests 6 years ago
Francisco Paisana bb0dbf0f1c created a asn1 utils with helper functions and types related to the asn1. These types/functions will help isolate the rrc_asn1 lib from most of the layers, reducing this way the compile times, and leading to better isolation. This will also make the transition to NR smoother. I removed the asn1 types from the NAS and USIM interface so far. 6 years ago
Francisco Paisana 416f9896ec fixes to include the findings from PR #550 6 years ago
Guillem Foreman 46724c336d Fixed errors for phy_dl_test and pdsch test 6 years ago
Guillem Foreman 4627737c87 Revert "Disable 256QAM tests failing in CentOS"
This reverts commit 833ce5224a.
6 years ago
Guillem Foreman c71763dc93 Fixed minor message in modem test 6 years ago
Guillem Foreman db4127ca64 Fixes 256QAM, added pdsch table 2, fixed warnings 6 years ago
Guillem Foreman 535325bc37 srsLTE: added resource allocation extended tables for 256QAM and integration with PDSCH test 6 years ago
Andre Puschmann 62a4fa1c93 fix various potential buffer overruns
this is based on suggested fixes by Dirk Grabinski and David who
have fuzzed various parts of srsLTE using afl
6 years ago
Andre Puschmann 701db61fde rlc: extend stress tester to simulate MAC PDU corruption 6 years ago
Andre Puschmann ecb6a0f99b fixing RLC AM bug where corrupted PDU causes segfault
the underlaying issue is that a corrupted PDU is passed to RLC
which claims to have segments whose total size exceed the size
of the entire PDU. Those PDUs are not ignored.
6 years ago
Xavier Arteaga a417d3a70a Added DCI trace if cqi is requested 6 years ago
Xavier Arteaga 87433c83da SRSUE: 64QAM R8 compatible 6 years ago
Ismael Gomez 833ce5224a Disable 256QAM tests failing in CentOS 6 years ago
Pedro Alvarez 498f1b8e4b Small PDCP fixes:
- Moved most the initialization of the pdcp_entity to the header.
  - Initilize some variables in gtpu_ntoa.
  - Removed debug print.
  - Format eNB GTP-u debugging code.
6 years ago
Pedro Alvarez 1c51d2ca9a Small clang format changes. 6 years ago
Pedro Alvarez 5d8dcbe4cb Make sure that PDCP SN is initialized properly in the eNB. UE attaches again when using encription. 6 years ago
Pedro Alvarez 53d2220aab Resolved conflicts with unique pointers after rebase in PDCP entity. 6 years ago
Pedro Alvarez 2643b9070f Fixing mistake in setting PDCP last_submitted_pdcp_rx_sn 6 years ago
Pedro Alvarez 6d5dbdedfa Fixed mistake in comparison in pdcp_entity. 6 years ago
Pedro Alvarez 693338da07 Added TX HFN print to make it easier to debug HFN mis-match 6 years ago
Pedro Alvarez 6b59cc0760 Debug print for PDCP Reestablish. 6 years ago
Pedro Alvarez 5ca6238877 Adding encription debug prints. 6 years ago
Pedro Alvarez b97d1191f4 Added more debug info at eNB GTP-U. Changed the pdcp_entity to follow the standard more strictly for RLC AM DRBs. 6 years ago
Pedro Alvarez f4fd6034ba Starting to add separate functions for PDCP handling for UM DRBs and AM DRBs 6 years ago
Pedro Alvarez 6578cf1d01 Making sure that next_pdcp_rx_sn is reset at reestablish. 6 years ago
Pedro Alvarez 6cbcc5154d Starting to use received SN to do user plane decription. 6 years ago
Andre Puschmann 58763fb714 stack: move initialization of log object into ctor
this fixes the issue when the stack is torn down if, for example,
the radio couldn't be loaded correctly. it will hence call stop() on all stack
components which are not initialzized yet, and logging therefore doesn't work.
the log object is know during contruction time and therefore can be passed
in as soon as possible.
6 years ago
Pedro Alvarez 8f5ad55c4a Added attach request as a UL info trasnfer in the UE. Added interface to remove eps bearer map when going idle. Fixed bug in GW in assignment of IPv4 addresses. UE seems to rebound from the service reject now. 6 years ago
Andre Puschmann 82a69fb51c mux: fix packing of short MAC PDUs 6 years ago
Andre Puschmann 0012868e91 rlc_am: reduce log level when provided PDU size is too small 6 years ago
Andre Puschmann 4aaa0473b9 pdu: remove unused variable total_sdu_len 6 years ago
Andre Puschmann fab75592ec fix MAC PDU padding with only padding and add test accordingly 6 years ago
Andre Puschmann b6d7fd5def improve error handling in PDU packing 6 years ago
Andre Puschmann da35f41dd5 rework MAC logical channel prioritization 6 years ago
Andre Puschmann 6d586d84a8 extend MAC PDU test 6 years ago
Xavier Arteaga 5d792e7ebe AGC: Fixed gain hysteresis 6 years ago
Andre Puschmann e0a28cf4c0 simplify PDCP init and also bypass it for SRB0 on eNB 6 years ago
Andre Puschmann 0ef96f789b bypass PDCP for SRB0 processing chain 6 years ago
Andre Puschmann 218f136254 remove default PDCP entity for SRB0 6 years ago
Andre Puschmann f5a929e425 pdcp: print length when processing incoming PDU 6 years ago
Francisco Paisana ce29ed545d moved mac thread to the stack. Protect the interface of the stack with PHY and gateway via a queue of tasks 6 years ago
Francisco Paisana 10a56e2a84 moved GW out of the UE stack. This is important to keep concurrency out of the stack once it becomes single-threaded 6 years ago
Xavier Arteaga bb26a42fb6 Fixed backtrace symbols free 6 years ago
Andre Puschmann 414e55fafc pcap: add dtor
this fixes issue if object is destroyed and PCAP is still open
6 years ago
Ismael Gomez 67b6a40c1b Use correlation for neighbour RSRP measurement 6 years ago
Andre Puschmann abef6ce152 move own ipv6 header definition into own header file and use it in tft filter 6 years ago
Guillem Foreman 269e21e3af Fixed minor format 6 years ago
Guillem Foreman 50edd9a325 Initial 256QAM Modem and Demodulator 6 years ago
Joseph Giovatto 0bb7f590b3 Moved include complex.h from header files to impl files to prevent
error /wr to complex.h and c linkage in CentOS 7.
6 years ago
Andre Puschmann 2b82f21fd2 fix compiler warning 6 years ago
Andre Puschmann acbe7fabe4 rlc: fix class member initialization
uninitialized member detected by coverity, now converted all default
initialization to be done in class definition
6 years ago
Andre Puschmann b32254c5e2 use lock_guard for GW 6 years ago
Andre Puschmann 89416a67c7 increase timeout for rlc stress tests
for valgrind where we sometimes hit the default timeout of 1500s
6 years ago
Xavier Arteaga 1f4cf8121b SRSUE: Initial UL channel simulator 6 years ago
Andre Puschmann 2b7b4d0e7e remove hard-coded LCID for dedicated bearer in GW 6 years ago
Pedro Alvarez 2723aa9b12 Added EPS bearer id to apply_tft interface. Sending packets to the correct LCID if they match the packet filter. 6 years ago
Pedro Alvarez a7e0a0624b Starting to add interface apply_traffic_flow_template between NAS and GW. 6 years ago
Pedro Alvarez 2fcf8c1827 Starting to add packing and unpacking tests to activate EPS bearer context request. 6 years ago
Francisco Paisana 415d3418b6 reorganized enb to mirror ue director/class structure with a stack class 6 years ago
Pedro Alvarez d67d18cc6b Removing deplicated error codes. 6 years ago
Xavier Arteaga bd3ec34f7b SRSUE: Apply CLang format phy args structure 6 years ago
Xavier Arteaga fd3671a7e5 SRSUE: Enable AGC 6 years ago
Andre Puschmann e8d6236975 remove init for all RLC TM/UM/AM
- all RLC entities are now initialized during contruction
- there is no need to check for, e.g., existance of timers, during
  runtime
- there is also no need to call re-init during resume
- timers are freed in dtor
6 years ago
Ismael Gomez f24c0cef8c Use timer interface instead of local boolean to query timer state 6 years ago
Ismael Gomez c2e9817f41 Possible solution to RLC Reestablishment 6 years ago
Ismael Gomez 14b526f2aa Add PDCP per-bearer reestablish 6 years ago
Ismael Gomez ade720e032 Add RLC resume procedure 6 years ago
Andre Puschmann 3f613d7183 nas/gw/rrc: make LCID for DRB dynamic
- add interface to RRC to allow NAS to query the DRB for a given
  EPS bearer id
- extend interface for NAS to setup GW to also pass LCID of bearer
- in NAS, use this new interface to pass actual LCID of the default
  DRB when creating the TUN device
6 years ago
Andre Puschmann f357c995fc liblte_mme: fix packing and unpacking of modify EPS bearer context
this just skips the security bits but the packing/unpacking of
the values, i.e. new TFT may still be wrong
6 years ago
Ismael Gomez b31b668a8e Remove unnecessary find_package(GUI) 6 years ago
Ismael Gomez 594d62f229 Added read_block function to ringbuffer 6 years ago
Ismael Gomez 19cb5c172b Added read-and-convert function to ringbuffer 6 years ago
Andre Puschmann e47010130f extend thread class to set unique thread name in ctor
this will also extend all classes that use srslte::thread
to specify the name of the thread in the ctor as well
as to set the name of the worker threads in the thread pool
the thread name will be displayed in gdb.
6 years ago
Andre Puschmann 0e95867f13 remove task dispatcher class 6 years ago
Andre Puschmann acf95fdd85 rlc_am: fix newline in logs 6 years ago
Xavier Arteaga b903e61548 Initialise all channel emulator attributes by default 6 years ago
Andre Puschmann b3f1915f7b pdu: fix zero-padding of RAR PDUs 6 years ago
Xavier Arteaga 9c84f8e3fd SRSLTE: Added Uniform Random vector generator; Delay channel test; Fixed Delay channel SEGFAULT; SRSUE channel unique pointer; 6 years ago
Xavier Arteaga 2ffa1f9f1e SRSUE: Added RLF simulator in channel emulator and integrated it in SRSUE. Removed Zeros Command 6 years ago
Xavier Arteaga 7c97e40e63 SRSUE: Improved internal channel emulator help 6 years ago
Xavier Arteaga 9ab2b2de81 SRSUE: Created delay channel emulator and added fading to the UE 6 years ago
Andre Puschmann 709e769d0d pdu: fix formatting 6 years ago
Andre Puschmann ee1f910877 pdu: add unit test for packing and unpacking RAR PDUs 6 years ago
Andre Puschmann ea2e692836 pdu: fix MAC RAR PDU packing and unpacking with backoff indicator 6 years ago
Andre Puschmann e97343579b liblte_mme: fix typo in header 6 years ago
Pedro Alvarez 1031ea896d add NAS activate dedicated bearer request unpacking test 6 years ago
Andre Puschmann 76b84a9b61 fix unpacking of deactivate eps bearer context 6 years ago
Pedro Alvarez 69b1a2319e Fix error in the TFT parameter list size unpacking 6 years ago
Pedro Alvarez 82828a699b Fixed bug in transaction identifier and radio prio unpacking in NAS. 6 years ago
Pedro Alvarez 02beeefdbd Fix header unpacking error in the Activate EPS dedicated bearer context request message 6 years ago
Andre Puschmann 1c749ad559 add basic handling for deactivating eps bearer 6 years ago
Andre Puschmann c14c3c23f1 pdcp: fix issue when setting SN length configuration 6 years ago
Andre Puschmann f000e36f21 liblte_mme: fix dedicated bearer handling, add handling for UE testmode 6 years ago
Andre Puschmann 8fd4c42849 fix include in build_info.h template 6 years ago
Andre Puschmann 20c9f4687c remove duplicated code mac_cfg_t 6 years ago
Xavier Arteaga 7629863c5a SRSUE MAC: 36.331 v10 9.2.2 MAC main config defaults does not include RACH 6 years ago
Xavier Arteaga 2c78111666 SRSUE: Fixed CLang Tidy in ue.cc 6 years ago
Francisco Paisana 00256f2cd9 fix the hanging in the UE during shutdown 6 years ago
Francisco Paisana 4311c3121c avoid crash when converting nulltype to string 6 years ago
Andre Puschmann 58b09c8677 fix pool_allocate macros for new unique_buffer 6 years ago
Xavier Arteaga 080b4a327c SRSUE: Refactored asynchronous cell and ue_radio. CA Fixed. 6 years ago
Andre Puschmann 65f50cd7ba introduce new UE layer design
- abstract UE object now consists of a radio, a PHY, and a stack layer
- add new stack abstraction layer that combines MAC, RLC, RRC, PDCP, NAS and GW
- PHY layer now has a single stack interface and does not talk to MAC and RRC seperatly
6 years ago
Andre Puschmann 3a6dd9b164 move UE RRC into own folder 6 years ago
Francisco Paisana 0e3baa0f2f Renamed the reset() method of byte_buffer_t to clear() 6 years ago
Francisco Paisana 3bedc93ba5 added _t to unique_byte_buffer type 6 years ago
Francisco Paisana bc01a5ecda changed block_queue api to return back the unique buffer in case it fails to push it to the queue 6 years ago
Francisco Paisana f4aa03154d change queue read and other functions apis 6 years ago
Francisco Paisana f469e2178b replaced byte_buffer_t allocated by the buffer pool for unique_byte_buffer which is safer and easier to use 6 years ago
Francisco Paisana 0976ea6f27 created a unique byte buffer that automatically deallocates 6 years ago
Andre Puschmann 4edcedd2b3 add helper to create cexp function for entire subframe 6 years ago
Andre Puschmann 4f42c0796c add CFO correction method with offset
- CFO correction which allows to specify the offset within
  the correction table to allow phase-continuity across
  multi-subframe transmissions (NB-IoT)
6 years ago
Andre Puschmann 7138126896 add short-cirtuit evaluation for calculating nof of ref symbols without passing object 6 years ago
Andre Puschmann e647dac3e4 add simple cross-correlation method
- implements a cross-correlation that takes the complex conjugate
  of one of the input signals (filter)
- the fft of this input signal is only computed once
6 years ago
Andre Puschmann 13c17ad9e7 add text output capabilities to filesink 6 years ago
Andre Puschmann 62dad5e21d add nb-iot tag support to PCAP writer 6 years ago
Andre Puschmann 92f3f02f2d remove radio_sync object 6 years ago
Andre Puschmann dc9df36a24 remove unused radio_multi code 6 years ago
Francisco Paisana 7be183c223 rework scheduler 6 years ago
Xavier Arteaga 2aa36dd11c Added backtrace print helper 6 years ago
Andre Puschmann fcd086a1c5 fix metrics_hub compilation for older gcc using std::chrono 6 years ago
Xavier Arteaga 114f66f8b9 Reduce ctest execution time 6 years ago
Andre Puschmann 0f6997170b fix unitialized var in pdu.h 6 years ago
Francisco Paisana aca1e9612d revert back from max_sizeof(...) to macros 6 years ago
Francisco Paisana 47ba5cd098 Set the optimization flag to Os for the rrc asn1 library 6 years ago
Francisco Paisana 14b6a1d483 setter method for choice types 6 years ago
Andre Puschmann 3f50e5f51c fix overlapping memcpy detected by valgrind
this has been detected by valgrind+gcc on Ubuntu 16.04 but
isn't an issue for more recent versions. Not sure if that is because
of an issue in older libc and there memcpy implementation or a
bug in valgrind, or both.

In any case, overlapping memcpy may cause undefined behaviour so
it seems ok to only copy the symbols that do not contain the
DMRS, i.e. not symbol 3 in each slot.
6 years ago
yagoda 0213045d74 small cmake bugfix for case where srsenb is disabled 6 years ago
Ismael Gomez efe74e765b Fix coverty non-inititalized variables in tdec 6 years ago
yagoda c25f3b0acf increasing rlc UM window size for eMBMS, small adjustment to eMBMS PHY common 6 years ago
Andre Puschmann 780ea8867c fix asn1_m2ap test
- there was an issue in the stack allocation of the large
  m2ap pdu struct that was fixed by heap-allocating it

- there was also an issue in the m2ap packing that used
  a temporary struct that was not initialized
6 years ago
Andre Puschmann fc432adb66 fix uninitialize variable in ue_ul.c 6 years ago