5g-team
/
srsRAN_4G
mirror of https://github.com/pvnis/srsRAN_4G.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
10,429 Commits
2 Branches
0 Tags
243 MiB
fix-cqi
master
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '2b5f393ea0'
${ noResults }
Commit Graph

2496 Commits (2b5f393ea0e5f42cbf0bf2c1884a88ec9bd76881)

Author SHA1 Message Date
Andre Puschmann e1776f8d28 ue,phy: update the PRACH params inside the lambda that also executes the reconfig 
setting the new PRACH params (writing the the local var) needs to protected as well
because it is called from the RRC context and the PHY worker will call configure_prach_params()
if it sees changes to it.
 3 years ago
Andre Puschmann 40499e6b6d ue_stack_lte: use std::atomic for running var 3 years ago
Andre Puschmann 79cdc28015 nas_test_common: call NAS layer from stack thread context 
since NAS layers insn't thread safe, all calls must come from
the same thread
 3 years ago
Andre Puschmann 78d60bc138 nas: remove all uses of atomic from 4G and 5G classes 
the NAS classes aren't thread safe and thread-safety shouldn't be
pretended by using atomics. Remove them and add explicit notice.
 3 years ago
Xavier Arteaga 8aa7ae7d95 Remove unused attribute 3 years ago
Xavier Arteaga 4cb633e6e6 UE dicards NR CFO measurement if SNR is negative 3 years ago
Xavier Arteaga 83b9b2d1ff Implemented UE open loop CFO compensation for NR 3 years ago
Xavier Arteaga 9c3dd56398 Added PDCCH DMRS interleaved mapping 3 years ago
Xavier Arteaga d61d6aa59f Integrated CORESET0 into UE's RRC 3 years ago
Francisco Paisana 7a527cd09e fix,lte: zero-initialize phy_meas_t in rlf test 3 years ago
Francisco Paisana 36eee0ab40 test,nr: add ra_search_space configuration to phy_cfg_nr; now the test ue searches for RA-RNTI while expecting a RAR 3 years ago
Francisco Paisana f518861ebc fix location of support/ folder. Created macros for ASSERT_EQ and ASSERT_NEQ 3 years ago
Ismael Gomez 7839ab09dc Add RLF-Reportv9 to srsUE 3 years ago
David Rupprecht 3217c00cfc Adjusting NAS base security function to 5G 3 years ago
Andre Puschmann fc2b6a7fb5 ue,rrc: fail NR reconfiguration if mac-logicalChannelConfig is not present 3 years ago
Andre Puschmann e6d9ec40ef ue,rrc: let RRC reconfig fail when LCID cannot be derived from DRB id 3 years ago
Xavier Arteaga cba6df3722 Extended NR PHY robustnes against wrong RRC configuration 3 years ago
Andre Puschmann 28668aac34 ue,proc_ra_nr: add temporary flag to skip RAR reception 
this will be removed again as soon as the eNB supports full RAR
transmission.
 3 years ago
Andre Puschmann d78cbdf9bb ue,proc_ra_nr: fix retransmission of PRACH after failed RAR rx 
if the backoff value is calculated to be zero, don't start
a timer but tx new preamble directly
 3 years ago
Andre Puschmann 99dc94ab38 nas: make state variables atomics 
NAS states and substates maybe be requested from other threads so
they need to be protected.

Note that the caller still needs to hold it's own mutex if different
actions are required based on the state.
 3 years ago
Xavier Arteaga c9183326ce Clean up some code and minor change 3 years ago
Xavier Arteaga dbb10dd6a2 Hold worker thread until baseband is transmitted 3 years ago
Xavier Arteaga 0c7239e5df SRSUE: add RF channel offset 3 years ago
Xavier Arteaga b57df4db10 Refactored worker_end mechanism for concurrent workers 3 years ago
Andre Puschmann e833751031 rrc_nr: add CSI config packing 3 years ago
Andre Puschmann f181733c7e rrc_nr,enb: add more fields to spcell cfg dedicated 3 years ago
David Rupprecht 04ef6e120d Added new SIM functions to get MCC, MNC and MSIN 3 years ago
Andre Puschmann 9c298b203d srsue: reduce the default RRC release to 8 (minimum value) 3 years ago
David Rupprecht 2563a78f34 Added basic 5G NAS metrics 3 years ago
David Rupprecht 9172059078 Supply ctor with logger instead of fetching 3 years ago
Xavier Arteaga bb4f469794 Integrated SR decoder in gNb 3 years ago
Andre Puschmann fc8fe032ff rrc_nr,endc: add more fields to NR RRC Reconfig for EN-DC activation 
adds a big chunk of new fields to the reconfig packing code,
tested with srsUE
 3 years ago
David Rupprecht 0217bf5332 Fixed name space for rrc ue 3 years ago
faluco 7b7ecb7983 Add a new configuration option that controls PDSCH baseband sample dump to a file on KO. 3 years ago
Xavier Arteaga b25681f9de gnb,prach: add PRACH to gNB 
rebase of Xavier's feature_gnb_prach branch
 3 years ago
David Rupprecht fb92118bb7 Add 5G NAS infrastructure 3 years ago
David Rupprecht 505225d845 Added ue nas base class with security functions 3 years ago
David Rupprecht 7fa85ab336 Added nas test common file 3 years ago
David Rupprecht 59ca11db68 Added missing target_link_libs 3 years ago
Andre Puschmann 9d6d437ba5 mac_nr,ue: don't decode RAR PDU that couldn't be decoded 
ignore RAR PDU when PDSCH wasn't OK
 3 years ago
Andre Puschmann c7d29f4af1 ttcn3: fix potential deadlock 
* fix a few races detected with TSAN in SR proc of the DUT
* fix deadlock caused by sync_queue_size set to 1
 4 years ago
Andre Puschmann e0d9afc342 proc_ra: fix race detected with TSAN 
rar_received is accessed from PHY worker and Stack thread
 4 years ago
Andre Puschmann 6c82d63aa6 remove legacy PNF/VNF code 
the code hasn't been maintained for a while an likely needs to be
adapted for a real-world scenarios.

in order to avoid having to maintain two MAC/PHY interfaces we
remove the code from now.
 4 years ago
Xavier Arteaga 54a12870ec SRSUE: avoid negative SR transmission in NR 4 years ago
Andre Puschmann f2f9082d09 ue,rrc_meas: fix invalid access to field when eport_quant_cell_nr_r15 is not present 4 years ago
Xavier Arteaga e764a26136 Integrated PUCCH decoding in gNb 4 years ago
Xavier Arteaga e3afd945bc Refactored NR HARQ ACK feedback 4 years ago
Xavier Arteaga eecaccb541 Added NR PHY helpers 4 years ago
Andre Puschmann 5dbeecdbb5 ue,upper: fix linking on 32bit platforms with missing atomic libs 4 years ago
Andre Puschmann 5999b0d3a5 ue: move blocking wait for detach outside of stack class 
the thread sleep waiting for the UE release should not run
on the stack thread. Move it to the UE class therefore.
 4 years ago
Andre Puschmann 3173dedf0a ue_stack_lte: make sure to execute stack commands on Stack thread 
some commands were executed from the calling thread which may lead
to concurrent access to members. Detected by TSAN. The patch
moves all remaining calls (the majority was alread moved) to the
Stack task queue.
 4 years ago
Andre Puschmann fb4dd3ba7b ttcn3: fix various races between SS and Stack thread detected by TSAN 
fixed through the right usage of mutexes in both TTCN PHY and syssim.
nested mutex locking is solved by calling SS from the PHY after
releaseing the PHY lock again.
 4 years ago
Ismael Gomez 4e39982a19
Fix TSAN warnings in UE (#3021) 
* Protect PHY SR signal management in a class

* Protect intra_freq_meas vector

* Protect cell and srate shared variables in thread-safe classes

* srsue,srsenb: include TSAN options header

* Protect ue_rnti_t and rnti scheduling windows behind thread-safe classes

* Protect access to state variable in sync_state

* Protect access to metrics configuration

* Protect access to is_pending_sr

* Protect access to UE prach worker

* Protect UE mux

* Avoid unlocking mutex twice

* Fix data races in RF/ZMQ

* Fix data races in intra_measure and PHY

* Fix minor data races in MAC

* Make TSAN default behaviour to not halt on error

* Fix blocking in intra cell measurement

* Address comments

Co-authored-by: Andre Puschmann <andre@softwareradiosystems.com>
 4 years ago
Pedro Alvarez 1b676aa406 Moved lib GTPU to its own folder 4 years ago
Pedro Alvarez 865298f8d5 Moved lib PDCP to its own folder 4 years ago
Pedro Alvarez 171d5727be Moved lib RLC into it's own folder 4 years ago
Andre Puschmann 8087bb01e4 nas: log message when airplane mode timer expires 4 years ago
Andre Puschmann 0a16f48869 gw: fix race condition 
GW thread was checking the default_eps_bearer variable without
protection. RRC could update it when deleting DRB or receiving RRC
connection release.
 4 years ago
Andre Puschmann 4d11e5552a rrc,ue: for RRC conn release, delay transition to RRC idle by 60ms as per TS 36.331 
when receiving RRC connection release all actions shall be delayed by 60ms as
per the standard
 4 years ago
Andre Puschmann 368c7b9e4f ue,stack: clear all EPS bearers when going RRC idle 
the EPS bearer manager was only informed when a single DRB
was removed but not when entering idle which requires to
remove all bearers.

This cause the service request to fail.
 4 years ago
Xavier Arteaga aef3e5a40a More NR PHY test and GNB PHY development 4 years ago
Xavier Arteaga d49734b1bc SRSENB: Refactor to accomodate 5G NR 4 years ago
Andre Puschmann e248e086ed ttcn3_dut: reset TFT matcher object when DUT is switched off 4 years ago
Andre Puschmann 7a85191323 nas: call GW for all removed EPS bearers 
this makes sure that GW can also remove all associated TFTs
 4 years ago
Andre Puschmann ab0fba5449 gw: try to remove TFTs for all non-default EPS bearer 
GW needs to reset its default EPS bearer when it is removed
and also try to remove all TFTs for a non-default bearere when
it is removed.
 4 years ago
Andre Puschmann 5313fb99d6 tft: add helper to delete all TFTs for EPS bearer 
when a EPS bearer is removed, all associated TFTs need
to be removed as well.
 4 years ago
Andre Puschmann eef9eb80c4 ttcn3_ue: fix removal of dedicated EPS bearer 4 years ago
Andre Puschmann 60f8a8db1c nas,tft: add support for TFT modification 4 years ago
Andre Puschmann 483a216bd5 ue,stack: refactor handling of radio bearears in UE stack 
this is a rather large commit that is hard to split because
it touches quite a few components.

It's a preparation patch for adding NR split bearers in the next
step.

We realized that managing RLC and PDCP bearers for both NR and LTE
in the same entity doesn't work. This is because we use the LCID
as a key for all accesses. With NR dual connectivity however we
can have the same LCID active at the same time for both LTE and NR
carriers.

The patch solves that by creating a dedicated NR instance for RLC/PDCP
in the stack. But then the question arises for UL traffic on, e.g. LCID 4
what PDCP instance the GW should use for pushing SDUs. It doesnt' know
that. And in fact it doesn't need to. It just needs to know EPS
bearer IDs. So the next change was to remove the knowledge of what
LCIDs are from the GW. Make is agnostic and only work on EPS bearer IDs.

The handling and mapping between EPS bearer IDs and LCIDs for LTE
or NR (mainly PDCP for pushing data) is done in the Stack because
it has access to both.

The NAS also has a EPS bearer map but only knows about default and
dedicated bearers. It doesn't know on which logical channels they
are transmitted.
 4 years ago
Andre Puschmann 3f9c069ff7 ue_stack_lte: add RLC and PDCP entities for NR 4 years ago
Andre Puschmann 7113e55d53 rlc: refactor RLC entity to use smart pointers for holding bearers 
this patch mainly modernizes the bearer creation to use smart pointers.
that allows to simplify the error handling.

ue_stack is changed to match new interface. This commit compiles
but doesn't work.
 4 years ago
David Rupprecht 6d5391756c Refactor build of RLC NR config 4 years ago
David Rupprecht d1d8500ce5 Add testcase for reconfiguration 4 years ago
Andre Puschmann e2c496d825 srsue,mac: fix race between PHY and MAC when stopping UE 
the issue let to unwanted log warning at the end of the UE
execution when the PHY was still pushing DL PDUs while MAC
was already stopped.

This fixes #3003
 4 years ago
Xavier Arteaga b1e4720721 SRSUE/SRSENB: added tx_enable flag in worker_end 4 years ago
Xavier Arteaga 027201d457 SRSUE/SRSENB: Refactor NR workers to generalise lower PHY 4 years ago
Ismael Gomez 9c60ef092c Fix test for non-contention HO 4 years ago
Ismael Gomez 66eb6f20f1 Fix non-contention HO missing the T-CRNTI 4 years ago
Ismael Gomez 5aa5a8e997 Revert UE changes 4 years ago
Ismael Gomez e35a0d72fa Revert UE changes 4 years ago
Ismael Gomez aa5944da78 Fix T-CRNTI push pdu 4 years ago
Ismael Gomez c206d3c0fa fix ttcn3 tests 4 years ago
Ismael Gomez dd9889e07c Add carrier index to uplink PCAP captures 4 years ago
Francisco 9139f88b31 fix,srsue: defer enqueuing of the rrc reconf complete message to avoid that it goes in the UL grant whose PDCCH was scheduled in the TTI as the PDSCH that carried the HO command 4 years ago
Xavier Arteaga fc5d069743 SRSUE: Default PHY measurements to NAN 4 years ago
Andre Puschmann 94959b5318 srsue,test: reorganize test folders and move to components like we in PHY 4 years ago
Pedro Alvarez a53b321ab8 Release UE upon reception of integrity error. 4 years ago
Pedro Alvarez 299d2ee35d Added interface to make the PDCP notify the RRC of integrity check 
failures.
 4 years ago
Xavier Arteaga 6123926353 Fix NR cell search frequency 4 years ago
Xavier Arteaga a79d518799 Added SSB search measure/decode file test 4 years ago
Xavier Arteaga 5181a9d64c Implemented PBCH blind decode 4 years ago
Xavier Arteaga a31f3d42ce Added RF NR search tool and added baseband file 4 years ago
Xavier Arteaga 157af40417 Fix shadow variables in sync.cc 4 years ago
Xavier Arteaga 3a011155db SRSUE: Make sure PHY reset is done when SYNC is IDLE 4 years ago
Andre Puschmann c0be8187c8 rlc interface: convert entire read_pdu() interface to return uint32_t 
we had it returning int but had a bug in using the return value properly,
i.e. handling when -1 was returned in RLC TM.

Thinking about it more, it doesn't make sense to have a negative return
value here anyway. Either the RLC can return a PDU or not. If it can't the
returned lenght is zero.
 4 years ago
Andre Puschmann aaffdeb326 rrc,rlc: add method to signal protocol failure to RRC 
general-purpose method for lower layers to signal protocol
failures to higher layers, i.e. RRC.

In the current case, implement a direct release of the UE (enb) or
a reestablishment (UE).
 4 years ago
Andre Puschmann 107f6334dd compile: fix compilation on 32bit systems that require -latomic 4 years ago
Francisco 486823e5de sched,bugfix: The PHR handling scheme now considers the number of PRBs of the UL grant that carried the PHR. Before, it was assuming the most conservative scenario of Nprb=1 4 years ago
Xavier Arteaga d74f70289e SRSUE: fix last reported RI state 4 years ago
Andre Puschmann b0a2f31478 prach: protect configuration and state getters with mutex 
purely TSAN with unit-test based approach that protects
the state getters and configuration routines with a mutex
 4 years ago
Andre Puschmann d2ec3ca5e1 intra_measure_base: fix race detected with TSAN 
use mutex to protect state getters
 4 years ago
Andre Puschmann f43e82a8a6 ue_phy_test: fix test 4 years ago
Andre Puschmann 98a91a2057 sync: protect sync_state, access ue_sync object only from one thread 
races detected with TSAN, primarily the ue_sync object which isn't
thread-safe is accessed by all workers to set the CFO and by the
sync thread to receive samples (which read the CFO).

The patch introduces shadow variables that are updates from the
main thread before/after the sync is executed. The atomic shadow
variables can then be read from otherthreads without holding a
mutex, i.e. blocking the sync.
 4 years ago
Andre Puschmann 2c975732dc metrics_stdout: fix race detected by TSAN 4 years ago
Andre Puschmann 8ab512c2be nas_test: fix TSAN warnings 
remove mutex and cvar again that we used to circumvent the startup.
we now use a atomic variable to sync the main thread and the stack.
 4 years ago
Xavier Arteaga 2d0a21f779 Move radio frequency mapping out of the PHY common into the PHY reset method 4 years ago
Andre Puschmann 11a6d3160f mac_test: include TSAN options header 4 years ago
Andre Puschmann 018c734b09 dl_harq: fix unlocking of unlocked mutex bug detected by TSAN 
in the mac_test the tb_decoded() method was called twice for
the 2nd codeword, causig TSAN to complain about an unlocked mutex
being unlocked.

The patch resolves the potential issue only calling tb_decoded
for a grant/tb thas has a non-zero MCS.

The patch also adjusts the reset function to have a safe and "unsafe"
version to be called from inside the class, similar to other
classes where we do the same.
 4 years ago
Xavier Arteaga 5c55ff24ec Minor UE aesthetical changes 4 years ago
Xavier Arteaga 44b6a2b55f Fix SYNC wait for IDLE if the state is reached 4 years ago
Xavier Arteaga 807b60988d Wait for PHY workers to transmit before considering SYNC in IDLE 4 years ago
Xavier Arteaga 93b35676e7 Solve concurrency issue when setting up SCell measurement 4 years ago
Xavier Arteaga 7185ec6beb PHY CC configuration is stashed and applied in the next TTI 4 years ago
Xavier Arteaga 235a664120 SRSUE: Removed PUSCH-DMRS/SRS pregeneration methods 4 years ago
Xavier Arteaga aab2211058 Protect UE PHY SCell configuration 4 years ago
Xavier Arteaga a7dcd629ef Cell search waits for IDLE transition before launch 4 years ago
Xavier Arteaga cc2a6dc269 Review cell selection and SCell configuration during HO 4 years ago
Xavier Arteaga 65d51f5855 Fix unitialised value 4 years ago
Andre Puschmann b40867ffec ue,rrc: add simple connection setup procedure 
this is an attempt to fix #2850 by defering the transmission of
the connection setup complete until the PHY has applied
the dedicated config in the connection setup.
 4 years ago
Andre Puschmann c1ad867824 epoll_helper: use std::atomic to protect exit called from different thread 4 years ago
Xavier Arteaga 48e0fc3c99 Implemented initial PBCH decoder and refactored SSB candidate selection 4 years ago
yagoda 8d2568ed2c small fix for console print for cyclic prefix 4 years ago
Francisco f2a56c9139 simplification of multiqueue design. 
- the consumer does multi-staged waiting:
  1. spins first across all queues in a RR fashion
  2. each queue access is done with a try_lock.
  3. if the try_lock fails, it increases the number of spins needed
  2. if no queue had data, the consumer sleeps for 100 usec.
- no differentiation between queues, in terms of notification features
 4 years ago
Francisco 2d6a878826 change interface to create multiqueue queues 4 years ago
Francisco f705735093 optimization - only allow some multiqueue queues to notify the multiqueue consumer of the arrival of tasks 4 years ago
yagoda 9501283c1c fixing support for extended Cyclic Prefix 
small cosmetic fixes of CP code
 4 years ago
Xavier Arteaga 7f853446d3 Added file option to NR cell search test 4 years ago
Xavier Arteaga 5eadc06dd4 Intra-frequency miscellanous changes 4 years ago
Xavier Arteaga 170fbefbf5 Avoid SCell receiver to copy 4 years ago
Xavier Arteaga d39402ed54 Added TTI trigger condition to intra-frequency measurement base 4 years ago
Xavier Arteaga c80f91ac9e Fix compilation 4 years ago
Xavier Arteaga ac9dc6f31d Compute Performance 4 years ago
Xavier Arteaga 0b3f4e5de0 Improvements in NR cell search 4 years ago
Xavier Arteaga 5b31654ae2 Minor aesthertical changes in nr_cell_search_test 4 years ago
Xavier Arteaga fb7623f5b6 Initial intra frequency NR cell search and test 4 years ago
Xavier Arteaga 60015e7ceb Made intra frequency cell search and measurment generic 4 years ago
faluco 1670124926 Implement UE metrics in JSON format. 
Added config options to control this feature.
 4 years ago
Xavier Arteaga 5e6983f8e6 SRSUE: enable 256QAM in RRC NR capability message 4 years ago
Xavier Arteaga a57336d64f Integrate periodic SSB measurement in SRSUE and fix related defects 4 years ago
Andre Puschmann adcfcfe012 proc_ra_nr: fix typo 4 years ago
Andre Puschmann c45540582d rrc: announce NR-PDCP support over EUTRA 
preperation for Split bearer support. This patch is needed to allow
split bearer. Otherwise, even if the config is set in the eNB, it
will not enable split bearers.
 4 years ago
Francisco ef9d1b8c13 stack optimization - reduction of contention in multiqueue class 
With the new design, each queue created in the multiqueue object has its own mutex.
Pushing tasks to separate queues will, therefore, not cause contention.
There will be, however, still contention between the popping thread and the pushing threads.
 4 years ago
Xavier Arteaga 60d1708b80 Initial SSB measurement implementation 4 years ago
Andre Puschmann 833ddc3229 build: fix linking failure on RPi 32bit 
this fixes a linking problem with RPi 3 (and probably others) running
with Raspbian (new Raspberry Pi OS) that can't use the inline
atomic functions but instead require linking against the lib -latomic.

The CMake code is based on SoapyRTLSdr file (licensed under MIT)
https://github.com/pothosware/SoapyRTLSDR/blob/master/CheckAtomic.cmake
 4 years ago
Xavier Arteaga 1396c2a1e2 Mulpiple CSI measurement fixes. Channel and sync metrics from CSI measurements 4 years ago
Xavier Arteaga 653177ca7c SRSUE: Refactored work_dl for NR. Added NZP-CSI-RS measurement 4 years ago
Ismael Gomez 0b91598e36 Move mlockall() to main() in srsUE and srsENB 4 years ago
David Rupprecht f0d2a22cb6 Fixed band index in rrc 4 years ago
David Rupprecht 8c194b887b Allow NAS init function to fail 4 years ago
David Rupprecht 617fb2ba7e Added default destructor for args 4 years ago
Xavier Arteaga 9fb091262a Duplicate NR PDSCH transmits ACK and add ACK Tx TTI to trace 4 years ago
Xavier Arteaga de9158eeaf Enable NR RRC MCS table selection 4 years ago
Pedro Alvarez 17a8ec6cdd Using estimated COUNT (from NAS overflow counter and RX SQN) for decription of NAS messaages. Should avoid issues decripting messages when the COUNT is larger than 256. 4 years ago
Andre Puschmann cd061d46e6 metrics_stdout: remove obsolete if 4 years ago
faluco 90e23d9de6 Print in the ue stdout metrics the CC number for LTE and the RAT for NR. 4 years ago
faluco b9be7c7594 Small cleanup in the stdout UE metrics. 
- Switch to use fmt for formatting the output.
- Change the CC column to be rat now.
- Reworked and re-styled the column alignment.
 4 years ago
Xavier Arteaga 95dafcb413 SRSUE: fix NR carrier PCI in metrics 4 years ago
Andre Puschmann 598594c51a all: bunch of pass by const& changes suggested by LGTM 4 years ago
Xavier Arteaga e1ff824cc2 SRSUE avoid NR SR in UCI for PUSCH 4 years ago
Xavier Arteaga 6c39a5e4ff Added PDSCH DMRS aditional unpacking 4 years ago
Xavier Arteaga 334b308c35 Fix DCI NR configuration from main configuration 4 years ago
Xavier Arteaga 86ad0446e1 Added NR PDSCH and PUSCH resource allocating flattening 4 years ago
Andre Puschmann a083b0da2a proc_ra: only log warning if RAR wasn't received in window 
lead to some failing tests with RF where PRACH wasn't received
correctly. recovery machanism will retransmit PRACH.
 4 years ago
Andre Puschmann 0826b86cec srsue: remove NR DL freq and ARFCN option 
not required anymore as all NR carrier tuning is done
through RRC signaling
 4 years ago
Andre Puschmann 4dd17aee45 rrc/phy/nr: calculate tuning freq of NR carrier from RRC signaling params 
skip initial tuning to hard-coded NR frequency and use RRC-provided
values to calculate center frequency
 4 years ago
Andre Puschmann ff53d2b8b8 all: set of trivial changes reported by LGTM 
mainly fixmes, unused/empty code, etc.
 4 years ago
AlaiaL 58ce75d3b4 Fixes coverity 369617 4 years ago
AlaiaL 82788ca094 Fixed issues from coverity: 
- 370233
- 370234
- 370239
- 370240
- 370241
- 370242
- 370243
- 370295
 4 years ago
Matan Perelman 7ee52dc676 srsUE: Add option to filter N_id_2 / PSS to configuration 4 years ago
David Rupprecht 102a943171 Fixed naming srsLTE to srsRAN 4 years ago
David Rupprecht fd451e8be3 Configure Short PDCP NR SN support 4 years ago
Andre Puschmann 7817f12f1f phy_common: reduce log level to info when UL grant is tried to activate twice 
in accordance with discussion in #2717 we reduce the log level to info
to avoid failing tests due to that event
 4 years ago
Xavier Arteaga ab6a5ef17a Added NR DCI conversion to string for formats 1_0 and 1_1 4 years ago
Francisco ff3fc0826b asn1 fixes and improvements 
- use const char* instead of std::string in enumerated<>::to_string() to avoid mallocs.
- Remove the use of "typedef", and use "using" keyword instead.
- Fix rrc_nr::setup_release_c<>::to_string() broken linkage.
 4 years ago
Francisco 23203b73ae fix - avoid recompiling srsue rrc files twice 4 years ago
Andre Puschmann e3b77fd82a rrc_nr: set timeout for NR cell measurement to 250ms 
the low timout of 10ms was:
1) causing too frequent measurement reports
2) causes a MO ping test to fail where the ICMP request
was sent on the LTE carrier but never got a reply because
the MCG addition was inbetween
 4 years ago
Andre Puschmann 2c156f0007 proc_ra: add further state checks when getting harq_retx signalled 
that makes sure to only restart contres timer if we are actually
in the contention resolution state.
 4 years ago
Andre Puschmann 607ba7c262 mac_test: fix RAR test for Msg3 retx 
with hi=1 the eNB signals a successul Msg3 reception.
To request a retx, which is the case in the MAC test,
it needs to signal a hi=0
 4 years ago
Xavier Arteaga 7246ce0cea Fix MSG3 false retransmission 
this fixes #2694 by considering hi=1 value and not treating
this as a Msg3 retx
 4 years ago
Andre Puschmann c1e4385f50 worker_pool: fix wrong log level when setting worker config 4 years ago
Xavier Arteaga 407903e0d6 SRSUE: refactor carrier setting for accepting a dynamic carrier configuration 4 years ago
Xavier Arteaga 47523935f6 Minor NR RRC fixes 4 years ago
David Rupprecht d2aa25d451 Added option for simulated measurement 4 years ago
Xavier Arteaga 09272edf4b Update NR PHY TTI 4 years ago
Xavier Arteaga 715f8900a8 Selected NR RA procedure PRACH send timeout according to system frame number period from PRACH PHY tables 4 years ago
Andre Puschmann 51e73aa1fc mac_nr_test: add basic DL HARQ test and extend checks for metrics 4 years ago
Andre Puschmann 4b3538aaa8 {dl,ul}_harq: fix metrics calculation 
rewrite  metrics calculation for NR HARQ and remove
unneeded operations.
 4 years ago
Andre Puschmann b6f2c80f66 mac_common: add helper method to get total buffer state 4 years ago
David Rupprecht a064e85c54 rename common lte header 4 years ago
David Rupprecht 81ad72b0ff Refactor srb and drb handling 4 years ago
David Rupprecht 91ff8a2e6d Add rrc_nr to rlc init function 4 years ago
David Rupprecht 6b41ae7e8b Updated PDCP config struct for rat type 4 years ago
Andre Puschmann 5700b090ea worker_pool: set log level for PHY-NR logger and use for PRACH 
log level for PHY-NR wasn't set so:
16:00:32.202953 [PHY-NR ] [I] [ 8024] Setting RAR Grant rnti=4602 dci=rar hop=0 f_alloc=0x32 t_alloc=0x1 mcs=4 tpc=3 csi=0
was always printed. Also use the logger for the PRACH
 4 years ago
Andre Puschmann c8d3e133dc ue: bump default RRC release announced to 15 4 years ago
David Rupprecht 75cd5e65e5 Removed arfcn and freq, and nof_prbs from config file 4 years ago
David Rupprecht 6ed6da1f12 Refactor ue config for eutra and nr config section 4 years ago
Xavier Arteaga 77b6b60b82 Fix rach_cfg.nof_groupA_preambles 4 years ago
David Rupprecht db9dd85783 Parse carrier config in NR RRC reconfig 4 years ago
David Rupprecht f42d4dbc28 Refactored carrier config 4 years ago
Andre Puschmann 87f9b2babc mac_nr: turn off warning for non-implemented features 
they cause RFCI to fail, features are known to be missing.
 4 years ago
Andre Puschmann 73d6b33920 {ul,dl}_harq_nr: reword log entries if HARQ PID isn't found 4 years ago
Andre Puschmann edd150b29f fix PID not being set when reading pending UL grant 
this should fix #2679
 4 years ago
Andre Puschmann 0df218ab90 cc_worker: fix PDSCH log fmt::v7::format_error 4 years ago
Xavier Arteaga 53b38fccf9 Fix compile and other 4 years ago
Xavier Arteaga 8ffced7e88 NR PHY logging minor corrections 4 years ago
Xavier Arteaga abfc1da921 Multiple NR-PUSCH fixes 4 years ago
Xavier Arteaga 7e06e789d5 Fic NR UCI in the info string 4 years ago
Xavier Arteaga 01ce0718be NR-PUSCH RE mapping correction and NR-SCH detailed grant information 4 years ago
Xavier Arteaga e7096d705e Fix NR RRC config NZP-CSI-RS 4 years ago
David Rupprecht bfe2ad98ef Added parsing for NR DL HARQ cfg 4 years ago
Andre Puschmann b9ae064338 mac_nr: add DL HARQ 
this commit adds a complete DL HARQ entity to the MAC of the UE.
It also refactors demux into an own class and adapts the PHY-MAC
interface to use the new MAC capabilities.
 4 years ago
David Rupprecht 138230f4e4 Remove NR RRC log line 4 years ago
David Rupprecht fe8727050b Added new rrc_nr to phy flattening functions and fixes 4 years ago
Xavier Arteaga e4e3456d76 Refactored PDSCH/PUSCH decoder for LDPC early stopping 4 years ago
David Rupprecht 4c68c17bd3 Fixed log level of nr loggers to lte level and hex size 4 years ago
Andre Puschmann bf4d0121dd cc_worker,proc_ra: set RNTI type for UL grant contained in RAR 
needed for HARQ to correctly pick up the Msg3 Tx
 4 years ago
Andre Puschmann 3e1998b2aa proc_sr_nr: tiny cosmetic logging changes 4 years ago
Andre Puschmann ad320c273e proc_bsr_nr: cancel SR if UL grant is received 4 years ago
Andre Puschmann d99402d3b3 rrc_nr: enable SR procedure when pulling config from ASN1 struct 4 years ago
Andre Puschmann 44baea6666 mac_nr: add UL HARQ 
this patch adds a basic UL HARQ entity for NR.

The patch also updates some interfaces between MAC/RA/HARQ,
i.e. get_temp_crnti().

It also adds a Msg3 unit test.
 4 years ago
Andre Puschmann b7146c41b2 nr: add NDI for PUSCH grant to sch cfg struct 4 years ago
Xavier Arteaga af97538448 Remove NR from log lines 4 years ago
Xavier Arteaga 7823bfc28c Fix append NR to loggers for NR components 4 years ago
Xavier Arteaga b5e879db47 SRSUE: review metrics interfaces 4 years ago
Xavier Arteaga 044da18db9 SRSUE: Reviewed PHY metrics getter 4 years ago
Xavier Arteaga dac331ab38 Fix SR PUCCH resource flattening 4 years ago
Xavier Arteaga 2f453b43ba Initial NR PHY interface 4 years ago
David Rupprecht eeddbe69ce Fixes repeating proc RA due to SR trigger 4 years ago
David Rupprecht 5a3a2a6d6f Added functions for adding phr and tag config 4 years ago
Andre Puschmann 396040fd75 metrics_csv: fix CC numbering for NR carrier in CSV 4 years ago
Andre Puschmann c9da21c9bb mac_nr: add error handling when unpacking SCH MAC PDU 
* only handle PDU if unpacking was successfull
* add TC unpacking with malformed PDU
 4 years ago
Xavier Arteaga bc1b14efea Fix NR common PDSCH Resource allocation count 4 years ago
Xavier Arteaga f30f3e0239 Minor aesthetic log change 4 years ago
Xavier Arteaga 21fe502448 Fix NR PRACH resource determination 4 years ago
Francisco f7a8b8bf94 separate drb srb ids into separate enum types 4 years ago
Francisco 21718af3b6 avoid allocating std::string to get lcid radio bearer name. Refactored the lte radio bearer enum type 4 years ago
David Rupprecht 5e02dbc536 Remove measurement id from trigger state nr allows to second nr reconfig 4 years ago
Andre Puschmann c1b66e89a5 mux_nr: protect MAC PDU packing from concurrent access from PHY workers 
this will be moved to UL HARQ shortly but for now we need
to protect the packing
 4 years ago
Andre Puschmann cf696138d3 mac_nr: fix packing order of SDU and CEs 
SDUs need to go first in the MAC PDU, followed by CEs
 4 years ago
Andre Puschmann 399954a970 mac_nr: convert bytes to bits for DL metrics 4 years ago
Andre Puschmann b083b612de proc_bsr_nr_test: fix SBSR test 4 years ago
Andre Puschmann 7da68dfee3 proc_bsr_nr: disable SR activation temporarily 
SR isn't currently working correctly resulting in random PRACHs
being sent.
 4 years ago
Andre Puschmann d1ad315969 mac_nr: add various safety/length checks 4 years ago
Andre Puschmann b1aaadb51c nr,cc_worker: convert grant size in bytes before passing to MAC 4 years ago
Andre Puschmann 7f415189f3 ue,mac: enable basic MAC metrics 
this adds basic MAC metrics calculation for the DL NR MAC
 4 years ago
Andre Puschmann 8024bf7820 mux_nr: improve logging when building UL MAC PDU 4 years ago
Andre Puschmann 880bd66db4 mac_nr_test: add testcase for MAC PDU packing with long L field 
this reproduces the issue found in #2609
 4 years ago
Andre Puschmann 9950278a12 nr,mac_sch_pdu,mux: fix packing of MAC subPDUs with 16bit L field 
the created RLC PDU was too large to fit inside the MAC grant
because only the header room for the short L field was used.

The patch determines the correct size before passing the opportunity to RLC.

It also improves logging in error case by using the MAC logger instead of
stderr/stdout when error occurs.
 4 years ago
Andre Puschmann db496df1e6 mac_nr: add support for periodic BSR reporting 
building on the previous refactor this patch now adds support
for peridoic BSR reporting (using short BSR). It furthermore does
the following changes:

* add BSR packing
* add proc_bsr_nr unit test
* move mac_nr test code into test folder under src (needs to be done with other test code too)
 4 years ago
Andre Puschmann 7188603f2e mac_nr: don't push MAC CE LCIDs to RLC when unpacking DL MAC PDU 
this should fix log warnings then demux was trying to feed MAC CEs
to RLC:

10:50:54.845116 [MAC ] [I] [ 1153] Handling subPDU 1/2: rnti=0x0 lcid=61, sdu_len=1
10:50:54.845117 [RLC ] [E] Radio bearer id must be in [0:11] - 61
10:50:54.845118 [RLC ] [W] LCID 61 doesn't exist. Dropping PDU.
10:50:54.845119 [MAC ] [I] [ 1153] Handling subPDU 2/2: rnti=0x0 lcid=63, sdu_len=33
10:50:54.845119 [RLC ] [E] Radio bearer id must be in [0:11] - 63
 4 years ago
David Rupprecht 56e947bf27 Added functionality for releasing a NR bearer 4 years ago
David Rupprecht cc6d8128ad Added gw interface if it is running 4 years ago
David Rupprecht 7a481c40ab Added mac prach nr proc error handling 4 years ago
David Rupprecht f9ea02b6bf Added functions for rrc reestablishing procedure if nr reconfig failes 4 years ago
David Rupprecht 43ec714ce1 Added functionality for printing nr metrics 4 years ago
Xavier Arteaga db1a1c059c NR PHY workers TTI synchronization between DL and UL work 4 years ago
Xavier Arteaga 991c6e7016 Refactored NR HARQ-ACK feedback enqueue 4 years ago
Xavier Arteaga 49731ab5a1 Initial NR-DCI refactor 
Added NR DCI 1_1 size

Several DCI NR fixes
 4 years ago
Xavier Arteaga dee2ec30cd SRSUE: use new MAC interface for NR SR procedure 4 years ago
Xavier Arteaga 01990c2e1d SRSUE: Add PHY-MAC SR related interfaces 4 years ago
Xavier Arteaga f4ae2d73aa SRSUE: report positive ACK for retx 4 years ago
Xavier Arteaga 20a4c39fa4 SRSUE: Disable PDSCH retransmissions in NR 4 years ago
David Rupprecht 506adca930 Set eutra nr band info based config value 4 years ago
Andre Puschmann d135ae4d29 proc_bsr: initial BSR procedure for NR 
* refactor some common methods to mac_common.cc
* add common mux_base class
* move UL PDU generation to mux class
* add logical channel registration to MAC, MUX, BSR
* add initial proc BSR
* add basic MAC NR test
* rework MAC interfaces
 4 years ago
Francisco d04a19f8bc refactor - increase code reuse in adt files 4 years ago
Xavier Arteaga e200a3359e SRSUE: check RNTI prior to UL encoding 4 years ago
Pedro Alvarez a5229a02d1 Make sure RRC identity is set when NAS reads UE context from file. 4 years ago
David Rupprecht 838d5ac0f4 Added description for using the same filename for mac and mac_nr pcap 4 years ago
Andre Puschmann bde7b49ca3 ue,mac_nr: add basic SR procedure 
the current implementation support only one SR config
and doesn't support the prohibit timer
 4 years ago
Xavier Arteaga 6219500148 Added NR-RRC RACH parsing 4 years ago
David Rupprecht 8c86d2084d Adding NR phy config RRC parsing 
Added error handling

Reworked flattening error handling
 4 years ago
Andre Puschmann 7a3a5f4cf4 rrc_nr: announce short SN in PDCP capabilities 
this allows selecting 12bit SNs for the NR PDCP entity
 4 years ago
AlaiaL bbaebd1274 Added a warning in the log when the cpu metrics are not registered due 
to the number cpu cores is greater than supported.
 4 years ago
AlaiaL c9d1c77e8c - Deleted the magic number of maximum supported cores, now it is a 
constexpr.
- When the system has more cores that the maximum supported, the cpu
metrics will not be registered.
 4 years ago
AlaiaL 6cd9bba641 Added the cpu metrics to the system metrics. 4 years ago
Xavier Arteaga 5bdf2c93b3 Initial NR PDSCH CSI-RS RE skip and other changes 4 years ago
Xavier Arteaga 7704c09ce2 Fix typos 4 years ago
Andre Puschmann 1a0891df51 all: check return value of make_byte_buffer() and handle them safely 4 years ago
Francisco dd336c53ea changed srsran_warning to srsran_expect. Applied new macro to rlc am 4 years ago
Codebot 4523ee6087 rename srsLTE to srsRAN 4 years ago
Xavier Arteaga 8c4ed489e8 SRSUE: Disable neighbour cell display by default 4 years ago
Xavier Arteaga 4ae194581f SRSUE: Adjustments in distance and speed estimations 4 years ago
Xavier Arteaga 49a535b81a SRSUE: force printing neighbour cells by default in console trace 4 years ago
Xavier Arteaga 2782d96170 SRSUE: compute speed from TA commands 4 years ago
Xavier Arteaga a8b5b8efa1 UHD: stability improvements 4 years ago
Xavier Arteaga f3c0360842 Applied aesthetical changes 4 years ago
Xavier Arteaga ddfff3edad SRSUE: Zero transmit buffer if the slot is not UL 4 years ago
Xavier Arteaga fb1a0b6bce SRSUE: added NR-PDCCH information 4 years ago
Xavier Arteaga d3cfb00211 SRSUE: Added TDD DL/UL slot detection 4 years ago
Xavier Arteaga 6f6c20e194 SRSUE: Added procedure for multiplexing UCI in NR-PUSCH 4 years ago
Francisco c6fff54f9e compilation issue fix - wrong number of argments in ttcn3_syssim creation 4 years ago
Francisco 68c938267f fix srslte include that causes a compilation issue 4 years ago
Francisco d1ab4aae66 fix ipv6 related compilation issue 4 years ago
Francisco 3e9f93eb8a refactor - remove old log_filter and logmap libraries from the codebase 4 years ago
yagoda 2ecdab8717 small fixes to the eMBMS downlink, lack of pdcch decoding was causing issues with uplink 4 years ago
Pedro Alvarez 7447fefd19 Make sure that sending the status report sent after RLC configuration in reestablishment 4 years ago
faluco 173dcdd421 - Import latest srslog version. 
- Remove string allocs in some log lines in radio.cc.

Add new tracing buffer capcity options into srsenb and srsue.

Add missing file.
 4 years ago
faluco 60cd649b8f Add a short description of the tracing options inside the config files. 4 years ago
faluco c7542daf43 Remove rlc traces and add new ones into tti run functions both in the enb and ue. 4 years ago
Francisco 20e341d0a1 mac,bugfix - fixed formatting of MAC and scheduler user-defined types 4 years ago
Francisco 5a1bf28fe1 optimization - minimization of number of std::string allocations for logging 4 years ago
Xavier Arteaga 9dffad87f2 Initial UCI bits multiplexing in PUSCH 4 years ago
Xavier Arteaga f4e9d00ea8 Initial HARQ-ACK multiplex in PUSCH 4 years ago
Andre Puschmann 44e7d41f57 mac_nr: free tx softbuffer in stop() 4 years ago
David Rupprecht e3d001a48e Proc RA NR test: fixed uninitialized values 4 years ago
David Rupprecht 6317c9295c SRSUE NR: Removed workaround to add pdcp lte bearer 4 years ago
David Rupprecht 027c20b0d3 SRSUE: Option mac pcap nr and lte write to the same pcap file 4 years ago
David Rupprecht f6d8f13053 SRSUE: Updated ue config packet capture description 4 years ago
David Rupprecht 410c8e5d0e Fix typo 4 years ago
David Rupprecht 5a95cbdfae Disable rat assignment in pcap class 4 years ago
David Rupprecht bb3e87302d Added new pcap enable option and mac nr 4 years ago
AlaiaL b1483802a2 [metrics] restoring metrics_stdout for enb and ue 4 years ago
AlaiaL d518a625cc [metrics] Added the system metrics to the csv 4 years ago
AlaiaL 0ba7cd7df9 [metrics] Added system metrics to the enb's stdout 4 years ago
AlaiaL 3a86c210f9 [metrics] Added the system metrics to the ue stdout 4 years ago
Xavier Arteaga 784f4be72e SRSUE: NR CSI report fixes 4 years ago
Xavier Arteaga 4679e9f871 Initial NR CSI reports 4 years ago
Francisco 12f998cea3 fix failing rrc_meas_test 4 years ago
Francisco a72a659fdf fix timers interface to avoid accessing to a timer after its release. fix gtpu tunnel activation during s1 handover 4 years ago
David Rupprecht 3cf68e796d SRSUE: Restore old nr attach status 4 years ago
Xavier Arteaga 1e55d68b55 Removed set RNTI from API 4 years ago
Francisco 4b09507c19 remove srslte.h includes from upper layers 4 years ago
Francisco 766018f2b4 fix gcc compilation issue 4 years ago
Francisco b329e25bbb move ue phy interfaces to separate interfaces header file 4 years ago
Francisco 13d805ef56 move ue rrc interfaces to separate interfaces header file 4 years ago
Francisco b1706b9197 move ue nas interfaces to separate interfaces header file 4 years ago
Francisco b8bd869d0f move ue rlc interfaces to separate interfaces header file 4 years ago
Francisco a988351f46 move ue pdcp interfaces to separate interfaces header file 4 years ago
Francisco ea04104e8e move ue gw interfaces to separate interfaces header file 4 years ago
Francisco 186285ffd3 move ue usim interfaces to separate interfaces header file 4 years ago
David Rupprecht 8f49b92760 Using PDCP entity lte instead of nr for nr bearer 4 years ago
David Rupprecht 517208a6bc Hardcoding MAC lcid 4 years ago
faluco 2328011732 - Remove old loggers in ttcn3 and in NR. 4 years ago
faluco fd6c1e16a8 - Remove unused loggers in TTCN3. 4 years ago
faluco eaf20fa4f3 - Removed some logger injections in the ue app. 
- Removed old logger setup code not needed anymore.
 4 years ago
faluco 3ce7454105 - Remove old loggers from ue_stack_lte, ue gw. 
- Remove old loggers setting up for these classes.
 4 years ago
Francisco f610a7b83d Change background worker pool to become a global variable 
Allocate rrc::ue objects in batches in the background worker pool
 4 years ago
Xavier Arteaga 126fc09b7d SRSUE: Added initial SR procedure for NR 4 years ago
Andre Puschmann 9c4146442a mac,phy: refactor NR MAC/PHY UL data passing interface 
inspired by accepted (but not yet merged) PR to include the
(unique_)byte_buffer_t for MAC/PHY interfacing, this patch adds
a few more useful bits to that. Buffer management for UL data is now
done in MAC and only a pointer to the data is passed in the UL action.

* Move Tx softbuffer to MAC (until UL HARQ class is ready)
* Remove temparal data member in cc_worker
* Remove memcpy after packing MAC PDU
 4 years ago
David Rupprecht f6f6ee406b SRSUE NR: use correct rnti in rar and make NR proc ra 4 years ago
David Rupprecht 1fcd006a7c fixed segfaulting 4 years ago
Xavier Arteaga b768002a93 SRSUE Added RAR unpacking and other fixes 4 years ago
David Rupprecht 82a8dcc77a Change interface to unique_byte_buffer 
logging message for msg3 preparing
 4 years ago
David Rupprecht 3af0342418 Added mux class and packing of msg3 4 years ago
David Rupprecht f90f10f6a8 SRSUE: NR handle rar pdu in tb decoded, fixed tti_tx issue, log RA procedure and adjusted testcase 4 years ago
Xavier Arteaga 760ad3a746 SRSUE: Interface stack and PHY for NR-RA procedure 4 years ago
David Rupprecht 0f1586dd2d Deleted all HAVE_5GNR in CC and h files 
CMakeList and travis yaml
 4 years ago
David Rupprecht 1987ddd923 Added phy_nr to ue_stack_lte 4 years ago
Xavier Arteaga fe452fae2b Aesthetical changes scell synchronization class 4 years ago
Xavier Arteaga 326c5bc25e Set secondary Serving cell synchronism bandwidth at cell selection and skip at configuration set-up 4 years ago