2908 Commits (388b1e5d9246d4cc24b8537fabf2017269b29ffc)

Author SHA1 Message Date
Xavier Arteaga d61d6aa59f Integrated CORESET0 into UE's RRC 3 years ago
Xavier Arteaga e07263ee26 Added band helper for getting band from ARFCN 3 years ago
Xavier Arteaga 7377496417 Added SCS to string and corrected coreset0 3 years ago
Xavier Arteaga 62ba7d386d Initial CORESET Zero constructor 3 years ago
Xavier Arteaga 5d149a4b78 Moved NR time/frequency allocation SLIV to new component 3 years ago
Francisco Paisana 36eee0ab40 test,nr: add ra_search_space configuration to phy_cfg_nr; now the test ue searches for RA-RNTI while expecting a RAR 3 years ago
Francisco Paisana 2668a8f68b sched,nr: fix Msg3 decoding in PHY to not expect any UCI 3 years ago
Xavier Arteaga 2cd5e98132 Fix NULL check in DCI NR for RAR type 3 years ago
Xavier Arteaga 3784359da5 Use NR DCI format 0_0 packing and unpacking for TC-RNTI type 3 years ago
Xavier Arteaga b846116c5c Added NR RAR UL DCI packing 3 years ago
Francisco Paisana f518861ebc fix location of support/ folder. Created macros for ASSERT_EQ and ASSERT_NEQ 3 years ago
Francisco Paisana 599fc978a5 improvement of srsran_assert design, with specializations to enable/disable assertions based on compile flags other than ASSERTS_ENABLED. Creation of the support/ folder 3 years ago
Francisco Paisana eb4999a18e lte,pdcp: silence error message when a reconfiguration of a PDCP entity is no-op 3 years ago
Andre Puschmann 4076338a1b enb: add MAC-NR PCAP
* use fixed filename until eNB stack layout is decided
3 years ago
Andre Puschmann 7726acad41 rlc_am_lte: fix counting of retx of entire PDUs and PDU segments
this patch fixes a bug discovered in a real network where the DL CQI of a
user degraded repidly in very short time. A relativly big RLC PDU that
was still sent with the good CQI in a big grant now needs to be split
across many tiny segments because the CQI degraded so much.

The retx couting for each transmitted segment caused the retx counter to
reach maxRetx quickly.

With this patch we do not increment the retx counter for each transmitted
PDU or segment of a PDU but instead only increment the counter when
a given SN is added to the retx queue. This can happen either:
a) if the SN is negativly acknowledged and was not already on the retx queue,
b) no new data is available for tx and a SN is selected for retx.

This is in accordance with TS 36.322 which handles retx counting in section
5.2.1 according to the above description.
3 years ago
Xavier Arteaga cba6df3722 Extended NR PHY robustnes against wrong RRC configuration 3 years ago
Xavier Arteaga de89e829e7 Added NR PUCCH Resource ASN1 helper 3 years ago
Xavier Arteaga 3ae131b336 gNb creates PUSCH decode PDU 3 years ago
Xavier Arteaga 856573b92f Added 4096 symbol size as LTE rate 3 years ago
Xavier Arteaga 54e1fe172c Minor NR PHY aesthetical modifications 3 years ago
Xavier Arteaga 956c4f8266 Added PHY NR test TDD FR1.15-1 pattern 3 years ago
Xavier Arteaga dfa323df6b Added 20MHz default configuration 3 years ago
Xavier Arteaga 1b50758bd5 Initial NZP-CSI default configuration from TS38.101-4 3 years ago
Andre Puschmann 3b5344b0f7 thread_pool: add optional ID to thread pool
this allows to prepend an ID to each thread pool to
better differentiate workers from different pools
3 years ago
Xavier Arteaga a300a47673 Fix value selector for NEON 3 years ago
Xavier Arteaga 42b052112f Added TS reference and use SRSRAN_CEI_LOG2 macro 3 years ago
Xavier Arteaga 1f495cb008 Added generic SRSRAN_CEIL_LOG2 3 years ago
Andre Puschmann b6f8280f67 cqi: protect potential div by zero bug 3 years ago
Xavier Arteaga 085e247ece Fix ZMQ TX channel mapping for NULL pointers
Fix ZMQ transmit frequency mapping

Use map mask in ZMQ to determine mapped channels

Fix ZMQ mapping
3 years ago
Xavier Arteaga 562fd1b4d4 Fix segfault 3 years ago
Francisco Paisana bd08a64b5e sched: fix crash for 100 prbs and subband CQI reporting 3 years ago
Ismael Gomez a896e32cf4 Refactor sub-band CQI processing 3 years ago
Ismael Gomez 9b10e1c45d Fix sub-band CQI in UE. Refactor variable names 3 years ago
Andre Puschmann a7eb9b471b pssch_file_test: relax test result check
the file test sometimes decodes 2 and sometimes 3 (less often) SCI.
its not entirly clear why it's different though.

this "fixes" #3088
3 years ago
Xavier Arteaga ca5ea369f5 Extended ue_dl_nr_file test 3 years ago
Xavier Arteaga 914a2e2d31 Add SCH NR softbuffer check 3 years ago
Xavier Arteaga 858fc2c0fc Cleanup include 3 years ago
Xavier Arteaga 5a6b8f42f5 Add standard rate check for FFT minimum size function 3 years ago
Xavier Arteaga 98929c95a8 Initial UE DL NR file test 3 years ago
Xavier Arteaga dcf9ae039c Fix related Sidekiq comments and mutex 3 years ago
Xavier Arteaga b3d9a94dd5 SIDEKIQ: fix tx time protection 3 years ago
Xavier Arteaga ecf668ee9e SIDEKIQ: fix comment 3 years ago
Xavier Arteaga 96ee4b7258 SIDEKIQ: Initial implementation
SIDEKIQ: Add SKIQ_FOUND to RF found condition

SIDEKIQ: finished SKIQ component abstraction

SIDEKIQ: fix issues and added external PPS example

SIDEKIQ: add PPS test card index argument

SIDEKIQ: improvements

SIDEKIQ: improved srate change

SIDEKIQ: more improvements

SIDEKIQ: more fixes

SIDEKIQ: fix Rx ch gain

SIDEKIQ: Fix multi-card synchronism

SIDEKIQ: Better Rx gain tracking
3 years ago
Robert Falkenberg 24e52d6291 soapy: fix array parameter mismatch for some functions
With soapy 0.8.0, GCC 11.1.0 warns of mismatched array bounds
in some functions.
This commit aligns the bound and adds proper wrappers to
fix subsequent warnings.
3 years ago
Francisco Paisana bc5a548fe8 sched: scheduler now accounts for prachs with different durations 3 years ago
Xavier Arteaga bb4f469794 Integrated SR decoder in gNb 3 years ago
Xavier Arteaga 6a9baef11d Limit DMRS PUCCH SNR to void NAN/INF 3 years ago
Xavier Arteaga d783fbf3a0 Reviewed NR procedure for PUCCH resource sselection and reviewed gNb PUCCH interface 3 years ago
Xavier Arteaga 64f4767c4f Fix NR PUCCH decoder memory access 3 years ago
Andre Puschmann c9c3a68fae asn1,rrc_nr: add error code handling to packing/unpacking of pdcch_cfg 3 years ago
Ismael Gomez 6fb9b6bf94 Fix sub-band CQI in UE. Refactor variable names 3 years ago
Ismael Gomez 2e1127f385 Add sub-band CQI periodicity and configuration to lib 3 years ago
Ismael Gomez 3f5094f30e Remove confusing subband_size variable and replace with subband_wideband_ratio 3 years ago
Francisco Paisana 1535e6b205 sched,nr: extend sched nr testing suite. restrict paralllelization for correct DAI generation 3 years ago
faluco 8708043a5f - Add date to log timestamps.
- Print once per second the current timestamp into stdout, feature guarded by a config expert option.
3 years ago
Andre Puschmann ff5fe5df14 rf_uhd_imp: fix race in RF metrics 3 years ago
Pedro Alvarez 8d41c0d476 Maded SRB configuration optional in rb.conf 3 years ago
David Rupprecht d990db66f6 Added syslog logger 3 years ago
Xavier Arteaga b25681f9de gnb,prach: add PRACH to gNB
rebase of Xavier's feature_gnb_prach branch
3 years ago
David Rupprecht e0b09f1301 Fixed coverity findings 3 years ago
Andre Puschmann 6c82d63aa6 remove legacy PNF/VNF code
the code hasn't been maintained for a while an likely needs to be
adapted for a real-world scenarios.

in order to avoid having to maintain two MAC/PHY interfaces we
remove the code from now.
3 years ago
Xavier Arteaga 54a12870ec SRSUE: avoid negative SR transmission in NR 3 years ago
Xavier Arteaga 603c67e36d Set g_ulsch LLR overlaped with g_harq_ack to zero 3 years ago
Xavier Arteaga 3416aad16d Fix PUSCH NR test false alarm 3 years ago
Xavier Arteaga 04aca98e5f Added more checks in PUSCH NR test 3 years ago
Xavier Arteaga ef865b81a3 NR SCH TB information prints actual rate and not the target rate 3 years ago
Xavier Arteaga 11a52248cd RA NR Calculates actual PUSCH rate 3 years ago
Xavier Arteaga 35840d6bc1 Removed all zero condition from LDPC decoding 3 years ago
Xavier Arteaga 64b7dfed65 UHD: fix nullptr buffer 3 years ago
Xavier Arteaga ecc0b92142 Integrated PUSCH decoder in gNb 3 years ago
Xavier Arteaga f07d925be1 Initial NR PHY test scheduling for PUSCH 3 years ago
David Rupprecht 724af2b060 Added nas 5g msg packing and unpacking 3 years ago
Andre Puschmann fa461f0129 rrc_nr: fix linker error in setup_release_c
move implementation to cc file to avoid

[build] /bin/ld: CMakeFiles/rrc_nr_asn1_test.dir/rrc_nr_test.cc.o: in function `asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::set_setup()':
[build] /home/anpu/src/srsLTE/lib/include/srsran/asn1/rrc_nr.h:2276: undefined reference to `asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::set(asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::types_opts::options)'
[build] clang: error: linker command failed with exit code 1 (use -v to see invocation)
3 years ago
Andre Puschmann 4379c20eb9 rlc_am_lte: avoid locking of Rx mutex twice when generating status PDU
call reset_status(), which now is an private method directly when
building a status PDU. No need for the Tx side to call Rx again.
3 years ago
Andre Puschmann 53a7dc78ee rlc_am_lte: replace do_status boolean with atomic
the do_status is queried from the Tx code frequently. To reduce
chances to delay the execution because the RLC Rx side is currently
holding the mutex we can use an atomic.
3 years ago
Xavier Arteaga 5307fec2f0 Added GNB MAC UL info initial interface and fix PHY implementation 3 years ago
Xavier Arteaga cf496e75eb Fix default PHY NR configuration 3 years ago
Xavier Arteaga 2fbd172888 Initial PHY NR configuration generator 3 years ago
Xavier Arteaga e764a26136 Integrated PUCCH decoding in gNb 3 years ago
Xavier Arteaga 3fe9176750 Added PUCCH dedocder to slot worker 3 years ago
Xavier Arteaga e3afd945bc Refactored NR HARQ ACK feedback 3 years ago
Xavier Arteaga 658b47d917 Added NR PUSCH and PUCCH decoder in gnb_ul 3 years ago
Xavier Arteaga f6fc215541 Refactored enb_dl_nr to gnb_dl and initial gnb_ul 3 years ago
Xavier Arteaga eecaccb541 Added NR PHY helpers 3 years ago
Andre Puschmann f292042f66 rlc_am_lte: use try-lock when building status PDU
the patch uses try-lock whenever a status PDU is tried
to be built. This makes sure that when the lock is currently
hold (e.g. by a thread processing rx PDUs) the generation
of the status PDUs is not taking too long and blocking the calling
thread. Instead the status PDU generation is deferred to the next
Tx opportunity.

It's a probabilistic approach that assumes that at some stage the
lock can in fact be acquired.
3 years ago
Andre Puschmann a9d21696c5 rlc_am_lte: make number of RLC SDUs per PDU a compile-time parameter
this allows to set the maximum number of RLC SDUs included
in a single PDU at compile time.
3 years ago
Andre Puschmann bbcaa49429 network_utils: fix TSAN detected race 3 years ago
Andre Puschmann 0e6e3d201e sys_metrics: reduce log level when measurement interval is shorter than expected
on highly loaded systems it can happen that the get_metrics() is called
twice within a few houndred milliseconds. Logging a warning in this
case isn't needed, so reduce to info.

on the other hand, 100ms might be to convervative. Patch also
lowers the smallest interval to 10ms
3 years ago
Ismael Gomez 4e39982a19
Fix TSAN warnings in UE (#3021)
* Protect PHY SR signal management in a class

* Protect intra_freq_meas vector

* Protect cell and srate shared variables in thread-safe classes

* srsue,srsenb: include TSAN options header

* Protect ue_rnti_t and rnti scheduling windows behind thread-safe classes

* Protect access to state variable in sync_state

* Protect access to metrics configuration

* Protect access to is_pending_sr

* Protect access to UE prach worker

* Protect UE mux

* Avoid unlocking mutex twice

* Fix data races in RF/ZMQ

* Fix data races in intra_measure and PHY

* Fix minor data races in MAC

* Make TSAN default behaviour to not halt on error

* Fix blocking in intra cell measurement

* Address comments

Co-authored-by: Andre Puschmann <andre@softwareradiosystems.com>
3 years ago
David Rupprecht 4ed33fed7d Fixed unpack bytes limit 3 years ago
Pedro Alvarez 1b676aa406 Moved lib GTPU to its own folder 3 years ago
Pedro Alvarez 865298f8d5 Moved lib PDCP to its own folder 3 years ago
Pedro Alvarez 171d5727be Moved lib RLC into it's own folder 3 years ago
Andre Puschmann b6a3b8c5b1 rlc: fix dtor
TSAN was complaining about destroying a locked mutex
3 years ago
faluco a70ad58440 Fix a data race in the UHD class wrapper where the last error member was being set concurrently causing random crashes.
Introduce a new macro to catch UHD exceptions and log them directly instead of storing an error string, similar to what errno does.

Remove usrp logging helpers that depend on the now removed member since all calls potentially log the error directly.
3 years ago
faluco e20934583e Remove an unsafe assert in the log backend that could be triggered under very certain circumstances.
RFCI has detected this assert failing in the log_backend_test. I have not been able to reproduce this locally but my theory is the following one:
one of the unit tests does the following:

backend.start();
backend.stop();

the internal running_flag member could be set to true and then to false by the main thread before the worker thread calls do_work(). If this happens
the assert will be triggered, which is wrong and too conservative, so remove the assert.
3 years ago
Xavier Arteaga 6f5614a0cc Suggested modifications on gNb MAC/PHY interface 3 years ago
Xavier Arteaga 8378c85ec4 Refactored gNb PHY 3 years ago
Xavier Arteaga 9126ad3b8b Added NR type1 RIV function helper 3 years ago
Xavier Arteaga e98a6f9eea Make ACK M constant i UEDLNR 3 years ago
Andre Puschmann 483a216bd5 ue,stack: refactor handling of radio bearears in UE stack
this is a rather large commit that is hard to split because
it touches quite a few components.

It's a preparation patch for adding NR split bearers in the next
step.

We realized that managing RLC and PDCP bearers for both NR and LTE
in the same entity doesn't work. This is because we use the LCID
as a key for all accesses. With NR dual connectivity however we
can have the same LCID active at the same time for both LTE and NR
carriers.

The patch solves that by creating a dedicated NR instance for RLC/PDCP
in the stack. But then the question arises for UL traffic on, e.g. LCID 4
what PDCP instance the GW should use for pushing SDUs. It doesnt' know
that. And in fact it doesn't need to. It just needs to know EPS
bearer IDs. So the next change was to remove the knowledge of what
LCIDs are from the GW. Make is agnostic and only work on EPS bearer IDs.

The handling and mapping between EPS bearer IDs and LCIDs for LTE
or NR (mainly PDCP for pushing data) is done in the Stack because
it has access to both.

The NAS also has a EPS bearer map but only knows about default and
dedicated bearers. It doesn't know on which logical channels they
are transmitted.
3 years ago
Andre Puschmann a4b2a065ff pdcp: reword warning when dropping PDU 3 years ago
Andre Puschmann 7113e55d53 rlc: refactor RLC entity to use smart pointers for holding bearers
this patch mainly modernizes the bearer creation to use smart pointers.
that allows to simplify the error handling.

ue_stack is changed to match new interface. This commit compiles
but doesn't work.
3 years ago
David Rupprecht 6d5391756c Refactor build of RLC NR config 3 years ago
David Rupprecht d1d8500ce5 Add testcase for reconfiguration 3 years ago
Xavier Arteaga eb7980f2b3 Initial UE synchronization for NR 3 years ago
Pedro Alvarez 4d13906760 Increase logging level of MAC mismatches to warning in PDCP 3 years ago
Andre Puschmann e1fb58d76e rlc_um: reduce log level for message handling lost PDUs
when a lost PDU is detected a warning will be logged. In theory
this could be info as well but a warning may help to detect issues
in tests. The same event causes multiple other warnings to be logged,
which is very spammy. The patch reduces the log level for
those messages to info.
3 years ago
Pedro Alvarez aae266e848 Added configuration option for S1AP SCTP bind port 3 years ago
David Rupprecht 85d7a851fb Added 5G NAS PCAP support 3 years ago
Andre Puschmann 83bf5dcd49 rlc_am_lte: reduce time holding Tx mutex when processing status PDUs
the patch is a re-implementation of the customer-specific optimization
we did in order to reduce the time the RLC holds the Tx mutex when
processing an incoming status PDU.

The patch makes sure to never operate on a raw mutex but instead
uses the deadlock-avoiding RAII lock.
3 years ago
Ismael Gomez 5aa5a8e997 Revert UE changes 3 years ago
Ismael Gomez e35a0d72fa Revert UE changes 3 years ago
Ismael Gomez dd9889e07c Add carrier index to uplink PCAP captures 3 years ago
Xavier Arteaga cf09044453 Optimised random bit (unpacked) and byte (packed) generator 3 years ago
Xavier Arteaga d2a19c3043 SCH minimum number of iterations to 2 to reduce systematic false alarm probability 3 years ago
Xavier Arteaga ef4c978d72 Optimized byte random generator 3 years ago
Andre Puschmann d7204df896 rlc_am_lte: check rx window first when receiving status PDU
move rx window check up so no actions are taken when receiving
malformed status PDU
3 years ago
Xavier Arteaga 2cd8ba3a1a PDCCH test skips 100PRB for ARM 3 years ago
Andre Puschmann 19f30aa652 rlc_am_lte: fix handling of out-of-order status PDUs
before processing incoming status PDUs we should be checking
if the ACK_SN falls within our current Tx window. If not the PDU
will be dropped.

Without the check we were incorrectly processing the status PDU
and because the sequence number wrap around wasn't working
correctly if ACK_SN is smaller than vt_a we were corrupting
our Tx window.
3 years ago
Andre Puschmann b862bbc2e6 rlc_am_lte: add missing mutex to get_status getter
fixws race detected with TSAN
3 years ago
Andre Puschmann 878142843e rlc_am_lte: add further sanity check when creating status PDU
the test verifies that the ACK_SN of a status PDU falls inside the
rx_window of the receiver. If not, than the RLC state has been
corrupted and the status PDU is likely invalid.
3 years ago
Xavier Arteaga 6be57dd216 Disable PDCCH false detection for non AVX2 machines 3 years ago
Alejandro Leal Conejos a51f2a1de4 Fills the value of the number of cpus for the system_metrics_t and
initiliaze its value to 0 when executing 2 measures in less than 100 ms.
3 years ago
Pedro Alvarez a53b321ab8 Release UE upon reception of integrity error. 3 years ago
Pedro Alvarez 299d2ee35d Added interface to make the PDCP notify the RRC of integrity check
failures.
3 years ago
Xavier Arteaga a79d518799 Added SSB search measure/decode file test 3 years ago
Xavier Arteaga 5181a9d64c Implemented PBCH blind decode 3 years ago
Xavier Arteaga a7b7f8e78a Avoid SSB search to have a peak that SSB data is outside buffer 3 years ago
Xavier Arteaga 480f1b14fe Protect Radio from null phy 3 years ago
Xavier Arteaga 9621cf57c2 Implemented NR SS raster object 3 years ago
Xavier Arteaga 49d857cd17 Refactored decode_tb function 3 years ago
Xavier Arteaga 22b1673b36 Added CRC match function and simplify CRC check 3 years ago
Xavier Arteaga 7846bfccb1 Implemented softbuffer RX CRC reset 3 years ago
David Rupprecht ff3e7c321d Added bref function for calc distance til end 3 years ago
Xavier Arteaga e8f2b3a74c Add PDCCH decoder correlation check in blind search 3 years ago
Xavier Arteaga 7c78fd2050 Implemented PDCCH DCI message correlation and updated test 3 years ago
Xavier Arteaga bcd2e59635 PDCCH test global variable cleanup 3 years ago
Andre Puschmann c0be8187c8 rlc interface: convert entire read_pdu() interface to return uint32_t
we had it returning int but had a bug in using the return value properly,
i.e. handling when -1 was returned in RLC TM.

Thinking about it more, it doesn't make sense to have a negative return
value here anyway. Either the RLC can return a PDU or not. If it can't the
returned lenght is zero.
3 years ago
Xavier Arteaga 60f294a6a1 Refactor PDCCH encode/decode unit test 3 years ago
Xavier Arteaga 5ddc974beb Reverted PDCCH threshold 3 years ago
Xavier Arteaga d46be09663 Increase viterbi default number of iterations 3 years ago
Xavier Arteaga 090022568e DCI NCCE find considers L and NCCE 3 years ago
Andre Puschmann a36e0477b8 rlc_am: fix status PDU packing when grant size isn't enough to send full report
when a small grant is provided it might not be possible to fit a full status
PDU. This is currently detected while packing the PDU.

In order to avoid sending potentiall contradicting status info to the sending
entity, the fix makes sure to only transmit a small PDU acking what really
has been received so far.

This might not be optimal in terms for retx but will not corrupt any
state.
3 years ago
Andre Puschmann 5838ec4999 rlc_am: revert expect macro back to error log and inform higher layers
the incidence really must be handled by the higher layers, i.e. the bearer
needs to be reestablished.
3 years ago
Andre Puschmann f22f4b4fbd rlc_am: fix potential stalling in RLC transmitter
it turned out that a certain order of events can lead to
a RLC transmitter stalling because even though unacknowledged PDUs
are queued, none of them was actually considered for retx.

This can happen if a pollRetxTimer expires for a SN that, meanwhile,
has already been acknowledged. The positive lead to the deletion of
the SN from the Tx window.

The fix makes sure that when a retx for a unexisting SN is requested,
the sender will consider the next unacknowledged SN instead.
3 years ago
Andre Puschmann 107f6334dd compile: fix compilation on 32bit systems that require -latomic 3 years ago
Francisco 486823e5de sched,bugfix: The PHR handling scheme now considers the number of PRBs of the UL grant that carried the PHR. Before, it was assuming the most conservative scenario of Nprb=1 3 years ago
Ismael Gomez 5db3030428 Tiny changes 3 years ago
Andre Puschmann 1529379e9e fec,pbch: remove unused variables
unused code that moreover was causing TSAN to complain, e.g.
in the ue_phy_test
3 years ago