1144 Commits (1329bb336e8a3d0213db5662cd2298fd2ef1f87a)

Author SHA1 Message Date
Francisco Paisana 02d4dde1f5 issue 2170 fix: add extra check that UL harq is empty before allocating it 4 years ago
Francisco Paisana f45d31d899 add fairness coefficient to UL. 4 years ago
Francisco Paisana ea8ad153c4 add configurable fairness parameter to pf scheduler 4 years ago
Francisco Paisana 2abe486e18 separate control loops for PUCCH and PUSCH TPC 4 years ago
Andre Puschmann 732a108982 mac: convert rar_pdu_msg[] from vector into array and protect access
attempt to address ASAN detected issue:

RACH:  tti=821, cc=3, preamble=11, offset=0, temp_crnti=0x47
ASAN:DEADLYSIGNAL
=================================================================
m==25385==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000024 (pc 0x564b19a26c93 bp 0x7fa0e5f1a8c0 sp 0x7fa0e5f1a798 T8)
==25385==The signal is caused by a WRITE memory access.
==25385==Hint: address points to the zero page.

------DL--------------------------------UL------------------------------------
rnti cqi  ri mcs brate   ok  nok  (%)  snr  phr mcs brate   ok  nok  (%)   bsr
  46 0.10   0 0.0     0    0    0   0%    0  0.0   0     0    0    0   0%   0.0
  47 0.10   0 0.0     0    0    0   0%    0  0.0   0     0    0    0   0%   0.0
    #0 0x564b19a26c92 in srslte::rar_subh::set_ta_cmd(unsigned int) /mnt/data/jenkins/workspace/srslte_ogt_manual_zmq/srsLTE/lib/src/mac/pdu.cc:1136
    #1 0x564b19577f7e in srsenb::mac::assemble_rar(srsenb::sched_interface::dl_sched_rar_grant_t*, unsigned int, int, unsigned int, unsigned int) /mnt/data/jenkins/workspace/srslte_ogt_manual_zmq/srsLTE/srsenb/src/stack/mac/mac.cc:837
    #2 0x564b19591765 in srsenb::mac::get_dl_sched(unsigned int, std::vector<srsenb::mac_interface_phy_lte::dl_sched_t, std::allocator<srsenb::mac_interface_phy_lte::dl_sched_t> >&) /mnt/data/jenkins/workspace/srslte_ogt_manual_zmq/srsLTE/srsenb/src/stack/mac/mac.cc:653
    #3 0x564b19497ee2 in srsenb::lte::sf_worker::work_imp() /mnt/data/jenkins/workspace/srslte_ogt_manual_zmq/srsLTE/srsenb/src/phy/lte/sf_worker.cc:208
    #4 0x564b199f8db4 in
4 years ago
Francisco Paisana 9de318c7e6 avoid allocating DL harqs when respective acks are still pending, when there is a reordering of ttis in the phy 4 years ago
Francisco Paisana 66aa34d173 update RRC NR ASN1 to 2020-09 v15.11 4 years ago
Pedro Alvarez 0c20b7a455 Added support for S1AP modify bearer request support. This includes:
- Handle received E-RAB S1AP at s1ap.cc.
 - Added methods to rrc.cc, rrc_ue.cc and rrc_bearer_cfg.cc to handle erab modify request.
 - Made RLC add_bearer() function capable of re-creating the RLC entity.
 - Send RRC reconfiguration to the UE and reply to the EPC with S1AP
   modify bearer response.

This commit also adds support to srsEPC to send S1AP modify bearer request for
testing purposes.
4 years ago
Francisco Paisana 099dad8cb1 disable PHR handling in the UL sched by default 4 years ago
Ismael Gomez f9a02299f9 Use MAC PDU pointer instead of tti_rx and rnti as a key to associate buffers. Decouple crc_info() and push_pdu() functions. This allows for different timing architectures in the PHY 4 years ago
Ismael Gomez 0498439d41
Backport some changes from FAPI branch (#2124)
* Reorder DCI FORMAT enum

* Fix endianness issue

* Fix return codes in phy_ue_db

* Log members should be destructed after the layers.

* Add JSON metrics and Events. Add Alarm log channel. Simplify MAC metrics struct.

* Restore metrics_stdout change
4 years ago
Francisco Paisana 7869c66fb7 avoid overwriting phy config ul64qam config for scell 4 years ago
Francisco Paisana 82eb31f70f add rlc metrics to enb 4 years ago
Francisco e2654e69ec Enable pdu stack latency measurements in the eNB. 4 years ago
Francisco b0a7506a8a add extra check to verify if erab is still available for rrc metric extraction 4 years ago
faluco 343587b32d Update NR classes after metrics interface changes. 4 years ago
faluco f20b75a05f Re-structure enb metrics a bit. Create a generic mac metric struct and per ue mac metrics struct. 4 years ago
faluco 5529943172 Add a per sector rach preable counter for the metrics. 4 years ago
Francisco f1c05f6826 add sector id to ues in mac metrics 4 years ago
Francisco 43e0a3209d fill enb rrc metrics with drb info 4 years ago
Pedro Alvarez 7eebd71627 Added S1AP E-RAB release command/response handling to srsENB.
Added the ability to srsEPC to send the E-RAB release command.
4 years ago
Francisco cba0cc457f sched rand test refactor: creation of abstract sched simulator class for testing 4 years ago
Francisco a068ae11b0 sched rand tester ue_sim class now handles cqi 4 years ago
Codebot 43082e8d6a enb/ue: turn various warning messages into info
turn events that may happen in the normal life of a eNB/UE
into info rather than warning to allow strict
warning/error checking in tests.
4 years ago
David Rupprecht 848496bb0f Moved get_earfcn to srslte get_carrier_freq func 4 years ago
Francisco 37ee8bcf46 fix issue 2082 - ensure that sched does not exceeds max coderate while decreasing mcs 4 years ago
Francisco b4861bc59a move sched params and sched helper methods to sched_helpers.h/cc files. Removed place in the scheduler where the mcs is increased forcefully to avoid segmentation 4 years ago
Francisco 920e15c1a5 fix logical channel pdu size computation 4 years ago
Ismael Gomez ae1092257f Fix issue in 15 PRB 2CA: Due to DCI format ambiguity, the scheduler needs to use Format1A instead of Format1. The number of PRB was incorrectly calculated when generating the grant, leading to corruptions in the MAC PDU. 4 years ago
Francisco 9eddfdb4a3 fix sched rand tester coderate check. tbs needs to be converted from bytes to bits 4 years ago
Francisco 0ae304a6ed update sched rand tester to detect when tbs coderate exceeds 0.93 4 years ago
Francisco 2598989f7d replace msg3grant type from C-array to bounded vector 4 years ago
Francisco 22229adf08 fix: normal phr is only sent for PCell 4 years ago
Francisco 8670558692 fix failing scheduler ca test 4 years ago
Francisco 479602ed1d add option to specify target ul sinr for UL power control to the enb rr.conf parser 4 years ago
Francisco 5865df39d1 created class that implements the scheduler transmit power control and PHR handling 4 years ago
Francisco 2b59e90304 fix: limit number of encoded PHICH in the scheduler to the max size of the array 4 years ago
Francisco 2b97b2c8bb add bound checks for data, bc, and rar allocations in the scheduler to avoid array overflows. 4 years ago
Francisco 86ab1864f7 The struct tti_point is now used ubiquitously in the scheduler 4 years ago
Pedro Alvarez 49bcffcdf8 Fix issue packing TEID in Error indication. 4 years ago
Pedro Alvarez 235f373af7 Started to add ability to send error indication when G-PDU from invalid TEID is received. 4 years ago
Francisco 8fb3ea6922 Added the ability to choose scheduling policy from enb.conf
- The two options provided at the moment are time-domain RR and PF
4 years ago
Francisco b71e8075f4 Refactoring of scheduling algorithms
- Use single interface for both DL and UL
- Wrote helper functions for tasks that are common to different algorithms
- created subfolder for all scheduling algorithms
4 years ago
Francisco d7fae0b7a3 Implementation of time-domain PF scheduler
- PF scheduling becomes the new default
4 years ago
Andre Puschmann 07d2bc4fe8 change license header to agnostic version with hint to root LICENSE file 4 years ago
Francisco a5ef9f1eb9 potential fix for heap-overflow in scheduler, issue #2053. Added a bound check for the number RACH handled per tti. RACHs are ignored once the limit is surpassed. 4 years ago
Francisco 2fcb507de7 Fix gcc compilation errors with false_position_method in sched_ue.cc 4 years ago
Francisco 8d181ef41c Optimization of cc_sched_ue::cqi_to_tbs(...) method via the use of root-finding algorithm 4 years ago
Francisco 94efeab672 Optimization of sched_ue methods to derive required number of prbs to allocate to a rnti
This optimization has been achieved by:
- implementation of "false position method" root-finding algorithm
- application of the false position method in cc_sched_ue::get_required_prb_dl/ul(...)

The number of iterations in the worst case scenario, reduced from 100 to 5 with
the proposed algorithm.
4 years ago
Francisco f07e52129c increase mcs ul upper bound to 24 when ue is cat4 and enb supports 64qam. Simplified max_mcs computation 4 years ago
Francisco 3d80ff4831 fix activation of PDCCH for adaptive retxs. 4 years ago
Francisco fc81a5c6ba harq ack state can now only be NACK or ACK. The ul_harq pending phich flag is now reset after phich scheduling. Thus, the existence of a crc_info(...) signal from the PHY is not required. 4 years ago
Francisco 3067e81e67 fix check of pending UL bytes 4 years ago
Francisco bb96625129 renaming lch_manager -> lch_ue_manager 4 years ago
Francisco a348508072 simplified sched_ue pending DL bytes calculation API 4 years ago
Francisco 0ffea62411 Wrote logging functions for SCHED MAC CE/LCID allocations 4 years ago
Francisco c1fb161004 Move sched lch_manager to separate file 4 years ago
Francisco eae0dc93ad rename scheduler files. scheduler -> sched 4 years ago
Francisco 68eda336bd remove ENB_METRICS_MAX_USERS compile time macro and use run-time variable to set maximum number of UEs the srseNB can have connected at a given instant. 4 years ago
Ismael Gomez ce20cc4c54 Add missing current_tx_nb which was causing all in uplink to fail 4 years ago
Pedro Alvarez d05bc064b5 Reduced SCTP connect() timeout.
Added configuration for RTO_MAX. Cleanup debug prints.
4 years ago
Francisco 324cb80cac rename cell_info_common->enb_cell_common and cell_ctxt_dedicated->ue_cell_ded 4 years ago
yagoda bdc1964335 consolidating RRC eMBMS configuration into single function, setting some parameters to const 4 years ago
yagoda b90574975b refactoring asn1 eMBMS code, removing asn1 from PHY and MAC in eNodeB 4 years ago
Andre Puschmann fb83b5c307 enb: fix reestablishment with AS security enabled
this fixes RRC reestablishment with security turned on

the bearers, primarily SRB1, were reestablished before the "old"
security context was restored from the previous RNTI of the
reestablishing user.

this let SRB1 without proper security config. therefore the UE
couldn't decrypt the first response of the UE on SRB1 that was
already encrypted.
4 years ago
Francisco 92c1c2a182 more efficient measObjToAddModList reconfiguration by ensuring consistency in EARFCN ordering 4 years ago
Francisco 68d463b08f remove var_meas_cfg_t class 4 years ago
Francisco 25bfb6d84d move rrc measconfig handling functions to separate file. Update measconfig tests 4 years ago
Francisco 1cb65f07f1 enable meas gaps in RRC and enb parser 4 years ago
Francisco Paisana 49a48c0130 add measgap awareness to scheduler metric and sf_sched. Add measGap test to random sched test suite. 4 years ago
Francisco Paisana 2b05d5a67c add meas gap addition logic to srsenb rrc mac controller 4 years ago
Francisco Paisana 9579931f16 added meas gap checks to scheduler ue 4 years ago
Francisco Paisana fdec451a9d disable mcs>20 if eNB supports UL 64QAM but UE doesn't 4 years ago
Francisco Paisana bc00abeeb8 fix phy configuration of UL 64QAM 4 years ago
Francisco Paisana b369d6d5d5 consider enb sib config when activating UL 64QAM 4 years ago
Francisco Paisana bf7c587e4f add UL 64QAM support to eNB RRC and scheduler 4 years ago
Francisco Paisana d5f6ccc0c4 integrated UL UE-dedicated sched tests in random test 4 years ago
Francisco Paisana 64fca23eb3 extended dci content checks of DL and UL grants in the scheduler random tester. 4 years ago
Francisco Paisana 88105c1577 change the namespace of tti point helper functions for the eNB 4 years ago
Ismael Gomez 524453a6af Fixes N_pucch_cs allocation to avoid collision with SR 4 years ago
Ismael Gomez 13f1d65b24 Add missing current_tx_nb which was causing all in uplink to fail 4 years ago
Francisco Paisana 3ea47b645a changed the way the number of UL pending bytes is calculated in the scheduler 4 years ago
Francisco Paisana 77d64f3ea5 add PDCCH alloc to UL retxs that resume the HARQ 4 years ago
Francisco Paisana d8203acd56 implement harq resuming functionality 4 years ago
Francisco Paisana 510959b50f update nr asn1 files, and asn1 tests 4 years ago
Francisco Paisana f927ccaf55 fix pusch grant allocation for cqi reporting in CA. 4 years ago
Francisco Paisana a351b2534e allow PUSCH grants for CQI in PCell 4 years ago
Francisco Paisana 2ade364434 defer scell activation to rrc reconf complete reception 4 years ago
Andre Puschmann 74dcdec54f enb: fix antenna port count for SCell config in RRC reconfig
set antenna port count for SCells in RRC reconfig message according
to configured ports in the enb config
4 years ago
Francisco Paisana a865858db3 disable srbs UL during handover to avoid UL grants and scheduling requests before the handover is complete 4 years ago
Francisco Paisana 484c7586b4 fix heap buffer overflow 4 years ago
Francisco Paisana 42cdc5e340 Allocate all the leftover bytes of the TBS to last allocated MAC SDU.
Fix the way the RLC header is accounted for depending on the bearer id.
For instance, the SRB0 does not require any RLC header.
4 years ago
Francisco Paisana 55d62a2baa fix rlc buffer updating inside the scheduler to account for RLC headers 4 years ago
Francisco Paisana 84cfc29ca1 apply the scell configuration sooner during intra-enb handover 4 years ago
Francisco Paisana b40a5a958e use common function to fill rrc reconf message in handover 4 years ago
Francisco Paisana e9b693942f diff-based cell selection activation 4 years ago
Francisco Paisana 836e7d7ede refactor scell addition in the srsenb::rrc to follow the same style of other rrc recfg fields 4 years ago
Francisco Paisana a8e11d7991 removal of the special case for rrc reconf update 4 years ago
Francisco Paisana f26b5ccde7 fix drb reestablishment during handover 4 years ago
Francisco Paisana 7bf196a6e0 removal of srb handling from srsenb::rrc::bearer_cfg_handler 4 years ago
Francisco Paisana 2ef1e286b2 fix set of rrc reconf message radio resource cfg fields 4 years ago
Francisco Paisana 890113fd32 now the rrc enb is using a common function for rr_cfg reconf for the first reconf message 4 years ago
Francisco Paisana ce78fa82ce now the rrc enb is using a common function for rr_cfg setup/reest 4 years ago
Francisco Paisana 97f2e4336e refactor of functions for filling the asn1 radio resource config structs. This functions are used during rrc setup/reest/reconf 4 years ago
Francisco Paisana 9b40d1da99 fix 256qam for handover 4 years ago
Francisco Paisana c24d754dbb add 256qam to scell as well 4 years ago
Francisco Paisana 514deaf25b fix resetting of phy and mac during reestablishment 4 years ago
Francisco Paisana 83d13cf20f uncomment 256qam features 4 years ago
Francisco Paisana 4cb6ed27eb updated scheduler ue mcs computation to account for new 256QAM tables 4 years ago
Francisco Paisana 461f34785d activation of 256qam in reconf message if the UE supports it. 4 years ago
Francisco Paisana 44a9ad76f1 avoid sched_ue dangling pointer
With the sched feature that allows scheduling in TTIs
ahead of time, there is no guarantee that when
the tti arrives to generate a sched result, the stored
raw sched_ue pointers are still valid. For this reason,
I now store the rnti and check if the rnti still exists.
4 years ago
Francisco Paisana 0d38e28ce7 address PR comments. Change warning message if sched ue cells cqi configs will lead to time collisions. 4 years ago
Francisco Paisana 852c31c0bc log warnings when the sched ue cfg is not valid 4 years ago
Francisco Paisana e84aa34139 comment out 256qam features 4 years ago
Francisco Paisana 1ce928ab2e use of current / future ue sched config structs in the srsenb::rrc::ue::mac_controller as an approach to deal with the multi-step mac reconfiguration of the UE 4 years ago
Francisco Paisana 1e6d902873 cleanup of srsenb::rrc::ue::mac_controller api 4 years ago
Pedro Alvarez f5ca40e3bf Make sure that security is enabled after sending RRC reestablish, so that reestablish complete is integrity checked and unciphered. 4 years ago
Francisco Paisana f1bdf33d10 addition of cells provided in cell_meas_list of rr.conf to cellsToAddModList in the rrc reconfiguration message 4 years ago
Francisco Paisana c5c7700cb7 implemented DL logical channel prioritization test for finite PBRs 4 years ago
Francisco Paisana 2d3681699a added test for DL sched logical channel prioritization. At the moment only PBR=infinity is tested 4 years ago
Francisco Paisana 9b10acff06 implemented logical channel prioritization in DL scheduler 4 years ago
Francisco Paisana b7ed8b1858 - added react method to to_state<...> transitions
- s1 handover composite state simplified
- the eNB now starts a HO cancellation when it receives an invalid
Handover Command
- the FSM log now prints the current state when it receives an unhandled
event
4 years ago
Francisco Paisana 53f1a62c64 cleaned up state machine of sched_ue for activation/deactivation of carriers 4 years ago
Francisco Paisana a761762ec8 extended cc_sched_ue fsm to account for more harmonious transition of an scell to deactivated state 4 years ago
Francisco Paisana 74c18ecf6c implementation of SCell Deactivation 4 years ago
Francisco Paisana eafc003671 Altered the way the generation of the scheduling decision for a given
TTI is made. Instead of generating one CC in each dl_sched()/ul_sched()
call, all CC decisions are generated at once. This avoids race
conditions with calls from the RRC to the MAC to configure UEs.
4 years ago
Francisco Paisana bc429eae94 add comment explaining why BSR has to be accounting in the computation of the number of bytes to allocate in UL 4 years ago
Francisco Paisana 12c147d75a The scheduler now accounts for the possible presence of BSRs in the size of UL grants 4 years ago
Francisco Paisana c46402c836 fix phy configuration during handover on srsenb. The function srsenb::rrc::ue::fill_scell_to_addmod_list assumes that the phy_cfg of the PCell is up-to-date, which was not the case. With this PR, the srsenb rrc updates the phy_cfg before the ho cmd is sent, but, in the case of intra-enb ho, the updates are not submitted to the phy before the reception of the crnti mac ce 4 years ago
Francisco Paisana 0f51d70aac fix measObj addition in srsenb. Now the enb considers both scells and meas_cells in the rr.conf 4 years ago
Francisco Paisana ae32ab9b13 addressed xavie's comments regarding list of scells to add to rrc reconf message not being in order when we iterate it 4 years ago
Francisco Paisana d42cdca729 fix scell activation in the phy during intra-enb handover. 4 years ago
Andre Puschmann 9866dcc10b enb: disable qam256 configuration
disable qam256 altogether until underlying PHY/MAC support
is implemented
4 years ago
Francisco Paisana 49186e2b1f Fix NCC set in HO command message for intra-enb handover 4 years ago
Francisco Paisana 2e10c8e13d bug fix - eNB was not allocating UL grants for an UE that has performed intra-enb handover. The problem resulted from the fact that the ue configuration in the scheduler not accounting for removed cells. 4 years ago
Francisco Paisana 8a5a571045 bug fix - in case of intra-enb Handover, the eNB was not adding SCells in the HO command 4 years ago
Francisco Paisana 4383796393 add scells in case of intra-enb handover 4 years ago
Francisco Paisana 688dda30a4 favour carriers with best channel conditions for UL grants due to SRs 4 years ago
Pedro Alvarez 2f0125ef4e Fix issue recovering key state, when the first HO fails (specifically, is_first_ncc was not recovered). Minor improvements in key logging. 4 years ago
Francisco Paisana 137e554eb3 reestablish pdcp bearers is required in case of AM bearers 4 years ago
Francisco Paisana 4c88404801 fix measurement report handling in case of intra enb handover 4 years ago
Francisco Paisana 4b1626bf24 fix eutra packing recovering during reestablishment in the srsenb 4 years ago
faluco dfeed52514 - Rename out_stream function to console. 4 years ago
faluco 62faef7c71 - Replaced all uses of the log::console method. 4 years ago
Francisco Paisana 942c28881d converted member method of list of cells in the enb to a free function 4 years ago
Francisco Paisana 3a924a1d80 avoid sending cellsToAddModList if cell offsets are zero 4 years ago
Francisco Paisana da70c0fdaf fix cellsToAddModList handling. Now the eNB always adds PCell+SCells as measObjects in the RRC Reconfiguration messages. It may also further include cellsToAddModList if they are provided in the rr.conf file 4 years ago
Francisco Paisana 89eeb5a355 use utility methods to find meas objs based on earfcn 4 years ago
Francisco Paisana 141960fbda remove unnecessary shared_ptrs and use value semantics instead for the var_meas_cfg of the different enb cells 4 years ago
Francisco Paisana 098172c911 fix cellIndex assignment in srsENB to not necessarily copy cell ID 4 years ago
Francisco Paisana dcf5a727f2 do not send RRC release in case the eNB receives a S1AP UEContextRelease command and the UE is doing handover. Handle GTPU end marker 4 years ago
Francisco Paisana 13a5bfb525 - fix reestablishment reject transmission in the srsenb. For SRB0 SDUs, no RLC header is required, so we do not need to check in such case if there is enough space in the TB for the header.
- fix srsenb reestablishment check for UE context. The pci has to be accounted for the srsenb to understand that the UE trying to do reestablishment corresponds to one of its own
4 years ago
Xavier Arteaga 3e6c337b44 SRSENB: protect MAC softbuffers access
SRSENB: fix retransmissions
4 years ago
Andre Puschmann 49655cd33c enb,s1ap: only log info in the s1ap connection procedure
the event is logged as error by the calling function already
4 years ago
Francisco Paisana 7e6487b6fa perform PUCCH+PRACH PRB reservation right at the start of a new TTI in the scheduler 4 years ago
Andre Puschmann d30822784f enb: refactor MAC PDU logging
* remove single line MAC PDU subheader logging in favor
  of to_string() helper that prints entire MAC header in single line
* log MAC PDU after parsing and packing
4 years ago
Ismael Gomez 59b6301cc8 Remove legacy arbritrary 1s timeout for eNB requests 4 years ago
Pedro Alvarez b59eca1b27 Wait until reestablish complete is finished to swap rnti in s1ap and gtpu. 4 years ago
Pedro Alvarez 6ec26ea627 Make sure that last_submitted_rx_sn is not 0 after handover. 4 years ago
Andre Puschmann 655c7ae8ae enb: fix warning when removing user
when removing a user from the eNB we iterated over all possible LCIDs
and set the buffer state to zero in the scheduler.

this resulted in following log entries:

13:57:23.856334 [RRC ] [I] Received Release Complete rnti=0x46
13:57:23.856352 [MAC ] [W] [ 5149] The provided lcid=6 is not valid
13:57:23.856362 [MAC ] [W] [ 5149] The provided lcid=7 is not valid
13:57:23.856368 [MAC ] [W] [ 5149] The provided lcid=8 is not valid
13:57:23.856371 [MAC ] [W] [ 5149] The provided lcid=9 is not valid
13:57:23.856376 [MAC ] [W] [ 5149] The provided lcid=10 is not valid

we now check if the bearer exits at RLC and only report those to the MAC.
4 years ago
Ismael Gomez 38e2ffe414 Use Format1A when using CA and 15 PRB due to DCI size ambiguity 4 years ago
Xavier Arteaga f14e699df4 SRSENB: fix MAC UE DB Read protection 4 years ago
Ismael Gomez 0afcea9d61
Do not allow empty TBS PUSCH. Account for CQI from inactive cells before activated. (#1667) 4 years ago
Francisco Paisana fddcc3d8ea In the case of Handover, postpone the activation of the CQI and SR config present in the HO command for after the RA proc completion to the target eNB 4 years ago
Francisco Paisana 8a651c972e add scells to ho cmd 4 years ago
Francisco Paisana 13caf287f9 fix S1 Handover with UE CA. The HandoverPreparation message was not being filled correctly 4 years ago
Ismael Gomez a4835dd2c8
More accurate MCS reduction when PUSCH carries UCI (#1630) 4 years ago
Francisco Paisana cc469fc7a3 fix reestablishment after S1 handover by setting ncc accordingly 4 years ago
Francisco Paisana b47f8e6c1a increased rrc inactivity timer to avoid unnecessary pagings while
setting up an initial enb-ue iperf connection
4 years ago
Matt Johnson e9eab89a6b srsenb/rrc: Avoid crash when CSFB requested but sib7 not configured
This commit addresses an issue where if a UE requests a release for
circuit switched fallback, but the sib7 carrier freqs info list is not
configured, the eNodeB would crash with a segfault due to attempting
to access an element from an empty list. This commit adds explicit
checking to handle the empty list case. If the list is empty, no
redirect carrier info is added to the connection release message and
the UE must scan for the fallback network itself.
4 years ago
Francisco Paisana 0036941af4 added extra state to S1 target enb mobility FSM. Accounts for out-of-order arrival of MMEStatusTransfer. Also, now we avoid creating DRBs before the MMEStatusTransfer 4 years ago
Andre Puschmann 5e40bfe72c mac_pdu: unpack and print BSR index as well as BSR value in bytes
before the BSR was extracted but the actual index (between 0 and 63)
was not stored but directly converted into bytes.

for log parsing and debugging it is easier to follow the index
value. this patch therefore adds both values to the log message
and extends the API accordingly.
4 years ago
Francisco Paisana bb5dd92dca implemented s1 handover cancellation procedure to force the target enb to release the ue ctxt 4 years ago
Francisco Paisana 8c9e596f89 refactored s1ap handover request interface. cleaned up rrc tenb s1 handover code 4 years ago
Francisco Paisana b6baf1a098 fix mobility warnings and s1 handover required message preparation 4 years ago
Andre Puschmann 8e631131c0 s1ap: fix uint64_t printf for 32bit machines 4 years ago
Francisco Paisana 7cd4f45d62 fsm refactor.
- avoid triggering directly a subfsm
- improved metafunctions
- other cleanups
4 years ago
Francisco Paisana 42e8453c00 fix security key setup for s1 handover 4 years ago
Francisco Paisana 083344579e fix s1 ho configuration of ue capabilities and security capabilities 4 years ago
Francisco Paisana 5d1343fe75 implemented S1 bearer status transfer 4 years ago
Francisco Paisana db8af399f8 extended rrc tenb s1 handover test. implemented layer reconfig during s1 handover 4 years ago
Francisco Paisana 7605c7df23 added s1ap handover notification, fixed s1ap asn1 bug, and fixed bad fields for admitted erabs in ho req ack 4 years ago
Francisco Paisana 9146e6ddf1 change method name to resize intervals 4 years ago
Francisco Paisana 4457bbda7e added new asserts to interval interface 4 years ago
Francisco Paisana 8b174ce2f4 changed interval interface to disallow interval::stop < interval::start via an assertion 4 years ago
Francisco Paisana c1755727d7 changed interval method names, and added comments and assertions 4 years ago
Francisco Paisana 20b69fb22e substitution of ul_alloc_t for prb_interval 4 years ago
Francisco Paisana 3eb1b83a43 updated allocate crnti method in mac to accoutn for new phy interface 4 years ago
Francisco Paisana 26f46ea067 add S1 Handover Request handling in target eNB 4 years ago
Ismael Gomez 382811e10e
Update S1AP RNTI context when doing Reestablishment (#1582) 4 years ago
Francisco Paisana a6c3144d92 remove extra byte from rrc dl_dcch and dl_ccch messages 4 years ago
Xavier Arteaga a1a58507c1 SRSENB: Added eNb CC index to PRACH log trace 4 years ago
Ismael Gomez dda91b14f7 Remove duplicate add_rnti() function since already done in set_config 4 years ago
Francisco Paisana b50f70e420 check if cqi is pending in all carriers to decide whether mcs needs to be reduced in PUSCH 4 years ago
Francisco Paisana 3f439cc947 account for current cqi config struct update in scheduler interface 4 years ago
Francisco Paisana 35fa5346b9 only reduce mcs if the current tti requires uci 4 years ago
Francisco Paisana 58c4bcf288 reduce mcs for UL grants carrying UCI 4 years ago
Xavier Arteaga 0192130742 SRSUE/SRSENB: UCI bits are carrier by the lowest serving cell index
SRSENB: Fix UCI in lowest serving cell index PUSCH transmission
4 years ago
Andre Puschmann a7911f0dab pdcp,rlc: refactor SDU queueing policy
this patch refactors the SDU queuing and dropping policy of the RLC and PDCP layer.
the previous design had issues when packets have been generated at a higher
rate above the PDCP than they could be consumed below the RLC.

When the RLC SDU queues were full, we allowed two policies, one to block on the write
and the other to drop the SDU. Both options are not ideal because they either
lead to a blocking stack thread or to lost PDCP PDUs.

To avoid this, this patch makes the following changes:

* PDCP monitors RLC's SDU queue and drops packets on its north-bound SAP if queues are full
  * a new method sdu_queue_is_full() has been added to the RLC interface for PDCP
* remove blocking write from pdcp and rlc write_sdu() interface
  * all writes into queues need to be non-blocking
  * if Tx queues are overflowing, SDUs are dropped above PDCP, not RLC
* log warning if RLC still needs to drop SDUs
  * this case should be avoided with the monitoring mechanism
4 years ago
Xavier Arteaga f39abe0094 SRSENB: fix MAC pending PHY config 4 years ago
Francisco Paisana 5e06430455 removal of stack handler interface 4 years ago
Francisco Paisana 7c364070ee creation of task scheduler interface for classes/functions running outside the main control thread 4 years ago
Francisco Paisana 039977aeb5 renamed interfaces 4 years ago
Francisco Paisana 1a9c04bf2f use of task scheduler handle in pdcp 4 years ago
Francisco Paisana e9f34c7613 using task scheduler in enb stack 4 years ago
Francisco Paisana 4f5e65781f created task scheduler class to deal with timers, thread pool, multiqueue, internal tasks 4 years ago
Pedro Alvarez 89b6e0f714 Send paging message to all cells. 4 years ago
Francisco Paisana fe8f8be62d apply separate cqi configurations to scells 4 years ago
Francisco Paisana e550bf726d updated fsm to allow enter methods to receive event that caused them 4 years ago
Francisco Paisana 504e3a1b7a fix max retx configuration in scheduler and updated tester to catch the error 4 years ago
Andre Puschmann 4c667bd478 rrc_ue: improve logging of CA activation
* check Pcell has configured Scells when entering function
* log if UE doesn't support CA (only if scells are configured)
* log info about CA activation only after all checks have passed
* fix typo
4 years ago
Pedro Alvarez 5ed6c18ac7 Copy E-UTRA capabilities to new RNTI in reestablishment. 4 years ago
Francisco Paisana d7a0fe4060 improve log messages for CA 4 years ago
Francisco Paisana 1899c468d3 updated rrc mobility test 4 years ago
Francisco Paisana 97d20ca579 remove obsolete bearer cfg methods 4 years ago
Francisco Paisana 0929a9de62 created rrc mac_controller class to handle the configuration of scheduler 4 years ago
Francisco Paisana 7ab4b5f723 fix long bsr handling 4 years ago
Francisco Paisana af58597647 fix mac tb building in scheduler 4 years ago
Francisco Paisana cb7f620254 created separate class to manage bearers buffers/status reports in the scheduler 4 years ago
Pedro Alvarez 45b8392a4c Added user warning to invalid configuration of RRC inactivity timer. 4 years ago
Pedro Alvarez 8e00febb1d srsENB: Derive inactivity timeout from T310 and T311 and N310. 4 years ago
Francisco Paisana 2cb80f9bf3 remove rnti in mac/phy in staged manner. First the "upper mac", and then the "lower mac" and phy 4 years ago
Ismael Gomez 493b7ea2da Remove SNR threshold based link failure detection 4 years ago
Francisco Paisana ced1afdbe7 check supported band combination r10 to determine if a UE supports CA 4 years ago
Francisco Paisana 790b32f6f5 fix CA ue category check 4 years ago
Francisco Paisana 2de702f50e disable carrier aggregation when ue release is below 10 or category is below 5 4 years ago
Xavier Arteaga 31d7124ae7 SRSENB: Added initial PUCCH format 3 default for more than 2 serving cells 4 years ago
Francisco Paisana e6ef201cb0 disable warning when there is no space in the scheduler PDCCH 4 years ago
Francisco Paisana 535d4b70f3 avoid capturing callback parameters by reference to avoid dangling pointers 4 years ago
Francisco Paisana 42969ad992 add tb size as argument to gnb 4 years ago
Francisco Paisana f0874b780b add radio_base/null classes 4 years ago
Pedro Alvarez 9c1a7d2cf1 Removed get_bearer_status in PDCP. Renamed get_state/set_state to
get_bearer_state/set_bearer_state.
4 years ago
Pedro Alvarez 208a539499 Split PDCP tx_count state variable into tx_hfn and next_pdcp_tx_sn
variables.
4 years ago
Pedro Alvarez fb088a8c54 Restoring PDCP state only when using RLC AM. 4 years ago
Pedro Alvarez 66d4f320e5 Added intereface to set PDCP state after reestablishment. 4 years ago
Pedro Alvarez 217f16d137 Getting PDCP state on re-establishment. 4 years ago
Pedro Alvarez 33567d81db Added interface to get internal PDCP state. 4 years ago
Andre Puschmann e2146e90ad enb: remove usleep after sending RRC Connection Release to UE
this cause a "dead-lock" with ZMQ because it made the stack
thread sleep for 50ms. With a sync-queue size of 1 (now the default
using ZMQ) the zmq-based radio to timeout. as a result
the rx/tx between UE and eNB stopped so the UE never reached
RRC Idle state.
4 years ago
Francisco Paisana cd0202aeaf use alternative method for conres CE scheduling 4 years ago
Francisco Paisana df1f8836b1 fix issue #1418 by changing the ConRes CE scheduling mechanism 4 years ago
Andre Puschmann 06d31f46ba enb: set maximum allowed TTI difference between PHY and Stack TTI clocks for ZMQ
this fixes the issue where PHY and MAC threads, and the processing
of events therein, are drifting apart too much.

This patch effectivly enforces a strong wait on the PHY if the
stack thread is too slow in processing its tasks.

For RF hardware the default is still 8192 TTIs, for ZMQ 1 TTI is used.
4 years ago
Andre Puschmann a1d64c1efe enb: improve error message when RAR cannot be sent 4 years ago
Francisco Paisana 3c2e3dbdbf added latest mac nr updates 4 years ago
Francisco Paisana 6509399ed3 fix for move-only events 4 years ago
Francisco Paisana 611a1c667f remove the requirement that pusch grant for uci data being a newtx 4 years ago
Francisco Paisana 1393bd11fa avoid using PUCCH for SCell DL allocations 4 years ago
Francisco Paisana d859c33035 added check for UCI collision during DL scheduling for CA 4 years ago
Francisco Paisana 53b85691b5 moved sf result to sched class. This way each carrier has a view to the results of the remaining carriers in the same subframe 4 years ago
Francisco Paisana 5d33acdb53 changed name of sched_ue_carrier class 4 years ago
Ismael Gomez 60b5fb9a74 Refactor variable name 4 years ago
Pedro Alvarez 9df40c3af0 Added debug GTPU print. 4 years ago
Francisco Paisana 857c4de420 extended handover test to check for correct SR/CQI resource setup 4 years ago
Francisco Paisana 7ce23e0afb extend handover intraenb handover fsm to account for multiple C-RNTI CEs 4 years ago
Francisco Paisana b843585abc add srsgnb stack class 4 years ago
Francisco Paisana f5174415f8 add srsenb::sdap class 4 years ago
Francisco Paisana 613003ac53 add srsenb::rrc class 4 years ago
Francisco Paisana 0916e29de4 add srsenb::rlc_nr class 4 years ago
Francisco Paisana 9001117b2d add srsenb::pdcp_nr class 4 years ago
Francisco Paisana 6908e0fab1 disabled all UL in the MAC during handover, including scheduling requests 4 years ago
Pedro Alvarez 960c0e97cd Added handling of RRC re-establishment to srsENB.
* Added the appropriate code for handling and sending the
   re-establishment procedure messages to rrc_ue.c/.h.
 * Triggered RRC reconfiguration after the reception of RRC
   re-establishment complete
 * Refreshed K_eNB at the reception of re-establishment
   request
 * Changed the mapping of TEIDs to RNTIs in the GTP-U layer,
   as the RNTI might change with reestablishment.
5 years ago
Francisco Paisana 452c043370 created a global map of lcids to srbs/drbs for NR 5 years ago
Francisco Paisana 6a164e032d added srsue::rrc_nr 5 years ago
Francisco Paisana 43635c3fa1 added cqi cfg to handover command 5 years ago
Francisco Paisana 026628a84f use of reestablishment method to reset the RLC bearers during handover 5 years ago
Francisco Paisana 9a0ea6e08c use log_helper for log macros 5 years ago
Francisco Paisana edba7f57e4 corrected mac_nr_pdu includes 5 years ago
Francisco Paisana d7b35ba7d1 added nr mac 5 years ago
Andre Puschmann a0e4b18507 enb_mac: pre-allocate UE object for quicker PRACH/RAR handling
we've seen long delays in handling PRACH on low-power devices
such as the RPi4. This was mainly caused by long delays
in creating the UE object on the fly during PRACH handling.

This patch pre-allocates one UE object that is then used
during the PRACH.
5 years ago
Ismael Gomez 270c7ce9dc Separate PHY interface to add rnti and pregenerate sequences. Calculate the sequences on the reception of ConnectionSetup instead of PRACH 5 years ago
Francisco Paisana d36ae722d5 added extra debug logs 5 years ago
Ismael Gomez a1f0f8de35
Add callback to RLC to indicate BSR for TX and reTX queues (used in ENB) (#1361) 5 years ago
Francisco Paisana 860174a819 remove comment and changed handover_type enum 5 years ago
Francisco Paisana b37923312e added intraenb handover fsm and respective test 5 years ago
Francisco Paisana 65ef16c7f1 void sending rrc connection release as msg4 5 years ago
Francisco Paisana 61680d64d7 move rrc::ue to separate file 5 years ago
Francisco Paisana 7713df2cf9 fix fixed mcs issue 5 years ago
Pedro Alvarez 51f8ba60da Make MBMS MCS configurable for the eNB. 5 years ago
Francisco Paisana 04961148e9 removed old code to compute meas obj diffs 5 years ago
Francisco Paisana b8339031f6 updated code for crnti update during handover and reset of the mac 5 years ago
Francisco Paisana 45cd893e21 update handover test 5 years ago
Francisco Paisana e8aff22e1b using new rrc obj id util methods in handover code 5 years ago
Francisco Paisana f43985b6cd small updates for testing handover and configuring the rrc 5 years ago
Francisco Paisana f2af447b1a use of unique_byte_buffer for sib scheduling to allow for padding 5 years ago
Francisco Paisana 598bad1f0e changed rrc ue cfg files names 5 years ago
Francisco Paisana ea5ba93f25 changed file names 5 years ago
Francisco Paisana ad03d7caf7 move position of security cfg 5 years ago
Francisco Paisana d43448e8a1 created security cfg handling class for rrc ue and refactor bearer_list handling 5 years ago
Francisco Paisana 09cafaa4bb update ded_info_nas_list handling 5 years ago
Francisco Paisana 2e4e22dc68 revert clang-format change 5 years ago
Francisco Paisana 1ac91f2f93 updated erab_setup_test 5 years ago
Francisco Paisana 0515229240 perform mac bearer addiction via the bearer handler class 5 years ago
Francisco Paisana 6bcb5910c9 usage of new bearer list cfg class for srb1/srb2 setup 5 years ago
Francisco Paisana ca0db7fffe created generic methods to apply toaddmodlist and removelists. 5 years ago
Francisco Paisana c65c081b51 created separate files to handle rrc bearers 5 years ago
Francisco Paisana dbcaec6689 avoid dangling reference 5 years ago
Francisco Paisana 71520d681a changes in pucch res allocation api to allow replacing p/scells 5 years ago
Andre Puschmann c892ae56be rrc_cell_cfg: fix potential div by zero
similar fix has been applied for SR resources
5 years ago
Andre Puschmann 248e2b5f7e rrc: fix potential division by zero 5 years ago
yagoda 210eae8e7e fixing small rr.conf config error 5 years ago
Francisco Paisana aab989022d avoid forward declarations 5 years ago
Francisco Paisana 08e1f01c72 allocation of the sr/cqi/pucch_cs resources takes place at a frequency basis now 5 years ago
Francisco Paisana ee994468f7 separate sr and pucch_cs allocation from rrc class 5 years ago
Francisco Paisana b16c7c1cfa created separate cqi res allocation types 5 years ago
Francisco Paisana 4b525127c9 created separate cell ctxt common list 5 years ago
Francisco Paisana 3c29bce014 apply segmentation break check to newtxs only. Allow configurable cqi 5 years ago
Francisco Paisana c75e31db03 added random cqi to sched tester 5 years ago
Francisco Paisana 500a7f6357 created new separate ue class in sched tester to handle acks and harq tests 5 years ago
Pedro Alvarez 2ea78c8feb Added configuration options for stack logging. 5 years ago
yagoda 3f99e40159 -changing rlc so that mrb is never removed when going to idle
-adding metric counting to eMBMS MAC so that the count is not lost during eMBMS subframes
5 years ago
yagoda 94f62b54ad fixing some bugs in embms with new stack and cc scheduler in enodeb 5 years ago
Francisco Paisana b69b274c63 comment removed 5 years ago
Francisco Paisana 6f02c067b3 fix cell ptr assignment 5 years ago
Francisco Paisana 5ef6031b44 added ability to use single-carrier if we are unable to allocate resources for the scells 5 years ago
Francisco Paisana 439193e4b0 added code to handle fail to alloc ue cqi and sr 5 years ago
Francisco Paisana de4d58d8fe fix coverity scan issues in master 5 years ago
Ismael Gomez 485771749e Allocate Scell resources when creating it rather than at UE creation 5 years ago
Ismael Gomez c0054140e9 Configure properly PUCCH CS mode for CA in ConnectionReconfiguration. Allocate n_pucch_cs resource and cqi/sr at rrc::ue constructor 5 years ago
Francisco Paisana 0fc36d44d7 disable handover altogether to avoid crash 5 years ago
Francisco Paisana b8e6ba02e4 remove warnings related to unused vars and fwd declarations with trivial dtors 5 years ago
Xavier Arteaga d7e7399e7b srsENB: PHY configuration in two stages 5 years ago
Xavier Arteaga 1bbf1caabc Reverted PUCCH3 default CA DL HARQ method 5 years ago
Xavier Arteaga a59884a14a SRSENB: configure PUCCH3 as default HARQ feedback for CA 5 years ago
yagoda 8e0b106c22 fixing some warnings from LGTM 5 years ago
Pedro Alvarez 218531b418 Making sure the eNB only sends S1AP context release requests if it has a MME-UE-S1AP-ID assigned. 5 years ago
Jason Tang 7b7308ac1b Fix CSFB 5 years ago
jmasterfunk84 7f51fcb419 Update s1ap.cc 5 years ago
Francisco Paisana b506e29b72 removed common ce_typeenum 5 years ago
Francisco Paisana 372126deac created ul-sch and mch lcid types 5 years ago
Francisco Paisana 367a190829 created dl-sch lcid type 5 years ago
Pedro Alvarez ad0abe740b Added support to PDCP SN len of 7. Also added a check for valid configs in pdcp entity. 5 years ago
Francisco Paisana 7a132f9ccd more enb interface comments 5 years ago
Francisco Paisana 0526ae8ab1 updated rrc mobility parsing. added some utility methods 5 years ago
Francisco Paisana 20f6655c6b use common method to build mac pdu. allow CE allocations in dci format2/2a 5 years ago
Francisco Paisana 64557740fc use mac_buffer_state interface to schedule CEs in scheduler 5 years ago
Francisco Paisana ec94819f08 changed mechanism for conres ce scheduling to be controlled by rrc 5 years ago
Francisco Paisana 66a38f53f5 fix req_bytes methods to account for new method to calculate conres scheduling. 5 years ago
Francisco Paisana d716d8bf7e use mini state machine for ConRes CE scheduling instead of relying that there is data in the DL buffer 5 years ago
Francisco Paisana 6de7b644ec schedule conres ce when pcell changes 5 years ago
Francisco Paisana d183d64409 added allocate_rnti method to mac. Useful both during PRACH and handover UE resource allocation 5 years ago
Francisco Paisana 6ddedd5972 moved pdu to common mac folder 5 years ago
Pedro Alvarez 882a610504 Fix mistake in adding dedicated DRB to scheduler. 5 years ago
Pedro Alvarez b176eef8e7 Using a single map to store erab_info messages. 5 years ago
Pedro Alvarez 84b012051c Added ability to reconfigure more than one DRB in the eNB RRC reconfiguration. 5 years ago
Pedro Alvarez 9b60d7977e Make sure that the NAS buffers for multiple erabs are initialized. 5 years ago
Pedro Alvarez cc2b474754 Starting to add array of erab_info messages. 5 years ago
Pedro Alvarez f872e6ec39 Marking nas_pending a vector to support multiple erab setup on sending RRC reconf. 5 years ago
Francisco Paisana ca7e667a22 small fix in list size check 5 years ago
Francisco Paisana 4d0068243b fixing scell activation in the enb rrc 5 years ago
Francisco Paisana c09f76ed6c unified stack task defer method 5 years ago
Xavier Arteaga 5b7493cab5 Added 256QAM modulation tables to scheduler 5 years ago
Xavier Arteaga a4225b189b SRSENB: Added initial UE capability parser 5 years ago
Xavier Arteaga 8b265883e4 SRSENB: UL TA measurement waits for a start order before start measuring 5 years ago
Andre Puschmann b994255b35 enb: fix handling of GTPU and S1AP init return values
if the eNB stack startup fails, for example due to binding
the wrong GTPU socket or similar issues, the eNB should stop
and log a message. Previously the return values for
S1AP and GTPU init were not even evaluated.
5 years ago
Ismael Gomez 425c70c8d7 Fix CQI scheduling allocation for CA 5 years ago
Ismael Gomez 0841ec510c Fix deadlock when UE disconnected due to incorrect use of rwlock 5 years ago
Francisco Paisana 26211f12bd add warning when space in pdcch cannot be found 5 years ago
Francisco Paisana 40da4495ce do a loop in rrc::tti_clock() to process all pending events 5 years ago
Francisco Paisana 076aa6b1f8 fix mobility test for when the eutra_capability is received 5 years ago
Francisco Paisana 179e959d05 fix msg3 retx issue. Now nof_prb for pucch above 1 are forbidden for prb==6 5 years ago
Francisco Paisana c661025cda fix log tti, and print a warning when the ul_harq tti does not match existing ones 5 years ago
Francisco Paisana 30ae2226c1 common interface for stack multiqueue tasks, background tasks and timers 5 years ago
Andre Puschmann 62e4bd9469 log_ptr: fix issue if accessing log_ptr that was reset already
during deinit of the UE/eNB it could happen that the log_ptr
was already set to null but the stack thread was still accessing
it through log_h->info()

i've moved the old macro into a new header and used as as much
as possible. there are still places in the code where similar
macros are used but we would need to change the variable name
to replace them
5 years ago
Pedro Alvarez 88f56721ee Fix issue where connection was still setup when no EPC was connected. 5 years ago
Francisco Paisana 344eaf49ec use logmap in the whole enb and ue 5 years ago
Ismael Gomez 9a264b62c4
Protect access to shared grants (#1117)
* Protect access to shared grants

* Set correct number of carriers for DL

* Fix previous issues

* Address comments
5 years ago
Francisco Paisana 4baeee10c5 avoid dangerous [] map operator 5 years ago
Francisco Paisana 1839b9a6e5 cleaned up paging code to avoid extra processing steps in worker threads 5 years ago
Francisco Paisana 9c028ab723 removed user_mutex from srsenb::rrc. All that needed to happen was the prach_worker calling add_user from stack thread (done in an earlier PR), and the get_metrics run in the stack thread. I achieved the latter with an extra metrics queue 5 years ago
Ismael Gomez c157a37894 Address comments 5 years ago
Ismael Gomez 7a7385d0e5 Support multiple carriers for common buffers (RAR/BCCH/PCCH) 5 years ago
Francisco Paisana a2866f661b made the number of ue payload allocations proportional to number of active carriers. Made mac::ue_db use unique_ptrs 5 years ago
Francisco Paisana 8772d8f85c use byte buffer pool for the ue tx_payload_buffer allocation. This halves the mac::ue object creation time 5 years ago
Andre Puschmann dff00c77c0 srsenb: fix mobility test after adding UE cap enquiry 5 years ago
Andre Puschmann ce45aabfec srsenb: enable UE capability enquiry during attach
the UE capability information isn't used so far but can now
be analyzed in the PCAP
5 years ago
Francisco Paisana 82cb6baef0 now the whole ue and enb mac uses the logmap 5 years ago
Ismael Gomez 5846e64a4d
Deallocate all CQI resources when deallocating users (#1097) 5 years ago
Francisco Paisana fb967d17a2 now we can disable tprofs individually 5 years ago
Francisco Paisana deb76d5dbd improved design to avoid data structures, and allow guarded start/stop even in lambdas 5 years ago
Francisco Paisana 8a54aef89d created a better/more composable design for time measures 5 years ago
Francisco Paisana eb20f651b9 account for all exit points 5 years ago
Francisco Paisana 854211496b redesign of tprof for thread safety 5 years ago
Francisco Paisana 269c852767 created a class for time profiling. An object of such class, if disabled, has almost zero overhead. Added a compile-time flag to turn on/off time profiling 5 years ago
Francisco Paisana 807d177b47 fix hanging issue, and simplified the handling of minRBG for different CFIs 5 years ago
Francisco Paisana ede09cb9b2 added dynamic CFI capability to the eNB scheduler 5 years ago
Xavier Arteaga ada8772f57 Initial srenb TA compensation 5 years ago
Ismael Gomez cf4f4508ce Normalize throughput in CSV/stdout metrics with respect to number of TTIs 5 years ago
Ismael Gomez 858165f177
Allocate a different PDU buffer for each carrier in MAC eNodeB (#1069) 5 years ago
Ismael Gomez 73447972d8
Fix issue with simultaneous CQI and ACK/NACK transmission in CA (#1067)
* Fix memory corruption when phy calling mac scheduler and not yet initiated

* Do not drop CQI if collision with ACK/NACK and PUSCH

* Allocate CQI resources for SCell properly

* Use UE_PCELL_CC_IDX macro

* Protect ul_sched from being called if not yet started
5 years ago
Xavier Arteaga e832769ae6 Updated copyright 5 years ago
Francisco Paisana 5330249625 created tti_point type and unit test. Added also the tti_point to the scheduler harqs, and rrc procedure 5 years ago
Francisco Paisana e824cbd251 fixes in the mac log and cell parsing 5 years ago
Andre Puschmann 1099e75e7c fix SCell carrier list population for MAC config
the issue caused to assign 0 as enb_cc_idx for the first SCell always
5 years ago
Francisco Paisana 567790c1a2 Renamed struct to store cell context in rrc. Moved sib buffers to this struct. Created helper methods for lookup 5 years ago
Francisco Paisana fe3195bb27 add default pcell to ue_cfg in RRC 5 years ago
Francisco Paisana 349aed5e0d use sib configuration to set SCellToAddModList 5 years ago
Francisco Paisana 4217dba7e0 fix msg3 delayed allocation and update test 5 years ago
Andre Puschmann 074ffbbb1d remove braces and reformat code 5 years ago
Andre Puschmann f14697cdaa schedule PMI for SCells right after PCell, disable SRS for SCells 5 years ago
Andre Puschmann fdb7b0fa41 fix simple typo 5 years ago
Andre Puschmann c534ee2b55 fix SCell packing in RRC reconfig 5 years ago
Andre Puschmann 0e4f97d1a0 fix bug in MAC where new PHY RNTI was always registered for enb_cc_idx==0 5 years ago
Andre Puschmann ab210c5f3c tiny cosmetic changes to the error messages printing 0x and clear cc_idx use 5 years ago
Andre Puschmann b7aad27d86 move packing of SCell list into extra method and add fill PHY config on the spot
previously we've packed the RRCReconfig with SCellToAddMod list and have then
parsed the message again to pack the PHY config dedicated for the new SCell carrier. This
is now done in one step.
5 years ago
Francisco Paisana d18b476e37 use utility macro for printing function name 5 years ago
yagoda f09c8324eb adding success/error macros in scheduler.cc 5 years ago
yagoda bfa451559b adding error logs to some scheduler function calls to ue_db to add clarity 5 years ago
Francisco Paisana 9b4a0baa87 activate scells in the phy 5 years ago
Francisco Paisana 7548402632 change scell activation interface to use arrays. Added a method to the scheduler to get the current set of activated carriers 5 years ago
Xavier Arteaga 76408b195e Rename TX_DELAY and FDD_HARQ_DELAY_MS 5 years ago
Andre Puschmann a8acd235f6 extend eNB MAC to support multiple CC per UE
- add tx/rx softbuffers for each CC that a UE might have
- make sure to call assign correct buffers when iterating
  over the CC for UL/DL grant assignment
5 years ago
Pedro Alvarez 96c82b3fc6 Moved PDCP configs to pdcp_config.h. Added `as_security_cfg_t` structure to hold access stratum keys.
Refactored PDCP, RRC and USIM accordingly.
5 years ago
Francisco Paisana dc8dca2a08 fix namespace-related compilation error 5 years ago
Francisco Paisana a744729007 use range of rbgs 5 years ago
Francisco Paisana 46579da1ff use signed integer to express the error 5 years ago
Francisco Paisana 9ad80ee29f added initial_dl_cqi to the enb rr.cfg parser 5 years ago
Francisco Paisana bcbb08ebae use initial_dl_cqi for first DL tx. 5 years ago
Francisco Paisana 3b937348a2 refactored some sched util methods 5 years ago
Francisco Paisana fad897cb35 DL scheduler metric now takes into account the min and max of RBGs possible. This is to forbid segmentation of SRB0 allocations 5 years ago
Francisco Paisana 6317750de2 fix computation of ranged of allowed sched dl bytes 5 years ago
Francisco Paisana 414259e83b fix allocation expected alloc bytes (min and max) 5 years ago
Francisco Paisana 698899d309 added scells to enb rrc reconf message 5 years ago
Andre Puschmann f2e1bfa699 refactor naming for s/p/cell structs and {enb,ue}_cc_idx 5 years ago
Francisco Paisana 639f473042 fixed unsigned signed comparison 5 years ago
Francisco Paisana 1e63fa41cf made ue_cc_idx int to set to -1 for rar and bc allocs 5 years ago
Francisco Paisana f3c3c52fcd added ue_cc_idx to dci allocation 5 years ago
Francisco Paisana e62972d38e fix fdd delays in scheduler 5 years ago
Pedro Alvarez 08a4ce0970 Added the ability to save S1AP pcaps at the eNB. 5 years ago
Andre Puschmann 2edecea33e fix SIB transmission for CA
Avoid double buffering of SIBs in MAC as this would require one buffer for each CC.
Instead, use byte_buffer managed by RRC that contains packed SIBs to avoid
double memcpy for each SIB tx. Only use MAC provided buffer in error case.

Also avoid MAC calling RLC for each SIB and call RRC directly.
5 years ago
Pau Espin Pedrol 91a5d1a74e gtpu: Log bind failure cause 5 years ago
Andre Puschmann 120ad76c63 refactor cell param handling and fix SIB transmissions
- move cell specific eNB params to cell list in rr.conf
- make sure DL EARFCN and DL freq can be used to manually overwrite a single cell config
- fix SIB packing and transmission for multi cell configs
- introduce cell list to MAC
- adapt default enb.conf.example and rr.conf.example
5 years ago
Xavier Arteaga da701cd82b SRSENB: Added PUSCH TA and EVM measurement. Some more PHY cleanup. 5 years ago
Pedro Alvarez bd3598f774 Moved srsEPC to the new S1AP library. Deleted liblte_s1ap.cc and liblte_s1ap.h. 5 years ago
Francisco Paisana ec1f1cc677 remove const_casts from scheduler. Fix ODR issue 5 years ago
Francisco Paisana e9a599857a created a header for all common structs and helper functions 5 years ago
Francisco Paisana 02ccb8b32b fix wrong calculation of sched tx and rx delays 5 years ago
Andre Puschmann 73c8b02820 enb: loop over CC in MAC 5 years ago
Andre Puschmann 664170fec6 pcap: add CC index when writing PCAP 5 years ago
Francisco Paisana 43e67b8536 created a harq entity that handles all harq procs. This entity accepts as arg the number of harq procs. 5 years ago
Francisco Paisana 1c041b2c1d created harq entity class 5 years ago
Francisco Paisana 9f266161cf increase tbs until allocation is big enough to fit MAC subheader and RLC header 5 years ago
Francisco Paisana 7e840bde86 fix tb idx assignment in scheduler mac sdu alloc 5 years ago
Francisco Paisana d1356568e0 separated sf sched result from sf_sched class. The interface became way simpler. No need for finish_tti() method, sf_sched::new_tti() is called automatically when we access the sf_sched. 5 years ago
Francisco Paisana bb38fa7119 fixed tti resetting after tti end 5 years ago
Francisco Paisana 47b05118ad simplified msg3 allocation. Now we can allocate resources ahead of time (e.g. msg3 is 2 ttis ahead) using the sf_sched interface. It's guaranteed that the given allocations wont be erased when the respective tti starts 5 years ago
Francisco Paisana 8f7890c60a store mask results in separate variables for testing, and reset sf_sched state at the end of the tti 5 years ago
Pedro Alvarez afc209711c Fix jump depending on uninitialized variable in srsenb::sched_ue::set_bearer_cfg_unlocked 5 years ago
Francisco Paisana 5bdc603113 added error macros 5 years ago
Francisco Paisana b37d9b9930 fixed msg4 setting in sched tester 5 years ago
Francisco Paisana 3cc94c3694 simplified mutexing of the scheduler. One single mutex for everything, and removed rwlock 5 years ago
Francisco Paisana 7210c35c6c checked all methods of srsenb::pdcp to see if they are called by different threads. Since it is all single-threaded, I removed the locks 5 years ago
Francisco Paisana fed06138b9 moved rach_detected to stack thread. Created a more friendly interface to enqueue tasks in stack 5 years ago
Francisco Paisana d10e950650 fix ue streamid assignment in s1ap 5 years ago
Andre Puschmann 8b46f631c1 add basic TTI stats in stack 5 years ago
Francisco Paisana ad9e126299 test for different enb_cc_idxs as pcell. Bug fixes 5 years ago
Francisco Paisana 0f3ef11f8b now the scheduler only activates a scell after receiving a valid CQI for the SCell 5 years ago
Francisco Paisana 518f813f13 now the CA testing generation and simulation happen simultaneously. This way we can do more tti/event specific checks 5 years ago
Francisco Paisana b319f8dfcd created first version of CA test. Now we need to create actual asserts 5 years ago
Xavier Arteaga 4c61ffd391 SRSENB: set UE common PHY configuration in RRC::UE constructor 5 years ago
Xavier Arteaga b45223c880 Fix minor MAC Clang warnings 5 years ago
Andre Puschmann dc8c5687c6 fix rwlock in PDCP
we've used a rdlock but since the users struct is modified, we should be
really using a rwlock
5 years ago
Andre Puschmann 9e113f8b27 pdcp: allow to configure security for rx/tx seperately
previously PDCP security (integrity and ciphering) could only
be enabled for both Rx and Tx at the same time.

this, however, caused an issue during the conformance testing in which,
in TC_8_2_1_1() for example, the eNB sends a SecModeCommand and a
RRC Reconfiguration in the same MAC TB. In this case, the eNB
needs to be able to enable DL security right after sending the SecModeCmd
in order to send the RRCReconfig encrypted. However, enabling UL security needs
to be postponed until after the SecModeComplete is received.

This patch allows to enable PDCP security for rx/tx independently if
that is needed. The default way is like before, enabling it for tx/rx at
the same time.
5 years ago
Francisco Paisana ac52208409 removed most of clang-tidy warnings, introduced logmap in asn1, fixed info object naming in s1ap and ngap for successful and unsuccessful outcomes 5 years ago
Francisco Paisana e859d622c7 added logref class to forbid logmap pointer invalidation. Created a test for the logref, and introduced it in the scheduler, rrc and nas 5 years ago
Francisco Paisana b8b8740258 fix wraparound in si proc and error in scell parsing 5 years ago
Francisco Paisana 052892916e fix mme/enb id assignment. Also, now using the macro for invalid rnti and a boolean flag for the uninitialized mme s1ap id 5 years ago
Francisco Paisana 7557ef45c8 changed the s1ap to allow the insertion of users without rnti 5 years ago
Francisco Paisana 42449b079a now the scell_activation CE is only for 1 octet. The 4 octet one is not yet supported. 5 years ago
Francisco Paisana d831522692 addition of SCell Activation CE Cmd to scheduler and MAC 5 years ago
Francisco Paisana 838053e8f2 added SCell Activation CE to scheduler. Handling this CE in the MAC is still missing 5 years ago
Francisco Paisana a0407dd6f7 created a lock guard for pthread rwlocks. This will avoid using gotos in many cases, and the RAII technique avoids many accidents. 5 years ago
Xavier Arteaga 385102fa2d SRSENB: minor format, renaming and interface changes 5 years ago
Xavier Arteaga bf4ecc8064 Fix srsenb PHY and unit/component tests 5 years ago
Xavier Arteaga 231431f569 SRSENB: enabled CA PUCCH decode in eNb 5 years ago
Xavier Arteaga 35f4e5d69a Initial PUCCH 1B with channel selection 5 years ago
Francisco Paisana c9ac42f11d renamed rlc pdu / mac sdu allocate functions, and added some comments describing what these functions do 5 years ago
Francisco Paisana 87038375d5 fixed the building of MAC SDUs in the scheduler. Now, we ensure there is always space for the MAC subheader and RLC header. The MAC subheader is correctly discounted from the remaining bytes in a TB. 5 years ago
Francisco Paisana 089f72d573 ensure minimum tbs. If it cant do it, increase mcs until it can. 5 years ago
Andre Puschmann cccabdaf4f removing unneeded install targets for static libs (reported by Filipe) 5 years ago
Francisco Paisana c8fc0d91b3 changed the supported cc list to a vector of structs 5 years ago
Francisco Paisana 42b15c7bed use common ue_cfg interface to set the ue antenna info 5 years ago
Francisco Paisana 5f557700f2 changed the sched::ue_cfg(...) function to allow diff configurations. The RRC now activates all carriers after rrc reconf complete 5 years ago
Francisco Paisana b66bc3a6b0 create a sched_interface struct for antenna info dedicated. This way we remove the asn1 as a dependency in the scheduler 5 years ago
Francisco Paisana 88a22e7dbf support cc cfg from rrc 5 years ago
Francisco Paisana e86862611c update the scheduler interfaces to accommodate the configuration of multiple carriers 5 years ago
Francisco Paisana 2dc31ea440 added interface to configure multiple cells from the RRC 5 years ago
Andre Puschmann ed179fd311 timers: rename value() to time_elapsed()
this seems to be better readable than value() since
we've sometimes confused it with the timeout value
5 years ago
Andre Puschmann a32d4ebf59 move PRACH config check into cfg parser 5 years ago
Andre Puschmann 179fd394b2 enb: add SRB2+DRB1 to scheduler AFTER receiving Reconfig Complete
this commit fixes and issue where, after receiving paging and the resulting
PRACH from the UE, the eNB would create DRB1 and already schedule DL traffic
on this bearer. However, since the UE has not received the reconfig message
yet, the DL traffic is dropped since DRB1 isn't set up yet.

the commit also does not reset the BSR state of the bearer inside MAC since
this caused to a stall of the received DL PDU. The value would initially be set to
a non-zero value (after receiving the DL PDU from EPC). But when the bearer
was (re-)introduced to MAC, it would reset the BSR to zero, and, since
MAC never polls RLC, the PDU wasn't sent down until the next PDU arrives
and sets the BSR to a non-zero value again.
5 years ago
Andre Puschmann d3cb2eac83 add RLC suspend/resume to eNB interface 5 years ago
Andre Puschmann 369592544c store last RRC Connection Reconfig with transaction identifier 5 years ago
Andre Puschmann f999e256f9 add error handling for RRC msg packing in eNB 5 years ago
Andre Puschmann ad304207b3 patch PRACH offset parameter for 6 PRB
the 6 PRB eNB requires a different PRACH offset than the default
value of 2 in the SIB1 example. In order to avoid having
to use a separate SIB config with just a single different value,
the patch patches the value to the only right configuration, if it's wrong.
It continues operation but still issues a warning so the user
can change it in the config.
5 years ago
Francisco Paisana c19d033dbc set SIB scheduling to debug mode 5 years ago
Francisco Paisana af0b80b0a7 fix test for prb==6 and accidental adaptive retx in UL 5 years ago
Francisco Paisana a9b8c3fd55 fix msg3 prb limit for prb==6. It has to collide with PUCCH 5 years ago
Francisco Paisana 39fff9ed68 fix potential bug with grouping of RARs with same RA-RNTI but different prach_tti. The scheduler might not clear the old tti on time before the grouping. 5 years ago
Francisco Paisana de195e9521 changed the RAR schedule to support the allocation of nof_grants lower than the current nof_grants in the queue with same ra-rnti 5 years ago
Francisco Paisana e9ca6e3d52 fix rar size 5 years ago
Francisco Paisana a74dcd947f changed rar/msg3 scheduling to accommodate multiple rars per TTI 5 years ago
Francisco Paisana dc782e514b change the naming from tti --> sf for scheduling operations specific to a subframe 5 years ago
Xavier Arteaga 5dcb6b5960 SRSENB: Set default PRACH sequence root index in SIB2 5 years ago
Xavier Arteaga b08c1f003e SRSENB: enabled multiple cells from rr.cfg 5 years ago
Francisco Paisana 5ae3afd2b8 created cbit_ref for unpacking const buffers 5 years ago
Francisco Paisana 5468189cd9 fix some variables' naming (e.g. x2_ap -> x2ap, e_rab -> erab) 5 years ago
Francisco Paisana 2a83eee0ee fix security key setup 5 years ago
Francisco Paisana 83758e4f55 fix integrity/ciphering bit setting 5 years ago
Francisco Paisana ee24b59924 converted s1ap to new s1ap asn1 lib. Cleaned up bitstring packing/unpacking and bitstring types 5 years ago
Francisco Paisana 25bb36cdc3 converted ho preparation to new s1ap asn1 lib. Extended s1ap test 5 years ago
Francisco Paisana 6d1172de71 converted enbstatustransfer and ulnastransport to the new s1ap asn1 lib 5 years ago
Francisco Paisana 40baed0b3e converted uecontextmodificationresponse, initial setup request, and s1setup request to the new s1ap asn1 lib 5 years ago
Francisco Paisana b1c5bf7185 reverse addrv4 packing in s1ap 5 years ago
Francisco Paisana a740fcb954 bug - wrong ue context release cmd 5 years ago
Francisco Paisana 3066b404ac fix integer ext asn1 generation 5 years ago
Francisco Paisana b6c53d786b updated s1ap rrc interface with new asn1 lib types 5 years ago
Andre Puschmann fef6893ce4 make user activity handling independent of system time
this commit removes the getsystime() call from the activity handling.
it uses a single timer per UE to handle its activity.

three different timer values exist. one for the Msg3 reception. This
is like before and is quite low to quickly remove fake UEs from the
RRC. The second is a generic value (set to 1s for now) that covers
the entire UE configuration phase where multiple messages are sent
back and forth until the UE is fully set up and the default
bearer runs. From there on, the UE inactivity timer is used which
may be much bigger than 1s.
5 years ago
yagoda 2db90c5dd3 allowing TA CE commands in Msg4 5 years ago
Francisco Paisana f280720564 this fix was detected by Syed in the mailing list 5 years ago
Andre Puschmann 6ec573987a remove default value for 'blocking' param from pdcp::write_sdu()
there were two defaults and one was shadowing the other. This
commit removes both defaults and uses blocking-mode for RRC
calls to PDCP in the UE. The eNB write_sdu() uses the non-blocking
mode by default. We have to review the eNB's RRC perhaps and use blocking
there too and non-blocking only for data plane
5 years ago
Francisco Paisana 2eb6145b99 reset carriers on each set_cfg call 5 years ago
Andre Puschmann 75672324b9 fix RRC connection reconfig for new bearer
this fixes the packing of a RRC connection reconfig after creating
a new ERAB

it also adds a PDCP config factory based on the received request
5 years ago
yagoda 845c0fc2c0 fixing lcid issue with eMBMS, adding MRNTI user to stdout metrics 5 years ago
Andre Puschmann 476f970ee1 replace FIXME with TODO 5 years ago
Andre Puschmann 705cd3c211 fix typos spotted by aleksander0m 5 years ago
Pedro Alvarez c5979f59eb Clang format UE, eNB and lib (#850)
* Clang-formated UE, eNB and lib.
* Fixed compiling errors from clang-format.
* Fix linking issues introduced by clang-format
* Fix poor formating in initializing arrays of arrays.
* Fix mistake in conflict resolution on rm_turbo.c
* Re-apply clang format to gtpc_ies.h
5 years ago
Andre Puschmann c7ee887170 add factory function for creating PDCP config 5 years ago
Andre Puschmann 8a064cd3a6 pass msg_type from caller when logging RRC message
before the type of some message wasn't displayed correctly,
like SIBs, for example because the logger didn't
know the filed to retrieve the type string
5 years ago
Andre Puschmann 60d07f1656 assign msg-type to temp variable before logging ASN1 message in RRC 5 years ago
Francisco Paisana d59016ae68 use of srslte::log* type for ASN1 logging. Initialization of the asn1 and rrc_asn1 loggers done now in both the ue and enb 5 years ago
Andre Puschmann c379ef6cb1 fix uninit var 5 years ago
Francisco Paisana d270518d69 updated rrc to new srsasn1 version 5 years ago
Francisco Paisana 1212d403c6 added {} in if condition 5 years ago
Francisco Paisana 6b4488d5c1 added sending of enb status transfer from SeNB 5 years ago
Francisco Paisana c7f11e5690 fixed issue with the liblte_s1ap transparent container packing 5 years ago
Francisco Paisana 39fcf25e0d added extra tests for handover. Did a some refactoring to move boilerplate out of the test mobility function 5 years ago
Francisco Paisana a18a7e307e moved all the parsing of the libconfig files to separate functions that can be called from individual tests. Created several stack layer dummy classes for testing. Extended the rrc_mobility test to check correctness of RRC HOPreparation struct 5 years ago
Francisco Paisana b792a3158c removed magic numbers for s1ap timers, and handled the error in the s1 ho cmd 5 years ago
Francisco Paisana 524c80a804 added handling of ho command 5 years ago
Pedro Alvarez e1cdd51eba Clang-formated before pull request 5 years ago
Pedro Alvarez e68956bcf6 Adding discard timer timeout to PDCP config. 5 years ago
Pedro Alvarez a049ec6b82 Finished to add boiler plate code to support PDCP discard notifications to RLC. 5 years ago
Pedro Alvarez 2e7ddef038 Continue to add discard_sdu to RLC interfaces. 5 years ago
Francisco Paisana ab3d7dd413 updated sched interface for multiple carriers 5 years ago
Francisco Paisana 1da86df597 added map between cc_idx and enb cell specifier 5 years ago
Francisco Paisana eeb47f8fa4 fixed issue regarding repetition of ConRes tx 5 years ago
Francisco Paisana e94e0a8641 changed the logic associated with the tx of the conres CE 5 years ago
Francisco Paisana 3159a5b84a added cc_idx to dl_rach_info 5 years ago
Francisco Paisana 01847c5f5d phy_config_enabled is general to all the carriers of the ue 5 years ago
Francisco Paisana cab9327b1a updated scheduler interfaces to accommodate multiple carriers 5 years ago
Francisco Paisana 6d4f746a61 moved tti_sched_result out of carrier_sched. Removed interdependencies between the two classes. Simplified ra_sched and bc_sched initialization 5 years ago
Francisco Paisana 7990e2f563 use of a common tti_params struct to store all values derived from tti_rx 5 years ago