5g-team
/
srsRAN_4G
mirror of https://github.com/pvnis/srsRAN_4G.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
4,566 Commits
2 Branches
0 Tags
243 MiB
fix-cqi
master
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'ffc26a702d'
${ noResults }
Commit Graph

1758 Commits (ffc26a702d7f18acf77e8e9a64f192169703b90c)

Author SHA1 Message Date
Robert Falkenberg c75f314c3f Fixed incorrect DCI location assignment in pdsch_enodeb.c example 5 years ago
Mark Rohrbacher 4a76801459 Fixed duplex spacing for bands 65 to 70 5 years ago
Robert Falkenberg 3cf4431c66 Fixed inverted handling of fseek result value in srslte_filesource_seek 5 years ago
Igor Kim dd613c1514 Fix TBS table with auto-generated one (#368) 5 years ago
Andre Puschmann ada4e6644f fixing various issues in NB-IoT sync code detected by Coverity and clang-tidy 5 years ago
Francisco Paisana c9d3b61038 added resumable procedures to make RRC and NAS non-blocking 5 years ago
Andre Puschmann e42449532b fix wrong namespace definition in various places 5 years ago
Andre Puschmann deb3cbec28 soapy: start rx stream without extra flags and print error if not successful 5 years ago
Andre Puschmann 80655db4a4 fix missing include in filesink 5 years ago
Andre Puschmann 95a5c2dcdb adding NB-IoT sync code 5 years ago
Ismael Gomez d887624e74 Increased PSS threshold to detect RLF after change to number of missed subframes 5 years ago
Ismael Gomez 19066c49ab Ad Rel10 info to dci logs 5 years ago
Pedro Alvarez 6efa944b5e Removed srslte prefix from pdcp_config_t 5 years ago
Pedro Alvarez 0e7c5634f1 Added comment to PDCP maximum SDU size. 5 years ago
Pedro Alvarez dd56d08269 Replaced byte_buffer by array in PDCP base 5 years ago
Pedro Alvarez 8c10eabf23 Changed PDCP LTE to use unique_lock. 5 years ago
Pedro Alvarez 3da0391fff Adding default initializers to PDCP config. 5 years ago
Pedro Alvarez 494be243c0 Changed security direction to use an enum. 5 years ago
Pedro Alvarez 61051b4cb3 Changed PDCP NR read_data_header to return SN. 5 years ago
Pedro Alvarez f90b69e5f4 More clang-format for PDCP 5 years ago
Pedro Alvarez 491695ab77 Clang-formated PDCP NR PR. 5 years ago
Pedro Alvarez 38bbc55631 Added tests for PDCP NR Rx with SN Len = 18. In-sequence reception seems to work. 5 years ago
Pedro Alvarez d4aeb12db8 Adding more TX tests to PDCP NR entity. 5 years ago
Pedro Alvarez 39e3800781 Fixed header packing for SN length 18 for PDCP NR. First TX test is passing. 5 years ago
Pedro Alvarez d399c65082 Starting to add PDCP SN len 18 unit tests. 5 years ago
Pedro Alvarez 7a69e8ba64 Removed comment. 5 years ago
Pedro Alvarez adfe9f950e Fixed issue in computing the SN. Added test for packets received in sequence for PDCP NR. Test is passing now. 5 years ago
Pedro Alvarez 2104e6bbcf Added test for more TX packets in PDCP NR. Tests passing for TX_NEXT = 0, 2048 and 4096 5 years ago
Pedro Alvarez ecd164ed65 Starting to add more tx tests to PDCP NR tests. 5 years ago
Pedro Alvarez af2b593b8c Added check for integrity in test. First Rx PDCP NR test passing. 5 years ago
Pedro Alvarez d3b6828082 Changed PDCP configuration to explicitly have tx and rx direction. Decrypt on PDCP NR seems fine. 5 years ago
Pedro Alvarez ea3c44e9ac Removing header before decrypting. Continuing to add decryption tests to PDCP NR 5 years ago
Pedro Alvarez 7e6725f0a2 Fixing up PDCP NR tx test. Starting to add rx test. 5 years ago
Pedro Alvarez 378c8d247e Starting to add the mechanisms to store the last PDU in the PDCP tests. 5 years ago
Pedro Alvarez a42726f836 Fixed hdr_len_bytes in PDCP NR. Tx seems OK now. 5 years ago
Pedro Alvarez 73e30743d1 Added enum to PDCP config to replace two bools. 5 years ago
Pedro Alvarez 457f35699d Reverted back to a single config structure between PDCP NR and PDCP LTE. 5 years ago
Pedro Alvarez 810cacdc02 Adding write_data_header and append_mac helper functions to PDCP NR entity. 5 years ago
Pedro Alvarez 9d0db108c6 Continue to add PDCP tx test 5 years ago
Pedro Alvarez d1ac121100 Writting PDU into PDCP in tx test. 5 years ago
Pedro Alvarez c9e99443d8 Adding PDCP NR Tx test. 5 years ago
Pedro Alvarez 4bb99464ed Starting to add PDCP NR tests. 5 years ago
Pedro Alvarez 8e8a7a4154 Add more logic to PDCP NR tx logic. 5 years ago
Pedro Alvarez 2081b22465 Added PDCP_SN_LEN constants. Added bearer_id and direction back to the pdcp_entity_base. 5 years ago
Pedro Alvarez 8e1b9b9f5b Starting to implement the receive function of PDCP NR. 5 years ago
Pedro Alvarez d7a2721bb0 Adding algorithm to get COUNT for PDCP NR. Added convinience functions to manipulate HFN, SN and COUNT. 5 years ago
Pedro Alvarez 52f75c3cf2 Starting to add PDCP NR state variables. 5 years ago
Pedro Alvarez 2449f901f0 Fixed error in setting Kint in pdcp_entity_lte. 5 years ago
Pedro Alvarez 1944bf9a80 Continue to split pdcp_entity_lte and pdcp_entity_nr. Compiling now. 5 years ago
Pedro Alvarez bd91678d98 Continuing to split pdcp_entity into pdcp_entity_lte and pdcp_entity_nr 5 years ago
Pedro Alvarez 005d03cb1a Starting to split pdcp_entity into pdcp_entity_lte and pdcp_entity_nr to support NR PDCP 5 years ago
Ismael Gomez 069c55f2e5 Fix db to dbm typo 5 years ago
Ismael Gomez 2859a75ca0 Reset counter for sync lost when PSS is found 5 years ago
Ismael Gomez d32739c315 Minor logging changes in PHY 5 years ago
Andre Puschmann e0bd7f156d replace remaining warning macros with pragma message 5 years ago
Andre Puschmann 09610ce788 add type setter to sch_subh and use it for MCH PDUs 5 years ago
Andre Puschmann c4bc151e14 rlc: fix MRB logging 5 years ago
Andre Puschmann e562dfed15 minor code formating and debug fixes 5 years ago
yagoda 408400bee6 adding fixes and tests for eMBMS 5 years ago
Francisco Paisana 424876c5e4 added DL TTI mask for MBMS 5 years ago
yagoda b99178d8da updating timing advance values for lime 5 years ago
Ismael Gomez 50e1ed6cc6 Change order of radio stop to avoid locking on rf_ms() by async thread 5 years ago
Guillem Foreman 2574de4d2d Fixed soft demodulator 5 years ago
Ismael Gomez 126f2efb5c
Radio and UHD fixes to avoid changing master clock rate and fixes X300 (#589) 
* Fixes X300 MIMO

* Do not change sampling rate and calibrate time_adv_nsamples for b210
 5 years ago
Andre Puschmann 9ee415ac82 correct the max size for a single TB 
since the size in bits is counted per TB we don't need to allocate
space for the 2x2 MIMO case. Both CW have their own buffer.
 5 years ago
Andre Puschmann 21f8698397 fix MAC PDU packing for large TB sizes 
update the byte_buffer length variable after updating the remaining
PDU length. This has caused an error when calculating the
remaing space in the PDU because the SDU length was counted twice.
 5 years ago
Andre Puschmann 94cc61e4b1 add MAC PDU pack test for max size TB PDU 5 years ago
Ismael Gomez c9c43e44e9 Fixed PDU buffer size 5 years ago
Andre Puschmann 2ae35e4ce0 make sure status PDU doens't exceed grant size 5 years ago
Pedro Alvarez 9597cc4c14 Clang-formated liblte_* 5 years ago
Xavier Arteaga 5e49aca835
Merge pull request #570 from softwareradiosystems/feature_256qam_fix 
Resource allocation extended tables and PDSCH table 2 for 256QAM
 5 years ago
Ismael Gomez 6d2c6ec58d Do not change master clock rate in UHD if dynamic rate is supported 5 years ago
Guillem Foreman 2a8ec5c9b9 More fixes 256QAM 5 years ago
Guillem Foreman eab73829f6 Changes requested 5 years ago
Ismael Gomez 538f38cf54 Let PDCP Control PDUs be processed 5 years ago
Pedro Alvarez 9b6aaac1b5 Ignore PDCP status PDUs, instead of passing them to the GW. Check on the GW if the packet is large enough to hold an IPv4 header. 5 years ago
Ismael Gomez 11d42acb3a Fix using deallocated PDU 5 years ago
Ismael Gomez 8c41625599 Add RLC suspend and resume 5 years ago
Andre Puschmann db196cc052 add RLC AM test for status PDU generation with small and big MAC grants 5 years ago
Andre Puschmann db9f093b63 add debug log when handling reordering timer 5 years ago
Andre Puschmann 849ad2655c fix creation of malformed RLC AM status PDU 
the issue was caused by an unneeded length check during the
assembly of the status PDU. This length check caused an too early
break from the while-loop that adds all missing SNs to the status PDU
leaving the PDU struct in an invalid state where ack_sn was equal to
one of the NACK_SNs.
The fix is to simply remove the length check during the generation to
fully generate the status PDU. If, for whatever reason, MAC provides
a too small grant to fully fit the status PDU, the PDU will not be
generated, i.e. the calling function checks the return value and does
not pass the (then too big PDU) down the stack.
 5 years ago
Andre Puschmann 9f3a947c02 modify RLC AM retx test to provide exactly a MAC opportunity of the size 
that is reported as buffer state
 5 years ago
Xavier Arteaga aa6652155c Phy: added ue_ul normalization mode parameter 5 years ago
Xavier Arteaga 20823e191d SRSUE: Added UL force amplitude optional parameter 5 years ago
Andre Puschmann 4e86b2f6b2 introduce layerd architecture we use for UE to eNB 
- this allows flexible use of different PHYs and radios
- use common radio_multi (moved to lib)
 5 years ago
Xavier Arteaga 2530894374 Channel emulator: added input pointer checks 5 years ago
Ismael Gomez d595c4d882 Fixes issue #545 and unlocking of tti_sync condvar before closing causing deadlock at stop 5 years ago
Andre Puschmann aff26abc89 fix memleak in Soapy driver when no device was found 5 years ago
Ismael Gomez 773c2a9721 Fixed multiple issues in Random Access procedure and extended MAC test 5 years ago
Andre Puschmann 6b2961fcee add MAC DL-SCH unpacking test 5 years ago
Andre Puschmann 92f0d58856 mac: move further init/config into ctor to allow early logging, etc. 5 years ago
Francisco Paisana 92b4b168fe added default rlc um and am in the interface as factories 5 years ago
Francisco Paisana b903c1a52c made default init for rlc um test 5 years ago
Francisco Paisana 58e2e51044 removed rlc_interfaces. The rlc_cnfg types are now part of the rrc_interface_types. Removed implicit RB initialization in the RLC. 5 years ago
Francisco Paisana c5509caece added extra operators and remove rrc_asn1 in some cmake targets 5 years ago
Francisco Paisana b936629221 removed rrc asn1 header from bcd_helpers, from rlc_interface, and rlc tests 5 years ago
Francisco Paisana bb0dbf0f1c created a asn1 utils with helper functions and types related to the asn1. These types/functions will help isolate the rrc_asn1 lib from most of the layers, reducing this way the compile times, and leading to better isolation. This will also make the transition to NR smoother. I removed the asn1 types from the NAS and USIM interface so far. 5 years ago
Francisco Paisana 416f9896ec fixes to include the findings from PR #550 5 years ago
Guillem Foreman 46724c336d Fixed errors for phy_dl_test and pdsch test 5 years ago
Guillem Foreman 4627737c87 Revert "Disable 256QAM tests failing in CentOS" 
This reverts commit 833ce5224a.
 5 years ago
Guillem Foreman c71763dc93 Fixed minor message in modem test 5 years ago
Guillem Foreman db4127ca64 Fixes 256QAM, added pdsch table 2, fixed warnings 5 years ago
Guillem Foreman 535325bc37 srsLTE: added resource allocation extended tables for 256QAM and integration with PDSCH test 5 years ago
Andre Puschmann 62a4fa1c93 fix various potential buffer overruns 
this is based on suggested fixes by Dirk Grabinski and David who
have fuzzed various parts of srsLTE using afl
 5 years ago
Andre Puschmann 701db61fde rlc: extend stress tester to simulate MAC PDU corruption 5 years ago
Andre Puschmann ecb6a0f99b fixing RLC AM bug where corrupted PDU causes segfault 
the underlaying issue is that a corrupted PDU is passed to RLC
which claims to have segments whose total size exceed the size
of the entire PDU. Those PDUs are not ignored.
 5 years ago
Xavier Arteaga a417d3a70a Added DCI trace if cqi is requested 5 years ago
Xavier Arteaga 87433c83da SRSUE: 64QAM R8 compatible 5 years ago
Ismael Gomez 833ce5224a Disable 256QAM tests failing in CentOS 5 years ago
Pedro Alvarez 498f1b8e4b Small PDCP fixes: 
- Moved most the initialization of the pdcp_entity to the header.
  - Initilize some variables in gtpu_ntoa.
  - Removed debug print.
  - Format eNB GTP-u debugging code.
 5 years ago
Pedro Alvarez 1c51d2ca9a Small clang format changes. 5 years ago
Pedro Alvarez 5d8dcbe4cb Make sure that PDCP SN is initialized properly in the eNB. UE attaches again when using encription. 5 years ago
Pedro Alvarez 53d2220aab Resolved conflicts with unique pointers after rebase in PDCP entity. 5 years ago
Pedro Alvarez 2643b9070f Fixing mistake in setting PDCP last_submitted_pdcp_rx_sn 5 years ago
Pedro Alvarez 6d5dbdedfa Fixed mistake in comparison in pdcp_entity. 5 years ago
Pedro Alvarez 693338da07 Added TX HFN print to make it easier to debug HFN mis-match 5 years ago
Pedro Alvarez 6b59cc0760 Debug print for PDCP Reestablish. 5 years ago
Pedro Alvarez 5ca6238877 Adding encription debug prints. 5 years ago
Pedro Alvarez b97d1191f4 Added more debug info at eNB GTP-U. Changed the pdcp_entity to follow the standard more strictly for RLC AM DRBs. 5 years ago
Pedro Alvarez f4fd6034ba Starting to add separate functions for PDCP handling for UM DRBs and AM DRBs 5 years ago
Pedro Alvarez 6578cf1d01 Making sure that next_pdcp_rx_sn is reset at reestablish. 5 years ago
Pedro Alvarez 6cbcc5154d Starting to use received SN to do user plane decription. 5 years ago
Andre Puschmann 58763fb714 stack: move initialization of log object into ctor 
this fixes the issue when the stack is torn down if, for example,
the radio couldn't be loaded correctly. it will hence call stop() on all stack
components which are not initialzized yet, and logging therefore doesn't work.
the log object is know during contruction time and therefore can be passed
in as soon as possible.
 5 years ago
Pedro Alvarez 8f5ad55c4a Added attach request as a UL info trasnfer in the UE. Added interface to remove eps bearer map when going idle. Fixed bug in GW in assignment of IPv4 addresses. UE seems to rebound from the service reject now. 5 years ago
Andre Puschmann 82a69fb51c mux: fix packing of short MAC PDUs 5 years ago
Andre Puschmann 0012868e91 rlc_am: reduce log level when provided PDU size is too small 5 years ago
Andre Puschmann 4aaa0473b9 pdu: remove unused variable total_sdu_len 5 years ago
Andre Puschmann fab75592ec fix MAC PDU padding with only padding and add test accordingly 5 years ago
Andre Puschmann b6d7fd5def improve error handling in PDU packing 5 years ago
Andre Puschmann da35f41dd5 rework MAC logical channel prioritization 5 years ago
Andre Puschmann 6d586d84a8 extend MAC PDU test 5 years ago
Xavier Arteaga 5d792e7ebe AGC: Fixed gain hysteresis 5 years ago
Andre Puschmann e0a28cf4c0 simplify PDCP init and also bypass it for SRB0 on eNB 5 years ago
Andre Puschmann 0ef96f789b bypass PDCP for SRB0 processing chain 5 years ago
Andre Puschmann 218f136254 remove default PDCP entity for SRB0 5 years ago
Andre Puschmann f5a929e425 pdcp: print length when processing incoming PDU 5 years ago
Francisco Paisana ce29ed545d moved mac thread to the stack. Protect the interface of the stack with PHY and gateway via a queue of tasks 5 years ago
Francisco Paisana 10a56e2a84 moved GW out of the UE stack. This is important to keep concurrency out of the stack once it becomes single-threaded 5 years ago
Xavier Arteaga bb26a42fb6 Fixed backtrace symbols free 5 years ago
Andre Puschmann 414e55fafc pcap: add dtor 
this fixes issue if object is destroyed and PCAP is still open
 5 years ago
Ismael Gomez 67b6a40c1b Use correlation for neighbour RSRP measurement 5 years ago
Andre Puschmann abef6ce152 move own ipv6 header definition into own header file and use it in tft filter 5 years ago
Guillem Foreman 269e21e3af Fixed minor format 5 years ago
Guillem Foreman 50edd9a325 Initial 256QAM Modem and Demodulator 5 years ago
Joseph Giovatto 0bb7f590b3 Moved include complex.h from header files to impl files to prevent 
error /wr to complex.h and c linkage in CentOS 7.
 5 years ago
Andre Puschmann 2b82f21fd2 fix compiler warning 5 years ago
Andre Puschmann acbe7fabe4 rlc: fix class member initialization 
uninitialized member detected by coverity, now converted all default
initialization to be done in class definition
 5 years ago
Andre Puschmann b32254c5e2 use lock_guard for GW 5 years ago
Andre Puschmann 89416a67c7 increase timeout for rlc stress tests 
for valgrind where we sometimes hit the default timeout of 1500s
 5 years ago
Xavier Arteaga 1f4cf8121b SRSUE: Initial UL channel simulator 5 years ago
Andre Puschmann 2b7b4d0e7e remove hard-coded LCID for dedicated bearer in GW 5 years ago
Pedro Alvarez 2723aa9b12 Added EPS bearer id to apply_tft interface. Sending packets to the correct LCID if they match the packet filter. 5 years ago
Pedro Alvarez a7e0a0624b Starting to add interface apply_traffic_flow_template between NAS and GW. 5 years ago
Pedro Alvarez 2fcf8c1827 Starting to add packing and unpacking tests to activate EPS bearer context request. 5 years ago
Francisco Paisana 415d3418b6 reorganized enb to mirror ue director/class structure with a stack class 5 years ago
Pedro Alvarez d67d18cc6b Removing deplicated error codes. 5 years ago
Xavier Arteaga bd3ec34f7b SRSUE: Apply CLang format phy args structure 6 years ago
Xavier Arteaga fd3671a7e5 SRSUE: Enable AGC 6 years ago
Andre Puschmann e8d6236975 remove init for all RLC TM/UM/AM 
- all RLC entities are now initialized during contruction
- there is no need to check for, e.g., existance of timers, during
  runtime
- there is also no need to call re-init during resume
- timers are freed in dtor
 6 years ago
Ismael Gomez f24c0cef8c Use timer interface instead of local boolean to query timer state 6 years ago
Ismael Gomez c2e9817f41 Possible solution to RLC Reestablishment 6 years ago
Ismael Gomez 14b526f2aa Add PDCP per-bearer reestablish 6 years ago
Ismael Gomez ade720e032 Add RLC resume procedure 6 years ago
Andre Puschmann 3f613d7183 nas/gw/rrc: make LCID for DRB dynamic 
- add interface to RRC to allow NAS to query the DRB for a given
  EPS bearer id
- extend interface for NAS to setup GW to also pass LCID of bearer
- in NAS, use this new interface to pass actual LCID of the default
  DRB when creating the TUN device
 6 years ago
Andre Puschmann f357c995fc liblte_mme: fix packing and unpacking of modify EPS bearer context 
this just skips the security bits but the packing/unpacking of
the values, i.e. new TFT may still be wrong
 6 years ago
Ismael Gomez b31b668a8e Remove unnecessary find_package(GUI) 6 years ago
Ismael Gomez 594d62f229 Added read_block function to ringbuffer 6 years ago
Ismael Gomez 19cb5c172b Added read-and-convert function to ringbuffer 6 years ago
Andre Puschmann e47010130f extend thread class to set unique thread name in ctor 
this will also extend all classes that use srslte::thread
to specify the name of the thread in the ctor as well
as to set the name of the worker threads in the thread pool
the thread name will be displayed in gdb.
 6 years ago
Andre Puschmann 0e95867f13 remove task dispatcher class 6 years ago
Andre Puschmann acf95fdd85 rlc_am: fix newline in logs 6 years ago
Xavier Arteaga b903e61548 Initialise all channel emulator attributes by default 6 years ago
Andre Puschmann b3f1915f7b pdu: fix zero-padding of RAR PDUs 6 years ago
Xavier Arteaga 9c84f8e3fd SRSLTE: Added Uniform Random vector generator; Delay channel test; Fixed Delay channel SEGFAULT; SRSUE channel unique pointer; 6 years ago
Xavier Arteaga 2ffa1f9f1e SRSUE: Added RLF simulator in channel emulator and integrated it in SRSUE. Removed Zeros Command 6 years ago
Xavier Arteaga 7c97e40e63 SRSUE: Improved internal channel emulator help 6 years ago
Xavier Arteaga 9ab2b2de81 SRSUE: Created delay channel emulator and added fading to the UE 6 years ago
Andre Puschmann 709e769d0d pdu: fix formatting 6 years ago
Andre Puschmann ee1f910877 pdu: add unit test for packing and unpacking RAR PDUs 6 years ago
Andre Puschmann ea2e692836 pdu: fix MAC RAR PDU packing and unpacking with backoff indicator 6 years ago
Andre Puschmann e97343579b liblte_mme: fix typo in header 6 years ago
Pedro Alvarez 1031ea896d add NAS activate dedicated bearer request unpacking test 6 years ago
Andre Puschmann 76b84a9b61 fix unpacking of deactivate eps bearer context 6 years ago
Pedro Alvarez 69b1a2319e Fix error in the TFT parameter list size unpacking 6 years ago
Pedro Alvarez 82828a699b Fixed bug in transaction identifier and radio prio unpacking in NAS. 6 years ago
Pedro Alvarez 02beeefdbd Fix header unpacking error in the Activate EPS dedicated bearer context request message 6 years ago
Andre Puschmann 1c749ad559 add basic handling for deactivating eps bearer 6 years ago
Andre Puschmann c14c3c23f1 pdcp: fix issue when setting SN length configuration 6 years ago
Andre Puschmann f000e36f21 liblte_mme: fix dedicated bearer handling, add handling for UE testmode 6 years ago
Andre Puschmann 8fd4c42849 fix include in build_info.h template 6 years ago
Andre Puschmann 20c9f4687c remove duplicated code mac_cfg_t 6 years ago
Xavier Arteaga 7629863c5a SRSUE MAC: 36.331 v10 9.2.2 MAC main config defaults does not include RACH 6 years ago
Xavier Arteaga 2c78111666 SRSUE: Fixed CLang Tidy in ue.cc 6 years ago
Francisco Paisana 00256f2cd9 fix the hanging in the UE during shutdown 6 years ago
Francisco Paisana 4311c3121c avoid crash when converting nulltype to string 6 years ago
Andre Puschmann 58b09c8677 fix pool_allocate macros for new unique_buffer 6 years ago
Xavier Arteaga 080b4a327c SRSUE: Refactored asynchronous cell and ue_radio. CA Fixed. 6 years ago
Andre Puschmann 65f50cd7ba introduce new UE layer design 
- abstract UE object now consists of a radio, a PHY, and a stack layer
- add new stack abstraction layer that combines MAC, RLC, RRC, PDCP, NAS and GW
- PHY layer now has a single stack interface and does not talk to MAC and RRC seperatly
 6 years ago
Andre Puschmann 3a6dd9b164 move UE RRC into own folder 6 years ago
Francisco Paisana 0e3baa0f2f Renamed the reset() method of byte_buffer_t to clear() 6 years ago