2899 Commits (c9d7db731428953e8d44ad6c10783283284e9b4c)

Author SHA1 Message Date
faluco 82db6544fb Add instrumentation points to rlc_am_lte::rlc_am_lte_tx::handle_control_pdu using srslog. 4 years ago
Andre Puschmann 16de8668e0 rlc_am_lte: convert mutexes to std::mutex
replace all pthread_mutex with std::mutex and use lock_guard and unique_lock (where needed)
4 years ago
Andre Puschmann 20cbc48f90 rlc_am_lte: refactor PDCP/RLC interface to use fix sized data structure
this patch replaces the std::vector type used in the interface between
PDCP and RLC to signal delivery status between both layers. The new
data type is a configurable but fixed-size vector.
The RLC AM doesn't need to dynamically allocate the vector for every SN but
uses the tx_window for storage.
4 years ago
Francisco ee77343f26 fix compilation issue for centos7 4 years ago
Francisco f72cd4151c rlc am,bugfix - fixed formatting of RLC AM header and status pdu 4 years ago
Francisco 0f9d73012f use srslte::move_callback instead of std::function in timers to avoid allocations 4 years ago
Francisco 5a1bf28fe1 optimization - minimization of number of std::string allocations for logging 4 years ago
Francisco 1ffc4cef86 rlc am,optimization - change helper log methods to avoid mallocs 4 years ago
Xavier Arteaga a03c78a777 Fix NR-PUSCH defect 4 years ago
Xavier Arteaga 05f4d6af71 Fix and validated UCI multiplex in NR-PUSCH 4 years ago
Xavier Arteaga 2b9bd1173e More NR-PUSCH UCI bit multiplexing 4 years ago
Xavier Arteaga 289fff9c22 Removed carrier set in UCI NR module 4 years ago
Xavier Arteaga 97435b085e Added CSI part1 and 1/2 bit HARQ-ACK multiplexing on PUSCH 4 years ago
Xavier Arteaga dc2542901a Verified HARQ-ACK in PUSCH 4 years ago
Xavier Arteaga 9dffad87f2 Initial UCI bits multiplexing in PUSCH 4 years ago
Xavier Arteaga f4e9d00ea8 Initial HARQ-ACK multiplex in PUSCH 4 years ago
Xavier Arteaga 7b588eafec Minor aesthet change 4 years ago
Andre Puschmann ace8764568 rlc_am_lte: add missing unlock when building status PDU fails 4 years ago
Francisco f0ed1e06a8 documentation,bugfix - added documentation to new blocking queues, changed class names, and removed blocking pushes from the critical path 4 years ago
Francisco d1236fd62f stack,optimization - replaced previous block_queue design for new bounded queue in several places in the enb 4 years ago
Francisco fb278a8b21 Fallback to default R8 TBS tables for format 1A DCI
Co-authored-by: xavierarteaga <xavier.arteaga@softwareradiosystems.com>
4 years ago
Andre Puschmann ceacf8508d rlc_am_lte: fix handling of maxretx
this patch fixes the actions/handling after RLC detected
maxRetx reached for a given SN.

According to the TS, RLC should only inform upper layers and
not try to recover from the event itself.

As a consequence, we won't manipulate the Tx or Rx window.
As a result of this, we might retransmit a SN more than
the specified amount of times.

It's the task of RRC to reestablish the bearer to recover
from that.
4 years ago
Francisco fb04fdbe69 sched,bugfix - fix mcs/tbs computation for 256-QAM. 4 years ago
Andre Puschmann 6a4bf65fd8 rlc_am_lte: extend check for valid status PDU
check for all NACKed SNs are smaller than ACK_SN
4 years ago
Andre Puschmann 62b2327178 rlc_am_lte: fix header reconstruction
* optimize processing of status PDU (SN is removed from window immediately)
* fix maxRetx signaling for segments
* make tx_window_t a template class, rename and use for rx_window as well
4 years ago
Francisco 39aea96c69 fix sched tests UL HARQs. Set common pucch cfg in the sched tests 4 years ago
Andre Puschmann 99df71a914 rf_zmq: make error message when port bind failed more verbose 4 years ago
Francisco 9748c0be84 simplified tbs/mcs computation in scheduler 4 years ago
Pedro Alvarez 9c67a029b5 Trying to make calculation of offset in status report more readable 4 years ago
Pedro Alvarez 7b23a83306 Fixup tests to consider wrap-around in status report 4 years ago
Pedro Alvarez c4e9516561 Fix issue when LMS wraps-around and FMS doesn't in PDCP status report. Fix incorrect update of FMS on clear_sdu. Adding unit test to LMS wrap-around. 4 years ago
Pedro Alvarez 0d020a7f07 Disable sending and handling status report on SRBs 4 years ago
Xavier Arteaga 81cc8de2b7 Protect NAS unbounded message read 4 years ago
David Rupprecht aef6805d03 Added pcap net feature to eNodeB 4 years ago
David Rupprecht 9e72d89fa1 MAC PCAP move run thread in base class 4 years ago
David Rupprecht 894e4d3501 Added mac pcap network class that dumps the packets to a udp network sink 4 years ago
David Rupprecht a58f0642cb created pcap base class for main handling 4 years ago
David Rupprecht da658ed2d4 Changable UE ID for enodeb 4 years ago
David Rupprecht 5a95cbdfae Disable rat assignment in pcap class 4 years ago
David Rupprecht 24bea9a860 Refactored functions for pcap udp packing and write lte mac pcap with udp frame 4 years ago
David Rupprecht bb3e87302d Added new pcap enable option and mac nr 4 years ago
AlaiaL 390a4c0f76 [metrics] Changing variable types.
Adjusting the license.
4 years ago
AlaiaL 723c56051e [metrics] Changed the extension from cpp to cc.
- Fix date of CMakeLists.txt.
- Initialization of the used variables in the cpu usage calculation.
4 years ago
AlaiaL 41cf15f5ad [metrics] Adjusted function names and documentation 4 years ago
AlaiaL d518a625cc [metrics] Added the system metrics to the csv 4 years ago
AlaiaL 0ba7cd7df9 [metrics] Added system metrics to the enb's stdout 4 years ago
AlaiaL 3a86c210f9 [metrics] Added the system metrics to the ue stdout 4 years ago
Xavier Arteaga 0346564241 Fix NR-PUCCH encoding 4 years ago
Xavier Arteaga 784f4be72e SRSUE: NR CSI report fixes 4 years ago
Xavier Arteaga 4679e9f871 Initial NR CSI reports 4 years ago
Francisco 202c4d7566 remove uses of method .clear() of stack timers 4 years ago
Francisco be7e78da53 limit allocation of PDCP SDU+Timer buffer to DRB+RLC AM cases 4 years ago
Pedro Alvarez 8dfa87c377 Disable undelivered SDU queue for SRBs. 4 years ago
Francisco a3cb21d378 move undelivered_pdcp_sdus class methods to .cc file. Fixed the forwarding of pending PDCP SNs during S1 handover 4 years ago
Francisco 17fa79f24c couple the pdcp discard timers and sdu buffer management into same subclass. Add asserts to ensure there is no ambiguity in the PDCP SN assignment and buffering. Extend the discard timer and pdcp sdu buffering to SN lengths above 12 4 years ago
Pedro Alvarez 4723dd0aa9 Converted undelivered sdus queue in the PDCP to use a vector.
This was done to improve the performance of the notify_delivery().
4 years ago
Xavier Arteaga 6c9ff3ac92 Fix packed sequence genration for non multiples of 8 4 years ago
Xavier Arteaga 1e55d68b55 Removed set RNTI from API 4 years ago
Xavier Arteaga 93752fb2c4 Fix LDPC compilation for GCC 10 4 years ago
Xavier Arteaga 576a923a4c Added i8 zero vector 4 years ago
Francisco 4b09507c19 remove srslte.h includes from upper layers 4 years ago
Francisco b329e25bbb move ue phy interfaces to separate interfaces header file 4 years ago
Francisco b8bd869d0f move ue rlc interfaces to separate interfaces header file 4 years ago
Francisco a988351f46 move ue pdcp interfaces to separate interfaces header file 4 years ago
Francisco ea04104e8e move ue gw interfaces to separate interfaces header file 4 years ago
David Rupprecht 8f49b92760 Using PDCP entity lte instead of nr for nr bearer 4 years ago
Pedro Alvarez c0b5edf6db
Make sure discard timers are initialized, even when timeout is infinite. (#2400) 4 years ago
Francisco 6e64933335 handle the scenario when the network thread fails to allocate a byte buffer 4 years ago
Francisco f610a7b83d Change background worker pool to become a global variable
Allocate rrc::ue objects in batches in the background worker pool
4 years ago
Xavier Arteaga 126fc09b7d SRSUE: Added initial SR procedure for NR 4 years ago
Andre Puschmann 822abc763e rlc_am_lte: when max retx is reached, remove SN from tx window
this fixes an issue when the RLC bearer isn't reset from RRC.
In this case, the RLC would retransmit the same PDU over and over
again despite the max retx counter being reached.
4 years ago
Francisco 0b6b62324f convert rlc am retx_queue to circular buffer 4 years ago
Andre Puschmann 9c4146442a mac,phy: refactor NR MAC/PHY UL data passing interface
inspired by accepted (but not yet merged) PR to include the
(unique_)byte_buffer_t for MAC/PHY interfacing, this patch adds
a few more useful bits to that. Buffer management for UL data is now
done in MAC and only a pointer to the data is passed in the UL action.

* Move Tx softbuffer to MAC (until UL HARQ class is ready)
* Remove temparal data member in cc_worker
* Remove memcpy after packing MAC PDU
4 years ago
David Rupprecht fc9d5befda Remove header test case 4 years ago
Andre Puschmann 06e7f169c6 rlc_um_nr: fix unpacking of 12bit UM PDU 4 years ago
Francisco 138685399e remove allocations from rlc_am_tx::handle_control_pdu 4 years ago
David Rupprecht cc0c091a39 pcap checksum to null for decoding if checksum check is enabled 4 years ago
Xavier Arteaga 6ba9f8fd41 SRSUE: Remove UL hard-coded phase and more PUSCH logging info 4 years ago
David Rupprecht 1fcd006a7c fixed segfaulting 4 years ago
Xavier Arteaga b768002a93 SRSUE Added RAR unpacking and other fixes 4 years ago
David Rupprecht 82a8dcc77a Change interface to unique_byte_buffer
logging message for msg3 preparing
4 years ago
Francisco 9a6512f4e8 fix RLC AM undelivered PDCN SNs reset bug 4 years ago
Francisco 1ede82bb30 use circular array for buffered PDCP SNs in RLC AM to limit memory allocations 4 years ago
Francisco 2a65bf9636 fix undelivered PDCP SNs buffers in RLC AM to handle SN=-1 case 4 years ago
Francisco bad2302e31 avoid the use of two arrays for managing buffered pdcp sns in RLC AM 4 years ago
Francisco 299634b319 use of vector to store undelivered PDCP SNs in RLC AM 4 years ago
David Rupprecht 0f1586dd2d Deleted all HAVE_5GNR in CC and h files
CMakeList and travis yaml
4 years ago
Pedro Alvarez d8f3878ce1
RLC failure to deliver notifications and discard timer limits to 1500ms (#2368)
* Added interfaces for the RLC to notify the PDCP of failure to transmit
SDU

* Limit discard timer to 1500ms, to avoid issues of lingering SDUs in the undeliverd_sdus_queue.

* Fix bug in early exit of notify_delivery and notify_failure

* fix compilation issue in rlc-pdcp notification

Co-authored-by: Francisco <francisco.paisana@softwareradiosystems.com>
4 years ago
Francisco 2f75abcc7a fix failing rlc am test 4 years ago
Francisco abe4f4c7eb use tx_window to store the map of rlc sn to pdcp sns 4 years ago
Francisco f86eb84876 conversion of RLC AM tx window from std::map to array 4 years ago
Francisco 1660fc81a0 fix comment regarding PDCP SN value for status report 4 years ago
Francisco 047dd2a56d use function helper for discard timer lookup and stopping in the PDCP 4 years ago
Francisco c6fa011eec fix pdcp discard timer list creation 4 years ago
Francisco 82bb0a7d81 implementation of pdcp discard timers using a vector for efficiency 4 years ago
Andre Puschmann 40d7934267 rlc: call PDCP notify without holding Tx lock
move notify_info_vec as stack variable and unlock mutex
before calling PDCP notify
4 years ago
Francisco 93b1450e03 fix enb crash during close down of enb and epc 4 years ago
Francisco Paisana cd8ee37f74
Use a reverse lookup to avoid iteration over a std::map (#2363)
* reuse vector capacity for pdcp sn notification
* use an extra lookup data structure to find PDCP SNs that an RLC SN contains
* fix rlc sn->pdcp sn lookup datastructure in rlc
* fix rlc failing test
4 years ago
Pedro Alvarez d947a0bccf Used the used SN to insert into the discard timer instead of the TX_COUNT 4 years ago
Pedro Alvarez 3f2fe4e5f6 Disable PDCP discard timer when using RLC UM. 4 years ago
Xavier Arteaga b8b27709b9 Radio: implement resampling buffer protection 4 years ago
Pedro Alvarez 24d5b9071c Fix issue with status report test config 4 years ago
Pedro Alvarez 6ecd6e273c Make sure that the status report is sent in RLF and PDCP reestablishment triggered by Handover 4 years ago
Pedro Alvarez 6a6bffcf5c Changed log of discarding SN due limit to info level 4 years ago
Pedro Alvarez c66c96aac7 Simplify if condition in checking the maximum allocated SNs in PDCP 4 years ago
Pedro Alvarez 33808a5cb8 Making sure that SNs don't wrap-around in PDCP with RLC AM. 4 years ago
Ismael Gomez 543e84d873 Fix compilation error in PPC 4 years ago
faluco 613d397d0a - Dump the PDCP metrics into the JSON file.
- Fix the PDCP metrics getting reset periodically which invalidated the byte counters.
4 years ago
faluco a940e169a3 Add the enb_cc_idx value to S1 events. 4 years ago
faluco b750647cd8 - Remove the cause field in the rrc disconnect event.
- Add the sib9 enb home name field to the sectors events, but leave the value as a TODO.
4 years ago
faluco 7b9dab3a73 Rename cc_idx variable to enb_cc_idx for specific upper layer events. 4 years ago
faluco a4605883f0 Implement second revision of the events and metrics document. 4 years ago
Pedro Alvarez 0e828aeb4b Remove unecessary mutex. PDCP metrics are accessed from the stack thread. 4 years ago
Pedro Alvarez c39905744c Fix metrics of TX PDUs and TX_PDU bytes in PDCP 4 years ago
Pedro Alvarez 451c305790 Add mutex to isolate metrics_hub thread from the stack thread when
getting the metrics from the PDCP
4 years ago
Pedro Alvarez 0c240a80aa Fix up PDCP metrics to calculate the buffered bytes when get_metrics is
called.
4 years ago
Xavier Arteaga 70a55ebf1e Fix ZMQ sleep time 4 years ago
Pedro Alvarez 46cd29e0ac Temporarly disable sending status report and retrasnsmissions on reestablishment in PDCP 4 years ago
Pedro Alvarez df501d1500 Clear underlivered SDUs info map for SRBs on reestablishment 4 years ago
Pedro Alvarez d705fa2106 Tentative fix for errors due to status report already present in RLC info queue 4 years ago
Pedro Alvarez ba5367bc56 Change order which reestablish is called in eNB
Make sure that RLC info queue is reset when reestablish happens
4 years ago
David Rupprecht 876858b44c Added mac nr prach common config convert function with test case 4 years ago
David Rupprecht a3be380e3b workaround to mitigate the linking error 4 years ago
Andre Puschmann e0495d1da8 zmq: fix parsing of log_trx_timeout
add temp var for this param. the bug cause log_trx_timeout
to have the value of the previously parsed fail_on_disconnect
4 years ago
Pedro Alvarez cfd94441a5 Added metrics to srsenb PDCP 4 years ago
Pedro Alvarez 8873b7c42f Added computation for the metrics 4 years ago
Pedro Alvarez d34aba8065 Added interfaces to get metrics from PDCP entities. 4 years ago
Pedro Alvarez eb2f5b978f Starting to add metrics to lib/upper/pdcp.cc 4 years ago
Pedro Alvarez 3eab97340b Fix issue in getting PDCP discard timer from configs 4 years ago
Xavier Arteaga 784a33583b SRSUE: Initial NR MAC-PHY interfaces
SRSUE Fix compilation

SRSUE: temporary fixes LTE/NR PHY/Stack interface problem

fix

fix
4 years ago
Francisco 6a178693a8 handle rrc configs with pdcp with sn=15 or 18 bits 4 years ago
Francisco faf2adde90 set last_submitted_pdcp_rx_sn to -1 of the next ul rx sn 4 years ago
Pedro Alvarez e2d2951b00 Added some extra logging for the PDCP get_buffered_pdus and notification reception. 4 years ago
Pedro Alvarez 963dff34af Added retransmissions to the UE's PDCP on re-establishment. 4 years ago
Xavier Arteaga 8ac6d7382f Fix PRACH sequence generation 4 years ago
Xavier Arteaga 2fd618a295 Avoid FFTW re-planning if no DFT change is required 4 years ago
Xavier Arteaga 596c8f52a9 PRACH set config avoids modulo operation 4 years ago
Xavier Arteaga 1e073b8b67 PRACH: avoid general cexp for sequence generation using LUT 4 years ago
Andre Puschmann c1a1c92e1b zmq: optionally log rx/tx timout from ZMQ ringbuffers to stderr
this patch adds two new config flags to the ZMQ driver that allows to:
* configure the default ZMQ trx timeout in ms
* turn on error logging if the timeout occurs

Use with, e.g.:
device_args = log_trx_timeout=true,trx_timeout_ms=3333
4 years ago
Xavier Arteaga 984c4a4748 Changed license header 4 years ago
Pedro Alvarez e0542a4651 Fix issue in sending PDCP status PDU from the eNB due to non-existing LCID at the RLC. 4 years ago
Pedro Alvarez b0fe302f8e Added interfaces so the upper layers can trigger the PDCP status report. Added ability to the UE to send Status Report aftre reestablishment. 4 years ago
Pedro Alvarez 89a23cec7e Added statusReportRequired to the PDCP entity config. 4 years ago
David Rupprecht 24123313bf Added MAC NR RA procedure with a minimal test case 4 years ago
Xavier Arteaga 3d3c80262c Modified Error messages 4 years ago
Xavier Arteaga d9805f7ba7 Added AVX512 LDPC 4 years ago
Xavier Arteaga 2e39e103f8 Minor NR related corrections 4 years ago
Xavier Arteaga 24cfed6489 Fix scrambling sequence for PUCCH format2 4 years ago
Xavier Arteaga 5f70526ac5 Minor NR-PUCCH related fixes 4 years ago
Xavier Arteaga 9faa2d5fcd SRSUE: Automatic DL-HARQ Reset for every TTI and Generate PUCCH baseband signal 4 years ago
Xavier Arteaga 2d9e964147 Fix RA RNTI grant count 4 years ago
Xavier Arteaga d807ccc3dd SRSUE: Initial NR-PUCCH HARQ feedback 4 years ago
Xavier Arteaga ff5fbbf0a0 Added vector sprint for bit 4 years ago
Xavier Arteaga 818f3ea7c7 Initial NR-PDSCH HARQ-ACK/NACK procedure 4 years ago
Xavier Arteaga 18db846c6c Remove NR hard-coded phase offsets 4 years ago
Xavier Arteaga 44df2288b9 Corrected typos 4 years ago
Pedro Alvarez f89b644902 Added function to get control pdu type to the PDCP base class. Shorten logger name in PDCP Status report test. 4 years ago
Pedro Alvarez 90113419c2 Added memset(0) to PDCP status report bitmap before starting to fill it in. 4 years ago
Pedro Alvarez 9bc08af880 - Added ability to the PDCP LTE entity to send PDCP Status report.
- Added handling of PDCP status report to the PDCP LTE entity.
- Added test to the generation and handling of PDCP status report.
4 years ago
Francisco Paisana 4152e43bab fix gtpu packing when extension header is enabled 4 years ago
Francisco dc4283c572 added cmake functions as helpers to set labels in ctests 4 years ago
Francisco add156c3fe update phy lib cmake test labels 4 years ago
Pedro Alvarez dd6d6f731d Passing SN provided by upper layers to PDCP entity. Using it to calculate TX_COUNT if passed. 4 years ago
Pedro Alvarez 492ea2a5a8 Addressing reviewers comments to #2290.
Removing unecessary \n for logs and changed log of PDCP info queue
 capacity to debug to avoid log spam.
Changed log level for unhandled S1AP messages from error to warning
 in EPC to avoid failing tests because of error message.
Changed usage of allocate_unique_buffer to make_unique_buffer()
4 years ago
Pedro Alvarez fcaaf72187 Starting to add discard functionality to PDCP LTE entity.
This includes:
  - Adding a queue (implemented with std::map) for undelivered PDUs.
    This queue uses the SN used for TX as the key.
  - Added discard timer that is started upon reception of the SDU. Upon
    expiry of the timeout a discard callback removes undelivered PDUs
from the queue.
  - Added the mechanisms to the notify_delivery to remove PDUs from the
    undelivered queue when the PDU is ACK'ed.
  - Added test case for both timer expiry and acknowledgment.
  - Fix up the getter for buffered SDUs to return the undelivered SDUs
  - Changed default PDCP discard timer, so AM has a discard timer by
    default.
4 years ago
faluco 5c8923123a Misc compilation fixes from the fapi repo. 4 years ago
faluco 57f66febfc Ported the RLC classes to srslog in the lib dir. 4 years ago
faluco f424f2e113 - Upgraded PDCP classes in lib to use srslog.
- Update tests to new changes.
4 years ago
faluco 6359a2d948 - Upgrade the gtpu class in lib dir to srslog.
- Propagate old log elimination through all the dependencies of gtpu.
4 years ago
faluco 62fcf04083 Ported the all radio classes to use srslog. 4 years ago
Francisco c2dfe615e7 fixed alignment of LIBLTE_BYTE_MSG_STRUCT to reflect the one of byte_buffer. Add bzero in liblte packers 4 years ago
Francisco 4188b5146e fix uninitialized memory access in gtpu_test and liblte_mme unpacking 4 years ago
faluco 9d15a44c73
Port lib/phy to srslog (#2298)
* - Ported the channel class to srslog.
- Removed all newlines of log messages in lib/phy.

* Remove more newlines that use the C debug macros.
4 years ago
Andre Puschmann 01acf95566 mac_rar_pdu_nr: update public interface to make it easier to access
* provide all subPDUs as const vector&
* return UL grant directly
4 years ago
Francisco 3265d940ec remove byte buffer pool cached member variables as they are unnecessary now. 4 years ago
Francisco 04ab4eefcd use new make_byte_buffer() helper method to create unique_byte_buffers 4 years ago
Francisco 8a9c326bcb remove old direct uses of byte_buffer_pool 4 years ago
Francisco 1e2153769e remove byte buffer pool cleanup method and unnecessary mutexes 4 years ago
Francisco 0c7c317be5 refactor byte_buffer class and move it to separate file 4 years ago
Andre Puschmann e227916819 mac_sch_pdu_nr: add SBSR, PHR and CRNTI packing 4 years ago
Andre Puschmann 4ca43c6804 mac_sch_pdu_nr: add unpacking helpers for CRNTI, SBSR and PHR CEs
* unpackers for CEs
* testcase with TV
4 years ago
Xavier Arteaga a154bef23f Added incremental phase in NR-PUSCH modulator 4 years ago
Xavier Arteaga 8f57437e6f Add NR-PUSCH-DMRS amplitude option and procedure 4 years ago
Xavier Arteaga a19671802e Added SRSUE NR-PUSCH initial procedures 4 years ago
Xavier Arteaga 19e9c25d1d Added ZMQ Tx sample offset 4 years ago
Pedro Alvarez 7b25eac47c Fix race condition in rlc_am_stress test and other fixes related to this
test. The race condition was being cause by write_sdu being called
simultanously to read_pdu, which could cause the read_pdu to try to get
the SDU info before it had been written by the write_sdu.

Changes in this commit include:
 - Make sure PDCP sn in included in RLC AM stress test.
 - Stop handling control PDU when TX is not enabled in RLC AM.
 - Fixed issue with length of the PDCP SN in rlc_stress_test.
 - Moved the place were sdu info erase was called to avoid double calls to erase
 - Tentative fix for race condition in rlc_am_stress test.
 - Added function to print information about undelivered_sdu_info_queue
   for debugging.
4 years ago
Pedro Alvarez 261c2b2e03 Removed limit to the undelivered SDUs info queue in RLC AM. Printing a warning if the queue is getting large instead. 4 years ago
Pedro Alvarez d0ef6ce00b Fix typos and bad comments in rlc_am_lte.cc and rlc_am_test.cc
Added checks for the nack_sn in the status reports of the rlc_am_test.
4 years ago
Pedro Alvarez 24db20bcca Removed some unused variables after changing method of tracking notifications. Removed rlc_am_notify_pdcp test file. Testing is now in rlc_am_test.cc 4 years ago
Pedro Alvarez 6c071a784c Changed notification mechanisms to use map of acked SNs instead of acked bytes.
This was required due to an issue where bytes were counted twice when a
packet had been lost.
4 years ago
Pedro Alvarez 649d642776 Moved notification tests from rlc_am_notify_pdcp_test.cc to rlc_am_test.cc.
This added some tests to resegmentation.
4 years ago
Pedro Alvarez 389cf4d943 Moved updating the notify info to it's own function. 4 years ago
Pedro Alvarez de669d214a Fix test header and queue_capacity check in RLC notifications.
Also, remove unecessary nullptr initializaion and fixup some newlines.
4 years ago
Pedro Alvarez de90b4753f Added the ability of the RLC AM to notify the PDCP of the acknowledged
PDCP PDUs. This includes:

- Modifying the byte_buffer_t to include PDCP SN meta-data. This way,
  the RLC can keep track of the ack'ed bytes for a specific PDCP PDU.
- Added in the RLC an `undelivered_sdu_info queue`, to keep track of the
  amount of ack'ed bytes and the total size of the PDCP PDU,
  so the RLC can know when delivery is finished.
- Added an interface between the PDCP and the RLC so that the RLC can
  notify the PDCP when it receives an ack from the status PDUs. The RLC
  passes to the PDCP a vector of all the ack'ed pdus in a rx'ed status PDU.
- Added some tests to the notify functionality. This includes some tests
  where the PDUs are acked imediatly, and one test where the PDU is
  retx'ed.
4 years ago
faluco 821925a273 - Upgrade to srslog the loggers in lib/mac.
- Adapted users of these classes and tests.
4 years ago
Xavier Arteaga a2d9b436d9 SRSUE: add NR stack to PHY and initial decoded PDU push 4 years ago
Xavier Arteaga 4f43935dd3 NR-SCH: CRC is KO if data is all zeros 4 years ago
Xavier Arteaga 77f0a53abd Added DCI Format 0_0 unpacking and more NR-PUSCH procedures 4 years ago
Francisco 9e25e95545 fix S1AP UE Capability Indication message. Created helper to log received S1AP messages 4 years ago
Andre Puschmann 8e13f04684 mac_pcap: refactor MAC PCAP and include NR RAT into same object
after adding the thread-safe PCAP writer functionality to the EUTRA
MAC object it became clear that we don't wont to replicate the
same for the NR object.

This patch therefore refactors the class that now supports both EUTRA and
NR rats. The old mac_nr_pcap.[h/cc] has been deleted. All test-cases
and usages now use the new object that needs to pass the RAT type in
the ctor.

this patch addresses the last open point of #2160
4 years ago
faluco 199f1c953e Remove unneeded logmap headers. 4 years ago
faluco b014233662 - Port time related classes to srslog.
- Adapt tti_point_test to srslog.
4 years ago
faluco 1a5799a6ca - Replace loggers is network utils.
- Adapt tests that use network utils and callers.
4 years ago
faluco e9ed6f31ba Port mac_pcap to srslog. 4 years ago
faluco f8485fb799 Replaced loggers to srslog in PNF and VNF classes. 4 years ago
faluco 96c07a69c0 Report the RLF event to the JSON event file in the enb. 4 years ago
Xavier Arteaga c60d207826 Add fix phase shift in gNb PHY 4 years ago
Xavier Arteaga 194670a2a3 NRPHY: hard-coded symbol phase correction 4 years ago
Xavier Arteaga 820c9066db Fix OFDM modulator for NR 4 years ago
Xavier Arteaga 2421f2cd99 Multiple PHY fixes and NR-PHY configuration refactor 4 years ago
Xavier Arteaga 7e6a35a9f7 Fix Synch error calculation 4 years ago
Xavier Arteaga b652cd68a5 Refactored NR PHY configuration to accept multiple CORESETs/SearchSpaces 4 years ago
Xavier Arteaga a85d79c6b7 Added ZMQ option to delay/advance Rx samples 4 years ago
Xavier Arteaga 73001c9541 Implement NR-DCI conversion to string 4 years ago
Xavier Arteaga 83a5ce96ed Initial NR OFDM symbol size compatibility 4 years ago
faluco 806268f6cf
Por asn1 code in lib directory to srslog (#2253)
* Match hex dump indentation with srslog.

* Port asn1 utils to use srslog. Converted logging functions from taking varargs to variadic template functions.

* Remove trailing new lines in log lines from asn1 utils.

* First round of upgrades to srslog to asn1 tests.

* Second round of porting asn1 tests to srslog.
4 years ago
Andre Puschmann f88943653b mac: implement MAC RAR PDU unpacking for NR
* add class for mac_rar_pdu_nr
* extend test case
4 years ago
Andre Puschmann da9e3363f1 mac_pdu_nr: rename MAC PDU class for NR to adhere naming conventions
* mainly to have _nr as trailing name for filename and class
* also add "sch" to class and filename (RAR PDU will have extra class)
4 years ago
Xavier Arteaga 6b4a17dc66 Fix uninit condition 4 years ago
Francisco e8f6a436af update gtpu test to account for scenario of buffered PDCP SNs, and buffering of direct path until indirect tunnel is closed 4 years ago
Francisco a55c4cdca5 avoid gtpu extension header pdcp number magic number 4 years ago
Francisco 13649e4e19 Implement new GTPU functionality:
- multiple tunnels per E-RAB
- data forwarding between connected GTPU tunnels
- forwarding GTPU End Marker between connected tunnels
- TeNB GTPU handles in-sequence delivery when multiple tunnels for the same ERAB exist.
4 years ago
Andre Puschmann 3784439088 add backward as backtrace pretty printer
this patch adds the MIT-licensed header-only library backward-cpp
as possible alternative for our internal backtrace-to-file
writer.
4 years ago
faluco 711438f756
Port enb specific classes to use srslog (#2155)
* - Started porting the enb PHY layer to use srslog loggers.
- Updated srslog to manage the none level.

* Finished porting enb phy layer including the NR part.

* Ported MAC, GTPU, PDCP, RLC and S1AP enb classes to use srslog.

* Use new stack logger.

* Ported the enb RRC clases to use srslog.

* Remove unused log macros.

* Replace loggers in sched, sched_carrier, sched_helpers.

* Replaced loggers in sched grid.

* Replaced loggers in sched harq.

* Replaced loggers in sched ue.

* Replaced loggers in sched ue ctrl.

* Replace loggers in sched ue ctrl TPC.

* Replaced loggers in sched subclasses.

* Replaced loggers in rrc_meascfg_test

* Configure loggers in rrc_mobility_test.

* Fix compilation errors left out after the rebase.

* - Implement a custom log sink that will serve as a test spy to intercept and count the number of error and warning log entries.
- Adapt the erab_test_setup and rrc_mobility tests to use this new class and make them pass again.

* - Remove trailing new lines introduced in the rebase.
- Ported the sched_ue_cell class to srslog.

* Remove unused log member.

* Ported mac tests to srslog.

* - Removed remaining trailing newlines from log entries.

* Fix compiler errors detected in CI.

* Fix another static variable without definition passed to log lines.

* Fixed a bug in srslog::flush that would never end when the backend queue is full.

* Fetch the RRC logger instead of injecting it in the constructor.
4 years ago
Andre Puschmann 617e0ddb67 band_helper: add helper class for RF bands
attempt to C++ify handling of radio bands and (E/NR)ARFCNs, etc.
4 years ago
Xavier Arteaga 4fe34b5e5b Apply minor comments in NR-PUCCH 4 years ago
Xavier Arteaga 4c6944b883 Implement NR-PUCCH Format 2 DMRS put/Estimate 4 years ago
Xavier Arteaga 958afaee60 Implement NR-PUCCH Format 2 encode/decode. Initial NR-PUCCH procedures. 4 years ago
Xavier Arteaga 4b6849b775 Polar: Add more information to ERROR traces 4 years ago
Xavier Arteaga 573ff24a47 Fix CRC for more sizes 4 years ago
Xavier Arteaga 1ee4d84f80 Added NR-PUCCH encode/decode format2 skeleton 4 years ago
Xavier Arteaga 4d96cf4a41 More NR-PUCCH support 4 years ago
Xavier Arteaga 697bdb4d6d Added NR-PUCCH Format 1 encoder, decoder and DMRS 4 years ago
Xavier Arteaga 33bb387f52 Initial NR-PUCCH formats 0 and 1 encoder 4 years ago
Xavier Arteaga e7562e5b3f Added ZC sequence LUT object 4 years ago
Xavier Arteaga d100919561 Initial NR-UCI encoder 4 years ago
David Rupprecht 306bb6b38b Added function for derive keys 4 years ago
David Rupprecht ceda458bb3 Added MAC NR to EUTRA and NR with stack interfaces including MAC config build
Moved MAC logical channel config to MAC interface types
4 years ago
David Rupprecht a6046ca875 Added funcs for asn flat config RLC and PDCP 4 years ago
Xavier Arteaga 7dd99da045 Disable carry-less multiplication 4 years ago
Xavier Arteaga 058bee5fda Increased prime number range 4 years ago
Xavier Arteaga 2f5b1ba9cb Avoid PUSCH-DMRS initialization for 0 PRB 4 years ago
Xavier Arteaga 732a220d42 Unified low-PAPR Ruv sequence generation 4 years ago
Xavier Arteaga aa8b69e9a7 Fix prime number 4 years ago
Xavier Arteaga 8de73988b8 Add real vector and complex scalar product 4 years ago
Xavier Arteaga a7ca8ffff7 Moved prime number to different file 4 years ago
Xavier Arteaga ae3c5ec7d0 Moved all block code (32, O/K) to FEC block
Fix missing header

Fix missing header
4 years ago
Xavier Arteaga 95ce49acd4 Added more vector copy functions 4 years ago
Xavier Arteaga be6cb666e2 Initial moved block coding to FEC 4 years ago
Xavier Arteaga f6b4f65f12 Add NR-PDSCH-DMRS SNR estimation 4 years ago
Pedro Alvarez 350e90a030 Make RLC retransmissions deterministic. It was creating unpredictablity
in the RLC AM tests. See issue #2228
4 years ago
Pedro Alvarez 6ca8bc12ec Fix wrong SN in RLC status PDU when packet is dropped. 4 years ago
Francisco 049ad77fca simplify asn1 choice types with one single type with a packer 4 years ago
Francisco c336c3eed2 added to_number() conversion of rrc_nr poll_byte 4 years ago
Ismael Gomez a6423442c2
Refactor NR RA files and fix header includes all over library (#2162)
* Refactor NR resource allocation classes. Use DCI instead of grant for dummy PDSCH UE/eNB test

* Minor refactors in NR workers and ue_dl

* Fix include issues

* fix compilation issues
4 years ago
Ismael Gomez d5f0634975
Add PUCCH SNR measurement (#2175)
* Add PUCCH SNR measurement

* Fix PUCCH SNR estimation

* Reverted PUCCH noise estimation

* use fpclassify instead of iszero

Co-authored-by: Xavier Arteaga <xavier@softwareradiosystems.com>
4 years ago
Ismael Gomez 0780f3caea pdu_queue must be non-blocking in order to avoid the ue or enb to block in the event of a memory leak and the buffer pool running out of buffers. In that case, the null return shall be handled properly and error logged. This commit restores commit c4c44c33f4. 4 years ago
Francisco Paisana d4242f2db7 precompute nof_re_table[sf][prb][slot][cfi] for faster nof_re computation and for more accurate lower bound nof_re computation 4 years ago
Andre Puschmann fcf481b83e pdu: add check when unpacking MAC PDUs to not read beyond PDU length
we've checked the same when unpacking the subheaders but missed the
case where the payload was read beyond the PDU length, as has been
seen with a malformed RAR PDU.
4 years ago
Andre Puschmann 78b07daf3b pcap: make public interfaces thread-safe and handle fopen returning nullptr
the previous patch only introduced a thread-safe queue between
PHY workers (writers) and PCAP writer thread (consumer).

However, it is also required to protect the ctor (and close()) to
prevent corrupted PCAP files.

The patch also correctly handles the case where the PCAP couldn't
be openend for writing and doesn't start the thread.
4 years ago
David Rupprecht 020d0dacc8 add the additional sec cap to NAS attach request
use same capabilities that are signaled for EUTRA
4 years ago
Andre Puschmann c02aa8f124 liblte_mme: add DCNR UE capabilties packing 4 years ago
Andre Puschmann 4fa89b7039 pcap: make PCAP write thread-safe
* offload PCAP writing to background thread
* use blocking_queue between writer and clients to make it thread-safe
* add basic test case

this fixes point 1-3 of #2161
4 years ago
Andre Puschmann 2ca894df01 pdu: fortify RAR packing
detected with ASAN trying to write negative number of padding bytes.

The patch checks the calculated length and returns with an error
if the length is negative.

=================================================================
==5759==AddressSanitizer: while reporting a bug found another one. Ignoring.
m==5759==ERROR: AddressSanitizer: negative-size-param: (size=-6)
4 years ago
Xavier Arteaga 54a864e021 Added Initial NR-PRACH configuration for preamble format 0 4 years ago
Xavier Arteaga b3200d9ef5 Renaming common UL/DL DMRS related types and initial NR PUSCH implementation 4 years ago
Xavier Arteaga cc5fdb68f3 Added on-the-fly sequence for bit packed 4 years ago
Xavier Arteaga d0a4b4d409 Changed DL-SCH LDPC scaling factor for decoding high rates 4 years ago
Xavier Arteaga 2e59f6a568 Applied LDPC fixes and minor aestheic modifications 4 years ago
Xavier Arteaga 13443c3f8c Added number of DMRS CDM groups without data to NR grant 4 years ago
Xavier Arteaga d413c1aaec Fix base graph selection and improved PHY LIB logging 4 years ago
Xavier Arteaga 808bb3fb94 Fix string to modulation conversion and apply clang-format 4 years ago
Xavier Arteaga 0a06074158 Skip NR PDSCH allocation in PDSCH DMRS symbols 4 years ago
Xavier Arteaga 1775052144 Fix NR PDSCH DMRS cinit and zero after free 4 years ago
Francisco Paisana 74ffe393c6 asn1 update: s1ap asn1 is now v16.1 (2020-03) 4 years ago
faluco 92b11c1adb Backport misc changes from the fapi repo. 4 years ago
Francisco Paisana 66aa34d173 update RRC NR ASN1 to 2020-09 v15.11 4 years ago
Andre Puschmann c5514d7f80 pdu: fix to_string() for TA command
the get_ta_cmd() is returning uint8_t which stringstream
interprets as ASCII character by default. So the log message is bogus.
4 years ago
Pedro Alvarez 0ad0e9acac Make sure that RLC entity is only re-created if it switches modes. 4 years ago
Pedro Alvarez 0c20b7a455 Added support for S1AP modify bearer request support. This includes:
- Handle received E-RAB S1AP at s1ap.cc.
 - Added methods to rrc.cc, rrc_ue.cc and rrc_bearer_cfg.cc to handle erab modify request.
 - Made RLC add_bearer() function capable of re-creating the RLC entity.
 - Send RRC reconfiguration to the UE and reply to the EPC with S1AP
   modify bearer response.

This commit also adds support to srsEPC to send S1AP modify bearer request for
testing purposes.
4 years ago
Andre Puschmann 48b37394f1 rlc: remove unneeded log entry
was added for testing only
4 years ago
Francisco Paisana e27c0869e5 update RRC ASN1 to 2020-09 v15.11 4 years ago
Andre Puschmann bc4c9606ce rlc_am: add extended bearer metrics
this patch adds support for measuring the:
* SDU rx latency (Average time in ms from first RLC segment to full SDU)
* amount of buffered bytes (sum of payload of PDUs buffered in rx_window)

the implementation is using std::chrono
4 years ago
Andre Puschmann d54c33258b rlc_metrics: add sdu rx latency and buffered bytes 4 years ago
Andre Puschmann 81cfce6cf0 rlc_um: remove latency calculation from RLC UM 4 years ago
Xavier Arteaga 533222f245 NR PDCCH fixes 4 years ago
Xavier Arteaga a746e29395 Removed shadow variable 4 years ago
Xavier Arteaga 99ca2d2f14 Add polar interleaver 4 years ago
Francisco Paisana 1ea635f9ae asn1 utils fix: avoid unpacking an unconstrained integer length twice 4 years ago
Andre Puschmann e43eab8b5f rlc: fix rate metrics (nan,inf values), use std::chrono
similar to GW, we remove gettimeofday and use std::chrono.
we also make sure to reset the metrics after reestablishment
4 years ago
Ismael Gomez f9a02299f9 Use MAC PDU pointer instead of tti_rx and rnti as a key to associate buffers. Decouple crc_info() and push_pdu() functions. This allows for different timing architectures in the PHY 4 years ago
Ismael Gomez 0498439d41
Backport some changes from FAPI branch (#2124)
* Reorder DCI FORMAT enum

* Fix endianness issue

* Fix return codes in phy_ue_db

* Log members should be destructed after the layers.

* Add JSON metrics and Events. Add Alarm log channel. Simplify MAC metrics struct.

* Restore metrics_stdout change
4 years ago
Francisco Paisana ea36e46635 fix asn1 length determinant packing/unpacking. avoid subtracting len by zero before the packing 4 years ago
Francisco Paisana d198e8fb31 fix asn1 length determinant packing for upper bounds above 64K 4 years ago
Francisco Paisana 1304746bce use of fmt lib in asn1 utils 4 years ago
Andre Puschmann 9133135e12 rlc_tm: remove error from log when RLC TM PDU can't be sent
RLC TM can't be segmented so it may happen that a PDU
cannot be sent because the grant is too small. That is not
an error and should only be logged in info.
4 years ago
Francisco Paisana 53116a99fc add rlc metrics to rlc_um 4 years ago
Francisco Paisana 82eb31f70f add rlc metrics to enb 4 years ago
Francisco Paisana 0f693b36b2 changed pdu latency calculation to std chrono 4 years ago
Francisco Paisana 7ffc236a1a enable log line when rlc tx pdu last segment is sent but the latency log is disabled 4 years ago
Francisco 951912d18a disable RLC latency measure when ENABLE_TIMESTAMP flag is disabled 4 years ago
Francisco 92bc98e2f0 add byte tx counter to the set of metrics being measured in RLC 4 years ago
Francisco e2654e69ec Enable pdu stack latency measurements in the eNB. 4 years ago
faluco f23fdf0639 Include missing files. 4 years ago
faluco 98a2c868b5 Update srslog to latest version. 4 years ago
Codebot 43082e8d6a enb/ue: turn various warning messages into info
turn events that may happen in the normal life of a eNB/UE
into info rather than warning to allow strict
warning/error checking in tests.
4 years ago
Codebot f5d14d7649 polar_chain_test: fix compilation issue when AVX2 isn't used
this fixes compilation on aarch64:

FAILED: lib/src/phy/fec/polar/test/CMakeFiles/polar_chain_test.dir/polar_chain_test.c.o
/usr/bin/gcc -DENABLE_TIMEPROF -DENABLE_TTCN3 -DHAVE_5GNR -DHAVE_MBEDTLS -I/usr/include/SoapySDR -Ilib/include -I../lib/include -Wno-unused-but-set-variable -Wall -Wno-comment -Wno-write-strings -Wno-unused-result -Wformat -Wmissing-field-initializers -Wtype-limits -std=c99 -fno-strict-aliasing -D_GNU_SOURCE -O3 -fno-trapping-math -fno-math-errno -DBUILD_TYPE_RELEASE -DIS_ARM -DHAVE_NEON -DHAVE_NEONv8 -fvisibility=hidden -fdiagnostics-color=always -Werror --param large-function-growth=1600 -O3 -DNDEBUG -fPIE -MD -MT lib/src/phy/fec/polar/test/CMakeFiles/polar_chain_test.dir/polar_chain_test.c.o -MF lib/src/phy/fec/polar/test/CMakeFiles/polar_chain_test.dir/polar_chain_test.c.o.d -o lib/src/phy/fec/polar/test/CMakeFiles/polar_chain_test.dir/polar_chain_test.c.o   -c ../lib/src/phy/fec/polar/test/polar_chain_test.c
../lib/src/phy/fec/polar/test/polar_chain_test.c: In function ‘main’:
../lib/src/phy/fec/polar/test/polar_chain_test.c:214:11: error: unused variable ‘gain_c_avx2’ [-Werror=unused-variable]
  214 |   float   gain_c_avx2 = NAN;
      |           ^~~~~~~~~~~
../lib/src/phy/fec/polar/test/polar_chain_test.c:191:7: error: unused variable ‘errors_symb_c_avx2’ [-Werror=unused-variable]
  191 |   int errors_symb_c_avx2 = 0;
      |       ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
4 years ago
David Rupprecht 848496bb0f Moved get_earfcn to srslte get_carrier_freq func 4 years ago
David Rupprecht 2e51cfc1a5 Added black cells with index function
Added new index functios
Use asn1 list functions for toAddMod and toRem lists
4 years ago
David Rupprecht 96b75b6433 Fixes clang compiler error in case of UHD_ENABLE_RFNOC enable 4 years ago
Andre Puschmann c0883291f6 rlc: pass TTI to get_metrics to calculate "real" LTE rx/tx rate
when retrieving the RLC metrics, the number of TTIs since the last
call are passed. This allows to calculate the actual rate
based on the LTE timing rather than only the system timing.
4 years ago
Andre Puschmann cff9f03a11 rlc_am_lte: remove unused rx/tx metrics members
those variables aren't used and are included in the bearer metrics already
4 years ago
Andre Puschmann 3c169e6be1 rlc_am: increment retx counter for segments
we've only incremented the retx when retransmitting a full PDU,
but not when only retransmitting segments.

This might lead to many more retx than allowed.
4 years ago
Francisco b41fc96d6d fix asn1 integer packing for integer values whose length is equal or above 32 bits 4 years ago
Pedro Alvarez 38206bea69 Fixed RLC AM fixed header size in get_buffer_state function. Fixed RLC AM tests accordingly. 4 years ago
Xavier Arteaga d6b5229dbe Added CSI-RS unit test and fix defects 4 years ago
Xavier Arteaga 08799cfe0f NR CSI-RS initial put/measure 4 years ago
Xavier Arteaga b7d74ef70b Initial CSI RS 4 years ago
Xavier Arteaga 8cc023e168 Fix PDCCH NR Test 4 years ago
Xavier Arteaga c0cdce6450 Updated license 4 years ago
Xavier Arteaga e07cf513d0 Improved NR blind search and DL test 4 years ago
Xavier Arteaga 90aa4fbea7 Improved srslte_chest_set_smooth_filter_gauss 4 years ago
Xavier Arteaga c635b1e467 Initial NR DCI blind-search 4 years ago
Xavier Arteaga 85d5026e38 Improved NR PDCCH unit test 4 years ago
Xavier Arteaga 315394560d Fix Polar unitialised read 4 years ago
Xavier Arteaga cd1aef7d76 Added NR PDCCH unit test plus fixes 4 years ago
Xavier Arteaga 53f6ac118e Initial PDCCH encode/decode 4 years ago
Xavier Arteaga 159a3d84bd Fix minor precoding issue 4 years ago
Andre Puschmann 00a6e16c14 update license header for liblte_*.{h,cc} files
user license-agnostic text to refer to license file.
make sure copyrights/years are correct.
4 years ago
Andre Puschmann 47c5f9e85b remove AGPL header from remaining cpp files
* also add commercial header to come CMake helpers
4 years ago
Andre Puschmann b9f363db9a ssl: rename liblte_ssl.h to ssl.h 4 years ago
Andre Puschmann ef19b1a9bd fix various uninit vars detected by cppcheck
non-critical fixes in tests mostly, still good to have those clean
4 years ago
Xavier Arteaga 81d72380b5 Reduce FEC Polar chain test time 4 years ago
Xavier Arteaga f9643843a0 SRSENB/UE Fixed NR workers 4 years ago
Xavier Arteaga b501f2eeaf SRSENB/UE: Added NR workers 4 years ago
Xavier Arteaga ac930003be SRSUE: Integrated NR workers 4 years ago
Xavier Arteaga 6fb56a3c62 LDPC: fix AVX tests compilation 4 years ago
Xavier Arteaga eed9405e40 Moved NR MAX MIMO layers to carrier 4 years ago
Xavier Arteaga 31a637adae Fix UCI SCH threshold, cover PUSCH 64QAM, check UCI-ACK valid in PUSCH test 4 years ago
Xavier Arteaga 12c076bf96 updated copyright headers 4 years ago
Xavier Arteaga 24297f973c Removed CTTC from file headers 4 years ago
Xavier Arteaga 035fcc9afb Removed FEC working directory 4 years ago
Xavier Arteaga bde1fa703d Added Polar RM and removed vectors with malloc from FEC NR 4 years ago
Pedro Alvarez 49bcffcdf8 Fix issue packing TEID in Error indication. 4 years ago
Andre Puschmann 07d2bc4fe8 change license header to agnostic version with hint to root LICENSE file 4 years ago
Francisco 2dc3fce9bd fix derivation of UL-64QAM support from the UE Capabilities in the eNB
Before this PR, the eNB was not activating UL-64QAM if the UE release was below 12,
due to an erroneous convertion of the ASN1 EUTRA Capabilities struct into the flattened
srslte::ue_capabilities_t.

With this PR, the eNB activates UL-64QAM for the following cases:
- UE category 5
- UE category 8 and release >= 10
- UE category UL 8 and release >= 12
4 years ago
Andre Puschmann 477fe77f24 rlc_am: reformat log message for PDU retx 4 years ago
Andre Puschmann 6d3af2d2bd rlc_um: fix bearer name in logging after re-configuration
the RLC bearer name was empty after reestablishing a UM bearer.

we need to pass the RLF config and RB name to the internal configure()
call of the Rx entity, like we already do for the Tx side
4 years ago
Xavier Arteaga 225bc9d260 Enable FEC SIMD acceleration 4 years ago
Jesus Gomez c9cdb0d53c Solve Issue 1: Invalid read in LDPC AVX2 Encoder/Decoder 4 years ago
Andre Puschmann 504d8fd9f0 pdsch: calculate average PDSCH EVM over all decoded codewords
when EVM measurements are enabled, instead of only logging them for
each decoded codeword, we also calculate the average.

this is useful for calibration.
4 years ago
Xavier Arteaga 755325fc3e Avoid sizeof and standard memory functions 4 years ago
Xavier Arteaga 35bf5b8c6d Added generic memory malloc 4 years ago
Xavier Arteaga 83dddae525 Added vector zero 4 years ago
Xavier Arteaga a5537cc1ef Correct argument 4 years ago
Xavier Arteaga b7fc2299e5 Softbuffers initialise buffer pointers with zero memory 4 years ago
Andre Puschmann 7f81f44427 rf_uhd: treat N3xx like the X3xx and do not set timespec on every burst iteration
the N310 too doesn't seem to like setting the timespec for each call to
send in a single burst
4 years ago
Francisco 0ffea62411 Wrote logging functions for SCHED MAC CE/LCID allocations 4 years ago
Pedro Alvarez d05bc064b5 Reduced SCTP connect() timeout.
Added configuration for RTO_MAX. Cleanup debug prints.
4 years ago
Xavier Arteaga c2bc042713 Disable SIMD AVX decoder 4 years ago
Andre Puschmann 43a6cd50e5 rf_imp: fix stopping of AGC thread
hard killing of AGC thread causes issue on some RF devices,
such as the N310. The thread still seemed to access the device while
the radio was already killed (or the streamer object deleted).

It's unclear why this isn't causing similar issues on B210 or X310,
at least not visible, but it is obviously not the correct way to stop a thread.

The patch now correctly sets the stop flag for the AGC thread, wakes it
it up and waits until it has terminated.
4 years ago
Xavier Arteaga 7495986b5c Minor aesthetic changes and fix memory issue 4 years ago
Xavier Arteaga 0396ebae17 Fix UE/ENB DL NR 4 years ago
Xavier Arteaga 8de2870788 Added NR ue_dl, enb_dl and test 4 years ago
Xavier Arteaga 6b5c4148c8 DL Channel estimation results accepts nof RE 4 years ago
Xavier Arteaga ce330a6dfb OFDM's DC is optional 4 years ago
Xavier Arteaga c6a2e4578e Refactored PHY object arguments 4 years ago
Xavier Arteaga e621a1cde3 EVM buffer takes number of bits 4 years ago
Xavier Arteaga a278a49e42 Limit PDSCH-NR unit test 4 years ago
Xavier Arteaga bff71761a9 PDSCH-NR: Added single layer channel equalization 4 years ago
Xavier Arteaga 0138c3b856 PDSCH-NR fixed with unit test 4 years ago
Jesus Gomez 6defd2658c Solve Issue 2: Rate matching zeroes output data prior to soft-combine 4 years ago
Xavier Arteaga fb64c2a460 Initial NR PDSCH encode/decode 4 years ago
Xavier Arteaga 666ba7d590 Added unpacked bit sequence XOR 4 years ago
Xavier Arteaga 6df83c32b3 Added NR layer mapper and demapper 4 years ago
Xavier Arteaga 644758416e DL-SCH-NR adjust unit test 4 years ago
Xavier Arteaga d27f0819a8 Fix DL-SCH for NR 4 years ago
Xavier Arteaga 53282bdfbf Dl-SCH-NR: updated unit test 4 years ago
Xavier Arteaga 4e5edb5168 DL-SCH NR added traces and fixes 4 years ago
Xavier Arteaga 2aa7e43771 Implemented NR DL SCH decoder and unit test 4 years ago
Xavier Arteaga 3464dd3c0d Added MCS table string serializer 4 years ago
Xavier Arteaga 794d1b5c4b Added LDPC decoder RM interface 4 years ago
Xavier Arteaga fa691bb8e3 Fix softbuffer 4 years ago
Xavier Arteaga 27a3e87fb7 Initial DL-SCH encoding 4 years ago
Xavier Arteaga bc66942b8d Bit unpacking input to constant 4 years ago
Xavier Arteaga 9a320baf37 extended resource allocation for NR 4 years ago
Xavier Arteaga 766a43225d 5G FEC extension 4 years ago
Xavier Arteaga 30037d9223 Added guru softbuffer interface 4 years ago
Xavier Arteaga 8e8889032e Changed CRC input vector to constant 4 years ago
Andre Puschmann ff5f215df9 rf_soapy: print warning when using the Lime with shorter sample rates
the Lime has better performance when using the default LTE sample
rates due to filterering being done in the LMS RF chip.

Print a warning when using the Lime with the non-default LTE rates.
4 years ago
Andre Puschmann 2c797fce1a phy_common: add method to check whether we use default LTE symbol size
helpful getter to check whether we've compiled in
or selected at run time to use default LTE sample rates
4 years ago
Xavier Arteaga a6ac80cfbf Initial NR DL DCI Packing/Unpacking 4 years ago
Francisco Paisana bf7c587e4f add UL 64QAM support to eNB RRC and scheduler 4 years ago
Andre Puschmann 5f7f818abb pdu: fix bug in BSR table lookup
the bug causes the BSR to return a bsr_idx of 0, i.e. no data
pending, when the buff_size was reported to be 1 B only.

Instead, the UE should return BSR idx 1, i.e. between 0 < BSR <= 10.
4 years ago
Andre Puschmann 035d989737 pdu: fix unpacking of LCG2 of LBSR MAC CE
LBSR packing is fine but this makes the eNB do wrong things
because it thinkgs LCG2 has no or too much data to send.

LCG2 is our default LCG for DRB1. One occasion we saw the issue
is doing full rate TCP DL which requires quite a bit of ACK traffic
back to the sender. With the BSR for LCG2 being wrong, providing
UL grants was delayed and so the TCP DL throuhgput was very low.

In the log below we see that the buff_size[2]=1 so there is data to send.
Interestingly, the packing was correct so Wireshark displays it correctly.
But the unpacking not, as can be seen in the MAC log below which reports
0 buffer state for all LCGs

22:08:54.804792 [MAC ] [I] [ 5084] pdu_get: sdu_len=1212, channel.sched_len=1213, bsr.buff_size[2]=1
22:08:54.804840 [MAC ] [I] [ 5084] UL LCID=3 len=1212 LBSR: b=0 0 0 0
4 years ago
Xavier Arteaga cf55eb4c4f Improved comments 4 years ago
Xavier Arteaga e8f94c40b8 Added LDPC codeblock segmentation 4 years ago
Xavier Arteaga fc3d154fe3 Fix compilation 4 years ago
Xavier Arteaga 736e6db616 Initial resource allocation for NR 4 years ago
Xavier Arteaga 0439161de6 Removed modulation enum from LDPC RM 4 years ago
Andre Puschmann 6773f6d02f pdu_queue: add reset method to empty queue 4 years ago
Andre Puschmann f155b7a5d5 rlc: fix stopping of poll retx timer (#2006)
* rlc_am: add TC for pollRetx timer handling

* rlc_am: fix stopping of pollRetx timer

stopping the pollRetx timer when receiving a status PDU
without checking the acknowledged PDUs is wrong.

if an ACK for another PDU, for which the polling bit has been set,
is still pending, it won't be rescheduled until another
PDU is transmitted that again starts the pollRetx timer.

this fixes the issue with missing RLC AM segment retx in #1992,
and #2003
4 years ago
Andre Puschmann 7cf919e2af Fix MAC PDU packing after sending Truncated BSR (#2004)
* mac_test: add extended TBSR unit test

unit test to MAC UL packing after sending a TBSR

this fixes the MAC issues described in issue #2002

* mux: fix updating of LCG buffer state after packing PDU

we've previously lowered the buffer state of the LCG according
to the bytes that have been scheduled, but not according to
those that have been actually included in the PDU.

* proc_bsr: fix LCG buffer state updating for TBSR

when sending a TBSR do not update the internal buffer
state of the BSR proc.

This caused issues because the buffer state for all LCG that
are not included in the TBSR are set to zero, although at least
one LCG does have data to transmit.

* rlc_am: include LCID when logging retx of SN
4 years ago
Andre Puschmann 1b97ba5300 benchmark_radio: fix duration and thread priority
I noticed that the app didn't configure the process with
RT thread prio. But it then turned out that in order to do
that we need to actually spawn a new thread. Also a few other things
didn't work out of the box.

In summary the changes are:
* fix duration to support more than 120s
* move main functionality in thread
* set high priority for radio thread
* only return success if no radio errors occured
4 years ago
Francisco Paisana 510959b50f update nr asn1 files, and asn1 tests 4 years ago
Xavier Arteaga 8d9577626b Fix NR FEC unit test 4 years ago
Xavier Arteaga 0c2f96d389 Fix 5G NR FEC memcheck 4 years ago
Xavier Arteaga 2835e87ff0 Add missing file 4 years ago
Xavier Arteaga f8dd67260f Polar: fix unit test working directory 4 years ago
Xavier Arteaga 15356b3ec8 Fix compilation for non-AVX2 machines 4 years ago
Xavier Arteaga 2c4aa1e379 Added Polar and LDPC forward error correction 4 years ago
Xavier Arteaga 4f89c6ed3f Added missing CMakeFiles 4 years ago
Xavier Arteaga f21590735d refactored FEC directories 4 years ago
Xavier Arteaga 7093a85f81 Refactored FEC directories 4 years ago
Xavier Arteaga c2621cc4f8 Protect ring-buffer write from nullptr 4 years ago
Andre Puschmann f647343f18 rlc_am: fix poll bit during header reconstruction
this makes sure that the reconstructed RLC AM header
has the poll bit set when any of its segments had it set.

this triggered a bug in RLC AM because the Status PDU
isn't transmitted for a RLC PDU that was segmented and
only the first segment had the P flag set.
4 years ago
Francisco Paisana b40a5a958e use common function to fill rrc reconf message in handover 4 years ago
Francisco Paisana e9b693942f diff-based cell selection activation 4 years ago
Francisco Paisana 836e7d7ede refactor scell addition in the srsenb::rrc to follow the same style of other rrc recfg fields 4 years ago
Francisco Paisana 97f2e4336e refactor of functions for filling the asn1 radio resource config structs. This functions are used during rrc setup/reest/reconf 4 years ago
Xavier Arteaga 9487d27ef9 Renamed NR constants and comments 4 years ago
Xavier Arteaga e8f168b20c PDSCH NR: Added files 4 years ago
Xavier Arteaga c8477483d9 PDSCH NR: Added files 4 years ago
Xavier Arteaga 30d8e05d50 Fix PDSCH-DMRS symbol index 4 years ago
Xavier Arteaga 8d34d344a8 Created PDSCH-NR configuration structures and refactored DMRS 4 years ago
Xavier Arteaga 009f300c5e Initial PHY Data procedures 4 years ago
Xavier Arteaga 775692f461 Rearanged PDCCH NR functions structures 4 years ago
Xavier Arteaga 937c52339d Added PDCCH DMRS estimation and measurement 4 years ago
Xavier Arteaga 5799100e42 FFT based Resampler admits NULL inputs/outputs 4 years ago
Xavier Arteaga 44ae70dcc6 Initial implementation of the 5G NR PDCCH DMRS encoding 4 years ago
Xavier Arteaga 29ad2427d9 Initial implementation of the 5G NR PDCCH DMRS encoding 4 years ago
Xavier Arteaga 579526f1fe Added sequence advance without generating data 4 years ago
Xavier Arteaga eba20b6367 Radio: fix frame overlap at start-of-burst 4 years ago
Xavier Arteaga be400503b9 Add pass criteria to PRACH USRP test 4 years ago
Xavier Arteaga 28bb4709ff Solved possible high impact PHY out-of-bounds issues 4 years ago
Pedro Alvarez e4f143059e Simple log fix to make it easier to compare PDCP RX and TX. 4 years ago
Andre Puschmann 0740154bff rrc,sync: fix two uninit vars
detected by Valgrind when running UE with TDD cell
4 years ago
Andre Puschmann 723ca2dd48 ra_dl: fix TDD reference symbol extraction
reported/provided by user softdev86 in https://github.com/srsLTE/srsLTE/issues/566

author tested with local 4 port cell. I am not able to verify locally but
it looks ok, we'll revise later if needed.
4 years ago
gracid f67a152a2a Remove unnecessary Lime calibration step from Soapy implementation
When using srsLTE with Lime devices, calibration was performed before any configuration steps have happened, thus making calibration values invalid. Removing Lime specific calibration step from rf_soapy_imp makes so that devices will be automatically calibrated by SoapyLMS on rf_soapy_start_stream call.

Tested and working with srsENB using LimeSDR-USB v1.4 and LimeSDR-Mini v1.2 boards.
4 years ago
gracid 78b63c9465 Set same antennas for all Soapy channels
This commit adresses an issue where two or more channels could have different antennas, despite being explicitly set in the configuration file
4 years ago
Francisco Paisana 4cb6ed27eb updated scheduler ue mcs computation to account for new 256QAM tables 4 years ago
Xavier Arteaga fac6d40a45 SRSENB: fix PUSCH max number of iterations 4 years ago
Xavier Arteaga 791c979063 Vector: fix cf to cs conjugate conversion 4 years ago
Andre Puschmann 5e7de0a95b cmake: install individual libraries (common, phy, etc)
this seems to be important for package maintainers
or people who use srslte components in other projects
thar require to link against static libs

so besides installing headers, the apps and the RF lib, we also
install all individual libraries

this fixes https://github.com/srsLTE/srsLTE/issues/500#
and https://github.com/softwareradiosystems/srsLTE/issues/1754
4 years ago
faluco 8376111419 - LGTM fixes. 4 years ago
Xavier Arteaga caf37b8e62 Added serving cell index in UCI/CSI report trace 4 years ago
Douglas Anderson fe21b2717c Fix "Comparison is always true because ret >= 0" LGTM warnings
... and refactor out some other dead code in the vacinity of these warnings
4 years ago
Andre Puschmann 1a03839f78 rlc_am_lte: fix potential bug when setting uint32_t to -1
discovered in Coverity CID 359664
4 years ago
Andre Puschmann 5a31c5765b rf_soapy: fix auto selection of Soapy device
when the default RF args are used, NULL is passed as argument
to the RF driver. In this case, we should use the previous
SoapySDRDevice_enumerate() and let Soapy pick the device
4 years ago
Xavier Arteaga ca6566ad46 Fix PUCCH format1b false detection 4 years ago
Pedro Alvarez b43e724b4c Remove packing/unpacking code for M2AP. 4 years ago
Jan Remeš 8c7b7cc55a libsrslte_rf: add library version
This patch adds version string to the 'libsrslte_rf' library.
This results in the library being built as
    libsrslte_rf.so.20.04.2
with the following symbolic links
    libsrslte_rf.so.0 -> libsrslte_rf.so.20.04.2
    libsrslte_rf.so -> libsrslte_rf.so.0

The SRSLTE_SOVERSION variable should be increased with each backwards
incompatible change of the library.

Signed-off-by: Jan Remes <jan.remes@invasys.com>
4 years ago
yagoda 615af5cc4d setting seed to constant in prach test 4 years ago
Andre Puschmann b08a586fd4 pdu: refactor error logging
just some refactoring of error messages when a PDU packing error occurs
4 years ago
faluco 693d2f10b7 - Fix hex dumps newlines. 4 years ago
Pedro Alvarez 2f0125ef4e Fix issue recovering key state, when the first HO fails (specifically, is_first_ncc was not recovered). Minor improvements in key logging. 4 years ago
faluco 079ae70e64 - Fix logs entries having two newlines instead of one. The old log formatter will delegate this to the new one. 4 years ago
Andre Puschmann f73fa47a7b pdu: fix printing of buffer state of long BSR
extracted wrong number of bits for 2nd LCID in long BSR
4 years ago
Xavier Arteaga ef9d77c966 SRSUE: add PRACH config present field in PHY configuration structure 4 years ago
faluco 51b27fc255
Import latest srslog version (#1796)
* - Import latest srslog version.
- Adjusted the nas_test to create logs correctly.
- Remove timestamp formatting now that is provided by srslog.
4 years ago
Ismael Gomez 4e88daae21
Set DCI unpacking errors to info (#1781) 4 years ago
faluco 85544bb8d3 - Remove unnecessary newline character and optimize the code to use fputs instead of fprintf since no formatting is required. 4 years ago
faluco dfeed52514 - Rename out_stream function to console. 4 years ago
faluco 62faef7c71 - Replaced all uses of the log::console method. 4 years ago
faluco 302f9793ca - Add common utils to print to stdout and stderr as a first step to remove the log::console method. 4 years ago
Andre Puschmann 795db30338 pdcp: drop PDCP control PDUs
this patch adds a check to drop all PDCP control PDUs
in order to prevent handling them as data PDUs.

This could happen when the size exceeded the arbitrary length check.

This should fix #1787
4 years ago
Xavier Arteaga d375e305ec Initial NR DMRS for PDSCH 4 years ago
Ismael Gomez 76bfc78147
Fix issues with Sounding-RS (#1761)
* Fix deadlock caused by update_measurements calling in_sync

* Fix overlapping SRS condition

* Do not use shortened PUSCH in transmissions and retx from RAR

* Revert "Fix deadlock caused by update_measurements calling in_sync"

This reverts commit f58c8c8c766f8f95baa3a3bf8287d8e25b2057ba.
4 years ago
Ismael Gomez b94d24ed98
Take into account CRS from neigbhour cells when measuring interference (#1757)
* Take into account CRS from neigbhour cells when measuring interference

* fix std::isnormal compilation

* Fixed compilation of test

* Address comments

* Remove unused overrides
4 years ago
Xavier Arteaga 236ef4378d Fix u32 parsing 4 years ago
Xavier Arteaga ede58319ae Vector: added conjugate complex float to short 4 years ago
Xavier Arteaga 8566cbb079 Added device name to prach_test_usrp 4 years ago
Xavier Arteaga 60d563aa06 Fix ringbuffer read conversion 4 years ago
Xavier Arteaga eb5210dbda Radio stops Rx stream prior to stop and benchmark prompts RF metrics 4 years ago
Xavier Arteaga de0501cc55 Fix radio benchmark 4 years ago
Xavier Arteaga c20d4ff5cc Added ringbuffer zerocopy a timeout 4 years ago
Xavier Arteaga 759719ad55 Improved RF helper 4 years ago
faluco f0d651ae8e - Fixed a leak in the MME class not releasing the static byte buffer pool.
- Now the pool gets destroyed on program exit using a unique_ptr.
- Removed manual cleanup() calls in all the code base to free the pool instance.
4 years ago
faluco b892da0294 - Calculate the FFT of the PRACH on demand.
- Fixed a PRACH test that was failing with ASAN.
4 years ago
Xavier Arteaga 8cb3945886 SRSUE: fix RV assertion for PUSCH 4 years ago
Xavier Arteaga 44c2412be2 SRSUE: silent PUSCH encoding error by dropping invalid grant 4 years ago
Andre Puschmann 9dd02af15c network_utils: lower verbosity of when socket connection fails
the network helper can log this event but it should be up to
the caller to decide whether this is an error or not.
4 years ago
Andre Puschmann 33c050791f pdu: add missing to_string() content for MAC SCH PDU subheaders
* add both scell activation CE
* add rnti to CRNTI and CONT RES CE
4 years ago
Xavier Arteaga 1d71cf8557 Avoid zero division 4 years ago
faluco 1860006203 - Fixed leaks in prach module spotted by asan. 4 years ago
yagoda 24574caf44 cleaning up the PRACH time offset calculation 4 years ago
yagoda b5a8d82058 -adding more prach tests to make test, removing some variables from stack
-PRACH time offset to TA unit conversion
4 years ago
yagoda 59082770d3 moving some arrays to the heap, fixing formatting, setting dft norm 4 years ago
yagoda f6ea431555 -adopting new PRACH equalization approach for successive cancellation
-adding frequency domain time offset detection
-adding to testing of PRACH
4 years ago
yagoda ec7873e7cc refactoring PRACH, adding phase correction to successive cancellation 4 years ago
yagoda 4d8888aae6 - adding simple successive cancellation to PRACH detection
- adding testing for same and for offset detection
4 years ago
Ismael Gomez 1bd3e76f98 Move unncessary buffer in radio 4 years ago
Ismael Gomez c4080e35cc Set different timestamp behaviour for X300 and B200 4 years ago
Andre Puschmann d48bc8837e pdu: refactor MAC PDU class
this patch refactors the MAC PDU class, the main changes are:

* add to_string() method to pretty print PDU and subheaders
  This allows to have a single log entry per MAC PDU with all its
  contents.
  It removes the C-style fprint() method

* Simplity payload vs. w_payload_ce
  Before we've used payload when reading the PDU and w_payload_ce
  as a buffer when writing. In all getters we needed to differentiate
  between both. Now payload points to w_payload_ce initially and is
  only updated when parsing a new PDU.

* add various helpers, e.g. to get subheader index, update a BSR, ..

* fix PDU test to use new to_string() method
4 years ago
Ismael Gomez 54eed11e1d Refactor decision for extended CSI/SRS 4 years ago
Ismael Gomez c9daf1f61a Make const args 4 years ago
Ismael Gomez e2154d2213 Renamed constants to SRSLTE and use SRSLTE_CFI macros 4 years ago
Ismael Gomez 38e2ffe414 Use Format1A when using CA and 15 PRB due to DCI size ambiguity 4 years ago
Ismael Gomez 51521ad8e4 Improved PDCCH blind search and fixed a few issues with ambiguous DCI size with Release 10 4 years ago
faluco db03275337 - Fix compiler errors when trying to build the project without SIMD support. 4 years ago
Xavier Arteaga 1f18e8a054 SIMD: frequency estimate optimization 4 years ago
Xavier Arteaga bf1b7b8527 SIMD: fix NEON compilation 4 years ago
Ismael Gomez 0afcea9d61
Do not allow empty TBS PUSCH. Account for CQI from inactive cells before activated. (#1667) 4 years ago
Xavier Arteaga 080543815f Solved compilation warnings and enb_phy_test stop 4 years ago
Xavier Arteaga b8f4d03979 Fix in SIMD frequency estimation 4 years ago
Xavier Arteaga 611dd67364 SRSENB: PUCCH TA measurement only available with detected PUCCH 4 years ago
Xavier Arteaga 87edafeddb Reduced SRS test cases to SF index 0 4 years ago
Xavier Arteaga ee6f24befe Optimize vector frequency estimation 4 years ago
Xavier Arteaga bc0aba0d8a SRSENB: calculate TA from PUCCH messages 4 years ago
Andre Puschmann 49a7a90698 mac: simplify BSR packing logic
simplify logic to check whether a BSR fits and, if so, which type.
before the check has been done in two places.

we now also accomodate for the CE subheader size.
4 years ago
Xavier Arteaga 1843c9efbc SRSENB: PUCCH TA measurement only available with detected PUCCH 4 years ago
Xavier Arteaga 3aec23f7d8 SRSENB: calculate TA from PUCCH messages 4 years ago
Xavier Arteaga df2c949417 Radio: add individual Rx gain and integrate in srsue
Fix compilation

Fix compilation

Add missing variable. Wasn't compiling

Radio: revert some changes
4 years ago
Xavier Arteaga 04d7267734 UHD: Force LO frequency option 4 years ago
Xavier Arteaga b3d66c98c3 SRSENB: tx gain per channel and fix bug 4 years ago
Andre Puschmann 3f02e56a1e uhd: do not stop rx_stream when setting rx_rate for the B210
with the B210 and 2 RF ports, i.e. MIMO mode, we have stopped the
Rx stream after changing the rx_samp_rate but didn't start it again.

Either the issue doesn't exist in SISO mode or we never saw it but for MIMO
it can be reproduced easily with rate changes during streaming, i.e.:

$ ./lib/src/radio/test/benchmark_radio -p 2 -t 10 -x -y -s 23.04e6
Instantiating objects and allocating memory...
Initialising instances...
Opening 2 channels in RF device= with args=default
[INFO] [UHD] linux; GNU C++ version 9.2.1 20200304; Boost_107100; UHD_3.15.0.0-2build5
[INFO] [LOGGING] Fastpath logging disabled at runtime.
Opening USRP channels=2, args: type=b200,master_clock_rate=23.04e6
[INFO] [B200] Detected Device: B210
[INFO] [B200] Operating over USB 3.
[INFO] [B200] Initialize CODEC control...
[INFO] [B200] Initialize Radio control...
[INFO] [B200] Performing register loopback test...
[INFO] [B200] Register loopback test passed
[INFO] [B200] Performing register loopback test...
[INFO] [B200] Register loopback test passed
[INFO] [B200] Asking for clock rate 23.040000 MHz...
[INFO] [B200] Actually got clock rate 23.040000 MHz.
[INFO] [MULTI_USRP]     1) catch time transition at pps edge
[INFO] [MULTI_USRP]     2) set times next pps (synchronously)

Warning: TX gain was not set. Using open-loop power control (not working properly)

Setting manual TX/RX offset to 0 samples
Start capturing 10000 frames of 23040 samples...
Changing sampling rate to 23.04 Msamps/s
Setting manual TX/RX offset to 0 samples
Changing sampling rate to 1.92 Msamps/s
Setting manual TX/RX offset to 0 samples
/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1211: Error timed out while receiving samples from UHD.

/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1211: Error timed out while receiving samples from UHD.

/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1211: Error timed out while receiving samples from UHD.

/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1211: Error timed out while receiving samples from UHD.

/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1211: Error timed out while receiving samples from UHD.
4 years ago
Andre Puschmann 7253efe17e rf_blade: fix memleak when device wasn't found 4 years ago
Andre Puschmann 9684b2a63a uhd: fix memleak when USRP wasn't found 4 years ago
Andre Puschmann c327a18f59 radio: fix memleak of dummy buffers 4 years ago
Ismael Gomez 59b9125d4e
Do not send time_spec in between the burst. X300 does not like it (#1583) 4 years ago
Ismael Gomez a4835dd2c8
More accurate MCS reduction when PUSCH carries UCI (#1630) 4 years ago
Xavier Arteaga bd46c40650 srsLTE: fix minor aesthetics 4 years ago
Xavier Arteaga 7bad21c30a Radio: added locks to protect sample rate change concurrent access 4 years ago
Xavier Arteaga 029f36b449 srsLTE: added efficient integer resampler and srsue/srsenb integration 4 years ago
Xavier Arteaga 0e96ef3df0 Channel emulator takes SNR as input parameter 4 years ago
Andre Puschmann 9149cf852d rf_uhd: fix rx timeout error after late with B210
it fixes #1623.

this happens more often with MIMO since lates are more likely here.

after a late, the Rx stream must not be stopped on the B2xx either.

<log>
RF status: O=3, U=0, L=1
/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1209: Error timed out while receiving samples from UHD.

stop rx stream
./home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1209: Error timed out while receiving samples from UHD.

stop rx stream
/home/anpu/src/srsLTE/lib/src/phy/ue/ue_sync.c.775: Error receiving samples

/home/anpu/src/srsLTE/lib/src/phy/ue/ue_cell_search.c.312: Error calling srslte_ue_sync_work()

/home/anpu/src/srsLTE/lib/src/phy/ue/ue_cell_search.c.272: Error searching cell
</log>
4 years ago
Andre Puschmann 5e40bfe72c mac_pdu: unpack and print BSR index as well as BSR value in bytes
before the BSR was extracted but the actual index (between 0 and 63)
was not stored but directly converted into bytes.

for log parsing and debugging it is easier to follow the index
value. this patch therefore adds both values to the log message
and extends the API accordingly.
4 years ago
Andre Puschmann 55336665b9 rlc: remove timers and sdu queue length from RLC TM ctor
timers aren't used in RLC TM, also the default queue length is
fine to be used at all times.
4 years ago
Andre Puschmann 8e44d0504c radio: fix device mapping for mimo
commit #51c6e8d1 introduced a regression in which the 2nd antenna
port was never considered. All MIMO ZMQ based tests therefore failed.
this fixes #1608
4 years ago
Xavier Arteaga 710700d0eb SRSUE: Fix synch error correction for multiple channels 4 years ago
Andre Puschmann d5da4bd8b6 radio: fix printf for 32bit 4 years ago
Francisco Paisana 7605c7df23 added s1ap handover notification, fixed s1ap asn1 bug, and fixed bad fields for admitted erabs in ho req ack 4 years ago
Francisco Paisana 26f46ea067 add S1 Handover Request handling in target eNB 4 years ago
Andre Puschmann cb2d7f4c16 rf_uhd_generic: add explicit ctor and dtor
clang 6 complained about a missing virtual dtor and thus
failed compilation. this patch adds both, an explicit ctor and dtor.
4 years ago
Andre Puschmann 498af989bf rf_uhd: add missing endl to UHD log macros 4 years ago
Xavier Arteaga 46ab07123d UHD: fix compatibility with 3.9.7 LTS 4 years ago
Andre Puschmann 5867668c0c rf_uhd_rfnoc: fix compilation for UHD before 3.15
the enable_rx_timestamps() for the radio_ctrl object has only been
introduced in Nov 2019 for UHD 3.15 and therefore needs
to be excluded when compiling for 3.14 and below.

Note: According to the original UHD commit in
67dbaa41f2 (diff-60a9387c0fc8406fd5b39fa995dd8c14)
it looks like the Rx timestamps are disabled by default
for UHD versions before 3.15

This commit fixes #1602
4 years ago
Xavier Arteaga 0cd61145ca RFNOC: added optional FPGA FIFO 4 years ago
Xavier Arteaga 237de07ab3 UHD: disable AD936x based device reset 4 years ago
Xavier Arteaga ff8925b6ec UHD: use same timeout policy than previous release 4 years ago
Xavier Arteaga ac76a398fe UHD: Minor stability improvement 4 years ago
Xavier Arteaga d2abaaf719 UHD: add initial test for AD936x based devices during initialization 4 years ago
Xavier Arteaga f80c779d88 RFNOC: added DUC/DDC internal loopback option and test 4 years ago
Xavier Arteaga dcf05f7a53 UHD: Improved RFNOC 4 years ago
Xavier Arteaga 38d9545e99 UHD: API improvement 4 years ago
Xavier Arteaga 405e0c8195 UHD: Check if tree exist before requesting access 4 years ago
Xavier Arteaga 5d43fc903e UHD: fix SPP equal 0 4 years ago
Xavier Arteaga 774c0926a6 UHD: added device args for log level, spp and return if timeout 4 years ago
Xavier Arteaga 88a1ab12c5 UHD: Generic detects if it a AD9361, USB based device and resets if LIBUSB_TRANSFER_ERROR is detected 4 years ago
Xavier Arteaga 04a661d239 UHD: RFNOC class detects custom DDC and DUC 4 years ago