5g-team
/
srsRAN_4G
mirror of https://github.com/pvnis/srsRAN_4G.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
8,190 Commits
2 Branches
0 Tags
243 MiB
fix-cqi
master
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'c23034e1a7'
${ noResults }
Commit Graph

2091 Commits (c23034e1a7d4f1388ea70fdc93dd1dbc62642188)

Author SHA1 Message Date
faluco ac62e3c398 Fix the priority of logging levels in places where we before logging we check if a certain log level is enabled. 4 years ago
Andre Puschmann cbedb65247 nas: log warning when NAS timer expires 
this allows to let test cases fail based on warnings when
NAS events/actions timeout
 4 years ago
Andre Puschmann dadb34f0ab rrc: fix missing newline in console output 4 years ago
Andre Puschmann 1aadc5c53e mac_nr: tiny cleanups of MAC class, use of new logger 4 years ago
Andre Puschmann 73cb0dabf2 mac_nr: move UE MAC class into own subfolder 
this should simplify further MAC NR extensions and lead
to a more organized folder structure
 4 years ago
Andre Puschmann 1a23b2f9bb ue: don't show NR PDSCH constallation plot in normal EUTRA mode 
only initialize NR PDSCH plot when nof NR worker is greater 0
 4 years ago
Andre Puschmann da9e3363f1 mac_pdu_nr: rename MAC PDU class for NR to adhere naming conventions 
* mainly to have _nr as trailing name for filename and class
* also add "sch" to class and filename (RAR PDU will have extra class)
 4 years ago
Andre Puschmann cc750d96ee nas: when receiving detach request, don't enter plmn_search automatically 
this patch fixes an issue with TC_9_3_1_17 after the "send attach in RRC connected" issue
has been fixed. The TC failed because the UE would always attempt to re-attach, even
after receiving an explicit detach request WITHOUT re-attach from the network.

According to TS 24.301 Sec. 5.5.2.3.2 the handling of that message largely depends
on the detach cause sent by network. Since we don't currently parse and handle
that the simplest solution here is to just enter deregistered:::null.

The patch is also part of the fix for issue #2237
 4 years ago
Andre Puschmann 2576ada9e1 nas: do not abort attach procedure if RRC is already connected 
this is an attempt to fix issue #2237 that cause the UE to fail to
attach because the attach request wasn't resent after T3410+T3411
expired.

this was only because RRC wasn't idle at that stage and the attach
request generation was aborted.

The patch fixes this by passing the NAS PDU directly to RRC in
connected state.

The patch also converts the blocking PDU alloc to a non-blocking one.
 4 years ago
faluco 5981469f9f
Upgrade loggers in srsue (#2163) 
* Replaced UE logger in the ue class.

* Replaced loggers in the main phy class and prach.

* Replaced loggers in phy common and ta_control.

* Replace loggers in cc and sf workers.

* Replaced loggers in intra_measure, scell_recv, search, sfn_sync, sync.

* Remove last uses of the old loggers in the main phy class.

* Remove stray newline in logs.

* Replaced loggers in ue gw.

* - Started to replace loggers in the ue stack.
- Replaced loggers in usim and pcsc.
- Adapted nas and usim tests.

* Replace loggers in nas.

* Added missing log init calls in two previously modified tests.

* Replaced logger in nas idle procs.

* Replaced loggers in nas emm state.

* Replaced loggers in tft packet filter and adapted tft test.

* Replaced loggers in main RRC class.

* Replaced loggers in RRC cell.

* Replaced loggers in RRC meas.

* Replaced loggers in rrc procedures.

* Started logger replacement in MAC layer, more precisely in demux and dl_harq classes.
Been unable to inject loggers in construction for dl_tb_process due to very weird static assertions in the std::vector code being the type not constructible which is not true, so instead use the main MAC logger directly.

* Replaced loggers in mac mux class.

* Replaced loggers in mac pro_bsr.

* Replaced loggers in mac proc phr.

* Replaced loggers in mac proc SR and RA.

* Replace loggers in mac UL HARQ.

* Replaced loggers in main ue stack class.

* Fixed nas test crashing due to a null string.

* Ported mac_test to use the new loggers.

* Removed TTI reporting for the PHY log as the old logger did.

* Replaced loggers in UE phy tests.

* Configure loggers in nas_test.

* Replaced loggers in rrc_meas_test.

* Replaced loggers in rrc_reconfig_test.

* Added missing newline in tft_test.

* Fix compilation errors in TTCN3 tests.

* Fix linker error detected in CI and warning.

* Replaced loggers in TTCN3 tests.

* Fix a text replace error in some log messages.

* Remove trailing newlines from log entries.

* Remove old logger from rrc.

* Flush backend before printing the test status.

* - Fix compilation error from previous rebase.
- Remove trailing newlines from some missing log entries.
 4 years ago
David Rupprecht 42aa5c4499 Fixed order to set c1 ind ul_dcch_msg 4 years ago
Andre Puschmann 4709bacefd srsue: add DL NR-ARFCN param 
* add PHY param to set DL NR-ARFCN
* use new band_helper class to convert ARFCNs to supported bands
* signal supported NR bands in UE capabilities
 4 years ago
David Rupprecht 9ccc36d4fa Make fake measurement frequency depend on measurement config 4 years ago
David Rupprecht 1b19ee40e7 Added usim features for key derivation 4 years ago
David Rupprecht ceda458bb3 Added MAC NR to EUTRA and NR with stack interfaces including MAC config build 
Moved MAC logical channel config to MAC interface types
 4 years ago
David Rupprecht e0420049e3 Build infrastucture for reconfig 4 years ago
David Rupprecht 64299960bd Added procedure for NR reconfiguration and RRC with NR complete 4 years ago
David Rupprecht 99c3aa9ba2 Refactor assert to TESTASSERT in unit test 4 years ago
Xavier Arteaga 13c594651e Apply minor NR GUI comments 4 years ago
Xavier Arteaga 2baccc8b13 Set NR-PDSCH default table to 256QAM 4 years ago
Xavier Arteaga 3ee667c4a5 SRSUE: added NR-PDSCH constellation in GUI 4 years ago
Xavier Arteaga 59114206ae SRSUE: Unify PRACH reconfiguration conditions 4 years ago
Andre Puschmann a09fb95c25 proc_ra: protect RA procedure from concurrent thread access 
that patch addreses issue #2199 by defering RA-related calls that
are executed from within PHY workers.

The time-critical bits of more complex functions such as tb_decoded()
are still executed in the PHY worker thread but the state machine
manipulation is defered.
 4 years ago
Ismael Gomez a6423442c2
Refactor NR RA files and fix header includes all over library (#2162) 
* Refactor NR resource allocation classes. Use DCI instead of grant for dummy PDSCH UE/eNB test

* Minor refactors in NR workers and ue_dl

* Fix include issues

* fix compilation issues
 4 years ago
Xavier Arteaga 8a3d70f6da Fix intra-cell measurement ringbuffer overflow 4 years ago
Ismael Gomez a360580999 Run PRACH workers before cc_workers fixes memory corruption when PRACH workers run in foreground (eg in ZMQ) 4 years ago
David Rupprecht a89477a805 Hardcoded Samsung caps can be activated with if 1 in rrc_nr.cc 4 years ago
David Rupprecht bc2e230461 Enable UM mode for Amarisoft 4 years ago
David Rupprecht da0e64c51a Add non_crit_ext for irat parameter 4 years ago
David Rupprecht ffe513415c stop gw in srsue nas test 4 years ago
David Rupprecht 1a10c783b5 Faking measurements 4 years ago
David Rupprecht f7d313147a Added infrastrukture for measurements 
Init rrc_nr as part of the LTE stack
 4 years ago
David Rupprecht 4305929ec7 Hardcoded NR/MRDC-Capabilities 4 years ago
David Rupprecht b79eef0860 Introducing nr_rrc <-> rrc interface for eutra and nr cap query 4 years ago
David Rupprecht 020d0dacc8 add the additional sec cap to NAS attach request 
use same capabilities that are signaled for EUTRA
 4 years ago
David Rupprecht 9eb0b72cb4 Added rrc function has_nr_dc 4 years ago
Andre Puschmann 37fc1c59e3 fix DRB release logging 
this caused wrong logs because the LCID was printed based on the assumption
that the DRB LCID is alwasy 2 + drb ID

Use drb_id as drb_cfg key
 4 years ago
faluco 63bd43fa52 Upgrade the swapping logic of the file sink to use the new srslog functionality. 4 years ago
Xavier Arteaga b3200d9ef5 Renaming common UL/DL DMRS related types and initial NR PUSCH implementation 4 years ago
Andre Puschmann 52da9eb46f srsue,phy: fix setting of PHY log level 
probably a regression from the new log system integration.
it was disabling PHY logs, from PRACH for example.
 4 years ago
Andre Puschmann 3573644624 srsue: fix stdout metrics print when scells aren't configured yet 
during MAC reset, scells are reset to and their PCI is set to UINT32_MAX
which results in malformatted stdout prints, see below:

Random Access Transmission: seq=16, ra-rnti=0x2
Random Access Transmission: seq=14, ra-rnti=0x2
 0   4   -24    24  -1.1u   1.0   140  0.50    0.0     0%   0.0   0.0    0.0    0.0    67%
 14294967295   0.0   0.0  -1.1u   0.0   0.0   0.0    0.0     0%   0.0   0.0    0.0    0.0     0%
 24294967295   0.0   0.0  -1.1u   0.0   0.0   0.0    0.0     0%   0.0   0.0    0.0    0.0     0%
 34294967295   0.0   0.0  -1.1u   0.0   0.0   0.0    0.0     0%   0.0   0.0    0.0    0.0     0%

this patch checks the configured PCI value against UINT32_MAX and
prints "n/a" in case the scells aren't set yet.
 4 years ago
Xavier Arteaga 909e5de34f Fix NR workers 4 years ago
Francisco Paisana e27c0869e5 update RRC ASN1 to 2020-09 v15.11 4 years ago
Francisco Paisana 6803f48cc0 cell selection and reest rrc procedures were causing a callstack reentrancy problem. This issue was circumvented with a defer_task call 4 years ago
Andre Puschmann c8801578df gw: use std::chrono for metrics and fix nan display 
* replace gettimeofday with std::chrono
* fix nan printing when nof_tti is zero (at startup)
 4 years ago
David Rupprecht 81609d48dd Added measurment report for interrat nr15 
Added function for removing interrat triggers
 4 years ago
David Rupprecht 5df2fb1fa1 Added rrc has nr neighbour cells 4 years ago
David Rupprecht 0e4d77da76 Refactor eutra reporting code and add report triggers for inter rat measurements 4 years ago
David Rupprecht e4e67eebce Added infrastucture to process measurments and evaluate interrat triggers 4 years ago
David Rupprecht 25e5b88704 Added NR range_to_value function and debug logging for measurements 4 years ago
David Rupprecht ce4526a935 Extended measurements interrat nr r15 testcase with measurements 4 years ago
David Rupprecht 826dd32c89 Rename meas_cell to meas_cell_eutra 
Added meas_cell_nr class

Make meas_cell list as template class

Inheritance rrc_cell to meas_cell_nr
Added process_new_cell_meas_nr function
 4 years ago
David Rupprecht 62b558fccf Move rat type to common header 
Removed phy measurement from rrc interface phy

Updated rrc interface for handling measurements
 4 years ago
Francisco Paisana 0f693b36b2 changed pdu latency calculation to std chrono 4 years ago
Codebot 43082e8d6a enb/ue: turn various warning messages into info 
turn events that may happen in the normal life of a eNB/UE
into info rather than warning to allow strict
warning/error checking in tests.
 4 years ago
David Rupprecht 848496bb0f Moved get_earfcn to srslte get_carrier_freq func 4 years ago
David Rupprecht d4fb2dfb16 Added handling of inter rat measurement config function 
Make report config more agonistic
 4 years ago
David Rupprecht 2e51cfc1a5 Added black cells with index function 
Added new index functios
Use asn1 list functions for toAddMod and toRem lists
 4 years ago
David Rupprecht f4b0042c10 Added minimal interrat and nr measurement testcase 
Added the handling of nr_r15 meas config
Added seperate handling of reportConfig for eutra
 4 years ago
Andre Puschmann ab598dae3b gw: calculate GW throughput based on TTI timing 
similiar like the RLC patch, MAC TTIs are passed to GW so the
rx/tx rate can be calculated based on the LTE timing
 4 years ago
Andre Puschmann c0883291f6 rlc: pass TTI to get_metrics to calculate "real" LTE rx/tx rate 
when retrieving the RLC metrics, the number of TTIs since the last
call are passed. This allows to calculate the actual rate
based on the LTE timing rather than only the system timing.
 4 years ago
Andre Puschmann 1de2abb5f7 sync: log TTI and TTI jumps before calling Stack thread 4 years ago
Andre Puschmann 346c07a9f2 sync: update log TTI before logging first message 4 years ago
Xavier Arteaga c635b1e467 Initial NR DCI blind-search 4 years ago
Xavier Arteaga ebd87e63c0 Fix worker NR compilation 4 years ago
Xavier Arteaga d5d3594f49 Removed unused attribute 4 years ago
Xavier Arteaga d72820ddaa SRSUE: fix compilation 4 years ago
Xavier Arteaga f9643843a0 SRSENB/UE Fixed NR workers 4 years ago
Xavier Arteaga b501f2eeaf SRSENB/UE: Added NR workers 4 years ago
Xavier Arteaga ac930003be SRSUE: Integrated NR workers 4 years ago
Xavier Arteaga a908fb6c5b Fix NR srsue/srsenb. Initial PHY NR in SRSENB. 4 years ago
Xavier Arteaga 2b2db90933 SRSUE: initial NR workers 4 years ago
Xavier Arteaga 85afdf8ce3 SRSENB: moved phy workers to lte worker pool 4 years ago
Xavier Arteaga eed9405e40 Moved NR MAX MIMO layers to carrier 4 years ago
Xavier Arteaga df5e3414dc Fix segmentation fault 4 years ago
Xavier Arteaga c6798653be SRSUE: created initial PHY LTE worker pool 4 years ago
Andre Puschmann 07d2bc4fe8 change license header to agnostic version with hint to root LICENSE file 4 years ago
Xavier Arteaga 53d8319d2b SRSUE: protect secondary serving cell synch from concurrent access 4 years ago
Xavier Arteaga 287e651ef1 SRSUE: Protect nullptr buffer in secondary serving cell synch 4 years ago
Xavier Arteaga 6d3bf7089f SRSUE: use available carriers for inter-frequency measurement 4 years ago
Francisco 66712023bb remove unneeded includes of full rrc asn1 lib 4 years ago
Pedro Alvarez 6929883649 Added mutex and condition_variable to srsUE's nas_test to avoid race condition on thread initialization. 4 years ago
Xavier Arteaga 959f37ae81 SRSUE: Renamed PHY scell_state to cell_state 4 years ago
Xavier Arteaga 008ef3c10c Fixed override methods in MAC test 4 years ago
Xavier Arteaga 4b8cd7ce92 SRSUE: protect scell state 4 years ago
Xavier Arteaga c5cb4d9984 SRSUE: Added time accurate SCell activation 4 years ago
Xavier Arteaga f64c268a69 SRSUE: Refactored MAC/RRC SCell Activation/Deactivation 4 years ago
Andre Puschmann 35373d1385 enb,ue: add cmdline arg to enable usage of default LTE sample rate 
some RF boards might have issues with the sharp filters that are needed
for the reduced sample rate operation that we use by default.

This switch allows to use the default LTE sampling rates and
configure this at run-time, not compile time.
 4 years ago
Andre Puschmann cd1ca4d095 mac_test: add LBSR test 
the test checks the correct packing of an LBSR when a SDU couldn't
be added before. This happended because RLC couldn't provide a new PDU.
 4 years ago
David Rupprecht a8074fe39d Fixed TTCN UE for starting a service request in rrc_idle 4 years ago
Pedro Alvarez 454162cea7 Deleted nas_interface_stack. 4 years ago
Pedro Alvarez 38822873e8 Stop T3402 4 years ago
Pedro Alvarez 604e79214d Changed NAS is_attached interface to is_registered. 4 years ago
Pedro Alvarez 5649ecaab0 Renamed nas_common.h to nas_config.h. Moved emm_state_t into nas_emm_state.h and nas_emm_state.cc. 4 years ago
Pedro Alvarez 96f39da5d7 Fixes for airplane simulator. 4 years ago
Pedro Alvarez 14844a168a Created new class to hold all NAS states for the NAS state machine. Added EMM-DEREGISTERED substates and EMM-REGISTERED substates. 
Decoupled PLMN selection, attach request and service request. Removed RRC connect procedure from NAS.
 4 years ago
Andre Puschmann 2be85217fd mac,ue: reset demux when restting MAC 
this potentially fixes the issue we see during HO and RLF
under high DL load.

The issue happens because buffered DL PDUs are delivered to
RLC after reestablishing RLC that confuse the receiving
RLC entity bc the sequence numbers are very high, as opposed
to begin with zero again after reestablishment.
 4 years ago
Ismael Gomez 67690136be Select strongest cell after cell search (#2001) 
* Select strongest cell in all frequencies when

* Change variable name
 4 years ago
Ismael Gomez 709d69d55f Reset rv_idx after an adaptive retx in UE 4 years ago
Andre Puschmann 7cf919e2af Fix MAC PDU packing after sending Truncated BSR (#2004) 
* mac_test: add extended TBSR unit test

unit test to MAC UL packing after sending a TBSR

this fixes the MAC issues described in issue #2002

* mux: fix updating of LCG buffer state after packing PDU

we've previously lowered the buffer state of the LCG according
to the bytes that have been scheduled, but not according to
those that have been actually included in the PDU.

* proc_bsr: fix LCG buffer state updating for TBSR

when sending a TBSR do not update the internal buffer
state of the BSR proc.

This caused issues because the buffer state for all LCG that
are not included in the TBSR are set to zero, although at least
one LCG does have data to transmit.

* rlc_am: include LCID when logging retx of SN
 4 years ago
Francisco Paisana 510959b50f update nr asn1 files, and asn1 tests 4 years ago
Andre Puschmann 082e002b67 nas: fix airplane mode simulation 
the current implementation was somehow broken after a
NAS refactor. It was undetected because we didn't really
use it.

this fixes the simulation by using a single timer to simulate
airplane mode transitions.
the timer is rearmed in the timer_expire() function
if the correspondig event is set.

Has been tested to work well with, e.g.:

--sim.airplane_t_on_ms 5000 --sim.airplane_t_off_ms 10000
 4 years ago
Xavier Arteaga 32ea840a30 INTRA: better ring-buffer protection 4 years ago
Xavier Arteaga 369cffec00 More deterministic SCell search test 4 years ago
Xavier Arteaga a5f9ea5654 SRSUE: force paging for every cell reselection procedure end 4 years ago
Andre Puschmann fd5cde525c proc_bsr: fix race condition in BSR reporting 
fix for #1934

This fixes a race condition between Stack thread and DL
PDU processing that lead to updates of the RLC buffer that
are undetected by the BSR routine.

What happens is that in a UL SCH PDU all outstanding data is transmitted
and and a LBSR with all zero buffers is sent.

14:39:47.327301 [MAC ] [D] [ 3793] BSR:   LCID=3 old_buffer=59
14:39:47.330600 [MAC ] [I] [ 3793] UL LCID=3 len=58 LBSR: b=0 0 0 0

Note that "old_buffer" isn't set to zero here.

At the same time (same TTI), the MAC PDU processing thread handles DL-SCH PDUs
that may generate new UL PDUs:

14:39:47.330749 [RLC ] [I] DRB1 Tx SDU (54 B, tx_sdu_queue_len=1)
14:39:47.330762 [RLC ] [I] DRB1 Tx SDU (54 B, tx_sdu_queue_len=2)
14:39:47.330775 [RLC ] [I] DRB1 Tx SDU (54 B, tx_sdu_queue_len=3)
..

Those PDUs are "new data" since the previous buffer state was zero.

Here is the race now between the threads, at the end of the bsr::step() function
old_buffer of each LCG is updated with the previous new_buffer, so
the buffer state of LCG=2 is now 59.

Now MAC starts the next TTI:

14:39:47.331910 [MAC ] [D] [ 3794] Running MAC tti=3794
14:39:47.331928 [MAC ] [D] [ 3794] Update Bj: lcid=0, Bj=0
14:39:47.331934 [MAC ] [D] [ 3794] Update Bj: lcid=1, Bj=0
14:39:47.331938 [MAC ] [D] [ 3794] Update Bj: lcid=2, Bj=0
14:39:47.331941 [MAC ] [D] [ 3794] Update Bj: lcid=3, Bj=-1752
14:39:47.331951 [MAC ] [D] [ 3794] BSR:   LCID=0 update new buffer=0
14:39:47.331960 [MAC ] [D] [ 3794] BSR:   LCID=1 update new buffer=0
14:39:47.331964 [MAC ] [D] [ 3794] BSR:   LCID=2 update new buffer=0
14:39:47.331971 [MAC ] [D] [ 3794] BSR:   LCID=3 update new buffer=335
14:39:47.331976 [MAC ] [D] [ 3794] BSR:    check_new_data() -> get_buffer_state_lcg(0)=0
14:39:47.331980 [MAC ] [D] [ 3794] BSR:    check_new_data() -> get_buffer_state_lcg(1)=0
14:39:47.331984 [MAC ] [D] [ 3794] BSR:    check_new_data() -> get_buffer_state_lcg(2)=59
14:39:47.331988 [MAC ] [D] [ 3794] BSR:    check_new_data() -> get_buffer_state_lcg(3)=0
14:39:47.331993 [MAC ] [D] [ 3794] BSR:   LCID=0 old_buffer=0
14:39:47.332000 [MAC ] [D] [ 3794] BSR:   LCID=1 old_buffer=0
14:39:47.332003 [MAC ] [D] [ 3794] BSR:   LCID=2 old_buffer=0
14:39:47.332007 [MAC ] [D] [ 3794] BSR:   LCID=3 old_buffer=335

And since the buffer state of LCG=2 isn't zero, the new data for LCID=3 of that LCG is considered.
So effectivly, the BSR missed the "empty" buffer state for a fraction of time and doesn't
consider the outgoing data generated in the same TTI as new. It therefore
doesn't transmit a BSR.

in which a BSR wasn't
 4 years ago
Andre Puschmann 465c3d9186 proc_sr: remove info log when starting SR proc 
this was a very noisy log that was printed in pretty much
every TTI because the BSR procedure starts a SR whenever
it needs to send a regular BSR. The SR is canceled when a UL
grant arrives but the log line stays there.

Since we are printing a log when we actually signal a SR
to the PHY, this line is not needed.
 4 years ago
Andre Puschmann 1e3ad5b0dc proc_bsr: fix high priority channel trigger logic 
this fixes the trigger logic for periodic BSRs. Previously we
would always trigger the "new data for highest priority LCID"
whenever new data becomes available for a LCID for which
a BSR has already been sent.

However, a BSR should only be sent if the priority is in fact higher
(lower int number).
 4 years ago
Andre Puschmann debbab93e8 mac_test: cosmetic change 4 years ago
Andre Puschmann e89254ad1f mac_test: fix mac_ra_test according to BSR changes 
the BSR routine had a bug in which it would generate a BSR even
before the reTx timer expires if new data becomes availble
for a LCID that already had data and a BSR was already sent.

The RA test here relies on a BSR in the generated MAC PDU to pass.

However, since after fixing the BSR bug the PDU the MUX unit
no longer generates a BSR, we need generate data for a LCID
which has higher priority than the one for which a BSR has
already been sent.
 4 years ago
Andre Puschmann d6ef66b0dc mac_test: add periodic BSR test 4 years ago
Andre Puschmann d5286e70aa proc_bsr: refactor and add extra print_state() method 
allows to call the print_state() routine from other places in the BSR
 4 years ago
Andre Puschmann d1ef5bd915 demux: log DL PDUs 
instead of just printing the LCIDs that contain SDUs,
we use the to_string() function to log the entire MAC DL-SCH PDU
 4 years ago
Andre Puschmann 0740154bff rrc,sync: fix two uninit vars 
detected by Valgrind when running UE with TDD cell
 4 years ago
Andre Puschmann 58776bc227
ue,sync: increase timeout for entering IDLE to 2s (#1941) 
in ZMQ runs we've seen that entering idle could take quite
a bit of time depending how quickly workers get their samples
sent or reconfigurations done.

In one example up to ~160ms

this patch increases the maximum wait time to 2s.
 4 years ago
Francisco Paisana 514deaf25b fix resetting of phy and mac during reestablishment 4 years ago
Xavier Arteaga 03b88f6149 Added noise to neighbour cell search test 4 years ago
Xavier Arteaga caf37b8e62 Added serving cell index in UCI/CSI report trace 4 years ago
Andre Puschmann 3b1ae970b9 metrics_test: fix uninit variable 4 years ago
Andre Puschmann a366500a78 rrc_proc: init cs_result to none 
detected by Coverity CID 363053
 4 years ago
Andre Puschmann d51a060bfa nas_test: fix potential out of bounds access 4 years ago
Andre Puschmann 1bbbc9d717 rrc_phy_ctrl_test: fix uninit memory 4 years ago
Francisco Paisana 0842ed9db1 fixed phy cell selection state update for the fail path 4 years ago
Francisco Paisana 665b3996bb now the phy controller handles the scenario where the phy cell selection failed to be initialized 4 years ago
Andre Puschmann 287c653755 proc_bsr: improve BSR logging to print name of triggered BSR instead of enum 4 years ago
Andre Puschmann 3994407f46 proc_bsr: fix BSR insertion in UL PDUs 
the BSR trigger wasn't reset after includinga regular or periodic
BSR inside a PDU. This caused the muxing to include another BSR in the
next UL grant. For very small grants, for example with 6 PRBs, this
causes the UE to send way too many BSRs.
 4 years ago
Andre Puschmann 7352bfa4bd mac_test: add unit test for retxBSR timer 
this test varifies the correct operation of the retxBSR timer.
the first PDU includes a long BSR to indicate more LCGs have
data to transmit. The retxBSR timer is started and subsequent
PDUs should not send a regular BSR.

After the retxBSR timer expires, a UL PDU should again include
a BSR.
 4 years ago
Andre Puschmann 937067a205 proc_phr: rename start_periodic_timer() and make sure its only started if a valid config is present 4 years ago
Andre Puschmann fab86382c1 mac,rrc: add interface to set SR config explicitly without touching any other MAC function 
when releasing PUCCH/SRS (see 5.3.13 in 36.331) we need to reset the SR config as well.
In our case, SR is handled by MAC so we need to (re-)configure MAC, not all of
MAC though, just SR.
 4 years ago
Francisco Paisana e7239163e9 silence noisy unhandled in_sync_ev logs 4 years ago
Francisco Paisana f185272367 added comments explaining the meaning of the cell reselection procedures 4 years ago
Francisco Paisana 49e7b8e36e - Change periodicity of cell reselection after a new serving cell has been selected 
- Enable PHY intra measurements during RRC_IDLE
 4 years ago
Francisco Paisana 585d7c923a refactor and simplification of cell selection procedure. Using now a SIB3 threshold to decide whether to select neighbor cell while in RRC_IDLE 4 years ago
Francisco Paisana cae116932b rewrite the rrc::leave_connected() function to better match the standard. The measurements should not stop while in RRC_IDLE. 4 years ago
Pedro Alvarez 5a4e71a6e4 Created k_enb_context structure that holds k_enb, NCC and NH to make it easier to restore context from failed handover. 4 years ago
Pedro Alvarez bcb422736c Save and restore NH on handover and handover failure. 4 years ago
Xavier Arteaga 08e24d00af Fix TA console trace 4 years ago
Pedro Alvarez 3eb525563a Fix issue reading MNC length in USIM. 4 years ago
Xavier Arteaga 6ae47b6510 SRSUE: Deafult PUCCH/SRS does not imply full PHY dedicated defaults 4 years ago
Andre Puschmann 5e95fd4a43 ul_harq: reduce log level for new_grant_ul() if RNTI isn't found 
this avoid logging a warning on UE shutdown if the MAC is already reset
but one of the PHY workers still decodes an UL grant for the old RTNI

21:30:29.254844 [RRC ] [I] Going RRC_IDLE
21:30:29.254848 [RRC ] [I] Proc "Go Idle" - Left connected state
21:30:29.259499 [PHY0] [I] [ 3865] Finished setting new PHY configuration cc_idx=0
21:30:29.259512 [PHY0] [I] [ 3865] Setting new PHY configuration cc_idx=0...
21:30:29.264190 [PHY0] [I] [ 3867] Finished setting new PHY configuration cc_idx=0
21:30:29.275036 [PHY1] [I] [ 3872] PHICH: hi=1, corr=1.0, I_lowest=1, n_dmrs=0, I_phich=0
21:30:29.275050 [MAC ] [W] [ 3872] Received grant for unknown rnti=0x46
 4 years ago
Andre Puschmann 362461329a rrc: improve log message when detecting RLF 4 years ago
Andre Puschmann 76c648106f rrc: remove varMeasState for unknown neighbor cells 
this fixes issue #1846 that appears to be related
to the enter/exit state for measurements that is kept
even after a cell disappears from the neighbor list
 4 years ago
Andre Puschmann 829dfc4e60 metrics_stdout: fix precision calculation for 100% 
the precision for 100% was causing the default value of -1 which in turn
cause to print the full precision resulting in ugly stdout plots.

before:
--------Signal--------------DL-------------------------------------UL----------------------
cc pci  rsrp    pl    cfo   mcs   snr turbo  brate   bler   ta_us  mcs   buff  brate   bler
 0   0   -10    74    0.0   0.0   0.0   0.0   200k     0%   0.0   0.0    0.0    0.0     0%
 1   0   0.0   0.0    0.0   0.0   0.0   0.0   150k100.000000%   0.0   0.0    0.0    0.0     0%

after:
--------Signal--------------DL-------------------------------------UL----------------------
cc pci  rsrp    pl    cfo   mcs   snr turbo  brate   bler   ta_us  mcs   buff  brate   bler
 0   0   -10    74    0.0   0.0   0.0   0.0   200k     0%   0.0   0.0    0.0    0.0     0%
 1   0   0.0   0.0    0.0   0.0   0.0   0.0   150k   100%   0.0   0.0    0.0    0.0     0%
 4 years ago
Andre Puschmann e72219789e ul_harq: don't clear payload buffer during HARQ reset 
this fixes #1791 which was caused by a race between
the PHY workers preparing a new UL-SCH PDU and the Stack resetting
the MAC, which in turn resets the HARQ processeses, which cleared
the buffer and set the length to zero.

Not explicitly clearing the buffer on a HARQ reset seems to be
fine since the PHY worker clears the buffer before starting to
pack a new PDU anyway.
 4 years ago
Pedro Alvarez 22a6dc305f Moved common variables and functions from the usim and pcsc_usim classes into usim_base class. 4 years ago
Francisco Paisana 8a917bdd06 fix RRC phy controller call to phy->set_config. Only the PCell was being configured 4 years ago
Francisco Paisana 4ebe92f6a3 refactor phy configuration in the rrc to keep track of activated scells, and cells configurations 4 years ago
Francisco Paisana cfc77118d3 disable console print of scell activation command during handover 4 years ago
Francisco Paisana d910c910a4 rrc::meas_cell now uses stack timers instead of system timers. 4 years ago
Francisco Paisana 49ad1a4312 added unit test for meas cells 4 years ago
Francisco Paisana 023d32975a avoid use of pointers to meas_cells in ho_proc as they may become dangling 4 years ago
Francisco Paisana 072b7be582 renamed rrc::cell_t to rrc::meas_cell 4 years ago
Andre Puschmann d02e8135fb metrics_stdout: reset n_reports var after writing intermediate table header 4 years ago
Andre Puschmann 0ef8e1fdac rrc: include pci when logging serving cell measurement 
this should facilitate easier log parsing and plotting
if the cell measurements _always_ include the PCI, even
in the case of the serving cell

15:49:11.357447 [RRC ] [I] MEAS:  New measurement serving cell: earfcn=0, pci=1, rsrp=-11.52 dBm, cfo=+0.1 Hz
15:49:11.391610 [RRC ] [I] MEAS:  New measurement serving cell: earfcn=0, pci=1, rsrp=-11.52 dBm, cfo=-0.4 Hz
15:49:11.427325 [RRC ] [I] MEAS:  New measurement serving cell: earfcn=0, pci=1, rsrp=-11.52 dBm, cfo=-0.6 Hz
15:49:11.463101 [RRC ] [I] MEAS:  New measurement serving cell: earfcn=0, pci=1, rsrp=-11.52 dBm, cfo=-0.7 Hz
15:49:11.499817 [RRC ] [I] MEAS:  New measurement serving cell: earfcn=0, pci=1, rsrp=-11.51 dBm, cfo=+0.1 Hz
15:49:11.499828 [RRC ] [I] MEAS:  New measurement neighbour cell: earfcn=2850, pci=0, rsrp=-12.16 dBm, cfo=-0.8 Hz
15:49:11.535027 [RRC ] [I] MEAS:  New measurement serving cell: earfcn=0, pci=1, rsrp=-11.46 dBm, cfo=-0.8 Hz
15:49:11.571707 [RRC ] [I] MEAS:  New measurement serving cell: earfcn=0, pci=1, rsrp=-11.46 dBm, cfo=-0.9 Hz
15:49:11.607932 [RRC ] [I] MEAS:  New measurement serving cell: earfcn=0, pci=1, rsrp=-11.52 dBm, cfo=-0.8 Hz
 4 years ago
Andre Puschmann 6e0abd30dd ue,phy_common: include Pcell PCI in cell measurements 
this allows easier plotting in RRC when PHY cell
measurements already include the PCI
 4 years ago
Andre Puschmann baf171d446 rrc: improve SR configuration logging 
* move logging of SR max attempts into MAC logging
* log new MAC config whenever it is updated
 4 years ago
Andre Puschmann bf7c2b800e proc_sr: log error when trying to enable faulty SR config 4 years ago
Andre Puschmann 04acc78c7d metrics_test: add neighbor cell test 
cleanup test and add neighbor cells so the displaying is tested

--------Signal--------------DL-------------------------------------UL----------------------
cc pci  rsrp    pl    cfo   mcs   snr turbo  brate   bler   ta_us  mcs   buff  brate   bler
 0   0   -10    74    0.0   0.0   0.0   0.0   200k     0%   0.0   0.0    0.0    0.0     0%
 1   0   0.0   0.0    0.0   0.0   0.0   0.0   150k    50%   0.0   0.0    0.0    0.0     0%
--------Signal-------------Neighbour--DL-------------------------------------UL----------------------
cc pci  rsrp    pl    cfo  pci  rsrp  mcs   snr turbo  brate   bler   ta_us  mcs   buff  brate   bler
 0   0   -10    74    0.0   8   -33   0.0   0.0   0.0   200k     0%   0.0   0.0    0.0    0.0     0%
 1   0   0.0   0.0    0.0   8   -33   0.0   0.0   0.0   150k    50%   0.0   0.0    0.0    0.0     0%
--------Signal--------------DL-------------------------------------UL----------------------
cc pci  rsrp    pl    cfo   mcs   snr turbo  brate   bler   ta_us  mcs   buff  brate   bler
 0   0   -10    74    0.0   0.0   0.0   0.0   200k     0%   0.0   0.0    0.0    0.0     0%
 1   0   0.0   0.0    0.0   0.0   0.0   0.0   150k    50%   0.0   0.0    0.0    0.0     0%
 0   0   -10    74    0.0   0.0   0.0   0.0   200k     0%   0.0   0.0    0.0    0.0     0%
 1   0   0.0   0.0    0.0   0.0   0.0   0.0   150k    50%   0.0   0.0    0.0    0.0     0%
 4 years ago
Andre Puschmann ddbf4e1645 metrics_stdout: print new table header if neighbour cells change 
this fixes an issue where the stdout metrics isn't readable if the only
neighbour cell gets removed during the 10s where no table header is printed.

--------Signal--------------Neighbor----DL-------------------------------------UL----------------------
cc pci  rsrp    pl    cfo  pci  rsrp  mcs   snr turbo  brate   bler   ta_us  mcs   buff  brate   bler
 0   2   -66    61  -3.3k   1   -76    11    18   1.1   8.4M     3%   0.0    21    262   167k     0%
 0   2   -65    60  -3.3k   1   -76    12    19   1.1   9.6M     2%   0.0    22    476   214k     0%
 0   2   -65    60  -3.3k   1   -76    16    22   1.3    13M     3%   0.0    23   1.1k   734k     0%
 0   2   -64    59  -3.3k   1   -76    17    23   1.3    15M     2%   0.0    23    602   424k     0%
 0   2   -63    58  -3.3k   1   -77    20    25   1.4    19M     3%   0.0    23    501   304k     0%
 0   2   -62    57  -3.3k   1   -77    22    27   1.8    20M    10%   0.0    22    417   418k     0%
 0   2   -61    56  -3.3k   1   -77    24    28   1.8    25M     9%   0.0    23    396   439k     0%
 0   2   -61    56  -3.3k   1   -77    26    29   1.5    23M    22%   0.0    23    841   407k     0%
 0   2   -60    55  -3.3k   1   -77    27    31   1.3    27M    11%   0.0    23    890   1.1M     0%
 0   2   -59    54  -3.3k   1   -77    27    32  1.00    30M     3%   0.0    23    583   524k     0%
 0   2   -59    54  -3.3k   1   -77    27    32  0.92    32M     1%   0.0    23   1.1k   503k     0%

--------Signal--------------DL-------------------------------------UL----------------------
cc pci  rsrp    pl    cfo   mcs   snr turbo  brate   bler   ta_us  mcs   buff  brate   bler
 0   2   -59    54  -3.3k    27    31   1.1    30M     4%   0.0    23   1.2k   529k     0%
 0   2   -60    55  -3.3k    27    30   1.4    25M    18%   0.0    23    540   442k     0%
 0   2   -61    56  -3.3k    26    29   1.6    23M    21%   0.0    23    536   429k     0%
 0   2   -62    57  -3.3k    24    28   1.8    23M    13%   0.0    23    834   456k     0%
 0   2   -62    57  -3.3k   1   -78    21    26   1.6    20M     7%   0.0    23    723   425k     0%
 0   2   -63    58  -3.3k   1   -76    17    22   1.1    15M     3%   0.0    23    470   267k     0%
 0   2   -64    59  -3.3k   1   -77    17    22   1.3    15M     3%   0.0    23    167   280k     0%
 0   2   -65    60  -3.3k   1   -76    14    21   1.3    11M     2%   0.0    22     57   223k     0%
 0   2   -65    60  -3.3k   1   -76    12    19   1.2   9.0M     3%   0.0    21    135   182k     0%
 0   2   -66    61  -3.4k   1   -70   9.3    17   1.0   6.9M     2%   0.0    21    246   126k     0%
 0   2   -67    62  -3.3k   1   -75   8.2    16   1.1   4.9M     3%   0.0    20    0.0   122k     0%
 4 years ago
Pedro Alvarez 2f0125ef4e Fix issue recovering key state, when the first HO fails (specifically, is_first_ncc was not recovered). Minor improvements in key logging. 4 years ago
Francisco Paisana 1f2cca8909 in the rrc reconf procedure, handle the scenario where the rrc reconfiguration message does not config the phy 4 years ago
Francisco Paisana edd5c50f9a pass nas pdus after sending rrc reconf complete 4 years ago
Francisco Paisana cf89f4300a fix ttcn3 to signal back to stack that a phy config has been completed 4 years ago
Francisco Paisana c6f4776a6f send the nassdus sooner in the rrc reconf procedure 4 years ago
Francisco Paisana 2416e274a7 fix rrc_meas_test. The phy now needs to signal back to the rrc that the phy config is complete 4 years ago
Francisco Paisana fc49b5a030 implemented rrc reconfiguration procedure that includes a continuation when phy configuration is complete 4 years ago
Andre Puschmann 936e3b7bef mac_test: add manual test for TC 7.1.4.6 4 years ago
Andre Puschmann 5a9b1865e4 proc_bsr: fix typo 4 years ago
Xavier Arteaga ef9d77c966 SRSUE: add PRACH config present field in PHY configuration structure 4 years ago
faluco 51b27fc255
Import latest srslog version (#1796) 
* - Import latest srslog version.
- Adjusted the nas_test to create logs correctly.
- Remove timestamp formatting now that is provided by srslog.
 4 years ago
Francisco Paisana 924cc4f937 during cell selection, if the serving cell is ok, avoid calling serving cell configuration if the sibs are already acquired 4 years ago
Ismael Gomez 4e88daae21
Set DCI unpacking errors to info (#1781) 4 years ago
faluco dfeed52514 - Rename out_stream function to console. 4 years ago
faluco 62faef7c71 - Replaced all uses of the log::console method. 4 years ago
Francisco Paisana b3eb9651d6 disable cqi in scells during handover procedure 4 years ago
Ismael Gomez f4c7021a5f Appy phy configuration to current_phy_cfg before sending to PHY after HO 4 years ago
Francisco Paisana 8a9a95a937 ensure sibs are acquired if cell selection calls cell search 4 years ago
Francisco Paisana af3ff5985e removal of console print of last selected cell during the cell selection procedure. 4 years ago
Francisco Paisana c33e94fede fix conformace 8_5_1_1 failure 4 years ago
Francisco Paisana 045f647914 fix edge case where serving cell is good enough for reestablishment but the sibs are not yet acquired 4 years ago
Andre Puschmann f32d9f8322 ttcn3: call stop in UE dtor 
fixes stop issue of TTCN3 DUT
 4 years ago
Ismael Gomez d671e39c93 Fix SINR not correctly considering noise. Missed dBm conversion 4 years ago
Francisco Paisana 5ecbe8fb17 cleanup of the reestablishment procedure state machine. It does not need to wait for the serving cell configuration because such procedure is already included in the cell selection procedure 4 years ago
Pedro Alvarez b3bfe336a9 Make sure that remote address test has a ip mask 4 years ago
Sylvain Munaut 6ce5863f03 test/tft_test: Add a combined test for IPv6 packets 4 years ago
Sylvain Munaut 9ba8b62972 test/tft_test: Update filter test suite 
The “IPv4 local address type” filter should be 9 bytes since it includes
not only the ip address, but also its subnet mask.

Quoting from 3GPP TS 24.008 10.5.6.12:
"""
 For "IPv4 remote address type", the packet filter component value field
 shall be encoded as a sequence of a four octet IPv4 address field and a
 four octet IPv4 address mask field. The IPv4 address field shall be
 transmitted first. For "IPv4 local address type", the packet filter
 component value field shall be encoded as defined for "IPv4 remote
 address type".
"""

Same for the ToS which also includes a 1 byte mask value
 4 years ago
Sylvain Munaut 5783c01cbb tf_packet_filter: Improve support for the different filter types 4 years ago
Ismael Gomez bb691f0cbe
Fix priority order in BSR trigger. Was not being triggered if SRB2 data was pending in the buffer (#1771) 4 years ago
Ismael Gomez 8c30822350 Fix bug in update_measurements() not reporting in_sync in single carrier 4 years ago
Francisco Paisana 0997daa7a0 now the handover procedure in the srsUE does not wait for the phy cell selection result. It only waits for the RA result 4 years ago
Ismael Gomez c75c463263
Use SNR instead of SINR for RLF threshold (#1769) 
* Use SNR instead of SINR for RLF threshold

* Send in/out-sync only for cc_idx=0
 4 years ago
Ismael Gomez 76bfc78147
Fix issues with Sounding-RS (#1761) 
* Fix deadlock caused by update_measurements calling in_sync

* Fix overlapping SRS condition

* Do not use shortened PUSCH in transmissions and retx from RAR

* Revert "Fix deadlock caused by update_measurements calling in_sync"

This reverts commit f58c8c8c766f8f95baa3a3bf8287d8e25b2057ba.
 4 years ago
Francisco Paisana 2d321231df fix reest proc. The reest proc state has to be set before launching the procedure, because the procedure can complete immediately on launch call 4 years ago
Pedro Alvarez 86f4d469c6 Added some functions to save and restore AS keys for the case of failed handover in the USIM 4 years ago
Francisco Paisana 81ab4c1a65 make sure ho procedure waits for t304 expiry in all cases 4 years ago
Ismael Gomez b94d24ed98
Take into account CRS from neigbhour cells when measuring interference (#1757) 
* Take into account CRS from neigbhour cells when measuring interference

* fix std::isnormal compilation

* Fixed compilation of test

* Address comments

* Remove unused overrides
 4 years ago
Francisco Paisana cf89d6645b add comments explaining each function of the reest procedure 4 years ago
Francisco Paisana d068d594af implemented rrc reestablishment procedure part after sending reest request 4 years ago
Francisco Paisana 7d6c9a1751 Add cause and cell pci to reestablishment console message 4 years ago
Francisco Paisana 73e21daeb2 refactor reestablishment procedure to more closely follow TS. 4 years ago
Andre Puschmann 1afc137032
[REBASE] Make PHY non-blocking and fefactor HO procedure (#1753) 
* Make PHY non-blocking and fefactor HO procedure

* makes entire PHY non-blocking through command interface
* adds dedicated queue for cell_search/cell_select commands
* refactor HO procedure to run faster, in one stack cycle. Looks closer to the specs
* force ue to always apply SIB2 configuration during reestablishment
* Run update_measurements in all workers

Co-authored-by: Ismael Gomez <ismagom@gmail.com>
 4 years ago
Ismael Gomez 399b986d0b
Fix deadlock caused by update_measurements calling in_sync (#1760) 4 years ago
Francisco Paisana eb370642ab verify cell selection observer is set before calling it 4 years ago
Francisco Paisana 7f8af023b8 added a callback that always gets triggered when the phy cell selection completes. This callback checks if cell selection failed, and if so, sets the rsrp of the selected cell to -infinity 4 years ago
faluco f0d651ae8e - Fixed a leak in the MME class not releasing the static byte buffer pool. 
- Now the pool gets destroyed on program exit using a unique_ptr.
- Removed manual cleanup() calls in all the code base to free the pool instance.
 4 years ago
Ismael Gomez 5968157ea5
Protect better the access to shared variables in phy_common and metrics (#1750) 4 years ago
Andre Puschmann eeb2b904aa ue,rach: fix failing RACH proc when Msg3 grant RNTI matches current CRNTI 
this was preventing that the Temp-CRNTI used in the RAR to be identical
to the currently configured C-RNTI of the UE.

The issue simply was that the RACH procedure was declared successful too
early, even before the Msg3 UL grant was filled with the Msg3 content.

The patch moves the logic that detects the successful completion of
the RACH procedure below the Msg3 packing.
 4 years ago
Andre Puschmann a36f9bddc2 ttcn3: use RNTI values in RACH provided by tester 
this patch extends the SS to use the C-RNTI and Temp CRNTI values
provided by the tester for RAR and Msg3.
 4 years ago
faluco e14cb4b405 - Fix a missing thread join in the phy which caused a memory leak. 4 years ago
faluco 5acc1c9a73 - Cleaned up style in the PRACH class: 
* Removed magic numbers.
* Reduced indentation of statements with early exists.
* Removed elses after a return statement.
* Trimmed unnecessary include files.
* Default initialized members in the class.
 4 years ago
faluco b6bbe8761a - Remove left over printf. 4 years ago
faluco 79f5b62551 - Calculate PRACH buffers on the fly when required instead of pregenerating all of them. 4 years ago
Andre Puschmann b616944a13 ue,rrc: fix security config during HO/reestablishment 
we fix a number of very related issues for HO/reestablishment
in the success/error case:

* this patch removes the hard-coded check that intra-cell HO aren't
allowed. There are cases where eNBs use this method to update
the security context.

* the patch also fixes an issue after failed HO where the security context
of the source eNB should be used for the reestablishment.

* update security keys according to specs when mobilitycontrol
indicated change of key
 4 years ago
Andre Puschmann d90de639e5 ttcn3_syssim: continue when epoll returns -1 
this allows to debug and step in the SS
 4 years ago
Andre Puschmann 1b266257a1 ttcn3_phy: improve logging of cell measurements 4 years ago
Andre Puschmann 6827c2df21 rrc_meas: disable layer3 filtering until quantity config is received 
the filter alpha was initialized to zero by default which causes an
issue because the first measurement for a cell can't be updated,
because the filtering function will always return the current value.

According to 36.331 Sec 5.5.3.2 Note 2, a k-value of 0 should turn
off filtering, which should be used as the default value until
an update is received from the network.
 4 years ago
Francisco Paisana 97133894e6 the Ocs value used in the measReport triggering decision was not being set correctly. The enum of the cell individual offset in the measCfg was being cast to an int and stored. Instead what we want is to store the actual offset value using the ASN1 enum->number lookup table. 4 years ago
Xavier Arteaga 44c2412be2 SRSUE: silent PUSCH encoding error by dropping invalid grant 4 years ago
Francisco Paisana 739c0c5c00 altered plmn search procedure handling of failed cell searches. If a cell search procedure fails due to inability to select a cell or acquire SIB1, the plmn search carries on for other frequencies. 4 years ago
Andre Puschmann 3088cdbb0f ttcn3: fix uncaught exception in SS 
fix accessing child element in parsed Json without checking
its existence.
 4 years ago
Andre Puschmann 8df388ba3e usim: fix typo in log 4 years ago
Andre Puschmann 3e824f6370 ttcn3: convert TTI action vector to queue 
this makes sures queued events are executed FIFO
 4 years ago
Andre Puschmann 624c8142ad ttcn3: refactor cell handling in SS 
this rather large patch changes the way cells are handled in the SS.
It moves RLC and PDCP entities to the cell map of the SS, such that each cell
has its own entities. This allows to support HO operation, for example,
in which two cells need to send SRB messages.

It also extends most of the syssim interface to include the cell name
in all commands so they can be applied on the specified cell only.
 4 years ago
Andre Puschmann 4650a620d9 ttcn3: refactor cell search and selection in TTCN3 PHY 
- make sure only suitable cells are reported/selected
 4 years ago
Andre Puschmann 973de8f78d ttcn3_dut: block OS signals before starting log backend 
this prevents the backend thread from handling the signals. they
are only handled by epoll running in the main thread.

this fixes #1713
 4 years ago
Ismael Gomez b397878d25 Fix comments in ue.conf 4 years ago
faluco c178e362b8 - Rewrite log management so that a log sink can be swapped for each testcase. 4 years ago
faluco 5e8a4c898d
Bring back the circular array object. (#1712) 4 years ago
Xavier Arteaga 52355024e7 SRSUE PHY: move mutex lock to cc worker and unlock for stack calls 4 years ago
Ismael Gomez 4c1d3ef7e8
Fix implementation of Random Access problem (#1689) 
* Fix implementation of Random Access problem

* Apply AS activated condition on RLF before calling Reestablishment
 4 years ago
Ismael Gomez f49fbd6d02
Fix the order of HO/reest measurement actions (#1696) 4 years ago
Andre Puschmann c16ac6c890 ue_stack: only push sync event to event queue is stack is still running 
stopping the UE in ZMQ mode caused a dead-lock because the Stack was
stopped before the PHY causing the sync queue to overflow. Since we
use a queue-length of 1 in ZMQ, mode, the PHY sync thread was blocking to
push a new sync event while the stack thread was already stopped.

this patch makes sure no new sync events are queued after the stack has
been terminated.
 4 years ago
Andre Puschmann aec18a93d1 mux,bsr: refactor UL buffer status reporting 
this patch fixes the UL BSR as per TS 36.321, it includes following
main changes:

* report UL buffer state to reflect the UEs transmit buffer after
  the MAC UL PDU containing the BSR has been built.
  In other words, if the UE, for example, can transmit all outstanding
  data in an UL grant, it will not report any pending data to transmit.

* refactor MUX routines and subheader space calculation
 4 years ago
Andre Puschmann 92d76a5eb6 mac_test: update tests involving BSR handling 
* split existing BSR test into dedicated test for short, long, and trunc
  BSR tests

* update MAC tests that include packing UL BSR.
  (After checking TS 36.321 again it seems we have reported old UL buffer states)
 4 years ago
Ismael Gomez 54eed11e1d Refactor decision for extended CSI/SRS 4 years ago
Ismael Gomez 51521ad8e4 Improved PDCCH blind search and fixed a few issues with ambiguous DCI size with Release 10 4 years ago
Andre Puschmann 14289ebcc6 dl_harq: lower log level when MCS changes in DL grant to debug 
fixes #1489

this is normal behavior and should not result in a warning message.
 4 years ago
Ismael Gomez 06a5bdaab2 Process all calls to RLF in the main RRC task 4 years ago
Francisco Paisana 92221eb780 update of rrc_interface_mac to remove signal from mac to rrc that RA failed in case of handover failure 4 years ago
Francisco Paisana 46e1e101d3 removal of unecessary ho_ra_complete(false) in mac. In case of HO failure, the rrc should let the t304 expire 4 years ago
Francisco Paisana aed9120458 in case of RA problem during handover, the UE cannot trigger RLF. It has to let t304 expire, which will then trigger the reestablishment procedure with the right cause 4 years ago
Francisco Paisana fca1273b3e avoid spurious warnings of trying to start the PRACH when it is already running during handover 4 years ago
Francisco Paisana fddcc3d8ea In the case of Handover, postpone the activation of the CQI and SR config present in the HO command for after the RA proc completion to the target eNB 4 years ago
Andre Puschmann 641a4a5e79 mac_test: fix compilation if PCAP write is enabled 4 years ago
Andre Puschmann 49a7a90698 mac: simplify BSR packing logic 
simplify logic to check whether a BSR fits and, if so, which type.
before the check has been done in two places.

we now also accomodate for the CE subheader size.
 4 years ago
Andre Puschmann 6364a4513c mac_pdu: fix issue when packing CE but no space left in PDU 
we've not checked the return value when adding a new CE, like BSR or PHR,
for a UL MAC PDU. For very small UL grants, this could fail and
we need to remove the subheader again before packing the PDU.

This fixes issue #1649.
 4 years ago
Daniel Willmann 7d0ae71f17 ttcn3_sys_interface: Handle initial cell attenuation 
When new Cells are added they can have an attenuation configured
directly. Honor that setting.
 4 years ago
Francisco Paisana 5242f9422b fix deadlock in handover 4 years ago
Ismael Gomez 72cc4e0ca5 Stop ContentionResolutionTimer on RA error. Updated test 4 years ago
Xavier Arteaga df2c949417 Radio: add individual Rx gain and integrate in srsue 
Fix compilation

Fix compilation

Add missing variable. Wasn't compiling

Radio: revert some changes
 4 years ago
Xavier Arteaga 029f36b449 srsLTE: added efficient integer resampler and srsue/srsenb integration 4 years ago
Xavier Arteaga 1ff74da078 Remove wrong error message 4 years ago
Francisco Paisana 75b204bc52 fix phy ctrl call to cell selection observers 4 years ago
Francisco Paisana 834c0b3929 integrated new observer pattern into phy controller fsm 4 years ago
Francisco Paisana 48dd436d86 integrated observer pattern into rrc phy ctrl fsm 4 years ago
Francisco Paisana 997552ee45 stop t304 when handover is successful 4 years ago
Francisco Paisana 1d8286eb62 always wait for t304 to expire in case of failed handover 4 years ago
Francisco Paisana ccc8ab70ef stop t304 on handover procedure exit 4 years ago
Francisco Paisana db15f43a77 set reestablishment cause correctly on handover failure 4 years ago
Francisco Paisana b1670c005b remove shadowed variables for reestablishment during handover 4 years ago
Xavier Arteaga 0e96ef3df0 Channel emulator takes SNR as input parameter 4 years ago
Andre Puschmann 5e40bfe72c mac_pdu: unpack and print BSR index as well as BSR value in bytes 
before the BSR was extracted but the actual index (between 0 and 63)
was not stored but directly converted into bytes.

for log parsing and debugging it is easier to follow the index
value. this patch therefore adds both values to the log message
and extends the API accordingly.
 4 years ago
Francisco Paisana 8c9e596f89 refactored s1ap handover request interface. cleaned up rrc tenb s1 handover code 4 years ago
Francisco Paisana 7cd4f45d62 fsm refactor. 
- avoid triggering directly a subfsm
- improved metafunctions
- other cleanups
 4 years ago
Francisco Paisana 841b884796 remove extern C flags from common_helper.h 4 years ago
Francisco Paisana 5be5409f62 scaling governor function moved to common header file 4 years ago
Francisco Paisana 087805d222 add warning if scaling governor is not performance mode 4 years ago
Francisco Paisana 8d10aa906e move defer_task to switch case in the rrc 4 years ago
Andre Puschmann 24dfb03b9d rrc: defer manipulations of the RLC/PDCP arrays 
all calls that manipulate the RLC and/or PDCP arrays suffer
from a high deadlock risk if a PHY worker holds the RLC
AM Rx mutex at the same time when the stack wants to carry
out this reconfiguration.

this applies to RRC Reconfigs, but potentially also to RRC Connection
Reestablishment or even RRC Connection Setup, although this should
seldom be the case.

By breaking the call stack between RLC->PDCP->RRC->RCL and
carrying out the reconfig as a single task without holding the
RLC readlock the deadlock should not happen anymore.

This should fix issue #1593
 4 years ago
faluco e5a792d508 - Fix unused variable. 4 years ago
faluco cfd3f51931
Import of srslog into srsepc and srsenb. (#1574) 
* - Import of srslog into srsepc and srsenb.
* - Removed logger_file and logger_stdout files.
 4 years ago
Xavier Arteaga 202ec283ff SRSUE: fix erroneous code in MUX 4 years ago
Xavier Arteaga 4e1e8cea1a SRSUE: MAC HARQ entities vector is fixed 4 years ago
Xavier Arteaga 09af743361 SRSUE: minor PHY modfifications 4 years ago
Xavier Arteaga 0b02f8948c SRSUE: fix shadow variable 4 years ago
Ismael Gomez c02e920b6b Trigger RA after SR failed directly (don't wait for next BSR trigger) 4 years ago
faluco efdff8ba4c
Import srslog into srsue (#1556) 
- Import the srslog project into srslte.
- Ported srsue app to use the new logging framework.
- Implemented a wrapper that dispatches log entries to srslog.
- Renamed an existing log test to be more specific to avoid name clashes.
 4 years ago
Andre Puschmann 1199a79851 fix Scell sync for large cells 
the PSS detection needs more temporary buffer than a full subframe.
we therefore need to allocate and initialize the sync object with
larger maximum size to support Scell search of large cells, e.g.
20 MHz

this fixes issue #1538
 4 years ago
Andre Puschmann ce5129467c correct default value of PHY threads in eNB and UE examples 4 years ago
Andre Puschmann 9550bd3ef8 rlc: revisit interface for MAC and RRC 
* add locked and unlocked version of has_data() since one is
  called from stack and one from PHY threads

* add comments in each interface section as to why locking
  is required or not

* remove RLC rwlock when not required

* move calls only used by RRC to RRC section
 4 years ago
Pedro Alvarez c686e6cea1
SRSUE: Set SCell configuration is unlocking (#1544) 4 years ago
Ismael Gomez 06eba7eb72 Discard cells if not found during cel selection 4 years ago
Andre Puschmann 138ec1f8e7 nas,usim: remove use of shadowed variables 4 years ago
Ismael Gomez 7866f19f6b Use correct target cell when doing reselection in HO 4 years ago
Ismael Gomez 443dee7035
Changes in Cell Selection Procedure (#1557) 
* Fixes RRC cell reselection procedure
 4 years ago
Xavier Arteaga 0192130742 SRSUE/SRSENB: UCI bits are carrier by the lowest serving cell index 
SRSENB: Fix UCI in lowest serving cell index PUSCH transmission
 4 years ago
Andre Puschmann 4fd5395903 change default EARFCN to 3350 or 2.68GHz 
as 3400 or 2.685 GHz is on the edge of band 7, some phones won't connect
to a 20 MHz cell on this EARFCN.

In order to simplify testing with other bandwidths we change the default EARFCN.
 4 years ago
Francisco Paisana 4fb8011a6d updated phy controller to use task scheduler 4 years ago
Francisco Paisana 36fc88d2e2 fsm log macros, and utility methods to convert event callbacks to move tasks 4 years ago
Francisco Paisana 9c5471b094 more ergonomic event callback 4 years ago
Francisco Paisana 58a9610efa use of stack event loop to propagate cell search and selection results 4 years ago
Francisco Paisana d48a45976e moved cell selection/search complete event signalling out of phy_controller 4 years ago
Francisco Paisana 48138b5281 removal of phy cell selection procedure as it now it is replaced by phy controller 4 years ago
Francisco Paisana 489969722e implemented phy controller FSM to perform cell selection & search. The controller also tracks the phy sync state 4 years ago
Andre Puschmann a7911f0dab pdcp,rlc: refactor SDU queueing policy 
this patch refactors the SDU queuing and dropping policy of the RLC and PDCP layer.
the previous design had issues when packets have been generated at a higher
rate above the PDCP than they could be consumed below the RLC.

When the RLC SDU queues were full, we allowed two policies, one to block on the write
and the other to drop the SDU. Both options are not ideal because they either
lead to a blocking stack thread or to lost PDCP PDUs.

To avoid this, this patch makes the following changes:

* PDCP monitors RLC's SDU queue and drops packets on its north-bound SAP if queues are full
  * a new method sdu_queue_is_full() has been added to the RLC interface for PDCP
* remove blocking write from pdcp and rlc write_sdu() interface
  * all writes into queues need to be non-blocking
  * if Tx queues are overflowing, SDUs are dropped above PDCP, not RLC
* log warning if RLC still needs to drop SDUs
  * this case should be avoided with the monitoring mechanism
 4 years ago
Francisco Paisana 5e06430455 removal of stack handler interface 4 years ago
Francisco Paisana 7c364070ee creation of task scheduler interface for classes/functions running outside the main control thread 4 years ago
Francisco Paisana 039977aeb5 renamed interfaces 4 years ago
Francisco Paisana 1a9c04bf2f use of task scheduler handle in pdcp 4 years ago
Francisco Paisana 4f5e65781f created task scheduler class to deal with timers, thread pool, multiqueue, internal tasks 4 years ago
Pedro Alvarez 528777fa29 Added sleep to avoid nas test concurrency issue. 4 years ago
Francisco Paisana 8c920837d6 fix issue when adding neighbour cell that matches serving cell 4 years ago
Francisco Paisana 43db9b81fb fix function ptr issue 4 years ago
Francisco Paisana d746115130 moved serving cell to meas_cell_list 4 years ago
Francisco Paisana 928459408e fix cell meas sorting issue 4 years ago
Francisco Paisana d2dd30c8cb rrc_meas_test failing 4 years ago
Francisco Paisana 9a1f69113f created class for managing neighbor cells of rrc 4 years ago
Francisco Paisana 069dc1f751 moved cell struct of srsue::rrc to separate file 4 years ago
Andre Puschmann 1e4eae7395 nas: log estimated count instead of local rx_count when logging integrity check result 4 years ago
Andre Puschmann bd0c13aad0 ue_stack: bump priority of stack thread 
the stack thread should really run with the next highest priority after
sync + phy workers to make sure it gets enough CPU
 4 years ago
Francisco Paisana 08f9801c76 remove requirement for rrc to be idle and nas attached to run reselection 4 years ago
Francisco Paisana d12b037e0d make cell reselection periodic and with period of 20msec 4 years ago
Francisco Paisana 510687766f added comments in rrc cell select test 4 years ago
Francisco Paisana c6f422d23e improved cell selection test in srsue::rrc 4 years ago
Francisco Paisana 3b1f2719dd return error from cell selection if unable to select serving cell 4 years ago
Francisco Paisana 3e016b8095 select serving cell during cell selection if it is stronger than neighbors 4 years ago
Andre Puschmann 218fa5cf55 ttcn3_dut: fix bug in DUT 
reducing the sync queue len to 1 caused an issue when the
PHY was locking the mutex while trying to push a TTI event
on the stack.

instead of signaling the new TTI within the PHY, we now do it outside
in the DUT (after releasing the PHY mutex)
 4 years ago
Francisco Paisana 84f34bc736 changed to a label filtering approach for ctest 4 years ago
Francisco Paisana ebb8f18000 set some extra tests with the prefix "long_" 4 years ago
Francisco Paisana c6323478d2 remove unecessary sleeps in mac test, and add long_ prefix in long tests 4 years ago
Pedro Alvarez 772ab89391 srsUE: Fix for NAS overflow counter computation. 4 years ago
Ismael Gomez 0382933cb1 Select serving cell if PHY not in sync 4 years ago
Ismael Gomez e378a45db0 Reorganized priorities to avoid GW starve the CPU 4 years ago
Francisco Paisana d7a0fe4060 improve log messages for CA 4 years ago
Andre Puschmann a5c0f96fa7 srsue: limit sync queue length to 1 for ZMQ radio 
apply same change that we've done on the eNB also on the UE
to avoid the PHY processing TTIs faster than the stack.

Without that, we see lots of those in the logs:

...
08:39:17.580325 [STCK] [W] Detected slow task processing (sync_queue_len=7).
...
 4 years ago
Andre Puschmann c15b2ec810 ttcn3_dut: always create timer when enabling TESTMODE B 
create timer but dont yet set it. this avoid adding multiple
checks if the timer var is actually initialized.
 4 years ago
Andre Puschmann cf12c98630 srsue: exit early if radio can't be initialized 
since the radio is the first component we initialize, it is safe to
exit the ue::init() straight away, as no other layers use any handles yet
 4 years ago
Andre Puschmann d16897c09a scell_sync: fix missing dtor freeing sync object 4 years ago
Andre Puschmann e981d5ee70 rrc,ue: refactor wait conditions before transition to RRC idle 
before entering RRC idle, after receiving a RRC connection release for example,
we need to wait until the RLC for SRB1 or SRB2 have been flushed, i.e.
the RLC has acknowledged the reception of the message.

Previously we have only waited for SRB1 but the message can also be received on SRB2
and in this case both bearers need to be checked.

The method is now streamlined to check both SRBs and is also used when
checking the msg transmission of an detach request.
 4 years ago
Andre Puschmann 63f1ea1bec ttcn3: streamline DRB and SRB Tx interface 
use the same tx interface with const uint8_t* and length byte instead of std::string
 4 years ago
Daniel Willmann 7a25d1d300 Send the RRC_PDU_IND as JSON 
Fixes: srslte_ttcn3#13, srslte_ttcn3#15
 4 years ago
Xavier Arteaga f8cc2d176d Fix typo 4 years ago
Xavier Arteaga 2f0c38fc70 SRSUE: avoid deadlock while configuring cell from stack 4 years ago
Francisco Paisana a0606669e2 fix ue nr gw initialization 4 years ago
Francisco Paisana fddcbc9879 fix vnf-ue stack interface 4 years ago
Andre Puschmann 2c5e159420 ttcn3_drb_interface: remove use of GetArray() 
unfortunately, the rapidjson version shipped with Ubuntu 16.04
doesn't support the GetArray() API so we need to use
normal iterator to loop over the array
 4 years ago
Andre Puschmann bf6ddbe976 ttcn3_drb_interface: use uint8_t and len as tx interface 4 years ago
Andre Puschmann 7f47edf67f fix issue where PDCP SDU was not going through UE stack to SS 
this cause the PDCP echo reply not to appear in MAC/PCAP
 4 years ago
Andre Puschmann 07f22326b4 pass current SS TTI when formatting DRB common IND 4 years ago
Daniel Willmann 8652f75510 Don't try to guess the lcid, use what we got 4 years ago
Daniel Willmann 0b88161b3c Send DRB PDUs as JSON to TTCN3 4 years ago
Daniel Willmann 31f1516d74 Use callback to establish connection before sending PDUs in TestmodeB 4 years ago
Daniel Willmann 9aa441f8b6 ttcn3_ue::timer_expired(): Loop through the correct queue 
Fixes a segfault when a NULL pdu is passed to loop_back_pdu_with_tft()
 4 years ago
Daniel Willmann a3adba0081 Implement DRB establishment and handle rx/tx 4 years ago
Daniel Willmann 999de5f484 ttcn3_helpers: Add function to generate JSON for DRB PDUs 4 years ago
Andre Puschmann aca307b79b ue,rrc: don't log neighbor list in info mode 
this floods the info log
 4 years ago
Francisco Paisana d7138b7752 fix nr activation guards 4 years ago
Ismael Gomez 29e126a583
Add per-channel TX gain (#1450) 
* Change type of rf_set_gain() to avoid unambiguous return with negative gains

* Add per-channel TX gain
 4 years ago
Francisco Paisana ddff68a546 add ifdef guards for NR code 4 years ago
Francisco Paisana 6735199728 fix nr optional linking 4 years ago