Andre Puschmann
732a108982
mac: convert rar_pdu_msg[] from vector into array and protect access
...
attempt to address ASAN detected issue:
RACH: tti=821, cc=3, preamble=11, offset=0, temp_crnti=0x47
ASAN:DEADLYSIGNAL
=================================================================
m==25385==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000024 (pc 0x564b19a26c93 bp 0x7fa0e5f1a8c0 sp 0x7fa0e5f1a798 T8)
==25385==The signal is caused by a WRITE memory access.
==25385==Hint: address points to the zero page.
------DL--------------------------------UL------------------------------------
rnti cqi ri mcs brate ok nok (%) snr phr mcs brate ok nok (%) bsr
46 0.10 0 0.0 0 0 0 0% 0 0.0 0 0 0 0 0% 0.0
47 0.10 0 0.0 0 0 0 0% 0 0.0 0 0 0 0 0% 0.0
#0 0x564b19a26c92 in srslte::rar_subh::set_ta_cmd(unsigned int) /mnt/data/jenkins/workspace/srslte_ogt_manual_zmq/srsLTE/lib/src/mac/pdu.cc:1136
#1 0x564b19577f7e in srsenb::mac::assemble_rar(srsenb::sched_interface::dl_sched_rar_grant_t*, unsigned int, int, unsigned int, unsigned int) /mnt/data/jenkins/workspace/srslte_ogt_manual_zmq/srsLTE/srsenb/src/stack/mac/mac.cc:837
#2 0x564b19591765 in srsenb::mac::get_dl_sched(unsigned int, std::vector<srsenb::mac_interface_phy_lte::dl_sched_t, std::allocator<srsenb::mac_interface_phy_lte::dl_sched_t> >&) /mnt/data/jenkins/workspace/srslte_ogt_manual_zmq/srsLTE/srsenb/src/stack/mac/mac.cc:653
#3 0x564b19497ee2 in srsenb::lte::sf_worker::work_imp() /mnt/data/jenkins/workspace/srslte_ogt_manual_zmq/srsLTE/srsenb/src/phy/lte/sf_worker.cc:208
#4 0x564b199f8db4 in
4 years ago
Francisco Paisana
9de318c7e6
avoid allocating DL harqs when respective acks are still pending, when there is a reordering of ttis in the phy
4 years ago
Francisco Paisana
66aa34d173
update RRC NR ASN1 to 2020-09 v15.11
4 years ago
Pedro Alvarez
0c20b7a455
Added support for S1AP modify bearer request support. This includes:
...
- Handle received E-RAB S1AP at s1ap.cc.
- Added methods to rrc.cc, rrc_ue.cc and rrc_bearer_cfg.cc to handle erab modify request.
- Made RLC add_bearer() function capable of re-creating the RLC entity.
- Send RRC reconfiguration to the UE and reply to the EPC with S1AP
modify bearer response.
This commit also adds support to srsEPC to send S1AP modify bearer request for
testing purposes.
4 years ago
Francisco Paisana
099dad8cb1
disable PHR handling in the UL sched by default
4 years ago
Ismael Gomez
f9a02299f9
Use MAC PDU pointer instead of tti_rx and rnti as a key to associate buffers. Decouple crc_info() and push_pdu() functions. This allows for different timing architectures in the PHY
4 years ago
Ismael Gomez
0498439d41
Backport some changes from FAPI branch ( #2124 )
...
* Reorder DCI FORMAT enum
* Fix endianness issue
* Fix return codes in phy_ue_db
* Log members should be destructed after the layers.
* Add JSON metrics and Events. Add Alarm log channel. Simplify MAC metrics struct.
* Restore metrics_stdout change
4 years ago
Francisco Paisana
7869c66fb7
avoid overwriting phy config ul64qam config for scell
4 years ago
Francisco Paisana
82eb31f70f
add rlc metrics to enb
4 years ago
Francisco
e2654e69ec
Enable pdu stack latency measurements in the eNB.
4 years ago
Francisco
b0a7506a8a
add extra check to verify if erab is still available for rrc metric extraction
4 years ago
faluco
343587b32d
Update NR classes after metrics interface changes.
4 years ago
faluco
f20b75a05f
Re-structure enb metrics a bit. Create a generic mac metric struct and per ue mac metrics struct.
4 years ago
faluco
5529943172
Add a per sector rach preable counter for the metrics.
4 years ago
Francisco
f1c05f6826
add sector id to ues in mac metrics
4 years ago
Francisco
43e0a3209d
fill enb rrc metrics with drb info
4 years ago
Pedro Alvarez
7eebd71627
Added S1AP E-RAB release command/response handling to srsENB.
...
Added the ability to srsEPC to send the E-RAB release command.
4 years ago
Francisco
cba0cc457f
sched rand test refactor: creation of abstract sched simulator class for testing
4 years ago
Francisco
a068ae11b0
sched rand tester ue_sim class now handles cqi
4 years ago
Codebot
43082e8d6a
enb/ue: turn various warning messages into info
...
turn events that may happen in the normal life of a eNB/UE
into info rather than warning to allow strict
warning/error checking in tests.
4 years ago
David Rupprecht
848496bb0f
Moved get_earfcn to srslte get_carrier_freq func
4 years ago
Francisco
37ee8bcf46
fix issue 2082 - ensure that sched does not exceeds max coderate while decreasing mcs
4 years ago
Francisco
b4861bc59a
move sched params and sched helper methods to sched_helpers.h/cc files. Removed place in the scheduler where the mcs is increased forcefully to avoid segmentation
4 years ago
Francisco
920e15c1a5
fix logical channel pdu size computation
4 years ago
Ismael Gomez
ae1092257f
Fix issue in 15 PRB 2CA: Due to DCI format ambiguity, the scheduler needs to use Format1A instead of Format1. The number of PRB was incorrectly calculated when generating the grant, leading to corruptions in the MAC PDU.
4 years ago
Francisco
9eddfdb4a3
fix sched rand tester coderate check. tbs needs to be converted from bytes to bits
4 years ago
Francisco
0ae304a6ed
update sched rand tester to detect when tbs coderate exceeds 0.93
4 years ago
Francisco
2598989f7d
replace msg3grant type from C-array to bounded vector
4 years ago
Francisco
22229adf08
fix: normal phr is only sent for PCell
4 years ago
Francisco
8670558692
fix failing scheduler ca test
4 years ago
Francisco
479602ed1d
add option to specify target ul sinr for UL power control to the enb rr.conf parser
4 years ago
Francisco
5865df39d1
created class that implements the scheduler transmit power control and PHR handling
4 years ago
Francisco
2b59e90304
fix: limit number of encoded PHICH in the scheduler to the max size of the array
4 years ago
Francisco
2b97b2c8bb
add bound checks for data, bc, and rar allocations in the scheduler to avoid array overflows.
4 years ago
Francisco
86ab1864f7
The struct tti_point is now used ubiquitously in the scheduler
4 years ago
Pedro Alvarez
49bcffcdf8
Fix issue packing TEID in Error indication.
4 years ago
Pedro Alvarez
235f373af7
Started to add ability to send error indication when G-PDU from invalid TEID is received.
4 years ago
Francisco
8fb3ea6922
Added the ability to choose scheduling policy from enb.conf
...
- The two options provided at the moment are time-domain RR and PF
4 years ago
Francisco
b71e8075f4
Refactoring of scheduling algorithms
...
- Use single interface for both DL and UL
- Wrote helper functions for tasks that are common to different algorithms
- created subfolder for all scheduling algorithms
4 years ago
Francisco
d7fae0b7a3
Implementation of time-domain PF scheduler
...
- PF scheduling becomes the new default
4 years ago
Andre Puschmann
07d2bc4fe8
change license header to agnostic version with hint to root LICENSE file
4 years ago
Francisco
a5ef9f1eb9
potential fix for heap-overflow in scheduler, issue #2053 . Added a bound check for the number RACH handled per tti. RACHs are ignored once the limit is surpassed.
4 years ago
Francisco
2fcb507de7
Fix gcc compilation errors with false_position_method in sched_ue.cc
4 years ago
Francisco
8d181ef41c
Optimization of cc_sched_ue::cqi_to_tbs(...) method via the use of root-finding algorithm
4 years ago
Francisco
94efeab672
Optimization of sched_ue methods to derive required number of prbs to allocate to a rnti
...
This optimization has been achieved by:
- implementation of "false position method" root-finding algorithm
- application of the false position method in cc_sched_ue::get_required_prb_dl/ul(...)
The number of iterations in the worst case scenario, reduced from 100 to 5 with
the proposed algorithm.
4 years ago
Francisco
f07e52129c
increase mcs ul upper bound to 24 when ue is cat4 and enb supports 64qam. Simplified max_mcs computation
4 years ago
Francisco
3d80ff4831
fix activation of PDCCH for adaptive retxs.
4 years ago
Francisco
fc81a5c6ba
harq ack state can now only be NACK or ACK. The ul_harq pending phich flag is now reset after phich scheduling. Thus, the existence of a crc_info(...) signal from the PHY is not required.
4 years ago
Francisco
3067e81e67
fix check of pending UL bytes
4 years ago
Francisco
bb96625129
renaming lch_manager -> lch_ue_manager
4 years ago
Francisco
a348508072
simplified sched_ue pending DL bytes calculation API
4 years ago
Francisco
0ffea62411
Wrote logging functions for SCHED MAC CE/LCID allocations
4 years ago
Francisco
c1fb161004
Move sched lch_manager to separate file
4 years ago
Francisco
eae0dc93ad
rename scheduler files. scheduler -> sched
4 years ago
Francisco
68eda336bd
remove ENB_METRICS_MAX_USERS compile time macro and use run-time variable to set maximum number of UEs the srseNB can have connected at a given instant.
4 years ago
Ismael Gomez
ce20cc4c54
Add missing current_tx_nb which was causing all in uplink to fail
4 years ago
Pedro Alvarez
d05bc064b5
Reduced SCTP connect() timeout.
...
Added configuration for RTO_MAX. Cleanup debug prints.
4 years ago
Francisco
324cb80cac
rename cell_info_common->enb_cell_common and cell_ctxt_dedicated->ue_cell_ded
4 years ago
yagoda
bdc1964335
consolidating RRC eMBMS configuration into single function, setting some parameters to const
4 years ago
yagoda
b90574975b
refactoring asn1 eMBMS code, removing asn1 from PHY and MAC in eNodeB
4 years ago
Andre Puschmann
fb83b5c307
enb: fix reestablishment with AS security enabled
...
this fixes RRC reestablishment with security turned on
the bearers, primarily SRB1, were reestablished before the "old"
security context was restored from the previous RNTI of the
reestablishing user.
this let SRB1 without proper security config. therefore the UE
couldn't decrypt the first response of the UE on SRB1 that was
already encrypted.
4 years ago
Francisco
92c1c2a182
more efficient measObjToAddModList reconfiguration by ensuring consistency in EARFCN ordering
4 years ago
Francisco
68d463b08f
remove var_meas_cfg_t class
4 years ago
Francisco
25bfb6d84d
move rrc measconfig handling functions to separate file. Update measconfig tests
4 years ago
Francisco
1cb65f07f1
enable meas gaps in RRC and enb parser
4 years ago
Francisco Paisana
49a48c0130
add measgap awareness to scheduler metric and sf_sched. Add measGap test to random sched test suite.
4 years ago
Francisco Paisana
2b05d5a67c
add meas gap addition logic to srsenb rrc mac controller
4 years ago
Francisco Paisana
9579931f16
added meas gap checks to scheduler ue
4 years ago
Francisco Paisana
fdec451a9d
disable mcs>20 if eNB supports UL 64QAM but UE doesn't
4 years ago
Francisco Paisana
bc00abeeb8
fix phy configuration of UL 64QAM
4 years ago
Francisco Paisana
b369d6d5d5
consider enb sib config when activating UL 64QAM
4 years ago
Francisco Paisana
bf7c587e4f
add UL 64QAM support to eNB RRC and scheduler
4 years ago
Francisco Paisana
d5f6ccc0c4
integrated UL UE-dedicated sched tests in random test
4 years ago
Francisco Paisana
64fca23eb3
extended dci content checks of DL and UL grants in the scheduler random tester.
4 years ago
Francisco Paisana
88105c1577
change the namespace of tti point helper functions for the eNB
4 years ago
Ismael Gomez
524453a6af
Fixes N_pucch_cs allocation to avoid collision with SR
4 years ago
Ismael Gomez
13f1d65b24
Add missing current_tx_nb which was causing all in uplink to fail
4 years ago
Francisco Paisana
3ea47b645a
changed the way the number of UL pending bytes is calculated in the scheduler
4 years ago
Francisco Paisana
77d64f3ea5
add PDCCH alloc to UL retxs that resume the HARQ
4 years ago
Francisco Paisana
d8203acd56
implement harq resuming functionality
4 years ago
Francisco Paisana
510959b50f
update nr asn1 files, and asn1 tests
4 years ago
Francisco Paisana
f927ccaf55
fix pusch grant allocation for cqi reporting in CA.
4 years ago
Francisco Paisana
a351b2534e
allow PUSCH grants for CQI in PCell
4 years ago
Francisco Paisana
2ade364434
defer scell activation to rrc reconf complete reception
4 years ago
Andre Puschmann
74dcdec54f
enb: fix antenna port count for SCell config in RRC reconfig
...
set antenna port count for SCells in RRC reconfig message according
to configured ports in the enb config
4 years ago
Francisco Paisana
a865858db3
disable srbs UL during handover to avoid UL grants and scheduling requests before the handover is complete
4 years ago
Francisco Paisana
484c7586b4
fix heap buffer overflow
4 years ago
Francisco Paisana
42cdc5e340
Allocate all the leftover bytes of the TBS to last allocated MAC SDU.
...
Fix the way the RLC header is accounted for depending on the bearer id.
For instance, the SRB0 does not require any RLC header.
4 years ago
Francisco Paisana
55d62a2baa
fix rlc buffer updating inside the scheduler to account for RLC headers
4 years ago
Francisco Paisana
84cfc29ca1
apply the scell configuration sooner during intra-enb handover
4 years ago
Francisco Paisana
b40a5a958e
use common function to fill rrc reconf message in handover
4 years ago
Francisco Paisana
e9b693942f
diff-based cell selection activation
4 years ago
Francisco Paisana
836e7d7ede
refactor scell addition in the srsenb::rrc to follow the same style of other rrc recfg fields
4 years ago
Francisco Paisana
a8e11d7991
removal of the special case for rrc reconf update
4 years ago
Francisco Paisana
f26b5ccde7
fix drb reestablishment during handover
4 years ago
Francisco Paisana
7bf196a6e0
removal of srb handling from srsenb::rrc::bearer_cfg_handler
4 years ago
Francisco Paisana
2ef1e286b2
fix set of rrc reconf message radio resource cfg fields
4 years ago
Francisco Paisana
890113fd32
now the rrc enb is using a common function for rr_cfg reconf for the first reconf message
4 years ago
Francisco Paisana
ce78fa82ce
now the rrc enb is using a common function for rr_cfg setup/reest
4 years ago
Francisco Paisana
97f2e4336e
refactor of functions for filling the asn1 radio resource config structs. This functions are used during rrc setup/reest/reconf
4 years ago