2468 Commits (f2409534e492716ed3dbf5ee423f6f73e520dff4)

Author SHA1 Message Date
Francisco 01d8814f39 sched,nr: when sched allocates PUSCH, SR doesn't need to be decoded 3 years ago
Fabian Eckermann b034a9c983 Lock mutex when setting common cfg. 3 years ago
Francisco f427a25a30 nr,gnb,mac: account for header space larger than 2 when packing PDSCH 3 years ago
Andre Puschmann f7dd327d08 enb,rrc_nr: send PUSCH nominal power 3 years ago
Carlo Galiotto dc3dad6e20 rrc,nr: implements PR review comments
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto fb75cbaadc rrc: disable MAC bearers when RNTI gets updated
When the RRC handles the C-RNTI CE to update the RNTI, all the bearers
associated with the new RNTI (that will no longer be used) need to be disabled.
This commit implements this.

Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Francisco 9df6c6b936 sched,nr: ensure the ue_cfg_t passed to the scheduler in NR FDD mode has the correct harq delay 3 years ago
Andre Puschmann 255ddb1329 enb,gnb: add basic support for sgnb release procedure
the procedure is currently started when the EUTRA UE object
is deleted (after RRC release) in order to clean-up the
ENDC resources on the gNB.
3 years ago
Francisco bc4264277a sched,nr: update NR scheduler tester to support parallel CC workers 3 years ago
Francisco ea324e8cbe nr,sched,test: update sched nr test to better reflect MAC-PHY FAPI 3 years ago
Andre Puschmann cc0255e4f1 enb,rrc_nr: reduce log level to info when C-RNTI is received for current RNTI
it might happen (cause by the UE or eNB) that the Msg3 with C-RNTI is passed
twice (e.g. Retx). It's ok to be logged for now but not in Error level. Reduce to warning.
3 years ago
Andre Puschmann d708f05869 rrc_endc: disable DC-PHR reporting in the UE
this solves #3432 until we've fully implemented the parsing/handling
of the DC-PHR
3 years ago
Carlo Galiotto ecd1a15e1f mac: revert order of processing MAC subPDUs
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Francisco efdd249cb3 nr,sched: fix dangling reference to ue_cfg in scheduler 3 years ago
Francisco 73859a5b6a nr,sched: improve logging of PDSCH and PUSCH in scheduler to also show coreset id and buffer state 3 years ago
Francisco 64ffd81cf9 nr,sched: fix recomputation of ue_bwp_cfg when sched receives new ue_cfg objects 3 years ago
faluco aa0c936f50 Fix race condition when destroying the gnb stack class.
The gnb stack class could be destroyed concurrently while still running its task scheduler thread.
3 years ago
faluco 75af37bd4b Batch of race fixes when running the UE and ENB with UHD.
Main fixes are in the UHD driver, fixing races and potential deadlocks.
3 years ago
Alejandro Leal Conejos 1a64c6adad Enum fixes so clang 12 can build the repo 3 years ago
Francisco 964dce575b nr,sched: fix nof_harqs in NR scheduler to 8 3 years ago
Francisco acd5b8c46a nr,gnb,rrc: correctly configure TDD for UE and scheduler 3 years ago
Francisco 25f34502a7 nr,gnb,rrc: restore the GTPU TEIDs back from NR RNTI to LTE RNTI when RRC reconfiguration fails 3 years ago
Francisco 25eb44914e nr,sched: fix sched_args_t default values 3 years ago
Francisco 04d48127bb nr,sched: enable NR fixed mcs configuration via enb.conf 3 years ago
Carlo Galiotto 919d949790 mac: fix rebase errors
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto a57ccdabf5 mac: move and check boolean from funcion to caller
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto 1a52cdcdaa mac: remove unused rwlock and unused cqi counter
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto f53e01cfa3 mac: apply changes by PR reviewers
- reinstate write_lock on ue metrics
- change "rwlock" variable name in mac_nr.h

Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto dc3e3a89f8 mac: update CQI in MAC with CSI reports from PHY
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto 781ae4abfb fix static analysis error (CID 373575)
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Xavier Arteaga f250c83a66 Minor NR configuration fixes 3 years ago
Francisco 6926754e67 nr,sched: fix sched logging in case of HARQ CRC=KO 3 years ago
Francisco c08bb6023c nr,sched,refactor: clear of unused typedefs and renaming of some types 3 years ago
Francisco 11ee4ab9dd nr,gnb,rrc: fix scheduler FDD configuration 3 years ago
Francisco 53c99796cc nr,gnb,rrc: ensure timing advance offset is set to present 3 years ago
Francisco ca7a3cf201 nr,sched: fix sched tbs acked metric computation 3 years ago
Francisco 510e9f47a7 sched,nr: simplify metrics extraction from MAC
Allow some level of mutex contention between metrics and worker threads in accessing
internal scheduler variables.
3 years ago
Francisco af0bc36de9 nr,sched: ensure scheduled RAR grants are reset every slot 3 years ago
Francisco 2b41efaa23 nr,phy,gnb: enable PUSCH debug logging 3 years ago
Francisco 1b595b6eff nr,gnb: if no nr cell is initiated, do not enable endc in the LTE RRC 3 years ago
Francisco 7e0fd2721d sched,lte: disable all SRBs UL during intraenb Handover 3 years ago
Francisco 78f8302839 sched,lte: addition of extra logs in sched ue configuration 3 years ago
Francisco 877b995a4d gnb,nr: add metrics for ack'd TBS in the gNB. 3 years ago
Francisco 479df12775 fix rrc_nr_test bad config 3 years ago
Francisco 9dcfa8fdb1 nr,gnb,rrc: pass default rrc_nr_cfg_t to rrc_nr_test 3 years ago
Francisco 2e71dc17a5 rrc,nr: transfer SSB config to ue phy_cfg in the scheduler 3 years ago
Francisco 43b12b9ffb rrc,nr: transfer SSB config to both UE and NR scheduler 3 years ago
Andre Puschmann 8118c368d9 rrc_nr: add missing PRACH config part 3 years ago
Andre Puschmann eaf87140e1 rrc_nr: add TAG and PHR config in MAC (but keep it disabled) 3 years ago
Andre Puschmann c463ccd961 rrc_endc: pack MAC main config dedicated with DC PHR config 3 years ago
Andre Puschmann 93acf57e1a rrc_nr: set cellGroupId and groupId 3 years ago
Andre Puschmann 929c6d9fe6 rrc,endc: avoid sending PHY config dedicated for SCG addition 3 years ago
Andre Puschmann e2ffbd85bc enb,rrc: add SIB2 field to display 5G logo ;-) 3 years ago
Andre Puschmann c8d6f54dab enb,rrc: add radio link monitoring config 3 years ago
Francisco 400d7587c8 lte,rrc,enb: stop rlf timers after the UE performs intra-eNB handover
The RLF timers may be triggered before handover, which will lead to the
UE getting released after it successfully handovers. To avoid this,
we should stop the timers.
3 years ago
Carlo Galiotto 43a7d822fa stack,rrc: fix double removal of EPS bearer
The EPS bearer was removed twice, causing an error in the logs.

Fix issue #3380

Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Francisco d30239f47b sched,nr: check existence of rnti before processing feedback 3 years ago
Francisco 73f1981e5e sched,nr: use R_prime instead of R in scheduler to limit coderate 3 years ago
Francisco 344f067c13 sched,nr: increase max R to 0.93 to enable mcs=28 3 years ago
Francisco 7d4a5238f6 sched,nr: force R<0.9 by reducing mcs 3 years ago
Francisco d6a3daff8a rrc,nr: re-activate NZP-CSI-RS for FDD 3 years ago
Francisco 053877f489 rrc,nr: fix conversion from asn1 to phy cfg 3 years ago
Francisco 47e5e85449 refactor: clean unnecessary includes of the asn1/rrc_nr.h 3 years ago
Francisco ef78c7e06f rrc,nr,gnb: add csi resource to add/mod config to FDD 3 years ago
Xavier Arteaga 1bdb1bb62d Store PUSCH CSI from PUSCH DMRS 3 years ago
Francisco 5c3f0a39ee sched,nr: set scheduler ue candidate logging to debug level 3 years ago
Bedran Karakoc 1e1e1420b1 Return AUTS in authentication failure for case AUTH_SYNCH_FAILURE 3 years ago
Bedran Karakoc aaaaea0537 Fix logging string formatting 3 years ago
Bedran Karakoc ca08b18745 Pass pdu_session_id instead of lcid for mapping in GTPU 3 years ago
Bedran Karakoc 850606f20b Added deregistration (UE terminating) 3 years ago
Francisco a066236a96 rrc,nr: disable NZP-CSI for FDD 3 years ago
Francisco cda4275ed0 sched,nr: disable simultaneous RAR and SSB until the PHY supports it 3 years ago
Xavier Arteaga b060c3deca Add possible band when invalid band is given 3 years ago
Andre Puschmann 546f637f91 rrc_endc: increase max_report_cells to 8
make sure that both EUTRA and NR cells fit in report
3 years ago
Andre Puschmann f8c2f2bc52 enb,rrc_nr: also make sure to send UL freq band list item 3 years ago
Andre Puschmann 703e8dc6f1 enb,rrc_nr: fix bug where freqInfoUL was not containing abs_freqpoint_A for FDD 3 years ago
Andre Puschmann 8d2c394326 enb,rrc: fix SSB absolute freq value in EUTRA measConfig
we've been using the ARFCN of the NR carrier instead of
the absolute freq SSB.

The patch fixes this and renames the variable to make it clearer.
3 years ago
Francisco 3b79393974 sched,nr: fix default ue configuration when prach arrives 3 years ago
Andre Puschmann bae003d3a9 enb,rrc: set SSB periodicity to 10ms 3 years ago
Andre Puschmann bdc84f24f3 gnb,cfg: fix SSB config deriviation
* this fixes the SSB config for TDD
* UE decodes the SSB correctly
3 years ago
faluco a2c433b228 Fix data race in the enb::mac::ue metrics object. 3 years ago
faluco 83b9777220 Fix data races in cell_list array members inside enb::phy_common. 3 years ago
Francisco Paisana efa2026a70 sched,nr: erase uneeded parameters from sched_nr_interface bwp_cft_t 3 years ago
Francisco Paisana 51f1c0d6ef rrc,nr: refactor csi report asn1 configuration 3 years ago
Francisco Paisana b7f40b2baf rrc,nr: reenable CSI reporting in gNB 3 years ago
faluco e5d48d1d21 Fix data race in MAC NR metrics. 3 years ago
faluco 9058ee9a5b Move gNB metrics processing to the stack thread avoiding concurrency issues in MAC and RRC. 3 years ago
faluco dadd2f7524 Removed querying the NR scheduler user array from the metrics thread that caused a data race. 3 years ago
faluco e0238f4092 NR: Fix a race condition where we could remove a UE from the mac while still being accessed by the NR PHY worker. 3 years ago
faluco a703279975 Fix a data race when passing the nr_workers to the txrx worker.
There was an unprotected access of the txrx reading this variable while being set from a different thread.
Fix it by starting the txrx thread after all variables are ready.
3 years ago
Andre Puschmann 06fbb58d70 gnb,mac: add dedicated arguments struct for MAC-NR
as the PCAP object is now only visible inside MAC-NR we can't
share the PCAP file between EUTRA/NR (like we do in the UE).

This patch removes the hard-coded filename for the NR PCAP file.
3 years ago
Fabian Eckermann cb721aa292 fix calculation of ssb frequency. 3 years ago
Ismael Gomez 2111788740
Move DRB activation/deactivation to after filling endc connectionReconfiguration (#3371)
* Move DRB activation/deactivation to after filling endc connectionReconfiguration

* Move bearer update in the scheduler to after filling endc connectionReconfiguration

Co-authored-by: Francisco Paisana <francisco.paisana@softwareradiosystems.com>
3 years ago
Xavier Arteaga b6ea78dfd3
Fix gNb PHY-Stack UL-DL time paradox (#3365)
* Fix gNb PHY-Stack UL-DL time paradox

* Fix clang compilation
3 years ago
Ismael Gomez 6bdeb2d6b6 Fix division by zero in JSON metrics 3 years ago
Francisco Paisana b58915d7ed rrc,nr: make gnb cell CSI NZP configuration consistent with UE NSA configuration. 3 years ago
Ismael Gomez 410cec7557 NR: assume all zero LCG is SBSR with 0 is received 3 years ago
Francisco Paisana 23bf542ae7 stack,nr: isolate calls between LTE and NR stacks via the task multiqueue 3 years ago
Francisco Paisana 9160c783c9 sched,nr: fix nr sched test 3 years ago
Francisco Paisana 7aa701eb85 nr,config: fix default SSB periodicity configuration in rrc and scheduler 3 years ago
Francisco Paisana 0cb76681a8 sched,nr: forbid concurrent SSB and PDSCH until it is supported 3 years ago
Andre Puschmann 8bb06ff2c0 Added SSB in gNb PHY 3 years ago
Francisco Paisana 952b958aff nr: signal RRC activity when an NR UL PDU is received 3 years ago
Andre Puschmann 3e5b40fd36 enb,rrc: fix compilation after freq point a has been removed from nr_carrier_t
since absolute freq point a members have been removed from the srslte_nr_carrier_t
struct (they are now actual frequencies) the abs_point_a values are now in
the RRC cell structs
3 years ago
Fabian Eckermann 95abfbfec8 Calculate ssb frequency from freqency point a. 3 years ago
Xavier Arteaga ca19b466bb Fix paging float to int conversion 3 years ago
Francisco Paisana f97b92abd0 sched,nr: fix nzp csi rs allocation in NR scheduler 3 years ago
Francisco Paisana 55ea2cbcee sched,nr: fix harq delay derivation 3 years ago
Francisco Paisana 8ceb573ea7 mac,nr: avoid concurrency in update of pdsch/pusch slot 3 years ago
Carlo Galiotto f177a03605 sched,nr: add const to function input parameter
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto 9887c17c17 sched,nr: move ssb_sched test to different file...
and also:
- correct half-frame bit in MIB package
- rename slot_index variable in ssb_sched function

Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto d18af603aa sched,nr: address comments in PR (code formatting)
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto bc7c21b8c3 sched,nr: add test case for SSB scheduling
The SSB test checks whether, with the given periodicity, the
SSB grant is present within the dl_sched structure passed to the PHY.
It also checks that the SSB grant is not scheduled outside
the required time slots.

NOTE: The test is a modified version of an existing scheduler test.

Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto fd4b368f71 sched,nr: handle case of ssb_periodicity not given
If the parameter ssb_periodicity is not given by higher layers,
the function needs to handle this case. The parameters could be
passed with 0 value, which makes the function crash.

For the time being, if ssb_periodicity is not given, the std value
5 ms will be used.

Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto 9d864bbe55 sched,nr: add function that schedule SSB
Notes:
- NOT YET TESTED
- Requires rebase on commit with PHY changes to work

Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Ismael Gomez 6b506ec357
phy_common: clear tx_hold flag before releasing the semaphore (#3342) 3 years ago
Andre Puschmann f8d55a6fd3 Refactor rrc nr. 3 years ago
yagoda 82bda02b36 adding nr metrics 3 years ago
Andre Puschmann 86938e8474 sched_nr_cfg: bump fixed UL MCS to 28 3 years ago
Andre Puschmann 782aefa553 enb,rrc: derive ENDC configuration from cell config
* move ENDC config struct to main RRC config (same for all UEs)
* remove hard-coded measurement config for NR carrier
* now both TDD and FDD cells are correctly handled
3 years ago
Fabian Eckermann eb294fd4e3 Add phy object to rrc_nr_test. 3 years ago
Fabian Eckermann 992d1bb02a Configure PHY from RRC. 3 years ago
Francisco Paisana 28e25b12b4 sched,nr: add error checking and logging for invalid PIDs 3 years ago
Francisco Paisana 14b3a65dfe sched,nr: fix assignment of PID for PUSCH grants that the scheduler outputs 3 years ago
Andre Puschmann 2b1be3dbce enb,rrc_nr: fix wrong fmt formater 3 years ago
Andre Puschmann a66994aa80 gnb,rrc: disable NZP and ZP CSI configs 3 years ago
Fabian Eckermann 1018e7ae1c fix validation of ul_arfcn. 3 years ago
Fabian Eckermann 93eb6e93d9 Read band from rr config. 3 years ago
Ismael Gomez a1294ed06a srsgnb: use lcg=3 for as a default for drb. Pass lcg to MAC config 3 years ago
Francisco Paisana 78dad52cc8 rrc,nr,gnb: disable CQI configuration in gNB until gNB PHY supports it 3 years ago
Francisco Paisana a64750e1be rrc,nr,gnb: fix number of PDCCH candidates in search space 3 years ago
Fabian Eckermann e02218e4ab configure phy to be tdd by default (currently static). 3 years ago
Ismael Gomez 91401ae3a4 Fix meascfg test 3 years ago
Ismael Gomez 7bc8bb8500 combine all report configuration with all measurement objects 3 years ago
Ismael Gomez ada05ea0c8 Add A1, A2 and A4 measurement Reports event triggers 3 years ago
Ismael Gomez 04db8c6bbf Log measurementReport before checking if it's valid 3 years ago
Fabian Eckermann 8830c2796f Add support for NSA FDD on band n3, n5 and n7. 3 years ago
Francisco Paisana c45c3ec95c sched,nr: ensure the SSB and NZP CSI RS allocations are cleared at the end of every slot 3 years ago
Francisco Paisana d927b779dc sched,nr: implement methods to fill nzp csi-rs in scheduler 3 years ago
faluco a8f58f503c - Fix arm compiler warning. GCC treats chars as unsigned in this arch.
- Fix race condition in json metrics.
3 years ago
Francisco Paisana 17e015df62 rrc,nr: fix PUCCH Resource CSI configuration to avoid collisions with SR 3 years ago
Andre Puschmann 315057d11c enb: signal user activity to EUTRA RRC when doing NR DL traffic
to avoid releasing the UE when only NR DL traffic is done.
similar to the EUTRA solution.
3 years ago
Xavier Arteaga 8b2514ded3 Added NZP-CSI-RS signals in gNb 3 years ago
Andre Puschmann 6054e1229b enb,rrc,rrc_nr: fix logging when removing user
each action should only be logged once
3 years ago
Andre Puschmann 9cefddd739 enb,mac_nr: remove user from scheduler when removed from MAC 3 years ago
Francisco Paisana 698eff29f4 sched,nr: avoid ul pending bytes of each UE becoming negative 3 years ago
Francisco Paisana 3119214124 nr,rrc: defer drb activation in NR to when the C-RNTI is received 3 years ago
Francisco Paisana cbb709d4e3 sched,nr: function to log UEs buffer status before scheduling decision, fix const_iterator of circular_map 3 years ago
Ismael Gomez 1c77998df5 Stop PDCP for data bearers before initiating HO 3 years ago
faluco fa351cd285 Rename functions that contain the unsafe word to nolock.
The term "unsafe" does not clearly state that the function is not locking the shared date and it sounds "dangerous", so use a more explicit term.
3 years ago