Andre Puschmann
598594c51a
all: bunch of pass by const& changes suggested by LGTM
4 years ago
Francisco
70d6e4d9b3
mac, fix - Verify that mac::ue also exists in the scheduler before attempting to retrieve its metrics
4 years ago
Francisco
6e7d992552
remove UE on S1AP Release Request if MME S1AP UE ID hasn't been assigned yet
4 years ago
Xavier Arteaga
6045998909
enb_phy_test uses default rr configuration
4 years ago
Francisco Paisana
d39183419c
Separate TPC PUSCH and PUCCH target SINR ( #2740 )
...
* separate target pusch and pucch sinr configurations in tpc class and rr.conf
4 years ago
Francisco
86dac9c823
several coverity high and medium impact fixes
4 years ago
Andre Puschmann
20575d3eec
phy,enb: only initialize NR workers if needed
...
the NR support in the eNB isn't finished yet but loading
all DL objects even for 4G only isn't required. So only
even attempt to load them if a NR cell is configured.
4 years ago
Andre Puschmann
ff53d2b8b8
all: set of trivial changes reported by LGTM
...
mainly fixmes, unused/empty code, etc.
4 years ago
AlaiaL
d88760f099
Fixes coverity 366620
4 years ago
AlaiaL
beaa1b3e24
Fixes coverity 369569
4 years ago
AlaiaL
82788ca094
Fixed issues from coverity:
...
- 370233
- 370234
- 370239
- 370240
- 370241
- 370242
- 370243
- 370295
4 years ago
herlesupreeth
0f06ec0d9c
Add feature to provide custom GTP-U (S1) address to be advertised inside S1AP messages
...
This feature is useful in scenarios where eNB is behind a NAT and EPC on public cloud
Since eNB's GTP-U can only bind to IP address visible in it's host (usually a private IP beind a NAT), it advertises the same to UE in S1AP message
resulting in traffic from EPC to eNB (DL traffic) not able to reach eNB. This commit solves this issue by providing a means to advertise a different IP address than the one GTP-U UDP socket is bound to.
This IP is usually advertised in InitialContextSetupResponse and E-RABSetupResponse.
In order to make use of this feature, use the following parameter in enb.conf
Example:
gtp_advertise_addr = 213.61.141.82
4 years ago
faluco
cd1c6732f7
Remove the creation of strings when preparing the contents of a log entry in sched_helpers.
4 years ago
Francisco
ff3fc0826b
asn1 fixes and improvements
...
- use const char* instead of std::string in enumerated<>::to_string() to avoid mallocs.
- Remove the use of "typedef", and use "using" keyword instead.
- Fix rrc_nr::setup_release_c<>::to_string() broken linkage.
4 years ago
Francisco
42e7fc656b
s1ap fix - send S1AP UEContextRelease when the UE does a new RRC connection setup with the same TMSI
4 years ago
faluco
69726bc939
Remove two allocs in the prio queues in sched_time_pf.
4 years ago
faluco
7df308c756
Remove two mallocs in the stack:
...
1) Extend the small buffer to 64bytes for the move_callback class.
2) Replace a std::map for a fixed size circular map in sched_time_pf.
4 years ago
Xavier Arteaga
407903e0d6
SRSUE: refactor carrier setting for accepting a dynamic carrier configuration
4 years ago
Xavier Arteaga
1a4de831e9
Ammended eNb PHY tests
4 years ago
Francisco
d1b336101f
revert enb phy tests. Check that when nof_carriers==6 the phy fails to start and reports an error.
4 years ago
Francisco
6137e4569b
fix srsran_assert definition when asserts are disabled
4 years ago
Francisco
3b78bf3730
bugfix - fix memcheck warnings. move instructions with side effects outside of asserts
4 years ago
David Rupprecht
a064e85c54
rename common lte header
4 years ago
David Rupprecht
81ad72b0ff
Refactor srb and drb handling
4 years ago
David Rupprecht
6b41ae7e8b
Updated PDCP config struct for rat type
4 years ago
Francisco
8ed8b94ca5
in search for contiguous prb interval, skip already scanned prbs
4 years ago
Francisco
22024ac35d
implemented bounded_bitset::find_lowest(...) for both reverse and non-reverse bit ordering. Applied this method to UL scheduling search for PRB intervals
4 years ago
David Rupprecht
f42d4dbc28
Refactored carrier config
4 years ago
Francisco
52bf973981
s1ap - set cause to transport when gtpu fails to allocate TEID
4 years ago
Francisco
791b8d24ce
fix regression in scell activation during intraenb handover
4 years ago
Ismael Gomez
77b11b82ac
Release UE if no activity in DRB ( #2658 )
...
* Count user activity with DRB only and SRBs for initial procedures. Add counter to release user after max KO in UL.
4 years ago
Francisco
4838cd2f5e
implement cell measurement bandwidth feature
4 years ago
Francisco
14d32db92f
implement Handover direct forwarding path availability configuration feature
4 years ago
Francisco
4b9e59e8cf
fix some s1ap msg causes
4 years ago
Francisco
b8fa1d1b61
fix rrc mobility test
4 years ago
Francisco
66988ffd32
s1ap - simplified erab setup procedure. Handle correctly the failure to setup causes
4 years ago
Francisco
f401683960
s1ap - simplified erab modify procedure
4 years ago
Francisco
76978f0d14
s1ap - simplified erab release procedure
4 years ago
Francisco
c5fc543516
s1ap - handling of ts1 reloc overall timer.
4 years ago
Xavier Arteaga
7823bfc28c
Fix append NR to loggers for NR components
4 years ago
Francisco
c2a99a8112
handover - support for handover cancellation causes, check for E-RAB QoS requirements, cancellation of handover if E-RABs are not supported in the target eNB
4 years ago
Francisco
f79e0fade8
handover - set handover required cause to handover desirable for radio reason
4 years ago
Francisco
6d401bc79f
handover - check if UE integrity and encryption algorithms are supported in the target eNB, and report handover failure if not.
4 years ago
faluco
9b634218be
Pre allocate some vectors members in the scheduler.
4 years ago
Francisco
77bd500312
handover - implement and test S1 Handover fail path for the case of invalid QoS config in HO Request message
4 years ago
Francisco
d2c404b166
handover - setup s1ap cause in case of handover failure at the target enb
4 years ago
Francisco
49bd895e29
s1ap - handle invalid or repeated erab ids in s1ap erab release command
4 years ago
Francisco
7842e3bff3
s1ap - add unit test to check correct handling of invalid E-RAB ids in modification request. Fix s1ap in order for the test to pass
4 years ago
Francisco
985846e3bd
s1ap - set multiple erab ids cause in replay when s1ap erab modify request has repeated ids.
4 years ago
Francisco
bc16c46ffc
detect and handle repeated ERAB IDs in S1AP ERAB Modify Request message
4 years ago
Andre Puschmann
c9da21c9bb
mac_nr: add error handling when unpacking SCH MAC PDU
...
* only handle PDU if unpacking was successfull
* add TC unpacking with malformed PDU
4 years ago
Francisco
685c971dc2
fix recursive call to get rb name
4 years ago
Francisco
f7a8b8bf94
separate drb srb ids into separate enum types
4 years ago
Francisco
3a23546c56
fix pdcp_nr.cc compilation
4 years ago
Francisco
21718af3b6
avoid allocating std::string to get lcid radio bearer name. Refactored the lte radio bearer enum type
4 years ago
Francisco
99b4595b69
fix enb phy test by limiting the number of carriers to 5
4 years ago
Francisco
d142d7b6a5
update test helpers for enb, so that the rrc tests pass
4 years ago
Francisco
ac7cc3c42d
change enb ue softbuffer initial allocation size
4 years ago
Francisco
75e9700de0
rlc - usage of memory pool to allocate RLC bearers
4 years ago
Francisco
8fe27a72d0
enb - decreased default enb.conf mac.max_nof_ues to 8 to avoid large memory pool preallocations
4 years ago
Francisco
71f1f1b556
enb - log warning when rnti-specific memory block is full
4 years ago
Francisco
a890a22ccd
enb - rnti memory pool now fallbacks to new/delete if rnti-specific memory block is full
4 years ago
Francisco
344bdf3165
allocation of UE rlc and pdcp classes in the ue dedicated memory pool
4 years ago
Francisco
60d5c6df7b
implementation of memory pool with individual memory blocks per UE that get accessed via their rnti
4 years ago
Francisco
9b7060a098
check ptr value before dereferencing
4 years ago
Ismael Gomez
c4069b58af
Call HARQ new tti only for the current PID
4 years ago
Andre Puschmann
cbe7980d7d
enb,mac_controller: apply new MAC config with disabled DRB
...
fix regression in RRC that updated the local MAC config to
disable DRB scheduling after maxRetx, but didn't actually apply the config
4 years ago
Francisco
bb9601c13b
gtpu - fix gptu manager members destruction order
4 years ago
Francisco
b7d4a72ea1
adt - fix circular map clear() and erase(it) functions
4 years ago
Francisco
643c73acee
gtpu - fix removal of gtpu tunnels when rnti is released
4 years ago
Andre Puschmann
7459a65a8e
enb,rrc_ue: remove unused variable
4 years ago
Francisco
d02cc51e33
use mutex or atomic in running flag to signal the interruption of a thread
4 years ago
Xavier Arteaga
49731ab5a1
Initial NR-DCI refactor
...
Added NR DCI 1_1 size
Several DCI NR fixes
4 years ago
Francisco
cdf72248f3
Reimplement batch-based background object/memory pool
...
Main changes:
- addition of pool utilities
- The node size/alignment and batch allocation threshold are now runtime arguments
- object pool and memory pool are not anymore based on the same class.
The object pool cannot use intrusive free list because it would overwrite the object
memory
4 years ago
Francisco
fbeb87c53e
remove unused parameters from mac::ue
4 years ago
Francisco
b004c2024d
integration of object pool in mac::ue for allocation of softbuffers. Definition of common object pool interface class
4 years ago
Francisco
460d7a8f4f
fix memory pool test - placed the pool state into a shared_ptr so that the callbacks still have a valid handle when the pool is destroyed
4 years ago
Francisco
ec3cd9ffea
adt - added background object pool test, and fix existing bugs related to the creation of pools with objects that are too small to be used in free lists
4 years ago
Francisco
d1c5b000dc
adt - creation of pre-initialized object pool, that leverages the background memory pool allocator
4 years ago
Francisco
eb9814837a
fix gtpu test valgrind warning
4 years ago
Francisco
a79ca92020
refactor type storage and pool tests
4 years ago
Francisco
046633674a
refactor - removal of stack-gtpu interface, and use of socket manager interface instead
4 years ago
Francisco
c24e382c19
Refactor of socket manager class
...
- use of inheritance to simplify testing
- removal of global network manager
- pass of custon socket manager to s1ap and gtpu ctors
- overhauled the registration of socket fd,callback in socket manager
4 years ago
Francisco
4aac7ac238
use global rx multisocket handler, and remove stack-s1ap interface
4 years ago
Francisco
39de2efa69
multisocket handler - use blocking socket remove method
4 years ago
Francisco
bf96d897ee
network utils refactor - renaming of socket handle to unique socket and cleanup of its methods
4 years ago
Francisco
aed5c51010
fix bug in cc_used_buffers_map in request_pdu(...)
4 years ago
Francisco
8fda69a3dd
refactor mac::ue cc_used_buffers_map class to use new circular_map container
4 years ago
Pedro Alvarez
696de22a28
Change default maximum number of KOs to 100
4 years ago
Pedro Alvarez
b2b7d8f617
Set rlf_timer timeout once. Make activity timer expiry also stops rlf_timer
4 years ago
Pedro Alvarez
e1a852d4b8
Split split RLF timer and Inactivity timer
4 years ago
Pedro Alvarez
47135cb75b
Changed counting of KOs to RRC
4 years ago
Pedro Alvarez
8194b5ec73
Added check for consequetive KOs in MAC. Change set_activity_user to pass activity and max KOs to RRC and trigger RLF timeout.
4 years ago
Francisco
ec72b310d7
fix mme ue s1ap id initialization
4 years ago
Francisco
23ae9967cf
replaced present+value for optional field in s1ap mme_ue_s1ap_id context field
4 years ago
Francisco
b8f220258d
s1ap - extend s1ap unit test to verify result of passing an invalid mme s1ap ue id
4 years ago
Francisco
c3482b45e1
s1ap - handle erroneous enb/mme s1ap ue id in received s1ap messages from the MME
4 years ago
Francisco
cc369aca1f
sched - handle the case when the CRC is missing and max retx is reached
4 years ago
faluco
67530687e9
Restore RRC release result variable after logging the event.
4 years ago
faluco
54fab314c0
Enhance RRC eNB events:
...
- Implement a common event "log_rrc" for all RRC events and discriminate by procedure using an enum.
- Log events for connection, reestablishment, reconfig, reject and release.
- Log the corresponding ASN1 message used by each procedure.
- Redefine the JSON object for this event to match the new structure.
Fixed a compilation error detected by the static analyzer in gcc9.3 where bounded_vector::data() was using taking the address of the internal buffer which confused it, prefer to use the data method of std::array.
4 years ago
Francisco
d4a223b5b1
s1ap unit test - add correct cause to erab modify response when erab-id is not recognized
4 years ago
Francisco
a68c50a282
s1ap - extend s1ap unit test to setup a full ue connection and modify bearer
4 years ago
Francisco
90bba3b85e
s1ap - set s1 handover cause as s1 intra system handover triggered
4 years ago
Pedro Alvarez
8c7aed1f81
Added handling of MSG3 timout exipiry in activity_timer_expired(). Avoid notifying S1AP in that case.
4 years ago
Pedro Alvarez
37699f2215
Send radio connection with UE lost if max retx are reached
4 years ago
Francisco
d571d26b0a
disable blocking queue in enb::mac when mac::stop() is called. Ignore PRACHs after stop() is called
4 years ago
Francisco
d04a19f8bc
refactor - increase code reuse in adt files
4 years ago
Francisco
5eccfad05b
gtpu - added comments, updated expected construct, handled in rrc the case a gtpu teid fails to allocate
4 years ago
Francisco
82b34f3b3f
gtpu refactor - fix gtpu logging formatting
4 years ago
Francisco
44440cf562
gtpu refactor - use of raii to automatic path switch and teid removal in forwarding. Clean up of gtpu_tunnel_manager methods.
4 years ago
Francisco
ab2bd9a2d2
gtpu refactor - handle dl path state activation internally in gtpu tunnel manager class
4 years ago
Francisco
cfd24f6a0e
gtpu - leverage byte_buffer_pool to store buffered sdus in gtpu
4 years ago
Francisco
bdc5094e17
gtpu - added unit test for gtpu_tunnel_manager class
4 years ago
Francisco
c201eb7708
use of more space efficient sorted vector structure for lcid tunnels of a rnti
4 years ago
Francisco
eba0edea4a
creation of static id obj pool class. Application of this class to gtpu tunnels container to avoid allocations
4 years ago
Francisco
3cf5e85b20
create separate class to handle gtpu tunnel creation/deletion/search
4 years ago
Francisco
099a533573
bugfix - verify that TEID exists before trying to access it
4 years ago
Francisco
e1523692c2
implementation of concurrent fixed size pool that leverages thread local caches to avoid mutexing
4 years ago
Pedro Alvarez
a5229a02d1
Make sure RRC identity is set when NAS reads UE context from file.
4 years ago
Pedro Alvarez
ca7a38a2ba
Remove old context in eNB's RRC if new connection request arrives with the same TMSI
4 years ago
Pedro Alvarez
8e48467a30
Make sure that meas_report_desc is present if ho_active == true in rr.conf
4 years ago
Francisco
1b47bee4c0
handover - avoid halting ho preparation just due to the presence of a handover restriction list or handover request extension field
4 years ago
Francisco
609366afce
change sched buffer state update log level to info for SRBs
4 years ago
AlaiaL
bbaebd1274
Added a warning in the log when the cpu metrics are not registered due
...
to the number cpu cores is greater than supported.
4 years ago
AlaiaL
c9d1c77e8c
- Deleted the magic number of maximum supported cores, now it is a
...
constexpr.
- When the system has more cores that the maximum supported, the cpu
metrics will not be registered.
4 years ago
AlaiaL
6cd9bba641
Added the cpu metrics to the system metrics.
4 years ago
Ismael Gomez
14bfd55fb9
Restore removed function from ue_db
4 years ago
Xavier Arteaga
5bdf2c93b3
Initial NR PDSCH CSI-RS RE skip and other changes
4 years ago
Pedro Alvarez
ea3c3b1d4f
Added some checks for the byte buffer allocation in the GTP-U
4 years ago
Xavier Arteaga
cade7c8104
Removed redundant error traces
4 years ago
Xavier Arteaga
c5bb522f11
SRSENB: Add PHY UE DB return codes
4 years ago
Andre Puschmann
1a0891df51
all: check return value of make_byte_buffer() and handle them safely
4 years ago
Francisco
dd336c53ea
changed srsran_warning to srsran_expect. Applied new macro to rlc am
4 years ago
Francisco
b5692037a2
created macros for assertions and warnings. The assert macro prints the whole callstack on crash. The warning macro can just log a warning or call an assertion fail depending on the cmake flag STOP_ON_WARNING
4 years ago
Francisco
7595dbaa02
avoid blocking call for pop from UE pool in mac ue. change log lines
4 years ago
Francisco
4869b14de3
application of new circular map to mac::ue_db
4 years ago
Codebot
4523ee6087
rename srsLTE to srsRAN
4 years ago
Francisco
df8ec4ddd5
reduce max coderate for SIB allocations
4 years ago
Francisco
638989ec4d
sched - limit max coderate (via an assumed low cqi) for sib and rar allocations
4 years ago
Ismael Gomez
430b7b7b34
Remove unnecessary info
4 years ago
Ismael Gomez
8d2197e751
Increase MAC UE circular buffer
4 years ago
Francisco
2054ad3f3c
eliminate old BFS-based PDCCH allocator. Improvement the scheduler speed by ~2x
4 years ago
Francisco
6bec92fbc9
using new DFS-based PDCCH allocator as a default
4 years ago
Francisco
8347cabe4f
implemented a DFS-based PDCCH allocator
4 years ago
Francisco
a2e2501424
avoid disabling SRBs in the eNB when the max retx reached signal is sent from the RLC to the RRC
4 years ago
Francisco
a540c56552
gtpu bugfix - avoid erasing indirect tunnel and causing iterator invalidation while iterating list of tunnels
4 years ago
Francisco
977c194cbc
gtpu,bugfix - handle the case when gtpu fails to allocate buffer for end marker. Also, added a timer that when expired, it autoremoves the GTPU handover tunnel
4 years ago
Pedro Alvarez
dde8157bf1
Make sure that S1 Setup request is restarted regardless of which error made the procedure fail.
4 years ago
Francisco
d646111aa9
refactor sched dci unit test
4 years ago
Francisco
d6bae76698
extend cch allocation unit tests to verify optimal cfi and DCI position selection for 6 PRBs
4 years ago