Francisco Paisana
2abe486e18
separate control loops for PUCCH and PUSCH TPC
4 years ago
Andre Puschmann
732a108982
mac: convert rar_pdu_msg[] from vector into array and protect access
...
attempt to address ASAN detected issue:
RACH: tti=821, cc=3, preamble=11, offset=0, temp_crnti=0x47
ASAN:DEADLYSIGNAL
=================================================================
m==25385==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000024 (pc 0x564b19a26c93 bp 0x7fa0e5f1a8c0 sp 0x7fa0e5f1a798 T8)
==25385==The signal is caused by a WRITE memory access.
==25385==Hint: address points to the zero page.
------DL--------------------------------UL------------------------------------
rnti cqi ri mcs brate ok nok (%) snr phr mcs brate ok nok (%) bsr
46 0.10 0 0.0 0 0 0 0% 0 0.0 0 0 0 0 0% 0.0
47 0.10 0 0.0 0 0 0 0% 0 0.0 0 0 0 0 0% 0.0
#0 0x564b19a26c92 in srslte::rar_subh::set_ta_cmd(unsigned int) /mnt/data/jenkins/workspace/srslte_ogt_manual_zmq/srsLTE/lib/src/mac/pdu.cc:1136
#1 0x564b19577f7e in srsenb::mac::assemble_rar(srsenb::sched_interface::dl_sched_rar_grant_t*, unsigned int, int, unsigned int, unsigned int) /mnt/data/jenkins/workspace/srslte_ogt_manual_zmq/srsLTE/srsenb/src/stack/mac/mac.cc:837
#2 0x564b19591765 in srsenb::mac::get_dl_sched(unsigned int, std::vector<srsenb::mac_interface_phy_lte::dl_sched_t, std::allocator<srsenb::mac_interface_phy_lte::dl_sched_t> >&) /mnt/data/jenkins/workspace/srslte_ogt_manual_zmq/srsLTE/srsenb/src/stack/mac/mac.cc:653
#3 0x564b19497ee2 in srsenb::lte::sf_worker::work_imp() /mnt/data/jenkins/workspace/srslte_ogt_manual_zmq/srsLTE/srsenb/src/phy/lte/sf_worker.cc:208
#4 0x564b199f8db4 in
4 years ago
Francisco Paisana
9de318c7e6
avoid allocating DL harqs when respective acks are still pending, when there is a reordering of ttis in the phy
4 years ago
Francisco Paisana
099dad8cb1
disable PHR handling in the UL sched by default
4 years ago
Ismael Gomez
f9a02299f9
Use MAC PDU pointer instead of tti_rx and rnti as a key to associate buffers. Decouple crc_info() and push_pdu() functions. This allows for different timing architectures in the PHY
4 years ago
faluco
343587b32d
Update NR classes after metrics interface changes.
4 years ago
faluco
f20b75a05f
Re-structure enb metrics a bit. Create a generic mac metric struct and per ue mac metrics struct.
4 years ago
faluco
5529943172
Add a per sector rach preable counter for the metrics.
4 years ago
faluco
dcd1157d39
- Prototype the extension of enb metrics.
4 years ago
Francisco
cba0cc457f
sched rand test refactor: creation of abstract sched simulator class for testing
4 years ago
Francisco
b4861bc59a
move sched params and sched helper methods to sched_helpers.h/cc files. Removed place in the scheduler where the mcs is increased forcefully to avoid segmentation
4 years ago
Francisco
99f94d9a1a
Bug fixes of srseNB scheduler TPC
...
- fix encoding of TPC command
- use of exponential average with irregular sampling for the ULSNR average estimate.
Turns out using a time-windowed average for the SNR was a bad idea.
If the UL grants are very sporadic, the SNR time window will never have samples
when a TPC is encoded
- update of TPC sched test
- other fixes in accumulators lib
4 years ago
Francisco
22229adf08
fix: normal phr is only sent for PCell
4 years ago
Francisco
69748e9313
fix compilation issue regarding definition of size_t in header and declaration of static member null_value in sliding average class
4 years ago
Francisco
d42dc50c44
Write TPC sched unit test and fix sched logical channel test
4 years ago
Francisco
479602ed1d
add option to specify target ul sinr for UL power control to the enb rr.conf parser
4 years ago
Francisco
5865df39d1
created class that implements the scheduler transmit power control and PHR handling
4 years ago
Francisco
86ab1864f7
The struct tti_point is now used ubiquitously in the scheduler
4 years ago
Francisco
8fb3ea6922
Added the ability to choose scheduling policy from enb.conf
...
- The two options provided at the moment are time-domain RR and PF
4 years ago
Francisco
b71e8075f4
Refactoring of scheduling algorithms
...
- Use single interface for both DL and UL
- Wrote helper functions for tasks that are common to different algorithms
- created subfolder for all scheduling algorithms
4 years ago
Francisco
d7fae0b7a3
Implementation of time-domain PF scheduler
...
- PF scheduling becomes the new default
4 years ago
Andre Puschmann
07d2bc4fe8
change license header to agnostic version with hint to root LICENSE file
4 years ago
Francisco
f07e52129c
increase mcs ul upper bound to 24 when ue is cat4 and enb supports 64qam. Simplified max_mcs computation
4 years ago
Francisco
3d80ff4831
fix activation of PDCCH for adaptive retxs.
4 years ago
Francisco
fc81a5c6ba
harq ack state can now only be NACK or ACK. The ul_harq pending phich flag is now reset after phich scheduling. Thus, the existence of a crc_info(...) signal from the PHY is not required.
4 years ago
Francisco
3067e81e67
fix check of pending UL bytes
4 years ago
Francisco
bb96625129
renaming lch_manager -> lch_ue_manager
4 years ago
Francisco
a348508072
simplified sched_ue pending DL bytes calculation API
4 years ago
Francisco
0ffea62411
Wrote logging functions for SCHED MAC CE/LCID allocations
4 years ago
Francisco
c1fb161004
Move sched lch_manager to separate file
4 years ago
Francisco
eae0dc93ad
rename scheduler files. scheduler -> sched
4 years ago
Francisco
68eda336bd
remove ENB_METRICS_MAX_USERS compile time macro and use run-time variable to set maximum number of UEs the srseNB can have connected at a given instant.
4 years ago
yagoda
bdc1964335
consolidating RRC eMBMS configuration into single function, setting some parameters to const
4 years ago
yagoda
b90574975b
refactoring asn1 eMBMS code, removing asn1 from PHY and MAC in eNodeB
4 years ago
Francisco Paisana
49a48c0130
add measgap awareness to scheduler metric and sf_sched. Add measGap test to random sched test suite.
4 years ago
Francisco Paisana
9579931f16
added meas gap checks to scheduler ue
4 years ago
Francisco Paisana
bf7c587e4f
add UL 64QAM support to eNB RRC and scheduler
4 years ago
Francisco Paisana
d5f6ccc0c4
integrated UL UE-dedicated sched tests in random test
4 years ago
Francisco Paisana
88105c1577
change the namespace of tti point helper functions for the eNB
4 years ago
Francisco Paisana
3ea47b645a
changed the way the number of UL pending bytes is calculated in the scheduler
4 years ago
Francisco Paisana
d8203acd56
implement harq resuming functionality
4 years ago
Francisco Paisana
f927ccaf55
fix pusch grant allocation for cqi reporting in CA.
4 years ago
Francisco Paisana
a351b2534e
allow PUSCH grants for CQI in PCell
4 years ago
Francisco Paisana
a865858db3
disable srbs UL during handover to avoid UL grants and scheduling requests before the handover is complete
4 years ago
Francisco Paisana
42cdc5e340
Allocate all the leftover bytes of the TBS to last allocated MAC SDU.
...
Fix the way the RLC header is accounted for depending on the bearer id.
For instance, the SRB0 does not require any RLC header.
4 years ago
Francisco Paisana
55d62a2baa
fix rlc buffer updating inside the scheduler to account for RLC headers
4 years ago
Francisco Paisana
44a9ad76f1
avoid sched_ue dangling pointer
...
With the sched feature that allows scheduling in TTIs
ahead of time, there is no guarantee that when
the tti arrives to generate a sched result, the stored
raw sched_ue pointers are still valid. For this reason,
I now store the rnti and check if the rnti still exists.
4 years ago
Francisco Paisana
852c31c0bc
log warnings when the sched ue cfg is not valid
4 years ago
Francisco Paisana
c5c7700cb7
implemented DL logical channel prioritization test for finite PBRs
4 years ago
Francisco Paisana
9b10acff06
implemented logical channel prioritization in DL scheduler
4 years ago
Francisco Paisana
a761762ec8
extended cc_sched_ue fsm to account for more harmonious transition of an scell to deactivated state
4 years ago
Francisco Paisana
eafc003671
Altered the way the generation of the scheduling decision for a given
...
TTI is made. Instead of generating one CC in each dl_sched()/ul_sched()
call, all CC decisions are generated at once. This avoids race
conditions with calls from the RRC to the MAC to configure UEs.
4 years ago
Francisco Paisana
688dda30a4
favour carriers with best channel conditions for UL grants due to SRs
4 years ago
Francisco Paisana
7e6487b6fa
perform PUCCH+PRACH PRB reservation right at the start of a new TTI in the scheduler
4 years ago
Ismael Gomez
38e2ffe414
Use Format1A when using CA and 15 PRB due to DCI size ambiguity
4 years ago
Ismael Gomez
a4835dd2c8
More accurate MCS reduction when PUSCH carries UCI ( #1630 )
4 years ago
Francisco Paisana
20b69fb22e
substitution of ul_alloc_t for prb_interval
4 years ago
Francisco Paisana
26f46ea067
add S1 Handover Request handling in target eNB
4 years ago
Francisco Paisana
caf862c99f
moved expected, bounded_bitset, move_callback to adt folder. created a test for bitset
4 years ago
Francisco Paisana
35fa5346b9
only reduce mcs if the current tti requires uci
4 years ago
Francisco Paisana
58c4bcf288
reduce mcs for UL grants carrying UCI
4 years ago
Francisco Paisana
5e06430455
removal of stack handler interface
5 years ago
Francisco Paisana
039977aeb5
renamed interfaces
5 years ago
Francisco Paisana
7ab4b5f723
fix long bsr handling
5 years ago
Francisco Paisana
af58597647
fix mac tb building in scheduler
5 years ago
Francisco Paisana
cb7f620254
created separate class to manage bearers buffers/status reports in the scheduler
5 years ago
Francisco Paisana
2cb80f9bf3
remove rnti in mac/phy in staged manner. First the "upper mac", and then the "lower mac" and phy
5 years ago
Ismael Gomez
493b7ea2da
Remove SNR threshold based link failure detection
5 years ago
Francisco Paisana
64e8f5e3ed
update license year
5 years ago
Andre Puschmann
a1d64c1efe
enb: improve error message when RAR cannot be sent
5 years ago
Francisco Paisana
3c2e3dbdbf
added latest mac nr updates
5 years ago
Francisco Paisana
d859c33035
added check for UCI collision during DL scheduling for CA
5 years ago
Francisco Paisana
53b85691b5
moved sf result to sched class. This way each carrier has a view to the results of the remaining carriers in the same subframe
5 years ago
Francisco Paisana
5d33acdb53
changed name of sched_ue_carrier class
5 years ago
Francisco Paisana
92c4b3f226
fix non-final sdap/mac/rlc dtor error
5 years ago
Francisco Paisana
9a0ea6e08c
use log_helper for log macros
5 years ago
Francisco Paisana
edba7f57e4
corrected mac_nr_pdu includes
5 years ago
Francisco Paisana
d7b35ba7d1
added nr mac
5 years ago
Andre Puschmann
a0e4b18507
enb_mac: pre-allocate UE object for quicker PRACH/RAR handling
...
we've seen long delays in handling PRACH on low-power devices
such as the RPi4. This was mainly caused by long delays
in creating the UE object on the fly during PRACH handling.
This patch pre-allocates one UE object that is then used
during the PRACH.
5 years ago
faluco
7ff251f112
- Fixed warnings caught by Clang 9.0.0
5 years ago
Francisco Paisana
500a7f6357
created new separate ue class in sched tester to handle acks and harq tests
5 years ago
Francisco Paisana
b8e6ba02e4
remove warnings related to unused vars and fwd declarations with trivial dtors
5 years ago
Francisco Paisana
df06443470
use c++ variadic template instead of variadic function
5 years ago
Francisco Paisana
367a190829
created dl-sch lcid type
5 years ago
Francisco Paisana
0526ae8ab1
updated rrc mobility parsing. added some utility methods
5 years ago
Francisco Paisana
20f6655c6b
use common method to build mac pdu. allow CE allocations in dci format2/2a
5 years ago
Francisco Paisana
64557740fc
use mac_buffer_state interface to schedule CEs in scheduler
5 years ago
Francisco Paisana
ec94819f08
changed mechanism for conres ce scheduling to be controlled by rrc
5 years ago
Francisco Paisana
d716d8bf7e
use mini state machine for ConRes CE scheduling instead of relying that there is data in the DL buffer
5 years ago
Francisco Paisana
d183d64409
added allocate_rnti method to mac. Useful both during PRACH and handover UE resource allocation
5 years ago
Francisco Paisana
6ddedd5972
moved pdu to common mac folder
5 years ago
Xavier Arteaga
5b7493cab5
Added 256QAM modulation tables to scheduler
5 years ago
Xavier Arteaga
8b265883e4
SRSENB: UL TA measurement waits for a start order before start measuring
5 years ago
Francisco Paisana
c661025cda
fix log tti, and print a warning when the ul_harq tti does not match existing ones
5 years ago
Ismael Gomez
7a7385d0e5
Support multiple carriers for common buffers (RAR/BCCH/PCCH)
5 years ago
Francisco Paisana
a2866f661b
made the number of ue payload allocations proportional to number of active carriers. Made mac::ue_db use unique_ptrs
5 years ago
Francisco Paisana
8772d8f85c
use byte buffer pool for the ue tx_payload_buffer allocation. This halves the mac::ue object creation time
5 years ago
Francisco Paisana
82cb6baef0
now the whole ue and enb mac uses the logmap
5 years ago
Francisco Paisana
807d177b47
fix hanging issue, and simplified the handling of minRBG for different CFIs
5 years ago
Francisco Paisana
ede09cb9b2
added dynamic CFI capability to the eNB scheduler
5 years ago
Xavier Arteaga
ada8772f57
Initial srenb TA compensation
5 years ago
Ismael Gomez
cf4f4508ce
Normalize throughput in CSV/stdout metrics with respect to number of TTIs
5 years ago
Ismael Gomez
858165f177
Allocate a different PDU buffer for each carrier in MAC eNodeB ( #1069 )
5 years ago
Xavier Arteaga
e832769ae6
Updated copyright
5 years ago
Francisco Paisana
5330249625
created tti_point type and unit test. Added also the tti_point to the scheduler harqs, and rrc procedure
5 years ago
Francisco Paisana
4217dba7e0
fix msg3 delayed allocation and update test
5 years ago
Francisco Paisana
d18b476e37
use utility macro for printing function name
5 years ago
Francisco Paisana
9b4a0baa87
activate scells in the phy
5 years ago
Francisco Paisana
7548402632
change scell activation interface to use arrays. Added a method to the scheduler to get the current set of activated carriers
5 years ago
Xavier Arteaga
76408b195e
Rename TX_DELAY and FDD_HARQ_DELAY_MS
5 years ago
Andre Puschmann
a8acd235f6
extend eNB MAC to support multiple CC per UE
...
- add tx/rx softbuffers for each CC that a UE might have
- make sure to call assign correct buffers when iterating
over the CC for UL/DL grant assignment
5 years ago
Francisco Paisana
a744729007
use range of rbgs
5 years ago
Francisco Paisana
46579da1ff
use signed integer to express the error
5 years ago
Francisco Paisana
bcbb08ebae
use initial_dl_cqi for first DL tx.
5 years ago
Francisco Paisana
3b937348a2
refactored some sched util methods
5 years ago
Francisco Paisana
fad897cb35
DL scheduler metric now takes into account the min and max of RBGs possible. This is to forbid segmentation of SRB0 allocations
5 years ago
Francisco Paisana
6317750de2
fix computation of ranged of allowed sched dl bytes
5 years ago
Francisco Paisana
414259e83b
fix allocation expected alloc bytes (min and max)
5 years ago
Francisco Paisana
e62972d38e
fix fdd delays in scheduler
5 years ago
Andre Puschmann
2edecea33e
fix SIB transmission for CA
...
Avoid double buffering of SIBs in MAC as this would require one buffer for each CC.
Instead, use byte_buffer managed by RRC that contains packed SIBs to avoid
double memcpy for each SIB tx. Only use MAC provided buffer in error case.
Also avoid MAC calling RLC for each SIB and call RRC directly.
5 years ago
Andre Puschmann
120ad76c63
refactor cell param handling and fix SIB transmissions
...
- move cell specific eNB params to cell list in rr.conf
- make sure DL EARFCN and DL freq can be used to manually overwrite a single cell config
- fix SIB packing and transmission for multi cell configs
- introduce cell list to MAC
- adapt default enb.conf.example and rr.conf.example
5 years ago
Xavier Arteaga
da701cd82b
SRSENB: Added PUSCH TA and EVM measurement. Some more PHY cleanup.
5 years ago
Francisco Paisana
ec1f1cc677
remove const_casts from scheduler. Fix ODR issue
5 years ago
Francisco Paisana
e9a599857a
created a header for all common structs and helper functions
5 years ago
Francisco Paisana
02ccb8b32b
fix wrong calculation of sched tx and rx delays
5 years ago
Andre Puschmann
664170fec6
pcap: add CC index when writing PCAP
5 years ago
Francisco Paisana
43e67b8536
created a harq entity that handles all harq procs. This entity accepts as arg the number of harq procs.
5 years ago
Francisco Paisana
1c041b2c1d
created harq entity class
5 years ago
Francisco Paisana
7e840bde86
fix tb idx assignment in scheduler mac sdu alloc
5 years ago
Francisco Paisana
d1356568e0
separated sf sched result from sf_sched class. The interface became way simpler. No need for finish_tti() method, sf_sched::new_tti() is called automatically when we access the sf_sched.
5 years ago
Francisco Paisana
bb38fa7119
fixed tti resetting after tti end
5 years ago
Francisco Paisana
47b05118ad
simplified msg3 allocation. Now we can allocate resources ahead of time (e.g. msg3 is 2 ttis ahead) using the sf_sched interface. It's guaranteed that the given allocations wont be erased when the respective tti starts
5 years ago
Francisco Paisana
8f7890c60a
store mask results in separate variables for testing, and reset sf_sched state at the end of the tti
5 years ago
Francisco Paisana
b37d9b9930
fixed msg4 setting in sched tester
5 years ago
Francisco Paisana
3cc94c3694
simplified mutexing of the scheduler. One single mutex for everything, and removed rwlock
5 years ago
Francisco Paisana
fed06138b9
moved rach_detected to stack thread. Created a more friendly interface to enqueue tasks in stack
5 years ago
Francisco Paisana
ad9e126299
test for different enb_cc_idxs as pcell. Bug fixes
5 years ago
Francisco Paisana
0f3ef11f8b
now the scheduler only activates a scell after receiving a valid CQI for the SCell
5 years ago
Xavier Arteaga
b45223c880
Fix minor MAC Clang warnings
5 years ago
Francisco Paisana
e859d622c7
added logref class to forbid logmap pointer invalidation. Created a test for the logref, and introduced it in the scheduler, rrc and nas
5 years ago
Francisco Paisana
d831522692
addition of SCell Activation CE Cmd to scheduler and MAC
5 years ago
Francisco Paisana
838053e8f2
added SCell Activation CE to scheduler. Handling this CE in the MAC is still missing
5 years ago
Xavier Arteaga
385102fa2d
SRSENB: minor format, renaming and interface changes
5 years ago
Xavier Arteaga
231431f569
SRSENB: enabled CA PUCCH decode in eNb
5 years ago
Xavier Arteaga
35f4e5d69a
Initial PUCCH 1B with channel selection
5 years ago
Francisco Paisana
c9ac42f11d
renamed rlc pdu / mac sdu allocate functions, and added some comments describing what these functions do
5 years ago
Francisco Paisana
87038375d5
fixed the building of MAC SDUs in the scheduler. Now, we ensure there is always space for the MAC subheader and RLC header. The MAC subheader is correctly discounted from the remaining bytes in a TB.
5 years ago
Francisco Paisana
c8fc0d91b3
changed the supported cc list to a vector of structs
5 years ago
Francisco Paisana
42b15c7bed
use common ue_cfg interface to set the ue antenna info
5 years ago
Francisco Paisana
5f557700f2
changed the sched::ue_cfg(...) function to allow diff configurations. The RRC now activates all carriers after rrc reconf complete
5 years ago