567 Commits (6773f6d02f9d2f859f0d0c7021f7591ae0387e25)

Author SHA1 Message Date
Francisco Paisana 12c147d75a The scheduler now accounts for the possible presence of BSRs in the size of UL grants 4 years ago
Francisco Paisana c46402c836 fix phy configuration during handover on srsenb. The function srsenb::rrc::ue::fill_scell_to_addmod_list assumes that the phy_cfg of the PCell is up-to-date, which was not the case. With this PR, the srsenb rrc updates the phy_cfg before the ho cmd is sent, but, in the case of intra-enb ho, the updates are not submitted to the phy before the reception of the crnti mac ce 4 years ago
Francisco Paisana 0f51d70aac fix measObj addition in srsenb. Now the enb considers both scells and meas_cells in the rr.conf 4 years ago
Francisco Paisana ae32ab9b13 addressed xavie's comments regarding list of scells to add to rrc reconf message not being in order when we iterate it 4 years ago
Francisco Paisana d42cdca729 fix scell activation in the phy during intra-enb handover. 4 years ago
Andre Puschmann 9866dcc10b enb: disable qam256 configuration
disable qam256 altogether until underlying PHY/MAC support
is implemented
4 years ago
Francisco Paisana 49186e2b1f Fix NCC set in HO command message for intra-enb handover 4 years ago
Francisco Paisana 2e10c8e13d bug fix - eNB was not allocating UL grants for an UE that has performed intra-enb handover. The problem resulted from the fact that the ue configuration in the scheduler not accounting for removed cells. 4 years ago
Francisco Paisana 8a5a571045 bug fix - in case of intra-enb Handover, the eNB was not adding SCells in the HO command 4 years ago
Francisco Paisana 4383796393 add scells in case of intra-enb handover 4 years ago
Francisco Paisana 688dda30a4 favour carriers with best channel conditions for UL grants due to SRs 4 years ago
Pedro Alvarez 2f0125ef4e Fix issue recovering key state, when the first HO fails (specifically, is_first_ncc was not recovered). Minor improvements in key logging. 4 years ago
Francisco Paisana 137e554eb3 reestablish pdcp bearers is required in case of AM bearers 4 years ago
Francisco Paisana 4c88404801 fix measurement report handling in case of intra enb handover 4 years ago
Francisco Paisana 4b1626bf24 fix eutra packing recovering during reestablishment in the srsenb 4 years ago
faluco dfeed52514 - Rename out_stream function to console. 4 years ago
faluco 62faef7c71 - Replaced all uses of the log::console method. 4 years ago
Francisco Paisana 942c28881d converted member method of list of cells in the enb to a free function 4 years ago
Francisco Paisana 3a924a1d80 avoid sending cellsToAddModList if cell offsets are zero 4 years ago
Francisco Paisana da70c0fdaf fix cellsToAddModList handling. Now the eNB always adds PCell+SCells as measObjects in the RRC Reconfiguration messages. It may also further include cellsToAddModList if they are provided in the rr.conf file 4 years ago
Francisco Paisana 89eeb5a355 use utility methods to find meas objs based on earfcn 4 years ago
Francisco Paisana 141960fbda remove unnecessary shared_ptrs and use value semantics instead for the var_meas_cfg of the different enb cells 4 years ago
Francisco Paisana 098172c911 fix cellIndex assignment in srsENB to not necessarily copy cell ID 4 years ago
Francisco Paisana dcf5a727f2 do not send RRC release in case the eNB receives a S1AP UEContextRelease command and the UE is doing handover. Handle GTPU end marker 4 years ago
Francisco Paisana 13a5bfb525 - fix reestablishment reject transmission in the srsenb. For SRB0 SDUs, no RLC header is required, so we do not need to check in such case if there is enough space in the TB for the header.
- fix srsenb reestablishment check for UE context. The pci has to be accounted for the srsenb to understand that the UE trying to do reestablishment corresponds to one of its own
4 years ago
Xavier Arteaga 3e6c337b44 SRSENB: protect MAC softbuffers access
SRSENB: fix retransmissions
4 years ago
Andre Puschmann 49655cd33c enb,s1ap: only log info in the s1ap connection procedure
the event is logged as error by the calling function already
4 years ago
Francisco Paisana 7e6487b6fa perform PUCCH+PRACH PRB reservation right at the start of a new TTI in the scheduler 4 years ago
Andre Puschmann d30822784f enb: refactor MAC PDU logging
* remove single line MAC PDU subheader logging in favor
  of to_string() helper that prints entire MAC header in single line
* log MAC PDU after parsing and packing
4 years ago
Ismael Gomez 59b6301cc8 Remove legacy arbritrary 1s timeout for eNB requests 4 years ago
Pedro Alvarez b59eca1b27 Wait until reestablish complete is finished to swap rnti in s1ap and gtpu. 4 years ago
Pedro Alvarez 6ec26ea627 Make sure that last_submitted_rx_sn is not 0 after handover. 4 years ago
Andre Puschmann 655c7ae8ae enb: fix warning when removing user
when removing a user from the eNB we iterated over all possible LCIDs
and set the buffer state to zero in the scheduler.

this resulted in following log entries:

13:57:23.856334 [RRC ] [I] Received Release Complete rnti=0x46
13:57:23.856352 [MAC ] [W] [ 5149] The provided lcid=6 is not valid
13:57:23.856362 [MAC ] [W] [ 5149] The provided lcid=7 is not valid
13:57:23.856368 [MAC ] [W] [ 5149] The provided lcid=8 is not valid
13:57:23.856371 [MAC ] [W] [ 5149] The provided lcid=9 is not valid
13:57:23.856376 [MAC ] [W] [ 5149] The provided lcid=10 is not valid

we now check if the bearer exits at RLC and only report those to the MAC.
4 years ago
Ismael Gomez 38e2ffe414 Use Format1A when using CA and 15 PRB due to DCI size ambiguity 4 years ago
Xavier Arteaga f14e699df4 SRSENB: fix MAC UE DB Read protection 4 years ago
Ismael Gomez 0afcea9d61
Do not allow empty TBS PUSCH. Account for CQI from inactive cells before activated. (#1667) 4 years ago
Francisco Paisana fddcc3d8ea In the case of Handover, postpone the activation of the CQI and SR config present in the HO command for after the RA proc completion to the target eNB 4 years ago
Francisco Paisana 8a651c972e add scells to ho cmd 4 years ago
Francisco Paisana 13caf287f9 fix S1 Handover with UE CA. The HandoverPreparation message was not being filled correctly 4 years ago
Ismael Gomez a4835dd2c8
More accurate MCS reduction when PUSCH carries UCI (#1630) 4 years ago
Francisco Paisana cc469fc7a3 fix reestablishment after S1 handover by setting ncc accordingly 4 years ago
Francisco Paisana b47f8e6c1a increased rrc inactivity timer to avoid unnecessary pagings while
setting up an initial enb-ue iperf connection
4 years ago
Matt Johnson e9eab89a6b srsenb/rrc: Avoid crash when CSFB requested but sib7 not configured
This commit addresses an issue where if a UE requests a release for
circuit switched fallback, but the sib7 carrier freqs info list is not
configured, the eNodeB would crash with a segfault due to attempting
to access an element from an empty list. This commit adds explicit
checking to handle the empty list case. If the list is empty, no
redirect carrier info is added to the connection release message and
the UE must scan for the fallback network itself.
4 years ago
Francisco Paisana 0036941af4 added extra state to S1 target enb mobility FSM. Accounts for out-of-order arrival of MMEStatusTransfer. Also, now we avoid creating DRBs before the MMEStatusTransfer 4 years ago
Andre Puschmann 5e40bfe72c mac_pdu: unpack and print BSR index as well as BSR value in bytes
before the BSR was extracted but the actual index (between 0 and 63)
was not stored but directly converted into bytes.

for log parsing and debugging it is easier to follow the index
value. this patch therefore adds both values to the log message
and extends the API accordingly.
4 years ago
Francisco Paisana bb5dd92dca implemented s1 handover cancellation procedure to force the target enb to release the ue ctxt 4 years ago
Francisco Paisana 8c9e596f89 refactored s1ap handover request interface. cleaned up rrc tenb s1 handover code 4 years ago
Francisco Paisana b6baf1a098 fix mobility warnings and s1 handover required message preparation 4 years ago
Andre Puschmann 8e631131c0 s1ap: fix uint64_t printf for 32bit machines 4 years ago
Francisco Paisana 7cd4f45d62 fsm refactor.
- avoid triggering directly a subfsm
- improved metafunctions
- other cleanups
4 years ago
Francisco Paisana 42e8453c00 fix security key setup for s1 handover 4 years ago
Francisco Paisana 083344579e fix s1 ho configuration of ue capabilities and security capabilities 4 years ago
Francisco Paisana 5d1343fe75 implemented S1 bearer status transfer 4 years ago
Francisco Paisana db8af399f8 extended rrc tenb s1 handover test. implemented layer reconfig during s1 handover 4 years ago
Francisco Paisana 7605c7df23 added s1ap handover notification, fixed s1ap asn1 bug, and fixed bad fields for admitted erabs in ho req ack 4 years ago
Francisco Paisana 9146e6ddf1 change method name to resize intervals 4 years ago
Francisco Paisana 4457bbda7e added new asserts to interval interface 4 years ago
Francisco Paisana 8b174ce2f4 changed interval interface to disallow interval::stop < interval::start via an assertion 4 years ago
Francisco Paisana c1755727d7 changed interval method names, and added comments and assertions 4 years ago
Francisco Paisana 20b69fb22e substitution of ul_alloc_t for prb_interval 4 years ago
Francisco Paisana 3eb1b83a43 updated allocate crnti method in mac to accoutn for new phy interface 4 years ago
Francisco Paisana 26f46ea067 add S1 Handover Request handling in target eNB 4 years ago
Ismael Gomez 382811e10e
Update S1AP RNTI context when doing Reestablishment (#1582) 4 years ago
Francisco Paisana a6c3144d92 remove extra byte from rrc dl_dcch and dl_ccch messages 4 years ago
Xavier Arteaga a1a58507c1 SRSENB: Added eNb CC index to PRACH log trace 5 years ago
Ismael Gomez dda91b14f7 Remove duplicate add_rnti() function since already done in set_config 5 years ago
Francisco Paisana b50f70e420 check if cqi is pending in all carriers to decide whether mcs needs to be reduced in PUSCH 5 years ago
Francisco Paisana 3f439cc947 account for current cqi config struct update in scheduler interface 5 years ago
Francisco Paisana 35fa5346b9 only reduce mcs if the current tti requires uci 5 years ago
Francisco Paisana 58c4bcf288 reduce mcs for UL grants carrying UCI 5 years ago
Xavier Arteaga 0192130742 SRSUE/SRSENB: UCI bits are carrier by the lowest serving cell index
SRSENB: Fix UCI in lowest serving cell index PUSCH transmission
5 years ago
Andre Puschmann a7911f0dab pdcp,rlc: refactor SDU queueing policy
this patch refactors the SDU queuing and dropping policy of the RLC and PDCP layer.
the previous design had issues when packets have been generated at a higher
rate above the PDCP than they could be consumed below the RLC.

When the RLC SDU queues were full, we allowed two policies, one to block on the write
and the other to drop the SDU. Both options are not ideal because they either
lead to a blocking stack thread or to lost PDCP PDUs.

To avoid this, this patch makes the following changes:

* PDCP monitors RLC's SDU queue and drops packets on its north-bound SAP if queues are full
  * a new method sdu_queue_is_full() has been added to the RLC interface for PDCP
* remove blocking write from pdcp and rlc write_sdu() interface
  * all writes into queues need to be non-blocking
  * if Tx queues are overflowing, SDUs are dropped above PDCP, not RLC
* log warning if RLC still needs to drop SDUs
  * this case should be avoided with the monitoring mechanism
5 years ago
Xavier Arteaga f39abe0094 SRSENB: fix MAC pending PHY config 5 years ago
Francisco Paisana 5e06430455 removal of stack handler interface 5 years ago
Francisco Paisana 7c364070ee creation of task scheduler interface for classes/functions running outside the main control thread 5 years ago
Francisco Paisana 039977aeb5 renamed interfaces 5 years ago
Francisco Paisana 1a9c04bf2f use of task scheduler handle in pdcp 5 years ago
Francisco Paisana e9f34c7613 using task scheduler in enb stack 5 years ago
Francisco Paisana 4f5e65781f created task scheduler class to deal with timers, thread pool, multiqueue, internal tasks 5 years ago
Pedro Alvarez 89b6e0f714 Send paging message to all cells. 5 years ago
Francisco Paisana fe8f8be62d apply separate cqi configurations to scells 5 years ago
Francisco Paisana e550bf726d updated fsm to allow enter methods to receive event that caused them 5 years ago
Francisco Paisana 504e3a1b7a fix max retx configuration in scheduler and updated tester to catch the error 5 years ago
Andre Puschmann 4c667bd478 rrc_ue: improve logging of CA activation
* check Pcell has configured Scells when entering function
* log if UE doesn't support CA (only if scells are configured)
* log info about CA activation only after all checks have passed
* fix typo
5 years ago
Pedro Alvarez 5ed6c18ac7 Copy E-UTRA capabilities to new RNTI in reestablishment. 5 years ago
Francisco Paisana d7a0fe4060 improve log messages for CA 5 years ago
Francisco Paisana 1899c468d3 updated rrc mobility test 5 years ago
Francisco Paisana 97d20ca579 remove obsolete bearer cfg methods 5 years ago
Francisco Paisana 0929a9de62 created rrc mac_controller class to handle the configuration of scheduler 5 years ago
Francisco Paisana 7ab4b5f723 fix long bsr handling 5 years ago
Francisco Paisana af58597647 fix mac tb building in scheduler 5 years ago
Francisco Paisana cb7f620254 created separate class to manage bearers buffers/status reports in the scheduler 5 years ago
Pedro Alvarez 45b8392a4c Added user warning to invalid configuration of RRC inactivity timer. 5 years ago
Pedro Alvarez 8e00febb1d srsENB: Derive inactivity timeout from T310 and T311 and N310. 5 years ago
Francisco Paisana 2cb80f9bf3 remove rnti in mac/phy in staged manner. First the "upper mac", and then the "lower mac" and phy 5 years ago
Ismael Gomez 493b7ea2da Remove SNR threshold based link failure detection 5 years ago
Francisco Paisana ced1afdbe7 check supported band combination r10 to determine if a UE supports CA 5 years ago
Francisco Paisana 790b32f6f5 fix CA ue category check 5 years ago
Francisco Paisana 2de702f50e disable carrier aggregation when ue release is below 10 or category is below 5 5 years ago
Xavier Arteaga 31d7124ae7 SRSENB: Added initial PUCCH format 3 default for more than 2 serving cells 5 years ago