5g-team
/
srsRAN_4G
mirror of https://github.com/pvnis/srsRAN_4G.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
10,066 Commits
2 Branches
0 Tags
243 MiB
fix-cqi
master
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '65dbac0bd3'
${ noResults }
Commit Graph

929 Commits (65dbac0bd3557b3a9c81090659ef30d394173b5e)

Author SHA1 Message Date
Francisco de05e1e549 sched,nr: fix invalid memory write 4 years ago
Francisco 75153c7c83 sched,nr: implementation of sched sim test class 4 years ago
Francisco f1b3cfc764 sched,nr: implementation of sched NR harq retxs. Refactor of rb grid classes. 4 years ago
Francisco d950433cbd sched,nr: fix time-domain parallelization sched nr test. creation of util class to handle acquisition of boolean resources 4 years ago
Francisco 35a236b1b9 sched,nr: fix sched_nr_test. Resolve data race issues. Created new config structs used across the scheduler. 4 years ago
Francisco 407da794e1 sched,nr: implementation of slot grid class 4 years ago
Francisco 4fa27f3841 sched,nr: implementation of main classes for NR scheduler, and basic test for concurrency 4 years ago
Andre Puschmann 483a216bd5 ue,stack: refactor handling of radio bearears in UE stack 
this is a rather large commit that is hard to split because
it touches quite a few components.

It's a preparation patch for adding NR split bearers in the next
step.

We realized that managing RLC and PDCP bearers for both NR and LTE
in the same entity doesn't work. This is because we use the LCID
as a key for all accesses. With NR dual connectivity however we
can have the same LCID active at the same time for both LTE and NR
carriers.

The patch solves that by creating a dedicated NR instance for RLC/PDCP
in the stack. But then the question arises for UL traffic on, e.g. LCID 4
what PDCP instance the GW should use for pushing SDUs. It doesnt' know
that. And in fact it doesn't need to. It just needs to know EPS
bearer IDs. So the next change was to remove the knowledge of what
LCIDs are from the GW. Make is agnostic and only work on EPS bearer IDs.

The handling and mapping between EPS bearer IDs and LCIDs for LTE
or NR (mainly PDCP for pushing data) is done in the Stack because
it has access to both.

The NAS also has a EPS bearer map but only knows about default and
dedicated bearers. It doesn't know on which logical channels they
are transmitted.
 4 years ago
David Rupprecht ec19919246 Fix NGAP valgrind test 4 years ago
Francisco 78acf81cf0 bugfix,sched: avoid instability in TPCs around PHR~0 4 years ago
Ismael Gomez 02ec4dd3d0 Remove unused variable 4 years ago
Ismael Gomez dd9889e07c Add carrier index to uplink PCAP captures 4 years ago
Bedran Karakoc c280ac5ad6 Introducing extended NGAP functionality 
Remove unused logger for now in ngap::ue to pass tests
 4 years ago
Francisco 5a82a63bb5 bugfix,srsenb: fix intraenb handover softbuffer allocation during handover 4 years ago
Francisco d5234b5f65 sched,bugfix: avoid using UL SNR average in tpc control loop 4 years ago
Francisco f55e1c5a73 fix,srsenb: start stack before the radio to avoid stack methods to be called when stack is not fully initialized 4 years ago
Francisco e8983b88f0 refactor: use enb_cc_idx instead of ue_cc_idx in mac::ue 4 years ago
Pedro Alvarez 299d2ee35d Added interface to make the PDCP notify the RRC of integrity check 
failures.
 4 years ago
Francisco fd3901e4a2 bugfix,srsenb,rrc: delete old context right away after sending Reestablishment msg. 
Following ReestablishmentRequests should use the most recent rnti as old context.
 4 years ago
Andre Puschmann f65faba756 sched_harq: fix uninitialized values in HARQ 
detected with Valgrind memcheck
 4 years ago
Francisco 35cea3d104 enb,optimization: consider mac::ue object in rnti pool memory block size 4 years ago
Francisco 7e77da6a15 mac,optimization: use rnti memory pool to create mac::ue objects 4 years ago
Francisco fd1d73666c bugfix,srsenb,mac: avoid sanity check for UL PDU length if CRC=KO 4 years ago
Francisco 76004a3054 enb,mac,refactor: mac::ue now uses byte_buffer_pool for UL PDUs 4 years ago
Francisco 9e2a7d4592 bugfix,tpc: only cap PUSCH TPC when PHR is negative. I also extended TPC unit test 4 years ago
Francisco bdc4362475 bugfix,tpc: place a cap on TPC due to PHR only when TPC is positive 4 years ago
Francisco 7badfb1c88 bugfix: avoid multiple TPC=0 for a single PHR<0 4 years ago
Francisco e2c37ad513 bugfix: missing early return in TPC derivation 4 years ago
Andre Puschmann c0be8187c8 rlc interface: convert entire read_pdu() interface to return uint32_t 
we had it returning int but had a bug in using the return value properly,
i.e. handling when -1 was returned in RLC TM.

Thinking about it more, it doesn't make sense to have a negative return
value here anyway. Either the RLC can return a PDU or not. If it can't the
returned lenght is zero.
 4 years ago
Andre Puschmann aaffdeb326 rrc,rlc: add method to signal protocol failure to RRC 
general-purpose method for lower layers to signal protocol
failures to higher layers, i.e. RRC.

In the current case, implement a direct release of the UE (enb) or
a reestablishment (UE).
 4 years ago
Francisco ceaef3523f sched,feature: Enable setting the target PHR below which the maximum UL grant size starts decreasing 4 years ago
Francisco 486823e5de sched,bugfix: The PHR handling scheme now considers the number of PRBs of the UL grant that carried the PHR. Before, it was assuming the most conservative scenario of Nprb=1 4 years ago
Francisco f7aef3ffc1 sched,bugfix: fix nof_retx update when UL HARQs are resumed 4 years ago
Francisco 89406b07d6 make eNB UL SNR initial value an exponential average alpha configurable 4 years ago
Francisco 3f75538660 rrc,feature: Use t301 to set time that the enb waits for the UE RRCConnectionSetupComplete or ReestablishmentComplete 4 years ago
Francisco 0349949cce bugfix, handover: disable inactivity timer during s1 handover in target enb 4 years ago
Pedro Alvarez 18e2149d68 Sending Initial Context Setup Response after RRC reconfiguration. 4 years ago
Francisco 2cdda3b6db sched,enhancement: allow PUSCH allocations when PHICH falls in measurement Gap by resuming UL HARQ 4 years ago
Francisco 200006c4b7 bugfix,scheduler: avoid offset to increase decrease unboundedly when mcs is equal to 0 or max_mcs 4 years ago
Francisco a587d20252 allow specification of subset of valid measurement gap offsets in rr.conf 4 years ago
Francisco 52247a46e5 rrc,refactor - change log level for paging try lock 4 years ago
Francisco 692bd193d5 rrc,improvements - use single subframe-indexed struct to access pending PCCH. The scheduler now doesnt lock checking for pending paging 4 years ago
Francisco 957ca453e9 bugfix,rrc: change mechanism to delete old paging messages to avoid deleting messages not yet sent 4 years ago
Francisco 7076dbfef8 feature, scheduler: Add configuration parameter to set minimum TTI interval between TPCs 4 years ago
Francisco 4627ae9802 bugfix, scheduler: effectively disable adaptive mcs when target bler is unspecified 4 years ago
Francisco dedd9c09a7 feature, scheduler: Add abitility to set minimum aggregation level in PDCCH, and disable adaptive aggregation level based on target BLER 4 years ago
Francisco c5029fc266 feature - implement adaptive link adaptation in DL and UL 4 years ago
Francisco 8811b7c9a7 fix handling of CRNTI CE in the RRC. The scheduler should not allocate more grants for the new rnti after this point. 4 years ago
Andre Puschmann fbb151af2d enb,rrc: fix bearer re-activation after max KO 
this patch makes sure that if RBs have been deactivated after
max KO on either the DL or the UL, they are reactivated if either
of them is working again.

UL/DL are always activated together, even if just one of them
recovers. The KO counter (or timer), however, is not stopped implicitly.
 4 years ago
Francisco a17e3b71e7 set minimum snr under which the UL SNR estimate is not updated 4 years ago
Francisco 8df6ed07c6 sched small fixes - use 0.930 instead of 0.932 for max coderate. Allow computing mcs/tbs based on max coderate directly. Other small fixes 4 years ago
Francisco 41bc7e4810 avoid letting repeated s1ap::user_release calls to deem the user as in zombie state. Use timer instead to auto-remove user from s1ap if no response from mme arrives 4 years ago
Francisco f705735093 optimization - only allow some multiqueue queues to notify the multiqueue consumer of the arrival of tasks 4 years ago
yagoda f90f6f0c7e adding MAC 0 padding support 4 years ago
Francisco 0a1ae0e4ad redesign and fix enb rrc message logs 4 years ago
Francisco 22f1f2d56c move ngap files into their own folders 4 years ago
Francisco 1488606156 refactor - create s1ap dedicated folder 4 years ago
Francisco 0e0835a805 move scheduler rbg/prb/cce mask and interval types and associated helper functions to a separate file 4 years ago
Andre Puschmann 167200f5cd rrc_bearer_cfg: replace fixed E-RAB to DRB mapping 
also make sure we don't assign LCIDs beyond the possible
number.

possible fix for https://github.com/srsran/srsRAN/issues/658

Co-authored-by: herlesupreeth <herlesupreeth@gmail.com>
Co-authored-by: Francisco <francisco.paisana@softwareradiosystems.com>
 4 years ago
Francisco 4d3ff0d139 implementation of basic search for optimal rbgmask for subband CQI 4 years ago
Francisco f8b6eae2bf use of min DL cqi across all PRBS to compute required DL PRBs 4 years ago
Francisco 8564996eaf fix sched_dl_cqi method to compute cqi-optimal rbgmask 4 years ago
Francisco 485c6ee129 subband CQI feature - add K parameter in sched_interface::ue_cfg_t and update it from RRC 4 years ago
Francisco 84ad6dd8ee Integrated new sched_dl_cqi class in sched_ue_cell 
- extend sched_dl_cqi interface to allow getting tti when cqi was last updated
- extend sched_dl_cqi to quickly get average cqi across the whole bandwidth
 4 years ago
Francisco 16d05ff042 Remove time exponential averaging of DL cqi 
- renaming: sched_cqi -> sched_dl_cqi
- testing: add unit test for sched_dl_cqi wideband cqi mode.
- feature: remove time exponential averaging of dl cqi
 4 years ago
Francisco 28c24a89ef sched subband cqi - create method to get cqi-optimal RBG mask 4 years ago
Francisco eeb8ad6571 sched,feature - creation of sched_cqi class to manage the update of CQI in a subband CQI setting 4 years ago
Francisco f25dbea4de fix PCCH assembly in srsenb rrc 4 years ago
Francisco 32228389a9 fix latest static analysis warnings in rrc paging 4 years ago
Francisco bfdb0332db remove undefined methods from rrc_ue 4 years ago
Francisco 46cfdaf9e5 Handle case when old rnti gets removed during RRC reestablishment 
This is achieved via:
- keep restarting the inactivity timer whenever a ReestablishmentRequest is received
- in case the RRC ReestablishmentComplete is very late and the old rnti was removed anyway,
  abort RRC reestablishment procedure and release new rnti
 4 years ago
Andre Puschmann b61be7878a enb,rrc: split RLF counter and timer handling for DL/UL/RLC 
this patch splits the counter and timer handling for PHY DL, PHY UL,
and RLC errors and makes sure that, for example, a successful DL
does not cancel the UL RLF timer, and vice versa.

They all use the same timeout value which is user-configurable.
 4 years ago
David Rupprecht f9c0009d23 Remove setup erabs function 4 years ago
Francisco 0d800eb8f6 stack, multiqueue - bugfix for multiqueue destruction, and addition of unit test 4 years ago
Francisco b54bb35343 use rnti_map_t in scheduler 4 years ago
Francisco 6b84754ede fix rrc and gtpu bearer rnti update during reestablishment. The rnti of UE's rrc_bearer_handler was not being updated 4 years ago
Francisco 1677abce8d create typedef for circular map of rntis. check return of gtpu ue creation 4 years ago
Francisco 9464f36714 make eNB UE release timer after RLF detection configurable 4 years ago
Francisco c6b9c12ba2 gtpu, feature - added the ability to configure gtpu indirect tunnel timeout value. This parameter is useful in the case that the end marker is not received 4 years ago
Francisco b619a2b649 application of new cache allocator to deques in scheduler 4 years ago
David Rupprecht c117b563c9 Initial commit for ngap in enb 4 years ago
Francisco 04ded030ea srsenb,bugfix - avoid logging error message when UE sends CRNTI MAC CE for old rnti whose context has already been erased. 4 years ago
Francisco f7016633d2 sched, fix - avoid tpc commands when target pusch and pucch snr are not specified 4 years ago
Francisco d3c51fdad4 limit minimum UL grant size to accommodate both BSR and RLC headers 4 years ago
Francisco cde61a5796 rrc paging - reduce the space taken by paging manager class 
Paging messages can only be transmitted in a subset of subframes - {0, 4, 5, 9}
I avoid now creating objects for the subframes that are not part of this subset
 4 years ago
Francisco b014cbfe0f rrc paging - removal of redundant mutexes in paging manager class. Now mutexes are indexed by subframe index instead of paging buffer index 4 years ago
Francisco 8487c10956 removal of unused variables 4 years ago
Francisco 01eace2631 rrc paging mechanism improvements 
- moved paging record handling to separate class
- parallel access to pending pcch messages by phy workers based on TTI and without common lock
- asn1 pcch message packing now takes place in stack thread, to avoid real-time issues
 4 years ago
Andre Puschmann 598594c51a all: bunch of pass by const& changes suggested by LGTM 4 years ago
Francisco Paisana d39183419c
Separate TPC PUSCH and PUCCH target SINR (#2740) 
* separate target pusch and pucch sinr configurations in tpc class and rr.conf
 4 years ago
Francisco 86dac9c823 several coverity high and medium impact fixes 4 years ago
AlaiaL d88760f099 Fixes coverity 366620 4 years ago
AlaiaL beaa1b3e24 Fixes coverity 369569 4 years ago
faluco 69726bc939 Remove two allocs in the prio queues in sched_time_pf. 4 years ago
faluco 7df308c756 Remove two mallocs in the stack: 
1) Extend the small buffer to 64bytes for the move_callback class.
2) Replace a std::map for a fixed size circular map in sched_time_pf.
 4 years ago
David Rupprecht 81ad72b0ff Refactor srb and drb handling 4 years ago
Ismael Gomez 77b11b82ac
Release UE if no activity in DRB (#2658) 
* Count user activity with DRB only and SRBs for initial procedures. Add counter to release user after max KO in UL.
 4 years ago
Francisco 14d32db92f implement Handover direct forwarding path availability configuration feature 4 years ago
Francisco b8fa1d1b61 fix rrc mobility test 4 years ago
Francisco 66988ffd32 s1ap - simplified erab setup procedure. Handle correctly the failure to setup causes 4 years ago
Francisco f401683960 s1ap - simplified erab modify procedure 4 years ago
Francisco 76978f0d14 s1ap - simplified erab release procedure 4 years ago
Francisco c5fc543516 s1ap - handling of ts1 reloc overall timer. 4 years ago
Francisco c2a99a8112 handover - support for handover cancellation causes, check for E-RAB QoS requirements, cancellation of handover if E-RABs are not supported in the target eNB 4 years ago
Francisco 6d401bc79f handover - check if UE integrity and encryption algorithms are supported in the target eNB, and report handover failure if not. 4 years ago
Francisco 77bd500312 handover - implement and test S1 Handover fail path for the case of invalid QoS config in HO Request message 4 years ago
Francisco d2c404b166 handover - setup s1ap cause in case of handover failure at the target enb 4 years ago
Francisco 49bd895e29 s1ap - handle invalid or repeated erab ids in s1ap erab release command 4 years ago
Francisco 7842e3bff3 s1ap - add unit test to check correct handling of invalid E-RAB ids in modification request. Fix s1ap in order for the test to pass 4 years ago
Francisco 985846e3bd s1ap - set multiple erab ids cause in replay when s1ap erab modify request has repeated ids. 4 years ago
Francisco 685c971dc2 fix recursive call to get rb name 4 years ago
Francisco 21718af3b6 avoid allocating std::string to get lcid radio bearer name. Refactored the lte radio bearer enum type 4 years ago
Francisco 344bdf3165 allocation of UE rlc and pdcp classes in the ue dedicated memory pool 4 years ago
Francisco 60d5c6df7b implementation of memory pool with individual memory blocks per UE that get accessed via their rnti 4 years ago
Francisco bb9601c13b gtpu - fix gptu manager members destruction order 4 years ago
Francisco b7d4a72ea1 adt - fix circular map clear() and erase(it) functions 4 years ago
Andre Puschmann 7459a65a8e enb,rrc_ue: remove unused variable 4 years ago
Francisco cdf72248f3 Reimplement batch-based background object/memory pool 
Main changes:
- addition of pool utilities
- The node size/alignment and batch allocation threshold are now runtime arguments
- object pool and memory pool are not anymore based on the same class.
  The object pool cannot use intrusive free list because it would overwrite the object
  memory
 4 years ago
Francisco fbeb87c53e remove unused parameters from mac::ue 4 years ago
Francisco b004c2024d integration of object pool in mac::ue for allocation of softbuffers. Definition of common object pool interface class 4 years ago
Francisco ec3cd9ffea adt - added background object pool test, and fix existing bugs related to the creation of pools with objects that are too small to be used in free lists 4 years ago
Francisco d1c5b000dc adt - creation of pre-initialized object pool, that leverages the background memory pool allocator 4 years ago
Francisco 046633674a refactor - removal of stack-gtpu interface, and use of socket manager interface instead 4 years ago
Francisco c24e382c19 Refactor of socket manager class 
- use of inheritance to simplify testing
- removal of global network manager
- pass of custon socket manager to s1ap and gtpu ctors
- overhauled the registration of socket fd,callback in socket manager
 4 years ago
Francisco 4aac7ac238 use global rx multisocket handler, and remove stack-s1ap interface 4 years ago
Francisco 39de2efa69 multisocket handler - use blocking socket remove method 4 years ago
Francisco bf96d897ee network utils refactor - renaming of socket handle to unique socket and cleanup of its methods 4 years ago
Francisco 8fda69a3dd refactor mac::ue cc_used_buffers_map class to use new circular_map container 4 years ago
Pedro Alvarez e1a852d4b8 Split split RLF timer and Inactivity timer 4 years ago
Pedro Alvarez 47135cb75b Changed counting of KOs to RRC 4 years ago
Pedro Alvarez 8194b5ec73 Added check for consequetive KOs in MAC. Change set_activity_user to pass activity and max KOs to RRC and trigger RLF timeout. 4 years ago
Francisco ec72b310d7 fix mme ue s1ap id initialization 4 years ago
Francisco 23ae9967cf replaced present+value for optional field in s1ap mme_ue_s1ap_id context field 4 years ago
Francisco c3482b45e1 s1ap - handle erroneous enb/mme s1ap ue id in received s1ap messages from the MME 4 years ago
Francisco cc369aca1f sched - handle the case when the CRC is missing and max retx is reached 4 years ago
faluco 54fab314c0 Enhance RRC eNB events: 
- Implement a common event "log_rrc" for all RRC events and discriminate by procedure using an enum.
- Log events for connection, reestablishment, reconfig, reject and release.
- Log the corresponding ASN1 message used by each procedure.
- Redefine the JSON object for this event to match the new structure.

Fixed a compilation error detected by the static analyzer in gcc9.3 where bounded_vector::data() was using taking the address of the internal buffer which confused it, prefer to use the data method of std::array.
 4 years ago
Pedro Alvarez 8c7aed1f81 Added handling of MSG3 timout exipiry in activity_timer_expired(). Avoid notifying S1AP in that case. 4 years ago
Pedro Alvarez 37699f2215 Send radio connection with UE lost if max retx are reached 4 years ago
Francisco d04a19f8bc refactor - increase code reuse in adt files 4 years ago
Francisco 5eccfad05b gtpu - added comments, updated expected construct, handled in rrc the case a gtpu teid fails to allocate 4 years ago
Francisco 82b34f3b3f gtpu refactor - fix gtpu logging formatting 4 years ago
Francisco 44440cf562 gtpu refactor - use of raii to automatic path switch and teid removal in forwarding. Clean up of gtpu_tunnel_manager methods. 4 years ago
Francisco ab2bd9a2d2 gtpu refactor - handle dl path state activation internally in gtpu tunnel manager class 4 years ago
Francisco cfd24f6a0e gtpu - leverage byte_buffer_pool to store buffered sdus in gtpu 4 years ago
Francisco bdc5094e17 gtpu - added unit test for gtpu_tunnel_manager class 4 years ago
Francisco c201eb7708 use of more space efficient sorted vector structure for lcid tunnels of a rnti 4 years ago
Francisco eba0edea4a creation of static id obj pool class. Application of this class to gtpu tunnels container to avoid allocations 4 years ago
Francisco 3cf5e85b20 create separate class to handle gtpu tunnel creation/deletion/search 4 years ago
Francisco 099a533573 bugfix - verify that TEID exists before trying to access it 4 years ago
Francisco e1523692c2 implementation of concurrent fixed size pool that leverages thread local caches to avoid mutexing 4 years ago
Andre Puschmann 1a0891df51 all: check return value of make_byte_buffer() and handle them safely 4 years ago
Francisco 4869b14de3 application of new circular map to mac::ue_db 4 years ago
Codebot 4523ee6087 rename srsLTE to srsRAN 4 years ago
Ismael Gomez 8d2197e751 Increase MAC UE circular buffer 4 years ago
Francisco 2054ad3f3c eliminate old BFS-based PDCCH allocator. Improvement the scheduler speed by ~2x 4 years ago
Francisco 6bec92fbc9 using new DFS-based PDCCH allocator as a default 4 years ago
Francisco 8347cabe4f implemented a DFS-based PDCCH allocator 4 years ago
Francisco a540c56552 gtpu bugfix - avoid erasing indirect tunnel and causing iterator invalidation while iterating list of tunnels 4 years ago
Francisco 977c194cbc gtpu,bugfix - handle the case when gtpu fails to allocate buffer for end marker. Also, added a timer that when expired, it autoremoves the GTPU handover tunnel 4 years ago
Francisco fb48f4484c sched refactor - removal or cleanup of unused sched methods 4 years ago
Francisco 137a21d6b2 sched refactor - use simple enum to represent allocation result. Refactored logging messages when allocation fails. 4 years ago
Francisco c0a90c5aa8 refactored sf result resetting to avoid realloc of memory 4 years ago
Francisco 1f35c4dc8b sched, feature enhancement, bugfix - allow RAR DL grants with variable PRB size 
Some bug fixes had to be solved:
- the cfi cannot be dynamic once we set a SIB/paging/RAR allocation. This is too avoid effective coderate to exceed its maximum
- the previous bugfix required adding the feature to cancel the last PDCCH+PDSCH allocation
 4 years ago
Francisco 47f1175502 [sched, feature enhancement] - allow variable nof prbs allocated per SIB / Paging message 4 years ago
Francisco 76103065f7 collapse the 2-stage DCI generation process of SIB/Paging/RAR into one single stage in the scheduler. 4 years ago
Francisco 3a4ae3d69d extended broadcast+RAR DCI encoding scheduler tests 4 years ago
Francisco 9601770196 rrc,bugfix - stop scheduling when RLC AM max_retx is achieved 4 years ago
Francisco 16b5e1fd4d fix collision detection of n1pucch for the ACK and SR in the scheduler 4 years ago
Francisco 6feb311e17 remove instantiations of move-constructors and move assignment operators from cc_buffer_handler 4 years ago
Francisco ca7fe1349e remove unnecessary sfinae from bounded_vector. Use bounded_vector for UE cc buffers. Set ue cc used buffers remove_pdu method to private 4 years ago
Francisco d27e0be609 created special class to manage mac::ue currently allocated rx UL buffers. This class avoids mallocs 4 years ago
Francisco 6159cb3817 add assert to ensure a valid ptr is passed to memory pool deallocator 4 years ago
Francisco 20928651c7 created batch allocator that leverages background worker pool 4 years ago
Francisco 3e9f93eb8a refactor - remove old log_filter and logmap libraries from the codebase 4 years ago
Francisco 770021e364 remove uneeded formatting and std::string creation/allocation in scheduler 4 years ago
Francisco fbbbf7886c sched,bugfix - reset harq used for msg3 correctly 4 years ago
Francisco d1483dc0f8 sched,bugfix - fix bitmask formatting. fix msg3 adaptive retx pdcch allocation 4 years ago
Francisco 837c5bdce5 clang tidy update. applied small fixes to warnings from clang-tidy 4 years ago
Andre Puschmann 20cbc48f90 rlc_am_lte: refactor PDCP/RLC interface to use fix sized data structure 
this patch replaces the std::vector type used in the interface between
PDCP and RLC to signal delivery status between both layers. The new
data type is a configurable but fixed-size vector.
The RLC AM doesn't need to dynamically allocate the vector for every SN but
uses the tx_window for storage.
 4 years ago
Francisco 20e341d0a1 mac,bugfix - fixed formatting of MAC and scheduler user-defined types 4 years ago
Francisco 5a1bf28fe1 optimization - minimization of number of std::string allocations for logging 4 years ago
Francisco d77b6e1d9c sched,optimization,refactor - use of custom formatter that avoids mallocs for getting bitmasks strings in hex and binary formats 4 years ago
Francisco f0ed1e06a8 documentation,bugfix - added documentation to new blocking queues, changed class names, and removed blocking pushes from the critical path 4 years ago
Francisco d1236fd62f stack,optimization - replaced previous block_queue design for new bounded queue in several places in the enb 4 years ago
Francisco b869b0d8e2 sched,bugfix&refactor: set dci_format before generating the remaining dci parameters in sched_ue::generate_dl_dci_format(...) 4 years ago
Francisco 77ac69796d sched,bug: change tbs/mcs derivation functions to forbid the use of alt cqi table for DCI format1A 4 years ago
Francisco 34e39a9835 Implementation of scheduler algorithm to avoid PUCCH collisions 
- The cch_allocator considers the existence of a fixed PUCCH region dedicated to CQI, SR, and HARQ ACKs
- At the moment PUCCH multiplexing is not considered
- The PUCCH width was increased to accommodate possible PUCCH-ACK positions
 4 years ago
Francisco 8ae8b31ba2 Allow collisions between PUCCH and Msg3 for 6 PRBs 
- The UL Harq now stores the type of UL alloc (msg3 or data)
 4 years ago
Francisco 7dcfe7bf0e sched: updated tbs calculation test. Fix edge cases that failed the test. 4 years ago
Francisco ed8ab3871c re-designed algorithm to compute lowest mcs that meets cqi,req_bytes,nof_prbs requirements in the scheduler 4 years ago
Francisco 9748c0be84 simplified tbs/mcs computation in scheduler 4 years ago
David Rupprecht aef6805d03 Added pcap net feature to eNodeB 4 years ago
Francisco c03dbc6742 fix RRC Connection Reestablishment procedure - correctly save old rnti bearer configuration in new rnti 4 years ago
Francisco 290f39d805 fix crnti mac ce handling in the rrc in normal (no handover) case 4 years ago
Francisco 023cb0fdde log on allocation failure in mac::ue class 4 years ago
Francisco beed2ddbaa simplified tx softbuffer acquisition interface in mac::ue 4 years ago
Francisco e0da736a5f fix memory management of softbuffers in mac::ue class 4 years ago
Francisco 02539344fb move rx used buffers of mac::ue to separate cc buffer handler class 4 years ago
Francisco cc6c9ffc51 move tx/rx softbuffers of mac::ue to separate cc buffer handler class 4 years ago
Francisco 2f95862932 move tx payload buffers of mac::ue to separate cc buffer handler class 4 years ago
Francisco 9eb46cc134 fixed clang tidy warnings in mac::ue.cc 4 years ago
Xavier Arteaga 1e55d68b55 Removed set RNTI from API 4 years ago
Francisco 4b09507c19 remove srslte.h includes from upper layers 4 years ago
Francisco b8bd869d0f move ue rlc interfaces to separate interfaces header file 4 years ago
Francisco a988351f46 move ue pdcp interfaces to separate interfaces header file 4 years ago
Francisco ea04104e8e move ue gw interfaces to separate interfaces header file 4 years ago
faluco 2328011732 - Remove old loggers in ttcn3 and in NR. 4 years ago
Andre Puschmann 46d8ed8742 enb,rrc: delay UE release after RLC maxRetx 
this fixes the eNB behaviour when RLC signals maxRetx reached.
By directly releasing the UE, we ignore the fact that the UE
could still have the reestablishment counters running, so
could attempt a reestablishment, which would result in a reject
because we would have destroyed the UE context too early.

this patch delays the removal of the UE to wait at least
until the reestablishment timers are expired.
 4 years ago
Pedro Alvarez 976b5c12c1
Releasing the UE when max retransmissions are reached in the RLC. (#2385) 4 years ago
Pedro Alvarez d8f3878ce1
RLC failure to deliver notifications and discard timer limits to 1500ms (#2368) 
* Added interfaces for the RLC to notify the PDCP of failure to transmit
SDU

* Limit discard timer to 1500ms, to avoid issues of lingering SDUs in the undeliverd_sdus_queue.

* Fix bug in early exit of notify_delivery and notify_failure

* fix compilation issue in rlc-pdcp notification

Co-authored-by: Francisco <francisco.paisana@softwareradiosystems.com>
 4 years ago
Francisco 6404722b4b convert qci_cfg in srsenb to std::map to allow qci values above 10 4 years ago
Francisco 9a9ed01dda rename pdcch_sched to sf_cch_allocator 4 years ago
Pedro Alvarez 6ecd6e273c Make sure that the status report is sent in RLF and PDCP reestablishment triggered by Handover 4 years ago
faluco a940e169a3 Add the enb_cc_idx value to S1 events. 4 years ago
faluco a4605883f0 Implement second revision of the events and metrics document. 4 years ago
Pedro Alvarez cfd94441a5 Added metrics to srsenb PDCP 4 years ago
Francisco 9546634b37 use unique_ptr for sched_ue database in scheduler. This will minimize the time spent locking while adding new users 4 years ago
Francisco c1adaec038 refactored cce position table structs 4 years ago
Francisco 823da24a8e removed uneeded sched method to set sched algorithm, and made configured flag atomic 4 years ago
Francisco 6b3cf6c597 moved pdcch sched to separate file 4 years ago
Pedro Alvarez b0fe302f8e Added interfaces so the upper layers can trigger the PDCP status report. Added ability to the UE to send Status Report aftre reestablishment. 4 years ago
Francisco a4423ff690 sched: fix compilation issue for gcc4.8 4 years ago
Francisco a7f4dfab2c sched: added checks for localized RBG assignment in case of DCI format1A 4 years ago
Francisco Paisana 34d4dc3974 set DCI format 1A while RRC setup/reestablishment/reconfiguration is on-going 4 years ago
Francisco Paisana c40ad81a90 cleanup s1ap methods. remove hard coded erab list in s1ap handover required message. 4 years ago
Francisco 23459dee28 Created enb_{rlc/pdcp/gtpu/phy_interfaces.h files. 4 years ago
Francisco 43e57df00b breaking enb_interfaces.h into multiple files on a layer basis. Created enb_rrc_interfaces.h, enb_mac_interfaces.h and enb_s1ap_interfaces.h 4 years ago
faluco 6359a2d948 - Upgrade the gtpu class in lib dir to srslog. 
- Propagate old log elimination through all the dependencies of gtpu.
 4 years ago
Francisco 3265d940ec remove byte buffer pool cached member variables as they are unnecessary now. 4 years ago
Pedro Alvarez de90b4753f Added the ability of the RLC AM to notify the PDCP of the acknowledged 
PDCP PDUs. This includes:

- Modifying the byte_buffer_t to include PDCP SN meta-data. This way,
  the RLC can keep track of the ack'ed bytes for a specific PDCP PDU.
- Added in the RLC an `undelivered_sdu_info queue`, to keep track of the
  amount of ack'ed bytes and the total size of the PDCP PDU,
  so the RLC can know when delivery is finished.
- Added an interface between the PDCP and the RLC so that the RLC can
  notify the PDCP when it receives an ack from the status PDUs. The RLC
  passes to the PDCP a vector of all the ack'ed pdus in a rx'ed status PDU.
- Added some tests to the notify functionality. This includes some tests
  where the PDUs are acked imediatly, and one test where the PDU is
  retx'ed.
 4 years ago
Francisco c4a50b7de0 avoid loss of pdcp sdus' SNs buffered in gtpu during handover 4 years ago
Francisco 9e25e95545 fix S1AP UE Capability Indication message. Created helper to log received S1AP messages 4 years ago
Francisco 78d1b8083a fix GTPU tunneling. Avoid forwarding packets to PDCP while the PDCP bearer is not yet created 4 years ago
Andre Puschmann 8e13f04684 mac_pcap: refactor MAC PCAP and include NR RAT into same object 
after adding the thread-safe PCAP writer functionality to the EUTRA
MAC object it became clear that we don't wont to replicate the
same for the NR object.

This patch therefore refactors the class that now supports both EUTRA and
NR rats. The old mac_nr_pcap.[h/cc] has been deleted. All test-cases
and usages now use the new object that needs to pass the RAT type in
the ctor.

this patch addresses the last open point of #2160
 4 years ago
faluco 79eca0980d - Ported fsm.h to srslog. 
- Adapted and removed old loggers in tests and code that used fsm.h
 4 years ago
faluco 96c07a69c0 Report the RLF event to the JSON event file in the enb. 4 years ago
Francisco ec14a6e50b verify correctness of input to gtpu::write_pdu 4 years ago
Francisco 411946c752 Improvements on GTPU message logging 
- Avoid multiple lines per each SDU Rx or Tx
- log info relative to source and destination of each SDU
- log info relative to whether the Rx SDU has been forwarded into a tunnel
- log info relative to whether the Rx SDUs are being buffered.
 4 years ago
Francisco 2bde28252c send UE capability indication through S1AP 4 years ago
Francisco d64ce7df77 implementation of S1 E-RAB Release Indication and Error Indication messages 4 years ago
faluco ac62e3c398 Fix the priority of logging levels in places where we before logging we check if a certain log level is enabled. 4 years ago
herlesupreeth 47fff7226a Send NAS PDU in E-RAB Release Command and issue RRCConnectionReconfiguration to UE 
This commit addresses the following points

- If a NAS-PDU IE is contained in the E-RAB RELEASE COMMAND message, the eNB shall pass it to the UE.
- Issue RRCConnectionReconfiguration for the DRB to be removed
- Cleaning of DRB in RLC and GTP-U
- Fix for Malformed E-RAB Setup Response upon reaching max. DRBs
 4 years ago
Andre Puschmann da9e3363f1 mac_pdu_nr: rename MAC PDU class for NR to adhere naming conventions 
* mainly to have _nr as trailing name for filename and class
* also add "sch" to class and filename (RAR PDU will have extra class)
 4 years ago
Francisco 2befbd1825 setup of forwarding tunnels during enb s1 handover 4 years ago
Francisco 56ec2c286e add gtpu test for tunneling 4 years ago
Francisco 13649e4e19 Implement new GTPU functionality: 
- multiple tunnels per E-RAB
- data forwarding between connected GTPU tunnels
- forwarding GTPU End Marker between connected tunnels
- TeNB GTPU handles in-sequence delivery when multiple tunnels for the same ERAB exist.
 4 years ago
faluco 711438f756
Port enb specific classes to use srslog (#2155) 
* - Started porting the enb PHY layer to use srslog loggers.
- Updated srslog to manage the none level.

* Finished porting enb phy layer including the NR part.

* Ported MAC, GTPU, PDCP, RLC and S1AP enb classes to use srslog.

* Use new stack logger.

* Ported the enb RRC clases to use srslog.

* Remove unused log macros.

* Replace loggers in sched, sched_carrier, sched_helpers.

* Replaced loggers in sched grid.

* Replaced loggers in sched harq.

* Replaced loggers in sched ue.

* Replaced loggers in sched ue ctrl.

* Replace loggers in sched ue ctrl TPC.

* Replaced loggers in sched subclasses.

* Replaced loggers in rrc_meascfg_test

* Configure loggers in rrc_mobility_test.

* Fix compilation errors left out after the rebase.

* - Implement a custom log sink that will serve as a test spy to intercept and count the number of error and warning log entries.
- Adapt the erab_test_setup and rrc_mobility tests to use this new class and make them pass again.

* - Remove trailing new lines introduced in the rebase.
- Ported the sched_ue_cell class to srslog.

* Remove unused log member.

* Ported mac tests to srslog.

* - Removed remaining trailing newlines from log entries.

* Fix compiler errors detected in CI.

* Fix another static variable without definition passed to log lines.

* Fixed a bug in srslog::flush that would never end when the backend queue is full.

* Fetch the RRC logger instead of injecting it in the constructor.
 4 years ago
yagoda 1420c23863 adding RAR buffers for multiple carriers, previously RARs into different carriers in the same TTI would overwrite each other 4 years ago
Francisco 26086252ba fix resetting of harqs in the scheduler during intra-enb handover 4 years ago
Ismael Gomez fed4e0ad82
Protect access to ul buffers (#2227) 
* Protect access to ul buffers

* Fix interval calculation when removing old buffers
 4 years ago
Francisco a24091edf8 fix handover regression. The new pcell was not being correctly reactivated 4 years ago
Francisco 4ed87babff extend sched_ue_cell interface 4 years ago
Francisco 3d7a83cb6e delete cc_sched_ue class 4 years ago
Francisco Paisana c1ff03bd1a moved uci feedback and state variables from cc_sched_ue to sched_ue_cell class 4 years ago
Francisco Paisana dadee757a1 moved harq entity and tpc to sched_ue_cell 4 years ago
Francisco Paisana 3892194d98 sched refactor, use enb_cc_idx rather than ue_cc_idx primarily to avoid uneeded conversions 4 years ago
Ismael Gomez 47dbd6ed70
Merge pull request #2214 from softwareradiosystems/pr_mac_buffers 
Limit the number of UL buffers in MAC and deallocate old ones
 4 years ago
Ismael Gomez 44e411be2b Track UL buffers per TTI instead of per PID and remove old ones periodically 4 years ago
Ismael Gomez a6423442c2
Refactor NR RA files and fix header includes all over library (#2162) 
* Refactor NR resource allocation classes. Use DCI instead of grant for dummy PDSCH UE/eNB test

* Minor refactors in NR workers and ue_dl

* Fix include issues

* fix compilation issues
 4 years ago
Ismael Gomez d5f0634975
Add PUCCH SNR measurement (#2175) 
* Add PUCCH SNR measurement

* Fix PUCCH SNR estimation

* Reverted PUCCH noise estimation

* use fpclassify instead of iszero

Co-authored-by: Xavier Arteaga <xavier@softwareradiosystems.com>
 4 years ago
Ismael Gomez c1c5fa426c Fix issue with new way of managing ul buffers not working with CA 4 years ago
Ismael Gomez e413086576 Limit the number of UL buffers in MAC and deallocate old ones 4 years ago
Francisco Paisana 5391001c46 remove unused variable 4 years ago
Francisco Paisana d4242f2db7 precompute nof_re_table[sf][prb][slot][cfi] for faster nof_re computation and for more accurate lower bound nof_re computation 4 years ago
Francisco Paisana d0a17b0a40 created sched_ue_cell class that is indexed based on enb_cc_idx 4 years ago
Francisco Paisana 8b306c81e2 refactor tbs/mcs computation in sched 4 years ago
Francisco Paisana 32c47d4fac change sched warning when it fails to fit srb0 data in grant to info 4 years ago
Francisco Paisana 1dd211c91c fix log initialization in sched_helpers.cc 4 years ago
Francisco Paisana afef5188a6 move sched_harq to subfolder 4 years ago
Francisco Paisana 233e604cfe cleanup sched_ue, moving some unrelated functions to sched_helpers 4 years ago
Francisco Paisana 9c7c190074 when the rrc fails to allocate the ue cell resources, it should erase the ue from all stack layers 4 years ago
Francisco Paisana 0d9ff3ecc7 fixed RBG<->PRB conversion. Changed PHICH logging to be single line 4 years ago
Francisco Paisana 0761a8f08b Add RLF-Report handling functions to srsENB 4 years ago
Francisco Paisana 434bdfca68 decoupled srsenb rrc ue mac controller from the rrc::ue class 4 years ago
Francisco Paisana f8b7351e1b implementation of object memory pool via class-specific operator new/delete 4 years ago
Francisco Paisana 8912a8ce6c added extra comments to memory pool code. generalized object pool to mutexed and non-mutexed cases 4 years ago
Francisco Paisana a73cbcdc9d added mem_pool for growing object pools. Applied the mem pool to the rrc::ue creation 4 years ago
Francisco Paisana bc8e65c82f bug fix in the PF scheduler. The correct history was not being stored for newtxs 4 years ago
Francisco Paisana 02d4dde1f5 issue 2170 fix: add extra check that UL harq is empty before allocating it 4 years ago
Francisco Paisana ea8ad153c4 add configurable fairness parameter to pf scheduler 4 years ago
Francisco Paisana 2abe486e18 separate control loops for PUCCH and PUSCH TPC 4 years ago
Andre Puschmann 732a108982 mac: convert rar_pdu_msg[] from vector into array and protect access 
attempt to address ASAN detected issue:

RACH:  tti=821, cc=3, preamble=11, offset=0, temp_crnti=0x47
ASAN:DEADLYSIGNAL
=================================================================
m==25385==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000024 (pc 0x564b19a26c93 bp 0x7fa0e5f1a8c0 sp 0x7fa0e5f1a798 T8)
==25385==The signal is caused by a WRITE memory access.
==25385==Hint: address points to the zero page.

------DL--------------------------------UL------------------------------------
rnti cqi  ri mcs brate   ok  nok  (%)  snr  phr mcs brate   ok  nok  (%)   bsr
  46 0.10   0 0.0     0    0    0   0%    0  0.0   0     0    0    0   0%   0.0
  47 0.10   0 0.0     0    0    0   0%    0  0.0   0     0    0    0   0%   0.0
    #0 0x564b19a26c92 in srslte::rar_subh::set_ta_cmd(unsigned int) /mnt/data/jenkins/workspace/srslte_ogt_manual_zmq/srsLTE/lib/src/mac/pdu.cc:1136
    #1 0x564b19577f7e in srsenb::mac::assemble_rar(srsenb::sched_interface::dl_sched_rar_grant_t*, unsigned int, int, unsigned int, unsigned int) /mnt/data/jenkins/workspace/srslte_ogt_manual_zmq/srsLTE/srsenb/src/stack/mac/mac.cc:837
    #2 0x564b19591765 in srsenb::mac::get_dl_sched(unsigned int, std::vector<srsenb::mac_interface_phy_lte::dl_sched_t, std::allocator<srsenb::mac_interface_phy_lte::dl_sched_t> >&) /mnt/data/jenkins/workspace/srslte_ogt_manual_zmq/srsLTE/srsenb/src/stack/mac/mac.cc:653
    #3 0x564b19497ee2 in srsenb::lte::sf_worker::work_imp() /mnt/data/jenkins/workspace/srslte_ogt_manual_zmq/srsLTE/srsenb/src/phy/lte/sf_worker.cc:208
    #4 0x564b199f8db4 in
 4 years ago
Francisco Paisana 9de318c7e6 avoid allocating DL harqs when respective acks are still pending, when there is a reordering of ttis in the phy 4 years ago
faluco 92b11c1adb Backport misc changes from the fapi repo. 4 years ago
Pedro Alvarez 0c20b7a455 Added support for S1AP modify bearer request support. This includes: 
- Handle received E-RAB S1AP at s1ap.cc.
 - Added methods to rrc.cc, rrc_ue.cc and rrc_bearer_cfg.cc to handle erab modify request.
 - Made RLC add_bearer() function capable of re-creating the RLC entity.
 - Send RRC reconfiguration to the UE and reply to the EPC with S1AP
   modify bearer response.

This commit also adds support to srsEPC to send S1AP modify bearer request for
testing purposes.
 4 years ago
Francisco Paisana 099dad8cb1 disable PHR handling in the UL sched by default 4 years ago
Ismael Gomez f9a02299f9 Use MAC PDU pointer instead of tti_rx and rnti as a key to associate buffers. Decouple crc_info() and push_pdu() functions. This allows for different timing architectures in the PHY 4 years ago
Francisco Paisana 82eb31f70f add rlc metrics to enb 4 years ago
faluco 343587b32d Update NR classes after metrics interface changes. 4 years ago
faluco f20b75a05f Re-structure enb metrics a bit. Create a generic mac metric struct and per ue mac metrics struct. 4 years ago
faluco 5529943172 Add a per sector rach preable counter for the metrics. 4 years ago
Francisco 43e0a3209d fill enb rrc metrics with drb info 4 years ago
faluco dcd1157d39 - Prototype the extension of enb metrics. 4 years ago
Pedro Alvarez 7eebd71627 Added S1AP E-RAB release command/response handling to srsENB. 
Added the ability to srsEPC to send the E-RAB release command.
 4 years ago
Francisco cba0cc457f sched rand test refactor: creation of abstract sched simulator class for testing 4 years ago
David Rupprecht 848496bb0f Moved get_earfcn to srslte get_carrier_freq func 4 years ago
Francisco b4861bc59a move sched params and sched helper methods to sched_helpers.h/cc files. Removed place in the scheduler where the mcs is increased forcefully to avoid segmentation 4 years ago
Francisco 99f94d9a1a Bug fixes of srseNB scheduler TPC 
- fix encoding of TPC command
- use of exponential average with irregular sampling for the ULSNR average estimate.
  Turns out using a time-windowed average for the SNR was a bad idea.
  If the UL grants are very sporadic, the SNR time window will never have samples
  when a TPC is encoded
- update of TPC sched test
- other fixes in accumulators lib
 4 years ago
Francisco 22229adf08 fix: normal phr is only sent for PCell 4 years ago
Francisco 69748e9313 fix compilation issue regarding definition of size_t in header and declaration of static member null_value in sliding average class 4 years ago