Andre Puschmann
a36e0477b8
rlc_am: fix status PDU packing when grant size isn't enough to send full report
...
when a small grant is provided it might not be possible to fit a full status
PDU. This is currently detected while packing the PDU.
In order to avoid sending potentiall contradicting status info to the sending
entity, the fix makes sure to only transmit a small PDU acking what really
has been received so far.
This might not be optimal in terms for retx but will not corrupt any
state.
4 years ago
Andre Puschmann
5838ec4999
rlc_am: revert expect macro back to error log and inform higher layers
...
the incidence really must be handled by the higher layers, i.e. the bearer
needs to be reestablished.
4 years ago
Andre Puschmann
f22f4b4fbd
rlc_am: fix potential stalling in RLC transmitter
...
it turned out that a certain order of events can lead to
a RLC transmitter stalling because even though unacknowledged PDUs
are queued, none of them was actually considered for retx.
This can happen if a pollRetxTimer expires for a SN that, meanwhile,
has already been acknowledged. The positive lead to the deletion of
the SN from the Tx window.
The fix makes sure that when a retx for a unexisting SN is requested,
the sender will consider the next unacknowledged SN instead.
4 years ago
Andre Puschmann
9612bb0e14
rlc_am_test: fix status PDU test and add extra test for failure signaling
4 years ago
Andre Puschmann
aaffdeb326
rrc,rlc: add method to signal protocol failure to RRC
...
general-purpose method for lower layers to signal protocol
failures to higher layers, i.e. RRC.
In the current case, implement a direct release of the UE (enb) or
a reestablishment (UE).
4 years ago
Andre Puschmann
107f6334dd
compile: fix compilation on 32bit systems that require -latomic
4 years ago
Francisco
ceaef3523f
sched,feature: Enable setting the target PHR below which the maximum UL grant size starts decreasing
4 years ago
Francisco
486823e5de
sched,bugfix: The PHR handling scheme now considers the number of PRBs of the UL grant that carried the PHR. Before, it was assuming the most conservative scenario of Nprb=1
4 years ago
Francisco
f7aef3ffc1
sched,bugfix: fix nof_retx update when UL HARQs are resumed
4 years ago
Ismael Gomez
5db3030428
Tiny changes
4 years ago
Francisco
89406b07d6
make eNB UL SNR initial value an exponential average alpha configurable
4 years ago
Andre Puschmann
1529379e9e
fec,pbch: remove unused variables
...
unused code that moreover was causing TSAN to complain, e.g.
in the ue_phy_test
4 years ago
Andre Puschmann
7ee38e6255
threads: disable thread attributes when compiled with TSAN
...
TSAN doesn't work well then threads are created with attributes
thar require root rights but the process is run as normal user.
this patch avoid the thread attributes in this case. TSAN isn't going
to be used for production builds.
4 years ago
Andre Puschmann
b88f22b9fe
network_utils_test: fix race detected with TSAN
4 years ago
Andre Puschmann
f823340a95
rf_imp: fix race when stopping gain thread
...
detected with TSAN using benchmark_radio test
4 years ago
Andre Puschmann
716caafd6c
multiqueue_test: fix race reported by TSAN
4 years ago
Andre Puschmann
1ef3cb7e5d
threads: fix race in stopping periodic thread
4 years ago
Andre Puschmann
312b5a241c
mac_pcap_base: fix race detected with TSAN
4 years ago
Andre Puschmann
c434aac526
rlc_stress_test: include tsan options header
4 years ago
Andre Puschmann
1d34aa280f
byte_buffer_queue: make class thread-safe by using atomics
4 years ago
Pedro Alvarez
18e2149d68
Sending Initial Context Setup Response after RRC reconfiguration.
4 years ago
Xavier Arteaga
4f7a94acb6
Fix comment
4 years ago
Xavier Arteaga
d329297151
Implement radio invalid mapping countermeasure
4 years ago
Andre Puschmann
3966065bff
pssch_test: fix newlines in printf
4 years ago
Andre Puschmann
2ace2b47b8
pssch: fix uninitialized value
4 years ago
Xavier Arteaga
bbab2cd9ba
Make PDCCH LLR mean amplitude in function of maximum
4 years ago
Xavier Arteaga
2ca0932d9b
Reviewed LTE noise estimation
4 years ago
Xavier Arteaga
10a268fdba
Added SNR to phy_dl_test
4 years ago
Francisco
f36f5271d3
timers,feature: make timers thread-safe by using atomic to store timers state.
4 years ago
Xavier Arteaga
dddb3ede71
Fix zero parity
4 years ago
Andre Puschmann
50f7fc644b
rlc_am_lte: log event when status prohibit timer expires
4 years ago
Xavier Arteaga
3c93d5ba43
Fix carrier mapping concurrency issue
4 years ago
Xavier Arteaga
235a664120
SRSUE: Removed PUSCH-DMRS/SRS pregeneration methods
4 years ago
Andre Puschmann
531acc0a98
rlc_am_test: add check for RLC buffer state return during retx
4 years ago
Andre Puschmann
3102861ee3
rlc_am_lte: make func param const&
4 years ago
Francisco
0dafe4dd58
fix coderate derivation in PDCCH based on aggregation level
4 years ago
Francisco
a587d20252
allow specification of subset of valid measurement gap offsets in rr.conf
4 years ago
Andre Puschmann
02cceee997
rf_zmq_imp: revert 28399dd876
and fix unit
...
although the manual test with Amarisoft eNB worked fine it seems
the delay is still needed in the default case. Over 50% of the
tests failed in the nightly with:
[zmq] Error: tx time is 0.067 ms in the past (138240 < 139776)
[zmq] Error: tx time is 1.100 ms in the past (184320 < 209664)
While this usleep() should increase the pass likelihood it
still doesn't guarantee error-free runs, so we might need
to revisit it again as some stage.
4 years ago
Andre Puschmann
e7aa484308
rf_zmq_test: remove srsran.h include
4 years ago
Andre Puschmann
bb6a5ebe80
tsan: add TSAN options file to set some default flags and exclude some libs from checks
4 years ago
Andre Puschmann
28399dd876
rf_zmq_imp: remove sleep
4 years ago
Andre Puschmann
574459fd90
rf: remove srsran.h include
4 years ago
Xavier Arteaga
f33731ecd4
Disable irrelevant unit/component test by default
4 years ago
Andre Puschmann
d9a5d3f95a
pcap_base: increase PDU queue length
...
some systems with slower HDD seem to have issues
writing the PDUs to disk. increasing length to see if that helps.
4 years ago
Xavier Arteaga
a245039cf3
Initial NR-PBCH-DMRS integration
4 years ago
Pedro Alvarez
997f7db23a
Small fixes for observer.h missing std::size_t
4 years ago
Pedro Alvarez
c74b2dd633
Fix some warnings in PHY due to array parameter mismatch for a few functions
4 years ago
Andre Puschmann
c1ad867824
epoll_helper: use std::atomic to protect exit called from different thread
4 years ago
Andre Puschmann
d8b2cfcef8
zmq,ringbuffer: protect concurrent access
...
some issue found through TSAN execution
4 years ago
Andre Puschmann
f1e6a975de
thread_pool: fix concurrent access of state variable
...
the thread workers need access to their current state to exit properly
when they are set to state STOP. However, since the state is kept in
a std::vector for all workers, it seems more appropiate to add a per-thread
running variable rather then mutexing the entire vector.
4 years ago
Xavier Arteaga
48e0fc3c99
Implemented initial PBCH decoder and refactored SSB candidate selection
4 years ago
Xavier Arteaga
de1b25558f
Added PRN sequence apply bit with state
4 years ago
Xavier Arteaga
1f38817b3b
Added random bit vector generator
4 years ago
Xavier Arteaga
bcb91d6173
srsran_vec_sprint_hex returns number of written characters
4 years ago
Xavier Arteaga
3634e96c3e
Added SSB measure test add/put/encode time measure
4 years ago
Xavier Arteaga
0aa5b14145
Initial NR PBCH encoding
4 years ago
Xavier Arteaga
d66dac0ab2
Added bit sequence state apply
4 years ago
Francisco
7076dbfef8
feature, scheduler: Add configuration parameter to set minimum TTI interval between TPCs
4 years ago
Francisco
dedd9c09a7
feature, scheduler: Add abitility to set minimum aggregation level in PDCCH, and disable adaptive aggregation level based on target BLER
4 years ago
Francisco
c5029fc266
feature - implement adaptive link adaptation in DL and UL
4 years ago
Francisco
8df6ed07c6
sched small fixes - use 0.930 instead of 0.932 for max coderate. Allow computing mcs/tbs based on max coderate directly. Other small fixes
4 years ago
Francisco
31936c9754
bugfix - printf formatting incorrect in bounded_bitset method
4 years ago
Francisco
b093576634
avoid sending UEContextReleaseRequest from Source eNB during S1 Handover.
4 years ago
Francisco
f2a56c9139
simplification of multiqueue design.
...
- the consumer does multi-staged waiting:
1. spins first across all queues in a RR fashion
2. each queue access is done with a try_lock.
3. if the try_lock fails, it increases the number of spins needed
2. if no queue had data, the consumer sleeps for 100 usec.
- no differentiation between queues, in terms of notification features
4 years ago
Francisco
60a8ee0af9
multiqueue optimization - use condition_var wait_for() method, use queue try_lock in the consumer side
4 years ago
Francisco
b41aba2a03
fix task scheduler test
4 years ago
Francisco
2d6a878826
change interface to create multiqueue queues
4 years ago
Francisco
f705735093
optimization - only allow some multiqueue queues to notify the multiqueue consumer of the arrival of tasks
4 years ago
Andre Puschmann
bc3be73364
rlc_am_lte: replace simple sanitfy check with error log with expect
...
this should help debugging the situation when this happens by
aborting when STOP_ON_WARNING is enabled
4 years ago
yagoda
9501283c1c
fixing support for extended Cyclic Prefix
...
small cosmetic fixes of CP code
4 years ago
Andre Puschmann
21b3635ae4
rlc_am_lte: refactor retransmit_pdu() to send different SNs
...
it seems that different SNs should be retransmitted depending
on the actual situation. In case of pollRetx timer expiration,
vt_s - 1 should actually be resent.
This patch prepares the function to accept different SNs but
leaves it to send vt_a by default. The RLC AM test would need
to changed as well to not fail.
4 years ago
Andre Puschmann
81c1851bbd
rlc_am_test: fix TSAN isses and removing info log when dropping PDU
4 years ago
yagoda
f90f6f0c7e
adding MAC 0 padding support
4 years ago
Xavier Arteaga
8ffbf0ff6d
Fix SSB segfault
4 years ago
Xavier Arteaga
f9aafd00a7
Added subcarrier spacing parsing from string
4 years ago
Xavier Arteaga
b69057b76e
Filesource filename to constant
4 years ago
Xavier Arteaga
5eadc06dd4
Intra-frequency miscellanous changes
4 years ago
Xavier Arteaga
7b159563ab
Fixes in LTE CRS measurements
4 years ago
Xavier Arteaga
1603580901
Fix NR PSS correlation
4 years ago
Xavier Arteaga
0b3f4e5de0
Improvements in NR cell search
4 years ago
Xavier Arteaga
53b2c6076b
Fix UHD subdev specification
4 years ago
Xavier Arteaga
11d925c0b2
Minor SSB fix and changes
4 years ago
Xavier Arteaga
c8cb128317
Declare band helper methods as constant
4 years ago
Xavier Arteaga
60015e7ceb
Made intra frequency cell search and measurment generic
4 years ago
Xavier Arteaga
648f0af437
Implement SSB search based on correlation
4 years ago
faluco
6fb81c7619
- Add a mutex with priority inheritance for srslog internal structures.
...
- Replace shared_variable members in log_channel class in favor of atomics.
- Remove the small string optimization in srslog now that we dont allocate anymore.
- Trim some critical sections in srslog.
4 years ago
Francisco
1488606156
refactor - create s1ap dedicated folder
4 years ago
Andre Puschmann
167200f5cd
rrc_bearer_cfg: replace fixed E-RAB to DRB mapping
...
also make sure we don't assign LCIDs beyond the possible
number.
possible fix for https://github.com/srsran/srsRAN/issues/658
Co-authored-by: herlesupreeth <herlesupreeth@gmail.com>
Co-authored-by: Francisco <francisco.paisana@softwareradiosystems.com>
4 years ago
Francisco
fa34aaa16e
ensure the DL mask count is reduced enough to fit required bytes
4 years ago
Francisco
485c6ee129
subband CQI feature - add K parameter in sched_interface::ue_cfg_t and update it from RRC
4 years ago
Francisco
84ad6dd8ee
Integrated new sched_dl_cqi class in sched_ue_cell
...
- extend sched_dl_cqi interface to allow getting tti when cqi was last updated
- extend sched_dl_cqi to quickly get average cqi across the whole bandwidth
4 years ago
Francisco
a841b7580e
fix deadlock caused by non-notification of multiqueue consumer side
4 years ago
Xavier Arteaga
9e1a85afe8
Fix NR SCH Nref calculation
4 years ago
Xavier Arteaga
0ecb3a7220
Modify NR PHY info messages
4 years ago
Xavier Arteaga
91030c5824
Fix procedure for MCS table selection
4 years ago
Xavier Arteaga
b02a0d3db9
Added RNTI type short string
4 years ago
Xavier Arteaga
08ec1d0df9
Changed srsLTE to srsRAN
4 years ago
Xavier Arteaga
a57336d64f
Integrate periodic SSB measurement in SRSUE and fix related defects
4 years ago
Xavier Arteaga
5e41e99f08
Added NR symbol offset helper function
4 years ago
Xavier Arteaga
7450232b3e
Added more NR band related helpers
4 years ago
Xavier Arteaga
758fd3c1ba
Implemented initial NR cell search
4 years ago
Xavier Arteaga
2f9c7e1345
Avoid cexpf in srsran_vec_apply_cfo_simd
4 years ago
Xavier Arteaga
90c42bc9c3
Fix resampler stack overflow
4 years ago
Xavier Arteaga
9517b78c03
Fix resampler and improved unit test
4 years ago
Francisco
996d8ef74d
multiqueue bugfix for non-blocking pushes when queue is full
4 years ago
Francisco
99abae9e6a
fix multiqueue producer to consumer notification to avoid deadlocks
4 years ago
Francisco
0d800eb8f6
stack, multiqueue - bugfix for multiqueue destruction, and addition of unit test
4 years ago
Francisco
d947e259c9
stack optimization - optimization of the multiqueue
...
avoid notifying the consumer side of the multiqueue of a new pushed object, if the
multiqueue already knows that the queue is not empty.
4 years ago
Francisco
d574afcd33
cleanup of multiqueue unused methods, and made queue_handle move semantics correct
4 years ago
Francisco
ef9d1b8c13
stack optimization - reduction of contention in multiqueue class
...
With the new design, each queue created in the multiqueue object has its own mutex.
Pushing tasks to separate queues will, therefore, not cause contention.
There will be, however, still contention between the popping thread and the pushing threads.
4 years ago
Xavier Arteaga
d9586015f5
SSB related minor aesthetical corrections
4 years ago
Xavier Arteaga
60d1708b80
Initial SSB measurement implementation
4 years ago
Xavier Arteaga
5c31f4335f
Initial SSB module header file
4 years ago
Xavier Arteaga
3f078cdc24
Added SSB related constants
4 years ago
Francisco
b54bb35343
use rnti_map_t in scheduler
4 years ago
Xavier Arteaga
1396c2a1e2
Mulpiple CSI measurement fixes. Channel and sync metrics from CSI measurements
4 years ago
Xavier Arteaga
fd0d804321
Added macro for calculating the squared absolute value of a complex variable
4 years ago
Xavier Arteaga
e68c822505
NR Added CSI measurement channel processing
4 years ago
Xavier Arteaga
c51ff0c9f9
Added safe exponential moving average filter
4 years ago
Francisco
c5396155ad
set default gtpu tunnel close timeout to infinity
4 years ago
Francisco
15484e9472
rrc - make t304 configurable via rr.conf
4 years ago
Francisco
c6b9c12ba2
gtpu, feature - added the ability to configure gtpu indirect tunnel timeout value. This parameter is useful in the case that the end marker is not received
4 years ago
Francisco
cd51537234
add comment explaining the use case of cached_alloc
4 years ago
Francisco
28847badcf
implementation of custom allocator for memory caching. This allocator may be used for unbounded queues
4 years ago
David Rupprecht
c117b563c9
Initial commit for ngap in enb
4 years ago
Francisco
7bee75e126
update description of srsenb --expert.nof_prealloc_ues config parameter, and added a comment in header file explaining the use of such parameter.
4 years ago
Francisco
5818488b27
change enb max_nof_ues config parameter to nof_prealloc_ues
4 years ago
Xavier Arteaga
de9158eeaf
Enable NR RRC MCS table selection
4 years ago
Xavier Arteaga
eef3fac863
Improved float XOR readability
4 years ago
Xavier Arteaga
751b6858b3
Added CSI-RS resource set measurements
4 years ago
Xavier Arteaga
3b919b4f6c
Minor aestheics change
4 years ago
Xavier Arteaga
243ad05dfa
Added on the fly sequence apply in float
4 years ago
faluco
aef18f9931
Implement a benchmark for measuring latency in the foreground threads when pushing log entries.
...
This benchmark runs with several threads to test contention.
4 years ago
Francisco
01eace2631
rrc paging mechanism improvements
...
- moved paging record handling to separate class
- parallel access to pending pcch messages by phy workers based on TTI and without common lock
- asn1 pcch message packing now takes place in stack thread, to avoid real-time issues
4 years ago
Xavier Arteaga
318f064ff4
Multiple NR SCH fixes
4 years ago
Xavier Arteaga
b8e0164f7f
Multiple fix NR PHY procedures
4 years ago
Xavier Arteaga
a8e181971c
Refactored PHY NR procedures for supporting DCI formats 0_1 and 1_1
4 years ago
Andre Puschmann
bbea3dd6a1
byte_buffer: fix compilation when buffer pool log is enabled
4 years ago
Francisco
5cecb40410
rlc,bugfix - increase pdcp sn notification ack list maximum size
4 years ago
Francisco
ad1a0eb2ac
rlc,fix - Add PDCP PDUs to undelivered_sdu_info_queue when the PDUs are popped from the tx_sdu_queue, rather than they are pushed to.
...
- This simplifies the sdu discard
- This also fixes an existing race condition
4 years ago
Andre Puschmann
598594c51a
all: bunch of pass by const& changes suggested by LGTM
4 years ago
Francisco
7ced0e73eb
rlc,bugfix - avoid accessing the PDCP info of RLC segments when the PDCP has already discarded the respective PDCP SN.
4 years ago
Andre Puschmann
597729ac53
rlc: always remove PDCP SNs from undelivered queue
...
if RLC PDUs with certain PDCP SNs were already in flight
when their discard timer at PDCP expires, they weren't
remove from the undelivered_sdu_info_queue causing
indesired log entries like:
08:08:52.455280 [RLC ] [W] PDCP_SN=2103 already marked as undelivered
when the SN was sent again (after wrap around).
The patch makes sure to always try to delete the PDCP SN
from the queue. It should fix (at least partly) #2560
4 years ago
Andre Puschmann
20075f6f33
rf_uhd_generic: fix segfault when accessing device tree
...
for some reasons the dev tree isn't available on the X310
with UHD4 and the code never checked the return value, causing
a segfault with that combo.
4 years ago
Xavier Arteaga
949ce965c7
Fix SCH NR CRC check
4 years ago
Xavier Arteaga
fb5dfb3a86
Improved NR unit test
4 years ago
Xavier Arteaga
28170c92a9
Multiple NR SCH fixes
4 years ago
Xavier Arteaga
efb8da69d8
Cleaned DCI NR info string
4 years ago
Xavier Arteaga
8cb3e92ab3
Added LDPC flooded early stop
4 years ago
Xavier Arteaga
033661182a
Aded SF len macro for NR
4 years ago