5g-team
/
srsRAN_4G
mirror of https://github.com/pvnis/srsRAN_4G.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
7,354 Commits
2 Branches
0 Tags
243 MiB
fix-cqi
master
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '202c4d7566'
${ noResults }
Commit Graph

3318 Commits (202c4d7566ed7ae96a6bc6d161db95dd7c7dd09c)

Author SHA1 Message Date
Xavier Arteaga 9a320baf37 extended resource allocation for NR 4 years ago
Xavier Arteaga 766a43225d 5G FEC extension 4 years ago
Xavier Arteaga 30037d9223 Added guru softbuffer interface 4 years ago
Xavier Arteaga 8e8889032e Changed CRC input vector to constant 4 years ago
Xavier Arteaga f64c268a69 SRSUE: Refactored MAC/RRC SCell Activation/Deactivation 4 years ago
Andre Puschmann ff5f215df9 rf_soapy: print warning when using the Lime with shorter sample rates 
the Lime has better performance when using the default LTE sample
rates due to filterering being done in the LMS RF chip.

Print a warning when using the Lime with the non-default LTE rates.
 4 years ago
Andre Puschmann 2c797fce1a phy_common: add method to check whether we use default LTE symbol size 
helpful getter to check whether we've compiled in
or selected at run time to use default LTE sample rates
 4 years ago
Xavier Arteaga a6ac80cfbf Initial NR DL DCI Packing/Unpacking 4 years ago
Francisco Paisana fdec451a9d disable mcs>20 if eNB supports UL 64QAM but UE doesn't 4 years ago
Francisco Paisana bf7c587e4f add UL 64QAM support to eNB RRC and scheduler 4 years ago
Andre Puschmann 5f7f818abb pdu: fix bug in BSR table lookup 
the bug causes the BSR to return a bsr_idx of 0, i.e. no data
pending, when the buff_size was reported to be 1 B only.

Instead, the UE should return BSR idx 1, i.e. between 0 < BSR <= 10.
 4 years ago
Andre Puschmann e227fec3d8 pdu_test: add rigerous test for LBSR content 
* make sure upper and lower edges of Table 6.1.3.1-1 in 36.321 are correct
* fix existing BSR test vectors (verified with Wireshark)
 4 years ago
Andre Puschmann 286844b3dd mac_pdu: reset subheader state when deleting from PDU 
when packing MAC PDUs, adding a new SDU might fail, for example
because RLC couldn't provide a new PDU. The muxer then needs
to delete the subheader from the PDU again.

When adding a padding BSR at the end, the same subheader is again
used to store the BSR, so any state in that subheader should be removed.

In the particular case, this was causing an issue when logging a LBSR
because the LCG buffer states are printed using the payload buffer,
which was still pointing to some memory that was used when trying
to add the new RLC PDU in the beginning.
 4 years ago
Andre Puschmann 035d989737 pdu: fix unpacking of LCG2 of LBSR MAC CE 
LBSR packing is fine but this makes the eNB do wrong things
because it thinkgs LCG2 has no or too much data to send.

LCG2 is our default LCG for DRB1. One occasion we saw the issue
is doing full rate TCP DL which requires quite a bit of ACK traffic
back to the sender. With the BSR for LCG2 being wrong, providing
UL grants was delayed and so the TCP DL throuhgput was very low.

In the log below we see that the buff_size[2]=1 so there is data to send.
Interestingly, the packing was correct so Wireshark displays it correctly.
But the unpacking not, as can be seen in the MAC log below which reports
0 buffer state for all LCGs

22:08:54.804792 [MAC ] [I] [ 5084] pdu_get: sdu_len=1212, channel.sched_len=1213, bsr.buff_size[2]=1
22:08:54.804840 [MAC ] [I] [ 5084] UL LCID=3 len=1212 LBSR: b=0 0 0 0
 4 years ago
Xavier Arteaga cf55eb4c4f Improved comments 4 years ago
Xavier Arteaga e8f94c40b8 Added LDPC codeblock segmentation 4 years ago
Xavier Arteaga fc3d154fe3 Fix compilation 4 years ago
Xavier Arteaga 736e6db616 Initial resource allocation for NR 4 years ago
Xavier Arteaga 0439161de6 Removed modulation enum from LDPC RM 4 years ago
Pedro Alvarez 454162cea7 Deleted nas_interface_stack. 4 years ago
Pedro Alvarez 604e79214d Changed NAS is_attached interface to is_registered. 4 years ago
Pedro Alvarez 14844a168a Created new class to hold all NAS states for the NAS state machine. Added EMM-DEREGISTERED substates and EMM-REGISTERED substates. 
Decoupled PLMN selection, attach request and service request. Removed RRC connect procedure from NAS.
 4 years ago
Andre Puschmann 6773f6d02f pdu_queue: add reset method to empty queue 4 years ago
Francisco Paisana 88105c1577 change the namespace of tti point helper functions for the eNB 4 years ago
Andre Puschmann f155b7a5d5 rlc: fix stopping of poll retx timer (#2006) 
* rlc_am: add TC for pollRetx timer handling

* rlc_am: fix stopping of pollRetx timer

stopping the pollRetx timer when receiving a status PDU
without checking the acknowledged PDUs is wrong.

if an ACK for another PDU, for which the polling bit has been set,
is still pending, it won't be rescheduled until another
PDU is transmitted that again starts the pollRetx timer.

this fixes the issue with missing RLC AM segment retx in #1992,
and #2003
 4 years ago
Andre Puschmann 7cf919e2af Fix MAC PDU packing after sending Truncated BSR (#2004) 
* mac_test: add extended TBSR unit test

unit test to MAC UL packing after sending a TBSR

this fixes the MAC issues described in issue #2002

* mux: fix updating of LCG buffer state after packing PDU

we've previously lowered the buffer state of the LCG according
to the bytes that have been scheduled, but not according to
those that have been actually included in the PDU.

* proc_bsr: fix LCG buffer state updating for TBSR

when sending a TBSR do not update the internal buffer
state of the BSR proc.

This caused issues because the buffer state for all LCG that
are not included in the TBSR are set to zero, although at least
one LCG does have data to transmit.

* rlc_am: include LCID when logging retx of SN
 4 years ago
Andre Puschmann 1b97ba5300 benchmark_radio: fix duration and thread priority 
I noticed that the app didn't configure the process with
RT thread prio. But it then turned out that in order to do
that we need to actually spawn a new thread. Also a few other things
didn't work out of the box.

In summary the changes are:
* fix duration to support more than 120s
* move main functionality in thread
* set high priority for radio thread
* only return success if no radio errors occured
 4 years ago
Francisco Paisana 510959b50f update nr asn1 files, and asn1 tests 4 years ago
Xavier Arteaga 8d9577626b Fix NR FEC unit test 4 years ago
Xavier Arteaga 0c2f96d389 Fix 5G NR FEC memcheck 4 years ago
Xavier Arteaga 2835e87ff0 Add missing file 4 years ago
Xavier Arteaga f8dd67260f Polar: fix unit test working directory 4 years ago
Xavier Arteaga 15356b3ec8 Fix compilation for non-AVX2 machines 4 years ago
Xavier Arteaga 2c4aa1e379 Added Polar and LDPC forward error correction 4 years ago
David Rupprecht 387a84ff84 Updated missing byte 4 years ago
David Rupprecht b85cb614aa Added test cases for asn1 decoding lib from pcap 4 years ago
Xavier Arteaga 271002c9fb Fix compilation 4 years ago
Xavier Arteaga 4f89c6ed3f Added missing CMakeFiles 4 years ago
Xavier Arteaga f21590735d refactored FEC directories 4 years ago
Xavier Arteaga 7093a85f81 Refactored FEC directories 4 years ago
Xavier Arteaga c2621cc4f8 Protect ring-buffer write from nullptr 4 years ago
Francisco Paisana a865858db3 disable srbs UL during handover to avoid UL grants and scheduling requests before the handover is complete 4 years ago
Andre Puschmann f647343f18 rlc_am: fix poll bit during header reconstruction 
this makes sure that the reconstructed RLC AM header
has the poll bit set when any of its segments had it set.

this triggered a bug in RLC AM because the Status PDU
isn't transmitted for a RLC PDU that was segmented and
only the first segment had the P flag set.
 4 years ago
Francisco Paisana b40a5a958e use common function to fill rrc reconf message in handover 4 years ago
Francisco Paisana e9b693942f diff-based cell selection activation 4 years ago
Francisco Paisana 836e7d7ede refactor scell addition in the srsenb::rrc to follow the same style of other rrc recfg fields 4 years ago
Francisco Paisana f26b5ccde7 fix drb reestablishment during handover 4 years ago
Francisco Paisana 97f2e4336e refactor of functions for filling the asn1 radio resource config structs. This functions are used during rrc setup/reest/reconf 4 years ago
Xavier Arteaga 9487d27ef9 Renamed NR constants and comments 4 years ago
Xavier Arteaga e8f168b20c PDSCH NR: Added files 4 years ago
Xavier Arteaga c8477483d9 PDSCH NR: Added files 4 years ago
Xavier Arteaga 30d8e05d50 Fix PDSCH-DMRS symbol index 4 years ago
Xavier Arteaga 275cbafe6e Modified comments 4 years ago
Xavier Arteaga 8d34d344a8 Created PDSCH-NR configuration structures and refactored DMRS 4 years ago
Xavier Arteaga 009f300c5e Initial PHY Data procedures 4 years ago
Xavier Arteaga 775692f461 Rearanged PDCCH NR functions structures 4 years ago
Xavier Arteaga 452eb2dbbf Updated some DOCS 4 years ago
Xavier Arteaga 937c52339d Added PDCCH DMRS estimation and measurement 4 years ago
Xavier Arteaga 5799100e42 FFT based Resampler admits NULL inputs/outputs 4 years ago
Xavier Arteaga 44ae70dcc6 Initial implementation of the 5G NR PDCCH DMRS encoding 4 years ago
Xavier Arteaga 29ad2427d9 Initial implementation of the 5G NR PDCCH DMRS encoding 4 years ago
Xavier Arteaga 579526f1fe Added sequence advance without generating data 4 years ago
Xavier Arteaga eba20b6367 Radio: fix frame overlap at start-of-burst 4 years ago
Xavier Arteaga be400503b9 Add pass criteria to PRACH USRP test 4 years ago
Xavier Arteaga 28bb4709ff Solved possible high impact PHY out-of-bounds issues 4 years ago
Pedro Alvarez e4f143059e Simple log fix to make it easier to compare PDCP RX and TX. 4 years ago
Xavier Arteaga 58be68f856 Changed cell gain command from cell index to cell id 4 years ago
Andre Puschmann 0740154bff rrc,sync: fix two uninit vars 
detected by Valgrind when running UE with TDD cell
 4 years ago
Andre Puschmann 723ca2dd48 ra_dl: fix TDD reference symbol extraction 
reported/provided by user softdev86 in https://github.com/srsLTE/srsLTE/issues/566

author tested with local 4 port cell. I am not able to verify locally but
it looks ok, we'll revise later if needed.
 4 years ago
gracid f67a152a2a Remove unnecessary Lime calibration step from Soapy implementation 
When using srsLTE with Lime devices, calibration was performed before any configuration steps have happened, thus making calibration values invalid. Removing Lime specific calibration step from rf_soapy_imp makes so that devices will be automatically calibrated by SoapyLMS on rf_soapy_start_stream call.

Tested and working with srsENB using LimeSDR-USB v1.4 and LimeSDR-Mini v1.2 boards.
 4 years ago
gracid 78b63c9465 Set same antennas for all Soapy channels 
This commit adresses an issue where two or more channels could have different antennas, despite being explicitly set in the configuration file
 4 years ago
Francisco Paisana 4cb6ed27eb updated scheduler ue mcs computation to account for new 256QAM tables 4 years ago
Francisco Paisana c7697b62a6 fix asn1_utils_test. arrays used for equal comparison where not being initialized. 4 years ago
Xavier Arteaga fac6d40a45 SRSENB: fix PUSCH max number of iterations 4 years ago
Xavier Arteaga 791c979063 Vector: fix cf to cs conjugate conversion 4 years ago
Francisco Paisana 698af97ec4 updated asn1 utils to account for conversion from 0 to bitstring. Added asn1 utils test to repository. 4 years ago
Andre Puschmann 5e7de0a95b cmake: install individual libraries (common, phy, etc) 
this seems to be important for package maintainers
or people who use srslte components in other projects
thar require to link against static libs

so besides installing headers, the apps and the RF lib, we also
install all individual libraries

this fixes https://github.com/srsLTE/srsLTE/issues/500#
and https://github.com/softwareradiosystems/srsLTE/issues/1754
 4 years ago
faluco 8376111419 - LGTM fixes. 4 years ago
Xavier Arteaga caf37b8e62 Added serving cell index in UCI/CSI report trace 4 years ago
Douglas Anderson fe21b2717c Fix "Comparison is always true because ret >= 0" LGTM warnings 
... and refactor out some other dead code in the vacinity of these warnings
 4 years ago
Andre Puschmann 48e7734188 phy_dl_test: fix uninit var 4 years ago
Andre Puschmann 1a03839f78 rlc_am_lte: fix potential bug when setting uint32_t to -1 
discovered in Coverity CID 359664
 4 years ago
Andre Puschmann bb1dd0f4cf gnb_interface: remove FIXME 4 years ago
Francisco Paisana 665b3996bb now the phy controller handles the scenario where the phy cell selection failed to be initialized 4 years ago
Pedro Alvarez 4c1416b84f Remove redundant declaration of EIA2 4 years ago
Andre Puschmann 5a31c5765b rf_soapy: fix auto selection of Soapy device 
when the default RF args are used, NULL is passed as argument
to the RF driver. In this case, we should use the previous
SoapySDRDevice_enumerate() and let Soapy pick the device
 4 years ago
Francisco Paisana 9b10acff06 implemented logical channel prioritization in DL scheduler 4 years ago
Xavier Arteaga ca6566ad46 Fix PUCCH format1b false detection 4 years ago
Andre Puschmann fab86382c1 mac,rrc: add interface to set SR config explicitly without touching any other MAC function 
when releasing PUCCH/SRS (see 5.3.13 in 36.331) we need to reset the SR config as well.
In our case, SR is handled by MAC so we need to (re-)configure MAC, not all of
MAC though, just SR.
 4 years ago
Francisco Paisana e7239163e9 silence noisy unhandled in_sync_ev logs 4 years ago
Francisco Paisana b7ed8b1858 - added react method to to_state<...> transitions 
- s1 handover composite state simplified
- the eNB now starts a HO cancellation when it receives an invalid
Handover Command
- the FSM log now prints the current state when it receives an unhandled
event
 4 years ago
Andre Puschmann 30b8848ea9 metrics_hub: protect access to vector of metrics_listener 
prevent potential race between metrics hub thread trying
to access the metrics vector and another thread
adding another element to it
 4 years ago
Pedro Alvarez b43e724b4c Remove packing/unpacking code for M2AP. 4 years ago
Pedro Alvarez 5a4e71a6e4 Created k_enb_context structure that holds k_enb, NCC and NH to make it easier to restore context from failed handover. 4 years ago
Jan Remeš 8c7b7cc55a libsrslte_rf: add library version 
This patch adds version string to the 'libsrslte_rf' library.
This results in the library being built as
    libsrslte_rf.so.20.04.2
with the following symbolic links
    libsrslte_rf.so.0 -> libsrslte_rf.so.20.04.2
    libsrslte_rf.so -> libsrslte_rf.so.0

The SRSLTE_SOVERSION variable should be increased with each backwards
incompatible change of the library.

Signed-off-by: Jan Remes <jan.remes@invasys.com>
 4 years ago
Pedro Alvarez 00ac85e1b3 Small compilation fixes for GCC 10.1 4 years ago
Xavier Arteaga da54e2b501 Better docs in RRC interface types and apply clang-format 4 years ago
Xavier Arteaga 6ae47b6510 SRSUE: Deafult PUCCH/SRS does not imply full PHY dedicated defaults 4 years ago
yagoda 615af5cc4d setting seed to constant in prach test 4 years ago
Andre Puschmann b08a586fd4 pdu: refactor error logging 
just some refactoring of error messages when a PDU packing error occurs
 4 years ago
faluco 693d2f10b7 - Fix hex dumps newlines. 4 years ago
Pedro Alvarez 2f0125ef4e Fix issue recovering key state, when the first HO fails (specifically, is_first_ncc was not recovered). Minor improvements in key logging. 4 years ago
Francisco Paisana 137e554eb3 reestablish pdcp bearers is required in case of AM bearers 4 years ago
faluco 079ae70e64 - Fix logs entries having two newlines instead of one. The old log formatter will delegate this to the new one. 4 years ago
Andre Puschmann f73fa47a7b pdu: fix printing of buffer state of long BSR 
extracted wrong number of bits for 2nd LCID in long BSR
 4 years ago
Xavier Arteaga ef9d77c966 SRSUE: add PRACH config present field in PHY configuration structure 4 years ago
faluco 51b27fc255
Import latest srslog version (#1796) 
* - Import latest srslog version.
- Adjusted the nas_test to create logs correctly.
- Remove timestamp formatting now that is provided by srslog.
 4 years ago
Ismael Gomez 4e88daae21
Set DCI unpacking errors to info (#1781) 4 years ago
faluco 85544bb8d3 - Remove unnecessary newline character and optimize the code to use fputs instead of fprintf since no formatting is required. 4 years ago
faluco dfeed52514 - Rename out_stream function to console. 4 years ago
faluco 62faef7c71 - Replaced all uses of the log::console method. 4 years ago
faluco 302f9793ca - Add common utils to print to stdout and stderr as a first step to remove the log::console method. 4 years ago
Andre Puschmann 58ce9d3959 pdcp: adding basic test to check if control PDUs are handled correctly 
use a 3 B long status PDU to check if its dropped from the rx'ing entity
 4 years ago
Andre Puschmann 795db30338 pdcp: drop PDCP control PDUs 
this patch adds a check to drop all PDCP control PDUs
in order to prevent handling them as data PDUs.

This could happen when the size exceeded the arbitrary length check.

This should fix #1787
 4 years ago
Sylvain Munaut 2890bd07ea liblte_mme.h: Adjust LIBLTE_MME_PACKET_FILTER_MAX_SIZE for IPv6 
Original was 20 but TS 24.008, section 10.5.6.12 specifies a max
of 60 for ipv6 packet filter
 4 years ago
Xavier Arteaga d375e305ec Initial NR DMRS for PDSCH 4 years ago
Ismael Gomez 76bfc78147
Fix issues with Sounding-RS (#1761) 
* Fix deadlock caused by update_measurements calling in_sync

* Fix overlapping SRS condition

* Do not use shortened PUSCH in transmissions and retx from RAR

* Revert "Fix deadlock caused by update_measurements calling in_sync"

This reverts commit f58c8c8c766f8f95baa3a3bf8287d8e25b2057ba.
 4 years ago
Pedro Alvarez 86f4d469c6 Added some functions to save and restore AS keys for the case of failed handover in the USIM 4 years ago
Ismael Gomez b94d24ed98
Take into account CRS from neigbhour cells when measuring interference (#1757) 
* Take into account CRS from neigbhour cells when measuring interference

* fix std::isnormal compilation

* Fixed compilation of test

* Address comments

* Remove unused overrides
 4 years ago
Xavier Arteaga 236ef4378d Fix u32 parsing 4 years ago
Xavier Arteaga ede58319ae Vector: added conjugate complex float to short 4 years ago
Xavier Arteaga 8566cbb079 Added device name to prach_test_usrp 4 years ago
Xavier Arteaga 60d563aa06 Fix ringbuffer read conversion 4 years ago
Xavier Arteaga eb5210dbda Radio stops Rx stream prior to stop and benchmark prompts RF metrics 4 years ago
Xavier Arteaga de0501cc55 Fix radio benchmark 4 years ago
Xavier Arteaga c20d4ff5cc Added ringbuffer zerocopy a timeout 4 years ago
Xavier Arteaga 759719ad55 Improved RF helper 4 years ago
Andre Puschmann 1afc137032
[REBASE] Make PHY non-blocking and fefactor HO procedure (#1753) 
* Make PHY non-blocking and fefactor HO procedure

* makes entire PHY non-blocking through command interface
* adds dedicated queue for cell_search/cell_select commands
* refactor HO procedure to run faster, in one stack cycle. Looks closer to the specs
* force ue to always apply SIB2 configuration during reestablishment
* Run update_measurements in all workers

Co-authored-by: Ismael Gomez <ismagom@gmail.com>
 4 years ago
faluco c1e680769c - Remove stray code left behind. 4 years ago
faluco f604506858 - Fixed missing initialization issues in nas that caused several jumps in liblte_mme to use uninitialized memory. 
- Fixed missing initialization in spgw that caused recvfrom to use an unitialized argument.
 4 years ago
faluco f0d651ae8e - Fixed a leak in the MME class not releasing the static byte buffer pool. 
- Now the pool gets destroyed on program exit using a unique_ptr.
- Removed manual cleanup() calls in all the code base to free the pool instance.
 4 years ago
Francisco Paisana dcf5a727f2 do not send RRC release in case the eNB receives a S1AP UEContextRelease command and the UE is doing handover. Handle GTPU end marker 4 years ago
faluco b892da0294 - Calculate the FFT of the PRACH on demand. 
- Fixed a PRACH test that was failing with ASAN.
 4 years ago
Xavier Arteaga 8cb3945886 SRSUE: fix RV assertion for PUSCH 4 years ago
Xavier Arteaga 44c2412be2 SRSUE: silent PUSCH encoding error by dropping invalid grant 4 years ago
Andre Puschmann 9dd02af15c network_utils: lower verbosity of when socket connection fails 
the network helper can log this event but it should be up to
the caller to decide whether this is an error or not.
 4 years ago
Andre Puschmann 6dc7841369 epoll_helper: move code to block OS signals into own helper function 
before epoll can handle signals, the calling thread needs to block
them. the blocking needs to happen before any other threads get
spawned so they inherit the mask.
 4 years ago
Andre Puschmann 33c050791f pdu: add missing to_string() content for MAC SCH PDU subheaders 
* add both scell activation CE
* add rnti to CRNTI and CONT RES CE
 4 years ago
Xavier Arteaga 1d71cf8557 Avoid zero division 4 years ago
faluco 5e8a4c898d
Bring back the circular array object. (#1712) 4 years ago
Andre Puschmann 6a56476b2a rlc: increase RLC Tx SDU queue 
the Tx SDU has been set to 128 PDUs because this gives approx.
150kByte UL buffer state (max value for Rel 8 BSR).

Previously, however, we've always reported too much pending UL
data because we weren't subtracting the transmitted data from
the reported data.

with this newer BSR reporting, however, even with full buffers we would
never report full buffers because the queues size is too short.

This seems to cause issues for iperf TCP sessions not resulting
in full DL rate, see isse #1703. It seems that the TCP bandwitdh
probing works better with larger buffers (in our case this can
only be achieved with more PDUs in the pool).

This should fix #1703
 4 years ago
Andre Puschmann 569d8ee860 rlc: remove unused macro 
this seems to be a legacy copy of the RLC_TX_QUEUE_LEN macro
in rlc_interfaces_types.h
 4 years ago
faluco 1860006203 - Fixed leaks in prach module spotted by asan. 4 years ago
Andre Puschmann e80aa0a553 add circular array class to simplify access to truly circular arrays 4 years ago
yagoda 24574caf44 cleaning up the PRACH time offset calculation 4 years ago
yagoda b5a8d82058 -adding more prach tests to make test, removing some variables from stack 
-PRACH time offset to TA unit conversion
 4 years ago
yagoda 59082770d3 moving some arrays to the heap, fixing formatting, setting dft norm 4 years ago
yagoda f6ea431555 -adopting new PRACH equalization approach for successive cancellation 
-adding frequency domain time offset detection
-adding to testing of PRACH
 4 years ago
yagoda ec7873e7cc refactoring PRACH, adding phase correction to successive cancellation 4 years ago
yagoda 4d8888aae6 - adding simple successive cancellation to PRACH detection 
- adding testing for same and for offset detection
 4 years ago
Ismael Gomez 1bd3e76f98 Move unncessary buffer in radio 4 years ago
Ismael Gomez c4080e35cc Set different timestamp behaviour for X300 and B200 4 years ago
Pedro Alvarez 08a0d6bc0a Fix compilation warning with unecessary comparison. 4 years ago
Ismael Gomez f49fbd6d02
Fix the order of HO/reest measurement actions (#1696) 4 years ago
Andre Puschmann d48bc8837e pdu: refactor MAC PDU class 
this patch refactors the MAC PDU class, the main changes are:

* add to_string() method to pretty print PDU and subheaders
  This allows to have a single log entry per MAC PDU with all its
  contents.
  It removes the C-style fprint() method

* Simplity payload vs. w_payload_ce
  Before we've used payload when reading the PDU and w_payload_ce
  as a buffer when writing. In all getters we needed to differentiate
  between both. Now payload points to w_payload_ce initially and is
  only updated when parsing a new PDU.

* add various helpers, e.g. to get subheader index, update a BSR, ..

* fix PDU test to use new to_string() method
 4 years ago
Ismael Gomez 54eed11e1d Refactor decision for extended CSI/SRS 4 years ago
Ismael Gomez c9daf1f61a Make const args 4 years ago
Ismael Gomez e2154d2213 Renamed constants to SRSLTE and use SRSLTE_CFI macros 4 years ago
Ismael Gomez 38e2ffe414 Use Format1A when using CA and 15 PRB due to DCI size ambiguity 4 years ago
Ismael Gomez 51521ad8e4 Improved PDCCH blind search and fixed a few issues with ambiguous DCI size with Release 10 4 years ago
faluco db03275337 - Fix compiler errors when trying to build the project without SIMD support. 4 years ago
faluco 12e82a947f
LTO compiler and linker fixes (#1676) 
* Guard the LTO feature in a CMAKE option and document possible issues of using it.
 4 years ago
Xavier Arteaga af8898943f SRSENB: implement console cell_gain command 
SRSENB: fix 5GNR compilation

SRSENB: fix override methods
 4 years ago
Xavier Arteaga 1f18e8a054 SIMD: frequency estimate optimization 4 years ago
Xavier Arteaga bf1b7b8527 SIMD: fix NEON compilation 4 years ago
Ismael Gomez 0afcea9d61
Do not allow empty TBS PUSCH. Account for CQI from inactive cells before activated. (#1667) 4 years ago
Francisco Paisana 92221eb780 update of rrc_interface_mac to remove signal from mac to rrc that RA failed in case of handover failure 4 years ago
Xavier Arteaga 080543815f Solved compilation warnings and enb_phy_test stop 4 years ago
Xavier Arteaga b8f4d03979 Fix in SIMD frequency estimation 4 years ago
Xavier Arteaga 611dd67364 SRSENB: PUCCH TA measurement only available with detected PUCCH 4 years ago
Xavier Arteaga 87edafeddb Reduced SRS test cases to SF index 0 4 years ago
Xavier Arteaga ee6f24befe Optimize vector frequency estimation 4 years ago
Xavier Arteaga bc0aba0d8a SRSENB: calculate TA from PUCCH messages 4 years ago
Andre Puschmann 49a7a90698 mac: simplify BSR packing logic 
simplify logic to check whether a BSR fits and, if so, which type.
before the check has been done in two places.

we now also accomodate for the CE subheader size.
 4 years ago
Andre Puschmann 96c911752c pdu: add test case for issue #1649 
testcase checks the correct handling of the remaining PDU space
when a long BSR is added but no space is left in PDU to fit it
 4 years ago
Xavier Arteaga 1843c9efbc SRSENB: PUCCH TA measurement only available with detected PUCCH 4 years ago
Xavier Arteaga 3aec23f7d8 SRSENB: calculate TA from PUCCH messages 4 years ago
Xavier Arteaga df2c949417 Radio: add individual Rx gain and integrate in srsue 
Fix compilation

Fix compilation

Add missing variable. Wasn't compiling

Radio: revert some changes
 4 years ago
Xavier Arteaga 04d7267734 UHD: Force LO frequency option 4 years ago
Xavier Arteaga b3d66c98c3 SRSENB: tx gain per channel and fix bug 4 years ago
Andre Puschmann 3f02e56a1e uhd: do not stop rx_stream when setting rx_rate for the B210 
with the B210 and 2 RF ports, i.e. MIMO mode, we have stopped the
Rx stream after changing the rx_samp_rate but didn't start it again.

Either the issue doesn't exist in SISO mode or we never saw it but for MIMO
it can be reproduced easily with rate changes during streaming, i.e.:

$ ./lib/src/radio/test/benchmark_radio -p 2 -t 10 -x -y -s 23.04e6
Instantiating objects and allocating memory...
Initialising instances...
Opening 2 channels in RF device= with args=default
[INFO] [UHD] linux; GNU C++ version 9.2.1 20200304; Boost_107100; UHD_3.15.0.0-2build5
[INFO] [LOGGING] Fastpath logging disabled at runtime.
Opening USRP channels=2, args: type=b200,master_clock_rate=23.04e6
[INFO] [B200] Detected Device: B210
[INFO] [B200] Operating over USB 3.
[INFO] [B200] Initialize CODEC control...
[INFO] [B200] Initialize Radio control...
[INFO] [B200] Performing register loopback test...
[INFO] [B200] Register loopback test passed
[INFO] [B200] Performing register loopback test...
[INFO] [B200] Register loopback test passed
[INFO] [B200] Asking for clock rate 23.040000 MHz...
[INFO] [B200] Actually got clock rate 23.040000 MHz.
[INFO] [MULTI_USRP]     1) catch time transition at pps edge
[INFO] [MULTI_USRP]     2) set times next pps (synchronously)

Warning: TX gain was not set. Using open-loop power control (not working properly)

Setting manual TX/RX offset to 0 samples
Start capturing 10000 frames of 23040 samples...
Changing sampling rate to 23.04 Msamps/s
Setting manual TX/RX offset to 0 samples
Changing sampling rate to 1.92 Msamps/s
Setting manual TX/RX offset to 0 samples
/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1211: Error timed out while receiving samples from UHD.

/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1211: Error timed out while receiving samples from UHD.

/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1211: Error timed out while receiving samples from UHD.

/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1211: Error timed out while receiving samples from UHD.

/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1211: Error timed out while receiving samples from UHD.
 4 years ago
Andre Puschmann 7253efe17e rf_blade: fix memleak when device wasn't found 4 years ago
Andre Puschmann 9684b2a63a uhd: fix memleak when USRP wasn't found 4 years ago
Andre Puschmann c327a18f59 radio: fix memleak of dummy buffers 4 years ago
Ismael Gomez 59b9125d4e
Do not send time_spec in between the burst. X300 does not like it (#1583) 4 years ago
Ismael Gomez a4835dd2c8
More accurate MCS reduction when PUSCH carries UCI (#1630) 4 years ago
Xavier Arteaga bd46c40650 srsLTE: fix minor aesthetics 4 years ago
Xavier Arteaga 7bad21c30a Radio: added locks to protect sample rate change concurrent access 4 years ago
Xavier Arteaga 029f36b449 srsLTE: added efficient integer resampler and srsue/srsenb integration 4 years ago
Francisco Paisana 834c0b3929 integrated new observer pattern into phy controller fsm 4 years ago
Francisco Paisana 48dd436d86 integrated observer pattern into rrc phy ctrl fsm 4 years ago
Francisco Paisana b2313e3631 observer pattern classes. Allows auto and explicit dispatch, and specifying which trigger method to use of an observer. 4 years ago
Xavier Arteaga 0e96ef3df0 Channel emulator takes SNR as input parameter 4 years ago
Andre Puschmann 9149cf852d rf_uhd: fix rx timeout error after late with B210 
it fixes #1623.

this happens more often with MIMO since lates are more likely here.

after a late, the Rx stream must not be stopped on the B2xx either.

<log>
RF status: O=3, U=0, L=1
/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1209: Error timed out while receiving samples from UHD.

stop rx stream
./home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1209: Error timed out while receiving samples from UHD.

stop rx stream
/home/anpu/src/srsLTE/lib/src/phy/ue/ue_sync.c.775: Error receiving samples

/home/anpu/src/srsLTE/lib/src/phy/ue/ue_cell_search.c.312: Error calling srslte_ue_sync_work()

/home/anpu/src/srsLTE/lib/src/phy/ue/ue_cell_search.c.272: Error searching cell
</log>
 4 years ago
Andre Puschmann 5e40bfe72c mac_pdu: unpack and print BSR index as well as BSR value in bytes 
before the BSR was extracted but the actual index (between 0 and 63)
was not stored but directly converted into bytes.

for log parsing and debugging it is easier to follow the index
value. this patch therefore adds both values to the log message
and extends the API accordingly.
 4 years ago
Andre Puschmann 55336665b9 rlc: remove timers and sdu queue length from RLC TM ctor 
timers aren't used in RLC TM, also the default queue length is
fine to be used at all times.
 4 years ago
Francisco Paisana bb5dd92dca implemented s1 handover cancellation procedure to force the target enb to release the ue ctxt 4 years ago
Francisco Paisana 8c9e596f89 refactored s1ap handover request interface. cleaned up rrc tenb s1 handover code 4 years ago
Andre Puschmann 8e44d0504c radio: fix device mapping for mimo 
commit #51c6e8d1 introduced a regression in which the 2nd antenna
port was never considered. All MIMO ZMQ based tests therefore failed.
this fixes #1608
 4 years ago
Xavier Arteaga 710700d0eb SRSUE: Fix synch error correction for multiple channels 4 years ago
Andre Puschmann d5da4bd8b6 radio: fix printf for 32bit 4 years ago
Francisco Paisana 7cd4f45d62 fsm refactor. 
- avoid triggering directly a subfsm
- improved metafunctions
- other cleanups
 4 years ago
Francisco Paisana 5d1343fe75 implemented S1 bearer status transfer 4 years ago
Francisco Paisana db8af399f8 extended rrc tenb s1 handover test. implemented layer reconfig during s1 handover 4 years ago
Francisco Paisana 7605c7df23 added s1ap handover notification, fixed s1ap asn1 bug, and fixed bad fields for admitted erabs in ho req ack 4 years ago
Francisco Paisana 841b884796 remove extern C flags from common_helper.h 4 years ago
Francisco Paisana a2b8bc9e0a check all cpus scaling governor 4 years ago
Francisco Paisana 5be5409f62 scaling governor function moved to common header file 4 years ago
Francisco Paisana 9146e6ddf1 change method name to resize intervals 4 years ago
Francisco Paisana 4457bbda7e added new asserts to interval interface 4 years ago
Francisco Paisana 8b174ce2f4 changed interval interface to disallow interval::stop < interval::start via an assertion 4 years ago
Francisco Paisana 39b380c8e0 fix compilation issue for gcc version < 5 4 years ago
Francisco Paisana 2f689372dd added missing header 4 years ago
Francisco Paisana c1755727d7 changed interval method names, and added comments and assertions 4 years ago
Francisco Paisana b2dd46ccad remove extra space in to_string 4 years ago
Francisco Paisana 20b69fb22e substitution of ul_alloc_t for prb_interval 4 years ago
Francisco Paisana 26f46ea067 add S1 Handover Request handling in target eNB 4 years ago
Francisco Paisana 857cc141c7 fix macro checking for exceptions, added missing includes, fixed bounded bitset methods' noexcept specifiers 4 years ago
Francisco Paisana cceeff10de moved expected, bounded_bitset, move_callback to adt folder. created a test for bitset 4 years ago
Francisco Paisana caf862c99f moved expected, bounded_bitset, move_callback to adt folder. created a test for bitset 4 years ago
Ismael Gomez 382811e10e
Update S1AP RNTI context when doing Reestablishment (#1582) 4 years ago
faluco 1253740da3 - Extracted traits from class to a detail namespace. 4 years ago
faluco 072e84cec8 - Simplified the usage of span now with implicit constructors as it should be. 
- Added overload for generic containers that have size and data members like vector.
- Removed unnecessary uses of make_span.
 4 years ago
faluco 158edd4fe7 Removed init list constructor test. 4 years ago
faluco eb4b2d4e43 - Added a clarification comment on why to use make_span. 
- Moved byte_buffer utilities to common.h thus breaking the dependency of ADT to COMMON.
- Fixed compilation failures in tests.
 4 years ago
faluco af8dfcf19c Extended a bit the span implementation with the following changes: 
- Documented methods and class.
- Adapted interface to the latest standard: no init list and generic container constructors, new iterator pair ctor.
- Implemented some SFINAE for managing conversions in constructors.
- Re-organised some methods to be grouped by category (modifiers, observers, iterators, ...).
- Added convenience make_span functions.
- Added some more  asserts.
- Adapted test to use some syntax that was modified.
 4 years ago
Francisco Paisana 76a62909c1 use of span type for universal array views 4 years ago
Francisco Paisana a9d882c1f1 fix task_scheduler_test. Fix potential reference invalidation in task_scheduler internal tasks data structure 4 years ago
Francisco Paisana 9d877e55b3 add test for when scope exit lambda is an lvalue 4 years ago
faluco 9e2a116e11 - Fix a missing template parameter in the constructor. 
- Decay the type to the template.
- Switched member order to improve memory layout.
 4 years ago
Francisco Paisana 0f67bee556 creation of a scope exit standalone file. Created a new folder ADT. Added test for scope exit. 4 years ago
Andre Puschmann cb2d7f4c16 rf_uhd_generic: add explicit ctor and dtor 
clang 6 complained about a missing virtual dtor and thus
failed compilation. this patch adds both, an explicit ctor and dtor.
 4 years ago
Andre Puschmann 498af989bf rf_uhd: add missing endl to UHD log macros 4 years ago
Xavier Arteaga 46ab07123d UHD: fix compatibility with 3.9.7 LTS 4 years ago
Andre Puschmann 5867668c0c rf_uhd_rfnoc: fix compilation for UHD before 3.15 
the enable_rx_timestamps() for the radio_ctrl object has only been
introduced in Nov 2019 for UHD 3.15 and therefore needs
to be excluded when compiling for 3.14 and below.

Note: According to the original UHD commit in
67dbaa41f2 (diff-60a9387c0fc8406fd5b39fa995dd8c14)
it looks like the Rx timestamps are disabled by default
for UHD versions before 3.15

This commit fixes #1602
 4 years ago
Xavier Arteaga 0cd61145ca RFNOC: added optional FPGA FIFO 4 years ago
Xavier Arteaga 237de07ab3 UHD: disable AD936x based device reset 4 years ago
Xavier Arteaga ff8925b6ec UHD: use same timeout policy than previous release 4 years ago
Xavier Arteaga ac76a398fe UHD: Minor stability improvement 4 years ago
Xavier Arteaga d2abaaf719 UHD: add initial test for AD936x based devices during initialization 4 years ago
Xavier Arteaga f80c779d88 RFNOC: added DUC/DDC internal loopback option and test 4 years ago
Xavier Arteaga dcf05f7a53 UHD: Improved RFNOC 4 years ago
Xavier Arteaga 38d9545e99 UHD: API improvement 4 years ago
Xavier Arteaga 405e0c8195 UHD: Check if tree exist before requesting access 4 years ago
Xavier Arteaga 5d43fc903e UHD: fix SPP equal 0 4 years ago
Xavier Arteaga 774c0926a6 UHD: added device args for log level, spp and return if timeout 4 years ago
Xavier Arteaga 88a1ab12c5 UHD: Generic detects if it a AD9361, USB based device and resets if LIBUSB_TRANSFER_ERROR is detected 4 years ago
Xavier Arteaga 04a661d239 UHD: RFNOC class detects custom DDC and DUC 4 years ago
Xavier Arteaga 180fb42dc3 UHD: minor aesthetic corrections 4 years ago
Xavier Arteaga 0f24d510ac UHD: Fix RFNOC DDC frequency calculator 4 years ago
Xavier Arteaga ebf995c621 UHD: better RFNOC detection and configuration 4 years ago
Xavier Arteaga 0e360b3953 UHD: RFNOC Dynamic re-configuration 4 years ago
Xavier Arteaga d9cb51d261 UHD: Added custom DDC/DUC support 
UHD: Aesthetic corrections

UHD: minor aesthetic changes
 4 years ago
Xavier Arteaga e4a794fdbd UHD: Initial RFNOC implementation 
UHD: Fix RFNOC for multiple carriers
 4 years ago
faluco cfd3f51931
Import of srslog into srsepc and srsenb. (#1574) 
* - Import of srslog into srsepc and srsenb.
* - Removed logger_file and logger_stdout files.
 4 years ago
Xavier Arteaga 21e9a3958f Minor changes 4 years ago
Xavier Arteaga 2271aec6b2 Radio: remove trace 4 years ago
Xavier Arteaga a5fefbfdd3 Radio: fix possible overflow 4 years ago
Xavier Arteaga 51c6e8d1a6 Radio: channel map includes device mapping, unmapped Rx uses dummy buffers 4 years ago
Xavier Arteaga 74fde5597f PDSCH_UE: added synchronization error to console 4 years ago
Xavier Arteaga edda1f730a srsLTE: Placeholder Band correction 4 years ago
Xavier Arteaga d8eaa99132 Radio: do not use more radios than necessary 4 years ago
Xavier Arteaga 5258f27490 Fix start-of_burst for PRACH Test USRP 4 years ago
Ismael Gomez dda91b14f7 Remove duplicate add_rnti() function since already done in set_config 4 years ago
Xavier Arteaga fda1d040e7 SRSENB: implement PUSCH threshold for UCI bits 4 years ago
faluco efdff8ba4c
Import srslog into srsue (#1556) 
- Import the srslog project into srslte.
- Ported srsue app to use the new logging framework.
- Implemented a wrapper that dispatches log entries to srslog.
- Renamed an existing log test to be more specific to avoid name clashes.
 4 years ago
Andre Puschmann d441486f76 fading: fix heap buffer overflow in fading sim 
at the when applying the fading channel we copied the state back
to our buffer. Since we are offsetting the read buffer
by X samples, we need to make sure that we don't read after then
(len-X) samples of the temporary memory buffer
 4 years ago
Andre Puschmann 1199a79851 fix Scell sync for large cells 
the PSS detection needs more temporary buffer than a full subframe.
we therefore need to allocate and initialize the sync object with
larger maximum size to support Scell search of large cells, e.g.
20 MHz

this fixes issue #1538
 4 years ago
Ismael Gomez f380f46a10 Revert "Remove unnecessary zero memory (#1564)" 
This reverts commit f662aeaff3.
 4 years ago
Andre Puschmann 9550bd3ef8 rlc: revisit interface for MAC and RRC 
* add locked and unlocked version of has_data() since one is
  called from stack and one from PHY threads

* add comments in each interface section as to why locking
  is required or not

* remove RLC rwlock when not required

* move calls only used by RRC to RRC section
 4 years ago
Andre Puschmann 7f98cb9b62 pdcp: log discard timer duration in init() 
to log the configured discard timer length
 4 years ago
Andre Puschmann a578ff1975 pdcp: fix typo 4 years ago
Francisco Paisana 58c4bcf288 reduce mcs for UL grants carrying UCI 4 years ago
Ismael Gomez f662aeaff3
Remove unnecessary zero memory (#1564) 
* RF drivers to allow nullptr buffers in send/recv

* Remove zeromem from radio

* remove unused buffers
 4 years ago
Andre Puschmann dc67d28709 nas: do not generate NAS encryption key if also is set to NULL 
its more a cosmetic change to clean the logs. this makes
sure that a zero key is logged when NULL encryption is selected.
 4 years ago
Ismael Gomez 1eaf7efab0 Fix UL adaptive retx rv index 4 years ago
Xavier Arteaga 5cf2089a8c srsLTE: increased SRS test TA us threshold 4 years ago
Xavier Arteaga 794f969e1a srsLTE: fix TA calculation 4 years ago
Xavier Arteaga 729986f259 srsLTE: Added PUCCH format 3 valid correlation 4 years ago
Xavier Arteaga 0192130742 SRSUE/SRSENB: UCI bits are carrier by the lowest serving cell index 
SRSENB: Fix UCI in lowest serving cell index PUSCH transmission
 4 years ago
Andre Puschmann c8b4ba885b rename rlc_tx_queue to byte_buffer_queue 
this data structure will be used by the PDCP layer as well.
 4 years ago
Francisco Paisana 36fc88d2e2 fsm log macros, and utility methods to convert event callbacks to move tasks 4 years ago
Francisco Paisana 9c5471b094 more ergonomic event callback 4 years ago
Francisco Paisana d48a45976e moved cell selection/search complete event signalling out of phy_controller 4 years ago
Francisco Paisana 489969722e implemented phy controller FSM to perform cell selection & search. The controller also tracks the phy sync state 4 years ago
Andre Puschmann 6fb01d61a7 rlc: change remaining occurances of "SN: " to "SN=" 
streamline all RLC AM and UM for better log analysis
 4 years ago
Xavier Arteaga 137d250d66 srsLTE: fix ZMQ decimation pointer 4 years ago
Andre Puschmann a7911f0dab pdcp,rlc: refactor SDU queueing policy 
this patch refactors the SDU queuing and dropping policy of the RLC and PDCP layer.
the previous design had issues when packets have been generated at a higher
rate above the PDCP than they could be consumed below the RLC.

When the RLC SDU queues were full, we allowed two policies, one to block on the write
and the other to drop the SDU. Both options are not ideal because they either
lead to a blocking stack thread or to lost PDCP PDUs.

To avoid this, this patch makes the following changes:

* PDCP monitors RLC's SDU queue and drops packets on its north-bound SAP if queues are full
  * a new method sdu_queue_is_full() has been added to the RLC interface for PDCP
* remove blocking write from pdcp and rlc write_sdu() interface
  * all writes into queues need to be non-blocking
  * if Tx queues are overflowing, SDUs are dropped above PDCP, not RLC
* log warning if RLC still needs to drop SDUs
  * this case should be avoided with the monitoring mechanism
 4 years ago
Andre Puschmann 7a66a00e15 block_queue: add method to check if given queue is full 4 years ago
Xavier Arteaga f39abe0094 SRSENB: fix MAC pending PHY config 4 years ago
Francisco Paisana 5e06430455 removal of stack handler interface 4 years ago
Francisco Paisana 7c364070ee creation of task scheduler interface for classes/functions running outside the main control thread 4 years ago
Francisco Paisana 039977aeb5 renamed interfaces 4 years ago
Francisco Paisana 1a9c04bf2f use of task scheduler handle in pdcp 4 years ago
Francisco Paisana e9f34c7613 using task scheduler in enb stack 4 years ago
Francisco Paisana 4f5e65781f created task scheduler class to deal with timers, thread pool, multiqueue, internal tasks 4 years ago
Pedro Alvarez 89b6e0f714 Send paging message to all cells. 4 years ago
Francisco Paisana fe8f8be62d apply separate cqi configurations to scells 4 years ago
Andre Puschmann d5f0ad9f35 pdcp: fix typo 4 years ago
Andre Puschmann 2749c870e3 rlc_am: refactor control test 
* move both tests into own functions and call those in main()
* use common test header and macros
 4 years ago
Andre Puschmann 035c369a43 mac_pdu: fix check of remaining length when adding new subheader to MAC PDU 
when adding a new subheader to a MAC PDU we should only add the subheader
if at least 2 bytes are left in the PDU. Even a 1 Byte MAC Control Element requires
another byte to pack the subheader.

This fixes #1424 in which a 3 B MAC opportunity is provided in the UL. After
adding the Short BSR, we tried to add another MAC subheader. Adding the subheader
succeeded even though no space is left to add a single byte. With this patch,
adding the subheader fails and the generates MAC PDU is correct.
 4 years ago
Andre Puschmann 58e255cb63 pdu_test: add unit test to verify correct packing of 3B PDU with Short BSR 4 years ago
Andre Puschmann 5589816690 pdu_test: fix PCAP output 
API now requires to pass CC index
 4 years ago
Andre Puschmann f6d3467884 ringbuffer: fix timeout calculation for timed read 
with ZMQ RF, we've seen the radio returning -1 and traced
the issue down to the ringbuffer.
in fact, pthread_cond_timedwait() returned 22 (EINVAL) indicating
a wrong timeout value. The issue was likely an overflow
in the timespec parameter. This patch checks for the return
value of pthread_cond_timedwait() and also calculates the
nanosecond wrap around for the timespec
 4 years ago
Andre Puschmann aed38a6028 rf_zmq: increase default ZMQ timeout to 2s 
amarisoft flags an RF error and exits after not receiving samples
for the radio. Running with ZMQ in the RFCI, the UE sometimes needs more
time to start up due to slow processing and no fftw wisdom file and
then Amarisoft eNB times out. This gives the whole process a little
bit more time. Should we still find it too short we may increase
it further.
 4 years ago
Andre Puschmann b3e92883d4 rlc_um: reduce log level when provided space is not enough to build PDU 
this is not a warning case as it can always happen. reduce level to info therefore.
 4 years ago
Andre Puschmann 95f5093432 rlc_am: hold lock while handling new PDUs 
This lock was removed in 1cbf7eac because it was considered unneeded.
However, as can be seen in issue #1503, we need to protect the access
to rx_window, for example.

Issue #1503 shows a stack trace where a PHY worker generates a status PDU.
While holding the mutex to access rx_window, the stack thread on the
other hand, happily accesses the rx_window member without acquiring
the lock. This commit protects all handle_*() functions in write_pdu().

This reverts commit 1cbf7eac04.
 4 years ago
Francisco Paisana e550bf726d updated fsm to allow enter methods to receive event that caused them 4 years ago
Andre Puschmann 6f5da19312 pdcp: similar to tx, also reduce log for Rx 
instead of logging PDU received from below, and SDU that is forwarded
to above, only log the PDU in rx in info mode.

The next layer will do the same and log the PDU received (which is the SDU coming from here)
so there is now loss of information in the logs.
 4 years ago
Andre Puschmann 6654453e22 pdcp: reduce amount of log messages during tx 
drop logging encrypted PDU seperately. Instead, only log formatted
PDCP PDU before passing to lower layers
 4 years ago
Xavier Arteaga 6f03ce7e11 srsLTE: minor radio fix 4 years ago
Xavier Arteaga 67543a73bb Radio: fix erroneous offset 4 years ago
Xavier Arteaga 8966db31d8 srsLTE: Radio benchmark plots all ports 4 years ago
Andre Puschmann ff96336f91 rlc_um: fix reestablishment for sending UM entity 
we've reset the rx state variables during reestablishment but not
the tx state variable.
 4 years ago
Francisco Paisana 84f34bc736 changed to a label filtering approach for ctest 4 years ago
Francisco Paisana ebb8f18000 set some extra tests with the prefix "long_" 4 years ago
Francisco Paisana c6323478d2 remove unecessary sleeps in mac test, and add long_ prefix in long tests 4 years ago
Andre Puschmann eb56efe9f5 rlc_am_lte: turn error message into warning and print state variables 
the issue doesn't cause any unrecoverable situation so its not
appropiate to use the error level
 4 years ago
Francisco Paisana cb7f620254 created separate class to manage bearers buffers/status reports in the scheduler 4 years ago
Andre Puschmann a3d7d4517c rlc_um: add dedicated unit test for the PDU packing bug 
Here is the test output with the fix disabled:

13:47:42.679774 [RLC_UM_1] [D] MAC opportunity - 14 bytes
13:47:42.679784 [RLC_UM_1] [D] pdu_space=14, head_len=2
13:47:42.679790 [RLC_UM_1] [D]  adding new SDU segment - 10 bytes of 10 remaining
13:47:42.679834 [RLC_UM_1] [D]  Complete SDU scheduled for tx. Stack latency: 0 us
13:47:42.679909 [RLC_UM_1] [D] pdu_space=4, head_len=2
13:47:42.679922 [RLC_UM_1] [D]  adding new SDU segment - 0 bytes of 10 remaining
13:47:42.679928 [RLC_UM_1] [I]  Tx PDU SN=0 (14 B)
13:47:42.679974 [RLC_UM_1] [D]  vt_us = 1

The test checks the correct packing and of the two PDUs at the end.
 4 years ago
Andre Puschmann df50dd7d3c rlc: extend RLC metrics 
extend RLC metrics to count Rx/Tx PDUs/SDUs bytes/#
 4 years ago
Andre Puschmann 48db31c5cf rlc_stress_test: fix random PDU dropping 
the rand() was sometimes giving NaN so this case needs to be handled
and the PDU not dropped to have real zero drop-rate
 4 years ago
Andre Puschmann 82f811ed52 rlc_am: change return value when writing SDU 
return false when SDU couldn't be added to SDU tx queue so
to count dropped SDUs in base
 4 years ago
Andre Puschmann 3cef20607e rlc_am: fix bug in returning zero len bytes 4 years ago
Andre Puschmann 86025cf390 rlc_um: fix PDU packing when newly added SDU segment was too large 
during the PDU packing it could happen that a new SDU segment
was added but the resulting larger header was so big that not even
a single byte of the new PDU could be added. because this
corner case wasn't handled correctly an invalid PDU was transmitted.

the solution is to revert the addition of the new SDU.
 4 years ago
Andre Puschmann fc3cd24177 rlc_um: fix counting of lost PDUs 
* change try_push() return value to indicate whether the addition
  of the SDU to the tx queue was successful or not
* count lost PDUs
 4 years ago
Andre Puschmann 96726a03e0 rlc_stress_test: fix PCAP support 
expose actual RLC configuration to PCAP object
 4 years ago
Andre Puschmann 1c7bfde404 rlc_stress_test: fix compilation with PCAP enabled 4 years ago
Ismael Gomez 493b7ea2da Remove SNR threshold based link failure detection 4 years ago
Ismael Gomez 874e614970 Increase PUCCH detection threshold to avoid false alarms 4 years ago
Francisco Paisana 2de702f50e disable carrier aggregation when ue release is below 10 or category is below 5 4 years ago
Francisco Paisana 9855749e9a remove comments 4 years ago
Francisco Paisana eee195c828 remote commented lines and added comments 4 years ago
Francisco Paisana 8ea059d578 fix pnf messages and shutdown 4 years ago
Francisco Paisana e555e50a90 fix pnf packing for MIB messages 4 years ago
Francisco Paisana e3e9bbcd62 fix PNF PDU size cutting 4 years ago
Francisco Paisana a0606669e2 fix ue nr gw initialization 4 years ago
Francisco Paisana e6418b4b39 fix variable naming 4 years ago
Francisco Paisana 1d07258458 created pnf bridge executable 4 years ago
Francisco Paisana fddcbc9879 fix vnf-ue stack interface 4 years ago
Andre Puschmann ad1b9d4d9b rlc_um: improve warning message to better differentiate them 4 years ago
Francisco Paisana d7138b7752 fix nr activation guards 4 years ago
Ismael Gomez 29e126a583
Add per-channel TX gain (#1450) 
* Change type of rf_set_gain() to avoid unambiguous return with negative gains

* Add per-channel TX gain
 4 years ago
Francisco Paisana 52c6c6aafd add ifdef guards for NR code 4 years ago
Francisco Paisana 0938c447f7 fix compilation error 4 years ago
Francisco Paisana b68ef69ab4 fix comments and other minor issues 4 years ago
Francisco Paisana 468389997e fix header sn check 4 years ago
Francisco Paisana 0259d31b13 fix lack of final in pdcp virtual methods 4 years ago
Francisco Paisana eb69683dc3 fix lack of final in virtual methods 4 years ago
Francisco Paisana 42969ad992 add tb size as argument to gnb 4 years ago
Francisco Paisana 2f8dad03cc add rlc nr locking 4 years ago
Francisco Paisana f0874b780b add radio_base/null classes 4 years ago
Francisco Paisana 64e8f5e3ed update license year 4 years ago
Pedro Alvarez 9c1a7d2cf1 Removed get_bearer_status in PDCP. Renamed get_state/set_state to 
get_bearer_state/set_bearer_state.
 4 years ago
Pedro Alvarez 208a539499 Split PDCP tx_count state variable into tx_hfn and next_pdcp_tx_sn 
variables.
 4 years ago
Pedro Alvarez 08578a7331 Switched to use a struct to hold the PDCP entity state variables. Deleted some unecessary setters. 4 years ago
Pedro Alvarez 66d4f320e5 Added intereface to set PDCP state after reestablishment. 4 years ago
Pedro Alvarez 33567d81db Added interface to get internal PDCP state. 4 years ago
Pedro Alvarez 4093e75237 Starting to add getters and setters of the state in PDCP lte entity. 4 years ago
Xavier Arteaga 0e415260e9 SRSUE: scell_sync vector changed to map 4 years ago
Xavier Arteaga e0e8405285 SRSUE: initial scell sync 
SRSUE: SCell Synch feedbacks delay

SRSUE: Implemented SCell Radio offset correction
 4 years ago
Xavier Arteaga 5c0bb000ca UE DL does not complain if no grant is not found 4 years ago
Xavier Arteaga 8a774136de Radio: return error if a RF instance fails to open 4 years ago
Xavier Arteaga f04cf2090a Integrates number of samples in radio buffer 
Fix minor issue

Radio: Fix minor bug and add unit test
 4 years ago
Xavier Arteaga de230826b9 Added string helper for removing spaces and parsing list 
Fix

Fix string parser
 4 years ago
Xavier Arteaga 89b24b54e5 Refactored radio class for acommodating multiple RF devices 4 years ago
Andre Puschmann 1f73e6ae69 multiqueue: add option to create queue with non-default capacity 
this allows to create a queue that has a non-default capacity
currently this is 8192, but the value might now be suitable in some
cases like for TTI sync events
 4 years ago
Francisco Paisana 3c2e3dbdbf added latest mac nr updates 4 years ago
Francisco Paisana cc52edf820 added latest pnf/vnf api updates 4 years ago
Francisco Paisana 27e5d98ef9 added vnf phy nr 4 years ago
Francisco Paisana b05ce2fe57 added pnf_dummy test 4 years ago
Francisco Paisana 8a022fb35b fix noexcept declaration issue in gcc4.8 4 years ago
Francisco Paisana 6509399ed3 fix for move-only events 4 years ago
Francisco Paisana 12dda03bb8 add ability for fsms to self-trigger 4 years ago
Andre Puschmann 9f98bb3f54 disable prach_test_usrp compilation if no RF is selected 4 years ago
Francisco Paisana d859c33035 added check for UCI collision during DL scheduling for CA 4 years ago
Ismael Gomez 60b5fb9a74 Refactor variable name 4 years ago
Xavier Arteaga 0e5704731e Removed UHD unrelated changes 4 years ago
Xavier Arteaga 258f7a180c Improved PRACH test USRP 4 years ago
Xavier Arteaga cd463d1b87 UHD: Initial C++ porting 
UHD: cmakefix

x3
 4 years ago
Andre Puschmann 8512c10286 create simple helper method to log command line arguments 5 years ago
Xavier Arteaga 039f2164a6 Initial Sounding Reference Signals implementation 5 years ago
Francisco Paisana 613003ac53 add srsenb::rrc class 5 years ago
Ismael Gomez 84b84eaad6 Move search_in_common variable 5 years ago
Ismael Gomez 9b634b8d2a Search DCI in UE space before common to avoid DCI size ambiguity. Fixes #1398 5 years ago
Francisco Paisana c6dde24476 avoid blocking when new procedure is launched from within proc::then call 5 years ago
Pedro Alvarez 960c0e97cd Added handling of RRC re-establishment to srsENB. 
* Added the appropriate code for handling and sending the
   re-establishment procedure messages to rrc_ue.c/.h.
 * Triggered RRC reconfiguration after the reception of RRC
   re-establishment complete
 * Refreshed K_eNB at the reception of re-establishment
   request
 * Changed the mapping of TEIDs to RNTIs in the GTP-U layer,
   as the RNTI might change with reestablishment.
 5 years ago
Daniel Willmann 0e99e2f6eb srsue: Refactor definition to live in its own .cc file 5 years ago
Francisco Paisana 452c043370 created a global map of lcids to srbs/drbs for NR 5 years ago
Andre Puschmann 9fd327fcac soapy: use SoapySDRDevice_enumerateStrArgs to create Soapy args object 
this allows to use Soapy device parameter when creating the device
 5 years ago
Andre Puschmann ff508a2c6b npdsch_ue: add rf_dev param and make remove samp rate check 
the remove of the samp rate check was needed on the PlutoSDR
because the result would not be the exact value that was
asked for
 5 years ago
David Rupprecht 61b69a0dab security: refactor code, fix race in eia1 
* state funktion for eia1 (mitigate race condition)
* Extra file for snow3g
* just use mbedtls aes
* ref specification
* adding const keyword to security functions
 5 years ago
faluco 617cad58ab Fix identation of arrays. 5 years ago
faluco cf5b321fb5 Replace magic numbers with macro constants. 
Adjust comments to refer to these macros.
 5 years ago
faluco ac3b7ed54c Move static array inside function as it is only used in there. 5 years ago
faluco 9484db8a90 Added header comments to srslte_sfidx_tdd_nof_X family of functions. 
Fixed a comment referring to an older TS release.
Remove elses after returns.
 5 years ago
faluco 8c59606d6f Add comment header to srslte_sfidx_tdd_type. 
Remove else after return.
 5 years ago
faluco 7354f49fe5 Added explanatory comments to TDD phy structs and enums. 5 years ago
Xavier Arteaga 9f5aef30e6 SRSENB: fix DL ACK decoding 5 years ago
Francisco Paisana 026628a84f use of reestablishment method to reset the RLC bearers during handover 5 years ago
Francisco Paisana edba7f57e4 corrected mac_nr_pdu includes 5 years ago
Ismael Gomez 270c7ce9dc Separate PHY interface to add rnti and pregenerate sequences. Calculate the sequences on the reception of ConnectionSetup instead of PRACH 5 years ago
Francisco Paisana d7c7bb382a fix license year 5 years ago
Francisco Paisana 2da8c923b1 removed commented code and fixed interfaces 5 years ago
Francisco Paisana b4b5cd7cd6 added nr gnb and ue interfaces 5 years ago
Ismael Gomez a1f0f8de35
Add callback to RLC to indicate BSR for TX and reTX queues (used in ENB) (#1361) 5 years ago
Francisco Paisana 8e9da9d12e avoid creating unused static variable to avoid linking issues 5 years ago
Andre Puschmann 1eaa99530f rlc_am: tiny refactor of rlc_amd_pdu_header_t 
mainly turning header into proper class and adding default init value
 5 years ago
Andre Puschmann 8756d14660 enb_interface: add default initialize to zero 5 years ago
Francisco Paisana c87197dd4e fix deadlock in multiqueue reset method. 5 years ago
Xavier Arteaga 20db13abc7 SRSUE: fix condition number calculation 5 years ago
Xavier Arteaga 9d5c2d70df SRSENB: Fix PHY reconfiguration for HO 
Minimal aesthetic change
 5 years ago
Pedro Alvarez 6ce33c3812 Small compilation fixes for GCC 10.1 5 years ago
Francisco Paisana e8aff22e1b using new rrc obj id util methods in handover code 5 years ago
Francisco Paisana f43985b6cd small updates for testing handover and configuring the rrc 5 years ago
Francisco Paisana 598bad1f0e changed rrc ue cfg files names 5 years ago
Francisco Paisana d43448e8a1 created security cfg handling class for rrc ue and refactor bearer_list handling 5 years ago
Francisco Paisana ca0db7fffe created generic methods to apply toaddmodlist and removelists. 5 years ago
Francisco Paisana c65c081b51 created separate files to handle rrc bearers 5 years ago
Francisco Paisana 65abcd2903 use true_type to represent success 5 years ago
Francisco Paisana 791d84e639 created error_type and cleaned up expected 5 years ago
Francisco Paisana 9a7f48b6a5 fix gcc4.8 compilation issue 5 years ago
Francisco Paisana 975d004224 fix compilation error 5 years ago
Francisco Paisana 0f49cb7357 abort if bad access 5 years ago
Francisco Paisana a2b76a4a5f use references rather than pointers 5 years ago
Francisco Paisana a88bffa5d5 created expected type and respective test 5 years ago
Andre Puschmann bdd97ca25f pdsch_enodeb: remove check in while-loop 
this check is always true since the false case is caught
before and the application is closed()
 5 years ago
Fabian Eckermann 447b989aad fix parsing of zmq arguments 
Use the return value of parse_string function to determine whether a parameter was found.
I experienced issues when the rx_type was set, but the rx_format was not. This led to "Unsupported sample format pub" as the tmp variable is still set to the value of the rx_type.
 5 years ago
Ismael Gomez 847366bcdb Don't set high master clock rate for 75 PRB 5 years ago
faluco 3fa5926cd5 Fix SIMD neg operation which was inverted. 
Re-enable -Werror.
 5 years ago
faluco 4fb290ea27 Remove ifdefs now that this SIMD op is supported. 5 years ago
faluco c39ea2f583 Adjust possible type mismatch. 5 years ago
Andre Puschmann 189685b6f5 demod_soft: fix clang warning in demod NEON code 
Try to bring back compilation.
Disable temporarily Werror.

Re-enable two simd functions.
 5 years ago
Andre Puschmann f67524707d neon: add srslte_simd_b_neg() 
clang complained about an uinit var that is returned and it turned
out that we don't even implement that function in NEON.

I've found a nice MIT-licensed header that was easy to integrate.
 5 years ago
Andre Puschmann 53ab53ee77 ue_sync: fix tracking in GNSS_SYNC mode 
this fixes the subframe-accurate rx in tracking mode.
previously we've only alligned to the next subframe start in find and
when there was a single overflow we've lost the track.

this patch calculates the offset in samples to the actual start of the
subframe (full ms of the receive timestamp) vs. the actual
receive timestamp and uses the value as the "next_rf_sample_offset"
to realign on the next receive
 5 years ago
Andre Puschmann 14143f8560 pssch_ue: fix memory leaks and operation with RF 
- add missing free's for ofdm and chest objects
- fix sf_idx setting
- add getchar() when plotting from file to observe output
 5 years ago
Andre Puschmann ca3b76df6e chest_sl: fix some possible array access at negative index 5 years ago
Francisco Paisana cf9d31ea64 fix coverity warning for useless call 5 years ago
Andre Puschmann 28c98280d7 ue_dl_nbiot: convert macro to access SF contents into member var 
also use srslte_vec_cf_cp() helper functions
 5 years ago
Andre Puschmann 9648e47eb6 ue_cell_search_nbiot: fix potential out-of-bounds access 
we've used a macro that can return -1 as access index
for an array. this has now been converted in a member
that is initialized and checked during init
 5 years ago
Andre Puschmann d64fa19321 ue_dl_nbiot: check sf_idx before accessing buffer 
this fixes a potential out-of-bounds access
 5 years ago
Andre Puschmann ba4c2f10f0 fix potential out-of-bounds access in static look-up-tables 
check index before accessing lut
 5 years ago
Andre Puschmann 52799192ab pssch_ue: fix uninit var 5 years ago
Andre Puschmann 7aeddfd186 fix potential error where return value -1 is used for loop termination 5 years ago
faluco 340ec61e8e Code review. 5 years ago
faluco e28d9bb473 Fix for 1492950. 5 years ago
faluco 6fdceadc4e Fix for 1480100. 5 years ago
faluco 7bec101831 Small refactor to eliminate a function that causes undefined behaviour. 5 years ago
Andre Puschmann a0665b721e prach: fix illegal mem access when wrong configs are passed 
this fixes Coverity issue 1480095
 5 years ago
Xavier Arteaga 282cda7155 Fix Radio segfault 5 years ago
Xavier Arteaga f69aad3aac Clean up channel class 5 years ago
faluco d9529a3a8f Fix for 1480071. 5 years ago
faluco 0ba9164ae2 Fix for 1480055. 5 years ago
Andre Puschmann 8185b7c793 ue_dl: fix potential out-of-bounds access when decoding DCIs 
fixes Coverity issue 1480088 where srslte_ue_dl_find_dl_dci() expects
an array of struct srslte_dci_dl_t but is only given one element.

srslte_ue_dl_find_and_decode() itself only uses the first decoded
message but find_dl_dci() may still decode more than that
 5 years ago
faluco 9efa24bfa9 More warning fixes. 5 years ago
faluco d3cb5dcffd Start fixing clang 10.0.0 warnings. 
Disable -Werror temporarily.
 5 years ago
faluco 74dae2c287 - Small refactor to make math operations without implicit casts. 5 years ago
faluco d7433a551b Initialize TDD matrix with shorter symbols using macros. While there move another matrix next to where it is used. 5 years ago
faluco 7ff251f112 - Fixed warnings caught by Clang 9.0.0 5 years ago
Francisco Paisana 2204cab4c8 old gcc version cannot support the detected pattern. Removing it 5 years ago
Francisco Paisana e3d0b1c89e format missing fsm table 5 years ago
Francisco Paisana f4d19a6d44 added fsm table formmatting comments 5 years ago
Francisco Paisana 3ef8c67d67 enter/exit are now inside the state class. No need for friend classes anymore 5 years ago
Francisco Paisana 2641c6ef08 resolve template type derivation in clang 5 years ago
Francisco Paisana 9b48130ae1 use of transition table to support guards in fsms 5 years ago
Francisco Paisana 04e192eb0f redesign fsm to use transition table 5 years ago
Andre Puschmann 49a375ce1a arch_select: fix compilation for clang 3 
In clang 3's C headers, the bit_SSE4_2 and bit_AVX2 macros
aren't defined/supported. So we can only use them if
they exist.
 5 years ago
Andre Puschmann 99c3975f83 remove CMake option to disable glibc header for IPv6 
we've added this to allow building for older glibc
version that cause issues with redefining some structs.

this patch removes the flag and auto-detects it using the glibc version
 5 years ago
Francisco Paisana fbd889ad4d fix formatting issues in asn1 5 years ago
Francisco Paisana e79fc9bf08 fixed generation of ie containers of one single ie object 5 years ago
Andre Puschmann e3e3848210 cell_search_nbiot: show DL frequency in MHz 5 years ago
Andre Puschmann f5d55847c2 nbiot: add r14 parameter to NPDSCH eNB and file test and make it the default 
also add skip SIB2 option to UE example
 5 years ago
Andre Puschmann 92fb6a94f4 npdsch: use r14 bcch sequence when encoding SIB 5 years ago
Andre Puschmann 2c6a95c1d5 nbiot_sync: fix potential segfault during sync when time gap is too big 5 years ago
yagoda 3f99e40159 -changing rlc so that mrb is never removed when going to idle 
-adding metric counting to eMBMS MAC so that the count is not lost during eMBMS subframes
 5 years ago
Francisco Paisana e5533e4bcd gcc 4.8.5 does not have std::max_align_t 5 years ago
Xavier Arteaga d94078d543 Minor changes 
Fix UE sequence generation

minor change
 5 years ago
Ismael Gomez 8c82203c74 Removed unused pregenerate option 5 years ago
Xavier Arteaga 2d39c7261c renamed vector copy prefix from to 5 years ago
Andre Puschmann 9d529ba0d5 fix compilation on arm, add missing declaration and headers 5 years ago
Xavier Arteaga 2569a94deb Radio Tx handles more overlap/gap cases 5 years ago
Andre Puschmann cd26f6988c temporarily disbale rf_zmq_test test due to hanging on exit on some platforms 5 years ago
Xavier Arteaga e15c49c5a5 Fix EVM hard-decision performance 5 years ago
Andre Puschmann f4f7210c56 pssch_ue: LGTM fixes 5 years ago
Andre Puschmann 68a1868c33 npdsch_{ue,enodeb}: few more LGTM fixes 5 years ago
Andre Puschmann 6a764ae87c psbch: change memcpy() to srs_vec alternative 5 years ago
Francisco Paisana 615bd54fd5 fix uninit var 5 years ago
Francisco Paisana f8c6f55cac fix uninit var usages and signed bit manipulations 5 years ago
Francisco Paisana de4d58d8fe fix coverity scan issues in master 5 years ago
Ismael Gomez c0054140e9 Configure properly PUCCH CS mode for CA in ConnectionReconfiguration. Allocate n_pucch_cs resource and cqi/sr at rrc::ue constructor 5 years ago
Xavier Arteaga 928439b94c DL Wiener: optimized with inlining 5 years ago
Xavier Arteaga 9d0a3268e8 Added DL channel estimator algorithm options 5 years ago
Xavier Arteaga 355b2ed7e1 Wiener: fixed more issues 5 years ago
Xavier Arteaga 9b9389ead5 DL Wiener: bug fixed and verified 5 years ago
Xavier Arteaga 4b6691a630 DL Wiener: Fixed phy common header missing 5 years ago
Xavier Arteaga 3ab5f3a7e8 Initial wiener filter integradion in DL channel estimator 5 years ago
Xavier Arteaga 5199aaa94e DL Wiener: Fixed minor header issues, format and optimization 5 years ago
Xavier Arteaga 6248ab43e3 Minor optimization in SIMD dot product kernel 5 years ago
Xavier Arteaga f4eb61a37c Implementation DL channel estimator using wiener filter 5 years ago
Xavier Arteaga fff96d9aac Phy utils: Added initial matrix inverse 5 years ago