205 Commits (0f06ec0d9c0e041080fe72244d93a72823ad9dc3)

Author SHA1 Message Date
Andre Puschmann 1155adf007 fixing printfs in asn1_utils 5 years ago
Andre Puschmann 75672324b9 fix RRC connection reconfig for new bearer
this fixes the packing of a RRC connection reconfig after creating
a new ERAB

it also adds a PDCP config factory based on the received request
5 years ago
Andre Puschmann 476f970ee1 replace FIXME with TODO 5 years ago
Pedro Alvarez c5979f59eb Clang format UE, eNB and lib (#850)
* Clang-formated UE, eNB and lib.
* Fixed compiling errors from clang-format.
* Fix linking issues introduced by clang-format
* Fix poor formating in initializing arrays of arrays.
* Fix mistake in conflict resolution on rm_turbo.c
* Re-apply clang format to gtpc_ies.h
5 years ago
Andre Puschmann 2ed2e35aa7 fixing two size_t printfs 5 years ago
Vasil Velichkov 87a0a25c18 M2AP: Align 8 bits in liblte_m2ap_unpack_protocolie_singlecontainer
Alignment with more then 8 bits is unusual for APER encoding.

It seems clangs uses different packing for the LIBLTE_BIT_MSG_STRUCT
struct then gcc and puts more bytes between N_bits and header.

typedef struct {
  uint32 N_bits;
  uint8  header[LIBLTE_MSG_HEADER_OFFSET];
  uint8  msg[LIBLTE_MAX_MSG_SIZE_BITS];
} LIBLTE_BIT_MSG_STRUCT __attribute__((aligned(8)));

Fixes a failure in srslte_asn1_m2ap_test when compiled with clang
272: Test command: lib/test/asn1/srslte_asn1_m2ap_test
272: Test timeout computed to be: 1500
272: 03:47:13.189195 [M2AP] [I] M2 Setup Request original message
272:              0000: 00 05 00 37 00 00 03 00 0d 00 08 00 00 f1 10 00
272:              0010: 1a 2d 00 00 0e 40 0a 03 80 65 6e 62 31 61 32 64
272:              0020: 30 00 0f 00 16 00 00 10 00 11 00 00 f1 10 1a 2d
272:              0030: 00 10 27 10 01 02 00 01 02 00 02
272: [m2_setup_request_test][Line 95]: FAIL at (plmn_id[0] & 0x0F) == 0 && (plmn_id[0] & 0xF0) >> 4 == 0 && (plmn_id[1] & 0x0F) == 1
1/1 Test #272: srslte_asn1_m2ap_test ............***Failed    0.00 sec
5 years ago
Vasil Velichkov 72f04a31b6 Fix typo in -Wno-parentheses
This fixes the following clang's warning

warning: unknown warning option '-Wno-parantheses'; did you mean
      '-Wno-parentheses'? [-Wunknown-warning-option]
5 years ago
Andre Puschmann c7ee887170 add factory function for creating PDCP config 5 years ago
Vasil Velichkov af2b4ecc79 Use -Wno-unused-but-set-variable only if supported
This fixes the following clang's warning

warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean
      '-Wno-unused-const-variable'? [-Wunknown-warning-option]
5 years ago
Andre Puschmann 0feb8d1362 fixing two more issues reported by lgtm in asn1 libs 5 years ago
Andre Puschmann 4e4a3eeb6c fix printf parameter in asn1_utils 5 years ago
Francisco Paisana a0d53b0d84 included ngap and rrc nr asn1 in asn1/ folder and added a ngap_test 5 years ago
Francisco Paisana d59016ae68 use of srslte::log* type for ASN1 logging. Initialization of the asn1 and rrc_asn1 loggers done now in both the ue and enb 5 years ago
Francisco Paisana d270518d69 updated rrc to new srsasn1 version 5 years ago
Francisco Paisana 6b4488d5c1 added sending of enb status transfer from SeNB 5 years ago
Francisco Paisana c7f11e5690 fixed issue with the liblte_s1ap transparent container packing 5 years ago
Francisco Paisana c29d8b418a fix coverity va_list issues 5 years ago
Francisco Paisana 514b9045ca added begin/end methods to asn1 arrays and fixed v2x bug 5 years ago
Francisco Paisana 50ed2ccfec added the handling of ho preparation failure and an ue class to s1ap 5 years ago
Francisco Paisana 35c9f02579 added quant cfg parsing and addition to measCfg 5 years ago
Francisco Paisana 427fdb83fe using std::make_tuple now to support old compilers. Move operator== definitions for meascfg types to rrc_asn1_types 5 years ago
Andre Puschmann 50999d8116 allow integrity protection for identity response 5 years ago
Francisco Paisana e92632e729 zero-initialized mbms rrc interface types 5 years ago
Francisco Paisana fc9bb3c934 removed rrc asn1 header include from the ue_interfaces and phy 5 years ago
Ismael Gomez 5689d6513d Fix not checking for explicit value 5 years ago
Ismael Gomez a3932f9bea Minor change to fix coverty issue 5 years ago
Francisco Paisana 94667beb00 added a bound checker to bit_ref packer, and other fixes 5 years ago
Francisco Paisana e768989074 added a packer/unpacker for bytes. This should a faster version than normal bit_ref::pack, when we want to pack multiple bytes, and the bit_ref::offset is 0. Also added a way to skip a fixed number of bits 5 years ago
Ismael Gomez 6bb0790cf1
Fix coverty issues (#652) 5 years ago
Ismael Gomez bfddc55148
RRC-PHY interface (#639)
RRC-PHY interface refactor. Moved RRC-MAC interface to rrc_asn1_utils and created RRC-PHY interface also in rrc_asn1_utils. All ASN1 includes should be made from rrc_asn1_utils only keeping ue_interfaces clean of ASN1

Tested with different common and dedicated configurations (64QAM UL, 256QAM, CA, SRS enabled/disabled, etc)
5 years ago
Francisco Paisana ad64207a32 added test for unknown group extensions, and the asn1 lib version in its generated files 5 years ago
Francisco Paisana 939c8905cb now the unknown group exts are also consumed 5 years ago
Francisco Paisana 116dc0a57b fixed group extensions, removed extra presence flag for copy_ptr<T> types as it was just a source of bugs. 5 years ago
Pedro Alvarez 9597cc4c14 Clang-formated liblte_* 6 years ago
Francisco Paisana 58e2e51044 removed rlc_interfaces. The rlc_cnfg types are now part of the rrc_interface_types. Removed implicit RB initialization in the RLC. 6 years ago
Francisco Paisana c5509caece added extra operators and remove rrc_asn1 in some cmake targets 6 years ago
Francisco Paisana b936629221 removed rrc asn1 header from bcd_helpers, from rlc_interface, and rlc tests 6 years ago
Francisco Paisana bb0dbf0f1c created a asn1 utils with helper functions and types related to the asn1. These types/functions will help isolate the rrc_asn1 lib from most of the layers, reducing this way the compile times, and leading to better isolation. This will also make the transition to NR smoother. I removed the asn1 types from the NAS and USIM interface so far. 6 years ago
Francisco Paisana 416f9896ec fixes to include the findings from PR #550 6 years ago
Andre Puschmann 62a4fa1c93 fix various potential buffer overruns
this is based on suggested fixes by Dirk Grabinski and David who
have fuzzed various parts of srsLTE using afl
6 years ago
Andre Puschmann f357c995fc liblte_mme: fix packing and unpacking of modify EPS bearer context
this just skips the security bits but the packing/unpacking of
the values, i.e. new TFT may still be wrong
6 years ago
Andre Puschmann 76b84a9b61 fix unpacking of deactivate eps bearer context 6 years ago
Pedro Alvarez 69b1a2319e Fix error in the TFT parameter list size unpacking 6 years ago
Pedro Alvarez 82828a699b Fixed bug in transaction identifier and radio prio unpacking in NAS. 6 years ago
Pedro Alvarez 02beeefdbd Fix header unpacking error in the Activate EPS dedicated bearer context request message 6 years ago
Andre Puschmann 1c749ad559 add basic handling for deactivating eps bearer 6 years ago
Andre Puschmann f000e36f21 liblte_mme: fix dedicated bearer handling, add handling for UE testmode 6 years ago
Francisco Paisana 47ba5cd098 Set the optimization flag to Os for the rrc asn1 library 6 years ago
Andre Puschmann 780ea8867c fix asn1_m2ap test
- there was an issue in the stack allocation of the large
  m2ap pdu struct that was fixed by heap-allocating it

- there was also an issue in the m2ap packing that used
  a temporary struct that was not initialized
6 years ago
Francisco Paisana 896ef5ee64 added default init for booleans and integers 6 years ago
Andre Puschmann 4b01a2e4a0 update copyright notice 6 years ago
Francisco Paisana dc0b903130 added default enum inits 6 years ago
Pedro Alvarez 5f7b6ba79e Split GTP-C and GTP-U functionality into seperate classes in the SPGW. Added GTP-U specific logging in the EPC. Added handle_s11_pdu function to both the MME GTP-C entity and the SPGW GTP-C entity. 6 years ago
Pedro Alvarez add60c1288 Applied clang-format to the EPC. 6 years ago
Francisco Paisana 18f61b13d9 fixed asn1 to_json converter for extensions 6 years ago
Francisco Paisana 80031d0846 shortened enumerated string/number conversion implementations. 6 years ago
Francisco Paisana ca3ea5e658 shortened enumerated types declarations 6 years ago
Francisco Paisana e50c062084 added extra separator comments 6 years ago
Andre Puschmann 788f283492 Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next 6 years ago
Francisco Paisana 840b9ce364 fixed octstring to_number() endianess 6 years ago
David Rupprecht 3d458319c9 fixed decoding of multiple s1ap plmns 6 years ago
Francisco Paisana 0204db2e12 new asn1 rrc library 6 years ago
Pedro Alvarez 584c190773 Merge branch 'next' into next_mme_encryption
Updating next_mme_encryption to the latest next.
6 years ago
Pedro Alvarez 997c24c099 Added config of cipher_algo and integ_algo initialization in NAS class. 6 years ago
Pedro Alvarez d7b92b8f77 Small commit to fix PDCP SN packing in liblte_s1ap 6 years ago
Pedro Alvarez 3205121015 M2 interface packing/unpacking (#305)
* Starting to add M2AP serialization structures.

* Added M2AP procedure ids.

* Added some M2AP max values.

* Removing m2ap.cc for now.

* Adding cause IE.

* Adding dummy m2ap.cc to check correct compilation of m2ap.h

* Fixed compilation issues in m2ap.h

* Adding Cell Information IE.

* Added Criticality diagnostics IE.

* Adding eNB-MBMS-ConfigurationDataItem.

* Adding MBMS-Service-Area-Id-List

* Added MBMS Service Area Id.

* Added Global eNB Id IE.

* Added Global MCE id IE.

* Added MBMS-Service-associatedLogicalM2-ConnectionItem IE.

* Added MBSFN_SUBFRAME_CONFIGURATION IE

* Added MCCHrelatedBCCH-ConfigPerMBSFNArea IE.

* Added MCH scheduling period IE.

* Added PMCH-Configuration IE.

* Added Time-to-Wait IE.

* Added TNL-Information IE.

* Starting to add M2SetupRequest msg.

* Adding M2 Setup Request message.

* Fixed up enums related to initiating messages, successful outcome and unscesseful outcome.

* Starting to add m2ap apck/unpack PDU functions.

* Started to add a test for M2 Setup Request Pack/Unpack.

* Filling in M2SetupRequest structure.

* Adding packing of more IEs in the M2SetupRequest.

* Starting to add unpacking functions to M2SetupRequest.

* Continuing to unpack M2SetupRequest. Unpacking PLMN Identity correctly now.

* Fixed up enb_id unpacking. eNB Id and eNB name unpacking correctly now.

* Starting to add unpacking for dataconfiguration item.

* Adding support for eCGI unpacking.

* Adding MBSFN Synchronization Area id Unpacking.

* Adding service area unpacking.

* Added unpacking functionality to the rest of the IEs in the M2 Setup Request. Unpacking the M2 Setup Request is passing unit test.

* Fized mistake in packing eNB Id. Starting to add packing to eCGI.

* Starting to pack value in ENB MBMS Configuration item.

* Fixed packing of ENB MBMS configuration item header.

* Packing of M2 Setup request is now passing the unit test.

* Starting to add M2setup response.

* Starting to add packing/unpacking succeful outcome.

* Starting to add M2SetupResponse to test.

* Continue to add testing to setup response. Choice type seems OK.

* Starting to add unpacking to MCE Id.

* Adding MCEname packing/unpacking.

* Continue to unpack m2setupresponse.

* Adding MBMS Area Id unpacking

* Added pddch length unpacking.

* Adding more IE unpacking.

* Adding more code to unpack M2 Setup response.

* Added M2 Setup response unpacking.

* Added M2 response packing. Fixed mistake on eCGI packing/unpacking, which broke M2 Setup request.

* M2 setup request and response pack and unpacking seems to work.

* Starting to add MBMS Session Start Request.

* Continue to unpack MBMS session start request.

* Added TMGI unpacking.

* Continue to add unpacking to MBMS session start request

* Starting to add TNL Information unpacking

* Added unpack for MBMS session start request.

* Strating to add MBMS session start request packing.

* Adding MCE MBMS M2AP Id packing.

* Added MBMS Session Start Reqeust pack and unpack.

* Added MBMS Session start response packing/unpacking.

* Starting to add unpacking of MBMS Scheduling information.

* Adding MCCH Update time Unpacking.

* Adding MBSFN Area Configuration List Unpacking.

* Starting to add unpack PMCH configuration Item.

* Adding AllocatedSubframesEnd unpack

* Fixed multiple mistakes in unpacking PMCH configuration.

* Unpacking MCH Scheduling Period

* Continue to unpack MBMS Session List Per PMCH Item.

* Added unpacking of PMCH Configuration List. Starting to add unpacking of MBSFN Subframe Configuration List.

* Adding radioframe allocation period and offset unpacking.

* Added unpacking of MBMS Scheduling Information (needs testing.)

* Added more testing to MBMS Scheduling Info.

* Small commit.

* Added more testing to the unpacking of MBMS Scheduling Information. Unpacking correctly now.

* Continue to pack MBMS Scheduling information. Packing PMCH Configuration.

* Fixed mistach in packing PMCH configuration list.

* Adding more packing to MBMS scheduling info message.

* Fixed more mistakes in MBMS Scheduling information packing. Passing tests now.

* Added MBMS Scheduling Information Response.

* Remove debug prints.
6 years ago
Pedro Alvarez e88e1bb4d2 Fixed TMSI packing length (was giving trouble with Xperia). 6 years ago
Pedro Alvarez 1fba7f0afa Moved function that gets NAS type string to liblte_mme.cc 6 years ago
Andre Puschmann 9b894799f0 add support for ciphered authentication response 7 years ago
Paul Sutton 2a0c98c82a minor uninitialized variable fix 7 years ago
Paul Sutton 4abe744337 Fix for use before check error 7 years ago
Andre Puschmann 9ce3be974a Merge branch 'next' into embms_merge_final 7 years ago
yagoda 49c3578f64 introducing embms support in common upper layer functions 7 years ago
Andre Puschmann a30ad8952c fix indent and simplify auth request packing 7 years ago
Andre Puschmann 4fe5258a23 fix packing/unpacking of esm info request msg 7 years ago
Andre Puschmann 4dc2951d59 perform initial attach with ESM info transfer 7 years ago
Andre Puschmann 9f71051696 fix parsing of attach accept PDN address to find protocol options 7 years ago
Andre Puschmann 455d4491c5 make RES length variable when packing auth response 7 years ago
Ismael Gomez 462de6607d Do not assume initialized variable in S1AP packing 7 years ago
Ismael Gomez 208871b251 Changed liblte structs to simple structs and initialized nas/rrc uses. 7 years ago
Paul Sutton e71dde7311 Fix for RRC ReportConfigEUTRA pack function 7 years ago
Pedro Alvarez 6e4720771f Merge branch 'next' into epc 7 years ago
Pedro Alvarez 57220bd6a8 Fixed compiler warnings. 7 years ago
Paul Sutton daf0a11345 Fix for RRC Connection Reject wait time pack/unpack 7 years ago
Pedro Alvarez 669ef9816f Added packing of TMSI to mobile station identity IE. 7 years ago
Andre Puschmann 07cd9ae528 fix coverity issues 7 years ago
Andre Puschmann 8daa834607 fix ASN1 s1ap code by checking upper bound of buffer 7 years ago
Pedro Alvarez 042552491b Merging next into epc branch. 7 years ago
Pedro Alvarez a4e1707835 Fixed bug in packing ESM information request. 7 years ago
Paul Sutton 84724d2ab1 NAS-plane encryption working (thanks to David Rupprecht) 7 years ago
Pedro Alvarez 103361deb9 Fixed SPGW initialization bug. 7 years ago
Paul Sutton d9b9ae9454 Fix for GUTI pack bug, add support for integrity with attach req 7 years ago
Pedro Alvarez ccbeb9e1c5 Fixed a bunch of compilation errors. 7 years ago
Pedro Alvarez 2088b3967b Commenting out the initial GTP-C packing functions (for now). 7 years ago
Pedro Alvarez 542edb988a Added GTPC ie and msg type definitions 7 years ago
Pedro Alvarez 04d3a3f8ca Continue to work on pakcing the create session request message 7 years ago
Pedro Alvarez 99f6ffe63b Starting to add code to create the GTP-C messages. 7 years ago
Paul Sutton 7e3fbbc639 Adding ASN support for RRC measurement report messages 7 years ago
Paul Sutton 12603e4da2 Bugfix for RRC ASN MeasConfig packing 8 years ago
Paul Sutton 4b68272964 Switch to static internal libs, set -fPIC by default 8 years ago
Ismael Gomez 8a367bf825 changed srsue namespace to srslte for all common objects 8 years ago
Andre Puschmann 1d1916d6e0 Merge branch 'restruct_update' into restruct_update_paul 8 years ago
Andre Puschmann bcecdf292b add C++ compile flags and enable useful warnings 8 years ago
Paul Sutton 80140c7c38 minor cmake edits 8 years ago
Andre Puschmann 5898af3d0b add srslte_asn1 lib
- remove extra subfolder containing liblte
- add asn1 lib containing rrc msg packing and unpacking
- add security related bits to common
8 years ago