1947 Commits (0d918024959132e24413b3e94bb5acdc64a049d1)

Author SHA1 Message Date
Francisco 1ede82bb30 use circular array for buffered PDCP SNs in RLC AM to limit memory allocations 4 years ago
Francisco 2a65bf9636 fix undelivered PDCP SNs buffers in RLC AM to handle SN=-1 case 4 years ago
Francisco bad2302e31 avoid the use of two arrays for managing buffered pdcp sns in RLC AM 4 years ago
Francisco 299634b319 use of vector to store undelivered PDCP SNs in RLC AM 4 years ago
Xavier Arteaga c2c05d1e8f Initialise to zeros NR PHY configuration by default 4 years ago
Pedro Alvarez d8f3878ce1
RLC failure to deliver notifications and discard timer limits to 1500ms (#2368)
* Added interfaces for the RLC to notify the PDCP of failure to transmit
SDU

* Limit discard timer to 1500ms, to avoid issues of lingering SDUs in the undeliverd_sdus_queue.

* Fix bug in early exit of notify_delivery and notify_failure

* fix compilation issue in rlc-pdcp notification

Co-authored-by: Francisco <francisco.paisana@softwareradiosystems.com>
4 years ago
Francisco 2f75abcc7a fix failing rlc am test 4 years ago
Francisco 1d185fb152 use macro for rlc tx window size. refactor tx window clearing 4 years ago
Francisco abe4f4c7eb use tx_window to store the map of rlc sn to pdcp sns 4 years ago
Francisco f86eb84876 conversion of RLC AM tx window from std::map to array 4 years ago
Francisco 047dd2a56d use function helper for discard timer lookup and stopping in the PDCP 4 years ago
Francisco 82bb0a7d81 implementation of pdcp discard timers using a vector for efficiency 4 years ago
Andre Puschmann 40d7934267 rlc: call PDCP notify without holding Tx lock
move notify_info_vec as stack variable and unlock mutex
before calling PDCP notify
4 years ago
Francisco 93b1450e03 fix enb crash during close down of enb and epc 4 years ago
Francisco Paisana cd8ee37f74
Use a reverse lookup to avoid iteration over a std::map (#2363)
* reuse vector capacity for pdcp sn notification
* use an extra lookup data structure to find PDCP SNs that an RLC SN contains
* fix rlc sn->pdcp sn lookup datastructure in rlc
* fix rlc failing test
4 years ago
Xavier Arteaga b8b27709b9 Radio: implement resampling buffer protection 4 years ago
Pedro Alvarez 6ecd6e273c Make sure that the status report is sent in RLF and PDCP reestablishment triggered by Handover 4 years ago
Pedro Alvarez 33808a5cb8 Making sure that SNs don't wrap-around in PDCP with RLC AM. 4 years ago
faluco a940e169a3 Add the enb_cc_idx value to S1 events. 4 years ago
faluco b750647cd8 - Remove the cause field in the rrc disconnect event.
- Add the sib9 enb home name field to the sectors events, but leave the value as a TODO.
4 years ago
faluco 7b9dab3a73 Rename cc_idx variable to enb_cc_idx for specific upper layer events. 4 years ago
faluco a4605883f0 Implement second revision of the events and metrics document. 4 years ago
Pedro Alvarez 0e828aeb4b Remove unecessary mutex. PDCP metrics are accessed from the stack thread. 4 years ago
Pedro Alvarez 451c305790 Add mutex to isolate metrics_hub thread from the stack thread when
getting the metrics from the PDCP
4 years ago
David Rupprecht a7949e69c8 configure and start ra proc
Fix crash due to missing init
4 years ago
David Rupprecht 876858b44c Added mac nr prach common config convert function with test case 4 years ago
David Rupprecht a3be380e3b workaround to mitigate the linking error 4 years ago
Pedro Alvarez cfd94441a5 Added metrics to srsenb PDCP 4 years ago
Pedro Alvarez 8873b7c42f Added computation for the metrics 4 years ago
Pedro Alvarez d34aba8065 Added interfaces to get metrics from PDCP entities. 4 years ago
Pedro Alvarez eb2f5b978f Starting to add metrics to lib/upper/pdcp.cc 4 years ago
Pedro Alvarez dd6a292d79 Added structure to hold PDCP metrics 4 years ago
Xavier Arteaga bdef411855 SRSUE: Aesthetic changes 4 years ago
Xavier Arteaga 96a47fb93a Add NR RRC interface types 4 years ago
Xavier Arteaga 784a33583b SRSUE: Initial NR MAC-PHY interfaces
SRSUE Fix compilation

SRSUE: temporary fixes LTE/NR PHY/Stack interface problem

fix

fix
4 years ago
Francisco 6a178693a8 handle rrc configs with pdcp with sn=15 or 18 bits 4 years ago
Francisco faf2adde90 set last_submitted_pdcp_rx_sn to -1 of the next ul rx sn 4 years ago
Xavier Arteaga 1e073b8b67 PRACH: avoid general cexp for sequence generation using LUT 4 years ago
Pedro Alvarez e0542a4651 Fix issue in sending PDCP status PDU from the eNB due to non-existing LCID at the RLC. 4 years ago
Pedro Alvarez b0fe302f8e Added interfaces so the upper layers can trigger the PDCP status report. Added ability to the UE to send Status Report aftre reestablishment. 4 years ago
Pedro Alvarez 89a23cec7e Added statusReportRequired to the PDCP entity config. 4 years ago
David Rupprecht 24123313bf Added MAC NR RA procedure with a minimal test case 4 years ago
Xavier Arteaga d9805f7ba7 Added AVX512 LDPC 4 years ago
Xavier Arteaga 2e39e103f8 Minor NR related corrections 4 years ago
Xavier Arteaga 24cfed6489 Fix scrambling sequence for PUCCH format2 4 years ago
Xavier Arteaga d807ccc3dd SRSUE: Initial NR-PUCCH HARQ feedback 4 years ago
Xavier Arteaga ff5fbbf0a0 Added vector sprint for bit 4 years ago
Xavier Arteaga 818f3ea7c7 Initial NR-PDSCH HARQ-ACK/NACK procedure 4 years ago
Xavier Arteaga 44df2288b9 Corrected typos 4 years ago
Pedro Alvarez f89b644902 Added function to get control pdu type to the PDCP base class. Shorten logger name in PDCP Status report test. 4 years ago
Pedro Alvarez 9bc08af880 - Added ability to the PDCP LTE entity to send PDCP Status report.
- Added handling of PDCP status report to the PDCP LTE entity.
- Added test to the generation and handling of PDCP status report.
4 years ago
Francisco Paisana c40ad81a90 cleanup s1ap methods. remove hard coded erab list in s1ap handover required message. 4 years ago
Francisco 23459dee28 Created enb_{rlc/pdcp/gtpu/phy_interfaces.h files. 4 years ago
Francisco 43e57df00b breaking enb_interfaces.h into multiple files on a layer basis. Created enb_rrc_interfaces.h, enb_mac_interfaces.h and enb_s1ap_interfaces.h 4 years ago
Pedro Alvarez dd6d6f731d Passing SN provided by upper layers to PDCP entity. Using it to calculate TX_COUNT if passed. 4 years ago
Pedro Alvarez 492ea2a5a8 Addressing reviewers comments to #2290.
Removing unecessary \n for logs and changed log of PDCP info queue
 capacity to debug to avoid log spam.
Changed log level for unhandled S1AP messages from error to warning
 in EPC to avoid failing tests because of error message.
Changed usage of allocate_unique_buffer to make_unique_buffer()
4 years ago
Pedro Alvarez fcaaf72187 Starting to add discard functionality to PDCP LTE entity.
This includes:
  - Adding a queue (implemented with std::map) for undelivered PDUs.
    This queue uses the SN used for TX as the key.
  - Added discard timer that is started upon reception of the SDU. Upon
    expiry of the timeout a discard callback removes undelivered PDUs
from the queue.
  - Added the mechanisms to the notify_delivery to remove PDUs from the
    undelivered queue when the PDU is ACK'ed.
  - Added test case for both timer expiry and acknowledgment.
  - Fix up the getter for buffered SDUs to return the undelivered SDUs
  - Changed default PDCP discard timer, so AM has a discard timer by
    default.
4 years ago
faluco 57f66febfc Ported the RLC classes to srslog in the lib dir. 4 years ago
faluco f424f2e113 - Upgraded PDCP classes in lib to use srslog.
- Update tests to new changes.
4 years ago
faluco 6359a2d948 - Upgrade the gtpu class in lib dir to srslog.
- Propagate old log elimination through all the dependencies of gtpu.
4 years ago
faluco 62fcf04083 Ported the all radio classes to use srslog. 4 years ago
Francisco c2dfe615e7 fixed alignment of LIBLTE_BYTE_MSG_STRUCT to reflect the one of byte_buffer. Add bzero in liblte packers 4 years ago
Francisco 4188b5146e fix uninitialized memory access in gtpu_test and liblte_mme unpacking 4 years ago
Ismael Gomez 77f905dc64 Move TTI to PID mapping to MAC 4 years ago
faluco 9d15a44c73
Port lib/phy to srslog (#2298)
* - Ported the channel class to srslog.
- Removed all newlines of log messages in lib/phy.

* Remove more newlines that use the C debug macros.
4 years ago
Andre Puschmann 6eed6f622f mac_nr: update RA related function in MAC/PHY interface
* expose interface to trigger PRACH from MAC
* indicate PRACH tx from PHY
* add temporary RAR PDU handling with Msg3 grant indication to PHY
4 years ago
Andre Puschmann 01acf95566 mac_rar_pdu_nr: update public interface to make it easier to access
* provide all subPDUs as const vector&
* return UL grant directly
4 years ago
Francisco 6925b40722 remove extra print when buffer pool is depleted 4 years ago
Francisco 798f1e57e6 fix byte buffer double free in EPC 4 years ago
Francisco d2ddcb0d4e avoid bzeroing byte buffers at every allocation for better runtime performance 4 years ago
Francisco 3265d940ec remove byte buffer pool cached member variables as they are unnecessary now. 4 years ago
Francisco 04ab4eefcd use new make_byte_buffer() helper method to create unique_byte_buffers 4 years ago
Francisco 8a9c326bcb remove old direct uses of byte_buffer_pool 4 years ago
Francisco 1e2153769e remove byte buffer pool cleanup method and unnecessary mutexes 4 years ago
Francisco 0c7c317be5 refactor byte_buffer class and move it to separate file 4 years ago
Andre Puschmann e227916819 mac_sch_pdu_nr: add SBSR, PHR and CRNTI packing 4 years ago
Andre Puschmann 6a0f3d0bc5 common_helper: remove newline 4 years ago
Andre Puschmann 4ca43c6804 mac_sch_pdu_nr: add unpacking helpers for CRNTI, SBSR and PHR CEs
* unpackers for CEs
* testcase with TV
4 years ago
Xavier Arteaga 8f57437e6f Add NR-PUSCH-DMRS amplitude option and procedure 4 years ago
Xavier Arteaga a19671802e Added SRSUE NR-PUSCH initial procedures 4 years ago
Pedro Alvarez 7b25eac47c Fix race condition in rlc_am_stress test and other fixes related to this
test. The race condition was being cause by write_sdu being called
simultanously to read_pdu, which could cause the read_pdu to try to get
the SDU info before it had been written by the write_sdu.

Changes in this commit include:
 - Make sure PDCP sn in included in RLC AM stress test.
 - Stop handling control PDU when TX is not enabled in RLC AM.
 - Fixed issue with length of the PDCP SN in rlc_stress_test.
 - Moved the place were sdu info erase was called to avoid double calls to erase
 - Tentative fix for race condition in rlc_am_stress test.
 - Added function to print information about undelivered_sdu_info_queue
   for debugging.
4 years ago
Pedro Alvarez 2b092ddc85 Initialize byte_buffer metadata to avoid unintialized variable warnings. 4 years ago
Pedro Alvarez 261c2b2e03 Removed limit to the undelivered SDUs info queue in RLC AM. Printing a warning if the queue is getting large instead. 4 years ago
Pedro Alvarez 24db20bcca Removed some unused variables after changing method of tracking notifications. Removed rlc_am_notify_pdcp test file. Testing is now in rlc_am_test.cc 4 years ago
Pedro Alvarez 6c071a784c Changed notification mechanisms to use map of acked SNs instead of acked bytes.
This was required due to an issue where bytes were counted twice when a
packet had been lost.
4 years ago
Pedro Alvarez 389cf4d943 Moved updating the notify info to it's own function. 4 years ago
Pedro Alvarez de669d214a Fix test header and queue_capacity check in RLC notifications.
Also, remove unecessary nullptr initializaion and fixup some newlines.
4 years ago
Pedro Alvarez de90b4753f Added the ability of the RLC AM to notify the PDCP of the acknowledged
PDCP PDUs. This includes:

- Modifying the byte_buffer_t to include PDCP SN meta-data. This way,
  the RLC can keep track of the ack'ed bytes for a specific PDCP PDU.
- Added in the RLC an `undelivered_sdu_info queue`, to keep track of the
  amount of ack'ed bytes and the total size of the PDCP PDU,
  so the RLC can know when delivery is finished.
- Added an interface between the PDCP and the RLC so that the RLC can
  notify the PDCP when it receives an ack from the status PDUs. The RLC
  passes to the PDCP a vector of all the ack'ed pdus in a rx'ed status PDU.
- Added some tests to the notify functionality. This includes some tests
  where the PDUs are acked imediatly, and one test where the PDU is
  retx'ed.
4 years ago
David Rupprecht 3dab82c42f Added interface that allows to update the lcid in case of a nr reconfiguration
nr rrc updates gw lcid if reconf was received
4 years ago
faluco 821925a273 - Upgrade to srslog the loggers in lib/mac.
- Adapted users of these classes and tests.
4 years ago
AlaiaL 9c764c299d - Removed the try/catch. Checking the allocation with std::nothrow
- Adjusting the code with the coding style.
4 years ago
Xavier Arteaga a2d9b436d9 SRSUE: add NR stack to PHY and initial decoded PDU push 4 years ago
Xavier Arteaga 77f0a53abd Added DCI Format 0_0 unpacking and more NR-PUSCH procedures 4 years ago
Francisco 9e25e95545 fix S1AP UE Capability Indication message. Created helper to log received S1AP messages 4 years ago
Francisco 78d1b8083a fix GTPU tunneling. Avoid forwarding packets to PDCP while the PDCP bearer is not yet created 4 years ago
Andre Puschmann 8e13f04684 mac_pcap: refactor MAC PCAP and include NR RAT into same object
after adding the thread-safe PCAP writer functionality to the EUTRA
MAC object it became clear that we don't wont to replicate the
same for the NR object.

This patch therefore refactors the class that now supports both EUTRA and
NR rats. The old mac_nr_pcap.[h/cc] has been deleted. All test-cases
and usages now use the new object that needs to pass the RAT type in
the ctor.

this patch addresses the last open point of #2160
4 years ago
faluco 199f1c953e Remove unneeded logmap headers. 4 years ago
faluco b014233662 - Port time related classes to srslog.
- Adapt tti_point_test to srslog.
4 years ago
faluco 1a5799a6ca - Replace loggers is network utils.
- Adapt tests that use network utils and callers.
4 years ago
faluco e9ed6f31ba Port mac_pcap to srslog. 4 years ago
faluco 79eca0980d - Ported fsm.h to srslog.
- Adapted and removed old loggers in tests and code that used fsm.h
4 years ago
faluco c8a4bf2613 - Fix unused variable in buffer_pool.h
- Replaced logger to srslog in log_args utility function.
4 years ago
faluco d37a07a47f Replaced loggers in buffer_pool.h 4 years ago
faluco f8485fb799 Replaced loggers to srslog in PNF and VNF classes. 4 years ago
faluco 96c07a69c0 Report the RLF event to the JSON event file in the enb. 4 years ago
Xavier Arteaga 2421f2cd99 Multiple PHY fixes and NR-PHY configuration refactor 4 years ago
Xavier Arteaga b652cd68a5 Refactored NR PHY configuration to accept multiple CORESETs/SearchSpaces 4 years ago
Xavier Arteaga 73001c9541 Implement NR-DCI conversion to string 4 years ago
Xavier Arteaga 83a5ce96ed Initial NR OFDM symbol size compatibility 4 years ago
Andre Puschmann f5c945dc2f mac_nr: add interface to set C-RNTI and contention ID from RRC
used during contention-based/free RA
4 years ago
Francisco 2bde28252c send UE capability indication through S1AP 4 years ago
Francisco d64ce7df77 implementation of S1 E-RAB Release Indication and Error Indication messages 4 years ago
faluco 806268f6cf
Por asn1 code in lib directory to srslog (#2253)
* Match hex dump indentation with srslog.

* Port asn1 utils to use srslog. Converted logging functions from taking varargs to variadic template functions.

* Remove trailing new lines in log lines from asn1 utils.

* First round of upgrades to srslog to asn1 tests.

* Second round of porting asn1 tests to srslog.
4 years ago
Andre Puschmann f88943653b mac: implement MAC RAR PDU unpacking for NR
* add class for mac_rar_pdu_nr
* extend test case
4 years ago
Andre Puschmann da9e3363f1 mac_pdu_nr: rename MAC PDU class for NR to adhere naming conventions
* mainly to have _nr as trailing name for filename and class
* also add "sch" to class and filename (RAR PDU will have extra class)
4 years ago
Francisco 2befbd1825 setup of forwarding tunnels during enb s1 handover 4 years ago
Francisco e8f6a436af update gtpu test to account for scenario of buffered PDCP SNs, and buffering of direct path until indirect tunnel is closed 4 years ago
Francisco 56ec2c286e add gtpu test for tunneling 4 years ago
Francisco 13649e4e19 Implement new GTPU functionality:
- multiple tunnels per E-RAB
- data forwarding between connected GTPU tunnels
- forwarding GTPU End Marker between connected tunnels
- TeNB GTPU handles in-sequence delivery when multiple tunnels for the same ERAB exist.
4 years ago
Andre Puschmann 3784439088 add backward as backtrace pretty printer
this patch adds the MIT-licensed header-only library backward-cpp
as possible alternative for our internal backtrace-to-file
writer.
4 years ago
faluco 711438f756
Port enb specific classes to use srslog (#2155)
* - Started porting the enb PHY layer to use srslog loggers.
- Updated srslog to manage the none level.

* Finished porting enb phy layer including the NR part.

* Ported MAC, GTPU, PDCP, RLC and S1AP enb classes to use srslog.

* Use new stack logger.

* Ported the enb RRC clases to use srslog.

* Remove unused log macros.

* Replace loggers in sched, sched_carrier, sched_helpers.

* Replaced loggers in sched grid.

* Replaced loggers in sched harq.

* Replaced loggers in sched ue.

* Replaced loggers in sched ue ctrl.

* Replace loggers in sched ue ctrl TPC.

* Replaced loggers in sched subclasses.

* Replaced loggers in rrc_meascfg_test

* Configure loggers in rrc_mobility_test.

* Fix compilation errors left out after the rebase.

* - Implement a custom log sink that will serve as a test spy to intercept and count the number of error and warning log entries.
- Adapt the erab_test_setup and rrc_mobility tests to use this new class and make them pass again.

* - Remove trailing new lines introduced in the rebase.
- Ported the sched_ue_cell class to srslog.

* Remove unused log member.

* Ported mac tests to srslog.

* - Removed remaining trailing newlines from log entries.

* Fix compiler errors detected in CI.

* Fix another static variable without definition passed to log lines.

* Fixed a bug in srslog::flush that would never end when the backend queue is full.

* Fetch the RRC logger instead of injecting it in the constructor.
4 years ago
Andre Puschmann 4709bacefd srsue: add DL NR-ARFCN param
* add PHY param to set DL NR-ARFCN
* use new band_helper class to convert ARFCNs to supported bands
* signal supported NR bands in UE capabilities
4 years ago
Andre Puschmann 617e0ddb67 band_helper: add helper class for RF bands
attempt to C++ify handling of radio bands and (E/NR)ARFCNs, etc.
4 years ago
Xavier Arteaga 4fe34b5e5b Apply minor comments in NR-PUCCH 4 years ago
Xavier Arteaga 4c6944b883 Implement NR-PUCCH Format 2 DMRS put/Estimate 4 years ago
Xavier Arteaga 958afaee60 Implement NR-PUCCH Format 2 encode/decode. Initial NR-PUCCH procedures. 4 years ago
Xavier Arteaga 4b6849b775 Polar: Add more information to ERROR traces 4 years ago
Xavier Arteaga 573ff24a47 Fix CRC for more sizes 4 years ago
Xavier Arteaga 1ee4d84f80 Added NR-PUCCH encode/decode format2 skeleton 4 years ago
Xavier Arteaga 4d96cf4a41 More NR-PUCCH support 4 years ago
Xavier Arteaga 697bdb4d6d Added NR-PUCCH Format 1 encoder, decoder and DMRS 4 years ago
Xavier Arteaga 33bb387f52 Initial NR-PUCCH formats 0 and 1 encoder 4 years ago
Xavier Arteaga e7562e5b3f Added ZC sequence LUT object 4 years ago
Xavier Arteaga d100919561 Initial NR-UCI encoder 4 years ago
David Rupprecht 1b19ee40e7 Added usim features for key derivation 4 years ago
David Rupprecht 306bb6b38b Added function for derive keys 4 years ago
David Rupprecht ceda458bb3 Added MAC NR to EUTRA and NR with stack interfaces including MAC config build
Moved MAC logical channel config to MAC interface types
4 years ago
David Rupprecht a6046ca875 Added funcs for asn flat config RLC and PDCP 4 years ago
David Rupprecht 64299960bd Added procedure for NR reconfiguration and RRC with NR complete 4 years ago
Xavier Arteaga 2f2114f377 Fix typo 4 years ago
Xavier Arteaga 732a220d42 Unified low-PAPR Ruv sequence generation 4 years ago
Xavier Arteaga 8de73988b8 Add real vector and complex scalar product 4 years ago
Xavier Arteaga 6bb1788df1 Added more NR CRC polynomials 4 years ago
Xavier Arteaga a7ca8ffff7 Moved prime number to different file 4 years ago
Xavier Arteaga ae3c5ec7d0 Moved all block code (32, O/K) to FEC block
Fix missing header

Fix missing header
4 years ago
Xavier Arteaga 95ce49acd4 Added more vector copy functions 4 years ago
Xavier Arteaga be6cb666e2 Initial moved block coding to FEC 4 years ago
Pedro Alvarez 350e90a030 Make RLC retransmissions deterministic. It was creating unpredictablity
in the RLC AM tests. See issue #2228
4 years ago
Francisco e0937d1dd1 add lcid check and increase limit to 10 4 years ago
Francisco bed979b722 fix out-of-bounds memory writing in the sched_interface::ue_cfg_t ue_bearers member 4 years ago