Addressed review comments:

1 - enb,cfg: fix typo
2 - enb,config: added back deleted config option
3 - ue,rrc_nr: fix wrong log level in log message
4 - enb,config: remove unused parameter

srsenb/rb.conf.example

@@ -11,8 +11,11 @@
 //       max_retx_thresh = 4;
 //     };
 //     dl_am = {                                                                                      
-//       t_reassembly = 50;
-//       t_status_prohibit = 50;
+//       t_reordering = 35;
+//       t_status_prohibit = 0;
+//     };
+//     enb_specific = {
+//      dl_max_retx_thresh = 32;
 //     };
 //   };
 // }
@@ -29,6 +32,9 @@
 //       t_reordering = 35;
 //       t_status_prohibit = 0;
 //     };
+//     enb_specific = {
+//      dl_max_retx_thresh = 32;
+//     };
 //   };
 // }
 

srsenb/src/enb_cfg_parser.cc

@@ -644,7 +644,7 @@ int field_5g_srb::parse(libconfig::Setting& root)
     cfg.present = true;
   }
 
-  // RLC-UM Should not exist section
+  // RLC-UM must not exist in this section
   if (root.exists("ul_um") || root.exists("dl_um")) {
     ERROR("Error SRBs must be AM.");
     return SRSRAN_ERROR;

srsgnb/hdr/stack/rrc/rrc_nr_config.h

@@ -46,7 +46,6 @@ struct rrc_cell_cfg_nr_t {
 typedef std::vector<rrc_cell_cfg_nr_t> rrc_cell_list_nr_t;
 
 struct srb_5g_cfg_t {
-  int                     enb_dl_max_retx_thres = -1;
   bool                    present = false;
   asn1::rrc_nr::rlc_cfg_c rlc_cfg;
 };

srsue/src/stack/rrc_nr/rrc_nr.cc

@@ -1062,7 +1062,7 @@ bool rrc_nr::apply_rlc_add_mod(const rlc_bearer_cfg_s& rlc_bearer_cfg)
       return false;
     }
   } else if (not is_drb) {
-    logger.error("Using default RLC configs for SRB%d", srb_id);
+    logger.debug("Using default RLC configs for SRB%d", srb_id);
     rlc_cfg = rlc_config_t::default_rlc_am_nr_config();
   } else {
     logger.error("In RLC bearer cfg does not contain rlc cfg");