fixing snprintf issue where return value was used for length calculation

5 years ago · 8f419c035b
parent 1155adf007
commit 8f419c035b
1 changed files with 7 additions and 6 deletions
--- a/srsue/src/stack/rrc/rrc.cc
+++ b/srsue/src/stack/rrc/rrc.cc
@ -572,12 +572,13 @@ void rrc::sort_neighbour_cells()
                  neighbour_cells[0]->phy_cell.cell.id,
                  neighbour_cells[0]->get_rsrp());
    for (uint32_t i = 1; i < neighbour_cells.size(); i++) {
-      n += snprintf(&ordered[n],
-                    512 - n,
-                    " | earfcn=%d, pci=%d, rsrp=%.2f",
-                    neighbour_cells[i]->get_earfcn(),
-                    neighbour_cells[i]->get_pci(),
-                    neighbour_cells[i]->get_rsrp());
+      int m = snprintf(&ordered[n],
+                       512 - n,
+                       " | earfcn=%d, pci=%d, rsrp=%.2f",
+                       neighbour_cells[i]->get_earfcn(),
+                       neighbour_cells[i]->get_pci(),
+                       neighbour_cells[i]->get_rsrp());
+      n += m;
    }
    rrc_log->info("Neighbours: %s]\n", ordered);
  } else {