Fix string to modulation conversion and apply clang-format

lib/include/srslte/phy/common/phy_common.h

@@ -453,7 +453,7 @@ SRSLTE_API float srslte_coderate(uint32_t tbs, uint32_t nof_re);
 
 SRSLTE_API char* srslte_cp_string(srslte_cp_t cp);
 
-SRSLTE_API srslte_mod_t srslte_str2mod(char* mod_str);
+SRSLTE_API srslte_mod_t srslte_str2mod(const char* mod_str);
 
 SRSLTE_API char* srslte_mod_string(srslte_mod_t mod);
 

lib/src/phy/common/phy_common.c

@@ -86,8 +86,8 @@ void srslte_cell_fprint(FILE* stream, srslte_cell_t* cell, uint32_t sfn)
 
 // TDD uplink-downlink configurations.
 // TS 36.211 v8.9.0 Table 4.2-2.
-static const srslte_tdd_sf_t tdd_sf[SRSLTE_MAX_TDD_SF_CONFIGS][SRSLTE_NOF_SF_X_FRAME] =
-  {{D, S, U, U, U, D, S, U, U, U},
+static const srslte_tdd_sf_t tdd_sf[SRSLTE_MAX_TDD_SF_CONFIGS][SRSLTE_NOF_SF_X_FRAME] = {
+    {D, S, U, U, U, D, S, U, U, U},
     {D, S, U, U, D, D, S, U, U, D},
     {D, S, U, D, D, D, S, U, D, D},
     {D, S, U, U, U, D, D, D, D, D},
@@ -128,8 +128,7 @@ uint32_t srslte_sfidx_tdd_nof_dw_slot(srslte_tdd_config_t tdd_config, uint32_t s
 
 // Number of DwPTS / GP / UpPTS symbols per subframe.
 // TS 36.211 v13.13.0 Table 4.2-2.
-static const uint32_t tdd_nof_sf_symbols[SRSLTE_MAX_TDD_SS_CONFIGS][3] =
-  {{3, 10, 1},
+static const uint32_t tdd_nof_sf_symbols[SRSLTE_MAX_TDD_SS_CONFIGS][3] = {{3, 10, 1},
                                                                           {9, 4, 1},
                                                                           {10, 3, 1},
                                                                           {11, 2, 1},
@@ -209,13 +208,18 @@ bool srslte_N_id_1_isvalid(uint32_t N_id_1)
   }
 }
 
-srslte_mod_t srslte_str2mod(char* mod_str)
+srslte_mod_t srslte_str2mod(const char* str)
 {
-  int i = 0;
+  char mod_str[7] = {};
 
-  /* Upper case */
-  while (mod_str[i] &= (~' '), mod_str[++i])
-    ;
+  // Convert letters to upper case
+  for (uint32_t i = 0; str[i] != '\0' && i < 6; i++) {
+    char c = str[i];
+    if (c >= 'a' && c <= 'z') {
+      c &= (~' ');
+    }
+    mod_str[i] = c;
+  }
 
   if (!strcmp(mod_str, "QPSK")) {
     return SRSLTE_MOD_QPSK;