fixed coverty issues

srslte/lib/ch_estimation/refsignal_ul.c

@@ -586,13 +586,9 @@ int srslte_refsignal_dmrs_pucch_gen(srslte_refsignal_ul_t *q, srslte_pucch_forma
         if (m == 1) {
           z_m = z_m_1; 
         }
-        if (w) {
+        for (uint32_t n=0;n<SRSLTE_NRE;n++) {
-          for (uint32_t n=0;n<SRSLTE_NRE;n++) {
+          r_pucch[(ns%2)*SRSLTE_NRE*N_rs+m*SRSLTE_NRE+n] = z_m*cexpf(I*(w[m]+q->tmp_arg[n]+alpha*n));
-            r_pucch[(ns%2)*SRSLTE_NRE*N_rs+m*SRSLTE_NRE+n] = z_m*cexpf(I*(w[m]+q->tmp_arg[n]+alpha*n));
+        }                                 
-          }                                 
-        } else {
-          return SRSLTE_ERROR; 
-        }          
       }
     }
     ret = SRSLTE_SUCCESS; 

srslte/lib/fec/viterbi37_port.c

@@ -50,10 +50,11 @@ int init_viterbi37_port(void *p, int starting_state) {
   struct v37 *vp = p;
   uint32_t i;
   
-  clear_v37(vp);
-  
   if (p == NULL)
     return -1;
+  
+  clear_v37(vp);
+    
   for (i = 0; i < 64; i++)
     vp->metrics1.w[i] = 63;
 

srslte/lib/fec/viterbi37_sse.c

@@ -69,12 +69,12 @@ void clear_v37_sse(struct v37 *vp) {
 int init_viterbi37_sse(void *p, int starting_state) {
   struct v37 *vp = p;
   uint32_t i;
-
-  clear_v37_sse(vp);
   
   for(i=0;i<64;i++)
     vp->metrics1.c[i] = 63;
 
+  clear_v37_sse(vp);
+
   vp->old_metrics = &vp->metrics1;
   vp->new_metrics = &vp->metrics2;
   vp->dp = vp->decisions;