rlc: remove timers and sdu queue length from RLC TM ctor

timers aren't used in RLC TM, also the default queue length is
fine to be used at all times.
master
Andre Puschmann 4 years ago
parent bb5dd92dca
commit 55336665b9

@ -34,12 +34,7 @@ namespace srslte {
class rlc_tm final : public rlc_common class rlc_tm final : public rlc_common
{ {
public: public:
rlc_tm(srslte::log_ref log_, rlc_tm(srslte::log_ref log_, uint32_t lcid_, srsue::pdcp_interface_rlc* pdcp_, srsue::rrc_interface_rlc* rrc_);
uint32_t lcid_,
srsue::pdcp_interface_rlc* pdcp_,
srsue::rrc_interface_rlc* rrc_,
srslte::timer_handler* timers_,
uint32_t queue_len = 16);
~rlc_tm() override; ~rlc_tm() override;
bool configure(const rlc_config_t& cnfg) override; bool configure(const rlc_config_t& cnfg) override;
void stop() override; void stop() override;

@ -393,7 +393,7 @@ void rlc::add_bearer(uint32_t lcid, const rlc_config_t& cnfg)
if (cnfg.rat == srslte_rat_t::lte) { if (cnfg.rat == srslte_rat_t::lte) {
switch (cnfg.rlc_mode) { switch (cnfg.rlc_mode) {
case rlc_mode_t::tm: case rlc_mode_t::tm:
rlc_entity = new rlc_tm(rlc_log, lcid, pdcp, rrc, timers); rlc_entity = new rlc_tm(rlc_log, lcid, pdcp, rrc);
break; break;
case rlc_mode_t::am: case rlc_mode_t::am:
rlc_entity = new rlc_am_lte(rlc_log, lcid, pdcp, rrc, timers); rlc_entity = new rlc_am_lte(rlc_log, lcid, pdcp, rrc, timers);
@ -412,7 +412,7 @@ void rlc::add_bearer(uint32_t lcid, const rlc_config_t& cnfg)
} else if (cnfg.rat == srslte_rat_t::nr) { } else if (cnfg.rat == srslte_rat_t::nr) {
switch (cnfg.rlc_mode) { switch (cnfg.rlc_mode) {
case rlc_mode_t::tm: case rlc_mode_t::tm:
rlc_entity = new rlc_tm(rlc_log, lcid, pdcp, rrc, timers); rlc_entity = new rlc_tm(rlc_log, lcid, pdcp, rrc);
break; break;
case rlc_mode_t::um: case rlc_mode_t::um:
rlc_entity = new rlc_um_nr(rlc_log, lcid, pdcp, rrc, timers); rlc_entity = new rlc_um_nr(rlc_log, lcid, pdcp, rrc, timers);

@ -23,17 +23,8 @@
namespace srslte { namespace srslte {
rlc_tm::rlc_tm(srslte::log_ref log_, rlc_tm::rlc_tm(srslte::log_ref log_, uint32_t lcid_, srsue::pdcp_interface_rlc* pdcp_, srsue::rrc_interface_rlc* rrc_) :
uint32_t lcid_, log(log_), pdcp(pdcp_), rrc(rrc_), lcid(lcid_)
srsue::pdcp_interface_rlc* pdcp_,
srsue::rrc_interface_rlc* rrc_,
srslte::timer_handler* timers_,
uint32_t queue_len_) :
ul_queue(queue_len_),
log(log_),
pdcp(pdcp_),
rrc(rrc_),
lcid(lcid_)
{ {
pool = byte_buffer_pool::get_instance(); pool = byte_buffer_pool::get_instance();
} }

Loading…
Cancel
Save