fix coverity issues

master
Andre Puschmann 7 years ago
parent 8258c28a4c
commit 07cd9ae528

@ -185,7 +185,8 @@ void parse_args(int argc, char **argv) {
cell.id = atoi(argv[optind]); cell.id = atoi(argv[optind]);
break; break;
case 'x': case 'x':
strncpy(mimo_type_str, argv[optind], 32); strncpy(mimo_type_str, argv[optind], 31);
mimo_type_str[31] = 0;
break; break;
case 'b': case 'b':
multiplex_pmi = (uint32_t) atoi(argv[optind]); multiplex_pmi = (uint32_t) atoi(argv[optind]);

@ -2243,9 +2243,9 @@ LIBLTE_ERROR_ENUM liblte_s1ap_pack_imsi(
if(ie != NULL && if(ie != NULL &&
ptr != NULL) ptr != NULL)
{ {
// max length of IE buffer is 32, so limit // max length of IE buffer is 8, so limit
if (ie->n_octets > 31) { if (ie->n_octets > 7) {
printf("Length in struct exceeds buffer (%d > 31).\n", ie->n_octets); printf("Length in struct exceeds buffer (%d > 7).\n", ie->n_octets);
return LIBLTE_ERROR_ENCODE_FAIL; return LIBLTE_ERROR_ENCODE_FAIL;
} }

@ -232,8 +232,8 @@ void phch_worker::work_imp()
/** Calculate RSSI on the input signal before generating the output */ /** Calculate RSSI on the input signal before generating the output */
// Average RSSI over all symbols // Average RSSI over all symbols (make sure SF length is non-zero)
float rssi_dbm = 10*log10(srslte_vec_avg_power_cf(signal_buffer[0], SRSLTE_SF_LEN_PRB(cell.nof_prb))) + 30; float rssi_dbm = SRSLTE_SF_LEN_PRB(cell.nof_prb) > 0 ? (10*log10(srslte_vec_avg_power_cf(signal_buffer[0], SRSLTE_SF_LEN_PRB(cell.nof_prb))) + 30) : 0;
if (isnormal(rssi_dbm)) { if (isnormal(rssi_dbm)) {
phy->avg_rssi_dbm = SRSLTE_VEC_EMA(rssi_dbm, phy->avg_rssi_dbm, phy->args->snr_ema_coeff); phy->avg_rssi_dbm = SRSLTE_VEC_EMA(rssi_dbm, phy->avg_rssi_dbm, phy->args->snr_ema_coeff);
} }

Loading…
Cancel
Save