Ismael Gomez
a1f0f8de35
Add callback to RLC to indicate BSR for TX and reTX queues (used in ENB) ( #1361 )
5 years ago
Andre Puschmann
1eaa99530f
rlc_am: tiny refactor of rlc_amd_pdu_header_t
...
mainly turning header into proper class and adding default init value
5 years ago
Francisco Paisana
791d84e639
created error_type and cleaned up expected
5 years ago
Francisco Paisana
975d004224
fix compilation error
5 years ago
Francisco Paisana
a2b76a4a5f
use references rather than pointers
5 years ago
Andre Puschmann
99c3975f83
remove CMake option to disable glibc header for IPv6
...
we've added this to allow building for older glibc
version that cause issues with redefining some structs.
this patch removes the flag and auto-detects it using the glibc version
5 years ago
Francisco Paisana
3da8464a21
fix compilation issue with lack of override keyword and scoping in fsm
5 years ago
Xavier Arteaga
01e224348c
Fix compilation for NR HL
5 years ago
Xavier Arteaga
77d5dedddc
Fix LGTM warnings and recommendations
5 years ago
Pedro Alvarez
ad0abe740b
Added support to PDCP SN len of 7. Also added a check for valid configs in pdcp entity.
5 years ago
Francisco Paisana
c09f76ed6c
unified stack task defer method
5 years ago
Francisco Paisana
a2ade9edd1
break down rrc_interface_types.h into multiple files. moved pdcp_config.h to same folder
5 years ago
Andre Puschmann
9307a54512
pdcp: adding enable_security_timed() method
...
this is an extension to the currently available security
configuration and activation methods provided by PDCP.
The new call allows to specify a Rx and Tx SN after which the
entire security config, i.e. integrity and ciphering, should
be enabled.
this is mainly required for the PDCP entity of the conformance
testing SS but could potentially also be used by the eNB
to enable security for PDCP after sending the SecModeCommand
for example.
the extra call was added to not break the existing API.
5 years ago
Pedro Alvarez
f4d648b26e
Removed rx_count state variable from PDCP LTE entity. Updated get_bearer_status(...) acordingly. Added get_last_submitted_rx_count() getter.
5 years ago
Francisco Paisana
30ae2226c1
common interface for stack multiqueue tasks, background tasks and timers
5 years ago
Francisco Paisana
575475962f
the rlc um rx does not need a mutex bc it is always called in the stack thread
5 years ago
Francisco Paisana
8aa44928e9
fix 5g compilation errors
5 years ago
Francisco Paisana
344eaf49ec
use logmap in the whole enb and ue
5 years ago
Francisco Paisana
9bde6d442c
removed the uneeded locks from the pdcp
5 years ago
Francisco Paisana
f3890b2908
use of mutexed cache to store the valid lcids that can be checked from gw thread
5 years ago
Francisco Paisana
46a1be3e76
updated mac-rlc interface to use unique_byte_buffer
5 years ago
Francisco Paisana
597334c4bf
limit the rlc queue size for suspended bearers
5 years ago
Xavier Arteaga
e832769ae6
Updated copyright
5 years ago
Pedro Alvarez
96c82b3fc6
Moved PDCP configs to pdcp_config.h. Added `as_security_cfg_t` structure to hold access stratum keys.
...
Refactored PDCP, RRC and USIM accordingly.
5 years ago
Andre Puschmann
9e113f8b27
pdcp: allow to configure security for rx/tx seperately
...
previously PDCP security (integrity and ciphering) could only
be enabled for both Rx and Tx at the same time.
this, however, caused an issue during the conformance testing in which,
in TC_8_2_1_1() for example, the eNB sends a SecModeCommand and a
RRC Reconfiguration in the same MAC TB. In this case, the eNB
needs to be able to enable DL security right after sending the SecModeCmd
in order to send the RRCReconfig encrypted. However, enabling UL security needs
to be postponed until after the SecModeComplete is received.
This patch allows to enable PDCP security for rx/tx independently if
that is needed. The default way is like before, enabling it for tx/rx at
the same time.
5 years ago
Pedro Alvarez
aecfb151ce
Apply clang-format to the lib in preperation for PR.
5 years ago
Pedro Alvarez
d98b888ca4
Separating PDCP read_header function from discard_header_function. Starting to add DRB unit test.
5 years ago
Pedro Alvarez
284a0f7b4e
Starting to add PDCP LTE unit tests. Test failing for now.
5 years ago
Pedro Alvarez
b841859220
Moved pdcp test functionality to a common header. Fixed linking issue in 5GNR PDCP
5 years ago
Pedro Alvarez
5f39c79bda
Moved some more packing functions to base class.
5 years ago
Pedro Alvarez
fdd67c3865
Fix issue in integrity check in PDCP SRBs. Moved some helper functions to the pdcp base class
5 years ago
Pedro Alvarez
965b0ee99b
Starting to fix handling of RX SRB PDUs in PDCP.
5 years ago
Xavier Arteaga
5b14a7d585
Implementation Tx RLC suspend
5 years ago
Ismael Gomez
52716f8716
Process HO complete in the background to avoid heap-after-use bug when PHY measurements are reported during a HO
...
rrc_meas refactor. Need to split commit
Fix typo
Temporal commit
Apply rx_gain_offset to neighbour cell measurements
srsLTE: modify TESTASSERT Macro to follow codeline
SRSUE: prevent RRC from having serving cell in neighbour list
SRSUE: DL HARQ does not need Time Aligment Timer. UL is disabled using PUCCH resources release
SRSUE: extend intra-frequency to CA SCell
SRSUE: fix confusing/ambiguous code in the RRC measurements and fix concurrency issue
SRSUE: remove RRC measurement report triggers when measurements are modified or HO succesful
SRSUE: fix compilation issues and Reest SIB indexes
Fixes sync using incorrect cell configuration when search cell does not find a correct cell
Small refactor to remove measurement report triggers always after removing measurement
SRSUE: Removed SIC PSS from UE
SRSUE: fix inter-frequency reestablishment and added more traces
SRSUE: Fix compilation issue
5 years ago
Andre Puschmann
6ec573987a
remove default value for 'blocking' param from pdcp::write_sdu()
...
there were two defaults and one was shadowing the other. This
commit removes both defaults and uses blocking-mode for RRC
calls to PDCP in the UE. The eNB write_sdu() uses the non-blocking
mode by default. We have to review the eNB's RRC perhaps and use blocking
there too and non-blocking only for data plane
5 years ago
Pedro Alvarez
c5979f59eb
Clang format UE, eNB and lib ( #850 )
...
* Clang-formated UE, eNB and lib.
* Fixed compiling errors from clang-format.
* Fix linking issues introduced by clang-format
* Fix poor formating in initializing arrays of arrays.
* Fix mistake in conflict resolution on rm_turbo.c
* Re-apply clang format to gtpc_ies.h
5 years ago
Francisco Paisana
6b4488d5c1
added sending of enb status transfer from SeNB
5 years ago
Pedro Alvarez
e1cdd51eba
Clang-formated before pull request
5 years ago
Pedro Alvarez
61958af70b
Timer removes itself from the map upon expiration
5 years ago
Pedro Alvarez
60feab3d7b
Added map to keep discardTimers in PDCP NR entity.
5 years ago
Pedro Alvarez
e68956bcf6
Adding discard timer timeout to PDCP config.
5 years ago
Pedro Alvarez
2e7ddef038
Continue to add discard_sdu to RLC interfaces.
5 years ago
Pedro Alvarez
a77dd4e959
Starting to add boiler-plate code to support Discard at RLC.
5 years ago
Pedro Alvarez
7ccc7d1d20
Starting to notify RLC upon PDCP discard (NR)
5 years ago
Pedro Alvarez
f3eeaf401a
Removed unecessary lambda redirection in pdcp_entity_nr
5 years ago
Andre Puschmann
9493e7492c
add initial RLC AM NR status PDU packing code including tests
5 years ago
Andre Puschmann
db2c43553e
add basic rlc_am_base class containing data/control PDU check
5 years ago
Andre Puschmann
b32a4cf294
add RLC AM NR PDU packing and unpacking
5 years ago
Pedro Alvarez
d4fb4d8c86
Fixup clang-format in pdcp before PR.
5 years ago
Pedro Alvarez
15613465cf
Moving some initialization from init function to constructor in the PDCP entities.
5 years ago
Andre Puschmann
b20f7ba541
refactor RLC UM and add NR receiver
5 years ago
Andre Puschmann
03bd63d9ab
rename RLC AM class to RLC AM LTE
5 years ago
Andre Puschmann
2d126371f6
adopt PDCP NR to use new timer class
5 years ago
Pedro Alvarez
ea0a413c8a
Added check on wether the PDCP entity is initialized.
5 years ago
Pedro Alvarez
cede56abe1
Fix small typo
5 years ago
Pedro Alvarez
8511fca940
Clang-formated to prepare for PR
5 years ago
Pedro Alvarez
d3a07fdd38
Added check for overflow at RX. Adding more tests.
5 years ago
Pedro Alvarez
62230c6ab9
Starting to have overflow protection in PDCP NR tx
5 years ago
Pedro Alvarez
1d56fa6308
Improved speed of tests for COUNT wraparound, by setting the PDCP initial state.
5 years ago
Pedro Alvarez
517ce8a220
Added test to test out of order COUNT wraparoung. Added setters to help with the testers.
5 years ago
Pedro Alvarez
b7fdcaabc5
Starting to add reordering timers at PDCP NR entity. Timeout seems to be triggered correctly and pass the SDUs to the upper layers when it expires. First tests passing.
5 years ago
Pedro Alvarez
45d298507b
Starting to move pdcp configs to rrc_interface_types. Starting to add test for reorder timeout.
5 years ago
Pedro Alvarez
6cf2bd7bc3
Starting to add reordering queue in the PDCP.
5 years ago
Pedro Alvarez
ff15ed5018
Starting to add timers to the NR PDCP.
5 years ago
Francisco Paisana
d2c56caf7e
applied new timer class to the whole code base
5 years ago
Andre Puschmann
f07a9277a0
fix RLC AM issue where an invalid status PDU was generated
...
happens when very small grant is provided and the status
PDU generation fails because of a too small grant
add extra check to prevent that ACK_SN is also in NACKS list
5 years ago
Andre Puschmann
c99d5077c8
add RLC UM NR transmitter
5 years ago
Andre Puschmann
d9577f0e1e
suppress type-limit warning issued by some compilers by making var signed
...
Used to happen with older gcc giving:
"rlc_am.cc:1791:22: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]"
5 years ago
Francisco Paisana
67d6a25194
Moving mac timers to stack timers ( #638 )
...
* first step towards moving MAC timers to stack. Mac is still using its own timers. srslte::timers class can be restructured.
* moved timers out of the UE MAC
5 years ago
Francisco Paisana
c9d3b61038
added resumable procedures to make RRC and NAS non-blocking
5 years ago
Andre Puschmann
e42449532b
fix wrong namespace definition in various places
5 years ago
Pedro Alvarez
6efa944b5e
Removed srslte prefix from pdcp_config_t
5 years ago
Pedro Alvarez
0e7c5634f1
Added comment to PDCP maximum SDU size.
5 years ago
Pedro Alvarez
dd56d08269
Replaced byte_buffer by array in PDCP base
5 years ago
Pedro Alvarez
61051b4cb3
Changed PDCP NR read_data_header to return SN.
5 years ago
Pedro Alvarez
f90b69e5f4
More clang-format for PDCP
5 years ago
Pedro Alvarez
491695ab77
Clang-formated PDCP NR PR.
5 years ago
Pedro Alvarez
adfe9f950e
Fixed issue in computing the SN. Added test for packets received in sequence for PDCP NR. Test is passing now.
5 years ago
Pedro Alvarez
af2b593b8c
Added check for integrity in test. First Rx PDCP NR test passing.
5 years ago
Pedro Alvarez
d3b6828082
Changed PDCP configuration to explicitly have tx and rx direction. Decrypt on PDCP NR seems fine.
5 years ago
Pedro Alvarez
ea3c44e9ac
Removing header before decrypting. Continuing to add decryption tests to PDCP NR
5 years ago
Pedro Alvarez
a42726f836
Fixed hdr_len_bytes in PDCP NR. Tx seems OK now.
5 years ago
Pedro Alvarez
73e30743d1
Added enum to PDCP config to replace two bools.
5 years ago
Pedro Alvarez
457f35699d
Reverted back to a single config structure between PDCP NR and PDCP LTE.
5 years ago
Pedro Alvarez
810cacdc02
Adding write_data_header and append_mac helper functions to PDCP NR entity.
5 years ago
Pedro Alvarez
c9e99443d8
Adding PDCP NR Tx test.
5 years ago
Pedro Alvarez
8e8a7a4154
Add more logic to PDCP NR tx logic.
5 years ago
Pedro Alvarez
2081b22465
Added PDCP_SN_LEN constants. Added bearer_id and direction back to the pdcp_entity_base.
5 years ago
Pedro Alvarez
8e1b9b9f5b
Starting to implement the receive function of PDCP NR.
5 years ago
Pedro Alvarez
d7a2721bb0
Adding algorithm to get COUNT for PDCP NR. Added convinience functions to manipulate HFN, SN and COUNT.
5 years ago
Pedro Alvarez
52f75c3cf2
Starting to add PDCP NR state variables.
5 years ago
Pedro Alvarez
2449f901f0
Fixed error in setting Kint in pdcp_entity_lte.
5 years ago
Pedro Alvarez
1944bf9a80
Continue to split pdcp_entity_lte and pdcp_entity_nr. Compiling now.
5 years ago
Pedro Alvarez
bd91678d98
Continuing to split pdcp_entity into pdcp_entity_lte and pdcp_entity_nr
5 years ago
Pedro Alvarez
005d03cb1a
Starting to split pdcp_entity into pdcp_entity_lte and pdcp_entity_nr to support NR PDCP
5 years ago
Ismael Gomez
11d42acb3a
Fix using deallocated PDU
5 years ago
Ismael Gomez
8c41625599
Add RLC suspend and resume
5 years ago
Francisco Paisana
58e2e51044
removed rlc_interfaces. The rlc_cnfg types are now part of the rrc_interface_types. Removed implicit RB initialization in the RLC.
5 years ago
Francisco Paisana
b936629221
removed rrc asn1 header from bcd_helpers, from rlc_interface, and rlc tests
5 years ago
Pedro Alvarez
498f1b8e4b
Small PDCP fixes:
...
- Moved most the initialization of the pdcp_entity to the header.
- Initilize some variables in gtpu_ntoa.
- Removed debug print.
- Format eNB GTP-u debugging code.
5 years ago
Pedro Alvarez
53d2220aab
Resolved conflicts with unique pointers after rebase in PDCP entity.
5 years ago
Pedro Alvarez
b97d1191f4
Added more debug info at eNB GTP-U. Changed the pdcp_entity to follow the standard more strictly for RLC AM DRBs.
5 years ago
Pedro Alvarez
f4fd6034ba
Starting to add separate functions for PDCP handling for UM DRBs and AM DRBs
5 years ago
Pedro Alvarez
6cbcc5154d
Starting to use received SN to do user plane decription.
5 years ago
Andre Puschmann
58763fb714
stack: move initialization of log object into ctor
...
this fixes the issue when the stack is torn down if, for example,
the radio couldn't be loaded correctly. it will hence call stop() on all stack
components which are not initialzized yet, and logging therefore doesn't work.
the log object is know during contruction time and therefore can be passed
in as soon as possible.
5 years ago
Andre Puschmann
e0a28cf4c0
simplify PDCP init and also bypass it for SRB0 on eNB
5 years ago
Andre Puschmann
218f136254
remove default PDCP entity for SRB0
5 years ago
Andre Puschmann
abef6ce152
move own ipv6 header definition into own header file and use it in tft filter
5 years ago
Andre Puschmann
acbe7fabe4
rlc: fix class member initialization
...
uninitialized member detected by coverity, now converted all default
initialization to be done in class definition
6 years ago
Francisco Paisana
415d3418b6
reorganized enb to mirror ue director/class structure with a stack class
6 years ago
Andre Puschmann
e8d6236975
remove init for all RLC TM/UM/AM
...
- all RLC entities are now initialized during contruction
- there is no need to check for, e.g., existance of timers, during
runtime
- there is also no need to call re-init during resume
- timers are freed in dtor
6 years ago
Ismael Gomez
f24c0cef8c
Use timer interface instead of local boolean to query timer state
6 years ago
Ismael Gomez
14b526f2aa
Add PDCP per-bearer reestablish
6 years ago
Ismael Gomez
ade720e032
Add RLC resume procedure
6 years ago
Francisco Paisana
3bedc93ba5
added _t to unique_byte_buffer type
6 years ago
Francisco Paisana
bc01a5ecda
changed block_queue api to return back the unique buffer in case it fails to push it to the queue
6 years ago
Francisco Paisana
f4aa03154d
change queue read and other functions apis
6 years ago
Francisco Paisana
f469e2178b
replaced byte_buffer_t allocated by the buffer pool for unique_byte_buffer which is safer and easier to use
6 years ago
Francisco Paisana
0976ea6f27
created a unique byte buffer that automatically deallocates
6 years ago
yagoda
c25f3b0acf
increasing rlc UM window size for eMBMS, small adjustment to eMBMS PHY common
6 years ago
Andre Puschmann
4b01a2e4a0
update copyright notice
6 years ago
Ismael Gomez
7780b1aba5
add tdd/ca support
6 years ago
David Rupprecht
eb3a83ac45
User Plane key in configuration interface
6 years ago
Andre Puschmann
e84d26ae4e
fix RLC UM reestablishment
6 years ago
Andre Puschmann
86232c143e
expose RLC tx queue length through config struct
6 years ago
Francisco Paisana
0204db2e12
new asn1 rrc library
6 years ago
Andre Puschmann
955f5dd37a
add mutex in pdcp entity
...
write_sdu and write_pdu are not re-entrant because all functions
that deal with the counters, e.g. integrity check and generate,
must be protected because MAC threads may call them at the same time.
this addresses issue #254
6 years ago
Andre Puschmann
0e7512f349
fix RLC UM params for eMBMS
6 years ago
Andre Puschmann
c3441046c9
simplify RLC buffer status query procedures
...
- add a simple and low-overhead has_data() method to check whether
an RLC entity has data to transmit or not
- use this method for all calls that are actually not interested
in the amount of data to send
- use the more expensive get_buffer_state() for all cases where
the actual size of the buffer is of importance
6 years ago
Andre Puschmann
df40259c26
fix issue in PDCP when bearer ID for DRBs was not starting with 1
6 years ago
Andre Puschmann
b71dab87f1
add function to query if RLC bearer exists (the implementation)
6 years ago
Andre Puschmann
6ca0d4494a
do not transmit new PDUs after calling stop
6 years ago
Andre Puschmann
ebadf3029e
Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next
6 years ago
Andre Puschmann
e06e5b8b60
limit maximum allowd RLC SDU size
6 years ago
Pedro Alvarez
d443604661
Merge next into gtp_cleanup_sn. Fixed some conflicts.
6 years ago
Andre Puschmann
96815e3a5f
fix RLC AM handling of bigger MAC grants
...
- fix concatenation and header reconstruction
6 years ago
Andre Puschmann
a6d9181881
fix RLC UM issue with very large MAC grants
6 years ago
Paul Sutton
0e4ab77fb0
GTPU cleanup, adding support for GTPU echo response ( #265 )
6 years ago
Pedro Alvarez
28f377128b
Making sure both Echo request and echo response are supported types. Echo response/request is working again.
6 years ago
Pedro Alvarez
a2befbd949
Fix mistake in echo reply/response message type.
6 years ago
Pedro Alvarez
e925ef0a42
Added some more debug infor to error prints. Making sure that packet is not sent from the eNB if there is an error in the GTP-U header packing. Fixed error in checking msg_type.
6 years ago
Pedro Alvarez
c1f633c5c7
Dropping bitfields for now. Using #defines and uint8_t for the flags.
6 years ago
Pedro Alvarez
ee04639337
Changed gtpu header flags to use a bitfield. Fixing compilation issues.
6 years ago
Paul Sutton
569a7cbc94
GTPU cleanup, adding support for GTPU echo response
6 years ago
Andre Puschmann
86e02921f0
fix regression in RLC base introduced during refactor causing eMBMS to fail
6 years ago
Andre Puschmann
22b4396c39
increase default tx_queue length for RLC UM and AM
...
- With the current default tx queue length (16 SDUs) the BSR reported by the UE
is too low if the size of the SDU is relativly small (e.g. 100 B).
This effectivly causes the eNB to only allocate a small grant
to the UE and thus reduces the UL throughput for small SDUs.
6 years ago
Andre Puschmann
ba87819ff1
retransmit random RLC AM PDU in case tx window is full
6 years ago
Andre Puschmann
34535c7efb
fix RLC AM issues reported by clang-tidy
6 years ago
Andre Puschmann
d981f129e0
Merge branch 'master' into next
6 years ago
Joseph Giovatto
2dddfa2aac
added ability to track tput per bearer ( #233 )
...
added mac_metrics for ul/dl harq retex counts
6 years ago