Pedro Alvarez
6d55560256
lib,rlc_am_nr: check if ACK SN is within rx_window. Stop
...
t-PollRetransmit only if status report is not ignored
3 years ago
Pedro Alvarez
c457132570
lib,rlc_am_nr: avoid if that would always be true when checking the
...
out-of-order ACK. Check ACK_SN instead of stop SN with Tx_Next_Ack
3 years ago
Pedro Alvarez
7c42b09e89
lib,rlc_am_nr: check if rx ACK is smaller than current Tx_Next_Ack
3 years ago
Robert Falkenberg
0c24e9c55f
lib,rlc_am_nr: clean retx_queue of ACK'ed SDUs
3 years ago
Robert Falkenberg
95480297f4
lib,rlc_am_nr: unit test removal of ACK'ed SDUs from retx queue
3 years ago
Robert Falkenberg
e20cb2e0c8
lib,rlc_am_nr: empty PDUs shall not increment metrics.num_tx_pdus
3 years ago
Pedro Alvarez
2c5a74340b
lib,rlc_um_nr: reduce log level of message
3 years ago
Robert Falkenberg
7b77558fd4
lib,rlc_um_nr: add log message if tx_sdu_queue has no non-null SDU
3 years ago
Pedro Alvarez
6a40fd8411
lib,pdcp_nr: disabe discard timer with RLC UM
3 years ago
Pedro Alvarez
92a6d8ec66
lib,rlc_um_nr: fix issue with discard in RLC UM NR
3 years ago
Pedro Alvarez
68b6facac8
lib,pdcp_nr: log RLC mode in PDCP configuration
3 years ago
Robert Falkenberg
9687af7660
add missing include for build with GCC 12
...
Related info: https://gcc.gnu.org/gcc-12/porting_to.html
3 years ago
Pedro Alvarez
97b32f2fb6
rrc_nr,utils: fix generation of RLC configs from ASN.1 structs created from cfg parser.
3 years ago
Pedro Alvarez
3620308940
lib,pdcp_nr: added options to select re-ordering timer
3 years ago
Pedro Alvarez
1fecae9b5a
lib,pdcp_nr: added ifdef to select pdcp_entity_nr
3 years ago
Robert Falkenberg
ebbecbe27c
lib,rlc_am_nr: cosmetic change -- clang format
3 years ago
Robert Falkenberg
9a34d4d81b
lib,rlc_am_nr: unit tests for NACK merging
3 years ago
Robert Falkenberg
ecc995bd4b
lib,rlc_am_nr: merge NACKs across SN overflows
3 years ago
Robert Falkenberg
e9156d4ba2
lib,rlc_am_nr: status PDU creation supports NACK range
3 years ago
Pedro Alvarez
283199d54f
lib,rlc_am_nr: added unit test for nack ranges without SO
3 years ago
Pedro Alvarez
e01bbb8f79
lib,rlc_am_nr: support also NACK ranges without SO_start/end. Fix for NACK ranges of sizee == 1
3 years ago
Pedro Alvarez
6d8357bee9
lib,rlc_am_nr: deleted error log for unhandled NACK ranges
3 years ago
Pedro Alvarez
de67d88ca9
lib,rlc_am_nr: fix buffer state checker in rx status report with ranges test
3 years ago
Pedro Alvarez
c386d89577
lib,rlc_am_nr: fix nack ranges with so
3 years ago
Pedro Alvarez
855ab8f7fd
lib,rlc_am_nr: added unit test to nack ranges
3 years ago
Pedro Alvarez
444783e2f2
lib,rlc_am_nr: added handling of nack ranges at RX
3 years ago
Pedro Alvarez
407c44617c
lib,rlc_am_nr: fix typo
3 years ago
Pedro Alvarez
840aac7fda
lic,rlc_am_nr: removed stop_no_lock(), it is not necessasry
3 years ago
Pedro Alvarez
ea532cbf41
lib,rlc_am_nr: added stop() method to RX entity
3 years ago
Pedro Alvarez
2f8fd7a483
lib,rlc_am_nr: add stop() method to TX entity
3 years ago
Robert Falkenberg
828c7ec02d
lib,rlc_am_nr: Change log level for already acked (removed) RETX.
3 years ago
Andre Puschmann
70eaec21e2
all: fix uninitialized variables detected by coverity
3 years ago
Pedro Alvarez
3714548391
lib,rlc_am_nr: re-enable rlc am nr stress tests
3 years ago
Pedro Alvarez
e023cecd28
lib,rlc_am_nr: lower log level of unsupported NACK ranges from warning to error
3 years ago
Pedro Alvarez
5992303aca
lib,rlc_am_nr: make sure we react to polling bit, even if SDU/SDU
...
segment is a duplicate/overlapping.
3 years ago
Pedro Alvarez
68cc16ad68
lib,rlc_am_nr: fix assert triggered by receiving duplicate segments
3 years ago
Andre Puschmann
cbc0b43621
lib,radio,rf: fix printf arguments
3 years ago
Andre Puschmann
67f66e7d63
radio_dummy: fix potential result overflow by converting to wider type first
3 years ago
Ali_UBUNTU18.04
3fdec57a47
liblte_mme: Added sec_hdr_type check in liblte_mme_pack_deactivate_eps_bearer_context_request_msg
3 years ago
Pedro Alvarez
ee06a8893b
lib,rlc_am_nr: fix wrong full sdu queue check
3 years ago
Pedro Alvarez
9dbb7acffa
lib,rlc_am_nr: ensure early return if there is not enough space for payload plus header
3 years ago
Pedro Alvarez
0c562336d2
lib,rlc_am_nr: change update of POLL SN to be the currently being
...
transmitted SDU (if not an RETX)
3 years ago
Pedro Alvarez
4d59989f72
lib,rlc_am_nr: fix t-PollRetransmion timer test to work with 18bit SN
3 years ago
Pedro Alvarez
abfa113576
lib,rlc_am_nr: fix wrong buffer state calculation for segment RETXes
...
when SO=0
3 years ago
Pedro Alvarez
d7a32a0ea5
lib,rlc_am_nr: sending first SDU segment if t-PollRetransmit expires
...
instead of full SDU. Adressing test accordingly
3 years ago
Pedro Alvarez
361d3f46e0
lib,rlc_am_nr: starting to fix retx poll expiry test
3 years ago
Pedro Alvarez
42f7094a0e
lib,rlc_am_nr: changed order in which the ack of poll SN is checked
3 years ago
Pedro Alvarez
0ee20d7a0c
lib,rlc_am_nr: addressing reviewers comments:
...
* Tweaked logs
* Addressed a missing modulus in handling a state variable.
* made restarting t-PollRetransmission look more like the comment.
3 years ago
Pedro Alvarez
2425985ab2
lib,rlc_am_nr: added test for poll retx timer
3 years ago
Pedro Alvarez
0551244d64
lib,rlc_am_nr: make sure has_data returns true when there are retxs. Make sure t-PollRetransmit is not started if it is set to infinity.
3 years ago
Pedro Alvarez
6ff18272e0
lib,rlc_am_nr: added debug_window function
3 years ago
Pedro Alvarez
d2d3c4140a
lib,rlc_am_nr: make sure that sdu_under_segmentation is set before calculating the polling bit
3 years ago
Pedro Alvarez
ffb0c21903
lib,rlc_am_nr: stop poll retransmission if POLL_SN is ACKed/NACKed
3 years ago
Pedro Alvarez
515f2099be
lib,rlc_am_nr: added SN to get pdu poll function. Setting POLL_SN now.
3 years ago
Pedro Alvarez
f93d699abc
lib,rlc_am_nr: retransmit first un-acked SDU when t-Poll_retransmit
...
expires
3 years ago
Pedro Alvarez
b3edced44a
lib,rlc_am_nr: added t_poll_retransmit to tx entity
3 years ago
Robert Falkenberg
c0546b8634
lib,rlc_am_nr: increase verbosity on invalid ACK
3 years ago
Robert Falkenberg
4028b26274
lib,rlc_am_nr: add info_state()
3 years ago
Robert Falkenberg
c16071a3ac
lib,rlc_am_nr: extend unit tests to check buffer state
3 years ago
Robert Falkenberg
d66c76b374
lib,rlc_am_nr: consider size of all pending retx in buffer state
3 years ago
Robert Falkenberg
ced6cf6e40
lib,rlc_am_nr: consider SDU under segmentation in buffer state
3 years ago
Robert Falkenberg
e0acb7b81c
lib,rlc_am_nr: update buffer-state-related unit test
3 years ago
Robert Falkenberg
20201cd89b
lib,rlc_am_nr: cosmetic change, add comment
3 years ago
Pedro Alvarez
8a27cdf45a
lib,rlc_am_nr: fix incorrectly stopping the t-StatusProhibit
3 years ago
Pedro Alvarez
63877ba209
lib,rlc_am_nr: make sure that tx_buffer_queue size is configurable
3 years ago
Andre Puschmann
8505523928
ue,ue_sync: fix CP setting for find and track objects
...
move setting of CP for find and track objects further down
after the respective objects have been resized and updated
there frame_len, fft_size, etc. members.
Doing this too early cause a segfault with div by zero
because the values were all zero
3 years ago
Andre Puschmann
225a7741b3
pssch_ue: fix uninitialized variables
3 years ago
Andre Puschmann
d854bbc22e
enb,rrc: remove hard-coded SCG bearer config
...
Use 5QI config when configuring secondary cell group bearer for NSA.
The 5QI used for this needs to match with the QCI used for the initial
LTE DRB.
This allows to use RLC AM over NSA.
3 years ago
Andre Puschmann
319a185eba
phy_common_test: fix test when compiled with USE_LTE_RATES
3 years ago
Robert Falkenberg
ca37eed664
lib,rlc_am_nr: default initialize member in class definition
3 years ago
Robert Falkenberg
85c95d94b2
lib,rlc_am_nr_test: add retx test with trimmed status PDU
3 years ago
Robert Falkenberg
a2332d10f2
lib,rlc_am_nr_packing: unit test + bugfix for trimming of status PDUs
3 years ago
Robert Falkenberg
872e55a84e
lib,rlc_am_nr_packing: reorder functions by importance
3 years ago
Robert Falkenberg
d9d3bfde63
lib,rlc_am_nr: remove redundant function calls.
3 years ago
Robert Falkenberg
48dce0aab0
lib,rlc_am_nr: truncate status PDUs if necessary
3 years ago
Robert Falkenberg
489259dc78
lib,rlc_am_nr: extend status PDU struct with self-contained packed size info
...
This change refactors the rlc_am_nr_status_pdu_t from a simple
container into a class with integrated counter of the packed size.
As this depends on the SN length, the SN length must be passed
via constructor.
3 years ago
Robert Falkenberg
eec4a395d0
lib,rlc_am_nr: status PDU to string prints NACK range
3 years ago
Andre Puschmann
68695078f0
phy_common: add basic test for sample rate for different bandwidths
3 years ago
Francisco
6984159c6f
asn1: fix amf-ngap-ue-id unpacking overflow bug
3 years ago
Andre Puschmann
ba092c0e9b
asn1,ngap_test: add TC to check unpacking of AMF-UE-ID > 32bits
3 years ago
Robert Falkenberg
87f22bb294
lib,rlc_am_nr_test: cosmetic change, deleted commented code
3 years ago
Robert Falkenberg
25d7258442
lib,rlc_am_nr_test: comment new tests
3 years ago
Robert Falkenberg
3a874e78af
lib,rlc_am_nr_test: fix format string of test delimiter
3 years ago
Robert Falkenberg
fc38d4f4d9
lib,rlc_am_nr: consider offset when packing retx with segmentation
3 years ago
Robert Falkenberg
69231f000f
lib,rlc_am_nr: don't enqueue segment retx if already pending for retx.
3 years ago
Robert Falkenberg
1a5683c226
lib,rlc_am_nr: add overlap check for segment offsets in rlc_amd_retx and queue
3 years ago
Robert Falkenberg
62558d94da
lib,rlc_am_nr: fix segmented retx of non-contiguous segments
3 years ago
Robert Falkenberg
697781f024
lib,rlc_am_nr: testcase for NACK duplicate (full PDU)
3 years ago
Pedro Alvarez
386b1640a9
gnb,bearer_mapper: hack to keep 5QI information in bearer mapper
3 years ago
Pedro Alvarez
b8006534f0
gnb,ngap,rrc_nr: Passing 5QI from the NGAP to the RRC when establishing eps bearers. Filling PDCP-NR config from 5QI config.
3 years ago
Pedro Alvarez
47caa60b45
lib,rlc_am_nr: fix up comment
3 years ago
Pedro Alvarez
2f1cf8ee11
lib,rlc_am_nr: make max retx configurable in AM stress test
3 years ago
Pedro Alvarez
4e2f7cf029
lib,rlc_am_nr: make sure that we RETX the segments if we get a NACK for an SDU that was already segmented
3 years ago
Pedro Alvarez
865dfe87e7
lib,rlc_am_nr: Added assert to check SO_start <= SO_end
3 years ago
Pedro Alvarez
7f7656e200
lib,rlc_am_nr: fix missing modulus
3 years ago
Pedro Alvarez
02c077106b
lib,rlc_am_nr: slowdown backoff if we run out of buffers in rlc_stress test
3 years ago
Pedro Alvarez
b70e6284e6
lib,rlc_am_nr: added logging info to to handling NACKs
3 years ago
Pedro Alvarez
330513ae57
lib,rlc_am_nr: updating segment info when segmenting RETX
3 years ago
Pedro Alvarez
9d0bbc45b3
lib,rlc_am_nr: added debug window function
3 years ago
Francisco
0de1565e52
rrc,s1ap: configurable target eNB TACs during LTE handover.
3 years ago
Pedro Alvarez
1aa13cee9e
lib,rlc_am_nr: cleanup logging of configuration
3 years ago
Robert Falkenberg
e5e5266eea
lib,rlc: add stress test support for NR AM18
3 years ago
Robert Falkenberg
1180d0f24d
lib,rlc_am_nr: properly remove all fully received SDUs from rx window
3 years ago
Pedro Alvarez
9ecf66f313
lib,rlc_am_nr: make sure that handle control PDU correctly locks the mutex
3 years ago
Robert Falkenberg
dd7bd351b3
lib,rlc_am_nr: fix pack/unpack of NACKs in status PDUs
3 years ago
Robert Falkenberg
aabd22f493
lib,rlc_am_nr: cosmetic change in assert rx_highest_status
3 years ago
Robert Falkenberg
77ae5182a6
lib,rlc_am_nr: stop/restart reassembly timer for segmented SDUs with gaps
3 years ago
Robert Falkenberg
d8cb4ec700
lib,rlc_am_nr: detect gaps in sequence of received SDU segments
...
This is required for checks such as
"there is at least one missing byte segment [...] before
the last byte of all received segments of this SDU"
3 years ago
Robert Falkenberg
51006bbab8
lib,rlc_am_nr: fix out-of-window assignment of rx_highest_status
...
Also add reminders for (not yet included) handling of
SDUs with segment gaps, i.e.
"...and there is at least one missing byte segment of the SDU
associated with [...] before the last byte of all received
segments of this SDU"
3 years ago
Robert Falkenberg
1d4f10fe0d
lib,rlc_am_nr: fix search start point for update of rx_next
3 years ago
Pedro Alvarez
87a4656307
lib,rlc_am_nr: fix for transmitting invalid NACKs
3 years ago
Pedro Alvarez
718c0ba2cd
lib,rlc: make it easier to save rlc_stress test result log to a file
3 years ago
Ismael Gomez
f8c2fa05bf
srsue,phy: support n_ta_offset parameter from sib1
3 years ago
Ismael Gomez
edeb8e8f18
srsue,nr: add TA support from RAR and MAC CE
3 years ago
Ismael Gomez
b3497c4a94
srsue,nr: decode SIB1 based on coreset0 configuration in MIB
3 years ago
Ismael Gomez
bfe69deccc
srsue, nr: Add SDAP to the UE. Supports only UL header
3 years ago
Ismael Gomez
f83557b891
srsue,phy: use common pucch for msg3. Completed table for all pucch_common_idx values
3 years ago
Ismael Gomez
be5c3afc51
radio: fix invalid mapping of multiple channels to multiple devices
3 years ago
Ismael Gomez
65dbac0bd3
srsenb,metrics: use epre for snr computation instead of rsrp
3 years ago
Ismael Gomez
2bbeef6068
srsgnb,metrics: add ul_pucch_ni metric and refactor rssi/epre nomenclature. Fix bug in rsrp_avg computation in pucch
3 years ago
Ismael Gomez
cf647b1fd5
srsenb,metrics: add PUSCH/PUCCH RSSI metrics. Add bearer DL total data metric for RLC UM
3 years ago
Pedro Alvarez
9a0d7113bc
lib,rlc_am_nr: fix checking the wrong SDU rx state on t-Reassembly expiry
3 years ago
Pedro Alvarez
8e06861113
lib,rlc_am_nr: fixup rx_next_highest when t-Reassembly exipres
3 years ago
Pedro Alvarez
46872a8c84
lib,rlc_am_nr: fix unprotected access to rx_window during timer expiration
3 years ago
Pedro Alvarez
a15b4c039e
lib,rlc_am_nr: fix state debugging info logging. Also log current TX/RX window size
3 years ago
Pedro Alvarez
0ada2adac7
lib,rlc_am_nr: minor fixes to address coments. Re-added comment, deleted useless assignement and fixed incorrect comment
3 years ago
Pedro Alvarez
6a1f6a35c1
lib,rlc_am_nr: fix loops for updating st.rx_highest_status and st.rx_next to be bounded by st.rx_next_highest, since rx_next_highest holds the value of the highest possible missing SDU.
3 years ago
Pedro Alvarez
981983377d
lib,rlc_am_nr: fixes for retx_segment test for 18bits after changes for Rx_Highest_Status
3 years ago
Pedro Alvarez
1e0e451174
lib,rlc_am_nr: fixes for retx_segment_test after changes to RX_Highest_Status
3 years ago
Pedro Alvarez
f4ff72bff8
lib,rlc_am_nr: fixes for setting the rx_highest_status incorrectly and incorrect status report generation.
3 years ago
Robert Falkenberg
a5c61418d5
lib,rf_imp: load rf plugins when loading this library
...
This fixes race of concurrently loading the same plugins
when srsran_rf_open_devname is called by multiple threads
Plugins are now loaded when srsran_rf is loaded (for
shared lib) or right before main() (for static lib)
3 years ago
Pedro Alvarez
e6f42331ba
lib,rlc_am_nr: fix race condition in handle data PDU. This was causing SDUs being removed from the rx_window, while the status report was geing generated.
3 years ago
Robert Falkenberg
fbdbc81bdd
lib,pdcp: fix modulus for SN increments
3 years ago
Robert Falkenberg
79e8f7625e
lib,rlc_am_nr: fix log msg for AM NR PDU header
3 years ago
Robert Falkenberg
bd6e306c94
lib,rlc_am_nr: extend unit tests for 18-bit SN
3 years ago
Robert Falkenberg
7e13cd0712
lib,rlc_am_nr: rename get_tx_window_size() to get_tx_window_utilization()
3 years ago
Robert Falkenberg
329f3e519b
lib,rlc_am_nr: reset do_status flag after sending status PDU
...
and extend unit test to fail when redundant status PDUs exist.
3 years ago
Pedro Alvarez
12f440145d
lib,rlc_am_nr: changed build_retx_pdu_without_segmentation to pass retx
...
info by copy. This is to avoid accidently using retx info by reference
after pop'ing the retx from the queue.
3 years ago
Pedro Alvarez
c023dba175
lib,rlc_am_nr: cleaned up some test names and some comments.
3 years ago
Pedro Alvarez
b4814bfdc1
lib,rlc_am_nr: added test for polling bit set when retx queue is empty. Fixed lost PDU test now that we correctly set the polling bit.
3 years ago
Pedro Alvarez
47aea19bd3
lib,rlc_am_nr: added test for poll setting in RETXes
3 years ago
Pedro Alvarez
1d1e6dd832
lib,rlc_am_nr: added pollBYTE support and a unit test for it
3 years ago
Pedro Alvarez
eaa8fff6a0
lib,rlc_am_nr: Passing bool to get_pdu_poll() to differentiate the
...
behaviour between RETX and non-RETX PDUs.
3 years ago
Robert Falkenberg
b52a102021
lib,rlc_am_nr: extend unit tests for 18-bit SNs
3 years ago
Robert Falkenberg
5bb6cdec1e
lib,rlc_am_nr: use std:vector for nacks in rlc_am_nr_status_pdu_t
...
- Also create tx_status a member to avoid frequent allocations
for each created PDU.
- Remove unused member nack_range from rlc_am_nr_status_pdu_t.
3 years ago
Robert Falkenberg
0cf052e31d
lib,rlc_am_nr: replace hard-coded WINDOWS_SIZE
3 years ago
Robert Falkenberg
80e23624f8
lib,rlc_am_nr: extract function am_window_size()
3 years ago
Robert Falkenberg
717132e0c3
lib,rlc_am_nr: fix access of unconfigured entity
3 years ago
Robert Falkenberg
47c1845cdc
lib,rlc_am_nr: add pdu_retx_queue_base, rlc_ringbuffer_base as interfaces
...
that are independent from templated capacity.
3 years ago
Robert Falkenberg
11ac8c2529
lib,rlc_am_nr: add support for 18-bit SNs
...
and first bunch of corresponding unit tests
3 years ago