Ismael Gomez
e7c2cea032
Fix data conversion parse in ue_dl_nr_file_test
3 years ago
Andre Puschmann
9c6f9f5949
dci_nr: print coreset0_bw when DCI is scrambled with SI-RNTI
3 years ago
Andre Puschmann
d5a00fcdad
dci_nr_test: add test for DCI 1_0 with SI-RNTI
3 years ago
Andre Puschmann
573b2f657a
ssb_file_test: make duplex and SSB SCS configurable, add new unit test for FDD+15kHz SCS
3 years ago
Andre Puschmann
dd34f5b274
ue_dl_nr_file_test: fix coreset0 bandwidth when decoding SI-RNTI
3 years ago
Andre Puschmann
972e080e48
ue_dl_nr_file_test: update SSB/SIB TV
...
update capture and make sure its rv=0
// Cell 0x01: nr_arfcn=368500 ul_nr_arfcn=349500 pci=500 mode=FDD rat=nr n_rb_dl=52 n_rb_ul=52 dl_mu=0 ul_mu=0 ssb_mu=0 ssb_arfcn=368410 ssb_prb=13:21 k_ssb=6 coreset0_prb=1:48 coreset0_idx=6
20:43:31.997 [PHY] DL - 01 ffff 784.0 PDSCH: harq=si prb=1:7 symb=2:12 CW0: tb_len=84 mod=2 rv_idx=0 cr=0.44
0000: 74 81 01 70 10 40 04 02 00 00 c8 00 24 68 a0 38 t..p.@......$h.8
0010: 05 01 00 40 1a 00 00 06 6c 6d 92 21 f3 70 40 20 ...@....lm.!.p@
0020: 00 00 80 80 00 41 06 80 a0 90 9c 20 08 55 19 40 .....A..... .U.@
0030: 00 00 33 a1 c6 d9 22 40 10 00 1e b8 94 63 c0 09 ..3..."@.....c..
0040: 28 c4 1b 8a 36 e1 5b 1c 3a 01 3c 5b 46 14 00 00 (...6.[.:.<[F...
0050: 00 00 00 00 ....
20:43:31.997 [PHY] DL - 01 ffff 784.0 PDCCH: ss_id=0 cce_index=0 al=4 dci=1_0
rb_alloc=0x120
time_domain_rsc=0
vrb_to_prb_map=0
mcs=6
rv_idx=0
si_indicator=0
dci_len=39
3 years ago
Andre Puschmann
7a64163aa4
ue_dl_nr_file_test: enable coreset0_idx=6 file test
3 years ago
Andre Puschmann
16b5f4c3db
ue_dl_nr_file_test: add further IQ capture with coreset0_idx=6
...
Cell 0x01: nr_arfcn=368500 ul_nr_arfcn=349500 pci=500 mode=FDD rat=nr n_rb_dl=52 n_rb_ul=52 dl_mu=0 ul_mu=0 ssb_mu=0 ssb_arfcn=368410 ssb_prb=13:21 k_ssb=6 coreset0_prb=1:48 coreset0_idx=6
12:58:46.197 [PHY] DL - 01 ffff 556.0 PDSCH: harq=si prb=1:7 symb=2:12 CW0: tb_len=84 mod=2 rv_idx=2 cr=0.44
0000: 74 81 01 70 10 40 04 02 00 00 c8 00 24 68 a0 38 t..p.@......$h.8
0010: 05 01 00 40 1a 00 00 06 6c 6d 92 21 f3 70 40 20 ...@....lm.!.p@
0020: 00 00 80 80 00 41 06 80 a0 90 9c 20 08 55 19 40 .....A..... .U.@
0030: 00 00 33 a1 c6 d9 22 40 10 00 1e b8 94 63 c0 09 ..3..."@.....c..
0040: 28 c4 1b 8a 36 e1 5b 1c 3a 01 3c 5b 46 14 00 00 (...6.[.:.<[F...
0050: 00 00 00 00 ....
12:58:46.197 [PHY] DL - 01 ffff 556.0 PDCCH: ss_id=0 cce_index=0 al=4 dci=1_0
rb_alloc=0x120
time_domain_rsc=0
vrb_to_prb_map=0
mcs=6
rv_idx=2
si_indicator=0
dci_len=39
3 years ago
Andre Puschmann
d2fc11fbec
ue_dl_nr_file_test: add missing parameter to existing file tests
3 years ago
Andre Puschmann
830cbcde08
ue_dl_nr_file_test: add all zero PDSCH check and let test fail in this case
3 years ago
Andre Puschmann
77269c055d
ue_dl_nr_file_test: expose ARFCN for center and SSB and use it to derive RB offset
3 years ago
Andre Puschmann
1684c56ca0
phy: add two IQ dumps with coreset0 and coreset1
...
coreset0:
15:03:16.697 [PHY] DL - 01 ffff 86.0 PDSCH: harq=si prb=2:7 symb=2:12 CW0: tb_len=84 mod=2 rv_idx=1 cr=0.44
0000: 74 81 01 70 10 40 04 02 00 00 c8 00 24 68 a0 38 t..p.@......$h.8
0010: 05 01 02 60 24 00 00 06 6c 6d 92 21 f3 70 40 20 ...`$...lm.!.p@
0020: 00 00 80 80 00 41 06 80 a0 90 9c 20 4c 29 21 00 .....A..... L)!.
0030: 00 00 33 a1 c6 d9 22 40 10 00 1e b8 94 63 c0 09 ..3..."@.....c..
0040: 28 c4 1b 8a 36 fd 5b 1c 3a 00 bc 5b 46 14 00 00 (...6.[.:..[F...
0050: 00 00 00 00 ....
15:03:16.697 [PHY] DL - 01 ffff 86.0 PDCCH: ss_id=0 cce_index=0 al=4 dci=1_0
rb_alloc=0x120
time_domain_rsc=0
vrb_to_prb_map=0
mcs=6
rv_idx=1
si_indicator=0
dci_len=39
coreset1:
15:03:16.693 [PHY] DL 0001 01 0100 85.6 PDCCH: ss_id=1 cce_index=0 al=4 dci=1_0
rb_alloc=0x5f
time_domain_rsc=0
vrb_to_prb_map=0
mcs=6
ndi=1
rv_idx=0
harq_process=0
dai=0
tpc_command=1
pucch_rsc=0
harq_feedback_timing=3
dci_len=39
15:03:16.693 [PHY] DL 0001 01 0100 85.6 PDSCH: harq=0 prb=2:48 symb=1:13 k1=4 CW0: tb_len=624 mod=2 rv_idx=0 cr=0.44 retx=0
0000: 43 02 6d 40 00 80 00 00 d6 5b 77 92 be 29 a1 5c C.m@.....[w..).\
0010: 9d d9 a3 42 64 bf d7 c0 cc 20 a6 4f b3 5e f5 06 ...Bd.... .O.^..
0020: 5f fc 03 02 83 ca e9 ee 04 e7 1a 1d 00 3f 9c 01 _............?..
0030: ec 1c 32 bb 6b 0f e2 e9 dc 7c f6 84 41 b2 2b e8 ..2.k....|..A.+.
0040: 10 f0 23 2c 91 f1 5d c7 6f b5 6e ac b6 fb c2 e6 ..#,..].o.n.....
0050: 32 2d b2 8b 07 36 11 f3 81 78 5d ff 1a 85 8d 6c 2-...6...x]....l
0060: 18 ce ca 52 1f 81 0f 78 c6 1a ab b5 e8 71 50 34 ...R...x.....qP4
3 years ago
Andre Puschmann
8c99d7a3bd
ue_dl_nr_file_test: use common helper function to derive coreset0 params
3 years ago
Andre Puschmann
279d82aa31
ue_dl_nr: debug to print PDCCH received symbols
3 years ago
Andre Puschmann
36a287edd8
ue_dl_nr_file_test: expose various coreset and search space related parameters
3 years ago
Andre Puschmann
f708635a5d
rrc_nr_cfg: set default PLMN for NR cell to 00101
3 years ago
Andre Puschmann
779bfcf791
phy_common: fix symbol size derivation for NR-only cells
...
make sure that 52 PRB cell with LTE rates gives 15.36e6 as sample rate
3 years ago
Andre Puschmann
853d870c52
rlc_um_nr: fix SN wrap-around in a few places
3 years ago
Andre Puschmann
813adb9567
rlc_um_nr: reduce verbosity in info mode
...
this will only print the most relevant messages in info mode.
also streamlines some messages with RLC AM entity.
3 years ago
Andre Puschmann
1bec07a64a
rlc_um_nr: fix starting/stopping of reassemble timer
3 years ago
Andre Puschmann
b3c7eeedd3
rlc_um_nr_test: add extra check to verify reassembly timer isn't running
3 years ago
Andre Puschmann
4187be3ff9
Revert "Revert "rlc_um_nr: reimplement update of RX_Next_Reassembly""
...
This reverts commit 296758e4ab
.
3 years ago
Andre Puschmann
7141fda69c
Revert "rlc_um_nr_test: disable test9 until low TCP UL rates are understood/fixed"
...
This reverts commit e491aef74e
.
3 years ago
Pedro Alvarez
f99d6bc224
lib,rlc: changed get_bearer() to get_lcid().
3 years ago
Pedro Alvarez
3b150e26cb
rlc_am_nr: Changed header_t to HeaderType typename in RLC data structs.
...
Fix issue in clear_pdcp_sdu()
3 years ago
Pedro Alvarez
123ac16653
rlc_am_nr: fixed issue with pointers from rx entity to tx entity
3 years ago
Pedro Alvarez
f99e841421
Changed using a rlc_am_lte and rlc_am_nr entity, to a single rlc_am entity.
3 years ago
Pedro Alvarez
eefedcfccd
rlc_am_nr: renamed rlc_am_base to just rlc_am
3 years ago
Pedro Alvarez
aef87d5366
rlc_am_nr: Change rlc_am_base to use unique_ptr to hold rx/tx entities
3 years ago
Pedro Alvarez
779eda98bd
Temporarly silence unused variable warnings.
3 years ago
Pedro Alvarez
e780eb5ab0
Fixed missing TM and RLC AM NR in mem_pool
3 years ago
Pedro Alvarez
debb4a0c6b
Refactored RLC AM segment pool for re-use in both LTE and NR
...
Moved RLC AMD PDU definitions from rlc_am_lte.h to rlc_common.h to make them re-usable in both RLC LTE and RLC NR
3 years ago
Pedro Alvarez
54be15e7a6
Moved write pdu to rlc_am_base::rlc_am_base_rx
3 years ago
Pedro Alvarez
476f9e1156
Changed logger initialization in RLC AM entities
3 years ago
Pedro Alvarez
022c51493b
Refactored RLC AM NR/LTE Rx and Tx entities to use a rlc_am_base_rx/tx class.
...
This was done to make it easier to share entity specific code between LTE and NR.
This removes the previously used templates.
3 years ago
Pedro Alvarez
b15f63f32f
Added an RLC AM base class to avoid code duplication in the RLC AM NR entity.
...
This class is based on a template that receives as argument the
rlc_am_*_tx/rx entities, so that those are different for LTE and NR.
Moved code from rlc_am_lte/nr entities so that they use the new base class.
3 years ago
Pedro Alvarez
e65bcd7147
Changed default max S1 Setup retries to infinity
3 years ago
Pedro Alvarez
e5a83474cc
Added max_s1_setup retries option to S1AP
3 years ago
Pedro Alvarez
930e3699d0
Added max_s1_retries parameter
3 years ago
Francisco
83c1fb65d7
nr,gnb,rrc: add rrc nr message handler and send functions to establish an SA RRC connection
3 years ago
Robert Falkenberg
02f261c0a9
rf: build srsran_rf as static library
...
For Ubuntu 18.04: Linking the static srsran_rf to libuhd
also requires to link Boost's "system" library.
Newer systems do not require this special handling.
3 years ago
Andre Puschmann
085d561f65
skiq: allow running without root permissions
...
do what the comment says, when thread can't be created with privelages,
try to create it without them.
3 years ago
Francisco
16753a006a
nr,gnb,rrc: add test logger delimiter; handle rrc setup complete
3 years ago
Ismael Gomez
360f718a5e
Add PHY resource allocation calculation for SIB common 0 search space
3 years ago
Francisco
9734f2e393
adt: fix optional_vector ctor, and add emplace method
3 years ago
Andre Puschmann
0967cda042
gnb,stack: move gNB components into own folder
...
* move RRC, MAC, NGAP, SDAP into gnb folder
* move testing code below respective layers
3 years ago
Andre Puschmann
951fea5f61
bearer_manager,rlc: reduce log level of message to warning level
...
relevant for the UE when it receives 2nd reconfiguration it could
be that the bearers are added again. in this case the handling is fine
and everything will work as expected. No reason to log error.
3 years ago
Francisco
5f3afffd05
nr,gnb: implementation of sib and mib asn1 generation functions
3 years ago
Francisco
96fd3aae3c
nr,gnb: small gnb interface refactors and fix of byte buffer operator=
3 years ago
Pedro Alvarez
2a5d21164f
Adding RLC AM NR unit tests
3 years ago
Pedro Alvarez
d528d8af4c
Added initial skeleton for RLC AM NR entity
3 years ago
Pedro Alvarez
2bb249bf09
Moved RLC AM LTE and NR packing functions to their own file.
3 years ago
Pedro Alvarez
f93d428e49
Moved RLC AM data structures to their own file
3 years ago
Francisco
7e7f7b4c01
nr: fix failing unit tests
3 years ago
Ismael Gomez
fa600ebda1
update sampling rate calculation from prb for nr
3 years ago
Francisco
dab6e8bdcd
nr,gnb: updates in parsing and phy files to allow the splitting of NR and LTE stacks
3 years ago
Andre Puschmann
1ead159f3f
backward: make signalhandler object static
...
having the sh a normal stack variable made the backtrace disappear
in some runs.
3 years ago
Andre Puschmann
b44372faae
crash_handler: write backtrace to stderr instead of backtrace file
...
the backtrace file is hard to collect in some environment but the stdout
and stderr is usually captured by default.
3 years ago
Francisco
8d719db43d
nr,gnb,mac: implement zero-copy get_dl_sched/get_ul_sched NR scheduler interface
3 years ago
Carlo Galiotto
ba50bbfb76
rlc,rrc,nr: remove rb_type from rlc_um_config
...
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto
9c2099f680
rrc,rlc,nr: fix RB label in RLC-NR for UE logs + ..
...
add rb_type in rlc_um_config
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto
d95c31d2de
rlc,rrc,nr: fix rlc bearer string diplayed in logs
...
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
faluco
90d21f8426
Fix invalid log line formatting.
3 years ago
Andre Puschmann
0bf2674d22
bearer_manager: reduce log level for clean/delete operations
...
this was causing errors in logs that aren't severe. the operations
are called when removing a UE regardless whether a bearer has been
created or not
3 years ago
Francisco
f6e1ecdaf3
nr,gnb,mac: remove redundant checks and unused lcid enum constants
3 years ago
Francisco
c615df9d1d
nr,gnb,mac: prioritize CRNTI CE handling over remaining SDUs and CEs in gNB mac receiver
3 years ago
Francisco
4286ab81d9
nr,gnb,mac: fix const-correctness of some methods of class srsran::mac_sch_pdu_nr
3 years ago
faluco
74456bf3d2
Whitelist a reported deadlock involving read lock.
3 years ago
Francisco
dfc2ea0a3e
nr,gnb,pdcp: extend the use of local rb_name member to pdcp nr
3 years ago
Francisco
c64be663d2
nr,gnb,pdcp: store the PDCP RB name in base class for easier use
3 years ago
Francisco
3c18e7c1f3
lte,enb,pdcp: fix addition of DRB logging in PDCP
3 years ago
Francisco
5b8d4c39af
pdcp,lte: fix drb/srb id logging to account for dynamic mapping
3 years ago
Andre Puschmann
e491aef74e
rlc_um_nr_test: disable test9 until low TCP UL rates are understood/fixed
3 years ago
Andre Puschmann
296758e4ab
Revert "rlc_um_nr: reimplement update of RX_Next_Reassembly"
...
This reverts commit 5b025cfbf8
.
3 years ago
Andre Puschmann
229b1eef21
radio,test: fix Coverity warning about dead code
...
add default in switch instead of using the the END state directly
that is checked before entering the switch. Coverity correctly
reports this as dead code.
3 years ago
Ismael Gomez
8a53a9d35c
ssb_decode_test: Fix stack overflow pbch_msg buffer
3 years ago
Andre Puschmann
6d0aafcf69
rlc_um_nr: fix has_missing_byte_segment() routine
...
return true if rx_window contains segment of this SN
3 years ago
Andre Puschmann
5b025cfbf8
rlc_um_nr: reimplement update of RX_Next_Reassembly
3 years ago
Andre Puschmann
2366dc286d
rlc_um_nr: improve logging
3 years ago
Andre Puschmann
85e478d8ad
rlc_um_nr_test: add TC to reproduce reassembly issue
...
* add TC to reproduce reassembly issue that causes low TCP throughput
* fix PCAP writing
* fix other testcase to wait for t_reassembly to expire
3 years ago
Alejandro Leal Conejos
ca7a377878
Fixes coverity 262740
3 years ago
Alejandro Leal Conejos
4bd8b6f2de
Fixes coverity 359677
3 years ago
Bedran Karakoc
a14cc451d0
Addition NGAP cleanup
3 years ago
Andre Puschmann
7f6801cb1e
ue_sync: fix 32bit compilation
...
fix printf format string on 32bit arches like ARMv7
FAILED: lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o
/usr/bin/gcc -DASSERTS_ENABLED -DENABLE_TIMEPROF -DENABLE_TTCN3 -DHAVE_BACKWARD -DHAVE_MBEDTLS -DHAVE_PCSC -I/usr/include/PCSC -I/usr/include/SoapySDR -Ilib/include -I../lib/include -Wno-unused-but-set-variable -Wall -Wno-comment -Wno-write-strings -Wno-unused-result -Wformat -Wmissing-field-initializers -Wtype-limits -std=c99 -fno-strict-aliasing -D_GNU_SOURCE -O3 -fno-trapping-math -fno-math-errno -DBUILD_TYPE_RELEASE -DIS_ARM -DHAVE_NEON -mfloat-abi=hard -mfpu=neon -fvisibility=hidden -fdiagnostics-color=always -Werror --param large-function-growth=1600 -O3 -DNDEBUG -fPIC -MD -MT lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o -MF lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o.d -o lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o -c ../lib/src/phy/ue/ue_sync.c
In file included from ../lib/include/srsran/srsran.h:31,
from ../lib/src/phy/ue/ue_sync.c:13:
../lib/src/phy/ue/ue_sync.c: In function ‘srsran_ue_sync_set_tti_from_timestamp’:
../lib/include/srsran/phy/utils/debug.h:59:23: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint64_t’ {aka ‘long long unsigned int’} [-Werror=format=]
fprintf(stdout, "[DEBUG]: " _fmt "\n", ##__VA_ARGS__); \
^~~~~~~~~~~
../lib/src/phy/ue/ue_sync.c:1044:3: note: in expansion of macro ‘DEBUG’
DEBUG("rx time with 3gpp base in ms %lu\n", time_3gpp_msecs);
^~~~~
../lib/src/phy/ue/ue_sync.c:1044:41: note: format string is defined here
DEBUG("rx time with 3gpp base in ms %lu\n", time_3gpp_msecs);
~~^
%llu
cc1: all warnings being treated as errors
3 years ago
joaquim-SRS
00b82bc772
Fix more issues in PHY lib
...
Fix variable shadowing issues in chest_test
Fix mutex unlock position in dft_fftw.c
CID 371598 Out of bounds access, in ssb_decode_test.c
3 years ago
joaquim-SRS
9b74e3429c
Fix more Coverity issues in the PHY lib
...
CID 369560 Missing unlock, in dft_fftw.c
CID 363710 Logically dead code, in resampler.c
CID 55097 Result is not floating point, in chest_test_dl.c
CID 351020 Result is not floating point, in chest_nbiot_test_dl.c
3 years ago
Nils Fürste
b036da07de
Extend ASN1 utils function from_number()
3 years ago
Fabian Eckermann
0007473c7a
Initialize variable.
3 years ago
Fabian Eckermann
f539851128
Fix possible out-of-bounds-read.
3 years ago
Fabian Eckermann
1b2d77a49d
Fix possible out-of-bounds-read.
3 years ago
Fabian Eckermann
8753ea1be5
Fix coverty defects.
3 years ago
Carlo Galiotto
9c74dda039
rrc,nr: add msg5 and inactivity timers to RRC-NR
...
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
faluco
edf0926a2f
Batch of LGTM fixes.
3 years ago
Francisco
529e2bdf55
nr,rlc: call bsr update callback in RLC UM NR
3 years ago
Francisco
7ad1ad800e
lte,enb,rlc: atomically compute DL buffer state and update the scheduler in the eNB
3 years ago
Ismael Gomez
d972fb368c
Some LGTM fixes ( #3564 )
...
* Fix LGTM issues
* ue: add logging to switch on function
* Fix new LGTM issues
3 years ago
Joaquim
93649429dd
WIP: Fix Coverity issues in PHY lib ( #3507 )
...
Fix several Coverity issues
This commit adrresses the following code issues found by Coverity:
CID 339785 Division by zero, in fading_channel_test.c
CID 355272 Division by zero, in awgn_channel_test.c
CID 355277 NULL ptr dereference, in awgn_channel_test.c
CID 359663 NULL ptr dereference, in delay_channel_test.c
CID 369544 NULL ptr dereference, in chest_dl_nbiot.c
CID 373326 Resource Leak, in dft_fftw.c
CID 373329 Resource Leak, in dft_fftw.c
CID 372878 Division by zero, in sliv_test.c
CID 372871 Division by zero, in dmrs_pdcch.c
CID 370622 Negative loop bound, in csr_rs.c
CID 370624 Negative loop bound, in csr_rs.c
CID 370626 Negative loop bound, in csr_rs.c
CID's 369568, 369594 NULL ptr dereference, in ch_awgn.c
CID 369540 Logically dead code, in refsignal_dl.c
CID 369608 Logically dead code, in refsignal_ul.c
CIDs 366291, 366296, 366297 Out-of-bounds access, in zc_sequence.c
CID 372209 Division by zero, in cqi.c
CID 370992 Uninitialized pointer read, in pdcch_test.c
CID 373334 Integer overflow, in ue_sync.h
CID 370993, 370995 Undefined division, in pdcch_test.c
CID 370994 Undefined division, in ssb_decode_test.c
CIDs 353368 353364 353365 359673 353366 353367
Explicit null dereferenced, in psss_file_test.c
CID 371865 Unchecked return value, in rf_uhd_imp.cc
CID 363810 Undefined division, in ldpc_rm_chain_test.c
CID 372209, 372211, 372213, 372216 Undefined modulo, in cqi.c
CID 339834 Array compared against 0, in chest_dl.c
CID 369589 Out of bounds access, in dmrs_pucch.c
CID 371681 Out of bounds access, in ue_sync_nr_test.c
CIDs 370761, 370825 Copy-paste error, in ssb.c
CID 369599 out of bounds read, in dmrs_pdcch_test.c
CID 363795 out of bounds read, in ldpc_dec_c_avx2_flood.c
CID 363805 out of bounds read, in ldpc_dec_c_avx2long_flood.c
CID 363821 out of bounds read, in ldpc_dec_c_flood.c
3 years ago
faluco
dc31fb05a3
Fix ODR issue detected by ASAN in arch for the srsran_verbose global variable.
3 years ago
faluco
fa8e8ddf1f
Fix an ODR issue detected by ASAN in arch, where the global variable handler_registered was defined multiple times.
3 years ago
yagoda
5d6b48311e
fixing a few regression bugs in embms
3 years ago
Andre Puschmann
497e183487
rf_zmq_imp: disable Tx baseband scaling
...
until the correct gain settings are documented and potential
mis-configuration are handled. It seems that the default
Tx/rx gains values are not working with this function.
3 years ago
Andre Puschmann
e2d26b5a8c
rlc_um_nr: log PDU without SN if full SDU is transmitted
...
PDUs that contain full SDUs don't have SNs, so the log should be
without it
3 years ago
Andre Puschmann
3eb1862ab9
gnb_interface: reduce MAX_GRANTS to 4
...
see #3530 for detailed discussion. This change saves some CPU cycles it seems
3 years ago
Fabian Eckermann
32a1646536
nr,gnb,rrc: Derive RRC parameters from config.
...
* Derive RRC parameters from config.
* nr,gnb,rrc: hard code prach config index to 8 to avoid expiring RA proc window.
3 years ago
faluco
5ff6b2eaa9
Fix data race in ZMQ where nsamples and running variables could be read concurrently.
3 years ago
Xavier Arteaga
322f57a952
Initial real-time Tx gain setting ( #2976 )
...
* Make filename const in filesink
* Sine generation returns the next phase
* Avoid malloc/free in radio class
* Implement Tx gain in ZMQ
* Initial ratio RT gain test
* UHD: use timed Tx gain commands to align changes to subframes
* Minor improvement in test_radio_rt_gain
* Fix compilation
* Check RF gain thread id before joining
* Remove redundant zero initialization.
Co-authored-by: Fabian Eckermann <fabian@srs.io>
3 years ago
Xavier Arteaga
ebab12403f
Asynchronous NR PHY configuration ( #3527 )
...
* Fix a race condition when accessing the NR PHY cfg by the RRC and phy workers.
Rework how the phy cfg is handled, now workers have their own copy that gets updated after a reconfig moving it out of the state class.
* Default initialize sf_len member in sf_worker for consistency.
* Asynchronous NR PHY configuration
* Fix compilation
* Corrected method override and fix unitialised value
* Added carrier equal comparison to avoid aligment byte padding comparison
Co-authored-by: faluco <borja.ferrer@softwareradiosystems.com>
3 years ago
faluco
0ada9a01ec
Whitelist TSAN issue in srsenb::mac::sr_detected.
3 years ago
faluco
a1b2f3915d
Whitelist lock order inversion tsan issue in srsenb::rlc::rb_is_um.
3 years ago
Andre Puschmann
8294724aad
gnb_interface: reduce MAX_GRANTS to 4
...
this significantly reduces data copies when providing the PHY
with scheduler results.
3 years ago
Xavier Arteaga
95bf85b3d3
Reduced maximum number of CSI reports
3 years ago
Pedro Alvarez
fbcffb84bd
Check if RLC is suspended before transmiting PDCP SDU.
...
This was done to avoid integrity issues, when the UE's RRC erroneously sent
measurement reports while the re-establishment was already in progress.
As errously sending PDCP PDUs on DRBs can cause issues as well, this was
disabled too.
3 years ago
Alejandro Leal Conejos
9daa32e591
Configure the term timeout using the cmake definition
...
EXTRA_TERM_TIMEOUT_S
3 years ago
Xavier Arteaga
d9bdc3f83e
Add CSI resource information and fix segmentation fault
3 years ago
Carlo Galiotto
284207dad6
WIP: fixing collision in the the users_map
...
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Xavier Arteaga
eace81d613
Fix UCI multiplexing for NR PUSCH
3 years ago
Xavier Arteaga
39bfcf4a5c
Add UCI valid in NR PUSCH info
3 years ago
Ismael Gomez
7920e084b8
Revert "Do not abort tsan"
...
This reverts commit e8e1d101c553912f733070e71d020a33ec895280.
3 years ago
Ismael Gomez
80c48a8b01
rlc: protect access to tx_enabled
3 years ago
Ismael Gomez
bf566fbd29
radio: protect concurrent access from tx_end and tx
3 years ago
Ismael Gomez
4239222909
Do not abort tsan
3 years ago
faluco
95b4a92f5f
Clarify the error messages printed when trying to open a RF device.
3 years ago
Francisco
c6226b0d94
lte,enb,rrc: parse cellIndividualOffset in rr.conf and propagate it to measConfig sent to UE
3 years ago
Pedro Alvarez
65a2b35f09
Fix not checking initialization of S11 in MME. Fixed typo.
3 years ago
Pedro Alvarez
0b948d4098
Make sure that bind returns error if it cannot bind. Added test for SCTP bind error/success.
3 years ago
Pedro Alvarez
e721504f8e
Removed the sctp_init_server for consistency. Added listen method to unique_socket class.
3 years ago
Pedro Alvarez
e9a7e6dbae
Getting rid of sctp_init_client function. The only thing it does is call the sctp_init_socket function.
3 years ago
Francisco
d60950d0f3
lte,enb,rlc: change new_tx and prio_tx variable names to snake_case and ensure they are zero initialized
3 years ago
Francisco
7aa5f731ce
lte,enb,rlc: push to scheduler pending prioritized bytes both in case of RLC timer expiry or in case of new buffer state detection
3 years ago
Francisco
4a58c10f30
lte,enb,rlc: compute and forward to scheduler the number of bytes pending for retx and status pdu in RLC AM bearer
3 years ago
Xavier Arteaga
4edb61212f
Added number of CDM groups to phy_dl_nr_test
3 years ago
Xavier Arteaga
8e5fe9018b
Corrected LBRM functionality
3 years ago
Xavier Arteaga
9ecea014bd
Added PUSCH DMRS minimum SNR
3 years ago
Francisco
0b51848dda
nr,gnb,rrc: use multiqueue to forward x2 tasks to NR stack
3 years ago
Fabian Eckermann
59df04547e
Increase buffer size for NR.
3 years ago
Andre Puschmann
3bf09021f9
enb: remove unused parameter
3 years ago
Francisco
5b2afb1739
rrc,nr,gnb: ensure same PDCCH config is sent to PHY, scheduler cell config, and sched ue cfg
3 years ago
Francisco
7a16be9692
rrc,nr: ensure coresets and search spaces are passed to scheduler cell_cfg and ue_cfg
3 years ago
Andre Puschmann
e5556fcc32
mac_pdu_nr_test: add LBSR unpacking tests
3 years ago
Andre Puschmann
af69551c8d
mac_sch_pdu_nr: add LBSR unpacking
...
* add LBSR unpacking
* add pretty printer
* also simplify and unify general unpacking code
3 years ago
Francisco
81174bda64
nr,ue,rrc: release NR logical channels during RRC release
3 years ago
Xavier Arteaga
537f165482
Added comments
3 years ago
Xavier Arteaga
3c40cd2840
Improved NR PHY logging info
3 years ago
Xavier Arteaga
addd687d7e
Fix NR PUCCH format 1 normalised correlation
3 years ago
Xavier Arteaga
e6bd6462b1
Estimate CFO for NR PUCCH formats 0 and 1
3 years ago
Xavier Arteaga
51ff429bc7
Added SS type to PDSCH context info
3 years ago
Xavier Arteaga
a5f6aa9f31
Added CSI string in PDSCH and PUSCH decode
3 years ago
Xavier Arteaga
003c6e524c
Added short NR CSI information
3 years ago
faluco
dacf40f63e
Delete move constructor and move assignment operator explictly for mac_pcap_base and s1ap_pcap classes.
...
Move emergency handlers header file into the support folder.
Refactored signal handling:
- Remove the dependency with the running static variable in the header file.
- Move implementations down to cc files.
- Allow specifying a new signal handler that will be used to stop the applications.
- Move signal handling files to support.
3 years ago
faluco
9075251627
Move the cleanup code from the signal handlers down to the new emergency handlers for the ue, epc and enb.
3 years ago
faluco
2c1e9c0c55
Implement an emergency cleanup handler registration mechanism to allow modules to clean themselves before application gets killed.
...
Flush PCAP contents just before killing the application.
3 years ago
Fabian Eckermann
44de4996e8
Fix log message.
3 years ago
Francisco
f427a25a30
nr,gnb,mac: account for header space larger than 2 when packing PDSCH
3 years ago
Francisco
ed2e88524f
asn1,rrc_nr: implement to_json in setup_release_c
3 years ago
Francisco
9df6c6b936
sched,nr: ensure the ue_cfg_t passed to the scheduler in NR FDD mode has the correct harq delay
3 years ago
Andre Puschmann
255ddb1329
enb,gnb: add basic support for sgnb release procedure
...
the procedure is currently started when the EUTRA UE object
is deleted (after RRC release) in order to clean-up the
ENDC resources on the gNB.
3 years ago
Francisco
ea324e8cbe
nr,sched,test: update sched nr test to better reflect MAC-PHY FAPI
3 years ago
Andre Puschmann
7cbd3d50b7
mac_sch_pdu_nr,bsr: fix length check for BSR
...
fix nasty bug where the length calucation for the LCID
was taking the bsr_format_nr_t that was having the same name.
3 years ago
faluco
28bbaa7816
Blacklist TSAN issues from libusb and libuhd.
3 years ago
faluco
75af37bd4b
Batch of race fixes when running the UE and ENB with UHD.
...
Main fixes are in the UHD driver, fixing races and potential deadlocks.
3 years ago
Alejandro Leal Conejos
1a64c6adad
Enum fixes so clang 12 can build the repo
3 years ago
Carlo Galiotto
f53e01cfa3
mac: apply changes by PR reviewers
...
- reinstate write_lock on ue metrics
- change "rwlock" variable name in mac_nr.h
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto
dc3e3a89f8
mac: update CQI in MAC with CSI reports from PHY
...
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Xavier Arteaga
a9904c2b64
Fix info format string
3 years ago
Xavier Arteaga
a31a40184d
Fix NR PRACH encoding
3 years ago
Xavier Arteaga
8bab12fb00
Added NR case to prach_test
3 years ago
Xavier Arteaga
3c4efba418
Added missing parameters to NR PHY configuration factory
3 years ago
Xavier Arteaga
5e1291b0c7
Fix PRACH detection sequence generation for NR
3 years ago
Francisco
11ee4ab9dd
nr,gnb,rrc: fix scheduler FDD configuration
3 years ago
Francisco
4e49508d8f
nr,gnb,mac: fix RAR encoding by resetting the RAR buffer
3 years ago
Francisco
1b595b6eff
nr,gnb: if no nr cell is initiated, do not enable endc in the LTE RRC
3 years ago
Francisco
3721523810
pdcp,lte: fix debug logging in PDCP, to avoid segmentation fault and crash
3 years ago
Francisco
43b12b9ffb
rrc,nr: transfer SSB config to both UE and NR scheduler
3 years ago
Carlo Galiotto
43a7d822fa
stack,rrc: fix double removal of EPS bearer
...
The EPS bearer was removed twice, causing an error in the logs.
Fix issue #3380
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Xavier Arteaga
7262287926
Zero power UCI bits is not an error but KO
3 years ago
Xavier Arteaga
4a327ad17d
Consider CRC length when calculating real LDPC rate
3 years ago
Xavier Arteaga
5f17c46098
Modify periodic CSI time offset to UL slot
3 years ago
Xavier Arteaga
bd186fab2e
Fix CMake SSB frequency addition overflow
3 years ago
Xavier Arteaga
be870d66ad
More relaxed SSB measure assertions and reorder SSB test
3 years ago
Xavier Arteaga
4b77127ed6
Added missing SSB pattern to unit test
3 years ago
Xavier Arteaga
8bb23cc74a
Correct CMake sign
3 years ago
Xavier Arteaga
52e00d6376
Fix PBCH encoding and added unit test
3 years ago
Xavier Arteaga
25bd0d6219
Added SSB pattern to/from string functions
3 years ago
Francisco
053877f489
rrc,nr: fix conversion from asn1 to phy cfg
3 years ago
Francisco
47e5e85449
refactor: clean unnecessary includes of the asn1/rrc_nr.h
3 years ago
Xavier Arteaga
1bdb1bb62d
Store PUSCH CSI from PUSCH DMRS
3 years ago
Fabian Eckermann
420d6a6a98
enhanced and fixed some tests.
3 years ago
Bedran Karakoc
850606f20b
Added deregistration (UE terminating)
3 years ago
Robert Falkenberg
b0430ebfe2
rf_imp.c: fix segfault when closing RF device with no AGC thread
3 years ago
Francisco
3b79393974
sched,nr: fix default ue configuration when prach arrives
3 years ago
Xavier Arteaga
d5b34696b4
Sepparate CSI report configuration from quantification and integrate in nr_phy_test with assertions
3 years ago
faluco
388b1e5d92
Fix data race in radio::is_start_of_burst.
3 years ago
faluco
7b0b76d58e
Whitelist two lock order inversion TSAN issues that acquire a readlock.
3 years ago
Francisco Paisana
b7f40b2baf
rrc,nr: reenable CSI reporting in gNB
3 years ago
Xavier Arteaga
00a6e71f50
Fix UL/DL frequency compensation
3 years ago
Fabian Eckermann
cb721aa292
fix calculation of ssb frequency.
3 years ago
Francisco Paisana
b58915d7ed
rrc,nr: make gnb cell CSI NZP configuration consistent with UE NSA configuration.
3 years ago
Francisco Paisana
23bf542ae7
stack,nr: isolate calls between LTE and NR stacks via the task multiqueue
3 years ago
Andre Puschmann
8bb06ff2c0
Added SSB in gNb PHY
3 years ago
Xavier Arteaga
3763d04578
implement helper function to calculate FFT size for a given sampling rate
3 years ago
Andre Puschmann
7496b7c14f
Add SSB to configuration factory
3 years ago
Andre Puschmann
5b0767772b
Added SSB center frequency to band helper
3 years ago
Andre Puschmann
91e17337db
Added SSB scaling configuration option
3 years ago
Andre Puschmann
3e5b40fd36
enb,rrc: fix compilation after freq point a has been removed from nr_carrier_t
...
since absolute freq point a members have been removed from the srslte_nr_carrier_t
struct (they are now actual frequencies) the abs_point_a values are now in
the RRC cell structs
3 years ago
Fabian Eckermann
5f40d4fd99
Add test for ssb from band calculation.
3 years ago
Fabian Eckermann
95abfbfec8
Calculate ssb frequency from freqency point a.
3 years ago
Francisco Paisana
f22483ce72
sched,nr: use formatting %d to represent slot index
3 years ago
Xavier Arteaga
c9d7db7314
Minor changes
3 years ago
Xavier Arteaga
e3bd92d87c
Fix SSB pattern in UE
3 years ago
Xavier Arteaga
8f90ee847a
Refactor carrier frequency from PHY and fix OFDM phase compensation
3 years ago
Xavier Arteaga
fda35bf6a1
Initial OFDM carrier phase compensation
3 years ago
Xavier Arteaga
2ab3971ef1
Fix NR PBCH encoding/decoding
3 years ago
Xavier Arteaga
530b381c6c
Change NR PDSCH/PUSCH freq/time resource format in log
3 years ago
Ismael Gomez
6b506ec357
phy_common: clear tx_hold flag before releasing the semaphore ( #3342 )
3 years ago
yagoda
82bda02b36
adding nr metrics
3 years ago
Andre Puschmann
1937e4d7fc
ssb: add extra checks when configuring SSB
...
this is to avoid invalid configs that later on cause segfaults, etc.
e.g.:
0 0x7f397adf64a3 (/lib/x86_64-linux-gnu/libc.so.6+0xbb4a3)
1 0x7f397cc8c6ce (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x796ce)
2 0x55b921d61707 in srsran_vec_cf_copy /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/src/phy/utils/vector.c:226
3 0x55b921d3b1d4 in ssb_demodulate /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/src/phy/sync/ssb.c:632
4 0x55b921d3d8ce in srsran_ssb_csi_measure /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/src/phy/sync/ssb.c:905
5 0x55b9215dc20f in srsue::nr::cc_worker::measure_csi() /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/srsue/src/phy/nr/cc_worker.cc:373
6 0x55b9215dd216 in srsue::nr::cc_worker::work_dl() /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/srsue/src/phy/nr/cc_worker.cc:483
7 0x55b9215f9c69 in srsue::nr::sf_worker::work_imp() /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/srsue/src/phy/nr/sf_worker.cc:78
8 0x55b921c47cc6 in srsran::thread_pool::worker::run_thread() /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/src/common/thread_pool.cc:48
9 0x55b92152ea0b in srsran:🧵 :thread_function_entry(void*) /mnt/data/jenkins/workspace/srslte_ogt_trial_builder_x86-ubuntu1804-asan/srsLTE/lib/include/srsran/common/threads.h:103
10 0x7f397c9fb6da in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76da)
11 0x7f397ae5c71e in __clone (/lib/x86_64-linux-gnu/libc.so.6+0x12171e)
3 years ago
Xavier Arteaga
1aa65bd10c
HOTFIX: force DFT wisdom save at exit
3 years ago
Fabian Eckermann
077f9cd03e
Add test for get_abs_freq_point_a_arfcn.
3 years ago
Fabian Eckermann
7f7cfe687d
fix calculation.
3 years ago
Ismael Gomez
c09f09b7be
Move rrc_common from srsue to lib
3 years ago
Fabian Eckermann
8830c2796f
Add support for NSA FDD on band n3, n5 and n7.
3 years ago
Fabian Eckermann
2d0be77660
Add helper functions for abs freq point a.
3 years ago
faluco
a8f58f503c
- Fix arm compiler warning. GCC treats chars as unsigned in this arch.
...
- Fix race condition in json metrics.
3 years ago
Andre Puschmann
315057d11c
enb: signal user activity to EUTRA RRC when doing NR DL traffic
...
to avoid releasing the UE when only NR DL traffic is done.
similar to the EUTRA solution.
3 years ago
Xavier Arteaga
8b2514ded3
Added NZP-CSI-RS signals in gNb
3 years ago
Francisco Paisana
cbb709d4e3
sched,nr: function to log UEs buffer status before scheduling decision, fix const_iterator of circular_map
3 years ago
faluco
1eaca0d343
Escape asn1 message strings that get printed in the enb event json report.
3 years ago
Ismael Gomez
1c77998df5
Stop PDCP for data bearers before initiating HO
3 years ago
faluco
fa351cd285
Rename functions that contain the unsafe word to nolock.
...
The term "unsafe" does not clearly state that the function is not locking the shared date and it sounds "dangerous", so use a more explicit term.
3 years ago
Andre Puschmann
59e1bca3f5
rlc_am_lte: fix potential crash when attempting to resize tx queue
...
under some circumstances it could happen that the RLC is configured
when SDUs are already being written to the queue. The resize
operation of the underlying container would fail in this case.
Make sure to empty the queue before doing the resize.
3 years ago
Francisco Paisana
bdf18856d1
sched,nr: fix handling of DL BSR in NR scheduler and computation of UCI
3 years ago
faluco
7b079fe289
Fix a data race in rlc TM metrics.
3 years ago
faluco
edb7342aef
Fix data race in rlc UM metrics.
3 years ago
faluco
6c91a824e2
Whitelist the TSAN lock order inversion issue in srsenb::mac::rlc_buffer_state.
3 years ago
faluco
8a38a89652
Fix compiler warning: control reaches end of non-void function
3 years ago
Andre Puschmann
426e876047
enb,nr: fix GTPU handler to forward UL PDUs
3 years ago
yagoda
bc4388a78c
-adding temp crnti removal for NR carrier attach
3 years ago
Andre Puschmann
430694c72f
gnb,dl: fix amplitude scaling
...
use PDSCH struct to get number of PRBs to compute scaling factor.
then PDCCH struct is only filled if it's encoded.
3 years ago
Andre Puschmann
802b22ac91
enb,nsa: refactor NR RRC/cell config parsing
...
this allows to access all cell-related params from within RRC
3 years ago
David Rupprecht
611255aa5f
Added GTPU bind address as output parameter
3 years ago
David Rupprecht
bd0e641633
Added GTPU PDU Session header parsing
3 years ago
Bedran Karakoc
43915550cc
NGAP GTP Bearer Establishment
3 years ago
David Rupprecht
3712983308
Added PDU Session est request
3 years ago
David Rupprecht
c670383ae9
Added NAS 5G functions incoming msg and reg proc
3 years ago
David Rupprecht
bbe54fb248
Fix uninitialized issue in NAS 5G pack/unpacking
3 years ago
Xavier Arteaga
d0ce17f736
Added SSB different SCS combination unit test
3 years ago
Xavier Arteaga
e2facef540
Abort radio application if decimation/interpolation ratios are not integer
3 years ago
Xavier Arteaga
cdfbe28b69
Initial NR-MIB packing/unpacking
3 years ago
Fabian Eckermann
f44eb0534f
Add RRC NR test for FDD
3 years ago
Xavier Arteaga
0324806d6c
Packed NR TDD config in duplex configuration and created test case for FDD
3 years ago