Andre Puschmann
62e4bd9469
log_ptr: fix issue if accessing log_ptr that was reset already
...
during deinit of the UE/eNB it could happen that the log_ptr
was already set to null but the stack thread was still accessing
it through log_h->info()
i've moved the old macro into a new header and used as as much
as possible. there are still places in the code where similar
macros are used but we would need to change the variable name
to replace them
5 years ago
Andre Puschmann
dbb8b6a360
nas: add helper for entering new state in FSM
...
the helper will log the event
5 years ago
Andre Puschmann
d8680cc9a8
nas: add helper to pack attach request and send to RRC
5 years ago
Andre Puschmann
cf28276a3a
nas: add helper function to reset NAS security context
5 years ago
Andre Puschmann
94c6034339
nas: rename start_attach_request to start_attach_proc
...
this is to better differentiate from "send_attach_request" that
only packs and send the actual attach request message. The
entire attach procedure may include PLMN search, etc.
5 years ago
Andre Puschmann
15c47fab56
nas: adding t3402 to restart attach after initial attach attempt counter expired
5 years ago
Andre Puschmann
7ef56cb637
nas: add an attach attempt counter as described in 24.301
5 years ago
Francisco Paisana
599588ff51
removed uneeded locks in the rlc, moved ue stack get_metrics to stack thread, solved the idle procedure double-locking
5 years ago
Ismael Gomez
95c6916987
Improve robustness in RF Overflow ( #1124 )
...
* Use task id to track old background tasks in RA procedure
* Improve robustness against RF overflow in PHY
* Increase SNR out-of-sync threshold
* Do not change frequency if it's the same
* Increase sync priority
* Increase time to start receiving to reduce input buffer occupation
* Use scoped lock in sf_worker
5 years ago
Francisco Paisana
8e837e173d
printf has already a way to pad spaces. If we use it, we can avoid accidentally adding extra logs because we did srslte::logmap::get("MAC") instead of srslte::logmap::get("MAC ")
5 years ago
Francisco Paisana
aeed623734
removed pdu processing from the ue rrc cmd queue. Instead, now the rrc processes the incoming pdus right away. This is essential to fix the security cmd issue in the ue
5 years ago
Andre Puschmann
b9a2217355
fix uninit vars reported by Coverity
5 years ago
Andre Puschmann
3f10224729
refactor airplane mode simulation and move to NAS
...
- move handling to NAS
- use switch off to enable airplane mode (don't wait for EPC response)
- add tiny FSM to control airplane mode activation/deactivation
- only start on/off counter after state has been entered
5 years ago
Francisco Paisana
e91a7ea513
removed stack-mac interface dedicated methods. We use now the task dispatch methods instead
5 years ago
Francisco Paisana
de03c96c3b
mac::process_pdus now uses the stack task dispatch interface
5 years ago
Francisco Paisana
7f6bde59fc
move write_pdu_pcch and write_pdu_bcch_bch to stack thread
5 years ago
Francisco Paisana
de3c28e52d
added task dispatch capabilities to stack interface
5 years ago
Francisco Paisana
46a1be3e76
updated mac-rlc interface to use unique_byte_buffer
5 years ago
Francisco Paisana
82cb6baef0
now the whole ue and enb mac uses the logmap
5 years ago
Francisco Paisana
45bc123967
remove manual tti counters from the rrc
5 years ago
Francisco Paisana
138347b6b5
nas using stack timers
5 years ago
Francisco Paisana
770f04b92a
the rrc now only works with the stack latest tti, instead of mac's tti
5 years ago
Francisco Paisana
e3e5b5be11
removed tti from some mac subcomponent interfaces
5 years ago
Francisco Paisana
d3f49d0e3c
changed interface sync-stack to allow tti jumps > 1
5 years ago
Francisco Paisana
e73cbb09b0
created tprof statistic for sliding windows
5 years ago
Ismael Gomez
cf4f4508ce
Normalize throughput in CSV/stdout metrics with respect to number of TTIs
5 years ago
Xavier Arteaga
e832769ae6
Updated copyright
5 years ago
Andre Puschmann
70ffe79b43
add support for periodic airplane mode simulation in srsUE
5 years ago
Pedro Alvarez
96c82b3fc6
Moved PDCP configs to pdcp_config.h. Added `as_security_cfg_t` structure to hold access stratum keys.
...
Refactored PDCP, RRC and USIM accordingly.
5 years ago
Andre Puschmann
5b8b718482
simplify NAS security handling and fix missing call in act test mode complete
...
add extra method to apply NAS security config, if configured,
that can be used by each NAS message sender
5 years ago
Andre Puschmann
664170fec6
pcap: add CC index when writing PCAP
5 years ago
Andre Puschmann
df31a5c4cc
store CC idx in DL/UL HARQ entity
5 years ago
Francisco Paisana
fed06138b9
moved rach_detected to stack thread. Created a more friendly interface to enqueue tasks in stack
5 years ago
Andre Puschmann
8e4f2a4d59
add UE parameter to enable TTI stats calculations
5 years ago
Andre Puschmann
a8bbe551ac
move thread class into srslte namespace to avoid ambiguity between std::thread
5 years ago
Andre Puschmann
8b46f631c1
add basic TTI stats in stack
5 years ago
Andre Puschmann
ae4cfb50f2
print warning to console if TUN interface couldn't be setup
5 years ago
Andre Puschmann
51864bc03c
rrc: print release cause when receiving rrc connection release
5 years ago
Francisco Paisana
ac52208409
removed most of clang-tidy warnings, introduced logmap in asn1, fixed info object naming in s1ap and ngap for successful and unsuccessful outcomes
5 years ago
Andre Puschmann
dffa2af461
fix NAS re-attach after detach request from network
...
needed to add a timer to delay transmission of attach request
to allow RRC release on eNB side
5 years ago
Francisco Paisana
e859d622c7
added logref class to forbid logmap pointer invalidation. Created a test for the logref, and introduced it in the scheduler, rrc and nas
5 years ago
Francisco Paisana
5a64fc0a93
sib_acquire_proc is not tti-driven anymore. No need to call run explicitly
5 years ago
Francisco Paisana
925ac862cb
sib acquiring is failing for sib2
5 years ago
Francisco Paisana
c29f08d8d5
refactored si acquisition procedure to use stack timers. Also created an interface that is going to be used for the task/timer handling
5 years ago
Francisco Paisana
22f51bb30b
made cell select non-blocking using background threads
5 years ago
Ismael Gomez
4fb83ae26d
Run configure_prach_params as a background task
5 years ago
Andre Puschmann
265037c202
some tiny MAC code refactoring and typo fixing
5 years ago
Francisco Paisana
c76cdc6cea
refactored the serving cell config procedure. there was one more state than it was needed.
5 years ago
Andre Puschmann
7c1b4c1f12
add support for IMEISV when requesting UE idendity
5 years ago
Xavier Arteaga
4d3c28ff97
SRSUE: wait for valid RSRP measurement before adquiring SIBs during cell search
5 years ago
Xavier Arteaga
fe199e6be2
SRSUE: Undo enable/disable RA procedure flag
5 years ago
Xavier Arteaga
f8294fb9df
SRSUE: RRC measurements refactor and more fixes
5 years ago
Ismael Gomez
52716f8716
Process HO complete in the background to avoid heap-after-use bug when PHY measurements are reported during a HO
...
rrc_meas refactor. Need to split commit
Fix typo
Temporal commit
Apply rx_gain_offset to neighbour cell measurements
srsLTE: modify TESTASSERT Macro to follow codeline
SRSUE: prevent RRC from having serving cell in neighbour list
SRSUE: DL HARQ does not need Time Aligment Timer. UL is disabled using PUCCH resources release
SRSUE: extend intra-frequency to CA SCell
SRSUE: fix confusing/ambiguous code in the RRC measurements and fix concurrency issue
SRSUE: remove RRC measurement report triggers when measurements are modified or HO succesful
SRSUE: fix compilation issues and Reest SIB indexes
Fixes sync using incorrect cell configuration when search cell does not find a correct cell
Small refactor to remove measurement report triggers always after removing measurement
SRSUE: Removed SIC PSS from UE
SRSUE: fix inter-frequency reestablishment and added more traces
SRSUE: Fix compilation issue
5 years ago
Francisco Paisana
ea777d92e8
applied new logmap class to nas
5 years ago
Andre Puschmann
77522a6b69
add srsUE parameter to change netns before creating TUN in GW
5 years ago
yagoda
260648582e
small formatting fix
5 years ago
yagoda
fc1c506d1f
refactoring TA command structure in UE
5 years ago
Pedro Alvarez
c5979f59eb
Clang format UE, eNB and lib ( #850 )
...
* Clang-formated UE, eNB and lib.
* Fixed compiling errors from clang-format.
* Fix linking issues introduced by clang-format
* Fix poor formating in initializing arrays of arrays.
* Fix mistake in conflict resolution on rm_turbo.c
* Re-apply clang format to gtpc_ies.h
5 years ago
Andre Puschmann
8a064cd3a6
pass msg_type from caller when logging RRC message
...
before the type of some message wasn't displayed correctly,
like SIBs, for example because the logger didn't
know the filed to retrieve the type string
5 years ago
Andre Puschmann
fa2821a4e7
fixing periodic measurment reporting
...
fixes various issues with unset timers, interval parameters, etc.
with those fixes, TC_8_3_1_1 and TC_8_3_1_2 pass
5 years ago
Francisco Paisana
d59016ae68
use of srslte::log* type for ASN1 logging. Initialization of the asn1 and rrc_asn1 loggers done now in both the ue and enb
5 years ago
Xavier Arteaga
6d896ee453
Fixed more static code analysis warnings
5 years ago
Xavier Arteaga
b48bb0d754
Removed atof, atoll and atoi calls
5 years ago
Xavier Arteaga
b4b1ab94af
SRSUE RRC: new PHY unknown sync state, cell select waits for PHY in-sync
5 years ago
Xavier Arteaga
67935d2b99
SRSUE: RRC blocks MAC RA procedure during reestablishment
5 years ago
Andre Puschmann
8ef0d6c6ca
do not automatically consider cells for which a measurment has been received as "in sync"
...
the in_sync flag has been misused in some parts of the code
receiving a PHY measurement for a cell does not automatically
mean that we are "in sync", as it is used in RRC as a condition
to indicate if we are camping on cell
the in_sync/out_of_sync condition should only be altered by the
corresponding functions sent from the PHY for the currently selected
cell (and not automatically for all cells)
the commit also removes the deletion of cells which are not "in sync"
from the list of neighbor cells. Instead, RRC calls a clean-up function
peridically that deletes old cells eventually.
5 years ago
Xavier Arteaga
f5e4ff9f4d
SRSUE: RRC Reest Procedure Refactor
5 years ago
Xavier Arteaga
f37a096f10
SRSUE: Refactored/Fixed RRC connection Re-establishment and minor CLang Format/Tidy fixes
5 years ago
Francisco Paisana
54992e72f1
fixed and simplified multiqueue task api to avoid dangling pointers.
5 years ago
Francisco Paisana
b2d3c2a150
fix compilation issue
5 years ago
Francisco Paisana
ac4d3b9624
std::functions do not accept move-only captures. So I had to create a wrapper earlier. In this PR, I cleaned a bit the previous API for the code to be a bit more readable
5 years ago
Francisco Paisana
177e880293
removed extra threads from enb rrc
5 years ago
Andre Puschmann
1a7142d73f
fix GW init procedure and set pool instance in ctor
5 years ago
Andre Puschmann
d25a734200
fix uninit value in NAS and move emm_info on stack
5 years ago
Francisco Paisana
d2c56caf7e
applied new timer class to the whole code base
5 years ago
Francisco Paisana
b254bdbb93
typedefed the proc_result_t<void> to become proc_state_t
5 years ago
Francisco Paisana
f2d88e5a5b
simplified NAS rrc connection request procedure
...
move non-type-specific methods of proc_t to its base class.
procedure state machine was simplified via a future-type. Now procedures dont get stuck until the user reads the procedure outcome.
made the NAS procedures more event trigger/reaction-based.
5 years ago
Francisco Paisana
8864787f59
added the continuation functionality to procedures via the "then()" method.
5 years ago
Francisco Paisana
c1be118d1d
new wrapper-based design for stack procedures. Removes extra base class, gets rid of spurious copies/moves during the pop(), and allows the use of a non-default ctor()
5 years ago
Francisco Paisana
8980810061
added some util print functions and fixed the issue with sync::cell_select when the last cell search was not successful
5 years ago
Andre Puschmann
82e3fd1052
fix uninitialized vars in RRC
5 years ago
Andre Puschmann
891a66a2e5
make the establishment cause a paramter when sending a connection request
...
needed to signal a mo_sig establishment cause after a RLF
5 years ago
Andre Puschmann
c24b25f42e
after RLF store PCI of current serving cell
...
the PCI is needed for the reestablishment request in case
the new serving cell has changed
5 years ago
Francisco Paisana
9bcb268421
added for-range loop and bool decay checks to clang-tidy. Applied some of the recommendations of clang-tidy to nas.cc
5 years ago
Andre Puschmann
cf548fe807
nas: add handling of T3410/T3411
5 years ago
Andre Puschmann
35307a047a
make UE switch_on non-blocking
...
this allows a simpler main that just signals NAS to switch on the UE
but doesn't block until the action is completed.
For making sure the UE also attached if the first attempt failed
the NAS needs to be extended to support the correct timers.
5 years ago
Francisco Paisana
81a466a641
since we moved cell search to the background thread, cell reselection prints a error message that it cannot start. In fact it already started. It is just waiting for the cell search to finish. This PR fixes this
5 years ago
Francisco Paisana
e67f66e539
moved cell search completed signal from the background thread to the stack thread
5 years ago
Francisco Paisana
b1496317d5
fixed the pcch proc issue by letting the cell selection explicitly propagate its result to the pcch_process_proc
5 years ago
Andre Puschmann
3c6ff0da30
make NAS logging less verbose
5 years ago
Andre Puschmann
c5f52adfba
nas: fix issue in which NAS wouldn't allow to attach once it failed
...
the main issue was the plmn_selected variable. the solution
was to create a function to enter the deregistered state that resets the variable
and performs all other actions that need to be performed, like clearing
EPS bearers.
The patch also extends the SS to support AT commands to enable/disable
data services and now succesfully passes TC_9_2_2_1_7
5 years ago
Francisco Paisana
2fb830fcfa
moved cell search to background task thread pool, and provided a stack interface to rrc to call "start_cell_search". Once completed, the background task signals back to RRC
5 years ago
Andre Puschmann
0467d8bc84
rework neighbor cell handling
5 years ago
Andre Puschmann
c7f0caa24a
add TTI field to MAC dl/ul grants and fix PCAP to include TTI
5 years ago
Francisco Paisana
6db0e474be
moved RA waiting procedure to a background task of the stack thread pool
5 years ago
Andre Puschmann
f94d2537a3
nas: send identity response integrity protected if security ctxt is present
5 years ago
Andre Puschmann
bb84b27f0b
fix RRC connect proc in NAS to allow reattch after detach
5 years ago
Francisco Paisana
fc9bb3c934
removed rrc asn1 header include from the ue_interfaces and phy
5 years ago
Francisco Paisana
946ead06e8
using an interface between the stack and lower mac to process demux pdus.
5 years ago
Francisco Paisana
63457f195c
extented queue test
5 years ago
Francisco Paisana
a2d7b2320a
placed GW packets in the same thread as UE stack thread
5 years ago
Francisco Paisana
647c624423
created a multiqueue handler, and started using it for the ue stack
5 years ago
Ismael Gomez
a3932f9bea
Minor change to fix coverty issue
5 years ago
Ismael Gomez
bfddc55148
RRC-PHY interface ( #639 )
...
RRC-PHY interface refactor. Moved RRC-MAC interface to rrc_asn1_utils and created RRC-PHY interface also in rrc_asn1_utils. All ASN1 includes should be made from rrc_asn1_utils only keeping ue_interfaces clean of ASN1
Tested with different common and dedicated configurations (64QAM UL, 256QAM, CA, SRS enabled/disabled, etc)
5 years ago
Francisco Paisana
67d6a25194
Moving mac timers to stack timers ( #638 )
...
* first step towards moving MAC timers to stack. Mac is still using its own timers. srslte::timers class can be restructured.
* moved timers out of the UE MAC
5 years ago
Ismael Gomez
69edee4e6c
Fix issues in uplink QoS ( #636 )
...
Fix bugs in Long BSR and Truncated BSR and added unit tests
5 years ago
Francisco Paisana
c9d3b61038
added resumable procedures to make RRC and NAS non-blocking
5 years ago
Andre Puschmann
7847c8da5e
extend ue cap handler to support multiple RATs
5 years ago
yagoda
408400bee6
adding fixes and tests for eMBMS
5 years ago
Xavier Arteaga
b5685c8f09
SRSUE: Fixed HO with carrier aggregation
5 years ago
Andre Puschmann
b46a71c2d8
add RRC metrics and remove extra methods to query RRC state
5 years ago
Ismael Gomez
abdb880b3b
Remove unused mux_is_transmitted local variable
5 years ago
Ismael Gomez
773c2a9721
Fixed multiple issues in Random Access procedure and extended MAC test
5 years ago
Andre Puschmann
5faa819dcd
fixing uninitialized class members found by coverity
5 years ago
Andre Puschmann
92f0d58856
mac: move further init/config into ctor to allow early logging, etc.
5 years ago
Pedro Alvarez
a868a13409
Fix compilation error when PCSC is enabled.
5 years ago
Francisco Paisana
58e2e51044
removed rlc_interfaces. The rlc_cnfg types are now part of the rrc_interface_types. Removed implicit RB initialization in the RLC.
5 years ago
Francisco Paisana
b936629221
removed rrc asn1 header from bcd_helpers, from rlc_interface, and rlc tests
5 years ago
Francisco Paisana
bb0dbf0f1c
created a asn1 utils with helper functions and types related to the asn1. These types/functions will help isolate the rrc_asn1 lib from most of the layers, reducing this way the compile times, and leading to better isolation. This will also make the transition to NR smoother. I removed the asn1 types from the NAS and USIM interface so far.
5 years ago
Xavier Arteaga
4a0ebe0cca
SRSUE: reviewed UE capabilities for 64QAM according to 3GPP 36.306
5 years ago
Andre Puschmann
1dea4add2a
stack: fix issue where stack thread was exited before stop_impl was called
5 years ago
Andre Puschmann
58763fb714
stack: move initialization of log object into ctor
...
this fixes the issue when the stack is torn down if, for example,
the radio couldn't be loaded correctly. it will hence call stop() on all stack
components which are not initialzized yet, and logging therefore doesn't work.
the log object is know during contruction time and therefore can be passed
in as soon as possible.
5 years ago
Ismael Gomez
9e6a9e0d03
Fix reestablishment mutex lock when called from RLC max retx
5 years ago
Pedro Alvarez
8f5ad55c4a
Added attach request as a UL info trasnfer in the UE. Added interface to remove eps bearer map when going idle. Fixed bug in GW in assignment of IPv4 addresses. UE seems to rebound from the service reject now.
5 years ago
Andre Puschmann
a3d95c8370
simplify SDU allocation and remove unneeded checks
5 years ago
Andre Puschmann
2599b1824d
reorder stack members and their loggers for correct destruction
5 years ago
Andre Puschmann
db224335a7
add MUX step function for PBR counting
5 years ago
Andre Puschmann
da35f41dd5
rework MAC logical channel prioritization
5 years ago
Francisco Paisana
8f8d9f3f30
applied changes in the stack internal method naming
5 years ago
Francisco Paisana
ce29ed545d
moved mac thread to the stack. Protect the interface of the stack with PHY and gateway via a queue of tasks
5 years ago
Francisco Paisana
62eb96366c
moved gw metrics out of stack_metrics_t
5 years ago
Francisco Paisana
10a56e2a84
moved GW out of the UE stack. This is important to keep concurrency out of the stack once it becomes single-threaded
5 years ago
Xavier Arteaga
cd036d8760
SRSUE: proc_ra.h/.cc use C++11 mutex
5 years ago
Xavier Arteaga
5d87aece0f
SRSUE: mac.h/.cc mutexes changed to C++11 and set initial values
5 years ago
Andre Puschmann
01679dbc8d
rearrange class members to make sure logs get destructed after stack components
5 years ago
Andre Puschmann
ad2b5d7635
pcsc: fix uninitialized variable and class dtor
5 years ago
Pedro Alvarez
6d05265d92
Adding mutex to protect the tft_filter map.
6 years ago
Andre Puschmann
2b7b4d0e7e
remove hard-coded LCID for dedicated bearer in GW
6 years ago
Pedro Alvarez
7a184a8cd8
Added log to tft_packet_filter.
6 years ago
Pedro Alvarez
39f5b03674
Removed empty line. Changed comment. Removed unused variables.
6 years ago
Pedro Alvarez
2723aa9b12
Added EPS bearer id to apply_tft interface. Sending packets to the correct LCID if they match the packet filter.
6 years ago
Pedro Alvarez
e2ca02bbe4
Starting to add match methods to tft_packet_filter
6 years ago
Pedro Alvarez
272e40a60d
Started to add a lookup in the gw to see if there is a match in the packet filter.
6 years ago
Pedro Alvarez
190a0ff37e
Adding test to unpacking of the packet filters.
6 years ago
Pedro Alvarez
a8eaf16881
Starting to add a structure for the packet filters.
6 years ago
Pedro Alvarez
a7e0a0624b
Starting to add interface apply_traffic_flow_template between NAS and GW.
6 years ago
Francisco Paisana
415d3418b6
reorganized enb to mirror ue director/class structure with a stack class
6 years ago
Pedro Alvarez
d67d18cc6b
Removing deplicated error codes.
6 years ago
Ismael Gomez
c2e9817f41
Possible solution to RLC Reestablishment
6 years ago
Andre Puschmann
3f613d7183
nas/gw/rrc: make LCID for DRB dynamic
...
- add interface to RRC to allow NAS to query the DRB for a given
EPS bearer id
- extend interface for NAS to setup GW to also pass LCID of bearer
- in NAS, use this new interface to pass actual LCID of the default
DRB when creating the TUN device
6 years ago
Andre Puschmann
b2a35f6b5a
nas: add parser and sender for modify EPS bearer context messages
6 years ago
Andre Puschmann
dcb04c6461
turn usim object into a unique_ptr
6 years ago
Andre Puschmann
3f90230d1a
nas: add EPS bearer map
6 years ago
Andre Puschmann
1ec5a4d4ed
add NAS metrics struct and move NAS states into common header
6 years ago
Andre Puschmann
1c749ad559
add basic handling for deactivating eps bearer
6 years ago
Andre Puschmann
0bd30343bb
fix packing of dedicated bearer context accept
6 years ago
Andre Puschmann
5451fb6007
nas: add basic handling for dedicated bearer and UE testmode messages
6 years ago
Andre Puschmann
7de9f39fcc
nas: move sending of attach complete message in extra function
6 years ago
Xavier Arteaga
bb663a69b8
SRSUE RRC: Cleaned Reestablishment code
6 years ago
Xavier Arteaga
e5084801a2
SRSUE RRC: refactored reestablishment procedure for executing Cell selection during T311 without blocking RRC
6 years ago
Xavier Arteaga
080b4a327c
SRSUE: Refactored asynchronous cell and ue_radio. CA Fixed.
6 years ago
Andre Puschmann
65f50cd7ba
introduce new UE layer design
...
- abstract UE object now consists of a radio, a PHY, and a stack layer
- add new stack abstraction layer that combines MAC, RLC, RRC, PDCP, NAS and GW
- PHY layer now has a single stack interface and does not talk to MAC and RRC seperatly
6 years ago