1866 Commits (a6c3144d924c60560a53c6da0a206a12bcce38f8)

Author SHA1 Message Date
Andre Puschmann f6d3467884 ringbuffer: fix timeout calculation for timed read
with ZMQ RF, we've seen the radio returning -1 and traced
the issue down to the ringbuffer.
in fact, pthread_cond_timedwait() returned 22 (EINVAL) indicating
a wrong timeout value. The issue was likely an overflow
in the timespec parameter. This patch checks for the return
value of pthread_cond_timedwait() and also calculates the
nanosecond wrap around for the timespec
5 years ago
Andre Puschmann aed38a6028 rf_zmq: increase default ZMQ timeout to 2s
amarisoft flags an RF error and exits after not receiving samples
for the radio. Running with ZMQ in the RFCI, the UE sometimes needs more
time to start up due to slow processing and no fftw wisdom file and
then Amarisoft eNB times out. This gives the whole process a little
bit more time. Should we still find it too short we may increase
it further.
5 years ago
Andre Puschmann b3e92883d4 rlc_um: reduce log level when provided space is not enough to build PDU
this is not a warning case as it can always happen. reduce level to info therefore.
5 years ago
Andre Puschmann 95f5093432 rlc_am: hold lock while handling new PDUs
This lock was removed in 1cbf7eac because it was considered unneeded.
However, as can be seen in issue #1503, we need to protect the access
to rx_window, for example.

Issue #1503 shows a stack trace where a PHY worker generates a status PDU.
While holding the mutex to access rx_window, the stack thread on the
other hand, happily accesses the rx_window member without acquiring
the lock. This commit protects all handle_*() functions in write_pdu().

This reverts commit 1cbf7eac04.
5 years ago
Andre Puschmann 6f5da19312 pdcp: similar to tx, also reduce log for Rx
instead of logging PDU received from below, and SDU that is forwarded
to above, only log the PDU in rx in info mode.

The next layer will do the same and log the PDU received (which is the SDU coming from here)
so there is now loss of information in the logs.
5 years ago
Andre Puschmann 6654453e22 pdcp: reduce amount of log messages during tx
drop logging encrypted PDU seperately. Instead, only log formatted
PDCP PDU before passing to lower layers
5 years ago
Xavier Arteaga 6f03ce7e11 srsLTE: minor radio fix 5 years ago
Xavier Arteaga 67543a73bb Radio: fix erroneous offset 5 years ago
Xavier Arteaga 8966db31d8 srsLTE: Radio benchmark plots all ports 5 years ago
Andre Puschmann ff96336f91 rlc_um: fix reestablishment for sending UM entity
we've reset the rx state variables during reestablishment but not
the tx state variable.
5 years ago
Francisco Paisana 84f34bc736 changed to a label filtering approach for ctest 5 years ago
Francisco Paisana c6323478d2 remove unecessary sleeps in mac test, and add long_ prefix in long tests 5 years ago
Andre Puschmann eb56efe9f5 rlc_am_lte: turn error message into warning and print state variables
the issue doesn't cause any unrecoverable situation so its not
appropiate to use the error level
5 years ago
Andre Puschmann df50dd7d3c rlc: extend RLC metrics
extend RLC metrics to count Rx/Tx PDUs/SDUs bytes/#
5 years ago
Andre Puschmann 82f811ed52 rlc_am: change return value when writing SDU
return false when SDU couldn't be added to SDU tx queue so
to count dropped SDUs in base
5 years ago
Andre Puschmann 3cef20607e rlc_am: fix bug in returning zero len bytes 5 years ago
Andre Puschmann 86025cf390 rlc_um: fix PDU packing when newly added SDU segment was too large
during the PDU packing it could happen that a new SDU segment
was added but the resulting larger header was so big that not even
a single byte of the new PDU could be added. because this
corner case wasn't handled correctly an invalid PDU was transmitted.

the solution is to revert the addition of the new SDU.
5 years ago
Andre Puschmann fc3cd24177 rlc_um: fix counting of lost PDUs
* change try_push() return value to indicate whether the addition
  of the SDU to the tx queue was successful or not
* count lost PDUs
5 years ago
Andre Puschmann 96726a03e0 rlc_stress_test: fix PCAP support
expose actual RLC configuration to PCAP object
5 years ago
Ismael Gomez 493b7ea2da Remove SNR threshold based link failure detection 5 years ago
Francisco Paisana 2de702f50e disable carrier aggregation when ue release is below 10 or category is below 5 5 years ago
Francisco Paisana e555e50a90 fix pnf packing for MIB messages 5 years ago
Francisco Paisana e3e9bbcd62 fix PNF PDU size cutting 5 years ago
Francisco Paisana fddcbc9879 fix vnf-ue stack interface 5 years ago
Andre Puschmann ad1b9d4d9b rlc_um: improve warning message to better differentiate them 5 years ago
Francisco Paisana d7138b7752 fix nr activation guards 5 years ago
Ismael Gomez 29e126a583
Add per-channel TX gain (#1450)
* Change type of rf_set_gain() to avoid unambiguous return with negative gains

* Add per-channel TX gain
5 years ago
Francisco Paisana 52c6c6aafd add ifdef guards for NR code 5 years ago
Francisco Paisana b68ef69ab4 fix comments and other minor issues 5 years ago
Francisco Paisana 468389997e fix header sn check 5 years ago
Francisco Paisana 42969ad992 add tb size as argument to gnb 5 years ago
Francisco Paisana 2f8dad03cc add rlc nr locking 5 years ago
Francisco Paisana f0874b780b add radio_base/null classes 5 years ago
Francisco Paisana 64e8f5e3ed update license year 5 years ago
Pedro Alvarez 9c1a7d2cf1 Removed get_bearer_status in PDCP. Renamed get_state/set_state to
get_bearer_state/set_bearer_state.
5 years ago
Pedro Alvarez 208a539499 Split PDCP tx_count state variable into tx_hfn and next_pdcp_tx_sn
variables.
5 years ago
Pedro Alvarez 08578a7331 Switched to use a struct to hold the PDCP entity state variables. Deleted some unecessary setters. 5 years ago
Pedro Alvarez 66d4f320e5 Added intereface to set PDCP state after reestablishment. 5 years ago
Pedro Alvarez 33567d81db Added interface to get internal PDCP state. 5 years ago
Pedro Alvarez 4093e75237 Starting to add getters and setters of the state in PDCP lte entity. 5 years ago
Xavier Arteaga 0e415260e9 SRSUE: scell_sync vector changed to map 5 years ago
Xavier Arteaga e0e8405285 SRSUE: initial scell sync
SRSUE: SCell Synch feedbacks delay

SRSUE: Implemented SCell Radio offset correction
5 years ago
Xavier Arteaga 5c0bb000ca UE DL does not complain if no grant is not found 5 years ago
Xavier Arteaga 8a774136de Radio: return error if a RF instance fails to open 5 years ago
Xavier Arteaga f04cf2090a Integrates number of samples in radio buffer
Fix minor issue

Radio: Fix minor bug and add unit test
5 years ago
Xavier Arteaga de230826b9 Added string helper for removing spaces and parsing list
Fix

Fix string parser
5 years ago
Xavier Arteaga 89b24b54e5 Refactored radio class for acommodating multiple RF devices 5 years ago
Francisco Paisana 3c2e3dbdbf added latest mac nr updates 5 years ago
Francisco Paisana cc52edf820 added latest pnf/vnf api updates 5 years ago
Francisco Paisana b05ce2fe57 added pnf_dummy test 5 years ago
Andre Puschmann 9f98bb3f54 disable prach_test_usrp compilation if no RF is selected 5 years ago
Xavier Arteaga 0e5704731e Removed UHD unrelated changes 5 years ago
Xavier Arteaga 258f7a180c Improved PRACH test USRP 5 years ago
Xavier Arteaga cd463d1b87 UHD: Initial C++ porting
UHD: cmakefix

x3
5 years ago
Xavier Arteaga 039f2164a6 Initial Sounding Reference Signals implementation 5 years ago
Francisco Paisana 613003ac53 add srsenb::rrc class 5 years ago
Ismael Gomez 84b84eaad6 Move search_in_common variable 5 years ago
Ismael Gomez 9b634b8d2a Search DCI in UE space before common to avoid DCI size ambiguity. Fixes #1398 5 years ago
Andre Puschmann 9fd327fcac soapy: use SoapySDRDevice_enumerateStrArgs to create Soapy args object
this allows to use Soapy device parameter when creating the device
5 years ago
David Rupprecht 61b69a0dab security: refactor code, fix race in eia1
* state funktion for eia1 (mitigate race condition)
* Extra file for snow3g
* just use mbedtls aes
* ref specification
* adding const keyword to security functions
5 years ago
faluco 617cad58ab Fix identation of arrays. 5 years ago
faluco cf5b321fb5 Replace magic numbers with macro constants.
Adjust comments to refer to these macros.
5 years ago
faluco ac3b7ed54c Move static array inside function as it is only used in there. 5 years ago
faluco 9484db8a90 Added header comments to srslte_sfidx_tdd_nof_X family of functions.
Fixed a comment referring to an older TS release.
Remove elses after returns.
5 years ago
faluco 8c59606d6f Add comment header to srslte_sfidx_tdd_type.
Remove else after return.
5 years ago
Xavier Arteaga 9f5aef30e6 SRSENB: fix DL ACK decoding 5 years ago
Francisco Paisana 2da8c923b1 removed commented code and fixed interfaces 5 years ago
Francisco Paisana b4b5cd7cd6 added nr gnb and ue interfaces 5 years ago
Ismael Gomez a1f0f8de35
Add callback to RLC to indicate BSR for TX and reTX queues (used in ENB) (#1361) 5 years ago
Andre Puschmann 1eaa99530f rlc_am: tiny refactor of rlc_amd_pdu_header_t
mainly turning header into proper class and adding default init value
5 years ago
Xavier Arteaga 20db13abc7 SRSUE: fix condition number calculation 5 years ago
Xavier Arteaga 9d5c2d70df SRSENB: Fix PHY reconfiguration for HO
Minimal aesthetic change
5 years ago
Pedro Alvarez 6ce33c3812 Small compilation fixes for GCC 10.1 5 years ago
Francisco Paisana e8aff22e1b using new rrc obj id util methods in handover code 5 years ago
Francisco Paisana d43448e8a1 created security cfg handling class for rrc ue and refactor bearer_list handling 5 years ago
Francisco Paisana ca0db7fffe created generic methods to apply toaddmodlist and removelists. 5 years ago
Francisco Paisana 791d84e639 created error_type and cleaned up expected 5 years ago
Francisco Paisana a2b76a4a5f use references rather than pointers 5 years ago
Fabian Eckermann 447b989aad fix parsing of zmq arguments
Use the return value of parse_string function to determine whether a parameter was found.
I experienced issues when the rx_type was set, but the rx_format was not. This led to "Unsupported sample format pub" as the tmp variable is still set to the value of the rx_type.
5 years ago
Ismael Gomez 847366bcdb Don't set high master clock rate for 75 PRB 5 years ago
faluco 4fb290ea27 Remove ifdefs now that this SIMD op is supported. 5 years ago
faluco c39ea2f583 Adjust possible type mismatch. 5 years ago
Andre Puschmann 189685b6f5 demod_soft: fix clang warning in demod NEON code
Try to bring back compilation.
Disable temporarily Werror.

Re-enable two simd functions.
5 years ago
Andre Puschmann f67524707d neon: add srslte_simd_b_neg()
clang complained about an uinit var that is returned and it turned
out that we don't even implement that function in NEON.

I've found a nice MIT-licensed header that was easy to integrate.
5 years ago
Andre Puschmann 53ab53ee77 ue_sync: fix tracking in GNSS_SYNC mode
this fixes the subframe-accurate rx in tracking mode.
previously we've only alligned to the next subframe start in find and
when there was a single overflow we've lost the track.

this patch calculates the offset in samples to the actual start of the
subframe (full ms of the receive timestamp) vs. the actual
receive timestamp and uses the value as the "next_rf_sample_offset"
to realign on the next receive
5 years ago
Andre Puschmann ca3b76df6e chest_sl: fix some possible array access at negative index 5 years ago
Andre Puschmann 28c98280d7 ue_dl_nbiot: convert macro to access SF contents into member var
also use srslte_vec_cf_cp() helper functions
5 years ago
Andre Puschmann 9648e47eb6 ue_cell_search_nbiot: fix potential out-of-bounds access
we've used a macro that can return -1 as access index
for an array. this has now been converted in a member
that is initialized and checked during init
5 years ago
Andre Puschmann d64fa19321 ue_dl_nbiot: check sf_idx before accessing buffer
this fixes a potential out-of-bounds access
5 years ago
Andre Puschmann ba4c2f10f0 fix potential out-of-bounds access in static look-up-tables
check index before accessing lut
5 years ago
Andre Puschmann 7aeddfd186 fix potential error where return value -1 is used for loop termination 5 years ago
faluco 340ec61e8e Code review. 5 years ago
faluco e28d9bb473 Fix for 1492950. 5 years ago
faluco 6fdceadc4e Fix for 1480100. 5 years ago
faluco 7bec101831 Small refactor to eliminate a function that causes undefined behaviour. 5 years ago
Andre Puschmann a0665b721e prach: fix illegal mem access when wrong configs are passed
this fixes Coverity issue 1480095
5 years ago
Xavier Arteaga 282cda7155 Fix Radio segfault 5 years ago
Xavier Arteaga f69aad3aac Clean up channel class 5 years ago
faluco d9529a3a8f Fix for 1480071. 5 years ago
faluco 0ba9164ae2 Fix for 1480055. 5 years ago