5g-team
/
srsRAN_4G
mirror of https://github.com/pvnis/srsRAN_4G.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
5,956 Commits
2 Branches
0 Tags
243 MiB
fix-cqi
master
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '86adbfceae'
${ noResults }
Commit Graph

1044 Commits (86adbfceaed2dd2f16232ed431a67e2be95abfcf)

Author SHA1 Message Date
Xavier Arteaga a59884a14a SRSENB: configure PUCCH3 as default HARQ feedback for CA 5 years ago
yagoda 8e0b106c22 fixing some warnings from LGTM 5 years ago
Pedro Alvarez 218531b418 Making sure the eNB only sends S1AP context release requests if it has a MME-UE-S1AP-ID assigned. 5 years ago
Andre Puschmann 3aa0179caf {ue,enb}.conf.example: add zmq examples to config 
the examples are commented but by just uncommenting those
two lines the user should be able to run a eNB and UE on the same
machine in SISO mode over ZMQ
 5 years ago
Jason Tang 7b7308ac1b Fix CSFB 5 years ago
jmasterfunk84 7f51fcb419 Update s1ap.cc 5 years ago
Francisco Paisana b506e29b72 removed common ce_typeenum 5 years ago
Francisco Paisana 372126deac created ul-sch and mch lcid types 5 years ago
Francisco Paisana 367a190829 created dl-sch lcid type 5 years ago
Xavier Arteaga 6c15feeff3 Fix compilation 5 years ago
Xavier Arteaga 77d5dedddc Fix LGTM warnings and recommendations 5 years ago
Pedro Alvarez ad0abe740b Added support to PDCP SN len of 7. Also added a check for valid configs in pdcp entity. 5 years ago
Francisco Paisana 7a132f9ccd more enb interface comments 5 years ago
Francisco Paisana 0526ae8ab1 updated rrc mobility parsing. added some utility methods 5 years ago
Francisco Paisana 20f6655c6b use common method to build mac pdu. allow CE allocations in dci format2/2a 5 years ago
Francisco Paisana 64557740fc use mac_buffer_state interface to schedule CEs in scheduler 5 years ago
Francisco Paisana ec94819f08 changed mechanism for conres ce scheduling to be controlled by rrc 5 years ago
Francisco Paisana 66a38f53f5 fix req_bytes methods to account for new method to calculate conres scheduling. 5 years ago
Francisco Paisana d716d8bf7e use mini state machine for ConRes CE scheduling instead of relying that there is data in the DL buffer 5 years ago
Francisco Paisana 6de7b644ec schedule conres ce when pcell changes 5 years ago
Francisco Paisana d183d64409 added allocate_rnti method to mac. Useful both during PRACH and handover UE resource allocation 5 years ago
Francisco Paisana 6ddedd5972 moved pdu to common mac folder 5 years ago
Xavier Arteaga 4756319e8f Reduce PHY logging 5 years ago
Pedro Alvarez 882a610504 Fix mistake in adding dedicated DRB to scheduler. 5 years ago
Pedro Alvarez b176eef8e7 Using a single map to store erab_info messages. 5 years ago
Pedro Alvarez 84b012051c Added ability to reconfigure more than one DRB in the eNB RRC reconfiguration. 5 years ago
Pedro Alvarez 9b60d7977e Make sure that the NAS buffers for multiple erabs are initialized. 5 years ago
Pedro Alvarez cc2b474754 Starting to add array of erab_info messages. 5 years ago
Pedro Alvarez f872e6ec39 Marking nas_pending a vector to support multiple erab setup on sending RRC reconf. 5 years ago
Francisco Paisana 6fedec8223 avoid dangling scells 5 years ago
Francisco Paisana ca7e667a22 small fix in list size check 5 years ago
Francisco Paisana 4d0068243b fixing scell activation in the enb rrc 5 years ago
Francisco Paisana c09f76ed6c unified stack task defer method 5 years ago
Xavier Arteaga 5b7493cab5 Added 256QAM modulation tables to scheduler 5 years ago
Xavier Arteaga a4225b189b SRSENB: Added initial UE capability parser 5 years ago
Xavier Arteaga 784bf81a1a Multiple fixes HARQ ACK/NACK feedback and CSI reporting for MIMO and CA 5 years ago
Xavier Arteaga 8b265883e4 SRSENB: UL TA measurement waits for a start order before start measuring 5 years ago
Andre Puschmann 3e916ac3a8 srsenb_phy: only wait for txrx thread if it has actually been started 5 years ago
Andre Puschmann b994255b35 enb: fix handling of GTPU and S1AP init return values 
if the eNB stack startup fails, for example due to binding
the wrong GTPU socket or similar issues, the eNB should stop
and log a message. Previously the return values for
S1AP and GTPU init were not even evaluated.
 5 years ago
Ismael Gomez 425c70c8d7 Fix CQI scheduling allocation for CA 5 years ago
Ismael Gomez 0841ec510c Fix deadlock when UE disconnected due to incorrect use of rwlock 5 years ago
Francisco Paisana 26211f12bd add warning when space in pdcch cannot be found 5 years ago
Francisco Paisana 40da4495ce do a loop in rrc::tti_clock() to process all pending events 5 years ago
Andre Puschmann d69aa55a42 enb: don't exit enb if rr.cfg for 6 PRBs isn't correct 
we agreed to print the error message but still patch the values to
work for 6 PRBs. Since there is only one option there is not
configuration ambiguity.
 5 years ago
Xavier Arteaga 9a2b0b7cc7 Standard vector allocation uses vector library 5 years ago
Francisco Paisana 076aa6b1f8 fix mobility test for when the eutra_capability is received 5 years ago
Francisco Paisana 69486f2953 took out change in cc_worker to force retxs 5 years ago
Francisco Paisana 179e959d05 fix msg3 retx issue. Now nof_prb for pucch above 1 are forbidden for prb==6 5 years ago
Francisco Paisana c661025cda fix log tti, and print a warning when the ul_harq tti does not match existing ones 5 years ago
Francisco Paisana 30ae2226c1 common interface for stack multiqueue tasks, background tasks and timers 5 years ago
Andre Puschmann 62e4bd9469 log_ptr: fix issue if accessing log_ptr that was reset already 
during deinit of the UE/eNB it could happen that the log_ptr
was already set to null but the stack thread was still accessing
it through log_h->info()

i've moved the old macro into a new header and used as as much
as possible. there are still places in the code where similar
macros are used but we would need to change the variable name
to replace them
 5 years ago
Pedro Alvarez 88f56721ee Fix issue where connection was still setup when no EPC was connected. 5 years ago
Francisco Paisana 344eaf49ec use logmap in the whole enb and ue 5 years ago
Ismael Gomez 9a264b62c4
Protect access to shared grants (#1117) 
* Protect access to shared grants

* Set correct number of carriers for DL

* Fix previous issues

* Address comments
 5 years ago
Francisco Paisana 4baeee10c5 avoid dangerous [] map operator 5 years ago
Francisco Paisana 1839b9a6e5 cleaned up paging code to avoid extra processing steps in worker threads 5 years ago
Francisco Paisana 9c028ab723 removed user_mutex from srsenb::rrc. All that needed to happen was the prach_worker calling add_user from stack thread (done in an earlier PR), and the get_metrics run in the stack thread. I achieved the latter with an extra metrics queue 5 years ago
Pedro Alvarez 75f35d8ded Making the default eNB TAC match the default EPC TAC. 5 years ago
Ismael Gomez c157a37894 Address comments 5 years ago
Ismael Gomez 7a7385d0e5 Support multiple carriers for common buffers (RAR/BCCH/PCCH) 5 years ago
Xavier Arteaga 8e891b7038 Added AWGN channel to SRSUE and SRSENB 5 years ago
Francisco Paisana a2866f661b made the number of ue payload allocations proportional to number of active carriers. Made mac::ue_db use unique_ptrs 5 years ago
Francisco Paisana 8772d8f85c use byte buffer pool for the ue tx_payload_buffer allocation. This halves the mac::ue object creation time 5 years ago
Andre Puschmann dff00c77c0 srsenb: fix mobility test after adding UE cap enquiry 5 years ago
Andre Puschmann ce45aabfec srsenb: enable UE capability enquiry during attach 
the UE capability information isn't used so far but can now
be analyzed in the PCAP
 5 years ago
Xavier Arteaga 2c93f6d20a Fix PUCCH DMRS correlation 5 years ago
Ismael Gomez fd3d4a7874 Refactor thread_pool: use std::mutex and fix some hidden potential bugs 5 years ago
Francisco Paisana 82cb6baef0 now the whole ue and enb mac uses the logmap 5 years ago
Ismael Gomez 5846e64a4d
Deallocate all CQI resources when deallocating users (#1097) 5 years ago
Francisco Paisana fb967d17a2 now we can disable tprofs individually 5 years ago
Francisco Paisana deb76d5dbd improved design to avoid data structures, and allow guarded start/stop even in lambdas 5 years ago
Francisco Paisana 8a54aef89d created a better/more composable design for time measures 5 years ago
Francisco Paisana eb20f651b9 account for all exit points 5 years ago
Francisco Paisana 854211496b redesign of tprof for thread safety 5 years ago
Francisco Paisana 269c852767 created a class for time profiling. An object of such class, if disabled, has almost zero overhead. Added a compile-time flag to turn on/off time profiling 5 years ago
Andre Puschmann 76f1b87b69 fix uninit var in s1ap 5 years ago
Francisco Paisana 34bc48d31a fix cfi to cc assignment 5 years ago
Francisco Paisana 0770c13f08 fixed overwriting of parsed max CFI 5 years ago
Francisco Paisana 5ee96079a2 added nof ctrl symbols of CFI to enb.conf 5 years ago
Francisco Paisana 4fc243ae4b added minimum CFI to config 5 years ago
Francisco Paisana 807d177b47 fix hanging issue, and simplified the handling of minRBG for different CFIs 5 years ago
Francisco Paisana ede09cb9b2 added dynamic CFI capability to the eNB scheduler 5 years ago
Xavier Arteaga ada8772f57 Initial srenb TA compensation 5 years ago
Andre Puschmann ac17ec6452 add common signal_handler for srsUE/srsENB/srsEPC 
the signal handler is the same for all three apps. The "running" flag
as well as the file_logger object are in the common header in order
to allow the signal handler to flush the file if the alarm goes off.
 5 years ago
Ismael Gomez cf4f4508ce Normalize throughput in CSV/stdout metrics with respect to number of TTIs 5 years ago
Xavier Arteaga 0408d357a7 Minor fixes 5 years ago
Ismael Gomez 858165f177
Allocate a different PDU buffer for each carrier in MAC eNodeB (#1069) 5 years ago
Ismael Gomez 73447972d8
Fix issue with simultaneous CQI and ACK/NACK transmission in CA (#1067) 
* Fix memory corruption when phy calling mac scheduler and not yet initiated

* Do not drop CQI if collision with ACK/NACK and PUSCH

* Allocate CQI resources for SCell properly

* Use UE_PCELL_CC_IDX macro

* Protect ul_sched from being called if not yet started
 5 years ago
Xavier Arteaga e832769ae6 Updated copyright 5 years ago
Francisco Paisana afd7ea9e83 Fixed the check for msg3 delay to account for retxs 5 years ago
Francisco Paisana 5330249625 created tti_point type and unit test. Added also the tti_point to the scheduler harqs, and rrc procedure 5 years ago
Francisco Paisana e824cbd251 fixes in the mac log and cell parsing 5 years ago
Andre Puschmann 1099e75e7c fix SCell carrier list population for MAC config 
the issue caused to assign 0 as enb_cc_idx for the first SCell always
 5 years ago
Xavier Arteaga caf7b514a0 Avoid TTI initial magic number 5 years ago
Xavier Arteaga 5af89513eb use double precission for frequency in srsue and srsenb 5 years ago
Xavier Arteaga 834a081c09 Add EPRE measurement to PUSCH decoder 5 years ago
Francisco Paisana 567790c1a2 Renamed struct to store cell context in rrc. Moved sib buffers to this struct. Created helper methods for lookup 5 years ago
Francisco Paisana fe3195bb27 add default pcell to ue_cfg in RRC 5 years ago
Francisco Paisana ce03971ca0 fix rrc_mobility_test 5 years ago
Francisco Paisana 349aed5e0d use sib configuration to set SCellToAddModList 5 years ago
Andre Puschmann 764c912977 fix a few more displaying issue in the stdout metrics 5 years ago
Francisco Paisana 4217dba7e0 fix msg3 delayed allocation and update test 5 years ago
Ismael Gomez e8b8c9922e
Add RF per-channel frequency band constraints (#1026) 5 years ago
Andre Puschmann 2f8643fb97 add tx/rx pkt ok/nok to enb metrics, also add enb metrics test 
This is what it'll look like if running the new test:

------DL--------------------------------UL-------------------------------------
rnti cqi  ri mcs brate   ok  nok  (%)  snr  phr mcs brate   ok  nok  (%)    bsr
  46  16 1.5  28 15.2G 1000 1000 100% 14.2 12.0  20 15.2M   50   10  20%  100.0
ffff 1.2 1.5 6.2 1.00M  100   54  54% 22.2 99.1  28 1.00k   50   10  20%  100.0
 5 years ago
Andre Puschmann 074ffbbb1d remove braces and reformat code 5 years ago
Andre Puschmann a95605a8a2 trim log name for eNB 5 years ago
Andre Puschmann f14697cdaa schedule PMI for SCells right after PCell, disable SRS for SCells 5 years ago
Andre Puschmann fdb7b0fa41 fix simple typo 5 years ago
Andre Puschmann 111aa6fc46 add SIB3 definition and enable in SI scheduling 
SIB3 contains common cell re-selection information for intra, inter and intra-RAT cell reselection
 5 years ago
Andre Puschmann 90beda34a1 fix parsing of optional field in SIB3 5 years ago
Andre Puschmann c534ee2b55 fix SCell packing in RRC reconfig 5 years ago
Andre Puschmann 0e4f97d1a0 fix bug in MAC where new PHY RNTI was always registered for enb_cc_idx==0 5 years ago
Andre Puschmann ab210c5f3c tiny cosmetic changes to the error messages printing 0x and clear cc_idx use 5 years ago
Andre Puschmann b7aad27d86 move packing of SCell list into extra method and add fill PHY config on the spot 
previously we've packed the RRCReconfig with SCellToAddMod list and have then
parsed the message again to pack the PHY config dedicated for the new SCell carrier. This
is now done in one step.
 5 years ago
Francisco Paisana d18b476e37 use utility macro for printing function name 5 years ago
yagoda f09c8324eb adding success/error macros in scheduler.cc 5 years ago
yagoda bfa451559b adding error logs to some scheduler function calls to ue_db to add clarity 5 years ago
Francisco Paisana 9b4a0baa87 activate scells in the phy 5 years ago
Francisco Paisana 7548402632 change scell activation interface to use arrays. Added a method to the scheduler to get the current set of activated carriers 5 years ago
Xavier Arteaga c42cb92784 Fix srsENB PHY stop 5 years ago
Xavier Arteaga 76408b195e Rename TX_DELAY and FDD_HARQ_DELAY_MS 5 years ago
Xavier Arteaga 442926cf66 Fix enb_phy_test deadlock 5 years ago
Andre Puschmann a8acd235f6 extend eNB MAC to support multiple CC per UE 
- add tx/rx softbuffers for each CC that a UE might have
- make sure to call assign correct buffers when iterating
  over the CC for UL/DL grant assignment
 5 years ago
Pedro Alvarez 96c82b3fc6 Moved PDCP configs to pdcp_config.h. Added `as_security_cfg_t` structure to hold access stratum keys. 
Refactored PDCP, RRC and USIM accordingly.
 5 years ago
Francisco Paisana dc8dca2a08 fix namespace-related compilation error 5 years ago
Francisco Paisana a744729007 use range of rbgs 5 years ago
Francisco Paisana 46579da1ff use signed integer to express the error 5 years ago
Francisco Paisana 9ad80ee29f added initial_dl_cqi to the enb rr.cfg parser 5 years ago
Francisco Paisana bcbb08ebae use initial_dl_cqi for first DL tx. 5 years ago
Francisco Paisana ab69c6fe43 account for delays in RAR tx in scheduler CA tester 5 years ago
Francisco Paisana 3b937348a2 refactored some sched util methods 5 years ago
Francisco Paisana fad897cb35 DL scheduler metric now takes into account the min and max of RBGs possible. This is to forbid segmentation of SRB0 allocations 5 years ago
Francisco Paisana 6317750de2 fix computation of ranged of allowed sched dl bytes 5 years ago
Francisco Paisana 414259e83b fix allocation expected alloc bytes (min and max) 5 years ago
Francisco Paisana 698899d309 added scells to enb rrc reconf message 5 years ago
Xavier Arteaga d585cf14f3 SRSENB: phy_ue_db returns default configuration for non User C-RNTI 5 years ago
Xavier Arteaga 47b7c1b72b SRSENB: remove assert macros from phy_ue_db.cc 5 years ago
Andre Puschmann f2e1bfa699 refactor naming for s/p/cell structs and {enb,ue}_cc_idx 5 years ago
Francisco Paisana 639f473042 fixed unsigned signed comparison 5 years ago
Francisco Paisana 1e63fa41cf made ue_cc_idx int to set to -1 for rar and bc allocs 5 years ago
Francisco Paisana f3c3c52fcd added ue_cc_idx to dci allocation 5 years ago
Francisco Paisana e62972d38e fix fdd delays in scheduler 5 years ago
Xavier Arteaga 04b3416d87 Remove auto for u16 5 years ago
Xavier Arteaga 5311c37429 SRSENB PHY: check RNTI type before requesting configuration 5 years ago
Xavier Arteaga 002a68e183 SRSENB: hard-coded parametrized PUCCH DMRS correlation threshold 5 years ago
Xavier Arteaga 385cc8ecd8 tweaked I_offset_ack in enb_phy_test 5 years ago
Xavier Arteaga 64caa4321b Fix UL control decoding. Some minor aesthetic changes. 5 years ago
Pedro Alvarez 8c58d1054a Changed pcap.mac_enable back to pcap.enable in eNB. 5 years ago
Pedro Alvarez 08a4ce0970 Added the ability to save S1AP pcaps at the eNB. 5 years ago
Andre Puschmann 2edecea33e fix SIB transmission for CA 
Avoid double buffering of SIBs in MAC as this would require one buffer for each CC.
Instead, use byte_buffer managed by RRC that contains packed SIBs to avoid
double memcpy for each SIB tx. Only use MAC provided buffer in error case.

Also avoid MAC calling RLC for each SIB and call RRC directly.
 5 years ago
Pau Espin Pedrol 91a5d1a74e gtpu: Log bind failure cause 5 years ago
Andre Puschmann 73feeaeba9 make UL earfcn optional in cell list 5 years ago
Andre Puschmann 120ad76c63 refactor cell param handling and fix SIB transmissions 
- move cell specific eNB params to cell list in rr.conf
- make sure DL EARFCN and DL freq can be used to manually overwrite a single cell config
- fix SIB packing and transmission for multi cell configs
- introduce cell list to MAC
- adapt default enb.conf.example and rr.conf.example
 5 years ago
Ismael Gomez 4e12405fff
Remove radio_multi class and organize channels, ports and carrier buffers (#1019) 5 years ago
Xavier Arteaga ecb22600ff improved eNb PHY test scheduler 5 years ago
Xavier Arteaga 89a672a585 SRSENB: fix UE phy dB defect for SCell Index 5 years ago
Xavier Arteaga 84dd9911ca eNb PHY test uses only Aggregation level 0 5 years ago
Xavier Arteaga 0d6694d5e6 Improvement in eNb PHY test 5 years ago
Xavier Arteaga 5c689ed4c4 SRSENB: minor aesthetic change 5 years ago
Xavier Arteaga 8eb96747ab SRSENB: Minor RAR RNTI fix 5 years ago
Xavier Arteaga da701cd82b SRSENB: Added PUSCH TA and EVM measurement. Some more PHY cleanup. 5 years ago
Pedro Alvarez bb9ff82490 Remove enb singleton and make sure log is initialized. 5 years ago
Pedro Alvarez bd3598f774 Moved srsEPC to the new S1AP library. Deleted liblte_s1ap.cc and liblte_s1ap.h. 5 years ago
Xavier Arteaga a61ff0b0fc SRSENB cleanup phy common 5 years ago
Xavier Arteaga cac2ee33b6 SRSENB: PHY uses tti_semaphore class instead of normal semaphores 5 years ago
Francisco Paisana ec1f1cc677 remove const_casts from scheduler. Fix ODR issue 5 years ago
Francisco Paisana e9a599857a created a header for all common structs and helper functions 5 years ago
Francisco Paisana 02ccb8b32b fix wrong calculation of sched tx and rx delays 5 years ago
Andre Puschmann 73c8b02820 enb: loop over CC in MAC 5 years ago
Andre Puschmann 664170fec6 pcap: add CC index when writing PCAP 5 years ago
Andre Puschmann 33a410bda4 fix parsing of DL/UL earfcn in cell config 
using a single earfcn or dl_freq value that gets set by default
in the [rf] section doesn't make sense in a enb config with more
than 1 cell, so we should actually remove the earfcn/freq setting in [rf]
and only configure the radio through the values in the cell list in rr.cfg
 5 years ago
Andre Puschmann 87f1b2a939 catch exceptions from eNB config parser 
since the eNB config gets more complex, especially with CA,
we need to catch potential parsing errors from libconfig,
print an error with the position of the error and gracefully
stop the enb
 5 years ago
Francisco Paisana 43e67b8536 created a harq entity that handles all harq procs. This entity accepts as arg the number of harq procs. 5 years ago
Francisco Paisana 1c041b2c1d created harq entity class 5 years ago
Andre Puschmann dfb1cd1361 temporarily disabling enb_phy_test_1cell until it is fixed 5 years ago
Francisco Paisana 9f266161cf increase tbs until allocation is big enough to fit MAC subheader and RLC header 5 years ago
Ismael Gomez 1f3aee2fc0 Fix incorrect parameters 5 years ago
Francisco Paisana 7e840bde86 fix tb idx assignment in scheduler mac sdu alloc 5 years ago
Francisco Paisana d1356568e0 separated sf sched result from sf_sched class. The interface became way simpler. No need for finish_tti() method, sf_sched::new_tti() is called automatically when we access the sf_sched. 5 years ago
Francisco Paisana bb38fa7119 fixed tti resetting after tti end 5 years ago
Francisco Paisana 47b05118ad simplified msg3 allocation. Now we can allocate resources ahead of time (e.g. msg3 is 2 ttis ahead) using the sf_sched interface. It's guaranteed that the given allocations wont be erased when the respective tti starts 5 years ago
Francisco Paisana 8f7890c60a store mask results in separate variables for testing, and reset sf_sched state at the end of the tti 5 years ago
Pedro Alvarez afc209711c Fix jump depending on uninitialized variable in srsenb::sched_ue::set_bearer_cfg_unlocked 5 years ago
Francisco Paisana 5bdc603113 added error macros 5 years ago
Francisco Paisana b37d9b9930 fixed msg4 setting in sched tester 5 years ago
Francisco Paisana 3cc94c3694 simplified mutexing of the scheduler. One single mutex for everything, and removed rwlock 5 years ago
Francisco Paisana 7210c35c6c checked all methods of srsenb::pdcp to see if they are called by different threads. Since it is all single-threaded, I removed the locks 5 years ago
Francisco Paisana fed06138b9 moved rach_detected to stack thread. Created a more friendly interface to enqueue tasks in stack 5 years ago
Francisco Paisana d10e950650 fix ue streamid assignment in s1ap 5 years ago
Andre Puschmann c79e202fd9 fix typo 5 years ago
Andre Puschmann 37c342af39 give enb_phy_tests individual names 5 years ago
Andre Puschmann a8bbe551ac move thread class into srslte namespace to avoid ambiguity between std::thread 5 years ago
Andre Puschmann 8b46f631c1 add basic TTI stats in stack 5 years ago
Francisco Paisana ad9e126299 test for different enb_cc_idxs as pcell. Bug fixes 5 years ago
Francisco Paisana 0f3ef11f8b now the scheduler only activates a scell after receiving a valid CQI for the SCell 5 years ago
Francisco Paisana f571b7c16b cleaned up some of the log error messages in the sched tester 5 years ago
Francisco Paisana c595696ec2 no need for a separate class for the CA tester 5 years ago
Francisco Paisana b44754f0ae the CA and random sched testers now use same structs and common interface. 5 years ago
Francisco Paisana 385fa226e0 started to use a type-safe tti counter for comparisons. Uniformized the common_sched_tester api. Next, need to use the same struct to register events. 5 years ago
Francisco Paisana 518f813f13 now the CA testing generation and simulation happen simultaneously. This way we can do more tti/event specific checks 5 years ago