2246 Commits (818f3ea7c7ec858be6b20028cedd71dfc52b0d8b)

Author SHA1 Message Date
Andre Puschmann 1b97ba5300 benchmark_radio: fix duration and thread priority
I noticed that the app didn't configure the process with
RT thread prio. But it then turned out that in order to do
that we need to actually spawn a new thread. Also a few other things
didn't work out of the box.

In summary the changes are:
* fix duration to support more than 120s
* move main functionality in thread
* set high priority for radio thread
* only return success if no radio errors occured
4 years ago
Francisco Paisana 510959b50f update nr asn1 files, and asn1 tests 4 years ago
Xavier Arteaga 8d9577626b Fix NR FEC unit test 4 years ago
Xavier Arteaga 0c2f96d389 Fix 5G NR FEC memcheck 4 years ago
Xavier Arteaga 2835e87ff0 Add missing file 4 years ago
Xavier Arteaga f8dd67260f Polar: fix unit test working directory 4 years ago
Xavier Arteaga 15356b3ec8 Fix compilation for non-AVX2 machines 4 years ago
Xavier Arteaga 2c4aa1e379 Added Polar and LDPC forward error correction 4 years ago
Xavier Arteaga 4f89c6ed3f Added missing CMakeFiles 4 years ago
Xavier Arteaga f21590735d refactored FEC directories 4 years ago
Xavier Arteaga 7093a85f81 Refactored FEC directories 4 years ago
Xavier Arteaga c2621cc4f8 Protect ring-buffer write from nullptr 4 years ago
Andre Puschmann f647343f18 rlc_am: fix poll bit during header reconstruction
this makes sure that the reconstructed RLC AM header
has the poll bit set when any of its segments had it set.

this triggered a bug in RLC AM because the Status PDU
isn't transmitted for a RLC PDU that was segmented and
only the first segment had the P flag set.
4 years ago
Francisco Paisana b40a5a958e use common function to fill rrc reconf message in handover 4 years ago
Francisco Paisana e9b693942f diff-based cell selection activation 4 years ago
Francisco Paisana 836e7d7ede refactor scell addition in the srsenb::rrc to follow the same style of other rrc recfg fields 4 years ago
Francisco Paisana 97f2e4336e refactor of functions for filling the asn1 radio resource config structs. This functions are used during rrc setup/reest/reconf 4 years ago
Xavier Arteaga 9487d27ef9 Renamed NR constants and comments 4 years ago
Xavier Arteaga e8f168b20c PDSCH NR: Added files 4 years ago
Xavier Arteaga c8477483d9 PDSCH NR: Added files 4 years ago
Xavier Arteaga 30d8e05d50 Fix PDSCH-DMRS symbol index 4 years ago
Xavier Arteaga 8d34d344a8 Created PDSCH-NR configuration structures and refactored DMRS 4 years ago
Xavier Arteaga 009f300c5e Initial PHY Data procedures 4 years ago
Xavier Arteaga 775692f461 Rearanged PDCCH NR functions structures 4 years ago
Xavier Arteaga 937c52339d Added PDCCH DMRS estimation and measurement 4 years ago
Xavier Arteaga 5799100e42 FFT based Resampler admits NULL inputs/outputs 4 years ago
Xavier Arteaga 44ae70dcc6 Initial implementation of the 5G NR PDCCH DMRS encoding 4 years ago
Xavier Arteaga 29ad2427d9 Initial implementation of the 5G NR PDCCH DMRS encoding 4 years ago
Xavier Arteaga 579526f1fe Added sequence advance without generating data 4 years ago
Xavier Arteaga eba20b6367 Radio: fix frame overlap at start-of-burst 4 years ago
Xavier Arteaga be400503b9 Add pass criteria to PRACH USRP test 4 years ago
Xavier Arteaga 28bb4709ff Solved possible high impact PHY out-of-bounds issues 4 years ago
Pedro Alvarez e4f143059e Simple log fix to make it easier to compare PDCP RX and TX. 4 years ago
Andre Puschmann 0740154bff rrc,sync: fix two uninit vars
detected by Valgrind when running UE with TDD cell
4 years ago
Andre Puschmann 723ca2dd48 ra_dl: fix TDD reference symbol extraction
reported/provided by user softdev86 in https://github.com/srsLTE/srsLTE/issues/566

author tested with local 4 port cell. I am not able to verify locally but
it looks ok, we'll revise later if needed.
4 years ago
gracid f67a152a2a Remove unnecessary Lime calibration step from Soapy implementation
When using srsLTE with Lime devices, calibration was performed before any configuration steps have happened, thus making calibration values invalid. Removing Lime specific calibration step from rf_soapy_imp makes so that devices will be automatically calibrated by SoapyLMS on rf_soapy_start_stream call.

Tested and working with srsENB using LimeSDR-USB v1.4 and LimeSDR-Mini v1.2 boards.
4 years ago
gracid 78b63c9465 Set same antennas for all Soapy channels
This commit adresses an issue where two or more channels could have different antennas, despite being explicitly set in the configuration file
4 years ago
Francisco Paisana 4cb6ed27eb updated scheduler ue mcs computation to account for new 256QAM tables 4 years ago
Xavier Arteaga fac6d40a45 SRSENB: fix PUSCH max number of iterations 4 years ago
Xavier Arteaga 791c979063 Vector: fix cf to cs conjugate conversion 4 years ago
Andre Puschmann 5e7de0a95b cmake: install individual libraries (common, phy, etc)
this seems to be important for package maintainers
or people who use srslte components in other projects
thar require to link against static libs

so besides installing headers, the apps and the RF lib, we also
install all individual libraries

this fixes https://github.com/srsLTE/srsLTE/issues/500#
and https://github.com/softwareradiosystems/srsLTE/issues/1754
4 years ago
faluco 8376111419 - LGTM fixes. 4 years ago
Xavier Arteaga caf37b8e62 Added serving cell index in UCI/CSI report trace 4 years ago
Douglas Anderson fe21b2717c Fix "Comparison is always true because ret >= 0" LGTM warnings
... and refactor out some other dead code in the vacinity of these warnings
4 years ago
Andre Puschmann 1a03839f78 rlc_am_lte: fix potential bug when setting uint32_t to -1
discovered in Coverity CID 359664
4 years ago
Andre Puschmann 5a31c5765b rf_soapy: fix auto selection of Soapy device
when the default RF args are used, NULL is passed as argument
to the RF driver. In this case, we should use the previous
SoapySDRDevice_enumerate() and let Soapy pick the device
4 years ago
Xavier Arteaga ca6566ad46 Fix PUCCH format1b false detection 4 years ago
Pedro Alvarez b43e724b4c Remove packing/unpacking code for M2AP. 4 years ago
Jan Remeš 8c7b7cc55a libsrslte_rf: add library version
This patch adds version string to the 'libsrslte_rf' library.
This results in the library being built as
    libsrslte_rf.so.20.04.2
with the following symbolic links
    libsrslte_rf.so.0 -> libsrslte_rf.so.20.04.2
    libsrslte_rf.so -> libsrslte_rf.so.0

The SRSLTE_SOVERSION variable should be increased with each backwards
incompatible change of the library.

Signed-off-by: Jan Remes <jan.remes@invasys.com>
4 years ago
yagoda 615af5cc4d setting seed to constant in prach test 4 years ago
Andre Puschmann b08a586fd4 pdu: refactor error logging
just some refactoring of error messages when a PDU packing error occurs
4 years ago
faluco 693d2f10b7 - Fix hex dumps newlines. 4 years ago
Pedro Alvarez 2f0125ef4e Fix issue recovering key state, when the first HO fails (specifically, is_first_ncc was not recovered). Minor improvements in key logging. 4 years ago
faluco 079ae70e64 - Fix logs entries having two newlines instead of one. The old log formatter will delegate this to the new one. 4 years ago
Andre Puschmann f73fa47a7b pdu: fix printing of buffer state of long BSR
extracted wrong number of bits for 2nd LCID in long BSR
4 years ago
Xavier Arteaga ef9d77c966 SRSUE: add PRACH config present field in PHY configuration structure 4 years ago
faluco 51b27fc255
Import latest srslog version (#1796)
* - Import latest srslog version.
- Adjusted the nas_test to create logs correctly.
- Remove timestamp formatting now that is provided by srslog.
4 years ago
Ismael Gomez 4e88daae21
Set DCI unpacking errors to info (#1781) 4 years ago
faluco 85544bb8d3 - Remove unnecessary newline character and optimize the code to use fputs instead of fprintf since no formatting is required. 4 years ago
faluco dfeed52514 - Rename out_stream function to console. 4 years ago
faluco 62faef7c71 - Replaced all uses of the log::console method. 4 years ago
faluco 302f9793ca - Add common utils to print to stdout and stderr as a first step to remove the log::console method. 4 years ago
Andre Puschmann 795db30338 pdcp: drop PDCP control PDUs
this patch adds a check to drop all PDCP control PDUs
in order to prevent handling them as data PDUs.

This could happen when the size exceeded the arbitrary length check.

This should fix #1787
4 years ago
Xavier Arteaga d375e305ec Initial NR DMRS for PDSCH 4 years ago
Ismael Gomez 76bfc78147
Fix issues with Sounding-RS (#1761)
* Fix deadlock caused by update_measurements calling in_sync

* Fix overlapping SRS condition

* Do not use shortened PUSCH in transmissions and retx from RAR

* Revert "Fix deadlock caused by update_measurements calling in_sync"

This reverts commit f58c8c8c766f8f95baa3a3bf8287d8e25b2057ba.
4 years ago
Ismael Gomez b94d24ed98
Take into account CRS from neigbhour cells when measuring interference (#1757)
* Take into account CRS from neigbhour cells when measuring interference

* fix std::isnormal compilation

* Fixed compilation of test

* Address comments

* Remove unused overrides
4 years ago
Xavier Arteaga 236ef4378d Fix u32 parsing 4 years ago
Xavier Arteaga ede58319ae Vector: added conjugate complex float to short 4 years ago
Xavier Arteaga 8566cbb079 Added device name to prach_test_usrp 4 years ago
Xavier Arteaga 60d563aa06 Fix ringbuffer read conversion 4 years ago
Xavier Arteaga eb5210dbda Radio stops Rx stream prior to stop and benchmark prompts RF metrics 4 years ago
Xavier Arteaga de0501cc55 Fix radio benchmark 4 years ago
Xavier Arteaga c20d4ff5cc Added ringbuffer zerocopy a timeout 4 years ago
Xavier Arteaga 759719ad55 Improved RF helper 4 years ago
faluco f0d651ae8e - Fixed a leak in the MME class not releasing the static byte buffer pool.
- Now the pool gets destroyed on program exit using a unique_ptr.
- Removed manual cleanup() calls in all the code base to free the pool instance.
4 years ago
faluco b892da0294 - Calculate the FFT of the PRACH on demand.
- Fixed a PRACH test that was failing with ASAN.
4 years ago
Xavier Arteaga 8cb3945886 SRSUE: fix RV assertion for PUSCH 4 years ago
Xavier Arteaga 44c2412be2 SRSUE: silent PUSCH encoding error by dropping invalid grant 4 years ago
Andre Puschmann 9dd02af15c network_utils: lower verbosity of when socket connection fails
the network helper can log this event but it should be up to
the caller to decide whether this is an error or not.
4 years ago
Andre Puschmann 33c050791f pdu: add missing to_string() content for MAC SCH PDU subheaders
* add both scell activation CE
* add rnti to CRNTI and CONT RES CE
4 years ago
Xavier Arteaga 1d71cf8557 Avoid zero division 4 years ago
faluco 1860006203 - Fixed leaks in prach module spotted by asan. 4 years ago
yagoda 24574caf44 cleaning up the PRACH time offset calculation 4 years ago
yagoda b5a8d82058 -adding more prach tests to make test, removing some variables from stack
-PRACH time offset to TA unit conversion
4 years ago
yagoda 59082770d3 moving some arrays to the heap, fixing formatting, setting dft norm 4 years ago
yagoda f6ea431555 -adopting new PRACH equalization approach for successive cancellation
-adding frequency domain time offset detection
-adding to testing of PRACH
4 years ago
yagoda ec7873e7cc refactoring PRACH, adding phase correction to successive cancellation 4 years ago
yagoda 4d8888aae6 - adding simple successive cancellation to PRACH detection
- adding testing for same and for offset detection
4 years ago
Ismael Gomez 1bd3e76f98 Move unncessary buffer in radio 4 years ago
Ismael Gomez c4080e35cc Set different timestamp behaviour for X300 and B200 4 years ago
Andre Puschmann d48bc8837e pdu: refactor MAC PDU class
this patch refactors the MAC PDU class, the main changes are:

* add to_string() method to pretty print PDU and subheaders
  This allows to have a single log entry per MAC PDU with all its
  contents.
  It removes the C-style fprint() method

* Simplity payload vs. w_payload_ce
  Before we've used payload when reading the PDU and w_payload_ce
  as a buffer when writing. In all getters we needed to differentiate
  between both. Now payload points to w_payload_ce initially and is
  only updated when parsing a new PDU.

* add various helpers, e.g. to get subheader index, update a BSR, ..

* fix PDU test to use new to_string() method
4 years ago
Ismael Gomez 54eed11e1d Refactor decision for extended CSI/SRS 4 years ago
Ismael Gomez c9daf1f61a Make const args 4 years ago
Ismael Gomez e2154d2213 Renamed constants to SRSLTE and use SRSLTE_CFI macros 4 years ago
Ismael Gomez 38e2ffe414 Use Format1A when using CA and 15 PRB due to DCI size ambiguity 4 years ago
Ismael Gomez 51521ad8e4 Improved PDCCH blind search and fixed a few issues with ambiguous DCI size with Release 10 4 years ago
faluco db03275337 - Fix compiler errors when trying to build the project without SIMD support. 4 years ago
Xavier Arteaga 1f18e8a054 SIMD: frequency estimate optimization 4 years ago
Xavier Arteaga bf1b7b8527 SIMD: fix NEON compilation 4 years ago
Ismael Gomez 0afcea9d61
Do not allow empty TBS PUSCH. Account for CQI from inactive cells before activated. (#1667) 4 years ago
Xavier Arteaga 080543815f Solved compilation warnings and enb_phy_test stop 4 years ago
Xavier Arteaga b8f4d03979 Fix in SIMD frequency estimation 4 years ago
Xavier Arteaga 611dd67364 SRSENB: PUCCH TA measurement only available with detected PUCCH 4 years ago
Xavier Arteaga 87edafeddb Reduced SRS test cases to SF index 0 4 years ago
Xavier Arteaga ee6f24befe Optimize vector frequency estimation 4 years ago
Xavier Arteaga bc0aba0d8a SRSENB: calculate TA from PUCCH messages 4 years ago
Andre Puschmann 49a7a90698 mac: simplify BSR packing logic
simplify logic to check whether a BSR fits and, if so, which type.
before the check has been done in two places.

we now also accomodate for the CE subheader size.
4 years ago
Xavier Arteaga 1843c9efbc SRSENB: PUCCH TA measurement only available with detected PUCCH 4 years ago
Xavier Arteaga 3aec23f7d8 SRSENB: calculate TA from PUCCH messages 4 years ago
Xavier Arteaga df2c949417 Radio: add individual Rx gain and integrate in srsue
Fix compilation

Fix compilation

Add missing variable. Wasn't compiling

Radio: revert some changes
4 years ago
Xavier Arteaga 04d7267734 UHD: Force LO frequency option 4 years ago
Xavier Arteaga b3d66c98c3 SRSENB: tx gain per channel and fix bug 4 years ago
Andre Puschmann 3f02e56a1e uhd: do not stop rx_stream when setting rx_rate for the B210
with the B210 and 2 RF ports, i.e. MIMO mode, we have stopped the
Rx stream after changing the rx_samp_rate but didn't start it again.

Either the issue doesn't exist in SISO mode or we never saw it but for MIMO
it can be reproduced easily with rate changes during streaming, i.e.:

$ ./lib/src/radio/test/benchmark_radio -p 2 -t 10 -x -y -s 23.04e6
Instantiating objects and allocating memory...
Initialising instances...
Opening 2 channels in RF device= with args=default
[INFO] [UHD] linux; GNU C++ version 9.2.1 20200304; Boost_107100; UHD_3.15.0.0-2build5
[INFO] [LOGGING] Fastpath logging disabled at runtime.
Opening USRP channels=2, args: type=b200,master_clock_rate=23.04e6
[INFO] [B200] Detected Device: B210
[INFO] [B200] Operating over USB 3.
[INFO] [B200] Initialize CODEC control...
[INFO] [B200] Initialize Radio control...
[INFO] [B200] Performing register loopback test...
[INFO] [B200] Register loopback test passed
[INFO] [B200] Performing register loopback test...
[INFO] [B200] Register loopback test passed
[INFO] [B200] Asking for clock rate 23.040000 MHz...
[INFO] [B200] Actually got clock rate 23.040000 MHz.
[INFO] [MULTI_USRP]     1) catch time transition at pps edge
[INFO] [MULTI_USRP]     2) set times next pps (synchronously)

Warning: TX gain was not set. Using open-loop power control (not working properly)

Setting manual TX/RX offset to 0 samples
Start capturing 10000 frames of 23040 samples...
Changing sampling rate to 23.04 Msamps/s
Setting manual TX/RX offset to 0 samples
Changing sampling rate to 1.92 Msamps/s
Setting manual TX/RX offset to 0 samples
/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1211: Error timed out while receiving samples from UHD.

/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1211: Error timed out while receiving samples from UHD.

/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1211: Error timed out while receiving samples from UHD.

/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1211: Error timed out while receiving samples from UHD.

/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1211: Error timed out while receiving samples from UHD.
4 years ago
Andre Puschmann 7253efe17e rf_blade: fix memleak when device wasn't found 4 years ago
Andre Puschmann 9684b2a63a uhd: fix memleak when USRP wasn't found 4 years ago
Andre Puschmann c327a18f59 radio: fix memleak of dummy buffers 4 years ago
Ismael Gomez 59b9125d4e
Do not send time_spec in between the burst. X300 does not like it (#1583) 4 years ago
Ismael Gomez a4835dd2c8
More accurate MCS reduction when PUSCH carries UCI (#1630) 4 years ago
Xavier Arteaga bd46c40650 srsLTE: fix minor aesthetics 4 years ago
Xavier Arteaga 7bad21c30a Radio: added locks to protect sample rate change concurrent access 4 years ago
Xavier Arteaga 029f36b449 srsLTE: added efficient integer resampler and srsue/srsenb integration 4 years ago
Xavier Arteaga 0e96ef3df0 Channel emulator takes SNR as input parameter 4 years ago
Andre Puschmann 9149cf852d rf_uhd: fix rx timeout error after late with B210
it fixes #1623.

this happens more often with MIMO since lates are more likely here.

after a late, the Rx stream must not be stopped on the B2xx either.

<log>
RF status: O=3, U=0, L=1
/home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1209: Error timed out while receiving samples from UHD.

stop rx stream
./home/anpu/src/srsLTE/lib/src/phy/rf/rf_uhd_imp.cc.1209: Error timed out while receiving samples from UHD.

stop rx stream
/home/anpu/src/srsLTE/lib/src/phy/ue/ue_sync.c.775: Error receiving samples

/home/anpu/src/srsLTE/lib/src/phy/ue/ue_cell_search.c.312: Error calling srslte_ue_sync_work()

/home/anpu/src/srsLTE/lib/src/phy/ue/ue_cell_search.c.272: Error searching cell
</log>
4 years ago
Andre Puschmann 5e40bfe72c mac_pdu: unpack and print BSR index as well as BSR value in bytes
before the BSR was extracted but the actual index (between 0 and 63)
was not stored but directly converted into bytes.

for log parsing and debugging it is easier to follow the index
value. this patch therefore adds both values to the log message
and extends the API accordingly.
4 years ago
Andre Puschmann 55336665b9 rlc: remove timers and sdu queue length from RLC TM ctor
timers aren't used in RLC TM, also the default queue length is
fine to be used at all times.
4 years ago
Andre Puschmann 8e44d0504c radio: fix device mapping for mimo
commit #51c6e8d1 introduced a regression in which the 2nd antenna
port was never considered. All MIMO ZMQ based tests therefore failed.
this fixes #1608
4 years ago
Xavier Arteaga 710700d0eb SRSUE: Fix synch error correction for multiple channels 4 years ago
Andre Puschmann d5da4bd8b6 radio: fix printf for 32bit 4 years ago
Francisco Paisana 7605c7df23 added s1ap handover notification, fixed s1ap asn1 bug, and fixed bad fields for admitted erabs in ho req ack 4 years ago
Francisco Paisana 26f46ea067 add S1 Handover Request handling in target eNB 4 years ago
Andre Puschmann cb2d7f4c16 rf_uhd_generic: add explicit ctor and dtor
clang 6 complained about a missing virtual dtor and thus
failed compilation. this patch adds both, an explicit ctor and dtor.
4 years ago
Andre Puschmann 498af989bf rf_uhd: add missing endl to UHD log macros 4 years ago
Xavier Arteaga 46ab07123d UHD: fix compatibility with 3.9.7 LTS 4 years ago
Andre Puschmann 5867668c0c rf_uhd_rfnoc: fix compilation for UHD before 3.15
the enable_rx_timestamps() for the radio_ctrl object has only been
introduced in Nov 2019 for UHD 3.15 and therefore needs
to be excluded when compiling for 3.14 and below.

Note: According to the original UHD commit in
67dbaa41f2 (diff-60a9387c0fc8406fd5b39fa995dd8c14)
it looks like the Rx timestamps are disabled by default
for UHD versions before 3.15

This commit fixes #1602
4 years ago
Xavier Arteaga 0cd61145ca RFNOC: added optional FPGA FIFO 4 years ago
Xavier Arteaga 237de07ab3 UHD: disable AD936x based device reset 4 years ago
Xavier Arteaga ff8925b6ec UHD: use same timeout policy than previous release 4 years ago
Xavier Arteaga ac76a398fe UHD: Minor stability improvement 4 years ago
Xavier Arteaga d2abaaf719 UHD: add initial test for AD936x based devices during initialization 4 years ago
Xavier Arteaga f80c779d88 RFNOC: added DUC/DDC internal loopback option and test 4 years ago
Xavier Arteaga dcf05f7a53 UHD: Improved RFNOC 4 years ago
Xavier Arteaga 38d9545e99 UHD: API improvement 4 years ago
Xavier Arteaga 405e0c8195 UHD: Check if tree exist before requesting access 4 years ago
Xavier Arteaga 5d43fc903e UHD: fix SPP equal 0 4 years ago
Xavier Arteaga 774c0926a6 UHD: added device args for log level, spp and return if timeout 4 years ago
Xavier Arteaga 88a1ab12c5 UHD: Generic detects if it a AD9361, USB based device and resets if LIBUSB_TRANSFER_ERROR is detected 4 years ago
Xavier Arteaga 04a661d239 UHD: RFNOC class detects custom DDC and DUC 4 years ago
Xavier Arteaga 180fb42dc3 UHD: minor aesthetic corrections 4 years ago
Xavier Arteaga 0f24d510ac UHD: Fix RFNOC DDC frequency calculator 4 years ago
Xavier Arteaga ebf995c621 UHD: better RFNOC detection and configuration 4 years ago
Xavier Arteaga 0e360b3953 UHD: RFNOC Dynamic re-configuration 4 years ago
Xavier Arteaga d9cb51d261 UHD: Added custom DDC/DUC support
UHD: Aesthetic corrections

UHD: minor aesthetic changes
4 years ago
Xavier Arteaga e4a794fdbd UHD: Initial RFNOC implementation
UHD: Fix RFNOC for multiple carriers
4 years ago
faluco cfd3f51931
Import of srslog into srsepc and srsenb. (#1574)
* - Import of srslog into srsepc and srsenb.
* - Removed logger_file and logger_stdout files.
4 years ago
Xavier Arteaga 2271aec6b2 Radio: remove trace 4 years ago
Xavier Arteaga a5fefbfdd3 Radio: fix possible overflow 4 years ago
Xavier Arteaga 51c6e8d1a6 Radio: channel map includes device mapping, unmapped Rx uses dummy buffers 4 years ago
Xavier Arteaga edda1f730a srsLTE: Placeholder Band correction 4 years ago
Xavier Arteaga d8eaa99132 Radio: do not use more radios than necessary 4 years ago
Xavier Arteaga 5258f27490 Fix start-of_burst for PRACH Test USRP 4 years ago
Xavier Arteaga fda1d040e7 SRSENB: implement PUSCH threshold for UCI bits 4 years ago
faluco efdff8ba4c
Import srslog into srsue (#1556)
- Import the srslog project into srslte.
- Ported srsue app to use the new logging framework.
- Implemented a wrapper that dispatches log entries to srslog.
- Renamed an existing log test to be more specific to avoid name clashes.
4 years ago
Andre Puschmann d441486f76 fading: fix heap buffer overflow in fading sim
at the when applying the fading channel we copied the state back
to our buffer. Since we are offsetting the read buffer
by X samples, we need to make sure that we don't read after then
(len-X) samples of the temporary memory buffer
4 years ago
Andre Puschmann 1199a79851 fix Scell sync for large cells
the PSS detection needs more temporary buffer than a full subframe.
we therefore need to allocate and initialize the sync object with
larger maximum size to support Scell search of large cells, e.g.
20 MHz

this fixes issue #1538
4 years ago
Ismael Gomez f380f46a10 Revert "Remove unnecessary zero memory (#1564)"
This reverts commit f662aeaff3.
4 years ago
Andre Puschmann 9550bd3ef8 rlc: revisit interface for MAC and RRC
* add locked and unlocked version of has_data() since one is
  called from stack and one from PHY threads

* add comments in each interface section as to why locking
  is required or not

* remove RLC rwlock when not required

* move calls only used by RRC to RRC section
4 years ago
Andre Puschmann 7f98cb9b62 pdcp: log discard timer duration in init()
to log the configured discard timer length
4 years ago
Andre Puschmann a578ff1975 pdcp: fix typo 4 years ago
Ismael Gomez f662aeaff3
Remove unnecessary zero memory (#1564)
* RF drivers to allow nullptr buffers in send/recv

* Remove zeromem from radio

* remove unused buffers
4 years ago
Andre Puschmann dc67d28709 nas: do not generate NAS encryption key if also is set to NULL
its more a cosmetic change to clean the logs. this makes
sure that a zero key is logged when NULL encryption is selected.
4 years ago
Ismael Gomez 1eaf7efab0 Fix UL adaptive retx rv index 4 years ago
Xavier Arteaga 5cf2089a8c srsLTE: increased SRS test TA us threshold 4 years ago
Xavier Arteaga 794f969e1a srsLTE: fix TA calculation 4 years ago
Xavier Arteaga 729986f259 srsLTE: Added PUCCH format 3 valid correlation 4 years ago
Xavier Arteaga 0192130742 SRSUE/SRSENB: UCI bits are carrier by the lowest serving cell index
SRSENB: Fix UCI in lowest serving cell index PUSCH transmission
4 years ago
Andre Puschmann 6fb01d61a7 rlc: change remaining occurances of "SN: " to "SN="
streamline all RLC AM and UM for better log analysis
4 years ago
Xavier Arteaga 137d250d66 srsLTE: fix ZMQ decimation pointer 4 years ago
Andre Puschmann a7911f0dab pdcp,rlc: refactor SDU queueing policy
this patch refactors the SDU queuing and dropping policy of the RLC and PDCP layer.
the previous design had issues when packets have been generated at a higher
rate above the PDCP than they could be consumed below the RLC.

When the RLC SDU queues were full, we allowed two policies, one to block on the write
and the other to drop the SDU. Both options are not ideal because they either
lead to a blocking stack thread or to lost PDCP PDUs.

To avoid this, this patch makes the following changes:

* PDCP monitors RLC's SDU queue and drops packets on its north-bound SAP if queues are full
  * a new method sdu_queue_is_full() has been added to the RLC interface for PDCP
* remove blocking write from pdcp and rlc write_sdu() interface
  * all writes into queues need to be non-blocking
  * if Tx queues are overflowing, SDUs are dropped above PDCP, not RLC
* log warning if RLC still needs to drop SDUs
  * this case should be avoided with the monitoring mechanism
4 years ago
Francisco Paisana 1a9c04bf2f use of task scheduler handle in pdcp 4 years ago
Andre Puschmann d5f0ad9f35 pdcp: fix typo 4 years ago
Andre Puschmann f6d3467884 ringbuffer: fix timeout calculation for timed read
with ZMQ RF, we've seen the radio returning -1 and traced
the issue down to the ringbuffer.
in fact, pthread_cond_timedwait() returned 22 (EINVAL) indicating
a wrong timeout value. The issue was likely an overflow
in the timespec parameter. This patch checks for the return
value of pthread_cond_timedwait() and also calculates the
nanosecond wrap around for the timespec
4 years ago
Andre Puschmann aed38a6028 rf_zmq: increase default ZMQ timeout to 2s
amarisoft flags an RF error and exits after not receiving samples
for the radio. Running with ZMQ in the RFCI, the UE sometimes needs more
time to start up due to slow processing and no fftw wisdom file and
then Amarisoft eNB times out. This gives the whole process a little
bit more time. Should we still find it too short we may increase
it further.
4 years ago
Andre Puschmann b3e92883d4 rlc_um: reduce log level when provided space is not enough to build PDU
this is not a warning case as it can always happen. reduce level to info therefore.
4 years ago
Andre Puschmann 95f5093432 rlc_am: hold lock while handling new PDUs
This lock was removed in 1cbf7eac because it was considered unneeded.
However, as can be seen in issue #1503, we need to protect the access
to rx_window, for example.

Issue #1503 shows a stack trace where a PHY worker generates a status PDU.
While holding the mutex to access rx_window, the stack thread on the
other hand, happily accesses the rx_window member without acquiring
the lock. This commit protects all handle_*() functions in write_pdu().

This reverts commit 1cbf7eac04.
4 years ago
Andre Puschmann 6f5da19312 pdcp: similar to tx, also reduce log for Rx
instead of logging PDU received from below, and SDU that is forwarded
to above, only log the PDU in rx in info mode.

The next layer will do the same and log the PDU received (which is the SDU coming from here)
so there is now loss of information in the logs.
4 years ago
Andre Puschmann 6654453e22 pdcp: reduce amount of log messages during tx
drop logging encrypted PDU seperately. Instead, only log formatted
PDCP PDU before passing to lower layers
4 years ago
Xavier Arteaga 6f03ce7e11 srsLTE: minor radio fix 4 years ago
Xavier Arteaga 67543a73bb Radio: fix erroneous offset 4 years ago
Xavier Arteaga 8966db31d8 srsLTE: Radio benchmark plots all ports 4 years ago
Andre Puschmann ff96336f91 rlc_um: fix reestablishment for sending UM entity
we've reset the rx state variables during reestablishment but not
the tx state variable.
4 years ago
Francisco Paisana 84f34bc736 changed to a label filtering approach for ctest 4 years ago
Francisco Paisana c6323478d2 remove unecessary sleeps in mac test, and add long_ prefix in long tests 4 years ago
Andre Puschmann eb56efe9f5 rlc_am_lte: turn error message into warning and print state variables
the issue doesn't cause any unrecoverable situation so its not
appropiate to use the error level
4 years ago
Andre Puschmann df50dd7d3c rlc: extend RLC metrics
extend RLC metrics to count Rx/Tx PDUs/SDUs bytes/#
4 years ago
Andre Puschmann 82f811ed52 rlc_am: change return value when writing SDU
return false when SDU couldn't be added to SDU tx queue so
to count dropped SDUs in base
4 years ago
Andre Puschmann 3cef20607e rlc_am: fix bug in returning zero len bytes 4 years ago
Andre Puschmann 86025cf390 rlc_um: fix PDU packing when newly added SDU segment was too large
during the PDU packing it could happen that a new SDU segment
was added but the resulting larger header was so big that not even
a single byte of the new PDU could be added. because this
corner case wasn't handled correctly an invalid PDU was transmitted.

the solution is to revert the addition of the new SDU.
4 years ago
Andre Puschmann fc3cd24177 rlc_um: fix counting of lost PDUs
* change try_push() return value to indicate whether the addition
  of the SDU to the tx queue was successful or not
* count lost PDUs
4 years ago
Andre Puschmann 96726a03e0 rlc_stress_test: fix PCAP support
expose actual RLC configuration to PCAP object
4 years ago
Ismael Gomez 493b7ea2da Remove SNR threshold based link failure detection 4 years ago
Francisco Paisana 2de702f50e disable carrier aggregation when ue release is below 10 or category is below 5 4 years ago
Francisco Paisana e555e50a90 fix pnf packing for MIB messages 4 years ago
Francisco Paisana e3e9bbcd62 fix PNF PDU size cutting 4 years ago
Francisco Paisana fddcbc9879 fix vnf-ue stack interface 4 years ago
Andre Puschmann ad1b9d4d9b rlc_um: improve warning message to better differentiate them 4 years ago
Francisco Paisana d7138b7752 fix nr activation guards 4 years ago
Ismael Gomez 29e126a583
Add per-channel TX gain (#1450)
* Change type of rf_set_gain() to avoid unambiguous return with negative gains

* Add per-channel TX gain
4 years ago
Francisco Paisana 52c6c6aafd add ifdef guards for NR code 4 years ago
Francisco Paisana b68ef69ab4 fix comments and other minor issues 4 years ago
Francisco Paisana 468389997e fix header sn check 4 years ago
Francisco Paisana 42969ad992 add tb size as argument to gnb 4 years ago
Francisco Paisana 2f8dad03cc add rlc nr locking 4 years ago
Francisco Paisana f0874b780b add radio_base/null classes 4 years ago
Francisco Paisana 64e8f5e3ed update license year 4 years ago
Pedro Alvarez 9c1a7d2cf1 Removed get_bearer_status in PDCP. Renamed get_state/set_state to
get_bearer_state/set_bearer_state.
4 years ago
Pedro Alvarez 208a539499 Split PDCP tx_count state variable into tx_hfn and next_pdcp_tx_sn
variables.
4 years ago
Pedro Alvarez 08578a7331 Switched to use a struct to hold the PDCP entity state variables. Deleted some unecessary setters. 4 years ago
Pedro Alvarez 66d4f320e5 Added intereface to set PDCP state after reestablishment. 4 years ago
Pedro Alvarez 33567d81db Added interface to get internal PDCP state. 4 years ago
Pedro Alvarez 4093e75237 Starting to add getters and setters of the state in PDCP lte entity. 4 years ago
Xavier Arteaga 0e415260e9 SRSUE: scell_sync vector changed to map 4 years ago
Xavier Arteaga e0e8405285 SRSUE: initial scell sync
SRSUE: SCell Synch feedbacks delay

SRSUE: Implemented SCell Radio offset correction
4 years ago
Xavier Arteaga 5c0bb000ca UE DL does not complain if no grant is not found 4 years ago
Xavier Arteaga 8a774136de Radio: return error if a RF instance fails to open 4 years ago
Xavier Arteaga f04cf2090a Integrates number of samples in radio buffer
Fix minor issue

Radio: Fix minor bug and add unit test
4 years ago
Xavier Arteaga de230826b9 Added string helper for removing spaces and parsing list
Fix

Fix string parser
4 years ago
Xavier Arteaga 89b24b54e5 Refactored radio class for acommodating multiple RF devices 4 years ago
Francisco Paisana 3c2e3dbdbf added latest mac nr updates 4 years ago
Francisco Paisana cc52edf820 added latest pnf/vnf api updates 4 years ago
Francisco Paisana b05ce2fe57 added pnf_dummy test 4 years ago
Andre Puschmann 9f98bb3f54 disable prach_test_usrp compilation if no RF is selected 4 years ago
Xavier Arteaga 0e5704731e Removed UHD unrelated changes 4 years ago
Xavier Arteaga 258f7a180c Improved PRACH test USRP 4 years ago
Xavier Arteaga cd463d1b87 UHD: Initial C++ porting
UHD: cmakefix

x3
4 years ago
Xavier Arteaga 039f2164a6 Initial Sounding Reference Signals implementation 4 years ago
Francisco Paisana 613003ac53 add srsenb::rrc class 4 years ago
Ismael Gomez 84b84eaad6 Move search_in_common variable 4 years ago
Ismael Gomez 9b634b8d2a Search DCI in UE space before common to avoid DCI size ambiguity. Fixes #1398 4 years ago
Andre Puschmann 9fd327fcac soapy: use SoapySDRDevice_enumerateStrArgs to create Soapy args object
this allows to use Soapy device parameter when creating the device
5 years ago
David Rupprecht 61b69a0dab security: refactor code, fix race in eia1
* state funktion for eia1 (mitigate race condition)
* Extra file for snow3g
* just use mbedtls aes
* ref specification
* adding const keyword to security functions
5 years ago
faluco 617cad58ab Fix identation of arrays. 5 years ago
faluco cf5b321fb5 Replace magic numbers with macro constants.
Adjust comments to refer to these macros.
5 years ago
faluco ac3b7ed54c Move static array inside function as it is only used in there. 5 years ago
faluco 9484db8a90 Added header comments to srslte_sfidx_tdd_nof_X family of functions.
Fixed a comment referring to an older TS release.
Remove elses after returns.
5 years ago
faluco 8c59606d6f Add comment header to srslte_sfidx_tdd_type.
Remove else after return.
5 years ago
Xavier Arteaga 9f5aef30e6 SRSENB: fix DL ACK decoding 5 years ago
Francisco Paisana 2da8c923b1 removed commented code and fixed interfaces 5 years ago
Francisco Paisana b4b5cd7cd6 added nr gnb and ue interfaces 5 years ago
Ismael Gomez a1f0f8de35
Add callback to RLC to indicate BSR for TX and reTX queues (used in ENB) (#1361) 5 years ago
Andre Puschmann 1eaa99530f rlc_am: tiny refactor of rlc_amd_pdu_header_t
mainly turning header into proper class and adding default init value
5 years ago
Xavier Arteaga 20db13abc7 SRSUE: fix condition number calculation 5 years ago
Xavier Arteaga 9d5c2d70df SRSENB: Fix PHY reconfiguration for HO
Minimal aesthetic change
5 years ago
Pedro Alvarez 6ce33c3812 Small compilation fixes for GCC 10.1 5 years ago
Francisco Paisana e8aff22e1b using new rrc obj id util methods in handover code 5 years ago
Francisco Paisana d43448e8a1 created security cfg handling class for rrc ue and refactor bearer_list handling 5 years ago
Francisco Paisana ca0db7fffe created generic methods to apply toaddmodlist and removelists. 5 years ago
Francisco Paisana 791d84e639 created error_type and cleaned up expected 5 years ago
Francisco Paisana a2b76a4a5f use references rather than pointers 5 years ago
Fabian Eckermann 447b989aad fix parsing of zmq arguments
Use the return value of parse_string function to determine whether a parameter was found.
I experienced issues when the rx_type was set, but the rx_format was not. This led to "Unsupported sample format pub" as the tmp variable is still set to the value of the rx_type.
5 years ago
Ismael Gomez 847366bcdb Don't set high master clock rate for 75 PRB 5 years ago
faluco 4fb290ea27 Remove ifdefs now that this SIMD op is supported. 5 years ago
faluco c39ea2f583 Adjust possible type mismatch. 5 years ago
Andre Puschmann 189685b6f5 demod_soft: fix clang warning in demod NEON code
Try to bring back compilation.
Disable temporarily Werror.

Re-enable two simd functions.
5 years ago
Andre Puschmann f67524707d neon: add srslte_simd_b_neg()
clang complained about an uinit var that is returned and it turned
out that we don't even implement that function in NEON.

I've found a nice MIT-licensed header that was easy to integrate.
5 years ago
Andre Puschmann 53ab53ee77 ue_sync: fix tracking in GNSS_SYNC mode
this fixes the subframe-accurate rx in tracking mode.
previously we've only alligned to the next subframe start in find and
when there was a single overflow we've lost the track.

this patch calculates the offset in samples to the actual start of the
subframe (full ms of the receive timestamp) vs. the actual
receive timestamp and uses the value as the "next_rf_sample_offset"
to realign on the next receive
5 years ago
Andre Puschmann ca3b76df6e chest_sl: fix some possible array access at negative index 5 years ago
Andre Puschmann 28c98280d7 ue_dl_nbiot: convert macro to access SF contents into member var
also use srslte_vec_cf_cp() helper functions
5 years ago
Andre Puschmann 9648e47eb6 ue_cell_search_nbiot: fix potential out-of-bounds access
we've used a macro that can return -1 as access index
for an array. this has now been converted in a member
that is initialized and checked during init
5 years ago
Andre Puschmann d64fa19321 ue_dl_nbiot: check sf_idx before accessing buffer
this fixes a potential out-of-bounds access
5 years ago
Andre Puschmann ba4c2f10f0 fix potential out-of-bounds access in static look-up-tables
check index before accessing lut
5 years ago
Andre Puschmann 7aeddfd186 fix potential error where return value -1 is used for loop termination 5 years ago
faluco 340ec61e8e Code review. 5 years ago
faluco e28d9bb473 Fix for 1492950. 5 years ago
faluco 6fdceadc4e Fix for 1480100. 5 years ago
faluco 7bec101831 Small refactor to eliminate a function that causes undefined behaviour. 5 years ago
Andre Puschmann a0665b721e prach: fix illegal mem access when wrong configs are passed
this fixes Coverity issue 1480095
5 years ago
Xavier Arteaga 282cda7155 Fix Radio segfault 5 years ago
Xavier Arteaga f69aad3aac Clean up channel class 5 years ago
faluco d9529a3a8f Fix for 1480071. 5 years ago
faluco 0ba9164ae2 Fix for 1480055. 5 years ago
Andre Puschmann 8185b7c793 ue_dl: fix potential out-of-bounds access when decoding DCIs
fixes Coverity issue 1480088 where srslte_ue_dl_find_dl_dci() expects
an array of struct srslte_dci_dl_t but is only given one element.

srslte_ue_dl_find_and_decode() itself only uses the first decoded
message but find_dl_dci() may still decode more than that
5 years ago
faluco 9efa24bfa9 More warning fixes. 5 years ago
faluco d3cb5dcffd Start fixing clang 10.0.0 warnings.
Disable -Werror temporarily.
5 years ago
faluco 74dae2c287 - Small refactor to make math operations without implicit casts. 5 years ago
faluco d7433a551b Initialize TDD matrix with shorter symbols using macros. While there move another matrix next to where it is used. 5 years ago
faluco 7ff251f112 - Fixed warnings caught by Clang 9.0.0 5 years ago
Andre Puschmann 49a375ce1a arch_select: fix compilation for clang 3
In clang 3's C headers, the bit_SSE4_2 and bit_AVX2 macros
aren't defined/supported. So we can only use them if
they exist.
5 years ago
Francisco Paisana fbd889ad4d fix formatting issues in asn1 5 years ago
Francisco Paisana e79fc9bf08 fixed generation of ie containers of one single ie object 5 years ago
Andre Puschmann f5d55847c2 nbiot: add r14 parameter to NPDSCH eNB and file test and make it the default
also add skip SIB2 option to UE example
5 years ago
Andre Puschmann 92fb6a94f4 npdsch: use r14 bcch sequence when encoding SIB 5 years ago
Andre Puschmann 2c6a95c1d5 nbiot_sync: fix potential segfault during sync when time gap is too big 5 years ago
yagoda 3f99e40159 -changing rlc so that mrb is never removed when going to idle
-adding metric counting to eMBMS MAC so that the count is not lost during eMBMS subframes
5 years ago
Xavier Arteaga d94078d543 Minor changes
Fix UE sequence generation

minor change
5 years ago
Xavier Arteaga 2d39c7261c renamed vector copy prefix from to 5 years ago
Andre Puschmann 9d529ba0d5 fix compilation on arm, add missing declaration and headers 5 years ago
Xavier Arteaga 2569a94deb Radio Tx handles more overlap/gap cases 5 years ago
Andre Puschmann cd26f6988c temporarily disbale rf_zmq_test test due to hanging on exit on some platforms 5 years ago
Andre Puschmann 6a764ae87c psbch: change memcpy() to srs_vec alternative 5 years ago
Francisco Paisana f8c6f55cac fix uninit var usages and signed bit manipulations 5 years ago