425 Commits (6fb01d61a75d8304b91989c1b8deb617f1968cff)

Author SHA1 Message Date
Andre Puschmann a7911f0dab pdcp,rlc: refactor SDU queueing policy
this patch refactors the SDU queuing and dropping policy of the RLC and PDCP layer.
the previous design had issues when packets have been generated at a higher
rate above the PDCP than they could be consumed below the RLC.

When the RLC SDU queues were full, we allowed two policies, one to block on the write
and the other to drop the SDU. Both options are not ideal because they either
lead to a blocking stack thread or to lost PDCP PDUs.

To avoid this, this patch makes the following changes:

* PDCP monitors RLC's SDU queue and drops packets on its north-bound SAP if queues are full
  * a new method sdu_queue_is_full() has been added to the RLC interface for PDCP
* remove blocking write from pdcp and rlc write_sdu() interface
  * all writes into queues need to be non-blocking
  * if Tx queues are overflowing, SDUs are dropped above PDCP, not RLC
* log warning if RLC still needs to drop SDUs
  * this case should be avoided with the monitoring mechanism
4 years ago
Francisco Paisana 7c364070ee creation of task scheduler interface for classes/functions running outside the main control thread 4 years ago
Francisco Paisana 1a9c04bf2f use of task scheduler handle in pdcp 4 years ago
Francisco Paisana 4f5e65781f created task scheduler class to deal with timers, thread pool, multiqueue, internal tasks 4 years ago
Andre Puschmann 2749c870e3 rlc_am: refactor control test
* move both tests into own functions and call those in main()
* use common test header and macros
4 years ago
Andre Puschmann 58e255cb63 pdu_test: add unit test to verify correct packing of 3B PDU with Short BSR 4 years ago
Andre Puschmann 5589816690 pdu_test: fix PCAP output
API now requires to pass CC index
4 years ago
Francisco Paisana e550bf726d updated fsm to allow enter methods to receive event that caused them 4 years ago
Francisco Paisana 84f34bc736 changed to a label filtering approach for ctest 4 years ago
Francisco Paisana ebb8f18000 set some extra tests with the prefix "long_" 4 years ago
Andre Puschmann a3d7d4517c rlc_um: add dedicated unit test for the PDU packing bug
Here is the test output with the fix disabled:

13:47:42.679774 [RLC_UM_1] [D] MAC opportunity - 14 bytes
13:47:42.679784 [RLC_UM_1] [D] pdu_space=14, head_len=2
13:47:42.679790 [RLC_UM_1] [D]  adding new SDU segment - 10 bytes of 10 remaining
13:47:42.679834 [RLC_UM_1] [D]  Complete SDU scheduled for tx. Stack latency: 0 us
13:47:42.679909 [RLC_UM_1] [D] pdu_space=4, head_len=2
13:47:42.679922 [RLC_UM_1] [D]  adding new SDU segment - 0 bytes of 10 remaining
13:47:42.679928 [RLC_UM_1] [I]  Tx PDU SN=0 (14 B)
13:47:42.679974 [RLC_UM_1] [D]  vt_us = 1

The test checks the correct packing and of the two PDUs at the end.
4 years ago
Andre Puschmann df50dd7d3c rlc: extend RLC metrics
extend RLC metrics to count Rx/Tx PDUs/SDUs bytes/#
4 years ago
Andre Puschmann 48db31c5cf rlc_stress_test: fix random PDU dropping
the rand() was sometimes giving NaN so this case needs to be handled
and the PDU not dropped to have real zero drop-rate
4 years ago
Andre Puschmann fc3cd24177 rlc_um: fix counting of lost PDUs
* change try_push() return value to indicate whether the addition
  of the SDU to the tx queue was successful or not
* count lost PDUs
4 years ago
Andre Puschmann 96726a03e0 rlc_stress_test: fix PCAP support
expose actual RLC configuration to PCAP object
4 years ago
Andre Puschmann 1c7bfde404 rlc_stress_test: fix compilation with PCAP enabled 4 years ago
Francisco Paisana e3e9bbcd62 fix PNF PDU size cutting 4 years ago
Francisco Paisana a0606669e2 fix ue nr gw initialization 4 years ago
Francisco Paisana e6418b4b39 fix variable naming 4 years ago
Francisco Paisana 1d07258458 created pnf bridge executable 4 years ago
Francisco Paisana f0874b780b add radio_base/null classes 4 years ago
Francisco Paisana 64e8f5e3ed update license year 4 years ago
Pedro Alvarez 9c1a7d2cf1 Removed get_bearer_status in PDCP. Renamed get_state/set_state to
get_bearer_state/set_bearer_state.
4 years ago
Pedro Alvarez 208a539499 Split PDCP tx_count state variable into tx_hfn and next_pdcp_tx_sn
variables.
4 years ago
Pedro Alvarez 08578a7331 Switched to use a struct to hold the PDCP entity state variables. Deleted some unecessary setters. 4 years ago
Andre Puschmann 1f73e6ae69 multiqueue: add option to create queue with non-default capacity
this allows to create a queue that has a non-default capacity
currently this is 8192, but the value might now be suitable in some
cases like for TTI sync events
4 years ago
Francisco Paisana 27e5d98ef9 added vnf phy nr 4 years ago
Francisco Paisana b05ce2fe57 added pnf_dummy test 4 years ago
Francisco Paisana 8a022fb35b fix noexcept declaration issue in gcc4.8 4 years ago
Francisco Paisana 6509399ed3 fix for move-only events 4 years ago
Francisco Paisana 12dda03bb8 add ability for fsms to self-trigger 4 years ago
Xavier Arteaga 039f2164a6 Initial Sounding Reference Signals implementation 4 years ago
Francisco Paisana edba7f57e4 corrected mac_nr_pdu includes 5 years ago
Francisco Paisana b4b5cd7cd6 added nr gnb and ue interfaces 5 years ago
Francisco Paisana a2b76a4a5f use references rather than pointers 5 years ago
Francisco Paisana a88bffa5d5 created expected type and respective test 5 years ago
Francisco Paisana cf9d31ea64 fix coverity warning for useless call 5 years ago
Francisco Paisana 2204cab4c8 old gcc version cannot support the detected pattern. Removing it 5 years ago
Francisco Paisana e3d0b1c89e format missing fsm table 5 years ago
Francisco Paisana f4d19a6d44 added fsm table formmatting comments 5 years ago
Francisco Paisana 3ef8c67d67 enter/exit are now inside the state class. No need for friend classes anymore 5 years ago
Francisco Paisana 9b48130ae1 use of transition table to support guards in fsms 5 years ago
Francisco Paisana 04e192eb0f redesign fsm to use transition table 5 years ago
Francisco Paisana e79fc9bf08 fixed generation of ie containers of one single ie object 5 years ago
Xavier Arteaga d94078d543 Minor changes
Fix UE sequence generation

minor change
5 years ago
Xavier Arteaga 9d0a3268e8 Added DL channel estimator algorithm options 5 years ago
Andre Puschmann 39680ffd26 rrc_asn1_decoder: fix uninit var 5 years ago
Francisco Paisana 1c74c5675e remove ambiguous enter/exit template method 5 years ago
Francisco Paisana e1ac6d7cfe use macro to disable throw 5 years ago
David Rupprecht 4e283ec942 Standalone decoders for nas and rrc in asn1 test. Thanks Dirk 5 years ago