Xavier Arteaga
27df357a66
Fixes #273
6 years ago
Xavier Arteaga
45e6473303
Removed not implemented/reserved TM4 PMI Error messages
6 years ago
Xavier Arteaga
717d767c2b
Removed PUSCH redundant line
6 years ago
Andre Puschmann
0380c83175
remove RF device calibration settings from UE/eNB config
...
- this remove RF calibration parameters that were an extra
section in the eNB/UE config but were hardly used (only old bladeRF)
- a better way to pass those parameter would be through the
device args in the normal rf config section
6 years ago
Ismael Gomez
6f0c554445
TA estimate correction factor calibrated for all bandwidths
6 years ago
Andre Puschmann
d981f129e0
Merge branch 'master' into next
6 years ago
Ismael Gomez
2cf381823c
Fixed bug in commit 197d855d3f
6 years ago
Zhe Huang
3433b0ffde
assign correct values from BladeRf manual calibration to correction
...
* Assign correct values from BladeRf manual calibration to correction
The rf_calibration function for blade RF was assgiing dc_gain to
BLADERF_CORR_FPGA_PHASE and dc_phase to BLADERF_CORR_FPGA_GAIN. This hot
fix corrects the value assignments in both rf_blade_set_tx_cal and
rf_blade_set_rx_cal functions.
6 years ago
Xavier Arteaga
f865296421
Added BladeRF Micro Support (required bladerf driver > 2.0.2)
6 years ago
IgnasJ
67c8bf1368
Fixes for srsLTE on ARM ( #229 )
...
* Fix ARM NEON code compilation
Fix LV_HAVE_NEON defintion incorrecly used instead of HAVE_NEON in some places
Replace vqabsq_s32 with vabsq_f32 as vqabsq_s32 requires int type (fails to compile)
Fix missing NEON code path in mat.h in srslte_mat_2x2_mmse_csi_simd()
* Fix timestamp overflow issue on 32-bit systems with Soapy driver
'time_t secs' can be 32-bit on some systems. This causes calculation:
'secs * 1000000000;' to overflow.
6 years ago
Ismael Gomez
0294923e2b
Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next
6 years ago
Ismael Gomez
197d855d3f
Fix issue #240
6 years ago
Xavier Arteaga
a9fcd64b1f
Fixes #259 : Turbodecoder AVX2 instructions under LV_HAVE_AVX (instead of LV_HAVE_AVX2)
6 years ago
Xavier Arteaga
7f72a90051
Implemented 16 bit LLR CSI in SSE
6 years ago
Ismael Gomez
243a7708d4
Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next
6 years ago
Ismael Gomez
826fbccf11
Fixed memory leaks in new decoder
6 years ago
Andre Puschmann
d19eb28a16
fix various variable initializations that gcc-4.8 complained about
6 years ago
Ismael Gomez
bc9d342959
New optimization on the PHY for both UE and eNodeB ( #251 )
...
* New parallel Turbodecoder implementation in SSE/AVX 16-bit and 8-bit
* Optimised UL Interleaver
* Include TB CRC calculation in FEC encoder
* New threading priorities
6 years ago
Xavier Arteaga
8d56b254f5
Fixed vector test failure criteria for conversions
6 years ago
Xavier Arteaga
ca429d2be5
Fixed turbocoder free
7 years ago
Andre Puschmann
dc41240106
increase UHD tx timeout to 1.0
7 years ago
Andre Puschmann
bfb9ba43b4
increase UHD recv timeout to 1.0
7 years ago
Andre Puschmann
e6366b4570
fix stopping of async thread in UHD
7 years ago
Andre Puschmann
9b8d7aeddf
fix warning
7 years ago
Andre Puschmann
b0a79ac616
fix segfault when ASYNC thread is disabled
7 years ago
wangqiang1588
dfce3ea155
Fix crash if args is NULL ,enable multi rx channels setting ( #198 )
7 years ago
Merlin Chlosta
deab23c9ec
Fix non-blocking rf_uhd_recv_with_time_multi ( #195 )
...
Return the number of actually received samples, not the requested samples.
7 years ago
Ismael Gomez
3a9f224f40
Turbo Coder LUT not a function of CB size
7 years ago
Xavier Arteaga
a21db86a78
SCH Codeblock CRC is computed at same time than parity 0
7 years ago
Andre Puschmann
be3b2fbc08
Merge pull request #239 from softwareradiosystems/epc_stacktrace
...
Epc stacktrace
7 years ago
Ismael Gomez
c012a6ea83
Mutex more operations in worker to fix segfault when HO. Protect pdsch/pusch from regenerating sequence
7 years ago
Xavier Arteaga
3d3f98b21e
Fixed posible interleaver segfault
7 years ago
Pedro Alvarez
c3ef88e112
Fixing conflicts with next.
7 years ago
Ismael Gomez
9c5b9cef94
Set initial AGC gain correctly
7 years ago
yagoda
8751645a48
cleaning up viterbi neon
7 years ago
Pedro Alvarez
7aaa9a1789
Moved srslte_debug_handle_crash to common/debug.c
7 years ago
Pedro Alvarez
96786e96da
Splitting the lib debug into phy and common debug.
7 years ago
Ismael Gomez
f273ec959b
Set initial AGC gain correctly
7 years ago
Andre Puschmann
5a0de01905
adding async thread to soapy
7 years ago
Andre Puschmann
d7e4797f3f
add rf error handler in soapy
7 years ago
Ismael Gomez
c32ee8944f
Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next
7 years ago
Ismael Gomez
1a1471955e
Fix incorrect MIB generation. Fixes issue #232
7 years ago
Ismael Gomez
a8f6081837
Minor changes in scheduler logs and style
7 years ago
Xavier Arteaga
92954c1aa4
Fixed UCI decoder defect in eNb. Improved PUSCH Unit Test. PUSCH CQI is printed like UE.
7 years ago
Xavier Arteaga
2c1608f6f1
Fixed UCI short CQI decoder. Fixed possible interleaver segfault. PUSCH Unit test tidied up.
7 years ago
jctallon
50589108c6
Mbms fixes ( #225 )
...
* fixing the threading structure for mbms in the gtpu
fixing some leaks in pmch tests
fixing stack overflow caused by radio objext
* adding sib.conf.mbsfn.example
* creating a different thread_mch object for the gtpu
* Make mch_thread an isolated class
* excluding mbsfn subframes from noise estimation and cfo estimation
* fixing pdsch ue plotting to only show pmch constellation when mbsfn is activated.
7 years ago
Ismael Gomez
8c92f3fddc
Improvements and fixes on srsENB scheduler ( #228 )
7 years ago
Ismael Gomez
d81062145f
Fixed phy_log was allocating memory dynamically on every call even when not enabled
7 years ago
Xavier Arteaga
f01f7b4945
Added Vector max abs SIMD function
7 years ago
Ismael Gomez
e18ba937dc
Limit uplink signal normalization to avoid clipping
7 years ago
Andre Puschmann
91e1b27219
Merge branch 'master' into next
7 years ago
Ismael Gomez
ea3fdf7f51
Increased uhd timeout
7 years ago
Andre Puschmann
0fcb27de53
soapy: make soapy log level a device param and fix issue in setting tx bandwidth
7 years ago
Ismael Gomez
c04c147451
Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next
7 years ago
Ismael Gomez
9d18349a08
Reduced uhd timeout
7 years ago
Andre Puschmann
ddf7d2b2f7
soapy: rework driver init and add option to load config file
7 years ago
Xavier Arteaga
5e4fb48184
Refactored CQI reporting logging in UE. Fixes #199
7 years ago
Francisco Paisana
337857df5f
added a normalization factor
7 years ago
Xavier Arteaga
22c0a67b97
Fixed minor issues
7 years ago
Andre Puschmann
f8fb176ff5
soapy: use log-level error to suppress late warning on console
7 years ago
Andre Puschmann
a68758ab0d
soapy: set RF bandwidth during rate change
7 years ago
Andre Puschmann
937cb4d7a8
rework error handling in Soapy and add statistics
7 years ago
Andre Puschmann
5d2a947aac
soapy: rework rx/tx timing
7 years ago
Andre Puschmann
727d26e75f
init Soapy with LTE rates before creating streams
7 years ago
Andre Puschmann
b8391d20a4
fix tx/rx calibration for Lime
7 years ago
Andre Puschmann
da55c6a71c
expose antenna port selection for soapy through device arguments
7 years ago
Andre Puschmann
1c3017771f
move helper functions for processing args to own header
7 years ago
David Rupprecht
764c3b574e
Add limeSDR mini devname
7 years ago
Andre Puschmann
2605c9066b
improve lime support for srsUE by stopping/starting rx streaming during rate changes
7 years ago
Xavier Arteaga
9406715609
Minor fix on timestammp substraction
7 years ago
Ismael Gomez
94bb1912b7
Fix distributed ngap not printing in dci info
7 years ago
Xavier Arteaga
30eb5c62a6
Merge pull request #211 from softwareradiosystems/pdsch-coworkers
...
Add pdsch coworkers, minifal noise estimation defect and fixed AGC out of bounds
7 years ago
Xavier Arteaga
301415a00a
Fixed AGC out of bounds gain
7 years ago
Xavier Arteaga
2d3e788d19
Fixed minimal DL noise estimation defect
7 years ago
Xavier Arteaga
78912694c5
Fixed PDSCH coworker deadlock
7 years ago
Ismael Gomez
ca9047e555
validate DL type1 sched grant rbg_subset
7 years ago
Xavier Arteaga
d9db80d17c
Merge branch 'next' into pdsch-coworkers
7 years ago
Xavier Arteaga
5b84d9be4b
Fixed DL channel estimator for ports 3&4
7 years ago
Xavier Arteaga
6ab69b1d4c
Added PDSCH coworkers
7 years ago
Ismael Gomez
bd4e1c9690
Fixed number of iterations lower than 1 in metrics
7 years ago
Xavier Arteaga
681b98ae50
Added vector CFO
7 years ago
Xavier Arteaga
63df8d4c19
Fixed PDSCH test with OFDM
7 years ago
Ismael Gomez
08654efd1c
minor changes
7 years ago
Ismael Gomez
3f816813c1
Restored async Late/Underflow monitor thread in USRP. Added option silent to turn it off
7 years ago
Ismael Gomez
be47be381c
uhd: Enable MIMO channel alignment for X300
7 years ago
Xavier Arteaga
1ba18f1ddc
Fix Resource Allocation Type 1 Defect
7 years ago
Andre Puschmann
cb15dee3d4
Merge branch 'embms_merge_final' into next
7 years ago
Ismael Gomez
4662b83fe9
Use bzero instead of {} for initializing structs
7 years ago
Andre Puschmann
61d525ea80
Merge branch 'next' into embms_merge_final
7 years ago
Ismael Gomez
467ba4e326
Average sampling offset estimate before adjusting timing to be more robust against EVA and ETU fading
7 years ago
Ismael Gomez
a87e7b3e43
Protect uhd_tx_streamer_send() by a mutex inside rf driver
7 years ago
Andre Puschmann
9ca2b89282
fixing compile warnings
7 years ago
yagoda
e4c3f0bc30
adding mbms-gw and mch generation tables
7 years ago
yagoda
9d7d6c9415
adding adaptations to the phy layer for mbms
7 years ago
Ismael Gomez
3847daa137
Fixed order of PCI and PRB in log print
7 years ago
Ismael Gomez
443d2b7fa0
Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next
7 years ago
Ismael Gomez
d139a73593
Fix SIGFPE in pdsch_codeword_decode
7 years ago
Xavier Arteaga
36936349fe
PUSCH test cases generator in CMake
7 years ago
Ismael Gomez
3065941638
Check for non-zero nof_re/nof_bits in pdsch_codeword_decode
7 years ago
Tom Tsou
ba3de5d94a
uhd: Add N3xx support
7 years ago
Ismael Gomez
4ffee4326b
Fix memory leaks in unit tests
7 years ago
Xavier Arteaga
28ef713160
AGC does not get stuck in high gain if low signal. AGC is now default.
7 years ago
Ismael Gomez
aa1724b8f3
Add missing-field-initializers flag and properly initialize structs
7 years ago
Joseph Giovatto
ab1d9e98f3
Format and typelimit warnings ( #169 )
...
* merge with origin 4fc7dbc3
8daa8346
* fixed whitespace diff
* added .gitignore
* added format warning flags to C_FLAGS
added typelimit check to C_FLAGS and CXX_CLAGS
* Revert "added format warning flags to C_FLAGS"
Apply to branch format_and_typelimt branch
This reverts commit bf7467e82e
.
* check for format warnings to top level C_FLAGS
added typelimit warnings to top level C_FLAGS and CXX_FLAGS
beset effort attempt to remedy warnings
removed unused param names in hex_log baseclass methods due to multitude of unused-warnings
7 years ago
Joseph Giovatto
9f5069cdc8
Format and typelimit warnings ( #169 )
...
* merge with origin 4fc7dbc3
8daa8346
* fixed whitespace diff
* added .gitignore
* added format warning flags to C_FLAGS
added typelimit check to C_FLAGS and CXX_CLAGS
* Revert "added format warning flags to C_FLAGS"
Apply to branch format_and_typelimt branch
This reverts commit bf7467e82e
.
* check for format warnings to top level C_FLAGS
added typelimit warnings to top level C_FLAGS and CXX_FLAGS
beset effort attempt to remedy warnings
removed unused param names in hex_log baseclass methods due to multitude of unused-warnings
7 years ago
Xavier Arteaga
7146819fcd
Added CSI Predecoding for TM4 with SIMD Support
7 years ago
Xavier Arteaga
bad1291843
Corrected ZF SIMD predecoder
7 years ago
Xavier Arteaga
0bc3be7abb
Added DL CSI decoding to TM2 and TM3
7 years ago
Xavier Arteaga
5ad6ef4d1d
Implemented SSE/MMX int32 bit Interleaver
7 years ago
Ismael Gomez
384e0f8649
Fixed UL interleaver (missing SIMD deinterleaver)
7 years ago
Xavier Arteaga
09e6f164a4
UE synchronizer can miss up to 100 PSS. This reduces PSS lost of synch for slow fading channels such as EVA5.
7 years ago
Xavier Arteaga
15173c5c30
Added gaussian filter configuration options in srsue.conf
7 years ago
Xavier Arteaga
d0d5893a1c
New DL channel noise estimator based on RS
7 years ago
Andre Puschmann
08212a6b13
fix compile warning due to missing async thread
7 years ago
Ismael Gomez
321a750f56
Added features to ringbuffer
7 years ago
Ismael Gomez
f470645e90
Fix for real issue #164
7 years ago
Ismael Gomez
bd258372ea
Fixes #164
7 years ago
Ismael Gomez
c0aea5ae13
Neighbour cell RSRP measurement always and only with correlation method
7 years ago
Ismael Gomez
809c550ca2
Use RS power estimation for serving cell RSRP/SNR measurements. Use correlation of RS sequences for neighbour cell verification of Cell ID
7 years ago
Ismael Gomez
c2098ad626
Removed unused sample offset correction
7 years ago
Andre Puschmann
44b1748a87
fix mem leak in sync
7 years ago
Andre Puschmann
7acc021a4e
fix mem leak in pmch_test
7 years ago
Andre Puschmann
57e0c01fc4
check max buffer length in hex print
7 years ago
Ismael Gomez
3adc6b5cbc
Merge pull request #158 from softwareradiosystems/csi
...
Csi
7 years ago
Andre Puschmann
ac0f934558
fix leaks in viterbi and modem tests
7 years ago
Andre Puschmann
c6933f5338
fix leak in turbocoder test
7 years ago
Andre Puschmann
4c76e98f9e
fix memleak in DL chest object
7 years ago
Andre Puschmann
cae09a8d58
fix mem leak in PMCH
7 years ago
Andre Puschmann
e933f05933
fix memleak in vector test../lib/src/phy/utils/test/vector_test.c
7 years ago
Xavier Arteaga
962164277a
Normalize CSI to maximum.
7 years ago
Francisco Paisana
cd0373c533
opt assignment was being erased by bzero call
7 years ago
Ismael Gomez
fce672954e
Minor edit to SNR-to-CQI table
7 years ago
Ismael Gomez
5f0bd0e74b
Add mutex to libfftw mkplan/destroyplan functions
7 years ago
Ismael Gomez
73602a8558
Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next
7 years ago
Ismael Gomez
90553e830d
Fixed cell search for non-home PLMN
7 years ago
Andre Puschmann
c198547728
add new RF RX error type and make the UHD driver issue that if anything unexpected happens
7 years ago
Andre Puschmann
281611b26a
allow n param in pss_usrp test
7 years ago
Andre Puschmann
57bb831f27
fix RM turbo test
7 years ago
Andre Puschmann
1efcea7e47
call dft_exit in various tests
7 years ago
Andre Puschmann
4a27915022
bzero dft object during init, add call to fftw_cleanup in dft_exit
7 years ago
Andre Puschmann
f60a9eab41
initialize RF UHD handler in init
7 years ago
Ismael Gomez
fd0c8168f0
Set to Continuous RX and TX
7 years ago
Xavier Arteaga
2a69211f32
SCH does not terminate all codeblocks if one fail. Also, SCH does not decode blocks with CRC=OK
7 years ago
yagoda
fafed4a4a0
small fix in mbsfn ofdm
7 years ago
Xavier Arteaga
6fc9c96c58
Added CSI softbits weightening for Single antenna transmission
7 years ago
Ismael Gomez
65aa5abb30
Restored RSRP calculation changed in commit 3f002aca85
7 years ago
Ismael Gomez
5251cb3671
Stop RX stream when cell not found during initial cell search
7 years ago
Xavier Arteaga
2c8467780d
UE stores last PMI and last RI in common phy
7 years ago
Xavier Arteaga
4df6227f5b
UE stores last PMI and last RI in common phy
7 years ago
Ismael Gomez
9b1c8aa608
Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next
7 years ago
Ismael Gomez
3a005af9f5
Normalize PUCCH power
7 years ago
Andre Puschmann
d959608e10
fix mem dealloc in viterbi for 16bit AVX
7 years ago
Xavier Arteaga
a2129601df
Noise level in MIMO is not divided by number of antennas
7 years ago
Xavier Arteaga
898c86d954
Channel estimattor selects the strongest RSRP.
7 years ago
Ismael Gomez
4117119510
Correct a possible sign overflow
7 years ago
Ismael Gomez
70dfa3b2a9
Fixes #6 AGC
7 years ago
Ismael Gomez
c78a6e4c0d
Changed SSS algorithm
7 years ago
Ismael Gomez
ea07f695ad
Removed printf
7 years ago
Ismael Gomez
a568db3b04
Fixed PRACH HS=TRUE bug and indentation
7 years ago
Andre Puschmann
ccfb9314bc
fix various coverity bugs
7 years ago
Ismael Gomez
86818ad65f
Fix compilations warnings and remove printf debugs
7 years ago
Ismael Gomez
b5bda138f3
Merge branch 'next'
7 years ago
Xavier Arteaga
3f002aca85
Corrected energy measurement of the RSRP
7 years ago
Ismael Gomez
c429f3031f
Proper normalization to noise power estimation in chest_dl
7 years ago
Ismael Gomez
ed76d73bbc
Print tpc_pucch for format2 dci also
7 years ago
yagoda
eb8a884e90
small optimization in neon viterbi
7 years ago
Andre Puschmann
8f850754f3
check malloc return value in various tests
7 years ago
Ismael Gomez
f17cfa3ac3
Fixed possible mod netgative SR period calculation
7 years ago
Ismael Gomez
a279ab47f0
Improved neighbour cell accuracy. Changed RRC to avoid segfault when neighbour cell addition
7 years ago
Ismael Gomez
2347fe0e6f
Fixed incorrect DCI location bug. Make all calls to regs/pdcch atomic w.r.t. the CFI
7 years ago
Andre Puschmann
dfe430a584
Merge branch 'next'
7 years ago
Xavier Arteaga
99ef760b6f
More Coverity fixes
7 years ago
Andre Puschmann
eac2b6e43c
Merge branch 'next'
7 years ago
yagoda
42040f7111
fixing conflicts
7 years ago
Andre Puschmann
4fc7dbc340
Merge branch 'next'
7 years ago
yagoda
ee1c8c292e
fixing coverity issues
7 years ago
Xavier Arteaga
10fc1855d6
Fixed Coverity INFO/DEBUG messages with too many arguments and a few more
7 years ago
Andre Puschmann
c011526e38
Merge branch 'next'
7 years ago
Andre Puschmann
d500bdbc24
fix more coverity issues
7 years ago
Andre Puschmann
fa508f07fa
Merge branch 'next'
7 years ago
Andre Puschmann
a7ced05be5
fix coverity issue in soapy
7 years ago
Xavier Arteaga
5741ce4c61
Fixed coverity for vector_test.c
7 years ago
Andre Puschmann
afcdf21dcc
Merge branch 'next'
7 years ago
Andre Puschmann
f49c1d8d65
Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next
7 years ago
Xavier Arteaga
c4247c7aca
Fix coverity for complex 16bit
7 years ago
Andre Puschmann
02856704c8
more coverity fixes
7 years ago
Xavier Arteaga
0299e9aae1
Fixed Aperiodic reporting RM31 for TM4 (Amarisoft proof)
7 years ago
Andre Puschmann
33bae5898a
Merge branch 'next'
7 years ago
Andre Puschmann
8da4373d30
fix various coverity bugs
7 years ago
Andre Puschmann
f2ea8222f9
soapy: make timeout a variable
7 years ago
Andre Puschmann
9be16097bf
lime: add lo_locked sensor read
7 years ago
Andre Puschmann
f3b1fe0f1a
update for null-termination of strings fix
7 years ago
Andre Puschmann
c8f9a7785a
fix null-termination of strings
7 years ago
Xavier Arteaga
c386bee399
Fixed PUSCH aperiodic report bug.
7 years ago
Ismael Gomez
71a2ad8ea8
Catches RA PDCCH order in Format1A
7 years ago
Ismael Gomez
8c7e8057f6
Minor printf corrections
7 years ago
Ismael Gomez
464357d88c
Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next
7 years ago
Ismael Gomez
754566b28f
Changed priorities to below UHD in srsUE
7 years ago
Xavier Arteaga
8800b77ded
Enable DCI format 1C (Compact DCI por pagin and SIB) to be decoded by pdsch_ue example
7 years ago
Ismael Gomez
8418c74a2d
Fixes RLC small grant issue in eNodeB and non-adaptive retx
7 years ago
Xavier Arteaga
d950aa925d
Removed SFO compensation in frequency domain.
7 years ago
Andre Puschmann
04dd4ba01b
uhd: add e300 default config and fix loop for rx'ing samples
7 years ago
Xavier Arteaga
a4c0cda237
Fixed pdsch_ue Rank indicator error messages for 4 antenna port cells
7 years ago
Ismael Gomez
0093928b73
Fixed some warnings in ARM
7 years ago
Ismael Gomez
62c9910b28
Increased timeout for LimeSDR
7 years ago
Ismael Gomez
76969932dc
Merge pull request #134 from softwareradiosystems/enbmimo
...
Enbmimo
7 years ago
Ismael Gomez
26017a8f98
Fixed double const warning
7 years ago
Ismael Gomez
0750ff3091
Option to not wrap when reading signal from file
7 years ago
Ismael Gomez
d2e1600053
Updated viterbi 16-bit scaling
7 years ago
Ismael Gomez
d88ed887d7
Revert "Take 1st block of iteration instead of 2nd in viterbi"
...
This reverts commit b12f500207
.
7 years ago
Xavier Arteaga
57d443ace2
Merge branch 'next' into enbmimo
7 years ago
Ismael Gomez
b12f500207
Take 1st block of iteration instead of 2nd in viterbi
7 years ago
Xavier Arteaga
9ffdb1e62d
Refactored PMI/CQI/RI reporting
7 years ago
yagoda
2375b152af
small fix for viterbi test without AVX2
7 years ago
Ismael Gomez
c521739b51
Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next
7 years ago
Xavier Arteaga
de654cd344
Merge branch 'next' into enbmimo
7 years ago
Xavier Arteaga
7a840d9f59
Solved RI reporting bug and improved PUSCH log trace
7 years ago
Ismael Gomez
e16839d7a7
Merge branch 'next' into 16bit_avx_viterbi
7 years ago
Xavier Arteaga
1db3f8ffcc
Fixed SSE interleaver SEGFAULT potential
7 years ago
Xavier Arteaga
2f08a13504
Fixed channel estimator noise estimation
7 years ago
Xavier Arteaga
9aea121528
Removed redundant bzero in chest_dl.c
7 years ago
yagoda
d749ee66f4
introducing 16 bit viterbi support
7 years ago
Xavier Arteaga
6b04152c18
Fixed channel estimator for fidx_offset > 3
7 years ago
Xavier Arteaga
a01c5ea08f
Fixes #119 : channel estimation subframe averaging
7 years ago
Ismael Gomez
1fb2262130
Revert "Increased viterbi quantification to maximum"
...
This reverts commit 5c7ce5a799
.
7 years ago
Ismael Gomez
e4696fec38
Added ue location calculation for a particular L
7 years ago
Ismael Gomez
5c7ce5a799
Increased viterbi quantification to maximum
7 years ago
Ismael Gomez
0689e69aad
Minor DCI str info edits
7 years ago
Ismael Gomez
ba807f1ef3
DLSCH error when CRC=0x0
7 years ago
Ismael Gomez
ba8a42b92a
Set master clock rate by default for usrp unless x300 is defined
7 years ago
Ismael Gomez
bbc5fad1cf
Possible fix to RSSI bug by scoping rssi_sensor variable to local function
7 years ago
Ismael Gomez
03da3dadce
Minor edits in dci info string
7 years ago
Ismael Gomez
a08c662028
Per-antenna SNR
7 years ago
Ismael Gomez
143bec18e3
fixed compilation
7 years ago
Ismael Gomez
a799098784
Merge branch 'next' into merge_patch
7 years ago
Ismael Gomez
c6ab02f3f4
Minor changes to logging
7 years ago
yagoda
318afbd8b4
minor fixes to phy logging
7 years ago
yagoda
23afd44a7d
modifications to enable phy lib logging
7 years ago
Ismael Gomez
33c35d575d
Save last PHICH correlation
7 years ago
Ismael Gomez
821d5595c5
Fixed AVX compilation
7 years ago
Ismael Gomez
ba7d4ca3a4
Added API to access port/ant chest values
7 years ago
Ismael Gomez
dfda8edc04
Minor changes to log
7 years ago
Ismael Gomez
37ee5505e9
Removed unused log_line() functions. Added DCI info string
7 years ago
yagoda
1b1301101c
adding support for phy(C level) logging to file
7 years ago
Andre Puschmann
68537b76d6
fix compilation issue on ARM
7 years ago
Ismael Gomez
6711387ad7
Disabled AGC for initial cell search. Copy CFO from search and disable CP based CFO after search to reduce overhead
7 years ago
Ismael Gomez
88e19ca19d
Start AGC from half maximum gain
7 years ago
Ismael Gomez
64ed986a11
Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next
7 years ago
Ismael Gomez
9355cd5732
Improved CFO loop. Fixed issue with sinusoid tolerance
7 years ago
Ismael Gomez
56f95ec8be
Avoid changing master clock rate if it's the same
7 years ago
Xavier Arteaga
ec254a9971
Merge branch 'next' of https://github.com/softwareradiosystems/srsLTE into enbmimo
7 years ago
Ismael Gomez
e96f1cb37c
Merge pull request #127 from softwareradiosystems/merge_patch
...
Merge patch
7 years ago
yagoda
a99d6318db
fixing viterbi testing bug
7 years ago
Xavier Arteaga
abbbae9e81
rf_uhd_imp tx forces zeros if null pointer buffer
7 years ago
Ismael Gomez
60b81f47f1
Do chest on filter only when sic_pss is enabled. Do not equalize SSS by default (something is not ok and takes more time to decode it)
7 years ago
Ismael Gomez
39f9f15232
Fixed bug with 2 rx antennas
7 years ago
Ismael Gomez
be7f247ad7
Merge branch 'master' into next
7 years ago
Ismael Gomez
142ee30029
Merge branch 'next_novolk' into next
7 years ago
Ismael Gomez
082da2f7b6
Added filter for maximum PSS CFO detection value. Increased averaging for PSS CFO estimation
7 years ago
Xavier Arteaga
4fec7799e2
Fixed Aperiodic RI reporting for TM1-2
7 years ago
Xavier Arteaga
f71240d845
Merge branch 'next' into enbmimo
7 years ago
Ismael Gomez
b0a2fa3b0b
Merge branch 'enbmimo' into mob_crypto_mimo
7 years ago
Ismael Gomez
e720568e82
Revert "Added UE Mode 3-1 aperiodic reporting"
...
This reverts commit 0bd683b3c4
.
7 years ago
Ismael Gomez
eefbdbc913
Revert "Added Aperiodic mode 3-1 in enb and some more optimizations"
...
This reverts commit 8ab196901f
.
7 years ago
Xavier Arteaga
8ab196901f
Added Aperiodic mode 3-1 in enb and some more optimizations
7 years ago
Xavier Arteaga
0bd683b3c4
Added UE Mode 3-1 aperiodic reporting
7 years ago
Xavier Arteaga
a2a7411509
Solved bug: Added TPC pack for DCI format 2A
7 years ago
Ismael Gomez
48dfc08fa3
Fixed SIC for PSS using channel estimates, added option to disable it (not usable on synchronous same-site cells). Use PSS CE in SSS decoding
7 years ago
Ismael Gomez
8f39a622fe
Added cancelation of self interference of PSS and SSS signals
7 years ago
Ismael Gomez
6b264732d2
Disabled subframe average
7 years ago
Ismael Gomez
f1c6bcd252
Merge branch 'next' into mobility
7 years ago
Ismael Gomez
dd8bacf466
Calibrated CFO loop default values
7 years ago
Ismael Gomez
46f15c19e6
Added subframe averaging option in chest_dl. Optional in pdsch_ue
7 years ago
Ismael Gomez
6e0c24c7ee
Fixed feedback loop in CFO correction
7 years ago
Ismael Gomez
a3a1d268b7
Improved CFO estimation/correction by filtering central 6 PRB. Cleaned ue_sync/sync/pss objects. Used const attr in vector and other objects
7 years ago
Ismael Gomez
2772471e41
Added filtering function to PSS
7 years ago
Ismael Gomez
2fd2f15157
Cell RS based CFO estimation
7 years ago
Ismael Gomez
15a1304395
Revert "Add noise reduction in PSS before estimating CFO"
...
This reverts commit 0d7af88822
.
7 years ago
Ismael Gomez
0d7af88822
Add noise reduction in PSS before estimating CFO
7 years ago
Xavier Arteaga
854a77455d
Merge pull request #113 from softwareradiosystems/next_new_features
...
adding simd xor functionality
7 years ago
Ismael Gomez
aacd9e1e5b
Revert "Use CP-based CFO estimation only for DL and UL. Estimate every subframe. Calibrated EMA to 0.3 highest valid for low SNR"
...
This reverts commit 6196c096af
.
7 years ago
Ismael Gomez
3a0ab02264
S1/X2 handover tested and working
7 years ago
yagoda
38903de07c
adding simd xor functionality
7 years ago
Ismael Gomez
cfbea7a6c1
Restored non-guru DFT interface. Removed input buffer from ue_dl interface
7 years ago
Ismael Gomez
b9854b65da
Merge branch 'next' into mobility
7 years ago
Ismael Gomez
e035e248b8
Fix bug in sync when not correcting CFO
7 years ago
Ismael Gomez
8447c965e3
Fixing RSRP measurements
7 years ago
Ismael Gomez
d428760b20
Merge branch 'next' into mobility
7 years ago
Ismael Gomez
408545dab8
X2 (constant NCC) working
7 years ago
Ismael Gomez
053f5a619d
Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next
7 years ago
Ismael Gomez
8b6bd607a7
Fixed and tested AGC
7 years ago
Ismael Gomez
6196c096af
Use CP-based CFO estimation only for DL and UL. Estimate every subframe. Calibrated EMA to 0.3 highest valid for low SNR
7 years ago
Xavier Arteaga
f377b12f91
Merge branch 'next' of https://github.com/softwareradiosystems/srsLTE into enbmimo
7 years ago
Xavier Arteaga
dbf10cff17
Solved PDSCH Power Allocation p_b on eNB side
7 years ago
Xavier Arteaga
176dae270c
Fixes #105 . Added backtrace print in 'srsLTE.backtrace.crash'
7 years ago
Xavier Arteaga
91e706d4d1
Fixes #107 : srslte_simd_f_sqrt NaN solved if input is 0
7 years ago
Ismael Gomez
0093497752
Merge pull request #106 from softwareradiosystems/power
...
Power
7 years ago
Xavier Arteaga
401cc9a20a
Merge branch 'power' of https://github.com/softwareradiosystems/srsLTE into enbmimo
7 years ago
Xavier Arteaga
58aac96a6e
Added Power Allocation from HL in UE side
7 years ago
Xavier Arteaga
4ecd73c984
Added power allocation p_a in UE
7 years ago
Xavier Arteaga
91c9ddf244
Added scaling factor to predecoder
7 years ago
Ismael Gomez
12d8b373c7
srsUE takes and reports intra-frequency measurements correctly
7 years ago
Xavier Arteaga
721d15a8bb
Solved PUSCH RI reporting bug
7 years ago
Xavier Arteaga
af5ca314d0
Merge branch 'next' of https://github.com/softwareradiosystems/srsLTE into enbmimo
7 years ago
Xavier Arteaga
e2a61af462
Added Aperiodic mode 3-1 in enb and some more optimizations
7 years ago
Ismael Gomez
e04a221911
Removed volk occurrences. Fixes #103
7 years ago
Xavier Arteaga
ab3a3108f1
Merge branch 'next' of https://github.com/softwareradiosystems/srsLTE into next
7 years ago
Xavier Arteaga
b7d678f05e
Solved bug when parsing two times the same subdev_spec
7 years ago
Ismael Gomez
809f211320
Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next
7 years ago
Xavier Arteaga
d041431c13
Merge branch 'reporting' into enbmimo
7 years ago
Xavier Arteaga
b084b153cf
Added UE Mode 3-1 aperiodic reporting
7 years ago
Ismael Gomez
058fbd7112
Fix adaptive retx in UE
7 years ago
Xavier Arteaga
861d65b070
Added subdev RF arguments. It fixes #95
7 years ago
Xavier Arteaga
ca07f0064d
Remove otw_format=sc12/sc16 from device args, also commas.
7 years ago
Ismael Gomez
344ace8f52
Fix issue #120
7 years ago
Xavier Arteaga
c2d8508dcb
Merge branch 'next' into enbmimo
7 years ago
Ismael Gomez
84db678608
Fixed Format1C RV with P-RNTI
7 years ago
Xavier Arteaga
9fbcf95367
Merge branch 'next' of https://github.com/softwareradiosystems/srsLTE into enbmimo
7 years ago
Xavier Arteaga
2b0a4fa2d0
eNB: solved sched-pdsch bug
7 years ago
Paul Sutton
646f949d77
Fix for debug inline issue
7 years ago
Xavier Arteaga
75957d41d7
Added DCI formats 2 and 2a inScheduler. Improved UE PHCH, corrected some MIMO bugs on both sides.
7 years ago
yagoda
cd6ca95cd1
lime additions and resampler optimizations ( #94 )
...
* adding optimizations to fractional resampler
* adding txrx delay for N210 and Lime
* minor corrections to Lime api
* optimization of the fractional resampler
7 years ago
Ismael Gomez
641eceb328
Merge branch 'next' into mobility
7 years ago
Paul Sutton
54b56ded4a
Merge branch 'master' into next
7 years ago
Paul Sutton
935afe6ef3
Minor soapy fix
7 years ago
Ismael Gomez
bb2bc95247
Fix diversity tx not working for 4 ports
7 years ago
Ismael Gomez
3a054a22b9
Remove OFDM normalization from enb_dl_init and do it before transmission
7 years ago
Xavier Arteaga
98969b2011
Implemented 3GPP 36.212 Tables 5.3.3.1.5-1 and 5.3.3.1.5-2
7 years ago
Ismael Gomez
81b34afff9
Normalize srsENB OFDM tx signal (srsENB not working PDSCH before this commit until ofdm changes commit)
7 years ago
Xavier Arteaga
f9e428ef68
Optimised RI/PMI calculation call
7 years ago
Ismael Gomez
de937faa20
Set invalid inputs error to dlsch_decode
7 years ago
Ismael Gomez
be0b832927
Implement CW swap and TB to CW mapping for TM4
7 years ago
Ismael Gomez
1d095b006a
Removed unused nof_tb variable
7 years ago
Ismael Gomez
abbd2e0f85
return error on precoding error
7 years ago
Xavier Arteaga
96a6d6ae9f
Merge branch 'next' into enbmimo
7 years ago
Xavier Arteaga
6985682ef0
Added 2nd Codeword interface in scheduler, plus pmi close loop reporting
7 years ago
Xavier Arteaga
af669a6cbb
Added RI reporting in enb and optimised RI computing calling time
7 years ago
Xavier Arteaga
15e75b2c65
Created Bit interleaver object and SSE optimised interleaver
7 years ago
Ismael Gomez
610e892036
Merge branch 'next_novolk' of github.com:softwareradiosystems/srsLTE into next_novolk
7 years ago
Ismael Gomez
85571c47cd
Added option to ue.conf to configure CFO EMA (set default to 0.4)
7 years ago
Xavier Arteaga
a400999927
Merge branch 'next_novolk' of https://github.com/softwareradiosystems/srsLTE into next_novolk
7 years ago
Xavier Arteaga
c1b296eb2c
SSE optimization for srslte_bit_interleave_w_offset
7 years ago
Ismael Gomez
b0157cb4f8
Removed error when can't save fft wisdom (prints in mkl)
7 years ago
Ismael Gomez
7bef0b0e7f
Merge branch 'next' into next_novolk
7 years ago
Xavier Arteaga
c8bba2f4d0
DFT optimization. memcpy removal ( #76 )
...
* Solved PHICH Segmentation fault for MIMO
* Initial Guru FFT optimitzation
* Guru (i)FFT implemented. All test passed!
* Integrated new DFT into pdsch_enodeb and pdsch_ue. Solved more DFT bugs.
* Solved Merge Errors and bugs
* Solved UL Guru bug (DC missing). Updated Init and OFDM calls for enb and ue (cell measurement too).
7 years ago
Xavier Arteaga
a570e63c5b
Corrected bug in RA
7 years ago
Xavier Arteaga
02680ed2aa
Merge pull request #75 from softwareradiosystems/next_novolk_update
...
Next novolk update
7 years ago
Ismael Gomez
2f44e2bf3a
Refactored cases mcs>29 for ul/dl
7 years ago
yagoda
3292f9c269
simd.h tidy up & small fix for eMBMS
7 years ago
Ismael Gomez
ed7856ea57
Merge branch 'next' into next_novolk
7 years ago
Andre Puschmann
ab11a80c6f
fix bug in tti interval calculation now returning 0 when called with the same value
7 years ago
Xavier Arteaga
0504e7a51b
Fixed test for abs value. Solved compilation Neon warnings and SSE errors
7 years ago
yagoda
f4b9e7311a
adding neon support to new vector structure
7 years ago
Xavier Arteaga
6657892b80
Added UCI CQI decoder for variable number of bits
7 years ago
Ismael Gomez
c4c1c62360
stable connection. Runs out of samples in ringbuffer if clock differences
7 years ago
Ismael Gomez
db87a41d80
Merge branch 'next_novolk' into mobility
7 years ago
Ismael Gomez
d3e3ecacb6
Merge branch 'next' into next_novolk
7 years ago
Ismael Gomez
5509262f54
Fixed possible bug in rx_metadata
7 years ago
Ismael Gomez
aeabcb4551
Merge branch 'next' into next_novolk
7 years ago
Ismael Gomez
db5d747c66
Fix coverty issues
7 years ago
Xavier Arteaga
95897ceb71
Added TM2 (Tx diversity) support for eNB
7 years ago
Ismael Gomez
f4e883d24f
Divided phch_recv in subclasses
7 years ago
Xavier Arteaga
e8da7160f0
eNB transmits diversity by default if two cell ports are configured
7 years ago
Ismael Gomez
1dff82065b
Merge branch 'next' into next_novolk
7 years ago
Andre Puschmann
8dc8d8d521
fix warning
7 years ago
Andre Puschmann
5d5e8167b7
stop radio after radio error
7 years ago
Andre Puschmann
f619f53cc4
fix soapy support
7 years ago
Andre Puschmann
5bd92fb658
fix prach example and close rf at exit
7 years ago
Andre Puschmann
df2bbd4087
fix multi channel tx support in soapy
7 years ago
Andre Puschmann
81b143715b
fix formating
7 years ago
Ismael Gomez
ea935165af
Merge branch 'next' into next_novolk
7 years ago
yagoda
983bd0060c
fixing incorrect type in bzero in pmch test
7 years ago
yagoda
c1ef157afd
adding test files for pmch
7 years ago
yagoda
b1cbcec742
adding pmch tests and fixing pdsch_enb
7 years ago
Ismael Gomez
dbae016b00
Removed unused vector functions
7 years ago
Ismael Gomez
4375113efc
Merge branch 'next' into next_novolk
7 years ago
Xavier Arteaga
94a06867a3
Optimized SIMD includes and solved AVX512 bugs
7 years ago
Xavier Arteaga
9e5f999666
Added more functions
7 years ago
Ismael Gomez
fbae23b2ac
Removed debugging printf
7 years ago
Ismael Gomez
db17c67194
Fixed bug in SSE turbo decoder
7 years ago
Ismael Gomez
736b73bb4b
Print PDSCH iterations per codeword
7 years ago
Ismael Gomez
680ba2761c
Fixed number of iterations calculation
7 years ago
Ismael Gomez
f15dbcdd7f
Restored UCI ACK processing to single ACK
7 years ago
Xavier Arteaga
c41ad5453c
Solved bugs and compilation error in simd and vector_simd
7 years ago
Justin Tallon
774a456e31
adding phy layer support for mbms
7 years ago
Xavier Arteaga
0c52c5651d
Merge branch 'next_novolk' of https://github.com/softwareradiosystems/srsLTE into next_novolk
7 years ago
Xavier Arteaga
c9f6bfccd4
Refactored vector library with SIMD independent architecture inline functions test-benchmark
7 years ago
Xavier Arteaga
8078238cb5
Removed test macros from mat.h
7 years ago
Ismael Gomez
b12d69b439
Set default TX mode to continuous and fixed uplink synchronization (radio set offset concurrent access)
7 years ago
Ismael Gomez
05306d6a05
Merge branch 'segfault_mimo' into next
7 years ago
Xavier Arteaga
55446fc2a2
Over the wire format can be selected through RF args
7 years ago
Ismael Gomez
931cfa2db9
Add source of Late message
7 years ago
Ismael Gomez
db4045f214
Do not exit on UHD recv error code
7 years ago
Xavier Arteaga
648f7c3591
Increased compatibility for TM3 and TM4 with one Rx antenna
7 years ago
Xavier Arteaga
c0fac73a84
Solved PHICH Segmentation fault for MIMO
7 years ago
Xavier Arteaga
336a6b6217
Increased compatibility for TM3 and TM4 with one Rx antenna
7 years ago
Xavier Arteaga
f58f74b102
Solved PHICH Segmentation fault for MIMO
7 years ago
Ismael Gomez
0844274147
Removed UHD decimation warnings for 2 antennas
7 years ago
Xavier Arteaga
54974c5d64
Fixed over the wire bits to 12 (MIMO only)
7 years ago
Xavier Arteaga
c29af35158
Solved bug: when a retransmission of a succesfully decoded block was received
7 years ago
Ismael Gomez
826667361e
Reduced chances of uhd demuxer error. Reset device when it occurs
7 years ago
Ismael Gomez
e1005bc019
Merge pull request #19 from softwareradiosystems/next_mimo
...
Solved mat.h include in precoding.c
7 years ago
Xavier Arteaga
a22d9aaaa3
Solved mat.h include in precoding.c
7 years ago
Ismael Gomez
d624199e70
Merge branch 'next' into next_novolk
7 years ago
Ismael Gomez
313e12e3e9
restored CQI table
7 years ago
Ismael Gomez
bf79d463d4
Merge branch 'next' into next_novolk
7 years ago
Ismael Gomez
05da1ac480
Merge branch 'mobility' of github.com:softwareradiosystems/srsLTE into mobility
7 years ago
Xavier Arteaga
afd2bbbfc2
Added periodic RI on PUCCH for TM3 and TM4
7 years ago
Xavier Arteaga
65f5987ea8
Added RI reporting for TM3 and TM4 (no PMI)
7 years ago
Xavier Arteaga
8fd8175320
Improved ACK and RI in PUSCH decoding
7 years ago
Xavier Arteaga
d9b6ae7563
PUSCH supports 2 ACK
7 years ago
Xavier Arteaga
91fe032276
Added PUSCH ACK decoder and test
7 years ago
Xavier Arteaga
709787b581
Improved robustness of PDSCH decoder
7 years ago
Xavier Arteaga
230eb63a97
Refactored grant: removed nof_tb from grant. Use tb_en instead.
7 years ago
Ismael Gomez
d9ddef9209
Merge branch 'next' into next_novolk
7 years ago
Ismael Gomez
3e712d6a57
Merge branch 'next_mimo' into next
7 years ago
Ismael Gomez
7aa33c1f27
Merge branch 'next' into next_novolk
7 years ago
Ismael Gomez
a4ab30a0c5
Use empirical SNR-to-CQI mapping table
7 years ago
Ismael Gomez
9a2c8d9b89
fixed error in decreased performance due to oscilating CFO
7 years ago
Ismael Gomez
41188b409e
cleaned up cfo set tolerance functions
7 years ago
Xavier Arteaga
0c31a5cfc1
Added periodic RI on PUCCH for TM3 and TM4
7 years ago
Xavier Arteaga
52bdd9290d
Added RI reporting for TM3 and TM4 (no PMI)
7 years ago
Xavier Arteaga
9e4528007c
Improved ACK and RI in PUSCH decoding
7 years ago
Xavier Arteaga
c04eadaa6b
PUSCH supports 2 ACK
7 years ago
Xavier Arteaga
6a668ef27f
Added PUSCH ACK decoder and test
7 years ago
Ismael Gomez
f0d9b333b2
Improved stability when UE reattaches
7 years ago
Ismael Gomez
394d8f166a
Improved initial CFO estimation for PRACH. Fixed bug in PDCCH after changing cell
7 years ago
Ismael Gomez
f1bacd009a
Reduced time to sync to cell
7 years ago
Ismael Gomez
31cdd734ee
remove get functions from set in uhd
7 years ago
Xavier Arteaga
1ab106c127
Improved robustness of PDSCH decoder
7 years ago
Ismael Gomez
14a901c807
compute sequences using static memory
7 years ago
Ismael Gomez
b59e4d08ca
fixed incorrect initialization of PUSCH estimator
7 years ago
Ismael Gomez
22f194182c
fixed memory leaks
7 years ago
Ismael Gomez
91a8a29100
fixed memory issues
7 years ago
Ismael Gomez
b0639ab394
resolved merge conflicts
7 years ago
Xavier Arteaga
2296d736be
Merge branch 'next_mimo' of https://github.com/softwareradiosystems/srsLTE into next_mimo
7 years ago
Ismael Gomez
30c6c8d21b
fixed offset length in pdsch scrambling sequence
7 years ago
Ismael Gomez
a9d03ebb42
fixed offset length in pdsch scrambling sequence
7 years ago
Xavier Arteaga
338be7d0c2
Refactored grant: removed nof_tb from grant. Use tb_en instead.
7 years ago
Ismael Gomez
283cb115ac
fixed bugs in enb
7 years ago
Ismael Gomez
79b0ca81d0
Fix memory alignment in PUCCH processing. Fixes #94
7 years ago
Ismael Gomez
5341d79b8a
Fix memory alignment in PUCCH processing. Fixes #94
7 years ago
Ismael Gomez
9dffa10550
fixed compiling issues
7 years ago
Ismael Gomez
29ca3705a7
Merge pull request #17 from softwareradiosystems/next_mimo
...
Next mimo
7 years ago
Xavier Arteaga
1486911e32
DCI blind search takes Transmission mode in consideration and some _multi functions removed
7 years ago
Ismael Gomez
9ae21dfd5d
reattaching cells with different IDs and PRB
7 years ago
Ismael Gomez
a993e72534
correction to previous commit
7 years ago
Ismael Gomez
38c67dc410
Moved FFTW to WISDOM and save/load from file
7 years ago
Ismael Gomez
6e0fd43c1f
Moved FFTW to WISDOM and save/load from file
7 years ago
Ismael Gomez
a51b6b09dd
Merged with next. Attach successful
7 years ago