Andre Puschmann
9c4146442a
mac,phy: refactor NR MAC/PHY UL data passing interface
...
inspired by accepted (but not yet merged) PR to include the
(unique_)byte_buffer_t for MAC/PHY interfacing, this patch adds
a few more useful bits to that. Buffer management for UL data is now
done in MAC and only a pointer to the data is passed in the UL action.
* Move Tx softbuffer to MAC (until UL HARQ class is ready)
* Remove temparal data member in cc_worker
* Remove memcpy after packing MAC PDU
4 years ago
David Rupprecht
fc9d5befda
Remove header test case
4 years ago
Andre Puschmann
5e93a6f5bd
rlc_um_nr_pdu_test: add 12bit SN unpack test
4 years ago
Andre Puschmann
06e7f169c6
rlc_um_nr: fix unpacking of 12bit UM PDU
4 years ago
Pedro Alvarez
976b5c12c1
Releasing the UE when max retransmissions are reached in the RLC. ( #2385 )
4 years ago
Francisco
138685399e
remove allocations from rlc_am_tx::handle_control_pdu
4 years ago
David Rupprecht
cc0c091a39
pcap checksum to null for decoding if checksum check is enabled
4 years ago
Xavier Arteaga
6ba9f8fd41
SRSUE: Remove UL hard-coded phase and more PUSCH logging info
4 years ago
David Rupprecht
1fcd006a7c
fixed segfaulting
4 years ago
Xavier Arteaga
b768002a93
SRSUE Added RAR unpacking and other fixes
4 years ago
David Rupprecht
82a8dcc77a
Change interface to unique_byte_buffer
...
logging message for msg3 preparing
4 years ago
Xavier Arteaga
760ad3a746
SRSUE: Interface stack and PHY for NR-RA procedure
4 years ago
Francisco
9a6512f4e8
fix RLC AM undelivered PDCN SNs reset bug
4 years ago
Francisco
1ede82bb30
use circular array for buffered PDCP SNs in RLC AM to limit memory allocations
4 years ago
Francisco
2a65bf9636
fix undelivered PDCP SNs buffers in RLC AM to handle SN=-1 case
4 years ago
Francisco
bad2302e31
avoid the use of two arrays for managing buffered pdcp sns in RLC AM
4 years ago
Francisco
299634b319
use of vector to store undelivered PDCP SNs in RLC AM
4 years ago
David Rupprecht
0f1586dd2d
Deleted all HAVE_5GNR in CC and h files
...
CMakeList and travis yaml
4 years ago
Xavier Arteaga
c2c05d1e8f
Initialise to zeros NR PHY configuration by default
4 years ago
Pedro Alvarez
d8f3878ce1
RLC failure to deliver notifications and discard timer limits to 1500ms ( #2368 )
...
* Added interfaces for the RLC to notify the PDCP of failure to transmit
SDU
* Limit discard timer to 1500ms, to avoid issues of lingering SDUs in the undeliverd_sdus_queue.
* Fix bug in early exit of notify_delivery and notify_failure
* fix compilation issue in rlc-pdcp notification
Co-authored-by: Francisco <francisco.paisana@softwareradiosystems.com>
4 years ago
Francisco
2f75abcc7a
fix failing rlc am test
4 years ago
Francisco
1d185fb152
use macro for rlc tx window size. refactor tx window clearing
4 years ago
Francisco
abe4f4c7eb
use tx_window to store the map of rlc sn to pdcp sns
4 years ago
Francisco
f86eb84876
conversion of RLC AM tx window from std::map to array
4 years ago
Francisco
1660fc81a0
fix comment regarding PDCP SN value for status report
4 years ago
Francisco
047dd2a56d
use function helper for discard timer lookup and stopping in the PDCP
4 years ago
Francisco
c6fa011eec
fix pdcp discard timer list creation
4 years ago
Francisco
82bb0a7d81
implementation of pdcp discard timers using a vector for efficiency
4 years ago
Andre Puschmann
40d7934267
rlc: call PDCP notify without holding Tx lock
...
move notify_info_vec as stack variable and unlock mutex
before calling PDCP notify
4 years ago
Francisco
93b1450e03
fix enb crash during close down of enb and epc
4 years ago
Francisco Paisana
cd8ee37f74
Use a reverse lookup to avoid iteration over a std::map ( #2363 )
...
* reuse vector capacity for pdcp sn notification
* use an extra lookup data structure to find PDCP SNs that an RLC SN contains
* fix rlc sn->pdcp sn lookup datastructure in rlc
* fix rlc failing test
4 years ago
Pedro Alvarez
d947a0bccf
Used the used SN to insert into the discard timer instead of the TX_COUNT
4 years ago
Pedro Alvarez
3f2fe4e5f6
Disable PDCP discard timer when using RLC UM.
4 years ago
Xavier Arteaga
b8b27709b9
Radio: implement resampling buffer protection
4 years ago
Pedro Alvarez
24d5b9071c
Fix issue with status report test config
4 years ago
Pedro Alvarez
6ecd6e273c
Make sure that the status report is sent in RLF and PDCP reestablishment triggered by Handover
4 years ago
Pedro Alvarez
6a6bffcf5c
Changed log of discarding SN due limit to info level
4 years ago
Pedro Alvarez
c66c96aac7
Simplify if condition in checking the maximum allocated SNs in PDCP
4 years ago
Pedro Alvarez
33808a5cb8
Making sure that SNs don't wrap-around in PDCP with RLC AM.
4 years ago
Ismael Gomez
543e84d873
Fix compilation error in PPC
4 years ago
faluco
613d397d0a
- Dump the PDCP metrics into the JSON file.
...
- Fix the PDCP metrics getting reset periodically which invalidated the byte counters.
4 years ago
faluco
a940e169a3
Add the enb_cc_idx value to S1 events.
4 years ago
faluco
b750647cd8
- Remove the cause field in the rrc disconnect event.
...
- Add the sib9 enb home name field to the sectors events, but leave the value as a TODO.
4 years ago
faluco
7b9dab3a73
Rename cc_idx variable to enb_cc_idx for specific upper layer events.
4 years ago
faluco
a4605883f0
Implement second revision of the events and metrics document.
4 years ago
Pedro Alvarez
0e828aeb4b
Remove unecessary mutex. PDCP metrics are accessed from the stack thread.
4 years ago
Pedro Alvarez
c39905744c
Fix metrics of TX PDUs and TX_PDU bytes in PDCP
4 years ago
Pedro Alvarez
451c305790
Add mutex to isolate metrics_hub thread from the stack thread when
...
getting the metrics from the PDCP
4 years ago
Pedro Alvarez
0c240a80aa
Fix up PDCP metrics to calculate the buffered bytes when get_metrics is
...
called.
4 years ago
Xavier Arteaga
70a55ebf1e
Fix ZMQ sleep time
4 years ago
Pedro Alvarez
46cd29e0ac
Temporarly disable sending status report and retrasnsmissions on reestablishment in PDCP
4 years ago
Pedro Alvarez
df501d1500
Clear underlivered SDUs info map for SRBs on reestablishment
4 years ago
Pedro Alvarez
d705fa2106
Tentative fix for errors due to status report already present in RLC info queue
4 years ago
Pedro Alvarez
ba5367bc56
Change order which reestablish is called in eNB
...
Make sure that RLC info queue is reset when reestablish happens
4 years ago
David Rupprecht
a7949e69c8
configure and start ra proc
...
Fix crash due to missing init
4 years ago
David Rupprecht
876858b44c
Added mac nr prach common config convert function with test case
4 years ago
David Rupprecht
b19cbdde23
Added test case for testing the decoding of cell group config
4 years ago
David Rupprecht
a3be380e3b
workaround to mitigate the linking error
4 years ago
Andre Puschmann
e0495d1da8
zmq: fix parsing of log_trx_timeout
...
add temp var for this param. the bug cause log_trx_timeout
to have the value of the previously parsed fail_on_disconnect
4 years ago
Pedro Alvarez
cfd94441a5
Added metrics to srsenb PDCP
4 years ago
Pedro Alvarez
8873b7c42f
Added computation for the metrics
4 years ago
Pedro Alvarez
d34aba8065
Added interfaces to get metrics from PDCP entities.
4 years ago
Pedro Alvarez
eb2f5b978f
Starting to add metrics to lib/upper/pdcp.cc
4 years ago
Pedro Alvarez
dd6a292d79
Added structure to hold PDCP metrics
4 years ago
Pedro Alvarez
3eab97340b
Fix issue in getting PDCP discard timer from configs
4 years ago
Xavier Arteaga
bdef411855
SRSUE: Aesthetic changes
4 years ago
Xavier Arteaga
96a47fb93a
Add NR RRC interface types
4 years ago
Xavier Arteaga
784a33583b
SRSUE: Initial NR MAC-PHY interfaces
...
SRSUE Fix compilation
SRSUE: temporary fixes LTE/NR PHY/Stack interface problem
fix
fix
4 years ago
Francisco
6a178693a8
handle rrc configs with pdcp with sn=15 or 18 bits
4 years ago
Francisco
faf2adde90
set last_submitted_pdcp_rx_sn to -1 of the next ul rx sn
4 years ago
Pedro Alvarez
e2d2951b00
Added some extra logging for the PDCP get_buffered_pdus and notification reception.
4 years ago
Pedro Alvarez
963dff34af
Added retransmissions to the UE's PDCP on re-establishment.
4 years ago
Xavier Arteaga
8ac6d7382f
Fix PRACH sequence generation
4 years ago
Xavier Arteaga
2fd618a295
Avoid FFTW re-planning if no DFT change is required
4 years ago
Xavier Arteaga
596c8f52a9
PRACH set config avoids modulo operation
4 years ago
Xavier Arteaga
1e073b8b67
PRACH: avoid general cexp for sequence generation using LUT
4 years ago
Andre Puschmann
c1a1c92e1b
zmq: optionally log rx/tx timout from ZMQ ringbuffers to stderr
...
this patch adds two new config flags to the ZMQ driver that allows to:
* configure the default ZMQ trx timeout in ms
* turn on error logging if the timeout occurs
Use with, e.g.:
device_args = log_trx_timeout=true,trx_timeout_ms=3333
4 years ago
Xavier Arteaga
984c4a4748
Changed license header
4 years ago
Pedro Alvarez
e0542a4651
Fix issue in sending PDCP status PDU from the eNB due to non-existing LCID at the RLC.
4 years ago
Pedro Alvarez
b0fe302f8e
Added interfaces so the upper layers can trigger the PDCP status report. Added ability to the UE to send Status Report aftre reestablishment.
4 years ago
Pedro Alvarez
89a23cec7e
Added statusReportRequired to the PDCP entity config.
4 years ago
David Rupprecht
24123313bf
Added MAC NR RA procedure with a minimal test case
4 years ago
Xavier Arteaga
3d3c80262c
Modified Error messages
4 years ago
Xavier Arteaga
d9805f7ba7
Added AVX512 LDPC
4 years ago
Pedro Alvarez
2ed8dceddf
Use TX_COUNT in RLC AM stress test. Avoids issue with re-using SNs within the test
4 years ago
Xavier Arteaga
2e39e103f8
Minor NR related corrections
4 years ago
Xavier Arteaga
24cfed6489
Fix scrambling sequence for PUCCH format2
4 years ago
Xavier Arteaga
5f70526ac5
Minor NR-PUCCH related fixes
4 years ago
Xavier Arteaga
9faa2d5fcd
SRSUE: Automatic DL-HARQ Reset for every TTI and Generate PUCCH baseband signal
4 years ago
Xavier Arteaga
2d9e964147
Fix RA RNTI grant count
4 years ago
Xavier Arteaga
d807ccc3dd
SRSUE: Initial NR-PUCCH HARQ feedback
4 years ago
Xavier Arteaga
ff5fbbf0a0
Added vector sprint for bit
4 years ago
Xavier Arteaga
818f3ea7c7
Initial NR-PDSCH HARQ-ACK/NACK procedure
4 years ago
Xavier Arteaga
18db846c6c
Remove NR hard-coded phase offsets
4 years ago
Xavier Arteaga
44df2288b9
Corrected typos
4 years ago
Pedro Alvarez
f89b644902
Added function to get control pdu type to the PDCP base class. Shorten logger name in PDCP Status report test.
4 years ago
Pedro Alvarez
90113419c2
Added memset(0) to PDCP status report bitmap before starting to fill it in.
4 years ago
Pedro Alvarez
9bc08af880
- Added ability to the PDCP LTE entity to send PDCP Status report.
...
- Added handling of PDCP status report to the PDCP LTE entity.
- Added test to the generation and handling of PDCP status report.
4 years ago
Francisco Paisana
4152e43bab
fix gtpu packing when extension header is enabled
4 years ago
Francisco Paisana
c40ad81a90
cleanup s1ap methods. remove hard coded erab list in s1ap handover required message.
4 years ago
Francisco Paisana
5e48327eca
fix valgrind memcheck warnings in rlc_am_test
4 years ago
Francisco
dc4283c572
added cmake functions as helpers to set labels in ctests
4 years ago
Francisco
add156c3fe
update phy lib cmake test labels
4 years ago
Francisco
23459dee28
Created enb_{rlc/pdcp/gtpu/phy_interfaces.h files.
4 years ago
Francisco
43e57df00b
breaking enb_interfaces.h into multiple files on a layer basis. Created enb_rrc_interfaces.h, enb_mac_interfaces.h and enb_s1ap_interfaces.h
4 years ago
Pedro Alvarez
dd6d6f731d
Passing SN provided by upper layers to PDCP entity. Using it to calculate TX_COUNT if passed.
4 years ago
Pedro Alvarez
492ea2a5a8
Addressing reviewers comments to #2290 .
...
Removing unecessary \n for logs and changed log of PDCP info queue
capacity to debug to avoid log spam.
Changed log level for unhandled S1AP messages from error to warning
in EPC to avoid failing tests because of error message.
Changed usage of allocate_unique_buffer to make_unique_buffer()
4 years ago
Pedro Alvarez
fcaaf72187
Starting to add discard functionality to PDCP LTE entity.
...
This includes:
- Adding a queue (implemented with std::map) for undelivered PDUs.
This queue uses the SN used for TX as the key.
- Added discard timer that is started upon reception of the SDU. Upon
expiry of the timeout a discard callback removes undelivered PDUs
from the queue.
- Added the mechanisms to the notify_delivery to remove PDUs from the
undelivered queue when the PDU is ACK'ed.
- Added test case for both timer expiry and acknowledgment.
- Fix up the getter for buffered SDUs to return the undelivered SDUs
- Changed default PDCP discard timer, so AM has a discard timer by
default.
4 years ago
faluco
5c8923123a
Misc compilation fixes from the fapi repo.
4 years ago
faluco
57f66febfc
Ported the RLC classes to srslog in the lib dir.
4 years ago
faluco
f424f2e113
- Upgraded PDCP classes in lib to use srslog.
...
- Update tests to new changes.
4 years ago
faluco
6359a2d948
- Upgrade the gtpu class in lib dir to srslog.
...
- Propagate old log elimination through all the dependencies of gtpu.
4 years ago
faluco
62fcf04083
Ported the all radio classes to use srslog.
4 years ago
Francisco
c2dfe615e7
fixed alignment of LIBLTE_BYTE_MSG_STRUCT to reflect the one of byte_buffer. Add bzero in liblte packers
4 years ago
Francisco
4188b5146e
fix uninitialized memory access in gtpu_test and liblte_mme unpacking
4 years ago
faluco
6545df6681
Removed new lines in log macros in all example apps.
4 years ago
Ismael Gomez
77f905dc64
Move TTI to PID mapping to MAC
4 years ago
faluco
9d15a44c73
Port lib/phy to srslog ( #2298 )
...
* - Ported the channel class to srslog.
- Removed all newlines of log messages in lib/phy.
* Remove more newlines that use the C debug macros.
4 years ago
Andre Puschmann
6eed6f622f
mac_nr: update RA related function in MAC/PHY interface
...
* expose interface to trigger PRACH from MAC
* indicate PRACH tx from PHY
* add temporary RAR PDU handling with Msg3 grant indication to PHY
4 years ago
Andre Puschmann
01acf95566
mac_rar_pdu_nr: update public interface to make it easier to access
...
* provide all subPDUs as const vector&
* return UL grant directly
4 years ago
Francisco
6925b40722
remove extra print when buffer pool is depleted
4 years ago
Francisco
798f1e57e6
fix byte buffer double free in EPC
4 years ago
Francisco
d2ddcb0d4e
avoid bzeroing byte buffers at every allocation for better runtime performance
4 years ago
Francisco
3265d940ec
remove byte buffer pool cached member variables as they are unnecessary now.
4 years ago
Francisco
04ab4eefcd
use new make_byte_buffer() helper method to create unique_byte_buffers
4 years ago
Francisco
8a9c326bcb
remove old direct uses of byte_buffer_pool
4 years ago
Francisco
1e2153769e
remove byte buffer pool cleanup method and unnecessary mutexes
4 years ago
Francisco
0c7c317be5
refactor byte_buffer class and move it to separate file
4 years ago
Andre Puschmann
30216fe1fc
mac_pdu_nr_test: add packing test for UL-SCH PDU with CRNTI, PHR and SBSR
4 years ago
Andre Puschmann
e227916819
mac_sch_pdu_nr: add SBSR, PHR and CRNTI packing
4 years ago
Andre Puschmann
6a0f3d0bc5
common_helper: remove newline
4 years ago
Andre Puschmann
4ca43c6804
mac_sch_pdu_nr: add unpacking helpers for CRNTI, SBSR and PHR CEs
...
* unpackers for CEs
* testcase with TV
4 years ago
Xavier Arteaga
a154bef23f
Added incremental phase in NR-PUSCH modulator
4 years ago
Xavier Arteaga
8f57437e6f
Add NR-PUSCH-DMRS amplitude option and procedure
4 years ago
Xavier Arteaga
a19671802e
Added SRSUE NR-PUSCH initial procedures
4 years ago
Xavier Arteaga
19e9c25d1d
Added ZMQ Tx sample offset
4 years ago
Pedro Alvarez
7b25eac47c
Fix race condition in rlc_am_stress test and other fixes related to this
...
test. The race condition was being cause by write_sdu being called
simultanously to read_pdu, which could cause the read_pdu to try to get
the SDU info before it had been written by the write_sdu.
Changes in this commit include:
- Make sure PDCP sn in included in RLC AM stress test.
- Stop handling control PDU when TX is not enabled in RLC AM.
- Fixed issue with length of the PDCP SN in rlc_stress_test.
- Moved the place were sdu info erase was called to avoid double calls to erase
- Tentative fix for race condition in rlc_am_stress test.
- Added function to print information about undelivered_sdu_info_queue
for debugging.
4 years ago
Pedro Alvarez
2b092ddc85
Initialize byte_buffer metadata to avoid unintialized variable warnings.
4 years ago
Pedro Alvarez
261c2b2e03
Removed limit to the undelivered SDUs info queue in RLC AM. Printing a warning if the queue is getting large instead.
4 years ago
Pedro Alvarez
d0ef6ce00b
Fix typos and bad comments in rlc_am_lte.cc and rlc_am_test.cc
...
Added checks for the nack_sn in the status reports of the rlc_am_test.
4 years ago
Pedro Alvarez
24db20bcca
Removed some unused variables after changing method of tracking notifications. Removed rlc_am_notify_pdcp test file. Testing is now in rlc_am_test.cc
4 years ago
Pedro Alvarez
6c071a784c
Changed notification mechanisms to use map of acked SNs instead of acked bytes.
...
This was required due to an issue where bytes were counted twice when a
packet had been lost.
4 years ago
Pedro Alvarez
649d642776
Moved notification tests from rlc_am_notify_pdcp_test.cc to rlc_am_test.cc.
...
This added some tests to resegmentation.
4 years ago
Pedro Alvarez
389cf4d943
Moved updating the notify info to it's own function.
4 years ago
Pedro Alvarez
de669d214a
Fix test header and queue_capacity check in RLC notifications.
...
Also, remove unecessary nullptr initializaion and fixup some newlines.
4 years ago
Pedro Alvarez
de90b4753f
Added the ability of the RLC AM to notify the PDCP of the acknowledged
...
PDCP PDUs. This includes:
- Modifying the byte_buffer_t to include PDCP SN meta-data. This way,
the RLC can keep track of the ack'ed bytes for a specific PDCP PDU.
- Added in the RLC an `undelivered_sdu_info queue`, to keep track of the
amount of ack'ed bytes and the total size of the PDCP PDU,
so the RLC can know when delivery is finished.
- Added an interface between the PDCP and the RLC so that the RLC can
notify the PDCP when it receives an ack from the status PDUs. The RLC
passes to the PDCP a vector of all the ack'ed pdus in a rx'ed status PDU.
- Added some tests to the notify functionality. This includes some tests
where the PDUs are acked imediatly, and one test where the PDU is
retx'ed.
4 years ago
David Rupprecht
3dab82c42f
Added interface that allows to update the lcid in case of a nr reconfiguration
...
nr rrc updates gw lcid if reconf was received
4 years ago
faluco
821925a273
- Upgrade to srslog the loggers in lib/mac.
...
- Adapted users of these classes and tests.
4 years ago
AlaiaL
9c764c299d
- Removed the try/catch. Checking the allocation with std::nothrow
...
- Adjusting the code with the coding style.
4 years ago
Xavier Arteaga
a2d9b436d9
SRSUE: add NR stack to PHY and initial decoded PDU push
4 years ago