3570 Commits (5a4eb5d6cd741e90ba0d0c96e187a442a849131e)

Author SHA1 Message Date
Pedro Alvarez 0ee20d7a0c lib,rlc_am_nr: addressing reviewers comments:
* Tweaked logs
 * Addressed a missing modulus in handling a state variable.
 * made restarting t-PollRetransmission look more like the comment.
3 years ago
Pedro Alvarez 0551244d64 lib,rlc_am_nr: make sure has_data returns true when there are retxs. Make sure t-PollRetransmit is not started if it is set to infinity. 3 years ago
Pedro Alvarez 6ff18272e0 lib,rlc_am_nr: added debug_window function 3 years ago
Pedro Alvarez d2d3c4140a lib,rlc_am_nr: make sure that sdu_under_segmentation is set before calculating the polling bit 3 years ago
Pedro Alvarez ffb0c21903 lib,rlc_am_nr: stop poll retransmission if POLL_SN is ACKed/NACKed 3 years ago
Pedro Alvarez 515f2099be lib,rlc_am_nr: added SN to get pdu poll function. Setting POLL_SN now. 3 years ago
Pedro Alvarez f93d699abc lib,rlc_am_nr: retransmit first un-acked SDU when t-Poll_retransmit
expires
3 years ago
Pedro Alvarez b3edced44a lib,rlc_am_nr: added t_poll_retransmit to tx entity 3 years ago
Robert Falkenberg c0546b8634 lib,rlc_am_nr: increase verbosity on invalid ACK 3 years ago
Robert Falkenberg 4028b26274 lib,rlc_am_nr: add info_state() 3 years ago
Robert Falkenberg d66c76b374 lib,rlc_am_nr: consider size of all pending retx in buffer state 3 years ago
Robert Falkenberg ced6cf6e40 lib,rlc_am_nr: consider SDU under segmentation in buffer state 3 years ago
Robert Falkenberg e0acb7b81c lib,rlc_am_nr: update buffer-state-related unit test 3 years ago
Pedro Alvarez 8a27cdf45a lib,rlc_am_nr: fix incorrectly stopping the t-StatusProhibit 3 years ago
Pedro Alvarez 63877ba209 lib,rlc_am_nr: make sure that tx_buffer_queue size is configurable 3 years ago
Andre Puschmann 8505523928 ue,ue_sync: fix CP setting for find and track objects
move setting of CP for find and track objects further down
after the respective objects have been resized and updated
there frame_len, fft_size, etc. members.

Doing this too early cause a segfault with div by zero
because the values were all zero
3 years ago
Andre Puschmann 319a185eba phy_common_test: fix test when compiled with USE_LTE_RATES 3 years ago
Robert Falkenberg ca37eed664 lib,rlc_am_nr: default initialize member in class definition 3 years ago
Robert Falkenberg a2332d10f2 lib,rlc_am_nr_packing: unit test + bugfix for trimming of status PDUs 3 years ago
Robert Falkenberg 872e55a84e lib,rlc_am_nr_packing: reorder functions by importance 3 years ago
Robert Falkenberg d9d3bfde63 lib,rlc_am_nr: remove redundant function calls. 3 years ago
Robert Falkenberg 48dce0aab0 lib,rlc_am_nr: truncate status PDUs if necessary 3 years ago
Robert Falkenberg 489259dc78 lib,rlc_am_nr: extend status PDU struct with self-contained packed size info
This change refactors the rlc_am_nr_status_pdu_t from a simple
container into a class with integrated counter of the packed size.
As this depends on the SN length, the SN length must be passed
via constructor.
3 years ago
Andre Puschmann 68695078f0 phy_common: add basic test for sample rate for different bandwidths 3 years ago
Francisco 6984159c6f asn1: fix amf-ngap-ue-id unpacking overflow bug 3 years ago
Robert Falkenberg fc38d4f4d9 lib,rlc_am_nr: consider offset when packing retx with segmentation 3 years ago
Robert Falkenberg 69231f000f lib,rlc_am_nr: don't enqueue segment retx if already pending for retx. 3 years ago
Robert Falkenberg 62558d94da lib,rlc_am_nr: fix segmented retx of non-contiguous segments 3 years ago
Pedro Alvarez 386b1640a9 gnb,bearer_mapper: hack to keep 5QI information in bearer mapper 3 years ago
Pedro Alvarez 47caa60b45 lib,rlc_am_nr: fix up comment 3 years ago
Pedro Alvarez 2f1cf8ee11 lib,rlc_am_nr: make max retx configurable in AM stress test 3 years ago
Pedro Alvarez 4e2f7cf029 lib,rlc_am_nr: make sure that we RETX the segments if we get a NACK for an SDU that was already segmented 3 years ago
Pedro Alvarez 865dfe87e7 lib,rlc_am_nr: Added assert to check SO_start <= SO_end 3 years ago
Pedro Alvarez 7f7656e200 lib,rlc_am_nr: fix missing modulus 3 years ago
Pedro Alvarez b70e6284e6 lib,rlc_am_nr: added logging info to to handling NACKs 3 years ago
Pedro Alvarez 330513ae57 lib,rlc_am_nr: updating segment info when segmenting RETX 3 years ago
Pedro Alvarez 9d0bbc45b3 lib,rlc_am_nr: added debug window function 3 years ago
Pedro Alvarez 1aa13cee9e lib,rlc_am_nr: cleanup logging of configuration 3 years ago
Robert Falkenberg 1180d0f24d lib,rlc_am_nr: properly remove all fully received SDUs from rx window 3 years ago
Pedro Alvarez 9ecf66f313 lib,rlc_am_nr: make sure that handle control PDU correctly locks the mutex 3 years ago
Robert Falkenberg dd7bd351b3 lib,rlc_am_nr: fix pack/unpack of NACKs in status PDUs 3 years ago
Robert Falkenberg aabd22f493 lib,rlc_am_nr: cosmetic change in assert rx_highest_status 3 years ago
Robert Falkenberg 77ae5182a6 lib,rlc_am_nr: stop/restart reassembly timer for segmented SDUs with gaps 3 years ago
Robert Falkenberg d8cb4ec700 lib,rlc_am_nr: detect gaps in sequence of received SDU segments
This is required for checks such as
"there is at least one missing byte segment [...] before
the last byte of all received segments of this SDU"
3 years ago
Robert Falkenberg 51006bbab8 lib,rlc_am_nr: fix out-of-window assignment of rx_highest_status
Also add reminders for (not yet included) handling of
SDUs with segment gaps, i.e.
"...and there is at least one missing byte segment of the SDU
associated with [...] before the last byte of all received
segments of this SDU"
3 years ago
Robert Falkenberg 1d4f10fe0d lib,rlc_am_nr: fix search start point for update of rx_next 3 years ago
Pedro Alvarez 87a4656307 lib,rlc_am_nr: fix for transmitting invalid NACKs 3 years ago
Ismael Gomez b3497c4a94 srsue,nr: decode SIB1 based on coreset0 configuration in MIB 3 years ago
Ismael Gomez f83557b891 srsue,phy: use common pucch for msg3. Completed table for all pucch_common_idx values 3 years ago
Ismael Gomez be5c3afc51 radio: fix invalid mapping of multiple channels to multiple devices 3 years ago
Ismael Gomez 65dbac0bd3 srsenb,metrics: use epre for snr computation instead of rsrp 3 years ago
Ismael Gomez 2bbeef6068 srsgnb,metrics: add ul_pucch_ni metric and refactor rssi/epre nomenclature. Fix bug in rsrp_avg computation in pucch 3 years ago
Ismael Gomez cf647b1fd5 srsenb,metrics: add PUSCH/PUCCH RSSI metrics. Add bearer DL total data metric for RLC UM 3 years ago
Pedro Alvarez 9a0d7113bc lib,rlc_am_nr: fix checking the wrong SDU rx state on t-Reassembly expiry 3 years ago
Pedro Alvarez 8e06861113 lib,rlc_am_nr: fixup rx_next_highest when t-Reassembly exipres 3 years ago
Pedro Alvarez 46872a8c84 lib,rlc_am_nr: fix unprotected access to rx_window during timer expiration 3 years ago
Pedro Alvarez a15b4c039e lib,rlc_am_nr: fix state debugging info logging. Also log current TX/RX window size 3 years ago
Pedro Alvarez 0ada2adac7 lib,rlc_am_nr: minor fixes to address coments. Re-added comment, deleted useless assignement and fixed incorrect comment 3 years ago
Pedro Alvarez 6a1f6a35c1 lib,rlc_am_nr: fix loops for updating st.rx_highest_status and st.rx_next to be bounded by st.rx_next_highest, since rx_next_highest holds the value of the highest possible missing SDU. 3 years ago
Pedro Alvarez f4ff72bff8 lib,rlc_am_nr: fixes for setting the rx_highest_status incorrectly and incorrect status report generation. 3 years ago
Robert Falkenberg a5c61418d5 lib,rf_imp: load rf plugins when loading this library
This fixes race of concurrently loading the same plugins
when srsran_rf_open_devname is called by multiple threads

Plugins are now loaded when srsran_rf is loaded (for
shared lib) or right before main() (for static lib)
3 years ago
Pedro Alvarez e6f42331ba lib,rlc_am_nr: fix race condition in handle data PDU. This was causing SDUs being removed from the rx_window, while the status report was geing generated. 3 years ago
Robert Falkenberg fbdbc81bdd lib,pdcp: fix modulus for SN increments 3 years ago
Robert Falkenberg 329f3e519b lib,rlc_am_nr: reset do_status flag after sending status PDU
and extend unit test to fail when redundant status PDUs exist.
3 years ago
Pedro Alvarez 12f440145d lib,rlc_am_nr: changed build_retx_pdu_without_segmentation to pass retx
info by copy. This is to avoid accidently using retx info by reference
after pop'ing the retx from the queue.
3 years ago
Pedro Alvarez c023dba175 lib,rlc_am_nr: cleaned up some test names and some comments. 3 years ago
Pedro Alvarez b4814bfdc1 lib,rlc_am_nr: added test for polling bit set when retx queue is empty. Fixed lost PDU test now that we correctly set the polling bit. 3 years ago
Pedro Alvarez 47aea19bd3 lib,rlc_am_nr: added test for poll setting in RETXes 3 years ago
Pedro Alvarez 1d1e6dd832 lib,rlc_am_nr: added pollBYTE support and a unit test for it 3 years ago
Pedro Alvarez eaa8fff6a0 lib,rlc_am_nr: Passing bool to get_pdu_poll() to differentiate the
behaviour between RETX and non-RETX PDUs.
3 years ago
Robert Falkenberg 5bb6cdec1e lib,rlc_am_nr: use std:vector for nacks in rlc_am_nr_status_pdu_t
- Also create tx_status a member to avoid frequent allocations
for each created PDU.

- Remove unused member nack_range from rlc_am_nr_status_pdu_t.
3 years ago
Robert Falkenberg 0cf052e31d lib,rlc_am_nr: replace hard-coded WINDOWS_SIZE 3 years ago
Robert Falkenberg 80e23624f8 lib,rlc_am_nr: extract function am_window_size() 3 years ago
Robert Falkenberg 717132e0c3 lib,rlc_am_nr: fix access of unconfigured entity 3 years ago
Robert Falkenberg 47c1845cdc lib,rlc_am_nr: add pdu_retx_queue_base, rlc_ringbuffer_base as interfaces
that are independent from templated capacity.
3 years ago
Robert Falkenberg 11ac8c2529 lib,rlc_am_nr: add support for 18-bit SNs
and first bunch of corresponding unit tests
3 years ago
Xavier Arteaga f57cf0b195 PHY: Initial PUCCH default resource selection (hard-coded row index 11) 3 years ago
Xavier Arteaga 99d2cd068f PHY: Initial PUCCH Format 1 frequency hopping 3 years ago
Robert Falkenberg 50ac1c6c0a cmake: flag install() of compiled targets as OPTIONAL
This enables `make install` for partial builds of selected targets,
which otherwise fails because the omitted targets are not present.
3 years ago
Robert Falkenberg b6d93577a0 rlc, nr: replace so_end by segment_length 3 years ago
Robert Falkenberg bb7339910f rlc: separate types of rlc_amd_retx_t for LTE and NR 3 years ago
Robert Falkenberg 4886dc8340 rlc, nr: NACK's so_end shall point to last missing byte
and not to first byte received again.
3 years ago
Joaquim Broquetas 520128162e
Add CFR to srsue LTE UL (#3865)
lte,phy: Add CFR to srsue LTE UL

This commit adds the configuration steps needed to enable
and configure the CFR module for the srsue's uplink signal.
Parsing of the CFR manual threshold has been streamlined.
3 years ago
Robert Falkenberg 7410182c64 srsran_rf: fix warning of mismatching expressions in if() and endif() 3 years ago
Robert Falkenberg 3daa43e732 srsran_rf: also build shared library when built without plugins 3 years ago
Robert Falkenberg e4d012388b phy,ctest: change anchor of relative paths used for test inputs
Use ${CMAKE_CURRENT_SOURCE_DIR} instead of ${CMAKE_HOME_DIRECTORY}
as anchor when specifying input files of tests.
Otherwise input files won't be found, when this project (srsRAN)
is not the root CMake project.
3 years ago
Robert Falkenberg 60c3d79f47 rlc, nr: complete packing of status PDUs with 18bit SNs 3 years ago
Robert Falkenberg f7515e98cf rlc, nr: add pack/unpack of nack_range in status PDUs 3 years ago
Robert Falkenberg b55f8ea624 rlc, nr: cosmetic changes 3 years ago
Robert Falkenberg 0fb6420e8b rlc, nr: avoid multi increments of SDU's retx_count within one status message 3 years ago
Robert Falkenberg 511ad9ed25 rlc, nr: Increment retx_count for segments 3 years ago
Robert Falkenberg 034aa6a6d4 rlc, nr: inform upper layer when max retransmissions is exceeded 3 years ago
Pedro Alvarez 35146bcb71 lib,rlc_am_nr: fix shadowed variable in RLC RETXes 3 years ago
Robert Falkenberg c75b8d1708 rlc, nr: increment sequence numbers using modulus 'mod_nr' 3 years ago
Robert Falkenberg 42a8e957d4 rlc, nr: fix rlc_am_nr_tx::has_data() 3 years ago
Robert Falkenberg 95ebc06ec1 rlc: implement SDU discard for AM+UM in NR+LTE
- Implemented in common base classes
- Added locking
3 years ago
Robert Falkenberg 9b44d13471 rlc, nr: notify PDCP about fully acked SDUs 3 years ago
Pedro Alvarez e6d976d115 lib,rlc_am_nr: fixed stack smashing bug that happened when too many NACKs were present in the status report 3 years ago
Pedro Alvarez ddbd857867 lib,rlc_am_nr: make sure that the RB name is logged when logging the header and status PDUs in NR 3 years ago
Pedro Alvarez b399724717 lib,rlc_am_nr: fix wrong if checking if the grant was too small to generate a segment 3 years ago
Robert Falkenberg e086479a7b srsran_rf: fix build without any active RF plugin 3 years ago
Robert Falkenberg 2dca581741 srsran_rf: only build each plugin when found AND enabled
Since [PLUGINNAME]_FOUND are cached variables, some plugins
were always built if they were found once, regardless if
the current value of ENABLE_[PLUGINNAME]
3 years ago
Codebot 81061fd545 Merge branch 'next' into agpl_next 3 years ago
Robert Falkenberg 2570c2ce77 srsran_rf: cosmetic changes 3 years ago
Robert Falkenberg 3a73d84294 srsran_rf: support dynamic loading of RF plugins
This adds flexible plugin-like loading of the individual RF
implementations (zmq, uhd, soapy,...) as per availability at runtime.
Unlike before, the binary application is not terminated if the
dependencies of individual RF interfaces are not installed on the
executing system.  To do this, the plugins are not linked by the linker
at compile time, but opened at runtime via dlopen() and dropped in case
of failure due to missing dependencies.
3 years ago
Andre Puschmann acecb1c303 emergency_handlers: increase max handlers to 256
in the ttcn3_dut application many "virtuaL" UE instances are created and
destroyed when executing the tests.

With the previous limit of 12 handlers the application stopped after
a few tests. With the limit raised to 256 we should be able to run
all white_listed TTCN3 tests for the UE without problems.

This fixes #3886
3 years ago
Bedran Karakoc 28493ec553 lib,nas_5g: Remove whitespaces in strings 3 years ago
Bedran Karakoc 767feddd73 lib,nas_5g: Implement to_string() functionality for options 3 years ago
Alejandro Leal 65519eaf3d Fixes the comparison. uint8_t was promoted to int. 3 years ago
Pedro Alvarez c8d15135c6 lib,rlc_am_nr: addressing reveier comments:
* made some methods const
  * changed from TESTASSERT to TESTASSERT_EQ
  * fix up comment
  * removed superfulous if
  * used typedef for list of segments received
  * added unit test for is_retx_required()
  * added unit test for malformed status PDU
3 years ago
Pedro Alvarez c47be649f4 lib,rlc_am_nr: added assert to double check nof_bytes before memcopying into the payload on build_retx_pdu_without_segmentation() 3 years ago
Pedro Alvarez 634c9ea3af lib,rlc_am_nr: starting to order segments to be able to receive them out-of-order 3 years ago
Pedro Alvarez 832d650574 lib,rlc_am_nr: remove unused variables. Fixed up some comments. 3 years ago
Pedro Alvarez 9bb3b1f18f lib,rlc_am_nr: remove unused code after re-factor 3 years ago
Pedro Alvarez 4bbbc8ffde lib,rlc_am_nr: fixed incorrectly adding to many segments when receiving a status report with an SO. 3 years ago
Pedro Alvarez 5e8b7b5ebe lib,rlc_am_nr: re-factored code for retx'ing with and without segmentation. 3 years ago
Pedro Alvarez 8c53c74c86 lib,rlc_am_nr: fix ptr increment when there is no SO when writting status report without SO. 3 years ago
Pedro Alvarez b13d0ca84a lib,rlc_am_nr: fixed generation of status report when SOs are present. Starting to test retx of segments. 3 years ago
Pedro Alvarez 876c45c534 lib,rlc_am_nr: added ability to pack/unpack SO_start and SO_end to rlc am nr NACKs. Added unit test for this feature. 3 years ago
Pedro Alvarez 12e530a800 lib,rlc_am_nr: fix generation of status report when NACKs of lost SDU segments are present. 3 years ago
Pedro Alvarez 7206517846 lib,rlc_am_nr: starting to add unit test for retx'ing segments. Fixed issue in updating tx_next when segmenting the SDU. 3 years ago
Pedro Alvarez 38e4c47f34 lib,rlc_am_nr: added current SO to keep track of the SO for the next RETX. 3 years ago
Pedro Alvarez 5fa72b2b3d lib,rlc_am_nr: fix creation of retx segement from existing segment. 3 years ago
Pedro Alvarez 65d5df8b6e lib,rlc_am_nr: Continue to add functionality to provide segments of retx'es. Started to add function to re-segment already existing SDU segment 3 years ago
Pedro Alvarez e4a72de342 lib,rlc_am_nr: refactored build_pdu helpers to receive the payload pointer for consistency. Added function to segment retx. Added some comments to build PDU helper functions. 3 years ago
Pedro Alvarez b1a33a07a1 lib,rlc_am_nr: starting to add test for segmenting retx. Changed sdu under segmentation to only hold the SN. The actual SDU already exists in the pdu stored in the tx_window. 3 years ago
Codebot 17291abdad Adding AGPL copyright to new files 3 years ago
Codebot 42cc7d5d1a Merge branch 'next' into agpl_next 3 years ago
Xavier Arteaga 8140e62a7f GNB-PHY: fix max PUSCH LDPC iterations 3 years ago
faluco c9c2d6982f Implement a function to remove emergency handlers when a signal is raised.
Make PCAP handlers deregister from this list when they are destructed. This avoid the signal handler calling destructed objects under very rare circumstances.
3 years ago
Bedran Karakoc 83868fd2d2 lib,nas_5g: Implement to_string() for 5GSM Cause 3 years ago
dvdgrgrtt 01ef334a24 lib,phy: Fix thresholds in Viterbi test
Under the NEON architecture, one of the BER thresholds was too tight.
3 years ago
Francisco Paisana e4a15c9c51 rrc,gnb: move non-phy fields out of phy_cell_nr_t 3 years ago
Francisco Paisana e8902c785f rrc,gnb: remove srsran_prach_cfg_t from gnb rrc config struct 3 years ago
Andre Puschmann 21c3a448b7 mac_sch_pdu_nr: fix UL-CCCH packing
fix MAC PDU packing issue for UL-CCCH that uses
only 6 B SDU. If the SDU fits inside 6 B, the LCID
for Msg3 should be set to be CCCH48 instead of CCCH64.
3 years ago
Francisco Paisana c0dda2958c rrc,gnb: fix search space NSA config 3 years ago
Francisco Paisana 532a4b54e7 rrc,gnb: remove phy flat pdcch cfg struct from rrc nr cfg 3 years ago
Francisco Paisana 88a95e8e57 rrc,gnb: remove uneeded flat phy cfg fields from rrc_nr_cfg_t 3 years ago
Andre Puschmann 26f3f6109b gw,pdcp,rlc,mac: log rate metrics in debug mode
reduce periodic log spam for L2 in info level
3 years ago
Joaquim Broquetas b2075673e5
Crest Factor Reduction feature for the phy layer (#3720)
* Add CFR module to the phy lib

* Add dynamic threshold with PAPR estimation

* Add a CFR unit test, CFR module improvements and refactoring.
Swap the gain normalization before the CFR.

* Add CFR config interface to srsenb

* Add CFR support to pdsch_enodeb

* Add DL PAPR measurement to eNB.

Co-authored-by: Cristian Balint <cristian.balint@gmail.com>

* Add test coverage to srsran_vec_gen_clip_env
3 years ago
Carlo Galiotto 91502c87db rrc-nr: rename rrc_util function and fix indexing
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto e88a4fbe18 rrc-nr: add sr_resources RRCSetup cnf conversion
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Pedro Alvarez 986e0fc273 gnb,rlc_am_nr: fix generation of default AM NR configs 3 years ago
Andre Puschmann 10aabe8763 rrc_nr_utils: set search space type for RA to type1 3 years ago
Robert Falkenberg 03bab82cd8 zmq: apply tx_gain to transmitted signal
This feature was temporary disabled in 497e183487
3 years ago
Robert Falkenberg 6b79116805 rf_file: close tx/rx files properly
Previously tests were failing on some machines, because
receiver was unable to receive the last few samples from file.
Reason: the transmitter did not close  the file properly, so
the last samples were (sometimes) not yet flushed to disk.
3 years ago
Robert Falkenberg c26f2b2041 rf_file: fix check for number of channels and cleanup after test 3 years ago
Robert Falkenberg f3d144dd59 filerf: add tx, multi-channel, open via device string and test
This commits extends the file-based RF device as follows:

* open device via device string
* add tx to file
* add multi-channel support (multiple files)
* add rf_file_test.c to for testing
3 years ago
Robert Falkenberg 57f84d4ca4 Radio: add support for file-based RF device abstraction 3 years ago
Robert Falkenberg d3eca325f7 Add file-based RF device for rx from arbitrary FILE*
It comes with the following changes:

* Add RF frontend API function "srslte_rf_open_file()"
* Open file-based RF via explicit call of custom
  "rf_file_open_file()", instead of "srslte_rf_open_multi()"
  function pointer as for regular devices.
* Introduce device name "file"
* Introduce new SRSLTE_ERROR_RX_EOF error code
* ZMQ: make update_rates() static to resolve conflicts
3 years ago