5g-team
/
srsRAN_4G
mirror of https://github.com/pvnis/srsRAN_4G.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
7,011 Commits
2 Branches
0 Tags
243 MiB
fix-cqi
master
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '59114206ae'
${ noResults }
Commit Graph

51 Commits (59114206aedd99f6962b278db948dc01d658f86d)

Author SHA1 Message Date
Andre Puschmann bc4c9606ce rlc_am: add extended bearer metrics 
this patch adds support for measuring the:
* SDU rx latency (Average time in ms from first RLC segment to full SDU)
* amount of buffered bytes (sum of payload of PDUs buffered in rx_window)

the implementation is using std::chrono
 4 years ago
Andre Puschmann d54c33258b rlc_metrics: add sdu rx latency and buffered bytes 4 years ago
Francisco Paisana 82eb31f70f add rlc metrics to enb 4 years ago
Francisco Paisana 0f693b36b2 changed pdu latency calculation to std chrono 4 years ago
Francisco Paisana 7ffc236a1a enable log line when rlc tx pdu last segment is sent but the latency log is disabled 4 years ago
Francisco 951912d18a disable RLC latency measure when ENABLE_TIMESTAMP flag is disabled 4 years ago
Francisco 92bc98e2f0 add byte tx counter to the set of metrics being measured in RLC 4 years ago
Francisco e2654e69ec Enable pdu stack latency measurements in the eNB. 4 years ago
Andre Puschmann cff9f03a11 rlc_am_lte: remove unused rx/tx metrics members 
those variables aren't used and are included in the bearer metrics already
 4 years ago
Andre Puschmann 3c169e6be1 rlc_am: increment retx counter for segments 
we've only incremented the retx when retransmitting a full PDU,
but not when only retransmitting segments.

This might lead to many more retx than allowed.
 4 years ago
Pedro Alvarez 38206bea69 Fixed RLC AM fixed header size in get_buffer_state function. Fixed RLC AM tests accordingly. 4 years ago
Andre Puschmann 07d2bc4fe8 change license header to agnostic version with hint to root LICENSE file 4 years ago
Andre Puschmann 477fe77f24 rlc_am: reformat log message for PDU retx 4 years ago
Andre Puschmann f155b7a5d5 rlc: fix stopping of poll retx timer (#2006) 
* rlc_am: add TC for pollRetx timer handling

* rlc_am: fix stopping of pollRetx timer

stopping the pollRetx timer when receiving a status PDU
without checking the acknowledged PDUs is wrong.

if an ACK for another PDU, for which the polling bit has been set,
is still pending, it won't be rescheduled until another
PDU is transmitted that again starts the pollRetx timer.

this fixes the issue with missing RLC AM segment retx in #1992,
and #2003
 4 years ago
Andre Puschmann 7cf919e2af Fix MAC PDU packing after sending Truncated BSR (#2004) 
* mac_test: add extended TBSR unit test

unit test to MAC UL packing after sending a TBSR

this fixes the MAC issues described in issue #2002

* mux: fix updating of LCG buffer state after packing PDU

we've previously lowered the buffer state of the LCG according
to the bytes that have been scheduled, but not according to
those that have been actually included in the PDU.

* proc_bsr: fix LCG buffer state updating for TBSR

when sending a TBSR do not update the internal buffer
state of the BSR proc.

This caused issues because the buffer state for all LCG that
are not included in the TBSR are set to zero, although at least
one LCG does have data to transmit.

* rlc_am: include LCID when logging retx of SN
 4 years ago
Andre Puschmann f647343f18 rlc_am: fix poll bit during header reconstruction 
this makes sure that the reconstructed RLC AM header
has the poll bit set when any of its segments had it set.

this triggered a bug in RLC AM because the Status PDU
isn't transmitted for a RLC PDU that was segmented and
only the first segment had the P flag set.
 4 years ago
Andre Puschmann 1a03839f78 rlc_am_lte: fix potential bug when setting uint32_t to -1 
discovered in Coverity CID 359664
 4 years ago
faluco dfeed52514 - Rename out_stream function to console. 4 years ago
faluco 62faef7c71 - Replaced all uses of the log::console method. 4 years ago
Andre Puschmann 6fb01d61a7 rlc: change remaining occurances of "SN: " to "SN=" 
streamline all RLC AM and UM for better log analysis
 5 years ago
Andre Puschmann a7911f0dab pdcp,rlc: refactor SDU queueing policy 
this patch refactors the SDU queuing and dropping policy of the RLC and PDCP layer.
the previous design had issues when packets have been generated at a higher
rate above the PDCP than they could be consumed below the RLC.

When the RLC SDU queues were full, we allowed two policies, one to block on the write
and the other to drop the SDU. Both options are not ideal because they either
lead to a blocking stack thread or to lost PDCP PDUs.

To avoid this, this patch makes the following changes:

* PDCP monitors RLC's SDU queue and drops packets on its north-bound SAP if queues are full
  * a new method sdu_queue_is_full() has been added to the RLC interface for PDCP
* remove blocking write from pdcp and rlc write_sdu() interface
  * all writes into queues need to be non-blocking
  * if Tx queues are overflowing, SDUs are dropped above PDCP, not RLC
* log warning if RLC still needs to drop SDUs
  * this case should be avoided with the monitoring mechanism
 5 years ago
Andre Puschmann 95f5093432 rlc_am: hold lock while handling new PDUs 
This lock was removed in 1cbf7eac because it was considered unneeded.
However, as can be seen in issue #1503, we need to protect the access
to rx_window, for example.

Issue #1503 shows a stack trace where a PHY worker generates a status PDU.
While holding the mutex to access rx_window, the stack thread on the
other hand, happily accesses the rx_window member without acquiring
the lock. This commit protects all handle_*() functions in write_pdu().

This reverts commit 1cbf7eac04.
 5 years ago
Andre Puschmann eb56efe9f5 rlc_am_lte: turn error message into warning and print state variables 
the issue doesn't cause any unrecoverable situation so its not
appropiate to use the error level
 5 years ago
Andre Puschmann df50dd7d3c rlc: extend RLC metrics 
extend RLC metrics to count Rx/Tx PDUs/SDUs bytes/#
 5 years ago
Andre Puschmann 82f811ed52 rlc_am: change return value when writing SDU 
return false when SDU couldn't be added to SDU tx queue so
to count dropped SDUs in base
 5 years ago
Andre Puschmann 3cef20607e rlc_am: fix bug in returning zero len bytes 5 years ago
Ismael Gomez a1f0f8de35
Add callback to RLC to indicate BSR for TX and reTX queues (used in ENB) (#1361) 5 years ago
Andre Puschmann 1eaa99530f rlc_am: tiny refactor of rlc_amd_pdu_header_t 
mainly turning header into proper class and adding default init value
 5 years ago
Francisco Paisana 791d84e639 created error_type and cleaned up expected 5 years ago
Francisco Paisana a2b76a4a5f use references rather than pointers 5 years ago
Xavier Arteaga 77d5dedddc Fix LGTM warnings and recommendations 5 years ago
Xavier Arteaga 562590e595 Fix LGTM warnings 5 years ago
Francisco Paisana 1cbf7eac04 removed uneeded lock in rlc_am_lte 5 years ago
Francisco Paisana 344eaf49ec use logmap in the whole enb and ue 5 years ago
Xavier Arteaga e832769ae6 Updated copyright 5 years ago
Andre Puschmann ed179fd311 timers: rename value() to time_elapsed() 
this seems to be better readable than value() since
we've sometimes confused it with the timeout value
 5 years ago
Andre Puschmann b085a8eabf rework debug log when getting buffer state in RLC AM 
also adds some description to RLC functions being called
from outside the stack thread
 5 years ago
Xavier Arteaga 8b6ba1aacf srsLTE: removed overlap bytes check in RLC AM 5 years ago
Xavier Arteaga 5872e763bf SRSLTE: RLC AM remove completely overlapped segments 5 years ago
Xavier Arteaga 39bec9aab1 SRSLTE: fix RLC reordering and segment overlaping 5 years ago
Andre Puschmann 476f970ee1 replace FIXME with TODO 5 years ago
Andre Puschmann 4f5e991480 fix typo in RLC AM 5 years ago
Pedro Alvarez c5979f59eb Clang format UE, eNB and lib (#850) 
* Clang-formated UE, eNB and lib.
* Fixed compiling errors from clang-format.
* Fix linking issues introduced by clang-format
* Fix poor formating in initializing arrays of arrays.
* Fix mistake in conflict resolution on rm_turbo.c
* Re-apply clang format to gtpc_ies.h
 5 years ago
Andre Puschmann 9078b2baf1 rlc_am: add check to prevent out of bounds access 5 years ago
Pedro Alvarez ca7c865ce8 Removed unecessery indentation in RLC AM write SDU. 5 years ago
Pedro Alvarez a77dd4e959 Starting to add boiler-plate code to support Discard at RLC. 5 years ago
Andre Puschmann db2c43553e add basic rlc_am_base class containing data/control PDU check 5 years ago
Andre Puschmann b8dbffe0b5 rewrite RLC AM debug code 5 years ago
Andre Puschmann dc841ab029 printf in rlc_am 5 years ago
Andre Puschmann b20f7ba541 refactor RLC UM and add NR receiver 5 years ago