9404 Commits (476f9e115686b6cef2cb37220fd0f8c06054b1fc)
 

Author SHA1 Message Date
Alejandro Leal Conejos 6cd917fca5 Fixes coverity 370816 3 years ago
Alejandro Leal Conejos 0fdbfcffd0 Removes unnecesary cast 3 years ago
Bedran Karakoc 9943c79c4a Return error in ul nas transport if AMF ctxt is not available 3 years ago
Bedran Karakoc a14cc451d0 Addition NGAP cleanup 3 years ago
Bedran Karakoc fa87715724 Increase context rx count for handled messages 3 years ago
Bedran Karakoc b6b0dd911b Apply NAS security for Identity Response 3 years ago
Bedran Karakoc 66ed8b9065 Add NSSAI slice differentiator, currently only 0 supported 3 years ago
Bedran Karakoc 7c53f1cbab Add stdout for successful NG connection 3 years ago
Bedran Karakoc 4e60475200 Apply security to Deregistration Request (UE Originating) 3 years ago
faluco f1385640c4 Fix data race in proc_bsr and ul_harq classes. 3 years ago
faluco 3f0d4f0293 Fix data races in proc_bsr_nr and proc_ra_nr. 3 years ago
Andre Puschmann 08e9b0b5c1 enb,rrc: reduce log level when inactivity event is received from NR 3 years ago
Andre Puschmann 7f6801cb1e ue_sync: fix 32bit compilation
fix printf format string on 32bit arches like ARMv7

FAILED: lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o
/usr/bin/gcc -DASSERTS_ENABLED -DENABLE_TIMEPROF -DENABLE_TTCN3 -DHAVE_BACKWARD -DHAVE_MBEDTLS -DHAVE_PCSC -I/usr/include/PCSC -I/usr/include/SoapySDR -Ilib/include -I../lib/include -Wno-unused-but-set-variable -Wall -Wno-comment -Wno-write-strings -Wno-unused-result -Wformat -Wmissing-field-initializers -Wtype-limits -std=c99 -fno-strict-aliasing -D_GNU_SOURCE -O3 -fno-trapping-math -fno-math-errno -DBUILD_TYPE_RELEASE -DIS_ARM -DHAVE_NEON -mfloat-abi=hard -mfpu=neon -fvisibility=hidden -fdiagnostics-color=always -Werror --param large-function-growth=1600 -O3 -DNDEBUG -fPIC -MD -MT lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o -MF lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o.d -o lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o   -c ../lib/src/phy/ue/ue_sync.c
In file included from ../lib/include/srsran/srsran.h:31,
                 from ../lib/src/phy/ue/ue_sync.c:13:
../lib/src/phy/ue/ue_sync.c: In function ‘srsran_ue_sync_set_tti_from_timestamp’:
../lib/include/srsran/phy/utils/debug.h:59:23: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint64_t’ {aka ‘long long unsigned int’} [-Werror=format=]
       fprintf(stdout, "[DEBUG]: " _fmt "\n", ##__VA_ARGS__);                                                           \
                       ^~~~~~~~~~~
../lib/src/phy/ue/ue_sync.c:1044:3: note: in expansion of macro ‘DEBUG’
   DEBUG("rx time with 3gpp base in ms %lu\n", time_3gpp_msecs);
   ^~~~~
../lib/src/phy/ue/ue_sync.c:1044:41: note: format string is defined here
   DEBUG("rx time with 3gpp base in ms %lu\n", time_3gpp_msecs);
                                       ~~^
                                       %llu
cc1: all warnings being treated as errors
3 years ago
joaquim-SRS 00b82bc772 Fix more issues in PHY lib
Fix variable shadowing issues in chest_test
Fix mutex unlock position in dft_fftw.c
CID 371598 Out of bounds access, in ssb_decode_test.c
3 years ago
joaquim-SRS 9b74e3429c Fix more Coverity issues in the PHY lib
CID 369560 Missing unlock, in dft_fftw.c
CID 363710 Logically dead code, in resampler.c
CID 55097 Result is not floating point, in chest_test_dl.c
CID 351020 Result is not floating point, in chest_nbiot_test_dl.c
3 years ago
Nils Fürste 3b1131936e Fix GTP-U bearer address conversion
Addresses with a leading 0 in hex represenatation were converted
without the leading 0 and padded afterwards with a trailing 0. This
leaded to wrong IPs in the GTP-U bearer setup.
3 years ago
Nils Fürste b036da07de Extend ASN1 utils function from_number() 3 years ago
Fabian Eckermann 0007473c7a Initialize variable. 3 years ago
Fabian Eckermann f539851128 Fix possible out-of-bounds-read. 3 years ago
Fabian Eckermann 3e9590fd13 Initialize variable. 3 years ago
Fabian Eckermann 1c75ed10a8 Initialize variable. 3 years ago
Fabian Eckermann 1b2d77a49d Fix possible out-of-bounds-read. 3 years ago
Fabian Eckermann 8753ea1be5 Fix coverty defects. 3 years ago
Carlo Galiotto 5972345c9d rrc,nr: increase msg5 timer to 5s and inactivity...
timer to 10s

Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto 0d67fbc36c rrc: change call to release user
We call s1ap instead of rrc

Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Carlo Galiotto 9c74dda039 rrc,nr: add msg5 and inactivity timers to RRC-NR
Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Andre Puschmann 0cfcd612b0 enb.conf.example: fix merge conflict 3 years ago
faluco edf0926a2f Batch of LGTM fixes. 3 years ago
Francisco 529e2bdf55 nr,rlc: call bsr update callback in RLC UM NR 3 years ago
Francisco 7ad1ad800e lte,enb,rlc: atomically compute DL buffer state and update the scheduler in the eNB 3 years ago
Ismael Gomez d972fb368c
Some LGTM fixes (#3564)
* Fix LGTM issues

* ue: add logging to switch on function

* Fix new LGTM issues
3 years ago
Alejandro Leal Conejos 2a2518b7e4 Fixes coverity 372096 3 years ago
Alejandro Leal Conejos 547ebf11f7 Fixes coverity 372880 3 years ago
Alejandro Leal Conejos ee0ec564ef Fixes coverity 373333 3 years ago
Alejandro Leal Conejos 4c518b8c82 Fixes coverity 373325 3 years ago
Joaquim 93649429dd
WIP: Fix Coverity issues in PHY lib (#3507)
Fix several Coverity issues

This commit adrresses the following code issues found by Coverity:

CID 339785 Division by zero, in fading_channel_test.c
CID 355272 Division by zero, in awgn_channel_test.c
CID 355277 NULL ptr dereference, in awgn_channel_test.c
CID 359663 NULL ptr dereference, in delay_channel_test.c
CID 369544 NULL ptr dereference, in chest_dl_nbiot.c
CID 373326 Resource Leak, in dft_fftw.c
CID 373329 Resource Leak, in dft_fftw.c
CID 372878 Division by zero, in sliv_test.c
CID 372871 Division by zero, in dmrs_pdcch.c
CID 370622 Negative loop bound, in csr_rs.c
CID 370624 Negative loop bound, in csr_rs.c
CID 370626 Negative loop bound, in csr_rs.c
CID's 369568, 369594 NULL ptr dereference, in ch_awgn.c
CID 369540 Logically dead code, in refsignal_dl.c
CID 369608 Logically dead code, in refsignal_ul.c
CIDs 366291, 366296, 366297 Out-of-bounds access, in zc_sequence.c
CID 372209 Division by zero, in cqi.c
CID 370992 Uninitialized pointer read, in pdcch_test.c
CID 373334 Integer overflow, in ue_sync.h
CID 370993, 370995 Undefined division, in pdcch_test.c
CID 370994 Undefined division, in ssb_decode_test.c
CIDs 353368 353364 353365 359673 353366 353367
Explicit null dereferenced, in psss_file_test.c
CID 371865 Unchecked return value, in rf_uhd_imp.cc
CID 363810 Undefined division, in ldpc_rm_chain_test.c
CID 372209, 372211, 372213, 372216 Undefined modulo, in cqi.c
CID 339834 Array compared against 0, in chest_dl.c
CID 369589 Out of bounds access, in dmrs_pucch.c
CID 371681 Out of bounds access, in ue_sync_nr_test.c
CIDs 370761, 370825 Copy-paste error, in ssb.c
CID 369599 out of bounds read, in dmrs_pdcch_test.c
CID 363795 out of bounds read, in ldpc_dec_c_avx2_flood.c
CID 363805 out of bounds read, in ldpc_dec_c_avx2long_flood.c
CID 363821 out of bounds read, in ldpc_dec_c_flood.c
3 years ago
Ismael Gomez bdbaf7357a ue,nr: Protect pending_cfgs in PHY worker_pool 3 years ago
faluco b058945142 Fix data race in sync::current_earfcn. 3 years ago
faluco 92b81b200f Fix data race in ul_harq_process::current_irv. 3 years ago
Francisco c928615952 nr,gnb,sched: avoid scheduling RAR for RNTIs whose ue object is not yet created in the scheduler 3 years ago
faluco dc31fb05a3 Fix ODR issue detected by ASAN in arch for the srsran_verbose global variable. 3 years ago
faluco fa8e8ddf1f Fix an ODR issue detected by ASAN in arch, where the global variable handler_registered was defined multiple times. 3 years ago
Nils Fürste 6c8324d95e srsenb.conf.example: Fix typos and make layout consistent 3 years ago
Pedro Alvarez b194bd8e63 Added comment and usage example to epc.conf.example to the request IMEI-SV option 3 years ago
Matan Perelman f4adf80263 Add option to request IMEISV 3 years ago
yagoda 5d6b48311e fixing a few regression bugs in embms 3 years ago
Pedro Alvarez bc903b13d5 Added nia0 to hardcoded configuration of nr-bearer-config 3 years ago
Pedro Alvarez a40a2dc191 Disable integrity/encription at PDCP-NR, as it will break when packets arrive out-of-order. 3 years ago
Carlo Galiotto dcc2c1c694 rrc,nr: defer rem_user after msg3 timer expires
This commits is to fix the issue of user removal from rrc_nr
after msg3 timer expires.
The issue was caused because the rrc_nr is accessing the ue object
after it gets removed from the users list in rrc_nr.
This commits defers the removal of the users, so there won't be any
access to invalid memory locations.

Fixes #3545

Signed-off-by: Carlo Galiotto <carlo@srs.io>
3 years ago
Andre Puschmann 497e183487 rf_zmq_imp: disable Tx baseband scaling
until the correct gain settings are documented and potential
mis-configuration are handled. It seems that the default
Tx/rx gains values are not working with this function.
3 years ago