Pedro Alvarez
d62266ec58
rrc: fix mobility test to check if SRB2 being started to early
2 years ago
Pedro Alvarez
0cc632988f
lib,rlc: tweaked some comments
3 years ago
Pedro Alvarez
f5658619b8
lib,rlc: ack_sn does not count as a positive or negative acknowledgment.
...
do not stop t-PollRetransmit for it
3 years ago
Pedro Alvarez
7ac7c8673a
lib,rlc: Fixed issue where `p` bit was not checked if PDU was outside of
...
the RX window. This could lead to a data stall, where TX keeps retx'ing
the same PDU to request a status report.
3 years ago
Pedro Alvarez
40f19b0e2c
lib,rlc: added check for status report in full rx_window test.
3 years ago
Pedro Alvarez
f4ca1848d6
lib,rlc: allow reception of ACK_SN == TX_NEXT+1,
...
as this can happen when the last segment has not been sent yet.
3 years ago
Pedro Alvarez
ede44369f4
lib,rlc: add fix for issue in checking full RLC TX window
3 years ago
Pedro Alvarez
dc71048d83
lib,rlc: fixed up test for full rx window
3 years ago
Pedro Alvarez
b7ec529ff2
lib,rlc: allow ACK_SN be one over the end of the RX window.
3 years ago
Pedro Alvarez
51ffd91f16
lib,rlc: added unit test that triggers assert when RX window is full
3 years ago
Robert Falkenberg
a1db7fe9fe
rlc_am_nr: fix shadowed variable
3 years ago
Andre Puschmann
f6033264f9
gnb,mac_nr: ignore SE_PHR CE received from UE
...
we are not handling the periodic SE_PHR yet.
3 years ago
Andre Puschmann
d99cff050d
ue,rrc_nr: handle RRC release
3 years ago
Robert Falkenberg
e057a8ec27
lib,pdcp_nr: unit test - remove redundant assignment
3 years ago
Robert Falkenberg
a11291eb08
lib,rlc_am_nr: fix handling of NACK ranges with SO reaching SDU edge
...
This changes the handling of NACK ranges with segment offset (SO),
where either so_start or so_end reach the edge of a full SDU.
That SDU is then NACK'ed as a whole, rather than as a segment
from 0 to 0xFFFF.
Otherwise, the search for segments will fail if said SDU was
initially sent as a whole (without segmentation).
3 years ago
Robert Falkenberg
fccfd5e140
lib,rlc_am_{lte,nr}: fix/add tx_window overrun protection
...
This commit fixes as bug causing a crash of the eNB in case
of many pending RETX and the reception of a trimmed PDU.
The following sequence leads to a crash:
- RETX queue contains many PDUs for RETX
- Receive trimmed PDU containing a trimmed subset of NACKs
- RETX queue is cleared and re-populated with a trimmed subset
- After all RETX (/!\ trimmed subset) is done, continue TX new PDUs
- tx_window blows up
- tx_window overflows if another status PDU is not received in time
- Overflow overwrites oldest element in tx_window
- Handling of next status PDU fails due to missing elements in tx_window
Related PR #4029
3 years ago
yagoda
66b5b6c236
phy: pass number PRBs from the correct cell config into the channel emulator when running NR standalone mode
3 years ago
Pedro Alvarez
d5909a306f
lib,pdcp_nr: fixed typos and rephrased log in tests.
3 years ago
Pedro Alvarez
0f1c8b03c7
lib,pdcp_nr: fixed up some comments and a logging message
3 years ago
Pedro Alvarez
540483ba9e
lib,pdcp: added unit test to check discard timer is running when a PDU is TX'ed and stopped when the ACK has been notified.
3 years ago
Pedro Alvarez
e87416ff99
lib,pcdp_nr: added checks for stopped reordering timer and correct state
...
when receiving out-of-order packets in unit tests.
3 years ago
Pedro Alvarez
eb819cb9d0
lib,pdcp_nr: fix RX_DELIV update when t-Reordering expires
3 years ago
Pedro Alvarez
5f385bb33f
lib,pdcp_nr: fix logging message when discard timer expires
3 years ago
Pedro Alvarez
82e4b9e238
lib,pdcp_nr: fix discard timer not being stopped correctly
3 years ago
Pedro Alvarez
6d313f1875
lib,pdcp_nr: added extra comments on logging information to regarding
...
discard and t-Reordering expiry
3 years ago
Andre Puschmann
fdbe894865
nas5g: print error message on console if PDU session establishment fails
3 years ago
Andre Puschmann
5cc311db64
ngap_test: fix uninitialized NSSAI
...
detected by Valgrind
3 years ago
Pedro Alvarez
c82f58c0b9
lib,pdcp_nr: drop SDU if RLC queue is full
3 years ago
Pedro Alvarez
57772ffa35
lib,pdcp_nr: added warning for trying to use t-Reordering of infinity on RLC UM bearers
3 years ago
Pedro Alvarez
8d65b40734
lib,pdcp_nr: allow for t-reordering of inifinity
3 years ago
Andre Puschmann
573dc34b73
gnb,rrc_nr_test: fix uninit memory
3 years ago
Andre Puschmann
f3ee8b2078
ngap: fix invalid access of amf ID when context wasn't created yet
3 years ago
Andre Puschmann
bed35c747c
gnb,rrc: fix handling of DRB for reconfig/reestablishment
...
the five_qi value received from the 5GC was not stored/passed when
the UE object was moved from one RNTI to another during e.g.
reestablishment. this makes sure the selected 5qi is passed over
during that process.
3 years ago
Andre Puschmann
bbd84f087e
gnb,rrc: add error checking/handling when creating cellgroup cfg
3 years ago
Andre Puschmann
d3a049bd7b
readme: add github actions badge
3 years ago
Andre Puschmann
35c8c712e4
cmake: fix typo
3 years ago
Robert Falkenberg
e891d72ab8
lib,rlc_am_nr: fix out-of-bounds access when unpacking malformed status PDUs
3 years ago
Pedro Alvarez
cc93b5b6b0
ue,gnb,rrc_nr: make sure that RLC is setup before PDCP, so the PDCP can know wether the RLC is UM or AM
3 years ago
Pedro Alvarez
84cf5c30ec
lib,pdcp_nr: rm ifdef to select PDCP NR. PDCP NR is always selected now
3 years ago
Robert Falkenberg
e0620873ef
lib,rlc_am_nr: no error on insufficient space for new or continued segment.
3 years ago
Robert Falkenberg
cbc8364a94
lib,rlc_am_nr: no error on insufficient space for RETX segment.
3 years ago
Robert Falkenberg
21a4a675dd
cmake/gcc: disable [-Werror=maybe-uninitialized] for GCC >= 12.1.0
...
With GCC 12.1.0 there are numerous false-positive warnings on
"maybe uninitialized" variables.
3 years ago
Robert Falkenberg
0c9ba5b87e
lib,asn1_utils: fix out of bounds access on zero-sized array
...
* fix error: ... offset 0 is out of the bounds [0, 0] [-Werror=array-bounds]
* fix note: destination object of size 0 allocated by ‘operator new []’
--> data_ = new T[cap_];
3 years ago
Pedro Alvarez
58f71b10b6
gnb,config: make SRB configuration mandatory
3 years ago
Pedro Alvarez
02b3558390
lib,pdcp_nr: fix typos
3 years ago
Pedro Alvarez
a08579dae9
ue,rrc_nr: mark is_security_active as true, after updating SK counter.
3 years ago
Pedro Alvarez
7f98101f30
lib,pdcp_nr: fix rx unit tests
3 years ago
Pedro Alvarez
904dbff471
lib,pdcp_nr: fixed PDCP NR tx unit tests
3 years ago
Pedro Alvarez
b361ab0650
lib,pdcp_nr: fix pdcp nr encryption
3 years ago
Pedro Alvarez
1b2c9502e2
lib,pdcp_nr: fix order in which header discard was done in PDCP NR.
3 years ago