5g-team
/
srsRAN_4G
mirror of https://github.com/pvnis/srsRAN_4G.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,385 Commits
2 Branches
0 Tags
243 MiB
fix-cqi
master
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '1807ba1e37'
${ noResults }
Commit Graph

4348 Commits (1807ba1e374403bf840ecbe81e47d05e06ef2f4b)

Author SHA1 Message Date
Francisco 529e2bdf55 nr,rlc: call bsr update callback in RLC UM NR 3 years ago
Francisco 7ad1ad800e lte,enb,rlc: atomically compute DL buffer state and update the scheduler in the eNB 3 years ago
Ismael Gomez d972fb368c
Some LGTM fixes (#3564) 
* Fix LGTM issues

* ue: add logging to switch on function

* Fix new LGTM issues
 3 years ago
Joaquim 93649429dd
WIP: Fix Coverity issues in PHY lib (#3507) 
Fix several Coverity issues

This commit adrresses the following code issues found by Coverity:

CID 339785 Division by zero, in fading_channel_test.c
CID 355272 Division by zero, in awgn_channel_test.c
CID 355277 NULL ptr dereference, in awgn_channel_test.c
CID 359663 NULL ptr dereference, in delay_channel_test.c
CID 369544 NULL ptr dereference, in chest_dl_nbiot.c
CID 373326 Resource Leak, in dft_fftw.c
CID 373329 Resource Leak, in dft_fftw.c
CID 372878 Division by zero, in sliv_test.c
CID 372871 Division by zero, in dmrs_pdcch.c
CID 370622 Negative loop bound, in csr_rs.c
CID 370624 Negative loop bound, in csr_rs.c
CID 370626 Negative loop bound, in csr_rs.c
CID's 369568, 369594 NULL ptr dereference, in ch_awgn.c
CID 369540 Logically dead code, in refsignal_dl.c
CID 369608 Logically dead code, in refsignal_ul.c
CIDs 366291, 366296, 366297 Out-of-bounds access, in zc_sequence.c
CID 372209 Division by zero, in cqi.c
CID 370992 Uninitialized pointer read, in pdcch_test.c
CID 373334 Integer overflow, in ue_sync.h
CID 370993, 370995 Undefined division, in pdcch_test.c
CID 370994 Undefined division, in ssb_decode_test.c
CIDs 353368 353364 353365 359673 353366 353367
Explicit null dereferenced, in psss_file_test.c
CID 371865 Unchecked return value, in rf_uhd_imp.cc
CID 363810 Undefined division, in ldpc_rm_chain_test.c
CID 372209, 372211, 372213, 372216 Undefined modulo, in cqi.c
CID 339834 Array compared against 0, in chest_dl.c
CID 369589 Out of bounds access, in dmrs_pucch.c
CID 371681 Out of bounds access, in ue_sync_nr_test.c
CIDs 370761, 370825 Copy-paste error, in ssb.c
CID 369599 out of bounds read, in dmrs_pdcch_test.c
CID 363795 out of bounds read, in ldpc_dec_c_avx2_flood.c
CID 363805 out of bounds read, in ldpc_dec_c_avx2long_flood.c
CID 363821 out of bounds read, in ldpc_dec_c_flood.c
 3 years ago
faluco dc31fb05a3 Fix ODR issue detected by ASAN in arch for the srsran_verbose global variable. 3 years ago
faluco fa8e8ddf1f Fix an ODR issue detected by ASAN in arch, where the global variable handler_registered was defined multiple times. 3 years ago
yagoda 5d6b48311e fixing a few regression bugs in embms 3 years ago
Andre Puschmann 497e183487 rf_zmq_imp: disable Tx baseband scaling 
until the correct gain settings are documented and potential
mis-configuration are handled. It seems that the default
Tx/rx gains values are not working with this function.
 3 years ago
Andre Puschmann e2d26b5a8c rlc_um_nr: log PDU without SN if full SDU is transmitted 
PDUs that contain full SDUs don't have SNs, so the log should be
without it
 3 years ago
Andre Puschmann 3eb1862ab9 gnb_interface: reduce MAX_GRANTS to 4 
see #3530 for detailed discussion. This change saves some CPU cycles it seems
 3 years ago
Fabian Eckermann 32a1646536
nr,gnb,rrc: Derive RRC parameters from config. 
* Derive RRC parameters from config.
* nr,gnb,rrc: hard code prach config index to 8 to avoid expiring RA proc window.
 3 years ago
faluco 5ff6b2eaa9 Fix data race in ZMQ where nsamples and running variables could be read concurrently. 3 years ago
Xavier Arteaga 322f57a952
Initial real-time Tx gain setting (#2976) 
* Make filename const in filesink

* Sine generation returns the next phase

* Avoid malloc/free in radio class

* Implement Tx gain in ZMQ

* Initial ratio RT gain test

* UHD: use timed Tx gain commands to align changes to subframes

* Minor improvement in test_radio_rt_gain

* Fix compilation

* Check RF gain thread id before joining

* Remove redundant zero initialization.

Co-authored-by: Fabian Eckermann <fabian@srs.io>
 3 years ago
Xavier Arteaga ebab12403f
Asynchronous NR PHY configuration (#3527) 
* Fix a race condition when accessing the NR PHY cfg by the RRC and phy workers.
Rework how the phy cfg is handled, now workers have their own copy that gets updated after a reconfig moving it out of the state class.

* Default initialize sf_len member in sf_worker for consistency.

* Asynchronous NR PHY configuration

* Fix compilation

* Corrected method override and fix unitialised value

* Added carrier equal comparison to avoid aligment byte padding comparison

Co-authored-by: faluco <borja.ferrer@softwareradiosystems.com>
 3 years ago
faluco 0ada9a01ec Whitelist TSAN issue in srsenb::mac::sr_detected. 3 years ago
faluco a1b2f3915d Whitelist lock order inversion tsan issue in srsenb::rlc::rb_is_um. 3 years ago
Andre Puschmann 8294724aad gnb_interface: reduce MAX_GRANTS to 4 
this significantly reduces data copies when providing the PHY
with scheduler results.
 3 years ago
Xavier Arteaga 95bf85b3d3 Reduced maximum number of CSI reports 3 years ago
Pedro Alvarez fbcffb84bd Check if RLC is suspended before transmiting PDCP SDU. 
This was done to avoid integrity issues, when the UE's RRC erroneously sent
measurement reports while the re-establishment was already in progress.

As errously sending PDCP PDUs on DRBs can cause issues as well, this was
disabled too.
 3 years ago
Alejandro Leal Conejos 9daa32e591 Configure the term timeout using the cmake definition 
EXTRA_TERM_TIMEOUT_S
 3 years ago
Xavier Arteaga d9bdc3f83e Add CSI resource information and fix segmentation fault 3 years ago
Carlo Galiotto 284207dad6 WIP: fixing collision in the the users_map 
Signed-off-by: Carlo Galiotto <carlo@srs.io>
 3 years ago
Xavier Arteaga eace81d613 Fix UCI multiplexing for NR PUSCH 3 years ago
Xavier Arteaga 39bfcf4a5c Add UCI valid in NR PUSCH info 3 years ago
Ismael Gomez 7920e084b8 Revert "Do not abort tsan" 
This reverts commit e8e1d101c553912f733070e71d020a33ec895280.
 3 years ago
Ismael Gomez 80c48a8b01 rlc: protect access to tx_enabled 3 years ago
Ismael Gomez bf566fbd29 radio: protect concurrent access from tx_end and tx 3 years ago
Ismael Gomez 4239222909 Do not abort tsan 3 years ago
faluco 95b4a92f5f Clarify the error messages printed when trying to open a RF device. 3 years ago
Francisco c6226b0d94 lte,enb,rrc: parse cellIndividualOffset in rr.conf and propagate it to measConfig sent to UE 3 years ago
Pedro Alvarez 65a2b35f09 Fix not checking initialization of S11 in MME. Fixed typo. 3 years ago
Pedro Alvarez 0b948d4098 Make sure that bind returns error if it cannot bind. Added test for SCTP bind error/success. 3 years ago
Pedro Alvarez e721504f8e Removed the sctp_init_server for consistency. Added listen method to unique_socket class. 3 years ago
Pedro Alvarez e9a7e6dbae Getting rid of sctp_init_client function. The only thing it does is call the sctp_init_socket function. 3 years ago
Francisco d60950d0f3 lte,enb,rlc: change new_tx and prio_tx variable names to snake_case and ensure they are zero initialized 3 years ago
Francisco 7aa5f731ce lte,enb,rlc: push to scheduler pending prioritized bytes both in case of RLC timer expiry or in case of new buffer state detection 3 years ago
Francisco 4a58c10f30 lte,enb,rlc: compute and forward to scheduler the number of bytes pending for retx and status pdu in RLC AM bearer 3 years ago
Xavier Arteaga 4edb61212f Added number of CDM groups to phy_dl_nr_test 3 years ago
Xavier Arteaga 8e5fe9018b Corrected LBRM functionality 3 years ago
Xavier Arteaga 9ecea014bd Added PUSCH DMRS minimum SNR 3 years ago
Francisco 0b51848dda nr,gnb,rrc: use multiqueue to forward x2 tasks to NR stack 3 years ago
Fabian Eckermann 59df04547e Increase buffer size for NR. 3 years ago
Andre Puschmann 3bf09021f9 enb: remove unused parameter 3 years ago
Francisco 5b2afb1739 rrc,nr,gnb: ensure same PDCCH config is sent to PHY, scheduler cell config, and sched ue cfg 3 years ago
Francisco 7a16be9692 rrc,nr: ensure coresets and search spaces are passed to scheduler cell_cfg and ue_cfg 3 years ago
Andre Puschmann e5556fcc32 mac_pdu_nr_test: add LBSR unpacking tests 3 years ago
Andre Puschmann af69551c8d mac_sch_pdu_nr: add LBSR unpacking 
* add LBSR unpacking
* add pretty printer
* also simplify and unify general unpacking code
 3 years ago
Francisco 81174bda64 nr,ue,rrc: release NR logical channels during RRC release 3 years ago
Xavier Arteaga 537f165482 Added comments 3 years ago
Xavier Arteaga 3c40cd2840 Improved NR PHY logging info 3 years ago
Xavier Arteaga addd687d7e Fix NR PUCCH format 1 normalised correlation 3 years ago
Xavier Arteaga e6bd6462b1 Estimate CFO for NR PUCCH formats 0 and 1 3 years ago
Xavier Arteaga 51ff429bc7 Added SS type to PDSCH context info 3 years ago
Xavier Arteaga a5f6aa9f31 Added CSI string in PDSCH and PUSCH decode 3 years ago
Xavier Arteaga 003c6e524c Added short NR CSI information 3 years ago
faluco dacf40f63e Delete move constructor and move assignment operator explictly for mac_pcap_base and s1ap_pcap classes. 
Move emergency handlers header file into the support folder.

Refactored signal handling:
- Remove the dependency with the running static variable in the header file.
- Move implementations down to cc files.
- Allow specifying a new signal handler that will be used to stop the applications.
- Move signal handling files to support.
 3 years ago
faluco 9075251627 Move the cleanup code from the signal handlers down to the new emergency handlers for the ue, epc and enb. 3 years ago
faluco 2c1e9c0c55 Implement an emergency cleanup handler registration mechanism to allow modules to clean themselves before application gets killed. 
Flush PCAP contents just before killing the application.
 3 years ago
Fabian Eckermann 44de4996e8 Fix log message. 3 years ago
Francisco f427a25a30 nr,gnb,mac: account for header space larger than 2 when packing PDSCH 3 years ago
Francisco ed2e88524f asn1,rrc_nr: implement to_json in setup_release_c 3 years ago
Francisco 9df6c6b936 sched,nr: ensure the ue_cfg_t passed to the scheduler in NR FDD mode has the correct harq delay 3 years ago
Andre Puschmann 255ddb1329 enb,gnb: add basic support for sgnb release procedure 
the procedure is currently started when the EUTRA UE object
is deleted (after RRC release) in order to clean-up the
ENDC resources on the gNB.
 3 years ago
Francisco ea324e8cbe nr,sched,test: update sched nr test to better reflect MAC-PHY FAPI 3 years ago
Andre Puschmann 7cbd3d50b7 mac_sch_pdu_nr,bsr: fix length check for BSR 
fix nasty bug where the length calucation for the LCID
was taking the bsr_format_nr_t that was having the same name.
 3 years ago
faluco 28bbaa7816 Blacklist TSAN issues from libusb and libuhd. 3 years ago
faluco 75af37bd4b Batch of race fixes when running the UE and ENB with UHD. 
Main fixes are in the UHD driver, fixing races and potential deadlocks.
 3 years ago
Alejandro Leal Conejos 1a64c6adad Enum fixes so clang 12 can build the repo 3 years ago
Carlo Galiotto f53e01cfa3 mac: apply changes by PR reviewers 
- reinstate write_lock on ue metrics
- change "rwlock" variable name in mac_nr.h

Signed-off-by: Carlo Galiotto <carlo@srs.io>
 3 years ago
Carlo Galiotto dc3e3a89f8 mac: update CQI in MAC with CSI reports from PHY 
Signed-off-by: Carlo Galiotto <carlo@srs.io>
 3 years ago
Xavier Arteaga a9904c2b64 Fix info format string 3 years ago
Xavier Arteaga a31a40184d Fix NR PRACH encoding 3 years ago
Xavier Arteaga 8bab12fb00 Added NR case to prach_test 3 years ago
Xavier Arteaga 3c4efba418 Added missing parameters to NR PHY configuration factory 3 years ago
Xavier Arteaga 5e1291b0c7 Fix PRACH detection sequence generation for NR 3 years ago
Francisco 11ee4ab9dd nr,gnb,rrc: fix scheduler FDD configuration 3 years ago
Francisco 4e49508d8f nr,gnb,mac: fix RAR encoding by resetting the RAR buffer 3 years ago
Francisco 1b595b6eff nr,gnb: if no nr cell is initiated, do not enable endc in the LTE RRC 3 years ago
Francisco 3721523810 pdcp,lte: fix debug logging in PDCP, to avoid segmentation fault and crash 3 years ago
Francisco 43b12b9ffb rrc,nr: transfer SSB config to both UE and NR scheduler 3 years ago
Carlo Galiotto 43a7d822fa stack,rrc: fix double removal of EPS bearer 
The EPS bearer was removed twice, causing an error in the logs.

Fix issue #3380

Signed-off-by: Carlo Galiotto <carlo@srs.io>
 3 years ago
Xavier Arteaga 7262287926 Zero power UCI bits is not an error but KO 3 years ago
Xavier Arteaga 4a327ad17d Consider CRC length when calculating real LDPC rate 3 years ago
Xavier Arteaga 5f17c46098 Modify periodic CSI time offset to UL slot 3 years ago
Xavier Arteaga bd186fab2e Fix CMake SSB frequency addition overflow 3 years ago
Xavier Arteaga be870d66ad More relaxed SSB measure assertions and reorder SSB test 3 years ago
Xavier Arteaga 4b77127ed6 Added missing SSB pattern to unit test 3 years ago
Xavier Arteaga 8bb23cc74a Correct CMake sign 3 years ago
Xavier Arteaga 52e00d6376 Fix PBCH encoding and added unit test 3 years ago
Xavier Arteaga 25bd0d6219 Added SSB pattern to/from string functions 3 years ago
Francisco 053877f489 rrc,nr: fix conversion from asn1 to phy cfg 3 years ago
Francisco 47e5e85449 refactor: clean unnecessary includes of the asn1/rrc_nr.h 3 years ago
Xavier Arteaga 1bdb1bb62d Store PUSCH CSI from PUSCH DMRS 3 years ago
Fabian Eckermann 420d6a6a98 enhanced and fixed some tests. 3 years ago
Bedran Karakoc 850606f20b Added deregistration (UE terminating) 3 years ago
Robert Falkenberg b0430ebfe2 rf_imp.c: fix segfault when closing RF device with no AGC thread 3 years ago
Francisco 3b79393974 sched,nr: fix default ue configuration when prach arrives 3 years ago
Xavier Arteaga d5b34696b4 Sepparate CSI report configuration from quantification and integrate in nr_phy_test with assertions 3 years ago
faluco 388b1e5d92 Fix data race in radio::is_start_of_burst. 3 years ago
faluco 7b0b76d58e Whitelist two lock order inversion TSAN issues that acquire a readlock. 3 years ago