5g-team
/
srsRAN_4G
mirror of https://github.com/pvnis/srsRAN_4G.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
10,035 Commits
2 Branches
0 Tags
243 MiB
fix-cqi
master
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '11ac8c2529'
${ noResults }
Commit Graph

144 Commits (11ac8c25294c75fb0a0a9a9f93072fa117117fba)

Author SHA1 Message Date
Pedro Alvarez 33735852a4 lib,rlc_am_nr: remove unecessary ternary operator. 3 years ago
Pedro Alvarez bd8c7f7c57 lib,rlc_am_nr: added max_hdr and min_hdr variables, that are configured based on SN length. Replaced magic numbers with said variables. 3 years ago
Pedro Alvarez 19268281c8 lib,rlc_am_nr: reduced logging level of some messages to debug. 3 years ago
Pedro Alvarez 5532c514ba lib,rlc_am_nr: added logging macros to make sure that the RB name is allways logged. 3 years ago
Pedro Alvarez f60259afb9 lib,rlc_am_nr: fixed multiple typos and deleted useless comments 3 years ago
Pedro Alvarez 9e6b852834 lib,rlc_am_nr: Added handle_full_sdu() and handle_segment_sdu() functions. Reduced duplicate code in handling SDU segments. 3 years ago
Pedro Alvarez 8afea13d9a lib,rlc_am_nr: added initial logic to support receiving PDU segments. 3 years ago
Pedro Alvarez aae1d9ad10 lib,rlc_am_nr: changed rlc_amd_nr_tx_sdu to use std::list to store 
segment infomation. Segment infomation incluses, SO and payload length.
 3 years ago
Pedro Alvarez 76c33c78a9 lib,rlc_am_nr: starting to add test for segmentation. Starting to add functions for creating new segments and segment continuation. 3 years ago
Pedro Alvarez f544cc7f7e lib,rlc_am_nr: fixed issue introduced with the changes of the header packing. 3 years ago
Pedro Alvarez 3e5b064a08 lib,rlc_am_nr: starting to add build_sdu_segment() function. 
Also adding write_header function that receives as argument uint8_t* so
we can write the header straight to the payload.
 3 years ago
Pedro Alvarez 72ba7503e5 lib,rlc_am_nr: make max tx queue size configurable. 3 years ago
Pedro Alvarez 57fc2470ad lib,rlc_am_lte: added some debug logging to t-PollRetranmission expiry and re-arming. 3 years ago
Pedro Alvarez ee4bf85209 lib,rlc_am_lte: check segment's polling requirements after updating the RETX queue. This makes sure that if the RETX and TX queues are empty after the last segment, polling is requested and the t-PollRetransmission is restarted 3 years ago
Pedro Alvarez b425316936 lib,rlc_am_nr: fixed tx_mod_base_nr(). Added unit test for inside_tx_window(). 3 years ago
Pedro Alvarez ab8577ff43 lib,rlc_am_nr: switched back to unsigned rx_mod_base. Removed if that is always true. 3 years ago
Pedro Alvarez fea7828d3e lib,rlc_am_nr: added struct to hold state variables. This is consistent 
with TX and makes it easier to make getter/setters.
 3 years ago
Pedro Alvarez bca9ef2454 lib,rlc_am_nr: made mod_nr configurable 3 years ago
Pedro Alvarez 665aea599c lib,rlc_am_nr: made sure that the return of rx_mod_base and tx_mod_base is signed by changing from a macro to an class method. 3 years ago
Pedro Alvarez 4b69af7ca2 lib,rlc_am_nr: possible fix for ubuntu 16.04 compilation warning 3 years ago
Pedro Alvarez 194fb4fabf lib,rlc_am_nr: stop status prohibit timer when a polling bit is received. 3 years ago
Pedro Alvarez a038c74cc0 Only run the status prohibit timer, if it has been set before. 3 years ago
Andre Puschmann f959c8c14a rlc_tm: remove warning when PDU can't be read 
MAC will call read_pdu() until RLC doesn't have any more data to send.
don't log a warning in this case.
 3 years ago
Pedro Alvarez 7460a9db69 lib,rlc_am_nr: check whether we exced nof_bytes in retx. changed build_retx_pdu API to receive unique_byte_buffer by ref. 3 years ago
Pedro Alvarez 1ca9804d84 lib,rlc_am_nr: make sure the return of make_byte_buffer() is checked 3 years ago
Pedro Alvarez b497d773ce lib,rlc_am_nr: Fixed some metrics calculation. Added more precise metrics checking to unit tests 3 years ago
Pedro Alvarez 5eaa56e6ba lib,rlc_am_nr: fix processing of ACKs 3 years ago
Pedro Alvarez b794593469 lib,rlc_am_nr: added processing of ACKs from status report 3 years ago
Pedro Alvarez ec93cc7238 rlc_am_nr: added logic to retx NACK'ed PDU. 3 years ago
Pedro Alvarez 473a45aae0 rlc_am_nr: fix buffer status calculation for retxs 3 years ago
Pedro Alvarez 63657ddfe6 Moved retx queue to rlc_am_data_structs, to enable it being re-used in RLC AM NR 3 years ago
Pedro Alvarez 4e1c713c14 rlc_am_nr: Enabled sending NACKs on status PDUs 
- Added some logic to only poll when PDU_WITHOUT_POLL > PollPDU
  - Fixed initalization of t-Reassembly
  - Fixed a bug in the packing of the status buffer.
Nacks now work for a single lost PDU.
 3 years ago
Pedro Alvarez a8453d644a Make sure t-reassembly triggers the status report 3 years ago
Pedro Alvarez 4c02407d3e Change the update of rx_next and rx_highest_status. 3 years ago
Pedro Alvarez 3f000f0472 Adding t_reassembly to RLC AM NR 3 years ago
Pedro Alvarez f09020e57f Adding unit test for lost SDUs. Fixing way rx_next and rx_status_highest are updated. 3 years ago
Pedro Alvarez c4f7e95e58 lib,rlc_am_nr: Make sure BSR callback is called 3 years ago
Pedro Alvarez ca13b6f3c4 Remove duplicate calculation of status report bytes 3 years ago
Pedro Alvarez 9e4631ee24 Added NR specific config struct for RLC AM. Added status prohibit timer. 3 years ago
Pedro Alvarez 5e8ab48c25 Wrote some logic to write SDU to PDCP 3 years ago
Pedro Alvarez 78d5ed1bc8 Fix get buffer state when status report is required 3 years ago
Pedro Alvarez a1c57eb473 Made sure that we don't try to read from empty queue. Modified some logging. 3 years ago
Pedro Alvarez 8ff545c423 Added RLC AM NR config structure. Added helpers to create RLC AM NR configs. Made it possible to create RLC AM NR entites in rlc.cc 3 years ago
Pedro Alvarez 1f8d0ab557 Fix generation of status report. 3 years ago
Pedro Alvarez 8ae4d379aa RLC AM NR: Added some logging functions to better debug the state and the received headers. Added initial handling of data pdu. Updating rx_next and rx_status_highest now. 3 years ago
Pedro Alvarez 2d29e4005c Starting to generate RLC NR status report. 
Starting to check if status pdu generation is correct.
 3 years ago
Pedro Alvarez be9bb344a4 Starting to add handle_data_pdu to RLC NR entity. 3 years ago
Pedro Alvarez 7121152cff Added basic functionality for read_pdu to RLC AM NR entity. 3 years ago
Pedro Alvarez 4196abafee Added get_buffer_status to RLC AM NR entity 3 years ago
Andre Puschmann 853d870c52 rlc_um_nr: fix SN wrap-around in a few places 3 years ago
Andre Puschmann 813adb9567 rlc_um_nr: reduce verbosity in info mode 
this will only print the most relevant messages in info mode.
also streamlines some messages with RLC AM entity.
 3 years ago
Andre Puschmann 1bec07a64a rlc_um_nr: fix starting/stopping of reassemble timer 3 years ago
Andre Puschmann 4187be3ff9 Revert "Revert "rlc_um_nr: reimplement update of RX_Next_Reassembly"" 
This reverts commit 296758e4ab.
 3 years ago
Pedro Alvarez f99d6bc224 lib,rlc: changed get_bearer() to get_lcid(). 3 years ago
Pedro Alvarez 123ac16653 rlc_am_nr: fixed issue with pointers from rx entity to tx entity 3 years ago
Pedro Alvarez f99e841421 Changed using a rlc_am_lte and rlc_am_nr entity, to a single rlc_am entity. 3 years ago
Pedro Alvarez eefedcfccd rlc_am_nr: renamed rlc_am_base to just rlc_am 3 years ago
Pedro Alvarez aef87d5366 rlc_am_nr: Change rlc_am_base to use unique_ptr to hold rx/tx entities 3 years ago
Pedro Alvarez 779eda98bd Temporarly silence unused variable warnings. 3 years ago
Pedro Alvarez e780eb5ab0 Fixed missing TM and RLC AM NR in mem_pool 3 years ago
Pedro Alvarez debb4a0c6b Refactored RLC AM segment pool for re-use in both LTE and NR 
Moved RLC AMD PDU definitions from rlc_am_lte.h to rlc_common.h to make them re-usable in both RLC LTE and RLC NR
 3 years ago
Pedro Alvarez 54be15e7a6 Moved write pdu to rlc_am_base::rlc_am_base_rx 3 years ago
Pedro Alvarez 476f9e1156 Changed logger initialization in RLC AM entities 3 years ago
Pedro Alvarez 022c51493b Refactored RLC AM NR/LTE Rx and Tx entities to use a rlc_am_base_rx/tx class. 
This was done to make it easier to share entity specific code between LTE and NR.
This removes the previously used templates.
 3 years ago
Pedro Alvarez b15f63f32f Added an RLC AM base class to avoid code duplication in the RLC AM NR entity. 
This class is based on a template that receives as argument the
rlc_am_*_tx/rx entities, so that those are different for LTE and NR.

Moved code from rlc_am_lte/nr entities so that they use the new base class.
 3 years ago
Andre Puschmann 951fea5f61 bearer_manager,rlc: reduce log level of message to warning level 
relevant for the UE when it receives 2nd reconfiguration it could
be that the bearers are added again. in this case the handling is fine
and everything will work as expected. No reason to log error.
 3 years ago
Pedro Alvarez d528d8af4c Added initial skeleton for RLC AM NR entity 3 years ago
Pedro Alvarez 2bb249bf09 Moved RLC AM LTE and NR packing functions to their own file. 3 years ago
Pedro Alvarez f93d428e49 Moved RLC AM data structures to their own file 3 years ago
Carlo Galiotto ba50bbfb76 rlc,rrc,nr: remove rb_type from rlc_um_config 
Signed-off-by: Carlo Galiotto <carlo@srs.io>
 3 years ago
Carlo Galiotto 9c2099f680 rrc,rlc,nr: fix RB label in RLC-NR for UE logs + .. 
add rb_type in rlc_um_config

Signed-off-by: Carlo Galiotto <carlo@srs.io>
 3 years ago
Carlo Galiotto d95c31d2de rlc,rrc,nr: fix rlc bearer string diplayed in logs 
Signed-off-by: Carlo Galiotto <carlo@srs.io>
 3 years ago
Andre Puschmann 296758e4ab Revert "rlc_um_nr: reimplement update of RX_Next_Reassembly" 
This reverts commit 5b025cfbf8.
 3 years ago
Andre Puschmann 6d0aafcf69 rlc_um_nr: fix has_missing_byte_segment() routine 
return true if rx_window contains segment of this SN
 3 years ago
Andre Puschmann 5b025cfbf8 rlc_um_nr: reimplement update of RX_Next_Reassembly 3 years ago
Andre Puschmann 2366dc286d rlc_um_nr: improve logging 3 years ago
Francisco 529e2bdf55 nr,rlc: call bsr update callback in RLC UM NR 3 years ago
Francisco 7ad1ad800e lte,enb,rlc: atomically compute DL buffer state and update the scheduler in the eNB 3 years ago
Andre Puschmann e2d26b5a8c rlc_um_nr: log PDU without SN if full SDU is transmitted 
PDUs that contain full SDUs don't have SNs, so the log should be
without it
 3 years ago
Ismael Gomez 80c48a8b01 rlc: protect access to tx_enabled 3 years ago
Francisco d60950d0f3 lte,enb,rlc: change new_tx and prio_tx variable names to snake_case and ensure they are zero initialized 3 years ago
Francisco 7aa5f731ce lte,enb,rlc: push to scheduler pending prioritized bytes both in case of RLC timer expiry or in case of new buffer state detection 3 years ago
Francisco 4a58c10f30 lte,enb,rlc: compute and forward to scheduler the number of bytes pending for retx and status pdu in RLC AM bearer 3 years ago
faluco fa351cd285 Rename functions that contain the unsafe word to nolock. 
The term "unsafe" does not clearly state that the function is not locking the shared date and it sounds "dangerous", so use a more explicit term.
 3 years ago
Andre Puschmann 59e1bca3f5 rlc_am_lte: fix potential crash when attempting to resize tx queue 
under some circumstances it could happen that the RLC is configured
when SDUs are already being written to the queue. The resize
operation of the underlying container would fail in this case.

Make sure to empty the queue before doing the resize.
 3 years ago
faluco 7b079fe289 Fix a data race in rlc TM metrics. 3 years ago
faluco edb7342aef Fix data race in rlc UM metrics. 3 years ago
faluco d009160ba6 Fix data race in the metrics of the rlc. 3 years ago
Andre Puschmann 7726acad41 rlc_am_lte: fix counting of retx of entire PDUs and PDU segments 
this patch fixes a bug discovered in a real network where the DL CQI of a
user degraded repidly in very short time. A relativly big RLC PDU that
was still sent with the good CQI in a big grant now needs to be split
across many tiny segments because the CQI degraded so much.

The retx couting for each transmitted segment caused the retx counter to
reach maxRetx quickly.

With this patch we do not increment the retx counter for each transmitted
PDU or segment of a PDU but instead only increment the counter when
a given SN is added to the retx queue. This can happen either:
a) if the SN is negativly acknowledged and was not already on the retx queue,
b) no new data is available for tx and a SN is selected for retx.

This is in accordance with TS 36.322 which handles retx counting in section
5.2.1 according to the above description.
 3 years ago
Andre Puschmann 4379c20eb9 rlc_am_lte: avoid locking of Rx mutex twice when generating status PDU 
call reset_status(), which now is an private method directly when
building a status PDU. No need for the Tx side to call Rx again.
 3 years ago
Andre Puschmann 53a7dc78ee rlc_am_lte: replace do_status boolean with atomic 
the do_status is queried from the Tx code frequently. To reduce
chances to delay the execution because the RLC Rx side is currently
holding the mutex we can use an atomic.
 3 years ago
Andre Puschmann f292042f66 rlc_am_lte: use try-lock when building status PDU 
the patch uses try-lock whenever a status PDU is tried
to be built. This makes sure that when the lock is currently
hold (e.g. by a thread processing rx PDUs) the generation
of the status PDUs is not taking too long and blocking the calling
thread. Instead the status PDU generation is deferred to the next
Tx opportunity.

It's a probabilistic approach that assumes that at some stage the
lock can in fact be acquired.
 3 years ago
Andre Puschmann a9d21696c5 rlc_am_lte: make number of RLC SDUs per PDU a compile-time parameter 
this allows to set the maximum number of RLC SDUs included
in a single PDU at compile time.
 3 years ago
Pedro Alvarez 171d5727be Moved lib RLC into it's own folder 3 years ago