5g-team
/
srsRAN_4G
mirror of https://github.com/pvnis/srsRAN_4G.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
4,125 Commits
2 Branches
0 Tags
243 MiB
fix-cqi
master
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '0094fbd191'
${ noResults }
Commit Graph

746 Commits (0094fbd191b60243dff1154bf777cc409ed2800e)

Author SHA1 Message Date
Pedro Alvarez d443604661 Merge next into gtp_cleanup_sn. Fixed some conflicts. 6 years ago
Andre Puschmann 96815e3a5f fix RLC AM handling of bigger MAC grants 
- fix concatenation and header reconstruction
 6 years ago
Andre Puschmann a6d9181881 fix RLC UM issue with very large MAC grants 6 years ago
Andre Puschmann bd6bb6903f fix block_queue pop and clear methods 
- pop was bzero'ing the popped object which
  causes for more complex objects like std::string
- clear wasn't actually emptying the queue
 6 years ago
Paul Sutton 0e4ab77fb0 GTPU cleanup, adding support for GTPU echo response (#265) 6 years ago
Andre Puschmann 0380c83175 remove RF device calibration settings from UE/eNB config 
- this remove RF calibration parameters that were an extra
  section in the eNB/UE config but were hardly used (only old bladeRF)
- a better way to pass those parameter would be through the
  device args in the normal rf config section
 6 years ago
Pedro Alvarez 28f377128b Making sure both Echo request and echo response are supported types. Echo response/request is working again. 6 years ago
Pedro Alvarez a2befbd949 Fix mistake in echo reply/response message type. 6 years ago
Pedro Alvarez e925ef0a42 Added some more debug infor to error prints. Making sure that packet is not sent from the eNB if there is an error in the GTP-U header packing. Fixed error in checking msg_type. 6 years ago
Pedro Alvarez c1f633c5c7 Dropping bitfields for now. Using #defines and uint8_t for the flags. 6 years ago
Pedro Alvarez ee04639337 Changed gtpu header flags to use a bitfield. Fixing compilation issues. 6 years ago
Andre Puschmann e64de7ec6b increase maximum buffer size to accomodate max TBS for Cat4 UEs 6 years ago
Pedro Alvarez 8dc029cc47 Merging next into NAS cleanup. 6 years ago
Pedro Alvarez b577c9ac8c Merge branch 'mnc_plmn_217' into next 6 years ago
Andre Puschmann 1985d7b37c fix byte_buffer copy and assignment ctor 6 years ago
Paul Sutton 569a7cbc94 GTPU cleanup, adding support for GTPU echo response 6 years ago
Andre Puschmann 07e42c1964 Merge branch 'rlc_am_subclass' into next 6 years ago
Pedro Alvarez c4a5af11d5 Fixed nibble order in mccmnc_to_plmn and plmn_to_mccmnc. Fixed corresponding PLMN test 6 years ago
Andre Puschmann 86e02921f0 fix regression in RLC base introduced during refactor causing eMBMS to fail 6 years ago
Andre Puschmann 22b4396c39 increase default tx_queue length for RLC UM and AM 
- With the current default tx queue length (16 SDUs) the BSR reported by the UE
  is too low if the size of the SDU is relativly small (e.g. 100 B).
  This effectivly causes the eNB to only allocate a small grant
  to the UE and thus reduces the UL throughput for small SDUs.
 6 years ago
Andre Puschmann ba87819ff1 retransmit random RLC AM PDU in case tx window is full 6 years ago
Andre Puschmann 34535c7efb fix RLC AM issues reported by clang-tidy 6 years ago
Andre Puschmann c9186f110c add log_filter dtor 6 years ago
Pedro Alvarez 49c44a2bd4 Moved int_helpers to lib so that the EPC can use those functions too. 6 years ago
Ismael Gomez 4068ad0064 Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next 6 years ago
Ismael Gomez d0c392e3dd Increase radio preamble buffer 6 years ago
Andre Puschmann b73f48f91e Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next 6 years ago
Ismael Gomez a0c87dcd15 Increased maximum burst samples 6 years ago
Andre Puschmann d981f129e0 Merge branch 'master' into next 6 years ago
Joseph Giovatto 2dddfa2aac added ability to track tput per bearer (#233) 
added mac_metrics for ul/dl harq retex counts
 6 years ago
Ismael Gomez 4a8d83721a Fix unnecessary memory usage in radio 6 years ago
IgnasJ 67c8bf1368 Fixes for srsLTE on ARM (#229) 
* Fix ARM NEON code compilation

Fix LV_HAVE_NEON defintion incorrecly used instead of HAVE_NEON in some places
Replace vqabsq_s32 with vabsq_f32 as vqabsq_s32 requires int type (fails to compile)
Fix missing NEON code path in mat.h in srslte_mat_2x2_mmse_csi_simd()

* Fix timestamp overflow issue on 32-bit systems with Soapy driver

'time_t secs' can be 32-bit on some systems. This causes calculation:
'secs * 1000000000;' to overflow.
 6 years ago
Ismael Gomez 0294923e2b Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next 6 years ago
Ismael Gomez 197d855d3f Fix issue #240 6 years ago
Xavier Arteaga a9fcd64b1f Fixes #259: Turbodecoder AVX2 instructions under LV_HAVE_AVX (instead of LV_HAVE_AVX2) 6 years ago
Andre Puschmann 184539b87d add LCID change API to UE interface, add method to reestablish single RLC bearer 6 years ago
Andre Puschmann 10bc01a7ae add API to change LCID of RLC bearers 6 years ago
Andre Puschmann 27459bf706 add API to change LCID of PDCP bearers 6 years ago
Andre Puschmann adbec3ee70 fix warning in common.h reported by clang-tidy 6 years ago
Ismael Gomez 243a7708d4 Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next 6 years ago
Ismael Gomez 826fbccf11 Fixed memory leaks in new decoder 6 years ago
Andre Puschmann c0899ddda9 refactor RLC AM, add tx/rx subclasses 6 years ago
Ismael Gomez bc9d342959
New optimization on the PHY for both UE and eNodeB (#251) 
* New parallel Turbodecoder implementation in SSE/AVX 16-bit and 8-bit

* Optimised UL Interleaver

* Include TB CRC calculation in FEC encoder

* New threading priorities
 6 years ago
Pedro Alvarez 0d80ae795b Added IMSI attach from unknown UE as a static function. 6 years ago
Pedro Alvarez 860e1b5491 Changing Handling of initial UE NAS messages to use static methods. Handling of unknown GUTI attach request should be ok. 6 years ago
Pedro Alvarez 93222f582c Changed authentication response to use downlink_nas_transport(). 6 years ago
Pedro Alvarez f6b8982939 Moved most of the GUTI attach to nas.cc. 6 years ago
Pedro Alvarez 1fba7f0afa Moved function that gets NAS type string to liblte_mme.cc 6 years ago
Pedro Alvarez 127e214b07 Added function to print string of NAS message type based on the message code. 6 years ago
Pedro Alvarez 7077530a29 Merge branch 'next' into nas_cleanup 6 years ago
Andre Puschmann f56592b0fe add getter for PDCP ul/dl counter 6 years ago
Andre Puschmann 91492b87ef add del_bearer for RLC/PDCP 6 years ago
Andre Puschmann 3b8371d090 add detach support (for switch off) 6 years ago
Andre Puschmann 2ef2baf72a increase size of buffer_pool 
- This solves an issue where in the worst-case an RLC AM instance would
  block because no new data nor control PDUs could be created to flush
  the buffers, effectivly causing a system stall.
- Happens in RLC AM stress test regularly with higher drop rates.
 6 years ago
Andre Puschmann 89df8f1582 unify RLC interface for writing SDUs w/ and w/o blocking 6 years ago
Andre Puschmann 3950629a75 remove obsolete RLC_MODE struct and move existing one to rlc_interface.h 6 years ago
Andre Puschmann ee5b055829 rename pdcp function for GW to is_lcid_enabled() 6 years ago
David Rupprecht bf4c84ef7b Fixed clear function in blocked queue (#199) 6 years ago
Andre Puschmann 6a2dc8677b remove obsolete header 6 years ago
Andre Puschmann b8438e9cc3 extend PDCP interface to allow non-blocking write of SDUs 6 years ago
Andre Puschmann 27d3d697df refactor RLC part#2 
- move metrics into entities
- make configure interface return true/false on success/failure
- add own srslte mode type
 6 years ago
Pedro Alvarez de8679b536 Continuing to cleanup. Starting to compile again. 6 years ago
Andre Puschmann 8e8fab027b refactor RLC base class 
- add rwlock
- put RLC entities into map
- general cleanup
 6 years ago
Pedro Alvarez f03967776a Continuing to clean nas.cc 6 years ago
Pedro Alvarez b25c12a084 Fixing nas.cc 6 years ago
Pedro Alvarez 85672d4a3f Fixing up s1ap.cc 6 years ago
Andre Puschmann b8b5ad9755 Merge branch 'pdcp_refactor' into next 6 years ago
Xavier Arteaga a21db86a78 SCH Codeblock CRC is computed at same time than parity 0 6 years ago
Andre Puschmann 47a8b1343f add rwlock to PDCP 6 years ago
Andre Puschmann 93c11e4416 turn PDCP array into map 6 years ago
Andre Puschmann b257204471 fix public PDCP interface 6 years ago
Andre Puschmann 31ba175b37 add public PDCP entity interface 6 years ago
Pedro Alvarez 3663d59920 Starting to add s1ap_interface_gtpc and s1ap_interface_nas. Adapting send initial context setup request accordingly. 6 years ago
Andre Puschmann be3b2fbc08
Merge pull request #239 from softwareradiosystems/epc_stacktrace 
Epc stacktrace
 6 years ago
Pedro Alvarez 84e7925f69 Fixed up a comment. 6 years ago
Pedro Alvarez 8017b792cf Changing SRSLTE_PHY_DEBUG back to SRSLTE_DEBUG. 6 years ago
Pedro Alvarez 597cf18b9d Changing common/debug.h to crash_handler.h 6 years ago
Andre Puschmann 291d80119c fix conflicts after merging 6 years ago
Ismael Gomez 3f38165827 Add log to pool deallocate 6 years ago
Ismael Gomez 2d5cdc4f35 Add log to pool deallocate 6 years ago
Ismael Gomez 5474f6d55f Add log to pool deallocate 6 years ago
Ismael Gomez 3cb9f51460 Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next 6 years ago
Andre Puschmann 936001aaf5 add blocking allocation to buffer_pool 6 years ago
Pedro Alvarez c3ef88e112 Fixing conflicts with next. 6 years ago
Andre Puschmann a9b023258c refactor RLC UM to have separate tx/rx objects 6 years ago
Andre Puschmann 4c59f52f9a
Merge pull request #237 from softwareradiosystems/epc_pcap 
Epc pcap
 6 years ago
Ismael Gomez 3122d8e959 RLC reestablish to re-enable tx_enabled 6 years ago
Ismael Gomez 75e8df2e9f Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next 6 years ago
Andre Puschmann 55b3b61ec1 Merge branch 'master' into next 6 years ago
Ismael Gomez bd5c1fd83a deallocate dedicatedInfoNAS in rrc 6 years ago
Ismael Gomez 074db8478c deallocate dedicatedInfoNAS in rrc 6 years ago
Pedro Alvarez bd43b6e937 Cleanup comment. 6 years ago
Andre Puschmann 9b894799f0 add support for ciphered authentication response 6 years ago
Pedro Alvarez ff49e56871 Starting to add s1ap_pcap class. 6 years ago
Pedro Alvarez 7aaa9a1789 Moved srslte_debug_handle_crash to common/debug.c 6 years ago
Pedro Alvarez 96786e96da Splitting the lib debug into phy and common debug. 6 years ago
Ismael Gomez 005fe87ae9 RLC reestablish to re-enable tx_enabled 6 years ago
Ismael Gomez 493706eab1 Incorrect default value in buffer pool 6 years ago
Ismael Gomez 2da9787907 Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next 6 years ago
Ismael Gomez a2615628aa Increase buffer pool size for enb 6 years ago
Pedro Alvarez b460ece601 Merge branch 'mbms_tun' into next 6 years ago
Andre Puschmann 355330dab9
Merge pull request #234 from softwareradiosystems/log_fix 
Log fix
 6 years ago
Ismael Gomez 85a7daa09d Move RLC buffer size to common 6 years ago
Ismael Gomez 589e569ce9
Changes on srsENB mutexing logic to fix general race condition and deadlock issues (#229) 
* fixed some issues with the UL scheduling

* Hack to fix UL scheduler

* minor fix

* Cleaned up code and fixed issue with the update_allocation function

* fixed the console printing in the enb

* log/console fix

* fixed the log print

* added a normalization factor

* RLC: entity uses dynamic instances. Simplified stop/reset/reestablish procedure. Added non-blocking interface

* Limit decimals in metrics stdout

* Changed mutexes to rwlock in RLC/RRC/MAC/PDCP to fix race conditions when removing users

* Fix deadlock bug for MIMO

* Remove headers

* Fix missing unlock causing overflows

* Do not decrease CQI when PUCCH (this is a temporal fix, requires to reduce the maximum MCS)

* Fix mutex unlock in worker

* Configurable RLC tx buffer. Default to 512 for enodeb

* Check NULL SDU in write_sdu()

* Protect RLC objects and tx_queue from being destroyed while using it

* Remove superfluous code

* Disable SIB logging

* Fix block_queue for enb
 6 years ago
Pedro Alvarez 0e135adc6f Starting to change gtpu_read_header and gtpu_write_header to lib. 6 years ago
Andre Puschmann 87fd218c72 remove unused cond variable in logger 6 years ago
Andre Puschmann 4deb251071 remove duplicate run-state variable in logger_file 6 years ago
jctallon 50589108c6 Mbms fixes (#225) 
* fixing the threading structure for mbms in the gtpu

fixing some leaks in pmch tests

fixing stack overflow caused by radio objext

* adding sib.conf.mbsfn.example

* creating a different thread_mch object for the gtpu

* Make mch_thread an isolated class

* excluding mbsfn subframes from noise estimation and cfo estimation

* fixing pdsch ue plotting to only show pmch constellation when mbsfn is activated.
 6 years ago
Andre Puschmann 05ede38ea6 remove obsolte config.h 6 years ago
Ismael Gomez 8c92f3fddc
Improvements and fixes on srsENB scheduler (#228) 6 years ago
Andre Puschmann 46436efb3b
Merge pull request #227 from softwareradiosystems/qci_epc 
Qci epc
 6 years ago
Andre Puschmann 1cba6b18ee
Merge pull request #221 from softwareradiosystems/op_vs_opc 
Op vs opc
 6 years ago
Xavier Arteaga f01f7b4945 Added Vector max abs SIMD function 6 years ago
Pedro Alvarez 0a6540d8bf Saving QCI into ESM context. Different QCIs should be working now. 6 years ago
Ismael Gomez e18ba937dc Limit uplink signal normalization to avoid clipping 6 years ago
Pedro Alvarez 66db3deeb4 Starting to add Bearer QoS parameter to create session request. 6 years ago
Pedro Alvarez 1b43c40422 Starting to add Bearer QoS IE to Create Session Request. 6 years ago
Pedro Alvarez f301bb6373 Merging next into op_vs_opc and resolving conflicts. 6 years ago
Andre Puschmann 064d7bd2dc use original UE establishment cause in S1AP initial UE message 6 years ago
Xavier Arteaga 5e4fb48184 Refactored CQI reporting logging in UE. Fixes #199 6 years ago
Andre Puschmann ecfa685dde add ctor to radio_multi, fix tearing down radio when not initialized 6 years ago
Andre Puschmann 01f6395d70 add option to force IMSI attach by not loading NAS ctxt from file 6 years ago
Pedro Alvarez 75c5e476f1 Added OPc option to UE. (needs testing.) 6 years ago
Pedro Alvarez 02bc1c9956 Revert "Starting to add OP/OPc support." 
This reverts commit 1766e11076.
 6 years ago
Pedro Alvarez e3d1cff4a3 Revert "Adding OPc option to security functions." 
This reverts commit 0eeb70bede.
 6 years ago
Pedro Alvarez 0eeb70bede Adding OPc option to security functions. 6 years ago
Pedro Alvarez 1766e11076 Starting to add OP/OPc support. 6 years ago
Ismael Gomez 6120f20290
Changes in RRC and S1AP to make enb more robust on UE add/rem operations. 
* Consolidated functions in S1AP

* Fixed ASAN in some GCC

* Stop quicker the enb

* Minor typo edit

* Fixed mutexing issues in RRC and possibly RLC/PDCP when adding/removing users
 6 years ago
Xavier Arteaga 301415a00a Fixed AGC out of bounds gain 7 years ago
Xavier Arteaga d9db80d17c Merge branch 'next' into pdsch-coworkers 7 years ago
Xavier Arteaga 6ab69b1d4c Added PDSCH coworkers 7 years ago
yagoda 4569247458 setting tx and rx mod in rlc um for mch to 1 7 years ago
Ismael Gomez 67e90d5a9b Code style: Use { } even in 1-line if 7 years ago
Ismael Gomez 863fe4fcd0 Revert "check in SRSLTE_CONFIG_DIR for configs by default" 
This reverts commit fb77cb87ca.
 7 years ago
Andre Puschmann fb77cb87ca check in SRSLTE_CONFIG_DIR for configs by default 7 years ago
Andre Puschmann 36c650399b rework app startup to search for config files in user's home directory 7 years ago
Ismael Gomez 0a2e9d7b8b Do not reset metrics in the hub 7 years ago
Xavier Arteaga 681b98ae50 Added vector CFO 7 years ago
Andre Puschmann cb15dee3d4 Merge branch 'embms_merge_final' into next 7 years ago
yagoda 54bdfd83ec adding support for mbsfn subframe configuration to pdsch examples 7 years ago
Ismael Gomez 4662b83fe9 Use bzero instead of {} for initializing structs 7 years ago
Andre Puschmann 61d525ea80 Merge branch 'next' into embms_merge_final 7 years ago
Andre Puschmann 234ec178b2 cleanup pdu.h 7 years ago
Ismael Gomez bad007cdd9 Increase/decrease nbytes counter inside mutexed queue 7 years ago
Ismael Gomez 467ba4e326 Average sampling offset estimate before adjusting timing to be more robust against EVA and ETU fading 7 years ago
yagoda 65f2747a8e removing mch handler in rlc, fixing embms autostart 7 years ago
yagoda d0cb214725 fixing sheduling issues and merge errors 7 years ago
yagoda 0ae22e0822 fixing scheduling issues for mbms 7 years ago
Andre Puschmann 9ca2b89282 fixing compile warnings 7 years ago
Andre Puschmann 9ce3be974a Merge branch 'next' into embms_merge_final 7 years ago
Andre Puschmann 2fb0dc62a0 refactor config for multicast RLC bearers 7 years ago
yagoda e4c3f0bc30 adding mbms-gw and mch generation tables 7 years ago
yagoda 49c3578f64 introducing embms support in common upper layer functions 7 years ago
yagoda ec918eab76 adding support for embms in common functions and interfaces 7 years ago
yagoda 9d7d6c9415 adding adaptations to the phy layer for mbms 7 years ago
Andre Puschmann a30ad8952c fix indent and simplify auth request packing 7 years ago
Andre Puschmann d0457211ad adding support for CHAP auth 7 years ago
Andre Puschmann 4dc2951d59 perform initial attach with ESM info transfer 7 years ago
Andre Puschmann 455d4491c5 make RES length variable when packing auth response 7 years ago
Andre Puschmann 3fe6dad323 adding hard SIM card support using PCSC 7 years ago
Andre Puschmann 51e093e611 Merge branch 'next' into rlc_updates 7 years ago
Ismael Gomez 040c33497d merged PR#189 and added check for non-empty queue in get size tail 7 years ago
Ismael Gomez 4515dd94ea Use blocking queue for RRC measurement fixes #193 7 years ago
Ismael Gomez 04609cd07d Check msg_queue size_tail_bytes existence of buffer 7 years ago
Ismael Gomez ba40a4de84 Add checks for when RLC TM queue is corrupted and reset it 7 years ago
Ismael Gomez f3f4528a2f Testing commit to force a Reestablishment 1s after CONNECT 7 years ago
Andre Puschmann 85028d2aed use pretty function name in buffer_pool debug 
- this avoids ambiguity between names, for example
  in reassemble_rx_sdus() for rlc_am an rlc_um
 7 years ago
Andre Puschmann 718a15608c dealloc SCH pdu in MAC instead of pdu_queue 
- this is basically e9fcb10c9e
  but with the counterpart in the eNB's MAC
 7 years ago
Andre Puschmann 595ed70cae Revert "Deallocate SCH pdu on demux instead of pdu_queue" 
This reverts commit e9fcb10c9e.
 7 years ago
Andre Puschmann 05696a5ca7 Merge branch 'next' into rlc_updates 7 years ago
Ismael Gomez e9fcb10c9e Deallocate SCH pdu on demux instead of pdu_queue 7 years ago
Ismael Gomez aa1724b8f3 Add missing-field-initializers flag and properly initialize structs 7 years ago
Joseph Giovatto ab1d9e98f3 Format and typelimit warnings (#169) 
* merge with origin 4fc7dbc3 8daa8346

* fixed whitespace diff

* added .gitignore

* added format warning flags to C_FLAGS
added typelimit check to C_FLAGS and CXX_CLAGS

* Revert "added format warning flags to C_FLAGS"

Apply to branch format_and_typelimt branch

This reverts commit bf7467e82e.

* check for format warnings to top level C_FLAGS
added typelimit warnings to top level C_FLAGS and CXX_FLAGS
beset effort attempt to remedy warnings
removed unused param names in hex_log baseclass methods due to multitude of unused-warnings
 7 years ago
Andre Puschmann 8fde56c582 unify rlc_am_stress test to allow also UM tests 7 years ago
Andre Puschmann a2f6166365 Merge branch 'next' into rlc_updates 7 years ago
Ismael Gomez 3ab74fb552 Exposed continuous TX mode to ue.conf 7 years ago
Ismael Gomez 3bf9ca6195 Send end of burst on idle 7 years ago
Ismael Gomez 785298e4c5 Merge branch 'next' of github.com:softwareradiosystems/srsLTE into next 7 years ago
Andre Puschmann d8bfd2713c initialize byte_buffer content in ctors 7 years ago
Ismael Gomez 62787bdd41 Remove unused include 7 years ago
Ismael Gomez b237d6063e Align header buffer to 8-byte boundary as expected by S1AP pack/unpack functions 7 years ago
Ismael Gomez 208871b251 Changed liblte structs to simple structs and initialized nas/rrc uses. 7 years ago
Ismael Gomez ab78eb6d58 Process BCCH from pdu_process thread. Process PCCH from new thread in RRC 7 years ago
Xavier Arteaga 0bc3be7abb Added DL CSI decoding to TM2 and TM3 7 years ago
Ismael Gomez 384e0f8649 Fixed UL interleaver (missing SIMD deinterleaver) 7 years ago
Ismael Gomez ffb8337be7 Merge branch 'next' into sync_states 7 years ago
Xavier Arteaga 15173c5c30 Added gaussian filter configuration options in srsue.conf 7 years ago
Xavier Arteaga d0d5893a1c New DL channel noise estimator based on RS 7 years ago
Ismael Gomez edd9cbf4dc Merge branch 'next' into sync_states 7 years ago
Andre Puschmann 27165b4fe2 Merge branch 'next' into rlc_updates 7 years ago
Andre Puschmann e7a268d79b fix SIMD compile issue on NEON 7 years ago
Andre Puschmann b298d3d3f9 add missing const keyword to log_filter's members 7 years ago
Andre Puschmann e76fe75c22 add missing const keyword to log_filter's members 7 years ago
Andre Puschmann 61a24cbd4a Merge branch 'next' into rlc_updates 7 years ago
Andre Puschmann dd76f85313 Merge branch 'master' into next 7 years ago
Joseph Giovatto 802f8b716f set msg and hex buf to const * 7 years ago
Joseph Giovatto 4e05266ea8 added printf format check for hex logs 7 years ago
Andre Puschmann 2dcd6695bc remove obsolete config.h 7 years ago
David Rupprecht 06d4559294 Change include path absolut to project dir 7 years ago
David Rupprecht 9d71bec7b6 Unified include guards 7 years ago