From cf55eb4c4fc636b1a5a9bf8e2765183dda63cca7 Mon Sep 17 00:00:00 2001 From: Xavier Arteaga Date: Wed, 4 Nov 2020 17:55:16 +0100 Subject: [PATCH] Improved comments --- lib/include/srslte/phy/common/phy_common_nr.h | 13 ++++++++++--- lib/include/srslte/phy/fec/cbsegm.h | 18 +++++++++--------- lib/src/phy/phch/ra_nr.c | 2 +- 3 files changed, 20 insertions(+), 13 deletions(-) diff --git a/lib/include/srslte/phy/common/phy_common_nr.h b/lib/include/srslte/phy/common/phy_common_nr.h index 31b1445d5..84064953c 100644 --- a/lib/include/srslte/phy/common/phy_common_nr.h +++ b/lib/include/srslte/phy/common/phy_common_nr.h @@ -141,11 +141,18 @@ typedef enum SRSLTE_API { /** * @brief DCI formats - * @remark Described in TS 38.331 V15.10.0 Section PDSCH-TimeDomainResourceAllocationList + * @remark Described in TS 38.212 V15.9.0 Section 7.3.1 DCI formats */ typedef enum SRSLTE_API { - srslte_dci_format_nr_1_0 = 0, - srslte_dci_format_nr_1_1, + srslte_dci_format_nr_0_0 = 0, ///< @brief Scheduling of PUSCH in one cell + srslte_dci_format_nr_0_1, ///< @brief Scheduling of PUSCH in one cell + srslte_dci_format_nr_1_0, ///< @brief Scheduling of PDSCH in one cell + srslte_dci_format_nr_1_1, ///< @brief Scheduling of PDSCH in one cell + srslte_dci_format_nr_2_0, ///< @brief Notifying a group of UEs of the slot format + srslte_dci_format_nr_2_1, ///< @brief Notifying a group of UEs of the PRB(s) and OFDM symbol(s) where UE may assume no + ///< transmission is intended for the UE + srslte_dci_format_nr_2_2, ///< @brief Transmission of TPC commands for PUCCH and PUSCH + srslte_dci_format_nr_2_3 ///< @brief Transmission of a group of TPC commands for SRS transmissions by one or more UEs } srslte_dci_format_nr_t; /** diff --git a/lib/include/srslte/phy/fec/cbsegm.h b/lib/include/srslte/phy/fec/cbsegm.h index 72602b7b8..ab87960d5 100644 --- a/lib/include/srslte/phy/fec/cbsegm.h +++ b/lib/include/srslte/phy/fec/cbsegm.h @@ -30,15 +30,15 @@ #define SRSLTE_NOF_TC_CB_SIZES 188 typedef struct SRSLTE_API { - uint32_t F; /*!< \brief %Total number of the transport block bit */ - uint32_t C; /*!< \brief %Total number of code blocks */ - uint32_t K1; /*!< \brief %Code block size 1 */ - uint32_t K2; /*!< \brief %Code block size 2 */ - uint32_t K1_idx; /*!< \brief %Code block size index 1 */ - uint32_t K2_idx; /*!< \brief %Code block size index 2 */ - uint32_t C1; /*!< \brief %Number of code blocks of size 1 */ - uint32_t C2; /*!< \brief %Number of code blocks of size 2 */ - uint32_t tbs; /*!< \brief %Actual transport block size */ + uint32_t F; ///< \brief Total number of the transport block bit + uint32_t C; ///< \brief Total number of code blocks + uint32_t K1; ///< \brief Code block size 1 + uint32_t K2; ///< \brief Code block size 2 + uint32_t K1_idx; ///< \brief Code block size index 1 + uint32_t K2_idx; ///< \brief Code block size index 2 + uint32_t C1; ///< \brief Number of code blocks of size 1 + uint32_t C2; ///< \brief Number of code blocks of size 2 + uint32_t tbs; ///< \brief Actual transport block size } srslte_cbsegm_t; /** diff --git a/lib/src/phy/phch/ra_nr.c b/lib/src/phy/phch/ra_nr.c index 8ecf8d5fc..8edfde1d9 100644 --- a/lib/src/phy/phch/ra_nr.c +++ b/lib/src/phy/phch/ra_nr.c @@ -84,7 +84,7 @@ static const mcs_entry_t ra_nr_table2[RA_NR_MCS_SIZE_TABLE2] = { {SRSLTE_MOD_256QAM, 948, 7.4063}}; /** - * TS 38.214 V15.10.0 Table 5.1.3.1-2: MCS index table 2 for PDSCH + * TS 38.214 V15.10.0 Table 5.1.3.1-3: MCS index table 3 for PDSCH */ static const mcs_entry_t ra_nr_table3[RA_NR_MCS_SIZE_TABLE3] = { {SRSLTE_MOD_QPSK, 30, 0.0586}, {SRSLTE_MOD_QPSK, 40, 0.0781}, {SRSLTE_MOD_QPSK, 50, 0.0977},