From fcedeb027821b2fed8b8e9ac0668870d2bc61da5 Mon Sep 17 00:00:00 2001 From: Merlin Chlosta Date: Mon, 22 Jan 2018 19:12:02 +0100 Subject: [PATCH 001/134] Add APN to config and PDN connectivity request --- lib/include/srslte/common/interfaces_common.h | 9 ++++++--- srsue/hdr/ue_base.h | 1 + srsue/src/main.cc | 1 + srsue/src/ue.cc | 3 ++- srsue/src/upper/nas.cc | 9 ++++++++- srsue/ue.conf.example | 9 +++++++++ 6 files changed, 27 insertions(+), 5 deletions(-) diff --git a/lib/include/srslte/common/interfaces_common.h b/lib/include/srslte/common/interfaces_common.h index 1ddcb5150..e7de90ea1 100644 --- a/lib/include/srslte/common/interfaces_common.h +++ b/lib/include/srslte/common/interfaces_common.h @@ -30,6 +30,7 @@ #include "srslte/common/timers.h" #include "srslte/common/security.h" #include "srslte/asn1/liblte_rrc.h" +#include namespace srslte { @@ -37,11 +38,13 @@ namespace srslte { class srslte_nas_config_t { public: - srslte_nas_config_t(uint32_t lcid_ = 0) - :lcid(lcid_) + srslte_nas_config_t(uint32_t lcid_ = 0, std::string apn_ = "") + :lcid(lcid_), + apn(apn_) {} - uint32_t lcid; + uint32_t lcid; + std::string apn; }; diff --git a/srsue/hdr/ue_base.h b/srsue/hdr/ue_base.h index 9674a1486..acedb51b0 100644 --- a/srsue/hdr/ue_base.h +++ b/srsue/hdr/ue_base.h @@ -126,6 +126,7 @@ typedef struct { usim_args_t usim; rrc_args_t rrc; std::string ue_category_str; + std::string apn; expert_args_t expert; }all_args_t; diff --git a/srsue/src/main.cc b/srsue/src/main.cc index 0f668b927..cdd31e13d 100644 --- a/srsue/src/main.cc +++ b/srsue/src/main.cc @@ -82,6 +82,7 @@ void parse_args(all_args_t *args, int argc, char *argv[]) { "UECapabilityInformation message. Default 0xe6041c00") ("rrc.ue_category", bpo::value(&args->ue_category_str)->default_value("4"), "UE Category (1 to 5)") + ("nas.apn", bpo::value(&args->apn)->default_value(""), "Set Access Point Name (APN) for data services") ("pcap.enable", bpo::value(&args->pcap.enable)->default_value(false), "Enable MAC packet captures for wireshark") ("pcap.filename", bpo::value(&args->pcap.filename)->default_value("ue.pcap"), "MAC layer capture filename") diff --git a/srsue/src/ue.cc b/srsue/src/ue.cc index 78988ef9e..66a40ce22 100644 --- a/srsue/src/ue.cc +++ b/srsue/src/ue.cc @@ -195,7 +195,8 @@ bool ue::init(all_args_t *args_) pdcp.init(&rlc, &rrc, &gw, &pdcp_log, 0 /* RB_ID_SRB0 */, SECURITY_DIRECTION_UPLINK); usim.init(&args->usim, &usim_log); - nas.init(&usim, &rrc, &gw, &nas_log, 1 /* RB_ID_SRB1 */); + srslte_nas_config_t nas_cfg(1, args->apn); /* RB_ID_SRB1 */ + nas.init(&usim, &rrc, &gw, &nas_log, nas_cfg); gw.init(&pdcp, &nas, &gw_log, 3 /* RB_ID_DRB1 */); gw.set_netmask(args->expert.ip_netmask); diff --git a/srsue/src/upper/nas.cc b/srsue/src/upper/nas.cc index 9a9015af7..b574de8d7 100644 --- a/srsue/src/upper/nas.cc +++ b/srsue/src/upper/nas.cc @@ -884,7 +884,14 @@ void nas::gen_pdn_connectivity_request(LIBLTE_BYTE_MSG_STRUCT *msg) { // Set the optional flags pdn_con_req.esm_info_transfer_flag_present = false; //FIXME: Check if this is needed - pdn_con_req.apn_present = false; + if (cfg.apn == "") { + pdn_con_req.apn_present = false; + } else { + pdn_con_req.apn_present = true; + LIBLTE_MME_ACCESS_POINT_NAME_STRUCT apn; + apn.apn = cfg.apn; + pdn_con_req.apn = apn; + } pdn_con_req.protocol_cnfg_opts_present = false; pdn_con_req.device_properties_present = false; diff --git a/srsue/ue.conf.example b/srsue/ue.conf.example index 347822072..1b87853fa 100644 --- a/srsue/ue.conf.example +++ b/srsue/ue.conf.example @@ -118,6 +118,15 @@ imei = 353490069873319 #ue_category = 4 #feature_group = 0xe6041c00 +##################################################################### +# NAS configuration +# +# apn: Set Access Point Name (APN) +##################################################################### +[nas] +# apn = internetinternet + + [gui] enable = false From 148c0a97bdcad3b208146d862a40552ab9ea8c9a Mon Sep 17 00:00:00 2001 From: FabianEckermann Date: Thu, 15 Feb 2018 16:42:26 +0100 Subject: [PATCH 002/134] Read MME APN from epc config --- srsepc/epc.conf.example | 2 + srsepc/hdr/mme/s1ap_common.h | 1 + srsepc/src/main.cc | 3 ++ srsepc/src/mme/mme_gtpc.cc | 2 +- srsepc/src/mme/s1ap_nas_transport.cc | 55 +++++++++++++++------------- 5 files changed, 37 insertions(+), 26 deletions(-) diff --git a/srsepc/epc.conf.example b/srsepc/epc.conf.example index d90e3a6ef..b32a6984a 100644 --- a/srsepc/epc.conf.example +++ b/srsepc/epc.conf.example @@ -11,6 +11,7 @@ # mcc: Mobile Country Code # mnc: Mobile Network Code # mme_bindx_addr: IP subnet to listen for eNB S1 connnections +# apn: Set Access Point Name (APN) # ##################################################################### [mme] @@ -20,6 +21,7 @@ tac = 0x0007 mcc = 001 mnc = 01 mme_bind_addr = 127.0.1.100 +apn = test123 ##################################################################### # HSS configuration diff --git a/srsepc/hdr/mme/s1ap_common.h b/srsepc/hdr/mme/s1ap_common.h index f5462ad65..9a7d72ce5 100644 --- a/srsepc/hdr/mme/s1ap_common.h +++ b/srsepc/hdr/mme/s1ap_common.h @@ -49,6 +49,7 @@ typedef struct{ uint16_t mnc; // BCD-coded with 0xF filler std::string mme_bind_addr; std::string mme_name; + std::string mme_apn; } s1ap_args_t; typedef struct{ diff --git a/srsepc/src/main.cc b/srsepc/src/main.cc index 89ae4c83e..1736279c4 100644 --- a/srsepc/src/main.cc +++ b/srsepc/src/main.cc @@ -81,6 +81,7 @@ parse_args(all_args_t *args, int argc, char* argv[]) { string mcc; string mnc; string mme_bind_addr; + string mme_apn; string spgw_bind_addr; string sgi_if_addr; string hss_db_file; @@ -105,6 +106,7 @@ parse_args(all_args_t *args, int argc, char* argv[]) { ("mme.mcc", bpo::value(&mcc)->default_value("001"), "Mobile Country Code") ("mme.mnc", bpo::value(&mnc)->default_value("01"), "Mobile Network Code") ("mme.mme_bind_addr", bpo::value(&mme_bind_addr)->default_value("127.0.0.1"),"IP address of MME for S1 connnection") + ("mme.apn", bpo::value(&mme_apn)->default_value(""), "Set Access Point Name (APN) for data services") ("hss.db_file", bpo::value(&hss_db_file)->default_value("ue_db.csv"),".csv file that stores UE's keys") ("hss.auth_algo", bpo::value(&hss_auth_algo)->default_value("milenage"),"HSS uthentication algorithm.") ("spgw.gtpu_bind_addr", bpo::value(&spgw_bind_addr)->default_value("127.0.0.1"),"IP address of SP-GW for the S1-U connection") @@ -204,6 +206,7 @@ parse_args(all_args_t *args, int argc, char* argv[]) { } args->mme_args.s1ap_args.mme_bind_addr = mme_bind_addr; + args->mme_args.s1ap_args.mme_apn = mme_apn; args->spgw_args.gtpu_bind_addr = spgw_bind_addr; args->spgw_args.sgi_if_addr = sgi_if_addr; args->hss_args.db_file = hss_db_file; diff --git a/srsepc/src/mme/mme_gtpc.cc b/srsepc/src/mme/mme_gtpc.cc index 4b396f7a8..0c36541c0 100644 --- a/srsepc/src/mme/mme_gtpc.cc +++ b/srsepc/src/mme/mme_gtpc.cc @@ -118,7 +118,7 @@ mme_gtpc::send_create_session_request(uint64_t imsi, uint32_t mme_ue_s1ap_id) m_mme_gtpc_log->console("Creating Session Response -- IMSI: %015lu \n", imsi); m_mme_gtpc_log->console("Creating Session Response -- MME control TEID: %lu \n", cs_req->sender_f_teid.teid); // APN - memcpy(cs_req->apn, "internet", sizeof("internet")); + strcpy(cs_req->apn, m_s1ap->m_s1ap_args.mme_apn.c_str()); // RAT Type //cs_req->rat_type = srslte::GTPC_RAT_TYPE::EUTRAN; diff --git a/srsepc/src/mme/s1ap_nas_transport.cc b/srsepc/src/mme/s1ap_nas_transport.cc index d4f0702de..0cd646136 100644 --- a/srsepc/src/mme/s1ap_nas_transport.cc +++ b/srsepc/src/mme/s1ap_nas_transport.cc @@ -114,7 +114,7 @@ s1ap_nas_transport::handle_initial_ue_message(LIBLTE_S1AP_MESSAGE_INITIALUEMESSA m_pool->deallocate(nas_msg); return false; } - handle_nas_attach_request(enb_ue_s1ap_id, attach_req,pdn_con_req,reply_buffer,reply_flag, enb_sri); + handle_nas_attach_request(enb_ue_s1ap_id, attach_req, pdn_con_req, reply_buffer, reply_flag, enb_sri); } else if(msg_type == LIBLTE_MME_SECURITY_HDR_TYPE_SERVICE_REQUEST) { @@ -201,7 +201,7 @@ s1ap_nas_transport::handle_uplink_nas_transport(LIBLTE_S1AP_MESSAGE_UPLINKNASTRA if(*reply_flag == true) { m_s1ap_log->info("DL NAS: Sent Downlink NAS message\n"); - m_s1ap_log->console("DL NAS: Sent Downlink NAs Message\n"); + m_s1ap_log->console("DL NAS: Sent Downlink NAS Message\n"); } m_pool->deallocate(nas_msg); @@ -326,8 +326,8 @@ s1ap_nas_transport::handle_nas_imsi_attach_request(uint32_t enb_ue_s1ap_id, //Send reply to eNB *reply_flag = true; - m_s1ap_log->info("Downlink NAS: Sending Athentication Request\n"); - m_s1ap_log->console("Downlink NAS: Sending Athentication Request\n"); + m_s1ap_log->info("Downlink NAS: Sending Authentication Request\n"); + m_s1ap_log->console("Downlink NAS: Sending Authentication Request\n"); return true; } @@ -358,7 +358,7 @@ s1ap_nas_transport::handle_nas_guti_attach_request(uint32_t enb_ue_s1ap_id, memcpy(&ue_ctx.ms_network_cap, &attach_req.ms_network_cap, sizeof(LIBLTE_MME_MS_NETWORK_CAPABILITY_STRUCT)); } uint8_t eps_bearer_id = pdn_con_req.eps_bearer_id; //TODO: Unused - ue_ctx.procedure_transaction_id = pdn_con_req.proc_transaction_id; + ue_ctx.procedure_transaction_id = pdn_con_req.proc_transaction_id; //Save whether ESM information transfer is necessary ue_ctx.eit = pdn_con_req.esm_info_transfer_flag_present; @@ -467,7 +467,7 @@ s1ap_nas_transport::handle_nas_authentication_response(srslte::byte_buffer_t *na m_s1ap_log->console("UE Authentication Rejected.\n"); m_s1ap_log->warning("UE Authentication Rejected.\n"); - //Send back Athentication Reject + //Send back Authentication Reject pack_authentication_reject(reply_buffer, ue_ctx->enb_ue_s1ap_id, ue_ctx->mme_ue_s1ap_id); *reply_flag = true; m_s1ap_log->console("Downlink NAS: Sending Authentication Reject.\n"); @@ -511,6 +511,7 @@ s1ap_nas_transport::handle_nas_security_mode_complete(srslte::byte_buffer_t *nas { pack_esm_information_request(reply_buffer, ue_ctx); m_s1ap_log->console("Sending ESM information request\n"); + m_s1ap_log->info("Sending ESM information request\n"); *reply_flag = true; } else @@ -532,7 +533,7 @@ s1ap_nas_transport::handle_nas_attach_complete(srslte::byte_buffer_t *nas_msg, u srslte::byte_buffer_t *esm_msg = m_pool->allocate(); LIBLTE_MME_ACTIVATE_DEFAULT_EPS_BEARER_CONTEXT_ACCEPT_MSG_STRUCT act_bearer; - m_s1ap_log->info_hex(nas_msg->msg, nas_msg->N_bytes, "NAS Attach complte"); + m_s1ap_log->info_hex(nas_msg->msg, nas_msg->N_bytes, "NAS Attach complete"); //Get NAS authentication response LIBLTE_ERROR_ENUM err = liblte_mme_unpack_attach_complete_msg((LIBLTE_BYTE_MSG_STRUCT *) nas_msg, &attach_comp); @@ -548,7 +549,7 @@ s1ap_nas_transport::handle_nas_attach_complete(srslte::byte_buffer_t *nas_msg, u } m_s1ap_log->console("Unpacked Attached Complete Message\n"); - m_s1ap_log->console("Unpacked Activavate Default EPS Bearer message. EPS Bearer id %d\n",act_bearer.eps_bearer_id); + m_s1ap_log->console("Unpacked Activate Default EPS Bearer message. EPS Bearer id %d\n",act_bearer.eps_bearer_id); //ue_ctx->erabs_ctx[act_bearer->eps_bearer_id].enb_fteid; if(act_bearer.eps_bearer_id < 5 || act_bearer.eps_bearer_id > 15) { @@ -576,6 +577,11 @@ s1ap_nas_transport::handle_esm_information_response(srslte::byte_buffer_t *nas_m m_s1ap_log->info("ESM Info: APN %s\n",esm_info_resp.eps_bearer_id); m_s1ap_log->console("ESM Info: APN %s\n",esm_info_resp.eps_bearer_id); } + if(esm_info_resp.protocol_cnfg_opts_present) + { + m_s1ap_log->info("ESM Info: %d Protocol Configuration Options %s\n",esm_info_resp.protocol_cnfg_opts.N_opts); + m_s1ap_log->console("ESM Info: %d Protocol Configuration Options %s\n",esm_info_resp.protocol_cnfg_opts.N_opts); + } //FIXME The packging of GTP-C messages is not ready. //This means that GTP-U tunnels are created with function calls, as opposed to GTP-C. @@ -794,8 +800,8 @@ s1ap_nas_transport::pack_authentication_request(srslte::byte_buffer_t *reply_msg LIBLTE_ERROR_ENUM err = liblte_mme_pack_authentication_request_msg(&auth_req, (LIBLTE_BYTE_MSG_STRUCT *) nas_buffer); if(err != LIBLTE_SUCCESS) { - m_s1ap_log->error("Error packing Athentication Request\n"); - m_s1ap_log->console("Error packing Athentication Request\n"); + m_s1ap_log->error("Error packing Authentication Request\n"); + m_s1ap_log->console("Error packing Authentication Request\n"); return false; } @@ -807,8 +813,8 @@ s1ap_nas_transport::pack_authentication_request(srslte::byte_buffer_t *reply_msg err = liblte_s1ap_pack_s1ap_pdu(&tx_pdu, (LIBLTE_BYTE_MSG_STRUCT *) reply_msg); if(err != LIBLTE_SUCCESS) { - m_s1ap_log->error("Error packing Athentication Request\n"); - m_s1ap_log->console("Error packing Athentication Request\n"); + m_s1ap_log->error("Error packing Authentication Request\n"); + m_s1ap_log->console("Error packing Authentication Request\n"); return false; } @@ -845,8 +851,8 @@ s1ap_nas_transport::pack_authentication_reject(srslte::byte_buffer_t *reply_msg, LIBLTE_ERROR_ENUM err = liblte_mme_pack_authentication_reject_msg(&auth_rej, (LIBLTE_BYTE_MSG_STRUCT *) nas_buffer); if(err != LIBLTE_SUCCESS) { - m_s1ap_log->error("Error packing Athentication Reject\n"); - m_s1ap_log->console("Error packing Athentication Reject\n"); + m_s1ap_log->error("Error packing Authentication Reject\n"); + m_s1ap_log->console("Error packing Authentication Reject\n"); return false; } @@ -858,8 +864,8 @@ s1ap_nas_transport::pack_authentication_reject(srslte::byte_buffer_t *reply_msg, err = liblte_s1ap_pack_s1ap_pdu(&tx_pdu, (LIBLTE_BYTE_MSG_STRUCT *) reply_msg); if(err != LIBLTE_SUCCESS) { - m_s1ap_log->error("Error packing Dw NAS Transport: Athentication Reject\n"); - m_s1ap_log->console("Error packing Downlink NAS Transport: Athentication Reject\n"); + m_s1ap_log->error("Error packing Dw NAS Transport: Authentication Reject\n"); + m_s1ap_log->console("Error packing Downlink NAS Transport: Authentication Reject\n"); return false; } @@ -948,7 +954,7 @@ s1ap_nas_transport::pack_security_mode_command(srslte::byte_buffer_t *reply_msg, LIBLTE_ERROR_ENUM err = liblte_mme_pack_security_mode_command_msg(&sm_cmd,sec_hdr_type, ue_ctx->security_ctxt.dl_nas_count,(LIBLTE_BYTE_MSG_STRUCT *) nas_buffer); if(err != LIBLTE_SUCCESS) { - m_s1ap_log->console("Error packing Athentication Request\n"); + m_s1ap_log->console("Error packing Authentication Request\n"); return false; } @@ -982,7 +988,7 @@ s1ap_nas_transport::pack_security_mode_command(srslte::byte_buffer_t *reply_msg, err = liblte_s1ap_pack_s1ap_pdu(&tx_pdu, (LIBLTE_BYTE_MSG_STRUCT *) reply_msg); if(err != LIBLTE_SUCCESS) { - m_s1ap_log->console("Error packing Athentication Request\n"); + m_s1ap_log->console("Error packing Authentication Request\n"); return false; } m_s1ap_log->debug_hex(reply_msg->msg, reply_msg->N_bytes, "Security Mode Command: "); @@ -1015,7 +1021,7 @@ s1ap_nas_transport::pack_esm_information_request(srslte::byte_buffer_t *reply_ms dw_nas->SubscriberProfileIDforRFP_present=false; LIBLTE_MME_ESM_INFORMATION_REQUEST_MSG_STRUCT esm_info_req; - esm_info_req.eps_bearer_id=0; + esm_info_req.eps_bearer_id = 0; esm_info_req.proc_transaction_id = ue_ctx->procedure_transaction_id; uint8_t sec_hdr_type=2; @@ -1048,8 +1054,8 @@ s1ap_nas_transport::pack_esm_information_request(srslte::byte_buffer_t *reply_ms err = liblte_s1ap_pack_s1ap_pdu(&tx_pdu, (LIBLTE_BYTE_MSG_STRUCT *) reply_msg); if(err != LIBLTE_SUCCESS) { - m_s1ap_log->error("Error packing Dw NAS Transport: Athentication Reject\n"); - m_s1ap_log->console("Error packing Downlink NAS Transport: Athentication Reject\n"); + m_s1ap_log->error("Error packing Dw NAS Transport: Authentication Reject\n"); + m_s1ap_log->console("Error packing Downlink NAS Transport: Authentication Reject\n"); return false; } @@ -1140,8 +1146,7 @@ s1ap_nas_transport::pack_attach_accept(ue_ctx_t *ue_ctx, LIBLTE_S1AP_E_RABTOBESE act_def_eps_bearer_context_req.eps_qos.mbr_dl_ext = 250; //FIXME check //set apn //act_def_eps_bearer_context_req.apn - std::string apn("test123"); - act_def_eps_bearer_context_req.apn.apn = apn; //FIXME + act_def_eps_bearer_context_req.apn.apn = m_s1ap->m_s1ap_args.mme_apn; act_def_eps_bearer_context_req.proc_transaction_id = ue_ctx->procedure_transaction_id; //FIXME //Set DNS server @@ -1230,8 +1235,8 @@ s1ap_nas_transport::pack_identity_request(srslte::byte_buffer_t *reply_msg, uint err = liblte_s1ap_pack_s1ap_pdu(&tx_pdu, (LIBLTE_BYTE_MSG_STRUCT *) reply_msg); if(err != LIBLTE_SUCCESS) { - m_s1ap_log->error("Error packing Dw NAS Transport: Athentication Reject\n"); - m_s1ap_log->console("Error packing Downlink NAS Transport: Athentication Reject\n"); + m_s1ap_log->error("Error packing Dw NAS Transport: Authentication Reject\n"); + m_s1ap_log->console("Error packing Downlink NAS Transport: Authentication Reject\n"); return false; } From 7e091b8e6057f583ef6337777b1fbdc90d9325db Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Fri, 23 Feb 2018 10:12:44 +0100 Subject: [PATCH 003/134] Fix Underflow when PHY Reset --- srsue/src/phy/phy.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/srsue/src/phy/phy.cc b/srsue/src/phy/phy.cc index 4417beb86..cf8ae33f8 100644 --- a/srsue/src/phy/phy.cc +++ b/srsue/src/phy/phy.cc @@ -366,7 +366,6 @@ void phy::reset() workers[i].reset(); } workers_common.reset(); - usleep(4000); workers_common.reset_ul(); } From 8474c6e3aac854bd7320158741fd9110b192d0ec Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Fri, 23 Feb 2018 13:05:02 +0100 Subject: [PATCH 004/134] Fixed HO to unkown cell issue --- srsue/hdr/upper/rrc.h | 112 +++++++++++++++++- srsue/src/upper/rrc.cc | 259 ++++++++++++++++++++++++----------------- 2 files changed, 258 insertions(+), 113 deletions(-) diff --git a/srsue/hdr/upper/rrc.h b/srsue/hdr/upper/rrc.h index 1aaf6f29b..5f269ec86 100644 --- a/srsue/hdr/upper/rrc.h +++ b/srsue/hdr/upper/rrc.h @@ -65,12 +65,14 @@ class cell_t return earfcn == this->earfcn && pci == phy_cell.id; } bool greater(cell_t *x) { - return x->rsrp > rsrp; + return rsrp > x->rsrp; } bool plmn_equals(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id) { - for (uint32_t i = 0; i < sib1.N_plmn_ids; i++) { - if (plmn_id.mcc == sib1.plmn_id[i].id.mcc && plmn_id.mnc == sib1.plmn_id[i].id.mnc) { - return true; + if (has_valid_sib1) { + for (uint32_t i = 0; i < sib1.N_plmn_ids; i++) { + if (plmn_id.mcc == sib1.plmn_id[i].id.mcc && plmn_id.mnc == sib1.plmn_id[i].id.mnc) { + return true; + } } } return false; @@ -80,6 +82,7 @@ class cell_t cell_t(tmp, 0, 0); } cell_t(srslte_cell_t phy_cell, uint32_t earfcn, float rsrp) { + gettimeofday(&last_update, NULL); this->has_valid_sib1 = false; this->has_valid_sib2 = false; this->has_valid_sib3 = false; @@ -94,14 +97,106 @@ class cell_t bzero(&sib13, sizeof(sib13)); } - uint32_t earfcn; + uint32_t get_earfcn() { + return earfcn; + } + + uint32_t get_pci() { + return phy_cell.id; + } + + void set_rsrp(float rsrp) { + this->rsrp = rsrp; + in_sync = true; + gettimeofday(&last_update, NULL); + } + + float get_rsrp() { + return rsrp; + } + + void set_sib1(LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_1_STRUCT *sib1) { + memcpy(&this->sib1, sib1, sizeof(LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_1_STRUCT)); + has_valid_sib1 = true; + } + void set_sib2(LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_2_STRUCT *sib2) { + memcpy(&this->sib2, sib2, sizeof(LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_2_STRUCT)); + has_valid_sib2 = true; + } + void set_sib3(LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_3_STRUCT *sib3) { + memcpy(&this->sib3, sib3, sizeof(LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_3_STRUCT)); + has_valid_sib3 = true; + } + void set_sib13(LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_13_STRUCT *sib13) { + memcpy(&this->sib13, sib13, sizeof(LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_13_STRUCT)); + has_valid_sib13 = true; + } + + uint32_t timeout_secs(struct timeval now) { + struct timeval t[3]; + memcpy(&t[2], &now, sizeof(struct timeval)); + memcpy(&t[1], &last_update, sizeof(struct timeval)); + get_time_interval(t); + return t[0].tv_sec; + } + + LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_1_STRUCT *sib1ptr() { + return &sib1; + } + LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_2_STRUCT *sib2ptr() { + return &sib2; + } + LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_3_STRUCT *sib3ptr() { + return &sib3; + } + + uint32_t get_cell_id() { + return sib1.cell_id; + } + + bool has_sib1() { + return has_valid_sib1; + } + bool has_sib2() { + return has_valid_sib2; + } + bool has_sib3() { + return has_valid_sib3; + } + bool has_sib13() { + return has_valid_sib13; + } + + uint16_t get_mcc() { + if (has_valid_sib1) { + if (sib1.N_plmn_ids > 0) { + return sib1.plmn_id[0].id.mcc; + } + } + return 0; + } + + uint16_t get_mnc() { + if (has_valid_sib1) { + if (sib1.N_plmn_ids > 0) { + return sib1.plmn_id[0].id.mnc; + } + } + return 0; + } + srslte_cell_t phy_cell; + bool in_sync; + + private: float rsrp; + uint32_t earfcn; + struct timeval last_update; + bool has_valid_sib1; bool has_valid_sib2; bool has_valid_sib3; bool has_valid_sib13; - bool in_sync; LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_1_STRUCT sib1; LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_2_STRUCT sib2; LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_3_STRUCT sib3; @@ -274,6 +369,7 @@ private: } // List of strongest neighbour cell + const static int NEIGHBOUR_TIMEOUT = 5; const static int NOF_NEIGHBOUR_CELLS = 8; std::vector neighbour_cells; cell_t *serving_cell; @@ -285,6 +381,9 @@ private: bool add_neighbour_cell(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp); bool add_neighbour_cell(cell_t *cell); void sort_neighbour_cells(); + void clean_neighbours(); + std::vector::iterator delete_neighbour(std::vector::iterator it); + void delete_neighbour(uint32_t cell_idx); typedef enum { SI_ACQUIRE_IDLE = 0, @@ -315,6 +414,7 @@ private: void run_tti(uint32_t tti); bool timer_expired(uint32_t timer_id); void ho_finish(); + void delete_report(uint32_t earfcn, uint32_t pci); private: const static int NOF_MEASUREMENTS = 3; diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 4d93c9452..9e26436ae 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -54,6 +54,7 @@ rrc::rrc() n310_cnt = 0; n311_cnt = 0; serving_cell = new cell_t(); + neighbour_cells.reserve(NOF_NEIGHBOUR_CELLS); } rrc::~rrc() @@ -168,6 +169,7 @@ void rrc::set_args(rrc_args_t *args) { void rrc::run_thread() { uint32_t failure_test = 0; + uint32_t cell_clean_cnt = 0; while (thread_running) { @@ -217,13 +219,13 @@ void rrc::run_thread() { * Cell is selected when all SIBs downloaded or applied. */ if (phy->sync_status()) { - if (!serving_cell->has_valid_sib1) { + if (!serving_cell->has_sib1()) { si_acquire_state = SI_ACQUIRE_SIB1; sysinfo_index = 0; - } else if (!serving_cell->has_valid_sib2) { + } else if (!serving_cell->has_sib2()) { si_acquire_state = SI_ACQUIRE_SIB2; } else { - apply_sib2_configs(&serving_cell->sib2); + apply_sib2_configs(serving_cell->sib2ptr()); si_acquire_state = SI_ACQUIRE_IDLE; state = RRC_STATE_CELL_SELECTED; } @@ -302,6 +304,13 @@ void rrc::run_thread() { default: break; } + if (state == RRC_STATE_CONNECTED || RRC_STATE_IDLE) { + cell_clean_cnt++; + if (cell_clean_cnt==1000) { + clean_neighbours(); + cell_clean_cnt = 0; + } + } usleep(1000); } } @@ -363,16 +372,16 @@ void rrc::run_si_acquisition_procedure() break; case SI_ACQUIRE_SIB2: // Instruct MAC to look for next SIB - if(sysinfo_index < serving_cell->sib1.N_sched_info) { - si_win_len = liblte_rrc_si_window_length_num[serving_cell->sib1.si_window_length]; + if(sysinfo_index < serving_cell->sib1ptr()->N_sched_info) { + si_win_len = liblte_rrc_si_window_length_num[serving_cell->sib1ptr()->si_window_length]; x = sysinfo_index*si_win_len; sf = x%10; offset = x/10; tti = mac->get_current_tti(); - period = liblte_rrc_si_periodicity_num[serving_cell->sib1.sched_info[sysinfo_index].si_periodicity]; + period = liblte_rrc_si_periodicity_num[serving_cell->sib1ptr()->sched_info[sysinfo_index].si_periodicity]; si_win_start = sib_start_tti(tti, period, offset, sf); - si_win_len = liblte_rrc_si_window_length_num[serving_cell->sib1.si_window_length]; + si_win_len = liblte_rrc_si_window_length_num[serving_cell->sib1ptr()->si_window_length]; if (last_win_start == 0 || (srslte_tti_interval(last_win_start, tti) > period*10 && srslte_tti_interval(last_win_start, tti) < 1000)) @@ -416,17 +425,11 @@ void rrc::run_si_acquisition_procedure() *******************************************************************************/ uint16_t rrc::get_mcc() { - if (serving_cell->sib1.N_plmn_ids > 0) { - return serving_cell->sib1.plmn_id[0].id.mcc; - } - return 0; + return serving_cell->get_mcc(); } uint16_t rrc::get_mnc() { - if (serving_cell->sib1.N_plmn_ids > 0) { - return serving_cell->sib1.plmn_id[0].id.mnc; - } - return 0; + return serving_cell->get_mnc(); } void rrc::plmn_search() { @@ -491,7 +494,7 @@ void rrc::set_serving_cell(uint32_t cell_idx) { // Move serving cell to neighbours list if (serving_cell->is_valid()) { // Make sure it does not exist already - int serving_idx = find_neighbour_cell(serving_cell->earfcn, serving_cell->phy_cell.id); + int serving_idx = find_neighbour_cell(serving_cell->get_earfcn(), serving_cell->phy_cell.id); if (serving_idx >= 0 && (uint32_t) serving_idx < neighbour_cells.size()) { printf("Error serving cell is already in the neighbour list. Removing it\n"); neighbour_cells.erase(std::remove(neighbour_cells.begin(), neighbour_cells.end(), neighbour_cells[serving_idx]), neighbour_cells.end()); @@ -506,7 +509,7 @@ void rrc::set_serving_cell(uint32_t cell_idx) { serving_cell = new_serving_cell; rrc_log->info("Setting serving cell idx=%d, earfcn=%d, PCI=%d, nof_neighbours=%d\n", - cell_idx, serving_cell->earfcn, serving_cell->phy_cell.id, neighbour_cells.size()); + cell_idx, serving_cell->get_earfcn(), serving_cell->phy_cell.id, neighbour_cells.size()); } else { rrc_log->error("Setting invalid serving cell idx %d\n", cell_idx); @@ -520,19 +523,19 @@ void rrc::select_next_cell_in_plmn() { neighbour_cells[i]->in_sync) // matches S criteria { // Try to select Cell - if (phy->cell_select(neighbour_cells[i]->earfcn, neighbour_cells[i]->phy_cell)) { + if (phy->cell_select(neighbour_cells[i]->get_earfcn(), neighbour_cells[i]->phy_cell)) { set_serving_cell(i); rrc_log->info("Selected cell PCI=%d, EARFCN=%d, Cell ID=0x%x\n", - serving_cell->phy_cell.id, serving_cell->earfcn, - serving_cell->sib1.cell_id); + serving_cell->phy_cell.id, serving_cell->get_earfcn(), + serving_cell->get_cell_id()); rrc_log->console("Selected cell PCI=%d, EARFCN=%d, Cell ID=0x%x\n", - serving_cell->phy_cell.id, serving_cell->earfcn, - serving_cell->sib1.cell_id); + serving_cell->phy_cell.id, serving_cell->get_earfcn(), + serving_cell->get_cell_id()); } else { // Set to out-of-sync if can't synchronize neighbour_cells[i]->in_sync = false; rrc_log->warning("Selecting cell EARFCN=%d, Cell ID=0x%x.\n", - neighbour_cells[i]->earfcn, neighbour_cells[i]->sib1.cell_id); + neighbour_cells[i]->get_earfcn(), neighbour_cells[i]->get_cell_id()); } return; } @@ -543,7 +546,7 @@ void rrc::select_next_cell_in_plmn() { void rrc::new_phy_meas(float rsrp, float rsrq, uint32_t tti, int earfcn_i, int pci_i) { if (earfcn_i < 0 || pci_i < 0) { - earfcn_i = serving_cell->earfcn; + earfcn_i = serving_cell->get_earfcn(); pci_i = serving_cell->phy_cell.id; } @@ -560,7 +563,7 @@ void rrc::new_phy_meas(float rsrp, float rsrq, uint32_t tti, int earfcn_i, int p // Update serving cell if (serving_cell->equals(earfcn, pci)) { cell_reselection_eval(rsrp, rsrq); - serving_cell->rsrp = rsrp; + serving_cell->set_rsrp(rsrp); rrc_log->info("MEAS: New measurement serving cell in IDLE, rsrp=%f, rsrq=%f, tti=%d\n", rsrp, rsrq, tti); // Or update/add neighbour cell @@ -573,13 +576,13 @@ void rrc::new_phy_meas(float rsrp, float rsrq, uint32_t tti, int earfcn_i, int p } // Verify cell selection criteria with strongest neighbour cell (always first) - if (cell_selection_eval(neighbour_cells[0]->rsrp) && - neighbour_cells[0]->rsrp > serving_cell->rsrp + 5) + if (cell_selection_eval(neighbour_cells[0]->get_rsrp()) && + neighbour_cells[0]->get_rsrp() > serving_cell->get_rsrp() + 5) { set_serving_cell(0); - rrc_log->info("Selecting best neighbour cell PCI=%d, rsrp=%.1f dBm\n", serving_cell->phy_cell.id, serving_cell->rsrp); + rrc_log->info("Selecting best neighbour cell PCI=%d, rsrp=%.1f dBm\n", serving_cell->phy_cell.id, serving_cell->get_rsrp()); state = RRC_STATE_CELL_SELECTING; - phy->cell_select(serving_cell->earfcn, serving_cell->phy_cell); + phy->cell_select(serving_cell->get_earfcn(), serving_cell->phy_cell); } } } @@ -590,7 +593,7 @@ void rrc::cell_found(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp) { int cell_idx = -1; if (serving_cell->equals(earfcn, phy_cell.id)) { - serving_cell->rsrp = rsrp; + serving_cell->set_rsrp(rsrp); serving_cell->in_sync = true; found = true; } else { @@ -598,18 +601,18 @@ void rrc::cell_found(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp) { cell_idx = find_neighbour_cell(earfcn, phy_cell.id); if (cell_idx >= 0) { set_serving_cell(cell_idx); - serving_cell->rsrp = rsrp; + serving_cell->set_rsrp(rsrp); serving_cell->in_sync = true; found = true; } } if (found) { - if (!serving_cell->has_valid_sib1) { + if (!serving_cell->has_sib1()) { si_acquire_state = SI_ACQUIRE_SIB1; } else if (state == RRC_STATE_PLMN_SELECTION) { - for (uint32_t j = 0; j < serving_cell->sib1.N_plmn_ids; j++) { - nas->plmn_found(serving_cell->sib1.plmn_id[j].id, serving_cell->sib1.tracking_area_code); + for (uint32_t j = 0; j < serving_cell->sib1ptr()->N_plmn_ids; j++) { + nas->plmn_found(serving_cell->sib1ptr()->plmn_id[j].id, serving_cell->sib1ptr()->tracking_area_code); } usleep(5000); phy->cell_search_next(); @@ -631,22 +634,54 @@ void rrc::cell_found(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp) { rrc_log->info("%s %s cell EARFCN=%d, PCI=%d, RSRP=%.1f dBm\n", found?"Updating":"Adding", cell_idx>=0?"neighbour":"serving", - serving_cell->earfcn, + serving_cell->get_earfcn(), serving_cell->phy_cell.id, - serving_cell->rsrp); + serving_cell->get_rsrp()); } bool sort_rsrp(cell_t *u1, cell_t *u2) { - return !u1->greater(u2); + return u1->greater(u2); } -// Sort neighbour cells by decreasing order of RSRP -void rrc::sort_neighbour_cells() { +void rrc::delete_neighbour(uint32_t cell_idx) { + measurements.delete_report(neighbour_cells[cell_idx]->get_earfcn(), neighbour_cells[cell_idx]->get_pci()); + delete neighbour_cells[cell_idx]; + neighbour_cells.erase(std::remove(neighbour_cells.begin(), neighbour_cells.end(), neighbour_cells[cell_idx]), neighbour_cells.end()); +} - for (uint32_t i=1;iin_sync == false) { - rrc_log->info("Removing neighbour cell PCI=%d, out_of_sync\n", neighbour_cells[i]->phy_cell.id); - neighbour_cells.erase(std::remove(neighbour_cells.begin(), neighbour_cells.end(), neighbour_cells[i]), neighbour_cells.end()); +std::vector::iterator rrc::delete_neighbour(std::vector::iterator it) { + measurements.delete_report((*it)->get_earfcn(), (*it)->get_pci()); + delete (*it); + return neighbour_cells.erase(it); +} + +void rrc::clean_neighbours() +{ + struct timeval now; + gettimeofday(&now, NULL); + + std::vector::iterator it = neighbour_cells.begin(); + while(it != neighbour_cells.end()) { + if ((*it)->timeout_secs(now) > NEIGHBOUR_TIMEOUT) { + rrc_log->info("Neighbour PCI=%d timed out. Deleting\n", (*it)->get_pci()); + it = delete_neighbour(it); + } else { + ++it; + } + } +} + +// Sort neighbour cells by decreasing order of RSRP +void rrc::sort_neighbour_cells() +{ + // Remove out-of-sync cells + std::vector::iterator it = neighbour_cells.begin(); + while(it != neighbour_cells.end()) { + if ((*it)->in_sync == false) { + rrc_log->info("Neighbour PCI=%d is out-of-sync. Deleting\n", (*it)->get_pci()); + it = delete_neighbour(it); + } else { + ++it; } } @@ -654,28 +689,27 @@ void rrc::sort_neighbour_cells() { char ordered[512]; int n=0; - n += snprintf(ordered, 512, "[pci=%d, rsrsp=%.2f", neighbour_cells[0]->phy_cell.id, neighbour_cells[0]->rsrp); + n += snprintf(ordered, 512, "[pci=%d, rsrsp=%.2f", neighbour_cells[0]->phy_cell.id, neighbour_cells[0]->get_rsrp()); for (uint32_t i=1;iphy_cell.id, neighbour_cells[i]->rsrp); + n += snprintf(&ordered[n], 512-n, " | pci=%d, rsrp=%.2f", neighbour_cells[i]->get_pci(), neighbour_cells[i]->get_rsrp()); } - rrc_log->info("Sorted neighbour cells: %s]\n", ordered); + rrc_log->info("Neighbours: %s]\n", ordered); } bool rrc::add_neighbour_cell(cell_t *new_cell) { bool ret = false; - if (neighbour_cells.size() < NOF_NEIGHBOUR_CELLS - 1) { + if (neighbour_cells.size() < NOF_NEIGHBOUR_CELLS) { ret = true; - } else if (!neighbour_cells[neighbour_cells.size()-1]->greater(new_cell)) { - // Delete old one - delete neighbour_cells[neighbour_cells.size()-1]; - neighbour_cells.erase(std::remove(neighbour_cells.begin(), neighbour_cells.end(), neighbour_cells[neighbour_cells.size()-1]), neighbour_cells.end()); + } else if (new_cell->greater(neighbour_cells[neighbour_cells.size()-1])) { + // Replace old one by new one + delete_neighbour(neighbour_cells.size()-1); ret = true; } if (ret) { neighbour_cells.push_back(new_cell); } rrc_log->info("Added neighbour cell EARFCN=%d, PCI=%d, nof_neighbours=%d\n", - new_cell->earfcn, new_cell->phy_cell.id, neighbour_cells.size()); + new_cell->get_earfcn(), new_cell->get_pci(), neighbour_cells.size()); sort_neighbour_cells(); return ret; } @@ -690,7 +724,7 @@ bool rrc::add_neighbour_cell(uint32_t earfcn, uint32_t pci, float rsrp) { bool rrc::add_neighbour_cell(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp) { if (earfcn == 0) { - earfcn = serving_cell->earfcn; + earfcn = serving_cell->get_earfcn(); } // First check if already exists @@ -700,7 +734,7 @@ bool rrc::add_neighbour_cell(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp // If exists, update RSRP, sort again and return if (cell_idx >= 0) { - neighbour_cells[cell_idx]->rsrp = rsrp; + neighbour_cells[cell_idx]->set_rsrp(rsrp); sort_neighbour_cells(); return true; } @@ -929,7 +963,7 @@ void rrc::send_con_restablish_request(LIBLTE_RRC_CON_REEST_REQ_CAUSE_ENUM cause, uint8_t *msg_ptr = varShortMAC; // ASN.1 encode byte-aligned VarShortMAC-Input - liblte_rrc_pack_cell_identity_ie(serving_cell->sib1.cell_id, &msg_ptr); + liblte_rrc_pack_cell_identity_ie(serving_cell->get_cell_id(), &msg_ptr); msg_ptr = &varShortMAC[4]; liblte_rrc_pack_phys_cell_id_ie(phy->get_current_pci(), &msg_ptr); msg_ptr = &varShortMAC[4+2]; @@ -937,7 +971,7 @@ void rrc::send_con_restablish_request(LIBLTE_RRC_CON_REEST_REQ_CAUSE_ENUM cause, srslte_bit_pack_vector(varShortMAC, varShortMAC_packed, (4+2+4)*8); rrc_log->info("Generated varShortMAC: cellId=0x%x, PCI=%d, rnti=%d\n", - serving_cell->sib1.cell_id, phy->get_current_pci(), crnti); + serving_cell->get_cell_id(), phy->get_current_pci(), crnti); // Compute MAC-I uint8_t mac_key[4]; @@ -1065,10 +1099,10 @@ bool rrc::ho_prepare() { if (pending_mob_reconf) { rrc_log->info("Processing HO command to target PCell=%d\n", mob_reconf.mob_ctrl_info.target_pci); - int target_cell_idx = find_neighbour_cell(serving_cell->earfcn, mob_reconf.mob_ctrl_info.target_pci); + int target_cell_idx = find_neighbour_cell(serving_cell->get_earfcn(), mob_reconf.mob_ctrl_info.target_pci); if (target_cell_idx < 0) { rrc_log->console("Received HO command to unknown PCI=%d\n", mob_reconf.mob_ctrl_info.target_pci); - rrc_log->error("Could not find target cell earfcn=%d, pci=%d\n", serving_cell->earfcn, mob_reconf.mob_ctrl_info.target_pci); + rrc_log->error("Could not find target cell earfcn=%d, pci=%d\n", serving_cell->get_earfcn(), mob_reconf.mob_ctrl_info.target_pci); return false; } @@ -1076,7 +1110,7 @@ bool rrc::ho_prepare() { mac_timers->timer_get(t310)->stop(); mac_timers->timer_get(t304)->set(this, liblte_rrc_t304_num[mob_reconf.mob_ctrl_info.t304]); if (mob_reconf.mob_ctrl_info.carrier_freq_eutra_present && - mob_reconf.mob_ctrl_info.carrier_freq_eutra.dl_carrier_freq != serving_cell->earfcn) { + mob_reconf.mob_ctrl_info.carrier_freq_eutra.dl_carrier_freq != serving_cell->get_earfcn()) { rrc_log->warning("Received mobilityControlInfo for inter-frequency handover\n"); } @@ -1099,9 +1133,9 @@ bool rrc::ho_prepare() { mac->set_ho_rnti(mob_reconf.mob_ctrl_info.new_ue_id, mob_reconf.mob_ctrl_info.target_pci); apply_rr_config_common_dl(&mob_reconf.mob_ctrl_info.rr_cnfg_common); - rrc_log->info("Selecting new cell pci=%d\n", neighbour_cells[target_cell_idx]->phy_cell.id); + rrc_log->info("Selecting new cell pci=%d\n", neighbour_cells[target_cell_idx]->get_pci()); if (!phy->cell_handover(neighbour_cells[target_cell_idx]->phy_cell)) { - rrc_log->error("Could not synchronize with target cell pci=%d\n", neighbour_cells[target_cell_idx]->phy_cell.id); + rrc_log->error("Could not synchronize with target cell pci=%d\n", neighbour_cells[target_cell_idx]->get_pci()); return false; } @@ -1177,7 +1211,7 @@ void rrc::ho_failed() { // Instruct PHY to resync with source PCI if (!phy->cell_handover(ho_src_cell.phy_cell)) { - rrc_log->error("Could not synchronize with target cell pci=%d\n", ho_src_cell.phy_cell.id); + rrc_log->error("Could not synchronize with target cell pci=%d\n", ho_src_cell.get_pci()); return; } @@ -1302,27 +1336,23 @@ void rrc::write_pdu_bcch_dlsch(byte_buffer_t *pdu) { rrc_log->info("Processing SIB: %d\n", liblte_rrc_sys_info_block_type_num[dlsch_msg.sibs[i].sib_type]); if (LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_1 == dlsch_msg.sibs[i].sib_type && SI_ACQUIRE_SIB1 == si_acquire_state) { - memcpy(&serving_cell->sib1, &dlsch_msg.sibs[i].sib.sib1, sizeof(LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_1_STRUCT)); - serving_cell->has_valid_sib1 = true; + serving_cell->set_sib1(&dlsch_msg.sibs[i].sib.sib1); handle_sib1(); - } else if (LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_2 == dlsch_msg.sibs[i].sib_type && !serving_cell->has_valid_sib2) { - memcpy(&serving_cell->sib2, &dlsch_msg.sibs[i].sib.sib2, sizeof(LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_2_STRUCT)); - serving_cell->has_valid_sib2 = true; + } else if (LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_2 == dlsch_msg.sibs[i].sib_type && !serving_cell->has_sib2()) { + serving_cell->set_sib2(&dlsch_msg.sibs[i].sib.sib2); handle_sib2(); - } else if (LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_3 == dlsch_msg.sibs[i].sib_type && !serving_cell->has_valid_sib3) { - memcpy(&serving_cell->sib3, &dlsch_msg.sibs[i].sib.sib3, sizeof(LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_3_STRUCT)); - serving_cell->has_valid_sib3 = true; + } else if (LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_3 == dlsch_msg.sibs[i].sib_type && !serving_cell->has_sib3()) { + serving_cell->set_sib3(&dlsch_msg.sibs[i].sib.sib3); handle_sib3(); - }else if (LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_13 == dlsch_msg.sibs[i].sib_type && !serving_cell->has_valid_sib13) { - memcpy(&serving_cell->sib13, &dlsch_msg.sibs[0].sib.sib13, sizeof(LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_13_STRUCT)); - serving_cell->has_valid_sib13 = true; + }else if (LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_13 == dlsch_msg.sibs[i].sib_type && !serving_cell->has_sib13()) { + serving_cell->set_sib13(&dlsch_msg.sibs[i].sib.sib13); handle_sib13(); } } last_win_start = 0; - if(serving_cell->has_valid_sib2) { + if(serving_cell->has_sib2()) { sysinfo_index++; } } @@ -1330,16 +1360,16 @@ void rrc::write_pdu_bcch_dlsch(byte_buffer_t *pdu) { void rrc::handle_sib1() { rrc_log->info("SIB1 received, CellID=%d, si_window=%d, sib2_period=%d\n", - serving_cell->sib1.cell_id&0xfff, - liblte_rrc_si_window_length_num[serving_cell->sib1.si_window_length], - liblte_rrc_si_periodicity_num[serving_cell->sib1.sched_info[0].si_periodicity]); + serving_cell->get_cell_id()&0xfff, + liblte_rrc_si_window_length_num[serving_cell->sib1ptr()->si_window_length], + liblte_rrc_si_periodicity_num[serving_cell->sib1ptr()->sched_info[0].si_periodicity]); // Print SIB scheduling info uint32_t i,j; - for(i=0;isib1.N_sched_info;i++){ - for(j=0;jsib1.sched_info[i].N_sib_mapping_info;j++){ - LIBLTE_RRC_SIB_TYPE_ENUM t = serving_cell->sib1.sched_info[i].sib_mapping_info[j].sib_type; - LIBLTE_RRC_SI_PERIODICITY_ENUM p = serving_cell->sib1.sched_info[i].si_periodicity; + for(i=0;isib1ptr()->N_sched_info;i++){ + for(j=0;jsib1ptr()->sched_info[i].N_sib_mapping_info;j++){ + LIBLTE_RRC_SIB_TYPE_ENUM t = serving_cell->sib1ptr()->sched_info[i].sib_mapping_info[j].sib_type; + LIBLTE_RRC_SI_PERIODICITY_ENUM p = serving_cell->sib1ptr()->sched_info[i].si_periodicity; rrc_log->debug("SIB scheduling info, sib_type=%d, si_periodicity=%d\n", liblte_rrc_sib_type_num[t], liblte_rrc_si_periodicity_num[p]); @@ -1347,16 +1377,14 @@ void rrc::handle_sib1() } // Set TDD Config - if(serving_cell->sib1.tdd) { - phy->set_config_tdd(&serving_cell->sib1.tdd_cnfg); + if(serving_cell->sib1ptr()->tdd) { + phy->set_config_tdd(&serving_cell->sib1ptr()->tdd_cnfg); } - serving_cell->has_valid_sib1 = true; - // Send PLMN and TAC to NAS std::stringstream ss; - for (uint32_t i = 0; i < serving_cell->sib1.N_plmn_ids; i++) { - nas->plmn_found(serving_cell->sib1.plmn_id[i].id, serving_cell->sib1.tracking_area_code); + for (uint32_t i = 0; i < serving_cell->sib1ptr()->N_plmn_ids; i++) { + nas->plmn_found(serving_cell->sib1ptr()->plmn_id[i].id, serving_cell->sib1ptr()->tracking_area_code); } // Jump to next state @@ -1379,7 +1407,7 @@ void rrc::handle_sib2() { rrc_log->info("SIB2 received\n"); - apply_sib2_configs(&serving_cell->sib2); + apply_sib2_configs(serving_cell->sib2ptr()); } @@ -1387,7 +1415,7 @@ void rrc::handle_sib3() { rrc_log->info("SIB3 received\n"); - LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_3_STRUCT *sib3 = &serving_cell->sib3; + LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_3_STRUCT *sib3 = serving_cell->sib3ptr(); // cellReselectionInfoCommon cell_resel_cfg.q_hyst = liblte_rrc_q_hyst_num[sib3->q_hyst]; @@ -1699,7 +1727,7 @@ void rrc::parse_dl_dcch(uint32_t lcid, byte_buffer_t *pdu) { * *******************************************************************************/ void rrc::enable_capabilities() { - bool enable_ul_64 = args.ue_category >= 5 && serving_cell->sib2.rr_config_common_sib.pusch_cnfg.enable_64_qam; + bool enable_ul_64 = args.ue_category >= 5 && serving_cell->sib2ptr()->rr_config_common_sib.pusch_cnfg.enable_64_qam; rrc_log->info("%s 64QAM PUSCH\n", enable_ul_64 ? "Enabling" : "Disabling"); phy->set_config_64qam_en(enable_ul_64); } @@ -2373,28 +2401,45 @@ void rrc::rrc_meas::new_phy_meas(uint32_t earfcn, uint32_t pci, float rsrp, floa L3_filter(&pcell_measurement, values); // Update serving cell measurement - parent->serving_cell->rsrp = rsrp; + parent->serving_cell->set_rsrp(rsrp); } else { // Add to list of neighbour cells - parent->add_neighbour_cell(earfcn, pci, rsrp); - - log_h->info("MEAS: New measurement earfcn=%d, pci=%d, rsrp=%f, rsrq=%f, tti=%d\n", earfcn, pci, rsrp, rsrq, tti); - - // Save PHY measurement for all active measurements whose earfcn/pci matches - for(std::map::iterator iter=active.begin(); iter!=active.end(); ++iter) { - meas_t *m = &iter->second; - if (objects[m->object_id].earfcn == earfcn) { - // If it's a newly discovered cell, add it to objects - if (!m->cell_values.count(pci)) { - uint32_t cell_idx = objects[m->object_id].cells.size(); - objects[m->object_id].cells[cell_idx].pci = pci; - objects[m->object_id].cells[cell_idx].q_offset = 0; + bool added = parent->add_neighbour_cell(earfcn, pci, rsrp); + + log_h->info("MEAS: New measurement %s earfcn=%d, pci=%d, rsrp=%f, rsrq=%f, tti=%d\n", + added?"added":"not added", earfcn, pci, rsrp, rsrq, tti); + + // Only report measurements of 8th strongest cells + if (added) { + // Save PHY measurement for all active measurements whose earfcn/pci matches + for(std::map::iterator iter=active.begin(); iter!=active.end(); ++iter) { + meas_t *m = &iter->second; + if (objects[m->object_id].earfcn == earfcn) { + // If it's a newly discovered cell, add it to objects + if (!m->cell_values.count(pci)) { + uint32_t cell_idx = objects[m->object_id].cells.size(); + objects[m->object_id].cells[cell_idx].pci = pci; + objects[m->object_id].cells[cell_idx].q_offset = 0; + } + // Update or add cell + L3_filter(&m->cell_values[pci], values); + return; } - // Update or add cell - L3_filter(&m->cell_values[pci], values); - return; + } + } + } +} + +// Remove all stored measurements for a given cell +void rrc::rrc_meas::delete_report(uint32_t earfcn, uint32_t pci) { + for(std::map::iterator iter=active.begin(); iter!=active.end(); ++iter) { + meas_t *m = &iter->second; + if (objects[m->object_id].earfcn == earfcn) { + if (m->cell_values.count(pci)) { + m->cell_values.erase(pci); + log_h->info("Deleting report PCI=%d from cell_values\n", pci); } } } From 9c416aa97e22130821d0a6562129f965ded905e4 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Fri, 23 Feb 2018 13:15:01 +0100 Subject: [PATCH 005/134] Disable RSSI sensor by default and expose rx_gain for calibration --- srsue/src/main.cc | 4 ++-- srsue/src/upper/rrc.cc | 2 +- srsue/ue.conf.example | 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/srsue/src/main.cc b/srsue/src/main.cc index e76891796..1cac2092d 100644 --- a/srsue/src/main.cc +++ b/srsue/src/main.cc @@ -159,11 +159,11 @@ void parse_args(all_args_t *args, int argc, char *argv[]) { "Pregenerate uplink signals after attach. Improves CPU performance.") ("expert.rssi_sensor_enabled", - bpo::value(&args->expert.phy.rssi_sensor_enabled)->default_value(true), + bpo::value(&args->expert.phy.rssi_sensor_enabled)->default_value(false), "Enable or disable RF frontend RSSI sensor. In some USRP devices can cause segmentation fault") ("expert.rx_gain_offset", - bpo::value(&args->expert.phy.rx_gain_offset)->default_value(10), + bpo::value(&args->expert.phy.rx_gain_offset)->default_value(62), "RX Gain offset to add to rx_gain to correct RSRP value") ("expert.prach_gain", diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 9e26436ae..6809eea4f 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -389,7 +389,7 @@ void rrc::run_si_acquisition_procedure() last_win_start = si_win_start; mac->bcch_start_rx(si_win_start, si_win_len); - rrc_log->info("Instructed MAC to search for system info, win_start=%d, win_len=%d\n", + rrc_log->debug("Instructed MAC to search for system info, win_start=%d, win_len=%d\n", si_win_start, si_win_len); } diff --git a/srsue/ue.conf.example b/srsue/ue.conf.example index 2b8da9643..5e6f01027 100644 --- a/srsue/ue.conf.example +++ b/srsue/ue.conf.example @@ -118,6 +118,7 @@ enable = false # ip_netmask: Netmask of the tun_srsue device. Default: 255.255.255.0 # rssi_sensor_enabled: Enable or disable RF frontend RSSI sensor. Required for RSRP metrics but # can cause UHD instability for long-duration testing. Default true. +# rx_gain_offset: RX Gain offset to add to rx_gain to calibrate RSRP readings # prach_gain: PRACH gain (dB). If defined, forces a gain for the tranmsission of PRACH only., # Default is to use tx_gain in [rf] section. # cqi_max: Upper bound on the maximum CQI to be reported. Default 15. @@ -176,6 +177,7 @@ enable = false [expert] #ip_netmask = 255.255.255.0 #rssi_sensor_enabled = false +#rx_gain_offset = 62 #prach_gain = 30 #cqi_max = 15 #cqi_fixed = 10 From aced809146ff2e1327829b288fd29cad059040f0 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Sat, 24 Feb 2018 21:28:05 +0100 Subject: [PATCH 006/134] Set rx_gain_offset for B210 --- srsue/src/main.cc | 4 ++-- srsue/ue.conf.example | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/srsue/src/main.cc b/srsue/src/main.cc index e76891796..1cac2092d 100644 --- a/srsue/src/main.cc +++ b/srsue/src/main.cc @@ -159,11 +159,11 @@ void parse_args(all_args_t *args, int argc, char *argv[]) { "Pregenerate uplink signals after attach. Improves CPU performance.") ("expert.rssi_sensor_enabled", - bpo::value(&args->expert.phy.rssi_sensor_enabled)->default_value(true), + bpo::value(&args->expert.phy.rssi_sensor_enabled)->default_value(false), "Enable or disable RF frontend RSSI sensor. In some USRP devices can cause segmentation fault") ("expert.rx_gain_offset", - bpo::value(&args->expert.phy.rx_gain_offset)->default_value(10), + bpo::value(&args->expert.phy.rx_gain_offset)->default_value(62), "RX Gain offset to add to rx_gain to correct RSRP value") ("expert.prach_gain", diff --git a/srsue/ue.conf.example b/srsue/ue.conf.example index 2b8da9643..b8cc43c2e 100644 --- a/srsue/ue.conf.example +++ b/srsue/ue.conf.example @@ -118,6 +118,7 @@ enable = false # ip_netmask: Netmask of the tun_srsue device. Default: 255.255.255.0 # rssi_sensor_enabled: Enable or disable RF frontend RSSI sensor. Required for RSRP metrics but # can cause UHD instability for long-duration testing. Default true. +# rx_gain_offset: RX Gain offset to add to rx_gain to calibrate RSRP readings # prach_gain: PRACH gain (dB). If defined, forces a gain for the tranmsission of PRACH only., # Default is to use tx_gain in [rf] section. # cqi_max: Upper bound on the maximum CQI to be reported. Default 15. @@ -176,6 +177,7 @@ enable = false [expert] #ip_netmask = 255.255.255.0 #rssi_sensor_enabled = false +#rx_gain_offset = 72 #prach_gain = 30 #cqi_max = 15 #cqi_fixed = 10 From 56455b31ef212286501f9f25b205259daeb2d6a9 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Sat, 24 Feb 2018 21:29:57 +0100 Subject: [PATCH 007/134] Use dedicated thread for MAC timers --- srsue/hdr/mac/mac.h | 15 +++++++++++++-- srsue/hdr/mac/ul_harq.h | 1 - srsue/src/mac/mac.cc | 14 +++++++++++++- 3 files changed, 26 insertions(+), 4 deletions(-) diff --git a/srsue/hdr/mac/mac.h b/srsue/hdr/mac/mac.h index e59aa8f16..f4b0ffe3a 100644 --- a/srsue/hdr/mac/mac.h +++ b/srsue/hdr/mac/mac.h @@ -162,13 +162,24 @@ private: void timer_alignment_expire(); srslte::timers timers; - // pointer to MAC PCAP object srslte::mac_pcap* pcap; bool is_first_ul_grant; + mac_metrics_t metrics; + + /* Class to run Timers in a dedicated thread */ + class mac_timers : public periodic_thread { + public: + void init(srslte::timers *timers, srslte::log *log_h); + private: + void run_period(); + srslte::timers *timers; + bool running; + srslte::log *log_h; + }; - mac_metrics_t metrics; + mac_timers mactimers; /* Class to process MAC PDUs from DEMUX unit */ class pdu_process : public thread { diff --git a/srsue/hdr/mac/ul_harq.h b/srsue/hdr/mac/ul_harq.h index 60deff36f..5c44a222e 100644 --- a/srsue/hdr/mac/ul_harq.h +++ b/srsue/hdr/mac/ul_harq.h @@ -246,7 +246,6 @@ private: } else { Warning("UL RAR grant available but no Msg3 on buffer\n"); } - printf("Transmitted Msg3\n"); // Normal UL grant } else { diff --git a/srsue/src/mac/mac.cc b/srsue/src/mac/mac.cc index daa82d1cb..2531faafc 100644 --- a/srsue/src/mac/mac.cc +++ b/srsue/src/mac/mac.cc @@ -82,6 +82,7 @@ bool mac::init(phy_interface_mac *phy, rlc_interface_mac *rlc, rrc_interface_mac started = true; start(MAC_MAIN_THREAD_PRIO); + mactimers.init(&timers, log_h); return started; } @@ -94,6 +95,7 @@ void mac::stop() ttisync.increase(); pdu_process_thread.stop(); wait_thread_finish(); + mactimers.stop(); } void mac::start_pcap(srslte::mac_pcap* pcap_) @@ -148,6 +150,17 @@ void mac::reset() bzero(&uernti, sizeof(ue_rnti_t)); } +void mac::mac_timers::init(srslte::timers *timers, srslte::log *log_h) { + this->timers = timers; + running = true; + this->log_h = log_h; + start_periodic(1000); +} + +void mac::mac_timers::run_period() { + timers->step_all(); +} + void mac::run_thread() { int cnt=0; @@ -165,7 +178,6 @@ void mac::run_thread() { tti = ttisync.wait(); log_h->step(tti); - timers.step_all(); // Step all procedures bsr_procedure.step(tti); From 42ece73453274f064b15ba450a59578397dbef35 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Sat, 24 Feb 2018 21:33:13 +0100 Subject: [PATCH 008/134] Changed cell selection/reselection to avoid stopping/restarting radio. Fixed SIB message search --- srsue/hdr/phy/phch_recv.h | 3 +-- srsue/hdr/upper/rrc_common.h | 4 +++ srsue/src/phy/phch_recv.cc | 51 ++++++++++++++++++++---------------- srsue/src/upper/nas.cc | 5 +++- srsue/src/upper/rrc.cc | 35 ++++++++++++------------- 5 files changed, 54 insertions(+), 44 deletions(-) diff --git a/srsue/hdr/phy/phch_recv.h b/srsue/hdr/phy/phch_recv.h index bc7255ac9..a14f8e9fa 100644 --- a/srsue/hdr/phy/phch_recv.h +++ b/srsue/hdr/phy/phch_recv.h @@ -104,7 +104,7 @@ private: bool set_cell(); void cell_search_inc(); - void resync_sfn(bool is_connected = false, bool rx_now = false); + void resync_sfn(bool restart_radio, bool restart_now = false); bool stop_sync(); void stop_rx(); @@ -307,7 +307,6 @@ private: IDLE = 0, CELL_SEARCH, CELL_SELECT, - CELL_RESELECT, CELL_MEASURE, CELL_CAMP, IDLE_RX diff --git a/srsue/hdr/upper/rrc_common.h b/srsue/hdr/upper/rrc_common.h index 6d1186812..259d08fd7 100644 --- a/srsue/hdr/upper/rrc_common.h +++ b/srsue/hdr/upper/rrc_common.h @@ -33,6 +33,7 @@ namespace srsue { // RRC states (3GPP 36.331 v10.0.0) typedef enum { RRC_STATE_IDLE = 0, + RRC_STATE_PLMN_START, RRC_STATE_PLMN_SELECTION, RRC_STATE_CELL_SELECTING, RRC_STATE_CELL_SELECTED, @@ -44,11 +45,14 @@ typedef enum { RRC_STATE_N_ITEMS, } rrc_state_t; static const char rrc_state_text[RRC_STATE_N_ITEMS][100] = {"IDLE", + "PLMN SELECTED", "PLMN SELECTION", "CELL SELECTING", "CELL SELECTED", "CONNECTING", "CONNECTED", + "HO PREPARE", + "HO PROCESS", "LEAVE CONNECTED"}; } // namespace srsue diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 5e2ec4dee..4a8fef5bf 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -265,17 +265,22 @@ bool phch_recv::set_cell() { return cell_is_set; } -void phch_recv::resync_sfn(bool is_connected, bool now) { +void phch_recv::resync_sfn(bool restart_radio, bool restart_now) { - if (!now) { + if (restart_radio) { wait_radio_reset(); stop_rx(); + usleep(100000); } - start_rx(now); sfn_p.reset(); - Info("SYNC: Starting SFN synchronization\n"); + search_p.reset(); + srslte_ue_sync_reset(&ue_sync); - phy_state = is_connected?CELL_RESELECT:CELL_SELECT; + if (restart_radio) { + start_rx(restart_now); + } + + phy_state = CELL_SELECT; } void phch_recv::set_earfcn(std::vector earfcn) { @@ -294,7 +299,7 @@ bool phch_recv::stop_sync() { if (phy_state == IDLE && is_in_idle) { return true; } else { - Info("SYNC: Going to IDLE\n"); + Info("SYNC: Going to IDLE (state=%d)\n", phy_state); phy_state = IDLE; int cnt = 0; while (!is_in_idle && cnt < 100) { @@ -302,7 +307,7 @@ bool phch_recv::stop_sync() { cnt++; } if (!is_in_idle) { - Warning("SYNC: Could not go to IDLE\n"); + Warning("SYNC: Could not go to IDLE (state=%d)\n", phy_state); } return is_in_idle; } @@ -310,11 +315,12 @@ bool phch_recv::stop_sync() { void phch_recv::reset_sync() { - Warning("SYNC: Resetting sync, cell_search_in_progress=%s\n", cell_search_in_progress?"yes":"no"); - - search_p.reset(); - srslte_ue_sync_reset(&ue_sync); - resync_sfn(true, true); + if (phy_state != CELL_SELECT) { + Warning("SYNC: Resetting sync, cell_search_in_progress=%s\n", cell_search_in_progress?"yes":"no"); + resync_sfn(false); + } else { + Warning("SYNC: Trying to reset sync while in cell reselection\n"); + } } void phch_recv::cell_search_inc() @@ -323,6 +329,8 @@ void phch_recv::cell_search_inc() if (cur_earfcn_index >= 0) { if (cur_earfcn_index >= (int) earfcn.size()) { cur_earfcn_index = 0; + cell_search_in_progress = false; + phy_state = IDLE; rrc->earfcn_end(); } else { Info("SYNC: Cell Search idx %d/%d\n", cur_earfcn_index, earfcn.size()); @@ -338,7 +346,7 @@ void phch_recv::cell_search_next(bool reset) { if (cell_search_in_progress || reset) { cell_search_in_progress = false; if (!stop_sync()) { - log_h->warning("SYNC: Couldn't stop PHY\n"); + log_h->warning("SYNC: Couldn't stop PHY (state=%d)\n", phy_state); } if (reset) { cur_earfcn_index = -1; @@ -393,9 +401,7 @@ bool phch_recv::cell_handover(srslte_cell_t cell) if (is_in_idle_rx) { Info("Cell HO: Reconfiguring cell\n"); if (set_cell()) { - //resync_sfn(true, true); - sfn_p.reset(); - phy_state = CELL_RESELECT; + resync_sfn(false); Info("Cell HO: Synchronizing with new cell\n"); ret = true; } else { @@ -419,7 +425,7 @@ bool phch_recv::cell_select(uint32_t earfcn, srslte_cell_t cell) { set_sampling_rate(); } if (phy_state < CELL_SELECT) { - resync_sfn(); + resync_sfn(true, false); } return true; } else { @@ -444,9 +450,7 @@ bool phch_recv::cell_select(uint32_t earfcn, srslte_cell_t cell) { if (set_cell()) { log_h->info("Cell Select: Synchronizing on cell...\n"); - resync_sfn(); - - usleep(500000); // Time offset we set start_rx to start receiving samples + resync_sfn(true, false); return true; } return false; @@ -616,13 +620,14 @@ void phch_recv::run_thread() } if (set_cell()) { set_sampling_rate(); - resync_sfn(); + resync_sfn(true, false); } break; case search::CELL_NOT_FOUND: if (cell_search_in_progress) { cell_search_inc(); } + phy_state = IDLE; break; default: radio_error(); @@ -630,7 +635,6 @@ void phch_recv::run_thread() } } break; - case CELL_RESELECT: case CELL_SELECT: switch (sfn_p.run_subframe(&cell, &tti)) { @@ -650,7 +654,7 @@ void phch_recv::run_thread() phy_state = CELL_SEARCH; } else { log_h->warning("SYNC: Timeout while synchronizing SFN. Reselecting cell\n"); - resync_sfn(true, true); + resync_sfn(false); } break; case sfn_sync::IDLE: @@ -666,6 +670,7 @@ void phch_recv::run_thread() case measure::MEASURE_OK: log_h->info("SYNC: Measured OK. Camping on cell PCI=%d...\n", cell.id); phy_state = CELL_CAMP; + cell_search_in_progress = false; rrc->cell_found(earfcn[cur_earfcn_index], cell, measure_p.rsrp()); break; case measure::IDLE: diff --git a/srsue/src/upper/nas.cc b/srsue/src/upper/nas.cc index 04b5f4869..7f5683867 100644 --- a/srsue/src/upper/nas.cc +++ b/srsue/src/upper/nas.cc @@ -171,7 +171,10 @@ void nas::plmn_search_end() { rrc->plmn_select(known_plmns[0]); } else { - nas_log->debug("Finished searching PLMN in current EARFCN set but no networks were found.\n"); + nas_log->info("Finished searching PLMN in current EARFCN set but no networks were found.\n"); + if (state == EMM_STATE_REGISTERED_INITIATED && plmn_selection == PLMN_NOT_SELECTED) { + rrc->plmn_search(); + } } } diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 9e26436ae..0760ccb7e 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -202,6 +202,12 @@ void rrc::run_thread() { // If not attached, PLMN selection will be triggered from higher layers } break; + case RRC_STATE_PLMN_START: + rrc_log->info("RRC PLMN Search: Starting cell search\n"); + plmn_select_timeout = 0; + phy->cell_search_start(); + state = RRC_STATE_PLMN_SELECTION; + break; case RRC_STATE_PLMN_SELECTION: plmn_select_timeout++; if (plmn_select_timeout >= RRC_PLMN_SELECT_TIMEOUT) { @@ -209,8 +215,7 @@ void rrc::run_thread() { phy->cell_search_stop(); sleep(1); rrc_log->console("\nRRC PLMN Search: timeout expired. Searching again\n"); - plmn_select_timeout = 0; - phy->cell_search_start(); + } break; case RRC_STATE_CELL_SELECTING: @@ -230,7 +235,7 @@ void rrc::run_thread() { state = RRC_STATE_CELL_SELECTED; } } - // Don't time out during restablishment (T311 running) + // Don't time out during reestablishment (T311 running) if (!mac_timers->timer_get(t311)->is_running()) { select_cell_timeout++; if (select_cell_timeout >= RRC_SELECT_CELL_TIMEOUT) { @@ -351,7 +356,7 @@ void rrc::run_si_acquisition_procedure() tti = mac->get_current_tti(); si_win_start = sib_start_tti(tti, 2, 0, 5); if (last_win_start == 0 || - (srslte_tti_interval(last_win_start, tti) > 20 && srslte_tti_interval(last_win_start, tti) < 1000)) + (srslte_tti_interval(tti, last_win_start) >= 20 && srslte_tti_interval(tti, last_win_start) < 1000)) { last_win_start = si_win_start; @@ -384,12 +389,12 @@ void rrc::run_si_acquisition_procedure() si_win_len = liblte_rrc_si_window_length_num[serving_cell->sib1ptr()->si_window_length]; if (last_win_start == 0 || - (srslte_tti_interval(last_win_start, tti) > period*10 && srslte_tti_interval(last_win_start, tti) < 1000)) + (srslte_tti_interval(tti, last_win_start) > period*10 && srslte_tti_interval(tti, last_win_start) < 1000)) { last_win_start = si_win_start; mac->bcch_start_rx(si_win_start, si_win_len); - rrc_log->info("Instructed MAC to search for system info, win_start=%d, win_len=%d\n", + rrc_log->debug("Instructed MAC to search for system info, win_start=%d, win_len=%d\n", si_win_start, si_win_len); } @@ -433,10 +438,7 @@ uint16_t rrc::get_mnc() { } void rrc::plmn_search() { - rrc_log->info("Starting PLMN search procedure\n"); - state = RRC_STATE_PLMN_SELECTION; - phy->cell_search_start(); - plmn_select_timeout = 0; + state = RRC_STATE_PLMN_START; } /* This is the NAS interface. When NAS requests to select a PLMN we have to @@ -576,7 +578,8 @@ void rrc::new_phy_meas(float rsrp, float rsrq, uint32_t tti, int earfcn_i, int p } // Verify cell selection criteria with strongest neighbour cell (always first) - if (cell_selection_eval(neighbour_cells[0]->get_rsrp()) && + if (neighbour_cells.size() > 1 && + cell_selection_eval(neighbour_cells[0]->get_rsrp()) && neighbour_cells[0]->get_rsrp() > serving_cell->get_rsrp() + 5) { set_serving_cell(0); @@ -761,10 +764,6 @@ void rrc::earfcn_end() { // If searching for PLMN, indicate NAS we scanned all frequencies if (state == RRC_STATE_PLMN_SELECTION) { nas->plmn_search_end(); - } else if (state == RRC_STATE_CELL_SELECTING) { - select_cell_timeout = 0; - rrc_log->info("Starting cell search again\n"); - phy->cell_search_start(); } } @@ -825,11 +824,11 @@ void rrc::out_of_sync() { if (!mac_timers->timer_get(t311)->is_running() && !mac_timers->timer_get(t310)->is_running()) { n310_cnt++; if (n310_cnt == N310) { + rrc_log->info("Detected %d out-of-sync from PHY. Trying to resync. Starting T310 timer %d ms\n", + N310, mac_timers->timer_get(t310)->get_timeout()); mac_timers->timer_get(t310)->reset(); mac_timers->timer_get(t310)->run(); n310_cnt = 0; - phy->sync_reset(); - rrc_log->info("Detected %d out-of-sync from PHY. Trying to resync. Starting T310 timer\n", N310); } } } else { @@ -856,7 +855,6 @@ void rrc::in_sync() { void rrc::radio_link_failure() { // TODO: Generate and store failure report - phy->sync_reset(); rrc_log->warning("Detected Radio-Link Failure\n"); rrc_log->console("Warning: Detected Radio-Link Failure\n"); if (state != RRC_STATE_CONNECTED) { @@ -1016,6 +1014,7 @@ void rrc::send_con_restablish_request(LIBLTE_RRC_CON_REEST_REQ_CAUSE_ENUM cause, set_phy_default(); mac->reset(); set_mac_default(); + phy->sync_reset(); state = RRC_STATE_CELL_SELECTING; } From df67735a99d256ff45df73bedfa12e8627fec57c Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Sun, 25 Feb 2018 13:08:36 +0100 Subject: [PATCH 009/134] Reset UL after IDLEling PHY --- srsue/src/phy/phch_recv.cc | 11 ++++++++++- srsue/src/upper/rrc.cc | 3 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 4a8fef5bf..d63d298ec 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -391,13 +391,22 @@ bool phch_recv::cell_handover(srslte_cell_t cell) bool ret = false; this->cell = cell; Info("Cell HO: Stopping sync with current cell\n"); - worker_com->reset_ul(); phy_state = IDLE_RX; cnt = 0; while(!is_in_idle_rx && cnt<20) { usleep(1000); cnt++; } + cnt = 0; + while(!is_in_idle_rx && cnt<20) { + usleep(1000); + cnt++; + } + for(uint32_t i=0;iget_nof_workers();i++) { + ((phch_worker*) workers_pool->get_worker(i))->reset(); + } + worker_com->reset(); + worker_com->reset_ul(); if (is_in_idle_rx) { Info("Cell HO: Reconfiguring cell\n"); if (set_cell()) { diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 0760ccb7e..9c5ad52c1 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -1128,7 +1128,8 @@ bool rrc::ho_prepare() { pdcp->reestablish(); rlc->reestablish(); mac->reset(); - phy->reset(); + // PHY is reset inside cell_handover() function + mac->set_ho_rnti(mob_reconf.mob_ctrl_info.new_ue_id, mob_reconf.mob_ctrl_info.target_pci); apply_rr_config_common_dl(&mob_reconf.mob_ctrl_info.rr_cnfg_common); From cfaa5e9b281e4bb501446a3d35f26ccf9a7cd4fc Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Sun, 25 Feb 2018 19:13:12 +0100 Subject: [PATCH 010/134] Fix previous commit could not HO more than once due to not refreshing serving cell after 1st HO --- lib/include/srslte/interfaces/ue_interfaces.h | 2 +- srsue/hdr/upper/rrc.h | 7 +++++-- srsue/src/phy/phch_recv.cc | 3 ++- srsue/src/upper/rrc.cc | 8 ++++---- 4 files changed, 12 insertions(+), 8 deletions(-) diff --git a/lib/include/srslte/interfaces/ue_interfaces.h b/lib/include/srslte/interfaces/ue_interfaces.h index 00b61fa1c..f18a6737b 100644 --- a/lib/include/srslte/interfaces/ue_interfaces.h +++ b/lib/include/srslte/interfaces/ue_interfaces.h @@ -160,7 +160,7 @@ public: virtual void in_sync() = 0; virtual void out_of_sync() = 0; virtual void earfcn_end() = 0; - virtual void cell_found(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp) = 0; + virtual void cell_camping(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp = NAN) = 0; virtual void new_phy_meas(float rsrp, float rsrq, uint32_t tti, int earfcn = -1, int pci = -1) = 0; }; diff --git a/srsue/hdr/upper/rrc.h b/srsue/hdr/upper/rrc.h index 5f269ec86..1bfae16b3 100644 --- a/srsue/hdr/upper/rrc.h +++ b/srsue/hdr/upper/rrc.h @@ -37,6 +37,7 @@ #include "srslte/common/security.h" #include "srslte/common/threads.h" +#include #include #include @@ -106,7 +107,9 @@ class cell_t } void set_rsrp(float rsrp) { - this->rsrp = rsrp; + if (~isnan(rsrp)) { + this->rsrp = rsrp; + } in_sync = true; gettimeofday(&last_update, NULL); } @@ -252,7 +255,7 @@ public: void in_sync(); void out_of_sync(); void earfcn_end(); - void cell_found(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp); + void cell_camping(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp); void new_phy_meas(float rsrp, float rsrq, uint32_t tti, int earfcn, int pci); // MAC interface diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index d63d298ec..5701297c4 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -651,6 +651,7 @@ void phch_recv::run_thread() if (!cell_search_in_progress) { log_h->info("Sync OK. Camping on cell PCI=%d...\n", cell.id); phy_state = CELL_CAMP; + rrc->cell_camping(earfcn[cur_earfcn_index], cell); } else { log_h->info("Sync OK. Measuring PCI=%d...\n", cell.id); measure_p.reset(); @@ -680,7 +681,7 @@ void phch_recv::run_thread() log_h->info("SYNC: Measured OK. Camping on cell PCI=%d...\n", cell.id); phy_state = CELL_CAMP; cell_search_in_progress = false; - rrc->cell_found(earfcn[cur_earfcn_index], cell, measure_p.rsrp()); + rrc->cell_camping(earfcn[cur_earfcn_index], cell, measure_p.rsrp()); break; case measure::IDLE: break; diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 9c5ad52c1..dfb356b92 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -590,14 +590,16 @@ void rrc::new_phy_meas(float rsrp, float rsrq, uint32_t tti, int earfcn_i, int p } } -void rrc::cell_found(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp) { +/* PHY begins camping in a cell. RRC updates RSRP measurement, + * proceeds with PLMN selection/cell search if applicable and sets + * new cell as current serving cell */ +void rrc::cell_camping(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp) { bool found = false; int cell_idx = -1; if (serving_cell->equals(earfcn, phy_cell.id)) { serving_cell->set_rsrp(rsrp); - serving_cell->in_sync = true; found = true; } else { // Check if cell is in our list of neighbour cells @@ -605,7 +607,6 @@ void rrc::cell_found(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp) { if (cell_idx >= 0) { set_serving_cell(cell_idx); serving_cell->set_rsrp(rsrp); - serving_cell->in_sync = true; found = true; } } @@ -629,7 +630,6 @@ void rrc::cell_found(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp) { phy->cell_search_next(); } else { set_serving_cell(earfcn, phy_cell.id); - si_acquire_state = SI_ACQUIRE_SIB1; } } From 65aa5abb309e2739af0725c86211a0ae6b6f8402 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Sun, 25 Feb 2018 20:51:16 +0100 Subject: [PATCH 011/134] Restored RSRP calculation changed in commit 3f002aca85f9a23226c3481b3619ae11ad798e94 --- lib/src/phy/ch_estimation/chest_dl.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/src/phy/ch_estimation/chest_dl.c b/lib/src/phy/ch_estimation/chest_dl.c index 5249696af..221bac319 100644 --- a/lib/src/phy/ch_estimation/chest_dl.c +++ b/lib/src/phy/ch_estimation/chest_dl.c @@ -540,22 +540,23 @@ void chest_interpolate_noise_est(srslte_chest_dl_t *q, cf_t *input, cf_t *ce, ui } } } - - /* Compute RSRP for the channel estimates in this port */ - uint32_t npilots = SRSLTE_REFSIGNAL_NUM_SF(q->cell.nof_prb, port_id); - q->rsrp[rxant_id][port_id] = srslte_vec_avg_power_cf(q->pilot_estimates, npilots); - q->rssi[rxant_id][port_id] = srslte_chest_dl_rssi(q, input, port_id); } int srslte_chest_dl_estimate_port(srslte_chest_dl_t *q, cf_t *input, cf_t *ce, uint32_t sf_idx, uint32_t port_id, uint32_t rxant_id) { + uint32_t npilots = SRSLTE_REFSIGNAL_NUM_SF(q->cell.nof_prb, port_id); + /* Get references from the input signal */ srslte_refsignal_cs_get_sf(q->cell, port_id, input, q->pilot_recv_signal); /* Use the known CSR signal to compute Least-squares estimates */ srslte_vec_prod_conj_ccc(q->pilot_recv_signal, q->csr_refs.pilots[port_id/2][sf_idx], - q->pilot_estimates, SRSLTE_REFSIGNAL_NUM_SF(q->cell.nof_prb, port_id)); + q->pilot_estimates, npilots); + /* Compute RSRP for the channel estimates in this port */ + double energy = cabs(srslte_vec_acc_cc(q->pilot_estimates, npilots)/npilots); + q->rsrp[rxant_id][port_id] = energy*energy; + q->rssi[rxant_id][port_id] = srslte_chest_dl_rssi(q, input, port_id); chest_interpolate_noise_est(q, input, ce, sf_idx, port_id, rxant_id, SRSLTE_SF_NORM); From beccfd29195194857417e278b157e3bdb9747000 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Sun, 25 Feb 2018 23:36:08 +0100 Subject: [PATCH 012/134] Average RSRP in linear domain to get better resolution --- srsue/hdr/phy/phch_recv.h | 6 ++--- srsue/src/phy/phch_recv.cc | 50 ++++++++++++++++++++------------------ 2 files changed, 29 insertions(+), 27 deletions(-) diff --git a/srsue/hdr/phy/phch_recv.h b/srsue/hdr/phy/phch_recv.h index a14f8e9fa..1e15aea62 100644 --- a/srsue/hdr/phy/phch_recv.h +++ b/srsue/hdr/phy/phch_recv.h @@ -167,13 +167,14 @@ private: typedef enum {IDLE, MEASURE_OK, ERROR} ret_code; ~measure(); - void init(cf_t *buffer[SRSLTE_MAX_PORTS], srslte::log *log_h, srslte::radio *radio_h, + void init(cf_t *buffer[SRSLTE_MAX_PORTS], srslte::log *log_h, uint32_t nof_rx_antennas, uint32_t nof_subframes = RSRP_MEASURE_NOF_FRAMES); void reset(); void set_cell(srslte_cell_t cell); ret_code run_subframe(uint32_t sf_idx); ret_code run_subframe_sync(srslte_ue_sync_t *ue_sync, uint32_t sf_idx); ret_code run_multiple_subframes(cf_t *buffer, uint32_t offset, uint32_t sf_idx, uint32_t nof_sf); + float rssi(); float rsrp(); float rsrq(); float snr(); @@ -183,7 +184,6 @@ private: srslte::log *log_h; srslte_ue_dl_t ue_dl; cf_t *buffer[SRSLTE_MAX_PORTS]; - srslte::radio *radio_h; uint32_t cnt; uint32_t nof_subframes; uint32_t current_prb; @@ -235,7 +235,7 @@ private: void write(uint32_t tti, cf_t *data, uint32_t nsamples); private: void run_thread(); - const static int INTRA_FREQ_MEAS_LEN_MS = 20; + const static int INTRA_FREQ_MEAS_LEN_MS = 50; const static int INTRA_FREQ_MEAS_PERIOD_MS = 200; const static int INTRA_FREQ_MEAS_PRIO = DEFAULT_PRIORITY + 5; diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 5701297c4..6737f52e0 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -91,7 +91,7 @@ void phch_recv::init(srslte::radio_multi *_radio_handler, mac_interface_phy *_ma sfn_p.init(&ue_sync, sf_buffer, log_h); // Initialize measurement class for the primary cell - measure_p.init(sf_buffer, log_h, radio_h, nof_rx_antennas); + measure_p.init(sf_buffer, log_h, nof_rx_antennas); // Start intra-frequency measurement intra_freq_meas.init(worker_com, rrc, log_h); @@ -675,9 +675,18 @@ void phch_recv::run_thread() } break; case CELL_MEASURE: + switch(measure_p.run_subframe_sync(&ue_sync, sf_idx)) { case measure::MEASURE_OK: + + // Calibrate measure object since worker not yet calibrated + if (worker_com->args->rssi_sensor_enabled) { + measure_p.set_rx_gain_offset(measure_p.rssi() - radio_h->get_rssi() + 30); + } else { + measure_p.set_rx_gain_offset(worker_com->args->rx_gain_offset + radio_h->get_rx_gain()); + } + log_h->info("SYNC: Measured OK. Camping on cell PCI=%d...\n", cell.id); phy_state = CELL_CAMP; cell_search_in_progress = false; @@ -1095,11 +1104,10 @@ phch_recv::sfn_sync::ret_code phch_recv::sfn_sync::run_subframe(srslte_cell_t *c /********* * Measurement class */ -void phch_recv::measure::init(cf_t *buffer[SRSLTE_MAX_PORTS], srslte::log *log_h, srslte::radio *radio_h, uint32_t nof_rx_antennas, uint32_t nof_subframes) +void phch_recv::measure::init(cf_t *buffer[SRSLTE_MAX_PORTS], srslte::log *log_h, uint32_t nof_rx_antennas, uint32_t nof_subframes) { - this->radio_h = radio_h; - this->log_h = log_h; + this->log_h = log_h; this->nof_subframes = nof_subframes; for (int i=0;ibuffer[i] = buffer[i]; @@ -1132,17 +1140,21 @@ void phch_recv::measure::set_cell(srslte_cell_t cell) } reset(); } - + +float phch_recv::measure::rssi() { + return 10*log10(mean_rssi); +} + float phch_recv::measure::rsrp() { - return mean_rsrp; + return 10*log10(mean_rsrp) + 30 - rx_gain_offset; } float phch_recv::measure::rsrq() { - return mean_rsrq; + return 10*log10(mean_rsrq); } float phch_recv::measure::snr() { - return mean_snr; + return 10*log10(mean_snr); } uint32_t phch_recv::measure::frame_st_idx() { @@ -1243,10 +1255,10 @@ phch_recv::measure::ret_code phch_recv::measure::run_subframe(uint32_t sf_idx) return ERROR; } - float rsrp = 10*log10(srslte_chest_dl_get_rsrp(&ue_dl.chest)) + 30 - rx_gain_offset; - float rsrq = 10*log10(srslte_chest_dl_get_rsrq(&ue_dl.chest)); - float snr = 10*log10(srslte_chest_dl_get_snr(&ue_dl.chest)); - float rssi = 10*log10(srslte_vec_avg_power_cf(buffer[0], SRSLTE_SF_LEN_PRB(current_prb))) + 30; + float rsrp = srslte_chest_dl_get_rsrp(&ue_dl.chest); + float rsrq = srslte_chest_dl_get_rsrq(&ue_dl.chest); + float snr = srslte_chest_dl_get_snr(&ue_dl.chest); + float rssi = srslte_vec_avg_power_cf(buffer[0], SRSLTE_SF_LEN_PRB(current_prb)); if (cnt == 0) { mean_rsrp = rsrp; @@ -1265,17 +1277,6 @@ phch_recv::measure::ret_code phch_recv::measure::run_subframe(uint32_t sf_idx) cnt, nof_subframes, sf_idx, rsrp, snr); if (cnt >= nof_subframes) { - - // Calibrate RSRP if no gain offset measurements - if (fabsf(rx_gain_offset) < 1.0 && radio_h) { - float temporal_offset = 0; - if (radio_h->has_rssi()) { - temporal_offset = mean_rssi - radio_h->get_rssi() + 30; - } else { - temporal_offset = radio_h->get_rx_gain(); - } - mean_rsrp -= temporal_offset; - } return MEASURE_OK; } else { return IDLE; @@ -1304,7 +1305,7 @@ void phch_recv::scell_recv::init(srslte::log *log_h, bool sic_pss_enabled, uint3 sf_buffer[0] = (cf_t*) srslte_vec_malloc(sizeof(cf_t)*max_sf_size); input_cfo_corrected = (cf_t*) srslte_vec_malloc(sizeof(cf_t)*15*max_sf_size); - measure_p.init(sf_buffer, log_h, NULL, 1, max_sf_window); + measure_p.init(sf_buffer, log_h, 1, max_sf_window); //do this different we don't need all this search window. if(srslte_sync_init(&sync_find, max_sf_window*max_sf_size, 5*max_sf_size, max_fft_sz)) { @@ -1609,6 +1610,7 @@ void phch_recv::intra_measure::run_thread() } if (running) { + // Read data from buffer and find cells in it srslte_ringbuffer_read(&ring_buffer, search_buffer, INTRA_FREQ_MEAS_LEN_MS*current_sflen*sizeof(cf_t)); int found_cells = scell.find_cells(search_buffer, common->rx_gain_offset, primary_cell, INTRA_FREQ_MEAS_LEN_MS, info); From bf80a0a21ba363eb207e27f0b25ad899d9e1b758 Mon Sep 17 00:00:00 2001 From: Xavier Arteaga Date: Mon, 26 Feb 2018 16:42:52 +0100 Subject: [PATCH 013/134] Udated enb.config.example for TM1-4 --- srsenb/enb.conf.example | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/srsenb/enb.conf.example b/srsenb/enb.conf.example index 1fafbdc00..9b62d80ca 100644 --- a/srsenb/enb.conf.example +++ b/srsenb/enb.conf.example @@ -13,6 +13,8 @@ # mme_addr: IP address of MME for S1 connnection # gtp_bind_addr: Local IP address to bind for GTP connection # n_prb: Number of Physical Resource Blocks (6,15,25,50,75,100) +# tm: Transmission mode 1-4 (TM1 default) +# nof_ports: Number of Tx ports (1 port default, set to 2 for TM2/3/4) # ##################################################################### [enb] @@ -25,6 +27,9 @@ mnc = 01 mme_addr = 127.0.1.100 gtp_bind_addr = 127.0.0.1 n_prb = 50 +#tm = 4 +#nof_ports = 2 + ##################################################################### # eNB configuration files From 252174865ceae75a9f907bc3e399f8500d43cf38 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Tue, 27 Feb 2018 14:24:27 +0100 Subject: [PATCH 014/134] fix coverity issue --- srsepc/src/mme/mme_gtpc.cc | 3 ++- srsepc/src/mme/s1ap.cc | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/srsepc/src/mme/mme_gtpc.cc b/srsepc/src/mme/mme_gtpc.cc index 0c36541c0..4e5d2ad7d 100644 --- a/srsepc/src/mme/mme_gtpc.cc +++ b/srsepc/src/mme/mme_gtpc.cc @@ -118,7 +118,8 @@ mme_gtpc::send_create_session_request(uint64_t imsi, uint32_t mme_ue_s1ap_id) m_mme_gtpc_log->console("Creating Session Response -- IMSI: %015lu \n", imsi); m_mme_gtpc_log->console("Creating Session Response -- MME control TEID: %lu \n", cs_req->sender_f_teid.teid); // APN - strcpy(cs_req->apn, m_s1ap->m_s1ap_args.mme_apn.c_str()); + strncpy(cs_req->apn, m_s1ap->m_s1ap_args.mme_apn.c_str(), sizeof(cs_req->apn)-1); + cs_req->apn[sizeof(cs_req->apn)-1] = 0; // RAT Type //cs_req->rat_type = srslte::GTPC_RAT_TYPE::EUTRAN; diff --git a/srsepc/src/mme/s1ap.cc b/srsepc/src/mme/s1ap.cc index 8d25fed11..80d8b6d74 100644 --- a/srsepc/src/mme/s1ap.cc +++ b/srsepc/src/mme/s1ap.cc @@ -38,7 +38,9 @@ boost::mutex s1ap_instance_mutex; s1ap::s1ap(): m_s1mme(-1), - m_next_mme_ue_s1ap_id(1) + m_next_mme_ue_s1ap_id(1), + m_mme_gtpc(NULL), + m_pool(NULL) { } From 6fc9c96c58b7856c3a23ec87a3ceccd0a0e3129f Mon Sep 17 00:00:00 2001 From: Xavier Arteaga Date: Wed, 28 Feb 2018 12:02:17 +0100 Subject: [PATCH 015/134] Added CSI softbits weightening for Single antenna transmission --- lib/include/srslte/phy/mimo/precoding.h | 3 + lib/include/srslte/phy/phch/pdsch.h | 6 ++ lib/include/srslte/phy/utils/simd.h | 12 +++- .../phy/ch_estimation/test/chest_test_dl.c | 4 +- lib/src/phy/mimo/precoding.c | 58 +++++++++++++++++-- lib/src/phy/mimo/test/precoder_test.c | 2 +- lib/src/phy/phch/pbch.c | 2 +- lib/src/phy/phch/pcfich.c | 2 +- lib/src/phy/phch/pdcch.c | 2 +- lib/src/phy/phch/pdsch.c | 52 ++++++++++++++++- lib/src/phy/phch/phich.c | 2 +- lib/src/phy/phch/pmch.c | 2 +- lib/src/phy/phch/pucch.c | 2 +- lib/src/phy/phch/pusch.c | 2 +- 14 files changed, 135 insertions(+), 16 deletions(-) diff --git a/lib/include/srslte/phy/mimo/precoding.h b/lib/include/srslte/phy/mimo/precoding.h index f8463d1cb..27395085c 100644 --- a/lib/include/srslte/phy/mimo/precoding.h +++ b/lib/include/srslte/phy/mimo/precoding.h @@ -79,6 +79,7 @@ SRSLTE_API int srslte_precoding_type(cf_t *x[SRSLTE_MAX_LAYERS], SRSLTE_API int srslte_predecoding_single(cf_t *y, cf_t *h, cf_t *x, + float *csi, int nof_symbols, float scaling, float noise_estimate); @@ -86,6 +87,7 @@ SRSLTE_API int srslte_predecoding_single(cf_t *y, SRSLTE_API int srslte_predecoding_single_multi(cf_t *y[SRSLTE_MAX_PORTS], cf_t *h[SRSLTE_MAX_PORTS], cf_t *x, + float *csi, int nof_rxant, int nof_symbols, float scaling, @@ -111,6 +113,7 @@ SRSLTE_API void srslte_predecoding_set_mimo_decoder (srslte_mimo_decoder_t _mimo SRSLTE_API int srslte_predecoding_type(cf_t *y[SRSLTE_MAX_PORTS], cf_t *h[SRSLTE_MAX_PORTS][SRSLTE_MAX_PORTS], cf_t *x[SRSLTE_MAX_LAYERS], + float *csi, int nof_rxant, int nof_ports, int nof_layers, diff --git a/lib/include/srslte/phy/phch/pdsch.h b/lib/include/srslte/phy/phch/pdsch.h index dab900d77..1889078e6 100644 --- a/lib/include/srslte/phy/phch/pdsch.h +++ b/lib/include/srslte/phy/phch/pdsch.h @@ -76,6 +76,9 @@ typedef struct SRSLTE_API { cf_t *d[SRSLTE_MAX_CODEWORDS]; /* Modulated/Demodulated codewords */ void *e[SRSLTE_MAX_CODEWORDS]; + bool csi_enabled; + float *csi[SRSLTE_MAX_CODEWORDS]; /* Channel Strengh Indicator */ + /* tx & rx objects */ srslte_modem_table_t mod[4]; @@ -107,6 +110,9 @@ SRSLTE_API int srslte_pdsch_set_rnti(srslte_pdsch_t *q, SRSLTE_API void srslte_pdsch_set_power_allocation(srslte_pdsch_t *q, float rho_a); +SRSLTE_API int srslte_pdsch_enable_csi(srslte_pdsch_t *q, + bool enable); + SRSLTE_API void srslte_pdsch_free_rnti(srslte_pdsch_t *q, uint16_t rnti); diff --git a/lib/include/srslte/phy/utils/simd.h b/lib/include/srslte/phy/utils/simd.h index e22a9ef09..3b5a00a8a 100644 --- a/lib/include/srslte/phy/utils/simd.h +++ b/lib/include/srslte/phy/utils/simd.h @@ -530,7 +530,7 @@ static inline simd_cf_t srslte_simd_cfi_loadu(const cf_t *ptr) { 0x11, 0x13, 0x15, 0x17, 0x19, 0x1B, 0x1D, 0x1F), in2); #else /* LV_HAVE_AVX512 */ - #ifdef LV_HAVE_AVX2 +#ifdef LV_HAVE_AVX2 __m256 in1 = _mm256_permute_ps(_mm256_loadu_ps((float*)(ptr)), 0b11011000); __m256 in2 = _mm256_permute_ps(_mm256_loadu_ps((float*)(ptr + 4)), 0b11011000); ret.re = _mm256_unpacklo_ps(in1, in2); @@ -705,6 +705,16 @@ static inline void srslte_simd_cf_storeu(float *re, float *im, simd_cf_t simdreg #endif /* LV_HAVE_AVX512 */ } +static inline simd_f_t srslte_simd_cf_re(simd_cf_t in) { + simd_f_t out = in.re; +#ifdef LV_HAVE_AVX2 + /* Permute for AVX registers (mis SSE registers) */ + const __m256i idx = _mm256_setr_epi32(0, 2, 4, 6, 1, 3, 5, 7); + out = _mm256_permutevar8x32_ps(out, idx); +#endif /* LV_HAVE_AVX2 */ + return out; +} + static inline simd_cf_t srslte_simd_cf_set1 (cf_t x) { simd_cf_t ret; #ifdef LV_HAVE_AVX512 diff --git a/lib/src/phy/ch_estimation/test/chest_test_dl.c b/lib/src/phy/ch_estimation/test/chest_test_dl.c index 62f7e1c86..222263c7e 100644 --- a/lib/src/phy/ch_estimation/test/chest_test_dl.c +++ b/lib/src/phy/ch_estimation/test/chest_test_dl.c @@ -173,7 +173,7 @@ int main(int argc, char **argv) { gettimeofday(&t[1], NULL); for (int j=0;j<100;j++) { - srslte_predecoding_single(input, ce, output, num_re, 1.0f, 0); + srslte_predecoding_single(input, ce, output, NULL, num_re, 1.0f, 0); } gettimeofday(&t[2], NULL); get_time_interval(t); @@ -188,7 +188,7 @@ int main(int argc, char **argv) { gettimeofday(&t[1], NULL); for (int j=0;j<100;j++) { - srslte_predecoding_single(input, ce, output, num_re, 1.0f, srslte_chest_dl_get_noise_estimate(&est)); + srslte_predecoding_single(input, ce, output, NULL, num_re, 1.0f, srslte_chest_dl_get_noise_estimate(&est)); } gettimeofday(&t[2], NULL); get_time_interval(t); diff --git a/lib/src/phy/mimo/precoding.c b/lib/src/phy/mimo/precoding.c index 6d50e3ed2..f8faeda75 100644 --- a/lib/src/phy/mimo/precoding.c +++ b/lib/src/phy/mimo/precoding.c @@ -34,6 +34,7 @@ #include "srslte/phy/utils/vector.h" #include "srslte/phy/utils/debug.h" #include "srslte/phy/utils/mat.h" +#include "srslte/phy/utils/simd.h" #ifdef LV_HAVE_SSE #include @@ -252,8 +253,49 @@ int srslte_predecoding_single_gen(cf_t *y[SRSLTE_MAX_PORTS], cf_t *h[SRSLTE_MAX_ return nof_symbols; } +int srslte_predecoding_single_csi(cf_t *y[SRSLTE_MAX_PORTS], cf_t *h[SRSLTE_MAX_PORTS], cf_t *x, float *csi, int nof_rxant, int nof_symbols, float scaling, float noise_estimate) { + int i = 0; + +#if SRSLTE_SIMD_CF_SIZE + const simd_f_t _noise = srslte_simd_f_set1(noise_estimate); + const simd_f_t _scaling = srslte_simd_f_set1(1.0f / scaling); + + for (; i < nof_symbols - SRSLTE_SIMD_CF_SIZE + 1; i += SRSLTE_SIMD_CF_SIZE) { + simd_cf_t _r = srslte_simd_cf_zero(); + simd_f_t _hh = srslte_simd_f_zero(); + + for (int p = 0; p < nof_rxant; p++) { + simd_cf_t _y = srslte_simd_cfi_load(&y[p][i]); + simd_cf_t _h = srslte_simd_cfi_load(&h[p][i]); + + _r = srslte_simd_cf_add(_r, srslte_simd_cf_conjprod(_y, _h)); + _hh = srslte_simd_f_add(_hh, srslte_simd_cf_re(srslte_simd_cf_conjprod(_h, _h))); + } + + simd_f_t _csi = srslte_simd_f_add(_hh, _noise); + simd_cf_t _x = srslte_simd_cf_mul(srslte_simd_cf_mul(_r, _scaling), srslte_simd_f_rcp(_csi)); + + srslte_simd_f_store(&csi[i], _csi); + srslte_simd_cfi_store(&x[i], _x); + } +#endif + + for (; i < nof_symbols; i++) { + cf_t r = 0; + float hh = 0; + float _scaling = 1.0f / scaling; + for (int p = 0; p < nof_rxant; p++) { + r += y[p][i] * conj(h[p][i]); + hh += (__real__ h[p][i] * __real__ h[p][i]) + (__imag__ h[p][i] * __imag__ h[p][i]); + } + csi[i] = hh + noise_estimate; + x[i] = r * _scaling / csi[i]; + } + return nof_symbols; +} + /* ZF/MMSE SISO equalizer x=y(h'h+no)^(-1)h' (ZF if n0=0.0)*/ -int srslte_predecoding_single(cf_t *y_, cf_t *h_, cf_t *x, int nof_symbols, float scaling, float noise_estimate) { +int srslte_predecoding_single(cf_t *y_, cf_t *h_, cf_t *x, float *csi, int nof_symbols, float scaling, float noise_estimate) { cf_t *y[SRSLTE_MAX_PORTS]; cf_t *h[SRSLTE_MAX_PORTS]; @@ -261,6 +303,10 @@ int srslte_predecoding_single(cf_t *y_, cf_t *h_, cf_t *x, int nof_symbols, floa h[0] = h_; int nof_rxant = 1; + if (csi) { + return srslte_predecoding_single_csi(y, h, x, csi, nof_rxant, nof_symbols, scaling, noise_estimate); + } + #ifdef LV_HAVE_AVX if (nof_symbols > 32 && nof_rxant <= 2) { return srslte_predecoding_single_avx(y, h, x, nof_rxant, nof_symbols, scaling, noise_estimate); @@ -281,8 +327,12 @@ int srslte_predecoding_single(cf_t *y_, cf_t *h_, cf_t *x, int nof_symbols, floa } /* ZF/MMSE SISO equalizer x=y(h'h+no)^(-1)h' (ZF if n0=0.0)*/ -int srslte_predecoding_single_multi(cf_t *y[SRSLTE_MAX_PORTS], cf_t *h[SRSLTE_MAX_PORTS], cf_t *x, +int srslte_predecoding_single_multi(cf_t *y[SRSLTE_MAX_PORTS], cf_t *h[SRSLTE_MAX_PORTS], cf_t *x, float *csi, int nof_rxant, int nof_symbols, float scaling, float noise_estimate) { + if (csi) { + return srslte_predecoding_single_csi(y, h, x, csi, nof_rxant, nof_symbols, scaling, noise_estimate); + } + #ifdef LV_HAVE_AVX if (nof_symbols > 32) { return srslte_predecoding_single_avx(y, h, x, nof_rxant, nof_symbols, scaling, noise_estimate); @@ -1418,7 +1468,7 @@ void srslte_predecoding_set_mimo_decoder (srslte_mimo_decoder_t _mimo_decoder) { /* 36.211 v10.3.0 Section 6.3.4 */ int srslte_predecoding_type(cf_t *y[SRSLTE_MAX_PORTS], cf_t *h[SRSLTE_MAX_PORTS][SRSLTE_MAX_PORTS], - cf_t *x[SRSLTE_MAX_LAYERS], int nof_rxant, int nof_ports, int nof_layers, + cf_t *x[SRSLTE_MAX_LAYERS], float *csi, int nof_rxant, int nof_ports, int nof_layers, int codebook_idx, int nof_symbols, srslte_mimo_type_t type, float scaling, float noise_estimate) { @@ -1451,7 +1501,7 @@ int srslte_predecoding_type(cf_t *y[SRSLTE_MAX_PORTS], cf_t *h[SRSLTE_MAX_PORTS] return -1; case SRSLTE_MIMO_TYPE_SINGLE_ANTENNA: if (nof_ports == 1 && nof_layers == 1) { - return srslte_predecoding_single_multi(y, h[0], x[0], nof_rxant, nof_symbols, scaling, noise_estimate); + return srslte_predecoding_single_multi(y, h[0], x[0], csi, nof_rxant, nof_symbols, scaling, noise_estimate); } else { fprintf(stderr, "Number of ports and layers must be 1 for transmission on single antenna ports (%d, %d)\n", nof_ports, nof_layers); diff --git a/lib/src/phy/mimo/test/precoder_test.c b/lib/src/phy/mimo/test/precoder_test.c index 1054545c3..a6925f318 100644 --- a/lib/src/phy/mimo/test/precoder_test.c +++ b/lib/src/phy/mimo/test/precoder_test.c @@ -291,7 +291,7 @@ int main(int argc, char **argv) { /* predecoding / equalization */ struct timeval t[3]; gettimeofday(&t[1], NULL); - srslte_predecoding_type(r, h, xr, nof_rx_ports, nof_tx_ports, nof_layers, + srslte_predecoding_type(r, h, xr, NULL, nof_rx_ports, nof_tx_ports, nof_layers, codebook_idx, nof_re, type, scaling, powf(10, -snr_db / 10)); gettimeofday(&t[2], NULL); get_time_interval(t); diff --git a/lib/src/phy/phch/pbch.c b/lib/src/phy/phch/pbch.c index c72b12c60..e7c0c33af 100644 --- a/lib/src/phy/phch/pbch.c +++ b/lib/src/phy/phch/pbch.c @@ -497,7 +497,7 @@ int srslte_pbch_decode(srslte_pbch_t *q, cf_t *slot1_symbols, cf_t *ce_slot1[SRS /* in control channels, only diversity is supported */ if (nant == 1) { /* no need for layer demapping */ - srslte_predecoding_single(q->symbols[0], q->ce[0], q->d, q->nof_symbols, 1.0f, noise_estimate); + srslte_predecoding_single(q->symbols[0], q->ce[0], q->d, NULL, q->nof_symbols, 1.0f, noise_estimate); } else { srslte_predecoding_diversity(q->symbols[0], q->ce, x, nant, q->nof_symbols, 1.0f); diff --git a/lib/src/phy/phch/pcfich.c b/lib/src/phy/phch/pcfich.c index 7269000a8..6b00e768a 100644 --- a/lib/src/phy/phch/pcfich.c +++ b/lib/src/phy/phch/pcfich.c @@ -219,7 +219,7 @@ int srslte_pcfich_decode_multi(srslte_pcfich_t *q, cf_t *sf_symbols[SRSLTE_MAX_P /* in control channels, only diversity is supported */ if (q->cell.nof_ports == 1) { /* no need for layer demapping */ - srslte_predecoding_single_multi(q_symbols, q_ce[0], q->d, q->nof_rx_antennas, q->nof_symbols, 1.0f, noise_estimate); + srslte_predecoding_single_multi(q_symbols, q_ce[0], q->d, NULL, q->nof_rx_antennas, q->nof_symbols, 1.0f, noise_estimate); } else { srslte_predecoding_diversity_multi(q_symbols, q_ce, x, q->nof_rx_antennas, q->cell.nof_ports, q->nof_symbols, 1.0f); srslte_layerdemap_diversity(x, q->d, q->cell.nof_ports, q->nof_symbols / q->cell.nof_ports); diff --git a/lib/src/phy/phch/pdcch.c b/lib/src/phy/phch/pdcch.c index 206ef1be6..83f681f8f 100644 --- a/lib/src/phy/phch/pdcch.c +++ b/lib/src/phy/phch/pdcch.c @@ -490,7 +490,7 @@ int srslte_pdcch_extract_llr_multi(srslte_pdcch_t *q, cf_t *sf_symbols[SRSLTE_MA /* in control channels, only diversity is supported */ if (q->cell.nof_ports == 1) { /* no need for layer demapping */ - srslte_predecoding_single_multi(q->symbols, q->ce[0], q->d, q->nof_rx_antennas, nof_symbols, 1.0f, noise_estimate/2); + srslte_predecoding_single_multi(q->symbols, q->ce[0], q->d, NULL, q->nof_rx_antennas, nof_symbols, 1.0f, noise_estimate/2); } else { srslte_predecoding_diversity_multi(q->symbols, q->ce, x, q->nof_rx_antennas, q->cell.nof_ports, nof_symbols, 1.0f); srslte_layerdemap_diversity(x, q->d, q->cell.nof_ports, nof_symbols / q->cell.nof_ports); diff --git a/lib/src/phy/phch/pdsch.c b/lib/src/phy/phch/pdsch.c index 1cf4af4e2..4cfa5c75c 100644 --- a/lib/src/phy/phch/pdsch.c +++ b/lib/src/phy/phch/pdsch.c @@ -294,6 +294,10 @@ void srslte_pdsch_free(srslte_pdsch_t *q) { if (q->d[i]) { free(q->d[i]); } + + if (q->csi[i]) { + free(q->csi[i]); + } } /* Free sch objects */ @@ -394,6 +398,22 @@ void srslte_pdsch_set_power_allocation(srslte_pdsch_t *q, float rho_a) { } } +int srslte_pdsch_enable_csi(srslte_pdsch_t *q, bool enable) { + if (enable) { + for (int i = 0; i < SRSLTE_MAX_CODEWORDS; i++) { + if (!q->csi[i]) { + q->csi[i] = srslte_vec_malloc(sizeof(float) * q->max_re); + if (!q->csi[i]) { + return SRSLTE_ERROR; + } + } + } + } + q->csi_enabled = enable; + + return SRSLTE_SUCCESS; +} + void srslte_pdsch_free_rnti(srslte_pdsch_t* q, uint16_t rnti) { uint32_t rnti_idx = q->is_ue?0:rnti; @@ -617,6 +637,36 @@ static int srslte_pdsch_codeword_decode(srslte_pdsch_t *q, srslte_pdsch_cfg_t *c /* Bit scrambling */ srslte_scrambling_s_offset(seq, q->e[codeword_idx], 0, nbits->nof_bits); + uint32_t qm = nbits->nof_bits/nbits->nof_re; + switch(cfg->grant.mcs[tb_idx].mod) { + + case SRSLTE_MOD_BPSK: + qm = 1; + break; + case SRSLTE_MOD_QPSK: + qm = 2; + break; + case SRSLTE_MOD_16QAM: + qm = 4; + break; + case SRSLTE_MOD_64QAM: + qm = 6; + break; + default: + ERROR("No modulation"); + } + + int16_t *e = q->e[codeword_idx]; + + if (q->csi_enabled) { + for (int i = 0; i < nbits->nof_bits / qm; i++) { + float csi = q->csi[codeword_idx][i]; + for (int k = 0; k < qm; k++) { + e[qm * i + k] = (int16_t) ((float) e[qm * i + k] * csi); + } + } + } + /* Return */ ret = srslte_dlsch_decode2(&q->dl_sch, cfg, softbuffer, q->e[codeword_idx], data, tb_idx); @@ -702,7 +752,7 @@ int srslte_pdsch_decode(srslte_pdsch_t *q, } // Pre-decoder - if (srslte_predecoding_type(q->symbols, q->ce, x, q->nof_rx_antennas, q->cell.nof_ports, cfg->nof_layers, + if (srslte_predecoding_type(q->symbols, q->ce, x, q->csi[0], q->nof_rx_antennas, q->cell.nof_ports, cfg->nof_layers, cfg->codebook_idx, cfg->nbits[0].nof_re, cfg->mimo_type, pdsch_scaling, noise_estimate)<0) { DEBUG("Error predecoding\n"); return SRSLTE_ERROR; diff --git a/lib/src/phy/phch/phich.c b/lib/src/phy/phch/phich.c index 6990d69e2..15aa4db88 100644 --- a/lib/src/phy/phch/phich.c +++ b/lib/src/phy/phch/phich.c @@ -239,7 +239,7 @@ int srslte_phich_decode(srslte_phich_t *q, cf_t *sf_symbols[SRSLTE_MAX_PORTS], /* in control channels, only diversity is supported */ if (q->cell.nof_ports == 1) { /* no need for layer demapping */ - srslte_predecoding_single_multi(q_sf_symbols, q_ce[0], q->d0, q->nof_rx_antennas, SRSLTE_PHICH_MAX_NSYMB, 1.0f, noise_estimate); + srslte_predecoding_single_multi(q_sf_symbols, q_ce[0], q->d0, NULL, q->nof_rx_antennas, SRSLTE_PHICH_MAX_NSYMB, 1.0f, noise_estimate); } else { srslte_predecoding_diversity_multi(q_sf_symbols, q_ce, x, q->nof_rx_antennas, q->cell.nof_ports, SRSLTE_PHICH_MAX_NSYMB, 1.0f); srslte_layerdemap_diversity(x, q->d0, q->cell.nof_ports, SRSLTE_PHICH_MAX_NSYMB / q->cell.nof_ports); diff --git a/lib/src/phy/phch/pmch.c b/lib/src/phy/phch/pmch.c index c1c322f34..c7ec0b204 100644 --- a/lib/src/phy/phch/pmch.c +++ b/lib/src/phy/phch/pmch.c @@ -378,7 +378,7 @@ int srslte_pmch_decode_multi(srslte_pmch_t *q, } // No tx diversity in MBSFN - srslte_predecoding_single_multi(q->symbols, q->ce[0], q->d, q->nof_rx_antennas, cfg->nbits[0].nof_re, 1.0f, noise_estimate); + srslte_predecoding_single_multi(q->symbols, q->ce[0], q->d, NULL, q->nof_rx_antennas, cfg->nbits[0].nof_re, 1.0f, noise_estimate); if (SRSLTE_VERBOSE_ISDEBUG()) { DEBUG("SAVED FILE subframe.dat: received subframe symbols\n"); diff --git a/lib/src/phy/phch/pucch.c b/lib/src/phy/phch/pucch.c index b1317de3e..dd3977757 100644 --- a/lib/src/phy/phch/pucch.c +++ b/lib/src/phy/phch/pucch.c @@ -787,7 +787,7 @@ int srslte_pucch_decode(srslte_pucch_t* q, srslte_pucch_format_t format, } // Equalization - srslte_predecoding_single(q->z_tmp, q->ce, q->z, nof_re, 1.0f, noise_estimate); + srslte_predecoding_single(q->z_tmp, q->ce, q->z, NULL, nof_re, 1.0f, noise_estimate); // Perform ML-decoding float corr=0, corr_max=-1e9; diff --git a/lib/src/phy/phch/pusch.c b/lib/src/phy/phch/pusch.c index feb4e8b4f..aa049f7c0 100644 --- a/lib/src/phy/phch/pusch.c +++ b/lib/src/phy/phch/pusch.c @@ -596,7 +596,7 @@ int srslte_pusch_decode(srslte_pusch_t *q, } // Equalization - srslte_predecoding_single(q->d, q->ce, q->z, cfg->nbits.nof_re, 1.0f, noise_estimate); + srslte_predecoding_single(q->d, q->ce, q->z, NULL, cfg->nbits.nof_re, 1.0f, noise_estimate); // DFT predecoding srslte_dft_precoding(&q->dft_precoding, q->z, q->d, cfg->grant.L_prb, cfg->nbits.nof_symb); From 8cabfa82cf80a40d5c0de822f5ab59abc69e0e6c Mon Sep 17 00:00:00 2001 From: Xavier Arteaga Date: Wed, 28 Feb 2018 12:30:34 +0100 Subject: [PATCH 016/134] Added CSI report enable option in SRS UE --- lib/include/srslte/interfaces/ue_interfaces.h | 1 + srsue/src/main.cc | 3 +++ srsue/src/phy/phch_worker.cc | 1 + srsue/ue.conf.example | 4 ++++ 4 files changed, 9 insertions(+) diff --git a/lib/include/srslte/interfaces/ue_interfaces.h b/lib/include/srslte/interfaces/ue_interfaces.h index f18a6737b..735e1d02d 100644 --- a/lib/include/srslte/interfaces/ue_interfaces.h +++ b/lib/include/srslte/interfaces/ue_interfaces.h @@ -493,6 +493,7 @@ typedef struct { bool rssi_sensor_enabled; bool sic_pss_enabled; float rx_gain_offset; + bool pdsch_csi_enabled; } phy_args_t; diff --git a/srsue/src/main.cc b/srsue/src/main.cc index 1cac2092d..cce7568b1 100644 --- a/srsue/src/main.cc +++ b/srsue/src/main.cc @@ -269,6 +269,9 @@ void parse_args(all_args_t *args, int argc, char *argv[]) { bpo::value(&args->expert.phy.estimator_fil_w)->default_value(0.1), "Chooses the coefficients for the 3-tap channel estimator centered filter.") + ("expert.pdsch_csi_enabled", + bpo::value(&args->expert.phy.pdsch_csi_enabled)->default_value(false), + "Stores the Channel State Information and uses it for weightening the softbits. It is only compatible with TM1.") ("rf_calibration.tx_corr_dc_gain", bpo::value(&args->rf_cal.tx_corr_dc_gain)->default_value(0.0), "TX DC offset gain correction") diff --git a/srsue/src/phy/phch_worker.cc b/srsue/src/phy/phch_worker.cc index 6a533759b..ce4fb5d7f 100644 --- a/srsue/src/phy/phch_worker.cc +++ b/srsue/src/phy/phch_worker.cc @@ -137,6 +137,7 @@ bool phch_worker::init(uint32_t max_prb, srslte::log *log_h, srslte::log *log_ph srslte_chest_dl_cfo_estimate_enable(&ue_dl.chest, phy->args->cfo_ref_mask!=0, phy->args->cfo_ref_mask); srslte_ue_ul_set_normalization(&ue_ul, true); srslte_ue_ul_set_cfo_enable(&ue_ul, true); + srslte_pdsch_enable_csi(&ue_dl.pdsch, phy->args->pdsch_csi_enabled); mem_initiated = true; diff --git a/srsue/ue.conf.example b/srsue/ue.conf.example index b8cc43c2e..a288470d3 100644 --- a/srsue/ue.conf.example +++ b/srsue/ue.conf.example @@ -173,6 +173,9 @@ enable = false # cfo_loop_pss_timeout: After the PSS estimation is below cfo_loop_pss_tol for cfo_loop_pss_timeout times consecutively, # RS adjustments are allowed. # +# pdsch_csi_enabled: Stores the Channel State Information and uses it for weightening the softbits. It is only +# compatible with TM1. It is False by default. +# ##################################################################### [expert] #ip_netmask = 255.255.255.0 @@ -196,6 +199,7 @@ enable = false #pregenerate_signals = false #metrics_csv_enable = false #metrics_csv_filename = /tmp/ue_metrics.csv +#pdsch_csi_enabled = true # Caution! Only TM1 supported! # CFO related values #cfo_integer_enabled = false From fafed4a4a00f4ab5ac5162bb1f612fd7716f1065 Mon Sep 17 00:00:00 2001 From: yagoda Date: Wed, 28 Feb 2018 17:58:47 +0000 Subject: [PATCH 017/134] small fix in mbsfn ofdm --- lib/src/phy/dft/ofdm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/src/phy/dft/ofdm.c b/lib/src/phy/dft/ofdm.c index e266023bb..977f37892 100644 --- a/lib/src/phy/dft/ofdm.c +++ b/lib/src/phy/dft/ofdm.c @@ -128,6 +128,8 @@ int srslte_ofdm_init_mbsfn_(srslte_ofdm_t *q, srslte_cp_t cp, cf_t *in_buffer, c if (sf_type == SRSLTE_SF_MBSFN) { q->mbsfn_subframe = true; q->non_mbsfn_region = 2; // default set to 2 + } else { + q->mbsfn_subframe = false; } return SRSLTE_SUCCESS; From a92a5d65f8ac38edd52fb1b2deafb2a86ea86c05 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Thu, 1 Mar 2018 12:30:47 +0100 Subject: [PATCH 018/134] Try to fix tx_end issue during HO --- srsue/src/phy/phch_recv.cc | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 6737f52e0..46973b125 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -397,16 +397,11 @@ bool phch_recv::cell_handover(srslte_cell_t cell) usleep(1000); cnt++; } - cnt = 0; - while(!is_in_idle_rx && cnt<20) { - usleep(1000); - cnt++; - } for(uint32_t i=0;iget_nof_workers();i++) { ((phch_worker*) workers_pool->get_worker(i))->reset(); } worker_com->reset(); - worker_com->reset_ul(); + radio_h->tx_end(); if (is_in_idle_rx) { Info("Cell HO: Reconfiguring cell\n"); if (set_cell()) { From fb53a515daac1f9d369e71a4ae8a9c0d393aa42a Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Thu, 1 Mar 2018 12:48:14 +0100 Subject: [PATCH 019/134] Disable tx_end during HO --- srsue/src/phy/phch_recv.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 46973b125..68d7d6c3c 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -401,7 +401,7 @@ bool phch_recv::cell_handover(srslte_cell_t cell) ((phch_worker*) workers_pool->get_worker(i))->reset(); } worker_com->reset(); - radio_h->tx_end(); + //radio_h->tx_end(); if (is_in_idle_rx) { Info("Cell HO: Reconfiguring cell\n"); if (set_cell()) { From 2a69211f32a032918766d28a9fbdd624c11f1d2e Mon Sep 17 00:00:00 2001 From: Xavier Arteaga Date: Thu, 1 Mar 2018 13:59:01 +0100 Subject: [PATCH 020/134] SCH does not terminate all codeblocks if one fail. Also, SCH does not decode blocks with CRC=OK --- lib/include/srslte/phy/fec/softbuffer.h | 3 ++ lib/src/phy/fec/softbuffer.c | 46 ++++++++++++++++++++++--- lib/src/phy/phch/sch.c | 31 +++++++++++++---- 3 files changed, 69 insertions(+), 11 deletions(-) diff --git a/lib/include/srslte/phy/fec/softbuffer.h b/lib/include/srslte/phy/fec/softbuffer.h index a47cc7b96..3949134d8 100644 --- a/lib/include/srslte/phy/fec/softbuffer.h +++ b/lib/include/srslte/phy/fec/softbuffer.h @@ -42,6 +42,9 @@ typedef struct SRSLTE_API { uint32_t max_cb; int16_t **buffer_f; + uint8_t **data; + bool *cb_crc; + bool tb_crc; } srslte_softbuffer_rx_t; typedef struct SRSLTE_API { diff --git a/lib/src/phy/fec/softbuffer.c b/lib/src/phy/fec/softbuffer.c index 8efa937cb..9ed526825 100644 --- a/lib/src/phy/fec/softbuffer.c +++ b/lib/src/phy/fec/softbuffer.c @@ -47,32 +47,56 @@ int srslte_softbuffer_rx_init(srslte_softbuffer_rx_t *q, uint32_t nof_prb) { int ret = SRSLTE_ERROR_INVALID_INPUTS; if (q != NULL) { - ret = SRSLTE_ERROR; - bzero(q, sizeof(srslte_softbuffer_rx_t)); ret = srslte_ra_tbs_from_idx(26, nof_prb); if (ret != SRSLTE_ERROR) { q->max_cb = (uint32_t) ret / (SRSLTE_TCOD_MAX_LEN_CB - 24) + 1; + ret = SRSLTE_ERROR; q->buffer_f = srslte_vec_malloc(sizeof(int16_t*) * q->max_cb); if (!q->buffer_f) { perror("malloc"); - return SRSLTE_ERROR; + goto clean_exit; } + q->data = srslte_vec_malloc(sizeof(uint8_t*) * q->max_cb); + if (!q->data) { + perror("malloc"); + goto clean_exit; + } + + q->cb_crc = srslte_vec_malloc(sizeof(bool) * q->max_cb); + if (!q->cb_crc) { + perror("malloc"); + goto clean_exit; + } + bzero(q->cb_crc, sizeof(bool) * q->max_cb); + // FIXME: Use HARQ buffer limitation based on UE category for (uint32_t i=0;imax_cb;i++) { q->buffer_f[i] = srslte_vec_malloc(sizeof(int16_t) * SOFTBUFFER_SIZE); if (!q->buffer_f[i]) { perror("malloc"); - return SRSLTE_ERROR; + goto clean_exit; + } + + q->data[i] = srslte_vec_malloc(sizeof(uint8_t) * 6144/8); + if (!q->data[i]) { + perror("malloc"); + goto clean_exit; } } //srslte_softbuffer_rx_reset(q); ret = SRSLTE_SUCCESS; } } + + clean_exit: + if (ret != SRSLTE_SUCCESS) { + srslte_softbuffer_rx_free(q); + } + return ret; } @@ -86,6 +110,17 @@ void srslte_softbuffer_rx_free(srslte_softbuffer_rx_t *q) { } free(q->buffer_f); } + if (q->data) { + for (uint32_t i=0;imax_cb;i++) { + if (q->data[i]) { + free(q->data[i]); + } + } + free(q->data); + } + if (q->cb_crc) { + free(q->cb_crc); + } bzero(q, sizeof(srslte_softbuffer_rx_t)); } } @@ -110,6 +145,9 @@ void srslte_softbuffer_rx_reset_cb(srslte_softbuffer_rx_t *q, uint32_t nof_cb) { } } } + if (q->cb_crc) { + bzero(q->cb_crc, sizeof(bool) * q->max_cb); + } } diff --git a/lib/src/phy/phch/sch.c b/lib/src/phy/phch/sch.c index e6b7d49b9..b679e00f9 100644 --- a/lib/src/phy/phch/sch.c +++ b/lib/src/phy/phch/sch.c @@ -336,14 +336,17 @@ bool decode_tb_cb(srslte_sch_t *q, decoder_input[i] = NULL; } + uint32_t remaining_cb = 0; for (int i=0;icb_crc[i]; + if (softbuffer->cb_crc[i] == false) { + remaining_cb ++; + } } srslte_tdec_reset(&q->decoder, cb_len); - uint32_t remaining_cb = nof_cb; - q->nof_iterations = 0; while(remaining_cb>0) { @@ -401,7 +404,8 @@ bool decode_tb_cb(srslte_sch_t *q, // CRC is OK if (!srslte_crc_checksum_byte(crc_ptr, q->cb_in, len_crc)) { - memcpy(&data[(cb_idx[i]*rlen)/8], q->cb_in, rlen/8 * sizeof(uint8_t)); + memcpy(softbuffer->data[cb_idx[i]], q->cb_in, rlen/8 * sizeof(uint8_t)); + softbuffer->cb_crc[cb_idx[i]] = true; q->nof_iterations += srslte_tdec_get_nof_iterations_cb(&q->decoder, i); @@ -418,15 +422,28 @@ bool decode_tb_cb(srslte_sch_t *q, cb_idx[i], remaining_cb, i, first_cb, nof_cb); q->nof_iterations += q->max_iterations; - q->nof_iterations /= (nof_cb-remaining_cb+1); - return false; + srslte_tdec_reset_cb(&q->decoder, i); + remaining_cb--; + decoder_input[i] = NULL; + cb_idx[i] = 0; } } } } + softbuffer->tb_crc = true; + for (int i = 0; i < nof_cb && softbuffer->tb_crc; i++) { + /* If one CB failed return false */ + softbuffer->tb_crc = softbuffer->cb_crc[i]; + } + if (softbuffer->tb_crc) { + for (int i = 0; i < nof_cb; i++) { + memcpy(&data[i * rlen / 8], softbuffer->data[i], rlen/8 * sizeof(uint8_t)); + } + } + q->nof_iterations /= nof_cb; - return true; + return softbuffer->tb_crc; } /** From ec901373d4487b591c2a735677f8f251c05f2bfb Mon Sep 17 00:00:00 2001 From: Xavier Arteaga Date: Thu, 1 Mar 2018 13:58:04 +0100 Subject: [PATCH 021/134] Correction ofo simd.h for AVX512 --- lib/include/srslte/phy/utils/simd.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/include/srslte/phy/utils/simd.h b/lib/include/srslte/phy/utils/simd.h index 3b5a00a8a..3223c18a7 100644 --- a/lib/include/srslte/phy/utils/simd.h +++ b/lib/include/srslte/phy/utils/simd.h @@ -707,11 +707,13 @@ static inline void srslte_simd_cf_storeu(float *re, float *im, simd_cf_t simdreg static inline simd_f_t srslte_simd_cf_re(simd_cf_t in) { simd_f_t out = in.re; +#ifndef LV_HAVE_AVX512 #ifdef LV_HAVE_AVX2 /* Permute for AVX registers (mis SSE registers) */ const __m256i idx = _mm256_setr_epi32(0, 2, 4, 6, 1, 3, 5, 7); out = _mm256_permutevar8x32_ps(out, idx); #endif /* LV_HAVE_AVX2 */ +#endif /* LV_HAVE_AVX512 */ return out; } From 0fcb065ae8f50ae6ec23c823a4c2db8daa36d42a Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Fri, 2 Mar 2018 14:08:29 +0100 Subject: [PATCH 022/134] Disabled TX continuous and sleep on cell search --- srsue/hdr/mac/dl_harq.h | 13 +++++++------ srsue/hdr/phy/phch_common.h | 2 +- srsue/src/phy/phch_recv.cc | 1 + srsue/src/upper/nas.cc | 1 + 4 files changed, 10 insertions(+), 7 deletions(-) diff --git a/srsue/hdr/mac/dl_harq.h b/srsue/hdr/mac/dl_harq.h index 9a7f66f47..261fb0d41 100644 --- a/srsue/hdr/mac/dl_harq.h +++ b/srsue/hdr/mac/dl_harq.h @@ -253,14 +253,14 @@ private: n_retx = 0; } - // Save grant - grant.last_ndi[tid] = cur_grant.ndi[tid]; - grant.last_tti = cur_grant.tti; - memcpy(&cur_grant, &grant, sizeof(Tgrant)); - // If data has not yet been successfully decoded if (!ack) { + // Save grant + grant.last_ndi[tid] = cur_grant.ndi[tid]; + grant.last_tti = cur_grant.tti; + memcpy(&cur_grant, &grant, sizeof(Tgrant)); + // Instruct the PHY To combine the received data and attempt to decode it if (pid == HARQ_BCCH_PID) { payload_buffer_ptr = harq_entity->demux_unit->request_buffer_bcch(cur_grant.n_bytes[tid]); @@ -281,7 +281,8 @@ private: } else { action->default_ack[tid] = true; - Warning("DL PID %d: Received duplicate TB. Discarting and retransmitting ACK\n", pid); + Warning("DL PID %d: Received duplicate TB. Discarting and retransmitting ACK (grant_tti=%d, ndi=%d, sz=%d)\n", + pid, cur_grant.tti, cur_grant.ndi[tid], cur_grant.n_bytes[tid]); } if (pid == HARQ_BCCH_PID || harq_entity->timer_aligment_timer->is_expired()) { diff --git a/srsue/hdr/phy/phch_common.h b/srsue/hdr/phy/phch_common.h index f21738b6b..e6ce10bc3 100644 --- a/srsue/hdr/phy/phch_common.h +++ b/srsue/hdr/phy/phch_common.h @@ -27,7 +27,7 @@ #ifndef UEPHYWORKERCOMMON_H #define UEPHYWORKERCOMMON_H -#define TX_MODE_CONTINUOUS 1 +#define TX_MODE_CONTINUOUS 0 #include diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 68d7d6c3c..7bb371db4 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -935,6 +935,7 @@ phch_recv::search::ret_code phch_recv::search::run(srslte_cell_t *cell) if (ret < 0) { Error("SYNC: Error decoding MIB: Error searching PSS\n"); + p->stop_rx(); return ERROR; } else if (ret == 0) { p->stop_rx(); diff --git a/srsue/src/upper/nas.cc b/srsue/src/upper/nas.cc index 7f5683867..07d254cdc 100644 --- a/srsue/src/upper/nas.cc +++ b/srsue/src/upper/nas.cc @@ -173,6 +173,7 @@ void nas::plmn_search_end() { } else { nas_log->info("Finished searching PLMN in current EARFCN set but no networks were found.\n"); if (state == EMM_STATE_REGISTERED_INITIATED && plmn_selection == PLMN_NOT_SELECTED) { + sleep(1); rrc->plmn_search(); } } From de747f4e1c7ed50bdde2a0dd57e9c6ba15bf21f5 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Fri, 2 Mar 2018 16:49:52 +0100 Subject: [PATCH 023/134] MUX retx Msg3 correctly --- srsue/hdr/mac/mux.h | 3 ++- srsue/src/mac/mux.cc | 23 ++++++++++++++--------- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/srsue/hdr/mac/mux.h b/srsue/hdr/mac/mux.h index 889dd68f3..17a854711 100644 --- a/srsue/hdr/mac/mux.h +++ b/srsue/hdr/mac/mux.h @@ -104,7 +104,8 @@ private: /* Msg3 Buffer */ static const uint32_t MSG3_BUFF_SZ = 1024; uint8_t msg3_buff[MSG3_BUFF_SZ]; - + uint8_t *msg3_buff_start_pdu; + /* PDU Buffer */ srslte::sch_pdu pdu_msg; bool msg3_has_been_transmitted; diff --git a/srsue/src/mac/mux.cc b/srsue/src/mac/mux.cc index 2f8ade2af..59b94f085 100644 --- a/srsue/src/mac/mux.cc +++ b/srsue/src/mac/mux.cc @@ -46,8 +46,9 @@ mux::mux(uint8_t nof_harq_proc_) : pdu_msg(MAX_NOF_SUBHEADERS), pid_has_bsr(nof_ log_h = NULL; rlc = NULL; bsr_procedure = NULL; - phr_procedure = NULL; - + phr_procedure = NULL; + msg3_buff_start_pdu = NULL; + msg3_flush(); } @@ -347,6 +348,7 @@ void mux::msg3_flush() msg3_has_been_transmitted = false; msg3_pending = false; bzero(msg3_buff, sizeof(MSG3_BUFF_SZ)); + msg3_buff_start_pdu = NULL; } bool mux::msg3_is_transmitted() @@ -366,19 +368,22 @@ bool mux::msg3_is_pending() { uint8_t* mux::msg3_get(uint8_t *payload, uint32_t pdu_sz) { if (pdu_sz < MSG3_BUFF_SZ - 32) { - uint8_t* msg3_buff_start_pdu = pdu_get(msg3_buff, pdu_sz, 0, 0); if (!msg3_buff_start_pdu) { - Error("Moving PDU from Mux unit to Msg3 buffer\n"); - return NULL; + msg3_buff_start_pdu = pdu_get(msg3_buff, pdu_sz, 0, 0); + if (!msg3_buff_start_pdu) { + Error("Moving PDU from Mux unit to Msg3 buffer\n"); + return NULL; + } + msg3_has_been_transmitted = true; + msg3_pending = false; } - memcpy(payload, msg3_buff_start_pdu, sizeof(uint8_t)*pdu_sz); - msg3_has_been_transmitted = true; - msg3_pending = false; - return payload; } else { Error("Msg3 size (%d) is longer than internal msg3_buff size=%d, (see mux.h)\n", pdu_sz, MSG3_BUFF_SZ-32); return NULL; } + memcpy(payload, msg3_buff_start_pdu, sizeof(uint8_t)*pdu_sz); + msg3_has_been_transmitted = true; + return payload; } From fd0c8168f0ea7bda062eab1ecfa3e27d740834eb Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Fri, 2 Mar 2018 20:59:17 +0100 Subject: [PATCH 024/134] Set to Continuous RX and TX --- lib/include/srslte/radio/radio.h | 11 ++- lib/src/phy/rf/rf_uhd_imp.c | 5 +- lib/src/radio/radio.cc | 21 ++--- lib/src/radio/radio_multi.cc | 7 +- srsenb/src/phy/txrx.cc | 4 +- srsue/hdr/phy/phch_common.h | 2 +- srsue/hdr/phy/phch_recv.h | 11 +-- srsue/hdr/upper/rrc.h | 2 +- srsue/src/phy/phch_recv.cc | 153 ++++++------------------------- srsue/src/phy/phch_worker.cc | 2 +- srsue/src/phy/phy.cc | 1 - srsue/src/upper/nas.cc | 1 - 12 files changed, 61 insertions(+), 159 deletions(-) diff --git a/lib/include/srslte/radio/radio.h b/lib/include/srslte/radio/radio.h index 454f1578f..143927730 100644 --- a/lib/include/srslte/radio/radio.h +++ b/lib/include/srslte/radio/radio.h @@ -72,6 +72,8 @@ namespace srslte { trace_enabled = false; tti = 0; agc_enabled = false; + radio_is_streaming = false; + is_initialized = false; }; bool init(char *args = NULL, char *devname = NULL, uint32_t nof_channels = 1); @@ -119,13 +121,13 @@ namespace srslte { void start_trace(); void write_trace(std::string filename); - void start_rx(bool now = false); - void stop_rx(); - + void set_tti(uint32_t tti); bool is_first_of_burst(); + bool is_init(); + void register_error_handler(srslte_rf_error_handler_t h); protected: @@ -168,6 +170,9 @@ namespace srslte { uint32_t tti; bool agc_enabled; + bool is_initialized = true;; + bool radio_is_streaming; + uint32_t saved_nof_channels; char saved_args[128]; char saved_devname[128]; diff --git a/lib/src/phy/rf/rf_uhd_imp.c b/lib/src/phy/rf/rf_uhd_imp.c index 0fc70c547..07eacbfb7 100644 --- a/lib/src/phy/rf/rf_uhd_imp.c +++ b/lib/src/phy/rf/rf_uhd_imp.c @@ -557,11 +557,12 @@ int rf_uhd_open_multi(char *args, void **h, uint32_t nof_channels) uhd_meta_range_free(&gain_range); // Start low priority thread to receive async commands - handler->async_thread_running = true; + /* + handler->async_thread_running = true; if (pthread_create(&handler->async_thread, NULL, async_thread, handler)) { perror("pthread_create"); return -1; - } + }*/ /* Restore priorities */ uhd_set_thread_priority(0, false); diff --git a/lib/src/radio/radio.cc b/lib/src/radio/radio.cc index f3baad4a5..aa7fa0d2c 100644 --- a/lib/src/radio/radio.cc +++ b/lib/src/radio/radio.cc @@ -71,7 +71,12 @@ bool radio::init(char *args, char *devname, uint32_t nof_channels) } saved_nof_channels = nof_channels; - return true; + is_initialized = true; + return true; +} + +bool radio::is_init() { + return is_initialized; } void radio::stop() @@ -141,6 +146,10 @@ bool radio::rx_at(void* buffer, uint32_t nof_samples, srslte_timestamp_t rx_time bool radio::rx_now(void* buffer[SRSLTE_MAX_PORTS], uint32_t nof_samples, srslte_timestamp_t* rxd_time) { + if (!radio_is_streaming) { + srslte_rf_start_rx_stream(&rf_device, true); + radio_is_streaming = true; + } if (srslte_rf_recv_with_time_multi(&rf_device, buffer, nof_samples, true, rxd_time?&rxd_time->full_secs:NULL, rxd_time?&rxd_time->frac_secs:NULL) > 0) { return true; @@ -446,16 +455,6 @@ void radio::set_tx_srate(double srate) tx_adv_sec = nsamples/cur_tx_srate; } -void radio::start_rx(bool now) -{ - srslte_rf_start_rx_stream(&rf_device, now); -} - -void radio::stop_rx() -{ - srslte_rf_stop_rx_stream(&rf_device); -} - void radio::register_error_handler(srslte_rf_error_handler_t h) { srslte_rf_register_error_handler(&rf_device, h); diff --git a/lib/src/radio/radio_multi.cc b/lib/src/radio/radio_multi.cc index 664458c75..df2cb4dfc 100644 --- a/lib/src/radio/radio_multi.cc +++ b/lib/src/radio/radio_multi.cc @@ -37,6 +37,7 @@ bool radio_multi::init_multi(uint32_t nof_rx_antennas, char* args, char* devname strncpy(saved_devname, devname, 127); } + is_initialized = true; return true; } @@ -46,7 +47,11 @@ bool radio_multi::rx_now(cf_t *buffer[SRSLTE_MAX_PORTS], uint32_t nof_samples, s for (int i=0;ifull_secs:NULL, rxd_time?&rxd_time->frac_secs:NULL) > 0) { return true; } else { diff --git a/srsenb/src/phy/txrx.cc b/srsenb/src/phy/txrx.cc index 7e97bd1af..fbc96ea72 100644 --- a/srsenb/src/phy/txrx.cc +++ b/srsenb/src/phy/txrx.cc @@ -104,9 +104,7 @@ void txrx::run_thread() log_h->info("Starting RX/TX thread nof_prb=%d, sf_len=%d\n",worker_com->cell.nof_prb, sf_len); - // Start streaming RX samples - radio_h->start_rx(); - + // Set TTI so that first TX is at tti=0 tti = 10235; diff --git a/srsue/hdr/phy/phch_common.h b/srsue/hdr/phy/phch_common.h index e6ce10bc3..f21738b6b 100644 --- a/srsue/hdr/phy/phch_common.h +++ b/srsue/hdr/phy/phch_common.h @@ -27,7 +27,7 @@ #ifndef UEPHYWORKERCOMMON_H #define UEPHYWORKERCOMMON_H -#define TX_MODE_CONTINUOUS 0 +#define TX_MODE_CONTINUOUS 1 #include diff --git a/srsue/hdr/phy/phch_recv.h b/srsue/hdr/phy/phch_recv.h index 1e15aea62..cea3004f6 100644 --- a/srsue/hdr/phy/phch_recv.h +++ b/srsue/hdr/phy/phch_recv.h @@ -95,7 +95,6 @@ private: void reset(); void radio_error(); - bool wait_radio_reset(); void set_ue_sync_opts(srslte_ue_sync_t *q, float cfo); void run_thread(); @@ -104,14 +103,7 @@ private: bool set_cell(); void cell_search_inc(); - void resync_sfn(bool restart_radio, bool restart_now = false); - bool stop_sync(); - void stop_rx(); - void start_rx(bool now = false); - bool radio_is_rx; - - bool radio_is_resetting; bool running; // Class to run cell search @@ -309,10 +301,9 @@ private: CELL_SELECT, CELL_MEASURE, CELL_CAMP, - IDLE_RX } phy_state; - bool is_in_idle, is_in_idle_rx; + bool is_in_idle; // Sampling rate mode (find is 1.96 MHz, camp is the full cell BW) enum { diff --git a/srsue/hdr/upper/rrc.h b/srsue/hdr/upper/rrc.h index 1bfae16b3..926e2bebe 100644 --- a/srsue/hdr/upper/rrc.h +++ b/srsue/hdr/upper/rrc.h @@ -325,7 +325,7 @@ private: static const uint32_t RRC_PLMN_SELECT_TIMEOUT = 10000; uint32_t select_cell_timeout; - static const uint32_t RRC_SELECT_CELL_TIMEOUT = 2000; + static const uint32_t RRC_SELECT_CELL_TIMEOUT = 1000; uint8_t k_rrc_enc[32]; uint8_t k_rrc_int[32]; diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 7bb371db4..36614a0d1 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -134,7 +134,6 @@ void phch_recv::reset() srate_mode = SRATE_NONE; cell_search_in_progress = false; current_earfcn = 0; - radio_is_resetting = false; sfn_p.reset(); measure_p.reset(); search_p.reset(); @@ -145,7 +144,6 @@ void phch_recv::radio_error() { log_h->error("SYNC: Receiving from radio.\n"); phy_state = IDLE; - radio_is_resetting=true; // Need to find a method to effectively reset radio, reloading the driver does not work //radio_h->reset(); @@ -155,22 +153,12 @@ void phch_recv::radio_error() exit(-1); reset(); - radio_is_resetting=false; } void phch_recv::set_cfo(float cfo) { srslte_ue_sync_set_cfo_ref(&ue_sync, cfo); } -bool phch_recv::wait_radio_reset() { - int cnt=0; - while(cnt < 20 && radio_is_resetting) { - sleep(1); - cnt++; - } - return radio_is_resetting; -} - void phch_recv::set_agc_enable(bool enable) { do_agc = enable; @@ -265,24 +253,6 @@ bool phch_recv::set_cell() { return cell_is_set; } -void phch_recv::resync_sfn(bool restart_radio, bool restart_now) { - - if (restart_radio) { - wait_radio_reset(); - stop_rx(); - usleep(100000); - } - sfn_p.reset(); - search_p.reset(); - srslte_ue_sync_reset(&ue_sync); - - if (restart_radio) { - start_rx(restart_now); - } - - phy_state = CELL_SELECT; -} - void phch_recv::set_earfcn(std::vector earfcn) { this->earfcn = earfcn; } @@ -292,35 +262,14 @@ void phch_recv::force_freq(float dl_freq, float ul_freq) { this->ul_freq = ul_freq; } -bool phch_recv::stop_sync() { - - wait_radio_reset(); - - if (phy_state == IDLE && is_in_idle) { - return true; - } else { - Info("SYNC: Going to IDLE (state=%d)\n", phy_state); - phy_state = IDLE; - int cnt = 0; - while (!is_in_idle && cnt < 100) { - usleep(10000); - cnt++; - } - if (!is_in_idle) { - Warning("SYNC: Could not go to IDLE (state=%d)\n", phy_state); - } - return is_in_idle; - } -} - void phch_recv::reset_sync() { - if (phy_state != CELL_SELECT) { - Warning("SYNC: Resetting sync, cell_search_in_progress=%s\n", cell_search_in_progress?"yes":"no"); - resync_sfn(false); - } else { - Warning("SYNC: Trying to reset sync while in cell reselection\n"); - } + sfn_p.reset(); + search_p.reset(); + measure_p.reset(); + srslte_ue_sync_reset(&ue_sync); + + phy_state = CELL_SELECT; } void phch_recv::cell_search_inc() @@ -345,9 +294,6 @@ void phch_recv::cell_search_inc() void phch_recv::cell_search_next(bool reset) { if (cell_search_in_progress || reset) { cell_search_in_progress = false; - if (!stop_sync()) { - log_h->warning("SYNC: Couldn't stop PHY (state=%d)\n", phy_state); - } if (reset) { cur_earfcn_index = -1; } @@ -373,9 +319,6 @@ void phch_recv::cell_search_start() { void phch_recv::cell_search_stop() { Info("SYNC: Stopping Cell Search procedure...\n"); - if (!stop_sync()) { - Error("SYNC: Stopping cell search\n"); - } cell_search_in_progress = false; } @@ -391,9 +334,9 @@ bool phch_recv::cell_handover(srslte_cell_t cell) bool ret = false; this->cell = cell; Info("Cell HO: Stopping sync with current cell\n"); - phy_state = IDLE_RX; + phy_state = IDLE; cnt = 0; - while(!is_in_idle_rx && cnt<20) { + while(!is_in_idle && cnt<20) { usleep(1000); cnt++; } @@ -401,12 +344,11 @@ bool phch_recv::cell_handover(srslte_cell_t cell) ((phch_worker*) workers_pool->get_worker(i))->reset(); } worker_com->reset(); - //radio_h->tx_end(); - if (is_in_idle_rx) { + if (is_in_idle) { Info("Cell HO: Reconfiguring cell\n"); if (set_cell()) { - resync_sfn(false); Info("Cell HO: Synchronizing with new cell\n"); + phy_state = CELL_SELECT; ret = true; } else { log_h->error("Cell HO: Configuring cell PCI=%d\n", cell.id); @@ -428,18 +370,12 @@ bool phch_recv::cell_select(uint32_t earfcn, srslte_cell_t cell) { if (srate_mode != SRATE_CAMP) { set_sampling_rate(); } - if (phy_state < CELL_SELECT) { - resync_sfn(true, false); - } + phy_state = CELL_SELECT; return true; } else { cell_search_in_progress = false; - if (!stop_sync()) { - log_h->warning("Still not in idle\n"); - } - if (earfcn != current_earfcn) { if (set_frequency()) { log_h->error("Cell Select: Configuring cell in EARFCN=%d, PCI=%d\n", earfcn, cell.id); @@ -453,8 +389,7 @@ bool phch_recv::cell_select(uint32_t earfcn, srslte_cell_t cell) { if (set_cell()) { log_h->info("Cell Select: Synchronizing on cell...\n"); - - resync_sfn(true, false); + phy_state = CELL_SELECT; return true; } return false; @@ -522,22 +457,6 @@ void phch_recv::set_sampling_rate() } } -void phch_recv::stop_rx() { - if (radio_is_rx) { - Info("SYNC: Stopping RX streaming\n"); - radio_h->stop_rx(); - } - radio_is_rx = false; -} - -void phch_recv::start_rx(bool now) { - if (!radio_is_rx) { - Info("SYNC: Starting RX streaming\n"); - radio_h->start_rx(now); - } - radio_is_rx = true; -} - uint32_t phch_recv::get_current_tti() { return tti; } @@ -592,18 +511,19 @@ void phch_recv::run_thread() uint32_t sf_idx = 0; phy_state = IDLE; is_in_idle = true; - is_in_idle_rx = false; + + cf_t *dummy_buffer[SRSLTE_MAX_PORTS]; + + for (int i=0;istep(tti); log_phy_lib_h->step(tti); @@ -624,7 +544,7 @@ void phch_recv::run_thread() } if (set_cell()) { set_sampling_rate(); - resync_sfn(true, false); + phy_state = CELL_SELECT; } break; case search::CELL_NOT_FOUND: @@ -659,7 +579,7 @@ void phch_recv::run_thread() phy_state = CELL_SEARCH; } else { log_h->warning("SYNC: Timeout while synchronizing SFN. Reselecting cell\n"); - resync_sfn(false); + phy_state = CELL_SELECT; } break; case sfn_sync::IDLE: @@ -775,28 +695,18 @@ void phch_recv::run_thread() } break; case IDLE: - if (!is_in_idle) { - stop_rx(); - } - is_in_idle = true; - usleep(1000); - break; - case IDLE_RX: - if (!worker) { - worker = (phch_worker *) workers_pool->wait_worker(tti); - } - is_in_idle_rx = true; - if (worker) { - for (uint32_t i = 0; i < SRSLTE_MAX_PORTS; i++) { - buffer[i] = worker->get_buffer(i); + if (radio_h->is_init()) { + uint32_t nsamples = 1920; + if (current_srate > 0) { + nsamples = current_srate/1000; } - if (!radio_h->rx_now(buffer, SRSLTE_SF_LEN_PRB(cell.nof_prb), NULL)) { - Error("SYNC: Receiving from radio while in IDLE_RX\n"); + if (!radio_h->rx_now(dummy_buffer, nsamples, NULL)) { + printf("SYNC: Receiving from radio while in IDLE_RX\n"); } } else { - // wait_worker() only returns NULL if it's being closed. Quit now to avoid unnecessary loops here - running = false; + usleep(1000); } + is_in_idle = true; break; } @@ -917,7 +827,6 @@ phch_recv::search::ret_code phch_recv::search::run(srslte_cell_t *cell) p->srate_mode = SRATE_FIND; p->radio_h->set_rx_srate(1.92e6); } - p->start_rx(); /* Find a cell in the given N_id_2 or go through the 3 of them to find the strongest */ uint32_t max_peak_cell = 0; @@ -935,10 +844,8 @@ phch_recv::search::ret_code phch_recv::search::run(srslte_cell_t *cell) if (ret < 0) { Error("SYNC: Error decoding MIB: Error searching PSS\n"); - p->stop_rx(); return ERROR; } else if (ret == 0) { - p->stop_rx(); Info("SYNC: Could not find any cell in this frequency\n"); return CELL_NOT_FOUND; } @@ -966,8 +873,6 @@ phch_recv::search::ret_code phch_recv::search::run(srslte_cell_t *cell) ret = srslte_ue_mib_sync_decode(&ue_mib_sync, 40, bch_payload, &cell->nof_ports, &sfn_offset); - p->stop_rx(); - if (ret == 1) { srslte_pbch_mib_unpack(bch_payload, cell, NULL); diff --git a/srsue/src/phy/phch_worker.cc b/srsue/src/phy/phch_worker.cc index 6a533759b..cdfab95b9 100644 --- a/srsue/src/phy/phch_worker.cc +++ b/srsue/src/phy/phch_worker.cc @@ -1380,7 +1380,7 @@ void phch_worker::update_measurements() /* Only worker 0 reads the RSSI sensor every ~1-nof_cores s */ if (get_id() == 0) { - if (rssi_read_cnt) { + if (!rssi_read_cnt) { if (phy->get_radio()->has_rssi() && phy->args->rssi_sensor_enabled) { phy->last_radio_rssi = phy->get_radio()->get_rssi(); phy->rx_gain_offset = phy->avg_rssi_dbm - phy->last_radio_rssi + 30; diff --git a/srsue/src/phy/phy.cc b/srsue/src/phy/phy.cc index cf8ae33f8..3dfb5889a 100644 --- a/srsue/src/phy/phy.cc +++ b/srsue/src/phy/phy.cc @@ -366,7 +366,6 @@ void phy::reset() workers[i].reset(); } workers_common.reset(); - workers_common.reset_ul(); } uint32_t phy::get_current_tti() diff --git a/srsue/src/upper/nas.cc b/srsue/src/upper/nas.cc index 07d254cdc..7f5683867 100644 --- a/srsue/src/upper/nas.cc +++ b/srsue/src/upper/nas.cc @@ -173,7 +173,6 @@ void nas::plmn_search_end() { } else { nas_log->info("Finished searching PLMN in current EARFCN set but no networks were found.\n"); if (state == EMM_STATE_REGISTERED_INITIATED && plmn_selection == PLMN_NOT_SELECTED) { - sleep(1); rrc->plmn_search(); } } From e64f3240cb83a9eec768fe78dbaadcaf3bc13a29 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Fri, 2 Mar 2018 21:33:28 +0100 Subject: [PATCH 025/134] Disable tx_end before PRACH (not needed now?) --- srsue/src/phy/phch_recv.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 36614a0d1..3c2e4fc1e 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -657,10 +657,11 @@ void phch_recv::run_thread() tx_mutex_cnt = (tx_mutex_cnt+1) % nof_tx_mutex; // Reset Uplink TX buffer to avoid mixing packets in TX queue + /* if (prach_buffer->is_pending()) { Info("SYNC: PRACH pending: Reset UL\n"); - worker_com->reset_ul(); - } + radio_h->tx_end(); + }*/ // Check if we need to TX a PRACH if (prach_buffer->is_ready_to_send(tti)) { From df1a0c68e2ed2d37a6d82008545bccd5b8152e62 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Fri, 2 Mar 2018 22:46:24 +0100 Subject: [PATCH 026/134] Disable ul_reset --- srsue/src/phy/phch_common.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/srsue/src/phy/phch_common.cc b/srsue/src/phy/phch_common.cc index 65681c8c6..3c3cf1641 100644 --- a/srsue/src/phy/phch_common.cc +++ b/srsue/src/phy/phch_common.cc @@ -355,13 +355,16 @@ void phch_common::reset() { void phch_common::reset_ul() { + /* is_first_tx = true; - is_first_of_burst = true; + is_first_of_burst = true; + for (uint32_t i=0;itx_end(); + */ } } From fea5c3462c17008512227a846ed923c19a75155c Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Sun, 4 Mar 2018 11:15:51 +0100 Subject: [PATCH 027/134] Start RX with delay --- lib/src/radio/radio.cc | 2 +- lib/src/radio/radio_multi.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/src/radio/radio.cc b/lib/src/radio/radio.cc index aa7fa0d2c..ba2b1d1f0 100644 --- a/lib/src/radio/radio.cc +++ b/lib/src/radio/radio.cc @@ -147,7 +147,7 @@ bool radio::rx_at(void* buffer, uint32_t nof_samples, srslte_timestamp_t rx_time bool radio::rx_now(void* buffer[SRSLTE_MAX_PORTS], uint32_t nof_samples, srslte_timestamp_t* rxd_time) { if (!radio_is_streaming) { - srslte_rf_start_rx_stream(&rf_device, true); + srslte_rf_start_rx_stream(&rf_device, false); radio_is_streaming = true; } if (srslte_rf_recv_with_time_multi(&rf_device, buffer, nof_samples, true, diff --git a/lib/src/radio/radio_multi.cc b/lib/src/radio/radio_multi.cc index df2cb4dfc..ff0a036a2 100644 --- a/lib/src/radio/radio_multi.cc +++ b/lib/src/radio/radio_multi.cc @@ -48,7 +48,7 @@ bool radio_multi::rx_now(cf_t *buffer[SRSLTE_MAX_PORTS], uint32_t nof_samples, s ptr[i] = buffer[i]; } if (!radio_is_streaming) { - srslte_rf_start_rx_stream(&rf_device, true); + srslte_rf_start_rx_stream(&rf_device, false); radio_is_streaming = true; } if (srslte_rf_recv_with_time_multi(&rf_device, ptr, nof_samples, true, From 650f43353267982d3c7d9f4724b51e2c950c9443 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Sun, 4 Mar 2018 11:55:31 +0100 Subject: [PATCH 028/134] Add mutex to worker_imp/set_cell worker --- srsue/hdr/phy/phch_worker.h | 3 ++- srsue/src/phy/phch_worker.cc | 27 +++++++++++++++++++++------ 2 files changed, 23 insertions(+), 7 deletions(-) diff --git a/srsue/hdr/phy/phch_worker.h b/srsue/hdr/phy/phch_worker.h index 78389ccf7..167334918 100644 --- a/srsue/hdr/phy/phch_worker.h +++ b/srsue/hdr/phy/phch_worker.h @@ -119,7 +119,8 @@ private: struct timeval tr_time[3]; srslte::trace tr_exec; bool trace_enabled; - + + pthread_mutex_t mutex; /* Common objects */ phch_common *phy; diff --git a/srsue/src/phy/phch_worker.cc b/srsue/src/phy/phch_worker.cc index cdfab95b9..f8b9e8148 100644 --- a/srsue/src/phy/phch_worker.cc +++ b/srsue/src/phy/phch_worker.cc @@ -86,6 +86,7 @@ phch_worker::~phch_worker() void phch_worker::reset() { + pthread_mutex_lock(&mutex); bzero(&dl_metrics, sizeof(dl_metrics_t)); bzero(&ul_metrics, sizeof(ul_metrics_t)); bzero(&dmrs_cfg, sizeof(srslte_refsignal_dmrs_pusch_cfg_t)); @@ -101,6 +102,7 @@ void phch_worker::reset() I_sr = 0; cfi = 0; rssi_read_cnt = 0; + pthread_mutex_unlock(&mutex); } void phch_worker::set_common(phch_common* phy_) @@ -140,29 +142,35 @@ bool phch_worker::init(uint32_t max_prb, srslte::log *log_h, srslte::log *log_ph mem_initiated = true; + pthread_mutex_init(&mutex, NULL); return true; } bool phch_worker::set_cell(srslte_cell_t cell_) { + bool ret = false; + pthread_mutex_lock(&mutex); if (cell.id != cell_.id || !cell_initiated) { memcpy(&cell, &cell_, sizeof(srslte_cell_t)); if (srslte_ue_dl_set_cell(&ue_dl, cell)) { Error("Initiating UE DL\n"); - return false; + goto unlock; } if (srslte_ue_ul_set_cell(&ue_ul, cell)) { Error("Initiating UE UL\n"); - return false; + goto unlock; } srslte_ue_ul_set_normalization(&ue_ul, true); srslte_ue_ul_set_cfo_enable(&ue_ul, true); cell_initiated = true; } - return true; + ret = true; +unlock: + pthread_mutex_unlock(&mutex); + return ret; } cf_t* phch_worker::get_buffer(uint32_t antenna_idx) @@ -193,9 +201,11 @@ void phch_worker::set_sample_offset(float sample_offset) void phch_worker::set_crnti(uint16_t rnti) { + pthread_mutex_lock(&mutex); srslte_ue_dl_set_rnti(&ue_dl, rnti); srslte_ue_ul_set_rnti(&ue_ul, rnti); - rnti_is_set = true; + rnti_is_set = true; + pthread_mutex_unlock(&mutex); } float phch_worker::get_ref_cfo() @@ -243,7 +253,9 @@ void phch_worker::work_imp() if (!cell_initiated) { return; } - + + pthread_mutex_lock(&mutex); + Debug("TTI %d running\n", tti); #ifdef LOG_EXECTIME @@ -412,7 +424,9 @@ void phch_worker::work_imp() chest_loop->out_of_sync(); } } - + + pthread_mutex_unlock(&mutex); + /* Tell the plotting thread to draw the plots */ #ifdef ENABLE_GUI if ((int) get_id() == plot_worker_id) { @@ -1211,6 +1225,7 @@ void phch_worker::enable_pregen_signals(bool enabled) void phch_worker::set_ul_params(bool pregen_disabled) { + phy_interface_rrc::phy_cfg_common_t *common = &phy->config->common; LIBLTE_RRC_PHYSICAL_CONFIG_DEDICATED_STRUCT *dedicated = &phy->config->dedicated; From 91664ef2beef186ef2717b0003da3afe9de839b0 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Sun, 4 Mar 2018 11:55:58 +0100 Subject: [PATCH 029/134] Do sell reselection on IDLE by phch_recv thread instead of worker --- lib/include/srslte/interfaces/ue_interfaces.h | 2 +- srsue/hdr/phy/phch_recv.h | 7 +++++- srsue/hdr/phy/phy.h | 2 +- srsue/src/phy/phch_recv.cc | 24 ++++++++++++++----- srsue/src/phy/phy.cc | 4 ++-- srsue/src/upper/rrc.cc | 22 +++++++---------- 6 files changed, 36 insertions(+), 25 deletions(-) diff --git a/lib/include/srslte/interfaces/ue_interfaces.h b/lib/include/srslte/interfaces/ue_interfaces.h index f18a6737b..52d11416c 100644 --- a/lib/include/srslte/interfaces/ue_interfaces.h +++ b/lib/include/srslte/interfaces/ue_interfaces.h @@ -582,7 +582,7 @@ public: virtual void cell_search_start() = 0; virtual void cell_search_stop() = 0; virtual void cell_search_next() = 0; - virtual bool cell_select(uint32_t earfcn, srslte_cell_t cell) = 0; + virtual void cell_select(uint32_t earfcn, srslte_cell_t cell) = 0; virtual bool cell_handover(srslte_cell_t cell) = 0; /* Is the PHY downlink synchronized? */ diff --git a/srsue/hdr/phy/phch_recv.h b/srsue/hdr/phy/phch_recv.h index cea3004f6..b5848a6b3 100644 --- a/srsue/hdr/phy/phch_recv.h +++ b/srsue/hdr/phy/phch_recv.h @@ -63,7 +63,7 @@ public: void cell_search_start(); void cell_search_stop(); void cell_search_next(bool reset = false); - bool cell_select(uint32_t earfcn, srslte_cell_t cell); + void cell_select(uint32_t earfcn, srslte_cell_t cell); bool cell_handover(srslte_cell_t cell); void meas_reset(); @@ -103,6 +103,10 @@ private: bool set_cell(); void cell_search_inc(); + void cell_reselect(); + + uint32_t new_earfcn; + srslte_cell_t new_cell; bool running; @@ -299,6 +303,7 @@ private: IDLE = 0, CELL_SEARCH, CELL_SELECT, + CELL_RESELECT, CELL_MEASURE, CELL_CAMP, } phy_state; diff --git a/srsue/hdr/phy/phy.h b/srsue/hdr/phy/phy.h index a29480ad4..9270973c0 100644 --- a/srsue/hdr/phy/phy.h +++ b/srsue/hdr/phy/phy.h @@ -87,7 +87,7 @@ public: void cell_search_start(); void cell_search_stop(); void cell_search_next(); - bool cell_select(uint32_t earfcn, srslte_cell_t phy_cell); + void cell_select(uint32_t earfcn, srslte_cell_t phy_cell); bool cell_handover(srslte_cell_t cell); void meas_reset(); diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 3c2e4fc1e..7a3efeab7 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -361,9 +361,21 @@ bool phch_recv::cell_handover(srslte_cell_t cell) return ret; } -bool phch_recv::cell_select(uint32_t earfcn, srslte_cell_t cell) { +/* interface from higher layers to select a new cell */ +void phch_recv::cell_select(uint32_t earfcn, srslte_cell_t cell) { - // Check if we are already camping in this cell + new_earfcn = earfcn; + new_cell = cell; + phy_state = CELL_RESELECT; +} + +/* Perform cell (re)-selection on IDLE or CAMP */ +void phch_recv::cell_reselect() +{ + uint32_t earfcn = new_earfcn; + srslte_cell_t cell = new_cell; + + // If we are already in the new cell, just resynchronize if (earfcn == current_earfcn && this->cell.id == cell.id) { log_h->info("Cell Select: Already in cell EARFCN=%d\n", earfcn); cell_search_in_progress = false; @@ -371,15 +383,14 @@ bool phch_recv::cell_select(uint32_t earfcn, srslte_cell_t cell) { set_sampling_rate(); } phy_state = CELL_SELECT; - return true; } else { + /* If we are going to a new cell, configure it */ cell_search_in_progress = false; if (earfcn != current_earfcn) { if (set_frequency()) { log_h->error("Cell Select: Configuring cell in EARFCN=%d, PCI=%d\n", earfcn, cell.id); - return false; } current_earfcn = earfcn; } @@ -390,9 +401,7 @@ bool phch_recv::cell_select(uint32_t earfcn, srslte_cell_t cell) { if (set_cell()) { log_h->info("Cell Select: Synchronizing on cell...\n"); phy_state = CELL_SELECT; - return true; } - return false; } } @@ -559,6 +568,9 @@ void phch_recv::run_thread() } } break; + case CELL_RESELECT: + cell_reselect(); + break; case CELL_SELECT: switch (sfn_p.run_subframe(&cell, &tti)) { diff --git a/srsue/src/phy/phy.cc b/srsue/src/phy/phy.cc index 3dfb5889a..a2d517a02 100644 --- a/srsue/src/phy/phy.cc +++ b/srsue/src/phy/phy.cc @@ -282,9 +282,9 @@ int phy::meas_stop(uint32_t earfcn, int pci) { return sf_recv.meas_stop(earfcn, pci); } -bool phy::cell_select(uint32_t earfcn, srslte_cell_t phy_cell) +void phy::cell_select(uint32_t earfcn, srslte_cell_t phy_cell) { - return sf_recv.cell_select(earfcn, phy_cell); + sf_recv.cell_select(earfcn, phy_cell); } bool phy::cell_handover(srslte_cell_t cell) { diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index dfb356b92..1aecb273b 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -525,20 +525,14 @@ void rrc::select_next_cell_in_plmn() { neighbour_cells[i]->in_sync) // matches S criteria { // Try to select Cell - if (phy->cell_select(neighbour_cells[i]->get_earfcn(), neighbour_cells[i]->phy_cell)) { - set_serving_cell(i); - rrc_log->info("Selected cell PCI=%d, EARFCN=%d, Cell ID=0x%x\n", - serving_cell->phy_cell.id, serving_cell->get_earfcn(), - serving_cell->get_cell_id()); - rrc_log->console("Selected cell PCI=%d, EARFCN=%d, Cell ID=0x%x\n", - serving_cell->phy_cell.id, serving_cell->get_earfcn(), - serving_cell->get_cell_id()); - } else { - // Set to out-of-sync if can't synchronize - neighbour_cells[i]->in_sync = false; - rrc_log->warning("Selecting cell EARFCN=%d, Cell ID=0x%x.\n", - neighbour_cells[i]->get_earfcn(), neighbour_cells[i]->get_cell_id()); - } + phy->cell_select(neighbour_cells[i]->get_earfcn(), neighbour_cells[i]->phy_cell); + set_serving_cell(i); + rrc_log->info("Selected cell PCI=%d, EARFCN=%d, Cell ID=0x%x\n", + serving_cell->phy_cell.id, serving_cell->get_earfcn(), + serving_cell->get_cell_id()); + rrc_log->console("Selected cell PCI=%d, EARFCN=%d, Cell ID=0x%x\n", + serving_cell->phy_cell.id, serving_cell->get_earfcn(), + serving_cell->get_cell_id()); return; } } From ed52604d3001e0237eb6f2a0b89cd990c2f988c9 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Sun, 4 Mar 2018 21:51:14 +0100 Subject: [PATCH 030/134] Restart rx_stream on radio error --- lib/src/radio/radio.cc | 7 ++----- srsue/src/phy/phch_recv.cc | 12 +++--------- 2 files changed, 5 insertions(+), 14 deletions(-) diff --git a/lib/src/radio/radio.cc b/lib/src/radio/radio.cc index ba2b1d1f0..7008790a3 100644 --- a/lib/src/radio/radio.cc +++ b/lib/src/radio/radio.cc @@ -87,11 +87,8 @@ void radio::stop() void radio::reset() { printf("Resetting Radio...\n"); - srslte_rf_close(&rf_device); - sleep(3); - if (srslte_rf_open_devname(&rf_device, saved_devname, saved_args, saved_nof_channels)) { - fprintf(stderr, "Error opening RF device\n"); - } + srslte_rf_stop_rx_stream(&rf_device); + radio_is_streaming = false; } void radio::set_manual_calibration(rf_cal_t* calibration) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 7a3efeab7..a6f1a5d84 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -143,16 +143,10 @@ void phch_recv::reset() void phch_recv::radio_error() { log_h->error("SYNC: Receiving from radio.\n"); - phy_state = IDLE; - - // Need to find a method to effectively reset radio, reloading the driver does not work - //radio_h->reset(); - radio_h->stop(); - - fprintf(stdout, "Error while receiving samples. Restart srsUE\n"); - exit(-1); - + phy_state = CELL_SEARCH; reset(); + // Need to find a method to effectively reset radio, reloading the driver does not work + radio_h->reset(); } void phch_recv::set_cfo(float cfo) { From b257ab96bf8ba407ae322e61dd2c8be1c1dee193 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Sun, 4 Mar 2018 21:51:32 +0100 Subject: [PATCH 031/134] Locking on worker::reset() causes dead-lock --- srsue/src/phy/phch_worker.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/srsue/src/phy/phch_worker.cc b/srsue/src/phy/phch_worker.cc index f8b9e8148..3075b0b30 100644 --- a/srsue/src/phy/phch_worker.cc +++ b/srsue/src/phy/phch_worker.cc @@ -86,7 +86,6 @@ phch_worker::~phch_worker() void phch_worker::reset() { - pthread_mutex_lock(&mutex); bzero(&dl_metrics, sizeof(dl_metrics_t)); bzero(&ul_metrics, sizeof(ul_metrics_t)); bzero(&dmrs_cfg, sizeof(srslte_refsignal_dmrs_pusch_cfg_t)); @@ -102,7 +101,6 @@ void phch_worker::reset() I_sr = 0; cfi = 0; rssi_read_cnt = 0; - pthread_mutex_unlock(&mutex); } void phch_worker::set_common(phch_common* phy_) From 3dddae0566a6e8eefda35c71421196aa520bb732 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Thu, 22 Feb 2018 12:18:29 +0100 Subject: [PATCH 032/134] rrc: check pool buffer allocation and handle error --- srsue/src/upper/rrc.cc | 43 +++++++++++++++++++++++------------------- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 1aecb273b..cade0e306 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -1529,10 +1529,13 @@ byte_buffer_t* rrc::byte_align_and_pack(byte_buffer_t *pdu) pdcp_buf = pool_allocate; } - srslte_bit_pack_vector(bit_buf.msg, pdcp_buf->msg, bit_buf.N_bits); - pdcp_buf->N_bytes = bit_buf.N_bits / 8; - pdcp_buf->set_timestamp(); - + if (pdcp_buf != NULL) { + srslte_bit_pack_vector(bit_buf.msg, pdcp_buf->msg, bit_buf.N_bits); + pdcp_buf->N_bytes = bit_buf.N_bits / 8; + pdcp_buf->set_timestamp(); + } else { + rrc_log->error("Fatal Error: Couldn't allocate PDU in byte_align_and_pack().\n"); + } return pdcp_buf; } @@ -1540,20 +1543,21 @@ void rrc::send_ul_ccch_msg(byte_buffer_t *pdu) { liblte_rrc_pack_ul_ccch_msg(&ul_ccch_msg, (LIBLTE_BIT_MSG_STRUCT *) &bit_buf); pdu = byte_align_and_pack(pdu); + if (pdu) { + // Set UE contention resolution ID in MAC + uint64_t uecri = 0; + uint8_t *ue_cri_ptr = (uint8_t *) &uecri; + uint32_t nbytes = 6; + for (uint32_t i = 0; i < nbytes; i++) { + ue_cri_ptr[nbytes - i - 1] = pdu->msg[i]; + } - // Set UE contention resolution ID in MAC - uint64_t uecri = 0; - uint8_t *ue_cri_ptr = (uint8_t *) &uecri; - uint32_t nbytes = 6; - for (uint32_t i = 0; i < nbytes; i++) { - ue_cri_ptr[nbytes - i - 1] = pdu->msg[i]; - } - - rrc_log->debug("Setting UE contention resolution ID: %d\n", uecri); - mac->set_contention_id(uecri); + rrc_log->debug("Setting UE contention resolution ID: %d\n", uecri); + mac->set_contention_id(uecri); - rrc_log->info("Sending %s\n", liblte_rrc_ul_ccch_msg_type_text[ul_ccch_msg.msg_type]); - pdcp->write_sdu(RB_ID_SRB0, pdu); + rrc_log->info("Sending %s\n", liblte_rrc_ul_ccch_msg_type_text[ul_ccch_msg.msg_type]); + pdcp->write_sdu(RB_ID_SRB0, pdu); + } } void rrc::send_ul_dcch_msg(byte_buffer_t *pdu) @@ -1561,9 +1565,10 @@ void rrc::send_ul_dcch_msg(byte_buffer_t *pdu) liblte_rrc_pack_ul_dcch_msg(&ul_dcch_msg, (LIBLTE_BIT_MSG_STRUCT *) &bit_buf); pdu = byte_align_and_pack(pdu); - - rrc_log->info("Sending %s\n", liblte_rrc_ul_dcch_msg_type_text[ul_dcch_msg.msg_type]); - pdcp->write_sdu(RB_ID_SRB1, pdu); + if (pdu) { + rrc_log->info("Sending %s\n", liblte_rrc_ul_dcch_msg_type_text[ul_dcch_msg.msg_type]); + pdcp->write_sdu(RB_ID_SRB1, pdu); + } } void rrc::write_sdu(uint32_t lcid, byte_buffer_t *sdu) { From a85288566bb7786856a058db44f0b4bf6c3d90e9 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Thu, 22 Feb 2018 13:51:20 +0100 Subject: [PATCH 033/134] print summary about allocated buffers when buffer pool is full --- lib/include/srslte/common/buffer_pool.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/include/srslte/common/buffer_pool.h b/lib/include/srslte/common/buffer_pool.h index e48144b6f..4edc50fc6 100644 --- a/lib/include/srslte/common/buffer_pool.h +++ b/lib/include/srslte/common/buffer_pool.h @@ -30,6 +30,8 @@ #include #include #include +#include +#include #include /******************************************************************************* @@ -76,8 +78,13 @@ public: { printf("%d buffers in queue\n", (int) used.size()); #ifdef SRSLTE_BUFFER_POOL_LOG_ENABLED + std::map buffer_cnt; for (uint32_t i=0;idebug_name)?used[i]->debug_name:"Undefined"); + buffer_cnt[strlen(used[i]->debug_name)?used[i]->debug_name:"Undefined"]++; + } + std::map::iterator it; + for (it = buffer_cnt.begin(); it != buffer_cnt.end(); it++) { + printf(" - %dx %s\n", it->second, it->first.c_str()); } #endif } From 507ce037bfa756e4c9843757fa104c7ee949ed4e Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Thu, 22 Feb 2018 14:07:27 +0100 Subject: [PATCH 034/134] parameterize RLC AM stress tester and add to ctest suite --- lib/test/upper/CMakeLists.txt | 3 +- lib/test/upper/rlc_am_stress_test.cc | 71 +++++++++++++++++++++++----- 2 files changed, 60 insertions(+), 14 deletions(-) diff --git a/lib/test/upper/CMakeLists.txt b/lib/test/upper/CMakeLists.txt index 8793118e7..79bbb8331 100644 --- a/lib/test/upper/CMakeLists.txt +++ b/lib/test/upper/CMakeLists.txt @@ -31,7 +31,8 @@ target_link_libraries(rlc_am_test srslte_upper srslte_phy srslte_common) add_test(rlc_am_test rlc_am_test) add_executable(rlc_am_stress_test rlc_am_stress_test.cc) -target_link_libraries(rlc_am_stress_test srslte_upper srslte_phy srslte_common) +target_link_libraries(rlc_am_stress_test srslte_upper srslte_phy srslte_common ${Boost_LIBRARIES}) +add_test(rlc_am_stress_test rlc_am_stress_test --duration 10) add_executable(rlc_um_data_test rlc_um_data_test.cc) target_link_libraries(rlc_um_data_test srslte_upper srslte_phy srslte_common) diff --git a/lib/test/upper/rlc_am_stress_test.cc b/lib/test/upper/rlc_am_stress_test.cc index 137236b4a..c5cf4e877 100644 --- a/lib/test/upper/rlc_am_stress_test.cc +++ b/lib/test/upper/rlc_am_stress_test.cc @@ -31,23 +31,66 @@ #include "srslte/common/logger_stdout.h" #include "srslte/common/threads.h" #include "srslte/upper/rlc.h" +#include +#include #include -#define NBUFS 5 +using namespace std; using namespace srsue; using namespace srslte; +namespace bpo = boost::program_options; + +typedef struct { + uint32_t test_duration_sec; + float error_rate; + uint32_t sdu_gen_delay_usec; +} stress_test_args_t; + +void parse_args(stress_test_args_t *args, int argc, char *argv[]) { + + // Command line only options + bpo::options_description general("General options"); + + general.add_options() + ("help,h", "Produce help message") + ("version,v", "Print version information and exit"); + + // Command line or config file options + bpo::options_description common("Configuration options"); + common.add_options() + ("duration", bpo::value(&args->test_duration_sec)->default_value(10), "Duration (sec)") + ("sdu_gen_delay", bpo::value(&args->sdu_gen_delay_usec)->default_value(10), "SDU generation delay (usec)") + ("error_rate", bpo::value(&args->error_rate)->default_value(0.1), "Rate at which RLC PDUs are dropped"); + + // these options are allowed on the command line + bpo::options_description cmdline_options; + cmdline_options.add(common).add(general); + + // parse the command line and store result in vm + bpo::variables_map vm; + bpo::store(bpo::command_line_parser(argc, argv).options(cmdline_options).run(), vm); + bpo::notify(vm); + + // help option was given - print usage and exit + if (vm.count("help")) { + cout << "Usage: " << argv[0] << " [OPTIONS] config_file" << endl << endl; + cout << common << endl << general << endl; + exit(0); + } +} class mac_reader :public thread { public: - mac_reader(rlc_interface_mac *rlc1_, rlc_interface_mac *rlc2_, float fail_rate_) + mac_reader(rlc_interface_mac *rlc1_, rlc_interface_mac *rlc2_, float fail_rate_, uint32_t sdu_gen_delay_usec_) { rlc1 = rlc1_; rlc2 = rlc2_; fail_rate = fail_rate_; run_enable = true; running = false; + sdu_gen_delay_usec = sdu_gen_delay_usec_; } void stop() @@ -82,7 +125,7 @@ private: if(((float)rand()/RAND_MAX > fail_rate) && read>0) { rlc2->write_pdu(1, pdu->msg, opp_size); } - usleep(100); + usleep(sdu_gen_delay_usec); } running = false; byte_buffer_pool::get_instance()->deallocate(pdu); @@ -91,6 +134,7 @@ private: rlc_interface_mac *rlc1; rlc_interface_mac *rlc2; float fail_rate; + uint32_t sdu_gen_delay_usec; bool run_enable; bool running; @@ -100,9 +144,9 @@ class mac_dummy :public srslte::mac_interface_timers { public: - mac_dummy(rlc_interface_mac *rlc1_, rlc_interface_mac *rlc2_, float fail_rate_) - :r1(rlc1_, rlc2_, fail_rate_) - ,r2(rlc2_, rlc1_, fail_rate_) + mac_dummy(rlc_interface_mac *rlc1_, rlc_interface_mac *rlc2_, float fail_rate_, uint32_t sdu_gen_delay_usec_) + :r1(rlc1_, rlc2_, fail_rate_, sdu_gen_delay_usec_) + ,r2(rlc2_, rlc1_, fail_rate_, sdu_gen_delay_usec_) { } @@ -191,7 +235,7 @@ private: pdu->N_bytes = 1500; pdu->msg[0] = sn++; rlc->write_sdu(1, pdu); - usleep(100); + usleep(10); } running = false; } @@ -205,7 +249,7 @@ private: rlc_interface_pdcp *rlc; }; -void stress_test() +void stress_test(stress_test_args_t args) { srslte::log_filter log1("RLC_AM_1"); srslte::log_filter log2("RLC_AM_2"); @@ -214,14 +258,12 @@ void stress_test() log1.set_hex_limit(-1); log2.set_hex_limit(-1); - float fail_rate = 0.1; - rlc rlc1; rlc rlc2; rlc_am_tester tester1(&rlc1, "tester1"); rlc_am_tester tester2(&rlc2, "tester2"); - mac_dummy mac(&rlc1, &rlc2, fail_rate); + mac_dummy mac(&rlc1, &rlc2, args.error_rate, args.sdu_gen_delay_usec); ue_interface ue; rlc1.init(&tester1, &tester1, &ue, &log1, &mac, 0); @@ -245,7 +287,7 @@ void stress_test() tester2.start(7); mac.start(); - usleep(100e6); + usleep(args.test_duration_sec * 1e6); tester1.stop(); tester2.stop(); @@ -254,6 +296,9 @@ void stress_test() int main(int argc, char **argv) { - stress_test(); + stress_test_args_t args; + parse_args(&args, argc, argv); + + stress_test(args); byte_buffer_pool::get_instance()->cleanup(); } From 2c85da3e4ba41ec5d4f82532de8faf9e227a23e5 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Wed, 21 Feb 2018 13:18:38 +0100 Subject: [PATCH 035/134] initilize variable in log_filter --- lib/src/common/log_filter.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/src/common/log_filter.cc b/lib/src/common/log_filter.cc index b498d466c..8b72a3c2b 100644 --- a/lib/src/common/log_filter.cc +++ b/lib/src/common/log_filter.cc @@ -40,6 +40,7 @@ log_filter::log_filter() do_tti = false; time_src = NULL; time_format = TIME; + logger_h = NULL; } log_filter::log_filter(std::string layer) From f60a9eab415ac08bb8c5e2e8591d3207d1abe058 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Wed, 21 Feb 2018 13:20:34 +0100 Subject: [PATCH 036/134] initialize RF UHD handler in init --- lib/src/phy/rf/rf_uhd_imp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/src/phy/rf/rf_uhd_imp.c b/lib/src/phy/rf/rf_uhd_imp.c index 07eacbfb7..a1bec2657 100644 --- a/lib/src/phy/rf/rf_uhd_imp.c +++ b/lib/src/phy/rf/rf_uhd_imp.c @@ -334,11 +334,12 @@ int rf_uhd_open_multi(char *args, void **h, uint32_t nof_channels) perror("malloc"); return -1; } + bzero(handler, sizeof(rf_uhd_handler_t)); *h = handler; - + /* Set priority to UHD threads */ uhd_set_thread_priority(uhd_default_thread_priority, true); - + /* Find available devices */ uhd_string_vector_handle devices_str; uhd_string_vector_make(&devices_str); From 4a279150224c54cc5f76cd426613aef11a25cae0 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Wed, 21 Feb 2018 13:21:58 +0100 Subject: [PATCH 037/134] bzero dft object during init, add call to fftw_cleanup in dft_exit --- lib/src/phy/dft/dft_fftw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/src/phy/dft/dft_fftw.c b/lib/src/phy/dft/dft_fftw.c index e6eb70ecf..ede6ce69b 100644 --- a/lib/src/phy/dft/dft_fftw.c +++ b/lib/src/phy/dft/dft_fftw.c @@ -58,10 +58,12 @@ void srslte_dft_exit() { #ifdef FFTW_WISDOM_FILE fftwf_export_wisdom_to_filename(FFTW_WISDOM_FILE); #endif + fftwf_cleanup(); } int srslte_dft_plan(srslte_dft_plan_t *plan, const int dft_points, srslte_dft_dir_t dir, srslte_dft_mode_t mode) { + bzero(plan, sizeof(srslte_dft_plan_t)); if(mode == SRSLTE_DFT_COMPLEX){ return srslte_dft_plan_c(plan,dft_points,dir); } else { From 1efcea7e47f88e5fde2b06eec1ee81c3c6e347c8 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Wed, 21 Feb 2018 13:29:10 +0100 Subject: [PATCH 038/134] call dft_exit in various tests --- lib/src/phy/dft/test/ofdm_test.c | 3 +++ lib/src/phy/utils/test/dft_test.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/lib/src/phy/dft/test/ofdm_test.c b/lib/src/phy/dft/test/ofdm_test.c index e77fcd39e..c40be4d0a 100644 --- a/lib/src/phy/dft/test/ofdm_test.c +++ b/lib/src/phy/dft/test/ofdm_test.c @@ -171,5 +171,8 @@ int main(int argc, char **argv) { n_prb++; } + + srslte_dft_exit(); + exit(0); } diff --git a/lib/src/phy/utils/test/dft_test.c b/lib/src/phy/utils/test/dft_test.c index fd5a308a7..b880f8027 100644 --- a/lib/src/phy/utils/test/dft_test.c +++ b/lib/src/phy/utils/test/dft_test.c @@ -157,6 +157,8 @@ int main(int argc, char **argv) { if(test_dft(in) != 0) return -1; + srslte_dft_exit(); + free(in); printf("Done\n"); exit(0); From 57bb831f27c4eb005039b991ef9e80758e67d08d Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Wed, 21 Feb 2018 13:32:21 +0100 Subject: [PATCH 039/134] fix RM turbo test --- lib/src/phy/fec/test/rm_turbo_test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/src/phy/fec/test/rm_turbo_test.c b/lib/src/phy/fec/test/rm_turbo_test.c index 1c5b2abf5..c8a0a95b5 100644 --- a/lib/src/phy/fec/test/rm_turbo_test.c +++ b/lib/src/phy/fec/test/rm_turbo_test.c @@ -198,6 +198,8 @@ int main(int argc, char **argv) { } srslte_rm_turbo_free_tables(); + free(rm_bits_s); + free(rm_bits_f); free(rm_bits); free(rm_bits2); free(rm_bits2_bytes); From 281611b26aabb1bffc2407e5b80d20206bc0c065 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Wed, 21 Feb 2018 13:45:49 +0100 Subject: [PATCH 040/134] allow n param in pss_usrp test --- lib/src/phy/sync/test/pss_usrp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/src/phy/sync/test/pss_usrp.c b/lib/src/phy/sync/test/pss_usrp.c index d82555c95..08afdd025 100644 --- a/lib/src/phy/sync/test/pss_usrp.c +++ b/lib/src/phy/sync/test/pss_usrp.c @@ -74,7 +74,7 @@ void usage(char *prog) { void parse_args(int argc, char **argv) { int opt; - while ((opt = getopt(argc, argv, "adgetvsfil")) != -1) { + while ((opt = getopt(argc, argv, "adgetvnsfil")) != -1) { switch (opt) { case 'a': rf_args = argv[optind]; From f6ee0e1c8a49f53c0c27eacd902288ae14045349 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Wed, 21 Feb 2018 15:47:14 +0100 Subject: [PATCH 041/134] move byte_buffer to UE base class --- srsue/hdr/ue.h | 2 -- srsue/hdr/ue_base.h | 5 ++++- srsue/src/ue.cc | 2 -- srsue/src/ue_base.cc | 6 ++++++ 4 files changed, 10 insertions(+), 5 deletions(-) diff --git a/srsue/hdr/ue.h b/srsue/hdr/ue.h index e36277461..e6c66b540 100644 --- a/srsue/hdr/ue.h +++ b/srsue/hdr/ue.h @@ -110,8 +110,6 @@ private: srslte::log_filter gw_log; srslte::log_filter usim_log; - srslte::byte_buffer_pool *pool; - all_args_t *args; bool started; diff --git a/srsue/hdr/ue_base.h b/srsue/hdr/ue_base.h index 256813d5f..201f63843 100644 --- a/srsue/hdr/ue_base.h +++ b/srsue/hdr/ue_base.h @@ -146,7 +146,7 @@ class ue_base { public: ue_base(); - virtual ~ue_base() {} + virtual ~ue_base(); static ue_base* get_instance(srsue_instance_type_t type); @@ -173,6 +173,9 @@ public: std::string get_build_mode(); std::string get_build_info(); std::string get_build_string(); + +private: + srslte::byte_buffer_pool *pool; }; } // namespace srsue diff --git a/srsue/src/ue.cc b/srsue/src/ue.cc index 2f8fa5794..1de1ddbd0 100644 --- a/srsue/src/ue.cc +++ b/srsue/src/ue.cc @@ -40,12 +40,10 @@ namespace srsue{ ue::ue() :started(false) { - pool = byte_buffer_pool::get_instance(); } ue::~ue() { - byte_buffer_pool::cleanup(); } bool ue::init(all_args_t *args_) diff --git a/srsue/src/ue_base.cc b/srsue/src/ue_base.cc index 4b2c372ae..a4264a099 100644 --- a/srsue/src/ue_base.cc +++ b/srsue/src/ue_base.cc @@ -64,6 +64,12 @@ ue_base::ue_base() { // load FFTW wisdom srslte_dft_load(); + + pool = byte_buffer_pool::get_instance(); +} + +ue_base::~ue_base() { + byte_buffer_pool::cleanup(); } void ue_base::cleanup(void) From 8fcf25360eab03c6c70ceca2e091b92c020473c6 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Wed, 21 Feb 2018 15:48:38 +0100 Subject: [PATCH 042/134] fix missing newline --- srsue/src/phy/phch_recv.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index a6f1a5d84..81c964a7b 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -954,7 +954,7 @@ phch_recv::sfn_sync::ret_code phch_recv::sfn_sync::run_subframe(srslte_cell_t *c srslte_ue_sync_decode_sss_on_track(ue_sync, true); int ret = srslte_ue_sync_zerocopy_multi(ue_sync, buffer); if (ret < 0) { - Error("SYNC: Error calling ue_sync_get_buffer"); + Error("SYNC: Error calling ue_sync_get_buffer.\n"); return ERROR; } From 20e6ed102e03880dc702ba25d79845a431896d9b Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Wed, 21 Feb 2018 15:50:22 +0100 Subject: [PATCH 043/134] fix when accessing uninitialized file --- lib/src/common/logger_file.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/src/common/logger_file.cc b/lib/src/common/logger_file.cc index 25155da08..a911ae20e 100644 --- a/lib/src/common/logger_file.cc +++ b/lib/src/common/logger_file.cc @@ -35,6 +35,7 @@ namespace srslte{ logger_file::logger_file() :inited(false) + ,logfile(NULL) ,not_done(true) ,cur_length(0) ,max_length(0) @@ -46,7 +47,9 @@ logger_file::~logger_file() { if(inited) { wait_thread_finish(); flush(); - fclose(logfile); + if (logfile) { + fclose(logfile); + } } } From 5cfffd11e102ef504cfa213d07316d5fd58242d9 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Wed, 21 Feb 2018 15:51:13 +0100 Subject: [PATCH 044/134] Revert "only reset SDU buffer in RLC AM/UM" This reverts commit 8d852ddfe5e4f6eedb80e247d62b8628f9643c2f. This commit was needed because the order in which objects where destructed on UE exit was such that the byte_buffer was deleted before RLC_AM dtor was called. --- lib/src/upper/rlc_am.cc | 8 ++++++++ lib/src/upper/rlc_um.cc | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/src/upper/rlc_am.cc b/lib/src/upper/rlc_am.cc index bc24f20bd..f4dced1ec 100644 --- a/lib/src/upper/rlc_am.cc +++ b/lib/src/upper/rlc_am.cc @@ -72,6 +72,14 @@ rlc_am::~rlc_am() { // reset RLC and dealloc SDUs stop(); + + if(rx_sdu) { + pool->deallocate(rx_sdu); + } + + if(tx_sdu) { + pool->deallocate(tx_sdu); + } } void rlc_am::init(srslte::log *log_, diff --git a/lib/src/upper/rlc_um.cc b/lib/src/upper/rlc_um.cc index 3fbcbaadf..a365a4501 100644 --- a/lib/src/upper/rlc_um.cc +++ b/lib/src/upper/rlc_um.cc @@ -136,11 +136,11 @@ void rlc_um::reset() vr_uh = 0; pdu_lost = false; if(rx_sdu) { - rx_sdu->reset(); + pool->deallocate(rx_sdu); } if(tx_sdu) { - tx_sdu->reset(); + pool->deallocate(tx_sdu); } if(mac_timers) { From 07c704b0ddb7b04da4b34f4defafc4bddb62ec33 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Thu, 22 Feb 2018 15:43:40 +0100 Subject: [PATCH 045/134] extend RLC AM stress tester to mimic reestablishment --- lib/test/upper/rlc_am_stress_test.cc | 44 ++++++++++++++++++---------- 1 file changed, 29 insertions(+), 15 deletions(-) diff --git a/lib/test/upper/rlc_am_stress_test.cc b/lib/test/upper/rlc_am_stress_test.cc index c5cf4e877..bdee2248b 100644 --- a/lib/test/upper/rlc_am_stress_test.cc +++ b/lib/test/upper/rlc_am_stress_test.cc @@ -44,6 +44,8 @@ typedef struct { uint32_t test_duration_sec; float error_rate; uint32_t sdu_gen_delay_usec; + uint32_t pdu_tx_delay_usec; + bool reestablish; } stress_test_args_t; void parse_args(stress_test_args_t *args, int argc, char *argv[]) { @@ -58,9 +60,11 @@ void parse_args(stress_test_args_t *args, int argc, char *argv[]) { // Command line or config file options bpo::options_description common("Configuration options"); common.add_options() - ("duration", bpo::value(&args->test_duration_sec)->default_value(10), "Duration (sec)") + ("duration", bpo::value(&args->test_duration_sec)->default_value(10), "Duration (sec)") ("sdu_gen_delay", bpo::value(&args->sdu_gen_delay_usec)->default_value(10), "SDU generation delay (usec)") - ("error_rate", bpo::value(&args->error_rate)->default_value(0.1), "Rate at which RLC PDUs are dropped"); + ("pdu_tx_delay", bpo::value(&args->pdu_tx_delay_usec)->default_value(10), "Delay in MAC for transfering PDU from tx'ing RLC to rx'ing RLC (usec)") + ("error_rate", bpo::value(&args->error_rate)->default_value(0.1), "Rate at which RLC PDUs are dropped") + ("reestablish", bpo::value(&args->reestablish)->default_value(false), "Mimic RLC reestablish during execution"); // these options are allowed on the command line bpo::options_description cmdline_options; @@ -83,14 +87,14 @@ class mac_reader :public thread { public: - mac_reader(rlc_interface_mac *rlc1_, rlc_interface_mac *rlc2_, float fail_rate_, uint32_t sdu_gen_delay_usec_) + mac_reader(rlc_interface_mac *rlc1_, rlc_interface_mac *rlc2_, float fail_rate_, uint32_t pdu_tx_delay_usec_) { rlc1 = rlc1_; rlc2 = rlc2_; fail_rate = fail_rate_; run_enable = true; running = false; - sdu_gen_delay_usec = sdu_gen_delay_usec_; + pdu_tx_delay_usec = pdu_tx_delay_usec_; } void stop() @@ -125,7 +129,7 @@ private: if(((float)rand()/RAND_MAX > fail_rate) && read>0) { rlc2->write_pdu(1, pdu->msg, opp_size); } - usleep(sdu_gen_delay_usec); + usleep(pdu_tx_delay_usec); } running = false; byte_buffer_pool::get_instance()->deallocate(pdu); @@ -134,7 +138,7 @@ private: rlc_interface_mac *rlc1; rlc_interface_mac *rlc2; float fail_rate; - uint32_t sdu_gen_delay_usec; + uint32_t pdu_tx_delay_usec; bool run_enable; bool running; @@ -144,9 +148,9 @@ class mac_dummy :public srslte::mac_interface_timers { public: - mac_dummy(rlc_interface_mac *rlc1_, rlc_interface_mac *rlc2_, float fail_rate_, uint32_t sdu_gen_delay_usec_) - :r1(rlc1_, rlc2_, fail_rate_, sdu_gen_delay_usec_) - ,r2(rlc2_, rlc1_, fail_rate_, sdu_gen_delay_usec_) + mac_dummy(rlc_interface_mac *rlc1_, rlc_interface_mac *rlc2_, float fail_rate_, uint32_t pdu_tx_delay) + :r1(rlc1_, rlc2_, fail_rate_, pdu_tx_delay) + ,r2(rlc2_, rlc1_, fail_rate_, pdu_tx_delay) { } @@ -184,12 +188,13 @@ class rlc_am_tester ,public thread { public: - rlc_am_tester(rlc_interface_pdcp *rlc_, std::string name_=""){ + rlc_am_tester(rlc_interface_pdcp *rlc_, std::string name_, uint32_t sdu_gen_delay_usec_){ rlc = rlc_; run_enable = true; running = false; rx_pdus = 0; name = name_; + sdu_gen_delay_usec = sdu_gen_delay_usec_; } void stop() @@ -235,7 +240,7 @@ private: pdu->N_bytes = 1500; pdu->msg[0] = sn++; rlc->write_sdu(1, pdu); - usleep(10); + usleep(sdu_gen_delay_usec); } running = false; } @@ -246,6 +251,8 @@ private: std::string name; + uint32_t sdu_gen_delay_usec; + rlc_interface_pdcp *rlc; }; @@ -261,9 +268,9 @@ void stress_test(stress_test_args_t args) rlc rlc1; rlc rlc2; - rlc_am_tester tester1(&rlc1, "tester1"); - rlc_am_tester tester2(&rlc2, "tester2"); - mac_dummy mac(&rlc1, &rlc2, args.error_rate, args.sdu_gen_delay_usec); + rlc_am_tester tester1(&rlc1, "tester1", args.sdu_gen_delay_usec); + rlc_am_tester tester2(&rlc2, "tester2", args.sdu_gen_delay_usec); + mac_dummy mac(&rlc1, &rlc2, args.error_rate, args.pdu_tx_delay_usec); ue_interface ue; rlc1.init(&tester1, &tester1, &ue, &log1, &mac, 0); @@ -287,7 +294,14 @@ void stress_test(stress_test_args_t args) tester2.start(7); mac.start(); - usleep(args.test_duration_sec * 1e6); + for (uint32_t i = 0; i < args.test_duration_sec; i++) { + // if enabled, mimic reestablishment every second + if (args.reestablish) { + rlc1.reestablish(); + rlc2.reestablish(); + } + usleep(1e6); + } tester1.stop(); tester2.stop(); From c198547728d95fc6b058b8d97e1e738cdfce850c Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Fri, 23 Feb 2018 13:23:04 +0100 Subject: [PATCH 046/134] add new RF RX error type and make the UHD driver issue that if anything unexpected happens --- lib/include/srslte/phy/rf/rf.h | 1 + lib/src/phy/rf/rf_uhd_imp.c | 22 ++++++++++++++++++++-- srsue/src/ue.cc | 7 ++++++- 3 files changed, 27 insertions(+), 3 deletions(-) diff --git a/lib/include/srslte/phy/rf/rf.h b/lib/include/srslte/phy/rf/rf.h index 44bde9943..da1600b66 100644 --- a/lib/include/srslte/phy/rf/rf.h +++ b/lib/include/srslte/phy/rf/rf.h @@ -60,6 +60,7 @@ typedef struct { SRSLTE_RF_ERROR_LATE, SRSLTE_RF_ERROR_UNDERFLOW, SRSLTE_RF_ERROR_OVERFLOW, + SRSLTE_RF_ERROR_RX, SRSLTE_RF_ERROR_OTHER } type; int opt; diff --git a/lib/src/phy/rf/rf_uhd_imp.c b/lib/src/phy/rf/rf_uhd_imp.c index a1bec2657..0370fa700 100644 --- a/lib/src/phy/rf/rf_uhd_imp.c +++ b/lib/src/phy/rf/rf_uhd_imp.c @@ -96,6 +96,19 @@ static void log_underflow(rf_uhd_handler_t *h) { } } +static void log_rx_error(rf_uhd_handler_t *h) { + if (h->uhd_error_handler) { + char error_string[512]; + uhd_usrp_last_error(h->usrp, error_string, 512); + fprintf(stderr, "USRP reported the following error: %s\n", error_string); + + srslte_rf_error_t error; + bzero(&error, sizeof(srslte_rf_error_t)); + error.type = SRSLTE_RF_ERROR_RX; + h->uhd_error_handler(error); + } +} + static void* async_thread(void *h) { rf_uhd_handler_t *handler = (rf_uhd_handler_t*) h; uhd_async_metadata_handle md; @@ -740,6 +753,7 @@ int rf_uhd_recv_with_time_multi(void *h, num_rx_samples, md, 1.0, false, &rxd_samples); if (error) { fprintf(stderr, "Error receiving from UHD: %d\n", error); + log_rx_error(handler); return -1; } @@ -762,8 +776,12 @@ int rf_uhd_recv_with_time_multi(void *h, } } } else { - return uhd_rx_streamer_recv(handler->rx_stream, data, - nsamples, md, 0.0, false, &rxd_samples); + uhd_error error = uhd_rx_streamer_recv(handler->rx_stream, data, nsamples, md, 0.0, false, &rxd_samples); + if (error) { + fprintf(stderr, "Error receiving from UHD: %d\n", error); + log_rx_error(handler); + return -1; + } } if (secs && frac_secs) { uhd_rx_metadata_time_spec(handler->rx_md_first, secs, frac_secs); diff --git a/srsue/src/ue.cc b/srsue/src/ue.cc index 1de1ddbd0..23175fa46 100644 --- a/srsue/src/ue.cc +++ b/srsue/src/ue.cc @@ -304,8 +304,13 @@ void ue::rf_msg(srslte_rf_error_t error) { ue_base *ue = ue_base::get_instance(LTE); ue->handle_rf_msg(error); - if(error.type == srslte_rf_error_t::SRSLTE_RF_ERROR_OVERFLOW) { + if (error.type == srslte_rf_error_t::SRSLTE_RF_ERROR_OVERFLOW) { ue->radio_overflow(); + } else + if (error.type == srslte_rf_error_t::SRSLTE_RF_ERROR_RX) { + ue->stop(); + ue->cleanup(); + exit(-1); } } From c9b459bf8aa087ca7826fb849dacfc2bfd788356 Mon Sep 17 00:00:00 2001 From: Pedro Alvarez Date: Mon, 5 Mar 2018 09:12:01 +0000 Subject: [PATCH 047/134] Fixing Activate default bearer context uninitialized value. --- srsepc/src/mme/s1ap_nas_transport.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/srsepc/src/mme/s1ap_nas_transport.cc b/srsepc/src/mme/s1ap_nas_transport.cc index 0cd646136..1c78ed58b 100644 --- a/srsepc/src/mme/s1ap_nas_transport.cc +++ b/srsepc/src/mme/s1ap_nas_transport.cc @@ -1166,6 +1166,7 @@ s1ap_nas_transport::pack_attach_accept(ue_ctx_t *ue_ctx, LIBLTE_S1AP_E_RABTOBESE act_def_eps_bearer_context_req.packet_flow_id_present = false; act_def_eps_bearer_context_req.apn_ambr_present = false; act_def_eps_bearer_context_req.esm_cause_present = false; + act_def_eps_bearer_context_req.connectivity_type_present = false; uint8_t sec_hdr_type =2; ue_ctx->security_ctxt.dl_nas_count++; From 01e56428826d0dc2332c638dfc205aaa235707b0 Mon Sep 17 00:00:00 2001 From: Pedro Alvarez Date: Mon, 5 Mar 2018 09:51:31 +0000 Subject: [PATCH 048/134] Replying same attach type to the UE as in the attach request. --- srsepc/hdr/mme/s1ap_common.h | 1 + srsepc/src/mme/s1ap_nas_transport.cc | 10 +++++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/srsepc/hdr/mme/s1ap_common.h b/srsepc/hdr/mme/s1ap_common.h index 9a7d72ce5..65c16f8c9 100644 --- a/srsepc/hdr/mme/s1ap_common.h +++ b/srsepc/hdr/mme/s1ap_common.h @@ -97,6 +97,7 @@ typedef struct{ LIBLTE_MME_MS_NETWORK_CAPABILITY_STRUCT ms_network_cap; bool eit; uint8_t procedure_transaction_id; + uint8_t attach_type; } ue_ctx_t; }//namespace #endif diff --git a/srsepc/src/mme/s1ap_nas_transport.cc b/srsepc/src/mme/s1ap_nas_transport.cc index 1c78ed58b..f8ef987d8 100644 --- a/srsepc/src/mme/s1ap_nas_transport.cc +++ b/srsepc/src/mme/s1ap_nas_transport.cc @@ -311,7 +311,10 @@ s1ap_nas_transport::handle_nas_imsi_attach_request(uint32_t enb_ue_s1ap_id, m_s1ap_log->console("PDN Connectivity Request -- EPS Bearer Identity requested: %d\n", pdn_con_req.eps_bearer_id); m_s1ap_log->console("PDN Connectivity Request -- Procedure Transaction Id: %d\n", pdn_con_req.proc_transaction_id); m_s1ap_log->console("PDN Connectivity Request -- ESM Information Transfer requested: %s\n", pdn_con_req.esm_info_transfer_flag_present ? "true" : "false"); - + + //Save attach request type + ue_ctx.attach_type = attach_req.eps_attach_type; + //Get Authentication Vectors from HSS if(!m_hss->gen_auth_info_answer(ue_ctx.imsi, ue_ctx.security_ctxt.k_asme, autn, rand, ue_ctx.security_ctxt.xres)) { @@ -360,6 +363,9 @@ s1ap_nas_transport::handle_nas_guti_attach_request(uint32_t enb_ue_s1ap_id, uint8_t eps_bearer_id = pdn_con_req.eps_bearer_id; //TODO: Unused ue_ctx.procedure_transaction_id = pdn_con_req.proc_transaction_id; + //Save attach request type + ue_ctx.attach_type = attach_req.eps_attach_type; + //Save whether ESM information transfer is necessary ue_ctx.eit = pdn_con_req.esm_info_transfer_flag_present; //m_s1ap_log->console("EPS Bearer id: %d\n", eps_bearer_id); @@ -412,6 +418,8 @@ s1ap_nas_transport::handle_nas_guti_attach_request(uint32_t enb_ue_s1ap_id, ue_ctx_t *ue_ctx_ptr = m_s1ap->find_ue_ctx(it->second); if(ue_ctx_ptr!=NULL) { + //Save attach request type + ue_ctx_ptr->attach_type = attach_req.eps_attach_type; m_s1ap_log->console("Found UE context. IMSI: %015lu\n",ue_ctx_ptr->imsi); m_mme_gtpc->send_create_session_request(ue_ctx_ptr->imsi, ue_ctx_ptr->mme_ue_s1ap_id); *reply_flag = false; //No reply needed From 0cb1127f934712d244f36e2f0f3f5035860d5117 Mon Sep 17 00:00:00 2001 From: Pedro Alvarez Date: Mon, 5 Mar 2018 10:05:58 +0000 Subject: [PATCH 049/134] Sending Service reject to UE as a temporary handling of service requests (Thanks to Merlin Chlosta). --- srsepc/hdr/mme/s1ap_nas_transport.h | 1 + srsepc/src/mme/s1ap_nas_transport.cc | 60 +++++++++++++++++++++++++++- 2 files changed, 60 insertions(+), 1 deletion(-) diff --git a/srsepc/hdr/mme/s1ap_nas_transport.h b/srsepc/hdr/mme/s1ap_nas_transport.h index 5a457cec7..e958c8dbc 100644 --- a/srsepc/hdr/mme/s1ap_nas_transport.h +++ b/srsepc/hdr/mme/s1ap_nas_transport.h @@ -84,6 +84,7 @@ public: bool pack_identity_request(srslte::byte_buffer_t *reply_msg, uint32_t enb_ue_s1ap_id, uint32_t mme_ue_s1ap_id); bool pack_emm_information(srslte::byte_buffer_t *reply_msg, uint32_t enb_ue_s1ap_id, uint32_t mme_ue_s1ap_id); + bool pack_service_reject(srslte::byte_buffer_t *reply_msg, uint8_t emm_cause, uint32_t enb_ue_s1ap_id); void log_unhandled_attach_request_ies(const LIBLTE_MME_ATTACH_REQUEST_MSG_STRUCT *attach_req); void log_unhandled_pdn_con_request_ies(const LIBLTE_MME_PDN_CONNECTIVITY_REQUEST_MSG_STRUCT *pdn_con_req); diff --git a/srsepc/src/mme/s1ap_nas_transport.cc b/srsepc/src/mme/s1ap_nas_transport.cc index f8ef987d8..22d3c63d1 100644 --- a/srsepc/src/mme/s1ap_nas_transport.cc +++ b/srsepc/src/mme/s1ap_nas_transport.cc @@ -121,7 +121,12 @@ s1ap_nas_transport::handle_initial_ue_message(LIBLTE_S1AP_MESSAGE_INITIALUEMESSA m_s1ap_log->info("Received Service Request \n"); m_s1ap_log->console("Received Service Request \n"); liblte_mme_unpack_service_request_msg((LIBLTE_BYTE_MSG_STRUCT*) nas_msg, &service_req); - return false; + + m_s1ap_log->info("Service Request not implemented. Sending Service Reject."); + m_s1ap_log->console("Service Request not implemented. Sending Service Reject."); + /* Force UE to re-attach */ + pack_service_reject(reply_buffer, LIBLTE_MME_EMM_CAUSE_IMPLICITLY_DETACHED, enb_ue_s1ap_id); + *reply_flag = true; } m_pool->deallocate(nas_msg); @@ -1322,6 +1327,59 @@ s1ap_nas_transport::pack_emm_information(srslte::byte_buffer_t *reply_msg, uint3 return true; } +bool +s1ap_nas_transport::pack_service_reject(srslte::byte_buffer_t *reply_msg, uint8_t emm_cause, uint32_t enb_ue_s1ap_id) +{ + srslte::byte_buffer_t *nas_buffer = m_pool->allocate(); + + //Setup initiating message + LIBLTE_S1AP_S1AP_PDU_STRUCT tx_pdu; + bzero(&tx_pdu, sizeof(LIBLTE_S1AP_S1AP_PDU_STRUCT)); + + tx_pdu.ext = false; + tx_pdu.choice_type = LIBLTE_S1AP_S1AP_PDU_CHOICE_INITIATINGMESSAGE; + + LIBLTE_S1AP_INITIATINGMESSAGE_STRUCT *init = &tx_pdu.choice.initiatingMessage; + init->procedureCode = LIBLTE_S1AP_PROC_ID_DOWNLINKNASTRANSPORT; + init->choice_type = LIBLTE_S1AP_INITIATINGMESSAGE_CHOICE_DOWNLINKNASTRANSPORT; + + //Setup Dw NAS structure + LIBLTE_S1AP_MESSAGE_DOWNLINKNASTRANSPORT_STRUCT *dw_nas = &init->choice.DownlinkNASTransport; + dw_nas->ext=false; + dw_nas->MME_UE_S1AP_ID.MME_UE_S1AP_ID = m_s1ap->get_next_mme_ue_s1ap_id(); + dw_nas->eNB_UE_S1AP_ID.ENB_UE_S1AP_ID = enb_ue_s1ap_id; + dw_nas->HandoverRestrictionList_present=false; + dw_nas->SubscriberProfileIDforRFP_present=false; + LIBLTE_MME_SERVICE_REJECT_MSG_STRUCT service_rej; + service_rej.t3442_present = true; + service_rej.t3442.unit = LIBLTE_MME_GPRS_TIMER_DEACTIVATED; + service_rej.t3442.value = 0; + service_rej.t3446_present = true; + service_rej.t3446 = 0; + service_rej.emm_cause = emm_cause; + + LIBLTE_ERROR_ENUM err = liblte_mme_pack_service_reject_msg(&service_rej, LIBLTE_MME_SECURITY_HDR_TYPE_PLAIN_NAS, 0, (LIBLTE_BYTE_MSG_STRUCT *) nas_buffer); + if(err != LIBLTE_SUCCESS) + { + m_s1ap_log->error("Error packing Service Reject\n"); + m_s1ap_log->console("Error packing Service Reject\n"); + return false; + } + + //Copy NAS PDU to Downlink NAS Trasport message buffer + memcpy(dw_nas->NAS_PDU.buffer, nas_buffer->msg, nas_buffer->N_bytes); + dw_nas->NAS_PDU.n_octets = nas_buffer->N_bytes; + + //Pack Downlink NAS Transport Message + err = liblte_s1ap_pack_s1ap_pdu(&tx_pdu, (LIBLTE_BYTE_MSG_STRUCT *) reply_msg); + if(err != LIBLTE_SUCCESS) + { + m_s1ap_log->error("Error packing Dw NAS Transport: Service Reject\n"); + m_s1ap_log->console("Error packing Downlink NAS Transport: Service Reject\n"); + return false; + } + return true; +} /*Helper functions*/ void s1ap_nas_transport::log_unhandled_attach_request_ies(const LIBLTE_MME_ATTACH_REQUEST_MSG_STRUCT *attach_req) From 067d76a5c8cc5e4ef0619d28b96e28777c20f1b2 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Mon, 5 Mar 2018 11:22:02 +0100 Subject: [PATCH 050/134] enable buffer pool log --- lib/include/srslte/common/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/include/srslte/common/common.h b/lib/include/srslte/common/common.h index 41a89fb36..ddd558016 100644 --- a/lib/include/srslte/common/common.h +++ b/lib/include/srslte/common/common.h @@ -63,7 +63,7 @@ #define SRSLTE_MAX_BUFFER_SIZE_BYTES 12756 #define SRSLTE_BUFFER_HEADER_OFFSET 1024 -//#define SRSLTE_BUFFER_POOL_LOG_ENABLED +#define SRSLTE_BUFFER_POOL_LOG_ENABLED #ifdef SRSLTE_BUFFER_POOL_LOG_ENABLED #define pool_allocate (pool->allocate(__FUNCTION__)) From 3efc197f3a7f2b48f83ae91836a721efbe1b48dd Mon Sep 17 00:00:00 2001 From: Pedro Alvarez Date: Mon, 5 Mar 2018 10:50:51 +0000 Subject: [PATCH 051/134] Actually changing the attach type. --- srsepc/src/mme/s1ap_nas_transport.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/srsepc/src/mme/s1ap_nas_transport.cc b/srsepc/src/mme/s1ap_nas_transport.cc index 22d3c63d1..5f791caa5 100644 --- a/srsepc/src/mme/s1ap_nas_transport.cc +++ b/srsepc/src/mme/s1ap_nas_transport.cc @@ -293,6 +293,10 @@ s1ap_nas_transport::handle_nas_imsi_attach_request(uint32_t enb_ue_s1ap_id, m_s1ap_log->console("Attach request -- IMSI: %015lu\n", ue_ctx.imsi); m_s1ap_log->info("Attach request -- IMSI: %015lu\n", ue_ctx.imsi); + + m_s1ap_log->console("Attach request -- Attach type: %d\n", attach_req.eps_attach_type); + m_s1ap_log->info("Attach request -- Attach type: %d\n", attach_req.eps_attach_type); + m_s1ap_log->console("Attach request -- eNB-UE S1AP Id: %d, MME-UE S1AP Id: %d\n", ue_ctx.enb_ue_s1ap_id, ue_ctx.mme_ue_s1ap_id); m_s1ap_log->console("Attach Request -- UE Network Capabilities EEA: %d%d%d%d%d%d%d%d\n", attach_req.ue_network_cap.eea[0], @@ -1106,7 +1110,7 @@ s1ap_nas_transport::pack_attach_accept(ue_ctx_t *ue_ctx, LIBLTE_S1AP_E_RABTOBESE } //Attach accept - attach_accept.eps_attach_result = LIBLTE_MME_EPS_ATTACH_RESULT_EPS_ONLY; + attach_accept.eps_attach_result = ue_ctx->attach_type; //Mandatory //FIXME: Set t3412 from config attach_accept.t3412.unit = LIBLTE_MME_GPRS_TIMER_UNIT_1_MINUTE; // GPRS 1 minute unit From 90553e830d4211edbd2fdb997ecee718ec00ae6f Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Mon, 5 Mar 2018 13:07:24 +0100 Subject: [PATCH 052/134] Fixed cell search for non-home PLMN --- lib/include/srslte/interfaces/ue_interfaces.h | 1 - lib/src/phy/ue/ue_sync.c | 7 +- srsue/hdr/phy/phch_recv.h | 8 +- srsue/hdr/phy/phy.h | 1 - srsue/src/phy/phch_recv.cc | 87 +++++++------------ srsue/src/phy/phy.cc | 5 -- srsue/src/upper/nas.cc | 17 ++-- srsue/src/upper/rrc.cc | 39 +++++---- 8 files changed, 76 insertions(+), 89 deletions(-) diff --git a/lib/include/srslte/interfaces/ue_interfaces.h b/lib/include/srslte/interfaces/ue_interfaces.h index 52d11416c..923111371 100644 --- a/lib/include/srslte/interfaces/ue_interfaces.h +++ b/lib/include/srslte/interfaces/ue_interfaces.h @@ -580,7 +580,6 @@ public: /* Cell search and selection procedures */ virtual void cell_search_start() = 0; - virtual void cell_search_stop() = 0; virtual void cell_search_next() = 0; virtual void cell_select(uint32_t earfcn, srslte_cell_t cell) = 0; virtual bool cell_handover(srslte_cell_t cell) = 0; diff --git a/lib/src/phy/ue/ue_sync.c b/lib/src/phy/ue/ue_sync.c index d99bff89a..b66cf5b53 100644 --- a/lib/src/phy/ue/ue_sync.c +++ b/lib/src/phy/ue/ue_sync.c @@ -755,7 +755,9 @@ int srslte_ue_sync_zerocopy_multi(srslte_ue_sync_t *q, cf_t *input_buffer[SRSLTE if (q->do_agc) { srslte_agc_process(&q->agc, input_buffer[0], q->sf_len); } - + + INFO("SYNC FIND: sf_idx=%d, ret=%d, next_state=%d\n", q->sf_idx, ret, q->state); + break; case SF_TRACK: @@ -817,6 +819,9 @@ int srslte_ue_sync_zerocopy_multi(srslte_ue_sync_t *q, cf_t *input_buffer[SRSLTE q->frame_total_cnt++; } + + INFO("SYNC TRACK: sf_idx=%d, ret=%d, next_state=%d\n", q->sf_idx, ret, q->state); + break; } } diff --git a/srsue/hdr/phy/phch_recv.h b/srsue/hdr/phy/phch_recv.h index b5848a6b3..861d58229 100644 --- a/srsue/hdr/phy/phch_recv.h +++ b/srsue/hdr/phy/phch_recv.h @@ -61,7 +61,6 @@ public: void reset_sync(); void cell_search_start(); - void cell_search_stop(); void cell_search_next(bool reset = false); void cell_select(uint32_t earfcn, srslte_cell_t cell); bool cell_handover(srslte_cell_t cell); @@ -299,14 +298,16 @@ private: const static uint32_t NOF_IN_SYNC_SF = 100; // State for primary cell - enum { + typedef enum { IDLE = 0, CELL_SEARCH, CELL_SELECT, CELL_RESELECT, CELL_MEASURE, CELL_CAMP, - } phy_state; + } phy_state_t; + + phy_state_t phy_state, prev_state; bool is_in_idle; @@ -330,7 +331,6 @@ private: float ul_dl_factor; uint32_t current_earfcn; int cur_earfcn_index; - bool cell_search_in_progress; float dl_freq; float ul_freq; diff --git a/srsue/hdr/phy/phy.h b/srsue/hdr/phy/phy.h index 9270973c0..0894a98fb 100644 --- a/srsue/hdr/phy/phy.h +++ b/srsue/hdr/phy/phy.h @@ -85,7 +85,6 @@ public: void sync_reset(); void configure_ul_params(bool pregen_disabled = false); void cell_search_start(); - void cell_search_stop(); void cell_search_next(); void cell_select(uint32_t earfcn, srslte_cell_t phy_cell); bool cell_handover(srslte_cell_t cell); diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index a6f1a5d84..ad76537e0 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -132,7 +132,6 @@ void phch_recv::reset() next_offset = 0; cell_is_set = false; srate_mode = SRATE_NONE; - cell_search_in_progress = false; current_earfcn = 0; sfn_p.reset(); measure_p.reset(); @@ -262,17 +261,17 @@ void phch_recv::reset_sync() { search_p.reset(); measure_p.reset(); srslte_ue_sync_reset(&ue_sync); - + Info("----- PHY RESET----\n"); phy_state = CELL_SELECT; } void phch_recv::cell_search_inc() { + Info("cell_search_inc, cur_idx=%d, size=%d\n", cur_earfcn_index, earfcn.size()); cur_earfcn_index++; if (cur_earfcn_index >= 0) { if (cur_earfcn_index >= (int) earfcn.size()) { cur_earfcn_index = 0; - cell_search_in_progress = false; phy_state = IDLE; rrc->earfcn_end(); } else { @@ -281,20 +280,16 @@ void phch_recv::cell_search_inc() current_earfcn = earfcn[cur_earfcn_index]; set_frequency(); } + phy_state = CELL_SEARCH; } } } void phch_recv::cell_search_next(bool reset) { - if (cell_search_in_progress || reset) { - cell_search_in_progress = false; - if (reset) { - cur_earfcn_index = -1; - } - cell_search_inc(); - phy_state = CELL_SEARCH; - cell_search_in_progress = true; + if (reset) { + cur_earfcn_index = -1; } + cell_search_inc(); } void phch_recv::cell_search_start() { @@ -311,11 +306,6 @@ void phch_recv::cell_search_start() { } } -void phch_recv::cell_search_stop() { - Info("SYNC: Stopping Cell Search procedure...\n"); - cell_search_in_progress = false; -} - bool phch_recv::cell_handover(srslte_cell_t cell) { int cnt = 0; @@ -369,19 +359,18 @@ void phch_recv::cell_reselect() uint32_t earfcn = new_earfcn; srslte_cell_t cell = new_cell; + Info("Reset from cell_reselect\n"); + reset_sync(); + // If we are already in the new cell, just resynchronize if (earfcn == current_earfcn && this->cell.id == cell.id) { - log_h->info("Cell Select: Already in cell EARFCN=%d\n", earfcn); - cell_search_in_progress = false; + log_h->info("Cell Select: Already in cell EARFCN=%d, PCI=%d\n", earfcn, cell.id); if (srate_mode != SRATE_CAMP) { set_sampling_rate(); + log_h->info("Cell Select: Setting Camping sampling rate\n"); } - phy_state = CELL_SELECT; } else { - /* If we are going to a new cell, configure it */ - cell_search_in_progress = false; - if (earfcn != current_earfcn) { if (set_frequency()) { log_h->error("Cell Select: Configuring cell in EARFCN=%d, PCI=%d\n", earfcn, cell.id); @@ -394,7 +383,6 @@ void phch_recv::cell_reselect() if (set_cell()) { log_h->info("Cell Select: Synchronizing on cell...\n"); - phy_state = CELL_SELECT; } } } @@ -533,33 +521,29 @@ void phch_recv::run_thread() sf_idx = tti%10; + prev_state = phy_state; + switch (phy_state) { case CELL_SEARCH: - if (cell_search_in_progress) + switch(search_p.run(&cell)) { - switch(search_p.run(&cell)) - { - case search::CELL_FOUND: - if (!srslte_cell_isvalid(&cell)) { - Error("SYNC: Detected invalid cell\n"); - phy_state = IDLE; - break; - } - if (set_cell()) { - set_sampling_rate(); - phy_state = CELL_SELECT; - } - break; - case search::CELL_NOT_FOUND: - if (cell_search_in_progress) { - cell_search_inc(); - } + case search::CELL_FOUND: + if (!srslte_cell_isvalid(&cell)) { + Error("SYNC: Detected invalid cell\n"); phy_state = IDLE; break; - default: - radio_error(); - break; } + if (set_cell()) { + set_sampling_rate(); + phy_state = CELL_SELECT; + } + break; + case search::CELL_NOT_FOUND: + cell_search_inc(); + break; + default: + radio_error(); + break; } break; case CELL_RESELECT: @@ -569,7 +553,7 @@ void phch_recv::run_thread() switch (sfn_p.run_subframe(&cell, &tti)) { case sfn_sync::SFN_FOUND: - if (!cell_search_in_progress) { + if (prev_state == CELL_SEARCH) { log_h->info("Sync OK. Camping on cell PCI=%d...\n", cell.id); phy_state = CELL_CAMP; rrc->cell_camping(earfcn[cur_earfcn_index], cell); @@ -580,13 +564,8 @@ void phch_recv::run_thread() } break; case sfn_sync::TIMEOUT: - if (cell_search_in_progress) { - log_h->warning("SYNC: Timeout while synchronizing SFN. Going back to cell search\n"); - phy_state = CELL_SEARCH; - } else { - log_h->warning("SYNC: Timeout while synchronizing SFN. Reselecting cell\n"); - phy_state = CELL_SELECT; - } + log_h->warning("SYNC: Timeout while synchronizing SFN. Going back to cell search\n"); + phy_state = CELL_SEARCH; break; case sfn_sync::IDLE: break; @@ -610,7 +589,6 @@ void phch_recv::run_thread() log_h->info("SYNC: Measured OK. Camping on cell PCI=%d...\n", cell.id); phy_state = CELL_CAMP; - cell_search_in_progress = false; rrc->cell_camping(earfcn[cur_earfcn_index], cell, measure_p.rsrp()); break; case measure::IDLE: @@ -833,6 +811,7 @@ phch_recv::search::ret_code phch_recv::search::run(srslte_cell_t *cell) if (p->srate_mode != SRATE_FIND) { p->srate_mode = SRATE_FIND; p->radio_h->set_rx_srate(1.92e6); + Info("SYNC: Setting Cell Search sampling rate\n"); } /* Find a cell in the given N_id_2 or go through the 3 of them to find the strongest */ @@ -992,7 +971,7 @@ phch_recv::sfn_sync::ret_code phch_recv::sfn_sync::run_subframe(srslte_cell_t *c } } } else { - Debug("SYNC: PSS/SSS not found...\n"); + Info("SYNC: PSS/SSS not found...\n"); } cnt++; diff --git a/srsue/src/phy/phy.cc b/srsue/src/phy/phy.cc index a2d517a02..e4b618158 100644 --- a/srsue/src/phy/phy.cc +++ b/srsue/src/phy/phy.cc @@ -256,11 +256,6 @@ void phy::cell_search_start() sf_recv.cell_search_start(); } -void phy::cell_search_stop() -{ - sf_recv.cell_search_stop(); -} - void phy::cell_search_next() { sf_recv.cell_search_next(); diff --git a/srsue/src/upper/nas.cc b/srsue/src/upper/nas.cc index 7f5683867..8a05595c7 100644 --- a/srsue/src/upper/nas.cc +++ b/srsue/src/upper/nas.cc @@ -161,14 +161,15 @@ void nas::plmn_found(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id, uint16_t tracking_ // RRC indicates that the UE has gone through all EARFCN and finished PLMN selection void nas::plmn_search_end() { if (known_plmns.size() > 0) { - nas_log->info("Could not find Home PLMN Id=%s, trying to connect to PLMN Id=%s\n", - plmn_id_to_string(home_plmn).c_str(), - plmn_id_to_string(known_plmns[0]).c_str()); - - nas_log->console("Could not find Home PLMN Id=%s, trying to connect to PLMN Id=%s\n", - plmn_id_to_string(home_plmn).c_str(), - plmn_id_to_string(known_plmns[0]).c_str()); - + if (home_plmn.mcc != known_plmns[0].mcc && home_plmn.mnc != known_plmns[0].mnc) { + nas_log->info("Could not find Home PLMN Id=%s, trying to connect to PLMN Id=%s\n", + plmn_id_to_string(home_plmn).c_str(), + plmn_id_to_string(known_plmns[0]).c_str()); + + nas_log->console("Could not find Home PLMN Id=%s, trying to connect to PLMN Id=%s\n", + plmn_id_to_string(home_plmn).c_str(), + plmn_id_to_string(known_plmns[0]).c_str()); + } rrc->plmn_select(known_plmns[0]); } else { nas_log->info("Finished searching PLMN in current EARFCN set but no networks were found.\n"); diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 1aecb273b..cdd19f22c 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -212,10 +212,8 @@ void rrc::run_thread() { plmn_select_timeout++; if (plmn_select_timeout >= RRC_PLMN_SELECT_TIMEOUT) { rrc_log->info("RRC PLMN Search: timeout expired\n"); - phy->cell_search_stop(); - sleep(1); - rrc_log->console("\nRRC PLMN Search: timeout expired. Searching again\n"); - + rrc_log->console("\nRRC PLMN Search: timeout expired.\n"); + state = RRC_STATE_IDLE; } break; case RRC_STATE_CELL_SELECTING: @@ -236,14 +234,13 @@ void rrc::run_thread() { } } // Don't time out during reestablishment (T311 running) - if (!mac_timers->timer_get(t311)->is_running()) { + if (!mac_timers->timer_get(t311)->is_running() || !phy->sync_status()) { select_cell_timeout++; if (select_cell_timeout >= RRC_SELECT_CELL_TIMEOUT) { rrc_log->info("RRC Cell Selecting: timeout expired. Starting Cell Search...\n"); - plmn_select_timeout = 0; select_cell_timeout = 0; + state = RRC_STATE_PLMN_START; serving_cell->in_sync = false; - phy->cell_search_start(); } } break; @@ -457,17 +454,30 @@ void rrc::plmn_select_rrc(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id) { if (state == RRC_STATE_IDLE || state == RRC_STATE_CONNECTED || state == RRC_STATE_PLMN_SELECTION) { if (phy->sync_status() && selected_plmn_id.mcc == plmn_id.mcc && selected_plmn_id.mnc == plmn_id.mnc) { rrc_log->info("Already camping on selected PLMN, connecting...\n"); - state = RRC_STATE_CELL_SELECTING; - select_cell_timeout = 0; } else { - rrc_log->info("PLMN Id=%s selected\n", plmn_id_to_string(plmn_id).c_str()); - // Sort cells according to RSRP - selected_plmn_id = plmn_id; - select_cell_timeout = 0; - state = RRC_STATE_CELL_SELECTING; + if (serving_cell->plmn_equals(selected_plmn_id)) { + phy->cell_select(serving_cell->get_earfcn(), serving_cell->phy_cell); + } else { + bool found = false; + for (uint32_t i=0;iplmn_equals(selected_plmn_id)) { + rrc_log->info("PLMN Id=%s selected, PCI=%d\n", plmn_id_to_string(plmn_id).c_str(), neighbour_cells[i]->get_pci()); + phy->cell_select(neighbour_cells[i]->get_earfcn(), neighbour_cells[i]->phy_cell); + found = true; + } + } + if (!found) { + rrc_log->warning("Could not find any cell for the selected PLMN\n"); + state = RRC_STATE_IDLE; + return; + } + } } + + state = RRC_STATE_CELL_SELECTING; + select_cell_timeout = 0; } else { rrc_log->warning("Requested PLMN select in incorrect state %s\n", rrc_state_text[state]); } @@ -988,7 +998,6 @@ void rrc::send_con_restablish_request(LIBLTE_RRC_CON_REEST_REQ_CAUSE_ENUM cause, break; default: rrc_log->info("Unsupported integrity algorithm during reestablishment\n"); - return; } // Prepare ConnectionRestalishmentRequest packet From 8591049e928da086cfb599b08799a1d46f992c18 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Mon, 5 Mar 2018 14:33:51 +0100 Subject: [PATCH 053/134] Added mutex to ul/dl harq reset --- lib/src/common/pdu_queue.cc | 12 ++++++++---- srsue/hdr/mac/dl_harq.h | 16 +++++++++++++++- srsue/hdr/mac/ul_harq.h | 11 ++++++++++- srsue/src/upper/rrc.cc | 2 ++ 4 files changed, 35 insertions(+), 6 deletions(-) diff --git a/lib/src/common/pdu_queue.cc b/lib/src/common/pdu_queue.cc index 3a116e641..061433033 100644 --- a/lib/src/common/pdu_queue.cc +++ b/lib/src/common/pdu_queue.cc @@ -76,10 +76,14 @@ void pdu_queue::deallocate(uint8_t* pdu) */ void pdu_queue::push(uint8_t *ptr, uint32_t len, uint32_t tstamp) { - pdu_t *pdu = (pdu_t*) ptr; - pdu->len = len; - pdu->tstamp = tstamp; - pdu_q.push(pdu); + if (ptr) { + pdu_t *pdu = (pdu_t*) ptr; + pdu->len = len; + pdu->tstamp = tstamp; + pdu_q.push(pdu); + } else { + log_h->warning("Error pushing pdu: ptr is empty\n"); + } } bool pdu_queue::process_pdus() diff --git a/srsue/hdr/mac/dl_harq.h b/srsue/hdr/mac/dl_harq.h index 261fb0d41..982a6eac6 100644 --- a/srsue/hdr/mac/dl_harq.h +++ b/srsue/hdr/mac/dl_harq.h @@ -196,6 +196,8 @@ private: is_initiated = false; ack = false; bzero(&cur_grant, sizeof(Tgrant)); + + pthread_mutex_init(&mutex, NULL); } ~dl_tb_process() { @@ -220,16 +222,23 @@ private: } void reset(void) { + pthread_mutex_lock(&mutex); is_first_tb = true; ack = false; - payload_buffer_ptr = NULL; + if (payload_buffer_ptr) { + harq_entity->demux_unit->deallocate(payload_buffer_ptr); + } bzero(&cur_grant, sizeof(Tgrant)); if (is_initiated) { srslte_softbuffer_rx_reset(&softbuffer); } + pthread_mutex_unlock(&mutex); } void new_grant_dl(Tgrant grant, Taction *action) { + + pthread_mutex_lock(&mutex); + // Compute RV for BCCH when not specified in PDCCH format if (pid == HARQ_BCCH_PID && grant.rv[tid] == -1) { uint32_t k; @@ -271,6 +280,7 @@ private: if (!action->payload_ptr[tid]) { action->decode_enabled[tid] = false; Error("Can't get a buffer for TBS=%d\n", cur_grant.n_bytes[tid]); + pthread_mutex_unlock(&mutex); return; } action->decode_enabled[tid]= true; @@ -299,6 +309,8 @@ private: Debug("Generating ACK\n"); } } + + pthread_mutex_unlock(&mutex); } void tb_decoded(bool ack_) { @@ -364,6 +376,8 @@ private: return is_new_transmission; } + pthread_mutex_t mutex; + bool is_initiated; dl_harq_entity *harq_entity; srslte::log *log_h; diff --git a/srsue/hdr/mac/ul_harq.h b/srsue/hdr/mac/ul_harq.h index 5c44a222e..4ab4756b9 100644 --- a/srsue/hdr/mac/ul_harq.h +++ b/srsue/hdr/mac/ul_harq.h @@ -159,6 +159,8 @@ private: tti_last_tx = 0; payload_buffer = NULL; bzero(&cur_grant, sizeof(Tgrant)); + + pthread_mutex_init(&mutex, NULL); } ~ul_harq_process() @@ -193,17 +195,21 @@ private: void reset() { + pthread_mutex_lock(&mutex); current_tx_nb = 0; current_irv = 0; tti_last_tx = 0; is_grant_configured = false; bzero(&cur_grant, sizeof(Tgrant)); + pthread_mutex_unlock(&mutex); } void reset_ndi() { cur_grant.ndi[0] = false; } void run_tti(uint32_t tti_tx, Tgrant *grant, bool *ack, Taction* action) { + pthread_mutex_lock(&mutex); + if (ack) { if (grant) { if (grant->ndi[0] == get_ndi() && grant->phy_grant.ul.mcs.tbs != 0) { @@ -276,6 +282,8 @@ private: } harq_entity->pcap->write_ul_crnti(pdu_ptr, grant->n_bytes[0], grant->rnti, get_nof_retx(), tti_tx); } + + pthread_mutex_unlock(&mutex); } uint32_t get_rv() @@ -304,7 +312,8 @@ private: bool is_msg3; bool is_initiated; uint32_t tti_last_tx; - + + pthread_mutex_t mutex; const static int payload_buffer_len = 128*1024; uint8_t *payload_buffer; diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 8ffdc1868..f2373ce2c 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -768,6 +768,8 @@ void rrc::earfcn_end() { // If searching for PLMN, indicate NAS we scanned all frequencies if (state == RRC_STATE_PLMN_SELECTION) { nas->plmn_search_end(); + } else if (state == RRC_STATE_CONNECTED) { + leave_connected(); } } From f53cb11e82c3cc4a0818c05226d54083c3da0a08 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Mon, 5 Mar 2018 14:54:01 +0100 Subject: [PATCH 054/134] Remove mutex from ul_harq --- srsue/hdr/mac/ul_harq.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/srsue/hdr/mac/ul_harq.h b/srsue/hdr/mac/ul_harq.h index 4ab4756b9..ee9bc6279 100644 --- a/srsue/hdr/mac/ul_harq.h +++ b/srsue/hdr/mac/ul_harq.h @@ -159,8 +159,6 @@ private: tti_last_tx = 0; payload_buffer = NULL; bzero(&cur_grant, sizeof(Tgrant)); - - pthread_mutex_init(&mutex, NULL); } ~ul_harq_process() @@ -195,21 +193,17 @@ private: void reset() { - pthread_mutex_lock(&mutex); current_tx_nb = 0; current_irv = 0; tti_last_tx = 0; is_grant_configured = false; bzero(&cur_grant, sizeof(Tgrant)); - pthread_mutex_unlock(&mutex); } void reset_ndi() { cur_grant.ndi[0] = false; } void run_tti(uint32_t tti_tx, Tgrant *grant, bool *ack, Taction* action) { - pthread_mutex_lock(&mutex); - if (ack) { if (grant) { if (grant->ndi[0] == get_ndi() && grant->phy_grant.ul.mcs.tbs != 0) { @@ -282,8 +276,6 @@ private: } harq_entity->pcap->write_ul_crnti(pdu_ptr, grant->n_bytes[0], grant->rnti, get_nof_retx(), tti_tx); } - - pthread_mutex_unlock(&mutex); } uint32_t get_rv() @@ -313,7 +305,6 @@ private: bool is_initiated; uint32_t tti_last_tx; - pthread_mutex_t mutex; const static int payload_buffer_len = 128*1024; uint8_t *payload_buffer; From 23f308666976d347b9792cd77b30b0bd486b2778 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Mon, 5 Mar 2018 15:13:24 +0100 Subject: [PATCH 055/134] Deallocate properly on dl_harq --- srsue/hdr/mac/dl_harq.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/srsue/hdr/mac/dl_harq.h b/srsue/hdr/mac/dl_harq.h index 982a6eac6..562008d61 100644 --- a/srsue/hdr/mac/dl_harq.h +++ b/srsue/hdr/mac/dl_harq.h @@ -227,6 +227,7 @@ private: ack = false; if (payload_buffer_ptr) { harq_entity->demux_unit->deallocate(payload_buffer_ptr); + payload_buffer_ptr = NULL; } bzero(&cur_grant, sizeof(Tgrant)); if (is_initiated) { @@ -314,6 +315,7 @@ private: } void tb_decoded(bool ack_) { + pthread_mutex_lock(&mutex); ack = ack_; if (ack) { if (pid == HARQ_BCCH_PID) { @@ -344,11 +346,15 @@ private: harq_entity->demux_unit->deallocate(payload_buffer_ptr); } + payload_buffer_ptr = NULL; + Info("DL %d (TB %d): %s tbs=%d, rv=%d, ack=%s, ndi=%d (%d), tti=%d (%d)\n", pid, tid, is_new_transmission ? "newTX" : "reTX ", cur_grant.n_bytes[tid], cur_grant.rv[tid], ack ? "OK" : "KO", cur_grant.ndi[tid], cur_grant.last_ndi[tid], cur_grant.tti, cur_grant.last_tti); + pthread_mutex_unlock(&mutex); + if (ack && pid == HARQ_BCCH_PID) { reset(); } From b8b39d6d1bd8f5fd4dbfde4a36efd4fd5ff575cf Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Mon, 5 Mar 2018 15:16:21 +0100 Subject: [PATCH 056/134] NULL payload buffer in dl_harq in the constructor --- srsue/hdr/mac/dl_harq.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/srsue/hdr/mac/dl_harq.h b/srsue/hdr/mac/dl_harq.h index 562008d61..9d7d8f48e 100644 --- a/srsue/hdr/mac/dl_harq.h +++ b/srsue/hdr/mac/dl_harq.h @@ -196,7 +196,7 @@ private: is_initiated = false; ack = false; bzero(&cur_grant, sizeof(Tgrant)); - + payload_buffer_ptr = NULL; pthread_mutex_init(&mutex, NULL); } From 09594d805871b539e540d4d1c219f040beffc4c6 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Mon, 5 Mar 2018 16:18:40 +0100 Subject: [PATCH 057/134] Restart RX stream on srate change --- lib/src/radio/radio.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/src/radio/radio.cc b/lib/src/radio/radio.cc index 7008790a3..fc21b73be 100644 --- a/lib/src/radio/radio.cc +++ b/lib/src/radio/radio.cc @@ -301,7 +301,9 @@ void radio::set_master_clock_rate(double rate) void radio::set_rx_srate(double srate) { + srslte_rf_stop_rx_stream(&rf_device); srslte_rf_set_rx_srate(&rf_device, srate); + srslte_rf_start_rx_stream(&rf_device, false); } void radio::set_tx_freq(double freq) From 76ed6fd8d809bd9aa6dc197080d27bbedcc35ba7 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Mon, 5 Mar 2018 16:19:26 +0100 Subject: [PATCH 058/134] Check cell state before infra_freq.meas --- srsue/src/phy/phch_recv.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index ddb0c6a38..b05a88205 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -553,7 +553,7 @@ void phch_recv::run_thread() switch (sfn_p.run_subframe(&cell, &tti)) { case sfn_sync::SFN_FOUND: - if (prev_state == CELL_SEARCH) { + if (prev_state != CELL_SEARCH) { log_h->info("Sync OK. Camping on cell PCI=%d...\n", cell.id); phy_state = CELL_CAMP; rrc->cell_camping(earfcn[cur_earfcn_index], cell); @@ -662,7 +662,9 @@ void phch_recv::run_thread() if ((tti%5) == 0 && worker_com->args->sic_pss_enabled) { srslte_pss_sic(&ue_sync.strack.pss, &buffer[0][SRSLTE_SF_LEN_PRB(cell.nof_prb)/2-ue_sync.strack.fft_size]); } - intra_freq_meas.write(tti, buffer[0], SRSLTE_SF_LEN_PRB(cell.nof_prb)); + if (srslte_cell_isvalid(&cell)) { + intra_freq_meas.write(tti, buffer[0], SRSLTE_SF_LEN_PRB(cell.nof_prb)); + } break; case 0: Warning("SYNC: Out-of-sync detected in PSS/SSS\n"); From 8b1ba55eaf7ecec4ab2c200a98c64ea0a04c5e3d Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Mon, 5 Mar 2018 16:20:06 +0100 Subject: [PATCH 059/134] Check payload length before demux --- srsue/src/mac/demux.cc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/srsue/src/mac/demux.cc b/srsue/src/mac/demux.cc index 56446bda9..99f7c036c 100644 --- a/srsue/src/mac/demux.cc +++ b/srsue/src/mac/demux.cc @@ -165,7 +165,14 @@ void demux::process_sch_pdu(srslte::sch_pdu *pdu_msg) // Route logical channel if (route_pdu) { Info("Delivering PDU for lcid=%d, %d bytes\n", pdu_msg->get()->get_sdu_lcid(), pdu_msg->get()->get_payload_size()); - rlc->write_pdu(pdu_msg->get()->get_sdu_lcid(), pdu_msg->get()->get_sdu_ptr(), pdu_msg->get()->get_payload_size()); + if (pdu_msg->get()->get_payload_size() < MAX_PDU_LEN) { + rlc->write_pdu(pdu_msg->get()->get_sdu_lcid(), pdu_msg->get()->get_sdu_ptr(), pdu_msg->get()->get_payload_size()); + } else { + char tmp[1024]; + srslte_vec_sprint_hex(tmp, pdu_msg->get()->get_sdu_ptr(), 32); + Error("PDU size %d exceeds maximum PDU buffer size, lcid=%d, hex=[%s]\n", + pdu_msg->get()->get_payload_size(), pdu_msg->get()->get_sdu_lcid(), tmp); + } } } else { // Process MAC Control Element From defe16767299d26086ef56b6c0477a460ad135a6 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Mon, 5 Mar 2018 16:20:45 +0100 Subject: [PATCH 060/134] Do not lock on set_crnti worker --- srsue/src/phy/phch_worker.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/srsue/src/phy/phch_worker.cc b/srsue/src/phy/phch_worker.cc index 3075b0b30..de73764f4 100644 --- a/srsue/src/phy/phch_worker.cc +++ b/srsue/src/phy/phch_worker.cc @@ -199,11 +199,9 @@ void phch_worker::set_sample_offset(float sample_offset) void phch_worker::set_crnti(uint16_t rnti) { - pthread_mutex_lock(&mutex); srslte_ue_dl_set_rnti(&ue_dl, rnti); srslte_ue_ul_set_rnti(&ue_ul, rnti); rnti_is_set = true; - pthread_mutex_unlock(&mutex); } float phch_worker::get_ref_cfo() From dcdb2d64496844761c674af8574c48c9fc1468f5 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Mon, 5 Mar 2018 16:26:51 +0100 Subject: [PATCH 061/134] Make sure request connection when NAS attaching --- srsue/src/upper/rrc.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index f2373ce2c..11cb432fa 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -187,6 +187,7 @@ void rrc::run_thread() { sleep(1); rrc_log->info("RRC IDLE: NAS is attaching and camping on cell, reselecting...\n"); plmn_select_rrc(selected_plmn_id); + connection_requested = true; } // If not camping on a cell } else { From 5f0bd0e74bd1bdafbf8e831a137d84f3150f37c8 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Mon, 5 Mar 2018 17:18:51 +0100 Subject: [PATCH 062/134] Add mutex to libfftw mkplan/destroyplan functions --- lib/src/phy/dft/dft_fftw.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/lib/src/phy/dft/dft_fftw.c b/lib/src/phy/dft/dft_fftw.c index ede6ce69b..d9318fa0d 100644 --- a/lib/src/phy/dft/dft_fftw.c +++ b/lib/src/phy/dft/dft_fftw.c @@ -45,6 +45,7 @@ #define FFTW_TYPE 0 #endif +pthread_mutex_t fft_mutex = PTHREAD_MUTEX_INITIALIZER; void srslte_dft_load() { #ifdef FFTW_WISDOM_FILE @@ -101,10 +102,15 @@ int srslte_dft_replan_guru_c(srslte_dft_plan_t *plan, const int new_dft_points, const fftwf_iodim iodim = {new_dft_points, istride, ostride}; const fftwf_iodim howmany_dims = {how_many, idist, odist}; + pthread_mutex_lock(&fft_mutex); + /* Destroy current plan */ fftwf_destroy_plan(plan->p); plan->p = fftwf_plan_guru_dft(1, &iodim, 1, &howmany_dims, in_buffer, out_buffer, sign, FFTW_TYPE); + + pthread_mutex_unlock(&fft_mutex); + if (!plan->p) { return -1; } @@ -116,11 +122,15 @@ int srslte_dft_replan_guru_c(srslte_dft_plan_t *plan, const int new_dft_points, int srslte_dft_replan_c(srslte_dft_plan_t *plan, const int new_dft_points) { int sign = (plan->dir == SRSLTE_DFT_FORWARD) ? FFTW_FORWARD : FFTW_BACKWARD; + + pthread_mutex_lock(&fft_mutex); if (plan->p) { fftwf_destroy_plan(plan->p); plan->p = NULL; } plan->p = fftwf_plan_dft_1d(new_dft_points, plan->in, plan->out, sign, FFTW_TYPE); + pthread_mutex_unlock(&fft_mutex); + if (!plan->p) { return -1; } @@ -136,10 +146,14 @@ int srslte_dft_plan_guru_c(srslte_dft_plan_t *plan, const int dft_points, srslte const fftwf_iodim iodim = {dft_points, istride, ostride}; const fftwf_iodim howmany_dims = {how_many, idist, odist}; + pthread_mutex_lock(&fft_mutex); + plan->p = fftwf_plan_guru_dft(1, &iodim, 1, &howmany_dims, in_buffer, out_buffer, sign, FFTW_TYPE); if (!plan->p) { return -1; } + pthread_mutex_unlock(&fft_mutex); + plan->size = dft_points; plan->init_size = plan->size; plan->mode = SRSLTE_DFT_COMPLEX; @@ -156,8 +170,14 @@ int srslte_dft_plan_guru_c(srslte_dft_plan_t *plan, const int dft_points, srslte int srslte_dft_plan_c(srslte_dft_plan_t *plan, const int dft_points, srslte_dft_dir_t dir) { allocate(plan,sizeof(fftwf_complex),sizeof(fftwf_complex), dft_points); + + pthread_mutex_lock(&fft_mutex); + int sign = (dir == SRSLTE_DFT_FORWARD) ? FFTW_FORWARD : FFTW_BACKWARD; plan->p = fftwf_plan_dft_1d(dft_points, plan->in, plan->out, sign, FFTW_TYPE); + + pthread_mutex_unlock(&fft_mutex); + if (!plan->p) { return -1; } @@ -177,11 +197,15 @@ int srslte_dft_plan_c(srslte_dft_plan_t *plan, const int dft_points, srslte_dft_ int srslte_dft_replan_r(srslte_dft_plan_t *plan, const int new_dft_points) { int sign = (plan->dir == SRSLTE_DFT_FORWARD) ? FFTW_R2HC : FFTW_HC2R; + + pthread_mutex_lock(&fft_mutex); if (plan->p) { fftwf_destroy_plan(plan->p); plan->p = NULL; } plan->p = fftwf_plan_r2r_1d(new_dft_points, plan->in, plan->out, sign, FFTW_TYPE); + pthread_mutex_unlock(&fft_mutex); + if (!plan->p) { return -1; } @@ -192,7 +216,11 @@ int srslte_dft_replan_r(srslte_dft_plan_t *plan, const int new_dft_points) { int srslte_dft_plan_r(srslte_dft_plan_t *plan, const int dft_points, srslte_dft_dir_t dir) { allocate(plan,sizeof(float),sizeof(float), dft_points); int sign = (dir == SRSLTE_DFT_FORWARD) ? FFTW_R2HC : FFTW_HC2R; + + pthread_mutex_lock(&fft_mutex); plan->p = fftwf_plan_r2r_1d(dft_points, plan->in, plan->out, sign, FFTW_TYPE); + pthread_mutex_unlock(&fft_mutex); + if (!plan->p) { return -1; } @@ -311,11 +339,15 @@ void srslte_dft_run_r(srslte_dft_plan_t *plan, const float *in, float *out) { void srslte_dft_plan_free(srslte_dft_plan_t *plan) { if (!plan) return; if (!plan->size) return; + + pthread_mutex_lock(&fft_mutex); if (!plan->is_guru) { if (plan->in) fftwf_free(plan->in); if (plan->out) fftwf_free(plan->out); } if (plan->p) fftwf_destroy_plan(plan->p); + pthread_mutex_unlock(&fft_mutex); + bzero(plan, sizeof(srslte_dft_plan_t)); } From 154623ed63f743227714a0e6a09b6592269e36f2 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Mon, 5 Mar 2018 17:39:34 +0100 Subject: [PATCH 063/134] Decrease the in-sync SNR threshold --- srsue/src/phy/phch_worker.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/srsue/src/phy/phch_worker.cc b/srsue/src/phy/phch_worker.cc index de73764f4..3a1dcbc98 100644 --- a/srsue/src/phy/phch_worker.cc +++ b/srsue/src/phy/phch_worker.cc @@ -410,7 +410,7 @@ void phch_worker::work_imp() update_measurements(); if (chest_ok) { - if (phy->avg_rsrp_dbm > -130.0 && phy->avg_snr_db > -30.0) { + if (phy->avg_rsrp_dbm > -130.0 && phy->avg_snr_db > -20.0) { log_h->debug("SNR=%.1f dB, RSRP=%.1f dBm sync=in-sync from channel estimator\n", 10*log10(srslte_chest_dl_get_snr(&ue_dl.chest)), phy->avg_rsrp_dbm); chest_loop->in_sync(); From 206e41a2440f87f30651a66ca54b627f9581a2b0 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Tue, 6 Mar 2018 12:37:08 +0100 Subject: [PATCH 064/134] Disable buffer pool timestamps --- lib/include/srslte/common/common.h | 34 ++++++++++++++++-------------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/lib/include/srslte/common/common.h b/lib/include/srslte/common/common.h index ddd558016..8089634b7 100644 --- a/lib/include/srslte/common/common.h +++ b/lib/include/srslte/common/common.h @@ -96,6 +96,8 @@ static const char error_text[ERROR_N_ITEMS][20] = { "None", "Can't start", "Already started"}; +//#define ENABLE_TIMESTAMP + /****************************************************************************** * Byte and Bit buffers * @@ -147,33 +149,27 @@ public: } long get_latency_us() { +#ifdef ENABLE_TIMESTAMP if(!timestamp_is_set) return 0; gettimeofday(×tamp[2], NULL); get_time_interval(timestamp); return timestamp[0].tv_usec; +#else + return 0; +#endif } void set_timestamp() { - gettimeofday(×tamp[1], NULL); - timestamp_is_set = true; +#ifdef ENABLE_TIMESTAMP + gettimeofday(×tamp[1], NULL); + timestamp_is_set = true; +#endif } private: - - - void get_time_interval(struct timeval * tdata) { - - tdata[0].tv_sec = tdata[2].tv_sec - tdata[1].tv_sec; - tdata[0].tv_usec = tdata[2].tv_usec - tdata[1].tv_usec; - if (tdata[0].tv_usec < 0) { - tdata[0].tv_sec--; - tdata[0].tv_usec += 1000000; - } - } - struct timeval timestamp[3]; bool timestamp_is_set; byte_buffer_t *next; @@ -215,15 +211,21 @@ struct bit_buffer_t{ } long get_latency_us() { +#ifdef ENABLE_TIMESTAMP if(!timestamp_is_set) return 0; gettimeofday(×tamp[2], NULL); return timestamp[0].tv_usec; +#else + return 0; +#endif } void set_timestamp() { - gettimeofday(×tamp[1], NULL); - timestamp_is_set = true; +#ifdef ENABLE_TIMESTAMP + gettimeofday(×tamp[1], NULL); + timestamp_is_set = true; +#endif } private: From dc65061dbb2ccf0e78abfaea1886ff7e3da7912a Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Tue, 6 Mar 2018 12:37:45 +0100 Subject: [PATCH 065/134] Print buffer pool status every 10s (Debugging commit) --- lib/include/srslte/common/buffer_pool.h | 3 +++ srsue/hdr/ue.h | 2 ++ srsue/hdr/ue_base.h | 2 ++ srsue/src/main.cc | 3 ++- srsue/src/ue.cc | 4 ++++ 5 files changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/include/srslte/common/buffer_pool.h b/lib/include/srslte/common/buffer_pool.h index 4edc50fc6..035fbc661 100644 --- a/lib/include/srslte/common/buffer_pool.h +++ b/lib/include/srslte/common/buffer_pool.h @@ -173,6 +173,9 @@ public: pool->deallocate(b); b = NULL; } + void print_all_buffers() { + pool->print_all_buffers(); + } private: buffer_pool *pool; }; diff --git a/srsue/hdr/ue.h b/srsue/hdr/ue.h index e6c66b540..d1343c68f 100644 --- a/srsue/hdr/ue.h +++ b/srsue/hdr/ue.h @@ -72,6 +72,8 @@ public: bool is_attached(); void start_plot(); + void print_pool(); + static void rf_msg(srslte_rf_error_t error); // UE metrics interface diff --git a/srsue/hdr/ue_base.h b/srsue/hdr/ue_base.h index 201f63843..7baa0dfc6 100644 --- a/srsue/hdr/ue_base.h +++ b/srsue/hdr/ue_base.h @@ -157,6 +157,8 @@ public: virtual bool is_attached() = 0; virtual void start_plot() = 0; + virtual void print_pool() = 0; + virtual void radio_overflow() = 0; void handle_rf_msg(srslte_rf_error_t error); diff --git a/srsue/src/main.cc b/srsue/src/main.cc index 1cac2092d..e687756ed 100644 --- a/srsue/src/main.cc +++ b/srsue/src/main.cc @@ -474,7 +474,8 @@ int main(int argc, char *argv[]) plot_started = true; } } - sleep(1); + ue->print_pool(); + sleep(10); } pthread_cancel(input); metricshub.stop(); diff --git a/srsue/src/ue.cc b/srsue/src/ue.cc index 23175fa46..e9afcec41 100644 --- a/srsue/src/ue.cc +++ b/srsue/src/ue.cc @@ -278,6 +278,10 @@ void ue::start_plot() { phy.start_plot(); } +void ue::print_pool() { + byte_buffer_pool::get_instance()->print_all_buffers(); +} + bool ue::get_metrics(ue_metrics_t &m) { m.rf = rf_metrics; From 8f028e34f30f8f14e902a5ee2b44d6ce8fa686b2 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Tue, 6 Mar 2018 12:39:29 +0100 Subject: [PATCH 066/134] Do not deallocate BCCH buffer in dl_harq --- srsue/hdr/mac/dl_harq.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/srsue/hdr/mac/dl_harq.h b/srsue/hdr/mac/dl_harq.h index 9d7d8f48e..f4c557898 100644 --- a/srsue/hdr/mac/dl_harq.h +++ b/srsue/hdr/mac/dl_harq.h @@ -226,7 +226,9 @@ private: is_first_tb = true; ack = false; if (payload_buffer_ptr) { - harq_entity->demux_unit->deallocate(payload_buffer_ptr); + if (pid != HARQ_BCCH_PID) { + harq_entity->demux_unit->deallocate(payload_buffer_ptr); + } payload_buffer_ptr = NULL; } bzero(&cur_grant, sizeof(Tgrant)); @@ -342,7 +344,7 @@ private: harq_entity->nof_pkts++); } } - } else { + } else if (pid != HARQ_BCCH_PID) { harq_entity->demux_unit->deallocate(payload_buffer_ptr); } From 0ce4e30905597f36e08d1fad6e43a466e526f15a Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Tue, 6 Mar 2018 12:40:34 +0100 Subject: [PATCH 067/134] Minor looging edits --- srsue/src/phy/phch_recv.cc | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index b05a88205..7d9c1bff2 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -142,8 +142,8 @@ void phch_recv::reset() void phch_recv::radio_error() { log_h->error("SYNC: Receiving from radio.\n"); - phy_state = CELL_SEARCH; reset(); + phy_state = CELL_SEARCH; // Need to find a method to effectively reset radio, reloading the driver does not work radio_h->reset(); } @@ -257,20 +257,20 @@ void phch_recv::force_freq(float dl_freq, float ul_freq) { void phch_recv::reset_sync() { + Info("SYNC: Reset. Going to Cell Select\n"); sfn_p.reset(); search_p.reset(); measure_p.reset(); srslte_ue_sync_reset(&ue_sync); - Info("----- PHY RESET----\n"); phy_state = CELL_SELECT; } void phch_recv::cell_search_inc() { - Info("cell_search_inc, cur_idx=%d, size=%d\n", cur_earfcn_index, earfcn.size()); cur_earfcn_index++; if (cur_earfcn_index >= 0) { if (cur_earfcn_index >= (int) earfcn.size()) { + Info("SYNC: Cell Search finished. Going to IDLE\n"); cur_earfcn_index = 0; phy_state = IDLE; rrc->earfcn_end(); @@ -346,8 +346,9 @@ bool phch_recv::cell_handover(srslte_cell_t cell) } /* interface from higher layers to select a new cell */ -void phch_recv::cell_select(uint32_t earfcn, srslte_cell_t cell) { - +void phch_recv::cell_select(uint32_t earfcn, srslte_cell_t cell) +{ + Info("SYNC: Cell Reselect to EARFCN=%d, PCI=%d\n", earfcn, cell.id); new_earfcn = earfcn; new_cell = cell; phy_state = CELL_RESELECT; @@ -359,7 +360,6 @@ void phch_recv::cell_reselect() uint32_t earfcn = new_earfcn; srslte_cell_t cell = new_cell; - Info("Reset from cell_reselect\n"); reset_sync(); // If we are already in the new cell, just resynchronize @@ -529,11 +529,12 @@ void phch_recv::run_thread() { case search::CELL_FOUND: if (!srslte_cell_isvalid(&cell)) { - Error("SYNC: Detected invalid cell\n"); + Error("SYNC: Detected invalid cell. Going to IDLE\n"); phy_state = IDLE; break; } if (set_cell()) { + Info("SYNC: Setting sampling rate and going to Cell Select\n"); set_sampling_rate(); phy_state = CELL_SELECT; } @@ -973,7 +974,7 @@ phch_recv::sfn_sync::ret_code phch_recv::sfn_sync::run_subframe(srslte_cell_t *c } } } else { - Info("SYNC: PSS/SSS not found...\n"); + Debug("SYNC: PSS/SSS not found...\n"); } cnt++; From acd78dbb8580c5f6afa52729ec2974e85f086b14 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Tue, 6 Mar 2018 12:40:55 +0100 Subject: [PATCH 068/134] Change in-sync snr threshold and pass PCCH only if ack=true --- srsue/src/phy/phch_worker.cc | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/srsue/src/phy/phch_worker.cc b/srsue/src/phy/phch_worker.cc index de73764f4..66c8a0d7c 100644 --- a/srsue/src/phy/phch_worker.cc +++ b/srsue/src/phy/phch_worker.cc @@ -397,7 +397,9 @@ void phch_worker::work_imp() if (!dl_action.generate_ack_callback) { if (dl_mac_grant.rnti_type == SRSLTE_RNTI_PCH && dl_action.decode_enabled[0]) { - phy->mac->pch_decoded_ok(dl_mac_grant.n_bytes[0]); + if (dl_ack[0]) { + phy->mac->pch_decoded_ok(dl_mac_grant.n_bytes[0]); + } } else if (!rar_delivered) { for (uint32_t tb = 0; tb < SRSLTE_MAX_TB; tb++) { if (dl_action.decode_enabled[tb]) { @@ -410,7 +412,7 @@ void phch_worker::work_imp() update_measurements(); if (chest_ok) { - if (phy->avg_rsrp_dbm > -130.0 && phy->avg_snr_db > -30.0) { + if (phy->avg_rsrp_dbm > -130.0 && phy->avg_snr_db > -20.0) { log_h->debug("SNR=%.1f dB, RSRP=%.1f dBm sync=in-sync from channel estimator\n", 10*log10(srslte_chest_dl_get_snr(&ue_dl.chest)), phy->avg_rsrp_dbm); chest_loop->in_sync(); @@ -519,11 +521,16 @@ bool phch_worker::decode_pdcch_dl(srsue::mac_interface_phy::mac_grant_t* grant) srslte_dci_msg_t dci_msg; srslte_ra_dl_dci_t dci_unpacked; - - Debug("Looking for RNTI=0x%x\n", dl_rnti); + + if (type == SRSLTE_RNTI_RAR) { + Info("Looking for RNTI=0x%x\n", dl_rnti); + } if (srslte_ue_dl_find_dl_dci_type(&ue_dl, phy->config->dedicated.antenna_info_explicit_value.tx_mode, cfi, tti%10, dl_rnti, type, &dci_msg) != 1) { + if (type == SRSLTE_RNTI_RAR) { + Info("RAR not found\n"); + } return false; } From 390a463d9f1fb2ed7f8d0fbe62ff0f74d3c94498 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Tue, 6 Mar 2018 12:41:44 +0100 Subject: [PATCH 069/134] Check for PDU allocation and add warnings --- lib/src/upper/pdcp.cc | 12 ++++++++++-- lib/src/upper/rlc.cc | 37 +++++++++++++++++++++++++------------ 2 files changed, 35 insertions(+), 14 deletions(-) diff --git a/lib/src/upper/pdcp.cc b/lib/src/upper/pdcp.cc index 188c56c97..cb3ec7d84 100644 --- a/lib/src/upper/pdcp.cc +++ b/lib/src/upper/pdcp.cc @@ -92,8 +92,12 @@ bool pdcp::is_drb_enabled(uint32_t lcid) void pdcp::write_sdu(uint32_t lcid, byte_buffer_t *sdu) { - if(valid_lcid(lcid)) + if(valid_lcid(lcid)) { pdcp_array[lcid].write_sdu(sdu); + } else { + pdcp_log->warning("Writing sdu: lcid=%d. Deallocating sdu\n", lcid); + byte_buffer_pool::get_instance()->deallocate(sdu); + } } void pdcp::add_bearer(uint32_t lcid, srslte_pdcp_config_t cfg) @@ -149,8 +153,12 @@ void pdcp::enable_encryption(uint32_t lcid) *******************************************************************************/ void pdcp::write_pdu(uint32_t lcid, byte_buffer_t *pdu) { - if(valid_lcid(lcid)) + if(valid_lcid(lcid)) { pdcp_array[lcid].write_pdu(pdu); + } else { + pdcp_log->warning("Writing pdu: lcid=%d. Deallocating pdu\n", lcid); + byte_buffer_pool::get_instance()->deallocate(pdu); + } } void pdcp::write_pdu_bcch_bch(byte_buffer_t *sdu) diff --git a/lib/src/upper/rlc.cc b/lib/src/upper/rlc.cc index a626f3002..e771c34a2 100644 --- a/lib/src/upper/rlc.cc +++ b/lib/src/upper/rlc.cc @@ -187,10 +187,14 @@ void rlc::write_pdu_bcch_bch(uint8_t *payload, uint32_t nof_bytes) rlc_log->info_hex(payload, nof_bytes, "BCCH BCH message received."); dl_tput_bytes[0] += nof_bytes; byte_buffer_t *buf = pool_allocate; - memcpy(buf->msg, payload, nof_bytes); - buf->N_bytes = nof_bytes; - buf->set_timestamp(); - pdcp->write_pdu_bcch_bch(buf); + if (buf) { + memcpy(buf->msg, payload, nof_bytes); + buf->N_bytes = nof_bytes; + buf->set_timestamp(); + pdcp->write_pdu_bcch_bch(buf); + } else { + rlc_log->error("Fatal error: Out of buffers from the pool in write_pdu_bcch_bch()\n"); + } } void rlc::write_pdu_bcch_dlsch(uint8_t *payload, uint32_t nof_bytes) @@ -198,10 +202,14 @@ void rlc::write_pdu_bcch_dlsch(uint8_t *payload, uint32_t nof_bytes) rlc_log->info_hex(payload, nof_bytes, "BCCH TXSCH message received."); dl_tput_bytes[0] += nof_bytes; byte_buffer_t *buf = pool_allocate; - memcpy(buf->msg, payload, nof_bytes); - buf->N_bytes = nof_bytes; - buf->set_timestamp(); - pdcp->write_pdu_bcch_dlsch(buf); + if (buf) { + memcpy(buf->msg, payload, nof_bytes); + buf->N_bytes = nof_bytes; + buf->set_timestamp(); + pdcp->write_pdu_bcch_dlsch(buf); + } else { + rlc_log->error("Fatal error: Out of buffers from the pool in write_pdu_bcch_dlsch()\n"); + } } void rlc::write_pdu_pcch(uint8_t *payload, uint32_t nof_bytes) @@ -209,10 +217,14 @@ void rlc::write_pdu_pcch(uint8_t *payload, uint32_t nof_bytes) rlc_log->info_hex(payload, nof_bytes, "PCCH message received."); dl_tput_bytes[0] += nof_bytes; byte_buffer_t *buf = pool_allocate; - memcpy(buf->msg, payload, nof_bytes); - buf->N_bytes = nof_bytes; - buf->set_timestamp(); - pdcp->write_pdu_pcch(buf); + if (buf) { + memcpy(buf->msg, payload, nof_bytes); + buf->N_bytes = nof_bytes; + buf->set_timestamp(); + pdcp->write_pdu_pcch(buf); + } else { + rlc_log->error("Fatal error: Out of buffers from the pool in write_pdu_pcch()\n"); + } } /******************************************************************************* @@ -281,6 +293,7 @@ void rlc::add_bearer(uint32_t lcid, srslte_rlc_config_t cnfg) bool rlc::valid_lcid(uint32_t lcid) { if(lcid >= SRSLTE_N_RADIO_BEARERS) { + rlc_log->warning("Invalid LCID=%d\n", lcid); return false; } else if(!rlc_array[lcid].active()) { return false; From be959d0575e8f7aec63fdd0d95bcfd0f99d7392a Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Tue, 6 Mar 2018 12:46:02 +0100 Subject: [PATCH 070/134] Fix several pool leaks in RRC/NAS --- srsue/hdr/upper/rrc.h | 16 +++++----- srsue/src/upper/nas.cc | 26 +++++++++------- srsue/src/upper/rrc.cc | 69 ++++++++++++++++++++---------------------- 3 files changed, 56 insertions(+), 55 deletions(-) diff --git a/srsue/hdr/upper/rrc.h b/srsue/hdr/upper/rrc.h index 926e2bebe..55ee21097 100644 --- a/srsue/hdr/upper/rrc.h +++ b/srsue/hdr/upper/rrc.h @@ -295,9 +295,9 @@ private: LIBLTE_RRC_DL_CCCH_MSG_STRUCT dl_ccch_msg; LIBLTE_RRC_DL_DCCH_MSG_STRUCT dl_dcch_msg; - byte_buffer_t* byte_align_and_pack(byte_buffer_t *pdu = NULL); - void send_ul_ccch_msg(byte_buffer_t *pdu = NULL); - void send_ul_dcch_msg(byte_buffer_t *pdu = NULL); + byte_buffer_t* byte_align_and_pack(); + void send_ul_ccch_msg(); + void send_ul_dcch_msg(); srslte::bit_buffer_t bit_buf; pthread_mutex_t mutex; @@ -532,10 +532,10 @@ private: void send_con_restablish_request(LIBLTE_RRC_CON_REEST_REQ_CAUSE_ENUM cause, uint16_t crnti); void send_con_restablish_complete(); void send_con_setup_complete(byte_buffer_t *nas_msg); - void send_ul_info_transfer(uint32_t lcid, byte_buffer_t *sdu); - void send_security_mode_complete(uint32_t lcid, byte_buffer_t *pdu); - void send_rrc_con_reconfig_complete(byte_buffer_t *pdu); - void send_rrc_ue_cap_info(byte_buffer_t *pdu); + void send_ul_info_transfer(byte_buffer_t *nas_msg); + void send_security_mode_complete(); + void send_rrc_con_reconfig_complete(); + void send_rrc_ue_cap_info(); // Parsers void parse_dl_ccch(byte_buffer_t *pdu); @@ -562,7 +562,7 @@ private: void apply_sib2_configs(LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_2_STRUCT *sib2); void handle_con_setup(LIBLTE_RRC_CONNECTION_SETUP_STRUCT *setup); void handle_con_reest(LIBLTE_RRC_CONNECTION_REESTABLISHMENT_STRUCT *setup); - void handle_rrc_con_reconfig(uint32_t lcid, LIBLTE_RRC_CONNECTION_RECONFIGURATION_STRUCT *reconfig, byte_buffer_t *pdu); + void handle_rrc_con_reconfig(uint32_t lcid, LIBLTE_RRC_CONNECTION_RECONFIGURATION_STRUCT *reconfig); void add_srb(LIBLTE_RRC_SRB_TO_ADD_MOD_STRUCT *srb_cnfg); void add_drb(LIBLTE_RRC_DRB_TO_ADD_MOD_STRUCT *drb_cnfg); void release_drb(uint8_t lcid); diff --git a/srsue/src/upper/nas.cc b/srsue/src/upper/nas.cc index 8a05595c7..42dae8fc1 100644 --- a/srsue/src/upper/nas.cc +++ b/srsue/src/upper/nas.cc @@ -222,7 +222,7 @@ void nas::write_pdu(uint32_t lcid, byte_buffer_t *pdu) { default: nas_log->error("Not handling NAS message with SEC_HDR_TYPE=%02X\n", sec_hdr_type); pool->deallocate(pdu); - break; + return; } // Write NAS pcap @@ -266,7 +266,7 @@ void nas::write_pdu(uint32_t lcid, byte_buffer_t *pdu) { default: nas_log->error("Not handling NAS message with MSG_TYPE=%02X\n", msg_type); pool->deallocate(pdu); - break; + return; } } @@ -547,6 +547,8 @@ void nas::parse_attach_accept(uint32_t lcid, byte_buffer_t *pdu) { act_def_eps_bearer_context_accept.protocol_cnfg_opts_present = false; liblte_mme_pack_activate_default_eps_bearer_context_accept_msg(&act_def_eps_bearer_context_accept, &attach_complete.esm_msg); + + pdu->reset(); liblte_mme_pack_attach_complete_msg(&attach_complete, LIBLTE_MME_SECURITY_HDR_TYPE_INTEGRITY_AND_CIPHERED, ctxt.tx_count, @@ -762,36 +764,37 @@ void nas::parse_security_mode_command(uint32_t lcid, byte_buffer_t *pdu) } // Send response - byte_buffer_t *sdu = pool_allocate; + pdu->reset(); liblte_mme_pack_security_mode_complete_msg(&sec_mode_comp, LIBLTE_MME_SECURITY_HDR_TYPE_INTEGRITY_AND_CIPHERED_WITH_NEW_EPS_SECURITY_CONTEXT, ctxt.tx_count, - (LIBLTE_BYTE_MSG_STRUCT *) sdu); + (LIBLTE_BYTE_MSG_STRUCT *) pdu); if(pcap != NULL) { - pcap->write_nas(sdu->msg, sdu->N_bytes); + pcap->write_nas(pdu->msg, pdu->N_bytes); } - cipher_encrypt(sdu); + cipher_encrypt(pdu); integrity_generate(&k_nas_int[16], ctxt.tx_count, SECURITY_DIRECTION_UPLINK, - &sdu->msg[5], - sdu->N_bytes - 5, - &sdu->msg[1]); + &pdu->msg[5], + pdu->N_bytes - 5, + &pdu->msg[1]); nas_log->info("Sending Security Mode Complete nas_current_ctxt.tx_count=%d, RB=%s\n", ctxt.tx_count, rrc->get_rb_name(lcid).c_str()); - rrc->write_sdu(lcid, sdu); + rrc->write_sdu(lcid, pdu); ctxt.tx_count++; pool->deallocate(pdu); } void nas::parse_service_reject(uint32_t lcid, byte_buffer_t *pdu) { nas_log->error("TODO:parse_service_reject\n"); + pool->deallocate(pdu); } void nas::parse_esm_information_request(uint32_t lcid, byte_buffer_t *pdu) { nas_log->error("TODO:parse_esm_information_request\n"); - + pool->deallocate(pdu); } void nas::parse_emm_information(uint32_t lcid, byte_buffer_t *pdu) { @@ -800,6 +803,7 @@ void nas::parse_emm_information(uint32_t lcid, byte_buffer_t *pdu) { nas_log->info("Received EMM Information: %s\n", str.c_str()); nas_log->console("%s\n", str.c_str()); ctxt.rx_count++; + pool->deallocate(pdu); } /******************************************************************************* diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 11cb432fa..7c2798658 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -1070,34 +1070,36 @@ void rrc::send_con_setup_complete(byte_buffer_t *nas_msg) { send_ul_dcch_msg(); } -void rrc::send_ul_info_transfer(uint32_t lcid, byte_buffer_t *sdu) { +void rrc::send_ul_info_transfer(byte_buffer_t *nas_msg) { rrc_log->debug("Preparing RX Info Transfer\n"); // Prepare RX INFO packet ul_dcch_msg.msg_type = LIBLTE_RRC_UL_DCCH_MSG_TYPE_UL_INFO_TRANSFER; ul_dcch_msg.msg.ul_info_transfer.dedicated_info_type = LIBLTE_RRC_UL_INFORMATION_TRANSFER_TYPE_NAS; - memcpy(ul_dcch_msg.msg.ul_info_transfer.dedicated_info.msg, sdu->msg, sdu->N_bytes); - ul_dcch_msg.msg.ul_info_transfer.dedicated_info.N_bytes = sdu->N_bytes; + memcpy(ul_dcch_msg.msg.ul_info_transfer.dedicated_info.msg, nas_msg->msg, nas_msg->N_bytes); + ul_dcch_msg.msg.ul_info_transfer.dedicated_info.N_bytes = nas_msg->N_bytes; - send_ul_dcch_msg(sdu); + pool->deallocate(nas_msg); + + send_ul_dcch_msg(); } -void rrc::send_security_mode_complete(uint32_t lcid, byte_buffer_t *pdu) { +void rrc::send_security_mode_complete() { rrc_log->debug("Preparing Security Mode Complete\n"); ul_dcch_msg.msg_type = LIBLTE_RRC_UL_DCCH_MSG_TYPE_SECURITY_MODE_COMPLETE; ul_dcch_msg.msg.security_mode_complete.rrc_transaction_id = transaction_id; - send_ul_dcch_msg(pdu); + send_ul_dcch_msg(); } -void rrc::send_rrc_con_reconfig_complete(byte_buffer_t *pdu) { +void rrc::send_rrc_con_reconfig_complete() { rrc_log->debug("Preparing RRC Connection Reconfig Complete\n"); ul_dcch_msg.msg_type = LIBLTE_RRC_UL_DCCH_MSG_TYPE_RRC_CON_RECONFIG_COMPLETE; ul_dcch_msg.msg.rrc_con_reconfig_complete.rrc_transaction_id = transaction_id; - send_ul_dcch_msg(pdu); + send_ul_dcch_msg(); } bool rrc::ho_prepare() { @@ -1177,7 +1179,7 @@ bool rrc::ho_prepare() { k_rrc_enc, k_rrc_int, k_up_enc, k_up_int, cipher_algo, integ_algo); pdcp->config_security_all(k_rrc_enc, k_rrc_int, cipher_algo, integ_algo); - send_rrc_con_reconfig_complete(NULL); + send_rrc_con_reconfig_complete(); } return true; } @@ -1229,15 +1231,14 @@ void rrc::ho_failed() { send_con_restablish_request(LIBLTE_RRC_CON_REEST_REQ_CAUSE_HANDOVER_FAILURE, ho_src_rnti); } -void rrc::handle_rrc_con_reconfig(uint32_t lcid, LIBLTE_RRC_CONNECTION_RECONFIGURATION_STRUCT *reconfig, - byte_buffer_t *pdu) { +void rrc::handle_rrc_con_reconfig(uint32_t lcid, LIBLTE_RRC_CONNECTION_RECONFIGURATION_STRUCT *reconfig) { uint32_t i; if (reconfig->mob_ctrl_info_present) { if (reconfig->mob_ctrl_info.target_pci == phy->get_current_pci()) { rrc_log->warning("Received HO command to own cell\n"); - send_rrc_con_reconfig_complete(pdu); + send_rrc_con_reconfig_complete(); } else { rrc_log->info("Received HO command to target PCell=%d\n", reconfig->mob_ctrl_info.target_pci); rrc_log->console("Received HO command to target PCell=%d, NCC=%d\n", @@ -1259,7 +1260,7 @@ void rrc::handle_rrc_con_reconfig(uint32_t lcid, LIBLTE_RRC_CONNECTION_RECONFIGU measurements.parse_meas_config(&reconfig->meas_cnfg); } - send_rrc_con_reconfig_complete(pdu); + send_rrc_con_reconfig_complete(); byte_buffer_t *nas_sdu; for (i = 0; i < reconfig->N_ded_info_nas; i++) { @@ -1318,10 +1319,10 @@ void rrc::leave_connected() * *******************************************************************************/ void rrc::write_pdu_bcch_bch(byte_buffer_t *pdu) { - pool->deallocate(pdu); if (state == RRC_STATE_PLMN_SELECTION) { // Do we need to do something with BCH? rrc_log->info_hex(pdu->msg, pdu->N_bytes, "BCCH BCH message received."); + pool->deallocate(pdu); } else { rrc_log->warning("Received BCCH BCH in incorrect state\n"); } @@ -1523,7 +1524,7 @@ void rrc::write_pdu_pcch(byte_buffer_t *pdu) { * * *******************************************************************************/ -byte_buffer_t* rrc::byte_align_and_pack(byte_buffer_t *pdu) +byte_buffer_t* rrc::byte_align_and_pack() { // Byte align and pack the message bits for PDCP if ((bit_buf.N_bits % 8) != 0) { @@ -1533,15 +1534,8 @@ byte_buffer_t* rrc::byte_align_and_pack(byte_buffer_t *pdu) } // Reset and reuse sdu buffer if provided - byte_buffer_t *pdcp_buf = pdu; - + byte_buffer_t *pdcp_buf = pool_allocate; if (pdcp_buf) { - pdcp_buf->reset(); - } else { - pdcp_buf = pool_allocate; - } - - if (pdcp_buf != NULL) { srslte_bit_pack_vector(bit_buf.msg, pdcp_buf->msg, bit_buf.N_bits); pdcp_buf->N_bytes = bit_buf.N_bits / 8; pdcp_buf->set_timestamp(); @@ -1551,10 +1545,10 @@ byte_buffer_t* rrc::byte_align_and_pack(byte_buffer_t *pdu) return pdcp_buf; } -void rrc::send_ul_ccch_msg(byte_buffer_t *pdu) +void rrc::send_ul_ccch_msg() { liblte_rrc_pack_ul_ccch_msg(&ul_ccch_msg, (LIBLTE_BIT_MSG_STRUCT *) &bit_buf); - pdu = byte_align_and_pack(pdu); + byte_buffer_t *pdu = byte_align_and_pack(); if (pdu) { // Set UE contention resolution ID in MAC uint64_t uecri = 0; @@ -1572,11 +1566,10 @@ void rrc::send_ul_ccch_msg(byte_buffer_t *pdu) } } -void rrc::send_ul_dcch_msg(byte_buffer_t *pdu) +void rrc::send_ul_dcch_msg() { liblte_rrc_pack_ul_dcch_msg(&ul_dcch_msg, (LIBLTE_BIT_MSG_STRUCT *) &bit_buf); - - pdu = byte_align_and_pack(pdu); + byte_buffer_t *pdu = byte_align_and_pack(); if (pdu) { rrc_log->info("Sending %s\n", liblte_rrc_ul_dcch_msg_type_text[ul_dcch_msg.msg_type]); pdcp->write_sdu(RB_ID_SRB1, pdu); @@ -1591,7 +1584,7 @@ void rrc::write_sdu(uint32_t lcid, byte_buffer_t *sdu) { send_con_setup_complete(sdu); break; case RRC_STATE_CONNECTED: - send_ul_info_transfer(lcid, sdu); + send_ul_info_transfer(sdu); break; default: rrc_log->error("SDU received from NAS while RRC state = %s\n", rrc_state_text[state]); @@ -1665,11 +1658,15 @@ void rrc::parse_dl_dcch(uint32_t lcid, byte_buffer_t *pdu) { get_rb_name(lcid).c_str(), liblte_rrc_dl_dcch_msg_type_text[dl_dcch_msg.msg_type]); - // Reset and reuse pdu buffer if possible - pdu->reset(); + pool->deallocate(pdu); switch (dl_dcch_msg.msg_type) { case LIBLTE_RRC_DL_DCCH_MSG_TYPE_DL_INFO_TRANSFER: + pdu = pool_allocate; + if (!pdu) { + rrc_log->error("Fatal error: out of buffers in pool\n"); + return; + } memcpy(pdu->msg, dl_dcch_msg.msg.dl_info_transfer.dedicated_info.msg, dl_dcch_msg.msg.dl_info_transfer.dedicated_info.N_bytes); pdu->N_bytes = dl_dcch_msg.msg.dl_info_transfer.dedicated_info.N_bytes; @@ -1696,18 +1693,18 @@ void rrc::parse_dl_dcch(uint32_t lcid, byte_buffer_t *pdu) { // Configure PDCP for security pdcp->config_security(lcid, k_rrc_enc, k_rrc_int, cipher_algo, integ_algo); pdcp->enable_integrity(lcid); - send_security_mode_complete(lcid, pdu); + send_security_mode_complete(); pdcp->enable_encryption(lcid); break; case LIBLTE_RRC_DL_DCCH_MSG_TYPE_RRC_CON_RECONFIG: transaction_id = dl_dcch_msg.msg.rrc_con_reconfig.rrc_transaction_id; - handle_rrc_con_reconfig(lcid, &dl_dcch_msg.msg.rrc_con_reconfig, pdu); + handle_rrc_con_reconfig(lcid, &dl_dcch_msg.msg.rrc_con_reconfig); break; case LIBLTE_RRC_DL_DCCH_MSG_TYPE_UE_CAPABILITY_ENQUIRY: transaction_id = dl_dcch_msg.msg.ue_cap_enquiry.rrc_transaction_id; for (uint32_t i = 0; i < dl_dcch_msg.msg.ue_cap_enquiry.N_ue_cap_reqs; i++) { if (LIBLTE_RRC_RAT_TYPE_EUTRA == dl_dcch_msg.msg.ue_cap_enquiry.ue_capability_request[i]) { - send_rrc_ue_cap_info(pdu); + send_rrc_ue_cap_info(); break; } } @@ -1743,7 +1740,7 @@ void rrc::enable_capabilities() { phy->set_config_64qam_en(enable_ul_64); } -void rrc::send_rrc_ue_cap_info(byte_buffer_t *pdu) { +void rrc::send_rrc_ue_cap_info() { rrc_log->debug("Preparing UE Capability Info\n"); ul_dcch_msg.msg_type = LIBLTE_RRC_UL_DCCH_MSG_TYPE_UE_CAPABILITY_INFO; @@ -1792,7 +1789,7 @@ void rrc::send_rrc_ue_cap_info(byte_buffer_t *pdu) { liblte_rrc_pack_ul_dcch_msg(&ul_dcch_msg, (LIBLTE_BIT_MSG_STRUCT *) &bit_buf); - send_ul_dcch_msg(pdu); + send_ul_dcch_msg(); } From b5166e10cd32d77a7744de773cbed9068ebd053a Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Tue, 6 Mar 2018 13:18:25 +0100 Subject: [PATCH 071/134] Do not restart insync/outsync counters after multiple events --- srsue/src/phy/phch_recv.cc | 4 ++-- srsue/src/phy/phch_worker.cc | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 7d9c1bff2..ecd2cf241 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -705,23 +705,23 @@ void phch_recv::run_thread() } void phch_recv::in_sync() { - out_of_sync_cnt = 0; in_sync_cnt++; // Send RRC in-sync signal after 100 ms consecutive subframes if (in_sync_cnt == NOF_IN_SYNC_SF) { rrc->in_sync(); in_sync_cnt = 0; + out_of_sync_cnt = 0; } } // Out of sync called by worker or phch_recv every 1 or 5 ms void phch_recv::out_of_sync() { - in_sync_cnt = 0; // Send RRC out-of-sync signal after 200 ms consecutive subframes out_of_sync_cnt++; if (out_of_sync_cnt >= NOF_OUT_OF_SYNC_SF) { rrc->out_of_sync(); out_of_sync_cnt = 0; + in_sync_cnt = 0; } } diff --git a/srsue/src/phy/phch_worker.cc b/srsue/src/phy/phch_worker.cc index 66c8a0d7c..88c9b54c8 100644 --- a/srsue/src/phy/phch_worker.cc +++ b/srsue/src/phy/phch_worker.cc @@ -412,13 +412,13 @@ void phch_worker::work_imp() update_measurements(); if (chest_ok) { - if (phy->avg_rsrp_dbm > -130.0 && phy->avg_snr_db > -20.0) { + if (phy->avg_rsrp_dbm > -130.0 && phy->avg_snr_db > -10.0) { log_h->debug("SNR=%.1f dB, RSRP=%.1f dBm sync=in-sync from channel estimator\n", - 10*log10(srslte_chest_dl_get_snr(&ue_dl.chest)), phy->avg_rsrp_dbm); + phy->avg_snr_db, phy->avg_rsrp_dbm); chest_loop->in_sync(); } else { log_h->warning("SNR=%.1f dB RSRP=%.1f dBm, sync=out-of-sync from channel estimator\n", - 10*log10(srslte_chest_dl_get_snr(&ue_dl.chest)), phy->avg_rsrp_dbm); + phy->avg_snr_db, phy->avg_rsrp_dbm); chest_loop->out_of_sync(); } } From 69a2542e0f4bda7b8d83ab7dd714bddb18236a85 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Tue, 6 Mar 2018 13:30:52 +0100 Subject: [PATCH 072/134] Fixed deallocating PDU in NAS too early --- srsue/src/upper/nas.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/srsue/src/upper/nas.cc b/srsue/src/upper/nas.cc index 0123d106b..0a5b597e4 100644 --- a/srsue/src/upper/nas.cc +++ b/srsue/src/upper/nas.cc @@ -784,7 +784,6 @@ void nas::parse_security_mode_command(uint32_t lcid, byte_buffer_t *pdu) rrc->get_rb_name(lcid).c_str()); rrc->write_sdu(lcid, pdu); ctxt.tx_count++; - pool->deallocate(pdu); } void nas::parse_service_reject(uint32_t lcid, byte_buffer_t *pdu) { From fce672954edde1a397d4264a3888a98c66a26d2b Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Tue, 6 Mar 2018 13:37:20 +0100 Subject: [PATCH 073/134] Minor edit to SNR-to-CQI table --- lib/src/phy/phch/cqi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/src/phy/phch/cqi.c b/lib/src/phy/phch/cqi.c index 522cdf10b..683144439 100644 --- a/lib/src/phy/phch/cqi.c +++ b/lib/src/phy/phch/cqi.c @@ -407,7 +407,7 @@ float srslte_cqi_to_coderate(uint32_t cqi) { * Table III. */ // From paper -static float cqi_to_snr_table[15] = { 1.95, 4, 6, 8, 10, 11.95, 14.05, 16, 17.9, 19.9, 21.5, 23.45, 25.0, 27.30, 29}; +static float cqi_to_snr_table[15] = { 1.95, 4, 6, 8, 10, 11.95, 14.05, 16, 17.9, 20.9, 22.5, 24.75, 25.5, 27.30, 29}; // From experimental measurements @ 5 MHz //static float cqi_to_snr_table[15] = { 1, 1.75, 3, 4, 5, 6, 7.5, 9, 11.5, 13.0, 15.0, 18, 20, 22.5, 26.5}; From 5a8454f5a8a0511cd3726f0e8b0eac8b86bed1d0 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Tue, 6 Mar 2018 13:44:19 +0100 Subject: [PATCH 074/134] Fix for staying on PLMN search after disconnect --- srsue/src/phy/phch_worker.cc | 2 +- srsue/src/upper/rrc.cc | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/srsue/src/phy/phch_worker.cc b/srsue/src/phy/phch_worker.cc index 88c9b54c8..4546788ec 100644 --- a/srsue/src/phy/phch_worker.cc +++ b/srsue/src/phy/phch_worker.cc @@ -529,7 +529,7 @@ bool phch_worker::decode_pdcch_dl(srsue::mac_interface_phy::mac_grant_t* grant) if (srslte_ue_dl_find_dl_dci_type(&ue_dl, phy->config->dedicated.antenna_info_explicit_value.tx_mode, cfi, tti%10, dl_rnti, type, &dci_msg) != 1) { if (type == SRSLTE_RNTI_RAR) { - Info("RAR not found\n"); + Info("RAR not found, SNR=%.1f dB\n", 10*log10(srslte_chest_dl_get_snr(&ue_dl.chest))); } return false; } diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 7c2798658..37ae14e8c 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -767,9 +767,9 @@ void rrc::earfcn_end() { rrc_log->info("Finished searching cells in EARFCN set while in state %s\n", rrc_state_text[state]); // If searching for PLMN, indicate NAS we scanned all frequencies - if (state == RRC_STATE_PLMN_SELECTION) { + if (state >= RRC_STATE_PLMN_SELECTION && state < RRC_STATE_CONNECTING) { nas->plmn_search_end(); - } else if (state == RRC_STATE_CONNECTED) { + } else if (state >= RRC_STATE_CONNECTING && state < RRC_STATE_LEAVE_CONNECTED) { leave_connected(); } } From add125a01f4884d279f291b899595f9665b8990b Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Tue, 6 Mar 2018 12:26:49 +0100 Subject: [PATCH 075/134] check expiration of poll_retx_timer and schedule retx if needed --- lib/src/upper/rlc_am.cc | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/lib/src/upper/rlc_am.cc b/lib/src/upper/rlc_am.cc index f4dced1ec..e6e1ff279 100644 --- a/lib/src/upper/rlc_am.cc +++ b/lib/src/upper/rlc_am.cc @@ -198,7 +198,7 @@ uint32_t rlc_am::get_bearer() void rlc_am::write_sdu(byte_buffer_t *sdu) { tx_sdu_queue.write(sdu); - log->info_hex(sdu->msg, sdu->N_bytes, "%s Tx SDU, tx_sdu_len=%d", rrc->get_rb_name(lcid).c_str(), tx_sdu_queue.size()); + log->info_hex(sdu->msg, sdu->N_bytes, "%s Tx SDU, tx_sdu_queue_len=%d", rrc->get_rb_name(lcid).c_str(), tx_sdu_queue.size()); } /**************************************************************************** @@ -273,6 +273,27 @@ uint32_t rlc_am::get_buffer_state() goto unlock_and_return; } + // check if pollRetx timer expired (Section 5.2.2.3 in TS 36.322) + if (poll_retx()) { + // if both tx and retx buffer are empty, retransmit next PDU to be ack'ed + log->info("Poll reTx timer expired (lcid=%d)\n", lcid); + if ((tx_window.size() > 0 && retx_queue.size() == 0 && tx_sdu_queue.size() == 0)) { + std::map::iterator it = tx_window.find(vt_s - 1); + if (it != tx_window.end()) { + log->info("Schedule last PDU (SN=%d) for reTx.\n", vt_s - 1); + rlc_amd_retx_t retx; + retx.is_segment = false; + retx.so_start = 0; + retx.so_end = tx_window[vt_s - 1].buf->N_bytes; + retx.sn = vt_s - 1; + retx_queue.push_back(retx); + } else { + log->error("Found invalid PDU in tx_window.\n"); + } + poll_retx_timeout.start(cfg.t_poll_retx); + } + } + // Bytes needed for retx if(retx_queue.size() > 0) { rlc_amd_retx_t retx = retx_queue.front(); From 853f7746074ac5e4d33edd9f281c6706a36028c8 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Tue, 6 Mar 2018 13:59:29 +0100 Subject: [PATCH 076/134] add threaded timeout test --- lib/include/srslte/common/timeout.h | 9 ++++- lib/test/common/timeout_test.cc | 61 ++++++++++++++++++++++++++--- 2 files changed, 64 insertions(+), 6 deletions(-) diff --git a/lib/include/srslte/common/timeout.h b/lib/include/srslte/common/timeout.h index 2c9560729..4174b0237 100644 --- a/lib/include/srslte/common/timeout.h +++ b/lib/include/srslte/common/timeout.h @@ -84,7 +84,6 @@ public: } void thread_func() { - // substract time elapsed until now from timer duration gettimeofday(&start_time[2], NULL); get_time_interval(start_time); @@ -105,6 +104,14 @@ public: return false; } } + int32_t get_msec_to_expire() { + if (running) { + gettimeofday(&start_time[2], NULL); + get_time_interval(start_time); + return (duration_msec*1000 - start_time[0].tv_usec)/1000; + } + return 0; + } bool is_running() { return running; diff --git a/lib/test/common/timeout_test.cc b/lib/test/common/timeout_test.cc index 5c08e1b66..c2451cdb0 100644 --- a/lib/test/common/timeout_test.cc +++ b/lib/test/common/timeout_test.cc @@ -64,7 +64,43 @@ private: pthread_mutex_t mutex; }; -int main(int argc, char **argv) { + +int timer_thread_test() +{ + bool result; + uint32_t id = 0; + uint32_t duration_msec = 5; + uint32_t result_tolerance = 1; + + callback c; + timeout t; + + gettimeofday(&c.start_time[1], NULL); + t.start(duration_msec); + + while (t.is_running() && !t.expired()) { + printf("time to expire=%dms\n", t.get_msec_to_expire()); + usleep(1000); + } + + gettimeofday(&c.start_time[2], NULL); + get_time_interval(c.start_time); + uint32_t diff_ms = c.start_time[0].tv_usec*1e-3; + printf("Target duration: %dms, started: %ld:%ld, ended: %ld:%ld, actual duration %dms\n", + duration_msec, c.start_time[1].tv_sec, c.start_time[1].tv_usec, c.start_time[2].tv_sec, c.start_time[2].tv_usec, diff_ms); + + result = (duration_msec - result_tolerance <= diff_ms < duration_msec + result_tolerance); + + if(result) { + printf("Timer thread test passed\n"); + return 0; + }else{ + return -1; + } +} + +int single_thread_test() +{ bool result; uint32_t id = 0; uint32_t duration_msec = 5; @@ -84,10 +120,25 @@ int main(int argc, char **argv) { result = (diff_ms == duration_msec); if(result) { - printf("Passed\n"); - exit(0); + printf("Single thread test passed\n"); + return 0; }else{ - printf("Failed\n;"); - exit(1); + return -1; } } + + +int main(int argc, char **argv) +{ + if (single_thread_test()) { + printf("Single thread test failed.\n"); + return -1; + } + + if (timer_thread_test()) { + printf("Timer thread test failed.\n"); + return -1; + } + + return 0; +} From d84f6d3d41b08a634536ee46a1c907b0ee7104c9 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Tue, 6 Mar 2018 13:59:57 +0100 Subject: [PATCH 077/134] add parameter to change loglevel in rlc am stresser --- lib/test/upper/rlc_am_stress_test.cc | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/lib/test/upper/rlc_am_stress_test.cc b/lib/test/upper/rlc_am_stress_test.cc index bdee2248b..fb83e4cfd 100644 --- a/lib/test/upper/rlc_am_stress_test.cc +++ b/lib/test/upper/rlc_am_stress_test.cc @@ -46,6 +46,7 @@ typedef struct { uint32_t sdu_gen_delay_usec; uint32_t pdu_tx_delay_usec; bool reestablish; + uint32_t log_level; } stress_test_args_t; void parse_args(stress_test_args_t *args, int argc, char *argv[]) { @@ -64,7 +65,8 @@ void parse_args(stress_test_args_t *args, int argc, char *argv[]) { ("sdu_gen_delay", bpo::value(&args->sdu_gen_delay_usec)->default_value(10), "SDU generation delay (usec)") ("pdu_tx_delay", bpo::value(&args->pdu_tx_delay_usec)->default_value(10), "Delay in MAC for transfering PDU from tx'ing RLC to rx'ing RLC (usec)") ("error_rate", bpo::value(&args->error_rate)->default_value(0.1), "Rate at which RLC PDUs are dropped") - ("reestablish", bpo::value(&args->reestablish)->default_value(false), "Mimic RLC reestablish during execution"); + ("reestablish", bpo::value(&args->reestablish)->default_value(false), "Mimic RLC reestablish during execution") + ("loglevel", bpo::value(&args->log_level)->default_value(srslte::LOG_LEVEL_DEBUG), "Log level (1=Error,2=Warning,3=Info,4=Debug"); // these options are allowed on the command line bpo::options_description cmdline_options; @@ -81,6 +83,11 @@ void parse_args(stress_test_args_t *args, int argc, char *argv[]) { cout << common << endl << general << endl; exit(0); } + + if (args->log_level > 4) { + args->log_level = 4; + printf("Set log level to %d (%s)\n", args->log_level, srslte::log_level_text[args->log_level]); + } } class mac_reader @@ -260,8 +267,8 @@ void stress_test(stress_test_args_t args) { srslte::log_filter log1("RLC_AM_1"); srslte::log_filter log2("RLC_AM_2"); - log1.set_level(srslte::LOG_LEVEL_DEBUG); - log2.set_level(srslte::LOG_LEVEL_DEBUG); + log1.set_level((LOG_LEVEL_ENUM)args.log_level); + log2.set_level((LOG_LEVEL_ENUM)args.log_level); log1.set_hex_limit(-1); log2.set_hex_limit(-1); From 77c8bf08cf5608fee21690ed0162b1d5857c982e Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Tue, 6 Mar 2018 14:00:29 +0100 Subject: [PATCH 078/134] remove newlines --- lib/src/common/buffer_pool.cc | 7 ------- 1 file changed, 7 deletions(-) diff --git a/lib/src/common/buffer_pool.cc b/lib/src/common/buffer_pool.cc index e41668abf..3bb191143 100644 --- a/lib/src/common/buffer_pool.cc +++ b/lib/src/common/buffer_pool.cc @@ -54,12 +54,5 @@ void byte_buffer_pool::cleanup(void) } pthread_mutex_unlock(&instance_mutex); } - - - - - - - } // namespace srsue From f5e3049f6376cca927b71542a8edc0487bb9fc36 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Tue, 6 Mar 2018 14:46:50 +0100 Subject: [PATCH 079/134] add check for possible buffer pool misallocation in RRC/NAS/GW --- srsue/src/upper/gw.cc | 8 ++++++-- srsue/src/upper/nas.cc | 13 +++++++++++++ srsue/src/upper/rrc.cc | 11 ++++++++--- 3 files changed, 27 insertions(+), 5 deletions(-) diff --git a/srsue/src/upper/gw.cc b/srsue/src/upper/gw.cc index 65748f57b..fbf4bca9f 100644 --- a/srsue/src/upper/gw.cc +++ b/srsue/src/upper/gw.cc @@ -242,7 +242,11 @@ void gw::run_thread() struct iphdr *ip_pkt; uint32 idx = 0; int32 N_bytes; - srslte::byte_buffer_t *pdu = pool_allocate; + srslte::byte_buffer_t *pdu = pool_allocate; + if (!pdu) { + gw_log->error("Fatal Error: Couldn't allocate PDU in run_thread().\n"); + return; + } const static uint32_t ATTACH_TIMEOUT_MS = 10000; const static uint32_t ATTACH_MAX_ATTEMPTS = 3; @@ -307,7 +311,7 @@ void gw::run_thread() do { pdu = pool_allocate; if (!pdu) { - printf("Not enough buffers in pool\n"); + gw_log->error("Fatal Error: Couldn't allocate PDU in run_thread().\n"); usleep(100000); } } while(!pdu); diff --git a/srsue/src/upper/nas.cc b/srsue/src/upper/nas.cc index 0a5b597e4..5d766776a 100644 --- a/srsue/src/upper/nas.cc +++ b/srsue/src/upper/nas.cc @@ -812,6 +812,11 @@ void nas::parse_emm_information(uint32_t lcid, byte_buffer_t *pdu) { void nas::send_attach_request() { LIBLTE_MME_ATTACH_REQUEST_MSG_STRUCT attach_req; byte_buffer_t *msg = pool_allocate; + if (!msg) { + nas_log->error("Fatal Error: Couldn't allocate PDU in send_attach_request().\n"); + return; + } + u_int32_t i; attach_req.eps_attach_type = LIBLTE_MME_EPS_ATTACH_TYPE_EPS_ATTACH; @@ -913,6 +918,10 @@ void nas::gen_pdn_connectivity_request(LIBLTE_BYTE_MSG_STRUCT *msg) { void nas::send_security_mode_reject(uint8_t cause) { byte_buffer_t *msg = pool_allocate; + if (!msg) { + nas_log->error("Fatal Error: Couldn't allocate PDU in send_security_mode_reject().\n"); + return; + } LIBLTE_MME_SECURITY_MODE_REJECT_MSG_STRUCT sec_mode_rej; sec_mode_rej.emm_cause = cause; @@ -928,6 +937,10 @@ void nas::send_identity_response() {} void nas::send_service_request() { byte_buffer_t *msg = pool_allocate; + if (!msg) { + nas_log->error("Fatal Error: Couldn't allocate PDU in send_service_request().\n"); + return; + } // Pack the service request message directly msg->msg[0] = (LIBLTE_MME_SECURITY_HDR_TYPE_SERVICE_REQUEST << 4) | (LIBLTE_MME_PD_EPS_MOBILITY_MANAGEMENT); diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 37ae14e8c..56d0eb6ce 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -1265,9 +1265,14 @@ void rrc::handle_rrc_con_reconfig(uint32_t lcid, LIBLTE_RRC_CONNECTION_RECONFIGU byte_buffer_t *nas_sdu; for (i = 0; i < reconfig->N_ded_info_nas; i++) { nas_sdu = pool_allocate; - memcpy(nas_sdu->msg, &reconfig->ded_info_nas_list[i].msg, reconfig->ded_info_nas_list[i].N_bytes); - nas_sdu->N_bytes = reconfig->ded_info_nas_list[i].N_bytes; - nas->write_pdu(lcid, nas_sdu); + if (nas_sdu) { + memcpy(nas_sdu->msg, &reconfig->ded_info_nas_list[i].msg, reconfig->ded_info_nas_list[i].N_bytes); + nas_sdu->N_bytes = reconfig->ded_info_nas_list[i].N_bytes; + nas->write_pdu(lcid, nas_sdu); + } else { + rrc_log->error("Fatal Error: Couldn't allocate PDU in handle_rrc_con_reconfig().\n"); + return; + } } } } From 4575a9e610291846176e3e98a3ca69881738a810 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Tue, 6 Mar 2018 15:20:23 +0100 Subject: [PATCH 080/134] add further checks for pool allocate return in srsENB and RLC UM/TM --- lib/src/upper/rlc_tm.cc | 12 ++++++++---- lib/src/upper/rlc_um.cc | 23 ++++++++++++++++++++++- srsenb/src/upper/gtpu.cc | 4 ++++ srsenb/src/upper/s1ap.cc | 32 ++++++++++++++++++++++++++++---- 4 files changed, 62 insertions(+), 9 deletions(-) diff --git a/lib/src/upper/rlc_tm.cc b/lib/src/upper/rlc_tm.cc index bcf3cd20a..b9d41d3f2 100644 --- a/lib/src/upper/rlc_tm.cc +++ b/lib/src/upper/rlc_tm.cc @@ -125,10 +125,14 @@ int rlc_tm::read_pdu(uint8_t *payload, uint32_t nof_bytes) void rlc_tm::write_pdu(uint8_t *payload, uint32_t nof_bytes) { byte_buffer_t *buf = pool_allocate; - memcpy(buf->msg, payload, nof_bytes); - buf->N_bytes = nof_bytes; - buf->set_timestamp(); - pdcp->write_pdu(lcid, buf); + if (buf) { + memcpy(buf->msg, payload, nof_bytes); + buf->N_bytes = nof_bytes; + buf->set_timestamp(); + pdcp->write_pdu(lcid, buf); + } else { + log->error("Fatal Error: Couldn't allocate buffer in rlc_tm::write_pdu().\n"); + } } } // namespace srsue diff --git a/lib/src/upper/rlc_um.cc b/lib/src/upper/rlc_um.cc index a365a4501..647494552 100644 --- a/lib/src/upper/rlc_um.cc +++ b/lib/src/upper/rlc_um.cc @@ -448,8 +448,13 @@ void rlc_um::handle_data_pdu(uint8_t *payload, uint32_t nof_bytes) void rlc_um::reassemble_rx_sdus() { - if(!rx_sdu) + if(!rx_sdu) { rx_sdu = pool_allocate; + if (!rx_sdu) { + log->error("Fatal Error: Couldn't allocate buffer in rlc_um::reassemble_rx_sdus().\n"); + return; + } + } // First catch up with lower edge of reordering window while(!inside_reordering_window(vr_ur)) @@ -474,6 +479,10 @@ void rlc_um::reassemble_rx_sdus() rx_sdu->set_timestamp(); pdcp->write_pdu(lcid, rx_sdu); rx_sdu = pool_allocate; + if (!rx_sdu) { + log->error("Fatal Error: Couldn't allocate buffer in rlc_um::reassemble_rx_sdus().\n"); + return; + } } pdu_lost = false; } @@ -494,6 +503,10 @@ void rlc_um::reassemble_rx_sdus() rx_sdu->set_timestamp(); pdcp->write_pdu(lcid, rx_sdu); rx_sdu = pool_allocate; + if (!rx_sdu) { + log->error("Fatal Error: Couldn't allocate buffer in rlc_um::reassemble_rx_sdus().\n"); + return; + } } pdu_lost = false; } @@ -528,6 +541,10 @@ void rlc_um::reassemble_rx_sdus() rx_sdu->set_timestamp(); pdcp->write_pdu(lcid, rx_sdu); rx_sdu = pool_allocate; + if (!rx_sdu) { + log->error("Fatal Error: Couldn't allocate buffer in rlc_um::reassemble_rx_sdus().\n"); + return; + } } pdu_lost = false; } @@ -557,6 +574,10 @@ void rlc_um::reassemble_rx_sdus() rx_sdu->set_timestamp(); pdcp->write_pdu(lcid, rx_sdu); rx_sdu = pool_allocate; + if (!rx_sdu) { + log->error("Fatal Error: Couldn't allocate buffer in rlc_um::reassemble_rx_sdus().\n"); + return; + } } pdu_lost = false; } diff --git a/srsenb/src/upper/gtpu.cc b/srsenb/src/upper/gtpu.cc index 53b7cffdb..2336f9047 100644 --- a/srsenb/src/upper/gtpu.cc +++ b/srsenb/src/upper/gtpu.cc @@ -195,6 +195,10 @@ void gtpu::rem_user(uint16_t rnti) void gtpu::run_thread() { byte_buffer_t *pdu = pool_allocate; + if (!pdu) { + gtpu_log->error("Fatal Error: Couldn't allocate buffer in gtpu::run_thread().\n"); + return; + } run_enable = true; running=true; diff --git a/srsenb/src/upper/s1ap.cc b/srsenb/src/upper/s1ap.cc index 44a564d09..a3d937a57 100644 --- a/srsenb/src/upper/s1ap.cc +++ b/srsenb/src/upper/s1ap.cc @@ -88,6 +88,10 @@ void s1ap::get_metrics(s1ap_metrics_t &m) void s1ap::run_thread() { srslte::byte_buffer_t *pdu = pool_allocate; + if (!pdu) { + s1ap_log->error("Fatal Error: Couldn't allocate buffer in s1ap::run_thread().\n"); + return; + } uint32_t sz = SRSLTE_MAX_BUFFER_SIZE_BYTES - SRSLTE_BUFFER_HEADER_OFFSET; running = true; @@ -514,10 +518,15 @@ bool s1ap::handle_dlnastransport(LIBLTE_S1AP_MESSAGE_DOWNLINKNASTRANSPORT_STRUCT } srslte::byte_buffer_t *pdu = pool_allocate; - memcpy(pdu->msg, msg->NAS_PDU.buffer, msg->NAS_PDU.n_octets); - pdu->N_bytes = msg->NAS_PDU.n_octets; - rrc->write_dl_info(rnti, pdu); - return true; + if (pdu) { + memcpy(pdu->msg, msg->NAS_PDU.buffer, msg->NAS_PDU.n_octets); + pdu->N_bytes = msg->NAS_PDU.n_octets; + rrc->write_dl_info(rnti, pdu); + return true; + } else { + s1ap_log->error("Fatal Error: Couldn't allocate buffer in s1ap::run_thread().\n"); + return false; + } } bool s1ap::handle_initialctxtsetuprequest(LIBLTE_S1AP_MESSAGE_INITIALCONTEXTSETUPREQUEST_STRUCT *msg) @@ -850,6 +859,11 @@ bool s1ap::send_initial_ctxt_setup_response(uint16_t rnti, LIBLTE_S1AP_MESSAGE_I return false; } srslte::byte_buffer_t *buf = pool_allocate; + if (!buf) { + s1ap_log->error("Fatal Error: Couldn't allocate buffer in s1ap::send_initial_ctxt_setup_response().\n"); + return false; + } + LIBLTE_S1AP_S1AP_PDU_STRUCT tx_pdu; tx_pdu.ext = false; @@ -896,6 +910,11 @@ bool s1ap::send_erab_setup_response(uint16_t rnti, LIBLTE_S1AP_MESSAGE_E_RABSETU return false; } srslte::byte_buffer_t *buf = pool_allocate; + if (!buf) { + s1ap_log->error("Fatal Error: Couldn't allocate buffer in s1ap::send_erab_setup_response().\n"); + return false; + } + LIBLTE_S1AP_S1AP_PDU_STRUCT tx_pdu; tx_pdu.ext = false; @@ -942,6 +961,11 @@ bool s1ap::send_initial_ctxt_setup_failure(uint16_t rnti) return false; } srslte::byte_buffer_t *buf = pool_allocate; + if (!buf) { + s1ap_log->error("Fatal Error: Couldn't allocate buffer in s1ap::send_initial_ctxt_setup_failure().\n"); + return false; + } + LIBLTE_S1AP_S1AP_PDU_STRUCT tx_pdu; tx_pdu.ext = false; tx_pdu.choice_type = LIBLTE_S1AP_S1AP_PDU_CHOICE_UNSUCCESSFULOUTCOME; From cd0373c533e3e174ab7e253a8addef18aeb29dbc Mon Sep 17 00:00:00 2001 From: Francisco Paisana Date: Tue, 6 Mar 2018 15:19:47 +0000 Subject: [PATCH 081/134] opt assignment was being erased by bzero call --- lib/src/phy/rf/rf_uhd_imp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/src/phy/rf/rf_uhd_imp.c b/lib/src/phy/rf/rf_uhd_imp.c index 0370fa700..b4b0cfcd6 100644 --- a/lib/src/phy/rf/rf_uhd_imp.c +++ b/lib/src/phy/rf/rf_uhd_imp.c @@ -80,8 +80,8 @@ static void log_overflow(rf_uhd_handler_t *h) { static void log_late(rf_uhd_handler_t *h, bool is_rx) { if (h->uhd_error_handler) { srslte_rf_error_t error; - error.opt = is_rx?1:0; bzero(&error, sizeof(srslte_rf_error_t)); + error.opt = is_rx?1:0; error.type = SRSLTE_RF_ERROR_LATE; h->uhd_error_handler(error); } From 962164277ad90b4c2f70dfab3b0571d6c8311926 Mon Sep 17 00:00:00 2001 From: Xavier Arteaga Date: Tue, 6 Mar 2018 17:09:59 +0100 Subject: [PATCH 082/134] Normalize CSI to maximum. --- lib/src/phy/phch/pdsch.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/src/phy/phch/pdsch.c b/lib/src/phy/phch/pdsch.c index 4cfa5c75c..c59956a71 100644 --- a/lib/src/phy/phch/pdsch.c +++ b/lib/src/phy/phch/pdsch.c @@ -659,8 +659,13 @@ static int srslte_pdsch_codeword_decode(srslte_pdsch_t *q, srslte_pdsch_cfg_t *c int16_t *e = q->e[codeword_idx]; if (q->csi_enabled) { + const uint32_t csi_max_idx = srslte_vec_max_fi(q->csi[codeword_idx], nbits->nof_bits / qm); + float csi_max = 1.0f; + if (csi_max_idx < nbits->nof_bits / qm) { + csi_max = q->csi[codeword_idx][csi_max_idx]; + } for (int i = 0; i < nbits->nof_bits / qm; i++) { - float csi = q->csi[codeword_idx][i]; + const float csi = q->csi[codeword_idx][i] / csi_max; for (int k = 0; k < qm; k++) { e[qm * i + k] = (int16_t) ((float) e[qm * i + k] * csi); } From b5421301af6acd7358ec050e4334e69b9a0083fc Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Tue, 6 Mar 2018 18:45:31 +0100 Subject: [PATCH 083/134] fix mem leak in NAS test --- srsue/test/upper/nas_test.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/srsue/test/upper/nas_test.cc b/srsue/test/upper/nas_test.cc index 4f4ffb687..bf249f792 100644 --- a/srsue/test/upper/nas_test.cc +++ b/srsue/test/upper/nas_test.cc @@ -76,6 +76,7 @@ public: printf("NAS generated SDU (len=%d):\n", sdu->N_bytes); last_sdu_len = sdu->N_bytes; srslte_vec_fprint_byte(stdout, sdu->msg, sdu->N_bytes); + byte_buffer_pool::get_instance()->deallocate(sdu); } std::string get_rb_name(uint32_t lcid) { return std::string("lcid"); } uint32_t get_last_sdu_len() { return last_sdu_len; } From c3088e1d16b6a78a9bdfc95135ec3dd905da21bc Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Tue, 6 Mar 2018 20:50:25 +0100 Subject: [PATCH 084/134] add cmake option to enable address sanitizer --- CMakeLists.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index d67985c49..10952a010 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -74,6 +74,7 @@ option(ENABLE_BLADERF "Enable BladeRF" ON) option(BUILD_STATIC "Attempt to statically link external deps" OFF) option(RPATH "Enable RPATH" OFF) +option(ENABLE_ASAN "Enable gcc address sanitizer" OFF) option(USE_LTE_RATES "Use standard LTE sampling rates" OFF) @@ -303,6 +304,10 @@ if(CMAKE_C_COMPILER_ID MATCHES "GNU" OR CMAKE_C_COMPILER_ID MATCHES "Clang") if(NOT WIN32) ADD_CXX_COMPILER_FLAG_IF_AVAILABLE(-fvisibility=hidden HAVE_VISIBILITY_HIDDEN) endif(NOT WIN32) + if (ENABLE_ASAN) + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fsanitize=address") + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address") + endif (ENABLE_ASAN) endif(CMAKE_C_COMPILER_ID MATCHES "GNU" OR CMAKE_C_COMPILER_ID MATCHES "Clang") if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin") From e933f05933abed155d95670854d2f014c3f2bed6 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Tue, 6 Mar 2018 21:34:36 +0100 Subject: [PATCH 085/134] fix memleak in vector test../lib/src/phy/utils/test/vector_test.c --- lib/src/phy/utils/test/vector_test.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/src/phy/utils/test/vector_test.c b/lib/src/phy/utils/test/vector_test.c index 55ff2944e..623fdb526 100644 --- a/lib/src/phy/utils/test/vector_test.c +++ b/lib/src/phy/utils/test/vector_test.c @@ -265,6 +265,7 @@ TEST(srslte_vec_sum_fff, free(x); free(y); + free(z); ) TEST(srslte_vec_sub_fff, @@ -287,6 +288,7 @@ TEST(srslte_vec_sub_fff, free(x); free(y); + free(z); ) TEST(srslte_vec_dot_prod_ccc, @@ -354,6 +356,7 @@ TEST(srslte_vec_prod_ccc, } free(x); + free(y); free(z); ) @@ -407,6 +410,7 @@ TEST(srslte_vec_prod_conj_ccc, } free(x); + free(y); free(z); ) From cae09a8d5832d8a2d802d155281caa856bf08f1b Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Tue, 6 Mar 2018 21:35:15 +0100 Subject: [PATCH 086/134] fix mem leak in PMCH --- lib/src/phy/phch/pmch.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/src/phy/phch/pmch.c b/lib/src/phy/phch/pmch.c index c1c322f34..ed6bbf2b5 100644 --- a/lib/src/phy/phch/pmch.c +++ b/lib/src/phy/phch/pmch.c @@ -152,9 +152,8 @@ int srslte_pmch_init(srslte_pmch_t *q, uint32_t max_prb) int srslte_pmch_init_multi(srslte_pmch_t *q, uint32_t max_prb, uint32_t nof_rx_antennas) { int ret = SRSLTE_ERROR_INVALID_INPUTS; - int i; - if (q != NULL && + if (q != NULL && nof_rx_antennas <= SRSLTE_MAX_PORTS) { @@ -169,7 +168,7 @@ int srslte_pmch_init_multi(srslte_pmch_t *q, uint32_t max_prb, uint32_t nof_rx_a INFO("Init PMCH: %d PRBs, max_symbols: %d\n", max_prb, q->max_re); - for (i = 0; i < 4; i++) { + for (int i = 0; i < 4; i++) { if (srslte_modem_table_lte(&q->mod[i], modulations[i])) { goto clean; } @@ -189,7 +188,7 @@ int srslte_pmch_init_multi(srslte_pmch_t *q, uint32_t max_prb, uint32_t nof_rx_a goto clean; } - for (i = 0; i < SRSLTE_MAX_PORTS; i++) { + for (int i = 0; i < SRSLTE_MAX_PORTS; i++) { q->x[i] = srslte_vec_malloc(sizeof(cf_t) * q->max_re); if (!q->x[i]) { goto clean; @@ -232,7 +231,7 @@ void srslte_pmch_free(srslte_pmch_t *q) { if (q->d) { free(q->d); } - for (i = 0; i < q->cell.nof_ports; i++) { + for (i = 0; i < SRSLTE_MAX_PORTS; i++) { if (q->x[i]) { free(q->x[i]); } From 4c76e98f9e049dcafe73951fd45549f60950f445 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Tue, 6 Mar 2018 21:35:55 +0100 Subject: [PATCH 087/134] fix memleak in DL chest object --- lib/src/phy/ch_estimation/chest_dl.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/lib/src/phy/ch_estimation/chest_dl.c b/lib/src/phy/ch_estimation/chest_dl.c index 221bac319..ec827ec13 100644 --- a/lib/src/phy/ch_estimation/chest_dl.c +++ b/lib/src/phy/ch_estimation/chest_dl.c @@ -88,7 +88,7 @@ int srslte_chest_dl_init(srslte_chest_dl_t *q, uint32_t max_prb) goto clean_exit; } - q->mbsfn_refs = calloc(SRSLTE_MAX_MBSFN_AREA_IDS, sizeof(srslte_refsignal_t*)); + q->mbsfn_refs = calloc(SRSLTE_MAX_MBSFN_AREA_IDS, sizeof(srslte_refsignal_t)); if (!q->mbsfn_refs) { fprintf(stderr, "Calloc error initializing mbsfn_refs (%d)\n", ret); goto clean_exit; @@ -169,14 +169,14 @@ clean_exit: void srslte_chest_dl_free(srslte_chest_dl_t *q) { - int i; if(&q->csr_refs) srslte_refsignal_free(&q->csr_refs); if (q->mbsfn_refs) { - for (i=0; imbsfn_refs[i]) { srslte_refsignal_free(q->mbsfn_refs[i]); + free(q->mbsfn_refs[i]); } } free(q->mbsfn_refs); @@ -206,15 +206,18 @@ void srslte_chest_dl_free(srslte_chest_dl_t *q) int srslte_chest_dl_set_mbsfn_area_id(srslte_chest_dl_t *q, uint16_t mbsfn_area_id){ - if(!q->mbsfn_refs[mbsfn_area_id]){ - q->mbsfn_refs[mbsfn_area_id] = calloc(1, sizeof(srslte_refsignal_t)); - } - if(q->mbsfn_refs[mbsfn_area_id]) { - if(srslte_refsignal_mbsfn_init(q->mbsfn_refs[mbsfn_area_id], q->cell, mbsfn_area_id)) { - return SRSLTE_ERROR; + if (mbsfn_area_id < SRSLTE_MAX_MBSFN_AREA_IDS) { + if(!q->mbsfn_refs[mbsfn_area_id]) { + q->mbsfn_refs[mbsfn_area_id] = calloc(1, sizeof(srslte_refsignal_t)); } - } - return SRSLTE_SUCCESS; + if(q->mbsfn_refs[mbsfn_area_id]) { + if(srslte_refsignal_mbsfn_init(q->mbsfn_refs[mbsfn_area_id], q->cell, mbsfn_area_id)) { + return SRSLTE_ERROR; + } + } + return SRSLTE_SUCCESS; + } + return SRSLTE_ERROR; } int srslte_chest_dl_set_cell(srslte_chest_dl_t *q, srslte_cell_t cell) From c6933f53388238491387726f082d14cec3c68f8d Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Tue, 6 Mar 2018 21:48:44 +0100 Subject: [PATCH 088/134] fix leak in turbocoder test --- lib/src/phy/fec/test/turbocoder_test.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/src/phy/fec/test/turbocoder_test.c b/lib/src/phy/fec/test/turbocoder_test.c index c7ca41fe3..8daeebdb8 100644 --- a/lib/src/phy/fec/test/turbocoder_test.c +++ b/lib/src/phy/fec/test/turbocoder_test.c @@ -71,8 +71,6 @@ int main(int argc, char **argv) { parse_args(argc, argv); - srslte_tcod_gentable(); - srslte_tcod_t tcod; srslte_tcod_init(&tcod, 6144); From 13efa740e846dea1b0b559d1229418d8bd1b1f39 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Tue, 6 Mar 2018 22:20:38 +0100 Subject: [PATCH 089/134] Changed logic in RRC/NAS/PHY for cell/plmn search to avoid stucking in IDLE --- lib/include/srslte/interfaces/ue_interfaces.h | 4 +- srsue/hdr/phy/phch_recv.h | 2 +- srsue/hdr/upper/nas.h | 3 +- srsue/hdr/upper/rrc.h | 7 +- srsue/src/phy/phch_recv.cc | 6 +- srsue/src/phy/phch_worker.cc | 4 +- srsue/src/upper/nas.cc | 24 +- srsue/src/upper/rrc.cc | 212 ++++++++++-------- srsue/test/upper/nas_test.cc | 2 +- 9 files changed, 140 insertions(+), 124 deletions(-) diff --git a/lib/include/srslte/interfaces/ue_interfaces.h b/lib/include/srslte/interfaces/ue_interfaces.h index 923111371..b1251c0bb 100644 --- a/lib/include/srslte/interfaces/ue_interfaces.h +++ b/lib/include/srslte/interfaces/ue_interfaces.h @@ -119,7 +119,7 @@ public: virtual uint32_t get_ul_count() = 0; virtual bool get_s_tmsi(LIBLTE_RRC_S_TMSI_STRUCT *s_tmsi) = 0; virtual bool get_k_asme(uint8_t *k_asme_, uint32_t n) = 0; - virtual void plmn_found(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id, uint16_t tracking_area_code) = 0; + virtual bool plmn_found(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id, uint16_t tracking_area_code) = 0; virtual void plmn_search_end() = 0; }; @@ -173,7 +173,7 @@ public: virtual uint16_t get_mnc() = 0; virtual void enable_capabilities() = 0; virtual void plmn_search() = 0; - virtual void plmn_select(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id) = 0; + virtual void plmn_select(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id, bool connect_request = false) = 0; virtual std::string get_rb_name(uint32_t lcid) = 0; }; diff --git a/srsue/hdr/phy/phch_recv.h b/srsue/hdr/phy/phch_recv.h index 861d58229..d77e489ae 100644 --- a/srsue/hdr/phy/phch_recv.h +++ b/srsue/hdr/phy/phch_recv.h @@ -150,7 +150,7 @@ private: srslte_ue_mib_t ue_mib; uint32_t cnt; uint32_t timeout; - const static uint32_t SYNC_SFN_TIMEOUT = 500; + const static uint32_t SYNC_SFN_TIMEOUT = 80; }; // Class to perform cell measurements diff --git a/srsue/hdr/upper/nas.h b/srsue/hdr/upper/nas.h index 6038993e0..8a1fd6ae3 100644 --- a/srsue/hdr/upper/nas.h +++ b/srsue/hdr/upper/nas.h @@ -88,9 +88,10 @@ public: uint32_t get_ul_count(); bool is_attached(); bool is_attaching(); + bool is_data_requested(); bool get_s_tmsi(LIBLTE_RRC_S_TMSI_STRUCT *s_tmsi); bool get_k_asme(uint8_t *k_asme_, uint32_t n); - void plmn_found(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id, uint16_t tracking_area_code); + bool plmn_found(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id, uint16_t tracking_area_code); void plmn_search_end(); // UE interface diff --git a/srsue/hdr/upper/rrc.h b/srsue/hdr/upper/rrc.h index 55ee21097..904ae59db 100644 --- a/srsue/hdr/upper/rrc.h +++ b/srsue/hdr/upper/rrc.h @@ -249,7 +249,7 @@ public: void enable_capabilities(); void plmn_search(); - void plmn_select(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id); + void plmn_select(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id, bool connect_request); // PHY interface void in_sync(); @@ -324,9 +324,6 @@ private: uint32_t plmn_select_timeout; static const uint32_t RRC_PLMN_SELECT_TIMEOUT = 10000; - uint32_t select_cell_timeout; - static const uint32_t RRC_SELECT_CELL_TIMEOUT = 1000; - uint8_t k_rrc_enc[32]; uint8_t k_rrc_int[32]; uint8_t k_up_enc[32]; @@ -401,7 +398,7 @@ private: uint16_t sysinfo_index; uint32_t last_win_start; - void select_next_cell_in_plmn(); + bool select_next_cell_in_plmn(); LIBLTE_RRC_PLMN_IDENTITY_STRUCT selected_plmn_id; bool thread_running; diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index ecd2cf241..ca6a35772 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -565,8 +565,8 @@ void phch_recv::run_thread() } break; case sfn_sync::TIMEOUT: - log_h->warning("SYNC: Timeout while synchronizing SFN. Going back to cell search\n"); - phy_state = CELL_SEARCH; + log_h->warning("SYNC: Timeout while synchronizing SFN\n"); + rrc->out_of_sync(); break; case sfn_sync::IDLE: break; @@ -1271,7 +1271,7 @@ int phch_recv::scell_recv::find_cells(cf_t *input_buffer, float rx_gain_offset, for (uint32_t sf5_cnt=0;sf5_cnt max_peak && sync_res == SRSLTE_SYNC_FOUND) { diff --git a/srsue/src/phy/phch_worker.cc b/srsue/src/phy/phch_worker.cc index 4546788ec..2d1b67c48 100644 --- a/srsue/src/phy/phch_worker.cc +++ b/srsue/src/phy/phch_worker.cc @@ -529,7 +529,9 @@ bool phch_worker::decode_pdcch_dl(srsue::mac_interface_phy::mac_grant_t* grant) if (srslte_ue_dl_find_dl_dci_type(&ue_dl, phy->config->dedicated.antenna_info_explicit_value.tx_mode, cfi, tti%10, dl_rnti, type, &dci_msg) != 1) { if (type == SRSLTE_RNTI_RAR) { - Info("RAR not found, SNR=%.1f dB\n", 10*log10(srslte_chest_dl_get_snr(&ue_dl.chest))); + Info("RAR not found, SNR=%.1f dB, tti=%d, cfi=%d, tx_mode=%d, cell_id=%d\n", + 10*log10(srslte_chest_dl_get_snr(&ue_dl.chest)), tti, cfi, + phy->config->dedicated.antenna_info_explicit_value.tx_mode, cell.id); } return false; } diff --git a/srsue/src/upper/nas.cc b/srsue/src/upper/nas.cc index 0a5b597e4..c25a05125 100644 --- a/srsue/src/upper/nas.cc +++ b/srsue/src/upper/nas.cc @@ -107,8 +107,8 @@ void nas::attach_request() { selecting_plmn = current_plmn; } } else if (state == EMM_STATE_REGISTERED) { - nas_log->info("NAS state is registered, connecting to same PLMN\n"); - rrc->plmn_select(current_plmn); + nas_log->info("NAS state is registered, selecting current PLMN\n"); + rrc->plmn_select(current_plmn, true); } else { nas_log->info("Attach request ignored. State = %s\n", emm_state_text[state]); } @@ -123,12 +123,7 @@ void nas::deattach_request() { * RRC interface ******************************************************************************/ -void nas::plmn_found(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id, uint16_t tracking_area_code) { - - // Do not process new PLMN if already selected - if (plmn_selection == PLMN_SELECTED) { - return; - } +bool nas::plmn_found(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id, uint16_t tracking_area_code) { // Check if already registered for (uint32_t i=0;iinfo("Found known PLMN Id=%s\n", plmn_id_to_string(plmn_id).c_str()); if (plmn_id.mcc == home_plmn.mcc && plmn_id.mnc == home_plmn.mnc) { nas_log->info("Connecting Home PLMN Id=%s\n", plmn_id_to_string(plmn_id).c_str()); - rrc->plmn_select(plmn_id); + rrc->plmn_select(plmn_id, state == EMM_STATE_REGISTERED_INITIATED); selecting_plmn = plmn_id; + return true; } - return; + return false; } } @@ -152,10 +148,11 @@ void nas::plmn_found(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id, uint16_t tracking_ tracking_area_code); if (plmn_id.mcc == home_plmn.mcc && plmn_id.mnc == home_plmn.mnc) { - rrc->plmn_select(plmn_id); + rrc->plmn_select(plmn_id, state == EMM_STATE_REGISTERED_INITIATED); selecting_plmn = plmn_id; + return true; } - + return false; } // RRC indicates that the UE has gone through all EARFCN and finished PLMN selection @@ -170,7 +167,7 @@ void nas::plmn_search_end() { plmn_id_to_string(home_plmn).c_str(), plmn_id_to_string(known_plmns[0]).c_str()); } - rrc->plmn_select(known_plmns[0]); + rrc->plmn_select(known_plmns[0], state == EMM_STATE_REGISTERED_INITIATED); } else { nas_log->info("Finished searching PLMN in current EARFCN set but no networks were found.\n"); if (state == EMM_STATE_REGISTERED_INITIATED && plmn_selection == PLMN_NOT_SELECTED) { @@ -538,6 +535,7 @@ void nas::parse_attach_accept(uint32_t lcid, byte_buffer_t *pdu) { state = EMM_STATE_REGISTERED; current_plmn = selecting_plmn; + plmn_selection = PLMN_SELECTED; ctxt.rx_count++; diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 37ae14e8c..875785093 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -126,6 +126,8 @@ void rrc::init(phy_interface_rrc *phy_, pending_mob_reconf = false; + connection_requested = false; + // Set default values for all layers set_rrc_default(); set_phy_default(); @@ -184,10 +186,8 @@ void rrc::run_thread() { if (phy->sync_status()) { // If attempting to attach, reselect cell if (nas->is_attaching()) { - sleep(1); - rrc_log->info("RRC IDLE: NAS is attaching and camping on cell, reselecting...\n"); + rrc_log->info("RRC IDLE: NAS has pending data and camping on cell, connecting...\n"); plmn_select_rrc(selected_plmn_id); - connection_requested = true; } // If not camping on a cell } else { @@ -196,7 +196,6 @@ void rrc::run_thread() { rrc_log->info("RRC IDLE: NAS is attached, PHY not synchronized. Re-selecting cell...\n"); plmn_select_rrc(selected_plmn_id); } else if (nas->is_attaching()) { - sleep(1); rrc_log->info("RRC IDLE: NAS is attaching, searching again PLMN\n"); plmn_search(); } @@ -234,16 +233,6 @@ void rrc::run_thread() { state = RRC_STATE_CELL_SELECTED; } } - // Don't time out during reestablishment (T311 running) - if (!mac_timers->timer_get(t311)->is_running() || !phy->sync_status()) { - select_cell_timeout++; - if (select_cell_timeout >= RRC_SELECT_CELL_TIMEOUT) { - rrc_log->info("RRC Cell Selecting: timeout expired. Starting Cell Search...\n"); - select_cell_timeout = 0; - state = RRC_STATE_PLMN_START; - serving_cell->in_sync = false; - } - } break; case RRC_STATE_CELL_SELECTED: @@ -258,9 +247,9 @@ void rrc::run_thread() { con_restablish_cell_reselected(); state = RRC_STATE_CONNECTING; connecting_timeout = 0; - } else if (connection_requested) { - connection_requested = false; + } else if (nas->is_attaching() || connection_requested) { rrc_log->info("RRC Cell Selected: Sending connection request...\n"); + connection_requested = false; send_con_request(); state = RRC_STATE_CONNECTING; connecting_timeout = 0; @@ -442,8 +431,8 @@ void rrc::plmn_search() { /* This is the NAS interface. When NAS requests to select a PLMN we have to * connect to either register or because there is pending higher layer traffic. */ -void rrc::plmn_select(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id) { - connection_requested = true; +void rrc::plmn_select(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id, bool connect_request) { + connection_requested = connect_request; plmn_select_rrc(plmn_id); } @@ -451,37 +440,41 @@ void rrc::plmn_select(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id) { * selected PLMN */ void rrc::plmn_select_rrc(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id) { + pthread_mutex_lock(&mutex); + // If already camping on the selected PLMN, select this cell if (state == RRC_STATE_IDLE || state == RRC_STATE_CONNECTED || state == RRC_STATE_PLMN_SELECTION) { if (phy->sync_status() && selected_plmn_id.mcc == plmn_id.mcc && selected_plmn_id.mnc == plmn_id.mnc) { - rrc_log->info("Already camping on selected PLMN, connecting...\n"); + rrc_log->info("Already camping on selected PLMN\n"); } else { selected_plmn_id = plmn_id; - if (serving_cell->plmn_equals(selected_plmn_id)) { - phy->cell_select(serving_cell->get_earfcn(), serving_cell->phy_cell); + if (serving_cell->plmn_equals(selected_plmn_id) && serving_cell->in_sync) { + rrc_log->info("PLMN Id=%s selected, Selecting serving cell earfcn=%d, pci=%d\n", + plmn_id_to_string(plmn_id).c_str(), serving_cell->get_earfcn(), serving_cell->phy_cell.id); } else { bool found = false; for (uint32_t i=0;iplmn_equals(selected_plmn_id)) { - rrc_log->info("PLMN Id=%s selected, PCI=%d\n", plmn_id_to_string(plmn_id).c_str(), neighbour_cells[i]->get_pci()); + rrc_log->info("PLMN Id=%s selected, Selecting neighbour cell PCI=%d\n", plmn_id_to_string(plmn_id).c_str(), neighbour_cells[i]->get_pci()); phy->cell_select(neighbour_cells[i]->get_earfcn(), neighbour_cells[i]->phy_cell); found = true; } } if (!found) { - rrc_log->warning("Could not find any cell for the selected PLMN\n"); - state = RRC_STATE_IDLE; + rrc_log->warning("Could not find any cell for the selected PLMN. Searching another PLMN\n"); + plmn_search(); + pthread_mutex_unlock(&mutex); return; } } } state = RRC_STATE_CELL_SELECTING; - select_cell_timeout = 0; } else { rrc_log->warning("Requested PLMN select in incorrect state %s\n", rrc_state_text[state]); } + pthread_mutex_unlock(&mutex); } void rrc::set_serving_cell(uint32_t earfcn, uint32_t pci) { @@ -494,6 +487,7 @@ void rrc::set_serving_cell(uint32_t earfcn, uint32_t pci) { } void rrc::set_serving_cell(uint32_t cell_idx) { + if (cell_idx < neighbour_cells.size()) { // Remove future serving cell from neighbours to make space for current serving cell @@ -529,29 +523,37 @@ void rrc::set_serving_cell(uint32_t cell_idx) { } } -void rrc::select_next_cell_in_plmn() { +bool rrc::select_next_cell_in_plmn() { // Neighbour cells are sorted in descending order of RSRP for (uint32_t i = 0; i < neighbour_cells.size(); i++) { - if (neighbour_cells[i]->plmn_equals(selected_plmn_id) && + if (/*TODO: CHECK that PLMN matches. Currently we don't receive SIB1 of neighbour cells + * neighbour_cells[i]->plmn_equals(selected_plmn_id) && */ neighbour_cells[i]->in_sync) // matches S criteria { - // Try to select Cell - phy->cell_select(neighbour_cells[i]->get_earfcn(), neighbour_cells[i]->phy_cell); - set_serving_cell(i); - rrc_log->info("Selected cell PCI=%d, EARFCN=%d, Cell ID=0x%x\n", - serving_cell->phy_cell.id, serving_cell->get_earfcn(), - serving_cell->get_cell_id()); - rrc_log->console("Selected cell PCI=%d, EARFCN=%d, Cell ID=0x%x\n", - serving_cell->phy_cell.id, serving_cell->get_earfcn(), - serving_cell->get_cell_id()); - return; + // If currently connected, verify cell selection criteria + if (!serving_cell->in_sync || + (cell_selection_eval(neighbour_cells[i]->get_rsrp()) && + neighbour_cells[i]->get_rsrp() > serving_cell->get_rsrp() + 5)) + { + // Try to select Cell + set_serving_cell(i); + rrc_log->info("Selected cell idx=%d, PCI=%d, EARFCN=%d\n", + i, serving_cell->phy_cell.id, serving_cell->get_earfcn()); + rrc_log->console("Selected cell PCI=%d, EARFCN=%d\n", + serving_cell->phy_cell.id, serving_cell->get_earfcn()); + phy->cell_select(serving_cell->get_earfcn(), serving_cell->phy_cell); + state = RRC_STATE_CELL_SELECTING; + return true; + } } } - rrc_log->info("No more known cells. Starting again\n"); + return false; } void rrc::new_phy_meas(float rsrp, float rsrq, uint32_t tti, int earfcn_i, int pci_i) { + pthread_mutex_lock(&mutex); + if (earfcn_i < 0 || pci_i < 0) { earfcn_i = serving_cell->get_earfcn(); pci_i = serving_cell->phy_cell.id; @@ -582,16 +584,22 @@ void rrc::new_phy_meas(float rsrp, float rsrq, uint32_t tti, int earfcn_i, int p } } - // Verify cell selection criteria with strongest neighbour cell (always first) - if (neighbour_cells.size() > 1 && - cell_selection_eval(neighbour_cells[0]->get_rsrp()) && - neighbour_cells[0]->get_rsrp() > serving_cell->get_rsrp() + 5) - { - set_serving_cell(0); - rrc_log->info("Selecting best neighbour cell PCI=%d, rsrp=%.1f dBm\n", serving_cell->phy_cell.id, serving_cell->get_rsrp()); - state = RRC_STATE_CELL_SELECTING; - phy->cell_select(serving_cell->get_earfcn(), serving_cell->phy_cell); - } + // Evaluate if we need to select a new cell + select_next_cell_in_plmn(); + } + pthread_mutex_unlock(&mutex); +} + +// PHY indicates that has gone through all known EARFCN +void rrc::earfcn_end() { + rrc_log->info("Finished searching cells in EARFCN set while in state %s\n", rrc_state_text[state]); + + // If searching for PLMN, indicate NAS we scanned all frequencies + if (state == RRC_STATE_PLMN_SELECTION) { + nas->plmn_search_end(); + } else { + rrc_log->info("Restarting Cell search...\n"); + phy->cell_search_start(); } } @@ -600,51 +608,53 @@ void rrc::new_phy_meas(float rsrp, float rsrq, uint32_t tti, int earfcn_i, int p * new cell as current serving cell */ void rrc::cell_camping(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp) { - bool found = false; - int cell_idx = -1; - + int cell_idx = -1; + bool found = true; + + pthread_mutex_lock(&mutex); + if (serving_cell->equals(earfcn, phy_cell.id)) { serving_cell->set_rsrp(rsrp); - found = true; } else { // Check if cell is in our list of neighbour cells cell_idx = find_neighbour_cell(earfcn, phy_cell.id); if (cell_idx >= 0) { set_serving_cell(cell_idx); serving_cell->set_rsrp(rsrp); - found = true; + } else { + found = false; + if (!add_neighbour_cell(earfcn, phy_cell, rsrp)) { + rrc_log->info( + "No more space for neighbour cells (detected cell RSRP=%.1f dBm worse than current %d neighbours)\n", + rsrp, + NOF_NEIGHBOUR_CELLS); + } else { + set_serving_cell(earfcn, phy_cell.id); + serving_cell->set_rsrp(rsrp); + } } } - if (found) { - if (!serving_cell->has_sib1()) { - si_acquire_state = SI_ACQUIRE_SIB1; - } else if (state == RRC_STATE_PLMN_SELECTION) { - for (uint32_t j = 0; j < serving_cell->sib1ptr()->N_plmn_ids; j++) { - nas->plmn_found(serving_cell->sib1ptr()->plmn_id[j].id, serving_cell->sib1ptr()->tracking_area_code); - } - usleep(5000); - phy->cell_search_next(); + pthread_mutex_unlock(&mutex); + + if (!serving_cell->has_sib1()) { + si_acquire_state = SI_ACQUIRE_SIB1; + } else if (state == RRC_STATE_PLMN_SELECTION) { + bool ret = false; + for (uint32_t j = 0; j < serving_cell->sib1ptr()->N_plmn_ids; j++) { + ret |= nas->plmn_found(serving_cell->sib1ptr()->plmn_id[j].id, serving_cell->sib1ptr()->tracking_area_code); } - } else { - // add to list of known cells and set current_cell - if (!add_neighbour_cell(earfcn, phy_cell, rsrp)) { - rrc_log->info("No more space for neighbour cells (detected cell RSRP=%.1f dBm worse than current %d neighbours)\n", - rsrp, NOF_NEIGHBOUR_CELLS); - usleep(5000); + // If any of the PLMNs in this cell is selected, search next cell + if (!ret) { phy->cell_search_next(); - } else { - set_serving_cell(earfcn, phy_cell.id); - si_acquire_state = SI_ACQUIRE_SIB1; } } rrc_log->info("%s %s cell EARFCN=%d, PCI=%d, RSRP=%.1f dBm\n", found?"Updating":"Adding", - cell_idx>=0?"neighbour":"serving", - serving_cell->get_earfcn(), - serving_cell->phy_cell.id, - serving_cell->get_rsrp()); + cell_idx>=0?"neighbour":"serving", earfcn, phy_cell.id, rsrp); + + } bool sort_rsrp(cell_t *u1, cell_t *u2) { @@ -668,6 +678,8 @@ void rrc::clean_neighbours() struct timeval now; gettimeofday(&now, NULL); + pthread_mutex_lock(&mutex); + std::vector::iterator it = neighbour_cells.begin(); while(it != neighbour_cells.end()) { if ((*it)->timeout_secs(now) > NEIGHBOUR_TIMEOUT) { @@ -677,6 +689,7 @@ void rrc::clean_neighbours() ++it; } } + pthread_mutex_unlock(&mutex); } // Sort neighbour cells by decreasing order of RSRP @@ -695,13 +708,17 @@ void rrc::sort_neighbour_cells() std::sort(neighbour_cells.begin(), neighbour_cells.end(), sort_rsrp); - char ordered[512]; - int n=0; - n += snprintf(ordered, 512, "[pci=%d, rsrsp=%.2f", neighbour_cells[0]->phy_cell.id, neighbour_cells[0]->get_rsrp()); - for (uint32_t i=1;iget_pci(), neighbour_cells[i]->get_rsrp()); + if (neighbour_cells.size() > 0) { + char ordered[512]; + int n=0; + n += snprintf(ordered, 512, "[pci=%d, rsrsp=%.2f", neighbour_cells[0]->phy_cell.id, neighbour_cells[0]->get_rsrp()); + for (uint32_t i=1;iget_pci(), neighbour_cells[i]->get_rsrp()); + } + rrc_log->info("Neighbours: %s]\n", ordered); + } else { + rrc_log->info("Neighbours: Empty\n"); } - rrc_log->info("Neighbours: %s]\n", ordered); } bool rrc::add_neighbour_cell(cell_t *new_cell) { @@ -744,7 +761,7 @@ bool rrc::add_neighbour_cell(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp if (cell_idx >= 0) { neighbour_cells[cell_idx]->set_rsrp(rsrp); sort_neighbour_cells(); - return true; + return true; } // If not, create a new one @@ -762,18 +779,6 @@ int rrc::find_neighbour_cell(uint32_t earfcn, uint32_t pci) { return -1; } -// PHY indicates that has gone through all known EARFCN -void rrc::earfcn_end() { - rrc_log->info("Finished searching cells in EARFCN set while in state %s\n", rrc_state_text[state]); - - // If searching for PLMN, indicate NAS we scanned all frequencies - if (state >= RRC_STATE_PLMN_SELECTION && state < RRC_STATE_CONNECTING) { - nas->plmn_search_end(); - } else if (state >= RRC_STATE_CONNECTING && state < RRC_STATE_LEAVE_CONNECTED) { - leave_connected(); - } -} - // Cell reselection in IDLE Section 5.2.4 of 36.304 void rrc::cell_reselection_eval(float rsrp, float rsrq) { @@ -826,7 +831,6 @@ float rrc::get_squal(float Qqualmeas) { // Detection of physical layer problems in RRC_CONNECTED (5.3.11.1) void rrc::out_of_sync() { - serving_cell->in_sync = false; if (state == RRC_STATE_CONNECTED) { if (!mac_timers->timer_get(t311)->is_running() && !mac_timers->timer_get(t310)->is_running()) { n310_cnt++; @@ -838,9 +842,23 @@ void rrc::out_of_sync() { n310_cnt = 0; } } - } else { - phy->sync_reset(); + } else if (state != RRC_STATE_LEAVE_CONNECTED) { + if (!mac_timers->timer_get(t311)->is_running()) { + if (serving_cell->in_sync) { + rrc_log->info("Detected out-of-sync while in IDLE. Resetting sync\n"); + phy->sync_reset(); + } else { + rrc_log->info("Detected out-of-sync while in IDLE. Selecting another cell in the PLMN\n"); + if (!select_next_cell_in_plmn()) { + rrc_log->info("Could not find any available cell in this PLMN. Searching PLMN again.\n"); + plmn_search(); + } + } + } else { + rrc_log->info("Detected out-of-sync while T311 is running\n"); + } } + serving_cell->in_sync = false; } // Recovery of physical layer problems (5.3.11.2) diff --git a/srsue/test/upper/nas_test.cc b/srsue/test/upper/nas_test.cc index 4f4ffb687..5a4a082ba 100644 --- a/srsue/test/upper/nas_test.cc +++ b/srsue/test/upper/nas_test.cc @@ -81,7 +81,7 @@ public: uint32_t get_last_sdu_len() { return last_sdu_len; } void plmn_search() {}; - void plmn_select(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id) {}; + void plmn_select(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id, bool con_req) {}; uint16_t get_mcc() { return mcc; } uint16_t get_mnc() { return mnc; } From ac194ae7b170d98c0a5d622cdff97d1b5c5709ed Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Tue, 6 Mar 2018 22:24:07 +0100 Subject: [PATCH 090/134] fix warning in timeout test --- lib/test/common/timeout_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test/common/timeout_test.cc b/lib/test/common/timeout_test.cc index c2451cdb0..4bde95f66 100644 --- a/lib/test/common/timeout_test.cc +++ b/lib/test/common/timeout_test.cc @@ -89,7 +89,7 @@ int timer_thread_test() printf("Target duration: %dms, started: %ld:%ld, ended: %ld:%ld, actual duration %dms\n", duration_msec, c.start_time[1].tv_sec, c.start_time[1].tv_usec, c.start_time[2].tv_sec, c.start_time[2].tv_usec, diff_ms); - result = (duration_msec - result_tolerance <= diff_ms < duration_msec + result_tolerance); + result = ((duration_msec - result_tolerance) < diff_ms || diff_ms < (duration_msec + result_tolerance)); if(result) { printf("Timer thread test passed\n"); From ac0f9345582539cfe14f3cd2601c9f055135962d Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Tue, 6 Mar 2018 22:33:57 +0100 Subject: [PATCH 091/134] fix leaks in viterbi and modem tests --- lib/src/phy/fec/test/viterbi_test.c | 1 + lib/src/phy/modem/test/modem_test.c | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/src/phy/fec/test/viterbi_test.c b/lib/src/phy/fec/test/viterbi_test.c index 28c60bce6..e4cf6f312 100644 --- a/lib/src/phy/fec/test/viterbi_test.c +++ b/lib/src/phy/fec/test/viterbi_test.c @@ -279,6 +279,7 @@ int main(int argc, char **argv) { free(llr); free(llr_c); free(data_rx); + free(data_rx2); if (snr_points == 1) { int expected_errors = get_expected_errors(nof_frames, seed, frame_length, tail_biting, ebno_db); diff --git a/lib/src/phy/modem/test/modem_test.c b/lib/src/phy/modem/test/modem_test.c index 600115386..ed9bef522 100644 --- a/lib/src/phy/modem/test/modem_test.c +++ b/lib/src/phy/modem/test/modem_test.c @@ -197,6 +197,7 @@ int main(int argc, char **argv) { } } + free(llr2); free(llr); free(symbols); free(symbols_bytes); From a85368cac0dd9cb50f2eb1878e4652df8ba882ae Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Wed, 7 Mar 2018 00:28:52 +0100 Subject: [PATCH 092/134] Discard duplicated TB after timeout --- srsue/hdr/mac/dl_harq.h | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/srsue/hdr/mac/dl_harq.h b/srsue/hdr/mac/dl_harq.h index f4c557898..cfdfdfc5f 100644 --- a/srsue/hdr/mac/dl_harq.h +++ b/srsue/hdr/mac/dl_harq.h @@ -190,6 +190,9 @@ private: } private: + + const static int RESET_DUPLICATE_TIMEOUT = 8*6; + class dl_tb_process { public: dl_tb_process(void) { @@ -273,6 +276,10 @@ private: grant.last_tti = cur_grant.tti; memcpy(&cur_grant, &grant, sizeof(Tgrant)); + if (payload_buffer_ptr) { + Warning("DL PID %d: Allocating buffer already allocated\n", pid); + } + // Instruct the PHY To combine the received data and attempt to decode it if (pid == HARQ_BCCH_PID) { payload_buffer_ptr = harq_entity->demux_unit->request_buffer_bcch(cur_grant.n_bytes[tid]); @@ -294,8 +301,14 @@ private: } else { action->default_ack[tid] = true; - Warning("DL PID %d: Received duplicate TB. Discarting and retransmitting ACK (grant_tti=%d, ndi=%d, sz=%d)\n", - pid, cur_grant.tti, cur_grant.ndi[tid], cur_grant.n_bytes[tid]); + uint32_t interval = srslte_tti_interval(grant.tti, cur_grant.tti); + Warning("DL PID %d: Received duplicate TB. Discarting and retransmitting ACK (grant_tti=%d, ndi=%d, sz=%d, reset=%s)\n", + pid, cur_grant.tti, cur_grant.ndi[tid], cur_grant.n_bytes[tid], interval>RESET_DUPLICATE_TIMEOUT?"yes":"no"); + if (interval > RESET_DUPLICATE_TIMEOUT) { + pthread_mutex_unlock(&mutex); + reset(); + pthread_mutex_lock(&mutex); + } } if (pid == HARQ_BCCH_PID || harq_entity->timer_aligment_timer->is_expired()) { From c6c170e73750477eded20dd24d2704bcfe44976a Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Wed, 7 Mar 2018 00:31:31 +0100 Subject: [PATCH 093/134] Do HO after correct synchronization --- srsue/hdr/upper/rrc.h | 3 +++ srsue/src/upper/rrc.cc | 28 +++++++++++++++++++++++++--- 2 files changed, 28 insertions(+), 3 deletions(-) diff --git a/srsue/hdr/upper/rrc.h b/srsue/hdr/upper/rrc.h index 904ae59db..8d092051a 100644 --- a/srsue/hdr/upper/rrc.h +++ b/srsue/hdr/upper/rrc.h @@ -311,6 +311,8 @@ private: uint16_t ho_src_rnti; cell_t ho_src_cell; + uint32_t ho_target_pci; + bool ho_syncing; phy_interface_rrc::phy_cfg_t ho_src_phy_cfg; mac_interface_rrc::mac_cfg_t ho_src_mac_cfg; bool pending_mob_reconf; @@ -542,6 +544,7 @@ private: // Helpers void ho_failed(); bool ho_prepare(); + void ho_synced(uint32_t target_pci); void rrc_connection_release(); void con_restablish_cell_reselected(); void radio_link_failure(); diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 81331b2e4..935d24435 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -99,6 +99,8 @@ void rrc::init(phy_interface_rrc *phy_, state = RRC_STATE_IDLE; si_acquire_state = SI_ACQUIRE_IDLE; + ho_syncing = false; + thread_running = true; start(); @@ -611,6 +613,11 @@ void rrc::cell_camping(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp) { int cell_idx = -1; bool found = true; + if (ho_syncing && phy_cell.id == ho_target_pci) { + ho_synced(ho_target_pci); + return; + } + pthread_mutex_lock(&mutex); if (serving_cell->equals(earfcn, phy_cell.id)) { @@ -1127,7 +1134,9 @@ bool rrc::ho_prepare() { int target_cell_idx = find_neighbour_cell(serving_cell->get_earfcn(), mob_reconf.mob_ctrl_info.target_pci); if (target_cell_idx < 0) { rrc_log->console("Received HO command to unknown PCI=%d\n", mob_reconf.mob_ctrl_info.target_pci); - rrc_log->error("Could not find target cell earfcn=%d, pci=%d\n", serving_cell->get_earfcn(), mob_reconf.mob_ctrl_info.target_pci); + rrc_log->error("Could not find target cell earfcn=%d, pci=%d\n", + serving_cell->get_earfcn(), + mob_reconf.mob_ctrl_info.target_pci); return false; } @@ -1159,12 +1168,22 @@ bool rrc::ho_prepare() { mac->set_ho_rnti(mob_reconf.mob_ctrl_info.new_ue_id, mob_reconf.mob_ctrl_info.target_pci); apply_rr_config_common_dl(&mob_reconf.mob_ctrl_info.rr_cnfg_common); + ho_target_pci = neighbour_cells[target_cell_idx]->phy_cell.id; + ho_syncing = true; + rrc_log->info("Selecting new cell pci=%d\n", neighbour_cells[target_cell_idx]->get_pci()); if (!phy->cell_handover(neighbour_cells[target_cell_idx]->phy_cell)) { rrc_log->error("Could not synchronize with target cell pci=%d\n", neighbour_cells[target_cell_idx]->get_pci()); return false; } + } + return true; +} +void rrc::ho_synced(uint32_t current_pci) +{ + ho_syncing = false; + if (current_pci == ho_target_pci) { if (mob_reconf.mob_ctrl_info.rach_cnfg_ded_present) { rrc_log->info("Starting non-contention based RA with preamble_idx=%d, mask_idx=%d\n", mob_reconf.mob_ctrl_info.rach_cnfg_ded.preamble_index, @@ -1181,7 +1200,7 @@ bool rrc::ho_prepare() { ncc = mob_reconf.sec_cnfg_ho.intra_lte.next_hop_chaining_count; if (mob_reconf.sec_cnfg_ho.intra_lte.key_change_ind) { rrc_log->console("keyChangeIndicator in securityConfigHO not supported\n"); - return false; + return; } if (mob_reconf.sec_cnfg_ho.intra_lte.sec_alg_cnfg_present) { cipher_algo = (CIPHERING_ALGORITHM_ID_ENUM) mob_reconf.sec_cnfg_ho.intra_lte.sec_alg_cnfg.cipher_alg; @@ -1198,8 +1217,11 @@ bool rrc::ho_prepare() { pdcp->config_security_all(k_rrc_enc, k_rrc_int, cipher_algo, integ_algo); send_rrc_con_reconfig_complete(); + } else { + rrc_log->error("HO: Synchronized with incorrect cell. Target PCI=%d, current PCI=%d\n", ho_target_pci, current_pci); + ho_failed(); } - return true; + return; } void rrc::ho_ra_completed(bool ra_successful) { From bdf379ee1c24ca8c68f0fb922b1d428e4032fb71 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Wed, 7 Mar 2018 10:50:10 +0100 Subject: [PATCH 094/134] Fixed roaming PLMN attach. Add out-of-sync debugging --- srsue/src/phy/phch_recv.cc | 2 ++ srsue/src/upper/rrc.cc | 21 +++++++++++++++------ 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index ca6a35772..be483b0e4 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -717,8 +717,10 @@ void phch_recv::in_sync() { // Out of sync called by worker or phch_recv every 1 or 5 ms void phch_recv::out_of_sync() { // Send RRC out-of-sync signal after 200 ms consecutive subframes + Info("Out-of-sync %d/%d\n", out_of_sync_cnt, NOF_OUT_OF_SYNC_SF); out_of_sync_cnt++; if (out_of_sync_cnt >= NOF_OUT_OF_SYNC_SF) { + Info("Sending to RRC\n"); rrc->out_of_sync(); out_of_sync_cnt = 0; in_sync_cnt = 0; diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 935d24435..a08297da6 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -452,8 +452,12 @@ void rrc::plmn_select_rrc(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id) { selected_plmn_id = plmn_id; if (serving_cell->plmn_equals(selected_plmn_id) && serving_cell->in_sync) { - rrc_log->info("PLMN Id=%s selected, Selecting serving cell earfcn=%d, pci=%d\n", - plmn_id_to_string(plmn_id).c_str(), serving_cell->get_earfcn(), serving_cell->phy_cell.id); + rrc_log->info("PLMN Id=%s selected, Selecting serving cell earfcn=%d, pci=%d, status=%d\n", + plmn_id_to_string(plmn_id).c_str(), serving_cell->get_earfcn(), serving_cell->phy_cell.id, + phy->sync_status()); + if (!phy->sync_status()) { + phy->cell_select(serving_cell->get_earfcn(), serving_cell->phy_cell); + } } else { bool found = false; for (uint32_t i=0;iinfo("Received out-of-sync state %s. n310=%d, t311=%s, t310=%s\n", + rrc_state_text[state], n310_cnt, + mac_timers->timer_get(t311)->is_running()?"running":"stop", + mac_timers->timer_get(t310)->is_running()?"running":"stop"); if (state == RRC_STATE_CONNECTED) { if (!mac_timers->timer_get(t311)->is_running() && !mac_timers->timer_get(t310)->is_running()) { n310_cnt++; @@ -1168,14 +1176,15 @@ bool rrc::ho_prepare() { mac->set_ho_rnti(mob_reconf.mob_ctrl_info.new_ue_id, mob_reconf.mob_ctrl_info.target_pci); apply_rr_config_common_dl(&mob_reconf.mob_ctrl_info.rr_cnfg_common); - ho_target_pci = neighbour_cells[target_cell_idx]->phy_cell.id; - ho_syncing = true; - rrc_log->info("Selecting new cell pci=%d\n", neighbour_cells[target_cell_idx]->get_pci()); if (!phy->cell_handover(neighbour_cells[target_cell_idx]->phy_cell)) { - rrc_log->error("Could not synchronize with target cell pci=%d\n", neighbour_cells[target_cell_idx]->get_pci()); + rrc_log->error("Could not synchronize with target cell pci=%d. Trying to return to source PCI\n", + neighbour_cells[target_cell_idx]->get_pci()); + ho_failed(); return false; } + ho_target_pci = neighbour_cells[target_cell_idx]->phy_cell.id; + ho_syncing = true; } return true; } From ac95976a6bbc9edf724efde39f4f74317d9ef16b Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Wed, 7 Mar 2018 14:50:56 +0100 Subject: [PATCH 095/134] Check Cell is valid before HO. Do cell search if going back to source fails --- srsue/src/phy/phch_recv.cc | 8 +++++++- srsue/src/upper/rrc.cc | 3 ++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index be483b0e4..4d4dbb78e 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -220,7 +220,7 @@ bool phch_recv::set_cell() { // Set cell in all objects if (srslte_ue_sync_set_cell(&ue_sync, cell)) { - Error("SYNC: Setting cell: initiating ue_sync"); + Error("SYNC: Setting cell: initiating ue_sync\n"); return false; } measure_p.set_cell(cell); @@ -308,6 +308,12 @@ void phch_recv::cell_search_start() { bool phch_recv::cell_handover(srslte_cell_t cell) { + + if (srslte_cell_isvalid(&cell)) { + log_h->error("Received HO command to invalid cell. ID=%d, PRB=%d, ports=%d\n", cell.id, cell.nof_prb, cell.nof_ports); + return false; + } + int cnt = 0; while(worker_com->is_any_pending_ack() && cnt < 10) { usleep(1000); diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index a08297da6..fdd461ebb 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -1268,7 +1268,8 @@ void rrc::ho_failed() { // Instruct PHY to resync with source PCI if (!phy->cell_handover(ho_src_cell.phy_cell)) { - rrc_log->error("Could not synchronize with target cell pci=%d\n", ho_src_cell.get_pci()); + rrc_log->error("Could not synchronize with target cell pci=%d. Going to PLMN Search\n", ho_src_cell.get_pci()); + plmn_search(); return; } From 04f6634b4908434e8cc87e4e72e4a5bbacf6abc5 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Wed, 7 Mar 2018 15:02:07 +0100 Subject: [PATCH 096/134] fix condition check in cell HO --- srsue/src/phy/phch_recv.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 4d4dbb78e..112cd03b8 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -308,8 +308,7 @@ void phch_recv::cell_search_start() { bool phch_recv::cell_handover(srslte_cell_t cell) { - - if (srslte_cell_isvalid(&cell)) { + if (!srslte_cell_isvalid(&cell)) { log_h->error("Received HO command to invalid cell. ID=%d, PRB=%d, ports=%d\n", cell.id, cell.nof_prb, cell.nof_ports); return false; } From 4af78e4960854909d82774fca42640d56158c4ba Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Wed, 7 Mar 2018 16:23:05 +0100 Subject: [PATCH 097/134] Fix invalid cell search check in previous commit --- srsue/src/phy/phch_recv.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 4d4dbb78e..b7bc26a86 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -309,7 +309,7 @@ void phch_recv::cell_search_start() { bool phch_recv::cell_handover(srslte_cell_t cell) { - if (srslte_cell_isvalid(&cell)) { + if (!srslte_cell_isvalid(&cell)) { log_h->error("Received HO command to invalid cell. ID=%d, PRB=%d, ports=%d\n", cell.id, cell.nof_prb, cell.nof_ports); return false; } From 57e0c01fc4638acc41711ac94d0028c09b5dd99c Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Wed, 7 Mar 2018 15:27:08 +0100 Subject: [PATCH 098/134] check max buffer length in hex print --- lib/include/srslte/phy/utils/vector.h | 2 +- lib/src/phy/utils/vector.c | 9 ++++++++- srsue/src/mac/demux.cc | 2 +- srsue/src/phy/phch_worker.cc | 4 ++-- 4 files changed, 12 insertions(+), 5 deletions(-) diff --git a/lib/include/srslte/phy/utils/vector.h b/lib/include/srslte/phy/utils/vector.h index 4ec95639a..fbf000a70 100644 --- a/lib/include/srslte/phy/utils/vector.h +++ b/lib/include/srslte/phy/utils/vector.h @@ -73,7 +73,7 @@ SRSLTE_API void srslte_vec_fprint_byte(FILE *stream, uint8_t *x, const uint32_t SRSLTE_API void srslte_vec_fprint_i(FILE *stream, int *x, const uint32_t len); SRSLTE_API void srslte_vec_fprint_s(FILE *stream, short *x, const uint32_t len); SRSLTE_API void srslte_vec_fprint_hex(FILE *stream, uint8_t *x, const uint32_t len); -SRSLTE_API void srslte_vec_sprint_hex(char *str, uint8_t *x, const uint32_t len); +SRSLTE_API void srslte_vec_sprint_hex(char *str, const uint32_t max_str_len, uint8_t *x, const uint32_t len); /* Saves/loads a vector to a file */ SRSLTE_API void srslte_vec_save_file(char *filename, const void *buffer, const uint32_t len); diff --git a/lib/src/phy/utils/vector.c b/lib/src/phy/utils/vector.c index b97583bb8..9ccd21559 100644 --- a/lib/src/phy/utils/vector.c +++ b/lib/src/phy/utils/vector.c @@ -200,10 +200,16 @@ void srslte_vec_fprint_hex(FILE *stream, uint8_t *x, const uint32_t len) { fprintf(stream, "];\n"); } -void srslte_vec_sprint_hex(char *str, uint8_t *x, const uint32_t len) { +void srslte_vec_sprint_hex(char *str, const uint32_t max_str_len, uint8_t *x, const uint32_t len) { uint32_t i, nbytes; uint8_t byte; nbytes = len/8; + // check that hex string fits in buffer (every byte takes 3 characters, plus brackets) + if ((3*(len/8 + ((len%8)?1:0))) + 2 >= max_str_len) { + fprintf(stderr, "Buffer too small for printing hex string (max_str_len=%d, payload_len=%d).\n", max_str_len, len); + return; + } + int n=0; n+=sprintf(&str[n], "["); for (i=0;iwrite_pdu(pdu_msg->get()->get_sdu_lcid(), pdu_msg->get()->get_sdu_ptr(), pdu_msg->get()->get_payload_size()); } else { char tmp[1024]; - srslte_vec_sprint_hex(tmp, pdu_msg->get()->get_sdu_ptr(), 32); + srslte_vec_sprint_hex(tmp, sizeof(tmp), pdu_msg->get()->get_sdu_ptr(), 32); Error("PDU size %d exceeds maximum PDU buffer size, lcid=%d, hex=[%s]\n", pdu_msg->get()->get_payload_size(), pdu_msg->get()->get_sdu_lcid(), tmp); } diff --git a/srsue/src/phy/phch_worker.cc b/srsue/src/phy/phch_worker.cc index 19106c514..8a6c5cd8b 100644 --- a/srsue/src/phy/phch_worker.cc +++ b/srsue/src/phy/phch_worker.cc @@ -577,7 +577,7 @@ bool phch_worker::decode_pdcch_dl(srsue::mac_interface_phy::mac_grant_t* grant) char hexstr[16]; hexstr[0]='\0'; if (log_h->get_level() >= srslte::LOG_LEVEL_INFO) { - srslte_vec_sprint_hex(hexstr, dci_msg.data, dci_msg.nof_bits); + srslte_vec_sprint_hex(hexstr, sizeof(hexstr), dci_msg.data, dci_msg.nof_bits); } Info("PDCCH: DL DCI %s cce_index=%2d, L=%d, n_data_bits=%d, hex=%s\n", srslte_dci_format_string(dci_msg.format), last_dl_pdcch_ncce, (1<get_level() >= srslte::LOG_LEVEL_INFO) { - srslte_vec_sprint_hex(hexstr, dci_msg.data, dci_msg.nof_bits); + srslte_vec_sprint_hex(hexstr, sizeof(hexstr), dci_msg.data, dci_msg.nof_bits); } // Change to last_location_ul Info("PDCCH: UL DCI Format0 cce_index=%d, L=%d, n_data_bits=%d, hex=%s\n", From 7acc021a4e4d497b43100172f9b73dc5750d63d3 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Wed, 7 Mar 2018 16:32:40 +0100 Subject: [PATCH 099/134] fix mem leak in pmch_test --- lib/src/phy/phch/test/pmch_test.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/src/phy/phch/test/pmch_test.c b/lib/src/phy/phch/test/pmch_test.c index a69b5d075..15634fe9b 100644 --- a/lib/src/phy/phch/test/pmch_test.c +++ b/lib/src/phy/phch/test/pmch_test.c @@ -157,6 +157,7 @@ int main(int argc, char **argv) { bzero(ce, sizeof(cf_t*)*SRSLTE_MAX_PORTS); bzero(tx_slot_symbols, sizeof(cf_t*)*SRSLTE_MAX_PORTS); bzero(rx_slot_symbols, sizeof(cf_t*)*SRSLTE_MAX_PORTS); + bzero(t, 3 * sizeof(struct timeval)); cell.nof_ports = 1; @@ -469,5 +470,8 @@ quit: } else { printf("Ok\n"); } + + srslte_dft_exit(); + exit(ret); } From 938e56fa2cc63eb5541b2f79b5e60e132c41a77c Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Thu, 8 Mar 2018 11:41:21 +0100 Subject: [PATCH 100/134] streamline log output in RLC AM/UM --- lib/src/upper/rlc_am.cc | 4 ++-- lib/src/upper/rlc_um.cc | 2 +- srsue/src/mac/mux.cc | 4 +--- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/src/upper/rlc_am.cc b/lib/src/upper/rlc_am.cc index e6e1ff279..5c7cb72ea 100644 --- a/lib/src/upper/rlc_am.cc +++ b/lib/src/upper/rlc_am.cc @@ -198,7 +198,7 @@ uint32_t rlc_am::get_bearer() void rlc_am::write_sdu(byte_buffer_t *sdu) { tx_sdu_queue.write(sdu); - log->info_hex(sdu->msg, sdu->N_bytes, "%s Tx SDU, tx_sdu_queue_len=%d", rrc->get_rb_name(lcid).c_str(), tx_sdu_queue.size()); + log->info_hex(sdu->msg, sdu->N_bytes, "%s Tx SDU (%d B, tx_sdu_queue_len=%d)", rrc->get_rb_name(lcid).c_str(), sdu->N_bytes, tx_sdu_queue.size()); } /**************************************************************************** @@ -848,7 +848,7 @@ int rlc_am::build_data_pdu(uint8_t *payload, uint32_t nof_bytes) // Set SN header.sn = vt_s; vt_s = (vt_s + 1)%MOD; - log->info("%s PDU scheduled for tx. SN: %d\n", rrc->get_rb_name(lcid).c_str(), header.sn); + log->info("%s PDU scheduled for tx. SN: %d (%d B)\n", rrc->get_rb_name(lcid).c_str(), header.sn, pdu->N_bytes); // Place PDU in tx_window, write header and TX tx_window[header.sn].buf = pdu; diff --git a/lib/src/upper/rlc_um.cc b/lib/src/upper/rlc_um.cc index 647494552..6bbefaf78 100644 --- a/lib/src/upper/rlc_um.cc +++ b/lib/src/upper/rlc_um.cc @@ -173,7 +173,7 @@ uint32_t rlc_um::get_bearer() void rlc_um::write_sdu(byte_buffer_t *sdu) { tx_sdu_queue.write(sdu); - log->info_hex(sdu->msg, sdu->N_bytes, "%s Tx SDU, tx_sdu_len=%d", rrc->get_rb_name(lcid).c_str(), tx_sdu_queue.size()); + log->info_hex(sdu->msg, sdu->N_bytes, "%s Tx SDU (% B ,tx_sdu_queue_len=%d)", rrc->get_rb_name(lcid).c_str(), sdu->N_bytes, tx_sdu_queue.size()); } /**************************************************************************** diff --git a/srsue/src/mac/mux.cc b/srsue/src/mac/mux.cc index 59b94f085..33d048957 100644 --- a/srsue/src/mac/mux.cc +++ b/srsue/src/mac/mux.cc @@ -166,8 +166,7 @@ uint8_t* mux::pdu_get(uint8_t *payload, uint32_t pdu_sz, uint32_t tx_tti, uint32 } } -// Logical Channel Procedure - + // Logical Channel Procedure bool is_rar = false; pdu_msg.init_tx(payload, pdu_sz, true); @@ -325,7 +324,6 @@ bool mux::allocate_sdu(uint32_t lcid, srslte::sch_pdu* pdu_msg, int max_sdu_sz) if (pdu_msg->new_subh()) { // there is space for a new subheader sdu_len = pdu_msg->get()->set_sdu(lcid, sdu_len, rlc); if (sdu_len > 0) { // new SDU could be added - Debug("SDU: allocated lcid=%d, rlc_buffer=%d, allocated=%d/%d, max_sdu_sz=%d, remaining=%d\n", lcid, buffer_state, sdu_len, sdu_space, max_sdu_sz, pdu_msg->rem_size()); return true; From a0fff683f25163b8a2c2692245cfab95cea46d68 Mon Sep 17 00:00:00 2001 From: Xavier Arteaga Date: Thu, 8 Mar 2018 14:39:01 +0100 Subject: [PATCH 101/134] Fixed pdsch_ue; it does not stop RF after cell search. --- lib/examples/pdsch_ue.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/examples/pdsch_ue.c b/lib/examples/pdsch_ue.c index 74bac426d..fc99fdc9a 100644 --- a/lib/examples/pdsch_ue.c +++ b/lib/examples/pdsch_ue.c @@ -451,9 +451,6 @@ int main(int argc, char **argv) { exit(0); } - srslte_rf_stop_rx_stream(&rf); - srslte_rf_flush_buffer(&rf); - /* set sampling frequency */ int srate = srslte_sampling_freq_hz(cell.nof_prb); if (srate != -1) { From f3c04949b755ce135fef9488f213e3d7fed60b88 Mon Sep 17 00:00:00 2001 From: Xavier Arteaga Date: Thu, 8 Mar 2018 16:56:51 +0100 Subject: [PATCH 102/134] PHCH Receive is reset, the current EARFCN becomes the first one in the list. --- srsue/src/phy/phch_recv.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 112cd03b8..7d6a2eec6 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -132,7 +132,11 @@ void phch_recv::reset() next_offset = 0; cell_is_set = false; srate_mode = SRATE_NONE; - current_earfcn = 0; + if (!earfcn.empty()) { + current_earfcn = earfcn[0]; + } else { + current_earfcn = 0; + } sfn_p.reset(); measure_p.reset(); search_p.reset(); From 9553784e2f5aa5c2839ca8ae70d23e4bf99531f3 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Thu, 8 Mar 2018 17:55:48 +0100 Subject: [PATCH 103/134] change phy_log in UE to log_filter --- lib/include/srslte/common/log.h | 2 ++ srsue/hdr/phy/phy.h | 6 +++--- srsue/hdr/ue.h | 2 +- srsue/src/phy/phy.cc | 2 +- srsue/src/ue.cc | 3 +++ srsue/test/mac/mac_test.cc | 4 ++-- 6 files changed, 12 insertions(+), 7 deletions(-) diff --git a/lib/include/srslte/common/log.h b/lib/include/srslte/common/log.h index ff3a31eaa..360482c47 100644 --- a/lib/include/srslte/common/log.h +++ b/lib/include/srslte/common/log.h @@ -84,6 +84,8 @@ public: level_text_short = true; } + virtual ~log() {}; + // This function shall be called at the start of every tti for printing tti void step(uint32_t tti_) { tti = tti_; diff --git a/srsue/hdr/phy/phy.h b/srsue/hdr/phy/phy.h index 0894a98fb..95140f8cd 100644 --- a/srsue/hdr/phy/phy.h +++ b/srsue/hdr/phy/phy.h @@ -28,7 +28,7 @@ #define UEPHY_H #include "srslte/srslte.h" -#include "srslte/common/log.h" +#include "srslte/common/log_filter.h" #include "phy/phy_metrics.h" #include "phy/phch_recv.h" #include "phy/prach.h" @@ -53,7 +53,7 @@ public: bool init(srslte::radio_multi *radio_handler, mac_interface_phy *mac, rrc_interface_phy *rrc, - std::vector log_vec, + std::vector log_vec, phy_args_t *args = NULL); void stop(); @@ -158,7 +158,7 @@ private: const static int WORKERS_THREAD_PRIO = 0; srslte::radio_multi *radio_handler; - std::vector log_vec; + std::vector log_vec; srslte::log *log_h; srslte::log *log_phy_lib_h; srsue::mac_interface_phy *mac; diff --git a/srsue/hdr/ue.h b/srsue/hdr/ue.h index d1343c68f..2aa7157e2 100644 --- a/srsue/hdr/ue.h +++ b/srsue/hdr/ue.h @@ -103,7 +103,7 @@ private: srslte::logger *logger; // rf_log is on ue_base - std::vector phy_log; + std::vector phy_log; srslte::log_filter mac_log; srslte::log_filter rlc_log; srslte::log_filter pdcp_log; diff --git a/srsue/src/phy/phy.cc b/srsue/src/phy/phy.cc index e4b618158..5c69d567d 100644 --- a/srsue/src/phy/phy.cc +++ b/srsue/src/phy/phy.cc @@ -120,7 +120,7 @@ bool phy::check_args(phy_args_t *args) } bool phy::init(srslte::radio_multi* radio_handler, mac_interface_phy *mac, rrc_interface_phy *rrc, - std::vector log_vec, phy_args_t *phy_args) { + std::vector log_vec, phy_args_t *phy_args) { mlockall(MCL_CURRENT | MCL_FUTURE); diff --git a/srsue/src/ue.cc b/srsue/src/ue.cc index 381cb52bf..1d83f087e 100644 --- a/srsue/src/ue.cc +++ b/srsue/src/ue.cc @@ -44,6 +44,9 @@ ue::ue() ue::~ue() { + for (uint32_t i = 0; i < phy_log.size(); i++) { + delete(phy_log[i]); + } } bool ue::init(all_args_t *args_) diff --git a/srsue/test/mac/mac_test.cc b/srsue/test/mac/mac_test.cc index b76ab2f95..3d21720d4 100644 --- a/srsue/test/mac/mac_test.cc +++ b/srsue/test/mac/mac_test.cc @@ -451,12 +451,12 @@ int main(int argc, char *argv[]) exit(1); } - std::vector phy_log; + std::vector phy_log; srslte::log_filter *mylog = new srslte::log_filter("PHY"); char tmp[16]; sprintf(tmp, "PHY%d",0); - phy_log.push_back((srslte::log*) mylog); + phy_log.push_back(mylog); switch (prog_args.verbose) { case 1: From 44b1748a8752b61036333c39e83dcaa6239259aa Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Thu, 8 Mar 2018 17:56:52 +0100 Subject: [PATCH 104/134] fix mem leak in sync --- lib/src/phy/sync/sync.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/lib/src/phy/sync/sync.c b/lib/src/phy/sync/sync.c index c948a53d4..39bd98141 100644 --- a/lib/src/phy/sync/sync.c +++ b/lib/src/phy/sync/sync.c @@ -152,21 +152,19 @@ clean_exit: void srslte_sync_free(srslte_sync_t *q) { if (q) { - srslte_pss_free(&q->pss); srslte_sss_free(&q->sss); srslte_cfo_free(&q->cfo_corr_frame); srslte_cfo_free(&q->cfo_corr_symbol); srslte_cp_synch_free(&q->cp_synch); - if (q->cfo_i_initiated) { - for (int i=0;i<2;i++) { - if (q->cfo_i_corr[i]) { - free(q->cfo_i_corr[i]); - } - srslte_pss_free(&q->pss_i[i]); + for (int i = 0; i < 2; i++) { + if (q->cfo_i_corr[i]) { + free(q->cfo_i_corr[i]); } + srslte_pss_free(&q->pss_i[i]); } + if (q->temp) { free(q->temp); } From cbda94f0a6b9395084946db9ba5ea07e4917ebf2 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Thu, 8 Mar 2018 17:58:11 +0100 Subject: [PATCH 105/134] fix mem leak in phch_recv --- srsue/hdr/phy/phch_recv.h | 2 ++ srsue/src/phy/phch_recv.cc | 19 +++++++++++++++++++ 2 files changed, 21 insertions(+) diff --git a/srsue/hdr/phy/phch_recv.h b/srsue/hdr/phy/phch_recv.h index d77e489ae..7a04e4b10 100644 --- a/srsue/hdr/phy/phch_recv.h +++ b/srsue/hdr/phy/phch_recv.h @@ -199,6 +199,7 @@ private: uint32_t offset; } cell_info_t; void init(srslte::log *log_h, bool sic_pss_enabled, uint32_t max_sf_window); + void deinit(); void reset(); int find_cells(cf_t *input_buffer, float rx_gain_offset, srslte_cell_t current_cell, uint32_t nof_sf, cell_info_t found_cells[MAX_CELLS]); private: @@ -220,6 +221,7 @@ private: // Class to perform intra-frequency measurements class intra_measure : public thread { public: + ~intra_measure(); void init(phch_common *common, rrc_interface_phy *rrc, srslte::log *log_h); void stop(); void add_cell(int pci); diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 7d6a2eec6..a96b9c545 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -711,6 +711,12 @@ void phch_recv::run_thread() mac->tti_clock(tti); tti = (tti+1) % 10240; } + + for (int i=0;icurrent_earfcn = earfcn; current_sflen = SRSLTE_SF_LEN_PRB(cell.nof_prb); From 43811e1886f73c7fcdd29fc56c75a63588fae6ad Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Thu, 8 Mar 2018 18:00:35 +0100 Subject: [PATCH 106/134] deallocate used buffers in buffer_pool dtor --- lib/include/srslte/common/buffer_pool.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/include/srslte/common/buffer_pool.h b/lib/include/srslte/common/buffer_pool.h index 035fbc661..76634a697 100644 --- a/lib/include/srslte/common/buffer_pool.h +++ b/lib/include/srslte/common/buffer_pool.h @@ -72,6 +72,10 @@ public: delete available.top(); available.pop(); } + + for (uint32_t i = 0; i < used.size(); i++) { + delete used[i]; + } } void print_all_buffers() From 5335f046ff6a0e42cf7c5b1860fd6f308e1aba46 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Thu, 8 Mar 2018 18:03:16 +0100 Subject: [PATCH 107/134] dealloc mutex and cond in msg_queue --- lib/include/srslte/common/msg_queue.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/include/srslte/common/msg_queue.h b/lib/include/srslte/common/msg_queue.h index bca4c5388..e8b8c742a 100644 --- a/lib/include/srslte/common/msg_queue.h +++ b/lib/include/srslte/common/msg_queue.h @@ -56,6 +56,9 @@ public: ~msg_queue() { + pthread_mutex_destroy(&mutex); + pthread_cond_destroy(¬_empty); + pthread_cond_destroy(¬_full); delete [] buf; } From b85a220145df84c7fb95c70f114849f2fe7f3b62 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Thu, 8 Mar 2018 16:35:37 -0500 Subject: [PATCH 108/134] Fix HO not setting serving cell --- srsue/src/upper/rrc.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index fdd461ebb..acb91e5fd 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -617,11 +617,6 @@ void rrc::cell_camping(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp) { int cell_idx = -1; bool found = true; - if (ho_syncing && phy_cell.id == ho_target_pci) { - ho_synced(ho_target_pci); - return; - } - pthread_mutex_lock(&mutex); if (serving_cell->equals(earfcn, phy_cell.id)) { @@ -665,6 +660,9 @@ void rrc::cell_camping(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp) { found?"Updating":"Adding", cell_idx>=0?"neighbour":"serving", earfcn, phy_cell.id, rsrp); + if (ho_syncing && phy_cell.id == ho_target_pci) { + ho_synced(ho_target_pci); + } } From 3afb93fcb9ad1ca42a407714b374d81b1efc01d9 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Fri, 9 Mar 2018 17:05:46 +0100 Subject: [PATCH 109/134] exit the UE with q in console --- srsue/src/main.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/srsue/src/main.cc b/srsue/src/main.cc index ef38a7f80..f5df0af2d 100644 --- a/srsue/src/main.cc +++ b/srsue/src/main.cc @@ -422,6 +422,9 @@ void *input_loop(void *m) { cout << "Enter t to restart trace." << endl; } metrics_screen.toggle_print(do_metrics); + } else + if ('q' == key) { + running = false; } } } From 6ca6919694fc6b374c9e3ee710b066ed0fafaf16 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Sun, 11 Mar 2018 21:47:15 -0400 Subject: [PATCH 110/134] Handle T300 expiry to avoid blocking on RLC TM UL CCCH when ConnectionRequest fails --- srsue/hdr/upper/rrc.h | 2 +- srsue/src/upper/rrc.cc | 21 +++++++++++++++++++-- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/srsue/hdr/upper/rrc.h b/srsue/hdr/upper/rrc.h index 8d092051a..5c9899eab 100644 --- a/srsue/hdr/upper/rrc.h +++ b/srsue/hdr/upper/rrc.h @@ -341,7 +341,7 @@ private: srslte::mac_interface_timers *mac_timers; uint32_t n310_cnt, N310; uint32_t n311_cnt, N311; - uint32_t t301, t310, t311, t304; + uint32_t t300, t301, t310, t311, t304; // Radio bearers typedef enum{ diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index acb91e5fd..1f0c6eb94 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -113,6 +113,7 @@ void rrc::init(phy_interface_rrc *phy_, args.nof_supported_bands = 1; args.feature_group = 0xe6041c00; + t300 = mac_timers->timer_get_unique_id(); t301 = mac_timers->timer_get_unique_id(); t310 = mac_timers->timer_get_unique_id(); t311 = mac_timers->timer_get_unique_id(); @@ -930,6 +931,13 @@ void rrc::timer_expired(uint32_t timeout_id) { } else if (timeout_id == t311) { rrc_log->info("Timer T311 expired: Going to RRC IDLE\n"); state = RRC_STATE_LEAVE_CONNECTED; + } else if (timeout_id == t300) { + rrc_log->info("Timer T300 expired: ConnectionRequest failed. Reset MAC and restablished RLC.\n"); + rlc->reestablish(); + mac->reset(); + set_mac_default(); + state = RRC_STATE_IDLE; + nas->plmn_search_end(); } else if (timeout_id == t301) { if (state == RRC_STATE_IDLE) { rrc_log->info("Timer T301 expired: Already in IDLE.\n"); @@ -985,6 +993,8 @@ void rrc::send_con_request() { ul_ccch_msg.msg.rrc_con_req.cause = LIBLTE_RRC_CON_REQ_EST_CAUSE_MO_SIGNALLING; + mac_timers->timer_get(t300)->reset(); + mac_timers->timer_get(t300)->run(); send_ul_ccch_msg(); } @@ -1676,6 +1686,8 @@ void rrc::parse_dl_ccch(byte_buffer_t *pdu) { case LIBLTE_RRC_DL_CCCH_MSG_TYPE_RRC_CON_REJ: rrc_log->info("Connection Reject received. Wait time: %d\n", dl_ccch_msg.msg.rrc_con_rej.wait_time); + // Stop T300 timer + mac_timers->timer_get(t300)->stop(); state = RRC_STATE_LEAVE_CONNECTED; break; case LIBLTE_RRC_DL_CCCH_MSG_TYPE_RRC_CON_SETUP: @@ -1978,14 +1990,15 @@ void rrc::apply_sib2_configs(LIBLTE_RRC_SYS_INFO_BLOCK_TYPE_2_STRUCT *sib2) { liblte_rrc_srs_subfr_config_num[sib2->rr_config_common_sib.srs_ul_cnfg.subfr_cnfg], sib2->rr_config_common_sib.srs_ul_cnfg.ack_nack_simul_tx ? "yes" : "no"); + mac_timers->timer_get(t300)->set(this, liblte_rrc_t300_num[sib2->ue_timers_and_constants.t300]); mac_timers->timer_get(t301)->set(this, liblte_rrc_t301_num[sib2->ue_timers_and_constants.t301]); mac_timers->timer_get(t310)->set(this, liblte_rrc_t310_num[sib2->ue_timers_and_constants.t310]); mac_timers->timer_get(t311)->set(this, liblte_rrc_t311_num[sib2->ue_timers_and_constants.t311]); N310 = liblte_rrc_n310_num[sib2->ue_timers_and_constants.n310]; N311 = liblte_rrc_n311_num[sib2->ue_timers_and_constants.n311]; - rrc_log->info("Set Constants and Timers: N310=%d, N311=%d, t301=%d, t310=%d, t311=%d\n", - N310, N311, mac_timers->timer_get(t301)->get_timeout(), + rrc_log->info("Set Constants and Timers: N310=%d, N311=%d, t300=%d, t301=%d, t310=%d, t311=%d\n", + N310, N311, mac_timers->timer_get(t300)->get_timeout(), mac_timers->timer_get(t301)->get_timeout(), mac_timers->timer_get(t310)->get_timeout(), mac_timers->timer_get(t311)->get_timeout()); } @@ -2222,6 +2235,10 @@ void rrc::apply_rr_config_dedicated(LIBLTE_RRC_RR_CONFIG_DEDICATED_STRUCT *cnfg) } void rrc::handle_con_setup(LIBLTE_RRC_CONNECTION_SETUP_STRUCT *setup) { + + // Stop T300 timer + mac_timers->timer_get(t300)->stop(); + // Apply the Radio Resource configuration apply_rr_config_dedicated(&setup->rr_cnfg); } From 8bda956330794a96e407394f7275e5652762fa57 Mon Sep 17 00:00:00 2001 From: Xavier Arteaga Date: Tue, 13 Mar 2018 01:01:53 +0100 Subject: [PATCH 111/134] Solved logging error trace --- srsue/src/phy/phch_worker.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/srsue/src/phy/phch_worker.cc b/srsue/src/phy/phch_worker.cc index 8a6c5cd8b..12e717b9a 100644 --- a/srsue/src/phy/phch_worker.cc +++ b/srsue/src/phy/phch_worker.cc @@ -574,7 +574,7 @@ bool phch_worker::decode_pdcch_dl(srsue::mac_interface_phy::mac_grant_t* grant) last_dl_pdcch_ncce = srslte_ue_dl_get_ncce(&ue_dl); - char hexstr[16]; + char hexstr[SRSLTE_DCI_MAX_BITS/8]; hexstr[0]='\0'; if (log_h->get_level() >= srslte::LOG_LEVEL_INFO) { srslte_vec_sprint_hex(hexstr, sizeof(hexstr), dci_msg.data, dci_msg.nof_bits); @@ -812,7 +812,7 @@ bool phch_worker::decode_pdcch_ul(mac_interface_phy::mac_grant_t* grant) grant->has_cqi_request = dci_unpacked.cqi_request; ret = true; - char hexstr[16]; + char hexstr[SRSLTE_DCI_MAX_BITS/8]; hexstr[0]='\0'; if (log_h->get_level() >= srslte::LOG_LEVEL_INFO) { srslte_vec_sprint_hex(hexstr, sizeof(hexstr), dci_msg.data, dci_msg.nof_bits); From c2098ad6260ee3c772c26f404314fe01c4bc5f18 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Tue, 13 Mar 2018 18:52:21 +0100 Subject: [PATCH 112/134] Removed unused sample offset correction --- lib/include/srslte/interfaces/ue_interfaces.h | 3 +- lib/include/srslte/phy/ue/ue_dl.h | 7 ----- lib/src/phy/ue/ue_dl.c | 30 +------------------ srsue/hdr/phy/phch_worker.h | 3 +- srsue/src/main.cc | 4 --- srsue/src/phy/phch_recv.cc | 2 -- srsue/src/phy/phch_worker.cc | 8 ----- srsue/src/phy/phy.cc | 3 +- 8 files changed, 4 insertions(+), 56 deletions(-) diff --git a/lib/include/srslte/interfaces/ue_interfaces.h b/lib/include/srslte/interfaces/ue_interfaces.h index 75acc27ea..9a7a68a34 100644 --- a/lib/include/srslte/interfaces/ue_interfaces.h +++ b/lib/include/srslte/interfaces/ue_interfaces.h @@ -487,8 +487,7 @@ typedef struct { uint32_t cfo_ref_mask; bool average_subframe_enabled; int time_correct_period; - bool sfo_correct_disable; - std::string sss_algorithm; + std::string sss_algorithm; float estimator_fil_w; bool rssi_sensor_enabled; bool sic_pss_enabled; diff --git a/lib/include/srslte/phy/ue/ue_dl.h b/lib/include/srslte/phy/ue/ue_dl.h index 6974a0b99..c5b0da52a 100644 --- a/lib/include/srslte/phy/ue/ue_dl.h +++ b/lib/include/srslte/phy/ue/ue_dl.h @@ -84,8 +84,6 @@ typedef struct SRSLTE_API { srslte_ofdm_t fft_mbsfn; srslte_chest_dl_t chest; - srslte_cfo_t sfo_correct; - srslte_pdsch_cfg_t pdsch_cfg; srslte_pdsch_cfg_t pmch_cfg; srslte_softbuffer_rx_t *softbuffers[SRSLTE_MAX_CODEWORDS]; @@ -126,8 +124,6 @@ typedef struct SRSLTE_API { srslte_dci_msg_t pending_ul_dci_msg; uint16_t pending_ul_dci_rnti; - float sample_offset; - float last_phich_corr; }srslte_ue_dl_t; @@ -195,9 +191,6 @@ SRSLTE_API int srslte_ue_dl_find_dl_dci_type(srslte_ue_dl_t *q, SRSLTE_API uint32_t srslte_ue_dl_get_ncce(srslte_ue_dl_t *q); -SRSLTE_API void srslte_ue_dl_set_sample_offset(srslte_ue_dl_t * q, - float sample_offset); - SRSLTE_API int srslte_ue_dl_decode(srslte_ue_dl_t *q, uint8_t *data[SRSLTE_MAX_CODEWORDS], uint32_t tm, diff --git a/lib/src/phy/ue/ue_dl.c b/lib/src/phy/ue/ue_dl.c index 3815041a7..98ff5c9fd 100644 --- a/lib/src/phy/ue/ue_dl.c +++ b/lib/src/phy/ue/ue_dl.c @@ -71,7 +71,6 @@ int srslte_ue_dl_init(srslte_ue_dl_t *q, q->pmch_pkt_errors = 0; q->pmch_pkts_total = 0; q->pending_ul_dci_rnti = 0; - q->sample_offset = 0; q->nof_rx_antennas = nof_rx_antennas; for (int j = 0; j < SRSLTE_MAX_PORTS; j++) { @@ -147,12 +146,7 @@ int srslte_ue_dl_init(srslte_ue_dl_t *q, goto clean_exit; } } - if (srslte_cfo_init(&q->sfo_correct, max_prb*SRSLTE_NRE)) { - fprintf(stderr, "Error initiating SFO correct\n"); - goto clean_exit; - } - srslte_cfo_set_tol(&q->sfo_correct, 1e-5f/q->fft[0].symbol_sz); - + ret = SRSLTE_SUCCESS; } else { fprintf(stderr, "Invalid parametres\n"); @@ -178,7 +172,6 @@ void srslte_ue_dl_free(srslte_ue_dl_t *q) { srslte_pdcch_free(&q->pdcch); srslte_pdsch_free(&q->pdsch); srslte_pmch_free(&q->pmch); - srslte_cfo_free(&q->sfo_correct); for (int i = 0; i < SRSLTE_MAX_TB; i++) { srslte_softbuffer_rx_free(q->softbuffers[i]); if (q->softbuffers[i]) { @@ -209,7 +202,6 @@ int srslte_ue_dl_set_cell(srslte_ue_dl_t *q, srslte_cell_t cell) q->pkt_errors = 0; q->pkts_total = 0; q->pending_ul_dci_rnti = 0; - q->sample_offset = 0; if (q->cell.id != cell.id || q->cell.nof_prb == 0) { if (q->cell.nof_prb != 0) { @@ -220,11 +212,6 @@ int srslte_ue_dl_set_cell(srslte_ue_dl_t *q, srslte_cell_t cell) fprintf(stderr, "Error resizing REGs\n"); return SRSLTE_ERROR; } - if (srslte_cfo_resize(&q->sfo_correct, q->cell.nof_prb*SRSLTE_NRE)) { - fprintf(stderr, "Error resizing SFO correct\n"); - return SRSLTE_ERROR; - } - srslte_cfo_set_tol(&q->sfo_correct, 1e-5f/q->fft[0].symbol_sz); for (int port = 0; port < q->nof_rx_antennas; port++) { if (srslte_ofdm_rx_set_prb(&q->fft[port], q->cell.cp, q->cell.nof_prb)) { fprintf(stderr, "Error resizing FFT\n"); @@ -348,10 +335,6 @@ void srslte_ue_dl_reset(srslte_ue_dl_t *q) { bzero(&q->pdsch_cfg, sizeof(srslte_pdsch_cfg_t)); } -void srslte_ue_dl_set_sample_offset(srslte_ue_dl_t * q, float sample_offset) { - q->sample_offset = sample_offset; -} - /** Applies the following operations to a subframe of synchronized samples: * - OFDM demodulation * - Channel estimation @@ -395,17 +378,6 @@ int srslte_ue_dl_decode_fft_estimate_noguru(srslte_ue_dl_t *q, cf_t *input[SRSLT /* Run FFT for all subframe data */ for (int j=0;jnof_rx_antennas;j++) { srslte_ofdm_rx_sf_ng(&q->fft[j], input[j], q->sf_symbols_m[j]); - - /* Correct SFO multiplying by complex exponential in the time domain */ - if (q->sample_offset) { - int nsym = SRSLTE_CP_NSYMB(q->cell.cp); - for (int i=0;i<2*nsym;i++) { - srslte_cfo_correct(&q->sfo_correct, - &q->sf_symbols_m[j][i*q->cell.nof_prb*SRSLTE_NRE], - &q->sf_symbols_m[j][i*q->cell.nof_prb*SRSLTE_NRE], - q->sample_offset / q->fft[j].symbol_sz); - } - } } return srslte_ue_dl_decode_estimate_mbsfn(q, sf_idx, cfi, SRSLTE_SF_NORM); } else { diff --git a/srsue/hdr/phy/phch_worker.h b/srsue/hdr/phy/phch_worker.h index 167334918..6f72285b2 100644 --- a/srsue/hdr/phy/phch_worker.h +++ b/srsue/hdr/phy/phch_worker.h @@ -54,8 +54,7 @@ public: void set_tti(uint32_t tti, uint32_t tx_tti); void set_tx_time(srslte_timestamp_t tx_time, uint32_t next_offset); void set_cfo(float cfo); - void set_sample_offset(float sample_offset); - + void set_ul_params(bool pregen_disabled = false); void set_crnti(uint16_t rnti); void enable_pregen_signals(bool enabled); diff --git a/srsue/src/main.cc b/srsue/src/main.cc index f5df0af2d..d2d029c63 100644 --- a/srsue/src/main.cc +++ b/srsue/src/main.cc @@ -258,10 +258,6 @@ void parse_args(all_args_t *args, int argc, char *argv[]) { bpo::value(&args->expert.phy.time_correct_period)->default_value(5), "Period for sampling time offset correction.") - ("expert.sfo_correct_disable", - bpo::value(&args->expert.phy.sfo_correct_disable)->default_value(false), - "Disables phase correction before channel estimation.") - ("expert.sss_algorithm", bpo::value(&args->expert.phy.sss_algorithm)->default_value("full"), "Selects the SSS estimation algorithm.") diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index a96b9c545..850294175 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -636,8 +636,6 @@ void phch_recv::run_thread() worker->set_cfo(ul_dl_factor * metrics.cfo / 15000); worker_com->set_sync_metrics(metrics); - worker->set_sample_offset(srslte_ue_sync_get_sfo(&ue_sync)/1000); - /* Compute TX time: Any transmission happens in TTI+4 thus advance 4 ms the reception time */ srslte_timestamp_t rx_time, tx_time, tx_time_prach; srslte_ue_sync_get_last_timestamp(&ue_sync, &rx_time); diff --git a/srsue/src/phy/phch_worker.cc b/srsue/src/phy/phch_worker.cc index 8a6c5cd8b..32f336f59 100644 --- a/srsue/src/phy/phch_worker.cc +++ b/srsue/src/phy/phch_worker.cc @@ -190,14 +190,6 @@ void phch_worker::set_cfo(float cfo_) cfo = cfo_; } -void phch_worker::set_sample_offset(float sample_offset) -{ - if (phy->args->sfo_correct_disable) { - sample_offset = 0; - } - srslte_ue_dl_set_sample_offset(&ue_dl, sample_offset); -} - void phch_worker::set_crnti(uint16_t rnti) { srslte_ue_dl_set_rnti(&ue_dl, rnti); diff --git a/srsue/src/phy/phy.cc b/srsue/src/phy/phy.cc index 5c69d567d..27b389a4e 100644 --- a/srsue/src/phy/phy.cc +++ b/srsue/src/phy/phy.cc @@ -97,8 +97,7 @@ void phy::set_default_args(phy_args_t *args) args->cfo_integer_enabled = false; args->cfo_correct_tol_hz = 50; args->time_correct_period = 5; - args->sfo_correct_disable = false; - args->sss_algorithm = "full"; + args->sss_algorithm = "full"; args->estimator_fil_w = 0.1; } From 809c550ca2dd0ebae0e1632abc3330004b2c5e2e Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Tue, 13 Mar 2018 19:07:15 +0100 Subject: [PATCH 113/134] Use RS power estimation for serving cell RSRP/SNR measurements. Use correlation of RS sequences for neighbour cell verification of Cell ID --- .../srslte/phy/ch_estimation/chest_dl.h | 10 ++- lib/src/phy/ch_estimation/chest_dl.c | 42 +++++++++-- srsue/hdr/phy/phch_recv.h | 3 +- srsue/src/phy/phch_recv.cc | 72 ++++++++++++------- 4 files changed, 96 insertions(+), 31 deletions(-) diff --git a/lib/include/srslte/phy/ch_estimation/chest_dl.h b/lib/include/srslte/phy/ch_estimation/chest_dl.h index c1f5579a1..e7cc28bed 100644 --- a/lib/include/srslte/phy/ch_estimation/chest_dl.h +++ b/lib/include/srslte/phy/ch_estimation/chest_dl.h @@ -82,10 +82,13 @@ typedef struct { srslte_interp_lin_t srslte_interp_lin_3; srslte_interp_lin_t srslte_interp_lin_mbsfn; float rssi[SRSLTE_MAX_PORTS][SRSLTE_MAX_PORTS]; - float rsrp[SRSLTE_MAX_PORTS][SRSLTE_MAX_PORTS]; + float rsrp[SRSLTE_MAX_PORTS][SRSLTE_MAX_PORTS]; + float rsrp_corr[SRSLTE_MAX_PORTS][SRSLTE_MAX_PORTS]; float noise_estimate[SRSLTE_MAX_PORTS][SRSLTE_MAX_PORTS]; float cfo; + bool rsrp_neighbour; + bool cfo_estimate_enable; uint32_t cfo_estimate_sf_mask; @@ -158,6 +161,9 @@ SRSLTE_API void srslte_chest_dl_cfo_estimate_enable(srslte_chest_dl_t *q, SRSLTE_API void srslte_chest_dl_average_subframe(srslte_chest_dl_t *q, bool enable); +SRSLTE_API void srslte_chest_dl_set_rsrp_neighbour(srslte_chest_dl_t *q, + bool rsrp_for_neighbour); + SRSLTE_API float srslte_chest_dl_get_noise_estimate(srslte_chest_dl_t *q); SRSLTE_API float srslte_chest_dl_get_cfo(srslte_chest_dl_t *q); @@ -185,4 +191,6 @@ SRSLTE_API float srslte_chest_dl_get_rsrp_port(srslte_chest_dl_t *q, SRSLTE_API float srslte_chest_dl_get_rsrp(srslte_chest_dl_t *q); +SRSLTE_API float srslte_chest_dl_get_rsrp_neighbour(srslte_chest_dl_t *q); + #endif diff --git a/lib/src/phy/ch_estimation/chest_dl.c b/lib/src/phy/ch_estimation/chest_dl.c index ec827ec13..8d9125910 100644 --- a/lib/src/phy/ch_estimation/chest_dl.c +++ b/lib/src/phy/ch_estimation/chest_dl.c @@ -152,7 +152,9 @@ int srslte_chest_dl_init(srslte_chest_dl_t *q, uint32_t max_prb) } q->noise_alg = SRSLTE_NOISE_ALG_REFS; - + + q->rsrp_neighbour = false; + q->smooth_filter_len = 3; srslte_chest_dl_set_smooth_filter3_coeff(q, 0.1); @@ -545,7 +547,7 @@ void chest_interpolate_noise_est(srslte_chest_dl_t *q, cf_t *input, cf_t *ce, ui } } -int srslte_chest_dl_estimate_port(srslte_chest_dl_t *q, cf_t *input, cf_t *ce, uint32_t sf_idx, uint32_t port_id, uint32_t rxant_id) +int srslte_chest_dl_estimate_port(srslte_chest_dl_t *q, cf_t *input, cf_t *ce, uint32_t sf_idx, uint32_t port_id, uint32_t rxant_id) { uint32_t npilots = SRSLTE_REFSIGNAL_NUM_SF(q->cell.nof_prb, port_id); @@ -557,14 +559,18 @@ int srslte_chest_dl_estimate_port(srslte_chest_dl_t *q, cf_t *input, cf_t *ce, u q->pilot_estimates, npilots); /* Compute RSRP for the channel estimates in this port */ - double energy = cabs(srslte_vec_acc_cc(q->pilot_estimates, npilots)/npilots); - q->rsrp[rxant_id][port_id] = energy*energy; + if (q->rsrp_neighbour) { + double energy = cabs(srslte_vec_acc_cc(q->pilot_estimates, npilots)/npilots); + q->rsrp_corr[rxant_id][port_id] = energy*energy; + } + q->rsrp[rxant_id][port_id] = srslte_vec_avg_power_cf(q->pilot_recv_signal, npilots); q->rssi[rxant_id][port_id] = srslte_chest_dl_rssi(q, input, port_id); chest_interpolate_noise_est(q, input, ce, sf_idx, port_id, rxant_id, SRSLTE_SF_NORM); return 0; } + int srslte_chest_dl_estimate_port_mbsfn(srslte_chest_dl_t *q, cf_t *input, cf_t *ce, uint32_t sf_idx, uint32_t port_id, uint32_t rxant_id, uint16_t mbsfn_area_id) { @@ -623,6 +629,10 @@ int srslte_chest_dl_estimate_multi_mbsfn(srslte_chest_dl_t *q, cf_t *input[SRSLT return SRSLTE_SUCCESS; } +void srslte_chest_dl_set_rsrp_neighbour(srslte_chest_dl_t *q, bool rsrp_for_neighbour) { + q->rsrp_neighbour = rsrp_for_neighbour; +} + void srslte_chest_dl_average_subframe(srslte_chest_dl_t *q, bool enable) { q->average_subframe = enable; @@ -710,6 +720,19 @@ float srslte_chest_dl_get_rsrp_port(srslte_chest_dl_t *q, uint32_t port) { return sum; } +float srslte_chest_dl_get_rsrp_neighbour_port(srslte_chest_dl_t *q, uint32_t port) { + float sum = 0.0f; + for (int j = 0; j < q->cell.nof_ports; ++j) { + sum +=q->rsrp_corr[port][j]; + } + + if (q->cell.nof_ports) { + sum /= q->cell.nof_ports; + } + + return sum; +} + float srslte_chest_dl_get_rsrp(srslte_chest_dl_t *q) { float max = -0.0f; for (int i = 0; i < q->last_nof_antennas; ++i) { @@ -720,3 +743,14 @@ float srslte_chest_dl_get_rsrp(srslte_chest_dl_t *q) { } return max; } + +float srslte_chest_dl_get_rsrp_neighbour(srslte_chest_dl_t *q) { + float max = -0.0f; + for (int i = 0; i < q->last_nof_antennas; ++i) { + float v = srslte_chest_dl_get_rsrp_neighbour_port(q, i); + if (v > max) { + max = v; + } + } + return max; +} diff --git a/srsue/hdr/phy/phch_recv.h b/srsue/hdr/phy/phch_recv.h index 7a04e4b10..3d00b631b 100644 --- a/srsue/hdr/phy/phch_recv.h +++ b/srsue/hdr/phy/phch_recv.h @@ -171,6 +171,7 @@ private: ret_code run_multiple_subframes(cf_t *buffer, uint32_t offset, uint32_t sf_idx, uint32_t nof_sf); float rssi(); float rsrp(); + float rsrp_n(); float rsrq(); float snr(); uint32_t frame_st_idx(); @@ -183,7 +184,7 @@ private: uint32_t nof_subframes; uint32_t current_prb; float rx_gain_offset; - float mean_rsrp, mean_rsrq, mean_snr, mean_rssi; + float mean_rsrp, mean_rsrp_n, mean_rsrq, mean_snr, mean_rssi; uint32_t final_offset; const static int RSRP_MEASURE_NOF_FRAMES = 5; }; diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 850294175..6ec87d2fa 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -1022,6 +1022,7 @@ void phch_recv::measure::init(cf_t *buffer[SRSLTE_MAX_PORTS], srslte::log *log_h Error("SYNC: Initiating ue_dl_measure\n"); return; } + srslte_chest_dl_set_rsrp_neighbour(&ue_dl.chest, true); reset(); } @@ -1054,6 +1055,10 @@ float phch_recv::measure::rsrp() { return 10*log10(mean_rsrp) + 30 - rx_gain_offset; } +float phch_recv::measure::rsrp_n() { + return 10*log10(mean_rsrp_n) + 30 - rx_gain_offset; +} + float phch_recv::measure::rsrq() { return 10*log10(mean_rsrq); } @@ -1099,12 +1104,13 @@ phch_recv::measure::ret_code phch_recv::measure::run_multiple_subframes(cf_t *in sf_idx ++; } + + // Fine-tune offset using RS +#ifdef FINE_TUNE_OFFSET_WITH_RS float max_rsrp = -200; int best_test_offset = 0; int test_offset = 0; bool found_best = false; - - // Fine-tune offset using RS for (uint32_t n=0;n<5;n++) { test_offset = offset-2+n; @@ -1128,11 +1134,14 @@ phch_recv::measure::ret_code phch_recv::measure::run_multiple_subframes(cf_t *in } } + Debug("INTRA: fine-tuning offset: %d, found_best=%d, rem_sf=%d\n", offset, found_best, nof_sf); + offset = found_best?best_test_offset:offset; +#endif + if (offset >= 0 && offset < sf_len*max_sf) { uint32_t nof_sf = (sf_len*max_sf - offset)/sf_len; - Debug("INTRA: fine-tuning offset: %d, found_best=%d, rem_sf=%d\n", offset, found_best, nof_sf); final_offset = offset; @@ -1161,25 +1170,28 @@ phch_recv::measure::ret_code phch_recv::measure::run_subframe(uint32_t sf_idx) } float rsrp = srslte_chest_dl_get_rsrp(&ue_dl.chest); + float rsrp_n = srslte_chest_dl_get_rsrp_neighbour(&ue_dl.chest); float rsrq = srslte_chest_dl_get_rsrq(&ue_dl.chest); float snr = srslte_chest_dl_get_snr(&ue_dl.chest); float rssi = srslte_vec_avg_power_cf(buffer[0], SRSLTE_SF_LEN_PRB(current_prb)); if (cnt == 0) { - mean_rsrp = rsrp; - mean_rsrq = rsrq; - mean_snr = snr; - mean_rssi = rssi; + mean_rsrp = rsrp; + mean_rsrp_n = rsrp_n; + mean_rsrq = rsrq; + mean_snr = snr; + mean_rssi = rssi; } else { - mean_rsrp = SRSLTE_VEC_CMA(rsrp, mean_rsrp, cnt); - mean_rsrq = SRSLTE_VEC_CMA(rsrq, mean_rsrq, cnt); - mean_snr = SRSLTE_VEC_CMA(snr, mean_snr, cnt); - mean_rssi = SRSLTE_VEC_CMA(rssi, mean_rssi, cnt); + mean_rsrp = SRSLTE_VEC_CMA(rsrp, mean_rsrp, cnt); + mean_rsrp_n = SRSLTE_VEC_CMA(rsrp_n, mean_rsrp_n, cnt); + mean_rsrq = SRSLTE_VEC_CMA(rsrq, mean_rsrq, cnt); + mean_snr = SRSLTE_VEC_CMA(snr, mean_snr, cnt); + mean_rssi = SRSLTE_VEC_CMA(rssi, mean_rssi, cnt); } cnt++; - log_h->debug("SYNC: Measuring RSRP %d/%d, sf_idx=%d, RSRP=%.1f dBm, SNR=%.1f dB\n", - cnt, nof_subframes, sf_idx, rsrp, snr); + log_h->debug("SYNC: Measuring RSRP %d/%d, sf_idx=%d, RSRP=%.1f dBm, corr-RSRP=%.1f dBm, SNR=%.1f dB\n", + cnt, nof_subframes, sf_idx, rsrp, rsrp_n, snr); if (cnt >= nof_subframes) { return MEASURE_OK; @@ -1217,6 +1229,7 @@ void phch_recv::scell_recv::init(srslte::log *log_h, bool sic_pss_enabled, uint3 fprintf(stderr, "Error initiating sync_find\n"); return; } + srslte_sync_set_sss_algorithm(&sync_find, SSS_FULL); srslte_sync_cp_en(&sync_find, false); srslte_sync_set_cfo_pss_enable(&sync_find, true); srslte_sync_set_threshold(&sync_find, 1.7); @@ -1230,8 +1243,7 @@ void phch_recv::scell_recv::init(srslte::log *log_h, bool sic_pss_enabled, uint3 srslte_sync_set_sss_eq_enable(&sync_find, true); sync_find.pss.chest_on_filter = true; - - sync_find.sss_channel_equalize = true; + sync_find.sss_channel_equalize = false; reset(); } @@ -1336,17 +1348,27 @@ int phch_recv::scell_recv::find_cells(cf_t *input_buffer, float rx_gain_offset, case measure::MEASURE_OK: // Consider a cell to be detectable 8.1.2.2.1.1 from 36.133. Currently only using first condition if (measure_p.rsrp() > ABSOLUTE_RSRP_THRESHOLD_DBM) { - cells[nof_cells].pci = found_cell.id; - cells[nof_cells].rsrp = measure_p.rsrp(); - cells[nof_cells].rsrq = measure_p.rsrq(); - cells[nof_cells].offset = measure_p.frame_st_idx(); - - Info( - "INTRA: Found neighbour cell %d: PCI=%03d, RSRP=%5.1f dBm, peak_idx=%5d, peak_value=%3.2f, sf=%d, max_sf=%d, n_id_2=%d, CFO=%6.1f Hz\n", - nof_cells, cell_id, measure_p.rsrp(), measure_p.frame_st_idx(), sync_find.peak_value, - sf_idx, max_sf5, n_id_2, 15000 * srslte_sync_get_cfo(&sync_find)); - nof_cells++; + // Check the cell id has been correctly identified by using the correlation of the RS sequences + // By experimentation, typically the cross-correlation is ~3/4 dB less + if (measure_p.rsrp_n() > measure_p.rsrp() - 6) { + cells[nof_cells].pci = found_cell.id; + cells[nof_cells].rsrp = measure_p.rsrp(); + cells[nof_cells].rsrq = measure_p.rsrq(); + cells[nof_cells].offset = measure_p.frame_st_idx(); + + Info( + "INTRA: Found neighbour cell %d: PCI=%03d, RSRP=%5.1f dBm, corr-RSRP=%5.1f dBm, peak_idx=%5d, peak_value=%3.2f, sf=%d, max_sf=%d, n_id_2=%d, CFO=%6.1f Hz\n", + nof_cells, cell_id, measure_p.rsrp(), measure_p.rsrp_n(), measure_p.frame_st_idx(), sync_find.peak_value, + sf_idx, max_sf5, n_id_2, 15000 * srslte_sync_get_cfo(&sync_find)); + + nof_cells++; + } else { + Info( + "INTRA: Found phantom cell %d: PCI=%03d, RSRP=%5.1f dBm, corr-RSRP=%5.1f dBm, peak_idx=%5d, peak_value=%3.2f, sf=%d, max_sf=%d, n_id_2=%d, CFO=%6.1f Hz\n", + nof_cells, cell_id, measure_p.rsrp(), measure_p.rsrp_n(), measure_p.frame_st_idx(), sync_find.peak_value, + sf_idx, max_sf5, n_id_2, 15000 * srslte_sync_get_cfo(&sync_find)); + } /* if (sic_pss_enabled) { From b77e3b0be56114958eda79747ab5be0f63c0db5d Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Tue, 13 Mar 2018 20:01:09 +0100 Subject: [PATCH 114/134] Avoid negative offset in neighbour cell search --- srsue/src/phy/phch_recv.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 6ec87d2fa..b186e0ae1 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -1099,7 +1099,7 @@ phch_recv::measure::ret_code phch_recv::measure::run_multiple_subframes(cf_t *in ret_code ret = IDLE; offset = offset-sf_len/2; - if (offset < 0) { + while (offset < 0) { offset += sf_len; sf_idx ++; } From 0fbeee72a17ce420a0036f2680e530a97a469517 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Tue, 13 Mar 2018 20:47:31 +0100 Subject: [PATCH 115/134] Fixed offset int in previous commit --- srsue/hdr/phy/phch_recv.h | 2 +- srsue/src/phy/phch_recv.cc | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/srsue/hdr/phy/phch_recv.h b/srsue/hdr/phy/phch_recv.h index 3d00b631b..8b87f0521 100644 --- a/srsue/hdr/phy/phch_recv.h +++ b/srsue/hdr/phy/phch_recv.h @@ -168,7 +168,7 @@ private: void set_cell(srslte_cell_t cell); ret_code run_subframe(uint32_t sf_idx); ret_code run_subframe_sync(srslte_ue_sync_t *ue_sync, uint32_t sf_idx); - ret_code run_multiple_subframes(cf_t *buffer, uint32_t offset, uint32_t sf_idx, uint32_t nof_sf); + ret_code run_multiple_subframes(cf_t *buffer, int offset, uint32_t sf_idx, uint32_t nof_sf); float rssi(); float rsrp(); float rsrp_n(); diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index b186e0ae1..2799cb999 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -1090,7 +1090,7 @@ phch_recv::measure::ret_code phch_recv::measure::run_subframe_sync(srslte_ue_syn } phch_recv::measure::ret_code phch_recv::measure::run_multiple_subframes(cf_t *input_buffer, - uint32_t offset, + int offset, uint32_t sf_idx, uint32_t max_sf) { @@ -1099,7 +1099,7 @@ phch_recv::measure::ret_code phch_recv::measure::run_multiple_subframes(cf_t *in ret_code ret = IDLE; offset = offset-sf_len/2; - while (offset < 0) { + while (offset < 0 && sf_idx < max_sf) { offset += sf_len; sf_idx ++; } From 33ebde5387ce652d39bc7506400c05ae129018cc Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Wed, 14 Mar 2018 09:53:48 +0100 Subject: [PATCH 116/134] Fixed bug SIB3 loop and window_start 10s wait in disconnect --- srsue/src/phy/phch_recv.cc | 2 +- srsue/src/upper/rrc.cc | 33 +++++++++++++++++++++++---------- 2 files changed, 24 insertions(+), 11 deletions(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 2799cb999..9d539a02d 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -1139,7 +1139,7 @@ phch_recv::measure::ret_code phch_recv::measure::run_multiple_subframes(cf_t *in offset = found_best?best_test_offset:offset; #endif - if (offset >= 0 && offset < sf_len*max_sf) { + if (offset >= 0 && offset < (int) sf_len*max_sf) { uint32_t nof_sf = (sf_len*max_sf - offset)/sf_len; diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 1f0c6eb94..8c346bfaa 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -98,6 +98,7 @@ void rrc::init(phy_interface_rrc *phy_, mac_timers = mac_timers_; state = RRC_STATE_IDLE; si_acquire_state = SI_ACQUIRE_IDLE; + last_win_start = 0; ho_syncing = false; @@ -178,10 +179,6 @@ void rrc::run_thread() { while (thread_running) { - if (state >= RRC_STATE_IDLE && state < RRC_STATE_CONNECTING) { - run_si_acquisition_procedure(); - } - switch(state) { /* Procedures in IDLE state 36.304 Sec 4 */ case RRC_STATE_IDLE: @@ -232,13 +229,16 @@ void rrc::run_thread() { si_acquire_state = SI_ACQUIRE_SIB2; } else { apply_sib2_configs(serving_cell->sib2ptr()); - si_acquire_state = SI_ACQUIRE_IDLE; state = RRC_STATE_CELL_SELECTED; } + run_si_acquisition_procedure(); } break; case RRC_STATE_CELL_SELECTED: + si_acquire_state = SI_ACQUIRE_IDLE; + last_win_start = 0; + /* The cell is selected when the SIBs are received and applied. * If we were in RRC_CONNECTED and arrive here it means a RLF occurred and we are in Reestablishment procedure. * If T311 is running means there is a reestablishment in progress, send ConnectionReestablishmentRequest. @@ -267,6 +267,8 @@ void rrc::run_thread() { if (connecting_timeout >= RRC_CONNECTING_TIMEOUT) { // Select another cell rrc_log->info("RRC Connecting: timeout expired. Selecting next cell\n"); + si_acquire_state = SI_ACQUIRE_IDLE; + last_win_start = 0; state = RRC_STATE_CELL_SELECTING; } break; @@ -358,6 +360,7 @@ void rrc::run_si_acquisition_procedure() if (state == RRC_STATE_CELL_SELECTING) { select_next_cell_in_plmn(); si_acquire_state = SI_ACQUIRE_IDLE; + last_win_start = 0; } else if (state == RRC_STATE_PLMN_SELECTION) { phy->cell_search_next(); } @@ -384,13 +387,14 @@ void rrc::run_si_acquisition_procedure() last_win_start = si_win_start; mac->bcch_start_rx(si_win_start, si_win_len); - rrc_log->debug("Instructed MAC to search for system info, win_start=%d, win_len=%d\n", - si_win_start, si_win_len); + rrc_log->info("Instructed MAC to search for system info=%d, win_start=%d, win_len=%d\n", + sysinfo_index, si_win_start, si_win_len); } } else { // We've received all SIBs, move on to connection request si_acquire_state = SI_ACQUIRE_IDLE; + last_win_start = 0; state = RRC_STATE_CELL_SELECTED; } break; @@ -477,6 +481,8 @@ void rrc::plmn_select_rrc(LIBLTE_RRC_PLMN_IDENTITY_STRUCT plmn_id) { } } + si_acquire_state = SI_ACQUIRE_IDLE; + last_win_start = 0; state = RRC_STATE_CELL_SELECTING; } else { rrc_log->warning("Requested PLMN select in incorrect state %s\n", rrc_state_text[state]); @@ -549,6 +555,8 @@ bool rrc::select_next_cell_in_plmn() { rrc_log->console("Selected cell PCI=%d, EARFCN=%d\n", serving_cell->phy_cell.id, serving_cell->get_earfcn()); phy->cell_select(serving_cell->get_earfcn(), serving_cell->phy_cell); + si_acquire_state = SI_ACQUIRE_IDLE; + last_win_start = 0; state = RRC_STATE_CELL_SELECTING; return true; } @@ -644,9 +652,7 @@ void rrc::cell_camping(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp) { pthread_mutex_unlock(&mutex); - if (!serving_cell->has_sib1()) { - si_acquire_state = SI_ACQUIRE_SIB1; - } else if (state == RRC_STATE_PLMN_SELECTION) { + if (state == RRC_STATE_PLMN_SELECTION && serving_cell->has_sib1()) { bool ret = false; for (uint32_t j = 0; j < serving_cell->sib1ptr()->N_plmn_ids; j++) { ret |= nas->plmn_found(serving_cell->sib1ptr()->plmn_id[j].id, serving_cell->sib1ptr()->tracking_area_code); @@ -655,6 +661,8 @@ void rrc::cell_camping(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp) { if (!ret) { phy->cell_search_next(); } + } else if (!ho_syncing) { + state = RRC_STATE_CELL_SELECTING; } rrc_log->info("%s %s cell EARFCN=%d, PCI=%d, RSRP=%.1f dBm\n", @@ -1062,6 +1070,8 @@ void rrc::send_con_restablish_request(LIBLTE_RRC_CON_REEST_REQ_CAUSE_ENUM cause, mac->reset(); set_mac_default(); phy->sync_reset(); + si_acquire_state = SI_ACQUIRE_IDLE; + last_win_start = 0; state = RRC_STATE_CELL_SELECTING; } @@ -1347,6 +1357,8 @@ void rrc::leave_connected() { rrc_log->console("RRC IDLE\n"); rrc_log->info("Leaving RRC_CONNECTED state\n"); + si_acquire_state = SI_ACQUIRE_IDLE; + last_win_start = 0; drb_up = false; measurements.reset(); pdcp->reset(); @@ -1424,6 +1436,7 @@ void rrc::write_pdu_bcch_dlsch(byte_buffer_t *pdu) { if(serving_cell->has_sib2()) { sysinfo_index++; + rrc_log->info("Increasing sysinfo_index=%d\n", sysinfo_index); } } From c815051238657aa361c76da6916d3bcafa2b708d Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Wed, 14 Mar 2018 10:22:44 +0100 Subject: [PATCH 117/134] Increased str buffer for DCI printing --- srsue/src/phy/phch_worker.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/srsue/src/phy/phch_worker.cc b/srsue/src/phy/phch_worker.cc index 0f2e75920..b3a33ea6c 100644 --- a/srsue/src/phy/phch_worker.cc +++ b/srsue/src/phy/phch_worker.cc @@ -566,7 +566,7 @@ bool phch_worker::decode_pdcch_dl(srsue::mac_interface_phy::mac_grant_t* grant) last_dl_pdcch_ncce = srslte_ue_dl_get_ncce(&ue_dl); - char hexstr[SRSLTE_DCI_MAX_BITS/8]; + char hexstr[512]; hexstr[0]='\0'; if (log_h->get_level() >= srslte::LOG_LEVEL_INFO) { srslte_vec_sprint_hex(hexstr, sizeof(hexstr), dci_msg.data, dci_msg.nof_bits); @@ -804,7 +804,7 @@ bool phch_worker::decode_pdcch_ul(mac_interface_phy::mac_grant_t* grant) grant->has_cqi_request = dci_unpacked.cqi_request; ret = true; - char hexstr[SRSLTE_DCI_MAX_BITS/8]; + char hexstr[512]; hexstr[0]='\0'; if (log_h->get_level() >= srslte::LOG_LEVEL_INFO) { srslte_vec_sprint_hex(hexstr, sizeof(hexstr), dci_msg.data, dci_msg.nof_bits); From c0aea5ae13bf89eaa83ff892dc595bdd8446c972 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Wed, 14 Mar 2018 10:23:05 +0100 Subject: [PATCH 118/134] Neighbour cell RSRP measurement always and only with correlation method --- lib/src/phy/ch_estimation/chest_dl.c | 4 +-- srsue/hdr/phy/phch_recv.h | 6 ++-- srsue/src/phy/phch_recv.cc | 52 +++++++--------------------- 3 files changed, 17 insertions(+), 45 deletions(-) diff --git a/lib/src/phy/ch_estimation/chest_dl.c b/lib/src/phy/ch_estimation/chest_dl.c index 8d9125910..e719b22c0 100644 --- a/lib/src/phy/ch_estimation/chest_dl.c +++ b/lib/src/phy/ch_estimation/chest_dl.c @@ -734,7 +734,7 @@ float srslte_chest_dl_get_rsrp_neighbour_port(srslte_chest_dl_t *q, uint32_t por } float srslte_chest_dl_get_rsrp(srslte_chest_dl_t *q) { - float max = -0.0f; + float max = -1e9; for (int i = 0; i < q->last_nof_antennas; ++i) { float v = srslte_chest_dl_get_rsrp_port(q, i); if (v > max) { @@ -745,7 +745,7 @@ float srslte_chest_dl_get_rsrp(srslte_chest_dl_t *q) { } float srslte_chest_dl_get_rsrp_neighbour(srslte_chest_dl_t *q) { - float max = -0.0f; + float max = -1e9; for (int i = 0; i < q->last_nof_antennas; ++i) { float v = srslte_chest_dl_get_rsrp_neighbour_port(q, i); if (v > max) { diff --git a/srsue/hdr/phy/phch_recv.h b/srsue/hdr/phy/phch_recv.h index 8b87f0521..d71bcb1d5 100644 --- a/srsue/hdr/phy/phch_recv.h +++ b/srsue/hdr/phy/phch_recv.h @@ -171,7 +171,6 @@ private: ret_code run_multiple_subframes(cf_t *buffer, int offset, uint32_t sf_idx, uint32_t nof_sf); float rssi(); float rsrp(); - float rsrp_n(); float rsrq(); float snr(); uint32_t frame_st_idx(); @@ -184,7 +183,7 @@ private: uint32_t nof_subframes; uint32_t current_prb; float rx_gain_offset; - float mean_rsrp, mean_rsrp_n, mean_rsrq, mean_snr, mean_rssi; + float mean_rsrp, mean_rsrq, mean_snr, mean_rssi; uint32_t final_offset; const static int RSRP_MEASURE_NOF_FRAMES = 5; }; @@ -205,7 +204,6 @@ private: int find_cells(cf_t *input_buffer, float rx_gain_offset, srslte_cell_t current_cell, uint32_t nof_sf, cell_info_t found_cells[MAX_CELLS]); private: - cf_t *input_cfo_corrected; cf_t *sf_buffer[SRSLTE_MAX_PORTS]; srslte::log *log_h; srslte_sync_t sync_find; @@ -233,7 +231,7 @@ private: void write(uint32_t tti, cf_t *data, uint32_t nsamples); private: void run_thread(); - const static int INTRA_FREQ_MEAS_LEN_MS = 50; + const static int INTRA_FREQ_MEAS_LEN_MS = 20; const static int INTRA_FREQ_MEAS_PERIOD_MS = 200; const static int INTRA_FREQ_MEAS_PRIO = DEFAULT_PRIORITY + 5; diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 9d539a02d..456f14ea0 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -1055,10 +1055,6 @@ float phch_recv::measure::rsrp() { return 10*log10(mean_rsrp) + 30 - rx_gain_offset; } -float phch_recv::measure::rsrp_n() { - return 10*log10(mean_rsrp_n) + 30 - rx_gain_offset; -} - float phch_recv::measure::rsrq() { return 10*log10(mean_rsrq); } @@ -1169,21 +1165,18 @@ phch_recv::measure::ret_code phch_recv::measure::run_subframe(uint32_t sf_idx) return ERROR; } - float rsrp = srslte_chest_dl_get_rsrp(&ue_dl.chest); - float rsrp_n = srslte_chest_dl_get_rsrp_neighbour(&ue_dl.chest); + float rsrp = srslte_chest_dl_get_rsrp_neighbour(&ue_dl.chest); float rsrq = srslte_chest_dl_get_rsrq(&ue_dl.chest); float snr = srslte_chest_dl_get_snr(&ue_dl.chest); float rssi = srslte_vec_avg_power_cf(buffer[0], SRSLTE_SF_LEN_PRB(current_prb)); if (cnt == 0) { mean_rsrp = rsrp; - mean_rsrp_n = rsrp_n; mean_rsrq = rsrq; mean_snr = snr; mean_rssi = rssi; } else { mean_rsrp = SRSLTE_VEC_CMA(rsrp, mean_rsrp, cnt); - mean_rsrp_n = SRSLTE_VEC_CMA(rsrp_n, mean_rsrp_n, cnt); mean_rsrq = SRSLTE_VEC_CMA(rsrq, mean_rsrq, cnt); mean_snr = SRSLTE_VEC_CMA(snr, mean_snr, cnt); mean_rssi = SRSLTE_VEC_CMA(rssi, mean_rssi, cnt); @@ -1191,7 +1184,7 @@ phch_recv::measure::ret_code phch_recv::measure::run_subframe(uint32_t sf_idx) cnt++; log_h->debug("SYNC: Measuring RSRP %d/%d, sf_idx=%d, RSRP=%.1f dBm, corr-RSRP=%.1f dBm, SNR=%.1f dB\n", - cnt, nof_subframes, sf_idx, rsrp, rsrp_n, snr); + cnt, nof_subframes, sf_idx, rsrp, snr); if (cnt >= nof_subframes) { return MEASURE_OK; @@ -1220,7 +1213,6 @@ void phch_recv::scell_recv::init(srslte::log *log_h, bool sic_pss_enabled, uint3 uint32_t max_sf_size = SRSLTE_SF_LEN(max_fft_sz); sf_buffer[0] = (cf_t*) srslte_vec_malloc(sizeof(cf_t)*max_sf_size); - input_cfo_corrected = (cf_t*) srslte_vec_malloc(sizeof(cf_t)*15*max_sf_size); measure_p.init(sf_buffer, log_h, 1, max_sf_window); @@ -1257,7 +1249,6 @@ void phch_recv::scell_recv::reset() void phch_recv::scell_recv::deinit() { srslte_sync_free(&sync_find); - free(input_cfo_corrected); free(sf_buffer[0]); } @@ -1335,40 +1326,23 @@ int phch_recv::scell_recv::find_cells(cf_t *input_buffer, float rx_gain_offset, found_cell.nof_ports = 1; // Use port 0 only for measurement measure_p.set_cell(found_cell); - // Correct CFO - /* - srslte_cfo_correct(&sync_find.cfo_corr_frame, - input_buffer, - input_cfo_corrected, - -srslte_sync_get_cfo(&sync_find)/sync_find.fft_size); - */ - switch(measure_p.run_multiple_subframes(input_buffer, peak_idx, sf_idx, nof_sf)) { case measure::MEASURE_OK: // Consider a cell to be detectable 8.1.2.2.1.1 from 36.133. Currently only using first condition if (measure_p.rsrp() > ABSOLUTE_RSRP_THRESHOLD_DBM) { - // Check the cell id has been correctly identified by using the correlation of the RS sequences - // By experimentation, typically the cross-correlation is ~3/4 dB less - if (measure_p.rsrp_n() > measure_p.rsrp() - 6) { - cells[nof_cells].pci = found_cell.id; - cells[nof_cells].rsrp = measure_p.rsrp(); - cells[nof_cells].rsrq = measure_p.rsrq(); - cells[nof_cells].offset = measure_p.frame_st_idx(); - - Info( - "INTRA: Found neighbour cell %d: PCI=%03d, RSRP=%5.1f dBm, corr-RSRP=%5.1f dBm, peak_idx=%5d, peak_value=%3.2f, sf=%d, max_sf=%d, n_id_2=%d, CFO=%6.1f Hz\n", - nof_cells, cell_id, measure_p.rsrp(), measure_p.rsrp_n(), measure_p.frame_st_idx(), sync_find.peak_value, - sf_idx, max_sf5, n_id_2, 15000 * srslte_sync_get_cfo(&sync_find)); - - nof_cells++; - } else { - Info( - "INTRA: Found phantom cell %d: PCI=%03d, RSRP=%5.1f dBm, corr-RSRP=%5.1f dBm, peak_idx=%5d, peak_value=%3.2f, sf=%d, max_sf=%d, n_id_2=%d, CFO=%6.1f Hz\n", - nof_cells, cell_id, measure_p.rsrp(), measure_p.rsrp_n(), measure_p.frame_st_idx(), sync_find.peak_value, - sf_idx, max_sf5, n_id_2, 15000 * srslte_sync_get_cfo(&sync_find)); - } + cells[nof_cells].pci = found_cell.id; + cells[nof_cells].rsrp = measure_p.rsrp(); + cells[nof_cells].rsrq = measure_p.rsrq(); + cells[nof_cells].offset = measure_p.frame_st_idx(); + + Info( + "INTRA: Found neighbour cell %d: PCI=%03d, RSRP=%5.1f dBm, peak_idx=%5d, peak_value=%3.2f, sf=%d, nof_sf=%d, n_id_2=%d, CFO=%6.1f Hz\n", + nof_cells, cell_id, measure_p.rsrp(), measure_p.frame_st_idx(), sync_find.peak_value, + sf_idx, nof_sf, n_id_2, 15000 * srslte_sync_get_cfo(&sync_find)); + + nof_cells++; /* if (sic_pss_enabled) { From f9d770e50e4e80cc35bd478cf2b70666645930ce Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Wed, 14 Mar 2018 17:30:55 +0100 Subject: [PATCH 119/134] Added option for Doppler frequency correction --- lib/include/srslte/interfaces/ue_interfaces.h | 3 ++- srsue/hdr/phy/phch_recv.h | 2 ++ srsue/hdr/phy/phch_worker.h | 1 - srsue/src/main.cc | 11 ++++----- srsue/src/phy/phch_recv.cc | 23 +++++++++++++++++-- srsue/src/phy/phch_worker.cc | 16 +------------ srsue/ue.conf.example | 3 +++ 7 files changed, 34 insertions(+), 25 deletions(-) diff --git a/lib/include/srslte/interfaces/ue_interfaces.h b/lib/include/srslte/interfaces/ue_interfaces.h index 9a7a68a34..e69419983 100644 --- a/lib/include/srslte/interfaces/ue_interfaces.h +++ b/lib/include/srslte/interfaces/ue_interfaces.h @@ -474,7 +474,8 @@ typedef struct { int cqi_max; int cqi_fixed; float snr_ema_coeff; - std::string snr_estim_alg; + std::string snr_estim_alg; + bool cfo_is_doppler; bool cfo_integer_enabled; float cfo_correct_tol_hz; float cfo_pss_ema; diff --git a/srsue/hdr/phy/phch_recv.h b/srsue/hdr/phy/phch_recv.h index d71bcb1d5..f955b30ce 100644 --- a/srsue/hdr/phy/phch_recv.h +++ b/srsue/hdr/phy/phch_recv.h @@ -104,6 +104,8 @@ private: void cell_search_inc(); void cell_reselect(); + float get_cfo(); + uint32_t new_earfcn; srslte_cell_t new_cell; diff --git a/srsue/hdr/phy/phch_worker.h b/srsue/hdr/phy/phch_worker.h index 6f72285b2..e87603e5d 100644 --- a/srsue/hdr/phy/phch_worker.h +++ b/srsue/hdr/phy/phch_worker.h @@ -73,7 +73,6 @@ public: float get_rsrp(); float get_noise(); float get_cfo(); - float get_ul_cfo(); private: /* Inherited from thread_pool::worker. Function called every subframe to run the DL/UL processing */ diff --git a/srsue/src/main.cc b/srsue/src/main.cc index d2d029c63..00fd23cf8 100644 --- a/srsue/src/main.cc +++ b/srsue/src/main.cc @@ -203,6 +203,11 @@ void parse_args(all_args_t *args, int argc, char *argv[]) { bpo::value(&args->expert.phy.equalizer_mode)->default_value("mmse"), "Equalizer mode") + ("expert.cfo_is_doppler", + bpo::value(&args->expert.phy.cfo_is_doppler)->default_value(false), + "Assume detected CFO is doppler and correct the UL in the same direction. If disabled, the CFO is assumed" + "to be caused by the local oscillator and the UL correction is in the opposite direction. Default assumes oscillator.") + ("expert.cfo_integer_enabled", bpo::value(&args->expert.phy.cfo_integer_enabled)->default_value(false), "Enables integer CFO estimation and correction.") @@ -215,12 +220,6 @@ void parse_args(all_args_t *args, int argc, char *argv[]) { bpo::value(&args->expert.phy.cfo_pss_ema)->default_value(DEFAULT_CFO_EMA_TRACK), "CFO Exponential Moving Average coefficient for PSS estimation during TRACK.") - /* REF EMA is currently not used - ("expert.cfo_ref_ema", - bpo::value(&args->expert.phy.cfo_ref_ema)->default_value(0.01), - "CFO Exponential Moving Average coefficient for RS estimation after PSS acquisition") - */ - ("expert.cfo_ref_mask", bpo::value(&args->expert.phy.cfo_ref_mask)->default_value(1023), "Bitmask for subframes on which to run RS estimation (set to 0 to disable, default all sf)") diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 456f14ea0..38dd5b561 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -428,6 +428,25 @@ bool phch_recv::set_frequency() } } +float phch_recv::get_cfo() +{ + float cfo = srslte_ue_sync_get_cfo(&ue_sync); + + float ret = cfo*ul_dl_factor; + + if (worker_com->args->cfo_is_doppler) { + ret *= -1; + } + + if (radio_h->get_freq_offset() != 0.0f) { + /* Compensates the radio frequency offset applied equally to DL and UL */ + const float offset_hz = (float) radio_h->get_freq_offset() * (1.0f - ul_dl_factor); + ret = cfo - offset_hz; + } + + return ret/15000; +} + void phch_recv::set_sampling_rate() { current_srate = (float) srslte_sampling_freq_hz(cell.nof_prb); @@ -633,7 +652,7 @@ void phch_recv::run_thread() metrics.sfo = srslte_ue_sync_get_sfo(&ue_sync); metrics.cfo = srslte_ue_sync_get_cfo(&ue_sync); - worker->set_cfo(ul_dl_factor * metrics.cfo / 15000); + worker->set_cfo(get_cfo()); worker_com->set_sync_metrics(metrics); /* Compute TX time: Any transmission happens in TTI+4 thus advance 4 ms the reception time */ @@ -659,7 +678,7 @@ void phch_recv::run_thread() if (prach_buffer->is_ready_to_send(tti)) { srslte_timestamp_copy(&tx_time_prach, &rx_time); srslte_timestamp_add(&tx_time_prach, 0, prach::tx_advance_sf * 1e-3); - prach_buffer->send(radio_h, ul_dl_factor * metrics.cfo / 15000, worker_com->pathloss, tx_time_prach); + prach_buffer->send(radio_h, get_cfo(), worker_com->pathloss, tx_time_prach); radio_h->tx_end(); worker_com->p0_preamble = prach_buffer->get_p0_preamble(); worker_com->cur_radio_power = SRSLTE_MIN(SRSLTE_PC_MAX, worker_com->pathloss+worker_com->p0_preamble); diff --git a/srsue/src/phy/phch_worker.cc b/srsue/src/phy/phch_worker.cc index b3a33ea6c..e613719cb 100644 --- a/srsue/src/phy/phch_worker.cc +++ b/srsue/src/phy/phch_worker.cc @@ -223,20 +223,6 @@ float phch_worker::get_cfo() return cfo; } -float phch_worker::get_ul_cfo() { - srslte::radio *radio = phy->get_radio(); - - if (radio->get_freq_offset() != 0.0f) { - /* Compensates the radio frequency offset applied equally to DL and UL */ - const float ul_dl_ratio = (float) radio->get_tx_freq() / (float) radio->get_rx_freq(); - const float offset_hz = (float) radio->get_freq_offset() * (1.0f - ul_dl_ratio); - return cfo - offset_hz / (15000); - } else { - return cfo; - } - -} - void phch_worker::work_imp() { if (!cell_initiated) { @@ -360,7 +346,7 @@ void phch_worker::work_imp() } /* Set UL CFO before transmission */ - srslte_ue_ul_set_cfo(&ue_ul, get_ul_cfo()); + srslte_ue_ul_set_cfo(&ue_ul, cfo); /* Transmit PUSCH, PUCCH or SRS */ bool signal_ready = false; diff --git a/srsue/ue.conf.example b/srsue/ue.conf.example index 52442e4af..a3de1a678 100644 --- a/srsue/ue.conf.example +++ b/srsue/ue.conf.example @@ -172,6 +172,8 @@ enable = false # cfo_correct_tol_hz: Tolerance (in Hz) for digial CFO compensation. Lower tolerance means that # a new table will be generated more often. # +# cfo_is_doppler: Assume detected CFO is doppler and correct the UL in the same direction. If disabled, the CFO is assumed +# to be caused by the local oscillator and the UL correction is in the opposite direction. Default assumes oscillator. # cfo_pss_ema: CFO Exponential Moving Average coefficient for PSS estimation during TRACK. # cfo_ref_ema: CFO Exponential Moving Average coefficient for RS estimation after PSS acquisition # cfo_ref_mask: Bitmask for subframes on which to run RS estimation (set to 0 to disable, default sf=[1, 5]) @@ -211,6 +213,7 @@ enable = false #pdsch_csi_enabled = true # Caution! Only TM1 supported! # CFO related values +#cfo_is_doppler = false #cfo_integer_enabled = false #cfo_correct_tol_hz = 1.0 #cfo_pss_ema = 0.05 From 155ac12193e85f245a601837eff9e59134dd48c7 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Wed, 14 Mar 2018 17:35:11 +0100 Subject: [PATCH 120/134] Remove measObject properly when release (fixes not enough unique timers bug) --- srsue/src/upper/rrc.cc | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 8c346bfaa..c01c2fc37 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -2462,7 +2462,10 @@ void rrc::rrc_meas::reset() filter_k_rsrp = liblte_rrc_filter_coefficient_num[LIBLTE_RRC_FILTER_COEFFICIENT_FC4]; filter_k_rsrq = liblte_rrc_filter_coefficient_num[LIBLTE_RRC_FILTER_COEFFICIENT_FC4]; objects.clear(); - active.clear(); + std::map::iterator iter = active.begin(); + while (iter != active.end()) { + remove_meas_id(iter++); + } reports_cfg.clear(); phy->meas_reset(); bzero(&pcell_measurement, sizeof(meas_value_t)); @@ -2983,12 +2986,15 @@ void rrc::rrc_meas::parse_meas_config(LIBLTE_RRC_MEAS_CONFIG_STRUCT *cfg) } else { is_new = true; active[measId->meas_id].periodic_timer = mac_timers->timer_get_unique_id(); + if (!active[measId->meas_id].periodic_timer) { + log_h->error("Could not get unique timer id\n"); + } } active[measId->meas_id].object_id = measId->meas_obj_id; active[measId->meas_id].report_id = measId->rep_cnfg_id; - log_h->info("MEAS: %s measId=%d, measObjectId=%d, reportConfigId=%d, nof_values=%d\n", + log_h->info("MEAS: %s measId=%d, measObjectId=%d, reportConfigId=%d, timer_id=%d, nof_values=%d\n", is_new?"Added":"Updated", measId->meas_id, measId->meas_obj_id, measId->rep_cnfg_id, - active[measId->meas_id].cell_values.size()); + active[measId->meas_id].periodic_timer, active[measId->meas_id].cell_values.size()); } } From 209293104f822910a428c309e47b5827c2baa642 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Wed, 14 Mar 2018 18:00:26 +0100 Subject: [PATCH 121/134] Fix bug introduced in 33ebde5387ce652d39bc7506400c05ae129018cc causing the UE to disconnect when reselecting cell --- srsue/src/upper/rrc.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index c01c2fc37..63d64808a 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -661,7 +661,7 @@ void rrc::cell_camping(uint32_t earfcn, srslte_cell_t phy_cell, float rsrp) { if (!ret) { phy->cell_search_next(); } - } else if (!ho_syncing) { + } else if (state < RRC_STATE_CONNECTING) { state = RRC_STATE_CELL_SELECTING; } From 58f204d94aca8bc2a4c5a6ed2df77466556c5a17 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Wed, 14 Mar 2018 21:19:02 +0100 Subject: [PATCH 122/134] Set DEBUG constant for RelWithDebug --- CMakeLists.txt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 10952a010..a91e11da7 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -257,9 +257,14 @@ if(CMAKE_C_COMPILER_ID MATCHES "GNU" OR CMAKE_C_COMPILER_ID MATCHES "Clang") if(${CMAKE_BUILD_TYPE} STREQUAL "Debug") set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -g -O0 -DDEBUG_MODE") else(${CMAKE_BUILD_TYPE} STREQUAL "Debug") - set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -O3") + if(${CMAKE_BUILD_TYPE} STREQUAL "RelWithDebInfo") + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DDEBUG_MODE") + else(${CMAKE_BUILD_TYPE} STREQUAL "RelWithDebInfo") + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -O3") + endif(${CMAKE_BUILD_TYPE} STREQUAL "RelWithDebInfo") endif(${CMAKE_BUILD_TYPE} STREQUAL "Debug") + if (USE_LTE_RATES) message(STATUS "Using standard LTE sampling rates") set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DFORCE_STANDARD_RATE") From bd258372ea4453080af86ba72741bdde5277bdee Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Wed, 14 Mar 2018 23:08:36 +0100 Subject: [PATCH 123/134] Fixes #164 --- lib/src/phy/phch/pbch.c | 61 +++++++++++++++++++++++------------------ 1 file changed, 34 insertions(+), 27 deletions(-) diff --git a/lib/src/phy/phch/pbch.c b/lib/src/phy/phch/pbch.c index e7c0c33af..302ee9e7d 100644 --- a/lib/src/phy/phch/pbch.c +++ b/lib/src/phy/phch/pbch.c @@ -399,35 +399,41 @@ uint32_t srslte_pbch_crc_check(srslte_pbch_t *q, uint8_t *bits, uint32_t nof_por int decode_frame(srslte_pbch_t *q, uint32_t src, uint32_t dst, uint32_t n, uint32_t nof_bits, uint32_t nof_ports) { int j; - - memcpy(&q->temp[dst * nof_bits], &q->llr[src * nof_bits], - n * nof_bits * sizeof(float)); - /* descramble */ - srslte_scrambling_f_offset(&q->seq, &q->temp[dst * nof_bits], dst * nof_bits, - n * nof_bits); + if (dst + n <= 4 && src + n <= 4) { + memcpy(&q->temp[dst * nof_bits], &q->llr[src * nof_bits], + n * nof_bits * sizeof(float)); - for (j = 0; j < dst * nof_bits; j++) { - q->temp[j] = SRSLTE_RX_NULL; - } - for (j = (dst + n) * nof_bits; j < 4 * nof_bits; j++) { - q->temp[j] = SRSLTE_RX_NULL; - } + /* descramble */ + srslte_scrambling_f_offset(&q->seq, &q->temp[dst * nof_bits], dst * nof_bits, + n * nof_bits); - /* unrate matching */ - srslte_rm_conv_rx(q->temp, 4 * nof_bits, q->rm_f, SRSLTE_BCH_ENCODED_LEN); - - /* Normalize LLR */ - srslte_vec_sc_prod_fff(q->rm_f, 1.0/((float) 2*n), q->rm_f, SRSLTE_BCH_ENCODED_LEN); - - /* decode */ - srslte_viterbi_decode_f(&q->decoder, q->rm_f, q->data, SRSLTE_BCH_PAYLOADCRC_LEN); + for (j = 0; j < dst * nof_bits; j++) { + q->temp[j] = SRSLTE_RX_NULL; + } + for (j = (dst + n) * nof_bits; j < 4 * nof_bits; j++) { + q->temp[j] = SRSLTE_RX_NULL; + } + + /* unrate matching */ + srslte_rm_conv_rx(q->temp, 4 * nof_bits, q->rm_f, SRSLTE_BCH_ENCODED_LEN); - if (!srslte_pbch_crc_check(q, q->data, nof_ports)) { - return 1; + /* Normalize LLR */ + srslte_vec_sc_prod_fff(q->rm_f, 1.0/((float) 2*n), q->rm_f, SRSLTE_BCH_ENCODED_LEN); + + /* decode */ + srslte_viterbi_decode_f(&q->decoder, q->rm_f, q->data, SRSLTE_BCH_PAYLOADCRC_LEN); + + if (!srslte_pbch_crc_check(q, q->data, nof_ports)) { + return 1; + } else { + return SRSLTE_SUCCESS; + } } else { - return SRSLTE_SUCCESS; + fprintf(stderr, "Error in PBCH decoder: Invalid frame pointers dst=%d, src=%d, n=%d\n", src, dst, n); + return -1; } + } /* Decodes the PBCH channel @@ -514,7 +520,7 @@ int srslte_pbch_decode(srslte_pbch_t *q, cf_t *slot1_symbols, cf_t *ce_slot1[SRS for (nb = 0; nb < q->frame_idx; nb++) { for (dst = 0; (dst < 4 - nb); dst++) { for (src = 0; src < q->frame_idx - nb; src++) { - ret = decode_frame(q, src, dst, nb + 1, nof_bits, nant); + ret = decode_frame(q, src, dst, nb + 1, nof_bits, nant); if (ret == 1) { if (sfn_offset) { *sfn_offset = (int) dst - src + q->frame_idx - 1; @@ -526,15 +532,16 @@ int srslte_pbch_decode(srslte_pbch_t *q, cf_t *slot1_symbols, cf_t *ce_slot1[SRS memcpy(bch_payload, q->data, sizeof(uint8_t) * SRSLTE_BCH_PAYLOAD_LEN); } INFO("Decoded PBCH: src=%d, dst=%d, nb=%d, sfn_offset=%d\n", src, dst, nb+1, (int) dst - src + q->frame_idx - 1); - return 1; + srslte_pbch_decode_reset(q); + return 1; } } } } } nant++; - } while(nant <= q->cell.nof_ports); - + } while(nant <= q->cell.nof_ports); + /* If not found, make room for the next packet of radio frame symbols */ if (q->frame_idx == 4) { memmove(q->llr, &q->llr[nof_bits], nof_bits * 3 * sizeof(float)); From c850e2f87adab470c0692e5781b22a0a43d3a92b Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Wed, 14 Mar 2018 23:08:51 +0100 Subject: [PATCH 124/134] Added check for issue #165 --- lib/src/common/pdu.cc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/src/common/pdu.cc b/lib/src/common/pdu.cc index 69c19518c..b3928f11b 100644 --- a/lib/src/common/pdu.cc +++ b/lib/src/common/pdu.cc @@ -120,8 +120,14 @@ uint8_t* sch_pdu::write_packet(srslte::log *log_h) { int init_rem_len=rem_len; sch_subh padding; - padding.set_padding(); - + padding.set_padding(); + + if (nof_subheaders <= 0) { + log_h->error("Writting PDU: nof_subheaders=%d\n", nof_subheaders); + log_h->console("Writting PDU: nof_subheaders=%d\n", nof_subheaders); + return NULL; + } + if (init_rem_len < 0) { log_h->error("init_rem_len=%d\n", init_rem_len); return NULL; From d66a455479bafe46141e4de4618a0dda65d6c621 Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Wed, 14 Mar 2018 17:44:51 +0100 Subject: [PATCH 125/134] add check for invalid nof subheaders in MAC PDU --- lib/src/common/pdu.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/src/common/pdu.cc b/lib/src/common/pdu.cc index b3928f11b..b020cde81 100644 --- a/lib/src/common/pdu.cc +++ b/lib/src/common/pdu.cc @@ -132,7 +132,12 @@ uint8_t* sch_pdu::write_packet(srslte::log *log_h) log_h->error("init_rem_len=%d\n", init_rem_len); return NULL; } - + + if (nof_subheaders <= 0) { + log_h->error("Trying to write packet with invalid number of subheaders (nof_subheaders=%d).\n", nof_subheaders); + return NULL; + } + /* If last SDU has zero payload, remove it. FIXME: Why happens this?? */ if (subheaders[nof_subheaders-1].get_payload_size() == 0) { del_subh(); From 25ccd296461ed8ce32044bbda200f8d02e3ff2bd Mon Sep 17 00:00:00 2001 From: Andre Puschmann Date: Thu, 15 Mar 2018 09:59:39 +0100 Subject: [PATCH 126/134] fix issue when cell search doesn't set rx frequency because phy init takes too long See commit f3c04949b755ce135fef9488f213e3d7fed60b88 for reference and a more detailed description. --- srsue/src/phy/phch_recv.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 38dd5b561..4563c1476 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -280,10 +280,8 @@ void phch_recv::cell_search_inc() rrc->earfcn_end(); } else { Info("SYNC: Cell Search idx %d/%d\n", cur_earfcn_index, earfcn.size()); - if (current_earfcn != earfcn[cur_earfcn_index]) { - current_earfcn = earfcn[cur_earfcn_index]; - set_frequency(); - } + current_earfcn = earfcn[cur_earfcn_index]; + set_frequency(); phy_state = CELL_SEARCH; } } From 599cf9bc076ade9012602880df7e24a782beb64d Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Thu, 15 Mar 2018 10:56:18 +0100 Subject: [PATCH 127/134] Resolved conflicting commits d66a455479bafe46141e4de4618a0dda65d6c621 and c850e2f87adab470c0692e5781b22a0a43d3a92b --- lib/src/common/pdu.cc | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/src/common/pdu.cc b/lib/src/common/pdu.cc index b020cde81..b0cdef638 100644 --- a/lib/src/common/pdu.cc +++ b/lib/src/common/pdu.cc @@ -123,8 +123,8 @@ uint8_t* sch_pdu::write_packet(srslte::log *log_h) padding.set_padding(); if (nof_subheaders <= 0) { - log_h->error("Writting PDU: nof_subheaders=%d\n", nof_subheaders); - log_h->console("Writting PDU: nof_subheaders=%d\n", nof_subheaders); + log_h->error("Trying to write packet with invalid number of subheaders (nof_subheaders=%d).\n", nof_subheaders); + log_h->console("Trying to write packet with invalid number of subheaders (nof_subheaders=%d).\n", nof_subheaders); return NULL; } @@ -133,11 +133,6 @@ uint8_t* sch_pdu::write_packet(srslte::log *log_h) return NULL; } - if (nof_subheaders <= 0) { - log_h->error("Trying to write packet with invalid number of subheaders (nof_subheaders=%d).\n", nof_subheaders); - return NULL; - } - /* If last SDU has zero payload, remove it. FIXME: Why happens this?? */ if (subheaders[nof_subheaders-1].get_payload_size() == 0) { del_subh(); From f470645e9042c07fca26b635b770d82440b79832 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Thu, 15 Mar 2018 10:56:46 +0100 Subject: [PATCH 128/134] Fix for real issue #164 --- lib/src/phy/phch/pbch.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/src/phy/phch/pbch.c b/lib/src/phy/phch/pbch.c index 302ee9e7d..722a28b4c 100644 --- a/lib/src/phy/phch/pbch.c +++ b/lib/src/phy/phch/pbch.c @@ -489,6 +489,8 @@ int srslte_pbch_decode(srslte_pbch_t *q, cf_t *slot1_symbols, cf_t *ce_slot1[SRS q->frame_idx++; ret = 0; + uint32_t frame_idx = q->frame_idx; + /* Try decoding for 1 to cell.nof_ports antennas */ if (q->search_all_ports) { nant = 1; @@ -498,7 +500,7 @@ int srslte_pbch_decode(srslte_pbch_t *q, cf_t *slot1_symbols, cf_t *ce_slot1[SRS do { if (nant != 3) { - DEBUG("Trying %d TX antennas with %d frames\n", nant, q->frame_idx); + DEBUG("Trying %d TX antennas with %d frames\n", nant, frame_idx); /* in control channels, only diversity is supported */ if (nant == 1) { @@ -511,19 +513,19 @@ int srslte_pbch_decode(srslte_pbch_t *q, cf_t *slot1_symbols, cf_t *ce_slot1[SRS } /* demodulate symbols */ - srslte_demod_soft_demodulate(SRSLTE_MOD_QPSK, q->d, &q->llr[nof_bits * (q->frame_idx - 1)], q->nof_symbols); + srslte_demod_soft_demodulate(SRSLTE_MOD_QPSK, q->d, &q->llr[nof_bits * (frame_idx - 1)], q->nof_symbols); /* We don't know where the 40 ms begin, so we try all combinations. E.g. if we received * 4 frames, try 1,2,3,4 individually, 12, 23, 34 in pairs, 123, 234 and finally 1234. * We know they are ordered. */ - for (nb = 0; nb < q->frame_idx; nb++) { + for (nb = 0; nb < frame_idx; nb++) { for (dst = 0; (dst < 4 - nb); dst++) { - for (src = 0; src < q->frame_idx - nb; src++) { + for (src = 0; src < frame_idx - nb; src++) { ret = decode_frame(q, src, dst, nb + 1, nof_bits, nant); if (ret == 1) { if (sfn_offset) { - *sfn_offset = (int) dst - src + q->frame_idx - 1; + *sfn_offset = (int) dst - src + frame_idx - 1; } if (nof_tx_ports) { *nof_tx_ports = nant; @@ -531,7 +533,7 @@ int srslte_pbch_decode(srslte_pbch_t *q, cf_t *slot1_symbols, cf_t *ce_slot1[SRS if (bch_payload) { memcpy(bch_payload, q->data, sizeof(uint8_t) * SRSLTE_BCH_PAYLOAD_LEN); } - INFO("Decoded PBCH: src=%d, dst=%d, nb=%d, sfn_offset=%d\n", src, dst, nb+1, (int) dst - src + q->frame_idx - 1); + INFO("Decoded PBCH: src=%d, dst=%d, nb=%d, sfn_offset=%d\n", src, dst, nb+1, (int) dst - src + frame_idx - 1); srslte_pbch_decode_reset(q); return 1; } From d873eaca5c0dd96827240bf7ab356df4d6d09b62 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Thu, 15 Mar 2018 11:14:22 +0100 Subject: [PATCH 129/134] Assign same timer id after release (was not really a bug) --- lib/include/srslte/common/timers.h | 14 +++++++------- srsue/src/upper/rrc.cc | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/include/srslte/common/timers.h b/lib/include/srslte/common/timers.h index d77692d5a..7517aa751 100644 --- a/lib/include/srslte/common/timers.h +++ b/lib/include/srslte/common/timers.h @@ -151,15 +151,15 @@ public: fprintf(stderr, "Error getting unique timer id: no more timers available\n"); return 0; } else { - while(used_timers[next_timer]) { - next_timer++; - if (next_timer >= nof_timers) { - next_timer=0; + for (uint32_t i=0;itimer_get(active[measId].periodic_timer)->stop(); mac_timers->timer_release_id(active[measId].periodic_timer); - log_h->info("MEAS: Removed measId=%d\n", measId); + log_h->info("MEAS: Removed measId=%d, timer_id=%d\n", measId, active[measId].periodic_timer); active.erase(measId); } else { log_h->warning("MEAS: Removing unexistent measId=%d\n", measId); @@ -2846,7 +2846,7 @@ void rrc::rrc_meas::remove_meas_id(uint32_t measId) { void rrc::rrc_meas::remove_meas_id(std::map::iterator it) { mac_timers->timer_get(it->second.periodic_timer)->stop(); mac_timers->timer_release_id(it->second.periodic_timer); - log_h->info("MEAS: Removed measId=%d\n", it->first); + log_h->info("MEAS: Removed measId=%d, timer_id=%d\n", it->first, active[measId].periodic_timer); active.erase(it); } From 5342bb430e6016997dce5c97e4aced28e4adc175 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Thu, 15 Mar 2018 11:15:33 +0100 Subject: [PATCH 130/134] previous commit not compiling --- srsue/src/upper/rrc.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 6f2ede299..6c8ab63cc 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -2846,7 +2846,7 @@ void rrc::rrc_meas::remove_meas_id(uint32_t measId) { void rrc::rrc_meas::remove_meas_id(std::map::iterator it) { mac_timers->timer_get(it->second.periodic_timer)->stop(); mac_timers->timer_release_id(it->second.periodic_timer); - log_h->info("MEAS: Removed measId=%d, timer_id=%d\n", it->first, active[measId].periodic_timer); + log_h->info("MEAS: Removed measId=%d, timer_id=%d\n", it->first, it->second.periodic_timer); active.erase(it); } From 64cc34adb07477af00bfd369e41f13af6ea9cf18 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Thu, 15 Mar 2018 11:31:09 +0100 Subject: [PATCH 131/134] previous commit not working --- lib/include/srslte/common/timers.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/include/srslte/common/timers.h b/lib/include/srslte/common/timers.h index 7517aa751..5e8b1cfd5 100644 --- a/lib/include/srslte/common/timers.h +++ b/lib/include/srslte/common/timers.h @@ -153,6 +153,7 @@ public: } else { for (uint32_t i=0;i Date: Thu, 15 Mar 2018 11:31:37 +0100 Subject: [PATCH 132/134] Revert "fix issue when cell search doesn't set rx frequency because phy init takes too long" This reverts commit 25ccd296461ed8ce32044bbda200f8d02e3ff2bd. --- srsue/src/phy/phch_recv.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 4563c1476..38dd5b561 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -280,8 +280,10 @@ void phch_recv::cell_search_inc() rrc->earfcn_end(); } else { Info("SYNC: Cell Search idx %d/%d\n", cur_earfcn_index, earfcn.size()); - current_earfcn = earfcn[cur_earfcn_index]; - set_frequency(); + if (current_earfcn != earfcn[cur_earfcn_index]) { + current_earfcn = earfcn[cur_earfcn_index]; + set_frequency(); + } phy_state = CELL_SEARCH; } } From df0dcb27e70a6867ac50aa179eb47a77eb8125f5 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Thu, 15 Mar 2018 11:31:39 +0100 Subject: [PATCH 133/134] Revert "PHCH Receive is reset, the current EARFCN becomes the first one in the list." This reverts commit f3c04949b755ce135fef9488f213e3d7fed60b88. --- srsue/src/phy/phch_recv.cc | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/srsue/src/phy/phch_recv.cc b/srsue/src/phy/phch_recv.cc index 38dd5b561..5821a1bf3 100644 --- a/srsue/src/phy/phch_recv.cc +++ b/srsue/src/phy/phch_recv.cc @@ -132,11 +132,7 @@ void phch_recv::reset() next_offset = 0; cell_is_set = false; srate_mode = SRATE_NONE; - if (!earfcn.empty()) { - current_earfcn = earfcn[0]; - } else { - current_earfcn = 0; - } + current_earfcn = 0; sfn_p.reset(); measure_p.reset(); search_p.reset(); From e845339d5406cc54e9b35fe343150e71078dcd00 Mon Sep 17 00:00:00 2001 From: Ismael Gomez Date: Thu, 15 Mar 2018 11:41:49 +0100 Subject: [PATCH 134/134] rrc.connected() return true during HO --- srsue/src/ue.cc | 2 +- srsue/src/upper/rrc.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/srsue/src/ue.cc b/srsue/src/ue.cc index 1d83f087e..ca8c9002b 100644 --- a/srsue/src/ue.cc +++ b/srsue/src/ue.cc @@ -275,7 +275,7 @@ void ue::stop() bool ue::is_attached() { - return (RRC_STATE_CONNECTED == rrc.get_state()); + return rrc.is_connected(); } void ue::start_plot() { diff --git a/srsue/src/upper/rrc.cc b/srsue/src/upper/rrc.cc index 6c8ab63cc..83d7174ca 100644 --- a/srsue/src/upper/rrc.cc +++ b/srsue/src/upper/rrc.cc @@ -156,7 +156,7 @@ rrc_state_t rrc::get_state() { } bool rrc::is_connected() { - return (RRC_STATE_CONNECTED == state); + return (RRC_STATE_CONNECTED >= state && state < RRC_STATE_LEAVE_CONNECTED); } bool rrc::have_drb() {