diff --git a/lib/include/srslte/mac/pdu.h b/lib/include/srslte/mac/pdu.h index f6620a42f..dba2da208 100644 --- a/lib/include/srslte/mac/pdu.h +++ b/lib/include/srslte/mac/pdu.h @@ -135,6 +135,7 @@ public: pdu_is_ul(false), buffer_tx(nullptr) {} + virtual ~pdu() = default; void fprint(FILE* stream) { diff --git a/srsue/hdr/stack/rrc/rrc_procedures.h b/srsue/hdr/stack/rrc/rrc_procedures.h index 5641aee3b..fdb1d605e 100644 --- a/srsue/hdr/stack/rrc/rrc_procedures.h +++ b/srsue/hdr/stack/rrc/rrc_procedures.h @@ -248,8 +248,6 @@ private: rrc* rrc_ptr; srslte::timer_handler::unique_timer rlc_flush_timer; - - bool wait = false; }; class rrc::cell_reselection_proc diff --git a/srsue/hdr/stack/upper/nas.h b/srsue/hdr/stack/upper/nas.h index 8af61557a..7b6995821 100644 --- a/srsue/hdr/stack/upper/nas.h +++ b/srsue/hdr/stack/upper/nas.h @@ -41,6 +41,7 @@ class nas : public nas_interface_rrc, public nas_interface_ue, public srslte::ti { public: explicit nas(srslte::task_handler_interface* task_handler_); + virtual ~nas() = default; void init(usim_interface_nas* usim_, rrc_interface_nas* rrc_, gw_interface_nas* gw_, const nas_args_t& args_); void stop(); void run_tti(); @@ -285,8 +286,7 @@ private: struct connection_request_completed_t { bool outcome; }; - struct attach_timeout { - }; + struct attach_timeout {}; explicit rrc_connect_proc(nas* nas_ptr_); srslte::proc_outcome_t init(srslte::establishment_cause_t cause_, srslte::unique_byte_buffer_t pdu); diff --git a/srsue/src/phy/phy.cc b/srsue/src/phy/phy.cc index 08ae97df0..739fd4556 100644 --- a/srsue/src/phy/phy.cc +++ b/srsue/src/phy/phy.cc @@ -139,7 +139,7 @@ int phy::init(const phy_args_t& args_) mylog->init(tmp, logger, true); mylog->set_level(args.log.phy_level); mylog->set_hex_limit(args.log.phy_hex_limit); - log_vec.push_back(std::move(std::unique_ptr(mylog))); + log_vec.push_back(std::unique_ptr(mylog)); } // Add PHY lib log @@ -150,7 +150,7 @@ int phy::init(const phy_args_t& args_) lib_log->init(tmp, logger, true); lib_log->set_level(args.log.phy_lib_level); lib_log->set_hex_limit(args.log.phy_hex_limit); - log_vec.push_back(std::move(std::unique_ptr(lib_log))); + log_vec.push_back(std::unique_ptr(lib_log)); } else { log_vec.push_back(nullptr); }